1 2012-04-12 Murray Cumming <murrayc@murrayc.com>
3 Adapt to the java-libglom 1.21.8 API.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
6 java-libglom's FieldFormatting is now Formatting.
8 2012-04-12 Murray Cumming <murrayc@murrayc.com>
10 Use the latest java-libglom version.
12 * pom.xml: Use java-libglom 1.21.8.
14 2012-04-12 Murray Cumming <murrayc@murrayc.com>
16 Translations: Add Esperanto.
18 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
19 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
20 properties: Add this translation because someone took the time to make it.
22 2012-03-15 Murray Cumming <murrayc@murrayc.com>
24 Use the latest java-libglom version.
26 * pom.xml: Use java-libglom 1.21.7.
28 2012-03-03 Ben Konrath <ben@bagu.org>
30 Display date and time in details view.
32 https://bugzilla.gnome.org/show_bug.cgi?id=671257
34 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
36 2012-02-24 Ben Konrath <ben@bagu.org>
38 Improve the tabs in the Notebook widget.
42 2012-01-30 Murray Cumming <murrayc@murrayc.com>
44 Translations: Try to translate the strings.
46 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
47 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
48 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
49 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
50 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
51 Take the Open translation from GTK+'s .po files.
52 Take the Details translation from Glom's po files.
53 I have added the other strings to Glom so we can get translations that way:
54 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
56 2012-01-27 Murray Cumming <murrayc@murrayc.com>
58 TableSelectionViewImpl: Put the search label and entry in a div.
60 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
61 Put the search widgets in a FlowTable so that the CSS can be used to
62 style them while keeping them together.
63 * src/main/webapp/style.css: Mention the new div.
65 2012-01-27 Murray Cumming <murrayc@murrayc.com>
67 Translate more strings in more locales.
69 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
70 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
71 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
72 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
73 Translate the "Details" and "Open" string too.
75 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
76 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
77 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
78 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
79 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
80 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
81 Add these new locales as placeholders though they currently contain English.
83 2012-01-27 Murray Cumming <murrayc@murrayc.com>
85 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
87 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
88 Check the ConfiguredDocument* for null before using it.
90 2012-01-26 Murray Cumming <murrayc@murrayc.com>
92 Tell Eclipse about the generated java files.
94 * .classpath: This lets it find OnlineGlomConstants.java.
95 It would be nice if Eclipse just used the maven build files.
97 2012-01-26 Murray Cumming <murrayc@murrayc.com>
99 Prevent a crash when no locale is specified in the URL.
101 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
102 Avoid returning a null string, obtained from
103 Window.Location.getParameter(). This caused a crash when it was
104 later passed to libglom's API.
105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
106 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
107 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
108 guard against future null strings.
110 2012-01-26 Murray Cumming <murrayc@murrayc.com>
112 Use the ?locale= query param instead of the &lang= token param.
114 * src/main/java/org/glom/web/client/place/ListPlace.java
115 * src/main/java/org/glom/web/client/place/DetailsPlace.java
116 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
117 Remove the lang token key and value.
119 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
120 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
121 When the user selects a different locale from the chooser, use
122 Window.Location.assign() to change the URL, which then causes a reload.
124 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
126 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
127 * src/main/java/org/glom/web/client/activity/ListActivity.java
128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
129 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
130 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
131 * src/main/java/org/glom/web/client/ui/ListView.java:
132 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
134 Remove localeID member variables and method/constructor parameters, instead
135 using Utils.getCurrentLocaleID() when we need a localID to pass to
138 2012-01-26 Murray Cumming <murrayc@murrayc.com>
140 Internationalize the UI strings.
142 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
143 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
144 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
145 because it is unused. Messages are apparently strings that can have
146 parameters, but we do not need that yet, so Contants will be enough for now.
147 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
148 to say that we support the en and de locales.
149 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
150 The original English strings.
151 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
152 Some German translations of the English strings.
153 The i18n goal then uses the .properties file to generate an
154 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
155 returns an implementation that returns the translated strings.
156 The documentation suggests putting these in src/java/*/client/, but it seems
157 best to put it in src/resources/*/client/.
158 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
159 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
160 instead of hard-coding them.
161 Note that we cannot import OnlineGlomConstants because it does not exist yet,
162 but that does not seem to stop the build, though it confuses Eclipse.
164 You can see the translated string by adding ?locale=de to the URL, like so:
165 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
167 2012-01-24 Murray Cumming <murrayc@murrayc.com>
169 Improve null/empty String checks.
171 * pom.xml: Add a dependency on commons-lang, to use
172 org.apache.commons.lang.StringUtils.
173 * src/main/java/org/glom/web/server/ConfiguredDocument.java
174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
175 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
176 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
177 Use StringUtils.isEmpty().
179 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
180 StringUtils class with a static isEmpty() function because we
181 cannot use org.apache.commons.lang.StringUtils in client-side
182 GWT code because it (apparently) cannot be compiled to javascript.
183 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
184 * src/main/java/org/glom/web/client/activity/ListActivity.java
185 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
186 * src/main/java/org/glom/web/client/place/DetailsPlace.java
187 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
188 * src/main/java/org/glom/web/client/place/ListPlace.java
189 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
190 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
191 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
192 * src/main/java/org/glom/web/client/ui/details/Group.java
193 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
194 our StringUtils.isEmpty() function.
196 2012-01-24 Murray Cumming <murrayc@murrayc.com>
198 Update to the latest java-libglom API.
200 * pom.xml: Require java-libglom 1.21.4.
201 * src/main/java/org/glom/web/server/ConfiguredDocument.java
202 getDocumentInfo(), getListViewLayoutGroup():
203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
205 * src/main/java/org/glom/web/server/database/DBAccess.java
206 getFieldsToShowForSQLQueryAddGroup(),
207 getPrimaryKeyLayoutItemField(): Replace get_database_title()
208 with either get_database_title_original() or
209 get_database_title(localeID).
211 2012-01-24 Murray Cumming <murrayc@murrayc.com>
213 ConfiguredDocument: Avoid a null pointer exception.
215 * src/main/java/org/glom/web/server/ConfiguredDocument.java
216 Initialize localeID to "" to avoid returning a null String which
217 causes a crash in java-libglom's swing-generated code.
219 2012-01-23 Murray Cumming <murrayc@murrayc.com>
221 Some simple renaming.
223 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
224 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
225 for localeChooser. This seems more appropriate and is less ambiguous
226 particularly in the .css file.
228 2012-01-23 Murray Cumming <murrayc@murrayc.com>
230 ConfiguredDocument: Rename the localedID private member variable.
232 2012-01-23 Murray Cumming <murrayc@murrayc.com>
234 Adapt to the latest java-libglom API from git master.
236 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
237 libglom now uses only Vector instead of List, which uses add() instead of
240 2012-01-20 Murray Cumming <murrayc@murrayc.com>
242 Build a source tarball with mvn assembly:single
244 * assembly.xml: Add this file.
245 * pom.xml: Use the maven-assembly-plugin and tell it to use
246 our assembly.xml file.
248 2012-01-19 Murray Cumming <murrayc@murrayc.com>
250 OnlineGlomServiceImpl: Get .glom files recursively.
252 * pom.xml: Depend on commons-io from org.apache.commons.
253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
254 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
255 files recursively, and with the easier filter for the extension.
256 Use org.apache.commons.io.FilenameUtils.removeExtension() to
257 simplify that code too.
259 2012-01-19 Murray Cumming <murrayc@murrayc.com>
261 README: Mention that you must install java-libglom packages separately.
263 But then it works, because java-libglom is now in the central maven
266 2012-01-18 Murray Cumming <murrayc@murrayc.com>
268 locales drop-down: Show the correct selected locale when the URL changes.
270 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
271 .java: setPlace(): Move some code into fillView().
273 2012-01-18 Murray Cumming <murrayc@murrayc.com>
275 locales drop-down: Do not lose the primary key.
277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
278 start(): onLocaleChange(): Pass the current primary key value,
279 instead of an empty value.
281 2012-01-18 Murray Cumming <murrayc@murrayc.com>
283 locales drop-down: Do not lose the drop-down selection.
285 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
286 .java (TableSelectionActivity.fillView): Set the selected locale
287 after changing the drop-down items (though we do not really need
288 to change them just because the locale changes.)
290 2012-01-18 Murray Cumming <murrayc@murrayc.com>
292 locales drop-down: Change the tables list when this changes.
294 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
295 .java: TableSelectionActivity.start(): Move the async table titles
296 retrieval into a private fillView() method and also call this when
297 the chosen locale changes.
298 Note that the document title is not actually translatable yet, but
299 that is a problem that I should fix soon in libglom.
301 2012-01-18 Murray Cumming <murrayc@murrayc.com>
303 Improve the placement of the locales drop-down.
305 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
306 Put the title and locales drop-down in a div (gwt.FlowTable).
307 * src/main/webapp/style.css: Add magic css properties to make this work.
308 Also remove the left margin from the title so that it lines up with the
311 2012-01-18 Murray Cumming <murrayc@murrayc.com>
313 locales selector: Show human-readable locale titles.
315 * src/main/java/org/glom/web/server/ConfiguredDocument.java
316 getDocumentInfo(): Use java.util.Locale to show a real title of
317 each locale, in the locale's own language.
319 2012-01-17 Murray Cumming <murrayc@murrayc.com>
321 Add a language/locale selector drop-down.
323 * src/main/java/org/glom/web/shared/DocumentInfo.java:
324 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
325 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
326 getDocumentInfo(): Store the available Locales in the DocumentInfo.
327 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
328 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
329 Add a ListBox to show the available locales. Add getLocaleSelector(),
330 setLocaleList(), getSelectedLocale(), setSelectedLocale().
331 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
332 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
333 java: Add these classes.
334 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
335 start(): Fill the locales ListBox. Handle its change event, firing a
337 setPlace(): Show the selected locale as specified by the URL token.
338 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
339 * src/main/java/org/glom/web/client/activity/ListActivity.java:
340 Handle LocaleChangeEvent, going to a new *Place with that locale.
342 The placement of the ListBox is not pretty, and it currently uses the ID
343 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
347 2012-01-17 Murray Cumming <murrayc@murrayc.com>
349 Search box: Show the search text from the URL token.
351 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
352 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
353 Add setQuickFindText().
354 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
355 .java: setPlace(): Store the queryText if the place is a ListPlace,
356 and call TableSelectionView.setQuickFindText().
358 2012-01-17 Murray Cumming <murrayc@murrayc.com>
360 Allow use of translations via, for instance, &lang=de in the URL.
362 * pom.xml: Use the unstable java-libglom 1.21 version.
364 * src/main/java/org/glom/web/client/OnlineGlomService.java:
365 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
366 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
367 init(): Instead of calling TranslatableItem.set_current_locale()
368 (now removed), call ConfiguredDocument.setDefaultLocaleID().
369 However, this is only for default locales, which are not needed to
370 change the locale in the URL.
371 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
372 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
373 getSortedRelatedListData(): Add a localeID parameter, so we can get the
374 layout for a particular locale.
375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
376 Add get/setDefaultLocaleID().
377 getDocumentInfo(), getListViewData(), getRelatedListData(),
378 getDetailsLayoutGroup(), getListViewLayoutGroup(),
379 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
380 localeID parameter, so we can get the layout for a particular locale.
382 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
383 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
384 * src/main/java/org/glom/web/client/place/ListPlace.java:
385 Parse and construct a lang parameter too.
387 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
388 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
389 passed to subsequent methods and constructors.
390 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
391 * src/main/java/org/glom/web/client/activity/ListActivity.java:
392 Store the localeID from the *Place and pass it to other constructors
393 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
395 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
396 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
397 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
398 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
399 * src/main/java/org/glom/web/client/ui/ListView.java:
400 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
401 Take localeID parameters and pass them to subsequent constructors and
402 methods, so that the layout is always retrieved for that locale.
404 This is rather repetitive.
406 Note that "" means the original (default) locale of the Glom document,
407 which is usually English.
409 2012-01-17 Murray Cumming <murrayc@murrayc.com>
411 Documents: Remove final keyword to fix startup configuration.
413 * src/main/java/org/glom/web/shared/Documents.java: Remove the
414 final keywords on the private member variables because that breaks
415 the startup, apparently (there are warnings) because it stops them
416 from being serialized. I added these in the previous commit.
418 2012-01-13 Murray Cumming <murrayc@murrayc.com>
420 Documents: Add some final keywords.
422 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
425 2012-01-13 Murray Cumming <murrayc@murrayc.com>
427 OnlineGlomServiceImpl: Add to overview comments.
429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
430 Note that this is where all the document are loaded. They are not
431 loaded freshly for each page.
433 2012-01-12 Murray Cumming <murrayc@murrayc.com>
437 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
438 Add a TextBox for the text of a quick find.
439 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
441 setBackLink(): Add a String quickFind parameter.
442 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
443 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
444 to the base interface, because that is how TableSelectionViewImpl is used.
445 * src/main/webapp/style.css: Add style for the search box and its label.
447 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
448 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
449 Add these files, based on the existing TableChangeEvent and
450 TableChangeEventHandlers.
451 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
452 start(): Handle QuickFindChangeEvent, passing its quickFind text to
453 a ListPlace() that the user should be taken to.
454 * src/main/java/org/glom/web/client/activity/ListActivity.java
455 start(): Handle it here too and adapt the TableChangeEvent handler to
456 pass the extra "" quickFind parameter to ListPlace.
457 * src/main/java/org/glom/web/client/place/ListPlace.java:
458 Constructor: Take an extra String quickFind parameter and store it,
459 returning it from a new getQuickFind() method.
460 getToken(): Put the quickFind text in the URL token.
461 getPlace(): Parse the quickFind text from the URL token.
462 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
463 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
464 ListPlace constructor.
465 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
466 .java: start(): Add a Change handler for the TableSelectionView's
467 TextBox (via its base HasChangeHandlers interface), firing the new
468 QuickFindChangeEvent.
469 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
470 pass the extra "" quickFind parameter.
472 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
473 setCellTable(): Add a String quickFind parameter and pass it to
474 the ListViewTable() constructor.
475 * src/main/java/org/glom/web/client/ui/ListView.java: Change
476 setCellTable() in the base interface, because that is how ListViewImpl
479 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
480 Add a String quickFind member variable.
481 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
482 Constructor: Add a String quickFind parameter, storing it in the
483 base ListTable's member variable.
484 onRangeChanged(): Pass quickFind to the
485 OnlineGlomServiceAsync.getSortedListViewData() and
486 OnlineGlomServiceAsync.getListViewData() methods.
488 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
489 getListViewData(), getSortedListViewData(): Add a String quickFind
490 parameter, passing it to ConfiguredDocument.getListViewData().
491 * src/main/java/org/glom/web/client/OnlineGlomService.java:
492 Change getListViewData(), getSortedListViewData() in the base interface,
493 because that is how OnlineGlomServiceImpl is used, via this:
494 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
495 Change getListViewData(), getSortedListViewData() here too.
496 This class can apparently be used to asynchronously call methods on
497 OnlineGlomService, and GWT seems to implement that after recognizing
498 just the *Async name convention and the extra AsyncCallback parameters.
500 * src/main/java/org/glom/web/server/ConfiguredDocument.java
501 getListViewData(): Add a String quickFind parameter, and pass it to
502 ListViewDBAccess.getData().
503 * src/main/java/org/glom/web/server/database/ListDBAccess.java
504 getListData(): Add a String quickFind parameter and pass it to
506 getSelectQuery(): Add a String quickFind parameter.
507 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
508 getSelectQuery(): Add a String quickFind parameter and use it with
509 Glom.get_find_where_clause_quick() to pass a where_clause to
510 Glom.build_sql_select_with_where_clause(), to actually filter the
512 getData(): Add a String quickFind parameter, passing it to getListData().
513 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
514 va: getData(): Pass an empty string to getListData() for the
517 2012-01-12 Murray Cumming <murrayc@murrayc.com>
519 ListTable: Minor change.
521 * src/main/java/org/glom/web/client/ui/list/ListTable.java
522 createCellTable(): Make this protected instead of public.
524 2012-01-12 Murray Cumming <murrayc@murrayc.com>
526 Many files: Use final for the parameters and use the @override attribute.
528 2012-01-22 Ben Konrath <ben@bagu.org>
530 Add anchor links for single line text that starts with http, ftp and www.
534 2012-01-22 Ben Konrath <ben@bagu.org>
536 Add ellipsis to single line text in details view.
540 2012-01-04 Murray Cumming <murrayc@murrayc.com>
542 Remove all javadoc author tags.
544 Because they are awkward and meaningless when many people touch
546 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
548 2012-01-04 Murray Cumming <murrayc@murrayc.com>
550 Revert the COPYING.LESSER to COPYING rename.
552 Apparently both should be there if it is LGPL.
554 2012-01-03 Murray Cumming <murrayc@murrayc.com>
556 *View: Remove unused imports.
558 * src/main/java/org/glom/web/client/ui/DetailsView.java:
559 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
560 * src/main/java/org/glom/web/client/ui/ListView.java:
561 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
562 Remove unused imports, as suggested by Eclipse.
564 2012-01-02 Murray Cumming <murrayc@murrayc.com>
566 Move the *View::Presenter types, and some API into one base View.
568 * src/main/java/org/glom/web/client/ui/DetailsView.java:
569 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
570 * src/main/java/org/glom/web/client/ui/ListView.java:
571 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
572 Presenter, setPresenter() and clear() into a shared base interface,
573 to avoid the unnecessary duplicate Presenter types and to more clearly
574 show how the *Views share the same structure, even if they are not
575 used polymorphically.
577 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
578 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
580 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
581 * src/main/java/org/glom/web/client/activity/ListActivity.java:
582 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
584 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
587 Feel free to revert this if there is a good reason for the duplicate
590 2012-01-02 Murray Cumming <murrayc@murrayc.com>
592 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
594 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
595 a class member instead of a local variable in the method.
596 This lets us use it to get the view instances, for use in tests.
597 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
598 beforeOnlineGlom(): Test some more details of the initial view.
599 Again, this is not very useful.
601 To really test gwt-glom we will need to start a local postgresql
602 instance with local data, like the Glom tests in C++.
604 2012-01-02 Murray Cumming <murrayc@murrayc.com>
606 pom.xml: Mention the LGPL license.
608 * pom.xml: Add a licenses section.
609 * COPYING.LESSER: Move this to COPYING, which
610 previously contained the GPL. But gwt-glom is all LGPL.
612 2012-01-02 Murray Cumming <murrayc@murrayc.com>
614 Add project information to README and pom.xml.
616 * README: Add a brief description and mention some mvn
618 * pom.xml: This extra information shows up in mvn site
621 2011-01-02 Murray Cumming <murrayc@murrayc.com>
623 Use the latest java-libglom version.
625 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
627 2012-01-01 Murray Cumming <murrayc@murrayc.com>
629 GwtTestOnlineGlom: Test a little more.
631 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
632 protected rather than private, as suggested by the gwt-test-utils
634 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
635 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
636 Test the initial visibility of the panels.
638 However, this is not a very useful test.
639 And I wonder how we should generally test using this idea for an
640 activity/places app like ours where the real changes happen implicitly
641 based on the history token/URL.
643 2012-01-01 Murray Cumming <murrayc@murrayc.com>
645 Slight modification to *Mapper comments.
647 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
649 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
651 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
653 Remove comments mentioning GIN because they are just copied from
654 the example code and are apparently not helpful:
655 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
656 Also change the mention of a class that is only in the example code.
658 2012-01-01 Murray Cumming <murrayc@murrayc.com>
660 GwtTestOnlineGlom test: Minor changes.
662 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
663 Avoid the long qualified class name and modify the comment
664 because it is now obvious to me that the mocked class is the only
665 custom one created via GWT.create().
667 2012-01-01 Murray Cumming <murrayc@murrayc.com>
669 Tests: Added the beginnings of a test using gwt-test-utils.
671 * pom.xml: Add dependencies on gwt-test-utils and easymock.
672 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
673 which tells gwt-test-utils what class will be tested.
674 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
675 Add a simple (but empty) test case. One class, used by the OnlineGlom
676 class, is mocked so that it can be created. However, I am not sure
677 why only this class needs to be mocked.
679 Note that mockito seems more popular, and clearer, than easymock,
680 but I have not got that working yet. It might be a matter of the
683 This test is run during mvn integration-test.
685 2011-12-31 Murray Cumming <murrayc@murrayc.com>
687 Tests: Use junit4-style syntax instead of junit3-style.
689 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
690 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
691 * src/test/java/org/glom/web/shared/DataItemTest.java:
692 Use the @Test annotation rather than relying on the test*() prefix.
693 Also no longer implement TestCase, to avoid triggering support for
694 the junit3-way, which stops the annotations from working.
695 Change the imports from import junit.framework.* to
696 import org.junit.*, which is apparently the new way.
698 2011-12-31 Murray Cumming <murrayc@murrayc.com>
700 Added a test for ListPlace token parsing and creation.
702 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
703 This is much the same as DetailsPlaceTest.
705 I wonder how we could test the other parts of the *Place API.
707 2011-12-30 Murray Cumming <murrayc@murrayc.com>
709 DetailsPlace test: Also test getToken() and recreation via getPlace().
711 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
712 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
713 recreate it, testing the recreated DetailsPlace for the same parameter
716 2011-12-30 Murray Cumming <murrayc@murrayc.com>
718 Use the surefire-report plugin.
720 * pom.xml: This generates a HTML report about the tests in
721 target/site/surefire-report.html
722 when you do mvn surefire-report:report. It seems to be popular/normal.
724 2011-12-30 Murray Cumming <murrayc@murrayc.com>
726 Added a test for DetailsPlace.
728 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
729 Test the getPlace() token parsing.
731 2011-12-30 Murray Cumming <murrayc@murrayc.com>
733 Added a first unit test.
735 * pom.xml: Add a test goal, and a dependency on junit in that scope.
736 * src/test/java/org/glom/web/shared/DataItemTest.java:
737 This is a silly test but it is just to get things started. Note that
738 maven/junit finds the test because it looks in src/test by default.
740 2011-12-22 Ben Konrath <ben@bagu.org>
742 Change charsetName to "UTF-8" when replacing line breaks.
744 JavaScript requires the charsetName to be "UTF-8". CharsetName values
745 that work in Java (such as "UTF8") will not work when compiled to
748 This fixes a problem with multi-line details view fields that have hard
749 line breaks. The "License Text" field on this page demonstrates the
752 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
754 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
756 2011-12-22 Ben Konrath <ben@bagu.org>
758 Fix another bug with related list navigation.
760 I've tested all the navigation buttons in all of the related lists
761 so things should be good now.
763 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
765 2011-12-22 Ben Konrath <ben@bagu.org>
767 Fix a crasher when refreshing the list view with the default table.
769 This crash will also happen when loading the list view with the default
770 table from a link or bookmark.
772 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
773 to the main document selection page when the document id hasn't been
775 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
776 the main document selection page when the document id hasn't been
778 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
779 values for the details place when the document id hasn't been set.
780 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
781 values for the list place when the document id hasn't been set.
783 2011-12-21 Ben Konrath <ben@bagu.org>
785 Protect against NPE when glom.document.locale is not in config.
787 This patch protects against an NPE when glom.document.locale is not in
788 the config file. This NPE will also happen if glom.document.locale is
791 The patch also updates the error message to display the class name when
792 the getMessage() returns null. This was happening when the NPE was
793 thrown and I had "Configuration Error: null". If an NPE is encountered
794 with this patch, "Configuration Error: NullPointerException " will be
797 This commit closes this bug:
799 https://bugzilla.gnome.org/show_bug.cgi?id=666669
801 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
803 2011-12-20 Murray Cumming <murrayc@murrayc.com>
805 Rename onlineglom.properties to onlineglom.properties.sample.
807 * src/main/resources/onlineglom.properties: Rename to:
808 * src/main/resources/onlineglom.properties.sample:
809 * src/main/resources/README: And add this file explaining that people
810 should rename it back when deploying.
812 2011-12-20 Murray Cumming <murrayc@murrayc.com>
814 Allow choosing the translation in the .properties file.
816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
817 init(): Read a glom.document.locale value from the configuration file
818 and call Glom's TransatableItem::set_current_locale() method.
819 * src/main/resources/onlineglom.properties: Add a commented-out
820 example of this new setting.
822 It would be better to add &lang=de_DE to the URL, but the current
823 libglom API does not allow us to do this easily. I am working on that.
825 2011-12-19 Murray Cumming <murrayc@murrayc.com>
827 Avoid a crash in parsing of token parameters.
829 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
830 ava: getTokenParams(): Do not crash if a parameter has a key but no
831 value, and ignore parameters with neither.
833 2011-12-17 Murray Cumming <murrayc@murayc.com>
835 History token building/handling: Improve use of token parameters.
837 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
838 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
839 and buildParamsToken(HashMap), for use by derived classes.
840 Make the separator private because it is no longer be needed.
841 * src/main/java/org/glom/web/client/place/DetailsPlace.java
842 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
843 instead of manual string concatenation.
844 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
845 of hardcoded indices and awkward splitting code.
846 * src/main/java/org/glom/web/client/place/ListPlace.java
847 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
848 instead of manual string concatenation.
849 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
850 of hardcoded indices and awkward splitting code.
851 This should fix bug #666420
853 2011-12-16 Murray Cumming <murrayc@murrayc.com>
855 Fix a Navgiation->Navigation typo in the code.
857 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
858 Rename processNavgiation() to processNavigation().
860 2011-12-16 Murray Cumming <murrayc@murrayc.com>
862 Fix a seperator->separator typo in the code.
864 * src/main/java/org/glom/web/client/place/DetailsPlace.java
865 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
866 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
869 2011-12-15 Ben Konrath <ben@bagu.org>
871 Cleanup some comments.
873 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
875 2011-12-14 Ben Konrath <ben@bagu.org>
877 Replace \n with <br/> for multiline text in the details view.
879 Vertical scrollbars are added when needed as well.
881 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
883 2011-12-14 Ben Konrath <ben@bagu.org>
885 Specify the font for document selection links.
887 * src/main/webapp/style.css:
889 2011-12-14 Ben Konrath <ben@bagu.org>
891 Fix bouncy CellTable while paging.
893 This doesn't currently work with related list tables in unselected
896 * src/main/java/org/glom/web/client/ui/list/ListTable.java
898 2011-12-14 Ben Konrath <ben@bagu.org>
900 Revamp the appearance of the document selection page.
902 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
903 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
904 * src/main/webapp/style.css:
906 2011-12-13 Ben Konrath <ben@bagu.org>
908 Set navigation button column to the smallest size possible.
910 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
912 2011-12-13 Ben Konrath <ben@bagu.org>
914 Change OpenButton nomenclature to NavigationButton.
916 Using NavigtionButton makes things more generic. Classes, methods and
917 variables have been changed.
919 This is a rename-only refactor.
921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
922 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
923 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
924 Renamed from OpenButtonCell.
925 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
926 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
927 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
929 2011-12-12 Ben Konrath <ben@bagu.org>
931 Remove unnecessary String argument in RelatedListTable and ListViewTable.
933 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
935 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
936 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
938 2011-12-12 Ben Konrath <ben@bagu.org>
940 Update variable names and comments.
942 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
943 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
945 2011-12-12 Ben Konrath <ben@bagu.org>
947 Properly initialize numNonEmptyRows variable to zero.
949 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
950 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
952 2011-12-05 Ben Konrath <ben@bagu.org>
954 Add latest mockup with HTML tables.
956 Features of this mockup:
958 -> HTML table for flowtable
959 -> HTML table for flowtable column
960 -> Example of how related lists would look
961 -> Not using text entries for data items
963 The current version of Online Glom doesn't use HTML tables for the
966 This mockup has been sent to the glom-devel mailing list but it's good
967 to have it here as well.
969 * mockups/details-view-html-tables.html:
971 2011-12-05 Ben Konrath <ben@bagu.org>
973 Remove unnecessary getPrimaryKeyField() method.
975 getPrimaryKeyFieldForTable(String) has been renamed to
976 getPrimaryKeyField(String).
978 * src/main/java/org/glom/web/server/database/DBAccess.java:
979 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
980 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
982 2011-12-05 Ben Konrath <ben@bagu.org>
984 Add string representation of TypedDataItem value to conversion error message.
986 * src/main/java/org/glom/web/server/Utils.java: Logging the error
987 message was extracted into its own method to avoid duplication.
989 2011-12-05 Ben Konrath <ben@bagu.org>
991 Add type checking to navigation primary key value creation.
993 Create navigation primary key only if the expected type from the Glom
994 document matches the type returned by the SQL query.
996 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
998 2011-12-05 Ben Konrath <ben@bagu.org>
1000 Rename a couple of variables in RelatedListNavigation.
1002 This is a rename-only refactor.
1004 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1006 2011-12-05 Ben Konrath <ben@bagu.org>
1008 Move getListLayoutGroup() into getListViewLayoutGroup().
1010 This removes getListLayoutGroup(). It was only being called by
1011 getListViewLayoutGroup().
1013 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1015 2011-12-05 Ben Konrath <ben@bagu.org>
1017 Remove check for LayoutItem_Portal in list table method.
1019 This check is no longer necessary because the method isn't being used
1020 to create the LayoutItemPortal DTO.
1022 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1024 2011-12-05 Ben Konrath <ben@bagu.org>
1026 Properly support related list navigation.
1028 Navigation from the "Repository Analyzer -> Package Scans ->
1029 Dependencies" related table wasn't working because the primary key for
1030 related tables wasn't being set properly. This commit fixes the
1033 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1034 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1035 doesn't set the primary key properly for related list tables.
1036 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1037 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1038 useful for getting the primary key for list view tables and for related
1040 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1041 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1042 Move code to set the primary key for the table from the abstract
1043 ListDBAccess class to ListViewDBAccess as it's only correct for list
1045 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1046 Properly add primary key to related list tables.
1048 2011-12-02 Ben Konrath <ben@bagu.org>
1050 Properly set the horizontal alignment of fields.
1052 This fix is for both the list tables and the details view.
1054 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1055 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1056 to set the horizontal alignment of fields.
1058 2011-12-02 Ben Konrath <ben@bagu.org>
1060 Display currency codes in the details view.
1062 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1064 2011-12-02 Ben Konrath <ben@bagu.org>
1066 Avoid duplicate JNI call.
1068 JNI is not as efficient as pure Java and this is an easy (and small)
1071 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1072 Use previously retrieved value for whereClauseToTableName instead of
1075 2011-12-02 Ben Konrath <ben@bagu.org>
1077 Rename a couple of variables in RelatedListNavigation.
1079 This is a rename-only refactor.
1081 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1083 2011-12-02 Ben Konrath <ben@bagu.org>
1085 Indicate clearly that a mismatched primary key type is a bug.
1087 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1088 warning to error. Add 'This is a bug.' to message.
1090 2011-12-02 Ben Konrath <ben@bagu.org>
1092 Update / fix some comments.
1094 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1096 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1098 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1099 Fix comments. Add some TODOs.
1101 2011-12-02 Ben Konrath <ben@bagu.org>
1103 Enable navigation to details view with string primary key from related list.
1105 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1106 Create a text primary key value when return type of result is
1107 java.sql.Types.VARCHAR.
1109 2011-12-02 Ben Konrath <ben@bagu.org>
1111 Use checkboxes for booleans in the details view.
1113 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1115 2011-12-01 Ben Konrath <ben@bagu.org>
1117 Improve performance of related list height calculation.
1119 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1120 Put code to calculate the expected height in a static initializer so
1121 that that it's only called once.
1123 2011-12-01 Ben Konrath <ben@bagu.org>
1125 Show related list tables in notebooks (again).
1127 Calculate the height of the related list tables so the Notebook can be
1128 set the correct height. The height of the related list table is also needed by
1129 FlowTable to be able decide how to create the layout.
1131 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1132 and set the Portal height based on the height of the related list
1133 table and the Portal container.
1134 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1135 Add method to calculate the height of the related list tables.
1136 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1137 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1138 calculate the height of the Pager widget.
1140 2011-12-01 Ben Konrath <ben@bagu.org>
1142 Use CellTable API for table property instead of setting style on Element.
1144 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1146 2011-12-01 Ben Konrath <ben@bagu.org>
1148 Make ListViewTable and RelatedListTable a consistent height.
1150 The tables are now a consistent height regardless of the contents of
1151 the table. A hidden button is added to empty rows to ensure that the
1152 height of these rows will match the height of rows with data.
1154 A navigation button column is now added to every table. The width of
1155 the navigation column is set to 0px when a RelatedListTable shouldn't
1156 have navigation buttons. This maintains the a consistent row height in
1157 tables that don't show the navigation buttons.
1159 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1160 navigation column when not needed.
1161 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1162 arguments for navigation button to constructor of ListViewTable.
1163 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1164 hidden button for empty data rows.
1165 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1166 arguments for navigation button to constructor.
1167 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1168 create navigation buttons. Add hideNavigationButtons() method.
1169 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1170 arguments for navigation button to constructor.
1172 2011-12-01 Ben Konrath <ben@bagu.org>
1174 Use 'visibility: hidden' in Utils.getWidgetHeight().
1176 This is better choice because hidden elements are invisible, don't
1177 respond to events and are not part of the tab order. They will,
1178 however, take up space which is required to be able to calculate the
1179 height of the widget.
1181 * src/main/java/org/glom/web/client/Utils.java:
1183 2011-12-01 Ben Konrath <ben@bagu.org>
1185 Use Utils.getWidgetHeight() in FlowTable.
1187 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1189 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1191 2011-12-01 Ben Konrath <ben@bagu.org>
1193 Put the details css class name on the correct table column.
1195 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1197 2011-11-30 Ben Konrath <ben@bagu.org>
1199 Update for java-libglom API change.
1201 The getters and setters on FieldFormatting and NumericFormat were
1202 changed to remove the 'M'.
1204 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1206 2011-11-29 Ben Konrath <ben@bagu.org>
1208 Only allow RelatedListTables in Portals.
1210 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1212 2011-11-29 Ben Konrath <ben@bagu.org>
1214 Only create a contents panel for Portals when title is being set.
1216 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1218 2011-11-29 Ben Konrath <ben@bagu.org>
1220 Set TabLayoutPanel height based on calculated height its widgets.
1222 This is a potential fix for this bug:
1224 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1226 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1228 2011-11-29 Ben Konrath <ben@bagu.org>
1230 Align details field labels and data with the Open buttons.
1232 * src/main/webapp/style.css:
1234 2011-11-29 Ben Konrath <ben@bagu.org>
1236 Remove unnecessary <div> in the Notebook widget.
1238 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1239 method to get container FlowPanel (<div>).
1240 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1241 initWidget() method directly on the TabLayoutPanel widget instead of
1242 Group's container widget.
1244 2011-11-29 Ben Konrath <ben@bagu.org>
1246 Don't add group titles for Portals in Notebooks.
1248 This reverts the previous patch and fixes a bug I introduced with
1249 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1251 * src/main/java/org/glom/web/client/ui/details/Group.java:
1252 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1254 2011-11-28 Ben Konrath <ben@bagu.org>
1256 Remove unused boolean argument in Portal constructor.
1258 Just a code cleanup.
1260 * src/main/java/org/glom/web/client/ui/details/Group.java:
1261 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1263 2011-11-28 Ben Konrath <ben@bagu.org>
1265 Remove hack for glom 1.18 style glom files.
1267 * src/main/java/org/glom/web/client/ui/details/Group.java:
1268 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1269 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1271 2011-11-28 Ben Konrath <ben@bagu.org>
1273 Use Gda Value version of primary key to log result too large error.
1275 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1277 2011-11-28 Ben Konrath <ben@bagu.org>
1279 Don't use TypedDataItem.getText() for Unknown types from the URL.
1281 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1282 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1283 instead of getText().
1284 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1285 String field and getUnknown() method.
1287 2011-11-28 Ben Konrath <ben@bagu.org>
1289 Log an error message when the java-libglom .so is not present.
1291 The error message was being set in the exception but not logged.
1293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1295 2011-11-28 Ben Konrath <ben@bagu.org>
1297 Ignore LayoutItem_CalendarPortals.
1299 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1300 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1302 2011-11-28 Ben Konrath <ben@bagu.org>
1304 Extract method for creating the LayoutItemPortal DTO.
1306 Just breaking the code up into smaller chunks.
1308 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1310 2011-11-28 Ben Konrath <ben@bagu.org>
1314 This should have been added with the refactor. Oops!
1316 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1318 2011-11-28 Ben Konrath <ben@bagu.org>
1320 Create primary key value from URL string using type from Glom document.
1322 See this bug, comments 19 - 25:
1324 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1326 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1327 create a TypeDataItem for the primary key here when loading from a
1328 URL. Show the same string for the primary key value as was received
1329 from the URL string (when loading from a URL).
1330 * src/main/java/org/glom/web/server/Utils.java: Update method for
1331 creating the Gda Value from the TypeDataItem to properly deal with
1332 creating a Gda Value based on the Glom document type for the primary
1333 key value string when loading from a URL.
1334 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1335 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1336 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1337 Update for changed method name.
1339 2011-11-27 Ben Konrath <ben@bagu.org>
1341 Rename PrimaryKeyItem to TypedDataItem.
1343 The name PrimaryKeyItem suggests what the class should be used for.
1344 TypedDataItem is a neutral name that describes the class better.
1346 This is a rename-only refactor.
1348 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1349 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1350 * src/main/java/org/glom/web/client/Utils.java:
1351 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1352 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1353 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1354 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1355 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1356 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1357 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1358 * src/main/java/org/glom/web/server/Utils.java:
1359 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1360 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1361 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1362 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1364 2011-11-25 Ben Konrath <ben@bagu.org>
1366 Improve Gda Value conversion from PrimaryKeyItem.
1368 The value from the PrimaryKeyItem is only used if its type match the
1369 type from the glom document.
1371 * src/main/java/org/glom/web/server/Utils.java:
1373 2011-11-25 Ben Konrath <ben@bagu.org>
1375 Manually check if the java-liblgom .so is visible to the JVM.
1377 It seems that Tomcat has problems when a static initializer throws an
1378 exception. This check is done before the first method call into
1379 java-libglom so that execution doesn't continue if the .so is not
1382 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1384 2011-11-25 Ben Konrath <ben@bagu.org>
1386 Improve browser configuration error messages.
1390 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1392 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1393 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1394 getConfigurationErrorMessage() method.
1395 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1396 Get and display a specific configuration error message when no Glom
1397 documents are found.
1398 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1399 Implement getConfigurationErrorMessage() method. Surround configuration
1400 code in the init() method with a try/catch block. This allows the
1401 errors to be caught while keeping the servlet available to retrieve the
1402 configuration error message.
1404 2011-11-25 Ben Konrath <ben@bagu.org>
1406 Don't use Strings to hold primary key values.
1408 The primary key values are now held in a new data object
1409 (PrimaryKeyItem) that holds type information and the primary key value
1410 using the correct type.
1412 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1413 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1415 PrimaryKeyItem instead of String to hold the primary key value.
1416 * src/main/java/org/glom/web/client/Utils.java: Remove
1417 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1418 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1419 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1420 PrimaryKeyItem instead of String to hold the primary key value. Load
1421 document selection page when the documentID has not been set correctly.
1422 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1423 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1425 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1426 Return empty string for URL instead of "null".
1427 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1428 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1429 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1430 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1431 PrimaryKeyItem instead of String to hold primary key values.
1432 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1433 PrimaryKeyValue to a Gda Value.
1434 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1435 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1436 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1437 Replace temporary database access code that uses the PrimaryKeyValue to
1438 Gda Value conversion.
1439 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1440 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1441 PrimaryKeyItem instead of String.
1442 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1443 hold primary key values.
1445 2011-11-24 Ben Konrath <ben@bagu.org>
1447 Use newly added java-libglom API to create queries.
1449 This isn't finished. I still need to stop using Strings for primary key
1450 values in the client code.
1452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1453 libglom to use fake connections so that retrieving the query string will
1455 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1456 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1457 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1458 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1459 Use the newly added libglom sql methods and classes to create the
1460 query. Add temporary hack to convert primary value strings to Gda
1463 2011-11-23 Ben Konrath <ben@bagu.org>
1465 Don't explicitly set the height of Portals.
1467 See comments 6 - 10 of this bug for details:
1469 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1471 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1473 2011-11-23 Ben Konrath <ben@bagu.org>
1475 Use an HTML table instead of CSS for the FlowTable layout.
1477 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1478 GWT's FlexTable to implement the FlowTable.
1479 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1481 2011-11-18 Ben Konrath <ben@bagu.org>
1483 Add boolean example to HTML table mockup.
1485 * mockups/details-view-html-tables-text-entries.html:
1487 2011-11-17 Ben Konrath <ben@bagu.org>
1489 Ensure the pager buttons are always visible for related lists.
1491 To accomplish this, I've turned off text wrapping in the list view and
1492 related list tables for both the header and data text. The related list
1493 table now has a fixed layout so the it doesn't overflow its container.
1494 This is required to ensure that the cell text is clipped when it
1495 overflows the cell and an ellipsis is added to the right side of the
1496 cell when text is clipped.
1498 A fixed table layout for the related list table in the details view
1499 seems what we want for the details view anyway, so the side-effect is
1502 The ellipsis will only be displayed in Firefox >= 7.
1506 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1508 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1509 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1510 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1512 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1513 Set the 'table-layout: fixed' CSS property to the related list table.
1514 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1515 'white-space: nowrap;' CSS property on both the list view and the
1516 related list tables.
1518 2011-11-16 Ben Konrath <ben@bagu.org>
1520 Rework the fix for empty notebook tab labels.
1522 Setting the empty group titles with its name caused problems for the
1523 details layout. Instead of using libglom's
1524 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1525 to the client when the title is empty. This allows the Notebook to use
1526 the name when the title is empty without affecting anything else.
1528 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1529 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1531 2011-11-16 Ben Konrath <ben@bagu.org>
1533 Set group titles with name when title is empty.
1535 This fixes a problem with an empty notebook tab label in the Lesson
1536 Planner document. The forth tab in the notebook should be "Internet":
1538 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1540 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1541 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1544 2011-11-16 Ben Konrath <ben@bagu.org>
1546 Remove whitespace from the configured username properties.
1548 This assumes that usernames won't have whitespace at the beginning
1549 or end. But I think this is a reasonable assumption.
1551 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1552 String.trim() to remove the whitespace from the username properties.
1554 2011-11-15 Ben Konrath <ben@bagu.org>
1556 Add details view mockup with HTML tables and text entries.
1558 This is from the attachment on this bug:
1560 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1562 * mockups/details-view-html-tables-text-entries.html:
1564 2011-11-15 Ben Konrath <ben@bagu.org>
1566 Add space between the columns of the flow table.
1570 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1572 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1573 space between columns in the flow table.
1575 2011-11-15 Ben Konrath <ben@bagu.org>
1577 Add backup files to the .gitignore.
1579 * .gitignore: Ignore files that end with ~.
1581 2011-11-09 Ben Konrath <ben@bagu.org>
1583 Use latest release of gwt-log.
1585 Gwt-log releases are now being submitted to the maven central
1586 repository so manual installation of the jar is no longer required.
1588 * pom.xml: Update version and groupId of gwt-log dependency.
1590 2011-10-31 Ben Konrath <ben@bagu.org>
1592 Don't use GWT numeric formatting to override the glom currency formatting.
1594 Currencies are now displayed like they are in Glom. See this bug:
1596 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1598 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1600 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1601 currency code to constructor and set it when the cell is rendered.
1602 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1603 currency code to the constructor of the NumericCell.
1605 2011-10-27 Ben Konrath <ben@bagu.org>
1607 Require the latest release of java-libglom (1.17.4).
1611 2011-10-26 Ben Konrath <ben@bagu.org>
1613 Add style to Notebook that matches current theme.
1615 It's not the best style in the world but it's better than the default.
1617 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1618 padding at the bottom of the child widgets.
1619 * src/main/webapp/style.css: Add style for the Notebook.
1621 2011-10-26 Ben Konrath <ben@bagu.org>
1623 Move servlet initialization code to overridden init method.
1625 This is half of the solution to getting proper error messages
1626 displayed when configuration errors occur. Here's the relevant bug:
1628 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1630 The rest of the solution involves surrounding the init method with a
1631 try/catch block and setting a global variable with the error /
1632 exception. A new async method should be created to retrieve and display
1633 the error message / exception.
1635 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1636 code from constructor to init method adding exceptions as needed.
1638 2011-10-26 Ben Konrath <ben@bagu.org>
1640 Add script to monitor and restart tomcat if required.
1642 * utils/check-and-recover-tomcat.py: New file.
1644 2011-10-26 Ben Konrath <ben@bagu.org>
1646 Display the correct number of data items in the pager.
1650 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1652 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1653 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1654 The implementation is the same for both tables: Keep track of the
1655 number of non-empty rows and fire and RowCountChangeEvent after the data has
1657 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1658 custom Pager class that subclasses SimplePager to handle displaying
1659 the correct number when empty rows have been added.
1661 2011-10-26 Ben Konrath <ben@bagu.org>
1663 Correct error in previous commit.
1665 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1666 eventBus parameter from listView.setCellTable().
1668 2011-10-26 Ben Konrath <ben@bagu.org>
1670 Fix error in TODO comment.
1672 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1674 2011-10-24 Ben Konrath <ben@bagu.org>
1676 Create Notebook widgets to the details view.
1678 This isn't finished just yet - I still need to create a reasonable
1679 style to match the current theme.
1681 * src/main/java/org/glom/web/client/Utils.java: Add method for
1682 calculating the height of a widget. This is used in the Notebook class.
1683 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1684 new constructor method in Group.
1685 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1686 method for creating child widget that can be used by subclasses
1687 like Notebook. New constructor that allows disabling the group
1688 titles - Notebooks don't set a group title for their child groups.
1689 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1690 to make Notebooks using GWT's TabLayoutPanel.
1691 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1692 constructor that allows disabling the group titles.
1693 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1694 LayoutItemNotebook DTO.
1695 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1696 DTO for Notebooks. It's just an empty class for now but we might need
1697 it to transfer some specific information in the future.
1699 2011-10-21 Ben Konrath <ben@bagu.org>
1701 Add navigation buttons to related list tables.
1703 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1704 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1705 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1706 method getSuitableRecordToViewDetails() for getting the table name
1707 and primary key value for related list navigation buttons.
1708 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1709 private cell renderer class to get the navigation information for
1710 related list tables from the server. Extract the navigation
1711 processing code from the details cell navigation and use it for the
1712 related list navigation as well.
1713 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1714 cell renderer class for the details open buttons. This was needed
1715 because the related list navigation buttons and the list view
1716 navigation buttons need to react differently when clicked.
1717 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1718 the onEnterKeyDown() method because it's now overriden in the
1719 subclasses that are specific to the related list tables and the list
1721 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1722 the vertical size a little because the buttons add a bit of vertical
1723 space to table. This is not a perfect solution because the vertical
1724 size of with table fewer than 5 rows will be a little smaller.
1725 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1726 changes in how navigation buttons are handled.
1727 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1728 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1729 database access object.
1730 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1731 to find the portal for a given relationship name from
1732 RelatedListDBAccess. Add method to find a primary key field for a
1734 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1735 Move code to find the portal for a given relationship name to
1737 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1738 New file: database access object for getting the related list
1739 navigation information (the table name and the primary key value).
1740 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1741 DTO for transferring a table name to navigate to and a primary key
1743 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1744 boolean and getter/setter to specifies if the related list should add
1747 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1749 Use the master branch of java-libglom
1751 * pom.xml: Depend on java-libglom 1.19 instead.
1753 This is the master branch. See also the libglom-1-18 branch.
1755 2011-10-11 Ben Konrath <ben@bagu.org>
1757 Enable the open navigation button when the data has been set.
1759 This avoids having active buttons that don't do anything when the data
1762 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1764 2011-10-11 Ben Konrath <ben@bagu.org>
1766 Use IsWidget interface for FlowTableItem.
1768 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1769 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1771 2011-10-11 Ben Konrath <ben@bagu.org>
1773 Remove GWT styling from open button in details view.
1775 There are still some issues with how the details cell is arranged but
1776 this should be made to match Glom 1.20. I'm going to leave fixing this
1777 until I have Glom 1.20 up and running.
1779 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1780 style name on open button.
1781 * src/main/webapp/style.css: Move and edit details-navigation class.
1782 Re-arrange some classes to make them appear in the same order as the
1785 2011-10-07 Ben Konrath <ben@bagu.org>
1787 Update to GWT 2.4.0.
1789 * .gitignore: Ignore new cache directory.
1790 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1791 * pom.xml: Change GWT and maven plugin to 2.4.0.
1792 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1794 * src/main/java/org/glom/web/client/ClientFactory.java:
1795 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1796 * src/main/java/org/glom/web/client/OnlineGlom.java:
1797 Update source for API changes.
1798 * utils/build-onlineglom-war.sh: Remove cache directory before the
1801 2011-10-07 Ben Konrath <ben@bagu.org>
1803 Add navigation buttons in the details view.
1805 This isn't finished but I thought I'd commit what I have as it's a
1806 pretty good start. I still need to:
1808 1. Change the style so that it fits better into the current theme
1809 2. Adjust the details cell to expand as much as possible.
1811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1812 click handlers to navigation buttons in the DetailsCells. Create a
1813 refreshData() method to get just the data from the server without the
1815 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1816 Update the tableSelector and browser title when the table name
1817 changes without using the tableSelector.
1818 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1819 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1820 getDetailsCells() to getCells(). Update variable names.
1821 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1822 method to set click handler on navigation button. Rename a few
1823 variables. Add navigation buttons where needed.
1824 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1825 variables and methods.
1826 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1827 navigation boolean and navigation table as required in the
1828 LayoutItemField DTO.
1829 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1830 variables for navigation along with getter/setter methods.
1832 2011-10-07 Ben Konrath <ben@bagu.org>
1834 Rename Field to DetailsCell.
1836 This is a refactor-only commit. No functionality has been added or
1839 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1840 Update variable and method names.
1841 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1842 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1843 variable and method names.
1844 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1846 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1847 variable and method names.
1849 2011-10-07 Ben Konrath <ben@bagu.org>
1851 Create separate methods for layout and data the details view.
1853 This is a refactor-only commit. No functionality has been added or
1856 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1857 private methods: setData(), createLayout().
1859 2011-10-07 Ben Konrath <ben@bagu.org>
1861 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1863 This is part of a change to get navigation buttons in the details view
1864 but it should have been done this way from the start.
1866 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1867 for method name change in TableSelectionView.
1868 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1869 Create TableChangeEvent and set the browser title using the
1870 TableSelectionView API.
1871 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1872 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1873 Change getSelectedTable() to getSelectedTableName(). Add
1874 getSelectedTableTitle().
1876 2011-10-07 Ben Konrath <ben@bagu.org>
1878 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1880 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1882 2011-10-07 Ben Konrath <ben@bagu.org>
1884 Update TableChangeEvent to use newTableName naming convention.
1886 This makes the class more consistent with GWT naming conventions.
1888 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1889 Update for method name change in TableChangeEvent.
1890 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1891 for method name change in TableChangeEvent.
1892 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1893 newTableName variable and getter method. Make toDebugString()
1896 2011-09-30 Ben Konrath <ben@bagu.org>
1898 Disable the pager in the list tables when the data row count is less than the minimum.
1900 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1901 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1903 2011-09-30 Ben Konrath <ben@bagu.org>
1905 Add empty rows to the end of related list and list view tables.
1907 I also extracted the cell rendering classes from the ListTable because
1908 the code was becoming a little crazy with all the anonymous inner
1909 classes. My plan is to use these cell rendering classes in the details
1910 view as well so this refactor will be needed for that change.
1912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1913 set the row count in related list tables if the data has more rows
1914 than the minimum number of rows visible.
1915 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1916 row count in list view tables if the data has more rows than the
1917 minimum number of rows visible.
1918 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1919 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1921 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1922 for rendering TYPE_NUMERIC cells. The code was extracted from the
1924 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1925 class for rendering cells with buttons in list views. The code was
1926 extracted from the ListTable class.
1927 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1928 for rendering TYPE_TEXT cells. The code was extracted from the
1930 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1931 Add empty rows to the end of the data if required. Implement
1932 ListTable.getMinNumVisibleRows().
1933 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1934 cell renderer code to public classes. Return null in
1935 Column.getValue() for empty rows. Add new abstract method:
1936 getMinNumVisibleRows(). Move code to set the row count of the list view
1937 table to ListViewImpl.
1938 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1939 empty rows to the end of the data if required. Implement
1940 ListTable.getMinNumVisibleRows().
1943 2011-09-27 Ben Konrath <ben@bagu.org>
1945 Use GWT.log for client-side debugging statements.
1947 These are optimized out when deployed so I should have used this method
1948 in the first place. These statements will eventually be replaced with some sort
1949 of notification in the browser.
1951 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1952 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1953 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1954 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1955 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1957 2011-09-27 Ben Konrath <ben@bagu.org>
1959 Put tableselector on the right, back to list link on right.
1961 The idea is that the table selector is acting like a label for the
1962 currently displayed table so it should be placed below the document title. This
1963 puts the table title in a similar position to where it is in Glom.
1965 * mockups/details-contacts.html:
1966 * mockups/details-projects.html:
1967 * mockups/listview-contacts.html:
1968 * mockups/listview-projects.html:
1969 * mockups/style.css:
1970 Update mockups to match how the interfaces currently look.
1971 * src/main/webapp/style.css: Swap positions of backlink with the table
1972 selector. Add some space on the left side of the table selector to
1973 line things up with the document title.
1975 2011-09-27 Ben Konrath <ben@bagu.org>
1977 Add field colouring to details view.
1979 This change re-works how field colouring works. The colour formatting
1980 information is now set to the client with the layout information instead of
1981 with the data. This eliminates the need to send the same colour strings for
1982 data in list view column when colour information is set.
1984 In order to set an alternate colour for negative numeric values, the
1985 number is now sent to client and formatted with the GWT NumberFormat class.
1987 This change also fixes:
1989 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1991 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1992 internationalization framework which is needed for client side numeric
1994 * src/main/java/org/glom/web/client/Utils.java: New file for some
1995 client static utility methods.
1996 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1997 the DataItem object to the Field class. Use a utility method to
1998 create the foreignKeyValue string.
1999 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2000 alignment and text colours in the constructor. Add setData(DataItem)
2001 method. Remove setText(String) method.
2002 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2003 colour information to GlomTextCell. Create and use GlomNumberCell for
2004 rendering numbers. Use utility method to get the string for the
2005 primary key of the key provider. Re-work how the horizontal alignment
2007 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2008 formatting to layout information. Methods for converting the libglom
2009 formatting information were moved from DBAccess.
2010 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2011 numeric formatting (it's now done on the client side). Don't set text
2012 colours in DataItem. Move libglom formatting conversion methods to
2014 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2015 getters/setters for text colour information.
2016 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2017 for transferring the libglom NumericFormat information to the client.
2018 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2019 and getters/setters for: GlomNumericFormat, background colour and
2020 foreground colour strings.
2022 2011-09-26 Ben Konrath <ben@bagu.org>
2024 Simplify code that iterates through the LayoutGroup.
2026 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2028 2011-09-26 Ben Konrath <ben@bagu.org>
2030 Accept Eclipse formatting for OnlineGlomServiceAsync.
2032 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2034 2011-09-26 Ben Konrath <ben@bagu.org>
2036 Don't use the ListDBAccess classes to get the primary key layout information.
2038 This was causing a bug where the wrong index for the hidden primary key
2039 was being sent to the client.
2041 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2042 primary key while creating the LayoutGroup DTO. Create a
2043 LayoutItemField DTO for hidden primary keys. Don't use the
2044 RelatedListDBAccess because it was only used for getting the primary
2046 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2047 access modifier from public to protected for getPrimaryKeyField() and
2048 getPrimaryKeyLayoutItemField().
2049 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2050 abstract method getExpectedResultSize() because RelatedListDBAccess
2051 doesn't have enough info to implement it.
2052 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2053 Remove @Override for getExpectedResultSize().
2054 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2055 Remove method getExpectedResultSize().
2057 2011-09-23 Ben Konrath <ben@bagu.org>
2059 Log which layout (list or details) the ignored item is from.
2061 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2063 2011-09-23 Ben Konrath <ben@bagu.org>
2065 Remove annotations that turn off code formatting in DataItem.
2067 * src/main/java/org/glom/web/shared/DataItem.java:
2069 2011-09-23 Ben Konrath <ben@bagu.org>
2071 Rename GlomField to DataItem and update associated methods.
2073 This is a rename-only refactor. No functionality has been added or
2076 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2078 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2079 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2080 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2081 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2082 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2083 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2085 * src/main/java/org/glom/web/server/database/DBAccess.java:
2086 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2087 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2088 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2089 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2090 * src/main/java/org/glom/web/shared/DataItem.java:
2091 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2092 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2094 2011-09-23 Ben Konrath <ben@bagu.org>
2096 Rename GlomDocument to DocumentInfo and update associated methods.
2098 This is a rename-only refactor. No functionality has been added or
2101 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2102 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2103 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2104 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2105 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2107 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2109 2011-09-20 Ben Konrath <ben@bagu.org>
2111 Require java-libglom 1.17.3.
2113 This picks up the fix for the seg fault problem with the Scenes table
2114 in the Openismus Film Manager example.
2118 2011-09-20 Ben Konrath <ben@bagu.org>
2120 Change the way sort clause is added for primary key when no sort clause is requested.
2122 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2123 before the sort clause is created. When a sort clause is not requested, the
2124 sort clause is created by finding the primary key in the LayoutFieldVector
2127 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2129 2011-09-20 Ben Konrath <ben@bagu.org>
2131 Log error message if no documents are found in the configured directory.
2133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2134 Extract the glom file extension string to a private static final class
2135 variable (mostly as syntactic sugar). Accept a minor formatting change.
2136 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2137 the example glom.document.directory configuration property to make it
2138 more clear that it can any directory, not just the home directory.
2140 2011-09-18 Ben Konrath <ben@bagu.org>
2142 Add related lists to details view.
2144 The related list table has support for paging and sorting just like the
2145 table in the list view.
2147 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2148 SQL queries for the related list tables.
2149 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2150 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2152 Rename getList methods to getListView and add comments. Remove
2153 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2154 it being unused. Add methods: getDetailsLayoutAndData(),
2155 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2157 Create the layout and set the data for the fields in one async call
2158 instead of two. Create related lists where appropriate.
2159 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2160 for method name changes in OnlineGlomService.
2161 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2162 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2163 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2165 * src/main/java/org/glom/web/client/ui/ListView.java:
2166 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2167 tableName from setCellTable(). Create a ListViewTable instead of
2169 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2170 represent a data field in the details view.
2171 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2172 from addDetailsCell() to Field class. Keep track of the Fields and
2173 Portals in the details view.
2174 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2175 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2176 and add a method to get it. Add method to set the contents of the
2178 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2179 New class for related list tables. This class has the data provider
2180 for the related list table.
2181 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2182 abstract class which is the base class for the ListViewTable and the
2184 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2185 New class for list view tables. This class has the data provider for
2186 the list view table.
2187 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2188 methods for related list tables. Add more information to the
2189 LayoutItemField and LayoutItemPortal DTOs.
2190 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2191 Remove debugging print statement.
2192 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2193 Remove debugging print statements. Add primary key field to SQL count
2195 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2196 Remove unnecessary LayoutFieldVector parameter from
2197 getResultSizeOfSQLQuery() method.
2198 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2199 New class for related list table database access.
2200 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2201 class that is a wrapper DTO for details view layout and data.
2202 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2203 new 'fromField' string to this DTO.
2204 * src/main/webapp/style.css: Remove bottom margin and override top
2207 2011-09-15 Ben Konrath <ben@bagu.org>
2209 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2211 This sets things up to make it easier to add the data retrieval for
2212 related lists (portals). No user noticeable changes were made with
2215 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2216 class has the code to retrieve the layouts and access the
2217 database using the new database helper classes.
2218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2219 Most of the functionality has been removed from this class. This
2220 class now represents the public interface for the client side
2221 code. It also deals with configuring the servlet and cleaning
2222 things up when the servlet is stopped.
2223 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2224 of static methods into this utility class.
2225 * src/main/java/org/glom/web/server/database/DBAccess.java:
2226 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2227 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2228 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2229 These classes have the database retrieval code. The class hierarchy
2230 has been setup to make it easy to reuse code for similar
2233 2011-09-06 Ben Konrath <ben@bagu.org>
2235 Create separate classes for list table code and the data provider.
2237 As part of this refactor, I also split up the code a bit to make it
2240 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2241 table code to two new classes (below).
2242 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2243 with code from ListViewImpl.
2244 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2245 New file with code from ListViewImpl.
2247 2011-09-06 Ben Konrath <ben@bagu.org>
2249 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2251 This fixes the LayoutItemPortal DTO to match the libglom layout object
2254 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2256 2011-09-01 Ben Konrath <ben@bagu.org>
2258 Set title of Portals in the Details View.
2260 * pom.xml: Bump required version of java-libglom to 1.17.1.
2261 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2262 widget creation to its own class. Add comments to constructor.
2263 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2264 The code is mostly from the Group class with the title now set.
2265 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2266 title of Portal. Update some comments. Fix some code formatting.
2268 2011-09-01 Ben Konrath <ben@bagu.org>
2270 Remove TODO comment for the flow table column width.
2272 The flow table column width is working correctly and doesn't need to be
2273 changed. See this mailing list post for more info:
2275 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2277 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2279 2011-08-27 Ben Konrath <ben@bagu.org>
2281 Add document title (database name) to top of the browser page.
2283 I added the document title to the TableSelecitonView but that will
2284 change if / when we add a view that doesn't require table selection.
2286 * mockups/details-contacts.html:
2287 * mockups/details-projects.html:
2288 * mockups/listview-contacts.html:
2289 * mockups/listview-projects.html:
2290 * mockups/style.css: Add document title to mockups to keep things
2292 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2293 sizes to account for the document title.
2294 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2295 Set the document title when it has been retrieved from the server.
2296 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2297 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2298 and implement setDocumentTitle(String) method.
2299 * src/main/webapp/style.css: Add ID for document title style.
2301 2011-08-25 Ben Konrath <ben@bagu.org>
2303 Add NavigationType enum to LayoutItemPortal DTO.
2305 This is the start of adding support for Portals to the Details View.
2307 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2308 LayoutItem_Portal.navigation_type enum from libglom to
2309 LayoutItemPortal.NavigationType enum.
2310 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2311 NavigationType enum, field for storing the NavigationType and getter
2314 2011-08-25 Ben Konrath <ben@bagu.org>
2316 Implement the flow table layout in the Details View.
2318 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2319 FlowTable to Group to account for the renamed class.
2320 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2321 File. This is a container widget that implements the Glom details view
2322 flow table behaviour.
2323 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2324 org/glom/web/client/ui/FlowTable.java.
2325 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2326 so that the size of the subgroups are a closer match to the size of
2327 the Glom subgroups. This makes the flowtable layout match the layout
2328 in Glom for the Music Collection example file.
2330 2011-08-16 Ben Konrath <ben@bagu.org>
2332 Create container element for LayoutItemPortal in Details View.
2334 This will help me develop the layout for the FlowTable.
2336 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2337 fieldPanel variable to detailsCell.
2339 2011-08-15 Ben Konrath <ben@bagu.org>
2341 Set the height of the data element in the Details View.
2343 I changed the InlineLabels (text in a span element) to Labels (text in
2344 a div element) so that I could set the height of the details-data
2345 elements instead of the details-cell parent elements. This allows the
2346 the details-data element to display the correct height if style is
2347 applied that shows the height.
2349 This change has the added benefit of allowing the order of the labels
2350 and data elements to be changed for right-to-left languages.
2352 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2353 InlineLabels to Labels.
2354 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2355 InlineLabels to Labels. Set the height of the data element.
2356 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2357 multiline text height in the Formatting DTO.
2358 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2359 for multiline height along with getter and setter methods.
2360 * src/main/webapp/style.css: Adjust style to account for the change
2361 from span elements to div elements in the details cell.
2363 2011-08-15 Ben Konrath <ben@bagu.org>
2365 Make the List View appearance match the mockups.
2367 It doesn't match exactly but it's much better than it was.
2369 * mockups/listview-contacts.html: Remove unused css classes.
2370 * mockups/listview-projects.html: Remove unused css classes.
2371 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2372 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2373 for mainPanel instead of VerticalPanel (table). Set style name on
2374 CellTable. Set style name on Details column. Right-align Details
2376 * src/main/webapp/style.css: Adjust properties to match the mockups.
2378 2011-08-12 Ben Konrath <ben@bagu.org>
2380 Add better support for subgroups in the details view.
2382 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2383 changed FlowTable constructor.
2384 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2385 support for subgroups and subgroup-titles.
2386 * src/main/webapp/style.css: Add CSS class for subgroups and
2389 2011-08-12 Ben Konrath <ben@bagu.org>
2391 Return the top level LayoutGroup title.
2393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2395 2011-08-11 Ben Konrath <ben@bagu.org>
2397 Make the TableSelector header match the mockup.
2399 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2400 the layout panel. Properly lineup the table selection header with
2401 the list and details view.
2402 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2403 margin around the details view.
2404 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2405 Rename listBox variable to tableSelector. Set id for the style sheet.
2406 Use a FlowPanel instead of a HorizontalPanel.
2407 * src/main/webapp/style.css: Add properties to make the TableSelector
2408 box match the mockups.
2410 2011-07-13 Ben Konrath <ben@bagu.org>
2412 Update install script for java-libglom version change.
2414 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2417 2011-07-13 Ben Konrath <ben@bagu.org>
2419 Add support sub-group in the details view.
2421 I also removed the code that special-cased the default details view
2424 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2426 I still have to make a proper flowtable.
2428 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2429 Don't special-case default details view layout.
2430 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2431 addLayoutField() as I'm going to use it.
2432 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2433 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2435 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2436 extracted from DetailsViewImpl.GroupPanel. Add support for
2438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2439 column count when getting the details layout.
2441 2011-07-12 Ben Konrath <ben@bagu.org>
2443 Set browser title with database and table titles.
2445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2446 Set the browser title when the table changes and when the activity
2448 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2449 title when retrieving document info (the GlomDocument object).
2450 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2451 with getter and setter methods. Remove unused convenience constructor.
2452 Use default code formatting.
2454 2011-07-12 Ben Konrath <ben@bagu.org>
2456 Ignore LayoutItemPortals in the details view.
2458 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2461 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2462 LayoutItemPortal layout objects.
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2464 LayoutItemPortal objects when retrieving the details layout.
2465 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2466 file. This is an empty class and just used to get type information for
2469 2011-07-12 Ben Konrath <ben@bagu.org>
2471 Use java-libglom 1.17.0.
2475 2011-07-11 Ben Konrath <ben@bagu.org>
2477 Remove "Table:" label from table selector.
2479 This matches a recent change in the Glom UI.
2481 * mockups/details-contacts.html:
2482 * mockups/details-projects.html:
2483 * mockups/listview-contacts.html:
2484 * mockups/listview-projects.html: Remove the "Table:" label from the
2486 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2488 2011-07-11 Ben Konrath <ben@bagu.org>
2490 Add main groups to the details view.
2492 This makes things look a little nicer in the details view. The next step
2493 is to implement the flowtable.
2495 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2496 resources from the standard gwt css theme. Standard.css is now
2497 included in OnlineGlom.html so that the online glom css rules have
2498 precedence over the gwt theme.
2499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2500 the whole LayoutGroup to the DetailsView instead of just the titles.
2501 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2502 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2503 details layout with a helper class (GroupPanel). I might extract this
2504 class when I make the full flowtable.
2505 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2506 string as default so I don't have to worry about NPEs when processing
2508 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2509 note beside OnlineGlom.gwt.xml above).
2510 * src/main/webapp/style.css: Add default font-size to body to override
2511 the font-size set by the standard theme. Don't use h2 tags for
2512 group-title. Create new details-cell class.
2514 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2516 ConfiguredDocument: Set the port number too.
2518 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2519 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2520 Glom document. Presumably this worked sometimes so far because there is a
2521 default port number.
2523 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2525 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2527 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2528 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2529 correct, though we should throw an exception too.
2531 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2533 Fix a addDocuemnt typo.
2535 * src/main/java/org/glom/web/shared/Documents.java
2536 (Documents.addDocuemnt): Rename to addDocument().
2537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2538 (OnlineGlomServiceImpl.getDocuments): Adapt.
2540 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2542 Slightly improved log output when connection fails.
2544 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2545 (ConfiguredDocument.setUsernameAndPassword):
2546 We don't know for sure if it' the username/password that's wrong, so
2547 rephrase the message.
2548 Also ouput the exception message, though it's generic in this case.
2550 2011-07-08 Ben Konrath <ben@bagu.org>
2554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2555 added braces to a one line if statement because the Eclipse formatter
2556 was getting confused.
2558 2011-07-07 Ben Konrath <ben@bagu.org>
2560 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2562 These should really be two separate tasks but I counldn't get things to
2563 work with GWT 2.2.0 and Eclipse 3.7.
2567 * .settings/org.eclipse.jdt.core.prefs:
2568 * .settings/org.eclipse.jdt.ui.prefs:
2569 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2570 * .settings/org.eclipse.m2e.core.prefs:
2571 Add new config files. Update current files. Remove references to the
2572 webtools plugins as we're not using any of the webtools features.
2573 * .gitignore: Add logs directory which is created when running with
2575 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2576 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2577 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2579 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2581 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2583 onlineglom.properties: Add explanatory comments.
2585 * src/main/resources/onlineglom.properties: Also change the default user
2586 from ben to someuser, to avoid the risk of people thinking we just
2587 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2589 2011-06-28 Ben Konrath <ben@bagu.org>
2591 Use filename in Log for incorrect passwords.
2593 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2594 getFileName(String) method to get the filename from the URI.
2596 2011-06-28 Ben Konrath <ben@bagu.org>
2598 Add the table name to the URL token for the ListPlace.
2600 This makes things consistent between the DetailsPlace and the
2601 ListPlace. It also allows the the ListPlace to be bookmarked.
2603 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2604 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2605 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2606 Remove getDefaultListLayout(). The default layout is now returned
2607 by the getListLayout() method when the table name is an empty string.
2608 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2609 Add table name field. Change to a new ListPlace when the table
2610 has been changed. Use getListLayout() for getting the default
2612 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2613 Add table name field. Set the correct table name in the list box
2614 when loading from bookmark. This corrects a problem for the
2616 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2617 Move table name to super-class (HasSelectableTable). Move document
2618 and table URL keys to super-class in HasSelectableTable.
2619 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2620 Add table name field. Add Tokenizer class with URL key common to
2621 the subclasses (DetailsPlace and ListPlace).
2622 * src/main/java/org/glom/web/client/place/ListPlace.java:
2623 Add table name. Add code to parse the URL token.
2624 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2625 Update ListPlace construction with empty table name string.
2626 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2627 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2628 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2629 Update ListPlace construction with table name string.
2630 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2631 Change defaultTableName field to tableName to reflect how it's now
2632 used. Update the getter and setter methods.
2634 2011-06-28 Ben Konrath <ben@bagu.org>
2636 Enable the table selector in the DetailsView.
2638 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2639 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2641 Remove getDefaultDetailsLayout(). The default layout is now returned
2642 by the getDetailsLayout() method when the table name is an empty
2644 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2645 event handler for table change event. Change to using
2646 getDetailsLayout() for the default details layout.
2647 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2649 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2650 when navigating to the details place.
2652 2011-06-27 Ben Konrath <ben@bagu.org>
2654 Use filename based unique document ID in URL and for RPC.
2656 The document ID is the glom document name with spaces (' ') replaced
2657 with pluses ('+') and without the .glom extension.
2659 This change is mostly a string substitution of 'documentTitle' for
2660 'documentID'. The only code change is the addition of a Documents DTO to get the
2661 filename to document title mappings as indicated below.
2663 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2664 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2665 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2666 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2667 Use Documents DTO to create the document links in the document
2669 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2670 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2671 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2672 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2673 * src/main/java/org/glom/web/client/place/ListPlace.java:
2674 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2675 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2676 * src/main/java/org/glom/web/client/ui/ListView.java:
2677 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2678 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2679 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2680 * src/main/java/org/glom/web/server/Log.java:
2681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2682 getDocumentTitles() to getDocuments() and return the Documents DTO.
2683 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2684 transferring the filename to document title mappings.
2686 2011-06-25 Ben Konrath <ben@bagu.org>
2688 Make the authentication popup work again.
2690 This bug was introduced when I extracted ConfiguredDocument to its own class.
2692 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2693 correct success / fail status in setUsernameAndPassword().
2695 2011-06-25 Ben Konrath <ben@bagu.org>
2697 Use filename as unique key for configuring database usernames and passwords.
2699 This replaces the use of the Glom document title which could change
2700 depending on the locale. Thanks to Murray Cumming for pointing out this
2703 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2704 * src/main/resources/onlineglom.properties:
2706 2011-06-24 Ben Konrath <ben@bagu.org>
2708 Pass primary key value to DetailsView.
2710 This enables the DetailsView to load the correct data.
2712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2713 primary key value field and set in constructor. Pass primary key
2714 value to getDetailsData().
2715 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2716 variables for document title and primary key value.
2717 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2718 key value to the DetailsPlace.
2720 2011-06-24 Ben Konrath <ben@bagu.org>
2722 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2724 This allows the primary key to be retrieved by the Details button. This
2725 functionality has not been implemented yet but it's in the works.
2727 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2728 the LayoutGroup result to ListView.setCellTable instead of all of its
2729 fields individually.
2730 * src/main/java/org/glom/web/client/ui/ListView.java:
2731 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2732 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2733 get the primary key for the table.
2734 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2735 index of the primary key in the LayoutGroup accounting for hidden
2736 primary keys. Rename getJavaNumberFormat() to
2737 convertToJavaNumberFormat() for consistency. Cleanup / add some
2739 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2740 field for primary key index and a field to indicate whether the
2741 primary key is hidden or not.
2743 2011-06-23 Ben Konrath <ben@bagu.org>
2745 Rename getTableData methods to getListData.
2747 This is a rename refactor for consistency with other methods.
2749 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2750 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2751 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2754 2011-06-23 Ben Konrath <ben@bagu.org>
2756 Extract the ConfiguredDocument innerclass into its own class.
2758 This makes the servlet code more object oriented.
2760 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2761 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2763 new ConfiguredDocument class.
2765 2011-06-21 Ben Konrath <ben@bagu.org>
2767 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2769 This makes things more inline with how libglom works and reduces code
2770 duplication. This refactor lays the groundwork for adding the primary key to
2771 the LayoutGroup object.
2773 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2774 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2776 Change method names to getListLayout and getDefaultListLayout for
2777 consistency. Use LayoutGroup as the DTO for the list layout instead of
2778 ColumnInfo and LayoutListTable.
2779 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2780 new method names along with the LayoutGroup object for transferring the
2782 * src/main/java/org/glom/web/client/ui/ListView.java:
2783 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2784 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2785 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2787 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2788 Replaced with LayoutGroup.
2789 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2790 expectedResultSize and defaultTableName fields which are needed for
2792 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2793 type field which is needed for the list layout but will also be
2794 useful for the details layout as things progress.
2795 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2796 Make class abstract. Remove the unnecessary
2797 getFormattingHorizontalAlignment method. Add setFormatting method.
2799 2011-06-16 Ben Konrath <ben@bagu.org>
2801 Add scripts for building and installing war.
2803 These will help when updating OnlineGlom but they're also good
2804 supplemental documentation of the build and deployment proceeding.
2806 * utils/build-onlineglom-war.sh: New file.
2807 * utils/install-onlineglom-war.sh: New file.
2809 2011-06-16 Ben Konrath <ben@bagu.org>
2811 Create wrapper class to create consistent log messages.
2813 I wrapped methods in the Log class of gwt-log to add the method names
2814 from the servlet and create consistent formatting of the document title
2815 and table names in the log messages.
2817 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2819 log methods to use methods from wrapped Log class.
2821 2011-06-16 Ben Konrath <ben@bagu.org>
2823 Remove superfluous conditional return.
2825 Thanks to Murray Cumming for pointing this out!
2827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2829 2011-06-15 Ben Konrath <ben@bagu.org>
2831 Return an ArrayList of LayoutGroups for the Details layout.
2833 This corrects a problem with the details layout as it can have more
2834 than one top level LayoutGroup.
2836 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2837 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2838 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2839 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2840 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2841 with ArrayList of LayoutGroups for the details view layout.
2842 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2843 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2844 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2845 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2846 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2847 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2849 2011-06-14 Ben Konrath <ben@bagu.org>
2851 Use cast_dynamic method to determine the libglom LayoutItem type.
2853 This is better than finding the LayoutItem type by using the string
2854 returned from the get_part_type_name() method.
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2858 2011-06-14 Ben Konrath <ben@bagu.org>
2860 Add method names to log entries in the servlet.
2862 This helps when tracking down deployment problems.
2864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2866 2011-06-14 Ben Konrath <ben@bagu.org>
2868 Add data to the DetailsView using a hard-coded primary key value.
2870 The layout and functionality of the DetailsView is not complete. This
2871 is just a checkpoint so the patch doesn't get too big.
2873 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2874 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2875 Add getDetailsData() servlet method.
2876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2877 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2878 LayoutFields are added to the DetailsView.
2879 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2880 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2881 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2882 take the string for the title instead of the object.
2883 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2884 Add implementation getDetailsData() along with some private helper
2886 * src/main/webapp/style.css: Add padding to details-data class. Add a
2887 details-label class with the same padding as the details-data class.
2889 2011-06-03 Ben Konrath <ben@bagu.org>
2891 Use presenter.goTo() to change to the DetailsPlace.
2893 This will make things easier when we need to open the DetailsView with
2894 data specific to the row that was clicked.
2896 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2898 2011-06-02 Ben Konrath <ben@bagu.org>
2900 Add CSS file from mockups.
2902 I'm adding this now because it's going to be useful to have when
2903 developing the DetailsView. The TableSelectionView and ListView aren't
2906 * src/main/webapp/OnlineGlom.html:
2907 * src/main/webapp/style.css:
2909 2011-06-02 Ben Konrath <ben@bagu.org>
2911 Use String.isEmpty() to check for empty string.
2913 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2915 2011-06-02 Ben Konrath <ben@bagu.org>
2917 Display main layout group titles in the DetailsView.
2919 This is the start of the DetailsActivity/DetailsView implementation.
2921 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2922 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2923 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2925 Get the layout information for the details view from the server and set
2926 the main layout group titles.
2927 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2928 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2929 Add addLayoutGroup() and addLayoutField() methods. This are just
2930 temporary methods for creating the the details view that will change
2932 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2933 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2935 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2936 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2937 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2938 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2939 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2940 Data Transfer Objects that mimic the libglom object structure. These are
2941 used for transferring the details layout but could also be used for
2942 transferring the list layout.
2944 2011-05-27 Ben Konrath <ben@bagu.org>
2946 Reset the AuthenticationPopup when clearing the ListView.
2948 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2950 2011-05-27 Ben Konrath <ben@bagu.org>
2952 Fix problem with onlineglom.properties file loading.
2954 The old way worked in Eclipse but not on the server. Loading the
2955 onlineglom.properties file now works in Eclipse and on the server.
2957 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2959 2011-05-24 Ben Konrath <ben@bagu.org>
2961 Update gwt-log from 3.1.0 to 3.1.2.
2963 Gwt-log 3.1.0 has been marked as depreciated.
2967 2011-05-24 Ben Konrath <ben@bagu.org>
2969 Add comment to ListActivity.goTo() method.
2971 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2973 2011-05-24 Ben Konrath <ben@bagu.org>
2975 Remove FIXME in convertGdkColorToHtmlColour()
2977 The Gdk::Color value returned by libglom is 16-bits per channel on both
2978 64 and 32-bit platforms.
2980 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2982 2011-05-19 Ben Konrath <ben@bagu.org>
2984 Improve performance of initial ListView load.
2986 I removed a round trip to the server for getting the default table name
2987 and then requesting information about that table. This also removes a potential
2988 problem with the table change handler not being setup in time to receive the
2989 table change event from the ListActivity.
2991 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2992 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2993 getDefaultLayoutListTable() method. Improve comments.
2994 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2995 getDefaultLayoutListTable() method instead of firing a table change
2996 event to get the table to load.
2997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2998 implementation of getDefaultLayoutListTable() method.
2999 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3002 2011-05-19 Ben Konrath <ben@bagu.org>
3004 Override toDebugString() in TableChangeEvent.
3006 This is useful to have for debugging.
3008 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3010 2011-05-19 Ben Konrath <ben@bagu.org>
3012 Add a "Back to List" link when at the DetailsPlace.
3014 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3015 Populate the CellTable based on the selected table of the ListBox if
3016 it's set otherwise use the default table. This allows the "Back to
3018 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3019 Remove Place from constructors. Add a setPlace() method. Add
3020 goToPlace() method. Set class as presenter for TableSelectionView.
3021 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3022 Use the same TableSelectionActivity when switching between the List and
3024 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3025 Subclass the new HasSelectableTablePlace. This removes some duplicate
3027 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3028 New class to represent Places that display the TableSelectionView.
3029 * src/main/java/org/glom/web/client/place/ListPlace.java:
3030 Subclass the new HasSelectableTablePlace. This removes some duplicate
3032 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3033 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3034 Add Presenter interface. Add setBackLinkVisible() method. Add
3035 setBackLink() method.
3037 2011-05-18 Ben Konrath <ben@bagu.org>
3039 Enable the "Details" buttons.
3041 Right now only an empty details view is displayed.
3043 * src/main/java/org/glom/web/client/ClientFactory.java:
3044 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3045 Add DetailsView to ClientFactory.
3046 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3047 A basic activity for the details view.
3048 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3049 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3051 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3052 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3054 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3055 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3056 unnecessary super() in constructor.
3057 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3058 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3059 really shouldn't create a new TableSelectionActivity for both the ListPlace
3060 and the DetailsPlace so this should be considered a temporary solution.
3061 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3062 New file. Represents a URL for the details view.
3063 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3064 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3065 A basic details view interface and implementation.
3066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3067 Enable the "Details" buttons.
3069 2011-05-12 Ben Konrath <ben@bagu.org>
3071 Use a LayoutPanel with multiple display areas for main layout.
3073 This is mostly a refactor in that there are no changes from the user
3074 point of view. These changes are required so that we can swap out the list view
3075 with the details view when the user clicks the "Details" button.
3077 * src/main/java/org/glom/web/client/ClientFactory.java:
3078 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3079 OnlineGlomView. Add TableSelectionView, ListView and
3080 AuthenticationPopup.
3081 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3082 for main layout. Add display regions for main activities. Add
3083 activity manager for for main activities.
3084 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3085 file from parts of the deleted OnlineGlomActivity.
3086 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3087 New file from parts of the deleted OnlineGlomActivity.
3088 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3089 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3090 New files for app wide table change event.
3091 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3092 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3093 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3094 Activity mappers for the main activities replace the deleted app-wide
3096 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3097 Fix a spelling error in he comment.
3098 * src/main/java/org/glom/web/client/ui/ListView.java:
3099 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3100 Renamed from LayoutListView and modified for MVP. This still not a
3101 proper dumb view as prescribed by the MVP pattern but it works for now.
3102 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3103 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3104 New widget stripped out of the deleted OnlineGlomView.
3105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3106 Remove hack that is fixed by this patch.
3108 2011-05-06 Ben Konrath <ben@bagu.org>
3110 Rename OnlineGlomPlace to ListPlace.
3112 The only change besides the rename is that url will now display #list
3113 instead of #Document.
3115 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3116 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3117 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3118 * src/main/java/org/glom/web/client/place/ListPlace.java:
3119 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3121 2011-05-06 Ben Konrath <ben@bagu.org>
3123 Use Presenter for app navigation.
3125 This is the proper way to deal with Place (URL) changes with the MVP
3128 * src/main/java/org/glom/web/client/ClientFactory.java:
3129 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3130 PlaceHistoryMapper and PlaceHistoryHandler.
3131 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3132 PlaceHistoryMapper and PlaceHistoryHandler.
3133 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3134 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3135 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3136 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3137 Add Presenter interface and setPresenter methods. Rename addHyperLink
3138 to addDocumentLink taking only the document title as a parameter.
3140 2011-04-14 Ben Konrath <ben@bagu.org>
3142 Prompt for db username/password if they haven't been set.
3144 This is implemented with a popup widget that is contained within the
3145 OnlineGlomView and managed by the OnlineGlomActivity.
3147 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3148 methods for checking and setting the database username and password.
3149 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3150 new methods for checking and setting the database username and
3152 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3153 Display authentication popup if the JDBC connection to the database
3154 has not been authenticated.
3155 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3157 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3158 for dealing with the authentication popup.
3159 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3160 Implement the methods for dealing with the authentication popup.
3161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3162 try to executed queries if the database connection hasn't been
3163 authenticated. Implement methods for checking and setting the
3164 database username and password.
3166 2011-04-12 Ben Konrath <ben@bagu.org>
3168 Make log messages a little clearer.
3170 Add a dash betweeen the document title and the table name.
3172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3174 2011-04-12 Ben Konrath <ben@bagu.org>
3176 Protect against NPEs when cleaning up database resources.
3178 While this isn't strictly necessary because the exception is caught,
3179 not protecting against the NPEs makes it harder to find the real error
3182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3184 2011-04-12 Ben Konrath <ben@bagu.org>
3186 Move configuration of the servlet to the constructor.
3188 The servlet will be initialized even if the database authentication
3189 information is not set or correct. I still need to add the UI for prompting
3190 the user for the authentication information when it's required.
3192 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3193 javadocs for getDocumentTitles() method.
3194 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3195 Set error message when RPC fails.
3196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3197 glom files directory from the configuration file. Try to set the
3198 database authentication information for the specific document if it's
3199 set and works otherwise try to use the global authentication
3200 information set for the directory.
3201 * src/main/resources/onlineglom.properties: Moved from
3202 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3203 Added detailed comments for the new keys.
3205 2011-04-11 Ben Konrath <ben@bagu.org>
3207 Remove unnecessary @Override in DocumentSelectionViewImpl.
3209 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3211 2011-04-11 Ben Konrath <ben@bagu.org>
3213 Remove center alignment in DocumentSelectionView.
3215 The title element is still centred but the document titles and bottom
3216 sentence are both left-aligned.
3218 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3220 2011-04-11 Ben Konrath <ben@bagu.org>
3222 Change 'Demo' naming convention to 'Document'.
3224 This is just a rename refactor with no functional changes to the code.
3226 * src/main/java/org/glom/web/client/ClientFactory.java:
3227 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3228 * src/main/java/org/glom/web/client/OnlineGlom.java:
3229 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3230 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3231 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3232 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3233 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java: