1 2012-03-05 Murray Cumming <murrayc@murrayc.com>
3 Require the latest java-libglom.
5 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
7 2012-03-05 Murray Cumming <murrayc@murrayc.com>
9 Reports: Implement grouping.
11 * src/main/java/org/glom/web/server/ReportGenerator.java:
12 Handle LayoutItem_GroupBy items and try to do the right thing
13 with JRDesignGroup. It seems to work.
15 2012-03-04 Murray Cumming <murrayc@murrayc.com>
17 Actually show some data with JasperReports.
19 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
20 getReportHTML(): Move most code into a ReportGenerator class.
21 * src/main/java/org/glom/web/server/ReportGenerator.java:
22 Recurse into sub-groups, adding fields to the JasperDesign's details
23 band. Note that we must set an arbitrary width and height, or it just
24 will not show any data.
26 2012-03-04 Murray Cumming <murrayc@murrayc.com>
28 Reports Chooser: Show the titles, not the names.
30 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
31 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
32 and the names as the values.
33 * src/main/java/org/glom/web/server/ConfiguredDocument.java
34 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
35 group now that we provide the report name, so it should always
38 2012-03-04 Murray Cumming <murrayc@murrayc.com>
40 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
42 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
43 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
44 an empty quickfind string. I also corrected libglom to create only
45 empty where clauses for empty quickfind strings, but this avoids the
48 2012-02-24 Ben Konrath <ben@bagu.org>
50 Improve the tabs in the Notebook widget.
54 2012-02-15 Murray Cumming <murrayc@murrayc.com>
56 Depend on jasperreports.
58 * pom.xml: Add the dependency. My plan is to use this on the
61 2012-01-31 Murray Cumming <murrayc@murrayc.com>
63 Implement navigation to report places.
65 * src/main/java/org/glom/web/client/activity/ReportActivity.java
66 start(): Do not bother to handle all events here.
67 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
68 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
69 Added getSelectedReport().
70 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
71 .java: start(): When handling a change to the reports chooser,
72 call getSelectedReport() and goTo() its ReportPlace.
73 * src/main/java/org/glom/web/client/ui/ReportView.java
74 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
75 Added setReportHTML() which puts the html in a gwt HTML widget.
76 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
77 getReportHTML(): Return "TODO" just to show that this works.
79 2012-01-31 Murray Cumming <murrayc@murrayc.com>
81 Make ReportPlace usable.
83 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
85 * src/main/java/org/glom/web/client/place/ReportPlace.java:
86 Correct the @prefix annotation.
88 2012-01-31 Murray Cumming <murrayc@murrayc.com>
90 OnlineGlomService: Return report HTML rather than the LayoutGroup.
92 * src/main/java/org/glom/web/client/OnlineGlomService.java:
93 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
94 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
95 Change getReportLayout() to getReportHMTL() because we will not need to
96 parse or render the report layout on the client side.
97 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
98 getReportLayout(): Return the libglom LayoutGroup type because we will
99 not need to convert to a shared type, because this will not be used on
101 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
104 Note that there is still no implementation for this.
106 2012-01-30 Murray Cumming <murrayc@murrayc.com>
108 Translations: Try to translate the strings.
110 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
111 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
112 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
113 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
114 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
115 Take the Open translation from GTK+'s .po files.
116 Take the Details translation from Glom's po files.
117 I have added the other strings to Glom so we can get translations that way:
118 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
120 2012-01-27 Murray Cumming <murrayc@murrayc.com>
122 Add a (empty) Report Place, View, and Activity.
124 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
126 * src/main/java/org/glom/web/client/place/HasTablePlace.java
127 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
128 this into a superclass:
129 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
130 and also use it as the base of this new ReportPlace:
131 * src/main/java/org/glom/web/client/place/ReportPlace.java
133 * src/main/java/org/glom/web/client/ui/ReportView.java
134 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
135 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
136 Add these, containing mostly boiler-plate for now.
138 * src/main/java/org/glom/web/client/OnlineGlomService.java
139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
140 * src/main/java/org/glom/web/server/ConfiguredDocument.java
141 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
142 Add API to get the LayoutGroup for the report.
144 2012-01-27 Murray Cumming <murrayc@murrayc.com>
146 TableSelectionViewImpl: Put the search label and entry in a div.
148 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
149 Put the search widgets in a FlowTable so that the CSS can be used to
150 style them while keeping them together.
151 * src/main/webapp/style.css: Mention the new div.
153 2012-01-27 Murray Cumming <murrayc@murrayc.com>
155 Translate more strings in more locales.
157 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
158 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
159 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
160 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
161 Translate the "Details" and "Open" string too.
163 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
164 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
165 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
166 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
167 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
168 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
169 Add these new locales as placeholders though they currently contain English.
171 2012-01-27 Murray Cumming <murrayc@murrayc.com>
173 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
176 Check the ConfiguredDocument* for null before using it.
178 2012-01-26 Murray Cumming <murrayc@murrayc.com>
180 Tell Eclipse about the generated java files.
182 * .classpath: This lets it find OnlineGlomConstants.java.
183 It would be nice if Eclipse just used the maven build files.
185 2012-01-26 Murray Cumming <murrayc@murrayc.com>
187 Prevent a crash when no locale is specified in the URL.
189 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
190 Avoid returning a null string, obtained from
191 Window.Location.getParameter(). This caused a crash when it was
192 later passed to libglom's API.
193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
194 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
195 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
196 guard against future null strings.
198 2012-01-26 Murray Cumming <murrayc@murrayc.com>
200 Use the ?locale= query param instead of the &lang= token param.
202 * src/main/java/org/glom/web/client/place/ListPlace.java
203 * src/main/java/org/glom/web/client/place/DetailsPlace.java
204 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
205 Remove the lang token key and value.
207 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
208 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
209 When the user selects a different locale from the chooser, use
210 Window.Location.assign() to change the URL, which then causes a reload.
212 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
214 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
215 * src/main/java/org/glom/web/client/activity/ListActivity.java
216 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
217 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
218 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
219 * src/main/java/org/glom/web/client/ui/ListView.java:
220 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
222 Remove localeID member variables and method/constructor parameters, instead
223 using Utils.getCurrentLocaleID() when we need a localID to pass to
226 2012-01-26 Murray Cumming <murrayc@murrayc.com>
228 Internationalize the UI strings.
230 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
231 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
232 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
233 because it is unused. Messages are apparently strings that can have
234 parameters, but we do not need that yet, so Contants will be enough for now.
235 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
236 to say that we support the en and de locales.
237 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
238 The original English strings.
239 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
240 Some German translations of the English strings.
241 The i18n goal then uses the .properties file to generate an
242 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
243 returns an implementation that returns the translated strings.
244 The documentation suggests putting these in src/java/*/client/, but it seems
245 best to put it in src/resources/*/client/.
246 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
247 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
248 instead of hard-coding them.
249 Note that we cannot import OnlineGlomConstants because it does not exist yet,
250 but that does not seem to stop the build, though it confuses Eclipse.
252 You can see the translated string by adding ?locale=de to the URL, like so:
253 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
255 2012-01-24 Murray Cumming <murrayc@murrayc.com>
257 Improve null/empty String checks.
259 * pom.xml: Add a dependency on commons-lang, to use
260 org.apache.commons.lang.StringUtils.
261 * src/main/java/org/glom/web/server/ConfiguredDocument.java
262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
263 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
264 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
265 Use StringUtils.isEmpty().
267 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
268 StringUtils class with a static isEmpty() function because we
269 cannot use org.apache.commons.lang.StringUtils in client-side
270 GWT code because it (apparently) cannot be compiled to javascript.
271 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
272 * src/main/java/org/glom/web/client/activity/ListActivity.java
273 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
274 * src/main/java/org/glom/web/client/place/DetailsPlace.java
275 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
276 * src/main/java/org/glom/web/client/place/ListPlace.java
277 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
278 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
279 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
280 * src/main/java/org/glom/web/client/ui/details/Group.java
281 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
282 our StringUtils.isEmpty() function.
284 2012-01-24 Murray Cumming <murrayc@murrayc.com>
286 Update to the latest java-libglom API.
288 * pom.xml: Require java-libglom 1.21.4.
289 * src/main/java/org/glom/web/server/ConfiguredDocument.java
290 getDocumentInfo(), getListViewLayoutGroup():
291 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
293 * src/main/java/org/glom/web/server/database/DBAccess.java
294 getFieldsToShowForSQLQueryAddGroup(),
295 getPrimaryKeyLayoutItemField(): Replace get_database_title()
296 with either get_database_title_original() or
297 get_database_title(localeID).
299 2012-01-24 Murray Cumming <murrayc@murrayc.com>
301 ConfiguredDocument: Avoid a null pointer exception.
303 * src/main/java/org/glom/web/server/ConfiguredDocument.java
304 Initialize localeID to "" to avoid returning a null String which
305 causes a crash in java-libglom's swing-generated code.
307 2012-01-23 Murray Cumming <murrayc@murrayc.com>
309 Some simple renaming.
311 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
312 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
313 for localeChooser. This seems more appropriate and is less ambiguous
314 particularly in the .css file.
316 2012-01-23 Murray Cumming <murrayc@murrayc.com>
318 ConfiguredDocument: Rename the localedID private member variable.
320 2012-01-23 Murray Cumming <murrayc@murrayc.com>
322 Adapt to the latest java-libglom API from git master.
324 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
325 libglom now uses only Vector instead of List, which uses add() instead of
328 2012-01-23 Murray Cumming <murrayc@murrayc.com>
330 Add and fill a Reports drop-down list box.
332 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
334 * src/main/java/org/glom/web/client/OnlineGlomService.java:
335 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
337 Added getReports(document, table, localeID), calling
338 ConfiguredDocument.getReports().
339 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
340 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
341 Added setReportsList() and a list widget.
342 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
343 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
345 2012-01-22 Murray Cumming <murrayc@murrayc.com>
347 ConfiguredDocument: Rename the localedID private member variable.
349 2012-01-20 Murray Cumming <murrayc@murrayc.com>
351 Build a source tarball with mvn assembly:single
353 * assembly.xml: Add this file.
354 * pom.xml: Use the maven-assembly-plugin and tell it to use
355 our assembly.xml file.
357 2012-01-19 Murray Cumming <murrayc@murrayc.com>
359 OnlineGlomServiceImpl: Get .glom files recursively.
361 * pom.xml: Depend on commons-io from org.apache.commons.
362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
363 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
364 files recursively, and with the easier filter for the extension.
365 Use org.apache.commons.io.FilenameUtils.removeExtension() to
366 simplify that code too.
368 2012-01-19 Murray Cumming <murrayc@murrayc.com>
370 README: Mention that you must install java-libglom packages separately.
372 But then it works, because java-libglom is now in the central maven
375 2012-01-18 Murray Cumming <murrayc@murrayc.com>
377 locales drop-down: Show the correct selected locale when the URL changes.
379 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
380 .java: setPlace(): Move some code into fillView().
382 2012-01-18 Murray Cumming <murrayc@murrayc.com>
384 locales drop-down: Do not lose the primary key.
386 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
387 start(): onLocaleChange(): Pass the current primary key value,
388 instead of an empty value.
390 2012-01-18 Murray Cumming <murrayc@murrayc.com>
392 locales drop-down: Do not lose the drop-down selection.
394 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
395 .java (TableSelectionActivity.fillView): Set the selected locale
396 after changing the drop-down items (though we do not really need
397 to change them just because the locale changes.)
399 2012-01-18 Murray Cumming <murrayc@murrayc.com>
401 locales drop-down: Change the tables list when this changes.
403 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
404 .java: TableSelectionActivity.start(): Move the async table titles
405 retrieval into a private fillView() method and also call this when
406 the chosen locale changes.
407 Note that the document title is not actually translatable yet, but
408 that is a problem that I should fix soon in libglom.
410 2012-01-18 Murray Cumming <murrayc@murrayc.com>
412 Improve the placement of the locales drop-down.
414 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
415 Put the title and locales drop-down in a div (gwt.FlowTable).
416 * src/main/webapp/style.css: Add magic css properties to make this work.
417 Also remove the left margin from the title so that it lines up with the
420 2012-01-18 Murray Cumming <murrayc@murrayc.com>
422 locales selector: Show human-readable locale titles.
424 * src/main/java/org/glom/web/server/ConfiguredDocument.java
425 getDocumentInfo(): Use java.util.Locale to show a real title of
426 each locale, in the locale's own language.
428 2012-01-17 Murray Cumming <murrayc@murrayc.com>
430 Add a language/locale selector drop-down.
432 * src/main/java/org/glom/web/shared/DocumentInfo.java:
433 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
434 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
435 getDocumentInfo(): Store the available Locales in the DocumentInfo.
436 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
437 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
438 Add a ListBox to show the available locales. Add getLocaleSelector(),
439 setLocaleList(), getSelectedLocale(), setSelectedLocale().
440 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
441 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
442 java: Add these classes.
443 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
444 start(): Fill the locales ListBox. Handle its change event, firing a
446 setPlace(): Show the selected locale as specified by the URL token.
447 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
448 * src/main/java/org/glom/web/client/activity/ListActivity.java:
449 Handle LocaleChangeEvent, going to a new *Place with that locale.
451 The placement of the ListBox is not pretty, and it currently uses the ID
452 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
456 2012-01-17 Murray Cumming <murrayc@murrayc.com>
458 Search box: Show the search text from the URL token.
460 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
462 Add setQuickFindText().
463 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
464 .java: setPlace(): Store the queryText if the place is a ListPlace,
465 and call TableSelectionView.setQuickFindText().
467 2012-01-17 Murray Cumming <murrayc@murrayc.com>
469 Allow use of translations via, for instance, &lang=de in the URL.
471 * pom.xml: Use the unstable java-libglom 1.21 version.
473 * src/main/java/org/glom/web/client/OnlineGlomService.java:
474 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
475 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
476 init(): Instead of calling TranslatableItem.set_current_locale()
477 (now removed), call ConfiguredDocument.setDefaultLocaleID().
478 However, this is only for default locales, which are not needed to
479 change the locale in the URL.
480 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
481 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
482 getSortedRelatedListData(): Add a localeID parameter, so we can get the
483 layout for a particular locale.
484 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
485 Add get/setDefaultLocaleID().
486 getDocumentInfo(), getListViewData(), getRelatedListData(),
487 getDetailsLayoutGroup(), getListViewLayoutGroup(),
488 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
489 localeID parameter, so we can get the layout for a particular locale.
491 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
492 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
493 * src/main/java/org/glom/web/client/place/ListPlace.java:
494 Parse and construct a lang parameter too.
496 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
497 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
498 passed to subsequent methods and constructors.
499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
500 * src/main/java/org/glom/web/client/activity/ListActivity.java:
501 Store the localeID from the *Place and pass it to other constructors
502 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
504 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
505 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
506 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
507 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
508 * src/main/java/org/glom/web/client/ui/ListView.java:
509 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
510 Take localeID parameters and pass them to subsequent constructors and
511 methods, so that the layout is always retrieved for that locale.
513 This is rather repetitive.
515 Note that "" means the original (default) locale of the Glom document,
516 which is usually English.
518 2012-01-17 Murray Cumming <murrayc@murrayc.com>
520 Documents: Remove final keyword to fix startup configuration.
522 * src/main/java/org/glom/web/shared/Documents.java: Remove the
523 final keywords on the private member variables because that breaks
524 the startup, apparently (there are warnings) because it stops them
525 from being serialized. I added these in the previous commit.
527 2012-01-13 Murray Cumming <murrayc@murrayc.com>
529 Documents: Add some final keywords.
531 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
534 2012-01-13 Murray Cumming <murrayc@murrayc.com>
536 OnlineGlomServiceImpl: Add to overview comments.
538 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
539 Note that this is where all the document are loaded. They are not
540 loaded freshly for each page.
542 2012-01-12 Murray Cumming <murrayc@murrayc.com>
546 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
547 Add a TextBox for the text of a quick find.
548 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
550 setBackLink(): Add a String quickFind parameter.
551 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
552 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
553 to the base interface, because that is how TableSelectionViewImpl is used.
554 * src/main/webapp/style.css: Add style for the search box and its label.
556 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
557 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
558 Add these files, based on the existing TableChangeEvent and
559 TableChangeEventHandlers.
560 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
561 start(): Handle QuickFindChangeEvent, passing its quickFind text to
562 a ListPlace() that the user should be taken to.
563 * src/main/java/org/glom/web/client/activity/ListActivity.java
564 start(): Handle it here too and adapt the TableChangeEvent handler to
565 pass the extra "" quickFind parameter to ListPlace.
566 * src/main/java/org/glom/web/client/place/ListPlace.java:
567 Constructor: Take an extra String quickFind parameter and store it,
568 returning it from a new getQuickFind() method.
569 getToken(): Put the quickFind text in the URL token.
570 getPlace(): Parse the quickFind text from the URL token.
571 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
572 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
573 ListPlace constructor.
574 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
575 .java: start(): Add a Change handler for the TableSelectionView's
576 TextBox (via its base HasChangeHandlers interface), firing the new
577 QuickFindChangeEvent.
578 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
579 pass the extra "" quickFind parameter.
581 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
582 setCellTable(): Add a String quickFind parameter and pass it to
583 the ListViewTable() constructor.
584 * src/main/java/org/glom/web/client/ui/ListView.java: Change
585 setCellTable() in the base interface, because that is how ListViewImpl
588 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
589 Add a String quickFind member variable.
590 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
591 Constructor: Add a String quickFind parameter, storing it in the
592 base ListTable's member variable.
593 onRangeChanged(): Pass quickFind to the
594 OnlineGlomServiceAsync.getSortedListViewData() and
595 OnlineGlomServiceAsync.getListViewData() methods.
597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
598 getListViewData(), getSortedListViewData(): Add a String quickFind
599 parameter, passing it to ConfiguredDocument.getListViewData().
600 * src/main/java/org/glom/web/client/OnlineGlomService.java:
601 Change getListViewData(), getSortedListViewData() in the base interface,
602 because that is how OnlineGlomServiceImpl is used, via this:
603 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
604 Change getListViewData(), getSortedListViewData() here too.
605 This class can apparently be used to asynchronously call methods on
606 OnlineGlomService, and GWT seems to implement that after recognizing
607 just the *Async name convention and the extra AsyncCallback parameters.
609 * src/main/java/org/glom/web/server/ConfiguredDocument.java
610 getListViewData(): Add a String quickFind parameter, and pass it to
611 ListViewDBAccess.getData().
612 * src/main/java/org/glom/web/server/database/ListDBAccess.java
613 getListData(): Add a String quickFind parameter and pass it to
615 getSelectQuery(): Add a String quickFind parameter.
616 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
617 getSelectQuery(): Add a String quickFind parameter and use it with
618 Glom.get_find_where_clause_quick() to pass a where_clause to
619 Glom.build_sql_select_with_where_clause(), to actually filter the
621 getData(): Add a String quickFind parameter, passing it to getListData().
622 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
623 va: getData(): Pass an empty string to getListData() for the
626 2012-01-12 Murray Cumming <murrayc@murrayc.com>
628 ListTable: Minor change.
630 * src/main/java/org/glom/web/client/ui/list/ListTable.java
631 createCellTable(): Make this protected instead of public.
633 2012-01-12 Murray Cumming <murrayc@murrayc.com>
635 Many files: Use final for the parameters and use the @override attribute.
637 2012-01-22 Ben Konrath <ben@bagu.org>
639 Add anchor links for single line text that starts with http, ftp and www.
643 2012-01-22 Ben Konrath <ben@bagu.org>
645 Add ellipsis to single line text in details view.
649 2012-01-04 Murray Cumming <murrayc@murrayc.com>
651 Remove all javadoc author tags.
653 Because they are awkward and meaningless when many people touch
655 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
657 2012-01-04 Murray Cumming <murrayc@murrayc.com>
659 Revert the COPYING.LESSER to COPYING rename.
661 Apparently both should be there if it is LGPL.
663 2012-01-03 Murray Cumming <murrayc@murrayc.com>
665 *View: Remove unused imports.
667 * src/main/java/org/glom/web/client/ui/DetailsView.java:
668 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
669 * src/main/java/org/glom/web/client/ui/ListView.java:
670 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
671 Remove unused imports, as suggested by Eclipse.
673 2012-01-02 Murray Cumming <murrayc@murrayc.com>
675 Move the *View::Presenter types, and some API into one base View.
677 * src/main/java/org/glom/web/client/ui/DetailsView.java:
678 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
679 * src/main/java/org/glom/web/client/ui/ListView.java:
680 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
681 Presenter, setPresenter() and clear() into a shared base interface,
682 to avoid the unnecessary duplicate Presenter types and to more clearly
683 show how the *Views share the same structure, even if they are not
684 used polymorphically.
686 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
687 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
690 * src/main/java/org/glom/web/client/activity/ListActivity.java:
691 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
693 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
696 Feel free to revert this if there is a good reason for the duplicate
699 2012-01-02 Murray Cumming <murrayc@murrayc.com>
701 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
703 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
704 a class member instead of a local variable in the method.
705 This lets us use it to get the view instances, for use in tests.
706 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
707 beforeOnlineGlom(): Test some more details of the initial view.
708 Again, this is not very useful.
710 To really test gwt-glom we will need to start a local postgresql
711 instance with local data, like the Glom tests in C++.
713 2012-01-02 Murray Cumming <murrayc@murrayc.com>
715 pom.xml: Mention the LGPL license.
717 * pom.xml: Add a licenses section.
718 * COPYING.LESSER: Move this to COPYING, which
719 previously contained the GPL. But gwt-glom is all LGPL.
721 2012-01-02 Murray Cumming <murrayc@murrayc.com>
723 Add project information to README and pom.xml.
725 * README: Add a brief description and mention some mvn
727 * pom.xml: This extra information shows up in mvn site
730 2011-01-02 Murray Cumming <murrayc@murrayc.com>
732 Use the latest java-libglom version.
734 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
736 2012-01-01 Murray Cumming <murrayc@murrayc.com>
738 GwtTestOnlineGlom: Test a little more.
740 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
741 protected rather than private, as suggested by the gwt-test-utils
743 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
744 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
745 Test the initial visibility of the panels.
747 However, this is not a very useful test.
748 And I wonder how we should generally test using this idea for an
749 activity/places app like ours where the real changes happen implicitly
750 based on the history token/URL.
752 2012-01-01 Murray Cumming <murrayc@murrayc.com>
754 Slight modification to *Mapper comments.
756 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
758 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
760 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
762 Remove comments mentioning GIN because they are just copied from
763 the example code and are apparently not helpful:
764 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
765 Also change the mention of a class that is only in the example code.
767 2012-01-01 Murray Cumming <murrayc@murrayc.com>
769 GwtTestOnlineGlom test: Minor changes.
771 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
772 Avoid the long qualified class name and modify the comment
773 because it is now obvious to me that the mocked class is the only
774 custom one created via GWT.create().
776 2012-01-01 Murray Cumming <murrayc@murrayc.com>
778 Tests: Added the beginnings of a test using gwt-test-utils.
780 * pom.xml: Add dependencies on gwt-test-utils and easymock.
781 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
782 which tells gwt-test-utils what class will be tested.
783 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
784 Add a simple (but empty) test case. One class, used by the OnlineGlom
785 class, is mocked so that it can be created. However, I am not sure
786 why only this class needs to be mocked.
788 Note that mockito seems more popular, and clearer, than easymock,
789 but I have not got that working yet. It might be a matter of the
792 This test is run during mvn integration-test.
794 2011-12-31 Murray Cumming <murrayc@murrayc.com>
796 Tests: Use junit4-style syntax instead of junit3-style.
798 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
799 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
800 * src/test/java/org/glom/web/shared/DataItemTest.java:
801 Use the @Test annotation rather than relying on the test*() prefix.
802 Also no longer implement TestCase, to avoid triggering support for
803 the junit3-way, which stops the annotations from working.
804 Change the imports from import junit.framework.* to
805 import org.junit.*, which is apparently the new way.
807 2011-12-31 Murray Cumming <murrayc@murrayc.com>
809 Added a test for ListPlace token parsing and creation.
811 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
812 This is much the same as DetailsPlaceTest.
814 I wonder how we could test the other parts of the *Place API.
816 2011-12-30 Murray Cumming <murrayc@murrayc.com>
818 DetailsPlace test: Also test getToken() and recreation via getPlace().
820 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
821 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
822 recreate it, testing the recreated DetailsPlace for the same parameter
825 2011-12-30 Murray Cumming <murrayc@murrayc.com>
827 Use the surefire-report plugin.
829 * pom.xml: This generates a HTML report about the tests in
830 target/site/surefire-report.html
831 when you do mvn surefire-report:report. It seems to be popular/normal.
833 2011-12-30 Murray Cumming <murrayc@murrayc.com>
835 Added a test for DetailsPlace.
837 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
838 Test the getPlace() token parsing.
840 2011-12-30 Murray Cumming <murrayc@murrayc.com>
842 Added a first unit test.
844 * pom.xml: Add a test goal, and a dependency on junit in that scope.
845 * src/test/java/org/glom/web/shared/DataItemTest.java:
846 This is a silly test but it is just to get things started. Note that
847 maven/junit finds the test because it looks in src/test by default.
849 2011-12-22 Ben Konrath <ben@bagu.org>
851 Change charsetName to "UTF-8" when replacing line breaks.
853 JavaScript requires the charsetName to be "UTF-8". CharsetName values
854 that work in Java (such as "UTF8") will not work when compiled to
857 This fixes a problem with multi-line details view fields that have hard
858 line breaks. The "License Text" field on this page demonstrates the
861 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
863 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
865 2011-12-22 Ben Konrath <ben@bagu.org>
867 Fix another bug with related list navigation.
869 I've tested all the navigation buttons in all of the related lists
870 so things should be good now.
872 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
874 2011-12-22 Ben Konrath <ben@bagu.org>
876 Fix a crasher when refreshing the list view with the default table.
878 This crash will also happen when loading the list view with the default
879 table from a link or bookmark.
881 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
882 to the main document selection page when the document id hasn't been
884 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
885 the main document selection page when the document id hasn't been
887 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
888 values for the details place when the document id hasn't been set.
889 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
890 values for the list place when the document id hasn't been set.
892 2011-12-21 Ben Konrath <ben@bagu.org>
894 Protect against NPE when glom.document.locale is not in config.
896 This patch protects against an NPE when glom.document.locale is not in
897 the config file. This NPE will also happen if glom.document.locale is
900 The patch also updates the error message to display the class name when
901 the getMessage() returns null. This was happening when the NPE was
902 thrown and I had "Configuration Error: null". If an NPE is encountered
903 with this patch, "Configuration Error: NullPointerException " will be
906 This commit closes this bug:
908 https://bugzilla.gnome.org/show_bug.cgi?id=666669
910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
912 2011-12-20 Murray Cumming <murrayc@murrayc.com>
914 Rename onlineglom.properties to onlineglom.properties.sample.
916 * src/main/resources/onlineglom.properties: Rename to:
917 * src/main/resources/onlineglom.properties.sample:
918 * src/main/resources/README: And add this file explaining that people
919 should rename it back when deploying.
921 2011-12-20 Murray Cumming <murrayc@murrayc.com>
923 Allow choosing the translation in the .properties file.
925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
926 init(): Read a glom.document.locale value from the configuration file
927 and call Glom's TransatableItem::set_current_locale() method.
928 * src/main/resources/onlineglom.properties: Add a commented-out
929 example of this new setting.
931 It would be better to add &lang=de_DE to the URL, but the current
932 libglom API does not allow us to do this easily. I am working on that.
934 2011-12-19 Murray Cumming <murrayc@murrayc.com>
936 Avoid a crash in parsing of token parameters.
938 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
939 ava: getTokenParams(): Do not crash if a parameter has a key but no
940 value, and ignore parameters with neither.
942 2011-12-17 Murray Cumming <murrayc@murayc.com>
944 History token building/handling: Improve use of token parameters.
946 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
947 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
948 and buildParamsToken(HashMap), for use by derived classes.
949 Make the separator private because it is no longer be needed.
950 * src/main/java/org/glom/web/client/place/DetailsPlace.java
951 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
952 instead of manual string concatenation.
953 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
954 of hardcoded indices and awkward splitting code.
955 * src/main/java/org/glom/web/client/place/ListPlace.java
956 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
957 instead of manual string concatenation.
958 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
959 of hardcoded indices and awkward splitting code.
960 This should fix bug #666420
962 2011-12-16 Murray Cumming <murrayc@murrayc.com>
964 Fix a Navgiation->Navigation typo in the code.
966 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
967 Rename processNavgiation() to processNavigation().
969 2011-12-16 Murray Cumming <murrayc@murrayc.com>
971 Fix a seperator->separator typo in the code.
973 * src/main/java/org/glom/web/client/place/DetailsPlace.java
974 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
975 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
978 2011-12-15 Ben Konrath <ben@bagu.org>
980 Cleanup some comments.
982 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
984 2011-12-14 Ben Konrath <ben@bagu.org>
986 Replace \n with <br/> for multiline text in the details view.
988 Vertical scrollbars are added when needed as well.
990 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
992 2011-12-14 Ben Konrath <ben@bagu.org>
994 Specify the font for document selection links.
996 * src/main/webapp/style.css:
998 2011-12-14 Ben Konrath <ben@bagu.org>
1000 Fix bouncy CellTable while paging.
1002 This doesn't currently work with related list tables in unselected
1005 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1007 2011-12-14 Ben Konrath <ben@bagu.org>
1009 Revamp the appearance of the document selection page.
1011 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1012 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1013 * src/main/webapp/style.css:
1015 2011-12-13 Ben Konrath <ben@bagu.org>
1017 Set navigation button column to the smallest size possible.
1019 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1021 2011-12-13 Ben Konrath <ben@bagu.org>
1023 Change OpenButton nomenclature to NavigationButton.
1025 Using NavigtionButton makes things more generic. Classes, methods and
1026 variables have been changed.
1028 This is a rename-only refactor.
1030 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1031 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1032 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1033 Renamed from OpenButtonCell.
1034 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1035 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1036 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1038 2011-12-12 Ben Konrath <ben@bagu.org>
1040 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1042 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1043 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1044 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1045 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1047 2011-12-12 Ben Konrath <ben@bagu.org>
1049 Update variable names and comments.
1051 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1052 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1054 2011-12-12 Ben Konrath <ben@bagu.org>
1056 Properly initialize numNonEmptyRows variable to zero.
1058 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1059 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1061 2011-12-05 Ben Konrath <ben@bagu.org>
1063 Add latest mockup with HTML tables.
1065 Features of this mockup:
1067 -> HTML table for flowtable
1068 -> HTML table for flowtable column
1069 -> Example of how related lists would look
1070 -> Not using text entries for data items
1072 The current version of Online Glom doesn't use HTML tables for the
1075 This mockup has been sent to the glom-devel mailing list but it's good
1076 to have it here as well.
1078 * mockups/details-view-html-tables.html:
1080 2011-12-05 Ben Konrath <ben@bagu.org>
1082 Remove unnecessary getPrimaryKeyField() method.
1084 getPrimaryKeyFieldForTable(String) has been renamed to
1085 getPrimaryKeyField(String).
1087 * src/main/java/org/glom/web/server/database/DBAccess.java:
1088 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1089 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1091 2011-12-05 Ben Konrath <ben@bagu.org>
1093 Add string representation of TypedDataItem value to conversion error message.
1095 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1096 message was extracted into its own method to avoid duplication.
1098 2011-12-05 Ben Konrath <ben@bagu.org>
1100 Add type checking to navigation primary key value creation.
1102 Create navigation primary key only if the expected type from the Glom
1103 document matches the type returned by the SQL query.
1105 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1107 2011-12-05 Ben Konrath <ben@bagu.org>
1109 Rename a couple of variables in RelatedListNavigation.
1111 This is a rename-only refactor.
1113 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1115 2011-12-05 Ben Konrath <ben@bagu.org>
1117 Move getListLayoutGroup() into getListViewLayoutGroup().
1119 This removes getListLayoutGroup(). It was only being called by
1120 getListViewLayoutGroup().
1122 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1124 2011-12-05 Ben Konrath <ben@bagu.org>
1126 Remove check for LayoutItem_Portal in list table method.
1128 This check is no longer necessary because the method isn't being used
1129 to create the LayoutItemPortal DTO.
1131 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1133 2011-12-05 Ben Konrath <ben@bagu.org>
1135 Properly support related list navigation.
1137 Navigation from the "Repository Analyzer -> Package Scans ->
1138 Dependencies" related table wasn't working because the primary key for
1139 related tables wasn't being set properly. This commit fixes the
1142 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1143 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1144 doesn't set the primary key properly for related list tables.
1145 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1146 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1147 useful for getting the primary key for list view tables and for related
1149 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1150 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1151 Move code to set the primary key for the table from the abstract
1152 ListDBAccess class to ListViewDBAccess as it's only correct for list
1154 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1155 Properly add primary key to related list tables.
1157 2011-12-02 Ben Konrath <ben@bagu.org>
1159 Properly set the horizontal alignment of fields.
1161 This fix is for both the list tables and the details view.
1163 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1164 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1165 to set the horizontal alignment of fields.
1167 2011-12-02 Ben Konrath <ben@bagu.org>
1169 Display currency codes in the details view.
1171 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1173 2011-12-02 Ben Konrath <ben@bagu.org>
1175 Avoid duplicate JNI call.
1177 JNI is not as efficient as pure Java and this is an easy (and small)
1180 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1181 Use previously retrieved value for whereClauseToTableName instead of
1184 2011-12-02 Ben Konrath <ben@bagu.org>
1186 Rename a couple of variables in RelatedListNavigation.
1188 This is a rename-only refactor.
1190 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1192 2011-12-02 Ben Konrath <ben@bagu.org>
1194 Indicate clearly that a mismatched primary key type is a bug.
1196 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1197 warning to error. Add 'This is a bug.' to message.
1199 2011-12-02 Ben Konrath <ben@bagu.org>
1201 Update / fix some comments.
1203 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1205 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1207 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1208 Fix comments. Add some TODOs.
1210 2011-12-02 Ben Konrath <ben@bagu.org>
1212 Enable navigation to details view with string primary key from related list.
1214 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1215 Create a text primary key value when return type of result is
1216 java.sql.Types.VARCHAR.
1218 2011-12-02 Ben Konrath <ben@bagu.org>
1220 Use checkboxes for booleans in the details view.
1222 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1224 2011-12-01 Ben Konrath <ben@bagu.org>
1226 Improve performance of related list height calculation.
1228 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1229 Put code to calculate the expected height in a static initializer so
1230 that that it's only called once.
1232 2011-12-01 Ben Konrath <ben@bagu.org>
1234 Show related list tables in notebooks (again).
1236 Calculate the height of the related list tables so the Notebook can be
1237 set the correct height. The height of the related list table is also needed by
1238 FlowTable to be able decide how to create the layout.
1240 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1241 and set the Portal height based on the height of the related list
1242 table and the Portal container.
1243 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1244 Add method to calculate the height of the related list tables.
1245 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1246 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1247 calculate the height of the Pager widget.
1249 2011-12-01 Ben Konrath <ben@bagu.org>
1251 Use CellTable API for table property instead of setting style on Element.
1253 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1255 2011-12-01 Ben Konrath <ben@bagu.org>
1257 Make ListViewTable and RelatedListTable a consistent height.
1259 The tables are now a consistent height regardless of the contents of
1260 the table. A hidden button is added to empty rows to ensure that the
1261 height of these rows will match the height of rows with data.
1263 A navigation button column is now added to every table. The width of
1264 the navigation column is set to 0px when a RelatedListTable shouldn't
1265 have navigation buttons. This maintains the a consistent row height in
1266 tables that don't show the navigation buttons.
1268 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1269 navigation column when not needed.
1270 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1271 arguments for navigation button to constructor of ListViewTable.
1272 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1273 hidden button for empty data rows.
1274 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1275 arguments for navigation button to constructor.
1276 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1277 create navigation buttons. Add hideNavigationButtons() method.
1278 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1279 arguments for navigation button to constructor.
1281 2011-12-01 Ben Konrath <ben@bagu.org>
1283 Use 'visibility: hidden' in Utils.getWidgetHeight().
1285 This is better choice because hidden elements are invisible, don't
1286 respond to events and are not part of the tab order. They will,
1287 however, take up space which is required to be able to calculate the
1288 height of the widget.
1290 * src/main/java/org/glom/web/client/Utils.java:
1292 2011-12-01 Ben Konrath <ben@bagu.org>
1294 Use Utils.getWidgetHeight() in FlowTable.
1296 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1298 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1300 2011-12-01 Ben Konrath <ben@bagu.org>
1302 Put the details css class name on the correct table column.
1304 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1306 2011-11-30 Ben Konrath <ben@bagu.org>
1308 Update for java-libglom API change.
1310 The getters and setters on FieldFormatting and NumericFormat were
1311 changed to remove the 'M'.
1313 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1315 2011-11-29 Ben Konrath <ben@bagu.org>
1317 Only allow RelatedListTables in Portals.
1319 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1321 2011-11-29 Ben Konrath <ben@bagu.org>
1323 Only create a contents panel for Portals when title is being set.
1325 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1327 2011-11-29 Ben Konrath <ben@bagu.org>
1329 Set TabLayoutPanel height based on calculated height its widgets.
1331 This is a potential fix for this bug:
1333 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1335 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1337 2011-11-29 Ben Konrath <ben@bagu.org>
1339 Align details field labels and data with the Open buttons.
1341 * src/main/webapp/style.css:
1343 2011-11-29 Ben Konrath <ben@bagu.org>
1345 Remove unnecessary <div> in the Notebook widget.
1347 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1348 method to get container FlowPanel (<div>).
1349 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1350 initWidget() method directly on the TabLayoutPanel widget instead of
1351 Group's container widget.
1353 2011-11-29 Ben Konrath <ben@bagu.org>
1355 Don't add group titles for Portals in Notebooks.
1357 This reverts the previous patch and fixes a bug I introduced with
1358 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1360 * src/main/java/org/glom/web/client/ui/details/Group.java:
1361 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1363 2011-11-28 Ben Konrath <ben@bagu.org>
1365 Remove unused boolean argument in Portal constructor.
1367 Just a code cleanup.
1369 * src/main/java/org/glom/web/client/ui/details/Group.java:
1370 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1372 2011-11-28 Ben Konrath <ben@bagu.org>
1374 Remove hack for glom 1.18 style glom files.
1376 * src/main/java/org/glom/web/client/ui/details/Group.java:
1377 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1378 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1380 2011-11-28 Ben Konrath <ben@bagu.org>
1382 Use Gda Value version of primary key to log result too large error.
1384 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1386 2011-11-28 Ben Konrath <ben@bagu.org>
1388 Don't use TypedDataItem.getText() for Unknown types from the URL.
1390 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1391 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1392 instead of getText().
1393 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1394 String field and getUnknown() method.
1396 2011-11-28 Ben Konrath <ben@bagu.org>
1398 Log an error message when the java-libglom .so is not present.
1400 The error message was being set in the exception but not logged.
1402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1404 2011-11-28 Ben Konrath <ben@bagu.org>
1406 Ignore LayoutItem_CalendarPortals.
1408 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1409 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1411 2011-11-28 Ben Konrath <ben@bagu.org>
1413 Extract method for creating the LayoutItemPortal DTO.
1415 Just breaking the code up into smaller chunks.
1417 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1419 2011-11-28 Ben Konrath <ben@bagu.org>
1423 This should have been added with the refactor. Oops!
1425 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1427 2011-11-28 Ben Konrath <ben@bagu.org>
1429 Create primary key value from URL string using type from Glom document.
1431 See this bug, comments 19 - 25:
1433 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1435 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1436 create a TypeDataItem for the primary key here when loading from a
1437 URL. Show the same string for the primary key value as was received
1438 from the URL string (when loading from a URL).
1439 * src/main/java/org/glom/web/server/Utils.java: Update method for
1440 creating the Gda Value from the TypeDataItem to properly deal with
1441 creating a Gda Value based on the Glom document type for the primary
1442 key value string when loading from a URL.
1443 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1444 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1445 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1446 Update for changed method name.
1448 2011-11-27 Ben Konrath <ben@bagu.org>
1450 Rename PrimaryKeyItem to TypedDataItem.
1452 The name PrimaryKeyItem suggests what the class should be used for.
1453 TypedDataItem is a neutral name that describes the class better.
1455 This is a rename-only refactor.
1457 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1458 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1459 * src/main/java/org/glom/web/client/Utils.java:
1460 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1461 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1462 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1463 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1464 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1465 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1467 * src/main/java/org/glom/web/server/Utils.java:
1468 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1469 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1470 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1471 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1473 2011-11-25 Ben Konrath <ben@bagu.org>
1475 Improve Gda Value conversion from PrimaryKeyItem.
1477 The value from the PrimaryKeyItem is only used if its type match the
1478 type from the glom document.
1480 * src/main/java/org/glom/web/server/Utils.java:
1482 2011-11-25 Ben Konrath <ben@bagu.org>
1484 Manually check if the java-liblgom .so is visible to the JVM.
1486 It seems that Tomcat has problems when a static initializer throws an
1487 exception. This check is done before the first method call into
1488 java-libglom so that execution doesn't continue if the .so is not
1491 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1493 2011-11-25 Ben Konrath <ben@bagu.org>
1495 Improve browser configuration error messages.
1499 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1501 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1502 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1503 getConfigurationErrorMessage() method.
1504 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1505 Get and display a specific configuration error message when no Glom
1506 documents are found.
1507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1508 Implement getConfigurationErrorMessage() method. Surround configuration
1509 code in the init() method with a try/catch block. This allows the
1510 errors to be caught while keeping the servlet available to retrieve the
1511 configuration error message.
1513 2011-11-25 Ben Konrath <ben@bagu.org>
1515 Don't use Strings to hold primary key values.
1517 The primary key values are now held in a new data object
1518 (PrimaryKeyItem) that holds type information and the primary key value
1519 using the correct type.
1521 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1522 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1523 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1524 PrimaryKeyItem instead of String to hold the primary key value.
1525 * src/main/java/org/glom/web/client/Utils.java: Remove
1526 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1527 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1528 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1529 PrimaryKeyItem instead of String to hold the primary key value. Load
1530 document selection page when the documentID has not been set correctly.
1531 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1532 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1534 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1535 Return empty string for URL instead of "null".
1536 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1537 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1538 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1539 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1540 PrimaryKeyItem instead of String to hold primary key values.
1541 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1542 PrimaryKeyValue to a Gda Value.
1543 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1544 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1545 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1546 Replace temporary database access code that uses the PrimaryKeyValue to
1547 Gda Value conversion.
1548 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1549 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1550 PrimaryKeyItem instead of String.
1551 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1552 hold primary key values.
1554 2011-11-24 Ben Konrath <ben@bagu.org>
1556 Use newly added java-libglom API to create queries.
1558 This isn't finished. I still need to stop using Strings for primary key
1559 values in the client code.
1561 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1562 libglom to use fake connections so that retrieving the query string will
1564 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1565 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1566 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1567 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1568 Use the newly added libglom sql methods and classes to create the
1569 query. Add temporary hack to convert primary value strings to Gda
1572 2011-11-23 Ben Konrath <ben@bagu.org>
1574 Don't explicitly set the height of Portals.
1576 See comments 6 - 10 of this bug for details:
1578 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1580 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1582 2011-11-23 Ben Konrath <ben@bagu.org>
1584 Use an HTML table instead of CSS for the FlowTable layout.
1586 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1587 GWT's FlexTable to implement the FlowTable.
1588 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1590 2011-11-18 Ben Konrath <ben@bagu.org>
1592 Add boolean example to HTML table mockup.
1594 * mockups/details-view-html-tables-text-entries.html:
1596 2011-11-17 Ben Konrath <ben@bagu.org>
1598 Ensure the pager buttons are always visible for related lists.
1600 To accomplish this, I've turned off text wrapping in the list view and
1601 related list tables for both the header and data text. The related list
1602 table now has a fixed layout so the it doesn't overflow its container.
1603 This is required to ensure that the cell text is clipped when it
1604 overflows the cell and an ellipsis is added to the right side of the
1605 cell when text is clipped.
1607 A fixed table layout for the related list table in the details view
1608 seems what we want for the details view anyway, so the side-effect is
1611 The ellipsis will only be displayed in Firefox >= 7.
1615 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1617 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1618 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1619 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1621 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1622 Set the 'table-layout: fixed' CSS property to the related list table.
1623 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1624 'white-space: nowrap;' CSS property on both the list view and the
1625 related list tables.
1627 2011-11-16 Ben Konrath <ben@bagu.org>
1629 Rework the fix for empty notebook tab labels.
1631 Setting the empty group titles with its name caused problems for the
1632 details layout. Instead of using libglom's
1633 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1634 to the client when the title is empty. This allows the Notebook to use
1635 the name when the title is empty without affecting anything else.
1637 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1638 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1640 2011-11-16 Ben Konrath <ben@bagu.org>
1642 Set group titles with name when title is empty.
1644 This fixes a problem with an empty notebook tab label in the Lesson
1645 Planner document. The forth tab in the notebook should be "Internet":
1647 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1649 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1650 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1653 2011-11-16 Ben Konrath <ben@bagu.org>
1655 Remove whitespace from the configured username properties.
1657 This assumes that usernames won't have whitespace at the beginning
1658 or end. But I think this is a reasonable assumption.
1660 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1661 String.trim() to remove the whitespace from the username properties.
1663 2011-11-15 Ben Konrath <ben@bagu.org>
1665 Add details view mockup with HTML tables and text entries.
1667 This is from the attachment on this bug:
1669 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1671 * mockups/details-view-html-tables-text-entries.html:
1673 2011-11-15 Ben Konrath <ben@bagu.org>
1675 Add space between the columns of the flow table.
1679 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1681 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1682 space between columns in the flow table.
1684 2011-11-15 Ben Konrath <ben@bagu.org>
1686 Add backup files to the .gitignore.
1688 * .gitignore: Ignore files that end with ~.
1690 2011-11-09 Ben Konrath <ben@bagu.org>
1692 Use latest release of gwt-log.
1694 Gwt-log releases are now being submitted to the maven central
1695 repository so manual installation of the jar is no longer required.
1697 * pom.xml: Update version and groupId of gwt-log dependency.
1699 2011-10-31 Ben Konrath <ben@bagu.org>
1701 Don't use GWT numeric formatting to override the glom currency formatting.
1703 Currencies are now displayed like they are in Glom. See this bug:
1705 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1707 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1709 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1710 currency code to constructor and set it when the cell is rendered.
1711 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1712 currency code to the constructor of the NumericCell.
1714 2011-10-27 Ben Konrath <ben@bagu.org>
1716 Require the latest release of java-libglom (1.17.4).
1720 2011-10-26 Ben Konrath <ben@bagu.org>
1722 Add style to Notebook that matches current theme.
1724 It's not the best style in the world but it's better than the default.
1726 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1727 padding at the bottom of the child widgets.
1728 * src/main/webapp/style.css: Add style for the Notebook.
1730 2011-10-26 Ben Konrath <ben@bagu.org>
1732 Move servlet initialization code to overridden init method.
1734 This is half of the solution to getting proper error messages
1735 displayed when configuration errors occur. Here's the relevant bug:
1737 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1739 The rest of the solution involves surrounding the init method with a
1740 try/catch block and setting a global variable with the error /
1741 exception. A new async method should be created to retrieve and display
1742 the error message / exception.
1744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1745 code from constructor to init method adding exceptions as needed.
1747 2011-10-26 Ben Konrath <ben@bagu.org>
1749 Add script to monitor and restart tomcat if required.
1751 * utils/check-and-recover-tomcat.py: New file.
1753 2011-10-26 Ben Konrath <ben@bagu.org>
1755 Display the correct number of data items in the pager.
1759 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1761 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1762 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1763 The implementation is the same for both tables: Keep track of the
1764 number of non-empty rows and fire and RowCountChangeEvent after the data has
1766 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1767 custom Pager class that subclasses SimplePager to handle displaying
1768 the correct number when empty rows have been added.
1770 2011-10-26 Ben Konrath <ben@bagu.org>
1772 Correct error in previous commit.
1774 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1775 eventBus parameter from listView.setCellTable().
1777 2011-10-26 Ben Konrath <ben@bagu.org>
1779 Fix error in TODO comment.
1781 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1783 2011-10-24 Ben Konrath <ben@bagu.org>
1785 Create Notebook widgets to the details view.
1787 This isn't finished just yet - I still need to create a reasonable
1788 style to match the current theme.
1790 * src/main/java/org/glom/web/client/Utils.java: Add method for
1791 calculating the height of a widget. This is used in the Notebook class.
1792 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1793 new constructor method in Group.
1794 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1795 method for creating child widget that can be used by subclasses
1796 like Notebook. New constructor that allows disabling the group
1797 titles - Notebooks don't set a group title for their child groups.
1798 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1799 to make Notebooks using GWT's TabLayoutPanel.
1800 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1801 constructor that allows disabling the group titles.
1802 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1803 LayoutItemNotebook DTO.
1804 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1805 DTO for Notebooks. It's just an empty class for now but we might need
1806 it to transfer some specific information in the future.
1808 2011-10-21 Ben Konrath <ben@bagu.org>
1810 Add navigation buttons to related list tables.
1812 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1813 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1815 method getSuitableRecordToViewDetails() for getting the table name
1816 and primary key value for related list navigation buttons.
1817 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1818 private cell renderer class to get the navigation information for
1819 related list tables from the server. Extract the navigation
1820 processing code from the details cell navigation and use it for the
1821 related list navigation as well.
1822 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1823 cell renderer class for the details open buttons. This was needed
1824 because the related list navigation buttons and the list view
1825 navigation buttons need to react differently when clicked.
1826 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1827 the onEnterKeyDown() method because it's now overriden in the
1828 subclasses that are specific to the related list tables and the list
1830 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1831 the vertical size a little because the buttons add a bit of vertical
1832 space to table. This is not a perfect solution because the vertical
1833 size of with table fewer than 5 rows will be a little smaller.
1834 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1835 changes in how navigation buttons are handled.
1836 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1837 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1838 database access object.
1839 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1840 to find the portal for a given relationship name from
1841 RelatedListDBAccess. Add method to find a primary key field for a
1843 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1844 Move code to find the portal for a given relationship name to
1846 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1847 New file: database access object for getting the related list
1848 navigation information (the table name and the primary key value).
1849 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1850 DTO for transferring a table name to navigate to and a primary key
1852 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1853 boolean and getter/setter to specifies if the related list should add
1856 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1858 Use the master branch of java-libglom
1860 * pom.xml: Depend on java-libglom 1.19 instead.
1862 This is the master branch. See also the libglom-1-18 branch.
1864 2011-10-11 Ben Konrath <ben@bagu.org>
1866 Enable the open navigation button when the data has been set.
1868 This avoids having active buttons that don't do anything when the data
1871 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1873 2011-10-11 Ben Konrath <ben@bagu.org>
1875 Use IsWidget interface for FlowTableItem.
1877 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1878 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1880 2011-10-11 Ben Konrath <ben@bagu.org>
1882 Remove GWT styling from open button in details view.
1884 There are still some issues with how the details cell is arranged but
1885 this should be made to match Glom 1.20. I'm going to leave fixing this
1886 until I have Glom 1.20 up and running.
1888 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1889 style name on open button.
1890 * src/main/webapp/style.css: Move and edit details-navigation class.
1891 Re-arrange some classes to make them appear in the same order as the
1894 2011-10-07 Ben Konrath <ben@bagu.org>
1896 Update to GWT 2.4.0.
1898 * .gitignore: Ignore new cache directory.
1899 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1900 * pom.xml: Change GWT and maven plugin to 2.4.0.
1901 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1903 * src/main/java/org/glom/web/client/ClientFactory.java:
1904 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1905 * src/main/java/org/glom/web/client/OnlineGlom.java:
1906 Update source for API changes.
1907 * utils/build-onlineglom-war.sh: Remove cache directory before the
1910 2011-10-07 Ben Konrath <ben@bagu.org>
1912 Add navigation buttons in the details view.
1914 This isn't finished but I thought I'd commit what I have as it's a
1915 pretty good start. I still need to:
1917 1. Change the style so that it fits better into the current theme
1918 2. Adjust the details cell to expand as much as possible.
1920 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1921 click handlers to navigation buttons in the DetailsCells. Create a
1922 refreshData() method to get just the data from the server without the
1924 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1925 Update the tableSelector and browser title when the table name
1926 changes without using the tableSelector.
1927 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1928 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1929 getDetailsCells() to getCells(). Update variable names.
1930 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1931 method to set click handler on navigation button. Rename a few
1932 variables. Add navigation buttons where needed.
1933 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1934 variables and methods.
1935 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1936 navigation boolean and navigation table as required in the
1937 LayoutItemField DTO.
1938 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1939 variables for navigation along with getter/setter methods.
1941 2011-10-07 Ben Konrath <ben@bagu.org>
1943 Rename Field to DetailsCell.
1945 This is a refactor-only commit. No functionality has been added or
1948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1949 Update variable and method names.
1950 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1951 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1952 variable and method names.
1953 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1955 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1956 variable and method names.
1958 2011-10-07 Ben Konrath <ben@bagu.org>
1960 Create separate methods for layout and data the details view.
1962 This is a refactor-only commit. No functionality has been added or
1965 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1966 private methods: setData(), createLayout().
1968 2011-10-07 Ben Konrath <ben@bagu.org>
1970 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1972 This is part of a change to get navigation buttons in the details view
1973 but it should have been done this way from the start.
1975 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1976 for method name change in TableSelectionView.
1977 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1978 Create TableChangeEvent and set the browser title using the
1979 TableSelectionView API.
1980 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1981 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1982 Change getSelectedTable() to getSelectedTableName(). Add
1983 getSelectedTableTitle().
1985 2011-10-07 Ben Konrath <ben@bagu.org>
1987 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1989 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1991 2011-10-07 Ben Konrath <ben@bagu.org>
1993 Update TableChangeEvent to use newTableName naming convention.
1995 This makes the class more consistent with GWT naming conventions.
1997 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1998 Update for method name change in TableChangeEvent.
1999 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2000 for method name change in TableChangeEvent.
2001 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2002 newTableName variable and getter method. Make toDebugString()
2005 2011-09-30 Ben Konrath <ben@bagu.org>
2007 Disable the pager in the list tables when the data row count is less than the minimum.
2009 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2010 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2012 2011-09-30 Ben Konrath <ben@bagu.org>
2014 Add empty rows to the end of related list and list view tables.
2016 I also extracted the cell rendering classes from the ListTable because
2017 the code was becoming a little crazy with all the anonymous inner
2018 classes. My plan is to use these cell rendering classes in the details
2019 view as well so this refactor will be needed for that change.
2021 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2022 set the row count in related list tables if the data has more rows
2023 than the minimum number of rows visible.
2024 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2025 row count in list view tables if the data has more rows than the
2026 minimum number of rows visible.
2027 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2028 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2030 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2031 for rendering TYPE_NUMERIC cells. The code was extracted from the
2033 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2034 class for rendering cells with buttons in list views. The code was
2035 extracted from the ListTable class.
2036 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2037 for rendering TYPE_TEXT cells. The code was extracted from the
2039 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2040 Add empty rows to the end of the data if required. Implement
2041 ListTable.getMinNumVisibleRows().
2042 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2043 cell renderer code to public classes. Return null in
2044 Column.getValue() for empty rows. Add new abstract method:
2045 getMinNumVisibleRows(). Move code to set the row count of the list view
2046 table to ListViewImpl.
2047 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2048 empty rows to the end of the data if required. Implement
2049 ListTable.getMinNumVisibleRows().
2052 2011-09-27 Ben Konrath <ben@bagu.org>
2054 Use GWT.log for client-side debugging statements.
2056 These are optimized out when deployed so I should have used this method
2057 in the first place. These statements will eventually be replaced with some sort
2058 of notification in the browser.
2060 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2061 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2062 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2063 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2064 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2066 2011-09-27 Ben Konrath <ben@bagu.org>
2068 Put tableselector on the right, back to list link on right.
2070 The idea is that the table selector is acting like a label for the
2071 currently displayed table so it should be placed below the document title. This
2072 puts the table title in a similar position to where it is in Glom.
2074 * mockups/details-contacts.html:
2075 * mockups/details-projects.html:
2076 * mockups/listview-contacts.html:
2077 * mockups/listview-projects.html:
2078 * mockups/style.css:
2079 Update mockups to match how the interfaces currently look.
2080 * src/main/webapp/style.css: Swap positions of backlink with the table
2081 selector. Add some space on the left side of the table selector to
2082 line things up with the document title.
2084 2011-09-27 Ben Konrath <ben@bagu.org>
2086 Add field colouring to details view.
2088 This change re-works how field colouring works. The colour formatting
2089 information is now set to the client with the layout information instead of
2090 with the data. This eliminates the need to send the same colour strings for
2091 data in list view column when colour information is set.
2093 In order to set an alternate colour for negative numeric values, the
2094 number is now sent to client and formatted with the GWT NumberFormat class.
2096 This change also fixes:
2098 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2100 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2101 internationalization framework which is needed for client side numeric
2103 * src/main/java/org/glom/web/client/Utils.java: New file for some
2104 client static utility methods.
2105 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2106 the DataItem object to the Field class. Use a utility method to
2107 create the foreignKeyValue string.
2108 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2109 alignment and text colours in the constructor. Add setData(DataItem)
2110 method. Remove setText(String) method.
2111 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2112 colour information to GlomTextCell. Create and use GlomNumberCell for
2113 rendering numbers. Use utility method to get the string for the
2114 primary key of the key provider. Re-work how the horizontal alignment
2116 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2117 formatting to layout information. Methods for converting the libglom
2118 formatting information were moved from DBAccess.
2119 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2120 numeric formatting (it's now done on the client side). Don't set text
2121 colours in DataItem. Move libglom formatting conversion methods to
2123 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2124 getters/setters for text colour information.
2125 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2126 for transferring the libglom NumericFormat information to the client.
2127 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2128 and getters/setters for: GlomNumericFormat, background colour and
2129 foreground colour strings.
2131 2011-09-26 Ben Konrath <ben@bagu.org>
2133 Simplify code that iterates through the LayoutGroup.
2135 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2137 2011-09-26 Ben Konrath <ben@bagu.org>
2139 Accept Eclipse formatting for OnlineGlomServiceAsync.
2141 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2143 2011-09-26 Ben Konrath <ben@bagu.org>
2145 Don't use the ListDBAccess classes to get the primary key layout information.
2147 This was causing a bug where the wrong index for the hidden primary key
2148 was being sent to the client.
2150 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2151 primary key while creating the LayoutGroup DTO. Create a
2152 LayoutItemField DTO for hidden primary keys. Don't use the
2153 RelatedListDBAccess because it was only used for getting the primary
2155 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2156 access modifier from public to protected for getPrimaryKeyField() and
2157 getPrimaryKeyLayoutItemField().
2158 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2159 abstract method getExpectedResultSize() because RelatedListDBAccess
2160 doesn't have enough info to implement it.
2161 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2162 Remove @Override for getExpectedResultSize().
2163 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2164 Remove method getExpectedResultSize().
2166 2011-09-23 Ben Konrath <ben@bagu.org>
2168 Log which layout (list or details) the ignored item is from.
2170 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2172 2011-09-23 Ben Konrath <ben@bagu.org>
2174 Remove annotations that turn off code formatting in DataItem.
2176 * src/main/java/org/glom/web/shared/DataItem.java:
2178 2011-09-23 Ben Konrath <ben@bagu.org>
2180 Rename GlomField to DataItem and update associated methods.
2182 This is a rename-only refactor. No functionality has been added or
2185 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2186 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2187 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2188 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2189 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2190 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2191 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2192 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2194 * src/main/java/org/glom/web/server/database/DBAccess.java:
2195 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2196 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2197 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2198 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2199 * src/main/java/org/glom/web/shared/DataItem.java:
2200 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2201 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2203 2011-09-23 Ben Konrath <ben@bagu.org>
2205 Rename GlomDocument to DocumentInfo and update associated methods.
2207 This is a rename-only refactor. No functionality has been added or
2210 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2211 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2212 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2213 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2214 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2216 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2218 2011-09-20 Ben Konrath <ben@bagu.org>
2220 Require java-libglom 1.17.3.
2222 This picks up the fix for the seg fault problem with the Scenes table
2223 in the Openismus Film Manager example.
2227 2011-09-20 Ben Konrath <ben@bagu.org>
2229 Change the way sort clause is added for primary key when no sort clause is requested.
2231 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2232 before the sort clause is created. When a sort clause is not requested, the
2233 sort clause is created by finding the primary key in the LayoutFieldVector
2236 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2238 2011-09-20 Ben Konrath <ben@bagu.org>
2240 Log error message if no documents are found in the configured directory.
2242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2243 Extract the glom file extension string to a private static final class
2244 variable (mostly as syntactic sugar). Accept a minor formatting change.
2245 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2246 the example glom.document.directory configuration property to make it
2247 more clear that it can any directory, not just the home directory.
2249 2011-09-18 Ben Konrath <ben@bagu.org>
2251 Add related lists to details view.
2253 The related list table has support for paging and sorting just like the
2254 table in the list view.
2256 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2257 SQL queries for the related list tables.
2258 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2259 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2260 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2261 Rename getList methods to getListView and add comments. Remove
2262 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2263 it being unused. Add methods: getDetailsLayoutAndData(),
2264 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2265 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2266 Create the layout and set the data for the fields in one async call
2267 instead of two. Create related lists where appropriate.
2268 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2269 for method name changes in OnlineGlomService.
2270 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2271 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2272 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2274 * src/main/java/org/glom/web/client/ui/ListView.java:
2275 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2276 tableName from setCellTable(). Create a ListViewTable instead of
2278 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2279 represent a data field in the details view.
2280 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2281 from addDetailsCell() to Field class. Keep track of the Fields and
2282 Portals in the details view.
2283 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2284 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2285 and add a method to get it. Add method to set the contents of the
2287 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2288 New class for related list tables. This class has the data provider
2289 for the related list table.
2290 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2291 abstract class which is the base class for the ListViewTable and the
2293 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2294 New class for list view tables. This class has the data provider for
2295 the list view table.
2296 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2297 methods for related list tables. Add more information to the
2298 LayoutItemField and LayoutItemPortal DTOs.
2299 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2300 Remove debugging print statement.
2301 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2302 Remove debugging print statements. Add primary key field to SQL count
2304 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2305 Remove unnecessary LayoutFieldVector parameter from
2306 getResultSizeOfSQLQuery() method.
2307 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2308 New class for related list table database access.
2309 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2310 class that is a wrapper DTO for details view layout and data.
2311 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2312 new 'fromField' string to this DTO.
2313 * src/main/webapp/style.css: Remove bottom margin and override top
2316 2011-09-15 Ben Konrath <ben@bagu.org>
2318 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2320 This sets things up to make it easier to add the data retrieval for
2321 related lists (portals). No user noticeable changes were made with
2324 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2325 class has the code to retrieve the layouts and access the
2326 database using the new database helper classes.
2327 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2328 Most of the functionality has been removed from this class. This
2329 class now represents the public interface for the client side
2330 code. It also deals with configuring the servlet and cleaning
2331 things up when the servlet is stopped.
2332 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2333 of static methods into this utility class.
2334 * src/main/java/org/glom/web/server/database/DBAccess.java:
2335 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2336 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2337 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2338 These classes have the database retrieval code. The class hierarchy
2339 has been setup to make it easy to reuse code for similar
2342 2011-09-06 Ben Konrath <ben@bagu.org>
2344 Create separate classes for list table code and the data provider.
2346 As part of this refactor, I also split up the code a bit to make it
2349 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2350 table code to two new classes (below).
2351 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2352 with code from ListViewImpl.
2353 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2354 New file with code from ListViewImpl.
2356 2011-09-06 Ben Konrath <ben@bagu.org>
2358 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2360 This fixes the LayoutItemPortal DTO to match the libglom layout object
2363 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2365 2011-09-01 Ben Konrath <ben@bagu.org>
2367 Set title of Portals in the Details View.
2369 * pom.xml: Bump required version of java-libglom to 1.17.1.
2370 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2371 widget creation to its own class. Add comments to constructor.
2372 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2373 The code is mostly from the Group class with the title now set.
2374 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2375 title of Portal. Update some comments. Fix some code formatting.
2377 2011-09-01 Ben Konrath <ben@bagu.org>
2379 Remove TODO comment for the flow table column width.
2381 The flow table column width is working correctly and doesn't need to be
2382 changed. See this mailing list post for more info:
2384 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2386 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2388 2011-08-27 Ben Konrath <ben@bagu.org>
2390 Add document title (database name) to top of the browser page.
2392 I added the document title to the TableSelecitonView but that will
2393 change if / when we add a view that doesn't require table selection.
2395 * mockups/details-contacts.html:
2396 * mockups/details-projects.html:
2397 * mockups/listview-contacts.html:
2398 * mockups/listview-projects.html:
2399 * mockups/style.css: Add document title to mockups to keep things
2401 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2402 sizes to account for the document title.
2403 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2404 Set the document title when it has been retrieved from the server.
2405 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2406 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2407 and implement setDocumentTitle(String) method.
2408 * src/main/webapp/style.css: Add ID for document title style.
2410 2011-08-25 Ben Konrath <ben@bagu.org>
2412 Add NavigationType enum to LayoutItemPortal DTO.
2414 This is the start of adding support for Portals to the Details View.
2416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2417 LayoutItem_Portal.navigation_type enum from libglom to
2418 LayoutItemPortal.NavigationType enum.
2419 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2420 NavigationType enum, field for storing the NavigationType and getter
2423 2011-08-25 Ben Konrath <ben@bagu.org>
2425 Implement the flow table layout in the Details View.
2427 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2428 FlowTable to Group to account for the renamed class.
2429 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2430 File. This is a container widget that implements the Glom details view
2431 flow table behaviour.
2432 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2433 org/glom/web/client/ui/FlowTable.java.
2434 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2435 so that the size of the subgroups are a closer match to the size of
2436 the Glom subgroups. This makes the flowtable layout match the layout
2437 in Glom for the Music Collection example file.
2439 2011-08-16 Ben Konrath <ben@bagu.org>
2441 Create container element for LayoutItemPortal in Details View.
2443 This will help me develop the layout for the FlowTable.
2445 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2446 fieldPanel variable to detailsCell.
2448 2011-08-15 Ben Konrath <ben@bagu.org>
2450 Set the height of the data element in the Details View.
2452 I changed the InlineLabels (text in a span element) to Labels (text in
2453 a div element) so that I could set the height of the details-data
2454 elements instead of the details-cell parent elements. This allows the
2455 the details-data element to display the correct height if style is
2456 applied that shows the height.
2458 This change has the added benefit of allowing the order of the labels
2459 and data elements to be changed for right-to-left languages.
2461 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2462 InlineLabels to Labels.
2463 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2464 InlineLabels to Labels. Set the height of the data element.
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2466 multiline text height in the Formatting DTO.
2467 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2468 for multiline height along with getter and setter methods.
2469 * src/main/webapp/style.css: Adjust style to account for the change
2470 from span elements to div elements in the details cell.
2472 2011-08-15 Ben Konrath <ben@bagu.org>
2474 Make the List View appearance match the mockups.
2476 It doesn't match exactly but it's much better than it was.
2478 * mockups/listview-contacts.html: Remove unused css classes.
2479 * mockups/listview-projects.html: Remove unused css classes.
2480 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2481 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2482 for mainPanel instead of VerticalPanel (table). Set style name on
2483 CellTable. Set style name on Details column. Right-align Details
2485 * src/main/webapp/style.css: Adjust properties to match the mockups.
2487 2011-08-12 Ben Konrath <ben@bagu.org>
2489 Add better support for subgroups in the details view.
2491 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2492 changed FlowTable constructor.
2493 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2494 support for subgroups and subgroup-titles.
2495 * src/main/webapp/style.css: Add CSS class for subgroups and
2498 2011-08-12 Ben Konrath <ben@bagu.org>
2500 Return the top level LayoutGroup title.
2502 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2504 2011-08-11 Ben Konrath <ben@bagu.org>
2506 Make the TableSelector header match the mockup.
2508 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2509 the layout panel. Properly lineup the table selection header with
2510 the list and details view.
2511 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2512 margin around the details view.
2513 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2514 Rename listBox variable to tableSelector. Set id for the style sheet.
2515 Use a FlowPanel instead of a HorizontalPanel.
2516 * src/main/webapp/style.css: Add properties to make the TableSelector
2517 box match the mockups.
2519 2011-07-13 Ben Konrath <ben@bagu.org>
2521 Update install script for java-libglom version change.
2523 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2526 2011-07-13 Ben Konrath <ben@bagu.org>
2528 Add support sub-group in the details view.
2530 I also removed the code that special-cased the default details view
2533 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2535 I still have to make a proper flowtable.
2537 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2538 Don't special-case default details view layout.
2539 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2540 addLayoutField() as I'm going to use it.
2541 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2542 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2544 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2545 extracted from DetailsViewImpl.GroupPanel. Add support for
2547 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2548 column count when getting the details layout.
2550 2011-07-12 Ben Konrath <ben@bagu.org>
2552 Set browser title with database and table titles.
2554 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2555 Set the browser title when the table changes and when the activity
2557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2558 title when retrieving document info (the GlomDocument object).
2559 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2560 with getter and setter methods. Remove unused convenience constructor.
2561 Use default code formatting.
2563 2011-07-12 Ben Konrath <ben@bagu.org>
2565 Ignore LayoutItemPortals in the details view.
2567 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2570 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2571 LayoutItemPortal layout objects.
2572 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2573 LayoutItemPortal objects when retrieving the details layout.
2574 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2575 file. This is an empty class and just used to get type information for
2578 2011-07-12 Ben Konrath <ben@bagu.org>
2580 Use java-libglom 1.17.0.
2584 2011-07-11 Ben Konrath <ben@bagu.org>
2586 Remove "Table:" label from table selector.
2588 This matches a recent change in the Glom UI.
2590 * mockups/details-contacts.html:
2591 * mockups/details-projects.html:
2592 * mockups/listview-contacts.html:
2593 * mockups/listview-projects.html: Remove the "Table:" label from the
2595 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2597 2011-07-11 Ben Konrath <ben@bagu.org>
2599 Add main groups to the details view.
2601 This makes things look a little nicer in the details view. The next step
2602 is to implement the flowtable.
2604 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2605 resources from the standard gwt css theme. Standard.css is now
2606 included in OnlineGlom.html so that the online glom css rules have
2607 precedence over the gwt theme.
2608 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2609 the whole LayoutGroup to the DetailsView instead of just the titles.
2610 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2611 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2612 details layout with a helper class (GroupPanel). I might extract this
2613 class when I make the full flowtable.
2614 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2615 string as default so I don't have to worry about NPEs when processing
2617 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2618 note beside OnlineGlom.gwt.xml above).
2619 * src/main/webapp/style.css: Add default font-size to body to override
2620 the font-size set by the standard theme. Don't use h2 tags for
2621 group-title. Create new details-cell class.
2623 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2625 ConfiguredDocument: Set the port number too.
2627 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2628 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2629 Glom document. Presumably this worked sometimes so far because there is a
2630 default port number.
2632 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2634 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2636 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2637 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2638 correct, though we should throw an exception too.
2640 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2642 Fix a addDocuemnt typo.
2644 * src/main/java/org/glom/web/shared/Documents.java
2645 (Documents.addDocuemnt): Rename to addDocument().
2646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2647 (OnlineGlomServiceImpl.getDocuments): Adapt.
2649 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2651 Slightly improved log output when connection fails.
2653 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2654 (ConfiguredDocument.setUsernameAndPassword):
2655 We don't know for sure if it' the username/password that's wrong, so
2656 rephrase the message.
2657 Also ouput the exception message, though it's generic in this case.
2659 2011-07-08 Ben Konrath <ben@bagu.org>
2663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2664 added braces to a one line if statement because the Eclipse formatter
2665 was getting confused.
2667 2011-07-07 Ben Konrath <ben@bagu.org>
2669 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2671 These should really be two separate tasks but I counldn't get things to
2672 work with GWT 2.2.0 and Eclipse 3.7.
2676 * .settings/org.eclipse.jdt.core.prefs:
2677 * .settings/org.eclipse.jdt.ui.prefs:
2678 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2679 * .settings/org.eclipse.m2e.core.prefs:
2680 Add new config files. Update current files. Remove references to the
2681 webtools plugins as we're not using any of the webtools features.
2682 * .gitignore: Add logs directory which is created when running with
2684 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2685 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2686 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2688 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2690 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2692 onlineglom.properties: Add explanatory comments.
2694 * src/main/resources/onlineglom.properties: Also change the default user
2695 from ben to someuser, to avoid the risk of people thinking we just
2696 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2698 2011-06-28 Ben Konrath <ben@bagu.org>
2700 Use filename in Log for incorrect passwords.
2702 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2703 getFileName(String) method to get the filename from the URI.
2705 2011-06-28 Ben Konrath <ben@bagu.org>
2707 Add the table name to the URL token for the ListPlace.
2709 This makes things consistent between the DetailsPlace and the
2710 ListPlace. It also allows the the ListPlace to be bookmarked.
2712 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2713 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2715 Remove getDefaultListLayout(). The default layout is now returned
2716 by the getListLayout() method when the table name is an empty string.
2717 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2718 Add table name field. Change to a new ListPlace when the table
2719 has been changed. Use getListLayout() for getting the default
2721 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2722 Add table name field. Set the correct table name in the list box
2723 when loading from bookmark. This corrects a problem for the
2725 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2726 Move table name to super-class (HasSelectableTable). Move document
2727 and table URL keys to super-class in HasSelectableTable.
2728 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2729 Add table name field. Add Tokenizer class with URL key common to
2730 the subclasses (DetailsPlace and ListPlace).
2731 * src/main/java/org/glom/web/client/place/ListPlace.java:
2732 Add table name. Add code to parse the URL token.
2733 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2734 Update ListPlace construction with empty table name string.
2735 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2736 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2737 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2738 Update ListPlace construction with table name string.
2739 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2740 Change defaultTableName field to tableName to reflect how it's now
2741 used. Update the getter and setter methods.
2743 2011-06-28 Ben Konrath <ben@bagu.org>
2745 Enable the table selector in the DetailsView.
2747 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2748 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2749 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2750 Remove getDefaultDetailsLayout(). The default layout is now returned
2751 by the getDetailsLayout() method when the table name is an empty
2753 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2754 event handler for table change event. Change to using
2755 getDetailsLayout() for the default details layout.
2756 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2758 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2759 when navigating to the details place.
2761 2011-06-27 Ben Konrath <ben@bagu.org>
2763 Use filename based unique document ID in URL and for RPC.
2765 The document ID is the glom document name with spaces (' ') replaced
2766 with pluses ('+') and without the .glom extension.
2768 This change is mostly a string substitution of 'documentTitle' for
2769 'documentID'. The only code change is the addition of a Documents DTO to get the
2770 filename to document title mappings as indicated below.
2772 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2773 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2775 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2776 Use Documents DTO to create the document links in the document
2778 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2779 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2780 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2781 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2782 * src/main/java/org/glom/web/client/place/ListPlace.java:
2783 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2784 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2785 * src/main/java/org/glom/web/client/ui/ListView.java:
2786 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2787 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2788 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2789 * src/main/java/org/glom/web/server/Log.java:
2790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2791 getDocumentTitles() to getDocuments() and return the Documents DTO.
2792 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2793 transferring the filename to document title mappings.
2795 2011-06-25 Ben Konrath <ben@bagu.org>
2797 Make the authentication popup work again.
2799 This bug was introduced when I extracted ConfiguredDocument to its own class.
2801 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2802 correct success / fail status in setUsernameAndPassword().
2804 2011-06-25 Ben Konrath <ben@bagu.org>
2806 Use filename as unique key for configuring database usernames and passwords.
2808 This replaces the use of the Glom document title which could change
2809 depending on the locale. Thanks to Murray Cumming for pointing out this
2812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2813 * src/main/resources/onlineglom.properties:
2815 2011-06-24 Ben Konrath <ben@bagu.org>
2817 Pass primary key value to DetailsView.
2819 This enables the DetailsView to load the correct data.
2821 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2822 primary key value field and set in constructor. Pass primary key
2823 value to getDetailsData().
2824 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2825 variables for document title and primary key value.
2826 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2827 key value to the DetailsPlace.
2829 2011-06-24 Ben Konrath <ben@bagu.org>
2831 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2833 This allows the primary key to be retrieved by the Details button. This
2834 functionality has not been implemented yet but it's in the works.
2836 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2837 the LayoutGroup result to ListView.setCellTable instead of all of its
2838 fields individually.
2839 * src/main/java/org/glom/web/client/ui/ListView.java:
2840 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2841 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2842 get the primary key for the table.
2843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2844 index of the primary key in the LayoutGroup accounting for hidden
2845 primary keys. Rename getJavaNumberFormat() to
2846 convertToJavaNumberFormat() for consistency. Cleanup / add some
2848 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2849 field for primary key index and a field to indicate whether the
2850 primary key is hidden or not.
2852 2011-06-23 Ben Konrath <ben@bagu.org>
2854 Rename getTableData methods to getListData.
2856 This is a rename refactor for consistency with other methods.
2858 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2859 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2860 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2863 2011-06-23 Ben Konrath <ben@bagu.org>
2865 Extract the ConfiguredDocument innerclass into its own class.
2867 This makes the servlet code more object oriented.
2869 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2870 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2871 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2872 new ConfiguredDocument class.
2874 2011-06-21 Ben Konrath <ben@bagu.org>
2876 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2878 This makes things more inline with how libglom works and reduces code
2879 duplication. This refactor lays the groundwork for adding the primary key to
2880 the LayoutGroup object.
2882 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2883 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2885 Change method names to getListLayout and getDefaultListLayout for
2886 consistency. Use LayoutGroup as the DTO for the list layout instead of
2887 ColumnInfo and LayoutListTable.
2888 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2889 new method names along with the LayoutGroup object for transferring the
2891 * src/main/java/org/glom/web/client/ui/ListView.java:
2892 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2893 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2894 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2896 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2897 Replaced with LayoutGroup.
2898 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2899 expectedResultSize and defaultTableName fields which are needed for
2901 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2902 type field which is needed for the list layout but will also be
2903 useful for the details layout as things progress.
2904 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2905 Make class abstract. Remove the unnecessary
2906 getFormattingHorizontalAlignment method. Add setFormatting method.
2908 2011-06-16 Ben Konrath <ben@bagu.org>
2910 Add scripts for building and installing war.
2912 These will help when updating OnlineGlom but they're also good
2913 supplemental documentation of the build and deployment proceeding.
2915 * utils/build-onlineglom-war.sh: New file.
2916 * utils/install-onlineglom-war.sh: New file.
2918 2011-06-16 Ben Konrath <ben@bagu.org>
2920 Create wrapper class to create consistent log messages.
2922 I wrapped methods in the Log class of gwt-log to add the method names
2923 from the servlet and create consistent formatting of the document title
2924 and table names in the log messages.
2926 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2928 log methods to use methods from wrapped Log class.
2930 2011-06-16 Ben Konrath <ben@bagu.org>
2932 Remove superfluous conditional return.
2934 Thanks to Murray Cumming for pointing this out!
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2938 2011-06-15 Ben Konrath <ben@bagu.org>
2940 Return an ArrayList of LayoutGroups for the Details layout.
2942 This corrects a problem with the details layout as it can have more
2943 than one top level LayoutGroup.
2945 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2946 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2947 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2948 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2949 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2950 with ArrayList of LayoutGroups for the details view layout.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2952 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2953 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2954 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2955 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2956 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2958 2011-06-14 Ben Konrath <ben@bagu.org>
2960 Use cast_dynamic method to determine the libglom LayoutItem type.
2962 This is better than finding the LayoutItem type by using the string
2963 returned from the get_part_type_name() method.
2965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2967 2011-06-14 Ben Konrath <ben@bagu.org>
2969 Add method names to log entries in the servlet.
2971 This helps when tracking down deployment problems.
2973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2975 2011-06-14 Ben Konrath <ben@bagu.org>
2977 Add data to the DetailsView using a hard-coded primary key value.
2979 The layout and functionality of the DetailsView is not complete. This
2980 is just a checkpoint so the patch doesn't get too big.
2982 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2983 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2984 Add getDetailsData() servlet method.
2985 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2986 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2987 LayoutFields are added to the DetailsView.
2988 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2989 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2990 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2991 take the string for the title instead of the object.
2992 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2993 Add implementation getDetailsData() along with some private helper
2995 * src/main/webapp/style.css: Add padding to details-data class. Add a
2996 details-label class with the same padding as the details-data class.
2998 2011-06-03 Ben Konrath <ben@bagu.org>
3000 Use presenter.goTo() to change to the DetailsPlace.
3002 This will make things easier when we need to open the DetailsView with
3003 data specific to the row that was clicked.
3005 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3007 2011-06-02 Ben Konrath <ben@bagu.org>
3009 Add CSS file from mockups.
3011 I'm adding this now because it's going to be useful to have when
3012 developing the DetailsView. The TableSelectionView and ListView aren't
3015 * src/main/webapp/OnlineGlom.html:
3016 * src/main/webapp/style.css:
3018 2011-06-02 Ben Konrath <ben@bagu.org>
3020 Use String.isEmpty() to check for empty string.
3022 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3024 2011-06-02 Ben Konrath <ben@bagu.org>
3026 Display main layout group titles in the DetailsView.
3028 This is the start of the DetailsActivity/DetailsView implementation.
3030 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3031 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3032 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3034 Get the layout information for the details view from the server and set
3035 the main layout group titles.
3036 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3037 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3038 Add addLayoutGroup() and addLayoutField() methods. This are just
3039 temporary methods for creating the the details view that will change
3041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3042 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3044 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3045 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3046 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3047 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3048 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3049 Data Transfer Objects that mimic the libglom object structure. These are
3050 used for transferring the details layout but could also be used for
3051 transferring the list layout.
3053 2011-05-27 Ben Konrath <ben@bagu.org>
3055 Reset the AuthenticationPopup when clearing the ListView.
3057 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3059 2011-05-27 Ben Konrath <ben@bagu.org>
3061 Fix problem with onlineglom.properties file loading.
3063 The old way worked in Eclipse but not on the server. Loading the
3064 onlineglom.properties file now works in Eclipse and on the server.
3066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3068 2011-05-24 Ben Konrath <ben@bagu.org>
3070 Update gwt-log from 3.1.0 to 3.1.2.
3072 Gwt-log 3.1.0 has been marked as depreciated.
3076 2011-05-24 Ben Konrath <ben@bagu.org>
3078 Add comment to ListActivity.goTo() method.
3080 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3082 2011-05-24 Ben Konrath <ben@bagu.org>
3084 Remove FIXME in convertGdkColorToHtmlColour()
3086 The Gdk::Color value returned by libglom is 16-bits per channel on both
3087 64 and 32-bit platforms.
3089 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3091 2011-05-19 Ben Konrath <ben@bagu.org>
3093 Improve performance of initial ListView load.
3095 I removed a round trip to the server for getting the default table name
3096 and then requesting information about that table. This also removes a potential
3097 problem with the table change handler not being setup in time to receive the
3098 table change event from the ListActivity.
3100 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3101 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3102 getDefaultLayoutListTable() method. Improve comments.
3103 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3104 getDefaultLayoutListTable() method instead of firing a table change
3105 event to get the table to load.
3106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3107 implementation of getDefaultLayoutListTable() method.
3108 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3111 2011-05-19 Ben Konrath <ben@bagu.org>
3113 Override toDebugString() in TableChangeEvent.
3115 This is useful to have for debugging.
3117 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3119 2011-05-19 Ben Konrath <ben@bagu.org>
3121 Add a "Back to List" link when at the DetailsPlace.
3123 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3124 Populate the CellTable based on the selected table of the ListBox if
3125 it's set otherwise use the default table. This allows the "Back to
3127 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3128 Remove Place from constructors. Add a setPlace() method. Add
3129 goToPlace() method. Set class as presenter for TableSelectionView.
3130 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3131 Use the same TableSelectionActivity when switching between the List and
3133 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3134 Subclass the new HasSelectableTablePlace. This removes some duplicate
3136 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3137 New class to represent Places that display the TableSelectionView.
3138 * src/main/java/org/glom/web/client/place/ListPlace.java:
3139 Subclass the new HasSelectableTablePlace. This removes some duplicate
3141 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3142 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3143 Add Presenter interface. Add setBackLinkVisible() method. Add
3144 setBackLink() method.
3146 2011-05-18 Ben Konrath <ben@bagu.org>
3148 Enable the "Details" buttons.
3150 Right now only an empty details view is displayed.
3152 * src/main/java/org/glom/web/client/ClientFactory.java:
3153 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3154 Add DetailsView to ClientFactory.
3155 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3156 A basic activity for the details view.
3157 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3158 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3160 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3161 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3163 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3164 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3165 unnecessary super() in constructor.
3166 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3167 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3168 really shouldn't create a new TableSelectionActivity for both the ListPlace
3169 and the DetailsPlace so this should be considered a temporary solution.
3170 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3171 New file. Represents a URL for the details view.
3172 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3173 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3174 A basic details view interface and implementation.
3175 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3176 Enable the "Details" buttons.
3178 2011-05-12 Ben Konrath <ben@bagu.org>
3180 Use a LayoutPanel with multiple display areas for main layout.
3182 This is mostly a refactor in that there are no changes from the user
3183 point of view. These changes are required so that we can swap out the list view
3184 with the details view when the user clicks the "Details" button.
3186 * src/main/java/org/glom/web/client/ClientFactory.java:
3187 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3188 OnlineGlomView. Add TableSelectionView, ListView and
3189 AuthenticationPopup.
3190 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3191 for main layout. Add display regions for main activities. Add
3192 activity manager for for main activities.
3193 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3194 file from parts of the deleted OnlineGlomActivity.
3195 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3196 New file from parts of the deleted OnlineGlomActivity.
3197 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3198 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3199 New files for app wide table change event.
3200 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3201 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3202 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3203 Activity mappers for the main activities replace the deleted app-wide
3205 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3206 Fix a spelling error in he comment.
3207 * src/main/java/org/glom/web/client/ui/ListView.java:
3208 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3209 Renamed from LayoutListView and modified for MVP. This still not a
3210 proper dumb view as prescribed by the MVP pattern but it works for now.
3211 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3212 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3213 New widget stripped out of the deleted OnlineGlomView.
3214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3215 Remove hack that is fixed by this patch.
3217 2011-05-06 Ben Konrath <ben@bagu.org>
3219 Rename OnlineGlomPlace to ListPlace.
3221 The only change besides the rename is that url will now display #list
3222 instead of #Document.
3224 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3225 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3226 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3227 * src/main/java/org/glom/web/client/place/ListPlace.java:
3228 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3230 2011-05-06 Ben Konrath <ben@bagu.org>
3232 Use Presenter for app navigation.
projects / online-glom:gwt-glom.git / blob