1 2012-11-13 Murray Cumming <murrayc@murrayc.com>
3 Document: Load static text and image items too.
5 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
6 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
7 New LayoutItem classes to represent these layout items.
8 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
9 main text of a LayoutItemText.
10 * src/main/java/org/glom/web/server/libglom/Document.java:
11 load_after_layout_group(): Handle the node types and instantiate the
13 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
14 Add testLayoutItemText() to check that the text is loaded properly.
16 2012-11-13 Murray Cumming <murrayc@murrayc.com>
18 Do not use client.GWT for shared code.
20 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
21 Import shared.GWT instead of client.GWT, which seems to be appropriate.
23 2012-11-12 Murray Cumming <murrayc@murrayc.com>
25 Use image data when recreating databases for testing.
27 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
28 for use locally (not acrosss the network) when recreating databases
30 getValue(): Use it here instead of getImageDataUrl(), noting that
31 this method is only for use when recreating databases.
32 * src/main/java/org/glom/web/server/libglom/Document.java:
33 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
35 2012-11-09 Murray Cumming <murrayc@murrayc.com>
37 OnlineGlomImages: Detect the mime-type (content type).
39 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
40 doGet(): Instead of hard-coding image/png.
42 2012-11-09 Murray Cumming <murrayc@murrayc.com>
44 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
47 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
48 Java Compiler and Java Build path settings in the UI.
50 2012-11-09 Murray Cumming <murrayc@murrayc.com>
52 Use the latest (now stable) version of GWT.
54 * pom.xml: And the latest version of the gwt-maven-plugin.
56 2012-11-08 Murray Cumming <murrayc@murrayc.com>
58 Added an Indonesian translation.
60 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
61 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
62 This is from the new translation in Glom.
64 2012-07-23 Murray Cumming <murrayc@murrayc.com>
68 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
70 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
72 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
73 for serving image data.
74 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
76 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
77 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
78 setData(): For image field types, add a GWT Image widget,
79 with the URL that was set in the DataItem.
81 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
82 * src/main/java/org/glom/web/server/database/DBAccess.java:
83 convertResultSetToDTO(): Set the URL for image data, so the client browser
84 can retrieve the image from our new servlet. This uses UriBuilder.
85 Move getPrimaryKeyField to:
86 * src/main/java/org/glom/web/server/libglom/Document.java:
87 Added getTablePrimaryKeyField().
89 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
90 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
91 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
94 2012-07-22 Murray Cumming <murrayc@murrayc.com>
98 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
99 * src/main/java/org/glom/web/client/OnlineGlomService.java:
100 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
101 to gwtGlom, which is more appropriate.
102 This servlet name does not seem to be visible to the client side anyway.
104 2012-07-22 Murray Cumming <murrayc@murrayc.com>
106 Tests: Make the imports of assert*() consistent.
108 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
109 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
110 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
111 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
112 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
113 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
114 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
115 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
116 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
117 * src/test/java/org/glom/web/shared/DataItemTest.java:
119 import static org.junit.Assert.*;
120 which seems fairly common.
124 2012-07-21 Murray Cumming <murrayc@murrayc.com>
126 tests: Move a test that needs a database connection.
128 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
129 Move testGetListViewLayoutGroup() to
130 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
131 because it needs a database connection.
133 2012-07-21 Murray Cumming <murrayc@murrayc.com>
135 tests: Use @BeforeClass on tearDown().
137 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
138 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
139 This avoids leaking a postgres process in SelfHostExampleTest.
141 2012-07-21 Murray Cumming <murrayc@murrayc.com>
143 tests: Test translations more.
145 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
146 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
147 Test titles in the non-default locale.
149 2012-07-21 Murray Cumming <murrayc@murrayc.com>
151 tests: Add SelfHostConfiguredDocumentTest
153 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
154 username and password, for use by ConfiguredDocument.
155 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
156 This tests some of the ConfiguredDocument API that requires a database connection.
158 2012-07-21 Murray Cumming <murrayc@murrayc.com>
160 Document: Load title translations and test them.
162 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
163 of titles. I am surprised that we do not do this yet.
164 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
165 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
166 Test translations more.
168 2012-07-20 Murray Cumming <murrayc@murrayc.com>
172 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
173 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
174 Set the timeout here too.
176 2012-07-20 Murray Cumming <murrayc@murrayc.com>
178 tests: ConfiguredDocumentTest: Make this pass.
180 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
181 Disable tests that need a database connection.
183 2012-07-20 Murray Cumming <murrayc@murrayc.com>
185 Use Java 1.7 instead of Java 1.6.
187 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
188 to do this twice, at least for Eclipse.
189 This seems OK because it is the current version.
191 2012-07-20 Murray Cumming <murrayc@murrayc.com>
195 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
196 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
197 Avoid using a null Connection.
199 2012-07-20 Murray Cumming <murrayc@murrayc.com>
201 tests: Add a ConfiguredDocument test.
203 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
206 2012-07-20 Murray Cumming <murrayc@murrayc.com>
208 LayoutItemFIeld: getName(): Use the Field if it is set.
210 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
211 getName(): If the full field details have been set, return its name, so that
212 callers do not need to set the name separately.
213 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
214 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
215 so we can count the rows.
217 2012-07-20 Murray Cumming <murrayc@murrayc.com>
219 tests: SelfHoster: Test SqlUtils too.
221 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
222 Retrieve some data and check it too, as in the regular Glom
223 test_selfhosting_new_from_example.cc test.
224 * src/test/java/org/glom/web/server/SelfHoster.java:
225 createConnection(): Make this public.
227 2012-07-20 Murray Cumming <murrayc@murrayc.com>
229 tests: SelfHoster: createConnection(): Do not warn about expected failures.
231 Let the caller say if the connection is expected to fail, to avoid
232 irrelevant error output.
234 2012-07-20 Murray Cumming <murrayc@murrayc.com>
236 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
238 * src/test/java/org/glom/web/server/SelfHoster.java:
239 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
240 due to the inevitable need to retry the connection while the database server
243 2012-07-20 Murray Cumming <murrayc@murray.com>
245 tests: SelfHoster: createConnection(): Set a timeout.
247 * src/test/java/org/glom/web/server/SelfHoster.java:
248 createConnection(): Use setLoginTimeout() because it otherwise seems to take
249 ages to actually return when it fails.
251 2012-07-20 Murray Cumming <murrayc@murrayc.com>
253 tests: SelfHoster: selfHost(): Close the test connection.
255 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
256 When we check that the connection works, close the connection. This seems
257 to not be closed automatically otherwise.
259 2012-07-20 Murray Cumming <murrayc@murrayc.com>
261 Use slf4j-simple to see JDBC errors.
263 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
265 2012-07-19 Murray Cumming <murrayc@murrayc.com>
267 SelfHoster.discoverFirstFreePort(): Close the socket.
269 * src/test/java/org/glom/web/server/SelfHoster.java:
270 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
272 2012-07-19 Murray Cumming <murrayc@murrayc.com>
274 Avoid another code warning in Eclipse Juno.
276 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
277 Do instanceof checks on the FileUtils.listFiles() result and its
280 2012-07-13 Murray Cumming <murrayc@murrayc.com>
282 Avoid some code warnings in Eclipse Juno
284 * src/main/java/org/glom/web/server/libglom/Document.java:
285 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
286 * src/test/java/org/glom/web/server/SelfHoster.java
287 createTextFile(): Make sure that the FileOutputStream is closed.
289 2012-06-22 Murray Cumming <murrayc@murrayc.com>
291 Added OnlineGlomPropertiesTest.
293 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
294 Make sure we never return a null string.
295 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
296 Added tests of the OnlineGlomProperties API, using our sample file.
298 2012-06-20 Murray Cumming <murrayc@murrayc.com>
300 Make OnlineGlomProperties be a normal class.
302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
303 Move OnlineGlomProperties into its own file to be a regular class:
304 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
305 This makes testing simpler.
307 2012-06-15 Murray Cumming <murrayc@murrayc.com>
309 OnlineGlomServiceImpl.init(): Move some code into a new method.
311 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
312 Create addDocument().
314 2012-06-15 Murray Cumming <murrayc@murrayc.com>
316 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
319 OnlineGlomProperties.getKey(): Make this more robust by moving the
320 check for *.*.filename to here.
322 2012-06-15 Murray Cumming <murrayc@murrayc.com>
324 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
327 init(): Move knowledge of the config file format into the
328 OnlineGlomProperties inner class.
330 2012-06-15 Murray Cumming <murrayc@murrayc.com>
332 SelfHostExampleTest: Make sure we cleanup on failure.
334 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
335 the use of cleanup() to a tearDown() JUnit method.
339 2012-06-12 Murray Cumming <murrayc@murrayc.com>
341 ConfiguredDocument: Add a primary key to portals at least once.
343 * src/main/java/org/glom/web/server/ConfiguredDocument.java
344 updatePortalsExtras): Fix a typo so that we add the primary key
345 column at least once.
346 This is a fix for the previous commit:
347 ConfiguredDocument: Do not add a primary key to portals each time.
349 2012-06-08 Murray Cumming <murrayc@murrayc.com>
351 SelfHoster: Avoid some compiler warnings.
353 * src/test/java/org/glom/web/server/SelfHoster.java
354 executeCommandLineAndWait():
355 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
356 the now-unused streams for stdout and stderr from the command Processes.
357 These are not used because readln() hangs while waiting for a new line,
358 where there may be no next line. The commented out code is still there
359 to help us figure out how to do this properly.
361 2012-06-08 Murray Cumming <murrayc@murrayc.com>
363 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
365 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
366 Make this actually test the cloning again, though it is not very useful
367 now that we do not use the part that had a problem with cloning before.
369 2012-06-08 Murray Cumming <murrayc@murrayc.com>
371 SelfHoster: Keep trying pg_ctl after starting postgres.
373 * src/test/java/org/glom/web/server/SelfHoster.java
374 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
375 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
376 regular Glom. This seems mad but it seems to work because the first
377 command would fail if pg_ctl would eventually fail.
379 2012-06-08 Murray Cumming <murrayc@murrayc.com>
381 SelfHoster: Wait until the server is really ready.
383 * src/test/java/org/glom/web/server/SelfHoster.java
384 selfHost(): Attempt the connection after starting the server, retrying
385 a few times if necessary, so that the server is really ready already when
386 we return from this method.
387 The regular Glom code does this too because pg_ctl reports success too soon.
389 2012-06-08 Murray Cumming <murrayc@murrayc.com>
391 ConfiguredDocument: Do not add a primary key to portals each time.
393 * src/main/java/org/glom/web/server/ConfiguredDocument.java
394 updatePortalsExtras(): Only add an extra primary key field if there is
395 none, to avoid adding one each time we retrieve the details layout from the
397 This should fix bug #676986 (Ben Konrath)
399 2012-05-25 Murray Cumming <murrayc@murrayc.com>
401 Document.load(): Support version 7 documents.
403 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
404 database_title attribute if the title attribute is not there.
407 2012-05-24 Ben Konrath <ben@bagu.org>
409 Add configuration for auto-generating mvn:i18n from with Eclipse.
411 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
413 2012-05-24 Murray Cumming <murrayc@murrayc.com>
415 Update translations, adding French.
417 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
418 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
419 Add a French translation, using the translation from Glom.
421 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
422 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
423 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
424 Update these based on the translations from Glom.
426 2012-05-24 Murray Cumming <murrayc@murrayc.com>
428 SelfHoster: Add some debug println messages to help when things fail.
430 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
431 System.out.println() lines.
433 2012-05-23 Murray Cumming <murrayc@murrayc.com>
435 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
437 * src/test/java/org/glom/web/server/SelfHoster.java:
438 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
439 instance) instead of just /usr/bin (as on Fedora). Check the result when
442 2012-05-23 Murray Cumming <murrayc@murrayc.com>
444 Remove LayoutItemPortal.get/setNavigationTable().
446 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
447 Remove get/setNavigationTable(), which is only a cache, because it is not
448 used, and does not need to be used, because that decision should be made on
450 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
451 updatePortalsExtras():
452 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
453 getNavigationRecord():
454 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
457 2012-05-21 Murray Cumming <murrayc@murrayc.com>
459 Initial self-hosting for tests.
461 * pom.xml: Change the scope for log4j, to hopefully make it
462 available to the test code which uses it indirectly via jOOQ.
463 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
464 self-hosting, though we only use it for testing.
466 * src/main/java/org/glom/web/server/libglom/Document.java:
467 example rows: Use a map instead of a list for each row of values,
468 so we know what field they are for, instead of relying on the sequence
469 being correct. This is not very efficient, but it does not really need
471 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
472 testReadTableExampleRows(): Adapted.
474 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
475 that returns an Object, for generic use. Note that Object seems to be
476 the implicit base even of double.
477 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
478 for use in CREATE TABLE SQL queries.
479 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
480 to do self-hosting of PostgreSQL databases via its command-line
481 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
482 backends/postgres_self.cc. This is incomplete - it needs more
483 warnings about failures and it needs to clean up properly when things
485 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
486 test of this new class.
488 2012-05-21 Murray Cumming <murrayc@murrayc.com>
490 Document: loading example data: Handle exceptions.
492 * src/main/java/org/glom/web/server/libglom/Document.java:
493 DateFormat.parse() and Double.valueOf() can throw exceptions, though
494 Eclipse did not warn about that.
496 2012-05-20 Murray Cumming <murrayc@murrayc.com>
498 Document: load(), save(): Handle the example rows.
500 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
502 * src/main/java/org/glom/web/server/libglom/Document.java:
503 load(), save(): Load and save the example rows, though the date, time
504 and image types are not handled properly yet.
505 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
506 Add testReadTableExampleRows() just to check that something is read.
508 2012-05-20 Murray Cumming <murrayc@murrayc.com>
510 Document: Add save().
512 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
513 Added getTranslationsMap() for use while saving.
514 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
515 Adedd getUseDefaultFormatting() for use while saving.
516 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
517 and several private methods that it uses.
519 This will be useful while testing via self-hosting.
520 It is not complete, but should be complete enough for testing.
522 2012-05-17 Murray Cumming <murrayc@murrayc.com>
524 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
526 * src/main/java/org/glom/web/client/OnlineGlomService.java
527 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
528 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
529 Remove getSortedListViewData() and getSortedRelatedListData(), adding
530 the sort column index and ascending bool to the regular method.
531 Instead, a sort column index of -1 now means no sort.
532 This is less explicit, but it's fairly simple, reduces the amount of
533 code, and makes the OnlineGlomService API slightly smaller.
534 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
535 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
537 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
538 getListViewData(), getRelatedListData():
539 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
540 getListViewData(), getRelatedListData():
541 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
543 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
545 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
550 2012-05-16 Murray Cumming <murrayc@murrayc.com>
552 Use translations for top-level groups too.
554 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
555 updateTitlesForLocale(): Use the translation for the group
556 as well as for child items.
560 Just recompiled to fix a problem in the released .tar.gz file.
564 2012-05-15 Murray Cumming <murrayc@murrayc.com>
566 Corrections to navigation to related records.
568 * src/main/java/org/glom/web/client/OnlineGlomService.java:
569 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
571 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
572 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
573 relationship name, because the relationship name is not necessarily unique
575 TOOD: This is inefficient, because it passes the whole list of
576 child field items back to the server, but it is more correct, and happens
577 to fix a bug with the primary key being lost after a few navigations.
578 There is probably a chance to make this more efficient anyway in some
581 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
582 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
583 * src/main/java/org/glom/web/server/ConfiguredDocument.java
584 * src/main/java/org/glom/web/server/database/DBAccess.java
585 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
586 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
589 2012-05-15 Murray Cumming <murrayc@murrayc.com>
591 Fix the use of translations.
593 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
594 Add updateTitlesForLocale().
595 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
596 Call it to discard unwanted translations and to make getTitle() return
597 the wanted translation wihout the need for the client code to specify a locale.
598 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
599 getTitle(): Fallback to the original title, as libglom does.
601 2012-05-15 Murray Cumming <murrayc@murrayc.com>
603 Document: Correctly report the number of available translation locales.
605 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
606 the available locale IDs list.
607 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
608 testLocales: Test this.
610 2012-05-15 Murray Cumming <murrayc@murrayc.com>
612 SqlUtils: Use camelCase.
614 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
615 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
616 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
617 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
618 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
619 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
621 2012-05-15 Murray Cumming <murrayc@murrayc.com>
623 Use jOOQ's tableByName() and fieldByName.
625 * pom.xml: Use jOOQ 2.3.1 to get the new API.
626 * src/main/java/org/glom/web/server/SqlUtils.java:
627 build_sql_select_step_with_where_clause(), .createField(),
628 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
629 so we can get correct quoting and escaping. Thanks to Lukas Eder for
630 adding this, and other things, to jOOQ.
632 2012-05-15 Murray Cumming <murrayc@murrayc.com>
634 SqlUtils: Remove the Connection parameters.
636 * src/main/java/org/glom/web/server/SqlUtils.java:
637 build_sql_select_with_key(), build_sql_select_with_where_clause(),
638 createSelect(), build_sql_select_step_with_where_clause(),
639 build_sql_count_select_with_where_clause(),
640 build_sql_select_count_rows(): Remove the Connection parameter because
641 jOOQ does not actually need a connectionwhen it is just used to build
643 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
645 * src/main/java/org/glom/web/server/ReportGenerator.java:
647 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
649 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
650 Constructor, getListData(), getResultSizeOfSQLQuery():
651 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
652 getSelectQuery(), getCountQuery():
653 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
654 getSelectQuery(), getCountQuery():
655 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
656 getNavigationRecord(): Adapted.
658 2012-05-14 Murray Cumming <murrayc@murrayc.com>
662 * src/main/java/org/glom/web/server/SqlUtils.java:
663 get_find_where_clause_quick(): Use a comparison of
664 lowercase values, instead of a simple equals. Regular Glom
665 uses the PostgreSQL ILIKE operator but jOOQ does not
666 support that just yet, though it will soon.
668 2012-05-14 Murray Cumming <murrayc@murrayc.com>
670 TableToViewDetails: Use a real serialization ID.
672 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
673 Though this does not fix the serialization problem.
675 2012-05-12 Murray Cumming <murrayc@murrayc.com>
677 Added LayoutItemPortalDeepCloneTest.
679 2012-05-11 Murray Cumming <murrayc@murrayc.com>
681 Make navigation work again.
683 * src/main/java/org/glom/web/server/libglom/Document.java:
684 Add getLayoutItemFieldShouldHaveNavigation().
685 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
686 Replace get/setAddNavigation() with the partly-existing
687 get/setNavigationTableName(), with an empty string being no navigation,
688 because this is simpler. Use the new
689 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
691 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
692 Add updateFieldsExtras() and call setNavigationTableName in it.
693 getDetailsLayoutGroup(),
694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
695 createLayout(): Adapted.
696 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
697 Constructor: Adapted.
699 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
700 Replace get/setAddNavigation() with get/setNavigation(), returning a
701 TableToViewDetails class with both the table name and UsesRelationship,
702 because both are need. The previous code used java-libglom's output
703 variable (strangely, via sharedptr) to return both, but we cannot really
705 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
706 getNavigationRecord(): Adapt. However, we cannot actually use the cache
707 here because it somehow gets set to null during deepCopy(). I must test this.
708 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
709 testGetSuitableTableToViewDetails(): Adapted.
711 TODO: Find out why deepClone() is not quite working.
713 2012-05-11 Murray Cumming <murrayc@murrayc.com>
715 DBAccess: Simplify the retrievel of full field details.
717 * src/main/java/org/glom/web/server/database/DBAccess.java
718 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
719 because the Document loading should have done this.
721 2012-05-11 Murray Cumming <murrayc@murrayc.com>
723 Document: Correct loading of doubly-related layout fields.
725 * src/main/java/org/glom/web/server/libglom/Document.java:
726 loadUsesRelationship(): Actually set the related relationship, instead
727 of only setting it if it's not found.
729 2012-05-09 Murray Cumming <murrayc@murrayc.com>
731 Replace all appearances of Colour with color.
733 Because US English is dominant.
735 2012-05-09 Murray Cumming <murrayc@murrayc.com>
737 Use colors in HTML format, solving a warning about an unused function.
739 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
740 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
741 Add *asHTMLColor() versions of methods.
742 TODO: However, we should create and cache the results on the server.
743 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
744 * src/main/java/org/glom/web/client/ui/list/ListTable.java
745 * src/main/java/org/glom/web/server/ConfiguredDocument.java
746 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
747 Use the asHTMLcolor() versions.
749 2012-05-09 Murray Cumming <murrayc@murrayc.com>
751 ListViewTable: Constructor: Take the table name as a parameter.
753 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
754 Constructor: Take the tableName, and set the member variable, because
756 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
757 setCellTable(): Pass the table name.
758 This makes navigation to non-default tables work again. I don't know
759 why it worked before in the master branch.
761 2012-05-07 Murray Cumming <murrayc@murrayc.com>
763 ConfiguredDocument: Restore correct addition of hidden primary key items.
765 * src/main/java/org/glom/web/client/ui/list/ListTable.java
766 (ListTable.createCellTable): Uncomment out the check for the hidden
768 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
769 add primary key items for top-level lists and portals, as before,
770 instead of adding them to each group.
771 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
772 Actually implement the extra methods such as setHiddenPrimaryKey() and
773 comment that these are used only for top-level list groups and in portals.
774 This strangeness suggests even more that this should not be squeezed
775 into the LayoutGroup class.
777 2012-05-07 Murray Cumming <murrayc@murrayc.com>
779 Fix Formatting loading.
781 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
782 getFormattingUsed(): Remove the duplicate Formatting member variable
783 in favour of the one from the base class.
784 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
785 Initialize a new Formatting instead of using null by default, so we
786 have some defaults, instead of having to initialize one later just to
787 get the same defaults. This also makes loading of formatting from the
788 document work, because that expected a non-null.
790 2012-05-07 Murray Cumming <murrayc@murrayc.com>
792 RelatedListTable: Make sure that the tableName is set.
794 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
795 Constructor: Take the tableName so it is available later. Otherwise,
796 the server assumes that we mean the default table and cannot find the
798 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
799 setData(): Pass the tableName to the RelatedListTable constructor.
801 2012-05-07 Murray Cumming <murrayc@murrayc.com>
805 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
806 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
807 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
809 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
811 * src/main/java/org/glom/web/server/database/DBAccess.java:
812 convertResultSetToDTO(), getPortal():
813 * src/main/java/org/glom/web/server/database/ListDBAccess.java
815 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
816 Add checks for null objects and out of range access, with log messages to
817 give hints so we can fix these properly.
819 2012-05-07 Murray Cumming <murrayc@murrayc.com>
821 Portals: some corrections.
823 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
825 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
826 constructor: Use getRelationshipNameUsed() instead of getName(), because
827 that is what is meant.
828 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
829 getFromField(): Fix a typo, to get the field name, not the table name.
830 * src/main/java/org/glom/web/server/database/DBAccess.java:
831 getPortal(): Fix a typo that stopped this from working.
833 2012-05-07 Murray Cumming <murrayc@murrayc.com>
835 LayoutItemPortal: Also override getTitleOriginal().
837 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
838 This lets the base getTitle() with no parameters work.
839 TODO: Test this properly.
841 2012-05-06 Murray Cumming <murrayc@murrayc.com>
843 LayoutItemPortal: getTitle*(): Use the relationship title.
845 2012-05-06 Murray Cumming <murrayc@murrayc.com>
847 LayoutItemField: Fix loading of custom titles.
849 * src/main/java/org/glom/web/server/libglom/Document.java
850 loadDataLayoutItemField(): The title, if any, instead of the field
851 title, is stored in a title_custom node. Load it from there.
852 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
854 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
855 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
856 getTitle*() overrides.
857 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
860 2012-05-06 Murray Cumming <murrayc@murrayc.com>
862 LayoutItemField: Fall back to field titles, so some are really shown.
864 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
865 Override getTitleOriginal() and getTitle(), as in java-libglom.
866 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
869 2012-05-06 Murray Cumming <murrayc@murrayc.com>
871 Correct use of setExpectedResultSize().
873 * src/main/java/org/glom/web/server/ConfiguredDocument.java
874 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
875 Use setExpectedResultSize only on top-level groups (for instance, the
876 list layout) or on child portals (in details views).
877 Use the correct table name for portals to avoid SQL errors.
878 Update the expected counts when returning cached layouts.
880 2012-05-06 Murray Cumming <murrayc@murrayc.com>
882 Document: Interpret no group column count as 1.
884 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
885 default, though we now check for this in the UI code anyway.
887 2012-05-06 Murray Cumming <murrayc@murrayc.com>
891 2012-05-06 Murray Cumming <murrayc@murrayc.com>
893 Translatable: Use Hashmap instead of Treemap because GWT supports it.
895 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
896 The use of Treemap lead to this error from async methods, with no
898 "The response could not be deserialized"
900 2012-05-06 Murray Cumming <murrayc@murrayc.com>
902 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
904 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
905 when using the Google -> GWT Compile, or
906 g toolbar button -> GWT Compile Project... feature in Eclipse.
908 2012-05-06 Murray Cumming <murrayc@murrayc.com>
910 ListTable.addColumn(): Protect against a null Formatting.
912 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
913 Create a default Formatting if it is null, because that is the simplest
916 2012-05-06 Murray Cumming <murrayc@murrayc.com>
918 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
920 * src/main/java/org/glom/web/server/ConfiguredDocument.java
921 updateLayoutGroup(): Check that the field is not null.
923 2012-05-06 Murray Cumming <murrayc@murrayc.com>
925 ListViewImpl: Protected against a bad cast error.
927 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
928 onEnterKeyDown(): Do not cast without an instanceof check.
930 2012-05-06 Murray Cumming <murrayc@murrayc.com>
932 ListTable: Protect against an out of range error.
934 * src/main/java/org/glom/web/client/ui/list/ListTable.java
935 createCellTable(): This is unlikely, but can happen while debugging.
937 2012-05-06 Murray Cumming <murrayc@murrayc.com>
939 AsyncMessage onFailure() callbacks: Log the exception message.
941 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
942 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
943 * src/main/java/org/glom/web/client/activity/ListActivity.java:
944 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
945 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
946 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
947 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
948 These are useful clues when something is wrong.
950 2012-05-06 Murray Cumming <murrayc@murrayc.com>
952 ConfiguredDocument: Avoid a null dereference.
954 * src/main/java/org/glom/web/server/ConfiguredDocument.java
955 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
956 details maps are created.
958 2012-05-06 Murray Cumming <murrayc@murrayc.com>
960 Document: Correct the port number parsing.
962 * src/main/java/org/glom/web/server/libglom/Document.java:
963 This lets us actually connect to the database and show the document.
965 2012-05-05 Murray Cumming <murrayc@murrayc.com>
969 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
970 user-interaction, asking us to load a temporary URL in a browser.s
971 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
972 which is apparently necessary for testing the service. See the comment.
973 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
974 Show the exception, if any. This is how I saw the 404 in the HTML in
977 2012-05-05 Murray Cumming <murrayc@murrayc.com>
979 DocumentTest: Move the .glom files into the resources directory.
981 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
982 URI via getResource().
984 2012-05-05 Murray Cumming <murrayc@murrayc.com>
986 Document: Remove the FieldIdentifies inner class.
988 * src/main/java/org/glom/web/server/libglom/Document.java: We only
989 use the Relationship (though the same function in libglom is maybe
990 used in other ways) and so this removes a compiler warning.
992 2012-05-05 Murray Cumming <murrayc@murrayc.com>
994 Document.load() Remove the error code parameter.
996 * src/main/java/org/glom/web/server/libglom/Document.java: load():
997 Remove the parameter. We do not set it yet and it could never have
998 worked as an output parameter (though maybe it did in java-libglom).
999 We could use an exception if we really want the failure reason.
1000 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1002 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1003 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1005 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1007 Make some inner classes static.
1009 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1011 * src/main/java/org/glom/web/server/ReportGenerator.java
1012 * src/main/java/org/glom/web/server/libglom/Document.java
1013 Make all inner classes static that can be static.
1015 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1017 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1020 init(): We do not use java-libglom any more.
1022 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1024 Remove mentions of java-libglom.
1026 * README: Remove mention of java-libglom, because it no longer needed.
1027 * utils/build-onlineglom-war.sh:
1028 * utils/check-and-recover-tomcat.py:
1029 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1030 useful. Building is now far easier, with no need for jhbuild.
1032 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1034 Fix the build (mvn package)
1036 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1037 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1038 Otherwise the GWT Java->Javascript compilation fails with just this
1039 error, during mvn package or when attempting to view in a browser,
1040 in the GWT developer mode in Eclipse.
1042 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1043 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1044 [INFO] Compiling module org.glom.web.OnlineGlom
1045 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1046 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1047 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1048 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1049 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1050 [INFO] [ERROR] Cannot proceed due to previous errors
1052 It has taken me 2 days to find out what was causing that. After reducing
1053 the code, the compiler eventually showed me the full error message.
1055 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1057 ConfiguredDocument: Cache the cloned and stripped layouts.
1059 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1060 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1061 layout in a map, so we can retrieve it again without rebuilding it.
1063 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1065 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1067 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1069 libglom classes: Implement some auto-generated emthods.
1071 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1073 Add GwtTestOnlineGlomService.
1075 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1076 However, this (and the other GwtTest*) does not seem to run during
1079 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1081 Remove use of unsupported features from client code.
1083 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1084 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1085 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1086 Use our client version of StringUtils instead of the apache commons one.
1088 However, the GWT Javascript compliation still fails.
1090 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1092 Add a Field class and implement some loading of it in Document.
1094 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1096 Initial Document loading implementation, instead of libglom.
1098 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1099 and Translatable classes, and adapt the rest of the code to use them.
1100 However, this is still missing Layout and Field classes and loading.
1102 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1104 Use of jOOQ: Move Field creation into a utility method.
1106 * src/main/java/org/glom/web/server/SqlUtils.java:
1107 This lets us improve it more easily.
1109 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1111 Use of jOOQ: Improve the code to COUNT a sub-select.
1113 * src/main/java/org/glom/web/server/SqlUtils.java:
1114 Move initial query creation into
1115 build_sql_select_step_with_where_clause().
1116 build_sql_select_count_rows(): Use the jOOQ API instead of
1117 concatentating text, because a jOOQ Select*Step is a TableLike,
1118 which is what from() takes.
1120 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1122 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1124 * pom.xml: Depend on jooq.
1125 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1126 methods with jOOQ, based on the C++ implementations in libglom,
1127 with some changes to the logic required by jooQ.
1128 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1130 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1131 * src/main/java/org/glom/web/server/ReportGenerator.java:
1132 * src/main/java/org/glom/web/server/SqlUtils.java:
1133 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1134 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1135 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1136 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1137 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1138 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1139 because jOOQ needs that, though it seems unnecessary.
1141 This is not quite finished. Ideally jOOQ would help us to build
1142 table_name.field_name names, quoting and escaping them properly.
1143 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1145 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1147 Move use of Glom.build_sql*() into a new SqlUtils class.
1149 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1150 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1151 but this will make it easier to start using something other than
1152 libglom or SqlBuilder.
1154 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1156 Update the project URL.
1158 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1160 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1162 Main layout: Use a FlowTable instead of absolute positioning.
1164 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1165 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1166 child panels/widgets must have an absolute position. But that is annoying, so
1167 this adds a FlowTable and puts the child panels in there.
1169 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1171 GwtTestOnlineGlom: Comment out unused code.
1173 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1174 Eclipse has started to say that some code is unused.
1176 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1178 Update to the latest versions of dependencies.
1180 * pom.xml: Update version numbers of dependencies to the latest
1182 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1184 * src/main/java/org/glom/web/server/ReportGenerator.java:
1185 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1186 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1187 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1189 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1190 Modify the imports where necessary.
1192 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1194 Style: Remove overflow:hidden from searchbox
1196 * src/main/webapp/style.css: Because this pushes the Back To Link
1197 label/link on to the next row, which is then hidden due to the
1198 hard-coded (in ems) height.
1200 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1202 Remove some duplicate code.
1204 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1205 getDocumentInfo(): This must have been duplicated during the merge from the
1210 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1212 Reports: Localize the waiting for report message.
1214 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1215 start(): Get the message from the contants.
1216 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1217 Add the string here.
1218 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1219 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1220 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1221 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1222 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1223 Update these files with the English text for newer strings for now.
1225 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1227 Reports: Show a message while waiting for the report.
1229 * src/main/java/org/glom/web/client/ui/ReportView.java
1230 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1231 Add setWaitingText(), to show a message saying that we are
1232 waiting for the report to be ready.
1233 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1234 start(): Call setWaitingText() before calling the async
1237 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1239 ReportGenerator: Specify date and time formats.
1241 * src/main/java/org/glom/web/server/ReportGenerator.java:
1242 createFieldValueElement(): Use the default (and localized)
1243 short formats, though we still need a way to show 4-digit
1244 years without providing the format for every locale.
1245 * src/main/java/org/glom/web/server/database/DBAccess.java:
1246 convertResultSetToDTO(): Use the short formats here too.
1248 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1250 ReportGenerator: Use the correct numeric formatting.
1252 * src/main/java/org/glom/web/server/ReportGenerator.java
1253 createFieldExpression(), createFieldValueElement(): Take the
1254 whole LayoutItem_Field instead of just the field name, so
1255 we have access to the formatting.
1256 createFieldValueElement(): Use JRTextField.setPattern() to
1257 specify the numeric formatting, with the help of a
1258 regular DecimalFormat.
1260 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1262 ReportGenerator: Avoid showing null for group by titles.
1264 * src/main/java/org/glom/web/server/ReportGenerator.java
1265 generateReport(): Use setBlankWhenNull() on the field title
1266 style too, because this is used for values in group by
1269 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1271 ReportGenerator: Add a colon to titles in vertical groups.
1273 * src/main/java/org/glom/web/server/ReportGenerator.java
1274 addFieldToDetailBandVertical(): Pass true for the withColon
1277 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1279 ReportGenerator: Simplify the code by using Position more.
1281 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1283 Reports: Support vertical groups, roughly.
1285 * src/main/java/org/glom/web/server/ReportGenerator.java:
1286 addToReport(): Rename to addGroupToReport() and, if necessary,
1287 call the new addVerticalGroupToReport() method.
1288 createFieldValueElement(): Let the caller specify the Y position
1291 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1293 Reports: Allow a second report to be shown.
1295 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1296 clear(): Do not remove the HTML widget, which broke the whole layout.
1298 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1300 Locales drop-down: Show that we use English by default.
1302 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1303 fillView(): When we use English, just because that is the default, when
1304 no locale is specified, show that in the Locales drop-down instead of
1305 just showing the first item.
1307 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1309 Unselect the Report/Locale/Table combo item when appropriate.
1311 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1312 setPlace(): clear reportName if this is not a ReportPlace.
1313 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1314 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1315 When the provided name is empty, unselect all items, so that none are
1316 indicated. This uses a for loop because I cannot find a single method
1319 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1321 Report: Give the user a way to get back to the list.
1323 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1324 start(), setPlace(): Show the Back To List link on reports, and also
1325 interpret selecting the empty report item as back to list.
1327 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1329 Really show the selected Report name.
1331 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1332 setPlace(): Store the reportName here, if it is that kind of Place.
1333 fillView(): Set the selected Report after filling the list of reports.
1334 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1335 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1336 null Strings, though we need some way to unselect all ListBox items
1339 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1341 ReportGenerator: Try to avoid some problems.
1343 * src/main/java/org/glom/web/server/ReportGenerator.java
1344 addField(): Try to avoid duplicates, and avoid using a null
1347 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1349 Reports: Use quickFind.
1351 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1352 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1354 getReportHTML(): Add a quickFind parameter.
1355 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1356 start(): Pass the quickFind parameter.
1357 * src/main/java/org/glom/web/server/ReportGenerator.java
1358 generateReport(): Take a quickFind parameter.
1360 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1362 ReportPlace: Actually use the report name.
1364 * src/main/java/org/glom/web/client/place/ReportPlace.java
1365 getPlace(): Do not assign the report name to the quickfind.
1367 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1369 Show java.library.path when complaining.
1371 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1372 init(): When telling us to check java.library.path, show the
1375 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1377 ReportGenerator: Do not show nulls.
1379 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1381 ReportGenerator: Make the title font larger.
1383 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1385 ReportGenerator: Put field titles inside groups, if there are groups.
1387 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1389 ReportGenerator: Take the Report itself instead of the name and group.
1391 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1392 Remove getReportLayoutGroup().
1393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1394 getReportHTML(): Pass the report instead
1395 of its name and layout group.
1396 * src/main/java/org/glom/web/server/ReportGenerator.java
1397 generateReport(): Use the report object to use the title
1398 instead of the name.
1400 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1402 ReportGenerator: Remove designBand parameters.
1404 * src/main/java/org/glom/web/server/ReportGenerator.java:
1405 Make designBand a class member instead of passing it to all
1408 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1410 ReportGenerator: Add lines, a bit like in the desktop version.
1412 * src/main/java/org/glom/web/server/ReportGenerator.java
1413 addToReport(): Use JRDesignLine.
1415 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1417 ReportGenerator: Correct the title positions and use some bold style.
1419 * src/main/java/org/glom/web/server/ReportGenerator.java:
1420 Break the code up into reusable functions, correct the placement of
1421 titles, and use normal/bold styles as in the reports in the desktop
1424 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1426 ReportGenerator: Add a header band to show the field titles.
1428 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1429 getReportHTML(): Pass the localeId to the ReportGenerator
1431 * src/main/java/org/glom/web/server/ReportGenerator.java
1432 constructor: Take the localeID so we can get translated field
1434 generateReport(), addToReport(), addFieldToBand(): Add field
1435 titles in a column header band.
1437 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1439 Reports drop-down list: Some improvement.
1441 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1442 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1443 Adedd setSelectedReport(),
1444 setReportList(): Add a blank line so that the user can select the
1446 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1447 start(): Show the current report by calling setSelectedReport().
1448 This does not seem to work yet.
1450 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1452 DetailsActivity, ListActivity: Move some variables into a base class.
1454 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1455 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1456 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1457 the clientFactory, documentID, tableName and authenticationPopup into
1458 a base class, to avoid duplication.
1460 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1462 Translate the Reports label.
1464 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1465 Get the "Reports" label string from the constants.
1466 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1467 perties: Add Reports to the constants.
1469 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1471 Reports: Implement grouping.
1473 * src/main/java/org/glom/web/server/ReportGenerator.java:
1474 Handle LayoutItem_GroupBy items and try to do the right thing
1475 with JRDesignGroup. It seems to work.
1477 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1479 Actually show some data with JasperReports.
1481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1482 getReportHTML(): Move most code into a ReportGenerator class.
1483 * src/main/java/org/glom/web/server/ReportGenerator.java:
1484 Recurse into sub-groups, adding fields to the JasperDesign's details
1485 band. Note that we must set an arbitrary width and height, or it just
1486 will not show any data.
1488 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1490 Reports Chooser: Show the titles, not the names.
1492 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1493 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1494 and the names as the values.
1495 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1496 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1497 group now that we provide the report name, so it should always
1500 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1502 Depend on jasperreports.
1504 * pom.xml: Add the dependency. My plan is to use this on the
1507 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1509 Implement navigation to report places.
1511 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1512 start(): Do not bother to handle all events here.
1513 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1514 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1515 Added getSelectedReport().
1516 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1517 .java: start(): When handling a change to the reports chooser,
1518 call getSelectedReport() and goTo() its ReportPlace.
1519 * src/main/java/org/glom/web/client/ui/ReportView.java
1520 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1521 Added setReportHTML() which puts the html in a gwt HTML widget.
1522 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1523 getReportHTML(): Return "TODO" just to show that this works.
1525 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1527 Make ReportPlace usable.
1529 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1530 Mention ReportPlace.
1531 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1532 Correct the @prefix annotation.
1534 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1536 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1538 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1539 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1540 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1541 Change getReportLayout() to getReportHMTL() because we will not need to
1542 parse or render the report layout on the client side.
1543 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1544 getReportLayout(): Return the libglom LayoutGroup type because we will
1545 not need to convert to a shared type, because this will not be used on
1547 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1550 Note that there is still no implementation for this.
1553 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1555 Add a (empty) Report Place, View, and Activity.
1557 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1559 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1560 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1561 this into a superclass:
1562 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1563 and also use it as the base of this new ReportPlace:
1564 * src/main/java/org/glom/web/client/place/ReportPlace.java
1566 * src/main/java/org/glom/web/client/ui/ReportView.java
1567 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1568 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1569 Add these, containing mostly boiler-plate for now.
1571 * src/main/java/org/glom/web/client/OnlineGlomService.java
1572 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1573 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1575 Add API to get the LayoutGroup for the report.
1577 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1579 Add and fill a Reports drop-down list box.
1581 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1583 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1584 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1586 Added getReports(document, table, localeID), calling
1587 ConfiguredDocument.getReports().
1588 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1589 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1590 Added setReportsList() and a list widget.
1591 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1592 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1597 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1599 Translations: Add Esperanto.
1601 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1602 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1603 properties: Add this translation because someone took the time to make it.
1605 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1607 Adapt to the java-libglom 1.21.7 API.
1609 * src/main/java/org/glom/web/server/ReportGenerator.java:
1610 addToReport(): get_group_secondary_fields() is now
1611 get_secondary_fields().
1614 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1616 Use the latest java-libglom version.
1618 * pom.xml: Use java-libglom 1.21.7.
1620 2012-03-03 Ben Konrath <ben@bagu.org>
1622 Display date and time in details view.
1624 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1626 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1628 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1630 Require the latest java-libglom.
1632 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1634 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1636 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1638 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1639 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1640 an empty quickfind string. I also corrected libglom to create only
1641 empty where clauses for empty quickfind strings, but this avoids the
1644 2012-02-24 Ben Konrath <ben@bagu.org>
1646 Improve the tabs in the Notebook widget.
1650 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1652 Translations: Try to translate the strings.
1654 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1655 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1656 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1657 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1658 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1659 Take the Open translation from GTK+'s .po files.
1660 Take the Details translation from Glom's po files.
1661 I have added the other strings to Glom so we can get translations that way:
1662 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1664 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1666 TableSelectionViewImpl: Put the search label and entry in a div.
1668 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1669 Put the search widgets in a FlowTable so that the CSS can be used to
1670 style them while keeping them together.
1671 * src/main/webapp/style.css: Mention the new div.
1673 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1675 Translate more strings in more locales.
1677 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1678 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1679 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1680 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1681 Translate the "Details" and "Open" string too.
1683 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1684 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1685 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1686 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1687 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1688 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1689 Add these new locales as placeholders though they currently contain English.
1691 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1693 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1696 Check the ConfiguredDocument* for null before using it.
1698 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1700 Tell Eclipse about the generated java files.
1702 * .classpath: This lets it find OnlineGlomConstants.java.
1703 It would be nice if Eclipse just used the maven build files.
1705 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1707 Prevent a crash when no locale is specified in the URL.
1709 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1710 Avoid returning a null string, obtained from
1711 Window.Location.getParameter(). This caused a crash when it was
1712 later passed to libglom's API.
1713 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1714 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1715 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1716 guard against future null strings.
1718 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1720 Use the ?locale= query param instead of the &lang= token param.
1722 * src/main/java/org/glom/web/client/place/ListPlace.java
1723 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1724 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1725 Remove the lang token key and value.
1727 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1728 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1729 When the user selects a different locale from the chooser, use
1730 Window.Location.assign() to change the URL, which then causes a reload.
1732 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1733 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1734 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1735 * src/main/java/org/glom/web/client/activity/ListActivity.java
1736 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1737 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1738 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1739 * src/main/java/org/glom/web/client/ui/ListView.java:
1740 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1742 Remove localeID member variables and method/constructor parameters, instead
1743 using Utils.getCurrentLocaleID() when we need a localID to pass to
1746 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1748 Internationalize the UI strings.
1750 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1751 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1752 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1753 because it is unused. Messages are apparently strings that can have
1754 parameters, but we do not need that yet, so Contants will be enough for now.
1755 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1756 to say that we support the en and de locales.
1757 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1758 The original English strings.
1759 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1760 Some German translations of the English strings.
1761 The i18n goal then uses the .properties file to generate an
1762 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1763 returns an implementation that returns the translated strings.
1764 The documentation suggests putting these in src/java/*/client/, but it seems
1765 best to put it in src/resources/*/client/.
1766 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1767 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1768 instead of hard-coding them.
1769 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1770 but that does not seem to stop the build, though it confuses Eclipse.
1772 You can see the translated string by adding ?locale=de to the URL, like so:
1773 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1775 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1777 Improve null/empty String checks.
1779 * pom.xml: Add a dependency on commons-lang, to use
1780 org.apache.commons.lang.StringUtils.
1781 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1783 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1784 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1785 Use StringUtils.isEmpty().
1787 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1788 StringUtils class with a static isEmpty() function because we
1789 cannot use org.apache.commons.lang.StringUtils in client-side
1790 GWT code because it (apparently) cannot be compiled to javascript.
1791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1792 * src/main/java/org/glom/web/client/activity/ListActivity.java
1793 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1794 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1795 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1796 * src/main/java/org/glom/web/client/place/ListPlace.java
1797 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1798 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1799 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1800 * src/main/java/org/glom/web/client/ui/details/Group.java
1801 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1802 our StringUtils.isEmpty() function.
1804 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1806 Update to the latest java-libglom API.
1808 * pom.xml: Require java-libglom 1.21.4.
1809 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1810 getDocumentInfo(), getListViewLayoutGroup():
1811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1813 * src/main/java/org/glom/web/server/database/DBAccess.java
1814 getFieldsToShowForSQLQueryAddGroup(),
1815 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1816 with either get_database_title_original() or
1817 get_database_title(localeID).
1819 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1821 ConfiguredDocument: Avoid a null pointer exception.
1823 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1824 Initialize localeID to "" to avoid returning a null String which
1825 causes a crash in java-libglom's swing-generated code.
1827 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1829 Some simple renaming.
1831 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1832 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1833 for localeChooser. This seems more appropriate and is less ambiguous
1834 particularly in the .css file.
1836 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1838 ConfiguredDocument: Rename the localedID private member variable.
1840 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1842 Adapt to the latest java-libglom API from git master.
1844 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1845 libglom now uses only Vector instead of List, which uses add() instead of
1848 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1850 ConfiguredDocument: Rename the localedID private member variable.
1852 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1854 Build a source tarball with mvn assembly:single
1856 * assembly.xml: Add this file.
1857 * pom.xml: Use the maven-assembly-plugin and tell it to use
1858 our assembly.xml file.
1860 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1862 OnlineGlomServiceImpl: Get .glom files recursively.
1864 * pom.xml: Depend on commons-io from org.apache.commons.
1865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1866 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1867 files recursively, and with the easier filter for the extension.
1868 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1869 simplify that code too.
1871 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1873 README: Mention that you must install java-libglom packages separately.
1875 But then it works, because java-libglom is now in the central maven
1878 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1880 locales drop-down: Show the correct selected locale when the URL changes.
1882 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1883 .java: setPlace(): Move some code into fillView().
1885 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1887 locales drop-down: Do not lose the primary key.
1889 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1890 start(): onLocaleChange(): Pass the current primary key value,
1891 instead of an empty value.
1893 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1895 locales drop-down: Do not lose the drop-down selection.
1897 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1898 .java (TableSelectionActivity.fillView): Set the selected locale
1899 after changing the drop-down items (though we do not really need
1900 to change them just because the locale changes.)
1902 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1904 locales drop-down: Change the tables list when this changes.
1906 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1907 .java: TableSelectionActivity.start(): Move the async table titles
1908 retrieval into a private fillView() method and also call this when
1909 the chosen locale changes.
1910 Note that the document title is not actually translatable yet, but
1911 that is a problem that I should fix soon in libglom.
1913 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1915 Improve the placement of the locales drop-down.
1917 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1918 Put the title and locales drop-down in a div (gwt.FlowTable).
1919 * src/main/webapp/style.css: Add magic css properties to make this work.
1920 Also remove the left margin from the title so that it lines up with the
1923 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1925 locales selector: Show human-readable locale titles.
1927 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1928 getDocumentInfo(): Use java.util.Locale to show a real title of
1929 each locale, in the locale's own language.
1931 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1933 Add a language/locale selector drop-down.
1935 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1936 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1937 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1938 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1939 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1940 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1941 Add a ListBox to show the available locales. Add getLocaleSelector(),
1942 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1943 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1944 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1945 java: Add these classes.
1946 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1947 start(): Fill the locales ListBox. Handle its change event, firing a
1949 setPlace(): Show the selected locale as specified by the URL token.
1950 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1951 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1952 Handle LocaleChangeEvent, going to a new *Place with that locale.
1954 The placement of the ListBox is not pretty, and it currently uses the ID
1955 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1959 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1961 Search box: Show the search text from the URL token.
1963 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1964 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1965 Add setQuickFindText().
1966 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1967 .java: setPlace(): Store the queryText if the place is a ListPlace,
1968 and call TableSelectionView.setQuickFindText().
1970 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1972 Allow use of translations via, for instance, &lang=de in the URL.
1974 * pom.xml: Use the unstable java-libglom 1.21 version.
1976 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1977 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1979 init(): Instead of calling TranslatableItem.set_current_locale()
1980 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1981 However, this is only for default locales, which are not needed to
1982 change the locale in the URL.
1983 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1984 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1985 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1986 layout for a particular locale.
1987 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1988 Add get/setDefaultLocaleID().
1989 getDocumentInfo(), getListViewData(), getRelatedListData(),
1990 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1991 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1992 localeID parameter, so we can get the layout for a particular locale.
1994 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1995 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1996 * src/main/java/org/glom/web/client/place/ListPlace.java:
1997 Parse and construct a lang parameter too.
1999 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2000 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2001 passed to subsequent methods and constructors.
2002 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2003 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2004 Store the localeID from the *Place and pass it to other constructors
2005 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2007 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2008 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2009 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2010 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2011 * src/main/java/org/glom/web/client/ui/ListView.java:
2012 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2013 Take localeID parameters and pass them to subsequent constructors and
2014 methods, so that the layout is always retrieved for that locale.
2016 This is rather repetitive.
2018 Note that "" means the original (default) locale of the Glom document,
2019 which is usually English.
2021 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2023 Documents: Remove final keyword to fix startup configuration.
2025 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2026 final keywords on the private member variables because that breaks
2027 the startup, apparently (there are warnings) because it stops them
2028 from being serialized. I added these in the previous commit.
2030 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2032 Documents: Add some final keywords.
2034 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2037 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2039 OnlineGlomServiceImpl: Add to overview comments.
2041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2042 Note that this is where all the document are loaded. They are not
2043 loaded freshly for each page.
2045 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2049 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2050 Add a TextBox for the text of a quick find.
2051 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2053 setBackLink(): Add a String quickFind parameter.
2054 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2055 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2056 to the base interface, because that is how TableSelectionViewImpl is used.
2057 * src/main/webapp/style.css: Add style for the search box and its label.
2059 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2060 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2061 Add these files, based on the existing TableChangeEvent and
2062 TableChangeEventHandlers.
2063 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2064 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2065 a ListPlace() that the user should be taken to.
2066 * src/main/java/org/glom/web/client/activity/ListActivity.java
2067 start(): Handle it here too and adapt the TableChangeEvent handler to
2068 pass the extra "" quickFind parameter to ListPlace.
2069 * src/main/java/org/glom/web/client/place/ListPlace.java:
2070 Constructor: Take an extra String quickFind parameter and store it,
2071 returning it from a new getQuickFind() method.
2072 getToken(): Put the quickFind text in the URL token.
2073 getPlace(): Parse the quickFind text from the URL token.
2074 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2075 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2076 ListPlace constructor.
2077 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2078 .java: start(): Add a Change handler for the TableSelectionView's
2079 TextBox (via its base HasChangeHandlers interface), firing the new
2080 QuickFindChangeEvent.
2081 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2082 pass the extra "" quickFind parameter.
2084 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2085 setCellTable(): Add a String quickFind parameter and pass it to
2086 the ListViewTable() constructor.
2087 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2088 setCellTable() in the base interface, because that is how ListViewImpl
2091 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2092 Add a String quickFind member variable.
2093 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2094 Constructor: Add a String quickFind parameter, storing it in the
2095 base ListTable's member variable.
2096 onRangeChanged(): Pass quickFind to the
2097 OnlineGlomServiceAsync.getSortedListViewData() and
2098 OnlineGlomServiceAsync.getListViewData() methods.
2100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2101 getListViewData(), getSortedListViewData(): Add a String quickFind
2102 parameter, passing it to ConfiguredDocument.getListViewData().
2103 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2104 Change getListViewData(), getSortedListViewData() in the base interface,
2105 because that is how OnlineGlomServiceImpl is used, via this:
2106 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2107 Change getListViewData(), getSortedListViewData() here too.
2108 This class can apparently be used to asynchronously call methods on
2109 OnlineGlomService, and GWT seems to implement that after recognizing
2110 just the *Async name convention and the extra AsyncCallback parameters.
2112 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2113 getListViewData(): Add a String quickFind parameter, and pass it to
2114 ListViewDBAccess.getData().
2115 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2116 getListData(): Add a String quickFind parameter and pass it to
2118 getSelectQuery(): Add a String quickFind parameter.
2119 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2120 getSelectQuery(): Add a String quickFind parameter and use it with
2121 Glom.get_find_where_clause_quick() to pass a where_clause to
2122 Glom.build_sql_select_with_where_clause(), to actually filter the
2124 getData(): Add a String quickFind parameter, passing it to getListData().
2125 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2126 va: getData(): Pass an empty string to getListData() for the
2127 quickFind parameter.
2129 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2131 ListTable: Minor change.
2133 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2134 createCellTable(): Make this protected instead of public.
2136 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2138 Many files: Use final for the parameters and use the @override attribute.
2140 2012-01-22 Ben Konrath <ben@bagu.org>
2142 Add anchor links for single line text that starts with http, ftp and www.
2146 2012-01-22 Ben Konrath <ben@bagu.org>
2148 Add ellipsis to single line text in details view.
2152 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2154 Remove all javadoc author tags.
2156 Because they are awkward and meaningless when many people touch
2158 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2160 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2162 Revert the COPYING.LESSER to COPYING rename.
2164 Apparently both should be there if it is LGPL.
2166 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2168 *View: Remove unused imports.
2170 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2171 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2172 * src/main/java/org/glom/web/client/ui/ListView.java:
2173 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2174 Remove unused imports, as suggested by Eclipse.
2176 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2178 Move the *View::Presenter types, and some API into one base View.
2180 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2181 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2182 * src/main/java/org/glom/web/client/ui/ListView.java:
2183 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2184 Presenter, setPresenter() and clear() into a shared base interface,
2185 to avoid the unnecessary duplicate Presenter types and to more clearly
2186 show how the *Views share the same structure, even if they are not
2187 used polymorphically.
2189 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2190 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2192 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2193 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2194 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2196 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2199 Feel free to revert this if there is a good reason for the duplicate
2202 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2204 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2206 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2207 a class member instead of a local variable in the method.
2208 This lets us use it to get the view instances, for use in tests.
2209 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2210 beforeOnlineGlom(): Test some more details of the initial view.
2211 Again, this is not very useful.
2213 To really test gwt-glom we will need to start a local postgresql
2214 instance with local data, like the Glom tests in C++.
2216 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2218 pom.xml: Mention the LGPL license.
2220 * pom.xml: Add a licenses section.
2221 * COPYING.LESSER: Move this to COPYING, which
2222 previously contained the GPL. But gwt-glom is all LGPL.
2224 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2226 Add project information to README and pom.xml.
2228 * README: Add a brief description and mention some mvn
2230 * pom.xml: This extra information shows up in mvn site
2233 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2235 Use the latest java-libglom version.
2237 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2239 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2241 GwtTestOnlineGlom: Test a little more.
2243 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2244 protected rather than private, as suggested by the gwt-test-utils
2246 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2247 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2248 Test the initial visibility of the panels.
2250 However, this is not a very useful test.
2251 And I wonder how we should generally test using this idea for an
2252 activity/places app like ours where the real changes happen implicitly
2253 based on the history token/URL.
2255 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2257 Slight modification to *Mapper comments.
2259 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2260 (DataActivityMapper)
2261 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2263 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2265 Remove comments mentioning GIN because they are just copied from
2266 the example code and are apparently not helpful:
2267 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2268 Also change the mention of a class that is only in the example code.
2270 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2272 GwtTestOnlineGlom test: Minor changes.
2274 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2275 Avoid the long qualified class name and modify the comment
2276 because it is now obvious to me that the mocked class is the only
2277 custom one created via GWT.create().
2279 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2281 Tests: Added the beginnings of a test using gwt-test-utils.
2283 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2284 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2285 which tells gwt-test-utils what class will be tested.
2286 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2287 Add a simple (but empty) test case. One class, used by the OnlineGlom
2288 class, is mocked so that it can be created. However, I am not sure
2289 why only this class needs to be mocked.
2291 Note that mockito seems more popular, and clearer, than easymock,
2292 but I have not got that working yet. It might be a matter of the
2295 This test is run during mvn integration-test.
2297 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2299 Tests: Use junit4-style syntax instead of junit3-style.
2301 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2302 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2303 * src/test/java/org/glom/web/shared/DataItemTest.java:
2304 Use the @Test annotation rather than relying on the test*() prefix.
2305 Also no longer implement TestCase, to avoid triggering support for
2306 the junit3-way, which stops the annotations from working.
2307 Change the imports from import junit.framework.* to
2308 import org.junit.*, which is apparently the new way.
2310 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2312 Added a test for ListPlace token parsing and creation.
2314 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2315 This is much the same as DetailsPlaceTest.
2317 I wonder how we could test the other parts of the *Place API.
2319 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2321 DetailsPlace test: Also test getToken() and recreation via getPlace().
2323 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2324 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2325 recreate it, testing the recreated DetailsPlace for the same parameter
2328 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2330 Use the surefire-report plugin.
2332 * pom.xml: This generates a HTML report about the tests in
2333 target/site/surefire-report.html
2334 when you do mvn surefire-report:report. It seems to be popular/normal.
2336 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2338 Added a test for DetailsPlace.
2340 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2341 Test the getPlace() token parsing.
2343 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2345 Added a first unit test.
2347 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2348 * src/test/java/org/glom/web/shared/DataItemTest.java:
2349 This is a silly test but it is just to get things started. Note that
2350 maven/junit finds the test because it looks in src/test by default.
2352 2011-12-22 Ben Konrath <ben@bagu.org>
2354 Change charsetName to "UTF-8" when replacing line breaks.
2356 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2357 that work in Java (such as "UTF8") will not work when compiled to
2360 This fixes a problem with multi-line details view fields that have hard
2361 line breaks. The "License Text" field on this page demonstrates the
2364 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2366 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2368 2011-12-22 Ben Konrath <ben@bagu.org>
2370 Fix another bug with related list navigation.
2372 I've tested all the navigation buttons in all of the related lists
2373 so things should be good now.
2375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2377 2011-12-22 Ben Konrath <ben@bagu.org>
2379 Fix a crasher when refreshing the list view with the default table.
2381 This crash will also happen when loading the list view with the default
2382 table from a link or bookmark.
2384 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2385 to the main document selection page when the document id hasn't been
2387 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2388 the main document selection page when the document id hasn't been
2390 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2391 values for the details place when the document id hasn't been set.
2392 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2393 values for the list place when the document id hasn't been set.
2395 2011-12-21 Ben Konrath <ben@bagu.org>
2397 Protect against NPE when glom.document.locale is not in config.
2399 This patch protects against an NPE when glom.document.locale is not in
2400 the config file. This NPE will also happen if glom.document.locale is
2403 The patch also updates the error message to display the class name when
2404 the getMessage() returns null. This was happening when the NPE was
2405 thrown and I had "Configuration Error: null". If an NPE is encountered
2406 with this patch, "Configuration Error: NullPointerException " will be
2409 This commit closes this bug:
2411 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2413 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2415 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2417 Rename onlineglom.properties to onlineglom.properties.sample.
2419 * src/main/resources/onlineglom.properties: Rename to:
2420 * src/main/resources/onlineglom.properties.sample:
2421 * src/main/resources/README: And add this file explaining that people
2422 should rename it back when deploying.
2424 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2426 Allow choosing the translation in the .properties file.
2428 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2429 init(): Read a glom.document.locale value from the configuration file
2430 and call Glom's TransatableItem::set_current_locale() method.
2431 * src/main/resources/onlineglom.properties: Add a commented-out
2432 example of this new setting.
2434 It would be better to add &lang=de_DE to the URL, but the current
2435 libglom API does not allow us to do this easily. I am working on that.
2437 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2439 Avoid a crash in parsing of token parameters.
2441 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2442 ava: getTokenParams(): Do not crash if a parameter has a key but no
2443 value, and ignore parameters with neither.
2445 2011-12-17 Murray Cumming <murrayc@murayc.com>
2447 History token building/handling: Improve use of token parameters.
2449 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2450 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2451 and buildParamsToken(HashMap), for use by derived classes.
2452 Make the separator private because it is no longer be needed.
2453 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2454 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2455 instead of manual string concatenation.
2456 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2457 of hardcoded indices and awkward splitting code.
2458 * src/main/java/org/glom/web/client/place/ListPlace.java
2459 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2460 instead of manual string concatenation.
2461 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2462 of hardcoded indices and awkward splitting code.
2463 This should fix bug #666420
2465 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2467 Fix a Navgiation->Navigation typo in the code.
2469 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2470 Rename processNavgiation() to processNavigation().
2472 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2474 Fix a seperator->separator typo in the code.
2476 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2477 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2478 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2481 2011-12-15 Ben Konrath <ben@bagu.org>
2483 Cleanup some comments.
2485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2487 2011-12-14 Ben Konrath <ben@bagu.org>
2489 Replace \n with <br/> for multiline text in the details view.
2491 Vertical scrollbars are added when needed as well.
2493 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2495 2011-12-14 Ben Konrath <ben@bagu.org>
2497 Specify the font for document selection links.
2499 * src/main/webapp/style.css:
2501 2011-12-14 Ben Konrath <ben@bagu.org>
2503 Fix bouncy CellTable while paging.
2505 This doesn't currently work with related list tables in unselected
2508 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2510 2011-12-14 Ben Konrath <ben@bagu.org>
2512 Revamp the appearance of the document selection page.
2514 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2515 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2516 * src/main/webapp/style.css:
2518 2011-12-13 Ben Konrath <ben@bagu.org>
2520 Set navigation button column to the smallest size possible.
2522 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2524 2011-12-13 Ben Konrath <ben@bagu.org>
2526 Change OpenButton nomenclature to NavigationButton.
2528 Using NavigtionButton makes things more generic. Classes, methods and
2529 variables have been changed.
2531 This is a rename-only refactor.
2533 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2534 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2535 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2536 Renamed from OpenButtonCell.
2537 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2538 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2539 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2541 2011-12-12 Ben Konrath <ben@bagu.org>
2543 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2545 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2546 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2547 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2548 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2550 2011-12-12 Ben Konrath <ben@bagu.org>
2552 Update variable names and comments.
2554 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2555 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2557 2011-12-12 Ben Konrath <ben@bagu.org>
2559 Properly initialize numNonEmptyRows variable to zero.
2561 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2562 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2564 2011-12-05 Ben Konrath <ben@bagu.org>
2566 Add latest mockup with HTML tables.
2568 Features of this mockup:
2570 -> HTML table for flowtable
2571 -> HTML table for flowtable column
2572 -> Example of how related lists would look
2573 -> Not using text entries for data items
2575 The current version of Online Glom doesn't use HTML tables for the
2578 This mockup has been sent to the glom-devel mailing list but it's good
2579 to have it here as well.
2581 * mockups/details-view-html-tables.html:
2583 2011-12-05 Ben Konrath <ben@bagu.org>
2585 Remove unnecessary getPrimaryKeyField() method.
2587 getPrimaryKeyFieldForTable(String) has been renamed to
2588 getPrimaryKeyField(String).
2590 * src/main/java/org/glom/web/server/database/DBAccess.java:
2591 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2592 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2594 2011-12-05 Ben Konrath <ben@bagu.org>
2596 Add string representation of TypedDataItem value to conversion error message.
2598 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2599 message was extracted into its own method to avoid duplication.
2601 2011-12-05 Ben Konrath <ben@bagu.org>
2603 Add type checking to navigation primary key value creation.
2605 Create navigation primary key only if the expected type from the Glom
2606 document matches the type returned by the SQL query.
2608 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2610 2011-12-05 Ben Konrath <ben@bagu.org>
2612 Rename a couple of variables in RelatedListNavigation.
2614 This is a rename-only refactor.
2616 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2618 2011-12-05 Ben Konrath <ben@bagu.org>
2620 Move getListLayoutGroup() into getListViewLayoutGroup().
2622 This removes getListLayoutGroup(). It was only being called by
2623 getListViewLayoutGroup().
2625 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2627 2011-12-05 Ben Konrath <ben@bagu.org>
2629 Remove check for LayoutItem_Portal in list table method.
2631 This check is no longer necessary because the method isn't being used
2632 to create the LayoutItemPortal DTO.
2634 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2636 2011-12-05 Ben Konrath <ben@bagu.org>
2638 Properly support related list navigation.
2640 Navigation from the "Repository Analyzer -> Package Scans ->
2641 Dependencies" related table wasn't working because the primary key for
2642 related tables wasn't being set properly. This commit fixes the
2645 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2646 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2647 doesn't set the primary key properly for related list tables.
2648 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2649 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2650 useful for getting the primary key for list view tables and for related
2652 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2653 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2654 Move code to set the primary key for the table from the abstract
2655 ListDBAccess class to ListViewDBAccess as it's only correct for list
2657 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2658 Properly add primary key to related list tables.
2660 2011-12-02 Ben Konrath <ben@bagu.org>
2662 Properly set the horizontal alignment of fields.
2664 This fix is for both the list tables and the details view.
2666 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2667 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2668 to set the horizontal alignment of fields.
2670 2011-12-02 Ben Konrath <ben@bagu.org>
2672 Display currency codes in the details view.
2674 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2676 2011-12-02 Ben Konrath <ben@bagu.org>
2678 Avoid duplicate JNI call.
2680 JNI is not as efficient as pure Java and this is an easy (and small)
2683 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2684 Use previously retrieved value for whereClauseToTableName instead of
2687 2011-12-02 Ben Konrath <ben@bagu.org>
2689 Rename a couple of variables in RelatedListNavigation.
2691 This is a rename-only refactor.
2693 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2695 2011-12-02 Ben Konrath <ben@bagu.org>
2697 Indicate clearly that a mismatched primary key type is a bug.
2699 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2700 warning to error. Add 'This is a bug.' to message.
2702 2011-12-02 Ben Konrath <ben@bagu.org>
2704 Update / fix some comments.
2706 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2708 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2710 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2711 Fix comments. Add some TODOs.
2713 2011-12-02 Ben Konrath <ben@bagu.org>
2715 Enable navigation to details view with string primary key from related list.
2717 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2718 Create a text primary key value when return type of result is
2719 java.sql.Types.VARCHAR.
2721 2011-12-02 Ben Konrath <ben@bagu.org>
2723 Use checkboxes for booleans in the details view.
2725 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2727 2011-12-01 Ben Konrath <ben@bagu.org>
2729 Improve performance of related list height calculation.
2731 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2732 Put code to calculate the expected height in a static initializer so
2733 that that it's only called once.
2735 2011-12-01 Ben Konrath <ben@bagu.org>
2737 Show related list tables in notebooks (again).
2739 Calculate the height of the related list tables so the Notebook can be
2740 set the correct height. The height of the related list table is also needed by
2741 FlowTable to be able decide how to create the layout.
2743 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2744 and set the Portal height based on the height of the related list
2745 table and the Portal container.
2746 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2747 Add method to calculate the height of the related list tables.
2748 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2749 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2750 calculate the height of the Pager widget.
2752 2011-12-01 Ben Konrath <ben@bagu.org>
2754 Use CellTable API for table property instead of setting style on Element.
2756 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2758 2011-12-01 Ben Konrath <ben@bagu.org>
2760 Make ListViewTable and RelatedListTable a consistent height.
2762 The tables are now a consistent height regardless of the contents of
2763 the table. A hidden button is added to empty rows to ensure that the
2764 height of these rows will match the height of rows with data.
2766 A navigation button column is now added to every table. The width of
2767 the navigation column is set to 0px when a RelatedListTable shouldn't
2768 have navigation buttons. This maintains the a consistent row height in
2769 tables that don't show the navigation buttons.
2771 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2772 navigation column when not needed.
2773 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2774 arguments for navigation button to constructor of ListViewTable.
2775 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2776 hidden button for empty data rows.
2777 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2778 arguments for navigation button to constructor.
2779 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2780 create navigation buttons. Add hideNavigationButtons() method.
2781 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2782 arguments for navigation button to constructor.
2784 2011-12-01 Ben Konrath <ben@bagu.org>
2786 Use 'visibility: hidden' in Utils.getWidgetHeight().
2788 This is better choice because hidden elements are invisible, don't
2789 respond to events and are not part of the tab order. They will,