1 2012-04-17 Murray Cumming <murrayc@murrayc.com>
3 Report: Give the user a way to get back to the list.
5 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
6 start(), setPlace(): Show the Back To List link on reports, and also
7 interpret selecting the empty report item as back to list.
9 2012-04-17 Murray Cumming <murrayc@murrayc.com>
11 Style: Remove overflow:hidden from searchbox
13 * src/main/webapp/style.css: Because this pushes the Back To Link
14 label/link on to the next row, which is then hidden due to the
15 hard-coded (in ems) height.
17 2012-04-13 Murray Cumming <murrayc@murrayc.com>
19 Really show the selected Report name.
21 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
22 setPlace(): Store the reportName here, if it is that kind of Place.
23 fillView(): Set the selected Report after filling the list of reports.
24 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
25 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
26 null Strings, though we need some way to unselect all ListBox items
29 2012-04-13 Murray Cumming <murrayc@murrayc.com>
31 ReportGenerator: Try to avoid some problems.
33 * src/main/java/org/glom/web/server/ReportGenerator.java
34 addField(): Try to avoid duplicates, and avoid using a null
37 2012-04-13 Murray Cumming <murrayc@murrayc.com>
39 Reports: Use quickFind.
41 * src/main/java/org/glom/web/client/OnlineGlomService.java;
42 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
43 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
44 getReportHTML(): Add a quickFind parameter.
45 * src/main/java/org/glom/web/client/activity/ReportActivity.java
46 start(): Pass the quickFind parameter.
47 * src/main/java/org/glom/web/server/ReportGenerator.java
48 generateReport(): Take a quickFind parameter.
50 2012-04-13 Murray Cumming <murrayc@murrayc.com>
52 ReportPlace: Actually use the report name.
54 * src/main/java/org/glom/web/client/place/ReportPlace.java
55 getPlace(): Do not assign the report name to the quickfind.
57 2012-04-13 Murray Cumming <murrayc@murrayc.com>
59 Show java.library.path when complaining.
61 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
62 init(): When telling us to check java.library.path, show the
65 2012-04-12 Murray Cumming <murrayc@murrayc.com>
67 Adapt to the java-libglom 1.21.8 API.
69 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
70 java-libglom's FieldFormatting is now Formatting.
72 2012-04-12 Murray Cumming <murrayc@murrayc.com>
74 Use the latest java-libglom version.
76 * pom.xml: Use java-libglom 1.21.8.
78 2012-03-15 Murray Cumming <murrayc@murrayc.com>
80 Adapt to the java-libglom 1.21.7 API.
82 * src/main/java/org/glom/web/server/ReportGenerator.java:
83 addToReport(): get_group_secondary_fields() is now
84 get_secondary_fields().
86 2012-03-15 Murray Cumming <murrayc@murrayc.com>
88 Use the latest java-libglom version.
90 * pom.xml: Use java-libglom 1.21.7.
92 2012-03-06 Murray Cumming <murrayc@murrayc.com>
94 ReportGenerator: Do not show nulls.
96 2012-03-06 Murray Cumming <murrayc@murrayc.com>
98 ReportGenerator: Make the title font larger.
100 2012-03-06 Murray Cumming <murrayc@murrayc.com>
102 ReportGenerator: Put field titles inside groups, if there are groups.
104 2012-03-06 Murray Cumming <murrayc@murrayc.com>
106 ReportGenerator: Take the Report itself instead of the name and group.
108 * src/main/java/org/glom/web/server/ConfiguredDocument.java
109 Remove getReportLayoutGroup().
110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
111 getReportHTML(): Pass the report instead
112 of its name and layout group.
113 * src/main/java/org/glom/web/server/ReportGenerator.java
114 generateReport(): Use the report object to use the title
117 2012-03-06 Murray Cumming <murrayc@murrayc.com>
119 ReportGenerator: Remove designBand parameters.
121 * src/main/java/org/glom/web/server/ReportGenerator.java:
122 Make designBand a class member instead of passing it to all
125 2012-03-06 Murray Cumming <murrayc@murrayc.com>
127 ReportGenerator: Add lines, a bit like in the desktop version.
129 * src/main/java/org/glom/web/server/ReportGenerator.java
130 addToReport(): Use JRDesignLine.
132 2012-03-06 Murray Cumming <murrayc@murrayc.com>
134 ReportGenerator: Correct the title positions and use some bold style.
136 * src/main/java/org/glom/web/server/ReportGenerator.java:
137 Break the code up into reusable functions, correct the placement of
138 titles, and use normal/bold styles as in the reports in the desktop
141 2012-03-06 Murray Cumming <murrayc@murrayc.com>
143 ReportGenerator: Add a header band to show the field titles.
145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
146 getReportHTML(): Pass the localeId to the ReportGenerator
148 * src/main/java/org/glom/web/server/ReportGenerator.java
149 constructor: Take the localeID so we can get translated field
151 generateReport(), addToReport(), addFieldToBand(): Add field
152 titles in a column header band.
154 2012-03-05 Murray Cumming <murrayc@murrayc.com>
156 Reports drop-down list: Some improvement.
158 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
159 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
160 Adedd setSelectedReport(),
161 setReportList(): Add a blank line so that the user can select the
163 * src/main/java/org/glom/web/client/activity/ReportActivity.java
164 start(): Show the current report by calling setSelectedReport().
165 This does not seem to work yet.
167 2012-03-05 Murray Cumming <murrayc@murrayc.com>
169 DetailsActivity, ListActivity: Move some variables into a base class.
171 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
172 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
173 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
174 the clientFactory, documentID, tableName and authenticationPopup into
175 a base class, to avoid duplication.
177 2012-03-05 Murray Cumming <murrayc@murrayc.com>
179 Translate the Reports label.
181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
182 Get the "Reports" label string from the constants.
183 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
184 perties: Add Reports to the constants.
186 2012-03-03 Ben Konrath <ben@bagu.org>
188 Display date and time in details view.
190 https://bugzilla.gnome.org/show_bug.cgi?id=671257
192 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
194 2012-03-05 Murray Cumming <murrayc@murrayc.com>
196 Require the latest java-libglom.
198 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
200 2012-03-05 Murray Cumming <murrayc@murrayc.com>
202 Reports: Implement grouping.
204 * src/main/java/org/glom/web/server/ReportGenerator.java:
205 Handle LayoutItem_GroupBy items and try to do the right thing
206 with JRDesignGroup. It seems to work.
208 2012-03-04 Murray Cumming <murrayc@murrayc.com>
210 Actually show some data with JasperReports.
212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
213 getReportHTML(): Move most code into a ReportGenerator class.
214 * src/main/java/org/glom/web/server/ReportGenerator.java:
215 Recurse into sub-groups, adding fields to the JasperDesign's details
216 band. Note that we must set an arbitrary width and height, or it just
217 will not show any data.
219 2012-03-04 Murray Cumming <murrayc@murrayc.com>
221 Reports Chooser: Show the titles, not the names.
223 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
224 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
225 and the names as the values.
226 * src/main/java/org/glom/web/server/ConfiguredDocument.java
227 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
228 group now that we provide the report name, so it should always
231 2012-03-04 Murray Cumming <murrayc@murrayc.com>
233 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
235 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
236 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
237 an empty quickfind string. I also corrected libglom to create only
238 empty where clauses for empty quickfind strings, but this avoids the
241 2012-02-24 Ben Konrath <ben@bagu.org>
243 Improve the tabs in the Notebook widget.
247 2012-02-15 Murray Cumming <murrayc@murrayc.com>
249 Depend on jasperreports.
251 * pom.xml: Add the dependency. My plan is to use this on the
254 2012-01-31 Murray Cumming <murrayc@murrayc.com>
256 Implement navigation to report places.
258 * src/main/java/org/glom/web/client/activity/ReportActivity.java
259 start(): Do not bother to handle all events here.
260 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
261 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
262 Added getSelectedReport().
263 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
264 .java: start(): When handling a change to the reports chooser,
265 call getSelectedReport() and goTo() its ReportPlace.
266 * src/main/java/org/glom/web/client/ui/ReportView.java
267 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
268 Added setReportHTML() which puts the html in a gwt HTML widget.
269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
270 getReportHTML(): Return "TODO" just to show that this works.
272 2012-01-31 Murray Cumming <murrayc@murrayc.com>
274 Make ReportPlace usable.
276 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
278 * src/main/java/org/glom/web/client/place/ReportPlace.java:
279 Correct the @prefix annotation.
281 2012-01-31 Murray Cumming <murrayc@murrayc.com>
283 OnlineGlomService: Return report HTML rather than the LayoutGroup.
285 * src/main/java/org/glom/web/client/OnlineGlomService.java:
286 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
287 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
288 Change getReportLayout() to getReportHMTL() because we will not need to
289 parse or render the report layout on the client side.
290 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
291 getReportLayout(): Return the libglom LayoutGroup type because we will
292 not need to convert to a shared type, because this will not be used on
294 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
297 Note that there is still no implementation for this.
299 2012-01-30 Murray Cumming <murrayc@murrayc.com>
301 Translations: Try to translate the strings.
303 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
304 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
305 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
306 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
307 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
308 Take the Open translation from GTK+'s .po files.
309 Take the Details translation from Glom's po files.
310 I have added the other strings to Glom so we can get translations that way:
311 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
313 2012-01-27 Murray Cumming <murrayc@murrayc.com>
315 Add a (empty) Report Place, View, and Activity.
317 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
319 * src/main/java/org/glom/web/client/place/HasTablePlace.java
320 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
321 this into a superclass:
322 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
323 and also use it as the base of this new ReportPlace:
324 * src/main/java/org/glom/web/client/place/ReportPlace.java
326 * src/main/java/org/glom/web/client/ui/ReportView.java
327 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
328 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
329 Add these, containing mostly boiler-plate for now.
331 * src/main/java/org/glom/web/client/OnlineGlomService.java
332 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
333 * src/main/java/org/glom/web/server/ConfiguredDocument.java
334 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
335 Add API to get the LayoutGroup for the report.
337 2012-01-27 Murray Cumming <murrayc@murrayc.com>
339 TableSelectionViewImpl: Put the search label and entry in a div.
341 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
342 Put the search widgets in a FlowTable so that the CSS can be used to
343 style them while keeping them together.
344 * src/main/webapp/style.css: Mention the new div.
346 2012-01-27 Murray Cumming <murrayc@murrayc.com>
348 Translate more strings in more locales.
350 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
351 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
352 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
353 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
354 Translate the "Details" and "Open" string too.
356 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
357 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
358 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
359 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
360 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
361 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
362 Add these new locales as placeholders though they currently contain English.
364 2012-01-27 Murray Cumming <murrayc@murrayc.com>
366 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
369 Check the ConfiguredDocument* for null before using it.
371 2012-01-26 Murray Cumming <murrayc@murrayc.com>
373 Tell Eclipse about the generated java files.
375 * .classpath: This lets it find OnlineGlomConstants.java.
376 It would be nice if Eclipse just used the maven build files.
378 2012-01-26 Murray Cumming <murrayc@murrayc.com>
380 Prevent a crash when no locale is specified in the URL.
382 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
383 Avoid returning a null string, obtained from
384 Window.Location.getParameter(). This caused a crash when it was
385 later passed to libglom's API.
386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
387 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
388 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
389 guard against future null strings.
391 2012-01-26 Murray Cumming <murrayc@murrayc.com>
393 Use the ?locale= query param instead of the &lang= token param.
395 * src/main/java/org/glom/web/client/place/ListPlace.java
396 * src/main/java/org/glom/web/client/place/DetailsPlace.java
397 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
398 Remove the lang token key and value.
400 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
401 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
402 When the user selects a different locale from the chooser, use
403 Window.Location.assign() to change the URL, which then causes a reload.
405 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
406 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
407 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
408 * src/main/java/org/glom/web/client/activity/ListActivity.java
409 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
410 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
411 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
412 * src/main/java/org/glom/web/client/ui/ListView.java:
413 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
415 Remove localeID member variables and method/constructor parameters, instead
416 using Utils.getCurrentLocaleID() when we need a localID to pass to
419 2012-01-26 Murray Cumming <murrayc@murrayc.com>
421 Internationalize the UI strings.
423 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
424 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
425 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
426 because it is unused. Messages are apparently strings that can have
427 parameters, but we do not need that yet, so Contants will be enough for now.
428 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
429 to say that we support the en and de locales.
430 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
431 The original English strings.
432 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
433 Some German translations of the English strings.
434 The i18n goal then uses the .properties file to generate an
435 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
436 returns an implementation that returns the translated strings.
437 The documentation suggests putting these in src/java/*/client/, but it seems
438 best to put it in src/resources/*/client/.
439 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
440 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
441 instead of hard-coding them.
442 Note that we cannot import OnlineGlomConstants because it does not exist yet,
443 but that does not seem to stop the build, though it confuses Eclipse.
445 You can see the translated string by adding ?locale=de to the URL, like so:
446 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
448 2012-01-24 Murray Cumming <murrayc@murrayc.com>
450 Improve null/empty String checks.
452 * pom.xml: Add a dependency on commons-lang, to use
453 org.apache.commons.lang.StringUtils.
454 * src/main/java/org/glom/web/server/ConfiguredDocument.java
455 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
456 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
457 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
458 Use StringUtils.isEmpty().
460 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
461 StringUtils class with a static isEmpty() function because we
462 cannot use org.apache.commons.lang.StringUtils in client-side
463 GWT code because it (apparently) cannot be compiled to javascript.
464 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
465 * src/main/java/org/glom/web/client/activity/ListActivity.java
466 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
467 * src/main/java/org/glom/web/client/place/DetailsPlace.java
468 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
469 * src/main/java/org/glom/web/client/place/ListPlace.java
470 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
471 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
472 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
473 * src/main/java/org/glom/web/client/ui/details/Group.java
474 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
475 our StringUtils.isEmpty() function.
477 2012-01-24 Murray Cumming <murrayc@murrayc.com>
479 Update to the latest java-libglom API.
481 * pom.xml: Require java-libglom 1.21.4.
482 * src/main/java/org/glom/web/server/ConfiguredDocument.java
483 getDocumentInfo(), getListViewLayoutGroup():
484 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
486 * src/main/java/org/glom/web/server/database/DBAccess.java
487 getFieldsToShowForSQLQueryAddGroup(),
488 getPrimaryKeyLayoutItemField(): Replace get_database_title()
489 with either get_database_title_original() or
490 get_database_title(localeID).
492 2012-01-24 Murray Cumming <murrayc@murrayc.com>
494 ConfiguredDocument: Avoid a null pointer exception.
496 * src/main/java/org/glom/web/server/ConfiguredDocument.java
497 Initialize localeID to "" to avoid returning a null String which
498 causes a crash in java-libglom's swing-generated code.
500 2012-01-23 Murray Cumming <murrayc@murrayc.com>
502 Some simple renaming.
504 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
505 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
506 for localeChooser. This seems more appropriate and is less ambiguous
507 particularly in the .css file.
509 2012-01-23 Murray Cumming <murrayc@murrayc.com>
511 ConfiguredDocument: Rename the localedID private member variable.
513 2012-01-23 Murray Cumming <murrayc@murrayc.com>
515 Adapt to the latest java-libglom API from git master.
517 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
518 libglom now uses only Vector instead of List, which uses add() instead of
521 2012-01-23 Murray Cumming <murrayc@murrayc.com>
523 Add and fill a Reports drop-down list box.
525 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
527 * src/main/java/org/glom/web/client/OnlineGlomService.java:
528 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
530 Added getReports(document, table, localeID), calling
531 ConfiguredDocument.getReports().
532 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
533 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
534 Added setReportsList() and a list widget.
535 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
536 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
538 2012-01-22 Murray Cumming <murrayc@murrayc.com>
540 ConfiguredDocument: Rename the localedID private member variable.
542 2012-01-20 Murray Cumming <murrayc@murrayc.com>
544 Build a source tarball with mvn assembly:single
546 * assembly.xml: Add this file.
547 * pom.xml: Use the maven-assembly-plugin and tell it to use
548 our assembly.xml file.
550 2012-01-19 Murray Cumming <murrayc@murrayc.com>
552 OnlineGlomServiceImpl: Get .glom files recursively.
554 * pom.xml: Depend on commons-io from org.apache.commons.
555 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
556 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
557 files recursively, and with the easier filter for the extension.
558 Use org.apache.commons.io.FilenameUtils.removeExtension() to
559 simplify that code too.
561 2012-01-19 Murray Cumming <murrayc@murrayc.com>
563 README: Mention that you must install java-libglom packages separately.
565 But then it works, because java-libglom is now in the central maven
568 2012-01-18 Murray Cumming <murrayc@murrayc.com>
570 locales drop-down: Show the correct selected locale when the URL changes.
572 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
573 .java: setPlace(): Move some code into fillView().
575 2012-01-18 Murray Cumming <murrayc@murrayc.com>
577 locales drop-down: Do not lose the primary key.
579 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
580 start(): onLocaleChange(): Pass the current primary key value,
581 instead of an empty value.
583 2012-01-18 Murray Cumming <murrayc@murrayc.com>
585 locales drop-down: Do not lose the drop-down selection.
587 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
588 .java (TableSelectionActivity.fillView): Set the selected locale
589 after changing the drop-down items (though we do not really need
590 to change them just because the locale changes.)
592 2012-01-18 Murray Cumming <murrayc@murrayc.com>
594 locales drop-down: Change the tables list when this changes.
596 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
597 .java: TableSelectionActivity.start(): Move the async table titles
598 retrieval into a private fillView() method and also call this when
599 the chosen locale changes.
600 Note that the document title is not actually translatable yet, but
601 that is a problem that I should fix soon in libglom.
603 2012-01-18 Murray Cumming <murrayc@murrayc.com>
605 Improve the placement of the locales drop-down.
607 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
608 Put the title and locales drop-down in a div (gwt.FlowTable).
609 * src/main/webapp/style.css: Add magic css properties to make this work.
610 Also remove the left margin from the title so that it lines up with the
613 2012-01-18 Murray Cumming <murrayc@murrayc.com>
615 locales selector: Show human-readable locale titles.
617 * src/main/java/org/glom/web/server/ConfiguredDocument.java
618 getDocumentInfo(): Use java.util.Locale to show a real title of
619 each locale, in the locale's own language.
621 2012-01-17 Murray Cumming <murrayc@murrayc.com>
623 Add a language/locale selector drop-down.
625 * src/main/java/org/glom/web/shared/DocumentInfo.java:
626 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
627 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
628 getDocumentInfo(): Store the available Locales in the DocumentInfo.
629 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
630 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
631 Add a ListBox to show the available locales. Add getLocaleSelector(),
632 setLocaleList(), getSelectedLocale(), setSelectedLocale().
633 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
634 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
635 java: Add these classes.
636 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
637 start(): Fill the locales ListBox. Handle its change event, firing a
639 setPlace(): Show the selected locale as specified by the URL token.
640 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
641 * src/main/java/org/glom/web/client/activity/ListActivity.java:
642 Handle LocaleChangeEvent, going to a new *Place with that locale.
644 The placement of the ListBox is not pretty, and it currently uses the ID
645 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
649 2012-01-17 Murray Cumming <murrayc@murrayc.com>
651 Search box: Show the search text from the URL token.
653 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
654 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
655 Add setQuickFindText().
656 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
657 .java: setPlace(): Store the queryText if the place is a ListPlace,
658 and call TableSelectionView.setQuickFindText().
660 2012-01-17 Murray Cumming <murrayc@murrayc.com>
662 Allow use of translations via, for instance, &lang=de in the URL.
664 * pom.xml: Use the unstable java-libglom 1.21 version.
666 * src/main/java/org/glom/web/client/OnlineGlomService.java:
667 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
669 init(): Instead of calling TranslatableItem.set_current_locale()
670 (now removed), call ConfiguredDocument.setDefaultLocaleID().
671 However, this is only for default locales, which are not needed to
672 change the locale in the URL.
673 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
674 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
675 getSortedRelatedListData(): Add a localeID parameter, so we can get the
676 layout for a particular locale.
677 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
678 Add get/setDefaultLocaleID().
679 getDocumentInfo(), getListViewData(), getRelatedListData(),
680 getDetailsLayoutGroup(), getListViewLayoutGroup(),
681 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
682 localeID parameter, so we can get the layout for a particular locale.
684 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
685 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
686 * src/main/java/org/glom/web/client/place/ListPlace.java:
687 Parse and construct a lang parameter too.
689 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
690 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
691 passed to subsequent methods and constructors.
692 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
693 * src/main/java/org/glom/web/client/activity/ListActivity.java:
694 Store the localeID from the *Place and pass it to other constructors
695 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
697 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
698 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
699 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
700 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
701 * src/main/java/org/glom/web/client/ui/ListView.java:
702 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
703 Take localeID parameters and pass them to subsequent constructors and
704 methods, so that the layout is always retrieved for that locale.
706 This is rather repetitive.
708 Note that "" means the original (default) locale of the Glom document,
709 which is usually English.
711 2012-01-17 Murray Cumming <murrayc@murrayc.com>
713 Documents: Remove final keyword to fix startup configuration.
715 * src/main/java/org/glom/web/shared/Documents.java: Remove the
716 final keywords on the private member variables because that breaks
717 the startup, apparently (there are warnings) because it stops them
718 from being serialized. I added these in the previous commit.
720 2012-01-13 Murray Cumming <murrayc@murrayc.com>
722 Documents: Add some final keywords.
724 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
727 2012-01-13 Murray Cumming <murrayc@murrayc.com>
729 OnlineGlomServiceImpl: Add to overview comments.
731 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
732 Note that this is where all the document are loaded. They are not
733 loaded freshly for each page.
735 2012-01-12 Murray Cumming <murrayc@murrayc.com>
739 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
740 Add a TextBox for the text of a quick find.
741 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
743 setBackLink(): Add a String quickFind parameter.
744 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
745 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
746 to the base interface, because that is how TableSelectionViewImpl is used.
747 * src/main/webapp/style.css: Add style for the search box and its label.
749 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
750 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
751 Add these files, based on the existing TableChangeEvent and
752 TableChangeEventHandlers.
753 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
754 start(): Handle QuickFindChangeEvent, passing its quickFind text to
755 a ListPlace() that the user should be taken to.
756 * src/main/java/org/glom/web/client/activity/ListActivity.java
757 start(): Handle it here too and adapt the TableChangeEvent handler to
758 pass the extra "" quickFind parameter to ListPlace.
759 * src/main/java/org/glom/web/client/place/ListPlace.java:
760 Constructor: Take an extra String quickFind parameter and store it,
761 returning it from a new getQuickFind() method.
762 getToken(): Put the quickFind text in the URL token.
763 getPlace(): Parse the quickFind text from the URL token.
764 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
765 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
766 ListPlace constructor.
767 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
768 .java: start(): Add a Change handler for the TableSelectionView's
769 TextBox (via its base HasChangeHandlers interface), firing the new
770 QuickFindChangeEvent.
771 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
772 pass the extra "" quickFind parameter.
774 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
775 setCellTable(): Add a String quickFind parameter and pass it to
776 the ListViewTable() constructor.
777 * src/main/java/org/glom/web/client/ui/ListView.java: Change
778 setCellTable() in the base interface, because that is how ListViewImpl
781 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
782 Add a String quickFind member variable.
783 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
784 Constructor: Add a String quickFind parameter, storing it in the
785 base ListTable's member variable.
786 onRangeChanged(): Pass quickFind to the
787 OnlineGlomServiceAsync.getSortedListViewData() and
788 OnlineGlomServiceAsync.getListViewData() methods.
790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
791 getListViewData(), getSortedListViewData(): Add a String quickFind
792 parameter, passing it to ConfiguredDocument.getListViewData().
793 * src/main/java/org/glom/web/client/OnlineGlomService.java:
794 Change getListViewData(), getSortedListViewData() in the base interface,
795 because that is how OnlineGlomServiceImpl is used, via this:
796 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
797 Change getListViewData(), getSortedListViewData() here too.
798 This class can apparently be used to asynchronously call methods on
799 OnlineGlomService, and GWT seems to implement that after recognizing
800 just the *Async name convention and the extra AsyncCallback parameters.
802 * src/main/java/org/glom/web/server/ConfiguredDocument.java
803 getListViewData(): Add a String quickFind parameter, and pass it to
804 ListViewDBAccess.getData().
805 * src/main/java/org/glom/web/server/database/ListDBAccess.java
806 getListData(): Add a String quickFind parameter and pass it to
808 getSelectQuery(): Add a String quickFind parameter.
809 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
810 getSelectQuery(): Add a String quickFind parameter and use it with
811 Glom.get_find_where_clause_quick() to pass a where_clause to
812 Glom.build_sql_select_with_where_clause(), to actually filter the
814 getData(): Add a String quickFind parameter, passing it to getListData().
815 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
816 va: getData(): Pass an empty string to getListData() for the
819 2012-01-12 Murray Cumming <murrayc@murrayc.com>
821 ListTable: Minor change.
823 * src/main/java/org/glom/web/client/ui/list/ListTable.java
824 createCellTable(): Make this protected instead of public.
826 2012-01-12 Murray Cumming <murrayc@murrayc.com>
828 Many files: Use final for the parameters and use the @override attribute.
830 2012-01-22 Ben Konrath <ben@bagu.org>
832 Add anchor links for single line text that starts with http, ftp and www.
836 2012-01-22 Ben Konrath <ben@bagu.org>
838 Add ellipsis to single line text in details view.
842 2012-01-04 Murray Cumming <murrayc@murrayc.com>
844 Remove all javadoc author tags.
846 Because they are awkward and meaningless when many people touch
848 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
850 2012-01-04 Murray Cumming <murrayc@murrayc.com>
852 Revert the COPYING.LESSER to COPYING rename.
854 Apparently both should be there if it is LGPL.
856 2012-01-03 Murray Cumming <murrayc@murrayc.com>
858 *View: Remove unused imports.
860 * src/main/java/org/glom/web/client/ui/DetailsView.java:
861 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
862 * src/main/java/org/glom/web/client/ui/ListView.java:
863 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
864 Remove unused imports, as suggested by Eclipse.
866 2012-01-02 Murray Cumming <murrayc@murrayc.com>
868 Move the *View::Presenter types, and some API into one base View.
870 * src/main/java/org/glom/web/client/ui/DetailsView.java:
871 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
872 * src/main/java/org/glom/web/client/ui/ListView.java:
873 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
874 Presenter, setPresenter() and clear() into a shared base interface,
875 to avoid the unnecessary duplicate Presenter types and to more clearly
876 show how the *Views share the same structure, even if they are not
877 used polymorphically.
879 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
880 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
882 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
883 * src/main/java/org/glom/web/client/activity/ListActivity.java:
884 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
886 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
889 Feel free to revert this if there is a good reason for the duplicate
892 2012-01-02 Murray Cumming <murrayc@murrayc.com>
894 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
896 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
897 a class member instead of a local variable in the method.
898 This lets us use it to get the view instances, for use in tests.
899 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
900 beforeOnlineGlom(): Test some more details of the initial view.
901 Again, this is not very useful.
903 To really test gwt-glom we will need to start a local postgresql
904 instance with local data, like the Glom tests in C++.
906 2012-01-02 Murray Cumming <murrayc@murrayc.com>
908 pom.xml: Mention the LGPL license.
910 * pom.xml: Add a licenses section.
911 * COPYING.LESSER: Move this to COPYING, which
912 previously contained the GPL. But gwt-glom is all LGPL.
914 2012-01-02 Murray Cumming <murrayc@murrayc.com>
916 Add project information to README and pom.xml.
918 * README: Add a brief description and mention some mvn
920 * pom.xml: This extra information shows up in mvn site
923 2011-01-02 Murray Cumming <murrayc@murrayc.com>
925 Use the latest java-libglom version.
927 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
929 2012-01-01 Murray Cumming <murrayc@murrayc.com>
931 GwtTestOnlineGlom: Test a little more.
933 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
934 protected rather than private, as suggested by the gwt-test-utils
936 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
937 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
938 Test the initial visibility of the panels.
940 However, this is not a very useful test.
941 And I wonder how we should generally test using this idea for an
942 activity/places app like ours where the real changes happen implicitly
943 based on the history token/URL.
945 2012-01-01 Murray Cumming <murrayc@murrayc.com>
947 Slight modification to *Mapper comments.
949 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
951 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
953 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
955 Remove comments mentioning GIN because they are just copied from
956 the example code and are apparently not helpful:
957 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
958 Also change the mention of a class that is only in the example code.
960 2012-01-01 Murray Cumming <murrayc@murrayc.com>
962 GwtTestOnlineGlom test: Minor changes.
964 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
965 Avoid the long qualified class name and modify the comment
966 because it is now obvious to me that the mocked class is the only
967 custom one created via GWT.create().
969 2012-01-01 Murray Cumming <murrayc@murrayc.com>
971 Tests: Added the beginnings of a test using gwt-test-utils.
973 * pom.xml: Add dependencies on gwt-test-utils and easymock.
974 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
975 which tells gwt-test-utils what class will be tested.
976 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
977 Add a simple (but empty) test case. One class, used by the OnlineGlom
978 class, is mocked so that it can be created. However, I am not sure
979 why only this class needs to be mocked.
981 Note that mockito seems more popular, and clearer, than easymock,
982 but I have not got that working yet. It might be a matter of the
985 This test is run during mvn integration-test.
987 2011-12-31 Murray Cumming <murrayc@murrayc.com>
989 Tests: Use junit4-style syntax instead of junit3-style.
991 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
992 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
993 * src/test/java/org/glom/web/shared/DataItemTest.java:
994 Use the @Test annotation rather than relying on the test*() prefix.
995 Also no longer implement TestCase, to avoid triggering support for
996 the junit3-way, which stops the annotations from working.
997 Change the imports from import junit.framework.* to
998 import org.junit.*, which is apparently the new way.
1000 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1002 Added a test for ListPlace token parsing and creation.
1004 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1005 This is much the same as DetailsPlaceTest.
1007 I wonder how we could test the other parts of the *Place API.
1009 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1011 DetailsPlace test: Also test getToken() and recreation via getPlace().
1013 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1014 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1015 recreate it, testing the recreated DetailsPlace for the same parameter
1018 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1020 Use the surefire-report plugin.
1022 * pom.xml: This generates a HTML report about the tests in
1023 target/site/surefire-report.html
1024 when you do mvn surefire-report:report. It seems to be popular/normal.
1026 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1028 Added a test for DetailsPlace.
1030 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1031 Test the getPlace() token parsing.
1033 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1035 Added a first unit test.
1037 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1038 * src/test/java/org/glom/web/shared/DataItemTest.java:
1039 This is a silly test but it is just to get things started. Note that
1040 maven/junit finds the test because it looks in src/test by default.
1042 2011-12-22 Ben Konrath <ben@bagu.org>
1044 Change charsetName to "UTF-8" when replacing line breaks.
1046 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1047 that work in Java (such as "UTF8") will not work when compiled to
1050 This fixes a problem with multi-line details view fields that have hard
1051 line breaks. The "License Text" field on this page demonstrates the
1054 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1056 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1058 2011-12-22 Ben Konrath <ben@bagu.org>
1060 Fix another bug with related list navigation.
1062 I've tested all the navigation buttons in all of the related lists
1063 so things should be good now.
1065 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1067 2011-12-22 Ben Konrath <ben@bagu.org>
1069 Fix a crasher when refreshing the list view with the default table.
1071 This crash will also happen when loading the list view with the default
1072 table from a link or bookmark.
1074 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1075 to the main document selection page when the document id hasn't been
1077 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1078 the main document selection page when the document id hasn't been
1080 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1081 values for the details place when the document id hasn't been set.
1082 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1083 values for the list place when the document id hasn't been set.
1085 2011-12-21 Ben Konrath <ben@bagu.org>
1087 Protect against NPE when glom.document.locale is not in config.
1089 This patch protects against an NPE when glom.document.locale is not in
1090 the config file. This NPE will also happen if glom.document.locale is
1093 The patch also updates the error message to display the class name when
1094 the getMessage() returns null. This was happening when the NPE was
1095 thrown and I had "Configuration Error: null". If an NPE is encountered
1096 with this patch, "Configuration Error: NullPointerException " will be
1099 This commit closes this bug:
1101 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1105 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1107 Rename onlineglom.properties to onlineglom.properties.sample.
1109 * src/main/resources/onlineglom.properties: Rename to:
1110 * src/main/resources/onlineglom.properties.sample:
1111 * src/main/resources/README: And add this file explaining that people
1112 should rename it back when deploying.
1114 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1116 Allow choosing the translation in the .properties file.
1118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1119 init(): Read a glom.document.locale value from the configuration file
1120 and call Glom's TransatableItem::set_current_locale() method.
1121 * src/main/resources/onlineglom.properties: Add a commented-out
1122 example of this new setting.
1124 It would be better to add &lang=de_DE to the URL, but the current
1125 libglom API does not allow us to do this easily. I am working on that.
1127 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1129 Avoid a crash in parsing of token parameters.
1131 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1132 ava: getTokenParams(): Do not crash if a parameter has a key but no
1133 value, and ignore parameters with neither.
1135 2011-12-17 Murray Cumming <murrayc@murayc.com>
1137 History token building/handling: Improve use of token parameters.
1139 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1140 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1141 and buildParamsToken(HashMap), for use by derived classes.
1142 Make the separator private because it is no longer be needed.
1143 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1144 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1145 instead of manual string concatenation.
1146 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1147 of hardcoded indices and awkward splitting code.
1148 * src/main/java/org/glom/web/client/place/ListPlace.java
1149 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1150 instead of manual string concatenation.
1151 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1152 of hardcoded indices and awkward splitting code.
1153 This should fix bug #666420
1155 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1157 Fix a Navgiation->Navigation typo in the code.
1159 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1160 Rename processNavgiation() to processNavigation().
1162 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1164 Fix a seperator->separator typo in the code.
1166 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1167 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1168 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1171 2011-12-15 Ben Konrath <ben@bagu.org>
1173 Cleanup some comments.
1175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1177 2011-12-14 Ben Konrath <ben@bagu.org>
1179 Replace \n with <br/> for multiline text in the details view.
1181 Vertical scrollbars are added when needed as well.
1183 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1185 2011-12-14 Ben Konrath <ben@bagu.org>
1187 Specify the font for document selection links.
1189 * src/main/webapp/style.css:
1191 2011-12-14 Ben Konrath <ben@bagu.org>
1193 Fix bouncy CellTable while paging.
1195 This doesn't currently work with related list tables in unselected
1198 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1200 2011-12-14 Ben Konrath <ben@bagu.org>
1202 Revamp the appearance of the document selection page.
1204 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1205 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1206 * src/main/webapp/style.css:
1208 2011-12-13 Ben Konrath <ben@bagu.org>
1210 Set navigation button column to the smallest size possible.
1212 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1214 2011-12-13 Ben Konrath <ben@bagu.org>
1216 Change OpenButton nomenclature to NavigationButton.
1218 Using NavigtionButton makes things more generic. Classes, methods and
1219 variables have been changed.
1221 This is a rename-only refactor.
1223 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1224 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1225 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1226 Renamed from OpenButtonCell.
1227 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1228 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1229 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1231 2011-12-12 Ben Konrath <ben@bagu.org>
1233 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1236 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1237 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1238 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1240 2011-12-12 Ben Konrath <ben@bagu.org>
1242 Update variable names and comments.
1244 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1245 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1247 2011-12-12 Ben Konrath <ben@bagu.org>
1249 Properly initialize numNonEmptyRows variable to zero.
1251 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1252 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1254 2011-12-05 Ben Konrath <ben@bagu.org>
1256 Add latest mockup with HTML tables.
1258 Features of this mockup:
1260 -> HTML table for flowtable
1261 -> HTML table for flowtable column
1262 -> Example of how related lists would look
1263 -> Not using text entries for data items
1265 The current version of Online Glom doesn't use HTML tables for the
1268 This mockup has been sent to the glom-devel mailing list but it's good
1269 to have it here as well.
1271 * mockups/details-view-html-tables.html:
1273 2011-12-05 Ben Konrath <ben@bagu.org>
1275 Remove unnecessary getPrimaryKeyField() method.
1277 getPrimaryKeyFieldForTable(String) has been renamed to
1278 getPrimaryKeyField(String).
1280 * src/main/java/org/glom/web/server/database/DBAccess.java:
1281 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1282 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1284 2011-12-05 Ben Konrath <ben@bagu.org>
1286 Add string representation of TypedDataItem value to conversion error message.
1288 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1289 message was extracted into its own method to avoid duplication.
1291 2011-12-05 Ben Konrath <ben@bagu.org>
1293 Add type checking to navigation primary key value creation.
1295 Create navigation primary key only if the expected type from the Glom
1296 document matches the type returned by the SQL query.
1298 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1300 2011-12-05 Ben Konrath <ben@bagu.org>
1302 Rename a couple of variables in RelatedListNavigation.
1304 This is a rename-only refactor.
1306 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1308 2011-12-05 Ben Konrath <ben@bagu.org>
1310 Move getListLayoutGroup() into getListViewLayoutGroup().
1312 This removes getListLayoutGroup(). It was only being called by
1313 getListViewLayoutGroup().
1315 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1317 2011-12-05 Ben Konrath <ben@bagu.org>
1319 Remove check for LayoutItem_Portal in list table method.
1321 This check is no longer necessary because the method isn't being used
1322 to create the LayoutItemPortal DTO.
1324 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1326 2011-12-05 Ben Konrath <ben@bagu.org>
1328 Properly support related list navigation.
1330 Navigation from the "Repository Analyzer -> Package Scans ->
1331 Dependencies" related table wasn't working because the primary key for
1332 related tables wasn't being set properly. This commit fixes the
1335 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1336 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1337 doesn't set the primary key properly for related list tables.
1338 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1339 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1340 useful for getting the primary key for list view tables and for related
1342 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1343 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1344 Move code to set the primary key for the table from the abstract
1345 ListDBAccess class to ListViewDBAccess as it's only correct for list
1347 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1348 Properly add primary key to related list tables.
1350 2011-12-02 Ben Konrath <ben@bagu.org>
1352 Properly set the horizontal alignment of fields.
1354 This fix is for both the list tables and the details view.
1356 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1357 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1358 to set the horizontal alignment of fields.
1360 2011-12-02 Ben Konrath <ben@bagu.org>
1362 Display currency codes in the details view.
1364 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1366 2011-12-02 Ben Konrath <ben@bagu.org>
1368 Avoid duplicate JNI call.
1370 JNI is not as efficient as pure Java and this is an easy (and small)
1373 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1374 Use previously retrieved value for whereClauseToTableName instead of
1377 2011-12-02 Ben Konrath <ben@bagu.org>
1379 Rename a couple of variables in RelatedListNavigation.
1381 This is a rename-only refactor.
1383 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1385 2011-12-02 Ben Konrath <ben@bagu.org>
1387 Indicate clearly that a mismatched primary key type is a bug.
1389 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1390 warning to error. Add 'This is a bug.' to message.
1392 2011-12-02 Ben Konrath <ben@bagu.org>
1394 Update / fix some comments.
1396 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1398 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1400 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1401 Fix comments. Add some TODOs.
1403 2011-12-02 Ben Konrath <ben@bagu.org>
1405 Enable navigation to details view with string primary key from related list.
1407 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1408 Create a text primary key value when return type of result is
1409 java.sql.Types.VARCHAR.
1411 2011-12-02 Ben Konrath <ben@bagu.org>
1413 Use checkboxes for booleans in the details view.
1415 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1417 2011-12-01 Ben Konrath <ben@bagu.org>
1419 Improve performance of related list height calculation.
1421 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1422 Put code to calculate the expected height in a static initializer so
1423 that that it's only called once.
1425 2011-12-01 Ben Konrath <ben@bagu.org>
1427 Show related list tables in notebooks (again).
1429 Calculate the height of the related list tables so the Notebook can be
1430 set the correct height. The height of the related list table is also needed by
1431 FlowTable to be able decide how to create the layout.
1433 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1434 and set the Portal height based on the height of the related list
1435 table and the Portal container.
1436 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1437 Add method to calculate the height of the related list tables.
1438 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1439 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1440 calculate the height of the Pager widget.
1442 2011-12-01 Ben Konrath <ben@bagu.org>
1444 Use CellTable API for table property instead of setting style on Element.
1446 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1448 2011-12-01 Ben Konrath <ben@bagu.org>
1450 Make ListViewTable and RelatedListTable a consistent height.
1452 The tables are now a consistent height regardless of the contents of
1453 the table. A hidden button is added to empty rows to ensure that the
1454 height of these rows will match the height of rows with data.
1456 A navigation button column is now added to every table. The width of
1457 the navigation column is set to 0px when a RelatedListTable shouldn't
1458 have navigation buttons. This maintains the a consistent row height in
1459 tables that don't show the navigation buttons.
1461 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1462 navigation column when not needed.
1463 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1464 arguments for navigation button to constructor of ListViewTable.
1465 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1466 hidden button for empty data rows.
1467 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1468 arguments for navigation button to constructor.
1469 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1470 create navigation buttons. Add hideNavigationButtons() method.
1471 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1472 arguments for navigation button to constructor.
1474 2011-12-01 Ben Konrath <ben@bagu.org>
1476 Use 'visibility: hidden' in Utils.getWidgetHeight().
1478 This is better choice because hidden elements are invisible, don't
1479 respond to events and are not part of the tab order. They will,
1480 however, take up space which is required to be able to calculate the
1481 height of the widget.
1483 * src/main/java/org/glom/web/client/Utils.java:
1485 2011-12-01 Ben Konrath <ben@bagu.org>
1487 Use Utils.getWidgetHeight() in FlowTable.
1489 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1491 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1493 2011-12-01 Ben Konrath <ben@bagu.org>
1495 Put the details css class name on the correct table column.
1497 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1499 2011-11-30 Ben Konrath <ben@bagu.org>
1501 Update for java-libglom API change.
1503 The getters and setters on FieldFormatting and NumericFormat were
1504 changed to remove the 'M'.
1506 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1508 2011-11-29 Ben Konrath <ben@bagu.org>
1510 Only allow RelatedListTables in Portals.
1512 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1514 2011-11-29 Ben Konrath <ben@bagu.org>
1516 Only create a contents panel for Portals when title is being set.
1518 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1520 2011-11-29 Ben Konrath <ben@bagu.org>
1522 Set TabLayoutPanel height based on calculated height its widgets.
1524 This is a potential fix for this bug:
1526 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1528 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1530 2011-11-29 Ben Konrath <ben@bagu.org>
1532 Align details field labels and data with the Open buttons.
1534 * src/main/webapp/style.css:
1536 2011-11-29 Ben Konrath <ben@bagu.org>
1538 Remove unnecessary <div> in the Notebook widget.
1540 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1541 method to get container FlowPanel (<div>).
1542 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1543 initWidget() method directly on the TabLayoutPanel widget instead of
1544 Group's container widget.
1546 2011-11-29 Ben Konrath <ben@bagu.org>
1548 Don't add group titles for Portals in Notebooks.
1550 This reverts the previous patch and fixes a bug I introduced with
1551 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1553 * src/main/java/org/glom/web/client/ui/details/Group.java:
1554 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1556 2011-11-28 Ben Konrath <ben@bagu.org>
1558 Remove unused boolean argument in Portal constructor.
1560 Just a code cleanup.
1562 * src/main/java/org/glom/web/client/ui/details/Group.java:
1563 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1565 2011-11-28 Ben Konrath <ben@bagu.org>
1567 Remove hack for glom 1.18 style glom files.
1569 * src/main/java/org/glom/web/client/ui/details/Group.java:
1570 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1571 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1573 2011-11-28 Ben Konrath <ben@bagu.org>
1575 Use Gda Value version of primary key to log result too large error.
1577 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1579 2011-11-28 Ben Konrath <ben@bagu.org>
1581 Don't use TypedDataItem.getText() for Unknown types from the URL.
1583 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1584 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1585 instead of getText().
1586 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1587 String field and getUnknown() method.
1589 2011-11-28 Ben Konrath <ben@bagu.org>
1591 Log an error message when the java-libglom .so is not present.
1593 The error message was being set in the exception but not logged.
1595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1597 2011-11-28 Ben Konrath <ben@bagu.org>
1599 Ignore LayoutItem_CalendarPortals.
1601 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1602 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1604 2011-11-28 Ben Konrath <ben@bagu.org>
1606 Extract method for creating the LayoutItemPortal DTO.
1608 Just breaking the code up into smaller chunks.
1610 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1612 2011-11-28 Ben Konrath <ben@bagu.org>
1616 This should have been added with the refactor. Oops!
1618 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1620 2011-11-28 Ben Konrath <ben@bagu.org>
1622 Create primary key value from URL string using type from Glom document.
1624 See this bug, comments 19 - 25:
1626 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1628 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1629 create a TypeDataItem for the primary key here when loading from a
1630 URL. Show the same string for the primary key value as was received
1631 from the URL string (when loading from a URL).
1632 * src/main/java/org/glom/web/server/Utils.java: Update method for
1633 creating the Gda Value from the TypeDataItem to properly deal with
1634 creating a Gda Value based on the Glom document type for the primary
1635 key value string when loading from a URL.
1636 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1637 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1638 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1639 Update for changed method name.
1641 2011-11-27 Ben Konrath <ben@bagu.org>
1643 Rename PrimaryKeyItem to TypedDataItem.
1645 The name PrimaryKeyItem suggests what the class should be used for.
1646 TypedDataItem is a neutral name that describes the class better.
1648 This is a rename-only refactor.
1650 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1651 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1652 * src/main/java/org/glom/web/client/Utils.java:
1653 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1654 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1655 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1656 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1657 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1658 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1660 * src/main/java/org/glom/web/server/Utils.java:
1661 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1662 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1663 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1664 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1666 2011-11-25 Ben Konrath <ben@bagu.org>
1668 Improve Gda Value conversion from PrimaryKeyItem.
1670 The value from the PrimaryKeyItem is only used if its type match the
1671 type from the glom document.
1673 * src/main/java/org/glom/web/server/Utils.java:
1675 2011-11-25 Ben Konrath <ben@bagu.org>
1677 Manually check if the java-liblgom .so is visible to the JVM.
1679 It seems that Tomcat has problems when a static initializer throws an
1680 exception. This check is done before the first method call into
1681 java-libglom so that execution doesn't continue if the .so is not
1684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1686 2011-11-25 Ben Konrath <ben@bagu.org>
1688 Improve browser configuration error messages.
1692 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1694 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1695 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1696 getConfigurationErrorMessage() method.
1697 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1698 Get and display a specific configuration error message when no Glom
1699 documents are found.
1700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1701 Implement getConfigurationErrorMessage() method. Surround configuration
1702 code in the init() method with a try/catch block. This allows the
1703 errors to be caught while keeping the servlet available to retrieve the
1704 configuration error message.
1706 2011-11-25 Ben Konrath <ben@bagu.org>
1708 Don't use Strings to hold primary key values.
1710 The primary key values are now held in a new data object
1711 (PrimaryKeyItem) that holds type information and the primary key value
1712 using the correct type.
1714 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1715 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1716 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1717 PrimaryKeyItem instead of String to hold the primary key value.
1718 * src/main/java/org/glom/web/client/Utils.java: Remove
1719 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1720 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1721 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1722 PrimaryKeyItem instead of String to hold the primary key value. Load
1723 document selection page when the documentID has not been set correctly.
1724 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1725 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1727 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1728 Return empty string for URL instead of "null".
1729 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1730 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1731 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1732 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1733 PrimaryKeyItem instead of String to hold primary key values.
1734 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1735 PrimaryKeyValue to a Gda Value.
1736 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1737 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1738 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1739 Replace temporary database access code that uses the PrimaryKeyValue to
1740 Gda Value conversion.
1741 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1742 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1743 PrimaryKeyItem instead of String.
1744 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1745 hold primary key values.
1747 2011-11-24 Ben Konrath <ben@bagu.org>
1749 Use newly added java-libglom API to create queries.
1751 This isn't finished. I still need to stop using Strings for primary key
1752 values in the client code.
1754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1755 libglom to use fake connections so that retrieving the query string will
1757 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1758 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1759 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1760 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1761 Use the newly added libglom sql methods and classes to create the
1762 query. Add temporary hack to convert primary value strings to Gda
1765 2011-11-23 Ben Konrath <ben@bagu.org>
1767 Don't explicitly set the height of Portals.
1769 See comments 6 - 10 of this bug for details:
1771 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1773 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1775 2011-11-23 Ben Konrath <ben@bagu.org>
1777 Use an HTML table instead of CSS for the FlowTable layout.
1779 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1780 GWT's FlexTable to implement the FlowTable.
1781 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1783 2011-11-18 Ben Konrath <ben@bagu.org>
1785 Add boolean example to HTML table mockup.
1787 * mockups/details-view-html-tables-text-entries.html:
1789 2011-11-17 Ben Konrath <ben@bagu.org>
1791 Ensure the pager buttons are always visible for related lists.
1793 To accomplish this, I've turned off text wrapping in the list view and
1794 related list tables for both the header and data text. The related list
1795 table now has a fixed layout so the it doesn't overflow its container.
1796 This is required to ensure that the cell text is clipped when it
1797 overflows the cell and an ellipsis is added to the right side of the
1798 cell when text is clipped.
1800 A fixed table layout for the related list table in the details view
1801 seems what we want for the details view anyway, so the side-effect is
1804 The ellipsis will only be displayed in Firefox >= 7.
1808 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1810 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1811 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1812 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1814 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1815 Set the 'table-layout: fixed' CSS property to the related list table.
1816 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1817 'white-space: nowrap;' CSS property on both the list view and the
1818 related list tables.
1820 2011-11-16 Ben Konrath <ben@bagu.org>
1822 Rework the fix for empty notebook tab labels.
1824 Setting the empty group titles with its name caused problems for the
1825 details layout. Instead of using libglom's
1826 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1827 to the client when the title is empty. This allows the Notebook to use
1828 the name when the title is empty without affecting anything else.
1830 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1831 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1833 2011-11-16 Ben Konrath <ben@bagu.org>
1835 Set group titles with name when title is empty.
1837 This fixes a problem with an empty notebook tab label in the Lesson
1838 Planner document. The forth tab in the notebook should be "Internet":
1840 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1842 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1843 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1846 2011-11-16 Ben Konrath <ben@bagu.org>
1848 Remove whitespace from the configured username properties.
1850 This assumes that usernames won't have whitespace at the beginning
1851 or end. But I think this is a reasonable assumption.
1853 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1854 String.trim() to remove the whitespace from the username properties.
1856 2011-11-15 Ben Konrath <ben@bagu.org>
1858 Add details view mockup with HTML tables and text entries.
1860 This is from the attachment on this bug:
1862 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1864 * mockups/details-view-html-tables-text-entries.html:
1866 2011-11-15 Ben Konrath <ben@bagu.org>
1868 Add space between the columns of the flow table.
1872 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1874 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1875 space between columns in the flow table.
1877 2011-11-15 Ben Konrath <ben@bagu.org>
1879 Add backup files to the .gitignore.
1881 * .gitignore: Ignore files that end with ~.
1883 2011-11-09 Ben Konrath <ben@bagu.org>
1885 Use latest release of gwt-log.
1887 Gwt-log releases are now being submitted to the maven central
1888 repository so manual installation of the jar is no longer required.
1890 * pom.xml: Update version and groupId of gwt-log dependency.
1892 2011-10-31 Ben Konrath <ben@bagu.org>
1894 Don't use GWT numeric formatting to override the glom currency formatting.
1896 Currencies are now displayed like they are in Glom. See this bug:
1898 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1900 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1902 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1903 currency code to constructor and set it when the cell is rendered.
1904 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1905 currency code to the constructor of the NumericCell.
1907 2011-10-27 Ben Konrath <ben@bagu.org>
1909 Require the latest release of java-libglom (1.17.4).
1913 2011-10-26 Ben Konrath <ben@bagu.org>
1915 Add style to Notebook that matches current theme.
1917 It's not the best style in the world but it's better than the default.
1919 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1920 padding at the bottom of the child widgets.
1921 * src/main/webapp/style.css: Add style for the Notebook.
1923 2011-10-26 Ben Konrath <ben@bagu.org>
1925 Move servlet initialization code to overridden init method.
1927 This is half of the solution to getting proper error messages
1928 displayed when configuration errors occur. Here's the relevant bug:
1930 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1932 The rest of the solution involves surrounding the init method with a
1933 try/catch block and setting a global variable with the error /
1934 exception. A new async method should be created to retrieve and display
1935 the error message / exception.
1937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1938 code from constructor to init method adding exceptions as needed.
1940 2011-10-26 Ben Konrath <ben@bagu.org>
1942 Add script to monitor and restart tomcat if required.
1944 * utils/check-and-recover-tomcat.py: New file.
1946 2011-10-26 Ben Konrath <ben@bagu.org>
1948 Display the correct number of data items in the pager.
1952 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1954 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1955 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1956 The implementation is the same for both tables: Keep track of the
1957 number of non-empty rows and fire and RowCountChangeEvent after the data has
1959 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1960 custom Pager class that subclasses SimplePager to handle displaying
1961 the correct number when empty rows have been added.
1963 2011-10-26 Ben Konrath <ben@bagu.org>
1965 Correct error in previous commit.
1967 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1968 eventBus parameter from listView.setCellTable().
1970 2011-10-26 Ben Konrath <ben@bagu.org>
1972 Fix error in TODO comment.
1974 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1976 2011-10-24 Ben Konrath <ben@bagu.org>
1978 Create Notebook widgets to the details view.
1980 This isn't finished just yet - I still need to create a reasonable
1981 style to match the current theme.
1983 * src/main/java/org/glom/web/client/Utils.java: Add method for
1984 calculating the height of a widget. This is used in the Notebook class.
1985 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1986 new constructor method in Group.
1987 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1988 method for creating child widget that can be used by subclasses
1989 like Notebook. New constructor that allows disabling the group
1990 titles - Notebooks don't set a group title for their child groups.
1991 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1992 to make Notebooks using GWT's TabLayoutPanel.
1993 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1994 constructor that allows disabling the group titles.
1995 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1996 LayoutItemNotebook DTO.
1997 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1998 DTO for Notebooks. It's just an empty class for now but we might need
1999 it to transfer some specific information in the future.
2001 2011-10-21 Ben Konrath <ben@bagu.org>
2003 Add navigation buttons to related list tables.
2005 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2006 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2008 method getSuitableRecordToViewDetails() for getting the table name
2009 and primary key value for related list navigation buttons.
2010 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2011 private cell renderer class to get the navigation information for
2012 related list tables from the server. Extract the navigation
2013 processing code from the details cell navigation and use it for the
2014 related list navigation as well.
2015 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2016 cell renderer class for the details open buttons. This was needed
2017 because the related list navigation buttons and the list view
2018 navigation buttons need to react differently when clicked.
2019 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2020 the onEnterKeyDown() method because it's now overriden in the
2021 subclasses that are specific to the related list tables and the list
2023 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2024 the vertical size a little because the buttons add a bit of vertical
2025 space to table. This is not a perfect solution because the vertical
2026 size of with table fewer than 5 rows will be a little smaller.
2027 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2028 changes in how navigation buttons are handled.
2029 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2030 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2031 database access object.
2032 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2033 to find the portal for a given relationship name from
2034 RelatedListDBAccess. Add method to find a primary key field for a
2036 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2037 Move code to find the portal for a given relationship name to
2039 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2040 New file: database access object for getting the related list
2041 navigation information (the table name and the primary key value).
2042 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2043 DTO for transferring a table name to navigate to and a primary key
2045 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2046 boolean and getter/setter to specifies if the related list should add
2049 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2051 Use the master branch of java-libglom
2053 * pom.xml: Depend on java-libglom 1.19 instead.
2055 This is the master branch. See also the libglom-1-18 branch.
2057 2011-10-11 Ben Konrath <ben@bagu.org>
2059 Enable the open navigation button when the data has been set.
2061 This avoids having active buttons that don't do anything when the data
2064 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2066 2011-10-11 Ben Konrath <ben@bagu.org>
2068 Use IsWidget interface for FlowTableItem.
2070 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2071 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2073 2011-10-11 Ben Konrath <ben@bagu.org>
2075 Remove GWT styling from open button in details view.
2077 There are still some issues with how the details cell is arranged but
2078 this should be made to match Glom 1.20. I'm going to leave fixing this
2079 until I have Glom 1.20 up and running.
2081 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2082 style name on open button.
2083 * src/main/webapp/style.css: Move and edit details-navigation class.
2084 Re-arrange some classes to make them appear in the same order as the
2087 2011-10-07 Ben Konrath <ben@bagu.org>
2089 Update to GWT 2.4.0.
2091 * .gitignore: Ignore new cache directory.
2092 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2093 * pom.xml: Change GWT and maven plugin to 2.4.0.
2094 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2096 * src/main/java/org/glom/web/client/ClientFactory.java:
2097 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2098 * src/main/java/org/glom/web/client/OnlineGlom.java:
2099 Update source for API changes.
2100 * utils/build-onlineglom-war.sh: Remove cache directory before the
2103 2011-10-07 Ben Konrath <ben@bagu.org>
2105 Add navigation buttons in the details view.
2107 This isn't finished but I thought I'd commit what I have as it's a
2108 pretty good start. I still need to:
2110 1. Change the style so that it fits better into the current theme
2111 2. Adjust the details cell to expand as much as possible.
2113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2114 click handlers to navigation buttons in the DetailsCells. Create a
2115 refreshData() method to get just the data from the server without the
2117 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2118 Update the tableSelector and browser title when the table name
2119 changes without using the tableSelector.
2120 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2121 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2122 getDetailsCells() to getCells(). Update variable names.
2123 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2124 method to set click handler on navigation button. Rename a few
2125 variables. Add navigation buttons where needed.
2126 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2127 variables and methods.
2128 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2129 navigation boolean and navigation table as required in the
2130 LayoutItemField DTO.
2131 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2132 variables for navigation along with getter/setter methods.
2134 2011-10-07 Ben Konrath <ben@bagu.org>
2136 Rename Field to DetailsCell.
2138 This is a refactor-only commit. No functionality has been added or
2141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2142 Update variable and method names.
2143 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2144 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2145 variable and method names.
2146 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2148 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2149 variable and method names.
2151 2011-10-07 Ben Konrath <ben@bagu.org>
2153 Create separate methods for layout and data the details view.
2155 This is a refactor-only commit. No functionality has been added or
2158 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2159 private methods: setData(), createLayout().
2161 2011-10-07 Ben Konrath <ben@bagu.org>
2163 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2165 This is part of a change to get navigation buttons in the details view
2166 but it should have been done this way from the start.
2168 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2169 for method name change in TableSelectionView.
2170 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2171 Create TableChangeEvent and set the browser title using the
2172 TableSelectionView API.
2173 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2174 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2175 Change getSelectedTable() to getSelectedTableName(). Add
2176 getSelectedTableTitle().
2178 2011-10-07 Ben Konrath <ben@bagu.org>
2180 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2182 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2184 2011-10-07 Ben Konrath <ben@bagu.org>
2186 Update TableChangeEvent to use newTableName naming convention.
2188 This makes the class more consistent with GWT naming conventions.
2190 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2191 Update for method name change in TableChangeEvent.
2192 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2193 for method name change in TableChangeEvent.
2194 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2195 newTableName variable and getter method. Make toDebugString()
2198 2011-09-30 Ben Konrath <ben@bagu.org>
2200 Disable the pager in the list tables when the data row count is less than the minimum.
2202 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2203 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2205 2011-09-30 Ben Konrath <ben@bagu.org>
2207 Add empty rows to the end of related list and list view tables.
2209 I also extracted the cell rendering classes from the ListTable because
2210 the code was becoming a little crazy with all the anonymous inner
2211 classes. My plan is to use these cell rendering classes in the details
2212 view as well so this refactor will be needed for that change.
2214 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2215 set the row count in related list tables if the data has more rows
2216 than the minimum number of rows visible.
2217 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2218 row count in list view tables if the data has more rows than the
2219 minimum number of rows visible.
2220 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2221 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2223 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2224 for rendering TYPE_NUMERIC cells. The code was extracted from the
2226 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2227 class for rendering cells with buttons in list views. The code was
2228 extracted from the ListTable class.
2229 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2230 for rendering TYPE_TEXT cells. The code was extracted from the
2232 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2233 Add empty rows to the end of the data if required. Implement
2234 ListTable.getMinNumVisibleRows().
2235 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2236 cell renderer code to public classes. Return null in
2237 Column.getValue() for empty rows. Add new abstract method:
2238 getMinNumVisibleRows(). Move code to set the row count of the list view
2239 table to ListViewImpl.
2240 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2241 empty rows to the end of the data if required. Implement
2242 ListTable.getMinNumVisibleRows().
2245 2011-09-27 Ben Konrath <ben@bagu.org>
2247 Use GWT.log for client-side debugging statements.
2249 These are optimized out when deployed so I should have used this method
2250 in the first place. These statements will eventually be replaced with some sort
2251 of notification in the browser.
2253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2254 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2255 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2257 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2259 2011-09-27 Ben Konrath <ben@bagu.org>
2261 Put tableselector on the right, back to list link on right.
2263 The idea is that the table selector is acting like a label for the
2264 currently displayed table so it should be placed below the document title. This
2265 puts the table title in a similar position to where it is in Glom.
2267 * mockups/details-contacts.html:
2268 * mockups/details-projects.html:
2269 * mockups/listview-contacts.html:
2270 * mockups/listview-projects.html:
2271 * mockups/style.css:
2272 Update mockups to match how the interfaces currently look.
2273 * src/main/webapp/style.css: Swap positions of backlink with the table
2274 selector. Add some space on the left side of the table selector to
2275 line things up with the document title.
2277 2011-09-27 Ben Konrath <ben@bagu.org>
2279 Add field colouring to details view.
2281 This change re-works how field colouring works. The colour formatting
2282 information is now set to the client with the layout information instead of
2283 with the data. This eliminates the need to send the same colour strings for
2284 data in list view column when colour information is set.
2286 In order to set an alternate colour for negative numeric values, the
2287 number is now sent to client and formatted with the GWT NumberFormat class.
2289 This change also fixes:
2291 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2293 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2294 internationalization framework which is needed for client side numeric
2296 * src/main/java/org/glom/web/client/Utils.java: New file for some
2297 client static utility methods.
2298 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2299 the DataItem object to the Field class. Use a utility method to
2300 create the foreignKeyValue string.
2301 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2302 alignment and text colours in the constructor. Add setData(DataItem)
2303 method. Remove setText(String) method.
2304 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2305 colour information to GlomTextCell. Create and use GlomNumberCell for
2306 rendering numbers. Use utility method to get the string for the
2307 primary key of the key provider. Re-work how the horizontal alignment
2309 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2310 formatting to layout information. Methods for converting the libglom
2311 formatting information were moved from DBAccess.
2312 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2313 numeric formatting (it's now done on the client side). Don't set text
2314 colours in DataItem. Move libglom formatting conversion methods to
2316 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2317 getters/setters for text colour information.
2318 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2319 for transferring the libglom NumericFormat information to the client.
2320 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2321 and getters/setters for: GlomNumericFormat, background colour and
2322 foreground colour strings.
2324 2011-09-26 Ben Konrath <ben@bagu.org>
2326 Simplify code that iterates through the LayoutGroup.
2328 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2330 2011-09-26 Ben Konrath <ben@bagu.org>
2332 Accept Eclipse formatting for OnlineGlomServiceAsync.
2334 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2336 2011-09-26 Ben Konrath <ben@bagu.org>
2338 Don't use the ListDBAccess classes to get the primary key layout information.
2340 This was causing a bug where the wrong index for the hidden primary key
2341 was being sent to the client.
2343 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2344 primary key while creating the LayoutGroup DTO. Create a
2345 LayoutItemField DTO for hidden primary keys. Don't use the
2346 RelatedListDBAccess because it was only used for getting the primary
2348 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2349 access modifier from public to protected for getPrimaryKeyField() and
2350 getPrimaryKeyLayoutItemField().
2351 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2352 abstract method getExpectedResultSize() because RelatedListDBAccess
2353 doesn't have enough info to implement it.
2354 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2355 Remove @Override for getExpectedResultSize().
2356 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2357 Remove method getExpectedResultSize().
2359 2011-09-23 Ben Konrath <ben@bagu.org>
2361 Log which layout (list or details) the ignored item is from.
2363 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2365 2011-09-23 Ben Konrath <ben@bagu.org>
2367 Remove annotations that turn off code formatting in DataItem.
2369 * src/main/java/org/glom/web/shared/DataItem.java:
2371 2011-09-23 Ben Konrath <ben@bagu.org>
2373 Rename GlomField to DataItem and update associated methods.
2375 This is a rename-only refactor. No functionality has been added or
2378 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2379 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2381 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2382 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2383 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2384 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2385 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2387 * src/main/java/org/glom/web/server/database/DBAccess.java:
2388 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2389 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2390 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2391 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2392 * src/main/java/org/glom/web/shared/DataItem.java:
2393 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2394 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2396 2011-09-23 Ben Konrath <ben@bagu.org>
2398 Rename GlomDocument to DocumentInfo and update associated methods.
2400 This is a rename-only refactor. No functionality has been added or
2403 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2404 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2405 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2407 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2408 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2409 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2411 2011-09-20 Ben Konrath <ben@bagu.org>
2413 Require java-libglom 1.17.3.
2415 This picks up the fix for the seg fault problem with the Scenes table
2416 in the Openismus Film Manager example.
2420 2011-09-20 Ben Konrath <ben@bagu.org>
2422 Change the way sort clause is added for primary key when no sort clause is requested.
2424 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2425 before the sort clause is created. When a sort clause is not requested, the
2426 sort clause is created by finding the primary key in the LayoutFieldVector
2429 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2431 2011-09-20 Ben Konrath <ben@bagu.org>
2433 Log error message if no documents are found in the configured directory.
2435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2436 Extract the glom file extension string to a private static final class
2437 variable (mostly as syntactic sugar). Accept a minor formatting change.
2438 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2439 the example glom.document.directory configuration property to make it
2440 more clear that it can any directory, not just the home directory.
2442 2011-09-18 Ben Konrath <ben@bagu.org>
2444 Add related lists to details view.
2446 The related list table has support for paging and sorting just like the
2447 table in the list view.
2449 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2450 SQL queries for the related list tables.
2451 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2452 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2453 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2454 Rename getList methods to getListView and add comments. Remove
2455 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2456 it being unused. Add methods: getDetailsLayoutAndData(),
2457 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2458 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2459 Create the layout and set the data for the fields in one async call
2460 instead of two. Create related lists where appropriate.
2461 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2462 for method name changes in OnlineGlomService.
2463 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2464 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2465 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2467 * src/main/java/org/glom/web/client/ui/ListView.java:
2468 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2469 tableName from setCellTable(). Create a ListViewTable instead of
2471 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2472 represent a data field in the details view.
2473 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2474 from addDetailsCell() to Field class. Keep track of the Fields and
2475 Portals in the details view.
2476 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2477 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2478 and add a method to get it. Add method to set the contents of the
2480 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2481 New class for related list tables. This class has the data provider
2482 for the related list table.
2483 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2484 abstract class which is the base class for the ListViewTable and the
2486 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2487 New class for list view tables. This class has the data provider for
2488 the list view table.
2489 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2490 methods for related list tables. Add more information to the
2491 LayoutItemField and LayoutItemPortal DTOs.
2492 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2493 Remove debugging print statement.
2494 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2495 Remove debugging print statements. Add primary key field to SQL count
2497 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2498 Remove unnecessary LayoutFieldVector parameter from
2499 getResultSizeOfSQLQuery() method.
2500 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2501 New class for related list table database access.
2502 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2503 class that is a wrapper DTO for details view layout and data.
2504 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2505 new 'fromField' string to this DTO.
2506 * src/main/webapp/style.css: Remove bottom margin and override top
2509 2011-09-15 Ben Konrath <ben@bagu.org>
2511 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2513 This sets things up to make it easier to add the data retrieval for
2514 related lists (portals). No user noticeable changes were made with
2517 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2518 class has the code to retrieve the layouts and access the
2519 database using the new database helper classes.
2520 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2521 Most of the functionality has been removed from this class. This
2522 class now represents the public interface for the client side
2523 code. It also deals with configuring the servlet and cleaning
2524 things up when the servlet is stopped.
2525 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2526 of static methods into this utility class.
2527 * src/main/java/org/glom/web/server/database/DBAccess.java:
2528 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2529 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2530 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2531 These classes have the database retrieval code. The class hierarchy
2532 has been setup to make it easy to reuse code for similar
2535 2011-09-06 Ben Konrath <ben@bagu.org>
2537 Create separate classes for list table code and the data provider.
2539 As part of this refactor, I also split up the code a bit to make it
2542 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2543 table code to two new classes (below).
2544 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2545 with code from ListViewImpl.
2546 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2547 New file with code from ListViewImpl.
2549 2011-09-06 Ben Konrath <ben@bagu.org>
2551 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2553 This fixes the LayoutItemPortal DTO to match the libglom layout object
2556 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2558 2011-09-01 Ben Konrath <ben@bagu.org>
2560 Set title of Portals in the Details View.
2562 * pom.xml: Bump required version of java-libglom to 1.17.1.
2563 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2564 widget creation to its own class. Add comments to constructor.
2565 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2566 The code is mostly from the Group class with the title now set.
2567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2568 title of Portal. Update some comments. Fix some code formatting.
2570 2011-09-01 Ben Konrath <ben@bagu.org>
2572 Remove TODO comment for the flow table column width.
2574 The flow table column width is working correctly and doesn't need to be
2575 changed. See this mailing list post for more info:
2577 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2579 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2581 2011-08-27 Ben Konrath <ben@bagu.org>
2583 Add document title (database name) to top of the browser page.
2585 I added the document title to the TableSelecitonView but that will
2586 change if / when we add a view that doesn't require table selection.
2588 * mockups/details-contacts.html:
2589 * mockups/details-projects.html:
2590 * mockups/listview-contacts.html:
2591 * mockups/listview-projects.html:
2592 * mockups/style.css: Add document title to mockups to keep things
2594 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2595 sizes to account for the document title.
2596 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2597 Set the document title when it has been retrieved from the server.
2598 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2599 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2600 and implement setDocumentTitle(String) method.
2601 * src/main/webapp/style.css: Add ID for document title style.
2603 2011-08-25 Ben Konrath <ben@bagu.org>
2605 Add NavigationType enum to LayoutItemPortal DTO.
2607 This is the start of adding support for Portals to the Details View.
2609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2610 LayoutItem_Portal.navigation_type enum from libglom to
2611 LayoutItemPortal.NavigationType enum.
2612 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2613 NavigationType enum, field for storing the NavigationType and getter
2616 2011-08-25 Ben Konrath <ben@bagu.org>
2618 Implement the flow table layout in the Details View.
2620 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2621 FlowTable to Group to account for the renamed class.
2622 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2623 File. This is a container widget that implements the Glom details view
2624 flow table behaviour.
2625 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2626 org/glom/web/client/ui/FlowTable.java.
2627 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2628 so that the size of the subgroups are a closer match to the size of
2629 the Glom subgroups. This makes the flowtable layout match the layout
2630 in Glom for the Music Collection example file.
2632 2011-08-16 Ben Konrath <ben@bagu.org>
2634 Create container element for LayoutItemPortal in Details View.
2636 This will help me develop the layout for the FlowTable.
2638 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2639 fieldPanel variable to detailsCell.
2641 2011-08-15 Ben Konrath <ben@bagu.org>
2643 Set the height of the data element in the Details View.
2645 I changed the InlineLabels (text in a span element) to Labels (text in
2646 a div element) so that I could set the height of the details-data
2647 elements instead of the details-cell parent elements. This allows the
2648 the details-data element to display the correct height if style is
2649 applied that shows the height.
2651 This change has the added benefit of allowing the order of the labels
2652 and data elements to be changed for right-to-left languages.
2654 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2655 InlineLabels to Labels.
2656 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2657 InlineLabels to Labels. Set the height of the data element.
2658 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2659 multiline text height in the Formatting DTO.
2660 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2661 for multiline height along with getter and setter methods.
2662 * src/main/webapp/style.css: Adjust style to account for the change
2663 from span elements to div elements in the details cell.
2665 2011-08-15 Ben Konrath <ben@bagu.org>
2667 Make the List View appearance match the mockups.
2669 It doesn't match exactly but it's much better than it was.
2671 * mockups/listview-contacts.html: Remove unused css classes.
2672 * mockups/listview-projects.html: Remove unused css classes.
2673 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2674 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2675 for mainPanel instead of VerticalPanel (table). Set style name on
2676 CellTable. Set style name on Details column. Right-align Details
2678 * src/main/webapp/style.css: Adjust properties to match the mockups.
2680 2011-08-12 Ben Konrath <ben@bagu.org>
2682 Add better support for subgroups in the details view.
2684 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2685 changed FlowTable constructor.
2686 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2687 support for subgroups and subgroup-titles.
2688 * src/main/webapp/style.css: Add CSS class for subgroups and
2691 2011-08-12 Ben Konrath <ben@bagu.org>
2693 Return the top level LayoutGroup title.
2695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2697 2011-08-11 Ben Konrath <ben@bagu.org>
2699 Make the TableSelector header match the mockup.
2701 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2702 the layout panel. Properly lineup the table selection header with
2703 the list and details view.
2704 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2705 margin around the details view.
2706 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2707 Rename listBox variable to tableSelector. Set id for the style sheet.
2708 Use a FlowPanel instead of a HorizontalPanel.
2709 * src/main/webapp/style.css: Add properties to make the TableSelector
2710 box match the mockups.
2712 2011-07-13 Ben Konrath <ben@bagu.org>
2714 Update install script for java-libglom version change.
2716 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2719 2011-07-13 Ben Konrath <ben@bagu.org>
2721 Add support sub-group in the details view.
2723 I also removed the code that special-cased the default details view
2726 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2728 I still have to make a proper flowtable.
2730 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2731 Don't special-case default details view layout.
2732 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2733 addLayoutField() as I'm going to use it.
2734 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2735 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2737 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2738 extracted from DetailsViewImpl.GroupPanel. Add support for
2740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2741 column count when getting the details layout.
2743 2011-07-12 Ben Konrath <ben@bagu.org>
2745 Set browser title with database and table titles.
2747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2748 Set the browser title when the table changes and when the activity
2750 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2751 title when retrieving document info (the GlomDocument object).
2752 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2753 with getter and setter methods. Remove unused convenience constructor.
2754 Use default code formatting.
2756 2011-07-12 Ben Konrath <ben@bagu.org>
2758 Ignore LayoutItemPortals in the details view.
2760 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2763 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2764 LayoutItemPortal layout objects.
2765 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2766 LayoutItemPortal objects when retrieving the details layout.
2767 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2768 file. This is an empty class and just used to get type information for
2771 2011-07-12 Ben Konrath <ben@bagu.org>
2773 Use java-libglom 1.17.0.
2777 2011-07-11 Ben Konrath <ben@bagu.org>
2779 Remove "Table:" label from table selector.
2781 This matches a recent change in the Glom UI.
2783 * mockups/details-contacts.html:
2784 * mockups/details-projects.html:
2785 * mockups/listview-contacts.html:
2786 * mockups/listview-projects.html: Remove the "Table:" label from the
2788 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2790 2011-07-11 Ben Konrath <ben@bagu.org>
2792 Add main groups to the details view.
2794 This makes things look a little nicer in the details view. The next step
2795 is to implement the flowtable.
2797 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2798 resources from the standard gwt css theme. Standard.css is now
2799 included in OnlineGlom.html so that the online glom css rules have
2800 precedence over the gwt theme.
2801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2802 the whole LayoutGroup to the DetailsView instead of just the titles.
2803 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2804 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2805 details layout with a helper class (GroupPanel). I might extract this
2806 class when I make the full flowtable.
2807 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2808 string as default so I don't have to worry about NPEs when processing
2810 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2811 note beside OnlineGlom.gwt.xml above).
2812 * src/main/webapp/style.css: Add default font-size to body to override
2813 the font-size set by the standard theme. Don't use h2 tags for
2814 group-title. Create new details-cell class.
2816 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2818 ConfiguredDocument: Set the port number too.
2820 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2821 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2822 Glom document. Presumably this worked sometimes so far because there is a
2823 default port number.
2825 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2827 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2829 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2830 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2831 correct, though we should throw an exception too.
2833 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2835 Fix a addDocuemnt typo.
2837 * src/main/java/org/glom/web/shared/Documents.java
2838 (Documents.addDocuemnt): Rename to addDocument().
2839 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2840 (OnlineGlomServiceImpl.getDocuments): Adapt.
2842 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2844 Slightly improved log output when connection fails.
2846 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2847 (ConfiguredDocument.setUsernameAndPassword):
2848 We don't know for sure if it' the username/password that's wrong, so
2849 rephrase the message.
2850 Also ouput the exception message, though it's generic in this case.
2852 2011-07-08 Ben Konrath <ben@bagu.org>
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2857 added braces to a one line if statement because the Eclipse formatter
2858 was getting confused.
2860 2011-07-07 Ben Konrath <ben@bagu.org>
2862 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2864 These should really be two separate tasks but I counldn't get things to
2865 work with GWT 2.2.0 and Eclipse 3.7.
2869 * .settings/org.eclipse.jdt.core.prefs:
2870 * .settings/org.eclipse.jdt.ui.prefs:
2871 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2872 * .settings/org.eclipse.m2e.core.prefs:
2873 Add new config files. Update current files. Remove references to the
2874 webtools plugins as we're not using any of the webtools features.
2875 * .gitignore: Add logs directory which is created when running with
2877 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2878 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2879 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2881 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2883 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2885 onlineglom.properties: Add explanatory comments.
2887 * src/main/resources/onlineglom.properties: Also change the default user
2888 from ben to someuser, to avoid the risk of people thinking we just
2889 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2891 2011-06-28 Ben Konrath <ben@bagu.org>
2893 Use filename in Log for incorrect passwords.
2895 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2896 getFileName(String) method to get the filename from the URI.
2898 2011-06-28 Ben Konrath <ben@bagu.org>
2900 Add the table name to the URL token for the ListPlace.
2902 This makes things consistent between the DetailsPlace and the
2903 ListPlace. It also allows the the ListPlace to be bookmarked.
2905 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2906 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2908 Remove getDefaultListLayout(). The default layout is now returned
2909 by the getListLayout() method when the table name is an empty string.
2910 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2911 Add table name field. Change to a new ListPlace when the table
2912 has been changed. Use getListLayout() for getting the default
2914 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2915 Add table name field. Set the correct table name in the list box
2916 when loading from bookmark. This corrects a problem for the
2918 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2919 Move table name to super-class (HasSelectableTable). Move document
2920 and table URL keys to super-class in HasSelectableTable.
2921 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2922 Add table name field. Add Tokenizer class with URL key common to
2923 the subclasses (DetailsPlace and ListPlace).
2924 * src/main/java/org/glom/web/client/place/ListPlace.java:
2925 Add table name. Add code to parse the URL token.
2926 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2927 Update ListPlace construction with empty table name string.
2928 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2929 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2930 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2931 Update ListPlace construction with table name string.
2932 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2933 Change defaultTableName field to tableName to reflect how it's now
2934 used. Update the getter and setter methods.
2936 2011-06-28 Ben Konrath <ben@bagu.org>
2938 Enable the table selector in the DetailsView.
2940 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2941 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2942 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2943 Remove getDefaultDetailsLayout(). The default layout is now returned
2944 by the getDetailsLayout() method when the table name is an empty
2946 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2947 event handler for table change event. Change to using
2948 getDetailsLayout() for the default details layout.
2949 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2951 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2952 when navigating to the details place.
2954 2011-06-27 Ben Konrath <ben@bagu.org>
2956 Use filename based unique document ID in URL and for RPC.
2958 The document ID is the glom document name with spaces (' ') replaced
2959 with pluses ('+') and without the .glom extension.
2961 This change is mostly a string substitution of 'documentTitle' for
2962 'documentID'. The only code change is the addition of a Documents DTO to get the
2963 filename to document title mappings as indicated below.
2965 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2966 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2967 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2968 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2969 Use Documents DTO to create the document links in the document
2971 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2972 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2973 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2974 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2975 * src/main/java/org/glom/web/client/place/ListPlace.java:
2976 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2977 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2978 * src/main/java/org/glom/web/client/ui/ListView.java:
2979 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2980 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2981 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2982 * src/main/java/org/glom/web/server/Log.java:
2983 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2984 getDocumentTitles() to getDocuments() and return the Documents DTO.
2985 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2986 transferring the filename to document title mappings.
2988 2011-06-25 Ben Konrath <ben@bagu.org>
2990 Make the authentication popup work again.
2992 This bug was introduced when I extracted ConfiguredDocument to its own class.
2994 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2995 correct success / fail status in setUsernameAndPassword().
2997 2011-06-25 Ben Konrath <ben@bagu.org>
2999 Use filename as unique key for configuring database usernames and passwords.
3001 This replaces the use of the Glom document title which could change
3002 depending on the locale. Thanks to Murray Cumming for pointing out this
3005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3006 * src/main/resources/onlineglom.properties:
3008 2011-06-24 Ben Konrath <ben@bagu.org>
3010 Pass primary key value to DetailsView.
3012 This enables the DetailsView to load the correct data.
3014 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3015 primary key value field and set in constructor. Pass primary key
3016 value to getDetailsData().
3017 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3018 variables for document title and primary key value.
3019 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3020 key value to the DetailsPlace.
3022 2011-06-24 Ben Konrath <ben@bagu.org>
3024 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3026 This allows the primary key to be retrieved by the Details button. This
3027 functionality has not been implemented yet but it's in the works.
3029 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3030 the LayoutGroup result to ListView.setCellTable instead of all of its
3031 fields individually.
3032 * src/main/java/org/glom/web/client/ui/ListView.java:
3033 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3034 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3035 get the primary key for the table.
3036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3037 index of the primary key in the LayoutGroup accounting for hidden
3038 primary keys. Rename getJavaNumberFormat() to
3039 convertToJavaNumberFormat() for consistency. Cleanup / add some
3041 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3042 field for primary key index and a field to indicate whether the
3043 primary key is hidden or not.
3045 2011-06-23 Ben Konrath <ben@bagu.org>
3047 Rename getTableData methods to getListData.
3049 This is a rename refactor for consistency with other methods.
3051 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3052 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3053 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3056 2011-06-23 Ben Konrath <ben@bagu.org>
3058 Extract the ConfiguredDocument innerclass into its own class.
3060 This makes the servlet code more object oriented.
3062 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3063 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3064 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3065 new ConfiguredDocument class.
3067 2011-06-21 Ben Konrath <ben@bagu.org>
3069 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3071 This makes things more inline with how libglom works and reduces code
3072 duplication. This refactor lays the groundwork for adding the primary key to
3073 the LayoutGroup object.
3075 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3076 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3077 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3078 Change method names to getListLayout and getDefaultListLayout for
3079 consistency. Use LayoutGroup as the DTO for the list layout instead of
3080 ColumnInfo and LayoutListTable.
3081 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3082 new method names along with the LayoutGroup object for transferring the
3084 * src/main/java/org/glom/web/client/ui/ListView.java:
3085 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3086 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3087 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3089 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3090 Replaced with LayoutGroup.
3091 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3092 expectedResultSize and defaultTableName fields which are needed for
3094 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3095 type field which is needed for the list layout but will also be
3096 useful for the details layout as things progress.
3097 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3098 Make class abstract. Remove the unnecessary
3099 getFormattingHorizontalAlignment method. Add setFormatting method.
3101 2011-06-16 Ben Konrath <ben@bagu.org>
3103 Add scripts for building and installing war.
3105 These will help when updating OnlineGlom but they're also good
3106 supplemental documentation of the build and deployment proceeding.
3108 * utils/build-onlineglom-war.sh: New file.
3109 * utils/install-onlineglom-war.sh: New file.
3111 2011-06-16 Ben Konrath <ben@bagu.org>
3113 Create wrapper class to create consistent log messages.
3115 I wrapped methods in the Log class of gwt-log to add the method names
3116 from the servlet and create consistent formatting of the document title
3117 and table names in the log messages.
3119 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3121 log methods to use methods from wrapped Log class.
3123 2011-06-16 Ben Konrath <ben@bagu.org>
3125 Remove superfluous conditional return.
3127 Thanks to Murray Cumming for pointing this out!
3129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3131 2011-06-15 Ben Konrath <ben@bagu.org>
3133 Return an ArrayList of LayoutGroups for the Details layout.
3135 This corrects a problem with the details layout as it can have more
3136 than one top level LayoutGroup.
3138 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3140 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3141 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3142 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3143 with ArrayList of LayoutGroups for the details view layout.
3144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3145 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3146 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3147 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3148 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3149 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3151 2011-06-14 Ben Konrath <ben@bagu.org>
3153 Use cast_dynamic method to determine the libglom LayoutItem type.
3155 This is better than finding the LayoutItem type by using the string
3156 returned from the get_part_type_name() method.
3158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3160 2011-06-14 Ben Konrath <ben@bagu.org>
3162 Add method names to log entries in the servlet.
3164 This helps when tracking down deployment problems.
3166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3168 2011-06-14 Ben Konrath <ben@bagu.org>
3170 Add data to the DetailsView using a hard-coded primary key value.
3172 The layout and functionality of the DetailsView is not complete. This
3173 is just a checkpoint so the patch doesn't get too big.
3175 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3176 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3177 Add getDetailsData() servlet method.
3178 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3179 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3180 LayoutFields are added to the DetailsView.
3181 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3182 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3183 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3184 take the string for the title instead of the object.
3185 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3186 Add implementation getDetailsData() along with some private helper
3188 * src/main/webapp/style.css: Add padding to details-data class. Add a
3189 details-label class with the same padding as the details-data class.
3191 2011-06-03 Ben Konrath <ben@bagu.org>
3193 Use presenter.goTo() to change to the DetailsPlace.
3195 This will make things easier when we need to open the DetailsView with
3196 data specific to the row that was clicked.
3198 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3200 2011-06-02 Ben Konrath <ben@bagu.org>
3202 Add CSS file from mockups.
3204 I'm adding this now because it's going to be useful to have when
3205 developing the DetailsView. The TableSelectionView and ListView aren't
3208 * src/main/webapp/OnlineGlom.html:
3209 * src/main/webapp/style.css:
3211 2011-06-02 Ben Konrath <ben@bagu.org>
3213 Use String.isEmpty() to check for empty string.
3215 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3217 2011-06-02 Ben Konrath <ben@bagu.org>
3219 Display main layout group titles in the DetailsView.
3221 This is the start of the DetailsActivity/DetailsView implementation.
3223 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3224 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3225 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3226 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3227 Get the layout information for the details view from the server and set
3228 the main layout group titles.
3229 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3230 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3231 Add addLayoutGroup() and addLayoutField() methods. This are just
3232 temporary methods for creating the the details view that will change
3234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3235 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3237 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3238 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3239 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3240 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3241 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3242 Data Transfer Objects that mimic the libglom object structure. These are
3243 used for transferring the details layout but could also be used for