1 2011-12-30 Murray Cumming <murrayc@murrayc.com>
3 Added a first unit test.
5 * pom.xml: Add a test goal, and a dependency on junit in that scope.
6 * src/test/java/org/glom/web/shared/DataItemTest.java:
7 This is a silly test but it is just to get things started. Note that
8 maven/junit finds the test because it looks in src/test by default.
10 2011-12-22 Ben Konrath <ben@bagu.org>
12 Change charsetName to "UTF-8" when replacing line breaks.
14 JavaScript requires the charsetName to be "UTF-8". CharsetName values
15 that work in Java (such as "UTF8") will not work when compiled to
18 This fixes a problem with multi-line details view fields that have hard
19 line breaks. The "License Text" field on this page demonstrates the
22 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
24 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
26 2011-12-22 Ben Konrath <ben@bagu.org>
28 Fix another bug with related list navigation.
30 I've tested all the navigation buttons in all of the related lists
31 so things should be good now.
33 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
35 2011-12-22 Ben Konrath <ben@bagu.org>
37 Fix a crasher when refreshing the list view with the default table.
39 This crash will also happen when loading the list view with the default
40 table from a link or bookmark.
42 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
43 to the main document selection page when the document id hasn't been
45 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
46 the main document selection page when the document id hasn't been
48 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
49 values for the details place when the document id hasn't been set.
50 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
51 values for the list place when the document id hasn't been set.
53 2011-12-21 Ben Konrath <ben@bagu.org>
55 Protect against NPE when glom.document.locale is not in config.
57 This patch protects against an NPE when glom.document.locale is not in
58 the config file. This NPE will also happen if glom.document.locale is
61 The patch also updates the error message to display the class name when
62 the getMessage() returns null. This was happening when the NPE was
63 thrown and I had "Configuration Error: null". If an NPE is encountered
64 with this patch, "Configuration Error: NullPointerException " will be
67 This commit closes this bug:
69 https://bugzilla.gnome.org/show_bug.cgi?id=666669
71 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
73 2011-12-20 Murray Cumming <murrayc@murrayc.com>
75 Rename onlineglom.properties to onlineglom.properties.sample.
77 * src/main/resources/onlineglom.properties: Rename to:
78 * src/main/resources/onlineglom.properties.sample:
79 * src/main/resources/README: And add this file explaining that people
80 should rename it back when deploying.
82 2011-12-20 Murray Cumming <murrayc@murrayc.com>
84 Allow choosing the translation in the .properties file.
86 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
87 init(): Read a glom.document.locale value from the configuration file
88 and call Glom's TransatableItem::set_current_locale() method.
89 * src/main/resources/onlineglom.properties: Add a commented-out
90 example of this new setting.
92 It would be better to add &lang=de_DE to the URL, but the current
93 libglom API does not allow us to do this easily. I am working on that.
95 2011-12-19 Murray Cumming <murrayc@murrayc.com>
97 Avoid a crash in parsing of token parameters.
99 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
100 ava: getTokenParams(): Do not crash if a parameter has a key but no
101 value, and ignore parameters with neither.
103 2011-12-17 Murray Cumming <murrayc@murayc.com>
105 History token building/handling: Improve use of token parameters.
107 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
108 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
109 and buildParamsToken(HashMap), for use by derived classes.
110 Make the separator private because it is no longer be needed.
111 * src/main/java/org/glom/web/client/place/DetailsPlace.java
112 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
113 instead of manual string concatenation.
114 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
115 of hardcoded indices and awkward splitting code.
116 * src/main/java/org/glom/web/client/place/ListPlace.java
117 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
118 instead of manual string concatenation.
119 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
120 of hardcoded indices and awkward splitting code.
121 This should fix bug #666420
123 2011-12-16 Murray Cumming <murrayc@murrayc.com>
125 Fix a Navgiation->Navigation typo in the code.
127 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
128 Rename processNavgiation() to processNavigation().
130 2011-12-16 Murray Cumming <murrayc@murrayc.com>
132 Fix a seperator->separator typo in the code.
134 * src/main/java/org/glom/web/client/place/DetailsPlace.java
135 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
136 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
139 2011-12-15 Ben Konrath <ben@bagu.org>
141 Cleanup some comments.
143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
145 2011-12-14 Ben Konrath <ben@bagu.org>
147 Replace \n with <br/> for multiline text in the details view.
149 Vertical scrollbars are added when needed as well.
151 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
153 2011-12-14 Ben Konrath <ben@bagu.org>
155 Specify the font for document selection links.
157 * src/main/webapp/style.css:
159 2011-12-14 Ben Konrath <ben@bagu.org>
161 Fix bouncy CellTable while paging.
163 This doesn't currently work with related list tables in unselected
166 * src/main/java/org/glom/web/client/ui/list/ListTable.java
168 2011-12-14 Ben Konrath <ben@bagu.org>
170 Revamp the appearance of the document selection page.
172 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
173 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
174 * src/main/webapp/style.css:
176 2011-12-13 Ben Konrath <ben@bagu.org>
178 Set navigation button column to the smallest size possible.
180 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
182 2011-12-13 Ben Konrath <ben@bagu.org>
184 Change OpenButton nomenclature to NavigationButton.
186 Using NavigtionButton makes things more generic. Classes, methods and
187 variables have been changed.
189 This is a rename-only refactor.
191 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
192 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
193 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
194 Renamed from OpenButtonCell.
195 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
196 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
197 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
199 2011-12-12 Ben Konrath <ben@bagu.org>
201 Remove unnecessary String argument in RelatedListTable and ListViewTable.
203 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
204 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
205 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
206 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
208 2011-12-12 Ben Konrath <ben@bagu.org>
210 Update variable names and comments.
212 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
213 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
215 2011-12-12 Ben Konrath <ben@bagu.org>
217 Properly initialize numNonEmptyRows variable to zero.
219 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
220 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
222 2011-12-05 Ben Konrath <ben@bagu.org>
224 Add latest mockup with HTML tables.
226 Features of this mockup:
228 -> HTML table for flowtable
229 -> HTML table for flowtable column
230 -> Example of how related lists would look
231 -> Not using text entries for data items
233 The current version of Online Glom doesn't use HTML tables for the
236 This mockup has been sent to the glom-devel mailing list but it's good
237 to have it here as well.
239 * mockups/details-view-html-tables.html:
241 2011-12-05 Ben Konrath <ben@bagu.org>
243 Remove unnecessary getPrimaryKeyField() method.
245 getPrimaryKeyFieldForTable(String) has been renamed to
246 getPrimaryKeyField(String).
248 * src/main/java/org/glom/web/server/database/DBAccess.java:
249 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
250 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
252 2011-12-05 Ben Konrath <ben@bagu.org>
254 Add string representation of TypedDataItem value to conversion error message.
256 * src/main/java/org/glom/web/server/Utils.java: Logging the error
257 message was extracted into its own method to avoid duplication.
259 2011-12-05 Ben Konrath <ben@bagu.org>
261 Add type checking to navigation primary key value creation.
263 Create navigation primary key only if the expected type from the Glom
264 document matches the type returned by the SQL query.
266 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
268 2011-12-05 Ben Konrath <ben@bagu.org>
270 Rename a couple of variables in RelatedListNavigation.
272 This is a rename-only refactor.
274 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
276 2011-12-05 Ben Konrath <ben@bagu.org>
278 Move getListLayoutGroup() into getListViewLayoutGroup().
280 This removes getListLayoutGroup(). It was only being called by
281 getListViewLayoutGroup().
283 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
285 2011-12-05 Ben Konrath <ben@bagu.org>
287 Remove check for LayoutItem_Portal in list table method.
289 This check is no longer necessary because the method isn't being used
290 to create the LayoutItemPortal DTO.
292 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
294 2011-12-05 Ben Konrath <ben@bagu.org>
296 Properly support related list navigation.
298 Navigation from the "Repository Analyzer -> Package Scans ->
299 Dependencies" related table wasn't working because the primary key for
300 related tables wasn't being set properly. This commit fixes the
303 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
304 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
305 doesn't set the primary key properly for related list tables.
306 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
307 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
308 useful for getting the primary key for list view tables and for related
310 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
311 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
312 Move code to set the primary key for the table from the abstract
313 ListDBAccess class to ListViewDBAccess as it's only correct for list
315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
316 Properly add primary key to related list tables.
318 2011-12-02 Ben Konrath <ben@bagu.org>
320 Properly set the horizontal alignment of fields.
322 This fix is for both the list tables and the details view.
324 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
325 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
326 to set the horizontal alignment of fields.
328 2011-12-02 Ben Konrath <ben@bagu.org>
330 Display currency codes in the details view.
332 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
334 2011-12-02 Ben Konrath <ben@bagu.org>
336 Avoid duplicate JNI call.
338 JNI is not as efficient as pure Java and this is an easy (and small)
341 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
342 Use previously retrieved value for whereClauseToTableName instead of
345 2011-12-02 Ben Konrath <ben@bagu.org>
347 Rename a couple of variables in RelatedListNavigation.
349 This is a rename-only refactor.
351 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
353 2011-12-02 Ben Konrath <ben@bagu.org>
355 Indicate clearly that a mismatched primary key type is a bug.
357 * src/main/java/org/glom/web/server/Utils.java: Change log level from
358 warning to error. Add 'This is a bug.' to message.
360 2011-12-02 Ben Konrath <ben@bagu.org>
362 Update / fix some comments.
364 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
366 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
369 Fix comments. Add some TODOs.
371 2011-12-02 Ben Konrath <ben@bagu.org>
373 Enable navigation to details view with string primary key from related list.
375 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
376 Create a text primary key value when return type of result is
377 java.sql.Types.VARCHAR.
379 2011-12-02 Ben Konrath <ben@bagu.org>
381 Use checkboxes for booleans in the details view.
383 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
385 2011-12-01 Ben Konrath <ben@bagu.org>
387 Improve performance of related list height calculation.
389 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
390 Put code to calculate the expected height in a static initializer so
391 that that it's only called once.
393 2011-12-01 Ben Konrath <ben@bagu.org>
395 Show related list tables in notebooks (again).
397 Calculate the height of the related list tables so the Notebook can be
398 set the correct height. The height of the related list table is also needed by
399 FlowTable to be able decide how to create the layout.
401 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
402 and set the Portal height based on the height of the related list
403 table and the Portal container.
404 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
405 Add method to calculate the height of the related list tables.
406 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
407 * src/main/webapp/style.css: Add css class for Pager. This is needed to
408 calculate the height of the Pager widget.
410 2011-12-01 Ben Konrath <ben@bagu.org>
412 Use CellTable API for table property instead of setting style on Element.
414 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
416 2011-12-01 Ben Konrath <ben@bagu.org>
418 Make ListViewTable and RelatedListTable a consistent height.
420 The tables are now a consistent height regardless of the contents of
421 the table. A hidden button is added to empty rows to ensure that the
422 height of these rows will match the height of rows with data.
424 A navigation button column is now added to every table. The width of
425 the navigation column is set to 0px when a RelatedListTable shouldn't
426 have navigation buttons. This maintains the a consistent row height in
427 tables that don't show the navigation buttons.
429 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
430 navigation column when not needed.
431 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
432 arguments for navigation button to constructor of ListViewTable.
433 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
434 hidden button for empty data rows.
435 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
436 arguments for navigation button to constructor.
437 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
438 create navigation buttons. Add hideNavigationButtons() method.
439 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
440 arguments for navigation button to constructor.
442 2011-12-01 Ben Konrath <ben@bagu.org>
444 Use 'visibility: hidden' in Utils.getWidgetHeight().
446 This is better choice because hidden elements are invisible, don't
447 respond to events and are not part of the tab order. They will,
448 however, take up space which is required to be able to calculate the
449 height of the widget.
451 * src/main/java/org/glom/web/client/Utils.java:
453 2011-12-01 Ben Konrath <ben@bagu.org>
455 Use Utils.getWidgetHeight() in FlowTable.
457 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
459 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
461 2011-12-01 Ben Konrath <ben@bagu.org>
463 Put the details css class name on the correct table column.
465 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
467 2011-11-30 Ben Konrath <ben@bagu.org>
469 Update for java-libglom API change.
471 The getters and setters on FieldFormatting and NumericFormat were
472 changed to remove the 'M'.
474 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
476 2011-11-29 Ben Konrath <ben@bagu.org>
478 Only allow RelatedListTables in Portals.
480 * src/main/java/org/glom/web/client/ui/details/Portal.java:
482 2011-11-29 Ben Konrath <ben@bagu.org>
484 Only create a contents panel for Portals when title is being set.
486 * src/main/java/org/glom/web/client/ui/details/Portal.java:
488 2011-11-29 Ben Konrath <ben@bagu.org>
490 Set TabLayoutPanel height based on calculated height its widgets.
492 This is a potential fix for this bug:
494 https://bugzilla.gnome.org/show_bug.cgi?id=665133
496 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
498 2011-11-29 Ben Konrath <ben@bagu.org>
500 Align details field labels and data with the Open buttons.
502 * src/main/webapp/style.css:
504 2011-11-29 Ben Konrath <ben@bagu.org>
506 Remove unnecessary <div> in the Notebook widget.
508 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
509 method to get container FlowPanel (<div>).
510 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
511 initWidget() method directly on the TabLayoutPanel widget instead of
512 Group's container widget.
514 2011-11-29 Ben Konrath <ben@bagu.org>
516 Don't add group titles for Portals in Notebooks.
518 This reverts the previous patch and fixes a bug I introduced with
519 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
521 * src/main/java/org/glom/web/client/ui/details/Group.java:
522 * src/main/java/org/glom/web/client/ui/details/Portal.java:
524 2011-11-28 Ben Konrath <ben@bagu.org>
526 Remove unused boolean argument in Portal constructor.
530 * src/main/java/org/glom/web/client/ui/details/Group.java:
531 * src/main/java/org/glom/web/client/ui/details/Portal.java:
533 2011-11-28 Ben Konrath <ben@bagu.org>
535 Remove hack for glom 1.18 style glom files.
537 * src/main/java/org/glom/web/client/ui/details/Group.java:
538 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
539 * src/main/java/org/glom/web/client/ui/details/Portal.java:
541 2011-11-28 Ben Konrath <ben@bagu.org>
543 Use Gda Value version of primary key to log result too large error.
545 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
547 2011-11-28 Ben Konrath <ben@bagu.org>
549 Don't use TypedDataItem.getText() for Unknown types from the URL.
551 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
552 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
553 instead of getText().
554 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
555 String field and getUnknown() method.
557 2011-11-28 Ben Konrath <ben@bagu.org>
559 Log an error message when the java-libglom .so is not present.
561 The error message was being set in the exception but not logged.
563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
565 2011-11-28 Ben Konrath <ben@bagu.org>
567 Ignore LayoutItem_CalendarPortals.
569 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
570 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
572 2011-11-28 Ben Konrath <ben@bagu.org>
574 Extract method for creating the LayoutItemPortal DTO.
576 Just breaking the code up into smaller chunks.
578 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
580 2011-11-28 Ben Konrath <ben@bagu.org>
584 This should have been added with the refactor. Oops!
586 * src/main/java/org/glom/web/shared/TypedDataItem.java:
588 2011-11-28 Ben Konrath <ben@bagu.org>
590 Create primary key value from URL string using type from Glom document.
592 See this bug, comments 19 - 25:
594 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
596 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
597 create a TypeDataItem for the primary key here when loading from a
598 URL. Show the same string for the primary key value as was received
599 from the URL string (when loading from a URL).
600 * src/main/java/org/glom/web/server/Utils.java: Update method for
601 creating the Gda Value from the TypeDataItem to properly deal with
602 creating a Gda Value based on the Glom document type for the primary
603 key value string when loading from a URL.
604 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
605 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
606 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
607 Update for changed method name.
609 2011-11-27 Ben Konrath <ben@bagu.org>
611 Rename PrimaryKeyItem to TypedDataItem.
613 The name PrimaryKeyItem suggests what the class should be used for.
614 TypedDataItem is a neutral name that describes the class better.
616 This is a rename-only refactor.
618 * src/main/java/org/glom/web/client/OnlineGlomService.java:
619 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
620 * src/main/java/org/glom/web/client/Utils.java:
621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
622 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
623 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
624 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
625 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
626 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
628 * src/main/java/org/glom/web/server/Utils.java:
629 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
630 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
631 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
632 * src/main/java/org/glom/web/shared/NavigationRecord.java:
634 2011-11-25 Ben Konrath <ben@bagu.org>
636 Improve Gda Value conversion from PrimaryKeyItem.
638 The value from the PrimaryKeyItem is only used if its type match the
639 type from the glom document.
641 * src/main/java/org/glom/web/server/Utils.java:
643 2011-11-25 Ben Konrath <ben@bagu.org>
645 Manually check if the java-liblgom .so is visible to the JVM.
647 It seems that Tomcat has problems when a static initializer throws an
648 exception. This check is done before the first method call into
649 java-libglom so that execution doesn't continue if the .so is not
652 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
654 2011-11-25 Ben Konrath <ben@bagu.org>
656 Improve browser configuration error messages.
660 https://bugzilla.gnome.org/show_bug.cgi?id=662792
662 * src/main/java/org/glom/web/client/OnlineGlomService.java:
663 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
664 getConfigurationErrorMessage() method.
665 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
666 Get and display a specific configuration error message when no Glom
668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
669 Implement getConfigurationErrorMessage() method. Surround configuration
670 code in the init() method with a try/catch block. This allows the
671 errors to be caught while keeping the servlet available to retrieve the
672 configuration error message.
674 2011-11-25 Ben Konrath <ben@bagu.org>
676 Don't use Strings to hold primary key values.
678 The primary key values are now held in a new data object
679 (PrimaryKeyItem) that holds type information and the primary key value
680 using the correct type.
682 * src/main/java/org/glom/web/client/OnlineGlomService.java:
683 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
685 PrimaryKeyItem instead of String to hold the primary key value.
686 * src/main/java/org/glom/web/client/Utils.java: Remove
687 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
688 PrimaryKeyItem based on the GlomFieldType and the DataItem.
689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
690 PrimaryKeyItem instead of String to hold the primary key value. Load
691 document selection page when the documentID has not been set correctly.
692 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
693 DetailsPlace -> URL and URL -> DetailsPlace conversion with
695 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
696 Return empty string for URL instead of "null".
697 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
698 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
699 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
700 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
701 PrimaryKeyItem instead of String to hold primary key values.
702 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
703 PrimaryKeyValue to a Gda Value.
704 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
705 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
706 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
707 Replace temporary database access code that uses the PrimaryKeyValue to
708 Gda Value conversion.
709 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
710 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
711 PrimaryKeyItem instead of String.
712 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
713 hold primary key values.
715 2011-11-24 Ben Konrath <ben@bagu.org>
717 Use newly added java-libglom API to create queries.
719 This isn't finished. I still need to stop using Strings for primary key
720 values in the client code.
722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
723 libglom to use fake connections so that retrieving the query string will
725 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
726 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
727 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
728 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
729 Use the newly added libglom sql methods and classes to create the
730 query. Add temporary hack to convert primary value strings to Gda
733 2011-11-23 Ben Konrath <ben@bagu.org>
735 Don't explicitly set the height of Portals.
737 See comments 6 - 10 of this bug for details:
739 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
741 * src/main/java/org/glom/web/client/ui/details/Portal.java:
743 2011-11-23 Ben Konrath <ben@bagu.org>
745 Use an HTML table instead of CSS for the FlowTable layout.
747 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
748 GWT's FlexTable to implement the FlowTable.
749 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
751 2011-11-18 Ben Konrath <ben@bagu.org>
753 Add boolean example to HTML table mockup.
755 * mockups/details-view-html-tables-text-entries.html:
757 2011-11-17 Ben Konrath <ben@bagu.org>
759 Ensure the pager buttons are always visible for related lists.
761 To accomplish this, I've turned off text wrapping in the list view and
762 related list tables for both the header and data text. The related list
763 table now has a fixed layout so the it doesn't overflow its container.
764 This is required to ensure that the cell text is clipped when it
765 overflows the cell and an ellipsis is added to the right side of the
766 cell when text is clipped.
768 A fixed table layout for the related list table in the details view
769 seems what we want for the details view anyway, so the side-effect is
772 The ellipsis will only be displayed in Firefox >= 7.
776 https://bugzilla.gnome.org/show_bug.cgi?id=662930
778 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
779 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
780 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
782 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
783 Set the 'table-layout: fixed' CSS property to the related list table.
784 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
785 'white-space: nowrap;' CSS property on both the list view and the
788 2011-11-16 Ben Konrath <ben@bagu.org>
790 Rework the fix for empty notebook tab labels.
792 Setting the empty group titles with its name caused problems for the
793 details layout. Instead of using libglom's
794 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
795 to the client when the title is empty. This allows the Notebook to use
796 the name when the title is empty without affecting anything else.
798 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
799 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
801 2011-11-16 Ben Konrath <ben@bagu.org>
803 Set group titles with name when title is empty.
805 This fixes a problem with an empty notebook tab label in the Lesson
806 Planner document. The forth tab in the notebook should be "Internet":
808 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
810 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
811 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
814 2011-11-16 Ben Konrath <ben@bagu.org>
816 Remove whitespace from the configured username properties.
818 This assumes that usernames won't have whitespace at the beginning
819 or end. But I think this is a reasonable assumption.
821 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
822 String.trim() to remove the whitespace from the username properties.
824 2011-11-15 Ben Konrath <ben@bagu.org>
826 Add details view mockup with HTML tables and text entries.
828 This is from the attachment on this bug:
830 https://bugzilla.gnome.org/show_bug.cgi?id=663109
832 * mockups/details-view-html-tables-text-entries.html:
834 2011-11-15 Ben Konrath <ben@bagu.org>
836 Add space between the columns of the flow table.
840 https://bugzilla.gnome.org/show_bug.cgi?id=662918
842 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
843 space between columns in the flow table.
845 2011-11-15 Ben Konrath <ben@bagu.org>
847 Add backup files to the .gitignore.
849 * .gitignore: Ignore files that end with ~.
851 2011-11-09 Ben Konrath <ben@bagu.org>
853 Use latest release of gwt-log.
855 Gwt-log releases are now being submitted to the maven central
856 repository so manual installation of the jar is no longer required.
858 * pom.xml: Update version and groupId of gwt-log dependency.
860 2011-10-31 Ben Konrath <ben@bagu.org>
862 Don't use GWT numeric formatting to override the glom currency formatting.
864 Currencies are now displayed like they are in Glom. See this bug:
866 https://bugzilla.gnome.org/show_bug.cgi?id=646216
868 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
870 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
871 currency code to constructor and set it when the cell is rendered.
872 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
873 currency code to the constructor of the NumericCell.
875 2011-10-27 Ben Konrath <ben@bagu.org>
877 Require the latest release of java-libglom (1.17.4).
881 2011-10-26 Ben Konrath <ben@bagu.org>
883 Add style to Notebook that matches current theme.
885 It's not the best style in the world but it's better than the default.
887 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
888 padding at the bottom of the child widgets.
889 * src/main/webapp/style.css: Add style for the Notebook.
891 2011-10-26 Ben Konrath <ben@bagu.org>
893 Move servlet initialization code to overridden init method.
895 This is half of the solution to getting proper error messages
896 displayed when configuration errors occur. Here's the relevant bug:
898 https://bugzilla.gnome.org/show_bug.cgi?id=662792
900 The rest of the solution involves surrounding the init method with a
901 try/catch block and setting a global variable with the error /
902 exception. A new async method should be created to retrieve and display
903 the error message / exception.
905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
906 code from constructor to init method adding exceptions as needed.
908 2011-10-26 Ben Konrath <ben@bagu.org>
910 Add script to monitor and restart tomcat if required.
912 * utils/check-and-recover-tomcat.py: New file.
914 2011-10-26 Ben Konrath <ben@bagu.org>
916 Display the correct number of data items in the pager.
920 https://bugzilla.gnome.org/show_bug.cgi?id=661441
922 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
923 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
924 The implementation is the same for both tables: Keep track of the
925 number of non-empty rows and fire and RowCountChangeEvent after the data has
927 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
928 custom Pager class that subclasses SimplePager to handle displaying
929 the correct number when empty rows have been added.
931 2011-10-26 Ben Konrath <ben@bagu.org>
933 Correct error in previous commit.
935 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
936 eventBus parameter from listView.setCellTable().
938 2011-10-26 Ben Konrath <ben@bagu.org>
940 Fix error in TODO comment.
942 * src/main/java/org/glom/web/client/activity/ListActivity.java:
944 2011-10-24 Ben Konrath <ben@bagu.org>
946 Create Notebook widgets to the details view.
948 This isn't finished just yet - I still need to create a reasonable
949 style to match the current theme.
951 * src/main/java/org/glom/web/client/Utils.java: Add method for
952 calculating the height of a widget. This is used in the Notebook class.
953 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
954 new constructor method in Group.
955 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
956 method for creating child widget that can be used by subclasses
957 like Notebook. New constructor that allows disabling the group
958 titles - Notebooks don't set a group title for their child groups.
959 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
960 to make Notebooks using GWT's TabLayoutPanel.
961 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
962 constructor that allows disabling the group titles.
963 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
964 LayoutItemNotebook DTO.
965 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
966 DTO for Notebooks. It's just an empty class for now but we might need
967 it to transfer some specific information in the future.
969 2011-10-21 Ben Konrath <ben@bagu.org>
971 Add navigation buttons to related list tables.
973 * src/main/java/org/glom/web/client/OnlineGlomService.java:
974 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
976 method getSuitableRecordToViewDetails() for getting the table name
977 and primary key value for related list navigation buttons.
978 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
979 private cell renderer class to get the navigation information for
980 related list tables from the server. Extract the navigation
981 processing code from the details cell navigation and use it for the
982 related list navigation as well.
983 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
984 cell renderer class for the details open buttons. This was needed
985 because the related list navigation buttons and the list view
986 navigation buttons need to react differently when clicked.
987 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
988 the onEnterKeyDown() method because it's now overriden in the
989 subclasses that are specific to the related list tables and the list
991 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
992 the vertical size a little because the buttons add a bit of vertical
993 space to table. This is not a perfect solution because the vertical
994 size of with table fewer than 5 rows will be a little smaller.
995 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
996 changes in how navigation buttons are handled.
997 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
998 getSuitableRecordToViewDetails() using the new RelatedListNavigation
999 database access object.
1000 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1001 to find the portal for a given relationship name from
1002 RelatedListDBAccess. Add method to find a primary key field for a
1004 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1005 Move code to find the portal for a given relationship name to
1007 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1008 New file: database access object for getting the related list
1009 navigation information (the table name and the primary key value).
1010 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1011 DTO for transferring a table name to navigate to and a primary key
1013 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1014 boolean and getter/setter to specifies if the related list should add
1017 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1019 Use the master branch of java-libglom
1021 * pom.xml: Depend on java-libglom 1.19 instead.
1023 This is the master branch. See also the libglom-1-18 branch.
1025 2011-10-11 Ben Konrath <ben@bagu.org>
1027 Enable the open navigation button when the data has been set.
1029 This avoids having active buttons that don't do anything when the data
1032 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1034 2011-10-11 Ben Konrath <ben@bagu.org>
1036 Use IsWidget interface for FlowTableItem.
1038 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1039 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1041 2011-10-11 Ben Konrath <ben@bagu.org>
1043 Remove GWT styling from open button in details view.
1045 There are still some issues with how the details cell is arranged but
1046 this should be made to match Glom 1.20. I'm going to leave fixing this
1047 until I have Glom 1.20 up and running.
1049 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1050 style name on open button.
1051 * src/main/webapp/style.css: Move and edit details-navigation class.
1052 Re-arrange some classes to make them appear in the same order as the
1055 2011-10-07 Ben Konrath <ben@bagu.org>
1057 Update to GWT 2.4.0.
1059 * .gitignore: Ignore new cache directory.
1060 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1061 * pom.xml: Change GWT and maven plugin to 2.4.0.
1062 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1064 * src/main/java/org/glom/web/client/ClientFactory.java:
1065 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1066 * src/main/java/org/glom/web/client/OnlineGlom.java:
1067 Update source for API changes.
1068 * utils/build-onlineglom-war.sh: Remove cache directory before the
1071 2011-10-07 Ben Konrath <ben@bagu.org>
1073 Add navigation buttons in the details view.
1075 This isn't finished but I thought I'd commit what I have as it's a
1076 pretty good start. I still need to:
1078 1. Change the style so that it fits better into the current theme
1079 2. Adjust the details cell to expand as much as possible.
1081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1082 click handlers to navigation buttons in the DetailsCells. Create a
1083 refreshData() method to get just the data from the server without the
1085 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1086 Update the tableSelector and browser title when the table name
1087 changes without using the tableSelector.
1088 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1089 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1090 getDetailsCells() to getCells(). Update variable names.
1091 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1092 method to set click handler on navigation button. Rename a few
1093 variables. Add navigation buttons where needed.
1094 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1095 variables and methods.
1096 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1097 navigation boolean and navigation table as required in the
1098 LayoutItemField DTO.
1099 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1100 variables for navigation along with getter/setter methods.
1102 2011-10-07 Ben Konrath <ben@bagu.org>
1104 Rename Field to DetailsCell.
1106 This is a refactor-only commit. No functionality has been added or
1109 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1110 Update variable and method names.
1111 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1112 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1113 variable and method names.
1114 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1116 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1117 variable and method names.
1119 2011-10-07 Ben Konrath <ben@bagu.org>
1121 Create separate methods for layout and data the details view.
1123 This is a refactor-only commit. No functionality has been added or
1126 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1127 private methods: setData(), createLayout().
1129 2011-10-07 Ben Konrath <ben@bagu.org>
1131 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1133 This is part of a change to get navigation buttons in the details view
1134 but it should have been done this way from the start.
1136 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1137 for method name change in TableSelectionView.
1138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1139 Create TableChangeEvent and set the browser title using the
1140 TableSelectionView API.
1141 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1142 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1143 Change getSelectedTable() to getSelectedTableName(). Add
1144 getSelectedTableTitle().
1146 2011-10-07 Ben Konrath <ben@bagu.org>
1148 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1150 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1152 2011-10-07 Ben Konrath <ben@bagu.org>
1154 Update TableChangeEvent to use newTableName naming convention.
1156 This makes the class more consistent with GWT naming conventions.
1158 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1159 Update for method name change in TableChangeEvent.
1160 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1161 for method name change in TableChangeEvent.
1162 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1163 newTableName variable and getter method. Make toDebugString()
1166 2011-09-30 Ben Konrath <ben@bagu.org>
1168 Disable the pager in the list tables when the data row count is less than the minimum.
1170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1171 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1173 2011-09-30 Ben Konrath <ben@bagu.org>
1175 Add empty rows to the end of related list and list view tables.
1177 I also extracted the cell rendering classes from the ListTable because
1178 the code was becoming a little crazy with all the anonymous inner
1179 classes. My plan is to use these cell rendering classes in the details
1180 view as well so this refactor will be needed for that change.
1182 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1183 set the row count in related list tables if the data has more rows
1184 than the minimum number of rows visible.
1185 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1186 row count in list view tables if the data has more rows than the
1187 minimum number of rows visible.
1188 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1189 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1191 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1192 for rendering TYPE_NUMERIC cells. The code was extracted from the
1194 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1195 class for rendering cells with buttons in list views. The code was
1196 extracted from the ListTable class.
1197 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1198 for rendering TYPE_TEXT cells. The code was extracted from the
1200 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1201 Add empty rows to the end of the data if required. Implement
1202 ListTable.getMinNumVisibleRows().
1203 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1204 cell renderer code to public classes. Return null in
1205 Column.getValue() for empty rows. Add new abstract method:
1206 getMinNumVisibleRows(). Move code to set the row count of the list view
1207 table to ListViewImpl.
1208 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1209 empty rows to the end of the data if required. Implement
1210 ListTable.getMinNumVisibleRows().
1213 2011-09-27 Ben Konrath <ben@bagu.org>
1215 Use GWT.log for client-side debugging statements.
1217 These are optimized out when deployed so I should have used this method
1218 in the first place. These statements will eventually be replaced with some sort
1219 of notification in the browser.
1221 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1222 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1223 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1224 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1225 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1227 2011-09-27 Ben Konrath <ben@bagu.org>
1229 Put tableselector on the right, back to list link on right.
1231 The idea is that the table selector is acting like a label for the
1232 currently displayed table so it should be placed below the document title. This
1233 puts the table title in a similar position to where it is in Glom.
1235 * mockups/details-contacts.html:
1236 * mockups/details-projects.html:
1237 * mockups/listview-contacts.html:
1238 * mockups/listview-projects.html:
1239 * mockups/style.css:
1240 Update mockups to match how the interfaces currently look.
1241 * src/main/webapp/style.css: Swap positions of backlink with the table
1242 selector. Add some space on the left side of the table selector to
1243 line things up with the document title.
1245 2011-09-27 Ben Konrath <ben@bagu.org>
1247 Add field colouring to details view.
1249 This change re-works how field colouring works. The colour formatting
1250 information is now set to the client with the layout information instead of
1251 with the data. This eliminates the need to send the same colour strings for
1252 data in list view column when colour information is set.
1254 In order to set an alternate colour for negative numeric values, the
1255 number is now sent to client and formatted with the GWT NumberFormat class.
1257 This change also fixes:
1259 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1261 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1262 internationalization framework which is needed for client side numeric
1264 * src/main/java/org/glom/web/client/Utils.java: New file for some
1265 client static utility methods.
1266 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1267 the DataItem object to the Field class. Use a utility method to
1268 create the foreignKeyValue string.
1269 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1270 alignment and text colours in the constructor. Add setData(DataItem)
1271 method. Remove setText(String) method.
1272 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1273 colour information to GlomTextCell. Create and use GlomNumberCell for
1274 rendering numbers. Use utility method to get the string for the
1275 primary key of the key provider. Re-work how the horizontal alignment
1277 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1278 formatting to layout information. Methods for converting the libglom
1279 formatting information were moved from DBAccess.
1280 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1281 numeric formatting (it's now done on the client side). Don't set text
1282 colours in DataItem. Move libglom formatting conversion methods to
1284 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1285 getters/setters for text colour information.
1286 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1287 for transferring the libglom NumericFormat information to the client.
1288 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1289 and getters/setters for: GlomNumericFormat, background colour and
1290 foreground colour strings.
1292 2011-09-26 Ben Konrath <ben@bagu.org>
1294 Simplify code that iterates through the LayoutGroup.
1296 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1298 2011-09-26 Ben Konrath <ben@bagu.org>
1300 Accept Eclipse formatting for OnlineGlomServiceAsync.
1302 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1304 2011-09-26 Ben Konrath <ben@bagu.org>
1306 Don't use the ListDBAccess classes to get the primary key layout information.
1308 This was causing a bug where the wrong index for the hidden primary key
1309 was being sent to the client.
1311 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1312 primary key while creating the LayoutGroup DTO. Create a
1313 LayoutItemField DTO for hidden primary keys. Don't use the
1314 RelatedListDBAccess because it was only used for getting the primary
1316 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1317 access modifier from public to protected for getPrimaryKeyField() and
1318 getPrimaryKeyLayoutItemField().
1319 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1320 abstract method getExpectedResultSize() because RelatedListDBAccess
1321 doesn't have enough info to implement it.
1322 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1323 Remove @Override for getExpectedResultSize().
1324 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1325 Remove method getExpectedResultSize().
1327 2011-09-23 Ben Konrath <ben@bagu.org>
1329 Log which layout (list or details) the ignored item is from.
1331 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1333 2011-09-23 Ben Konrath <ben@bagu.org>
1335 Remove annotations that turn off code formatting in DataItem.
1337 * src/main/java/org/glom/web/shared/DataItem.java:
1339 2011-09-23 Ben Konrath <ben@bagu.org>
1341 Rename GlomField to DataItem and update associated methods.
1343 This is a rename-only refactor. No functionality has been added or
1346 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1347 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1348 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1349 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1350 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1351 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1352 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1353 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1354 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1355 * src/main/java/org/glom/web/server/database/DBAccess.java:
1356 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1357 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1358 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1359 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1360 * src/main/java/org/glom/web/shared/DataItem.java:
1361 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1362 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1364 2011-09-23 Ben Konrath <ben@bagu.org>
1366 Rename GlomDocument to DocumentInfo and update associated methods.
1368 This is a rename-only refactor. No functionality has been added or
1371 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1372 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1373 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1374 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1376 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1377 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1379 2011-09-20 Ben Konrath <ben@bagu.org>
1381 Require java-libglom 1.17.3.
1383 This picks up the fix for the seg fault problem with the Scenes table
1384 in the Openismus Film Manager example.
1388 2011-09-20 Ben Konrath <ben@bagu.org>
1390 Change the way sort clause is added for primary key when no sort clause is requested.
1392 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1393 before the sort clause is created. When a sort clause is not requested, the
1394 sort clause is created by finding the primary key in the LayoutFieldVector
1397 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1399 2011-09-20 Ben Konrath <ben@bagu.org>
1401 Log error message if no documents are found in the configured directory.
1403 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1404 Extract the glom file extension string to a private static final class
1405 variable (mostly as syntactic sugar). Accept a minor formatting change.
1406 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1407 the example glom.document.directory configuration property to make it
1408 more clear that it can any directory, not just the home directory.
1410 2011-09-18 Ben Konrath <ben@bagu.org>
1412 Add related lists to details view.
1414 The related list table has support for paging and sorting just like the
1415 table in the list view.
1417 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1418 SQL queries for the related list tables.
1419 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1420 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1421 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1422 Rename getList methods to getListView and add comments. Remove
1423 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1424 it being unused. Add methods: getDetailsLayoutAndData(),
1425 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1426 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1427 Create the layout and set the data for the fields in one async call
1428 instead of two. Create related lists where appropriate.
1429 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1430 for method name changes in OnlineGlomService.
1431 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1432 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1433 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1435 * src/main/java/org/glom/web/client/ui/ListView.java:
1436 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1437 tableName from setCellTable(). Create a ListViewTable instead of
1439 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1440 represent a data field in the details view.
1441 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1442 from addDetailsCell() to Field class. Keep track of the Fields and
1443 Portals in the details view.
1444 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1445 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1446 and add a method to get it. Add method to set the contents of the
1448 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1449 New class for related list tables. This class has the data provider
1450 for the related list table.
1451 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1452 abstract class which is the base class for the ListViewTable and the
1454 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1455 New class for list view tables. This class has the data provider for
1456 the list view table.
1457 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1458 methods for related list tables. Add more information to the
1459 LayoutItemField and LayoutItemPortal DTOs.
1460 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1461 Remove debugging print statement.
1462 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1463 Remove debugging print statements. Add primary key field to SQL count
1465 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1466 Remove unnecessary LayoutFieldVector parameter from
1467 getResultSizeOfSQLQuery() method.
1468 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1469 New class for related list table database access.
1470 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1471 class that is a wrapper DTO for details view layout and data.
1472 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1473 new 'fromField' string to this DTO.
1474 * src/main/webapp/style.css: Remove bottom margin and override top
1477 2011-09-15 Ben Konrath <ben@bagu.org>
1479 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1481 This sets things up to make it easier to add the data retrieval for
1482 related lists (portals). No user noticeable changes were made with
1485 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1486 class has the code to retrieve the layouts and access the
1487 database using the new database helper classes.
1488 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1489 Most of the functionality has been removed from this class. This
1490 class now represents the public interface for the client side
1491 code. It also deals with configuring the servlet and cleaning
1492 things up when the servlet is stopped.
1493 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1494 of static methods into this utility class.
1495 * src/main/java/org/glom/web/server/database/DBAccess.java:
1496 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1497 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1498 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1499 These classes have the database retrieval code. The class hierarchy
1500 has been setup to make it easy to reuse code for similar
1503 2011-09-06 Ben Konrath <ben@bagu.org>
1505 Create separate classes for list table code and the data provider.
1507 As part of this refactor, I also split up the code a bit to make it
1510 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1511 table code to two new classes (below).
1512 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1513 with code from ListViewImpl.
1514 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1515 New file with code from ListViewImpl.
1517 2011-09-06 Ben Konrath <ben@bagu.org>
1519 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1521 This fixes the LayoutItemPortal DTO to match the libglom layout object
1524 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1526 2011-09-01 Ben Konrath <ben@bagu.org>
1528 Set title of Portals in the Details View.
1530 * pom.xml: Bump required version of java-libglom to 1.17.1.
1531 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1532 widget creation to its own class. Add comments to constructor.
1533 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1534 The code is mostly from the Group class with the title now set.
1535 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1536 title of Portal. Update some comments. Fix some code formatting.
1538 2011-09-01 Ben Konrath <ben@bagu.org>
1540 Remove TODO comment for the flow table column width.
1542 The flow table column width is working correctly and doesn't need to be
1543 changed. See this mailing list post for more info:
1545 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1547 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1549 2011-08-27 Ben Konrath <ben@bagu.org>
1551 Add document title (database name) to top of the browser page.
1553 I added the document title to the TableSelecitonView but that will
1554 change if / when we add a view that doesn't require table selection.
1556 * mockups/details-contacts.html:
1557 * mockups/details-projects.html:
1558 * mockups/listview-contacts.html:
1559 * mockups/listview-projects.html:
1560 * mockups/style.css: Add document title to mockups to keep things
1562 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1563 sizes to account for the document title.
1564 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1565 Set the document title when it has been retrieved from the server.
1566 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1567 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1568 and implement setDocumentTitle(String) method.
1569 * src/main/webapp/style.css: Add ID for document title style.
1571 2011-08-25 Ben Konrath <ben@bagu.org>
1573 Add NavigationType enum to LayoutItemPortal DTO.
1575 This is the start of adding support for Portals to the Details View.
1577 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1578 LayoutItem_Portal.navigation_type enum from libglom to
1579 LayoutItemPortal.NavigationType enum.
1580 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1581 NavigationType enum, field for storing the NavigationType and getter
1584 2011-08-25 Ben Konrath <ben@bagu.org>
1586 Implement the flow table layout in the Details View.
1588 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1589 FlowTable to Group to account for the renamed class.
1590 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1591 File. This is a container widget that implements the Glom details view
1592 flow table behaviour.
1593 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1594 org/glom/web/client/ui/FlowTable.java.
1595 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1596 so that the size of the subgroups are a closer match to the size of
1597 the Glom subgroups. This makes the flowtable layout match the layout
1598 in Glom for the Music Collection example file.
1600 2011-08-16 Ben Konrath <ben@bagu.org>
1602 Create container element for LayoutItemPortal in Details View.
1604 This will help me develop the layout for the FlowTable.
1606 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1607 fieldPanel variable to detailsCell.
1609 2011-08-15 Ben Konrath <ben@bagu.org>
1611 Set the height of the data element in the Details View.
1613 I changed the InlineLabels (text in a span element) to Labels (text in
1614 a div element) so that I could set the height of the details-data
1615 elements instead of the details-cell parent elements. This allows the
1616 the details-data element to display the correct height if style is
1617 applied that shows the height.
1619 This change has the added benefit of allowing the order of the labels
1620 and data elements to be changed for right-to-left languages.
1622 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1623 InlineLabels to Labels.
1624 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1625 InlineLabels to Labels. Set the height of the data element.
1626 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1627 multiline text height in the Formatting DTO.
1628 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1629 for multiline height along with getter and setter methods.
1630 * src/main/webapp/style.css: Adjust style to account for the change
1631 from span elements to div elements in the details cell.
1633 2011-08-15 Ben Konrath <ben@bagu.org>
1635 Make the List View appearance match the mockups.
1637 It doesn't match exactly but it's much better than it was.
1639 * mockups/listview-contacts.html: Remove unused css classes.
1640 * mockups/listview-projects.html: Remove unused css classes.
1641 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1642 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1643 for mainPanel instead of VerticalPanel (table). Set style name on
1644 CellTable. Set style name on Details column. Right-align Details
1646 * src/main/webapp/style.css: Adjust properties to match the mockups.
1648 2011-08-12 Ben Konrath <ben@bagu.org>
1650 Add better support for subgroups in the details view.
1652 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1653 changed FlowTable constructor.
1654 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1655 support for subgroups and subgroup-titles.
1656 * src/main/webapp/style.css: Add CSS class for subgroups and
1659 2011-08-12 Ben Konrath <ben@bagu.org>
1661 Return the top level LayoutGroup title.
1663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1665 2011-08-11 Ben Konrath <ben@bagu.org>
1667 Make the TableSelector header match the mockup.
1669 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1670 the layout panel. Properly lineup the table selection header with
1671 the list and details view.
1672 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1673 margin around the details view.
1674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1675 Rename listBox variable to tableSelector. Set id for the style sheet.
1676 Use a FlowPanel instead of a HorizontalPanel.
1677 * src/main/webapp/style.css: Add properties to make the TableSelector
1678 box match the mockups.
1680 2011-07-13 Ben Konrath <ben@bagu.org>
1682 Update install script for java-libglom version change.
1684 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1687 2011-07-13 Ben Konrath <ben@bagu.org>
1689 Add support sub-group in the details view.
1691 I also removed the code that special-cased the default details view
1694 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1696 I still have to make a proper flowtable.
1698 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1699 Don't special-case default details view layout.
1700 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1701 addLayoutField() as I'm going to use it.
1702 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1703 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1705 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1706 extracted from DetailsViewImpl.GroupPanel. Add support for
1708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1709 column count when getting the details layout.
1711 2011-07-12 Ben Konrath <ben@bagu.org>
1713 Set browser title with database and table titles.
1715 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1716 Set the browser title when the table changes and when the activity
1718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1719 title when retrieving document info (the GlomDocument object).
1720 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1721 with getter and setter methods. Remove unused convenience constructor.
1722 Use default code formatting.
1724 2011-07-12 Ben Konrath <ben@bagu.org>
1726 Ignore LayoutItemPortals in the details view.
1728 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1731 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1732 LayoutItemPortal layout objects.
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1734 LayoutItemPortal objects when retrieving the details layout.
1735 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1736 file. This is an empty class and just used to get type information for
1739 2011-07-12 Ben Konrath <ben@bagu.org>
1741 Use java-libglom 1.17.0.
1745 2011-07-11 Ben Konrath <ben@bagu.org>
1747 Remove "Table:" label from table selector.
1749 This matches a recent change in the Glom UI.
1751 * mockups/details-contacts.html:
1752 * mockups/details-projects.html:
1753 * mockups/listview-contacts.html:
1754 * mockups/listview-projects.html: Remove the "Table:" label from the
1756 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1758 2011-07-11 Ben Konrath <ben@bagu.org>
1760 Add main groups to the details view.
1762 This makes things look a little nicer in the details view. The next step
1763 is to implement the flowtable.
1765 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1766 resources from the standard gwt css theme. Standard.css is now
1767 included in OnlineGlom.html so that the online glom css rules have
1768 precedence over the gwt theme.
1769 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1770 the whole LayoutGroup to the DetailsView instead of just the titles.
1771 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1772 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1773 details layout with a helper class (GroupPanel). I might extract this
1774 class when I make the full flowtable.
1775 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1776 string as default so I don't have to worry about NPEs when processing
1778 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1779 note beside OnlineGlom.gwt.xml above).
1780 * src/main/webapp/style.css: Add default font-size to body to override
1781 the font-size set by the standard theme. Don't use h2 tags for
1782 group-title. Create new details-cell class.
1784 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1786 ConfiguredDocument: Set the port number too.
1788 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1789 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1790 Glom document. Presumably this worked sometimes so far because there is a
1791 default port number.
1793 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1795 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1797 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1798 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1799 correct, though we should throw an exception too.
1801 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1803 Fix a addDocuemnt typo.
1805 * src/main/java/org/glom/web/shared/Documents.java
1806 (Documents.addDocuemnt): Rename to addDocument().
1807 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1808 (OnlineGlomServiceImpl.getDocuments): Adapt.
1810 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1812 Slightly improved log output when connection fails.
1814 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1815 (ConfiguredDocument.setUsernameAndPassword):
1816 We don't know for sure if it' the username/password that's wrong, so
1817 rephrase the message.
1818 Also ouput the exception message, though it's generic in this case.
1820 2011-07-08 Ben Konrath <ben@bagu.org>
1824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1825 added braces to a one line if statement because the Eclipse formatter
1826 was getting confused.
1828 2011-07-07 Ben Konrath <ben@bagu.org>
1830 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1832 These should really be two separate tasks but I counldn't get things to
1833 work with GWT 2.2.0 and Eclipse 3.7.
1837 * .settings/org.eclipse.jdt.core.prefs:
1838 * .settings/org.eclipse.jdt.ui.prefs:
1839 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1840 * .settings/org.eclipse.m2e.core.prefs:
1841 Add new config files. Update current files. Remove references to the
1842 webtools plugins as we're not using any of the webtools features.
1843 * .gitignore: Add logs directory which is created when running with
1845 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1846 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1847 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1849 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1851 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1853 onlineglom.properties: Add explanatory comments.
1855 * src/main/resources/onlineglom.properties: Also change the default user
1856 from ben to someuser, to avoid the risk of people thinking we just
1857 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1859 2011-06-28 Ben Konrath <ben@bagu.org>
1861 Use filename in Log for incorrect passwords.
1863 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1864 getFileName(String) method to get the filename from the URI.
1866 2011-06-28 Ben Konrath <ben@bagu.org>
1868 Add the table name to the URL token for the ListPlace.
1870 This makes things consistent between the DetailsPlace and the
1871 ListPlace. It also allows the the ListPlace to be bookmarked.
1873 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1874 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1876 Remove getDefaultListLayout(). The default layout is now returned
1877 by the getListLayout() method when the table name is an empty string.
1878 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1879 Add table name field. Change to a new ListPlace when the table
1880 has been changed. Use getListLayout() for getting the default
1882 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1883 Add table name field. Set the correct table name in the list box
1884 when loading from bookmark. This corrects a problem for the
1886 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1887 Move table name to super-class (HasSelectableTable). Move document
1888 and table URL keys to super-class in HasSelectableTable.
1889 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1890 Add table name field. Add Tokenizer class with URL key common to
1891 the subclasses (DetailsPlace and ListPlace).
1892 * src/main/java/org/glom/web/client/place/ListPlace.java:
1893 Add table name. Add code to parse the URL token.
1894 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1895 Update ListPlace construction with empty table name string.
1896 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1897 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1898 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1899 Update ListPlace construction with table name string.
1900 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1901 Change defaultTableName field to tableName to reflect how it's now
1902 used. Update the getter and setter methods.
1904 2011-06-28 Ben Konrath <ben@bagu.org>
1906 Enable the table selector in the DetailsView.
1908 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1909 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1911 Remove getDefaultDetailsLayout(). The default layout is now returned
1912 by the getDetailsLayout() method when the table name is an empty
1914 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1915 event handler for table change event. Change to using
1916 getDetailsLayout() for the default details layout.
1917 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1919 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1920 when navigating to the details place.
1922 2011-06-27 Ben Konrath <ben@bagu.org>
1924 Use filename based unique document ID in URL and for RPC.
1926 The document ID is the glom document name with spaces (' ') replaced
1927 with pluses ('+') and without the .glom extension.
1929 This change is mostly a string substitution of 'documentTitle' for
1930 'documentID'. The only code change is the addition of a Documents DTO to get the
1931 filename to document title mappings as indicated below.
1933 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1934 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1935 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1936 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1937 Use Documents DTO to create the document links in the document
1939 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1940 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1941 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1942 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1943 * src/main/java/org/glom/web/client/place/ListPlace.java:
1944 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1945 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1946 * src/main/java/org/glom/web/client/ui/ListView.java:
1947 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1948 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1949 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1950 * src/main/java/org/glom/web/server/Log.java:
1951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
1952 getDocumentTitles() to getDocuments() and return the Documents DTO.
1953 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
1954 transferring the filename to document title mappings.
1956 2011-06-25 Ben Konrath <ben@bagu.org>
1958 Make the authentication popup work again.
1960 This bug was introduced when I extracted ConfiguredDocument to its own class.
1962 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
1963 correct success / fail status in setUsernameAndPassword().
1965 2011-06-25 Ben Konrath <ben@bagu.org>
1967 Use filename as unique key for configuring database usernames and passwords.
1969 This replaces the use of the Glom document title which could change
1970 depending on the locale. Thanks to Murray Cumming for pointing out this
1973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1974 * src/main/resources/onlineglom.properties:
1976 2011-06-24 Ben Konrath <ben@bagu.org>
1978 Pass primary key value to DetailsView.
1980 This enables the DetailsView to load the correct data.
1982 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1983 primary key value field and set in constructor. Pass primary key
1984 value to getDetailsData().
1985 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
1986 variables for document title and primary key value.
1987 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
1988 key value to the DetailsPlace.
1990 2011-06-24 Ben Konrath <ben@bagu.org>
1992 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
1994 This allows the primary key to be retrieved by the Details button. This
1995 functionality has not been implemented yet but it's in the works.
1997 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
1998 the LayoutGroup result to ListView.setCellTable instead of all of its
1999 fields individually.
2000 * src/main/java/org/glom/web/client/ui/ListView.java:
2001 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2002 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2003 get the primary key for the table.
2004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2005 index of the primary key in the LayoutGroup accounting for hidden
2006 primary keys. Rename getJavaNumberFormat() to
2007 convertToJavaNumberFormat() for consistency. Cleanup / add some
2009 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2010 field for primary key index and a field to indicate whether the
2011 primary key is hidden or not.
2013 2011-06-23 Ben Konrath <ben@bagu.org>
2015 Rename getTableData methods to getListData.
2017 This is a rename refactor for consistency with other methods.
2019 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2020 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2021 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2024 2011-06-23 Ben Konrath <ben@bagu.org>
2026 Extract the ConfiguredDocument innerclass into its own class.
2028 This makes the servlet code more object oriented.
2030 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2031 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2032 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2033 new ConfiguredDocument class.
2035 2011-06-21 Ben Konrath <ben@bagu.org>
2037 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2039 This makes things more inline with how libglom works and reduces code
2040 duplication. This refactor lays the groundwork for adding the primary key to
2041 the LayoutGroup object.
2043 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2044 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2046 Change method names to getListLayout and getDefaultListLayout for
2047 consistency. Use LayoutGroup as the DTO for the list layout instead of
2048 ColumnInfo and LayoutListTable.
2049 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2050 new method names along with the LayoutGroup object for transferring the
2052 * src/main/java/org/glom/web/client/ui/ListView.java:
2053 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2054 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2055 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2057 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2058 Replaced with LayoutGroup.
2059 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2060 expectedResultSize and defaultTableName fields which are needed for
2062 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2063 type field which is needed for the list layout but will also be
2064 useful for the details layout as things progress.
2065 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2066 Make class abstract. Remove the unnecessary
2067 getFormattingHorizontalAlignment method. Add setFormatting method.
2069 2011-06-16 Ben Konrath <ben@bagu.org>
2071 Add scripts for building and installing war.
2073 These will help when updating OnlineGlom but they're also good
2074 supplemental documentation of the build and deployment proceeding.
2076 * utils/build-onlineglom-war.sh: New file.
2077 * utils/install-onlineglom-war.sh: New file.
2079 2011-06-16 Ben Konrath <ben@bagu.org>
2081 Create wrapper class to create consistent log messages.
2083 I wrapped methods in the Log class of gwt-log to add the method names
2084 from the servlet and create consistent formatting of the document title
2085 and table names in the log messages.
2087 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2088 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2089 log methods to use methods from wrapped Log class.
2091 2011-06-16 Ben Konrath <ben@bagu.org>
2093 Remove superfluous conditional return.
2095 Thanks to Murray Cumming for pointing this out!
2097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2099 2011-06-15 Ben Konrath <ben@bagu.org>
2101 Return an ArrayList of LayoutGroups for the Details layout.
2103 This corrects a problem with the details layout as it can have more
2104 than one top level LayoutGroup.
2106 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2107 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2108 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2109 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2110 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2111 with ArrayList of LayoutGroups for the details view layout.
2112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2113 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2114 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2115 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2116 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2117 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2119 2011-06-14 Ben Konrath <ben@bagu.org>
2121 Use cast_dynamic method to determine the libglom LayoutItem type.
2123 This is better than finding the LayoutItem type by using the string
2124 returned from the get_part_type_name() method.
2126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2128 2011-06-14 Ben Konrath <ben@bagu.org>
2130 Add method names to log entries in the servlet.
2132 This helps when tracking down deployment problems.
2134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2136 2011-06-14 Ben Konrath <ben@bagu.org>
2138 Add data to the DetailsView using a hard-coded primary key value.
2140 The layout and functionality of the DetailsView is not complete. This
2141 is just a checkpoint so the patch doesn't get too big.
2143 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2144 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2145 Add getDetailsData() servlet method.
2146 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2147 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2148 LayoutFields are added to the DetailsView.
2149 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2150 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2151 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2152 take the string for the title instead of the object.
2153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2154 Add implementation getDetailsData() along with some private helper
2156 * src/main/webapp/style.css: Add padding to details-data class. Add a
2157 details-label class with the same padding as the details-data class.
2159 2011-06-03 Ben Konrath <ben@bagu.org>
2161 Use presenter.goTo() to change to the DetailsPlace.
2163 This will make things easier when we need to open the DetailsView with
2164 data specific to the row that was clicked.
2166 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2168 2011-06-02 Ben Konrath <ben@bagu.org>
2170 Add CSS file from mockups.
2172 I'm adding this now because it's going to be useful to have when
2173 developing the DetailsView. The TableSelectionView and ListView aren't
2176 * src/main/webapp/OnlineGlom.html:
2177 * src/main/webapp/style.css:
2179 2011-06-02 Ben Konrath <ben@bagu.org>
2181 Use String.isEmpty() to check for empty string.
2183 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2185 2011-06-02 Ben Konrath <ben@bagu.org>
2187 Display main layout group titles in the DetailsView.
2189 This is the start of the DetailsActivity/DetailsView implementation.
2191 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2192 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2193 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2194 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2195 Get the layout information for the details view from the server and set
2196 the main layout group titles.
2197 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2198 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2199 Add addLayoutGroup() and addLayoutField() methods. This are just
2200 temporary methods for creating the the details view that will change
2202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2203 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2205 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2206 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2207 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2208 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2209 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2210 Data Transfer Objects that mimic the libglom object structure. These are
2211 used for transferring the details layout but could also be used for
2212 transferring the list layout.
2214 2011-05-27 Ben Konrath <ben@bagu.org>
2216 Reset the AuthenticationPopup when clearing the ListView.
2218 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2220 2011-05-27 Ben Konrath <ben@bagu.org>
2222 Fix problem with onlineglom.properties file loading.
2224 The old way worked in Eclipse but not on the server. Loading the
2225 onlineglom.properties file now works in Eclipse and on the server.
2227 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2229 2011-05-24 Ben Konrath <ben@bagu.org>
2231 Update gwt-log from 3.1.0 to 3.1.2.
2233 Gwt-log 3.1.0 has been marked as depreciated.
2237 2011-05-24 Ben Konrath <ben@bagu.org>
2239 Add comment to ListActivity.goTo() method.
2241 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2243 2011-05-24 Ben Konrath <ben@bagu.org>
2245 Remove FIXME in convertGdkColorToHtmlColour()
2247 The Gdk::Color value returned by libglom is 16-bits per channel on both
2248 64 and 32-bit platforms.
2250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2252 2011-05-19 Ben Konrath <ben@bagu.org>
2254 Improve performance of initial ListView load.
2256 I removed a round trip to the server for getting the default table name
2257 and then requesting information about that table. This also removes a potential
2258 problem with the table change handler not being setup in time to receive the
2259 table change event from the ListActivity.
2261 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2262 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2263 getDefaultLayoutListTable() method. Improve comments.
2264 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2265 getDefaultLayoutListTable() method instead of firing a table change
2266 event to get the table to load.
2267 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2268 implementation of getDefaultLayoutListTable() method.
2269 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2272 2011-05-19 Ben Konrath <ben@bagu.org>
2274 Override toDebugString() in TableChangeEvent.
2276 This is useful to have for debugging.
2278 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2280 2011-05-19 Ben Konrath <ben@bagu.org>
2282 Add a "Back to List" link when at the DetailsPlace.
2284 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2285 Populate the CellTable based on the selected table of the ListBox if
2286 it's set otherwise use the default table. This allows the "Back to
2288 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2289 Remove Place from constructors. Add a setPlace() method. Add
2290 goToPlace() method. Set class as presenter for TableSelectionView.
2291 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2292 Use the same TableSelectionActivity when switching between the List and
2294 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2295 Subclass the new HasSelectableTablePlace. This removes some duplicate
2297 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2298 New class to represent Places that display the TableSelectionView.
2299 * src/main/java/org/glom/web/client/place/ListPlace.java:
2300 Subclass the new HasSelectableTablePlace. This removes some duplicate
2302 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2303 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2304 Add Presenter interface. Add setBackLinkVisible() method. Add
2305 setBackLink() method.
2307 2011-05-18 Ben Konrath <ben@bagu.org>
2309 Enable the "Details" buttons.
2311 Right now only an empty details view is displayed.
2313 * src/main/java/org/glom/web/client/ClientFactory.java:
2314 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2315 Add DetailsView to ClientFactory.
2316 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2317 A basic activity for the details view.
2318 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2319 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2321 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2322 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2324 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2325 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2326 unnecessary super() in constructor.
2327 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2328 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2329 really shouldn't create a new TableSelectionActivity for both the ListPlace
2330 and the DetailsPlace so this should be considered a temporary solution.
2331 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2332 New file. Represents a URL for the details view.
2333 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2334 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2335 A basic details view interface and implementation.
2336 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2337 Enable the "Details" buttons.
2339 2011-05-12 Ben Konrath <ben@bagu.org>
2341 Use a LayoutPanel with multiple display areas for main layout.
2343 This is mostly a refactor in that there are no changes from the user
2344 point of view. These changes are required so that we can swap out the list view
2345 with the details view when the user clicks the "Details" button.
2347 * src/main/java/org/glom/web/client/ClientFactory.java:
2348 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2349 OnlineGlomView. Add TableSelectionView, ListView and
2350 AuthenticationPopup.
2351 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2352 for main layout. Add display regions for main activities. Add
2353 activity manager for for main activities.
2354 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2355 file from parts of the deleted OnlineGlomActivity.
2356 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2357 New file from parts of the deleted OnlineGlomActivity.
2358 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2359 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2360 New files for app wide table change event.
2361 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2362 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2363 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2364 Activity mappers for the main activities replace the deleted app-wide
2366 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2367 Fix a spelling error in he comment.
2368 * src/main/java/org/glom/web/client/ui/ListView.java:
2369 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2370 Renamed from LayoutListView and modified for MVP. This still not a
2371 proper dumb view as prescribed by the MVP pattern but it works for now.
2372 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2373 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2374 New widget stripped out of the deleted OnlineGlomView.
2375 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2376 Remove hack that is fixed by this patch.
2378 2011-05-06 Ben Konrath <ben@bagu.org>
2380 Rename OnlineGlomPlace to ListPlace.
2382 The only change besides the rename is that url will now display #list
2383 instead of #Document.
2385 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2386 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2387 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2388 * src/main/java/org/glom/web/client/place/ListPlace.java:
2389 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2391 2011-05-06 Ben Konrath <ben@bagu.org>
2393 Use Presenter for app navigation.
2395 This is the proper way to deal with Place (URL) changes with the MVP
2398 * src/main/java/org/glom/web/client/ClientFactory.java:
2399 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2400 PlaceHistoryMapper and PlaceHistoryHandler.
2401 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2402 PlaceHistoryMapper and PlaceHistoryHandler.
2403 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2404 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2405 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2406 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2407 Add Presenter interface and setPresenter methods. Rename addHyperLink
2408 to addDocumentLink taking only the document title as a parameter.
2410 2011-04-14 Ben Konrath <ben@bagu.org>
2412 Prompt for db username/password if they haven't been set.
2414 This is implemented with a popup widget that is contained within the
2415 OnlineGlomView and managed by the OnlineGlomActivity.
2417 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2418 methods for checking and setting the database username and password.
2419 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2420 new methods for checking and setting the database username and
2422 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2423 Display authentication popup if the JDBC connection to the database
2424 has not been authenticated.
2425 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2427 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2428 for dealing with the authentication popup.
2429 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2430 Implement the methods for dealing with the authentication popup.
2431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2432 try to executed queries if the database connection hasn't been
2433 authenticated. Implement methods for checking and setting the
2434 database username and password.
2436 2011-04-12 Ben Konrath <ben@bagu.org>
2438 Make log messages a little clearer.
2440 Add a dash betweeen the document title and the table name.
2442 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2444 2011-04-12 Ben Konrath <ben@bagu.org>
2446 Protect against NPEs when cleaning up database resources.
2448 While this isn't strictly necessary because the exception is caught,
2449 not protecting against the NPEs makes it harder to find the real error
2452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2454 2011-04-12 Ben Konrath <ben@bagu.org>
2456 Move configuration of the servlet to the constructor.
2458 The servlet will be initialized even if the database authentication
2459 information is not set or correct. I still need to add the UI for prompting
2460 the user for the authentication information when it's required.
2462 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2463 javadocs for getDocumentTitles() method.
2464 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2465 Set error message when RPC fails.
2466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2467 glom files directory from the configuration file. Try to set the
2468 database authentication information for the specific document if it's
2469 set and works otherwise try to use the global authentication
2470 information set for the directory.
2471 * src/main/resources/onlineglom.properties: Moved from
2472 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2473 Added detailed comments for the new keys.
2475 2011-04-11 Ben Konrath <ben@bagu.org>
2477 Remove unnecessary @Override in DocumentSelectionViewImpl.
2479 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2481 2011-04-11 Ben Konrath <ben@bagu.org>
2483 Remove center alignment in DocumentSelectionView.
2485 The title element is still centred but the document titles and bottom
2486 sentence are both left-aligned.
2488 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2490 2011-04-11 Ben Konrath <ben@bagu.org>
2492 Change 'Demo' naming convention to 'Document'.
2494 This is just a rename refactor with no functional changes to the code.
2496 * src/main/java/org/glom/web/client/ClientFactory.java:
2497 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2498 * src/main/java/org/glom/web/client/OnlineGlom.java:
2499 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2500 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2501 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2502 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2503 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2504 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2505 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2506 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2507 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2508 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2510 2011-04-08 Ben Konrath <ben@bagu.org>
2512 Remove FIXME from safeLongToInt() method.
2514 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2519 2011-04-08 Ben Konrath <ben@bagu.org>
2521 Display an error if no glom documents are found in the specified directory.
2523 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2524 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2525 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2528 2011-04-08 Ben Konrath <ben@bagu.org>
2530 Add copyright header to one more file ... oops.
2532 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2534 2011-04-08 Ben Konrath <ben@bagu.org>
2536 Add copyright header to files without it.
2538 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2539 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2540 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2541 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2542 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2543 * src/main/java/org/glom/web/shared/GlomField.java:
2545 2011-04-08 Ben Konrath <ben@bagu.org>
2547 Add support for accessing multiple glom documents in the servlet.
2549 This completes the demo selection functionality.
2551 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2552 document title to methods.
2553 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2554 document title to methods.
2555 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2556 Set browser window title when the activity starts. Correct name of
2557 document title variable.
2558 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2559 Set browser window title when the activity starts. Set the table
2560 selector change handler after table selector has been set. Clear the
2561 OnlineGlomView when the activity has been stopped.
2562 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2563 document title as the place token. Use "#Document:" instead of
2564 "#OnlineGlomPlace:" in the URL.
2565 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2566 Change heading to "Online Glom"
2567 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2568 document title in RPC methods.
2569 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2570 setDocumentTitle() method. Add clear() method.
2571 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2572 setDocumentTitle() method. Implement clear() method which removes the
2573 change handler on the ListBox, clears the ListBox and clears the
2575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2576 Implement methods with document title. Keep track for the configured
2577 glom documents and their corresponding JDBC configurations in a hash
2578 table. This information is retrieved using the document title as the
2579 key in the hash table.
2580 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2581 document title field as it's no longer needed.
2583 2011-04-08 Ben Konrath <ben@bagu.org>
2585 Update the Eclipse JDT configuration.
2587 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2588 methods. Automatically add the copyright header to new files.
2590 2011-04-05 Ben Konrath <ben@bagu.org>
2592 Add new page for demo selection.
2594 This patch adds all the components required to view and start an
2595 OnlineGlom demo by clicking on the desired hyperlink. The user is
2596 able to return to the demo selection page with the browser's back
2597 button. I still need to modify the servlet to work with multiple
2598 documents so all demo links will load the file defined in the
2599 OnlineGlom.properties.
2601 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2602 This is only useful during development so we don't need to save it.
2603 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2604 get a reference to the DemoSelectionView.
2605 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2606 method to get a reference to the DemoSelectionView.
2607 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2608 default view to DemoSelectionView.
2609 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2610 to get glom document titles for glom files in a hard-coded directory.
2611 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2612 method to get glom document titles for glom files in a hard-coded
2614 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2615 Presenter for DemoSelectionView.
2616 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2617 for DemoSelectionView.
2618 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2619 Update for DemoSelectionView.
2620 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2621 Basic 'Place' implementation for the DemoSelectionView.
2622 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2623 The interface for the DemoSelectionView.
2624 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2625 The implementation of the DemoSelectionView.
2626 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2627 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2629 implementation of method to get glom document titles for glom files
2630 in a hard-coded directory.
2631 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2632 on longer being used.
2633 * src/main/webapp/glom.png: Glom logo.
2635 2011-04-05 Ben Konrath <ben@bagu.org>
2637 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2639 This is the forth and final commit of a refactor that will allow
2640 OnlineGlom to be used with multiple documents.
2642 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2643 Move RPC code from OnlineGlomViewImpl to this class.
2644 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2646 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2647 RPC code to the presenter class (the P in MVP).
2649 2011-04-04 Ben Konrath <ben@bagu.org>
2651 Start moving the existing OnlineGlom code to MVP.
2653 This work is based on the GWT MVP framework that is documented here:
2655 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2657 This is the third commit of a refactor that will allow OnlineGlom to
2658 be used with multiple documents.
2660 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2661 Interface for client factory which is used to get instances of various
2662 classes throughout the app.
2663 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2664 Implementation of client factory.
2665 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2666 initialize the MVP framework.
2667 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2668 New file. Activity manager for the main container widget. This is the
2670 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2671 Maps place (URL) to its corresponding activity.
2672 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2673 New file. This is just a place holder for a generated file.
2674 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2675 New file. Represents the URL for the main Online Glom app.
2676 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2677 for changes in LayoutListViewImpl.
2678 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2679 interface for View. Move code to OnlineGlomViewImpl class.
2680 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2681 file. Implementation of OnlineGlomView.
2682 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2683 Place resources. Use ClientFactoryImpl by default.
2685 2011-04-04 Ben Konrath <ben@bagu.org>
2687 Move View classes to their own package.
2689 This is the second commit of a refactor that will allow OnlineGlom to
2690 be used with multiple documents.
2692 * src/main/java/org/glom/web/client/OnlineGlom.java:
2693 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2694 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2696 2011-04-02 Ben Konrath <ben@bagu.org>
2698 Move UI code from the main module to its own class.
2700 This is the first commit of a refactor that will allow OnlineGlom to be
2701 used with multiple documents.
2703 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2704 references to OnlineGlom to OnlineGlomView.
2705 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2706 OnlineGlomView and instantiate it here.
2707 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2708 represents the main OnlineGlomView with one document.
2710 2011-04-01 Ben Konrath <ben@bagu.org>
2712 Fix formatting of gwt.xml and add DTD.
2714 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2716 2011-03-30 Ben Konrath <ben@bagu.org>
2718 Propperly convert gdkColor string to html colour string.
2720 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2722 2011-03-28 Ben Konrath <ben@bagu.org>
2724 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2726 This implementation matches
2727 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2728 readable and is not tied to Swig.
2730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2732 2011-03-28 Ben Konrath <ben@bagu.org>
2734 Use read-only checkboxes for boolean field types.
2736 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2737 in the CellTable based on the field type. It currently only
2738 distinguishes between boolean and text columns but I'll need to add
2739 support for more types.
2740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2741 column type in the ColumnInfo object. Add method to convert between the
2742 glom field type enum in ColumnInfo and the glom field type in libglom.
2743 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2745 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2746 getting and setting booleans.
2748 2011-03-25 Ben Konrath <ben@bagu.org>
2750 Don't get the Date twice from the ResultSet.
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2754 2011-03-25 Ben Konrath <ben@bagu.org>
2756 Cleanup code in the servlet.
2758 * TODO: Remove item about row count. Add item about testing row count
2759 query with large number of rows.
2760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2761 spelling mistakes, change method parameter to be consistent with
2764 2011-03-25 Ben Konrath <ben@bagu.org>
2766 Add server side logging with the gwt-log library.
2768 * .gitignore: Ignore the log file we're now producing.
2769 * TODO: Add a couple TODO item for logging.
2770 * pom.xml: Add gwt-log and log4j as a dependency.
2771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2772 logging of errors, warnings and some important info.
2773 * src/main/resources/log4j.properties: New file to configure log4j.
2775 2011-03-24 Ben Konrath <ben@bagu.org>
2777 Add a disable button for the Details view.
2779 * src/main/java/org/glom/web/client/LayoutListView.java:
2781 2011-03-22 Ben Konrath <ben@bagu.org>
2783 Use a count query to get the number of rows for the list view pager.
2785 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2787 2011-03-22 Ben Konrath <ben@bagu.org>
2789 Add more TODO information about CellTable pager positioning.
2793 2011-03-19 Ben Konrath <ben@bagu.org>
2795 Add TODO item about CellTable pager positioning.
2799 2011-03-18 Ben Konrath <ben@bagu.org>
2801 Remove unneeded GlomFieldColumn class.
2803 This is just a small code cleanup.
2805 * src/main/java/org/glom/web/client/LayoutListView.java:
2807 2011-03-18 Ben Konrath <ben@bagu.org>
2809 Use cursor mode in the query that gets data for the list view.
2811 I still need to fix the potential memory problem when getting the row
2812 count for the list view.
2814 * TODO: Add note about testing memory usage with large data sets. Add
2815 item about fixing row counting with large data sets.
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2817 PostgreSQL JDBC driver into cursor mode when getting data for the
2820 2011-03-15 Ben Konrath <ben@bagu.org>
2822 Remove the GWT Container from the Eclipse build classpath.
2824 The GWT dependencies are set by Maven so this isn't needed.
2828 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2830 Added some earlier mockups to git, but not to the tarball dist.
2832 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2833 Openismus. These hopefully show how we might structure the HTML so that
2834 it can be styled easily with CSS. However, we probably need to adapt them
2835 for the CSS structure that GWT dictates for common widgets.
2837 2011-03-14 Ben Konrath <ben@bagu.org>
2839 Locate OnlineGlom.properties using the ServletContext.
2841 This is required to be able to locate the file in the deployed servlet.
2843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2844 Configure the database and glom document in in a helper method so
2845 that the ServletContext can be used to locate OnlineGlom.properties.
2846 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2847 src/main/webapp. This is the proper location for .properites files.
2849 2011-03-12 Ben Konrath <ben@bagu.org>
2851 Add note to README about why we're compiling down to obfuscated JavaScript.
2855 2011-03-11 Ben Konrath <ben@bagu.org>
2857 Use properties file to configure servlet.
2859 This allows people to change the glom file path, db username and db
2860 password without recompiling the code.
2862 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2863 * src/main/webapp/OnlineGlom.properties:
2865 2011-03-11 Ben Konrath <ben@bagu.org>
2867 Use table fields in layout list view if the layout list is not defined.
2869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2870 Manually create a LayoutFieldVector for the query builder using the
2871 table fields when a layout list is not defined in the glom file.
2873 2011-03-11 Ben Konrath <ben@bagu.org>
2875 Only show FIXME string for images when there's an image.
2877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2878 in this change are some small code cleanups.
2880 2011-03-11 Ben Konrath <ben@bagu.org>
2882 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2886 2011-03-11 Ben Konrath <ben@bagu.org>
2888 Correctly set the index of the default table.
2890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2891 Correctly set the index of the default table. Add commented out example
2894 2011-03-10 Ben Konrath <ben@bagu.org>
2896 Add comment to pom.xml about the previous change.
2898 * pom.xml: Add comment about the deployment issue so that it's obvious
2899 why java-libglom is set to the provided scope.
2901 2011-03-10 Ben Konrath <ben@bagu.org>
2903 Change java-libglom dependency from compile to provided in pom.xml.
2905 Since java-libglom uses jni it can only be loaded once and therefore
2906 must be placed in $CATALINA_HOME/lib and not included in each war.
2907 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2908 More information about this issue can be found in the Tomcat 6 release
2909 notes in the "JNI Based Applications" section:
2911 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2913 * README: Remove note about this issue. Deployment info should really
2914 be on the wiki anyway so I'll add it right now.
2915 * pom.xml: Change java-libglom dependency from compile to provided so
2916 that it's copied in to the packaged war.
2918 2011-03-09 Ben Konrath <ben@bagu.org>
2920 Change to using a neutral locale for currency, date and time formatting.
2922 This solves the problem of currency values being represented without a
2923 space between the currency code and the number (e.g. "EUR5.89" is now
2924 represented as "EUR 5.89"). More work is required when we implement
2925 a locale preference setting.
2927 * TODO: Add note about currency formatting issues with different
2929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2930 to using the neutral ROOT locale.
2932 2011-03-09 Ben Konrath <ben@bagu.org>
2934 Add support for currency codes that are not ISO 4217 codes.
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2937 the currency code defined in the glom file when it's not 3 characters
2938 long or when Java doesn't recognize the string as an ISO 4217 code.
2940 2011-03-08 Ben Konrath <ben@bagu.org>
2942 Remove test classes, launch configurations and configuration.
2944 The test stuff was getting in the way when creating the war. To make
2945 the war file you can now do 'mvn clean package'. The packaged war file
2946 will be in the target directory.
2948 * .classpath: Remove unused classpathentry for tests and i18n.
2949 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
2950 property. Don't run test or i18n goals when packaging the war.
2951 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
2956 * OnlineGlomTest-dev.launch:
2957 * OnlineGlomTest-prod.launch:
2958 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2959 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
2961 2011-03-07 Ben Konrath <ben@bagu.org>
2963 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
2965 These fixes allow me to use 'mvn deploy' to create the war file.
2967 * .classpath: This generated config has been updated by Eclipse. This
2968 change was probably triggered by me updating from Eclipse 3.6.1 to
2970 * .gitignore: Add entry to ignore the directory
2971 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
2972 * .project: The generated config has been updated by Eclipse. This
2973 change was probably triggered by me updating from Eclipse 3.6.1 to
2975 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
2976 so that Eclipse doesn't complain
2977 * pom.xml: Update to gwt-maven-plugin 2.2.0.
2978 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
2979 'tests' directory to 'client' directory. This is the new
2980 gwt-maven-plugin convension.
2981 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
2982 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
2984 2011-03-07 Ben Konrath <ben@bagu.org>
2986 Add support for horizontal alignment in the LayoutList columns.
2988 * TODO: Remove item about horizontal alignment. Add item about
2989 improvements to ColumnInfo.
2990 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
2991 alignment on the columns. Use ColumnInfo RPC object get the column
2992 title and horizontal alignment.
2993 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
2994 LayoutListView creation with ColumnInfo RPC object.
2995 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2996 a ColumnInfo object for every LayoutList columnn. Convert the
2997 FieldFormatting.HorizontalAlignment to the correct
2998 ColumnnInfo.HorizontatlAlignment with the new
2999 getColumnInfoHorizontalAlignment helper method.
3000 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3001 to encapsulate column information like alignment and title. This
3002 could be used to set the colour instead of on a per cell field basis.
3003 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3004 column title storage and retrieval with ColumnInfo.
3006 2011-03-04 Ben Konrath <ben@bagu.org>
3008 Add support for column sorting.
3010 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3011 AsynDataProvider to be an anonymous inner class. Use new
3012 getSortedTableData RPC method when column sort is requested. Set all
3013 columns sortable and add an AsyncHandler to activate sorting in the
3015 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3016 method getSortedTableData(). Cleanup other method signatures.
3017 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3018 new method getSortedTableData(). Cleanup other method signatures.
3019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3020 Implement getSortedTableData() and getTableData() methods by using a
3021 private helper method with the appropriate parameters filled in. Use
3022 user supplied sort clause when supplied, otherwise fall back to
3023 sorting by the primary key. Move destroy() method to be underneath
3024 constructor for readability. Cleanup comments.
3026 2011-03-03 Ben Konrath <ben@bagu.org>
3028 Add support for colour text and colour backgrounds to the layout list cells.
3030 Only the cell backgrounds are coloured which leaves a gap between the
3031 cells that isn't coloured. I need to figure out a way to set
3032 'style=background-colour:' on the whole column rather than just the
3035 * TODO: Add a note about colouring the background of the whole column.
3036 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3037 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3038 render the coloured text and backgrounds. Use GlomField[] for the row type.
3039 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3041 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3042 GlomField[] for the row type.
3043 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3044 GlomField[] for the row type. Set the text, text colour and background
3045 colour in the GlomField objects as specified in the glom document. Add
3046 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3047 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3048 the glom field text, foreground colour and background colour.
3050 2011-03-02 Ben Konrath <ben@bagu.org>
3052 Don't display hidden tables in the combo box.
3054 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3057 code to ignore hidden tables using ArrayLists for the table names and
3059 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3060 tableNames to use ArrayLists instead of String[]. Update getter and setter
3063 2011-03-01 Ben Konrath <ben@bagu.org>
3065 Add support for Date and Time number types.
3067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3068 Implement formatting for Date and Time values. Change the default glom
3069 file to small business example.
3071 2011-03-01 Ben Konrath <ben@bagu.org>
3073 Add support for formatting glom types as specified in the glom file.
3075 Formatting isn't finished yet - I still need to add support for Date
3078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3079 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3080 checks for null values in JDBC cleanup code and catch all exceptions
3081 instead of just SQLExceptions.
3082 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3085 2011-03-01 Ben Konrath <ben@bagu.org>
3087 Use GWT 2.2.0 instead of 2.1.1.
3089 * pom.xml: Change GWT version numbers.
3091 2011-03-01 Ben Konrath <ben@bagu.org>
3093 A few small code cleanups.
3095 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3097 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3098 unnecessary object creation in constructor.
3099 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3100 unnecessary object creation in constructor.
3102 2011-02-28 Ben Konrath <ben@bagu.org>
3104 Add file for TODO list.
3108 2011-02-18 Ben Konrath <ben@bagu.org>
3110 Enable the CellTable Pager when more than 20 rows need to be viewed.
3112 The Pager will automatically become active when the results are larger
3113 than the CellTable size which is currently set to 20 lines.
3115 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3116 name on debug statment in RPC call in LayoutListDataProvider, add
3117 numRows parameter to LayoutListView constructor, propperly set rowCount
3119 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3120 name on debug statment in RPC call, use LayoutListTable object in RPC
3121 calls, pass rowCount to LayoutListView.
3122 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3123 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3125 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3126 interface for changes in OnlineGlomService.
3127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3128 getLayoutListHeaders() to getLayoutListTable() and return
3129 LayoutListTable. Using this object allows me to pass other information
3130 about the LayoutList like the expected number of rows in the result set.
3131 The Connection object from the connection pool is now propperly closed.
3132 Only the requested number of lines are returned to the client in
3134 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3135 GlomTable and add columnTitles and numRows.
3137 2011-02-18 Ben Konrath <ben@bagu.org>
3139 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3141 This is a small performance boost. I'll use GlomTable to get the required
3142 layoutlist information.
3144 * src/main/java/org/glom/web/client/OnlineGlom.java:
3145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3146 * src/main/java/org/glom/web/shared/GlomDocument.java:
3148 2011-02-18 Ben Konrath <ben@bagu.org>
3150 Add option to turn off formatting in JDT formatter preferences.
3152 * .settings/org.eclipse.jdt.core.prefs:
3154 2011-02-18 Ben Konrath <ben@bagu.org>
3156 Rename LayoutList to LayoutListView.
3158 I'm working towards setting things up to easily use MVP when the time
3161 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3163 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3166 2011-02-17 Ben Konrath <ben@bagu.org>
3168 Move LayoutListDataProvider class into LayoutList.java.
3170 * src/main/java/org/glom/web/client/LayoutList.java:
3172 2011-02-17 Ben Konrath <ben@bagu.org>
3174 Rename RPC service classes from LibGlomService* to OnlineGlomService*.
3176 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Update
3178 * src/main/java/org/glom/web/client/OnlineGlom.java: Update references.
3179 * src/main/java/org/glom/web/client/OnlineGlomService.java: Rename
3180 from LibGlomServer.java.
3181 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3182 Rename from LibGlomServiceAsync.java.
3183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3184 Rename from LibGlomServiceImpl.java.
3185 * src/main/webapp/WEB-INF/web.xml: Update configuration.
3187 2011-02-17 Ben Konrath <ben@bagu.org>
3189 Update JDT settings.
3191 * .settings/org.eclipse.jdt.core.prefs:
3193 2011-02-17 Ben Konrath <ben@bagu.org>
3195 Move GWT-RPC objects to shared package (where they should be).
3197 * src/main/java/org/glom/web/client/LibGlomService.java: Update imports.
3198 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Update imports.
3199 * src/main/java/org/glom/web/client/OnlineGlom.java: Update imports.
3200 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Update imports.
3201 * src/main/java/org/glom/web/shared/GlomDocument.java: Move to
3202 org.glom.web.shared package.
3203 * src/main/java/org/glom/web/shared/GlomTable.java: Move to
3204 org.glom.web.shared package.
3205 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Included shared
3206 directory in compilation to javascript.
3208 2011-02-16 Ben Konrath <ben@bagu.org>
3210 Add sort clause to the sql query that grabs table information.
3212 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add sort clause
3213 if one of the columns is a primary key.
3215 2011-02-16 Ben Konrath <ben@bagu.org>
3217 Disable generateAsync feature of gwt-maven.
3219 The generated interface does not correctly match the methods in LibGlomService
3220 and the generated singleton Util inner-class doesn't respect the servlet
3223 * pom.xml: Turn off generateAsync feature.
3224 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Re-add file
3225 with singleton Util inner-class.
3227 2011-02-14 Ben Konrath <ben@bagu.org>
3229 Add LGPL v3 licence notices.
3231 Followed directions listed here:
3232 http://www.gnu.org/licenses/gpl-howto.html
3234 * COPYING: This file is a copy of the GPL v3.
3235 * COPYING.LESSER: This file is a copy of the LGPL v3.
3236 * src/main/java/org/glom/web/client/GlomDocument.java: Add licence