1 2012-04-18 Murray Cumming <murrayc@murrayc.com>
3 ReportGenerator: Use the correct numeric formatting.
5 * src/main/java/org/glom/web/server/ReportGenerator.java
6 createFieldExpression(), createFieldValueElement(): Take the
7 whole LayoutItem_Field instead of just the field name, so
8 we have access to the formatting.
9 createFieldValueElement(): Use JRTextField.setPattern() to
10 specify the numeric formatting, with the help of a
11 regular DecimalFormat.
13 2012-04-18 Murray Cumming <murrayc@murrayc.com>
15 ReportGenerator: Avoid showing null for group by titles.
17 * src/main/java/org/glom/web/server/ReportGenerator.java
18 generateReport(): Use setBlankWhenNull() on the field title
19 style too, because this is used for values in group by
22 2012-04-18 Murray Cumming <murrayc@murrayc.com>
24 ReportGenerator: Add a colon to titles in vertical groups.
26 * src/main/java/org/glom/web/server/ReportGenerator.java
27 addFieldToDetailBandVertical(): Pass true for the withColon
30 2012-04-18 Murray Cumming <murrayc@murrayc.com>
32 ReportGenerator: Simplify the code by using Position more.
34 2012-04-18 Murray Cumming <murrayc@murrayc.com>
36 Reports: Support vertical groups, roughly.
38 * src/main/java/org/glom/web/server/ReportGenerator.java:
39 addToReport(): Rename to addGroupToReport() and, if necessary,
40 call the new addVerticalGroupToReport() method.
41 createFieldValueElement(): Let the caller specify the Y position
44 2012-04-17 Murray Cumming <murrayc@murrayc.com>
46 Reports: Allow a second report to be shown.
48 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
49 clear(): Do not remove the HTML widget, which broke the whole layout.
51 2012-04-17 Murray Cumming <murrayc@murrayc.com>
53 Locales drop-down: Show that we use English by default.
55 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
56 fillView(): When we use English, just because that is the default, when
57 no locale is specified, show that in the Locales drop-down instead of
58 just showing the first item.
60 2012-04-17 Murray Cumming <murrayc@murrayc.com>
62 Unselect the Report/Locale/Table combo item when appropriate.
64 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
65 setPlace(): clear reportName if this is not a ReportPlace.
66 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
67 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
68 When the provided name is empty, unselect all items, so that none are
69 indicated. This uses a for loop because I cannot find a single method
72 2012-04-17 Murray Cumming <murrayc@murrayc.com>
74 Report: Give the user a way to get back to the list.
76 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
77 start(), setPlace(): Show the Back To List link on reports, and also
78 interpret selecting the empty report item as back to list.
80 2012-04-17 Murray Cumming <murrayc@murrayc.com>
82 Style: Remove overflow:hidden from searchbox
84 * src/main/webapp/style.css: Because this pushes the Back To Link
85 label/link on to the next row, which is then hidden due to the
86 hard-coded (in ems) height.
88 2012-04-13 Murray Cumming <murrayc@murrayc.com>
90 Really show the selected Report name.
92 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
93 setPlace(): Store the reportName here, if it is that kind of Place.
94 fillView(): Set the selected Report after filling the list of reports.
95 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
96 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
97 null Strings, though we need some way to unselect all ListBox items
100 2012-04-13 Murray Cumming <murrayc@murrayc.com>
102 ReportGenerator: Try to avoid some problems.
104 * src/main/java/org/glom/web/server/ReportGenerator.java
105 addField(): Try to avoid duplicates, and avoid using a null
108 2012-04-13 Murray Cumming <murrayc@murrayc.com>
110 Reports: Use quickFind.
112 * src/main/java/org/glom/web/client/OnlineGlomService.java;
113 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
115 getReportHTML(): Add a quickFind parameter.
116 * src/main/java/org/glom/web/client/activity/ReportActivity.java
117 start(): Pass the quickFind parameter.
118 * src/main/java/org/glom/web/server/ReportGenerator.java
119 generateReport(): Take a quickFind parameter.
121 2012-04-13 Murray Cumming <murrayc@murrayc.com>
123 ReportPlace: Actually use the report name.
125 * src/main/java/org/glom/web/client/place/ReportPlace.java
126 getPlace(): Do not assign the report name to the quickfind.
128 2012-04-13 Murray Cumming <murrayc@murrayc.com>
130 Show java.library.path when complaining.
132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
133 init(): When telling us to check java.library.path, show the
136 2012-04-12 Murray Cumming <murrayc@murrayc.com>
138 Adapt to the java-libglom 1.21.8 API.
140 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
141 java-libglom's FieldFormatting is now Formatting.
143 2012-04-12 Murray Cumming <murrayc@murrayc.com>
145 Use the latest java-libglom version.
147 * pom.xml: Use java-libglom 1.21.8.
149 2012-03-15 Murray Cumming <murrayc@murrayc.com>
151 Adapt to the java-libglom 1.21.7 API.
153 * src/main/java/org/glom/web/server/ReportGenerator.java:
154 addToReport(): get_group_secondary_fields() is now
155 get_secondary_fields().
157 2012-03-15 Murray Cumming <murrayc@murrayc.com>
159 Use the latest java-libglom version.
161 * pom.xml: Use java-libglom 1.21.7.
163 2012-03-06 Murray Cumming <murrayc@murrayc.com>
165 ReportGenerator: Do not show nulls.
167 2012-03-06 Murray Cumming <murrayc@murrayc.com>
169 ReportGenerator: Make the title font larger.
171 2012-03-06 Murray Cumming <murrayc@murrayc.com>
173 ReportGenerator: Put field titles inside groups, if there are groups.
175 2012-03-06 Murray Cumming <murrayc@murrayc.com>
177 ReportGenerator: Take the Report itself instead of the name and group.
179 * src/main/java/org/glom/web/server/ConfiguredDocument.java
180 Remove getReportLayoutGroup().
181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
182 getReportHTML(): Pass the report instead
183 of its name and layout group.
184 * src/main/java/org/glom/web/server/ReportGenerator.java
185 generateReport(): Use the report object to use the title
188 2012-03-06 Murray Cumming <murrayc@murrayc.com>
190 ReportGenerator: Remove designBand parameters.
192 * src/main/java/org/glom/web/server/ReportGenerator.java:
193 Make designBand a class member instead of passing it to all
196 2012-03-06 Murray Cumming <murrayc@murrayc.com>
198 ReportGenerator: Add lines, a bit like in the desktop version.
200 * src/main/java/org/glom/web/server/ReportGenerator.java
201 addToReport(): Use JRDesignLine.
203 2012-03-06 Murray Cumming <murrayc@murrayc.com>
205 ReportGenerator: Correct the title positions and use some bold style.
207 * src/main/java/org/glom/web/server/ReportGenerator.java:
208 Break the code up into reusable functions, correct the placement of
209 titles, and use normal/bold styles as in the reports in the desktop
212 2012-03-06 Murray Cumming <murrayc@murrayc.com>
214 ReportGenerator: Add a header band to show the field titles.
216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
217 getReportHTML(): Pass the localeId to the ReportGenerator
219 * src/main/java/org/glom/web/server/ReportGenerator.java
220 constructor: Take the localeID so we can get translated field
222 generateReport(), addToReport(), addFieldToBand(): Add field
223 titles in a column header band.
225 2012-03-05 Murray Cumming <murrayc@murrayc.com>
227 Reports drop-down list: Some improvement.
229 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
230 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
231 Adedd setSelectedReport(),
232 setReportList(): Add a blank line so that the user can select the
234 * src/main/java/org/glom/web/client/activity/ReportActivity.java
235 start(): Show the current report by calling setSelectedReport().
236 This does not seem to work yet.
238 2012-03-05 Murray Cumming <murrayc@murrayc.com>
240 DetailsActivity, ListActivity: Move some variables into a base class.
242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
243 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
244 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
245 the clientFactory, documentID, tableName and authenticationPopup into
246 a base class, to avoid duplication.
248 2012-03-05 Murray Cumming <murrayc@murrayc.com>
250 Translate the Reports label.
252 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
253 Get the "Reports" label string from the constants.
254 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
255 perties: Add Reports to the constants.
257 2012-03-03 Ben Konrath <ben@bagu.org>
259 Display date and time in details view.
261 https://bugzilla.gnome.org/show_bug.cgi?id=671257
263 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
265 2012-03-05 Murray Cumming <murrayc@murrayc.com>
267 Require the latest java-libglom.
269 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
271 2012-03-05 Murray Cumming <murrayc@murrayc.com>
273 Reports: Implement grouping.
275 * src/main/java/org/glom/web/server/ReportGenerator.java:
276 Handle LayoutItem_GroupBy items and try to do the right thing
277 with JRDesignGroup. It seems to work.
279 2012-03-04 Murray Cumming <murrayc@murrayc.com>
281 Actually show some data with JasperReports.
283 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
284 getReportHTML(): Move most code into a ReportGenerator class.
285 * src/main/java/org/glom/web/server/ReportGenerator.java:
286 Recurse into sub-groups, adding fields to the JasperDesign's details
287 band. Note that we must set an arbitrary width and height, or it just
288 will not show any data.
290 2012-03-04 Murray Cumming <murrayc@murrayc.com>
292 Reports Chooser: Show the titles, not the names.
294 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
295 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
296 and the names as the values.
297 * src/main/java/org/glom/web/server/ConfiguredDocument.java
298 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
299 group now that we provide the report name, so it should always
302 2012-03-04 Murray Cumming <murrayc@murrayc.com>
304 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
306 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
307 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
308 an empty quickfind string. I also corrected libglom to create only
309 empty where clauses for empty quickfind strings, but this avoids the
312 2012-02-24 Ben Konrath <ben@bagu.org>
314 Improve the tabs in the Notebook widget.
318 2012-02-15 Murray Cumming <murrayc@murrayc.com>
320 Depend on jasperreports.
322 * pom.xml: Add the dependency. My plan is to use this on the
325 2012-01-31 Murray Cumming <murrayc@murrayc.com>
327 Implement navigation to report places.
329 * src/main/java/org/glom/web/client/activity/ReportActivity.java
330 start(): Do not bother to handle all events here.
331 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
332 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
333 Added getSelectedReport().
334 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
335 .java: start(): When handling a change to the reports chooser,
336 call getSelectedReport() and goTo() its ReportPlace.
337 * src/main/java/org/glom/web/client/ui/ReportView.java
338 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
339 Added setReportHTML() which puts the html in a gwt HTML widget.
340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
341 getReportHTML(): Return "TODO" just to show that this works.
343 2012-01-31 Murray Cumming <murrayc@murrayc.com>
345 Make ReportPlace usable.
347 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
349 * src/main/java/org/glom/web/client/place/ReportPlace.java:
350 Correct the @prefix annotation.
352 2012-01-31 Murray Cumming <murrayc@murrayc.com>
354 OnlineGlomService: Return report HTML rather than the LayoutGroup.
356 * src/main/java/org/glom/web/client/OnlineGlomService.java:
357 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
358 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
359 Change getReportLayout() to getReportHMTL() because we will not need to
360 parse or render the report layout on the client side.
361 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
362 getReportLayout(): Return the libglom LayoutGroup type because we will
363 not need to convert to a shared type, because this will not be used on
365 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
368 Note that there is still no implementation for this.
370 2012-01-30 Murray Cumming <murrayc@murrayc.com>
372 Translations: Try to translate the strings.
374 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
375 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
376 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
377 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
378 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
379 Take the Open translation from GTK+'s .po files.
380 Take the Details translation from Glom's po files.
381 I have added the other strings to Glom so we can get translations that way:
382 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
384 2012-01-27 Murray Cumming <murrayc@murrayc.com>
386 Add a (empty) Report Place, View, and Activity.
388 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
390 * src/main/java/org/glom/web/client/place/HasTablePlace.java
391 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
392 this into a superclass:
393 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
394 and also use it as the base of this new ReportPlace:
395 * src/main/java/org/glom/web/client/place/ReportPlace.java
397 * src/main/java/org/glom/web/client/ui/ReportView.java
398 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
399 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
400 Add these, containing mostly boiler-plate for now.
402 * src/main/java/org/glom/web/client/OnlineGlomService.java
403 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
404 * src/main/java/org/glom/web/server/ConfiguredDocument.java
405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
406 Add API to get the LayoutGroup for the report.
408 2012-01-27 Murray Cumming <murrayc@murrayc.com>
410 TableSelectionViewImpl: Put the search label and entry in a div.
412 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
413 Put the search widgets in a FlowTable so that the CSS can be used to
414 style them while keeping them together.
415 * src/main/webapp/style.css: Mention the new div.
417 2012-01-27 Murray Cumming <murrayc@murrayc.com>
419 Translate more strings in more locales.
421 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
422 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
423 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
424 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
425 Translate the "Details" and "Open" string too.
427 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
428 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
429 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
430 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
431 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
432 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
433 Add these new locales as placeholders though they currently contain English.
435 2012-01-27 Murray Cumming <murrayc@murrayc.com>
437 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
439 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
440 Check the ConfiguredDocument* for null before using it.
442 2012-01-26 Murray Cumming <murrayc@murrayc.com>
444 Tell Eclipse about the generated java files.
446 * .classpath: This lets it find OnlineGlomConstants.java.
447 It would be nice if Eclipse just used the maven build files.
449 2012-01-26 Murray Cumming <murrayc@murrayc.com>
451 Prevent a crash when no locale is specified in the URL.
453 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
454 Avoid returning a null string, obtained from
455 Window.Location.getParameter(). This caused a crash when it was
456 later passed to libglom's API.
457 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
458 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
459 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
460 guard against future null strings.
462 2012-01-26 Murray Cumming <murrayc@murrayc.com>
464 Use the ?locale= query param instead of the &lang= token param.
466 * src/main/java/org/glom/web/client/place/ListPlace.java
467 * src/main/java/org/glom/web/client/place/DetailsPlace.java
468 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
469 Remove the lang token key and value.
471 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
472 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
473 When the user selects a different locale from the chooser, use
474 Window.Location.assign() to change the URL, which then causes a reload.
476 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
477 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
478 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
479 * src/main/java/org/glom/web/client/activity/ListActivity.java
480 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
481 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
482 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
483 * src/main/java/org/glom/web/client/ui/ListView.java:
484 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
486 Remove localeID member variables and method/constructor parameters, instead
487 using Utils.getCurrentLocaleID() when we need a localID to pass to
490 2012-01-26 Murray Cumming <murrayc@murrayc.com>
492 Internationalize the UI strings.
494 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
495 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
496 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
497 because it is unused. Messages are apparently strings that can have
498 parameters, but we do not need that yet, so Contants will be enough for now.
499 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
500 to say that we support the en and de locales.
501 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
502 The original English strings.
503 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
504 Some German translations of the English strings.
505 The i18n goal then uses the .properties file to generate an
506 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
507 returns an implementation that returns the translated strings.
508 The documentation suggests putting these in src/java/*/client/, but it seems
509 best to put it in src/resources/*/client/.
510 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
511 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
512 instead of hard-coding them.
513 Note that we cannot import OnlineGlomConstants because it does not exist yet,
514 but that does not seem to stop the build, though it confuses Eclipse.
516 You can see the translated string by adding ?locale=de to the URL, like so:
517 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
519 2012-01-24 Murray Cumming <murrayc@murrayc.com>
521 Improve null/empty String checks.
523 * pom.xml: Add a dependency on commons-lang, to use
524 org.apache.commons.lang.StringUtils.
525 * src/main/java/org/glom/web/server/ConfiguredDocument.java
526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
527 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
528 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
529 Use StringUtils.isEmpty().
531 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
532 StringUtils class with a static isEmpty() function because we
533 cannot use org.apache.commons.lang.StringUtils in client-side
534 GWT code because it (apparently) cannot be compiled to javascript.
535 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
536 * src/main/java/org/glom/web/client/activity/ListActivity.java
537 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
538 * src/main/java/org/glom/web/client/place/DetailsPlace.java
539 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
540 * src/main/java/org/glom/web/client/place/ListPlace.java
541 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
542 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
543 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
544 * src/main/java/org/glom/web/client/ui/details/Group.java
545 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
546 our StringUtils.isEmpty() function.
548 2012-01-24 Murray Cumming <murrayc@murrayc.com>
550 Update to the latest java-libglom API.
552 * pom.xml: Require java-libglom 1.21.4.
553 * src/main/java/org/glom/web/server/ConfiguredDocument.java
554 getDocumentInfo(), getListViewLayoutGroup():
555 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
557 * src/main/java/org/glom/web/server/database/DBAccess.java
558 getFieldsToShowForSQLQueryAddGroup(),
559 getPrimaryKeyLayoutItemField(): Replace get_database_title()
560 with either get_database_title_original() or
561 get_database_title(localeID).
563 2012-01-24 Murray Cumming <murrayc@murrayc.com>
565 ConfiguredDocument: Avoid a null pointer exception.
567 * src/main/java/org/glom/web/server/ConfiguredDocument.java
568 Initialize localeID to "" to avoid returning a null String which
569 causes a crash in java-libglom's swing-generated code.
571 2012-01-23 Murray Cumming <murrayc@murrayc.com>
573 Some simple renaming.
575 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
576 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
577 for localeChooser. This seems more appropriate and is less ambiguous
578 particularly in the .css file.
580 2012-01-23 Murray Cumming <murrayc@murrayc.com>
582 ConfiguredDocument: Rename the localedID private member variable.
584 2012-01-23 Murray Cumming <murrayc@murrayc.com>
586 Adapt to the latest java-libglom API from git master.
588 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
589 libglom now uses only Vector instead of List, which uses add() instead of
592 2012-01-23 Murray Cumming <murrayc@murrayc.com>
594 Add and fill a Reports drop-down list box.
596 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
598 * src/main/java/org/glom/web/client/OnlineGlomService.java:
599 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
601 Added getReports(document, table, localeID), calling
602 ConfiguredDocument.getReports().
603 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
604 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
605 Added setReportsList() and a list widget.
606 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
607 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
609 2012-01-22 Murray Cumming <murrayc@murrayc.com>
611 ConfiguredDocument: Rename the localedID private member variable.
613 2012-01-20 Murray Cumming <murrayc@murrayc.com>
615 Build a source tarball with mvn assembly:single
617 * assembly.xml: Add this file.
618 * pom.xml: Use the maven-assembly-plugin and tell it to use
619 our assembly.xml file.
621 2012-01-19 Murray Cumming <murrayc@murrayc.com>
623 OnlineGlomServiceImpl: Get .glom files recursively.
625 * pom.xml: Depend on commons-io from org.apache.commons.
626 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
627 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
628 files recursively, and with the easier filter for the extension.
629 Use org.apache.commons.io.FilenameUtils.removeExtension() to
630 simplify that code too.
632 2012-01-19 Murray Cumming <murrayc@murrayc.com>
634 README: Mention that you must install java-libglom packages separately.
636 But then it works, because java-libglom is now in the central maven
639 2012-01-18 Murray Cumming <murrayc@murrayc.com>
641 locales drop-down: Show the correct selected locale when the URL changes.
643 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
644 .java: setPlace(): Move some code into fillView().
646 2012-01-18 Murray Cumming <murrayc@murrayc.com>
648 locales drop-down: Do not lose the primary key.
650 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
651 start(): onLocaleChange(): Pass the current primary key value,
652 instead of an empty value.
654 2012-01-18 Murray Cumming <murrayc@murrayc.com>
656 locales drop-down: Do not lose the drop-down selection.
658 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
659 .java (TableSelectionActivity.fillView): Set the selected locale
660 after changing the drop-down items (though we do not really need
661 to change them just because the locale changes.)
663 2012-01-18 Murray Cumming <murrayc@murrayc.com>
665 locales drop-down: Change the tables list when this changes.
667 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
668 .java: TableSelectionActivity.start(): Move the async table titles
669 retrieval into a private fillView() method and also call this when
670 the chosen locale changes.
671 Note that the document title is not actually translatable yet, but
672 that is a problem that I should fix soon in libglom.
674 2012-01-18 Murray Cumming <murrayc@murrayc.com>
676 Improve the placement of the locales drop-down.
678 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
679 Put the title and locales drop-down in a div (gwt.FlowTable).
680 * src/main/webapp/style.css: Add magic css properties to make this work.
681 Also remove the left margin from the title so that it lines up with the
684 2012-01-18 Murray Cumming <murrayc@murrayc.com>
686 locales selector: Show human-readable locale titles.
688 * src/main/java/org/glom/web/server/ConfiguredDocument.java
689 getDocumentInfo(): Use java.util.Locale to show a real title of
690 each locale, in the locale's own language.
692 2012-01-17 Murray Cumming <murrayc@murrayc.com>
694 Add a language/locale selector drop-down.
696 * src/main/java/org/glom/web/shared/DocumentInfo.java:
697 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
698 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
699 getDocumentInfo(): Store the available Locales in the DocumentInfo.
700 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
701 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
702 Add a ListBox to show the available locales. Add getLocaleSelector(),
703 setLocaleList(), getSelectedLocale(), setSelectedLocale().
704 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
705 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
706 java: Add these classes.
707 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
708 start(): Fill the locales ListBox. Handle its change event, firing a
710 setPlace(): Show the selected locale as specified by the URL token.
711 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
712 * src/main/java/org/glom/web/client/activity/ListActivity.java:
713 Handle LocaleChangeEvent, going to a new *Place with that locale.
715 The placement of the ListBox is not pretty, and it currently uses the ID
716 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
720 2012-01-17 Murray Cumming <murrayc@murrayc.com>
722 Search box: Show the search text from the URL token.
724 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
725 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
726 Add setQuickFindText().
727 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
728 .java: setPlace(): Store the queryText if the place is a ListPlace,
729 and call TableSelectionView.setQuickFindText().
731 2012-01-17 Murray Cumming <murrayc@murrayc.com>
733 Allow use of translations via, for instance, &lang=de in the URL.
735 * pom.xml: Use the unstable java-libglom 1.21 version.
737 * src/main/java/org/glom/web/client/OnlineGlomService.java:
738 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
739 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
740 init(): Instead of calling TranslatableItem.set_current_locale()
741 (now removed), call ConfiguredDocument.setDefaultLocaleID().
742 However, this is only for default locales, which are not needed to
743 change the locale in the URL.
744 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
745 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
746 getSortedRelatedListData(): Add a localeID parameter, so we can get the
747 layout for a particular locale.
748 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
749 Add get/setDefaultLocaleID().
750 getDocumentInfo(), getListViewData(), getRelatedListData(),
751 getDetailsLayoutGroup(), getListViewLayoutGroup(),
752 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
753 localeID parameter, so we can get the layout for a particular locale.
755 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
756 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
757 * src/main/java/org/glom/web/client/place/ListPlace.java:
758 Parse and construct a lang parameter too.
760 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
761 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
762 passed to subsequent methods and constructors.
763 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
764 * src/main/java/org/glom/web/client/activity/ListActivity.java:
765 Store the localeID from the *Place and pass it to other constructors
766 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
768 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
769 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
770 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
771 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
772 * src/main/java/org/glom/web/client/ui/ListView.java:
773 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
774 Take localeID parameters and pass them to subsequent constructors and
775 methods, so that the layout is always retrieved for that locale.
777 This is rather repetitive.
779 Note that "" means the original (default) locale of the Glom document,
780 which is usually English.
782 2012-01-17 Murray Cumming <murrayc@murrayc.com>
784 Documents: Remove final keyword to fix startup configuration.
786 * src/main/java/org/glom/web/shared/Documents.java: Remove the
787 final keywords on the private member variables because that breaks
788 the startup, apparently (there are warnings) because it stops them
789 from being serialized. I added these in the previous commit.
791 2012-01-13 Murray Cumming <murrayc@murrayc.com>
793 Documents: Add some final keywords.
795 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
798 2012-01-13 Murray Cumming <murrayc@murrayc.com>
800 OnlineGlomServiceImpl: Add to overview comments.
802 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
803 Note that this is where all the document are loaded. They are not
804 loaded freshly for each page.
806 2012-01-12 Murray Cumming <murrayc@murrayc.com>
810 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
811 Add a TextBox for the text of a quick find.
812 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
814 setBackLink(): Add a String quickFind parameter.
815 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
816 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
817 to the base interface, because that is how TableSelectionViewImpl is used.
818 * src/main/webapp/style.css: Add style for the search box and its label.
820 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
821 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
822 Add these files, based on the existing TableChangeEvent and
823 TableChangeEventHandlers.
824 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
825 start(): Handle QuickFindChangeEvent, passing its quickFind text to
826 a ListPlace() that the user should be taken to.
827 * src/main/java/org/glom/web/client/activity/ListActivity.java
828 start(): Handle it here too and adapt the TableChangeEvent handler to
829 pass the extra "" quickFind parameter to ListPlace.
830 * src/main/java/org/glom/web/client/place/ListPlace.java:
831 Constructor: Take an extra String quickFind parameter and store it,
832 returning it from a new getQuickFind() method.
833 getToken(): Put the quickFind text in the URL token.
834 getPlace(): Parse the quickFind text from the URL token.
835 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
836 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
837 ListPlace constructor.
838 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
839 .java: start(): Add a Change handler for the TableSelectionView's
840 TextBox (via its base HasChangeHandlers interface), firing the new
841 QuickFindChangeEvent.
842 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
843 pass the extra "" quickFind parameter.
845 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
846 setCellTable(): Add a String quickFind parameter and pass it to
847 the ListViewTable() constructor.
848 * src/main/java/org/glom/web/client/ui/ListView.java: Change
849 setCellTable() in the base interface, because that is how ListViewImpl
852 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
853 Add a String quickFind member variable.
854 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
855 Constructor: Add a String quickFind parameter, storing it in the
856 base ListTable's member variable.
857 onRangeChanged(): Pass quickFind to the
858 OnlineGlomServiceAsync.getSortedListViewData() and
859 OnlineGlomServiceAsync.getListViewData() methods.
861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
862 getListViewData(), getSortedListViewData(): Add a String quickFind
863 parameter, passing it to ConfiguredDocument.getListViewData().
864 * src/main/java/org/glom/web/client/OnlineGlomService.java:
865 Change getListViewData(), getSortedListViewData() in the base interface,
866 because that is how OnlineGlomServiceImpl is used, via this:
867 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
868 Change getListViewData(), getSortedListViewData() here too.
869 This class can apparently be used to asynchronously call methods on
870 OnlineGlomService, and GWT seems to implement that after recognizing
871 just the *Async name convention and the extra AsyncCallback parameters.
873 * src/main/java/org/glom/web/server/ConfiguredDocument.java
874 getListViewData(): Add a String quickFind parameter, and pass it to
875 ListViewDBAccess.getData().
876 * src/main/java/org/glom/web/server/database/ListDBAccess.java
877 getListData(): Add a String quickFind parameter and pass it to
879 getSelectQuery(): Add a String quickFind parameter.
880 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
881 getSelectQuery(): Add a String quickFind parameter and use it with
882 Glom.get_find_where_clause_quick() to pass a where_clause to
883 Glom.build_sql_select_with_where_clause(), to actually filter the
885 getData(): Add a String quickFind parameter, passing it to getListData().
886 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
887 va: getData(): Pass an empty string to getListData() for the
890 2012-01-12 Murray Cumming <murrayc@murrayc.com>
892 ListTable: Minor change.
894 * src/main/java/org/glom/web/client/ui/list/ListTable.java
895 createCellTable(): Make this protected instead of public.
897 2012-01-12 Murray Cumming <murrayc@murrayc.com>
899 Many files: Use final for the parameters and use the @override attribute.
901 2012-01-22 Ben Konrath <ben@bagu.org>
903 Add anchor links for single line text that starts with http, ftp and www.
907 2012-01-22 Ben Konrath <ben@bagu.org>
909 Add ellipsis to single line text in details view.
913 2012-01-04 Murray Cumming <murrayc@murrayc.com>
915 Remove all javadoc author tags.
917 Because they are awkward and meaningless when many people touch
919 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
921 2012-01-04 Murray Cumming <murrayc@murrayc.com>
923 Revert the COPYING.LESSER to COPYING rename.
925 Apparently both should be there if it is LGPL.
927 2012-01-03 Murray Cumming <murrayc@murrayc.com>
929 *View: Remove unused imports.
931 * src/main/java/org/glom/web/client/ui/DetailsView.java:
932 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
933 * src/main/java/org/glom/web/client/ui/ListView.java:
934 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
935 Remove unused imports, as suggested by Eclipse.
937 2012-01-02 Murray Cumming <murrayc@murrayc.com>
939 Move the *View::Presenter types, and some API into one base View.
941 * src/main/java/org/glom/web/client/ui/DetailsView.java:
942 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
943 * src/main/java/org/glom/web/client/ui/ListView.java:
944 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
945 Presenter, setPresenter() and clear() into a shared base interface,
946 to avoid the unnecessary duplicate Presenter types and to more clearly
947 show how the *Views share the same structure, even if they are not
948 used polymorphically.
950 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
951 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
954 * src/main/java/org/glom/web/client/activity/ListActivity.java:
955 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
957 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
960 Feel free to revert this if there is a good reason for the duplicate
963 2012-01-02 Murray Cumming <murrayc@murrayc.com>
965 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
967 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
968 a class member instead of a local variable in the method.
969 This lets us use it to get the view instances, for use in tests.
970 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
971 beforeOnlineGlom(): Test some more details of the initial view.
972 Again, this is not very useful.
974 To really test gwt-glom we will need to start a local postgresql
975 instance with local data, like the Glom tests in C++.
977 2012-01-02 Murray Cumming <murrayc@murrayc.com>
979 pom.xml: Mention the LGPL license.
981 * pom.xml: Add a licenses section.
982 * COPYING.LESSER: Move this to COPYING, which
983 previously contained the GPL. But gwt-glom is all LGPL.
985 2012-01-02 Murray Cumming <murrayc@murrayc.com>
987 Add project information to README and pom.xml.
989 * README: Add a brief description and mention some mvn
991 * pom.xml: This extra information shows up in mvn site
994 2011-01-02 Murray Cumming <murrayc@murrayc.com>
996 Use the latest java-libglom version.
998 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1000 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1002 GwtTestOnlineGlom: Test a little more.
1004 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1005 protected rather than private, as suggested by the gwt-test-utils
1007 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1008 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1009 Test the initial visibility of the panels.
1011 However, this is not a very useful test.
1012 And I wonder how we should generally test using this idea for an
1013 activity/places app like ours where the real changes happen implicitly
1014 based on the history token/URL.
1016 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1018 Slight modification to *Mapper comments.
1020 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1021 (DataActivityMapper)
1022 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1024 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1026 Remove comments mentioning GIN because they are just copied from
1027 the example code and are apparently not helpful:
1028 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1029 Also change the mention of a class that is only in the example code.
1031 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1033 GwtTestOnlineGlom test: Minor changes.
1035 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1036 Avoid the long qualified class name and modify the comment
1037 because it is now obvious to me that the mocked class is the only
1038 custom one created via GWT.create().
1040 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1042 Tests: Added the beginnings of a test using gwt-test-utils.
1044 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1045 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1046 which tells gwt-test-utils what class will be tested.
1047 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1048 Add a simple (but empty) test case. One class, used by the OnlineGlom
1049 class, is mocked so that it can be created. However, I am not sure
1050 why only this class needs to be mocked.
1052 Note that mockito seems more popular, and clearer, than easymock,
1053 but I have not got that working yet. It might be a matter of the
1056 This test is run during mvn integration-test.
1058 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1060 Tests: Use junit4-style syntax instead of junit3-style.
1062 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1063 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1064 * src/test/java/org/glom/web/shared/DataItemTest.java:
1065 Use the @Test annotation rather than relying on the test*() prefix.
1066 Also no longer implement TestCase, to avoid triggering support for
1067 the junit3-way, which stops the annotations from working.
1068 Change the imports from import junit.framework.* to
1069 import org.junit.*, which is apparently the new way.
1071 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1073 Added a test for ListPlace token parsing and creation.
1075 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1076 This is much the same as DetailsPlaceTest.
1078 I wonder how we could test the other parts of the *Place API.
1080 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1082 DetailsPlace test: Also test getToken() and recreation via getPlace().
1084 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1085 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1086 recreate it, testing the recreated DetailsPlace for the same parameter
1089 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1091 Use the surefire-report plugin.
1093 * pom.xml: This generates a HTML report about the tests in
1094 target/site/surefire-report.html
1095 when you do mvn surefire-report:report. It seems to be popular/normal.
1097 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1099 Added a test for DetailsPlace.
1101 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1102 Test the getPlace() token parsing.
1104 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1106 Added a first unit test.
1108 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1109 * src/test/java/org/glom/web/shared/DataItemTest.java:
1110 This is a silly test but it is just to get things started. Note that
1111 maven/junit finds the test because it looks in src/test by default.
1113 2011-12-22 Ben Konrath <ben@bagu.org>
1115 Change charsetName to "UTF-8" when replacing line breaks.
1117 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1118 that work in Java (such as "UTF8") will not work when compiled to
1121 This fixes a problem with multi-line details view fields that have hard
1122 line breaks. The "License Text" field on this page demonstrates the
1125 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1127 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1129 2011-12-22 Ben Konrath <ben@bagu.org>
1131 Fix another bug with related list navigation.
1133 I've tested all the navigation buttons in all of the related lists
1134 so things should be good now.
1136 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1138 2011-12-22 Ben Konrath <ben@bagu.org>
1140 Fix a crasher when refreshing the list view with the default table.
1142 This crash will also happen when loading the list view with the default
1143 table from a link or bookmark.
1145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1146 to the main document selection page when the document id hasn't been
1148 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1149 the main document selection page when the document id hasn't been
1151 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1152 values for the details place when the document id hasn't been set.
1153 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1154 values for the list place when the document id hasn't been set.
1156 2011-12-21 Ben Konrath <ben@bagu.org>
1158 Protect against NPE when glom.document.locale is not in config.
1160 This patch protects against an NPE when glom.document.locale is not in
1161 the config file. This NPE will also happen if glom.document.locale is
1164 The patch also updates the error message to display the class name when
1165 the getMessage() returns null. This was happening when the NPE was
1166 thrown and I had "Configuration Error: null". If an NPE is encountered
1167 with this patch, "Configuration Error: NullPointerException " will be
1170 This commit closes this bug:
1172 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1176 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1178 Rename onlineglom.properties to onlineglom.properties.sample.
1180 * src/main/resources/onlineglom.properties: Rename to:
1181 * src/main/resources/onlineglom.properties.sample:
1182 * src/main/resources/README: And add this file explaining that people
1183 should rename it back when deploying.
1185 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1187 Allow choosing the translation in the .properties file.
1189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1190 init(): Read a glom.document.locale value from the configuration file
1191 and call Glom's TransatableItem::set_current_locale() method.
1192 * src/main/resources/onlineglom.properties: Add a commented-out
1193 example of this new setting.
1195 It would be better to add &lang=de_DE to the URL, but the current
1196 libglom API does not allow us to do this easily. I am working on that.
1198 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1200 Avoid a crash in parsing of token parameters.
1202 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1203 ava: getTokenParams(): Do not crash if a parameter has a key but no
1204 value, and ignore parameters with neither.
1206 2011-12-17 Murray Cumming <murrayc@murayc.com>
1208 History token building/handling: Improve use of token parameters.
1210 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1211 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1212 and buildParamsToken(HashMap), for use by derived classes.
1213 Make the separator private because it is no longer be needed.
1214 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1215 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1216 instead of manual string concatenation.
1217 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1218 of hardcoded indices and awkward splitting code.
1219 * src/main/java/org/glom/web/client/place/ListPlace.java
1220 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1221 instead of manual string concatenation.
1222 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1223 of hardcoded indices and awkward splitting code.
1224 This should fix bug #666420
1226 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1228 Fix a Navgiation->Navigation typo in the code.
1230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1231 Rename processNavgiation() to processNavigation().
1233 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1235 Fix a seperator->separator typo in the code.
1237 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1238 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1239 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1242 2011-12-15 Ben Konrath <ben@bagu.org>
1244 Cleanup some comments.
1246 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1248 2011-12-14 Ben Konrath <ben@bagu.org>
1250 Replace \n with <br/> for multiline text in the details view.
1252 Vertical scrollbars are added when needed as well.
1254 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1256 2011-12-14 Ben Konrath <ben@bagu.org>
1258 Specify the font for document selection links.
1260 * src/main/webapp/style.css:
1262 2011-12-14 Ben Konrath <ben@bagu.org>
1264 Fix bouncy CellTable while paging.
1266 This doesn't currently work with related list tables in unselected
1269 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1271 2011-12-14 Ben Konrath <ben@bagu.org>
1273 Revamp the appearance of the document selection page.
1275 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1276 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1277 * src/main/webapp/style.css:
1279 2011-12-13 Ben Konrath <ben@bagu.org>
1281 Set navigation button column to the smallest size possible.
1283 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1285 2011-12-13 Ben Konrath <ben@bagu.org>
1287 Change OpenButton nomenclature to NavigationButton.
1289 Using NavigtionButton makes things more generic. Classes, methods and
1290 variables have been changed.
1292 This is a rename-only refactor.
1294 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1295 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1296 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1297 Renamed from OpenButtonCell.
1298 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1299 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1300 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1302 2011-12-12 Ben Konrath <ben@bagu.org>
1304 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1307 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1308 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1309 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1311 2011-12-12 Ben Konrath <ben@bagu.org>
1313 Update variable names and comments.
1315 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1316 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1318 2011-12-12 Ben Konrath <ben@bagu.org>
1320 Properly initialize numNonEmptyRows variable to zero.
1322 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1323 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1325 2011-12-05 Ben Konrath <ben@bagu.org>
1327 Add latest mockup with HTML tables.
1329 Features of this mockup:
1331 -> HTML table for flowtable
1332 -> HTML table for flowtable column
1333 -> Example of how related lists would look
1334 -> Not using text entries for data items
1336 The current version of Online Glom doesn't use HTML tables for the
1339 This mockup has been sent to the glom-devel mailing list but it's good
1340 to have it here as well.
1342 * mockups/details-view-html-tables.html:
1344 2011-12-05 Ben Konrath <ben@bagu.org>
1346 Remove unnecessary getPrimaryKeyField() method.
1348 getPrimaryKeyFieldForTable(String) has been renamed to
1349 getPrimaryKeyField(String).
1351 * src/main/java/org/glom/web/server/database/DBAccess.java:
1352 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1353 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1355 2011-12-05 Ben Konrath <ben@bagu.org>
1357 Add string representation of TypedDataItem value to conversion error message.
1359 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1360 message was extracted into its own method to avoid duplication.
1362 2011-12-05 Ben Konrath <ben@bagu.org>
1364 Add type checking to navigation primary key value creation.
1366 Create navigation primary key only if the expected type from the Glom
1367 document matches the type returned by the SQL query.
1369 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1371 2011-12-05 Ben Konrath <ben@bagu.org>
1373 Rename a couple of variables in RelatedListNavigation.
1375 This is a rename-only refactor.
1377 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1379 2011-12-05 Ben Konrath <ben@bagu.org>
1381 Move getListLayoutGroup() into getListViewLayoutGroup().
1383 This removes getListLayoutGroup(). It was only being called by
1384 getListViewLayoutGroup().
1386 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1388 2011-12-05 Ben Konrath <ben@bagu.org>
1390 Remove check for LayoutItem_Portal in list table method.
1392 This check is no longer necessary because the method isn't being used
1393 to create the LayoutItemPortal DTO.
1395 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1397 2011-12-05 Ben Konrath <ben@bagu.org>
1399 Properly support related list navigation.
1401 Navigation from the "Repository Analyzer -> Package Scans ->
1402 Dependencies" related table wasn't working because the primary key for
1403 related tables wasn't being set properly. This commit fixes the
1406 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1407 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1408 doesn't set the primary key properly for related list tables.
1409 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1410 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1411 useful for getting the primary key for list view tables and for related
1413 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1414 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1415 Move code to set the primary key for the table from the abstract
1416 ListDBAccess class to ListViewDBAccess as it's only correct for list
1418 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1419 Properly add primary key to related list tables.
1421 2011-12-02 Ben Konrath <ben@bagu.org>
1423 Properly set the horizontal alignment of fields.
1425 This fix is for both the list tables and the details view.
1427 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1428 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1429 to set the horizontal alignment of fields.
1431 2011-12-02 Ben Konrath <ben@bagu.org>
1433 Display currency codes in the details view.
1435 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1437 2011-12-02 Ben Konrath <ben@bagu.org>
1439 Avoid duplicate JNI call.
1441 JNI is not as efficient as pure Java and this is an easy (and small)
1444 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1445 Use previously retrieved value for whereClauseToTableName instead of
1448 2011-12-02 Ben Konrath <ben@bagu.org>
1450 Rename a couple of variables in RelatedListNavigation.
1452 This is a rename-only refactor.
1454 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1456 2011-12-02 Ben Konrath <ben@bagu.org>
1458 Indicate clearly that a mismatched primary key type is a bug.
1460 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1461 warning to error. Add 'This is a bug.' to message.
1463 2011-12-02 Ben Konrath <ben@bagu.org>
1465 Update / fix some comments.
1467 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1469 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1471 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1472 Fix comments. Add some TODOs.
1474 2011-12-02 Ben Konrath <ben@bagu.org>
1476 Enable navigation to details view with string primary key from related list.
1478 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1479 Create a text primary key value when return type of result is
1480 java.sql.Types.VARCHAR.
1482 2011-12-02 Ben Konrath <ben@bagu.org>
1484 Use checkboxes for booleans in the details view.
1486 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1488 2011-12-01 Ben Konrath <ben@bagu.org>
1490 Improve performance of related list height calculation.
1492 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1493 Put code to calculate the expected height in a static initializer so
1494 that that it's only called once.
1496 2011-12-01 Ben Konrath <ben@bagu.org>
1498 Show related list tables in notebooks (again).
1500 Calculate the height of the related list tables so the Notebook can be
1501 set the correct height. The height of the related list table is also needed by
1502 FlowTable to be able decide how to create the layout.
1504 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1505 and set the Portal height based on the height of the related list
1506 table and the Portal container.
1507 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1508 Add method to calculate the height of the related list tables.
1509 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1510 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1511 calculate the height of the Pager widget.
1513 2011-12-01 Ben Konrath <ben@bagu.org>
1515 Use CellTable API for table property instead of setting style on Element.
1517 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1519 2011-12-01 Ben Konrath <ben@bagu.org>
1521 Make ListViewTable and RelatedListTable a consistent height.
1523 The tables are now a consistent height regardless of the contents of
1524 the table. A hidden button is added to empty rows to ensure that the
1525 height of these rows will match the height of rows with data.
1527 A navigation button column is now added to every table. The width of
1528 the navigation column is set to 0px when a RelatedListTable shouldn't
1529 have navigation buttons. This maintains the a consistent row height in
1530 tables that don't show the navigation buttons.
1532 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1533 navigation column when not needed.
1534 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1535 arguments for navigation button to constructor of ListViewTable.
1536 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1537 hidden button for empty data rows.
1538 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1539 arguments for navigation button to constructor.
1540 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1541 create navigation buttons. Add hideNavigationButtons() method.
1542 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1543 arguments for navigation button to constructor.
1545 2011-12-01 Ben Konrath <ben@bagu.org>
1547 Use 'visibility: hidden' in Utils.getWidgetHeight().
1549 This is better choice because hidden elements are invisible, don't
1550 respond to events and are not part of the tab order. They will,
1551 however, take up space which is required to be able to calculate the
1552 height of the widget.
1554 * src/main/java/org/glom/web/client/Utils.java:
1556 2011-12-01 Ben Konrath <ben@bagu.org>
1558 Use Utils.getWidgetHeight() in FlowTable.
1560 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1562 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1564 2011-12-01 Ben Konrath <ben@bagu.org>
1566 Put the details css class name on the correct table column.
1568 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1570 2011-11-30 Ben Konrath <ben@bagu.org>
1572 Update for java-libglom API change.
1574 The getters and setters on FieldFormatting and NumericFormat were
1575 changed to remove the 'M'.
1577 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1579 2011-11-29 Ben Konrath <ben@bagu.org>
1581 Only allow RelatedListTables in Portals.
1583 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1585 2011-11-29 Ben Konrath <ben@bagu.org>
1587 Only create a contents panel for Portals when title is being set.
1589 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1591 2011-11-29 Ben Konrath <ben@bagu.org>
1593 Set TabLayoutPanel height based on calculated height its widgets.
1595 This is a potential fix for this bug:
1597 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1599 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1601 2011-11-29 Ben Konrath <ben@bagu.org>
1603 Align details field labels and data with the Open buttons.
1605 * src/main/webapp/style.css:
1607 2011-11-29 Ben Konrath <ben@bagu.org>
1609 Remove unnecessary <div> in the Notebook widget.
1611 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1612 method to get container FlowPanel (<div>).
1613 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1614 initWidget() method directly on the TabLayoutPanel widget instead of
1615 Group's container widget.
1617 2011-11-29 Ben Konrath <ben@bagu.org>
1619 Don't add group titles for Portals in Notebooks.
1621 This reverts the previous patch and fixes a bug I introduced with
1622 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1624 * src/main/java/org/glom/web/client/ui/details/Group.java:
1625 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1627 2011-11-28 Ben Konrath <ben@bagu.org>
1629 Remove unused boolean argument in Portal constructor.
1631 Just a code cleanup.
1633 * src/main/java/org/glom/web/client/ui/details/Group.java:
1634 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1636 2011-11-28 Ben Konrath <ben@bagu.org>
1638 Remove hack for glom 1.18 style glom files.
1640 * src/main/java/org/glom/web/client/ui/details/Group.java:
1641 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1642 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1644 2011-11-28 Ben Konrath <ben@bagu.org>
1646 Use Gda Value version of primary key to log result too large error.
1648 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1650 2011-11-28 Ben Konrath <ben@bagu.org>
1652 Don't use TypedDataItem.getText() for Unknown types from the URL.
1654 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1655 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1656 instead of getText().
1657 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1658 String field and getUnknown() method.
1660 2011-11-28 Ben Konrath <ben@bagu.org>
1662 Log an error message when the java-libglom .so is not present.
1664 The error message was being set in the exception but not logged.
1666 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1668 2011-11-28 Ben Konrath <ben@bagu.org>
1670 Ignore LayoutItem_CalendarPortals.
1672 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1673 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1675 2011-11-28 Ben Konrath <ben@bagu.org>
1677 Extract method for creating the LayoutItemPortal DTO.
1679 Just breaking the code up into smaller chunks.
1681 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1683 2011-11-28 Ben Konrath <ben@bagu.org>
1687 This should have been added with the refactor. Oops!
1689 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1691 2011-11-28 Ben Konrath <ben@bagu.org>
1693 Create primary key value from URL string using type from Glom document.
1695 See this bug, comments 19 - 25:
1697 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1699 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1700 create a TypeDataItem for the primary key here when loading from a
1701 URL. Show the same string for the primary key value as was received
1702 from the URL string (when loading from a URL).
1703 * src/main/java/org/glom/web/server/Utils.java: Update method for
1704 creating the Gda Value from the TypeDataItem to properly deal with
1705 creating a Gda Value based on the Glom document type for the primary
1706 key value string when loading from a URL.
1707 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1708 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1709 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1710 Update for changed method name.
1712 2011-11-27 Ben Konrath <ben@bagu.org>
1714 Rename PrimaryKeyItem to TypedDataItem.
1716 The name PrimaryKeyItem suggests what the class should be used for.
1717 TypedDataItem is a neutral name that describes the class better.
1719 This is a rename-only refactor.
1721 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1722 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1723 * src/main/java/org/glom/web/client/Utils.java:
1724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1725 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1726 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1727 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1728 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1729 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1731 * src/main/java/org/glom/web/server/Utils.java:
1732 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1733 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1734 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1735 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1737 2011-11-25 Ben Konrath <ben@bagu.org>
1739 Improve Gda Value conversion from PrimaryKeyItem.
1741 The value from the PrimaryKeyItem is only used if its type match the
1742 type from the glom document.
1744 * src/main/java/org/glom/web/server/Utils.java:
1746 2011-11-25 Ben Konrath <ben@bagu.org>
1748 Manually check if the java-liblgom .so is visible to the JVM.
1750 It seems that Tomcat has problems when a static initializer throws an
1751 exception. This check is done before the first method call into
1752 java-libglom so that execution doesn't continue if the .so is not
1755 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1757 2011-11-25 Ben Konrath <ben@bagu.org>
1759 Improve browser configuration error messages.
1763 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1765 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1766 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1767 getConfigurationErrorMessage() method.
1768 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1769 Get and display a specific configuration error message when no Glom
1770 documents are found.
1771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1772 Implement getConfigurationErrorMessage() method. Surround configuration
1773 code in the init() method with a try/catch block. This allows the
1774 errors to be caught while keeping the servlet available to retrieve the
1775 configuration error message.
1777 2011-11-25 Ben Konrath <ben@bagu.org>
1779 Don't use Strings to hold primary key values.
1781 The primary key values are now held in a new data object
1782 (PrimaryKeyItem) that holds type information and the primary key value
1783 using the correct type.
1785 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1786 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1788 PrimaryKeyItem instead of String to hold the primary key value.
1789 * src/main/java/org/glom/web/client/Utils.java: Remove
1790 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1791 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1792 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1793 PrimaryKeyItem instead of String to hold the primary key value. Load
1794 document selection page when the documentID has not been set correctly.
1795 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1796 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1798 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1799 Return empty string for URL instead of "null".
1800 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1801 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1802 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1803 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1804 PrimaryKeyItem instead of String to hold primary key values.
1805 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1806 PrimaryKeyValue to a Gda Value.
1807 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1808 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1809 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1810 Replace temporary database access code that uses the PrimaryKeyValue to
1811 Gda Value conversion.
1812 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1813 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1814 PrimaryKeyItem instead of String.
1815 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1816 hold primary key values.
1818 2011-11-24 Ben Konrath <ben@bagu.org>
1820 Use newly added java-libglom API to create queries.
1822 This isn't finished. I still need to stop using Strings for primary key
1823 values in the client code.
1825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1826 libglom to use fake connections so that retrieving the query string will
1828 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1829 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1830 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1831 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1832 Use the newly added libglom sql methods and classes to create the
1833 query. Add temporary hack to convert primary value strings to Gda
1836 2011-11-23 Ben Konrath <ben@bagu.org>
1838 Don't explicitly set the height of Portals.
1840 See comments 6 - 10 of this bug for details:
1842 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1844 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1846 2011-11-23 Ben Konrath <ben@bagu.org>
1848 Use an HTML table instead of CSS for the FlowTable layout.
1850 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1851 GWT's FlexTable to implement the FlowTable.
1852 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1854 2011-11-18 Ben Konrath <ben@bagu.org>
1856 Add boolean example to HTML table mockup.
1858 * mockups/details-view-html-tables-text-entries.html:
1860 2011-11-17 Ben Konrath <ben@bagu.org>
1862 Ensure the pager buttons are always visible for related lists.
1864 To accomplish this, I've turned off text wrapping in the list view and
1865 related list tables for both the header and data text. The related list
1866 table now has a fixed layout so the it doesn't overflow its container.
1867 This is required to ensure that the cell text is clipped when it
1868 overflows the cell and an ellipsis is added to the right side of the
1869 cell when text is clipped.
1871 A fixed table layout for the related list table in the details view
1872 seems what we want for the details view anyway, so the side-effect is
1875 The ellipsis will only be displayed in Firefox >= 7.
1879 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1881 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1882 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1883 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1885 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1886 Set the 'table-layout: fixed' CSS property to the related list table.
1887 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1888 'white-space: nowrap;' CSS property on both the list view and the
1889 related list tables.
1891 2011-11-16 Ben Konrath <ben@bagu.org>
1893 Rework the fix for empty notebook tab labels.
1895 Setting the empty group titles with its name caused problems for the
1896 details layout. Instead of using libglom's
1897 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1898 to the client when the title is empty. This allows the Notebook to use
1899 the name when the title is empty without affecting anything else.
1901 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1902 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1904 2011-11-16 Ben Konrath <ben@bagu.org>
1906 Set group titles with name when title is empty.
1908 This fixes a problem with an empty notebook tab label in the Lesson
1909 Planner document. The forth tab in the notebook should be "Internet":
1911 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1913 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1914 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1917 2011-11-16 Ben Konrath <ben@bagu.org>
1919 Remove whitespace from the configured username properties.
1921 This assumes that usernames won't have whitespace at the beginning
1922 or end. But I think this is a reasonable assumption.
1924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1925 String.trim() to remove the whitespace from the username properties.
1927 2011-11-15 Ben Konrath <ben@bagu.org>
1929 Add details view mockup with HTML tables and text entries.
1931 This is from the attachment on this bug:
1933 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1935 * mockups/details-view-html-tables-text-entries.html:
1937 2011-11-15 Ben Konrath <ben@bagu.org>
1939 Add space between the columns of the flow table.
1943 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1945 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1946 space between columns in the flow table.
1948 2011-11-15 Ben Konrath <ben@bagu.org>
1950 Add backup files to the .gitignore.
1952 * .gitignore: Ignore files that end with ~.
1954 2011-11-09 Ben Konrath <ben@bagu.org>
1956 Use latest release of gwt-log.
1958 Gwt-log releases are now being submitted to the maven central
1959 repository so manual installation of the jar is no longer required.
1961 * pom.xml: Update version and groupId of gwt-log dependency.
1963 2011-10-31 Ben Konrath <ben@bagu.org>
1965 Don't use GWT numeric formatting to override the glom currency formatting.
1967 Currencies are now displayed like they are in Glom. See this bug:
1969 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1971 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1973 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1974 currency code to constructor and set it when the cell is rendered.
1975 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1976 currency code to the constructor of the NumericCell.
1978 2011-10-27 Ben Konrath <ben@bagu.org>
1980 Require the latest release of java-libglom (1.17.4).
1984 2011-10-26 Ben Konrath <ben@bagu.org>
1986 Add style to Notebook that matches current theme.
1988 It's not the best style in the world but it's better than the default.
1990 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1991 padding at the bottom of the child widgets.
1992 * src/main/webapp/style.css: Add style for the Notebook.
1994 2011-10-26 Ben Konrath <ben@bagu.org>
1996 Move servlet initialization code to overridden init method.
1998 This is half of the solution to getting proper error messages
1999 displayed when configuration errors occur. Here's the relevant bug:
2001 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2003 The rest of the solution involves surrounding the init method with a
2004 try/catch block and setting a global variable with the error /
2005 exception. A new async method should be created to retrieve and display
2006 the error message / exception.
2008 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2009 code from constructor to init method adding exceptions as needed.
2011 2011-10-26 Ben Konrath <ben@bagu.org>
2013 Add script to monitor and restart tomcat if required.
2015 * utils/check-and-recover-tomcat.py: New file.
2017 2011-10-26 Ben Konrath <ben@bagu.org>
2019 Display the correct number of data items in the pager.
2023 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2025 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2026 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2027 The implementation is the same for both tables: Keep track of the
2028 number of non-empty rows and fire and RowCountChangeEvent after the data has
2030 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2031 custom Pager class that subclasses SimplePager to handle displaying
2032 the correct number when empty rows have been added.
2034 2011-10-26 Ben Konrath <ben@bagu.org>
2036 Correct error in previous commit.
2038 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2039 eventBus parameter from listView.setCellTable().
2041 2011-10-26 Ben Konrath <ben@bagu.org>
2043 Fix error in TODO comment.
2045 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2047 2011-10-24 Ben Konrath <ben@bagu.org>
2049 Create Notebook widgets to the details view.
2051 This isn't finished just yet - I still need to create a reasonable
2052 style to match the current theme.
2054 * src/main/java/org/glom/web/client/Utils.java: Add method for
2055 calculating the height of a widget. This is used in the Notebook class.
2056 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2057 new constructor method in Group.
2058 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2059 method for creating child widget that can be used by subclasses
2060 like Notebook. New constructor that allows disabling the group
2061 titles - Notebooks don't set a group title for their child groups.
2062 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2063 to make Notebooks using GWT's TabLayoutPanel.
2064 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2065 constructor that allows disabling the group titles.
2066 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2067 LayoutItemNotebook DTO.
2068 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2069 DTO for Notebooks. It's just an empty class for now but we might need
2070 it to transfer some specific information in the future.
2072 2011-10-21 Ben Konrath <ben@bagu.org>
2074 Add navigation buttons to related list tables.
2076 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2079 method getSuitableRecordToViewDetails() for getting the table name
2080 and primary key value for related list navigation buttons.
2081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2082 private cell renderer class to get the navigation information for
2083 related list tables from the server. Extract the navigation
2084 processing code from the details cell navigation and use it for the
2085 related list navigation as well.
2086 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2087 cell renderer class for the details open buttons. This was needed
2088 because the related list navigation buttons and the list view
2089 navigation buttons need to react differently when clicked.
2090 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2091 the onEnterKeyDown() method because it's now overriden in the
2092 subclasses that are specific to the related list tables and the list
2094 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2095 the vertical size a little because the buttons add a bit of vertical
2096 space to table. This is not a perfect solution because the vertical
2097 size of with table fewer than 5 rows will be a little smaller.
2098 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2099 changes in how navigation buttons are handled.
2100 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2101 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2102 database access object.
2103 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2104 to find the portal for a given relationship name from
2105 RelatedListDBAccess. Add method to find a primary key field for a
2107 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2108 Move code to find the portal for a given relationship name to
2110 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2111 New file: database access object for getting the related list
2112 navigation information (the table name and the primary key value).
2113 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2114 DTO for transferring a table name to navigate to and a primary key
2116 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2117 boolean and getter/setter to specifies if the related list should add
2120 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2122 Use the master branch of java-libglom
2124 * pom.xml: Depend on java-libglom 1.19 instead.
2126 This is the master branch. See also the libglom-1-18 branch.
2128 2011-10-11 Ben Konrath <ben@bagu.org>
2130 Enable the open navigation button when the data has been set.
2132 This avoids having active buttons that don't do anything when the data
2135 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2137 2011-10-11 Ben Konrath <ben@bagu.org>
2139 Use IsWidget interface for FlowTableItem.
2141 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2142 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2144 2011-10-11 Ben Konrath <ben@bagu.org>
2146 Remove GWT styling from open button in details view.
2148 There are still some issues with how the details cell is arranged but
2149 this should be made to match Glom 1.20. I'm going to leave fixing this
2150 until I have Glom 1.20 up and running.
2152 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2153 style name on open button.
2154 * src/main/webapp/style.css: Move and edit details-navigation class.
2155 Re-arrange some classes to make them appear in the same order as the
2158 2011-10-07 Ben Konrath <ben@bagu.org>
2160 Update to GWT 2.4.0.
2162 * .gitignore: Ignore new cache directory.
2163 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2164 * pom.xml: Change GWT and maven plugin to 2.4.0.
2165 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2167 * src/main/java/org/glom/web/client/ClientFactory.java:
2168 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2169 * src/main/java/org/glom/web/client/OnlineGlom.java:
2170 Update source for API changes.
2171 * utils/build-onlineglom-war.sh: Remove cache directory before the
2174 2011-10-07 Ben Konrath <ben@bagu.org>
2176 Add navigation buttons in the details view.
2178 This isn't finished but I thought I'd commit what I have as it's a
2179 pretty good start. I still need to:
2181 1. Change the style so that it fits better into the current theme
2182 2. Adjust the details cell to expand as much as possible.
2184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2185 click handlers to navigation buttons in the DetailsCells. Create a
2186 refreshData() method to get just the data from the server without the
2188 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2189 Update the tableSelector and browser title when the table name
2190 changes without using the tableSelector.
2191 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2192 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2193 getDetailsCells() to getCells(). Update variable names.
2194 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2195 method to set click handler on navigation button. Rename a few
2196 variables. Add navigation buttons where needed.
2197 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2198 variables and methods.
2199 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2200 navigation boolean and navigation table as required in the
2201 LayoutItemField DTO.
2202 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2203 variables for navigation along with getter/setter methods.
2205 2011-10-07 Ben Konrath <ben@bagu.org>
2207 Rename Field to DetailsCell.
2209 This is a refactor-only commit. No functionality has been added or
2212 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2213 Update variable and method names.
2214 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2215 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2216 variable and method names.
2217 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2219 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2220 variable and method names.
2222 2011-10-07 Ben Konrath <ben@bagu.org>
2224 Create separate methods for layout and data the details view.
2226 This is a refactor-only commit. No functionality has been added or
2229 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2230 private methods: setData(), createLayout().
2232 2011-10-07 Ben Konrath <ben@bagu.org>
2234 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2236 This is part of a change to get navigation buttons in the details view
2237 but it should have been done this way from the start.
2239 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2240 for method name change in TableSelectionView.
2241 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2242 Create TableChangeEvent and set the browser title using the
2243 TableSelectionView API.
2244 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2245 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2246 Change getSelectedTable() to getSelectedTableName(). Add
2247 getSelectedTableTitle().
2249 2011-10-07 Ben Konrath <ben@bagu.org>
2251 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2253 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2255 2011-10-07 Ben Konrath <ben@bagu.org>
2257 Update TableChangeEvent to use newTableName naming convention.
2259 This makes the class more consistent with GWT naming conventions.
2261 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2262 Update for method name change in TableChangeEvent.
2263 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2264 for method name change in TableChangeEvent.
2265 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2266 newTableName variable and getter method. Make toDebugString()
2269 2011-09-30 Ben Konrath <ben@bagu.org>
2271 Disable the pager in the list tables when the data row count is less than the minimum.
2273 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2274 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2276 2011-09-30 Ben Konrath <ben@bagu.org>
2278 Add empty rows to the end of related list and list view tables.
2280 I also extracted the cell rendering classes from the ListTable because
2281 the code was becoming a little crazy with all the anonymous inner
2282 classes. My plan is to use these cell rendering classes in the details
2283 view as well so this refactor will be needed for that change.
2285 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2286 set the row count in related list tables if the data has more rows
2287 than the minimum number of rows visible.
2288 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2289 row count in list view tables if the data has more rows than the
2290 minimum number of rows visible.
2291 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2292 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2294 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2295 for rendering TYPE_NUMERIC cells. The code was extracted from the
2297 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2298 class for rendering cells with buttons in list views. The code was
2299 extracted from the ListTable class.
2300 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2301 for rendering TYPE_TEXT cells. The code was extracted from the
2303 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2304 Add empty rows to the end of the data if required. Implement
2305 ListTable.getMinNumVisibleRows().
2306 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2307 cell renderer code to public classes. Return null in
2308 Column.getValue() for empty rows. Add new abstract method:
2309 getMinNumVisibleRows(). Move code to set the row count of the list view
2310 table to ListViewImpl.
2311 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2312 empty rows to the end of the data if required. Implement
2313 ListTable.getMinNumVisibleRows().
2316 2011-09-27 Ben Konrath <ben@bagu.org>
2318 Use GWT.log for client-side debugging statements.
2320 These are optimized out when deployed so I should have used this method
2321 in the first place. These statements will eventually be replaced with some sort
2322 of notification in the browser.
2324 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2325 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2326 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2327 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2328 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2330 2011-09-27 Ben Konrath <ben@bagu.org>
2332 Put tableselector on the right, back to list link on right.
2334 The idea is that the table selector is acting like a label for the
2335 currently displayed table so it should be placed below the document title. This
2336 puts the table title in a similar position to where it is in Glom.
2338 * mockups/details-contacts.html:
2339 * mockups/details-projects.html:
2340 * mockups/listview-contacts.html:
2341 * mockups/listview-projects.html:
2342 * mockups/style.css:
2343 Update mockups to match how the interfaces currently look.
2344 * src/main/webapp/style.css: Swap positions of backlink with the table
2345 selector. Add some space on the left side of the table selector to
2346 line things up with the document title.
2348 2011-09-27 Ben Konrath <ben@bagu.org>
2350 Add field colouring to details view.
2352 This change re-works how field colouring works. The colour formatting
2353 information is now set to the client with the layout information instead of
2354 with the data. This eliminates the need to send the same colour strings for
2355 data in list view column when colour information is set.
2357 In order to set an alternate colour for negative numeric values, the
2358 number is now sent to client and formatted with the GWT NumberFormat class.
2360 This change also fixes:
2362 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2364 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2365 internationalization framework which is needed for client side numeric
2367 * src/main/java/org/glom/web/client/Utils.java: New file for some
2368 client static utility methods.
2369 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2370 the DataItem object to the Field class. Use a utility method to
2371 create the foreignKeyValue string.
2372 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2373 alignment and text colours in the constructor. Add setData(DataItem)
2374 method. Remove setText(String) method.
2375 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2376 colour information to GlomTextCell. Create and use GlomNumberCell for
2377 rendering numbers. Use utility method to get the string for the
2378 primary key of the key provider. Re-work how the horizontal alignment
2380 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2381 formatting to layout information. Methods for converting the libglom
2382 formatting information were moved from DBAccess.
2383 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2384 numeric formatting (it's now done on the client side). Don't set text
2385 colours in DataItem. Move libglom formatting conversion methods to
2387 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2388 getters/setters for text colour information.
2389 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2390 for transferring the libglom NumericFormat information to the client.
2391 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2392 and getters/setters for: GlomNumericFormat, background colour and
2393 foreground colour strings.
2395 2011-09-26 Ben Konrath <ben@bagu.org>
2397 Simplify code that iterates through the LayoutGroup.
2399 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2401 2011-09-26 Ben Konrath <ben@bagu.org>
2403 Accept Eclipse formatting for OnlineGlomServiceAsync.
2405 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2407 2011-09-26 Ben Konrath <ben@bagu.org>
2409 Don't use the ListDBAccess classes to get the primary key layout information.
2411 This was causing a bug where the wrong index for the hidden primary key
2412 was being sent to the client.
2414 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2415 primary key while creating the LayoutGroup DTO. Create a
2416 LayoutItemField DTO for hidden primary keys. Don't use the
2417 RelatedListDBAccess because it was only used for getting the primary
2419 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2420 access modifier from public to protected for getPrimaryKeyField() and
2421 getPrimaryKeyLayoutItemField().
2422 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2423 abstract method getExpectedResultSize() because RelatedListDBAccess
2424 doesn't have enough info to implement it.
2425 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2426 Remove @Override for getExpectedResultSize().
2427 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2428 Remove method getExpectedResultSize().
2430 2011-09-23 Ben Konrath <ben@bagu.org>
2432 Log which layout (list or details) the ignored item is from.
2434 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2436 2011-09-23 Ben Konrath <ben@bagu.org>
2438 Remove annotations that turn off code formatting in DataItem.
2440 * src/main/java/org/glom/web/shared/DataItem.java:
2442 2011-09-23 Ben Konrath <ben@bagu.org>
2444 Rename GlomField to DataItem and update associated methods.
2446 This is a rename-only refactor. No functionality has been added or
2449 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2450 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2451 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2452 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2453 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2454 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2455 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2456 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2457 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2458 * src/main/java/org/glom/web/server/database/DBAccess.java:
2459 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2460 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2461 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2462 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2463 * src/main/java/org/glom/web/shared/DataItem.java:
2464 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2465 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2467 2011-09-23 Ben Konrath <ben@bagu.org>
2469 Rename GlomDocument to DocumentInfo and update associated methods.
2471 This is a rename-only refactor. No functionality has been added or
2474 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2475 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2476 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2477 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2478 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2480 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2482 2011-09-20 Ben Konrath <ben@bagu.org>
2484 Require java-libglom 1.17.3.
2486 This picks up the fix for the seg fault problem with the Scenes table
2487 in the Openismus Film Manager example.
2491 2011-09-20 Ben Konrath <ben@bagu.org>
2493 Change the way sort clause is added for primary key when no sort clause is requested.
2495 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2496 before the sort clause is created. When a sort clause is not requested, the
2497 sort clause is created by finding the primary key in the LayoutFieldVector
2500 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2502 2011-09-20 Ben Konrath <ben@bagu.org>
2504 Log error message if no documents are found in the configured directory.
2506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2507 Extract the glom file extension string to a private static final class
2508 variable (mostly as syntactic sugar). Accept a minor formatting change.
2509 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2510 the example glom.document.directory configuration property to make it
2511 more clear that it can any directory, not just the home directory.
2513 2011-09-18 Ben Konrath <ben@bagu.org>
2515 Add related lists to details view.
2517 The related list table has support for paging and sorting just like the
2518 table in the list view.
2520 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2521 SQL queries for the related list tables.
2522 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2523 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2525 Rename getList methods to getListView and add comments. Remove
2526 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2527 it being unused. Add methods: getDetailsLayoutAndData(),
2528 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2529 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2530 Create the layout and set the data for the fields in one async call
2531 instead of two. Create related lists where appropriate.
2532 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2533 for method name changes in OnlineGlomService.
2534 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2535 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2536 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2538 * src/main/java/org/glom/web/client/ui/ListView.java:
2539 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2540 tableName from setCellTable(). Create a ListViewTable instead of
2542 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2543 represent a data field in the details view.
2544 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2545 from addDetailsCell() to Field class. Keep track of the Fields and
2546 Portals in the details view.
2547 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2548 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2549 and add a method to get it. Add method to set the contents of the
2551 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2552 New class for related list tables. This class has the data provider
2553 for the related list table.
2554 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2555 abstract class which is the base class for the ListViewTable and the
2557 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2558 New class for list view tables. This class has the data provider for
2559 the list view table.
2560 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2561 methods for related list tables. Add more information to the
2562 LayoutItemField and LayoutItemPortal DTOs.
2563 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2564 Remove debugging print statement.
2565 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2566 Remove debugging print statements. Add primary key field to SQL count
2568 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2569 Remove unnecessary LayoutFieldVector parameter from
2570 getResultSizeOfSQLQuery() method.
2571 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2572 New class for related list table database access.
2573 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2574 class that is a wrapper DTO for details view layout and data.
2575 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2576 new 'fromField' string to this DTO.
2577 * src/main/webapp/style.css: Remove bottom margin and override top
2580 2011-09-15 Ben Konrath <ben@bagu.org>
2582 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2584 This sets things up to make it easier to add the data retrieval for
2585 related lists (portals). No user noticeable changes were made with
2588 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2589 class has the code to retrieve the layouts and access the
2590 database using the new database helper classes.
2591 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2592 Most of the functionality has been removed from this class. This
2593 class now represents the public interface for the client side
2594 code. It also deals with configuring the servlet and cleaning
2595 things up when the servlet is stopped.
2596 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2597 of static methods into this utility class.
2598 * src/main/java/org/glom/web/server/database/DBAccess.java:
2599 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2600 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2601 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2602 These classes have the database retrieval code. The class hierarchy
2603 has been setup to make it easy to reuse code for similar
2606 2011-09-06 Ben Konrath <ben@bagu.org>
2608 Create separate classes for list table code and the data provider.
2610 As part of this refactor, I also split up the code a bit to make it
2613 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2614 table code to two new classes (below).
2615 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2616 with code from ListViewImpl.
2617 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2618 New file with code from ListViewImpl.
2620 2011-09-06 Ben Konrath <ben@bagu.org>
2622 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2624 This fixes the LayoutItemPortal DTO to match the libglom layout object
2627 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2629 2011-09-01 Ben Konrath <ben@bagu.org>
2631 Set title of Portals in the Details View.
2633 * pom.xml: Bump required version of java-libglom to 1.17.1.
2634 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2635 widget creation to its own class. Add comments to constructor.
2636 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2637 The code is mostly from the Group class with the title now set.
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2639 title of Portal. Update some comments. Fix some code formatting.
2641 2011-09-01 Ben Konrath <ben@bagu.org>
2643 Remove TODO comment for the flow table column width.
2645 The flow table column width is working correctly and doesn't need to be
2646 changed. See this mailing list post for more info:
2648 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2650 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2652 2011-08-27 Ben Konrath <ben@bagu.org>
2654 Add document title (database name) to top of the browser page.
2656 I added the document title to the TableSelecitonView but that will
2657 change if / when we add a view that doesn't require table selection.
2659 * mockups/details-contacts.html:
2660 * mockups/details-projects.html:
2661 * mockups/listview-contacts.html:
2662 * mockups/listview-projects.html:
2663 * mockups/style.css: Add document title to mockups to keep things
2665 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2666 sizes to account for the document title.
2667 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2668 Set the document title when it has been retrieved from the server.
2669 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2670 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2671 and implement setDocumentTitle(String) method.
2672 * src/main/webapp/style.css: Add ID for document title style.
2674 2011-08-25 Ben Konrath <ben@bagu.org>
2676 Add NavigationType enum to LayoutItemPortal DTO.
2678 This is the start of adding support for Portals to the Details View.
2680 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2681 LayoutItem_Portal.navigation_type enum from libglom to
2682 LayoutItemPortal.NavigationType enum.
2683 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2684 NavigationType enum, field for storing the NavigationType and getter
2687 2011-08-25 Ben Konrath <ben@bagu.org>
2689 Implement the flow table layout in the Details View.
2691 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2692 FlowTable to Group to account for the renamed class.
2693 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2694 File. This is a container widget that implements the Glom details view
2695 flow table behaviour.
2696 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2697 org/glom/web/client/ui/FlowTable.java.
2698 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2699 so that the size of the subgroups are a closer match to the size of
2700 the Glom subgroups. This makes the flowtable layout match the layout
2701 in Glom for the Music Collection example file.
2703 2011-08-16 Ben Konrath <ben@bagu.org>
2705 Create container element for LayoutItemPortal in Details View.
2707 This will help me develop the layout for the FlowTable.
2709 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2710 fieldPanel variable to detailsCell.
2712 2011-08-15 Ben Konrath <ben@bagu.org>
2714 Set the height of the data element in the Details View.
2716 I changed the InlineLabels (text in a span element) to Labels (text in
2717 a div element) so that I could set the height of the details-data
2718 elements instead of the details-cell parent elements. This allows the
2719 the details-data element to display the correct height if style is
2720 applied that shows the height.
2722 This change has the added benefit of allowing the order of the labels
2723 and data elements to be changed for right-to-left languages.
2725 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2726 InlineLabels to Labels.
2727 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2728 InlineLabels to Labels. Set the height of the data element.
2729 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2730 multiline text height in the Formatting DTO.
2731 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2732 for multiline height along with getter and setter methods.
2733 * src/main/webapp/style.css: Adjust style to account for the change
2734 from span elements to div elements in the details cell.
2736 2011-08-15 Ben Konrath <ben@bagu.org>
2738 Make the List View appearance match the mockups.
2740 It doesn't match exactly but it's much better than it was.
2742 * mockups/listview-contacts.html: Remove unused css classes.
2743 * mockups/listview-projects.html: Remove unused css classes.
2744 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2745 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2746 for mainPanel instead of VerticalPanel (table). Set style name on
2747 CellTable. Set style name on Details column. Right-align Details
2749 * src/main/webapp/style.css: Adjust properties to match the mockups.
2751 2011-08-12 Ben Konrath <ben@bagu.org>
2753 Add better support for subgroups in the details view.
2755 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2756 changed FlowTable constructor.
2757 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2758 support for subgroups and subgroup-titles.
2759 * src/main/webapp/style.css: Add CSS class for subgroups and
2762 2011-08-12 Ben Konrath <ben@bagu.org>
2764 Return the top level LayoutGroup title.
2766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2768 2011-08-11 Ben Konrath <ben@bagu.org>
2770 Make the TableSelector header match the mockup.
2772 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2773 the layout panel. Properly lineup the table selection header with
2774 the list and details view.
2775 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2776 margin around the details view.
2777 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2778 Rename listBox variable to tableSelector. Set id for the style sheet.
2779 Use a FlowPanel instead of a HorizontalPanel.
2780 * src/main/webapp/style.css: Add properties to make the TableSelector
2781 box match the mockups.
2783 2011-07-13 Ben Konrath <ben@bagu.org>
2785 Update install script for java-libglom version change.
2787 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2790 2011-07-13 Ben Konrath <ben@bagu.org>
2792 Add support sub-group in the details view.
2794 I also removed the code that special-cased the default details view
2797 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2799 I still have to make a proper flowtable.
2801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2802 Don't special-case default details view layout.
2803 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2804 addLayoutField() as I'm going to use it.
2805 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2806 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2808 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2809 extracted from DetailsViewImpl.GroupPanel. Add support for
2811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2812 column count when getting the details layout.
2814 2011-07-12 Ben Konrath <ben@bagu.org>
2816 Set browser title with database and table titles.
2818 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2819 Set the browser title when the table changes and when the activity
2821 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2822 title when retrieving document info (the GlomDocument object).
2823 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2824 with getter and setter methods. Remove unused convenience constructor.
2825 Use default code formatting.
2827 2011-07-12 Ben Konrath <ben@bagu.org>
2829 Ignore LayoutItemPortals in the details view.
2831 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2834 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2835 LayoutItemPortal layout objects.
2836 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2837 LayoutItemPortal objects when retrieving the details layout.
2838 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2839 file. This is an empty class and just used to get type information for
2842 2011-07-12 Ben Konrath <ben@bagu.org>
2844 Use java-libglom 1.17.0.
2848 2011-07-11 Ben Konrath <ben@bagu.org>
2850 Remove "Table:" label from table selector.
2852 This matches a recent change in the Glom UI.
2854 * mockups/details-contacts.html:
2855 * mockups/details-projects.html:
2856 * mockups/listview-contacts.html:
2857 * mockups/listview-projects.html: Remove the "Table:" label from the
2859 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2861 2011-07-11 Ben Konrath <ben@bagu.org>
2863 Add main groups to the details view.
2865 This makes things look a little nicer in the details view. The next step
2866 is to implement the flowtable.
2868 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2869 resources from the standard gwt css theme. Standard.css is now
2870 included in OnlineGlom.html so that the online glom css rules have
2871 precedence over the gwt theme.
2872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2873 the whole LayoutGroup to the DetailsView instead of just the titles.
2874 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2875 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2876 details layout with a helper class (GroupPanel). I might extract this
2877 class when I make the full flowtable.
2878 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2879 string as default so I don't have to worry about NPEs when processing
2881 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2882 note beside OnlineGlom.gwt.xml above).
2883 * src/main/webapp/style.css: Add default font-size to body to override
2884 the font-size set by the standard theme. Don't use h2 tags for
2885 group-title. Create new details-cell class.
2887 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2889 ConfiguredDocument: Set the port number too.
2891 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2892 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2893 Glom document. Presumably this worked sometimes so far because there is a
2894 default port number.
2896 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2898 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2900 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2901 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2902 correct, though we should throw an exception too.
2904 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2906 Fix a addDocuemnt typo.
2908 * src/main/java/org/glom/web/shared/Documents.java
2909 (Documents.addDocuemnt): Rename to addDocument().
2910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2911 (OnlineGlomServiceImpl.getDocuments): Adapt.
2913 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2915 Slightly improved log output when connection fails.
2917 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2918 (ConfiguredDocument.setUsernameAndPassword):
2919 We don't know for sure if it' the username/password that's wrong, so
2920 rephrase the message.
2921 Also ouput the exception message, though it's generic in this case.
2923 2011-07-08 Ben Konrath <ben@bagu.org>
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2928 added braces to a one line if statement because the Eclipse formatter
2929 was getting confused.
2931 2011-07-07 Ben Konrath <ben@bagu.org>
2933 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2935 These should really be two separate tasks but I counldn't get things to
2936 work with GWT 2.2.0 and Eclipse 3.7.
2940 * .settings/org.eclipse.jdt.core.prefs:
2941 * .settings/org.eclipse.jdt.ui.prefs:
2942 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2943 * .settings/org.eclipse.m2e.core.prefs:
2944 Add new config files. Update current files. Remove references to the
2945 webtools plugins as we're not using any of the webtools features.
2946 * .gitignore: Add logs directory which is created when running with
2948 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2949 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2950 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2952 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2954 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2956 onlineglom.properties: Add explanatory comments.
2958 * src/main/resources/onlineglom.properties: Also change the default user
2959 from ben to someuser, to avoid the risk of people thinking we just
2960 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2962 2011-06-28 Ben Konrath <ben@bagu.org>
2964 Use filename in Log for incorrect passwords.
2966 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2967 getFileName(String) method to get the filename from the URI.
2969 2011-06-28 Ben Konrath <ben@bagu.org>
2971 Add the table name to the URL token for the ListPlace.
2973 This makes things consistent between the DetailsPlace and the
2974 ListPlace. It also allows the the ListPlace to be bookmarked.
2976 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2977 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2979 Remove getDefaultListLayout(). The default layout is now returned
2980 by the getListLayout() method when the table name is an empty string.
2981 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2982 Add table name field. Change to a new ListPlace when the table
2983 has been changed. Use getListLayout() for getting the default
2985 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2986 Add table name field. Set the correct table name in the list box
2987 when loading from bookmark. This corrects a problem for the
2989 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2990 Move table name to super-class (HasSelectableTable). Move document
2991 and table URL keys to super-class in HasSelectableTable.
2992 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2993 Add table name field. Add Tokenizer class with URL key common to
2994 the subclasses (DetailsPlace and ListPlace).
2995 * src/main/java/org/glom/web/client/place/ListPlace.java:
2996 Add table name. Add code to parse the URL token.
2997 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2998 Update ListPlace construction with empty table name string.
2999 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3000 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3001 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3002 Update ListPlace construction with table name string.
3003 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3004 Change defaultTableName field to tableName to reflect how it's now
3005 used. Update the getter and setter methods.
3007 2011-06-28 Ben Konrath <ben@bagu.org>
3009 Enable the table selector in the DetailsView.
3011 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3012 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3013 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3014 Remove getDefaultDetailsLayout(). The default layout is now returned
3015 by the getDetailsLayout() method when the table name is an empty
3017 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3018 event handler for table change event. Change to using
3019 getDetailsLayout() for the default details layout.
3020 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3022 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3023 when navigating to the details place.
3025 2011-06-27 Ben Konrath <ben@bagu.org>
3027 Use filename based unique document ID in URL and for RPC.
3029 The document ID is the glom document name with spaces (' ') replaced
3030 with pluses ('+') and without the .glom extension.
3032 This change is mostly a string substitution of 'documentTitle' for
3033 'documentID'. The only code change is the addition of a Documents DTO to get the
3034 filename to document title mappings as indicated below.
3036 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3037 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3038 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3039 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3040 Use Documents DTO to create the document links in the document
3042 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3043 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3044 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3045 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3046 * src/main/java/org/glom/web/client/place/ListPlace.java:
3047 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3048 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3049 * src/main/java/org/glom/web/client/ui/ListView.java:
3050 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3051 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3052 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3053 * src/main/java/org/glom/web/server/Log.java:
3054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3055 getDocumentTitles() to getDocuments() and return the Documents DTO.
3056 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3057 transferring the filename to document title mappings.
3059 2011-06-25 Ben Konrath <ben@bagu.org>
3061 Make the authentication popup work again.
3063 This bug was introduced when I extracted ConfiguredDocument to its own class.
3065 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3066 correct success / fail status in setUsernameAndPassword().
3068 2011-06-25 Ben Konrath <ben@bagu.org>
3070 Use filename as unique key for configuring database usernames and passwords.
3072 This replaces the use of the Glom document title which could change
3073 depending on the locale. Thanks to Murray Cumming for pointing out this
3076 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3077 * src/main/resources/onlineglom.properties:
3079 2011-06-24 Ben Konrath <ben@bagu.org>
3081 Pass primary key value to DetailsView.
3083 This enables the DetailsView to load the correct data.
3085 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3086 primary key value field and set in constructor. Pass primary key
3087 value to getDetailsData().
3088 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3089 variables for document title and primary key value.
3090 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3091 key value to the DetailsPlace.
3093 2011-06-24 Ben Konrath <ben@bagu.org>
3095 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3097 This allows the primary key to be retrieved by the Details button. This
3098 functionality has not been implemented yet but it's in the works.
3100 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3101 the LayoutGroup result to ListView.setCellTable instead of all of its
3102 fields individually.
3103 * src/main/java/org/glom/web/client/ui/ListView.java:
3104 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3105 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3106 get the primary key for the table.
3107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3108 index of the primary key in the LayoutGroup accounting for hidden
3109 primary keys. Rename getJavaNumberFormat() to
3110 convertToJavaNumberFormat() for consistency. Cleanup / add some
3112 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3113 field for primary key index and a field to indicate whether the
3114 primary key is hidden or not.
3116 2011-06-23 Ben Konrath <ben@bagu.org>
3118 Rename getTableData methods to getListData.
3120 This is a rename refactor for consistency with other methods.
3122 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3123 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3124 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3127 2011-06-23 Ben Konrath <ben@bagu.org>
3129 Extract the ConfiguredDocument innerclass into its own class.
3131 This makes the servlet code more object oriented.
3133 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3134 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3136 new ConfiguredDocument class.
3138 2011-06-21 Ben Konrath <ben@bagu.org>
3140 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3142 This makes things more inline with how libglom works and reduces code
3143 duplication. This refactor lays the groundwork for adding the primary key to
3144 the LayoutGroup object.
3146 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3147 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3149 Change method names to getListLayout and getDefaultListLayout for
3150 consistency. Use LayoutGroup as the DTO for the list layout instead of
3151 ColumnInfo and LayoutListTable.
3152 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3153 new method names along with the LayoutGroup object for transferring the
3155 * src/main/java/org/glom/web/client/ui/ListView.java:
3156 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3157 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3158 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3160 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3161 Replaced with LayoutGroup.
3162 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3163 expectedResultSize and defaultTableName fields which are needed for
3165 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3166 type field which is needed for the list layout but will also be
3167 useful for the details layout as things progress.
3168 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3169 Make class abstract. Remove the unnecessary
3170 getFormattingHorizontalAlignment method. Add setFormatting method.
3172 2011-06-16 Ben Konrath <ben@bagu.org>
3174 Add scripts for building and installing war.
3176 These will help when updating OnlineGlom but they're also good
3177 supplemental documentation of the build and deployment proceeding.
3179 * utils/build-onlineglom-war.sh: New file.
3180 * utils/install-onlineglom-war.sh: New file.
3182 2011-06-16 Ben Konrath <ben@bagu.org>
3184 Create wrapper class to create consistent log messages.
3186 I wrapped methods in the Log class of gwt-log to add the method names
3187 from the servlet and create consistent formatting of the document title
3188 and table names in the log messages.
3190 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3192 log methods to use methods from wrapped Log class.
3194 2011-06-16 Ben Konrath <ben@bagu.org>
3196 Remove superfluous conditional return.
3198 Thanks to Murray Cumming for pointing this out!
3200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3202 2011-06-15 Ben Konrath <ben@bagu.org>
3204 Return an ArrayList of LayoutGroups for the Details layout.
3206 This corrects a problem with the details layout as it can have more
3207 than one top level LayoutGroup.
3209 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3210 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3211 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3212 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3214 with ArrayList of LayoutGroups for the details view layout.
3215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3216 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3217 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3218 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3219 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3220 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3222 2011-06-14 Ben Konrath <ben@bagu.org>
3224 Use cast_dynamic method to determine the libglom LayoutItem type.
3226 This is better than finding the LayoutItem type by using the string
3227 returned from the get_part_type_name() method.
3229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3231 2011-06-14 Ben Konrath <ben@bagu.org>
3233 Add method names to log entries in the servlet.
3235 This helps when tracking down deployment problems.
3237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3239 2011-06-14 Ben Konrath <ben@bagu.org>
3241 Add data to the DetailsView using a hard-coded primary key value.
3243 The layout and functionality of the DetailsView is not complete. This
3244 is just a checkpoint so the patch doesn't get too big.
3246 * src/main/java/org/glom/web/client/OnlineGlomService.java: