1 2012-01-24 Murray Cumming <murrayc@murrayc.com>
3 Improve null/empty String checks.
5 * pom.xml: Add a dependency on commons-lang, to use
6 org.apache.commons.lang.StringUtils.
7 * src/main/java/org/glom/web/server/ConfiguredDocument.java
8 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
9 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
10 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
11 Use StringUtils.isEmpty().
13 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
14 StringUtils class with a static isEmpty() function because we
15 cannot use org.apache.commons.lang.StringUtils in client-side
16 GWT code because it (apparently) cannot be compiled to javascript.
17 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
18 * src/main/java/org/glom/web/client/activity/ListActivity.java
19 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
20 * src/main/java/org/glom/web/client/place/DetailsPlace.java
21 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
22 * src/main/java/org/glom/web/client/place/ListPlace.java
23 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
24 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
25 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
26 * src/main/java/org/glom/web/client/ui/details/Group.java
27 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
28 our StringUtils.isEmpty() function.
30 2012-01-24 Murray Cumming <murrayc@murrayc.com>
32 Update to the latest java-libglom API.
34 * pom.xml: Require java-libglom 1.21.4.
35 * src/main/java/org/glom/web/server/ConfiguredDocument.java
36 getDocumentInfo(), getListViewLayoutGroup():
37 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
39 * src/main/java/org/glom/web/server/database/DBAccess.java
40 getFieldsToShowForSQLQueryAddGroup(),
41 getPrimaryKeyLayoutItemField(): Replace get_database_title()
42 with either get_database_title_original() or
43 get_database_title(localeID).
45 2012-01-24 Murray Cumming <murrayc@murrayc.com>
47 ConfiguredDocument: Avoid a null pointer exception.
49 * src/main/java/org/glom/web/server/ConfiguredDocument.java
50 Initialize localeID to "" to avoid returning a null String which
51 causes a crash in java-libglom's swing-generated code.
53 2012-01-23 Murray Cumming <murrayc@murrayc.com>
57 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
58 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
59 for localeChooser. This seems more appropriate and is less ambiguous
60 particularly in the .css file.
62 2012-01-23 Murray Cumming <murrayc@murrayc.com>
64 ConfiguredDocument: Rename the localedID private member variable.
66 2012-01-23 Murray Cumming <murrayc@murrayc.com>
68 Adapt to the latest java-libglom API from git master.
70 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
71 libglom now uses only Vector instead of List, which uses add() instead of
74 2012-01-23 Murray Cumming <murrayc@murrayc.com>
76 Add and fill a Reports drop-down list box.
78 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
80 * src/main/java/org/glom/web/client/OnlineGlomService.java:
81 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
82 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
83 Added getReports(document, table, localeID), calling
84 ConfiguredDocument.getReports().
85 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
86 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
87 Added setReportsList() and a list widget.
88 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
89 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
91 2012-01-22 Murray Cumming <murrayc@murrayc.com>
93 ConfiguredDocument: Rename the localedID private member variable.
95 2012-01-20 Murray Cumming <murrayc@murrayc.com>
97 Build a source tarball with mvn assembly:single
99 * assembly.xml: Add this file.
100 * pom.xml: Use the maven-assembly-plugin and tell it to use
101 our assembly.xml file.
103 2012-01-19 Murray Cumming <murrayc@murrayc.com>
105 OnlineGlomServiceImpl: Get .glom files recursively.
107 * pom.xml: Depend on commons-io from org.apache.commons.
108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
109 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
110 files recursively, and with the easier filter for the extension.
111 Use org.apache.commons.io.FilenameUtils.removeExtension() to
112 simplify that code too.
114 2012-01-19 Murray Cumming <murrayc@murrayc.com>
116 README: Mention that you must install java-libglom packages separately.
118 But then it works, because java-libglom is now in the central maven
121 2012-01-18 Murray Cumming <murrayc@murrayc.com>
123 locales drop-down: Show the correct selected locale when the URL changes.
125 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
126 .java: setPlace(): Move some code into fillView().
128 2012-01-18 Murray Cumming <murrayc@murrayc.com>
130 locales drop-down: Do not lose the primary key.
132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
133 start(): onLocaleChange(): Pass the current primary key value,
134 instead of an empty value.
136 2012-01-18 Murray Cumming <murrayc@murrayc.com>
138 locales drop-down: Do not lose the drop-down selection.
140 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
141 .java (TableSelectionActivity.fillView): Set the selected locale
142 after changing the drop-down items (though we do not really need
143 to change them just because the locale changes.)
145 2012-01-18 Murray Cumming <murrayc@murrayc.com>
147 locales drop-down: Change the tables list when this changes.
149 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
150 .java: TableSelectionActivity.start(): Move the async table titles
151 retrieval into a private fillView() method and also call this when
152 the chosen locale changes.
153 Note that the document title is not actually translatable yet, but
154 that is a problem that I should fix soon in libglom.
156 2012-01-18 Murray Cumming <murrayc@murrayc.com>
158 Improve the placement of the locales drop-down.
160 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
161 Put the title and locales drop-down in a div (gwt.FlowTable).
162 * src/main/webapp/style.css: Add magic css properties to make this work.
163 Also remove the left margin from the title so that it lines up with the
166 2012-01-18 Murray Cumming <murrayc@murrayc.com>
168 locales selector: Show human-readable locale titles.
170 * src/main/java/org/glom/web/server/ConfiguredDocument.java
171 getDocumentInfo(): Use java.util.Locale to show a real title of
172 each locale, in the locale's own language.
174 2012-01-17 Murray Cumming <murrayc@murrayc.com>
176 Add a language/locale selector drop-down.
178 * src/main/java/org/glom/web/shared/DocumentInfo.java:
179 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
180 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
181 getDocumentInfo(): Store the available Locales in the DocumentInfo.
182 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
183 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
184 Add a ListBox to show the available locales. Add getLocaleSelector(),
185 setLocaleList(), getSelectedLocale(), setSelectedLocale().
186 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
187 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
188 java: Add these classes.
189 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
190 start(): Fill the locales ListBox. Handle its change event, firing a
192 setPlace(): Show the selected locale as specified by the URL token.
193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
194 * src/main/java/org/glom/web/client/activity/ListActivity.java:
195 Handle LocaleChangeEvent, going to a new *Place with that locale.
197 The placement of the ListBox is not pretty, and it currently uses the ID
198 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
202 2012-01-17 Murray Cumming <murrayc@murrayc.com>
204 Search box: Show the search text from the URL token.
206 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
207 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
208 Add setQuickFindText().
209 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
210 .java: setPlace(): Store the queryText if the place is a ListPlace,
211 and call TableSelectionView.setQuickFindText().
213 2012-01-17 Murray Cumming <murrayc@murrayc.com>
215 Allow use of translations via, for instance, &lang=de in the URL.
217 * pom.xml: Use the unstable java-libglom 1.21 version.
219 * src/main/java/org/glom/web/client/OnlineGlomService.java:
220 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
222 init(): Instead of calling TranslatableItem.set_current_locale()
223 (now removed), call ConfiguredDocument.setDefaultLocaleID().
224 However, this is only for default locales, which are not needed to
225 change the locale in the URL.
226 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
227 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
228 getSortedRelatedListData(): Add a localeID parameter, so we can get the
229 layout for a particular locale.
230 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
231 Add get/setDefaultLocaleID().
232 getDocumentInfo(), getListViewData(), getRelatedListData(),
233 getDetailsLayoutGroup(), getListViewLayoutGroup(),
234 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
235 localeID parameter, so we can get the layout for a particular locale.
237 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
238 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
239 * src/main/java/org/glom/web/client/place/ListPlace.java:
240 Parse and construct a lang parameter too.
242 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
243 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
244 passed to subsequent methods and constructors.
245 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
246 * src/main/java/org/glom/web/client/activity/ListActivity.java:
247 Store the localeID from the *Place and pass it to other constructors
248 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
250 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
251 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
252 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
253 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
254 * src/main/java/org/glom/web/client/ui/ListView.java:
255 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
256 Take localeID parameters and pass them to subsequent constructors and
257 methods, so that the layout is always retrieved for that locale.
259 This is rather repetitive.
261 Note that "" means the original (default) locale of the Glom document,
262 which is usually English.
264 2012-01-17 Murray Cumming <murrayc@murrayc.com>
266 Documents: Remove final keyword to fix startup configuration.
268 * src/main/java/org/glom/web/shared/Documents.java: Remove the
269 final keywords on the private member variables because that breaks
270 the startup, apparently (there are warnings) because it stops them
271 from being serialized. I added these in the previous commit.
273 2012-01-13 Murray Cumming <murrayc@murrayc.com>
275 Documents: Add some final keywords.
277 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
280 2012-01-13 Murray Cumming <murrayc@murrayc.com>
282 OnlineGlomServiceImpl: Add to overview comments.
284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
285 Note that this is where all the document are loaded. They are not
286 loaded freshly for each page.
288 2012-01-12 Murray Cumming <murrayc@murrayc.com>
292 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
293 Add a TextBox for the text of a quick find.
294 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
296 setBackLink(): Add a String quickFind parameter.
297 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
298 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
299 to the base interface, because that is how TableSelectionViewImpl is used.
300 * src/main/webapp/style.css: Add style for the search box and its label.
302 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
303 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
304 Add these files, based on the existing TableChangeEvent and
305 TableChangeEventHandlers.
306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
307 start(): Handle QuickFindChangeEvent, passing its quickFind text to
308 a ListPlace() that the user should be taken to.
309 * src/main/java/org/glom/web/client/activity/ListActivity.java
310 start(): Handle it here too and adapt the TableChangeEvent handler to
311 pass the extra "" quickFind parameter to ListPlace.
312 * src/main/java/org/glom/web/client/place/ListPlace.java:
313 Constructor: Take an extra String quickFind parameter and store it,
314 returning it from a new getQuickFind() method.
315 getToken(): Put the quickFind text in the URL token.
316 getPlace(): Parse the quickFind text from the URL token.
317 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
318 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
319 ListPlace constructor.
320 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
321 .java: start(): Add a Change handler for the TableSelectionView's
322 TextBox (via its base HasChangeHandlers interface), firing the new
323 QuickFindChangeEvent.
324 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
325 pass the extra "" quickFind parameter.
327 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
328 setCellTable(): Add a String quickFind parameter and pass it to
329 the ListViewTable() constructor.
330 * src/main/java/org/glom/web/client/ui/ListView.java: Change
331 setCellTable() in the base interface, because that is how ListViewImpl
334 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
335 Add a String quickFind member variable.
336 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
337 Constructor: Add a String quickFind parameter, storing it in the
338 base ListTable's member variable.
339 onRangeChanged(): Pass quickFind to the
340 OnlineGlomServiceAsync.getSortedListViewData() and
341 OnlineGlomServiceAsync.getListViewData() methods.
343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
344 getListViewData(), getSortedListViewData(): Add a String quickFind
345 parameter, passing it to ConfiguredDocument.getListViewData().
346 * src/main/java/org/glom/web/client/OnlineGlomService.java:
347 Change getListViewData(), getSortedListViewData() in the base interface,
348 because that is how OnlineGlomServiceImpl is used, via this:
349 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
350 Change getListViewData(), getSortedListViewData() here too.
351 This class can apparently be used to asynchronously call methods on
352 OnlineGlomService, and GWT seems to implement that after recognizing
353 just the *Async name convention and the extra AsyncCallback parameters.
355 * src/main/java/org/glom/web/server/ConfiguredDocument.java
356 getListViewData(): Add a String quickFind parameter, and pass it to
357 ListViewDBAccess.getData().
358 * src/main/java/org/glom/web/server/database/ListDBAccess.java
359 getListData(): Add a String quickFind parameter and pass it to
361 getSelectQuery(): Add a String quickFind parameter.
362 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
363 getSelectQuery(): Add a String quickFind parameter and use it with
364 Glom.get_find_where_clause_quick() to pass a where_clause to
365 Glom.build_sql_select_with_where_clause(), to actually filter the
367 getData(): Add a String quickFind parameter, passing it to getListData().
368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
369 va: getData(): Pass an empty string to getListData() for the
372 2012-01-12 Murray Cumming <murrayc@murrayc.com>
374 ListTable: Minor change.
376 * src/main/java/org/glom/web/client/ui/list/ListTable.java
377 createCellTable(): Make this protected instead of public.
379 2012-01-12 Murray Cumming <murrayc@murrayc.com>
381 Many files: Use final for the parameters and use the @override attribute.
383 2012-01-22 Ben Konrath <ben@bagu.org>
385 Add anchor links for single line text that starts with http, ftp and www.
389 2012-01-22 Ben Konrath <ben@bagu.org>
391 Add ellipsis to single line text in details view.
395 2012-01-04 Murray Cumming <murrayc@murrayc.com>
397 Remove all javadoc author tags.
399 Because they are awkward and meaningless when many people touch
401 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
403 2012-01-04 Murray Cumming <murrayc@murrayc.com>
405 Revert the COPYING.LESSER to COPYING rename.
407 Apparently both should be there if it is LGPL.
409 2012-01-03 Murray Cumming <murrayc@murrayc.com>
411 *View: Remove unused imports.
413 * src/main/java/org/glom/web/client/ui/DetailsView.java:
414 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
415 * src/main/java/org/glom/web/client/ui/ListView.java:
416 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
417 Remove unused imports, as suggested by Eclipse.
419 2012-01-02 Murray Cumming <murrayc@murrayc.com>
421 Move the *View::Presenter types, and some API into one base View.
423 * src/main/java/org/glom/web/client/ui/DetailsView.java:
424 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
425 * src/main/java/org/glom/web/client/ui/ListView.java:
426 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
427 Presenter, setPresenter() and clear() into a shared base interface,
428 to avoid the unnecessary duplicate Presenter types and to more clearly
429 show how the *Views share the same structure, even if they are not
430 used polymorphically.
432 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
433 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
435 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
436 * src/main/java/org/glom/web/client/activity/ListActivity.java:
437 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
439 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
442 Feel free to revert this if there is a good reason for the duplicate
445 2012-01-02 Murray Cumming <murrayc@murrayc.com>
447 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
449 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
450 a class member instead of a local variable in the method.
451 This lets us use it to get the view instances, for use in tests.
452 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
453 beforeOnlineGlom(): Test some more details of the initial view.
454 Again, this is not very useful.
456 To really test gwt-glom we will need to start a local postgresql
457 instance with local data, like the Glom tests in C++.
459 2012-01-02 Murray Cumming <murrayc@murrayc.com>
461 pom.xml: Mention the LGPL license.
463 * pom.xml: Add a licenses section.
464 * COPYING.LESSER: Move this to COPYING, which
465 previously contained the GPL. But gwt-glom is all LGPL.
467 2012-01-02 Murray Cumming <murrayc@murrayc.com>
469 Add project information to README and pom.xml.
471 * README: Add a brief description and mention some mvn
473 * pom.xml: This extra information shows up in mvn site
476 2011-01-02 Murray Cumming <murrayc@murrayc.com>
478 Use the latest java-libglom version.
480 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
482 2012-01-01 Murray Cumming <murrayc@murrayc.com>
484 GwtTestOnlineGlom: Test a little more.
486 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
487 protected rather than private, as suggested by the gwt-test-utils
489 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
490 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
491 Test the initial visibility of the panels.
493 However, this is not a very useful test.
494 And I wonder how we should generally test using this idea for an
495 activity/places app like ours where the real changes happen implicitly
496 based on the history token/URL.
498 2012-01-01 Murray Cumming <murrayc@murrayc.com>
500 Slight modification to *Mapper comments.
502 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
504 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
506 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
508 Remove comments mentioning GIN because they are just copied from
509 the example code and are apparently not helpful:
510 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
511 Also change the mention of a class that is only in the example code.
513 2012-01-01 Murray Cumming <murrayc@murrayc.com>
515 GwtTestOnlineGlom test: Minor changes.
517 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
518 Avoid the long qualified class name and modify the comment
519 because it is now obvious to me that the mocked class is the only
520 custom one created via GWT.create().
522 2012-01-01 Murray Cumming <murrayc@murrayc.com>
524 Tests: Added the beginnings of a test using gwt-test-utils.
526 * pom.xml: Add dependencies on gwt-test-utils and easymock.
527 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
528 which tells gwt-test-utils what class will be tested.
529 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
530 Add a simple (but empty) test case. One class, used by the OnlineGlom
531 class, is mocked so that it can be created. However, I am not sure
532 why only this class needs to be mocked.
534 Note that mockito seems more popular, and clearer, than easymock,
535 but I have not got that working yet. It might be a matter of the
538 This test is run during mvn integration-test.
540 2011-12-31 Murray Cumming <murrayc@murrayc.com>
542 Tests: Use junit4-style syntax instead of junit3-style.
544 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
545 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
546 * src/test/java/org/glom/web/shared/DataItemTest.java:
547 Use the @Test annotation rather than relying on the test*() prefix.
548 Also no longer implement TestCase, to avoid triggering support for
549 the junit3-way, which stops the annotations from working.
550 Change the imports from import junit.framework.* to
551 import org.junit.*, which is apparently the new way.
553 2011-12-31 Murray Cumming <murrayc@murrayc.com>
555 Added a test for ListPlace token parsing and creation.
557 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
558 This is much the same as DetailsPlaceTest.
560 I wonder how we could test the other parts of the *Place API.
562 2011-12-30 Murray Cumming <murrayc@murrayc.com>
564 DetailsPlace test: Also test getToken() and recreation via getPlace().
566 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
567 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
568 recreate it, testing the recreated DetailsPlace for the same parameter
571 2011-12-30 Murray Cumming <murrayc@murrayc.com>
573 Use the surefire-report plugin.
575 * pom.xml: This generates a HTML report about the tests in
576 target/site/surefire-report.html
577 when you do mvn surefire-report:report. It seems to be popular/normal.
579 2011-12-30 Murray Cumming <murrayc@murrayc.com>
581 Added a test for DetailsPlace.
583 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
584 Test the getPlace() token parsing.
586 2011-12-30 Murray Cumming <murrayc@murrayc.com>
588 Added a first unit test.
590 * pom.xml: Add a test goal, and a dependency on junit in that scope.
591 * src/test/java/org/glom/web/shared/DataItemTest.java:
592 This is a silly test but it is just to get things started. Note that
593 maven/junit finds the test because it looks in src/test by default.
595 2011-12-22 Ben Konrath <ben@bagu.org>
597 Change charsetName to "UTF-8" when replacing line breaks.
599 JavaScript requires the charsetName to be "UTF-8". CharsetName values
600 that work in Java (such as "UTF8") will not work when compiled to
603 This fixes a problem with multi-line details view fields that have hard
604 line breaks. The "License Text" field on this page demonstrates the
607 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
609 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
611 2011-12-22 Ben Konrath <ben@bagu.org>
613 Fix another bug with related list navigation.
615 I've tested all the navigation buttons in all of the related lists
616 so things should be good now.
618 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
620 2011-12-22 Ben Konrath <ben@bagu.org>
622 Fix a crasher when refreshing the list view with the default table.
624 This crash will also happen when loading the list view with the default
625 table from a link or bookmark.
627 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
628 to the main document selection page when the document id hasn't been
630 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
631 the main document selection page when the document id hasn't been
633 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
634 values for the details place when the document id hasn't been set.
635 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
636 values for the list place when the document id hasn't been set.
638 2011-12-21 Ben Konrath <ben@bagu.org>
640 Protect against NPE when glom.document.locale is not in config.
642 This patch protects against an NPE when glom.document.locale is not in
643 the config file. This NPE will also happen if glom.document.locale is
646 The patch also updates the error message to display the class name when
647 the getMessage() returns null. This was happening when the NPE was
648 thrown and I had "Configuration Error: null". If an NPE is encountered
649 with this patch, "Configuration Error: NullPointerException " will be
652 This commit closes this bug:
654 https://bugzilla.gnome.org/show_bug.cgi?id=666669
656 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
658 2011-12-20 Murray Cumming <murrayc@murrayc.com>
660 Rename onlineglom.properties to onlineglom.properties.sample.
662 * src/main/resources/onlineglom.properties: Rename to:
663 * src/main/resources/onlineglom.properties.sample:
664 * src/main/resources/README: And add this file explaining that people
665 should rename it back when deploying.
667 2011-12-20 Murray Cumming <murrayc@murrayc.com>
669 Allow choosing the translation in the .properties file.
671 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
672 init(): Read a glom.document.locale value from the configuration file
673 and call Glom's TransatableItem::set_current_locale() method.
674 * src/main/resources/onlineglom.properties: Add a commented-out
675 example of this new setting.
677 It would be better to add &lang=de_DE to the URL, but the current
678 libglom API does not allow us to do this easily. I am working on that.
680 2011-12-19 Murray Cumming <murrayc@murrayc.com>
682 Avoid a crash in parsing of token parameters.
684 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
685 ava: getTokenParams(): Do not crash if a parameter has a key but no
686 value, and ignore parameters with neither.
688 2011-12-17 Murray Cumming <murrayc@murayc.com>
690 History token building/handling: Improve use of token parameters.
692 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
693 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
694 and buildParamsToken(HashMap), for use by derived classes.
695 Make the separator private because it is no longer be needed.
696 * src/main/java/org/glom/web/client/place/DetailsPlace.java
697 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
698 instead of manual string concatenation.
699 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
700 of hardcoded indices and awkward splitting code.
701 * src/main/java/org/glom/web/client/place/ListPlace.java
702 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
703 instead of manual string concatenation.
704 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
705 of hardcoded indices and awkward splitting code.
706 This should fix bug #666420
708 2011-12-16 Murray Cumming <murrayc@murrayc.com>
710 Fix a Navgiation->Navigation typo in the code.
712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
713 Rename processNavgiation() to processNavigation().
715 2011-12-16 Murray Cumming <murrayc@murrayc.com>
717 Fix a seperator->separator typo in the code.
719 * src/main/java/org/glom/web/client/place/DetailsPlace.java
720 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
721 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
724 2011-12-15 Ben Konrath <ben@bagu.org>
726 Cleanup some comments.
728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
730 2011-12-14 Ben Konrath <ben@bagu.org>
732 Replace \n with <br/> for multiline text in the details view.
734 Vertical scrollbars are added when needed as well.
736 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
738 2011-12-14 Ben Konrath <ben@bagu.org>
740 Specify the font for document selection links.
742 * src/main/webapp/style.css:
744 2011-12-14 Ben Konrath <ben@bagu.org>
746 Fix bouncy CellTable while paging.
748 This doesn't currently work with related list tables in unselected
751 * src/main/java/org/glom/web/client/ui/list/ListTable.java
753 2011-12-14 Ben Konrath <ben@bagu.org>
755 Revamp the appearance of the document selection page.
757 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
758 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
759 * src/main/webapp/style.css:
761 2011-12-13 Ben Konrath <ben@bagu.org>
763 Set navigation button column to the smallest size possible.
765 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
767 2011-12-13 Ben Konrath <ben@bagu.org>
769 Change OpenButton nomenclature to NavigationButton.
771 Using NavigtionButton makes things more generic. Classes, methods and
772 variables have been changed.
774 This is a rename-only refactor.
776 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
777 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
778 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
779 Renamed from OpenButtonCell.
780 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
781 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
782 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
784 2011-12-12 Ben Konrath <ben@bagu.org>
786 Remove unnecessary String argument in RelatedListTable and ListViewTable.
788 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
789 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
790 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
791 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
793 2011-12-12 Ben Konrath <ben@bagu.org>
795 Update variable names and comments.
797 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
798 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
800 2011-12-12 Ben Konrath <ben@bagu.org>
802 Properly initialize numNonEmptyRows variable to zero.
804 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
805 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
807 2011-12-05 Ben Konrath <ben@bagu.org>
809 Add latest mockup with HTML tables.
811 Features of this mockup:
813 -> HTML table for flowtable
814 -> HTML table for flowtable column
815 -> Example of how related lists would look
816 -> Not using text entries for data items
818 The current version of Online Glom doesn't use HTML tables for the
821 This mockup has been sent to the glom-devel mailing list but it's good
822 to have it here as well.
824 * mockups/details-view-html-tables.html:
826 2011-12-05 Ben Konrath <ben@bagu.org>
828 Remove unnecessary getPrimaryKeyField() method.
830 getPrimaryKeyFieldForTable(String) has been renamed to
831 getPrimaryKeyField(String).
833 * src/main/java/org/glom/web/server/database/DBAccess.java:
834 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
835 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
837 2011-12-05 Ben Konrath <ben@bagu.org>
839 Add string representation of TypedDataItem value to conversion error message.
841 * src/main/java/org/glom/web/server/Utils.java: Logging the error
842 message was extracted into its own method to avoid duplication.
844 2011-12-05 Ben Konrath <ben@bagu.org>
846 Add type checking to navigation primary key value creation.
848 Create navigation primary key only if the expected type from the Glom
849 document matches the type returned by the SQL query.
851 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
853 2011-12-05 Ben Konrath <ben@bagu.org>
855 Rename a couple of variables in RelatedListNavigation.
857 This is a rename-only refactor.
859 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
861 2011-12-05 Ben Konrath <ben@bagu.org>
863 Move getListLayoutGroup() into getListViewLayoutGroup().
865 This removes getListLayoutGroup(). It was only being called by
866 getListViewLayoutGroup().
868 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
870 2011-12-05 Ben Konrath <ben@bagu.org>
872 Remove check for LayoutItem_Portal in list table method.
874 This check is no longer necessary because the method isn't being used
875 to create the LayoutItemPortal DTO.
877 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
879 2011-12-05 Ben Konrath <ben@bagu.org>
881 Properly support related list navigation.
883 Navigation from the "Repository Analyzer -> Package Scans ->
884 Dependencies" related table wasn't working because the primary key for
885 related tables wasn't being set properly. This commit fixes the
888 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
889 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
890 doesn't set the primary key properly for related list tables.
891 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
892 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
893 useful for getting the primary key for list view tables and for related
895 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
896 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
897 Move code to set the primary key for the table from the abstract
898 ListDBAccess class to ListViewDBAccess as it's only correct for list
900 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
901 Properly add primary key to related list tables.
903 2011-12-02 Ben Konrath <ben@bagu.org>
905 Properly set the horizontal alignment of fields.
907 This fix is for both the list tables and the details view.
909 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
910 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
911 to set the horizontal alignment of fields.
913 2011-12-02 Ben Konrath <ben@bagu.org>
915 Display currency codes in the details view.
917 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
919 2011-12-02 Ben Konrath <ben@bagu.org>
921 Avoid duplicate JNI call.
923 JNI is not as efficient as pure Java and this is an easy (and small)
926 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
927 Use previously retrieved value for whereClauseToTableName instead of
930 2011-12-02 Ben Konrath <ben@bagu.org>
932 Rename a couple of variables in RelatedListNavigation.
934 This is a rename-only refactor.
936 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
938 2011-12-02 Ben Konrath <ben@bagu.org>
940 Indicate clearly that a mismatched primary key type is a bug.
942 * src/main/java/org/glom/web/server/Utils.java: Change log level from
943 warning to error. Add 'This is a bug.' to message.
945 2011-12-02 Ben Konrath <ben@bagu.org>
947 Update / fix some comments.
949 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
951 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
953 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
954 Fix comments. Add some TODOs.
956 2011-12-02 Ben Konrath <ben@bagu.org>
958 Enable navigation to details view with string primary key from related list.
960 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
961 Create a text primary key value when return type of result is
962 java.sql.Types.VARCHAR.
964 2011-12-02 Ben Konrath <ben@bagu.org>
966 Use checkboxes for booleans in the details view.
968 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
970 2011-12-01 Ben Konrath <ben@bagu.org>
972 Improve performance of related list height calculation.
974 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
975 Put code to calculate the expected height in a static initializer so
976 that that it's only called once.
978 2011-12-01 Ben Konrath <ben@bagu.org>
980 Show related list tables in notebooks (again).
982 Calculate the height of the related list tables so the Notebook can be
983 set the correct height. The height of the related list table is also needed by
984 FlowTable to be able decide how to create the layout.
986 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
987 and set the Portal height based on the height of the related list
988 table and the Portal container.
989 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
990 Add method to calculate the height of the related list tables.
991 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
992 * src/main/webapp/style.css: Add css class for Pager. This is needed to
993 calculate the height of the Pager widget.
995 2011-12-01 Ben Konrath <ben@bagu.org>
997 Use CellTable API for table property instead of setting style on Element.
999 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1001 2011-12-01 Ben Konrath <ben@bagu.org>
1003 Make ListViewTable and RelatedListTable a consistent height.
1005 The tables are now a consistent height regardless of the contents of
1006 the table. A hidden button is added to empty rows to ensure that the
1007 height of these rows will match the height of rows with data.
1009 A navigation button column is now added to every table. The width of
1010 the navigation column is set to 0px when a RelatedListTable shouldn't
1011 have navigation buttons. This maintains the a consistent row height in
1012 tables that don't show the navigation buttons.
1014 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1015 navigation column when not needed.
1016 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1017 arguments for navigation button to constructor of ListViewTable.
1018 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1019 hidden button for empty data rows.
1020 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1021 arguments for navigation button to constructor.
1022 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1023 create navigation buttons. Add hideNavigationButtons() method.
1024 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1025 arguments for navigation button to constructor.
1027 2011-12-01 Ben Konrath <ben@bagu.org>
1029 Use 'visibility: hidden' in Utils.getWidgetHeight().
1031 This is better choice because hidden elements are invisible, don't
1032 respond to events and are not part of the tab order. They will,
1033 however, take up space which is required to be able to calculate the
1034 height of the widget.
1036 * src/main/java/org/glom/web/client/Utils.java:
1038 2011-12-01 Ben Konrath <ben@bagu.org>
1040 Use Utils.getWidgetHeight() in FlowTable.
1042 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1044 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1046 2011-12-01 Ben Konrath <ben@bagu.org>
1048 Put the details css class name on the correct table column.
1050 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1052 2011-11-30 Ben Konrath <ben@bagu.org>
1054 Update for java-libglom API change.
1056 The getters and setters on FieldFormatting and NumericFormat were
1057 changed to remove the 'M'.
1059 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1061 2011-11-29 Ben Konrath <ben@bagu.org>
1063 Only allow RelatedListTables in Portals.
1065 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1067 2011-11-29 Ben Konrath <ben@bagu.org>
1069 Only create a contents panel for Portals when title is being set.
1071 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1073 2011-11-29 Ben Konrath <ben@bagu.org>
1075 Set TabLayoutPanel height based on calculated height its widgets.
1077 This is a potential fix for this bug:
1079 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1081 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1083 2011-11-29 Ben Konrath <ben@bagu.org>
1085 Align details field labels and data with the Open buttons.
1087 * src/main/webapp/style.css:
1089 2011-11-29 Ben Konrath <ben@bagu.org>
1091 Remove unnecessary <div> in the Notebook widget.
1093 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1094 method to get container FlowPanel (<div>).
1095 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1096 initWidget() method directly on the TabLayoutPanel widget instead of
1097 Group's container widget.
1099 2011-11-29 Ben Konrath <ben@bagu.org>
1101 Don't add group titles for Portals in Notebooks.
1103 This reverts the previous patch and fixes a bug I introduced with
1104 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1106 * src/main/java/org/glom/web/client/ui/details/Group.java:
1107 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1109 2011-11-28 Ben Konrath <ben@bagu.org>
1111 Remove unused boolean argument in Portal constructor.
1113 Just a code cleanup.
1115 * src/main/java/org/glom/web/client/ui/details/Group.java:
1116 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1118 2011-11-28 Ben Konrath <ben@bagu.org>
1120 Remove hack for glom 1.18 style glom files.
1122 * src/main/java/org/glom/web/client/ui/details/Group.java:
1123 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1124 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1126 2011-11-28 Ben Konrath <ben@bagu.org>
1128 Use Gda Value version of primary key to log result too large error.
1130 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1132 2011-11-28 Ben Konrath <ben@bagu.org>
1134 Don't use TypedDataItem.getText() for Unknown types from the URL.
1136 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1137 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1138 instead of getText().
1139 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1140 String field and getUnknown() method.
1142 2011-11-28 Ben Konrath <ben@bagu.org>
1144 Log an error message when the java-libglom .so is not present.
1146 The error message was being set in the exception but not logged.
1148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1150 2011-11-28 Ben Konrath <ben@bagu.org>
1152 Ignore LayoutItem_CalendarPortals.
1154 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1155 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1157 2011-11-28 Ben Konrath <ben@bagu.org>
1159 Extract method for creating the LayoutItemPortal DTO.
1161 Just breaking the code up into smaller chunks.
1163 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1165 2011-11-28 Ben Konrath <ben@bagu.org>
1169 This should have been added with the refactor. Oops!
1171 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1173 2011-11-28 Ben Konrath <ben@bagu.org>
1175 Create primary key value from URL string using type from Glom document.
1177 See this bug, comments 19 - 25:
1179 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1181 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1182 create a TypeDataItem for the primary key here when loading from a
1183 URL. Show the same string for the primary key value as was received
1184 from the URL string (when loading from a URL).
1185 * src/main/java/org/glom/web/server/Utils.java: Update method for
1186 creating the Gda Value from the TypeDataItem to properly deal with
1187 creating a Gda Value based on the Glom document type for the primary
1188 key value string when loading from a URL.
1189 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1190 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1191 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1192 Update for changed method name.
1194 2011-11-27 Ben Konrath <ben@bagu.org>
1196 Rename PrimaryKeyItem to TypedDataItem.
1198 The name PrimaryKeyItem suggests what the class should be used for.
1199 TypedDataItem is a neutral name that describes the class better.
1201 This is a rename-only refactor.
1203 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1204 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1205 * src/main/java/org/glom/web/client/Utils.java:
1206 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1207 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1208 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1209 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1210 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1211 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1213 * src/main/java/org/glom/web/server/Utils.java:
1214 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1215 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1216 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1217 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1219 2011-11-25 Ben Konrath <ben@bagu.org>
1221 Improve Gda Value conversion from PrimaryKeyItem.
1223 The value from the PrimaryKeyItem is only used if its type match the
1224 type from the glom document.
1226 * src/main/java/org/glom/web/server/Utils.java:
1228 2011-11-25 Ben Konrath <ben@bagu.org>
1230 Manually check if the java-liblgom .so is visible to the JVM.
1232 It seems that Tomcat has problems when a static initializer throws an
1233 exception. This check is done before the first method call into
1234 java-libglom so that execution doesn't continue if the .so is not
1237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1239 2011-11-25 Ben Konrath <ben@bagu.org>
1241 Improve browser configuration error messages.
1245 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1247 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1248 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1249 getConfigurationErrorMessage() method.
1250 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1251 Get and display a specific configuration error message when no Glom
1252 documents are found.
1253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1254 Implement getConfigurationErrorMessage() method. Surround configuration
1255 code in the init() method with a try/catch block. This allows the
1256 errors to be caught while keeping the servlet available to retrieve the
1257 configuration error message.
1259 2011-11-25 Ben Konrath <ben@bagu.org>
1261 Don't use Strings to hold primary key values.
1263 The primary key values are now held in a new data object
1264 (PrimaryKeyItem) that holds type information and the primary key value
1265 using the correct type.
1267 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1268 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1270 PrimaryKeyItem instead of String to hold the primary key value.
1271 * src/main/java/org/glom/web/client/Utils.java: Remove
1272 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1273 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1274 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1275 PrimaryKeyItem instead of String to hold the primary key value. Load
1276 document selection page when the documentID has not been set correctly.
1277 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1278 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1280 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1281 Return empty string for URL instead of "null".
1282 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1283 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1284 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1285 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1286 PrimaryKeyItem instead of String to hold primary key values.
1287 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1288 PrimaryKeyValue to a Gda Value.
1289 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1290 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1291 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1292 Replace temporary database access code that uses the PrimaryKeyValue to
1293 Gda Value conversion.
1294 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1295 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1296 PrimaryKeyItem instead of String.
1297 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1298 hold primary key values.
1300 2011-11-24 Ben Konrath <ben@bagu.org>
1302 Use newly added java-libglom API to create queries.
1304 This isn't finished. I still need to stop using Strings for primary key
1305 values in the client code.
1307 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1308 libglom to use fake connections so that retrieving the query string will
1310 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1311 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1312 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1313 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1314 Use the newly added libglom sql methods and classes to create the
1315 query. Add temporary hack to convert primary value strings to Gda
1318 2011-11-23 Ben Konrath <ben@bagu.org>
1320 Don't explicitly set the height of Portals.
1322 See comments 6 - 10 of this bug for details:
1324 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1326 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1328 2011-11-23 Ben Konrath <ben@bagu.org>
1330 Use an HTML table instead of CSS for the FlowTable layout.
1332 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1333 GWT's FlexTable to implement the FlowTable.
1334 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1336 2011-11-18 Ben Konrath <ben@bagu.org>
1338 Add boolean example to HTML table mockup.
1340 * mockups/details-view-html-tables-text-entries.html:
1342 2011-11-17 Ben Konrath <ben@bagu.org>
1344 Ensure the pager buttons are always visible for related lists.
1346 To accomplish this, I've turned off text wrapping in the list view and
1347 related list tables for both the header and data text. The related list
1348 table now has a fixed layout so the it doesn't overflow its container.
1349 This is required to ensure that the cell text is clipped when it
1350 overflows the cell and an ellipsis is added to the right side of the
1351 cell when text is clipped.
1353 A fixed table layout for the related list table in the details view
1354 seems what we want for the details view anyway, so the side-effect is
1357 The ellipsis will only be displayed in Firefox >= 7.
1361 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1363 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1364 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1365 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1367 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1368 Set the 'table-layout: fixed' CSS property to the related list table.
1369 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1370 'white-space: nowrap;' CSS property on both the list view and the
1371 related list tables.
1373 2011-11-16 Ben Konrath <ben@bagu.org>
1375 Rework the fix for empty notebook tab labels.
1377 Setting the empty group titles with its name caused problems for the
1378 details layout. Instead of using libglom's
1379 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1380 to the client when the title is empty. This allows the Notebook to use
1381 the name when the title is empty without affecting anything else.
1383 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1384 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1386 2011-11-16 Ben Konrath <ben@bagu.org>
1388 Set group titles with name when title is empty.
1390 This fixes a problem with an empty notebook tab label in the Lesson
1391 Planner document. The forth tab in the notebook should be "Internet":
1393 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1395 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1396 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1399 2011-11-16 Ben Konrath <ben@bagu.org>
1401 Remove whitespace from the configured username properties.
1403 This assumes that usernames won't have whitespace at the beginning
1404 or end. But I think this is a reasonable assumption.
1406 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1407 String.trim() to remove the whitespace from the username properties.
1409 2011-11-15 Ben Konrath <ben@bagu.org>
1411 Add details view mockup with HTML tables and text entries.
1413 This is from the attachment on this bug:
1415 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1417 * mockups/details-view-html-tables-text-entries.html:
1419 2011-11-15 Ben Konrath <ben@bagu.org>
1421 Add space between the columns of the flow table.
1425 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1427 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1428 space between columns in the flow table.
1430 2011-11-15 Ben Konrath <ben@bagu.org>
1432 Add backup files to the .gitignore.
1434 * .gitignore: Ignore files that end with ~.
1436 2011-11-09 Ben Konrath <ben@bagu.org>
1438 Use latest release of gwt-log.
1440 Gwt-log releases are now being submitted to the maven central
1441 repository so manual installation of the jar is no longer required.
1443 * pom.xml: Update version and groupId of gwt-log dependency.
1445 2011-10-31 Ben Konrath <ben@bagu.org>
1447 Don't use GWT numeric formatting to override the glom currency formatting.
1449 Currencies are now displayed like they are in Glom. See this bug:
1451 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1453 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1455 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1456 currency code to constructor and set it when the cell is rendered.
1457 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1458 currency code to the constructor of the NumericCell.
1460 2011-10-27 Ben Konrath <ben@bagu.org>
1462 Require the latest release of java-libglom (1.17.4).
1466 2011-10-26 Ben Konrath <ben@bagu.org>
1468 Add style to Notebook that matches current theme.
1470 It's not the best style in the world but it's better than the default.
1472 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1473 padding at the bottom of the child widgets.
1474 * src/main/webapp/style.css: Add style for the Notebook.
1476 2011-10-26 Ben Konrath <ben@bagu.org>
1478 Move servlet initialization code to overridden init method.
1480 This is half of the solution to getting proper error messages
1481 displayed when configuration errors occur. Here's the relevant bug:
1483 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1485 The rest of the solution involves surrounding the init method with a
1486 try/catch block and setting a global variable with the error /
1487 exception. A new async method should be created to retrieve and display
1488 the error message / exception.
1490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1491 code from constructor to init method adding exceptions as needed.
1493 2011-10-26 Ben Konrath <ben@bagu.org>
1495 Add script to monitor and restart tomcat if required.
1497 * utils/check-and-recover-tomcat.py: New file.
1499 2011-10-26 Ben Konrath <ben@bagu.org>
1501 Display the correct number of data items in the pager.
1505 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1507 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1508 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1509 The implementation is the same for both tables: Keep track of the
1510 number of non-empty rows and fire and RowCountChangeEvent after the data has
1512 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1513 custom Pager class that subclasses SimplePager to handle displaying
1514 the correct number when empty rows have been added.
1516 2011-10-26 Ben Konrath <ben@bagu.org>
1518 Correct error in previous commit.
1520 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1521 eventBus parameter from listView.setCellTable().
1523 2011-10-26 Ben Konrath <ben@bagu.org>
1525 Fix error in TODO comment.
1527 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1529 2011-10-24 Ben Konrath <ben@bagu.org>
1531 Create Notebook widgets to the details view.
1533 This isn't finished just yet - I still need to create a reasonable
1534 style to match the current theme.
1536 * src/main/java/org/glom/web/client/Utils.java: Add method for
1537 calculating the height of a widget. This is used in the Notebook class.
1538 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1539 new constructor method in Group.
1540 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1541 method for creating child widget that can be used by subclasses
1542 like Notebook. New constructor that allows disabling the group
1543 titles - Notebooks don't set a group title for their child groups.
1544 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1545 to make Notebooks using GWT's TabLayoutPanel.
1546 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1547 constructor that allows disabling the group titles.
1548 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1549 LayoutItemNotebook DTO.
1550 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1551 DTO for Notebooks. It's just an empty class for now but we might need
1552 it to transfer some specific information in the future.
1554 2011-10-21 Ben Konrath <ben@bagu.org>
1556 Add navigation buttons to related list tables.
1558 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1559 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1561 method getSuitableRecordToViewDetails() for getting the table name
1562 and primary key value for related list navigation buttons.
1563 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1564 private cell renderer class to get the navigation information for
1565 related list tables from the server. Extract the navigation
1566 processing code from the details cell navigation and use it for the
1567 related list navigation as well.
1568 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1569 cell renderer class for the details open buttons. This was needed
1570 because the related list navigation buttons and the list view
1571 navigation buttons need to react differently when clicked.
1572 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1573 the onEnterKeyDown() method because it's now overriden in the
1574 subclasses that are specific to the related list tables and the list
1576 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1577 the vertical size a little because the buttons add a bit of vertical
1578 space to table. This is not a perfect solution because the vertical
1579 size of with table fewer than 5 rows will be a little smaller.
1580 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1581 changes in how navigation buttons are handled.
1582 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1583 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1584 database access object.
1585 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1586 to find the portal for a given relationship name from
1587 RelatedListDBAccess. Add method to find a primary key field for a
1589 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1590 Move code to find the portal for a given relationship name to
1592 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1593 New file: database access object for getting the related list
1594 navigation information (the table name and the primary key value).
1595 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1596 DTO for transferring a table name to navigate to and a primary key
1598 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1599 boolean and getter/setter to specifies if the related list should add
1602 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1604 Use the master branch of java-libglom
1606 * pom.xml: Depend on java-libglom 1.19 instead.
1608 This is the master branch. See also the libglom-1-18 branch.
1610 2011-10-11 Ben Konrath <ben@bagu.org>
1612 Enable the open navigation button when the data has been set.
1614 This avoids having active buttons that don't do anything when the data
1617 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1619 2011-10-11 Ben Konrath <ben@bagu.org>
1621 Use IsWidget interface for FlowTableItem.
1623 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1624 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1626 2011-10-11 Ben Konrath <ben@bagu.org>
1628 Remove GWT styling from open button in details view.
1630 There are still some issues with how the details cell is arranged but
1631 this should be made to match Glom 1.20. I'm going to leave fixing this
1632 until I have Glom 1.20 up and running.
1634 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1635 style name on open button.
1636 * src/main/webapp/style.css: Move and edit details-navigation class.
1637 Re-arrange some classes to make them appear in the same order as the
1640 2011-10-07 Ben Konrath <ben@bagu.org>
1642 Update to GWT 2.4.0.
1644 * .gitignore: Ignore new cache directory.
1645 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1646 * pom.xml: Change GWT and maven plugin to 2.4.0.
1647 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1649 * src/main/java/org/glom/web/client/ClientFactory.java:
1650 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1651 * src/main/java/org/glom/web/client/OnlineGlom.java:
1652 Update source for API changes.
1653 * utils/build-onlineglom-war.sh: Remove cache directory before the
1656 2011-10-07 Ben Konrath <ben@bagu.org>
1658 Add navigation buttons in the details view.
1660 This isn't finished but I thought I'd commit what I have as it's a
1661 pretty good start. I still need to:
1663 1. Change the style so that it fits better into the current theme
1664 2. Adjust the details cell to expand as much as possible.
1666 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1667 click handlers to navigation buttons in the DetailsCells. Create a
1668 refreshData() method to get just the data from the server without the
1670 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1671 Update the tableSelector and browser title when the table name
1672 changes without using the tableSelector.
1673 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1674 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1675 getDetailsCells() to getCells(). Update variable names.
1676 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1677 method to set click handler on navigation button. Rename a few
1678 variables. Add navigation buttons where needed.
1679 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1680 variables and methods.
1681 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1682 navigation boolean and navigation table as required in the
1683 LayoutItemField DTO.
1684 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1685 variables for navigation along with getter/setter methods.
1687 2011-10-07 Ben Konrath <ben@bagu.org>
1689 Rename Field to DetailsCell.
1691 This is a refactor-only commit. No functionality has been added or
1694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1695 Update variable and method names.
1696 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1697 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1698 variable and method names.
1699 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1701 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1702 variable and method names.
1704 2011-10-07 Ben Konrath <ben@bagu.org>
1706 Create separate methods for layout and data the details view.
1708 This is a refactor-only commit. No functionality has been added or
1711 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1712 private methods: setData(), createLayout().
1714 2011-10-07 Ben Konrath <ben@bagu.org>
1716 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1718 This is part of a change to get navigation buttons in the details view
1719 but it should have been done this way from the start.
1721 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1722 for method name change in TableSelectionView.
1723 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1724 Create TableChangeEvent and set the browser title using the
1725 TableSelectionView API.
1726 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1727 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1728 Change getSelectedTable() to getSelectedTableName(). Add
1729 getSelectedTableTitle().
1731 2011-10-07 Ben Konrath <ben@bagu.org>
1733 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1735 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1737 2011-10-07 Ben Konrath <ben@bagu.org>
1739 Update TableChangeEvent to use newTableName naming convention.
1741 This makes the class more consistent with GWT naming conventions.
1743 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1744 Update for method name change in TableChangeEvent.
1745 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1746 for method name change in TableChangeEvent.
1747 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1748 newTableName variable and getter method. Make toDebugString()
1751 2011-09-30 Ben Konrath <ben@bagu.org>
1753 Disable the pager in the list tables when the data row count is less than the minimum.
1755 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1756 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1758 2011-09-30 Ben Konrath <ben@bagu.org>
1760 Add empty rows to the end of related list and list view tables.
1762 I also extracted the cell rendering classes from the ListTable because
1763 the code was becoming a little crazy with all the anonymous inner
1764 classes. My plan is to use these cell rendering classes in the details
1765 view as well so this refactor will be needed for that change.
1767 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1768 set the row count in related list tables if the data has more rows
1769 than the minimum number of rows visible.
1770 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1771 row count in list view tables if the data has more rows than the
1772 minimum number of rows visible.
1773 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1774 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1776 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1777 for rendering TYPE_NUMERIC cells. The code was extracted from the
1779 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1780 class for rendering cells with buttons in list views. The code was
1781 extracted from the ListTable class.
1782 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1783 for rendering TYPE_TEXT cells. The code was extracted from the
1785 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1786 Add empty rows to the end of the data if required. Implement
1787 ListTable.getMinNumVisibleRows().
1788 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1789 cell renderer code to public classes. Return null in
1790 Column.getValue() for empty rows. Add new abstract method:
1791 getMinNumVisibleRows(). Move code to set the row count of the list view
1792 table to ListViewImpl.
1793 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1794 empty rows to the end of the data if required. Implement
1795 ListTable.getMinNumVisibleRows().
1798 2011-09-27 Ben Konrath <ben@bagu.org>
1800 Use GWT.log for client-side debugging statements.
1802 These are optimized out when deployed so I should have used this method
1803 in the first place. These statements will eventually be replaced with some sort
1804 of notification in the browser.
1806 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1807 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1808 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1809 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1810 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1812 2011-09-27 Ben Konrath <ben@bagu.org>
1814 Put tableselector on the right, back to list link on right.
1816 The idea is that the table selector is acting like a label for the
1817 currently displayed table so it should be placed below the document title. This
1818 puts the table title in a similar position to where it is in Glom.
1820 * mockups/details-contacts.html:
1821 * mockups/details-projects.html:
1822 * mockups/listview-contacts.html:
1823 * mockups/listview-projects.html:
1824 * mockups/style.css:
1825 Update mockups to match how the interfaces currently look.
1826 * src/main/webapp/style.css: Swap positions of backlink with the table
1827 selector. Add some space on the left side of the table selector to
1828 line things up with the document title.
1830 2011-09-27 Ben Konrath <ben@bagu.org>
1832 Add field colouring to details view.
1834 This change re-works how field colouring works. The colour formatting
1835 information is now set to the client with the layout information instead of
1836 with the data. This eliminates the need to send the same colour strings for
1837 data in list view column when colour information is set.
1839 In order to set an alternate colour for negative numeric values, the
1840 number is now sent to client and formatted with the GWT NumberFormat class.
1842 This change also fixes:
1844 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1846 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1847 internationalization framework which is needed for client side numeric
1849 * src/main/java/org/glom/web/client/Utils.java: New file for some
1850 client static utility methods.
1851 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1852 the DataItem object to the Field class. Use a utility method to
1853 create the foreignKeyValue string.
1854 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1855 alignment and text colours in the constructor. Add setData(DataItem)
1856 method. Remove setText(String) method.
1857 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1858 colour information to GlomTextCell. Create and use GlomNumberCell for
1859 rendering numbers. Use utility method to get the string for the
1860 primary key of the key provider. Re-work how the horizontal alignment
1862 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1863 formatting to layout information. Methods for converting the libglom
1864 formatting information were moved from DBAccess.
1865 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1866 numeric formatting (it's now done on the client side). Don't set text
1867 colours in DataItem. Move libglom formatting conversion methods to
1869 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1870 getters/setters for text colour information.
1871 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1872 for transferring the libglom NumericFormat information to the client.
1873 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1874 and getters/setters for: GlomNumericFormat, background colour and
1875 foreground colour strings.
1877 2011-09-26 Ben Konrath <ben@bagu.org>
1879 Simplify code that iterates through the LayoutGroup.
1881 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1883 2011-09-26 Ben Konrath <ben@bagu.org>
1885 Accept Eclipse formatting for OnlineGlomServiceAsync.
1887 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1889 2011-09-26 Ben Konrath <ben@bagu.org>
1891 Don't use the ListDBAccess classes to get the primary key layout information.
1893 This was causing a bug where the wrong index for the hidden primary key
1894 was being sent to the client.
1896 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1897 primary key while creating the LayoutGroup DTO. Create a
1898 LayoutItemField DTO for hidden primary keys. Don't use the
1899 RelatedListDBAccess because it was only used for getting the primary
1901 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1902 access modifier from public to protected for getPrimaryKeyField() and
1903 getPrimaryKeyLayoutItemField().
1904 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1905 abstract method getExpectedResultSize() because RelatedListDBAccess
1906 doesn't have enough info to implement it.
1907 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1908 Remove @Override for getExpectedResultSize().
1909 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1910 Remove method getExpectedResultSize().
1912 2011-09-23 Ben Konrath <ben@bagu.org>
1914 Log which layout (list or details) the ignored item is from.
1916 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1918 2011-09-23 Ben Konrath <ben@bagu.org>
1920 Remove annotations that turn off code formatting in DataItem.
1922 * src/main/java/org/glom/web/shared/DataItem.java:
1924 2011-09-23 Ben Konrath <ben@bagu.org>
1926 Rename GlomField to DataItem and update associated methods.
1928 This is a rename-only refactor. No functionality has been added or
1931 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1932 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1933 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1935 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1936 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1937 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1938 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1940 * src/main/java/org/glom/web/server/database/DBAccess.java:
1941 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1942 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1943 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1944 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1945 * src/main/java/org/glom/web/shared/DataItem.java:
1946 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1947 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1949 2011-09-23 Ben Konrath <ben@bagu.org>
1951 Rename GlomDocument to DocumentInfo and update associated methods.
1953 This is a rename-only refactor. No functionality has been added or
1956 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1957 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1958 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1959 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1960 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1962 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1964 2011-09-20 Ben Konrath <ben@bagu.org>
1966 Require java-libglom 1.17.3.
1968 This picks up the fix for the seg fault problem with the Scenes table
1969 in the Openismus Film Manager example.
1973 2011-09-20 Ben Konrath <ben@bagu.org>
1975 Change the way sort clause is added for primary key when no sort clause is requested.
1977 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1978 before the sort clause is created. When a sort clause is not requested, the
1979 sort clause is created by finding the primary key in the LayoutFieldVector
1982 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1984 2011-09-20 Ben Konrath <ben@bagu.org>
1986 Log error message if no documents are found in the configured directory.
1988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1989 Extract the glom file extension string to a private static final class
1990 variable (mostly as syntactic sugar). Accept a minor formatting change.
1991 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1992 the example glom.document.directory configuration property to make it
1993 more clear that it can any directory, not just the home directory.
1995 2011-09-18 Ben Konrath <ben@bagu.org>
1997 Add related lists to details view.
1999 The related list table has support for paging and sorting just like the
2000 table in the list view.
2002 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2003 SQL queries for the related list tables.
2004 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2005 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2006 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2007 Rename getList methods to getListView and add comments. Remove
2008 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2009 it being unused. Add methods: getDetailsLayoutAndData(),
2010 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2011 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2012 Create the layout and set the data for the fields in one async call
2013 instead of two. Create related lists where appropriate.
2014 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2015 for method name changes in OnlineGlomService.
2016 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2017 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2018 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2020 * src/main/java/org/glom/web/client/ui/ListView.java:
2021 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2022 tableName from setCellTable(). Create a ListViewTable instead of
2024 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2025 represent a data field in the details view.
2026 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2027 from addDetailsCell() to Field class. Keep track of the Fields and
2028 Portals in the details view.
2029 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2030 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2031 and add a method to get it. Add method to set the contents of the
2033 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2034 New class for related list tables. This class has the data provider
2035 for the related list table.
2036 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2037 abstract class which is the base class for the ListViewTable and the
2039 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2040 New class for list view tables. This class has the data provider for
2041 the list view table.
2042 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2043 methods for related list tables. Add more information to the
2044 LayoutItemField and LayoutItemPortal DTOs.
2045 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2046 Remove debugging print statement.
2047 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2048 Remove debugging print statements. Add primary key field to SQL count
2050 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2051 Remove unnecessary LayoutFieldVector parameter from
2052 getResultSizeOfSQLQuery() method.
2053 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2054 New class for related list table database access.
2055 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2056 class that is a wrapper DTO for details view layout and data.
2057 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2058 new 'fromField' string to this DTO.
2059 * src/main/webapp/style.css: Remove bottom margin and override top
2062 2011-09-15 Ben Konrath <ben@bagu.org>
2064 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2066 This sets things up to make it easier to add the data retrieval for
2067 related lists (portals). No user noticeable changes were made with
2070 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2071 class has the code to retrieve the layouts and access the
2072 database using the new database helper classes.
2073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2074 Most of the functionality has been removed from this class. This
2075 class now represents the public interface for the client side
2076 code. It also deals with configuring the servlet and cleaning
2077 things up when the servlet is stopped.
2078 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2079 of static methods into this utility class.
2080 * src/main/java/org/glom/web/server/database/DBAccess.java:
2081 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2082 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2083 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2084 These classes have the database retrieval code. The class hierarchy
2085 has been setup to make it easy to reuse code for similar
2088 2011-09-06 Ben Konrath <ben@bagu.org>
2090 Create separate classes for list table code and the data provider.
2092 As part of this refactor, I also split up the code a bit to make it
2095 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2096 table code to two new classes (below).
2097 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2098 with code from ListViewImpl.
2099 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2100 New file with code from ListViewImpl.
2102 2011-09-06 Ben Konrath <ben@bagu.org>
2104 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2106 This fixes the LayoutItemPortal DTO to match the libglom layout object
2109 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2111 2011-09-01 Ben Konrath <ben@bagu.org>
2113 Set title of Portals in the Details View.
2115 * pom.xml: Bump required version of java-libglom to 1.17.1.
2116 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2117 widget creation to its own class. Add comments to constructor.
2118 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2119 The code is mostly from the Group class with the title now set.
2120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2121 title of Portal. Update some comments. Fix some code formatting.
2123 2011-09-01 Ben Konrath <ben@bagu.org>
2125 Remove TODO comment for the flow table column width.
2127 The flow table column width is working correctly and doesn't need to be
2128 changed. See this mailing list post for more info:
2130 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2132 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2134 2011-08-27 Ben Konrath <ben@bagu.org>
2136 Add document title (database name) to top of the browser page.
2138 I added the document title to the TableSelecitonView but that will
2139 change if / when we add a view that doesn't require table selection.
2141 * mockups/details-contacts.html:
2142 * mockups/details-projects.html:
2143 * mockups/listview-contacts.html:
2144 * mockups/listview-projects.html:
2145 * mockups/style.css: Add document title to mockups to keep things
2147 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2148 sizes to account for the document title.
2149 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2150 Set the document title when it has been retrieved from the server.
2151 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2152 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2153 and implement setDocumentTitle(String) method.
2154 * src/main/webapp/style.css: Add ID for document title style.
2156 2011-08-25 Ben Konrath <ben@bagu.org>
2158 Add NavigationType enum to LayoutItemPortal DTO.
2160 This is the start of adding support for Portals to the Details View.
2162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2163 LayoutItem_Portal.navigation_type enum from libglom to
2164 LayoutItemPortal.NavigationType enum.
2165 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2166 NavigationType enum, field for storing the NavigationType and getter
2169 2011-08-25 Ben Konrath <ben@bagu.org>
2171 Implement the flow table layout in the Details View.
2173 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2174 FlowTable to Group to account for the renamed class.
2175 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2176 File. This is a container widget that implements the Glom details view
2177 flow table behaviour.
2178 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2179 org/glom/web/client/ui/FlowTable.java.
2180 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2181 so that the size of the subgroups are a closer match to the size of
2182 the Glom subgroups. This makes the flowtable layout match the layout
2183 in Glom for the Music Collection example file.
2185 2011-08-16 Ben Konrath <ben@bagu.org>
2187 Create container element for LayoutItemPortal in Details View.
2189 This will help me develop the layout for the FlowTable.
2191 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2192 fieldPanel variable to detailsCell.
2194 2011-08-15 Ben Konrath <ben@bagu.org>
2196 Set the height of the data element in the Details View.
2198 I changed the InlineLabels (text in a span element) to Labels (text in
2199 a div element) so that I could set the height of the details-data
2200 elements instead of the details-cell parent elements. This allows the
2201 the details-data element to display the correct height if style is
2202 applied that shows the height.
2204 This change has the added benefit of allowing the order of the labels
2205 and data elements to be changed for right-to-left languages.
2207 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2208 InlineLabels to Labels.
2209 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2210 InlineLabels to Labels. Set the height of the data element.
2211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2212 multiline text height in the Formatting DTO.
2213 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2214 for multiline height along with getter and setter methods.
2215 * src/main/webapp/style.css: Adjust style to account for the change
2216 from span elements to div elements in the details cell.
2218 2011-08-15 Ben Konrath <ben@bagu.org>
2220 Make the List View appearance match the mockups.
2222 It doesn't match exactly but it's much better than it was.
2224 * mockups/listview-contacts.html: Remove unused css classes.
2225 * mockups/listview-projects.html: Remove unused css classes.
2226 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2227 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2228 for mainPanel instead of VerticalPanel (table). Set style name on
2229 CellTable. Set style name on Details column. Right-align Details
2231 * src/main/webapp/style.css: Adjust properties to match the mockups.
2233 2011-08-12 Ben Konrath <ben@bagu.org>
2235 Add better support for subgroups in the details view.
2237 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2238 changed FlowTable constructor.
2239 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2240 support for subgroups and subgroup-titles.
2241 * src/main/webapp/style.css: Add CSS class for subgroups and
2244 2011-08-12 Ben Konrath <ben@bagu.org>
2246 Return the top level LayoutGroup title.
2248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2250 2011-08-11 Ben Konrath <ben@bagu.org>
2252 Make the TableSelector header match the mockup.
2254 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2255 the layout panel. Properly lineup the table selection header with
2256 the list and details view.
2257 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2258 margin around the details view.
2259 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2260 Rename listBox variable to tableSelector. Set id for the style sheet.
2261 Use a FlowPanel instead of a HorizontalPanel.
2262 * src/main/webapp/style.css: Add properties to make the TableSelector
2263 box match the mockups.
2265 2011-07-13 Ben Konrath <ben@bagu.org>
2267 Update install script for java-libglom version change.
2269 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2272 2011-07-13 Ben Konrath <ben@bagu.org>
2274 Add support sub-group in the details view.
2276 I also removed the code that special-cased the default details view
2279 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2281 I still have to make a proper flowtable.
2283 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2284 Don't special-case default details view layout.
2285 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2286 addLayoutField() as I'm going to use it.
2287 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2288 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2290 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2291 extracted from DetailsViewImpl.GroupPanel. Add support for
2293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2294 column count when getting the details layout.
2296 2011-07-12 Ben Konrath <ben@bagu.org>
2298 Set browser title with database and table titles.
2300 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2301 Set the browser title when the table changes and when the activity
2303 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2304 title when retrieving document info (the GlomDocument object).
2305 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2306 with getter and setter methods. Remove unused convenience constructor.
2307 Use default code formatting.
2309 2011-07-12 Ben Konrath <ben@bagu.org>
2311 Ignore LayoutItemPortals in the details view.
2313 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2316 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2317 LayoutItemPortal layout objects.
2318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2319 LayoutItemPortal objects when retrieving the details layout.
2320 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2321 file. This is an empty class and just used to get type information for
2324 2011-07-12 Ben Konrath <ben@bagu.org>
2326 Use java-libglom 1.17.0.
2330 2011-07-11 Ben Konrath <ben@bagu.org>
2332 Remove "Table:" label from table selector.
2334 This matches a recent change in the Glom UI.
2336 * mockups/details-contacts.html:
2337 * mockups/details-projects.html:
2338 * mockups/listview-contacts.html:
2339 * mockups/listview-projects.html: Remove the "Table:" label from the
2341 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2343 2011-07-11 Ben Konrath <ben@bagu.org>
2345 Add main groups to the details view.
2347 This makes things look a little nicer in the details view. The next step
2348 is to implement the flowtable.
2350 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2351 resources from the standard gwt css theme. Standard.css is now
2352 included in OnlineGlom.html so that the online glom css rules have
2353 precedence over the gwt theme.
2354 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2355 the whole LayoutGroup to the DetailsView instead of just the titles.
2356 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2357 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2358 details layout with a helper class (GroupPanel). I might extract this
2359 class when I make the full flowtable.
2360 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2361 string as default so I don't have to worry about NPEs when processing
2363 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2364 note beside OnlineGlom.gwt.xml above).
2365 * src/main/webapp/style.css: Add default font-size to body to override
2366 the font-size set by the standard theme. Don't use h2 tags for
2367 group-title. Create new details-cell class.
2369 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2371 ConfiguredDocument: Set the port number too.
2373 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2374 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2375 Glom document. Presumably this worked sometimes so far because there is a
2376 default port number.
2378 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2380 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2382 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2383 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2384 correct, though we should throw an exception too.
2386 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2388 Fix a addDocuemnt typo.
2390 * src/main/java/org/glom/web/shared/Documents.java
2391 (Documents.addDocuemnt): Rename to addDocument().
2392 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2393 (OnlineGlomServiceImpl.getDocuments): Adapt.
2395 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2397 Slightly improved log output when connection fails.
2399 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2400 (ConfiguredDocument.setUsernameAndPassword):
2401 We don't know for sure if it' the username/password that's wrong, so
2402 rephrase the message.
2403 Also ouput the exception message, though it's generic in this case.
2405 2011-07-08 Ben Konrath <ben@bagu.org>
2409 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2410 added braces to a one line if statement because the Eclipse formatter
2411 was getting confused.
2413 2011-07-07 Ben Konrath <ben@bagu.org>
2415 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2417 These should really be two separate tasks but I counldn't get things to
2418 work with GWT 2.2.0 and Eclipse 3.7.
2422 * .settings/org.eclipse.jdt.core.prefs:
2423 * .settings/org.eclipse.jdt.ui.prefs:
2424 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2425 * .settings/org.eclipse.m2e.core.prefs:
2426 Add new config files. Update current files. Remove references to the
2427 webtools plugins as we're not using any of the webtools features.
2428 * .gitignore: Add logs directory which is created when running with
2430 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2431 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2432 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2434 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2436 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2438 onlineglom.properties: Add explanatory comments.
2440 * src/main/resources/onlineglom.properties: Also change the default user
2441 from ben to someuser, to avoid the risk of people thinking we just
2442 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2444 2011-06-28 Ben Konrath <ben@bagu.org>
2446 Use filename in Log for incorrect passwords.
2448 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2449 getFileName(String) method to get the filename from the URI.
2451 2011-06-28 Ben Konrath <ben@bagu.org>
2453 Add the table name to the URL token for the ListPlace.
2455 This makes things consistent between the DetailsPlace and the
2456 ListPlace. It also allows the the ListPlace to be bookmarked.
2458 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2459 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2460 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2461 Remove getDefaultListLayout(). The default layout is now returned
2462 by the getListLayout() method when the table name is an empty string.
2463 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2464 Add table name field. Change to a new ListPlace when the table
2465 has been changed. Use getListLayout() for getting the default
2467 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2468 Add table name field. Set the correct table name in the list box
2469 when loading from bookmark. This corrects a problem for the
2471 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2472 Move table name to super-class (HasSelectableTable). Move document
2473 and table URL keys to super-class in HasSelectableTable.
2474 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2475 Add table name field. Add Tokenizer class with URL key common to
2476 the subclasses (DetailsPlace and ListPlace).
2477 * src/main/java/org/glom/web/client/place/ListPlace.java:
2478 Add table name. Add code to parse the URL token.
2479 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2480 Update ListPlace construction with empty table name string.
2481 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2482 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2483 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2484 Update ListPlace construction with table name string.
2485 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2486 Change defaultTableName field to tableName to reflect how it's now
2487 used. Update the getter and setter methods.
2489 2011-06-28 Ben Konrath <ben@bagu.org>
2491 Enable the table selector in the DetailsView.
2493 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2494 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2496 Remove getDefaultDetailsLayout(). The default layout is now returned
2497 by the getDetailsLayout() method when the table name is an empty
2499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2500 event handler for table change event. Change to using
2501 getDetailsLayout() for the default details layout.
2502 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2504 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2505 when navigating to the details place.
2507 2011-06-27 Ben Konrath <ben@bagu.org>
2509 Use filename based unique document ID in URL and for RPC.
2511 The document ID is the glom document name with spaces (' ') replaced
2512 with pluses ('+') and without the .glom extension.
2514 This change is mostly a string substitution of 'documentTitle' for
2515 'documentID'. The only code change is the addition of a Documents DTO to get the
2516 filename to document title mappings as indicated below.
2518 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2519 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2520 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2521 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2522 Use Documents DTO to create the document links in the document
2524 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2525 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2526 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2527 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2528 * src/main/java/org/glom/web/client/place/ListPlace.java:
2529 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2530 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2531 * src/main/java/org/glom/web/client/ui/ListView.java:
2532 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2533 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2534 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2535 * src/main/java/org/glom/web/server/Log.java:
2536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2537 getDocumentTitles() to getDocuments() and return the Documents DTO.
2538 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2539 transferring the filename to document title mappings.
2541 2011-06-25 Ben Konrath <ben@bagu.org>
2543 Make the authentication popup work again.
2545 This bug was introduced when I extracted ConfiguredDocument to its own class.
2547 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2548 correct success / fail status in setUsernameAndPassword().
2550 2011-06-25 Ben Konrath <ben@bagu.org>
2552 Use filename as unique key for configuring database usernames and passwords.
2554 This replaces the use of the Glom document title which could change
2555 depending on the locale. Thanks to Murray Cumming for pointing out this
2558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2559 * src/main/resources/onlineglom.properties:
2561 2011-06-24 Ben Konrath <ben@bagu.org>
2563 Pass primary key value to DetailsView.
2565 This enables the DetailsView to load the correct data.
2567 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2568 primary key value field and set in constructor. Pass primary key
2569 value to getDetailsData().
2570 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2571 variables for document title and primary key value.
2572 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2573 key value to the DetailsPlace.
2575 2011-06-24 Ben Konrath <ben@bagu.org>
2577 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2579 This allows the primary key to be retrieved by the Details button. This
2580 functionality has not been implemented yet but it's in the works.
2582 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2583 the LayoutGroup result to ListView.setCellTable instead of all of its
2584 fields individually.
2585 * src/main/java/org/glom/web/client/ui/ListView.java:
2586 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2587 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2588 get the primary key for the table.
2589 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2590 index of the primary key in the LayoutGroup accounting for hidden
2591 primary keys. Rename getJavaNumberFormat() to
2592 convertToJavaNumberFormat() for consistency. Cleanup / add some
2594 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2595 field for primary key index and a field to indicate whether the
2596 primary key is hidden or not.
2598 2011-06-23 Ben Konrath <ben@bagu.org>
2600 Rename getTableData methods to getListData.
2602 This is a rename refactor for consistency with other methods.
2604 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2605 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2606 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2609 2011-06-23 Ben Konrath <ben@bagu.org>
2611 Extract the ConfiguredDocument innerclass into its own class.
2613 This makes the servlet code more object oriented.
2615 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2616 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2617 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2618 new ConfiguredDocument class.
2620 2011-06-21 Ben Konrath <ben@bagu.org>
2622 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2624 This makes things more inline with how libglom works and reduces code
2625 duplication. This refactor lays the groundwork for adding the primary key to
2626 the LayoutGroup object.
2628 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2629 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2630 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2631 Change method names to getListLayout and getDefaultListLayout for
2632 consistency. Use LayoutGroup as the DTO for the list layout instead of
2633 ColumnInfo and LayoutListTable.
2634 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2635 new method names along with the LayoutGroup object for transferring the
2637 * src/main/java/org/glom/web/client/ui/ListView.java:
2638 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2639 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2640 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2642 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2643 Replaced with LayoutGroup.
2644 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2645 expectedResultSize and defaultTableName fields which are needed for
2647 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2648 type field which is needed for the list layout but will also be
2649 useful for the details layout as things progress.
2650 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2651 Make class abstract. Remove the unnecessary
2652 getFormattingHorizontalAlignment method. Add setFormatting method.
2654 2011-06-16 Ben Konrath <ben@bagu.org>
2656 Add scripts for building and installing war.
2658 These will help when updating OnlineGlom but they're also good
2659 supplemental documentation of the build and deployment proceeding.
2661 * utils/build-onlineglom-war.sh: New file.
2662 * utils/install-onlineglom-war.sh: New file.
2664 2011-06-16 Ben Konrath <ben@bagu.org>
2666 Create wrapper class to create consistent log messages.
2668 I wrapped methods in the Log class of gwt-log to add the method names
2669 from the servlet and create consistent formatting of the document title
2670 and table names in the log messages.
2672 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2674 log methods to use methods from wrapped Log class.
2676 2011-06-16 Ben Konrath <ben@bagu.org>
2678 Remove superfluous conditional return.
2680 Thanks to Murray Cumming for pointing this out!
2682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2684 2011-06-15 Ben Konrath <ben@bagu.org>
2686 Return an ArrayList of LayoutGroups for the Details layout.
2688 This corrects a problem with the details layout as it can have more
2689 than one top level LayoutGroup.
2691 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2692 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2693 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2694 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2696 with ArrayList of LayoutGroups for the details view layout.
2697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2698 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2699 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2700 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2701 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2702 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2704 2011-06-14 Ben Konrath <ben@bagu.org>
2706 Use cast_dynamic method to determine the libglom LayoutItem type.
2708 This is better than finding the LayoutItem type by using the string
2709 returned from the get_part_type_name() method.
2711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2713 2011-06-14 Ben Konrath <ben@bagu.org>
2715 Add method names to log entries in the servlet.
2717 This helps when tracking down deployment problems.
2719 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2721 2011-06-14 Ben Konrath <ben@bagu.org>
2723 Add data to the DetailsView using a hard-coded primary key value.
2725 The layout and functionality of the DetailsView is not complete. This
2726 is just a checkpoint so the patch doesn't get too big.
2728 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2729 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2730 Add getDetailsData() servlet method.
2731 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2732 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2733 LayoutFields are added to the DetailsView.
2734 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2735 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2736 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2737 take the string for the title instead of the object.
2738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2739 Add implementation getDetailsData() along with some private helper
2741 * src/main/webapp/style.css: Add padding to details-data class. Add a
2742 details-label class with the same padding as the details-data class.
2744 2011-06-03 Ben Konrath <ben@bagu.org>
2746 Use presenter.goTo() to change to the DetailsPlace.
2748 This will make things easier when we need to open the DetailsView with
2749 data specific to the row that was clicked.
2751 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2753 2011-06-02 Ben Konrath <ben@bagu.org>
2755 Add CSS file from mockups.
2757 I'm adding this now because it's going to be useful to have when
2758 developing the DetailsView. The TableSelectionView and ListView aren't
2761 * src/main/webapp/OnlineGlom.html:
2762 * src/main/webapp/style.css:
2764 2011-06-02 Ben Konrath <ben@bagu.org>
2766 Use String.isEmpty() to check for empty string.
2768 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2770 2011-06-02 Ben Konrath <ben@bagu.org>
2772 Display main layout group titles in the DetailsView.
2774 This is the start of the DetailsActivity/DetailsView implementation.
2776 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2777 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2778 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2779 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2780 Get the layout information for the details view from the server and set
2781 the main layout group titles.
2782 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2783 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2784 Add addLayoutGroup() and addLayoutField() methods. This are just
2785 temporary methods for creating the the details view that will change
2787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2788 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2790 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2791 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2792 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2793 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2794 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2795 Data Transfer Objects that mimic the libglom object structure. These are
2796 used for transferring the details layout but could also be used for
2797 transferring the list layout.
2799 2011-05-27 Ben Konrath <ben@bagu.org>
2801 Reset the AuthenticationPopup when clearing the ListView.
2803 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2805 2011-05-27 Ben Konrath <ben@bagu.org>
2807 Fix problem with onlineglom.properties file loading.
2809 The old way worked in Eclipse but not on the server. Loading the
2810 onlineglom.properties file now works in Eclipse and on the server.
2812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2814 2011-05-24 Ben Konrath <ben@bagu.org>
2816 Update gwt-log from 3.1.0 to 3.1.2.
2818 Gwt-log 3.1.0 has been marked as depreciated.
2822 2011-05-24 Ben Konrath <ben@bagu.org>
2824 Add comment to ListActivity.goTo() method.
2826 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2828 2011-05-24 Ben Konrath <ben@bagu.org>
2830 Remove FIXME in convertGdkColorToHtmlColour()
2832 The Gdk::Color value returned by libglom is 16-bits per channel on both
2833 64 and 32-bit platforms.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2837 2011-05-19 Ben Konrath <ben@bagu.org>
2839 Improve performance of initial ListView load.
2841 I removed a round trip to the server for getting the default table name
2842 and then requesting information about that table. This also removes a potential
2843 problem with the table change handler not being setup in time to receive the
2844 table change event from the ListActivity.
2846 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2847 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2848 getDefaultLayoutListTable() method. Improve comments.
2849 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2850 getDefaultLayoutListTable() method instead of firing a table change
2851 event to get the table to load.
2852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2853 implementation of getDefaultLayoutListTable() method.
2854 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2857 2011-05-19 Ben Konrath <ben@bagu.org>
2859 Override toDebugString() in TableChangeEvent.
2861 This is useful to have for debugging.
2863 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2865 2011-05-19 Ben Konrath <ben@bagu.org>
2867 Add a "Back to List" link when at the DetailsPlace.
2869 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2870 Populate the CellTable based on the selected table of the ListBox if
2871 it's set otherwise use the default table. This allows the "Back to
2873 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2874 Remove Place from constructors. Add a setPlace() method. Add
2875 goToPlace() method. Set class as presenter for TableSelectionView.
2876 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2877 Use the same TableSelectionActivity when switching between the List and
2879 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2880 Subclass the new HasSelectableTablePlace. This removes some duplicate
2882 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2883 New class to represent Places that display the TableSelectionView.
2884 * src/main/java/org/glom/web/client/place/ListPlace.java:
2885 Subclass the new HasSelectableTablePlace. This removes some duplicate
2887 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2888 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2889 Add Presenter interface. Add setBackLinkVisible() method. Add
2890 setBackLink() method.
2892 2011-05-18 Ben Konrath <ben@bagu.org>
2894 Enable the "Details" buttons.
2896 Right now only an empty details view is displayed.
2898 * src/main/java/org/glom/web/client/ClientFactory.java:
2899 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2900 Add DetailsView to ClientFactory.
2901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2902 A basic activity for the details view.
2903 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2904 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2906 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2907 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2909 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2910 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2911 unnecessary super() in constructor.
2912 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2913 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2914 really shouldn't create a new TableSelectionActivity for both the ListPlace
2915 and the DetailsPlace so this should be considered a temporary solution.
2916 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2917 New file. Represents a URL for the details view.
2918 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2919 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2920 A basic details view interface and implementation.
2921 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2922 Enable the "Details" buttons.
2924 2011-05-12 Ben Konrath <ben@bagu.org>
2926 Use a LayoutPanel with multiple display areas for main layout.
2928 This is mostly a refactor in that there are no changes from the user
2929 point of view. These changes are required so that we can swap out the list view
2930 with the details view when the user clicks the "Details" button.
2932 * src/main/java/org/glom/web/client/ClientFactory.java:
2933 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2934 OnlineGlomView. Add TableSelectionView, ListView and
2935 AuthenticationPopup.
2936 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2937 for main layout. Add display regions for main activities. Add
2938 activity manager for for main activities.
2939 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2940 file from parts of the deleted OnlineGlomActivity.
2941 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2942 New file from parts of the deleted OnlineGlomActivity.
2943 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2944 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2945 New files for app wide table change event.
2946 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2947 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2948 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2949 Activity mappers for the main activities replace the deleted app-wide
2951 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2952 Fix a spelling error in he comment.
2953 * src/main/java/org/glom/web/client/ui/ListView.java:
2954 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2955 Renamed from LayoutListView and modified for MVP. This still not a
2956 proper dumb view as prescribed by the MVP pattern but it works for now.
2957 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2958 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2959 New widget stripped out of the deleted OnlineGlomView.
2960 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2961 Remove hack that is fixed by this patch.
2963 2011-05-06 Ben Konrath <ben@bagu.org>
2965 Rename OnlineGlomPlace to ListPlace.
2967 The only change besides the rename is that url will now display #list
2968 instead of #Document.
2970 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2971 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2972 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2973 * src/main/java/org/glom/web/client/place/ListPlace.java:
2974 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2976 2011-05-06 Ben Konrath <ben@bagu.org>
2978 Use Presenter for app navigation.
2980 This is the proper way to deal with Place (URL) changes with the MVP
2983 * src/main/java/org/glom/web/client/ClientFactory.java:
2984 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2985 PlaceHistoryMapper and PlaceHistoryHandler.
2986 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2987 PlaceHistoryMapper and PlaceHistoryHandler.
2988 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2989 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2990 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2991 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2992 Add Presenter interface and setPresenter methods. Rename addHyperLink
2993 to addDocumentLink taking only the document title as a parameter.
2995 2011-04-14 Ben Konrath <ben@bagu.org>
2997 Prompt for db username/password if they haven't been set.
2999 This is implemented with a popup widget that is contained within the
3000 OnlineGlomView and managed by the OnlineGlomActivity.
3002 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3003 methods for checking and setting the database username and password.
3004 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3005 new methods for checking and setting the database username and
3007 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3008 Display authentication popup if the JDBC connection to the database
3009 has not been authenticated.
3010 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3012 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3013 for dealing with the authentication popup.
3014 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3015 Implement the methods for dealing with the authentication popup.
3016 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3017 try to executed queries if the database connection hasn't been
3018 authenticated. Implement methods for checking and setting the
3019 database username and password.
3021 2011-04-12 Ben Konrath <ben@bagu.org>
3023 Make log messages a little clearer.
3025 Add a dash betweeen the document title and the table name.
3027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3029 2011-04-12 Ben Konrath <ben@bagu.org>
3031 Protect against NPEs when cleaning up database resources.
3033 While this isn't strictly necessary because the exception is caught,
3034 not protecting against the NPEs makes it harder to find the real error
3037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3039 2011-04-12 Ben Konrath <ben@bagu.org>
3041 Move configuration of the servlet to the constructor.
3043 The servlet will be initialized even if the database authentication
3044 information is not set or correct. I still need to add the UI for prompting
3045 the user for the authentication information when it's required.
3047 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3048 javadocs for getDocumentTitles() method.
3049 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3050 Set error message when RPC fails.
3051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3052 glom files directory from the configuration file. Try to set the
3053 database authentication information for the specific document if it's
3054 set and works otherwise try to use the global authentication
3055 information set for the directory.
3056 * src/main/resources/onlineglom.properties: Moved from
3057 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3058 Added detailed comments for the new keys.
3060 2011-04-11 Ben Konrath <ben@bagu.org>
3062 Remove unnecessary @Override in DocumentSelectionViewImpl.
3064 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3066 2011-04-11 Ben Konrath <ben@bagu.org>
3068 Remove center alignment in DocumentSelectionView.
3070 The title element is still centred but the document titles and bottom
3071 sentence are both left-aligned.
3073 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3075 2011-04-11 Ben Konrath <ben@bagu.org>
3077 Change 'Demo' naming convention to 'Document'.
3079 This is just a rename refactor with no functional changes to the code.
3081 * src/main/java/org/glom/web/client/ClientFactory.java:
3082 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3083 * src/main/java/org/glom/web/client/OnlineGlom.java:
3084 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3085 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3086 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3087 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3088 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3089 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3090 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3091 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3092 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3095 2011-04-08 Ben Konrath <ben@bagu.org>
3097 Remove FIXME from safeLongToInt() method.
3099 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3104 2011-04-08 Ben Konrath <ben@bagu.org>
3106 Display an error if no glom documents are found in the specified directory.
3108 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3109 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3110 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3113 2011-04-08 Ben Konrath <ben@bagu.org>
3115 Add copyright header to one more file ... oops.
3117 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3119 2011-04-08 Ben Konrath <ben@bagu.org>
3121 Add copyright header to files without it.
3123 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3124 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3125 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3126 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3127 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3128 * src/main/java/org/glom/web/shared/GlomField.java:
3130 2011-04-08 Ben Konrath <ben@bagu.org>
3132 Add support for accessing multiple glom documents in the servlet.
3134 This completes the demo selection functionality.
3136 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3137 document title to methods.
3138 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3139 document title to methods.
3140 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3141 Set browser window title when the activity starts. Correct name of
3142 document title variable.
3143 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3144 Set browser window title when the activity starts. Set the table
3145 selector change handler after table selector has been set. Clear the
3146 OnlineGlomView when the activity has been stopped.
3147 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3148 document title as the place token. Use "#Document:" instead of
3149 "#OnlineGlomPlace:" in the URL.
3150 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3151 Change heading to "Online Glom"
3152 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3153 document title in RPC methods.
3154 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3155 setDocumentTitle() method. Add clear() method.
3156 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3157 setDocumentTitle() method. Implement clear() method which removes the
3158 change handler on the ListBox, clears the ListBox and clears the
3160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3161 Implement methods with document title. Keep track for the configured
3162 glom documents and their corresponding JDBC configurations in a hash
3163 table. This information is retrieved using the document title as the
3164 key in the hash table.
3165 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3166 document title field as it's no longer needed.
3168 2011-04-08 Ben Konrath <ben@bagu.org>
3170 Update the Eclipse JDT configuration.
3172 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3173 methods. Automatically add the copyright header to new files.
3175 2011-04-05 Ben Konrath <ben@bagu.org>
3177 Add new page for demo selection.
3179 This patch adds all the components required to view and start an
3180 OnlineGlom demo by clicking on the desired hyperlink. The user is
3181 able to return to the demo selection page with the browser's back
3182 button. I still need to modify the servlet to work with multiple
3183 documents so all demo links will load the file defined in the
3184 OnlineGlom.properties.
3186 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3187 This is only useful during development so we don't need to save it.
3188 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3189 get a reference to the DemoSelectionView.
3190 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3191 method to get a reference to the DemoSelectionView.
3192 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3193 default view to DemoSelectionView.
3194 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3195 to get glom document titles for glom files in a hard-coded directory.
3196 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3197 method to get glom document titles for glom files in a hard-coded
3199 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3200 Presenter for DemoSelectionView.
3201 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3202 for DemoSelectionView.
3203 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3204 Update for DemoSelectionView.
3205 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3206 Basic 'Place' implementation for the DemoSelectionView.
3207 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3208 The interface for the DemoSelectionView.
3209 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3210 The implementation of the DemoSelectionView.
3211 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3212 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3214 implementation of method to get glom document titles for glom files
3215 in a hard-coded directory.
3216 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3217 on longer being used.
3218 * src/main/webapp/glom.png: Glom logo.
3220 2011-04-05 Ben Konrath <ben@bagu.org>
3222 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3224 This is the forth and final commit of a refactor that will allow
3225 OnlineGlom to be used with multiple documents.
3227 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3228 Move RPC code from OnlineGlomViewImpl to this class.
3229 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods