1 2012-01-02 Murray Cumming <murrayc@murrayc.com>
3 pom.xml: Mention the LGPL license.
5 * pom.xml: Add a licenses section.
6 * COPYING.LESSER: Move this to COPYING, which
7 previously contained the GPL. But gwt-glom is all LGPL.
9 2012-01-02 Murray Cumming <murrayc@murrayc.com>
11 Add project information to README and pom.xml.
13 * README: Add a brief description and mention some mvn
15 * pom.xml: This extra information shows up in mvn site
18 2011-01-02 Murray Cumming <murrayc@murrayc.com>
20 Use the latest java-libglom version.
22 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
24 2012-01-01 Murray Cumming <murrayc@murrayc.com>
26 GwtTestOnlineGlom: Test a little more.
28 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
29 protected rather than private, as suggested by the gwt-test-utils
31 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
32 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
33 Test the initial visibility of the panels.
35 However, this is not a very useful test.
36 And I wonder how we should generally test using this idea for an
37 activity/places app like ours where the real changes happen implicitly
38 based on the history token/URL.
40 2012-01-01 Murray Cumming <murrayc@murrayc.com>
42 Slight modification to *Mapper comments.
44 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
46 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
48 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
50 Remove comments mentioning GIN because they are just copied from
51 the example code and are apparently not helpful:
52 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
53 Also change the mention of a class that is only in the example code.
55 2012-01-01 Murray Cumming <murrayc@murrayc.com>
57 GwtTestOnlineGlom test: Minor changes.
59 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
60 Avoid the long qualified class name and modify the comment
61 because it is now obvious to me that the mocked class is the only
62 custom one created via GWT.create().
64 2012-01-01 Murray Cumming <murrayc@murrayc.com>
66 Tests: Added the beginnings of a test using gwt-test-utils.
68 * pom.xml: Add dependencies on gwt-test-utils and easymock.
69 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
70 which tells gwt-test-utils what class will be tested.
71 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
72 Add a simple (but empty) test case. One class, used by the OnlineGlom
73 class, is mocked so that it can be created. However, I am not sure
74 why only this class needs to be mocked.
76 Note that mockito seems more popular, and clearer, than easymock,
77 but I have not got that working yet. It might be a matter of the
80 This test is run during mvn integration-test.
82 2011-12-31 Murray Cumming <murrayc@murrayc.com>
84 Tests: Use junit4-style syntax instead of junit3-style.
86 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
87 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
88 * src/test/java/org/glom/web/shared/DataItemTest.java:
89 Use the @Test annotation rather than relying on the test*() prefix.
90 Also no longer implement TestCase, to avoid triggering support for
91 the junit3-way, which stops the annotations from working.
92 Change the imports from import junit.framework.* to
93 import org.junit.*, which is apparently the new way.
95 2011-12-31 Murray Cumming <murrayc@murrayc.com>
97 Added a test for ListPlace token parsing and creation.
99 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
100 This is much the same as DetailsPlaceTest.
102 I wonder how we could test the other parts of the *Place API.
104 2011-12-30 Murray Cumming <murrayc@murrayc.com>
106 DetailsPlace test: Also test getToken() and recreation via getPlace().
108 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
109 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
110 recreate it, testing the recreated DetailsPlace for the same parameter
113 2011-12-30 Murray Cumming <murrayc@murrayc.com>
115 Use the surefire-report plugin.
117 * pom.xml: This generates a HTML report about the tests in
118 target/site/surefire-report.html
119 when you do mvn surefire-report:report. It seems to be popular/normal.
121 2011-12-30 Murray Cumming <murrayc@murrayc.com>
123 Added a test for DetailsPlace.
125 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
126 Test the getPlace() token parsing.
128 2011-12-30 Murray Cumming <murrayc@murrayc.com>
130 Added a first unit test.
132 * pom.xml: Add a test goal, and a dependency on junit in that scope.
133 * src/test/java/org/glom/web/shared/DataItemTest.java:
134 This is a silly test but it is just to get things started. Note that
135 maven/junit finds the test because it looks in src/test by default.
137 2011-12-22 Ben Konrath <ben@bagu.org>
139 Change charsetName to "UTF-8" when replacing line breaks.
141 JavaScript requires the charsetName to be "UTF-8". CharsetName values
142 that work in Java (such as "UTF8") will not work when compiled to
145 This fixes a problem with multi-line details view fields that have hard
146 line breaks. The "License Text" field on this page demonstrates the
149 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
151 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
153 2011-12-22 Ben Konrath <ben@bagu.org>
155 Fix another bug with related list navigation.
157 I've tested all the navigation buttons in all of the related lists
158 so things should be good now.
160 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
162 2011-12-22 Ben Konrath <ben@bagu.org>
164 Fix a crasher when refreshing the list view with the default table.
166 This crash will also happen when loading the list view with the default
167 table from a link or bookmark.
169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
170 to the main document selection page when the document id hasn't been
172 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
173 the main document selection page when the document id hasn't been
175 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
176 values for the details place when the document id hasn't been set.
177 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
178 values for the list place when the document id hasn't been set.
180 2011-12-21 Ben Konrath <ben@bagu.org>
182 Protect against NPE when glom.document.locale is not in config.
184 This patch protects against an NPE when glom.document.locale is not in
185 the config file. This NPE will also happen if glom.document.locale is
188 The patch also updates the error message to display the class name when
189 the getMessage() returns null. This was happening when the NPE was
190 thrown and I had "Configuration Error: null". If an NPE is encountered
191 with this patch, "Configuration Error: NullPointerException " will be
194 This commit closes this bug:
196 https://bugzilla.gnome.org/show_bug.cgi?id=666669
198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
200 2011-12-20 Murray Cumming <murrayc@murrayc.com>
202 Rename onlineglom.properties to onlineglom.properties.sample.
204 * src/main/resources/onlineglom.properties: Rename to:
205 * src/main/resources/onlineglom.properties.sample:
206 * src/main/resources/README: And add this file explaining that people
207 should rename it back when deploying.
209 2011-12-20 Murray Cumming <murrayc@murrayc.com>
211 Allow choosing the translation in the .properties file.
213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
214 init(): Read a glom.document.locale value from the configuration file
215 and call Glom's TransatableItem::set_current_locale() method.
216 * src/main/resources/onlineglom.properties: Add a commented-out
217 example of this new setting.
219 It would be better to add &lang=de_DE to the URL, but the current
220 libglom API does not allow us to do this easily. I am working on that.
222 2011-12-19 Murray Cumming <murrayc@murrayc.com>
224 Avoid a crash in parsing of token parameters.
226 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
227 ava: getTokenParams(): Do not crash if a parameter has a key but no
228 value, and ignore parameters with neither.
230 2011-12-17 Murray Cumming <murrayc@murayc.com>
232 History token building/handling: Improve use of token parameters.
234 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
235 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
236 and buildParamsToken(HashMap), for use by derived classes.
237 Make the separator private because it is no longer be needed.
238 * src/main/java/org/glom/web/client/place/DetailsPlace.java
239 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
240 instead of manual string concatenation.
241 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
242 of hardcoded indices and awkward splitting code.
243 * src/main/java/org/glom/web/client/place/ListPlace.java
244 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
245 instead of manual string concatenation.
246 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
247 of hardcoded indices and awkward splitting code.
248 This should fix bug #666420
250 2011-12-16 Murray Cumming <murrayc@murrayc.com>
252 Fix a Navgiation->Navigation typo in the code.
254 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
255 Rename processNavgiation() to processNavigation().
257 2011-12-16 Murray Cumming <murrayc@murrayc.com>
259 Fix a seperator->separator typo in the code.
261 * src/main/java/org/glom/web/client/place/DetailsPlace.java
262 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
263 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
266 2011-12-15 Ben Konrath <ben@bagu.org>
268 Cleanup some comments.
270 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
272 2011-12-14 Ben Konrath <ben@bagu.org>
274 Replace \n with <br/> for multiline text in the details view.
276 Vertical scrollbars are added when needed as well.
278 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
280 2011-12-14 Ben Konrath <ben@bagu.org>
282 Specify the font for document selection links.
284 * src/main/webapp/style.css:
286 2011-12-14 Ben Konrath <ben@bagu.org>
288 Fix bouncy CellTable while paging.
290 This doesn't currently work with related list tables in unselected
293 * src/main/java/org/glom/web/client/ui/list/ListTable.java
295 2011-12-14 Ben Konrath <ben@bagu.org>
297 Revamp the appearance of the document selection page.
299 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
300 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
301 * src/main/webapp/style.css:
303 2011-12-13 Ben Konrath <ben@bagu.org>
305 Set navigation button column to the smallest size possible.
307 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
309 2011-12-13 Ben Konrath <ben@bagu.org>
311 Change OpenButton nomenclature to NavigationButton.
313 Using NavigtionButton makes things more generic. Classes, methods and
314 variables have been changed.
316 This is a rename-only refactor.
318 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
319 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
320 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
321 Renamed from OpenButtonCell.
322 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
323 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
324 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
326 2011-12-12 Ben Konrath <ben@bagu.org>
328 Remove unnecessary String argument in RelatedListTable and ListViewTable.
330 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
331 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
332 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
333 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
335 2011-12-12 Ben Konrath <ben@bagu.org>
337 Update variable names and comments.
339 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
340 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
342 2011-12-12 Ben Konrath <ben@bagu.org>
344 Properly initialize numNonEmptyRows variable to zero.
346 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
347 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
349 2011-12-05 Ben Konrath <ben@bagu.org>
351 Add latest mockup with HTML tables.
353 Features of this mockup:
355 -> HTML table for flowtable
356 -> HTML table for flowtable column
357 -> Example of how related lists would look
358 -> Not using text entries for data items
360 The current version of Online Glom doesn't use HTML tables for the
363 This mockup has been sent to the glom-devel mailing list but it's good
364 to have it here as well.
366 * mockups/details-view-html-tables.html:
368 2011-12-05 Ben Konrath <ben@bagu.org>
370 Remove unnecessary getPrimaryKeyField() method.
372 getPrimaryKeyFieldForTable(String) has been renamed to
373 getPrimaryKeyField(String).
375 * src/main/java/org/glom/web/server/database/DBAccess.java:
376 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
377 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
379 2011-12-05 Ben Konrath <ben@bagu.org>
381 Add string representation of TypedDataItem value to conversion error message.
383 * src/main/java/org/glom/web/server/Utils.java: Logging the error
384 message was extracted into its own method to avoid duplication.
386 2011-12-05 Ben Konrath <ben@bagu.org>
388 Add type checking to navigation primary key value creation.
390 Create navigation primary key only if the expected type from the Glom
391 document matches the type returned by the SQL query.
393 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
395 2011-12-05 Ben Konrath <ben@bagu.org>
397 Rename a couple of variables in RelatedListNavigation.
399 This is a rename-only refactor.
401 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
403 2011-12-05 Ben Konrath <ben@bagu.org>
405 Move getListLayoutGroup() into getListViewLayoutGroup().
407 This removes getListLayoutGroup(). It was only being called by
408 getListViewLayoutGroup().
410 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
412 2011-12-05 Ben Konrath <ben@bagu.org>
414 Remove check for LayoutItem_Portal in list table method.
416 This check is no longer necessary because the method isn't being used
417 to create the LayoutItemPortal DTO.
419 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
421 2011-12-05 Ben Konrath <ben@bagu.org>
423 Properly support related list navigation.
425 Navigation from the "Repository Analyzer -> Package Scans ->
426 Dependencies" related table wasn't working because the primary key for
427 related tables wasn't being set properly. This commit fixes the
430 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
431 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
432 doesn't set the primary key properly for related list tables.
433 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
434 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
435 useful for getting the primary key for list view tables and for related
437 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
438 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
439 Move code to set the primary key for the table from the abstract
440 ListDBAccess class to ListViewDBAccess as it's only correct for list
442 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
443 Properly add primary key to related list tables.
445 2011-12-02 Ben Konrath <ben@bagu.org>
447 Properly set the horizontal alignment of fields.
449 This fix is for both the list tables and the details view.
451 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
452 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
453 to set the horizontal alignment of fields.
455 2011-12-02 Ben Konrath <ben@bagu.org>
457 Display currency codes in the details view.
459 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
461 2011-12-02 Ben Konrath <ben@bagu.org>
463 Avoid duplicate JNI call.
465 JNI is not as efficient as pure Java and this is an easy (and small)
468 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
469 Use previously retrieved value for whereClauseToTableName instead of
472 2011-12-02 Ben Konrath <ben@bagu.org>
474 Rename a couple of variables in RelatedListNavigation.
476 This is a rename-only refactor.
478 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
480 2011-12-02 Ben Konrath <ben@bagu.org>
482 Indicate clearly that a mismatched primary key type is a bug.
484 * src/main/java/org/glom/web/server/Utils.java: Change log level from
485 warning to error. Add 'This is a bug.' to message.
487 2011-12-02 Ben Konrath <ben@bagu.org>
489 Update / fix some comments.
491 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
493 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
495 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
496 Fix comments. Add some TODOs.
498 2011-12-02 Ben Konrath <ben@bagu.org>
500 Enable navigation to details view with string primary key from related list.
502 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
503 Create a text primary key value when return type of result is
504 java.sql.Types.VARCHAR.
506 2011-12-02 Ben Konrath <ben@bagu.org>
508 Use checkboxes for booleans in the details view.
510 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
512 2011-12-01 Ben Konrath <ben@bagu.org>
514 Improve performance of related list height calculation.
516 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
517 Put code to calculate the expected height in a static initializer so
518 that that it's only called once.
520 2011-12-01 Ben Konrath <ben@bagu.org>
522 Show related list tables in notebooks (again).
524 Calculate the height of the related list tables so the Notebook can be
525 set the correct height. The height of the related list table is also needed by
526 FlowTable to be able decide how to create the layout.
528 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
529 and set the Portal height based on the height of the related list
530 table and the Portal container.
531 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
532 Add method to calculate the height of the related list tables.
533 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
534 * src/main/webapp/style.css: Add css class for Pager. This is needed to
535 calculate the height of the Pager widget.
537 2011-12-01 Ben Konrath <ben@bagu.org>
539 Use CellTable API for table property instead of setting style on Element.
541 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
543 2011-12-01 Ben Konrath <ben@bagu.org>
545 Make ListViewTable and RelatedListTable a consistent height.
547 The tables are now a consistent height regardless of the contents of
548 the table. A hidden button is added to empty rows to ensure that the
549 height of these rows will match the height of rows with data.
551 A navigation button column is now added to every table. The width of
552 the navigation column is set to 0px when a RelatedListTable shouldn't
553 have navigation buttons. This maintains the a consistent row height in
554 tables that don't show the navigation buttons.
556 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
557 navigation column when not needed.
558 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
559 arguments for navigation button to constructor of ListViewTable.
560 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
561 hidden button for empty data rows.
562 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
563 arguments for navigation button to constructor.
564 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
565 create navigation buttons. Add hideNavigationButtons() method.
566 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
567 arguments for navigation button to constructor.
569 2011-12-01 Ben Konrath <ben@bagu.org>
571 Use 'visibility: hidden' in Utils.getWidgetHeight().
573 This is better choice because hidden elements are invisible, don't
574 respond to events and are not part of the tab order. They will,
575 however, take up space which is required to be able to calculate the
576 height of the widget.
578 * src/main/java/org/glom/web/client/Utils.java:
580 2011-12-01 Ben Konrath <ben@bagu.org>
582 Use Utils.getWidgetHeight() in FlowTable.
584 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
586 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
588 2011-12-01 Ben Konrath <ben@bagu.org>
590 Put the details css class name on the correct table column.
592 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
594 2011-11-30 Ben Konrath <ben@bagu.org>
596 Update for java-libglom API change.
598 The getters and setters on FieldFormatting and NumericFormat were
599 changed to remove the 'M'.
601 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
603 2011-11-29 Ben Konrath <ben@bagu.org>
605 Only allow RelatedListTables in Portals.
607 * src/main/java/org/glom/web/client/ui/details/Portal.java:
609 2011-11-29 Ben Konrath <ben@bagu.org>
611 Only create a contents panel for Portals when title is being set.
613 * src/main/java/org/glom/web/client/ui/details/Portal.java:
615 2011-11-29 Ben Konrath <ben@bagu.org>
617 Set TabLayoutPanel height based on calculated height its widgets.
619 This is a potential fix for this bug:
621 https://bugzilla.gnome.org/show_bug.cgi?id=665133
623 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
625 2011-11-29 Ben Konrath <ben@bagu.org>
627 Align details field labels and data with the Open buttons.
629 * src/main/webapp/style.css:
631 2011-11-29 Ben Konrath <ben@bagu.org>
633 Remove unnecessary <div> in the Notebook widget.
635 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
636 method to get container FlowPanel (<div>).
637 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
638 initWidget() method directly on the TabLayoutPanel widget instead of
639 Group's container widget.
641 2011-11-29 Ben Konrath <ben@bagu.org>
643 Don't add group titles for Portals in Notebooks.
645 This reverts the previous patch and fixes a bug I introduced with
646 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
648 * src/main/java/org/glom/web/client/ui/details/Group.java:
649 * src/main/java/org/glom/web/client/ui/details/Portal.java:
651 2011-11-28 Ben Konrath <ben@bagu.org>
653 Remove unused boolean argument in Portal constructor.
657 * src/main/java/org/glom/web/client/ui/details/Group.java:
658 * src/main/java/org/glom/web/client/ui/details/Portal.java:
660 2011-11-28 Ben Konrath <ben@bagu.org>
662 Remove hack for glom 1.18 style glom files.
664 * src/main/java/org/glom/web/client/ui/details/Group.java:
665 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
666 * src/main/java/org/glom/web/client/ui/details/Portal.java:
668 2011-11-28 Ben Konrath <ben@bagu.org>
670 Use Gda Value version of primary key to log result too large error.
672 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
674 2011-11-28 Ben Konrath <ben@bagu.org>
676 Don't use TypedDataItem.getText() for Unknown types from the URL.
678 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
679 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
680 instead of getText().
681 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
682 String field and getUnknown() method.
684 2011-11-28 Ben Konrath <ben@bagu.org>
686 Log an error message when the java-libglom .so is not present.
688 The error message was being set in the exception but not logged.
690 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
692 2011-11-28 Ben Konrath <ben@bagu.org>
694 Ignore LayoutItem_CalendarPortals.
696 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
697 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
699 2011-11-28 Ben Konrath <ben@bagu.org>
701 Extract method for creating the LayoutItemPortal DTO.
703 Just breaking the code up into smaller chunks.
705 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
707 2011-11-28 Ben Konrath <ben@bagu.org>
711 This should have been added with the refactor. Oops!
713 * src/main/java/org/glom/web/shared/TypedDataItem.java:
715 2011-11-28 Ben Konrath <ben@bagu.org>
717 Create primary key value from URL string using type from Glom document.
719 See this bug, comments 19 - 25:
721 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
723 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
724 create a TypeDataItem for the primary key here when loading from a
725 URL. Show the same string for the primary key value as was received
726 from the URL string (when loading from a URL).
727 * src/main/java/org/glom/web/server/Utils.java: Update method for
728 creating the Gda Value from the TypeDataItem to properly deal with
729 creating a Gda Value based on the Glom document type for the primary
730 key value string when loading from a URL.
731 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
732 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
733 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
734 Update for changed method name.
736 2011-11-27 Ben Konrath <ben@bagu.org>
738 Rename PrimaryKeyItem to TypedDataItem.
740 The name PrimaryKeyItem suggests what the class should be used for.
741 TypedDataItem is a neutral name that describes the class better.
743 This is a rename-only refactor.
745 * src/main/java/org/glom/web/client/OnlineGlomService.java:
746 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
747 * src/main/java/org/glom/web/client/Utils.java:
748 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
749 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
750 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
751 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
752 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
753 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
755 * src/main/java/org/glom/web/server/Utils.java:
756 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
757 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
758 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
759 * src/main/java/org/glom/web/shared/NavigationRecord.java:
761 2011-11-25 Ben Konrath <ben@bagu.org>
763 Improve Gda Value conversion from PrimaryKeyItem.
765 The value from the PrimaryKeyItem is only used if its type match the
766 type from the glom document.
768 * src/main/java/org/glom/web/server/Utils.java:
770 2011-11-25 Ben Konrath <ben@bagu.org>
772 Manually check if the java-liblgom .so is visible to the JVM.
774 It seems that Tomcat has problems when a static initializer throws an
775 exception. This check is done before the first method call into
776 java-libglom so that execution doesn't continue if the .so is not
779 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
781 2011-11-25 Ben Konrath <ben@bagu.org>
783 Improve browser configuration error messages.
787 https://bugzilla.gnome.org/show_bug.cgi?id=662792
789 * src/main/java/org/glom/web/client/OnlineGlomService.java:
790 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
791 getConfigurationErrorMessage() method.
792 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
793 Get and display a specific configuration error message when no Glom
795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
796 Implement getConfigurationErrorMessage() method. Surround configuration
797 code in the init() method with a try/catch block. This allows the
798 errors to be caught while keeping the servlet available to retrieve the
799 configuration error message.
801 2011-11-25 Ben Konrath <ben@bagu.org>
803 Don't use Strings to hold primary key values.
805 The primary key values are now held in a new data object
806 (PrimaryKeyItem) that holds type information and the primary key value
807 using the correct type.
809 * src/main/java/org/glom/web/client/OnlineGlomService.java:
810 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
812 PrimaryKeyItem instead of String to hold the primary key value.
813 * src/main/java/org/glom/web/client/Utils.java: Remove
814 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
815 PrimaryKeyItem based on the GlomFieldType and the DataItem.
816 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
817 PrimaryKeyItem instead of String to hold the primary key value. Load
818 document selection page when the documentID has not been set correctly.
819 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
820 DetailsPlace -> URL and URL -> DetailsPlace conversion with
822 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
823 Return empty string for URL instead of "null".
824 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
825 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
826 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
827 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
828 PrimaryKeyItem instead of String to hold primary key values.
829 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
830 PrimaryKeyValue to a Gda Value.
831 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
832 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
833 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
834 Replace temporary database access code that uses the PrimaryKeyValue to
835 Gda Value conversion.
836 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
837 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
838 PrimaryKeyItem instead of String.
839 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
840 hold primary key values.
842 2011-11-24 Ben Konrath <ben@bagu.org>
844 Use newly added java-libglom API to create queries.
846 This isn't finished. I still need to stop using Strings for primary key
847 values in the client code.
849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
850 libglom to use fake connections so that retrieving the query string will
852 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
853 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
854 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
855 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
856 Use the newly added libglom sql methods and classes to create the
857 query. Add temporary hack to convert primary value strings to Gda
860 2011-11-23 Ben Konrath <ben@bagu.org>
862 Don't explicitly set the height of Portals.
864 See comments 6 - 10 of this bug for details:
866 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
868 * src/main/java/org/glom/web/client/ui/details/Portal.java:
870 2011-11-23 Ben Konrath <ben@bagu.org>
872 Use an HTML table instead of CSS for the FlowTable layout.
874 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
875 GWT's FlexTable to implement the FlowTable.
876 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
878 2011-11-18 Ben Konrath <ben@bagu.org>
880 Add boolean example to HTML table mockup.
882 * mockups/details-view-html-tables-text-entries.html:
884 2011-11-17 Ben Konrath <ben@bagu.org>
886 Ensure the pager buttons are always visible for related lists.
888 To accomplish this, I've turned off text wrapping in the list view and
889 related list tables for both the header and data text. The related list
890 table now has a fixed layout so the it doesn't overflow its container.
891 This is required to ensure that the cell text is clipped when it
892 overflows the cell and an ellipsis is added to the right side of the
893 cell when text is clipped.
895 A fixed table layout for the related list table in the details view
896 seems what we want for the details view anyway, so the side-effect is
899 The ellipsis will only be displayed in Firefox >= 7.
903 https://bugzilla.gnome.org/show_bug.cgi?id=662930
905 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
906 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
907 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
909 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
910 Set the 'table-layout: fixed' CSS property to the related list table.
911 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
912 'white-space: nowrap;' CSS property on both the list view and the
915 2011-11-16 Ben Konrath <ben@bagu.org>
917 Rework the fix for empty notebook tab labels.
919 Setting the empty group titles with its name caused problems for the
920 details layout. Instead of using libglom's
921 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
922 to the client when the title is empty. This allows the Notebook to use
923 the name when the title is empty without affecting anything else.
925 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
926 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
928 2011-11-16 Ben Konrath <ben@bagu.org>
930 Set group titles with name when title is empty.
932 This fixes a problem with an empty notebook tab label in the Lesson
933 Planner document. The forth tab in the notebook should be "Internet":
935 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
937 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
938 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
941 2011-11-16 Ben Konrath <ben@bagu.org>
943 Remove whitespace from the configured username properties.
945 This assumes that usernames won't have whitespace at the beginning
946 or end. But I think this is a reasonable assumption.
948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
949 String.trim() to remove the whitespace from the username properties.
951 2011-11-15 Ben Konrath <ben@bagu.org>
953 Add details view mockup with HTML tables and text entries.
955 This is from the attachment on this bug:
957 https://bugzilla.gnome.org/show_bug.cgi?id=663109
959 * mockups/details-view-html-tables-text-entries.html:
961 2011-11-15 Ben Konrath <ben@bagu.org>
963 Add space between the columns of the flow table.
967 https://bugzilla.gnome.org/show_bug.cgi?id=662918
969 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
970 space between columns in the flow table.
972 2011-11-15 Ben Konrath <ben@bagu.org>
974 Add backup files to the .gitignore.
976 * .gitignore: Ignore files that end with ~.
978 2011-11-09 Ben Konrath <ben@bagu.org>
980 Use latest release of gwt-log.
982 Gwt-log releases are now being submitted to the maven central
983 repository so manual installation of the jar is no longer required.
985 * pom.xml: Update version and groupId of gwt-log dependency.
987 2011-10-31 Ben Konrath <ben@bagu.org>
989 Don't use GWT numeric formatting to override the glom currency formatting.
991 Currencies are now displayed like they are in Glom. See this bug:
993 https://bugzilla.gnome.org/show_bug.cgi?id=646216
995 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
997 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
998 currency code to constructor and set it when the cell is rendered.
999 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1000 currency code to the constructor of the NumericCell.
1002 2011-10-27 Ben Konrath <ben@bagu.org>
1004 Require the latest release of java-libglom (1.17.4).
1008 2011-10-26 Ben Konrath <ben@bagu.org>
1010 Add style to Notebook that matches current theme.
1012 It's not the best style in the world but it's better than the default.
1014 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1015 padding at the bottom of the child widgets.
1016 * src/main/webapp/style.css: Add style for the Notebook.
1018 2011-10-26 Ben Konrath <ben@bagu.org>
1020 Move servlet initialization code to overridden init method.
1022 This is half of the solution to getting proper error messages
1023 displayed when configuration errors occur. Here's the relevant bug:
1025 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1027 The rest of the solution involves surrounding the init method with a
1028 try/catch block and setting a global variable with the error /
1029 exception. A new async method should be created to retrieve and display
1030 the error message / exception.
1032 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1033 code from constructor to init method adding exceptions as needed.
1035 2011-10-26 Ben Konrath <ben@bagu.org>
1037 Add script to monitor and restart tomcat if required.
1039 * utils/check-and-recover-tomcat.py: New file.
1041 2011-10-26 Ben Konrath <ben@bagu.org>
1043 Display the correct number of data items in the pager.
1047 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1049 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1050 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1051 The implementation is the same for both tables: Keep track of the
1052 number of non-empty rows and fire and RowCountChangeEvent after the data has
1054 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1055 custom Pager class that subclasses SimplePager to handle displaying
1056 the correct number when empty rows have been added.
1058 2011-10-26 Ben Konrath <ben@bagu.org>
1060 Correct error in previous commit.
1062 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1063 eventBus parameter from listView.setCellTable().
1065 2011-10-26 Ben Konrath <ben@bagu.org>
1067 Fix error in TODO comment.
1069 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1071 2011-10-24 Ben Konrath <ben@bagu.org>
1073 Create Notebook widgets to the details view.
1075 This isn't finished just yet - I still need to create a reasonable
1076 style to match the current theme.
1078 * src/main/java/org/glom/web/client/Utils.java: Add method for
1079 calculating the height of a widget. This is used in the Notebook class.
1080 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1081 new constructor method in Group.
1082 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1083 method for creating child widget that can be used by subclasses
1084 like Notebook. New constructor that allows disabling the group
1085 titles - Notebooks don't set a group title for their child groups.
1086 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1087 to make Notebooks using GWT's TabLayoutPanel.
1088 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1089 constructor that allows disabling the group titles.
1090 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1091 LayoutItemNotebook DTO.
1092 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1093 DTO for Notebooks. It's just an empty class for now but we might need
1094 it to transfer some specific information in the future.
1096 2011-10-21 Ben Konrath <ben@bagu.org>
1098 Add navigation buttons to related list tables.
1100 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1101 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1103 method getSuitableRecordToViewDetails() for getting the table name
1104 and primary key value for related list navigation buttons.
1105 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1106 private cell renderer class to get the navigation information for
1107 related list tables from the server. Extract the navigation
1108 processing code from the details cell navigation and use it for the
1109 related list navigation as well.
1110 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1111 cell renderer class for the details open buttons. This was needed
1112 because the related list navigation buttons and the list view
1113 navigation buttons need to react differently when clicked.
1114 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1115 the onEnterKeyDown() method because it's now overriden in the
1116 subclasses that are specific to the related list tables and the list
1118 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1119 the vertical size a little because the buttons add a bit of vertical
1120 space to table. This is not a perfect solution because the vertical
1121 size of with table fewer than 5 rows will be a little smaller.
1122 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1123 changes in how navigation buttons are handled.
1124 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1125 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1126 database access object.
1127 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1128 to find the portal for a given relationship name from
1129 RelatedListDBAccess. Add method to find a primary key field for a
1131 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1132 Move code to find the portal for a given relationship name to
1134 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1135 New file: database access object for getting the related list
1136 navigation information (the table name and the primary key value).
1137 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1138 DTO for transferring a table name to navigate to and a primary key
1140 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1141 boolean and getter/setter to specifies if the related list should add
1144 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1146 Use the master branch of java-libglom
1148 * pom.xml: Depend on java-libglom 1.19 instead.
1150 This is the master branch. See also the libglom-1-18 branch.
1152 2011-10-11 Ben Konrath <ben@bagu.org>
1154 Enable the open navigation button when the data has been set.
1156 This avoids having active buttons that don't do anything when the data
1159 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1161 2011-10-11 Ben Konrath <ben@bagu.org>
1163 Use IsWidget interface for FlowTableItem.
1165 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1166 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1168 2011-10-11 Ben Konrath <ben@bagu.org>
1170 Remove GWT styling from open button in details view.
1172 There are still some issues with how the details cell is arranged but
1173 this should be made to match Glom 1.20. I'm going to leave fixing this
1174 until I have Glom 1.20 up and running.
1176 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1177 style name on open button.
1178 * src/main/webapp/style.css: Move and edit details-navigation class.
1179 Re-arrange some classes to make them appear in the same order as the
1182 2011-10-07 Ben Konrath <ben@bagu.org>
1184 Update to GWT 2.4.0.
1186 * .gitignore: Ignore new cache directory.
1187 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1188 * pom.xml: Change GWT and maven plugin to 2.4.0.
1189 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1191 * src/main/java/org/glom/web/client/ClientFactory.java:
1192 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1193 * src/main/java/org/glom/web/client/OnlineGlom.java:
1194 Update source for API changes.
1195 * utils/build-onlineglom-war.sh: Remove cache directory before the
1198 2011-10-07 Ben Konrath <ben@bagu.org>
1200 Add navigation buttons in the details view.
1202 This isn't finished but I thought I'd commit what I have as it's a
1203 pretty good start. I still need to:
1205 1. Change the style so that it fits better into the current theme
1206 2. Adjust the details cell to expand as much as possible.
1208 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1209 click handlers to navigation buttons in the DetailsCells. Create a
1210 refreshData() method to get just the data from the server without the
1212 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1213 Update the tableSelector and browser title when the table name
1214 changes without using the tableSelector.
1215 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1216 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1217 getDetailsCells() to getCells(). Update variable names.
1218 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1219 method to set click handler on navigation button. Rename a few
1220 variables. Add navigation buttons where needed.
1221 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1222 variables and methods.
1223 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1224 navigation boolean and navigation table as required in the
1225 LayoutItemField DTO.
1226 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1227 variables for navigation along with getter/setter methods.
1229 2011-10-07 Ben Konrath <ben@bagu.org>
1231 Rename Field to DetailsCell.
1233 This is a refactor-only commit. No functionality has been added or
1236 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1237 Update variable and method names.
1238 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1239 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1240 variable and method names.
1241 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1243 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1244 variable and method names.
1246 2011-10-07 Ben Konrath <ben@bagu.org>
1248 Create separate methods for layout and data the details view.
1250 This is a refactor-only commit. No functionality has been added or
1253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1254 private methods: setData(), createLayout().
1256 2011-10-07 Ben Konrath <ben@bagu.org>
1258 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1260 This is part of a change to get navigation buttons in the details view
1261 but it should have been done this way from the start.
1263 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1264 for method name change in TableSelectionView.
1265 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1266 Create TableChangeEvent and set the browser title using the
1267 TableSelectionView API.
1268 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1269 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1270 Change getSelectedTable() to getSelectedTableName(). Add
1271 getSelectedTableTitle().
1273 2011-10-07 Ben Konrath <ben@bagu.org>
1275 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1277 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1279 2011-10-07 Ben Konrath <ben@bagu.org>
1281 Update TableChangeEvent to use newTableName naming convention.
1283 This makes the class more consistent with GWT naming conventions.
1285 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1286 Update for method name change in TableChangeEvent.
1287 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1288 for method name change in TableChangeEvent.
1289 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1290 newTableName variable and getter method. Make toDebugString()
1293 2011-09-30 Ben Konrath <ben@bagu.org>
1295 Disable the pager in the list tables when the data row count is less than the minimum.
1297 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1298 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1300 2011-09-30 Ben Konrath <ben@bagu.org>
1302 Add empty rows to the end of related list and list view tables.
1304 I also extracted the cell rendering classes from the ListTable because
1305 the code was becoming a little crazy with all the anonymous inner
1306 classes. My plan is to use these cell rendering classes in the details
1307 view as well so this refactor will be needed for that change.
1309 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1310 set the row count in related list tables if the data has more rows
1311 than the minimum number of rows visible.
1312 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1313 row count in list view tables if the data has more rows than the
1314 minimum number of rows visible.
1315 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1316 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1318 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1319 for rendering TYPE_NUMERIC cells. The code was extracted from the
1321 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1322 class for rendering cells with buttons in list views. The code was
1323 extracted from the ListTable class.
1324 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1325 for rendering TYPE_TEXT cells. The code was extracted from the
1327 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1328 Add empty rows to the end of the data if required. Implement
1329 ListTable.getMinNumVisibleRows().
1330 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1331 cell renderer code to public classes. Return null in
1332 Column.getValue() for empty rows. Add new abstract method:
1333 getMinNumVisibleRows(). Move code to set the row count of the list view
1334 table to ListViewImpl.
1335 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1336 empty rows to the end of the data if required. Implement
1337 ListTable.getMinNumVisibleRows().
1340 2011-09-27 Ben Konrath <ben@bagu.org>
1342 Use GWT.log for client-side debugging statements.
1344 These are optimized out when deployed so I should have used this method
1345 in the first place. These statements will eventually be replaced with some sort
1346 of notification in the browser.
1348 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1349 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1350 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1351 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1352 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1354 2011-09-27 Ben Konrath <ben@bagu.org>
1356 Put tableselector on the right, back to list link on right.
1358 The idea is that the table selector is acting like a label for the
1359 currently displayed table so it should be placed below the document title. This
1360 puts the table title in a similar position to where it is in Glom.
1362 * mockups/details-contacts.html:
1363 * mockups/details-projects.html:
1364 * mockups/listview-contacts.html:
1365 * mockups/listview-projects.html:
1366 * mockups/style.css:
1367 Update mockups to match how the interfaces currently look.
1368 * src/main/webapp/style.css: Swap positions of backlink with the table
1369 selector. Add some space on the left side of the table selector to
1370 line things up with the document title.
1372 2011-09-27 Ben Konrath <ben@bagu.org>
1374 Add field colouring to details view.
1376 This change re-works how field colouring works. The colour formatting
1377 information is now set to the client with the layout information instead of
1378 with the data. This eliminates the need to send the same colour strings for
1379 data in list view column when colour information is set.
1381 In order to set an alternate colour for negative numeric values, the
1382 number is now sent to client and formatted with the GWT NumberFormat class.
1384 This change also fixes:
1386 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1388 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1389 internationalization framework which is needed for client side numeric
1391 * src/main/java/org/glom/web/client/Utils.java: New file for some
1392 client static utility methods.
1393 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1394 the DataItem object to the Field class. Use a utility method to
1395 create the foreignKeyValue string.
1396 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1397 alignment and text colours in the constructor. Add setData(DataItem)
1398 method. Remove setText(String) method.
1399 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1400 colour information to GlomTextCell. Create and use GlomNumberCell for
1401 rendering numbers. Use utility method to get the string for the
1402 primary key of the key provider. Re-work how the horizontal alignment
1404 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1405 formatting to layout information. Methods for converting the libglom
1406 formatting information were moved from DBAccess.
1407 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1408 numeric formatting (it's now done on the client side). Don't set text
1409 colours in DataItem. Move libglom formatting conversion methods to
1411 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1412 getters/setters for text colour information.
1413 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1414 for transferring the libglom NumericFormat information to the client.
1415 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1416 and getters/setters for: GlomNumericFormat, background colour and
1417 foreground colour strings.
1419 2011-09-26 Ben Konrath <ben@bagu.org>
1421 Simplify code that iterates through the LayoutGroup.
1423 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1425 2011-09-26 Ben Konrath <ben@bagu.org>
1427 Accept Eclipse formatting for OnlineGlomServiceAsync.
1429 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1431 2011-09-26 Ben Konrath <ben@bagu.org>
1433 Don't use the ListDBAccess classes to get the primary key layout information.
1435 This was causing a bug where the wrong index for the hidden primary key
1436 was being sent to the client.
1438 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1439 primary key while creating the LayoutGroup DTO. Create a
1440 LayoutItemField DTO for hidden primary keys. Don't use the
1441 RelatedListDBAccess because it was only used for getting the primary
1443 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1444 access modifier from public to protected for getPrimaryKeyField() and
1445 getPrimaryKeyLayoutItemField().
1446 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1447 abstract method getExpectedResultSize() because RelatedListDBAccess
1448 doesn't have enough info to implement it.
1449 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1450 Remove @Override for getExpectedResultSize().
1451 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1452 Remove method getExpectedResultSize().
1454 2011-09-23 Ben Konrath <ben@bagu.org>
1456 Log which layout (list or details) the ignored item is from.
1458 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1460 2011-09-23 Ben Konrath <ben@bagu.org>
1462 Remove annotations that turn off code formatting in DataItem.
1464 * src/main/java/org/glom/web/shared/DataItem.java:
1466 2011-09-23 Ben Konrath <ben@bagu.org>
1468 Rename GlomField to DataItem and update associated methods.
1470 This is a rename-only refactor. No functionality has been added or
1473 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1474 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1475 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1476 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1477 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1478 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1479 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1480 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1482 * src/main/java/org/glom/web/server/database/DBAccess.java:
1483 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1484 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1485 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1486 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1487 * src/main/java/org/glom/web/shared/DataItem.java:
1488 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1489 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1491 2011-09-23 Ben Konrath <ben@bagu.org>
1493 Rename GlomDocument to DocumentInfo and update associated methods.
1495 This is a rename-only refactor. No functionality has been added or
1498 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1499 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1500 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1501 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1502 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1504 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1506 2011-09-20 Ben Konrath <ben@bagu.org>
1508 Require java-libglom 1.17.3.
1510 This picks up the fix for the seg fault problem with the Scenes table
1511 in the Openismus Film Manager example.
1515 2011-09-20 Ben Konrath <ben@bagu.org>
1517 Change the way sort clause is added for primary key when no sort clause is requested.
1519 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1520 before the sort clause is created. When a sort clause is not requested, the
1521 sort clause is created by finding the primary key in the LayoutFieldVector
1524 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1526 2011-09-20 Ben Konrath <ben@bagu.org>
1528 Log error message if no documents are found in the configured directory.
1530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1531 Extract the glom file extension string to a private static final class
1532 variable (mostly as syntactic sugar). Accept a minor formatting change.
1533 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1534 the example glom.document.directory configuration property to make it
1535 more clear that it can any directory, not just the home directory.
1537 2011-09-18 Ben Konrath <ben@bagu.org>
1539 Add related lists to details view.
1541 The related list table has support for paging and sorting just like the
1542 table in the list view.
1544 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1545 SQL queries for the related list tables.
1546 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1547 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1548 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1549 Rename getList methods to getListView and add comments. Remove
1550 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1551 it being unused. Add methods: getDetailsLayoutAndData(),
1552 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1554 Create the layout and set the data for the fields in one async call
1555 instead of two. Create related lists where appropriate.
1556 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1557 for method name changes in OnlineGlomService.
1558 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1559 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1560 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1562 * src/main/java/org/glom/web/client/ui/ListView.java:
1563 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1564 tableName from setCellTable(). Create a ListViewTable instead of
1566 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1567 represent a data field in the details view.
1568 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1569 from addDetailsCell() to Field class. Keep track of the Fields and
1570 Portals in the details view.
1571 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1572 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1573 and add a method to get it. Add method to set the contents of the
1575 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1576 New class for related list tables. This class has the data provider
1577 for the related list table.
1578 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1579 abstract class which is the base class for the ListViewTable and the
1581 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1582 New class for list view tables. This class has the data provider for
1583 the list view table.
1584 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1585 methods for related list tables. Add more information to the
1586 LayoutItemField and LayoutItemPortal DTOs.
1587 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1588 Remove debugging print statement.
1589 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1590 Remove debugging print statements. Add primary key field to SQL count
1592 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1593 Remove unnecessary LayoutFieldVector parameter from
1594 getResultSizeOfSQLQuery() method.
1595 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1596 New class for related list table database access.
1597 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1598 class that is a wrapper DTO for details view layout and data.
1599 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1600 new 'fromField' string to this DTO.
1601 * src/main/webapp/style.css: Remove bottom margin and override top
1604 2011-09-15 Ben Konrath <ben@bagu.org>
1606 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1608 This sets things up to make it easier to add the data retrieval for
1609 related lists (portals). No user noticeable changes were made with
1612 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1613 class has the code to retrieve the layouts and access the
1614 database using the new database helper classes.
1615 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1616 Most of the functionality has been removed from this class. This
1617 class now represents the public interface for the client side
1618 code. It also deals with configuring the servlet and cleaning
1619 things up when the servlet is stopped.
1620 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1621 of static methods into this utility class.
1622 * src/main/java/org/glom/web/server/database/DBAccess.java:
1623 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1624 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1625 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1626 These classes have the database retrieval code. The class hierarchy
1627 has been setup to make it easy to reuse code for similar
1630 2011-09-06 Ben Konrath <ben@bagu.org>
1632 Create separate classes for list table code and the data provider.
1634 As part of this refactor, I also split up the code a bit to make it
1637 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1638 table code to two new classes (below).
1639 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1640 with code from ListViewImpl.
1641 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1642 New file with code from ListViewImpl.
1644 2011-09-06 Ben Konrath <ben@bagu.org>
1646 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1648 This fixes the LayoutItemPortal DTO to match the libglom layout object
1651 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1653 2011-09-01 Ben Konrath <ben@bagu.org>
1655 Set title of Portals in the Details View.
1657 * pom.xml: Bump required version of java-libglom to 1.17.1.
1658 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1659 widget creation to its own class. Add comments to constructor.
1660 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1661 The code is mostly from the Group class with the title now set.
1662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1663 title of Portal. Update some comments. Fix some code formatting.
1665 2011-09-01 Ben Konrath <ben@bagu.org>
1667 Remove TODO comment for the flow table column width.
1669 The flow table column width is working correctly and doesn't need to be
1670 changed. See this mailing list post for more info:
1672 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1674 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1676 2011-08-27 Ben Konrath <ben@bagu.org>
1678 Add document title (database name) to top of the browser page.
1680 I added the document title to the TableSelecitonView but that will
1681 change if / when we add a view that doesn't require table selection.
1683 * mockups/details-contacts.html:
1684 * mockups/details-projects.html:
1685 * mockups/listview-contacts.html:
1686 * mockups/listview-projects.html:
1687 * mockups/style.css: Add document title to mockups to keep things
1689 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1690 sizes to account for the document title.
1691 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1692 Set the document title when it has been retrieved from the server.
1693 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1694 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1695 and implement setDocumentTitle(String) method.
1696 * src/main/webapp/style.css: Add ID for document title style.
1698 2011-08-25 Ben Konrath <ben@bagu.org>
1700 Add NavigationType enum to LayoutItemPortal DTO.
1702 This is the start of adding support for Portals to the Details View.
1704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1705 LayoutItem_Portal.navigation_type enum from libglom to
1706 LayoutItemPortal.NavigationType enum.
1707 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1708 NavigationType enum, field for storing the NavigationType and getter
1711 2011-08-25 Ben Konrath <ben@bagu.org>
1713 Implement the flow table layout in the Details View.
1715 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1716 FlowTable to Group to account for the renamed class.
1717 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1718 File. This is a container widget that implements the Glom details view
1719 flow table behaviour.
1720 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1721 org/glom/web/client/ui/FlowTable.java.
1722 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1723 so that the size of the subgroups are a closer match to the size of
1724 the Glom subgroups. This makes the flowtable layout match the layout
1725 in Glom for the Music Collection example file.
1727 2011-08-16 Ben Konrath <ben@bagu.org>
1729 Create container element for LayoutItemPortal in Details View.
1731 This will help me develop the layout for the FlowTable.
1733 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1734 fieldPanel variable to detailsCell.
1736 2011-08-15 Ben Konrath <ben@bagu.org>
1738 Set the height of the data element in the Details View.
1740 I changed the InlineLabels (text in a span element) to Labels (text in
1741 a div element) so that I could set the height of the details-data
1742 elements instead of the details-cell parent elements. This allows the
1743 the details-data element to display the correct height if style is
1744 applied that shows the height.
1746 This change has the added benefit of allowing the order of the labels
1747 and data elements to be changed for right-to-left languages.
1749 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1750 InlineLabels to Labels.
1751 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1752 InlineLabels to Labels. Set the height of the data element.
1753 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1754 multiline text height in the Formatting DTO.
1755 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1756 for multiline height along with getter and setter methods.
1757 * src/main/webapp/style.css: Adjust style to account for the change
1758 from span elements to div elements in the details cell.
1760 2011-08-15 Ben Konrath <ben@bagu.org>
1762 Make the List View appearance match the mockups.
1764 It doesn't match exactly but it's much better than it was.
1766 * mockups/listview-contacts.html: Remove unused css classes.
1767 * mockups/listview-projects.html: Remove unused css classes.
1768 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1769 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1770 for mainPanel instead of VerticalPanel (table). Set style name on
1771 CellTable. Set style name on Details column. Right-align Details
1773 * src/main/webapp/style.css: Adjust properties to match the mockups.
1775 2011-08-12 Ben Konrath <ben@bagu.org>
1777 Add better support for subgroups in the details view.
1779 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1780 changed FlowTable constructor.
1781 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1782 support for subgroups and subgroup-titles.
1783 * src/main/webapp/style.css: Add CSS class for subgroups and
1786 2011-08-12 Ben Konrath <ben@bagu.org>
1788 Return the top level LayoutGroup title.
1790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1792 2011-08-11 Ben Konrath <ben@bagu.org>
1794 Make the TableSelector header match the mockup.
1796 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1797 the layout panel. Properly lineup the table selection header with
1798 the list and details view.
1799 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1800 margin around the details view.
1801 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1802 Rename listBox variable to tableSelector. Set id for the style sheet.
1803 Use a FlowPanel instead of a HorizontalPanel.
1804 * src/main/webapp/style.css: Add properties to make the TableSelector
1805 box match the mockups.
1807 2011-07-13 Ben Konrath <ben@bagu.org>
1809 Update install script for java-libglom version change.
1811 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1814 2011-07-13 Ben Konrath <ben@bagu.org>
1816 Add support sub-group in the details view.
1818 I also removed the code that special-cased the default details view
1821 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1823 I still have to make a proper flowtable.
1825 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1826 Don't special-case default details view layout.
1827 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1828 addLayoutField() as I'm going to use it.
1829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1830 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1832 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1833 extracted from DetailsViewImpl.GroupPanel. Add support for
1835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1836 column count when getting the details layout.
1838 2011-07-12 Ben Konrath <ben@bagu.org>
1840 Set browser title with database and table titles.
1842 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1843 Set the browser title when the table changes and when the activity
1845 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1846 title when retrieving document info (the GlomDocument object).
1847 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1848 with getter and setter methods. Remove unused convenience constructor.
1849 Use default code formatting.
1851 2011-07-12 Ben Konrath <ben@bagu.org>
1853 Ignore LayoutItemPortals in the details view.
1855 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1858 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1859 LayoutItemPortal layout objects.
1860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1861 LayoutItemPortal objects when retrieving the details layout.
1862 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1863 file. This is an empty class and just used to get type information for
1866 2011-07-12 Ben Konrath <ben@bagu.org>
1868 Use java-libglom 1.17.0.
1872 2011-07-11 Ben Konrath <ben@bagu.org>
1874 Remove "Table:" label from table selector.
1876 This matches a recent change in the Glom UI.
1878 * mockups/details-contacts.html:
1879 * mockups/details-projects.html:
1880 * mockups/listview-contacts.html:
1881 * mockups/listview-projects.html: Remove the "Table:" label from the
1883 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1885 2011-07-11 Ben Konrath <ben@bagu.org>
1887 Add main groups to the details view.
1889 This makes things look a little nicer in the details view. The next step
1890 is to implement the flowtable.
1892 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1893 resources from the standard gwt css theme. Standard.css is now
1894 included in OnlineGlom.html so that the online glom css rules have
1895 precedence over the gwt theme.
1896 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1897 the whole LayoutGroup to the DetailsView instead of just the titles.
1898 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1899 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1900 details layout with a helper class (GroupPanel). I might extract this
1901 class when I make the full flowtable.
1902 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1903 string as default so I don't have to worry about NPEs when processing
1905 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1906 note beside OnlineGlom.gwt.xml above).
1907 * src/main/webapp/style.css: Add default font-size to body to override
1908 the font-size set by the standard theme. Don't use h2 tags for
1909 group-title. Create new details-cell class.
1911 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1913 ConfiguredDocument: Set the port number too.
1915 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1916 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1917 Glom document. Presumably this worked sometimes so far because there is a
1918 default port number.
1920 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1922 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1924 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1925 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1926 correct, though we should throw an exception too.
1928 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1930 Fix a addDocuemnt typo.
1932 * src/main/java/org/glom/web/shared/Documents.java
1933 (Documents.addDocuemnt): Rename to addDocument().
1934 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1935 (OnlineGlomServiceImpl.getDocuments): Adapt.
1937 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1939 Slightly improved log output when connection fails.
1941 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1942 (ConfiguredDocument.setUsernameAndPassword):
1943 We don't know for sure if it' the username/password that's wrong, so
1944 rephrase the message.
1945 Also ouput the exception message, though it's generic in this case.
1947 2011-07-08 Ben Konrath <ben@bagu.org>
1951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1952 added braces to a one line if statement because the Eclipse formatter
1953 was getting confused.
1955 2011-07-07 Ben Konrath <ben@bagu.org>
1957 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1959 These should really be two separate tasks but I counldn't get things to
1960 work with GWT 2.2.0 and Eclipse 3.7.
1964 * .settings/org.eclipse.jdt.core.prefs:
1965 * .settings/org.eclipse.jdt.ui.prefs:
1966 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1967 * .settings/org.eclipse.m2e.core.prefs:
1968 Add new config files. Update current files. Remove references to the
1969 webtools plugins as we're not using any of the webtools features.
1970 * .gitignore: Add logs directory which is created when running with
1972 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1973 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1974 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1976 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1978 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1980 onlineglom.properties: Add explanatory comments.
1982 * src/main/resources/onlineglom.properties: Also change the default user
1983 from ben to someuser, to avoid the risk of people thinking we just
1984 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1986 2011-06-28 Ben Konrath <ben@bagu.org>
1988 Use filename in Log for incorrect passwords.
1990 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1991 getFileName(String) method to get the filename from the URI.
1993 2011-06-28 Ben Konrath <ben@bagu.org>
1995 Add the table name to the URL token for the ListPlace.
1997 This makes things consistent between the DetailsPlace and the
1998 ListPlace. It also allows the the ListPlace to be bookmarked.
2000 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2001 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2002 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2003 Remove getDefaultListLayout(). The default layout is now returned
2004 by the getListLayout() method when the table name is an empty string.
2005 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2006 Add table name field. Change to a new ListPlace when the table
2007 has been changed. Use getListLayout() for getting the default
2009 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2010 Add table name field. Set the correct table name in the list box
2011 when loading from bookmark. This corrects a problem for the
2013 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2014 Move table name to super-class (HasSelectableTable). Move document
2015 and table URL keys to super-class in HasSelectableTable.
2016 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2017 Add table name field. Add Tokenizer class with URL key common to
2018 the subclasses (DetailsPlace and ListPlace).
2019 * src/main/java/org/glom/web/client/place/ListPlace.java:
2020 Add table name. Add code to parse the URL token.
2021 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2022 Update ListPlace construction with empty table name string.
2023 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2024 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2025 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2026 Update ListPlace construction with table name string.
2027 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2028 Change defaultTableName field to tableName to reflect how it's now
2029 used. Update the getter and setter methods.
2031 2011-06-28 Ben Konrath <ben@bagu.org>
2033 Enable the table selector in the DetailsView.
2035 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2036 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2038 Remove getDefaultDetailsLayout(). The default layout is now returned
2039 by the getDetailsLayout() method when the table name is an empty
2041 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2042 event handler for table change event. Change to using
2043 getDetailsLayout() for the default details layout.
2044 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2046 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2047 when navigating to the details place.
2049 2011-06-27 Ben Konrath <ben@bagu.org>
2051 Use filename based unique document ID in URL and for RPC.
2053 The document ID is the glom document name with spaces (' ') replaced
2054 with pluses ('+') and without the .glom extension.
2056 This change is mostly a string substitution of 'documentTitle' for
2057 'documentID'. The only code change is the addition of a Documents DTO to get the
2058 filename to document title mappings as indicated below.
2060 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2061 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2062 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2063 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2064 Use Documents DTO to create the document links in the document
2066 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2067 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2068 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2069 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2070 * src/main/java/org/glom/web/client/place/ListPlace.java:
2071 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2072 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2073 * src/main/java/org/glom/web/client/ui/ListView.java:
2074 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2075 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2076 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2077 * src/main/java/org/glom/web/server/Log.java:
2078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2079 getDocumentTitles() to getDocuments() and return the Documents DTO.
2080 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2081 transferring the filename to document title mappings.
2083 2011-06-25 Ben Konrath <ben@bagu.org>
2085 Make the authentication popup work again.
2087 This bug was introduced when I extracted ConfiguredDocument to its own class.
2089 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2090 correct success / fail status in setUsernameAndPassword().
2092 2011-06-25 Ben Konrath <ben@bagu.org>
2094 Use filename as unique key for configuring database usernames and passwords.
2096 This replaces the use of the Glom document title which could change
2097 depending on the locale. Thanks to Murray Cumming for pointing out this
2100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2101 * src/main/resources/onlineglom.properties:
2103 2011-06-24 Ben Konrath <ben@bagu.org>
2105 Pass primary key value to DetailsView.
2107 This enables the DetailsView to load the correct data.
2109 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2110 primary key value field and set in constructor. Pass primary key
2111 value to getDetailsData().
2112 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2113 variables for document title and primary key value.
2114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2115 key value to the DetailsPlace.
2117 2011-06-24 Ben Konrath <ben@bagu.org>
2119 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2121 This allows the primary key to be retrieved by the Details button. This
2122 functionality has not been implemented yet but it's in the works.
2124 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2125 the LayoutGroup result to ListView.setCellTable instead of all of its
2126 fields individually.
2127 * src/main/java/org/glom/web/client/ui/ListView.java:
2128 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2129 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2130 get the primary key for the table.
2131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2132 index of the primary key in the LayoutGroup accounting for hidden
2133 primary keys. Rename getJavaNumberFormat() to
2134 convertToJavaNumberFormat() for consistency. Cleanup / add some
2136 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2137 field for primary key index and a field to indicate whether the
2138 primary key is hidden or not.
2140 2011-06-23 Ben Konrath <ben@bagu.org>
2142 Rename getTableData methods to getListData.
2144 This is a rename refactor for consistency with other methods.
2146 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2147 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2148 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2151 2011-06-23 Ben Konrath <ben@bagu.org>
2153 Extract the ConfiguredDocument innerclass into its own class.
2155 This makes the servlet code more object oriented.
2157 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2158 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2160 new ConfiguredDocument class.
2162 2011-06-21 Ben Konrath <ben@bagu.org>
2164 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2166 This makes things more inline with how libglom works and reduces code
2167 duplication. This refactor lays the groundwork for adding the primary key to
2168 the LayoutGroup object.
2170 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2171 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2173 Change method names to getListLayout and getDefaultListLayout for
2174 consistency. Use LayoutGroup as the DTO for the list layout instead of
2175 ColumnInfo and LayoutListTable.
2176 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2177 new method names along with the LayoutGroup object for transferring the
2179 * src/main/java/org/glom/web/client/ui/ListView.java:
2180 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2181 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2182 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2184 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2185 Replaced with LayoutGroup.
2186 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2187 expectedResultSize and defaultTableName fields which are needed for
2189 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2190 type field which is needed for the list layout but will also be
2191 useful for the details layout as things progress.
2192 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2193 Make class abstract. Remove the unnecessary
2194 getFormattingHorizontalAlignment method. Add setFormatting method.
2196 2011-06-16 Ben Konrath <ben@bagu.org>
2198 Add scripts for building and installing war.
2200 These will help when updating OnlineGlom but they're also good
2201 supplemental documentation of the build and deployment proceeding.
2203 * utils/build-onlineglom-war.sh: New file.
2204 * utils/install-onlineglom-war.sh: New file.
2206 2011-06-16 Ben Konrath <ben@bagu.org>
2208 Create wrapper class to create consistent log messages.
2210 I wrapped methods in the Log class of gwt-log to add the method names
2211 from the servlet and create consistent formatting of the document title
2212 and table names in the log messages.
2214 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2216 log methods to use methods from wrapped Log class.
2218 2011-06-16 Ben Konrath <ben@bagu.org>
2220 Remove superfluous conditional return.
2222 Thanks to Murray Cumming for pointing this out!
2224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2226 2011-06-15 Ben Konrath <ben@bagu.org>
2228 Return an ArrayList of LayoutGroups for the Details layout.
2230 This corrects a problem with the details layout as it can have more
2231 than one top level LayoutGroup.
2233 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2234 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2235 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2236 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2237 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2238 with ArrayList of LayoutGroups for the details view layout.
2239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2240 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2241 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2242 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2243 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2244 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2246 2011-06-14 Ben Konrath <ben@bagu.org>
2248 Use cast_dynamic method to determine the libglom LayoutItem type.
2250 This is better than finding the LayoutItem type by using the string
2251 returned from the get_part_type_name() method.
2253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2255 2011-06-14 Ben Konrath <ben@bagu.org>
2257 Add method names to log entries in the servlet.
2259 This helps when tracking down deployment problems.
2261 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2263 2011-06-14 Ben Konrath <ben@bagu.org>
2265 Add data to the DetailsView using a hard-coded primary key value.
2267 The layout and functionality of the DetailsView is not complete. This
2268 is just a checkpoint so the patch doesn't get too big.
2270 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2271 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2272 Add getDetailsData() servlet method.
2273 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2274 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2275 LayoutFields are added to the DetailsView.
2276 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2277 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2278 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2279 take the string for the title instead of the object.
2280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2281 Add implementation getDetailsData() along with some private helper
2283 * src/main/webapp/style.css: Add padding to details-data class. Add a
2284 details-label class with the same padding as the details-data class.
2286 2011-06-03 Ben Konrath <ben@bagu.org>
2288 Use presenter.goTo() to change to the DetailsPlace.
2290 This will make things easier when we need to open the DetailsView with
2291 data specific to the row that was clicked.
2293 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2295 2011-06-02 Ben Konrath <ben@bagu.org>
2297 Add CSS file from mockups.
2299 I'm adding this now because it's going to be useful to have when
2300 developing the DetailsView. The TableSelectionView and ListView aren't
2303 * src/main/webapp/OnlineGlom.html:
2304 * src/main/webapp/style.css:
2306 2011-06-02 Ben Konrath <ben@bagu.org>
2308 Use String.isEmpty() to check for empty string.
2310 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2312 2011-06-02 Ben Konrath <ben@bagu.org>
2314 Display main layout group titles in the DetailsView.
2316 This is the start of the DetailsActivity/DetailsView implementation.
2318 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2319 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2320 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2321 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2322 Get the layout information for the details view from the server and set
2323 the main layout group titles.
2324 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2325 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2326 Add addLayoutGroup() and addLayoutField() methods. This are just
2327 temporary methods for creating the the details view that will change
2329 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2330 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2332 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2333 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2334 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2335 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2336 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2337 Data Transfer Objects that mimic the libglom object structure. These are
2338 used for transferring the details layout but could also be used for
2339 transferring the list layout.
2341 2011-05-27 Ben Konrath <ben@bagu.org>
2343 Reset the AuthenticationPopup when clearing the ListView.
2345 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2347 2011-05-27 Ben Konrath <ben@bagu.org>
2349 Fix problem with onlineglom.properties file loading.
2351 The old way worked in Eclipse but not on the server. Loading the
2352 onlineglom.properties file now works in Eclipse and on the server.
2354 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2356 2011-05-24 Ben Konrath <ben@bagu.org>
2358 Update gwt-log from 3.1.0 to 3.1.2.
2360 Gwt-log 3.1.0 has been marked as depreciated.
2364 2011-05-24 Ben Konrath <ben@bagu.org>
2366 Add comment to ListActivity.goTo() method.
2368 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2370 2011-05-24 Ben Konrath <ben@bagu.org>
2372 Remove FIXME in convertGdkColorToHtmlColour()
2374 The Gdk::Color value returned by libglom is 16-bits per channel on both
2375 64 and 32-bit platforms.
2377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2379 2011-05-19 Ben Konrath <ben@bagu.org>
2381 Improve performance of initial ListView load.
2383 I removed a round trip to the server for getting the default table name
2384 and then requesting information about that table. This also removes a potential
2385 problem with the table change handler not being setup in time to receive the
2386 table change event from the ListActivity.
2388 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2389 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2390 getDefaultLayoutListTable() method. Improve comments.
2391 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2392 getDefaultLayoutListTable() method instead of firing a table change
2393 event to get the table to load.
2394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2395 implementation of getDefaultLayoutListTable() method.
2396 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2399 2011-05-19 Ben Konrath <ben@bagu.org>
2401 Override toDebugString() in TableChangeEvent.
2403 This is useful to have for debugging.
2405 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2407 2011-05-19 Ben Konrath <ben@bagu.org>
2409 Add a "Back to List" link when at the DetailsPlace.
2411 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2412 Populate the CellTable based on the selected table of the ListBox if
2413 it's set otherwise use the default table. This allows the "Back to
2415 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2416 Remove Place from constructors. Add a setPlace() method. Add
2417 goToPlace() method. Set class as presenter for TableSelectionView.
2418 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2419 Use the same TableSelectionActivity when switching between the List and
2421 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2422 Subclass the new HasSelectableTablePlace. This removes some duplicate
2424 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2425 New class to represent Places that display the TableSelectionView.
2426 * src/main/java/org/glom/web/client/place/ListPlace.java:
2427 Subclass the new HasSelectableTablePlace. This removes some duplicate
2429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2431 Add Presenter interface. Add setBackLinkVisible() method. Add
2432 setBackLink() method.
2434 2011-05-18 Ben Konrath <ben@bagu.org>
2436 Enable the "Details" buttons.
2438 Right now only an empty details view is displayed.
2440 * src/main/java/org/glom/web/client/ClientFactory.java:
2441 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2442 Add DetailsView to ClientFactory.
2443 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2444 A basic activity for the details view.
2445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2446 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2448 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2449 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2451 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2452 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2453 unnecessary super() in constructor.
2454 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2455 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2456 really shouldn't create a new TableSelectionActivity for both the ListPlace
2457 and the DetailsPlace so this should be considered a temporary solution.
2458 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2459 New file. Represents a URL for the details view.
2460 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2461 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2462 A basic details view interface and implementation.
2463 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2464 Enable the "Details" buttons.
2466 2011-05-12 Ben Konrath <ben@bagu.org>
2468 Use a LayoutPanel with multiple display areas for main layout.
2470 This is mostly a refactor in that there are no changes from the user
2471 point of view. These changes are required so that we can swap out the list view
2472 with the details view when the user clicks the "Details" button.
2474 * src/main/java/org/glom/web/client/ClientFactory.java:
2475 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2476 OnlineGlomView. Add TableSelectionView, ListView and
2477 AuthenticationPopup.
2478 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2479 for main layout. Add display regions for main activities. Add
2480 activity manager for for main activities.
2481 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2482 file from parts of the deleted OnlineGlomActivity.
2483 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2484 New file from parts of the deleted OnlineGlomActivity.
2485 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2486 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2487 New files for app wide table change event.
2488 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2489 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2490 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2491 Activity mappers for the main activities replace the deleted app-wide
2493 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2494 Fix a spelling error in he comment.
2495 * src/main/java/org/glom/web/client/ui/ListView.java:
2496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2497 Renamed from LayoutListView and modified for MVP. This still not a
2498 proper dumb view as prescribed by the MVP pattern but it works for now.
2499 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2500 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2501 New widget stripped out of the deleted OnlineGlomView.
2502 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2503 Remove hack that is fixed by this patch.
2505 2011-05-06 Ben Konrath <ben@bagu.org>
2507 Rename OnlineGlomPlace to ListPlace.
2509 The only change besides the rename is that url will now display #list
2510 instead of #Document.
2512 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2513 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2514 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2515 * src/main/java/org/glom/web/client/place/ListPlace.java:
2516 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2518 2011-05-06 Ben Konrath <ben@bagu.org>
2520 Use Presenter for app navigation.
2522 This is the proper way to deal with Place (URL) changes with the MVP
2525 * src/main/java/org/glom/web/client/ClientFactory.java:
2526 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2527 PlaceHistoryMapper and PlaceHistoryHandler.
2528 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2529 PlaceHistoryMapper and PlaceHistoryHandler.
2530 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2531 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2532 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2533 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2534 Add Presenter interface and setPresenter methods. Rename addHyperLink
2535 to addDocumentLink taking only the document title as a parameter.
2537 2011-04-14 Ben Konrath <ben@bagu.org>
2539 Prompt for db username/password if they haven't been set.
2541 This is implemented with a popup widget that is contained within the
2542 OnlineGlomView and managed by the OnlineGlomActivity.
2544 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2545 methods for checking and setting the database username and password.
2546 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2547 new methods for checking and setting the database username and
2549 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2550 Display authentication popup if the JDBC connection to the database
2551 has not been authenticated.
2552 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2554 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2555 for dealing with the authentication popup.
2556 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2557 Implement the methods for dealing with the authentication popup.
2558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2559 try to executed queries if the database connection hasn't been
2560 authenticated. Implement methods for checking and setting the
2561 database username and password.
2563 2011-04-12 Ben Konrath <ben@bagu.org>
2565 Make log messages a little clearer.
2567 Add a dash betweeen the document title and the table name.
2569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2571 2011-04-12 Ben Konrath <ben@bagu.org>
2573 Protect against NPEs when cleaning up database resources.
2575 While this isn't strictly necessary because the exception is caught,
2576 not protecting against the NPEs makes it harder to find the real error
2579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2581 2011-04-12 Ben Konrath <ben@bagu.org>
2583 Move configuration of the servlet to the constructor.
2585 The servlet will be initialized even if the database authentication
2586 information is not set or correct. I still need to add the UI for prompting
2587 the user for the authentication information when it's required.
2589 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2590 javadocs for getDocumentTitles() method.
2591 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2592 Set error message when RPC fails.
2593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2594 glom files directory from the configuration file. Try to set the
2595 database authentication information for the specific document if it's
2596 set and works otherwise try to use the global authentication
2597 information set for the directory.
2598 * src/main/resources/onlineglom.properties: Moved from
2599 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2600 Added detailed comments for the new keys.
2602 2011-04-11 Ben Konrath <ben@bagu.org>
2604 Remove unnecessary @Override in DocumentSelectionViewImpl.
2606 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2608 2011-04-11 Ben Konrath <ben@bagu.org>
2610 Remove center alignment in DocumentSelectionView.
2612 The title element is still centred but the document titles and bottom
2613 sentence are both left-aligned.
2615 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2617 2011-04-11 Ben Konrath <ben@bagu.org>
2619 Change 'Demo' naming convention to 'Document'.
2621 This is just a rename refactor with no functional changes to the code.
2623 * src/main/java/org/glom/web/client/ClientFactory.java:
2624 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2625 * src/main/java/org/glom/web/client/OnlineGlom.java:
2626 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2627 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2628 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2629 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2630 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2631 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2632 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2633 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2634 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2635 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2637 2011-04-08 Ben Konrath <ben@bagu.org>
2639 Remove FIXME from safeLongToInt() method.
2641 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2646 2011-04-08 Ben Konrath <ben@bagu.org>
2648 Display an error if no glom documents are found in the specified directory.
2650 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2651 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2652 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2655 2011-04-08 Ben Konrath <ben@bagu.org>
2657 Add copyright header to one more file ... oops.
2659 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2661 2011-04-08 Ben Konrath <ben@bagu.org>
2663 Add copyright header to files without it.
2665 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2666 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2667 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2668 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2669 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2670 * src/main/java/org/glom/web/shared/GlomField.java:
2672 2011-04-08 Ben Konrath <ben@bagu.org>
2674 Add support for accessing multiple glom documents in the servlet.
2676 This completes the demo selection functionality.
2678 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2679 document title to methods.
2680 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2681 document title to methods.
2682 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2683 Set browser window title when the activity starts. Correct name of
2684 document title variable.
2685 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2686 Set browser window title when the activity starts. Set the table
2687 selector change handler after table selector has been set. Clear the
2688 OnlineGlomView when the activity has been stopped.
2689 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2690 document title as the place token. Use "#Document:" instead of
2691 "#OnlineGlomPlace:" in the URL.
2692 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2693 Change heading to "Online Glom"
2694 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2695 document title in RPC methods.
2696 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2697 setDocumentTitle() method. Add clear() method.
2698 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2699 setDocumentTitle() method. Implement clear() method which removes the
2700 change handler on the ListBox, clears the ListBox and clears the
2702 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2703 Implement methods with document title. Keep track for the configured
2704 glom documents and their corresponding JDBC configurations in a hash
2705 table. This information is retrieved using the document title as the
2706 key in the hash table.
2707 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2708 document title field as it's no longer needed.
2710 2011-04-08 Ben Konrath <ben@bagu.org>
2712 Update the Eclipse JDT configuration.
2714 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2715 methods. Automatically add the copyright header to new files.
2717 2011-04-05 Ben Konrath <ben@bagu.org>
2719 Add new page for demo selection.
2721 This patch adds all the components required to view and start an
2722 OnlineGlom demo by clicking on the desired hyperlink. The user is
2723 able to return to the demo selection page with the browser's back
2724 button. I still need to modify the servlet to work with multiple
2725 documents so all demo links will load the file defined in the
2726 OnlineGlom.properties.
2728 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2729 This is only useful during development so we don't need to save it.
2730 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2731 get a reference to the DemoSelectionView.
2732 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2733 method to get a reference to the DemoSelectionView.
2734 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2735 default view to DemoSelectionView.
2736 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2737 to get glom document titles for glom files in a hard-coded directory.
2738 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2739 method to get glom document titles for glom files in a hard-coded
2741 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2742 Presenter for DemoSelectionView.
2743 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2744 for DemoSelectionView.
2745 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2746 Update for DemoSelectionView.
2747 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2748 Basic 'Place' implementation for the DemoSelectionView.
2749 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2750 The interface for the DemoSelectionView.
2751 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2752 The implementation of the DemoSelectionView.
2753 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2754 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2755 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2756 implementation of method to get glom document titles for glom files
2757 in a hard-coded directory.
2758 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2759 on longer being used.
2760 * src/main/webapp/glom.png: Glom logo.
2762 2011-04-05 Ben Konrath <ben@bagu.org>
2764 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2766 This is the forth and final commit of a refactor that will allow
2767 OnlineGlom to be used with multiple documents.
2769 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2770 Move RPC code from OnlineGlomViewImpl to this class.
2771 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2773 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2774 RPC code to the presenter class (the P in MVP).
2776 2011-04-04 Ben Konrath <ben@bagu.org>
2778 Start moving the existing OnlineGlom code to MVP.
2780 This work is based on the GWT MVP framework that is documented here:
2782 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2784 This is the third commit of a refactor that will allow OnlineGlom to
2785 be used with multiple documents.
2787 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2788 Interface for client factory which is used to get instances of various
2789 classes throughout the app.
2790 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2791 Implementation of client factory.
2792 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2793 initialize the MVP framework.
2794 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2795 New file. Activity manager for the main container widget. This is the
2797 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2798 Maps place (URL) to its corresponding activity.
2799 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2800 New file. This is just a place holder for a generated file.
2801 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2802 New file. Represents the URL for the main Online Glom app.
2803 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2804 for changes in LayoutListViewImpl.
2805 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2806 interface for View. Move code to OnlineGlomViewImpl class.
2807 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2808 file. Implementation of OnlineGlomView.
2809 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2810 Place resources. Use ClientFactoryImpl by default.
2812 2011-04-04 Ben Konrath <ben@bagu.org>
2814 Move View classes to their own package.
2816 This is the second commit of a refactor that will allow OnlineGlom to
2817 be used with multiple documents.
2819 * src/main/java/org/glom/web/client/OnlineGlom.java:
2820 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2821 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2823 2011-04-02 Ben Konrath <ben@bagu.org>
2825 Move UI code from the main module to its own class.
2827 This is the first commit of a refactor that will allow OnlineGlom to be
2828 used with multiple documents.
2830 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2831 references to OnlineGlom to OnlineGlomView.
2832 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2833 OnlineGlomView and instantiate it here.
2834 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2835 represents the main OnlineGlomView with one document.
2837 2011-04-01 Ben Konrath <ben@bagu.org>
2839 Fix formatting of gwt.xml and add DTD.
2841 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2843 2011-03-30 Ben Konrath <ben@bagu.org>
2845 Propperly convert gdkColor string to html colour string.
2847 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2849 2011-03-28 Ben Konrath <ben@bagu.org>
2851 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2853 This implementation matches
2854 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2855 readable and is not tied to Swig.
2857 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2859 2011-03-28 Ben Konrath <ben@bagu.org>
2861 Use read-only checkboxes for boolean field types.
2863 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2864 in the CellTable based on the field type. It currently only
2865 distinguishes between boolean and text columns but I'll need to add
2866 support for more types.
2867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2868 column type in the ColumnInfo object. Add method to convert between the
2869 glom field type enum in ColumnInfo and the glom field type in libglom.
2870 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2872 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2873 getting and setting booleans.
2875 2011-03-25 Ben Konrath <ben@bagu.org>
2877 Don't get the Date twice from the ResultSet.
2879 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2881 2011-03-25 Ben Konrath <ben@bagu.org>
2883 Cleanup code in the servlet.
2885 * TODO: Remove item about row count. Add item about testing row count
2886 query with large number of rows.
2887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2888 spelling mistakes, change method parameter to be consistent with
2891 2011-03-25 Ben Konrath <ben@bagu.org>
2893 Add server side logging with the gwt-log library.
2895 * .gitignore: Ignore the log file we're now producing.
2896 * TODO: Add a couple TODO item for logging.
2897 * pom.xml: Add gwt-log and log4j as a dependency.
2898 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2899 logging of errors, warnings and some important info.
2900 * src/main/resources/log4j.properties: New file to configure log4j.
2902 2011-03-24 Ben Konrath <ben@bagu.org>
2904 Add a disable button for the Details view.
2906 * src/main/java/org/glom/web/client/LayoutListView.java:
2908 2011-03-22 Ben Konrath <ben@bagu.org>
2910 Use a count query to get the number of rows for the list view pager.
2912 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2914 2011-03-22 Ben Konrath <ben@bagu.org>
2916 Add more TODO information about CellTable pager positioning.
2920 2011-03-19 Ben Konrath <ben@bagu.org>
2922 Add TODO item about CellTable pager positioning.
2926 2011-03-18 Ben Konrath <ben@bagu.org>
2928 Remove unneeded GlomFieldColumn class.
2930 This is just a small code cleanup.
2932 * src/main/java/org/glom/web/client/LayoutListView.java:
2934 2011-03-18 Ben Konrath <ben@bagu.org>
2936 Use cursor mode in the query that gets data for the list view.
2938 I still need to fix the potential memory problem when getting the row
2939 count for the list view.
2941 * TODO: Add note about testing memory usage with large data sets. Add
2942 item about fixing row counting with large data sets.
2943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2944 PostgreSQL JDBC driver into cursor mode when getting data for the
2947 2011-03-15 Ben Konrath <ben@bagu.org>
2949 Remove the GWT Container from the Eclipse build classpath.
2951 The GWT dependencies are set by Maven so this isn't needed.
2955 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2957 Added some earlier mockups to git, but not to the tarball dist.
2959 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2960 Openismus. These hopefully show how we might structure the HTML so that
2961 it can be styled easily with CSS. However, we probably need to adapt them
2962 for the CSS structure that GWT dictates for common widgets.
2964 2011-03-14 Ben Konrath <ben@bagu.org>
2966 Locate OnlineGlom.properties using the ServletContext.
2968 This is required to be able to locate the file in the deployed servlet.
2970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2971 Configure the database and glom document in in a helper method so
2972 that the ServletContext can be used to locate OnlineGlom.properties.
2973 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2974 src/main/webapp. This is the proper location for .properites files.
2976 2011-03-12 Ben Konrath <ben@bagu.org>
2978 Add note to README about why we're compiling down to obfuscated JavaScript.
2982 2011-03-11 Ben Konrath <ben@bagu.org>
2984 Use properties file to configure servlet.
2986 This allows people to change the glom file path, db username and db
2987 password without recompiling the code.
2989 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2990 * src/main/webapp/OnlineGlom.properties:
2992 2011-03-11 Ben Konrath <ben@bagu.org>
2994 Use table fields in layout list view if the layout list is not defined.
2996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2997 Manually create a LayoutFieldVector for the query builder using the
2998 table fields when a layout list is not defined in the glom file.
3000 2011-03-11 Ben Konrath <ben@bagu.org>
3002 Only show FIXME string for images when there's an image.
3004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
3005 in this change are some small code cleanups.
3007 2011-03-11 Ben Konrath <ben@bagu.org>
3009 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3013 2011-03-11 Ben Konrath <ben@bagu.org>
3015 Correctly set the index of the default table.
3017 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3018 Correctly set the index of the default table. Add commented out example
3021 2011-03-10 Ben Konrath <ben@bagu.org>
3023 Add comment to pom.xml about the previous change.
3025 * pom.xml: Add comment about the deployment issue so that it's obvious
3026 why java-libglom is set to the provided scope.
3028 2011-03-10 Ben Konrath <ben@bagu.org>
3030 Change java-libglom dependency from compile to provided in pom.xml.
3032 Since java-libglom uses jni it can only be loaded once and therefore
3033 must be placed in $CATALINA_HOME/lib and not included in each war.
3034 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3035 More information about this issue can be found in the Tomcat 6 release
3036 notes in the "JNI Based Applications" section:
3038 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3040 * README: Remove note about this issue. Deployment info should really
3041 be on the wiki anyway so I'll add it right now.
3042 * pom.xml: Change java-libglom dependency from compile to provided so
3043 that it's copied in to the packaged war.
3045 2011-03-09 Ben Konrath <ben@bagu.org>
3047 Change to using a neutral locale for currency, date and time formatting.
3049 This solves the problem of currency values being represented without a
3050 space between the currency code and the number (e.g. "EUR5.89" is now
3051 represented as "EUR 5.89"). More work is required when we implement
3052 a locale preference setting.
3054 * TODO: Add note about currency formatting issues with different
3056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3057 to using the neutral ROOT locale.
3059 2011-03-09 Ben Konrath <ben@bagu.org>
3061 Add support for currency codes that are not ISO 4217 codes.
3063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3064 the currency code defined in the glom file when it's not 3 characters
3065 long or when Java doesn't recognize the string as an ISO 4217 code.
3067 2011-03-08 Ben Konrath <ben@bagu.org>
3069 Remove test classes, launch configurations and configuration.
3071 The test stuff was getting in the way when creating the war. To make
3072 the war file you can now do 'mvn clean package'. The packaged war file
3073 will be in the target directory.
3075 * .classpath: Remove unused classpathentry for tests and i18n.
3076 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3077 property. Don't run test or i18n goals when packaging the war.
3078 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3083 * OnlineGlomTest-dev.launch:
3084 * OnlineGlomTest-prod.launch:
3085 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3086 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3088 2011-03-07 Ben Konrath <ben@bagu.org>
3090 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3092 These fixes allow me to use 'mvn deploy' to create the war file.
3094 * .classpath: This generated config has been updated by Eclipse. This
3095 change was probably triggered by me updating from Eclipse 3.6.1 to
3097 * .gitignore: Add entry to ignore the directory
3098 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3099 * .project: The generated config has been updated by Eclipse. This
3100 change was probably triggered by me updating from Eclipse 3.6.1 to
3102 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3103 so that Eclipse doesn't complain
3104 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3105 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3106 'tests' directory to 'client' directory. This is the new
3107 gwt-maven-plugin convension.
3108 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3109 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3111 2011-03-07 Ben Konrath <ben@bagu.org>
3113 Add support for horizontal alignment in the LayoutList columns.
3115 * TODO: Remove item about horizontal alignment. Add item about
3116 improvements to ColumnInfo.
3117 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3118 alignment on the columns. Use ColumnInfo RPC object get the column
3119 title and horizontal alignment.
3120 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3121 LayoutListView creation with ColumnInfo RPC object.
3122 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3123 a ColumnInfo object for every LayoutList columnn. Convert the
3124 FieldFormatting.HorizontalAlignment to the correct
3125 ColumnnInfo.HorizontatlAlignment with the new
3126 getColumnInfoHorizontalAlignment helper method.
3127 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3128 to encapsulate column information like alignment and title. This
3129 could be used to set the colour instead of on a per cell field basis.
3130 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3131 column title storage and retrieval with ColumnInfo.
3133 2011-03-04 Ben Konrath <ben@bagu.org>
3135 Add support for column sorting.
3137 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3138 AsynDataProvider to be an anonymous inner class. Use new
3139 getSortedTableData RPC method when column sort is requested. Set all
3140 columns sortable and add an AsyncHandler to activate sorting in the
3142 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3143 method getSortedTableData(). Cleanup other method signatures.
3144 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3145 new method getSortedTableData(). Cleanup other method signatures.
3146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3147 Implement getSortedTableData() and getTableData() methods by using a
3148 private helper method with the appropriate parameters filled in. Use
3149 user supplied sort clause when supplied, otherwise fall back to
3150 sorting by the primary key. Move destroy() method to be underneath
3151 constructor for readability. Cleanup comments.
3153 2011-03-03 Ben Konrath <ben@bagu.org>
3155 Add support for colour text and colour backgrounds to the layout list cells.
3157 Only the cell backgrounds are coloured which leaves a gap between the
3158 cells that isn't coloured. I need to figure out a way to set
3159 'style=background-colour:' on the whole column rather than just the
3162 * TODO: Add a note about colouring the background of the whole column.
3163 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3164 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3165 render the coloured text and backgrounds. Use GlomField[] for the row type.
3166 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3168 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3169 GlomField[] for the row type.
3170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3171 GlomField[] for the row type. Set the text, text colour and background
3172 colour in the GlomField objects as specified in the glom document. Add
3173 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3174 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3175 the glom field text, foreground colour and background colour.
3177 2011-03-02 Ben Konrath <ben@bagu.org>
3179 Don't display hidden tables in the combo box.
3181 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3184 code to ignore hidden tables using ArrayLists for the table names and
3186 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3187 tableNames to use ArrayLists instead of String[]. Update getter and setter
3190 2011-03-01 Ben Konrath <ben@bagu.org>
3192 Add support for Date and Time number types.
3194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3195 Implement formatting for Date and Time values. Change the default glom
3196 file to small business example.
3198 2011-03-01 Ben Konrath <ben@bagu.org>
3200 Add support for formatting glom types as specified in the glom file.
3202 Formatting isn't finished yet - I still need to add support for Date
3205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3206 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3207 checks for null values in JDBC cleanup code and catch all exceptions
3208 instead of just SQLExceptions.
3209 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3212 2011-03-01 Ben Konrath <ben@bagu.org>
3214 Use GWT 2.2.0 instead of 2.1.1.
3216 * pom.xml: Change GWT version numbers.
3218 2011-03-01 Ben Konrath <ben@bagu.org>
3220 A few small code cleanups.
3222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3224 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3225 unnecessary object creation in constructor.
3226 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3227 unnecessary object creation in constructor.
3229 2011-02-28 Ben Konrath <ben@bagu.org>
3231 Add file for TODO list.
3235 2011-02-18 Ben Konrath <ben@bagu.org>
3237 Enable the CellTable Pager when more than 20 rows need to be viewed.