1 2012-05-25 Murray Cumming <murrayc@murrayc.com>
3 Document.load(): Support version 7 documents.
5 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
6 database_title attribute if the title attribute is not there.
8 2012-05-24 Ben Konrath <ben@bagu.org>
10 Add configuration for auto-generating mvn:i18n from with Eclipse.
12 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
14 2012-05-24 Murray Cumming <murrayc@murrayc.com>
16 Update translations, adding French.
18 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
19 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
20 Add a French translation, using the translation from Glom.
22 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
23 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
24 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
25 Update these based on the translations from Glom.
27 2012-05-24 Murray Cumming <murrayc@murrayc.com>
29 SelfHoster: Add some debug println messages to help when things fail.
31 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
32 System.out.println() lines.
34 2012-05-23 Murray Cumming <murrayc@murrayc.com>
36 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
38 * src/test/java/org/glom/web/server/SelfHoster.java:
39 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
40 instance) instead of just /usr/bin (as on Fedora). Check the result when
43 2012-05-23 Murray Cumming <murrayc@murrayc.com>
45 Remove LayoutItemPortal.get/setNavigationTable().
47 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
48 Remove get/setNavigationTable(), which is only a cache, because it is not
49 used, and does not need to be used, because that decision should be made on
51 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
52 updatePortalsExtras():
53 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
54 getNavigationRecord():
55 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
58 2012-05-21 Murray Cumming <murrayc@murrayc.com>
60 Initial self-hosting for tests.
62 * pom.xml: Change the scope for log4j, to hopefully make it
63 available to the test code which uses it indirectly via jOOQ.
64 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
65 self-hosting, though we only use it for testing.
67 * src/main/java/org/glom/web/server/libglom/Document.java:
68 example rows: Use a map instead of a list for each row of values,
69 so we know what field they are for, instead of relying on the sequence
70 being correct. This is not very efficient, but it does not really need
72 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
73 testReadTableExampleRows(): Adapted.
75 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
76 that returns an Object, for generic use. Note that Object seems to be
77 the implicit base even of double.
78 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
79 for use in CREATE TABLE SQL queries.
80 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
81 to do self-hosting of PostgreSQL databases via its command-line
82 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
83 backends/postgres_self.cc. This is incomplete - it needs more
84 warnings about failures and it needs to clean up properly when things
86 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
87 test of this new class.
89 2012-05-21 Murray Cumming <murrayc@murrayc.com>
91 Document: loading example data: Handle exceptions.
93 * src/main/java/org/glom/web/server/libglom/Document.java:
94 DateFormat.parse() and Double.valueOf() can throw exceptions, though
95 Eclipse did not warn about that.
97 2012-05-20 Murray Cumming <murrayc@murrayc.com>
99 Document: load(), save(): Handle the example rows.
101 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
103 * src/main/java/org/glom/web/server/libglom/Document.java:
104 load(), save(): Load and save the example rows, though the date, time
105 and image types are not handled properly yet.
106 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
107 Add testReadTableExampleRows() just to check that something is read.
109 2012-05-20 Murray Cumming <murrayc@murrayc.com>
111 Document: Add save().
113 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
114 Added getTranslationsMap() for use while saving.
115 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
116 Adedd getUseDefaultFormatting() for use while saving.
117 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
118 and several private methods that it uses.
120 This will be useful while testing via self-hosting.
121 It is not complete, but should be complete enough for testing.
123 2012-05-17 Murray Cumming <murrayc@murrayc.com>
125 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
127 * src/main/java/org/glom/web/client/OnlineGlomService.java
128 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
130 Remove getSortedListViewData() and getSortedRelatedListData(), adding
131 the sort column index and ascending bool to the regular method.
132 Instead, a sort column index of -1 now means no sort.
133 This is less explicit, but it's fairly simple, reduces the amount of
134 code, and makes the OnlineGlomService API slightly smaller.
135 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
136 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
138 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
139 getListViewData(), getRelatedListData():
140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
141 getListViewData(), getRelatedListData():
142 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
144 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
146 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
151 2012-05-16 Murray Cumming <murrayc@murrayc.com>
153 Use translations for top-level groups too.
155 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
156 updateTitlesForLocale(): Use the translation for the group
157 as well as for child items.
161 Just recompiled to fix a problem in the released .tar.gz file.
165 2012-05-15 Murray Cumming <murrayc@murrayc.com>
167 Corrections to navigation to related records.
169 * src/main/java/org/glom/web/client/OnlineGlomService.java:
170 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
172 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
173 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
174 relationship name, because the relationship name is not necessarily unique
176 TOOD: This is inefficient, because it passes the whole list of
177 child field items back to the server, but it is more correct, and happens
178 to fix a bug with the primary key being lost after a few navigations.
179 There is probably a chance to make this more efficient anyway in some
182 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
183 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java
185 * src/main/java/org/glom/web/server/database/DBAccess.java
186 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
187 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
190 2012-05-15 Murray Cumming <murrayc@murrayc.com>
192 Fix the use of translations.
194 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
195 Add updateTitlesForLocale().
196 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
197 Call it to discard unwanted translations and to make getTitle() return
198 the wanted translation wihout the need for the client code to specify a locale.
199 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
200 getTitle(): Fallback to the original title, as libglom does.
202 2012-05-15 Murray Cumming <murrayc@murrayc.com>
204 Document: Correctly report the number of available translation locales.
206 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
207 the available locale IDs list.
208 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
209 testLocales: Test this.
211 2012-05-15 Murray Cumming <murrayc@murrayc.com>
213 SqlUtils: Use camelCase.
215 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
216 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
217 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
218 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
219 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
220 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
222 2012-05-15 Murray Cumming <murrayc@murrayc.com>
224 Use jOOQ's tableByName() and fieldByName.
226 * pom.xml: Use jOOQ 2.3.1 to get the new API.
227 * src/main/java/org/glom/web/server/SqlUtils.java:
228 build_sql_select_step_with_where_clause(), .createField(),
229 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
230 so we can get correct quoting and escaping. Thanks to Lukas Eder for
231 adding this, and other things, to jOOQ.
233 2012-05-15 Murray Cumming <murrayc@murrayc.com>
235 SqlUtils: Remove the Connection parameters.
237 * src/main/java/org/glom/web/server/SqlUtils.java:
238 build_sql_select_with_key(), build_sql_select_with_where_clause(),
239 createSelect(), build_sql_select_step_with_where_clause(),
240 build_sql_count_select_with_where_clause(),
241 build_sql_select_count_rows(): Remove the Connection parameter because
242 jOOQ does not actually need a connectionwhen it is just used to build
244 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
246 * src/main/java/org/glom/web/server/ReportGenerator.java:
248 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
250 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
251 Constructor, getListData(), getResultSizeOfSQLQuery():
252 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
253 getSelectQuery(), getCountQuery():
254 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
255 getSelectQuery(), getCountQuery():
256 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
257 getNavigationRecord(): Adapted.
259 2012-05-14 Murray Cumming <murrayc@murrayc.com>
263 * src/main/java/org/glom/web/server/SqlUtils.java:
264 get_find_where_clause_quick(): Use a comparison of
265 lowercase values, instead of a simple equals. Regular Glom
266 uses the PostgreSQL ILIKE operator but jOOQ does not
267 support that just yet, though it will soon.
269 2012-05-14 Murray Cumming <murrayc@murrayc.com>
271 TableToViewDetails: Use a real serialization ID.
273 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
274 Though this does not fix the serialization problem.
276 2012-05-12 Murray Cumming <murrayc@murrayc.com>
278 Added LayoutItemPortalDeepCloneTest.
280 2012-05-11 Murray Cumming <murrayc@murrayc.com>
282 Make navigation work again.
284 * src/main/java/org/glom/web/server/libglom/Document.java:
285 Add getLayoutItemFieldShouldHaveNavigation().
286 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
287 Replace get/setAddNavigation() with the partly-existing
288 get/setNavigationTableName(), with an empty string being no navigation,
289 because this is simpler. Use the new
290 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
292 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
293 Add updateFieldsExtras() and call setNavigationTableName in it.
294 getDetailsLayoutGroup(),
295 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
296 createLayout(): Adapted.
297 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
298 Constructor: Adapted.
300 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
301 Replace get/setAddNavigation() with get/setNavigation(), returning a
302 TableToViewDetails class with both the table name and UsesRelationship,
303 because both are need. The previous code used java-libglom's output
304 variable (strangely, via sharedptr) to return both, but we cannot really
306 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
307 getNavigationRecord(): Adapt. However, we cannot actually use the cache
308 here because it somehow gets set to null during deepCopy(). I must test this.
309 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
310 testGetSuitableTableToViewDetails(): Adapted.
312 TODO: Find out why deepClone() is not quite working.
314 2012-05-11 Murray Cumming <murrayc@murrayc.com>
316 DBAccess: Simplify the retrievel of full field details.
318 * src/main/java/org/glom/web/server/database/DBAccess.java
319 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
320 because the Document loading should have done this.
322 2012-05-11 Murray Cumming <murrayc@murrayc.com>
324 Document: Correct loading of doubly-related layout fields.
326 * src/main/java/org/glom/web/server/libglom/Document.java:
327 loadUsesRelationship(): Actually set the related relationship, instead
328 of only setting it if it's not found.
330 2012-05-09 Murray Cumming <murrayc@murrayc.com>
332 Replace all appearances of Colour with color.
334 Because US English is dominant.
336 2012-05-09 Murray Cumming <murrayc@murrayc.com>
338 Use colors in HTML format, solving a warning about an unused function.
340 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
341 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
342 Add *asHTMLColor() versions of methods.
343 TODO: However, we should create and cache the results on the server.
344 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
345 * src/main/java/org/glom/web/client/ui/list/ListTable.java
346 * src/main/java/org/glom/web/server/ConfiguredDocument.java
347 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
348 Use the asHTMLcolor() versions.
350 2012-05-09 Murray Cumming <murrayc@murrayc.com>
352 ListViewTable: Constructor: Take the table name as a parameter.
354 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
355 Constructor: Take the tableName, and set the member variable, because
357 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
358 setCellTable(): Pass the table name.
359 This makes navigation to non-default tables work again. I don't know
360 why it worked before in the master branch.
362 2012-05-07 Murray Cumming <murrayc@murrayc.com>
364 ConfiguredDocument: Restore correct addition of hidden primary key items.
366 * src/main/java/org/glom/web/client/ui/list/ListTable.java
367 (ListTable.createCellTable): Uncomment out the check for the hidden
369 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
370 add primary key items for top-level lists and portals, as before,
371 instead of adding them to each group.
372 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
373 Actually implement the extra methods such as setHiddenPrimaryKey() and
374 comment that these are used only for top-level list groups and in portals.
375 This strangeness suggests even more that this should not be squeezed
376 into the LayoutGroup class.
378 2012-05-07 Murray Cumming <murrayc@murrayc.com>
380 Fix Formatting loading.
382 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
383 getFormattingUsed(): Remove the duplicate Formatting member variable
384 in favour of the one from the base class.
385 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
386 Initialize a new Formatting instead of using null by default, so we
387 have some defaults, instead of having to initialize one later just to
388 get the same defaults. This also makes loading of formatting from the
389 document work, because that expected a non-null.
391 2012-05-07 Murray Cumming <murrayc@murrayc.com>
393 RelatedListTable: Make sure that the tableName is set.
395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
396 Constructor: Take the tableName so it is available later. Otherwise,
397 the server assumes that we mean the default table and cannot find the
399 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
400 setData(): Pass the tableName to the RelatedListTable constructor.
402 2012-05-07 Murray Cumming <murrayc@murrayc.com>
406 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
407 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
408 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
410 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
412 * src/main/java/org/glom/web/server/database/DBAccess.java:
413 convertResultSetToDTO(), getPortal():
414 * src/main/java/org/glom/web/server/database/ListDBAccess.java
416 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
417 Add checks for null objects and out of range access, with log messages to
418 give hints so we can fix these properly.
420 2012-05-07 Murray Cumming <murrayc@murrayc.com>
422 Portals: some corrections.
424 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
426 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
427 constructor: Use getRelationshipNameUsed() instead of getName(), because
428 that is what is meant.
429 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
430 getFromField(): Fix a typo, to get the field name, not the table name.
431 * src/main/java/org/glom/web/server/database/DBAccess.java:
432 getPortal(): Fix a typo that stopped this from working.
434 2012-05-07 Murray Cumming <murrayc@murrayc.com>
436 LayoutItemPortal: Also override getTitleOriginal().
438 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
439 This lets the base getTitle() with no parameters work.
440 TODO: Test this properly.
442 2012-05-06 Murray Cumming <murrayc@murrayc.com>
444 LayoutItemPortal: getTitle*(): Use the relationship title.
446 2012-05-06 Murray Cumming <murrayc@murrayc.com>
448 LayoutItemField: Fix loading of custom titles.
450 * src/main/java/org/glom/web/server/libglom/Document.java
451 loadDataLayoutItemField(): The title, if any, instead of the field
452 title, is stored in a title_custom node. Load it from there.
453 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
455 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
456 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
457 getTitle*() overrides.
458 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
461 2012-05-06 Murray Cumming <murrayc@murrayc.com>
463 LayoutItemField: Fall back to field titles, so some are really shown.
465 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
466 Override getTitleOriginal() and getTitle(), as in java-libglom.
467 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
470 2012-05-06 Murray Cumming <murrayc@murrayc.com>
472 Correct use of setExpectedResultSize().
474 * src/main/java/org/glom/web/server/ConfiguredDocument.java
475 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
476 Use setExpectedResultSize only on top-level groups (for instance, the
477 list layout) or on child portals (in details views).
478 Use the correct table name for portals to avoid SQL errors.
479 Update the expected counts when returning cached layouts.
481 2012-05-06 Murray Cumming <murrayc@murrayc.com>
483 Document: Interpret no group column count as 1.
485 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
486 default, though we now check for this in the UI code anyway.
488 2012-05-06 Murray Cumming <murrayc@murrayc.com>
492 2012-05-06 Murray Cumming <murrayc@murrayc.com>
494 Translatable: Use Hashmap instead of Treemap because GWT supports it.
496 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
497 The use of Treemap lead to this error from async methods, with no
499 "The response could not be deserialized"
501 2012-05-06 Murray Cumming <murrayc@murrayc.com>
503 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
505 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
506 when using the Google -> GWT Compile, or
507 g toolbar button -> GWT Compile Project... feature in Eclipse.
509 2012-05-06 Murray Cumming <murrayc@murrayc.com>
511 ListTable.addColumn(): Protect against a null Formatting.
513 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
514 Create a default Formatting if it is null, because that is the simplest
517 2012-05-06 Murray Cumming <murrayc@murrayc.com>
519 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
521 * src/main/java/org/glom/web/server/ConfiguredDocument.java
522 updateLayoutGroup(): Check that the field is not null.
524 2012-05-06 Murray Cumming <murrayc@murrayc.com>
526 ListViewImpl: Protected against a bad cast error.
528 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
529 onEnterKeyDown(): Do not cast without an instanceof check.
531 2012-05-06 Murray Cumming <murrayc@murrayc.com>
533 ListTable: Protect against an out of range error.
535 * src/main/java/org/glom/web/client/ui/list/ListTable.java
536 createCellTable(): This is unlikely, but can happen while debugging.
538 2012-05-06 Murray Cumming <murrayc@murrayc.com>
540 AsyncMessage onFailure() callbacks: Log the exception message.
542 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
543 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
544 * src/main/java/org/glom/web/client/activity/ListActivity.java:
545 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
546 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
547 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
548 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
549 These are useful clues when something is wrong.
551 2012-05-06 Murray Cumming <murrayc@murrayc.com>
553 ConfiguredDocument: Avoid a null dereference.
555 * src/main/java/org/glom/web/server/ConfiguredDocument.java
556 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
557 details maps are created.
559 2012-05-06 Murray Cumming <murrayc@murrayc.com>
561 Document: Correct the port number parsing.
563 * src/main/java/org/glom/web/server/libglom/Document.java:
564 This lets us actually connect to the database and show the document.
566 2012-05-05 Murray Cumming <murrayc@murrayc.com>
570 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
571 user-interaction, asking us to load a temporary URL in a browser.s
572 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
573 which is apparently necessary for testing the service. See the comment.
574 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
575 Show the exception, if any. This is how I saw the 404 in the HTML in
578 2012-05-05 Murray Cumming <murrayc@murrayc.com>
580 DocumentTest: Move the .glom files into the resources directory.
582 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
583 URI via getResource().
585 2012-05-05 Murray Cumming <murrayc@murrayc.com>
587 Document: Remove the FieldIdentifies inner class.
589 * src/main/java/org/glom/web/server/libglom/Document.java: We only
590 use the Relationship (though the same function in libglom is maybe
591 used in other ways) and so this removes a compiler warning.
593 2012-05-05 Murray Cumming <murrayc@murrayc.com>
595 Document.load() Remove the error code parameter.
597 * src/main/java/org/glom/web/server/libglom/Document.java: load():
598 Remove the parameter. We do not set it yet and it could never have
599 worked as an output parameter (though maybe it did in java-libglom).
600 We could use an exception if we really want the failure reason.
601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
603 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
604 setUp(), testGetSuitableTableToViewDetails(): Adapt.
606 2012-05-05 Murray Cumming <murrayc@murrayc.com>
608 Make some inner classes static.
610 * src/main/java/org/glom/web/server/ConfiguredDocument.java
611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
612 * src/main/java/org/glom/web/server/ReportGenerator.java
613 * src/main/java/org/glom/web/server/libglom/Document.java
614 Make all inner classes static that can be static.
616 2012-05-05 Murray Cumming <murrayc@murrayc.com>
618 OnlineGlomServiceImpl: Do not load and check for java-libglom.
620 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
621 init(): We do not use java-libglom any more.
623 2012-05-05 Murray Cumming <murrayc@murrayc.com>
625 Remove mentions of java-libglom.
627 * README: Remove mention of java-libglom, because it no longer needed.
628 * utils/build-onlineglom-war.sh:
629 * utils/check-and-recover-tomcat.py:
630 * utils/install-onlineglom-war.sh: Remove these as they are no longer
631 useful. Building is now far easier, with no need for jhbuild.
633 2012-05-05 Murray Cumming <murrayc@murrayc.com>
635 Fix the build (mvn package)
637 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
638 (LayoutGroup): Make the LayoutItemList inner class static and protected.
639 Otherwise the GWT Java->Javascript compilation fails with just this
640 error, during mvn package or when attempting to view in a browser,
641 in the GWT developer mode in Eclipse.
643 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
644 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
645 [INFO] Compiling module org.glom.web.OnlineGlom
646 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
647 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
648 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
649 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
650 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
651 [INFO] [ERROR] Cannot proceed due to previous errors
653 It has taken me 2 days to find out what was causing that. After reducing
654 the code, the compiler eventually showed me the full error message.
656 2012-05-04 Murray Cumming <murrayc@murrayc.com>
658 ConfiguredDocument: Cache the cloned and stripped layouts.
660 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
661 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
662 layout in a map, so we can retrieve it again without rebuilding it.
664 2012-05-04 Murray Cumming <murrayc@murrayc.com>
666 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
668 2012-05-04 Murray Cumming <murrayc@murrayc.com>
670 libglom classes: Implement some auto-generated emthods.
672 2012-05-04 Murray Cumming <murrayc@murrayc.com>
674 Add GwtTestOnlineGlomService.
676 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
677 However, this (and the other GwtTest*) does not seem to run during
680 2012-05-04 Murray Cumming <murrayc@murrayc.com>
682 Remove use of unsupported features from client code.
684 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
685 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
686 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
687 Use our client version of StringUtils instead of the apache commons one.
689 However, the GWT Javascript compliation still fails.
691 2012-04-25 Murray Cumming <murrayc@murrayc.com>
693 Add a Field class and implement some loading of it in Document.
695 2012-04-25 Murray Cumming <murrayc@murrayc.com>
697 Initial Document loading implementation, instead of libglom.
699 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
700 and Translatable classes, and adapt the rest of the code to use them.
701 However, this is still missing Layout and Field classes and loading.
703 2012-04-24 Murray Cumming <murrayc@murrayc.com>
705 Use of jOOQ: Move Field creation into a utility method.
707 * src/main/java/org/glom/web/server/SqlUtils.java:
708 This lets us improve it more easily.
710 2012-04-24 Murray Cumming <murrayc@murrayc.com>
712 Use of jOOQ: Improve the code to COUNT a sub-select.
714 * src/main/java/org/glom/web/server/SqlUtils.java:
715 Move initial query creation into
716 build_sql_select_step_with_where_clause().
717 build_sql_select_count_rows(): Use the jOOQ API instead of
718 concatentating text, because a jOOQ Select*Step is a TableLike,
719 which is what from() takes.
721 2012-04-23 Murray Cumming <murrayc@murrayc.com>
723 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
725 * pom.xml: Depend on jooq.
726 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
727 methods with jOOQ, based on the C++ implementations in libglom,
728 with some changes to the logic required by jooQ.
729 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
731 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
732 * src/main/java/org/glom/web/server/ReportGenerator.java:
733 * src/main/java/org/glom/web/server/SqlUtils.java:
734 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
735 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
736 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
737 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
738 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
739 Adapt. In particular, the SqlUtils methods now need to take a Connection,
740 because jOOQ needs that, though it seems unnecessary.
742 This is not quite finished. Ideally jOOQ would help us to build
743 table_name.field_name names, quoting and escaping them properly.
744 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
746 2012-04-21 Murray Cumming <murrayc@murrayc.com>
748 Move use of Glom.build_sql*() into a new SqlUtils class.
750 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
751 to wrap Glom.build_sql*(). The parameter types are still Glom one,
752 but this will make it easier to start using something other than
753 libglom or SqlBuilder.
755 2012-04-21 Murray Cumming <murrayc@murrayc.com>
757 Update the project URL.
759 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
761 2012-04-21 Murray Cumming <murrayc@murrayc.com>
763 Main layout: Use a FlowTable instead of absolute positioning.
765 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
766 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
767 child panels/widgets must have an absolute position. But that is annoying, so
768 this adds a FlowTable and puts the child panels in there.
770 2012-04-21 Murray Cumming <murrayc@murrayc.com>
772 GwtTestOnlineGlom: Comment out unused code.
774 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
775 Eclipse has started to say that some code is unused.
777 2012-04-21 Murray Cumming <murrayc@murrayc.com>
779 Update to the latest versions of dependencies.
781 * pom.xml: Update version numbers of dependencies to the latest
783 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
785 * src/main/java/org/glom/web/server/ReportGenerator.java:
786 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
787 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
788 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
790 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
791 Modify the imports where necessary.
793 2012-04-17 Murray Cumming <murrayc@murrayc.com>
795 Style: Remove overflow:hidden from searchbox
797 * src/main/webapp/style.css: Because this pushes the Back To Link
798 label/link on to the next row, which is then hidden due to the
799 hard-coded (in ems) height.
801 2012-04-20 Murray Cumming <murrayc@murrayc.com>
803 Remove some duplicate code.
805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
806 getDocumentInfo(): This must have been duplicated during the merge from the
811 2012-04-19 Murray Cumming <murrayc@murrayc.com>
813 Reports: Localize the waiting for report message.
815 * src/main/java/org/glom/web/client/activity/ReportActivity.java
816 start(): Get the message from the contants.
817 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
819 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
820 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
821 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
822 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
823 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
824 Update these files with the English text for newer strings for now.
826 2012-04-19 Murray Cumming <murrayc@murrayc.com>
828 Reports: Show a message while waiting for the report.
830 * src/main/java/org/glom/web/client/ui/ReportView.java
831 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
832 Add setWaitingText(), to show a message saying that we are
833 waiting for the report to be ready.
834 * src/main/java/org/glom/web/client/activity/ReportActivity.java
835 start(): Call setWaitingText() before calling the async
838 2012-04-19 Murray Cumming <murrayc@murrayc.com>
840 ReportGenerator: Specify date and time formats.
842 * src/main/java/org/glom/web/server/ReportGenerator.java:
843 createFieldValueElement(): Use the default (and localized)
844 short formats, though we still need a way to show 4-digit
845 years without providing the format for every locale.
846 * src/main/java/org/glom/web/server/database/DBAccess.java:
847 convertResultSetToDTO(): Use the short formats here too.
849 2012-04-18 Murray Cumming <murrayc@murrayc.com>
851 ReportGenerator: Use the correct numeric formatting.
853 * src/main/java/org/glom/web/server/ReportGenerator.java
854 createFieldExpression(), createFieldValueElement(): Take the
855 whole LayoutItem_Field instead of just the field name, so
856 we have access to the formatting.
857 createFieldValueElement(): Use JRTextField.setPattern() to
858 specify the numeric formatting, with the help of a
859 regular DecimalFormat.
861 2012-04-18 Murray Cumming <murrayc@murrayc.com>
863 ReportGenerator: Avoid showing null for group by titles.
865 * src/main/java/org/glom/web/server/ReportGenerator.java
866 generateReport(): Use setBlankWhenNull() on the field title
867 style too, because this is used for values in group by
870 2012-04-18 Murray Cumming <murrayc@murrayc.com>
872 ReportGenerator: Add a colon to titles in vertical groups.
874 * src/main/java/org/glom/web/server/ReportGenerator.java
875 addFieldToDetailBandVertical(): Pass true for the withColon
878 2012-04-18 Murray Cumming <murrayc@murrayc.com>
880 ReportGenerator: Simplify the code by using Position more.
882 2012-04-18 Murray Cumming <murrayc@murrayc.com>
884 Reports: Support vertical groups, roughly.
886 * src/main/java/org/glom/web/server/ReportGenerator.java:
887 addToReport(): Rename to addGroupToReport() and, if necessary,
888 call the new addVerticalGroupToReport() method.
889 createFieldValueElement(): Let the caller specify the Y position
892 2012-04-17 Murray Cumming <murrayc@murrayc.com>
894 Reports: Allow a second report to be shown.
896 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
897 clear(): Do not remove the HTML widget, which broke the whole layout.
899 2012-04-17 Murray Cumming <murrayc@murrayc.com>
901 Locales drop-down: Show that we use English by default.
903 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
904 fillView(): When we use English, just because that is the default, when
905 no locale is specified, show that in the Locales drop-down instead of
906 just showing the first item.
908 2012-04-17 Murray Cumming <murrayc@murrayc.com>
910 Unselect the Report/Locale/Table combo item when appropriate.
912 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
913 setPlace(): clear reportName if this is not a ReportPlace.
914 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
915 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
916 When the provided name is empty, unselect all items, so that none are
917 indicated. This uses a for loop because I cannot find a single method
920 2012-04-17 Murray Cumming <murrayc@murrayc.com>
922 Report: Give the user a way to get back to the list.
924 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
925 start(), setPlace(): Show the Back To List link on reports, and also
926 interpret selecting the empty report item as back to list.
928 2012-04-13 Murray Cumming <murrayc@murrayc.com>
930 Really show the selected Report name.
932 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
933 setPlace(): Store the reportName here, if it is that kind of Place.
934 fillView(): Set the selected Report after filling the list of reports.
935 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
936 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
937 null Strings, though we need some way to unselect all ListBox items
940 2012-04-13 Murray Cumming <murrayc@murrayc.com>
942 ReportGenerator: Try to avoid some problems.
944 * src/main/java/org/glom/web/server/ReportGenerator.java
945 addField(): Try to avoid duplicates, and avoid using a null
948 2012-04-13 Murray Cumming <murrayc@murrayc.com>
950 Reports: Use quickFind.
952 * src/main/java/org/glom/web/client/OnlineGlomService.java;
953 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
955 getReportHTML(): Add a quickFind parameter.
956 * src/main/java/org/glom/web/client/activity/ReportActivity.java
957 start(): Pass the quickFind parameter.
958 * src/main/java/org/glom/web/server/ReportGenerator.java
959 generateReport(): Take a quickFind parameter.
961 2012-04-13 Murray Cumming <murrayc@murrayc.com>
963 ReportPlace: Actually use the report name.
965 * src/main/java/org/glom/web/client/place/ReportPlace.java
966 getPlace(): Do not assign the report name to the quickfind.
968 2012-04-13 Murray Cumming <murrayc@murrayc.com>
970 Show java.library.path when complaining.
972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
973 init(): When telling us to check java.library.path, show the
976 2012-03-06 Murray Cumming <murrayc@murrayc.com>
978 ReportGenerator: Do not show nulls.
980 2012-03-06 Murray Cumming <murrayc@murrayc.com>
982 ReportGenerator: Make the title font larger.
984 2012-03-06 Murray Cumming <murrayc@murrayc.com>
986 ReportGenerator: Put field titles inside groups, if there are groups.
988 2012-03-06 Murray Cumming <murrayc@murrayc.com>
990 ReportGenerator: Take the Report itself instead of the name and group.
992 * src/main/java/org/glom/web/server/ConfiguredDocument.java
993 Remove getReportLayoutGroup().
994 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
995 getReportHTML(): Pass the report instead
996 of its name and layout group.
997 * src/main/java/org/glom/web/server/ReportGenerator.java
998 generateReport(): Use the report object to use the title
1001 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1003 ReportGenerator: Remove designBand parameters.
1005 * src/main/java/org/glom/web/server/ReportGenerator.java:
1006 Make designBand a class member instead of passing it to all
1009 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1011 ReportGenerator: Add lines, a bit like in the desktop version.
1013 * src/main/java/org/glom/web/server/ReportGenerator.java
1014 addToReport(): Use JRDesignLine.
1016 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1018 ReportGenerator: Correct the title positions and use some bold style.
1020 * src/main/java/org/glom/web/server/ReportGenerator.java:
1021 Break the code up into reusable functions, correct the placement of
1022 titles, and use normal/bold styles as in the reports in the desktop
1025 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1027 ReportGenerator: Add a header band to show the field titles.
1029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1030 getReportHTML(): Pass the localeId to the ReportGenerator
1032 * src/main/java/org/glom/web/server/ReportGenerator.java
1033 constructor: Take the localeID so we can get translated field
1035 generateReport(), addToReport(), addFieldToBand(): Add field
1036 titles in a column header band.
1038 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1040 Reports drop-down list: Some improvement.
1042 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1043 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1044 Adedd setSelectedReport(),
1045 setReportList(): Add a blank line so that the user can select the
1047 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1048 start(): Show the current report by calling setSelectedReport().
1049 This does not seem to work yet.
1051 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1053 DetailsActivity, ListActivity: Move some variables into a base class.
1055 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1056 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1057 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1058 the clientFactory, documentID, tableName and authenticationPopup into
1059 a base class, to avoid duplication.
1061 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1063 Translate the Reports label.
1065 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1066 Get the "Reports" label string from the constants.
1067 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1068 perties: Add Reports to the constants.
1070 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1072 Reports: Implement grouping.
1074 * src/main/java/org/glom/web/server/ReportGenerator.java:
1075 Handle LayoutItem_GroupBy items and try to do the right thing
1076 with JRDesignGroup. It seems to work.
1078 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1080 Actually show some data with JasperReports.
1082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1083 getReportHTML(): Move most code into a ReportGenerator class.
1084 * src/main/java/org/glom/web/server/ReportGenerator.java:
1085 Recurse into sub-groups, adding fields to the JasperDesign's details
1086 band. Note that we must set an arbitrary width and height, or it just
1087 will not show any data.
1089 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1091 Reports Chooser: Show the titles, not the names.
1093 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1094 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1095 and the names as the values.
1096 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1097 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1098 group now that we provide the report name, so it should always
1101 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1103 Depend on jasperreports.
1105 * pom.xml: Add the dependency. My plan is to use this on the
1108 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1110 Implement navigation to report places.
1112 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1113 start(): Do not bother to handle all events here.
1114 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1115 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1116 Added getSelectedReport().
1117 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1118 .java: start(): When handling a change to the reports chooser,
1119 call getSelectedReport() and goTo() its ReportPlace.
1120 * src/main/java/org/glom/web/client/ui/ReportView.java
1121 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1122 Added setReportHTML() which puts the html in a gwt HTML widget.
1123 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1124 getReportHTML(): Return "TODO" just to show that this works.
1126 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1128 Make ReportPlace usable.
1130 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1131 Mention ReportPlace.
1132 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1133 Correct the @prefix annotation.
1135 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1137 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1139 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1140 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1141 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1142 Change getReportLayout() to getReportHMTL() because we will not need to
1143 parse or render the report layout on the client side.
1144 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1145 getReportLayout(): Return the libglom LayoutGroup type because we will
1146 not need to convert to a shared type, because this will not be used on
1148 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1151 Note that there is still no implementation for this.
1154 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1156 Add a (empty) Report Place, View, and Activity.
1158 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1160 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1161 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1162 this into a superclass:
1163 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1164 and also use it as the base of this new ReportPlace:
1165 * src/main/java/org/glom/web/client/place/ReportPlace.java
1167 * src/main/java/org/glom/web/client/ui/ReportView.java
1168 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1169 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1170 Add these, containing mostly boiler-plate for now.
1172 * src/main/java/org/glom/web/client/OnlineGlomService.java
1173 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1174 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1176 Add API to get the LayoutGroup for the report.
1178 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1180 Add and fill a Reports drop-down list box.
1182 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1184 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1185 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1187 Added getReports(document, table, localeID), calling
1188 ConfiguredDocument.getReports().
1189 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1190 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1191 Added setReportsList() and a list widget.
1192 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1193 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1198 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1200 Translations: Add Esperanto.
1202 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1203 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1204 properties: Add this translation because someone took the time to make it.
1206 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1208 Adapt to the java-libglom 1.21.7 API.
1210 * src/main/java/org/glom/web/server/ReportGenerator.java:
1211 addToReport(): get_group_secondary_fields() is now
1212 get_secondary_fields().
1215 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1217 Use the latest java-libglom version.
1219 * pom.xml: Use java-libglom 1.21.7.
1221 2012-03-03 Ben Konrath <ben@bagu.org>
1223 Display date and time in details view.
1225 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1227 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1229 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1231 Require the latest java-libglom.
1233 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1235 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1237 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1239 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1240 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1241 an empty quickfind string. I also corrected libglom to create only
1242 empty where clauses for empty quickfind strings, but this avoids the
1245 2012-02-24 Ben Konrath <ben@bagu.org>
1247 Improve the tabs in the Notebook widget.
1251 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1253 Translations: Try to translate the strings.
1255 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1256 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1257 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1258 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1259 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1260 Take the Open translation from GTK+'s .po files.
1261 Take the Details translation from Glom's po files.
1262 I have added the other strings to Glom so we can get translations that way:
1263 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1265 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1267 TableSelectionViewImpl: Put the search label and entry in a div.
1269 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1270 Put the search widgets in a FlowTable so that the CSS can be used to
1271 style them while keeping them together.
1272 * src/main/webapp/style.css: Mention the new div.
1274 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1276 Translate more strings in more locales.
1278 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1279 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1280 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1281 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1282 Translate the "Details" and "Open" string too.
1284 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1285 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1286 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1287 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1288 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1289 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1290 Add these new locales as placeholders though they currently contain English.
1292 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1294 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1297 Check the ConfiguredDocument* for null before using it.
1299 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1301 Tell Eclipse about the generated java files.
1303 * .classpath: This lets it find OnlineGlomConstants.java.
1304 It would be nice if Eclipse just used the maven build files.
1306 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1308 Prevent a crash when no locale is specified in the URL.
1310 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1311 Avoid returning a null string, obtained from
1312 Window.Location.getParameter(). This caused a crash when it was
1313 later passed to libglom's API.
1314 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1315 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1316 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1317 guard against future null strings.
1319 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1321 Use the ?locale= query param instead of the &lang= token param.
1323 * src/main/java/org/glom/web/client/place/ListPlace.java
1324 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1325 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1326 Remove the lang token key and value.
1328 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1329 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1330 When the user selects a different locale from the chooser, use
1331 Window.Location.assign() to change the URL, which then causes a reload.
1333 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1334 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1335 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1336 * src/main/java/org/glom/web/client/activity/ListActivity.java
1337 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1338 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1339 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1340 * src/main/java/org/glom/web/client/ui/ListView.java:
1341 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1343 Remove localeID member variables and method/constructor parameters, instead
1344 using Utils.getCurrentLocaleID() when we need a localID to pass to
1347 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1349 Internationalize the UI strings.
1351 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1352 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1353 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1354 because it is unused. Messages are apparently strings that can have
1355 parameters, but we do not need that yet, so Contants will be enough for now.
1356 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1357 to say that we support the en and de locales.
1358 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1359 The original English strings.
1360 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1361 Some German translations of the English strings.
1362 The i18n goal then uses the .properties file to generate an
1363 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1364 returns an implementation that returns the translated strings.
1365 The documentation suggests putting these in src/java/*/client/, but it seems
1366 best to put it in src/resources/*/client/.
1367 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1368 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1369 instead of hard-coding them.
1370 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1371 but that does not seem to stop the build, though it confuses Eclipse.
1373 You can see the translated string by adding ?locale=de to the URL, like so:
1374 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1376 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1378 Improve null/empty String checks.
1380 * pom.xml: Add a dependency on commons-lang, to use
1381 org.apache.commons.lang.StringUtils.
1382 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1383 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1385 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1386 Use StringUtils.isEmpty().
1388 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1389 StringUtils class with a static isEmpty() function because we
1390 cannot use org.apache.commons.lang.StringUtils in client-side
1391 GWT code because it (apparently) cannot be compiled to javascript.
1392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1393 * src/main/java/org/glom/web/client/activity/ListActivity.java
1394 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1395 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1396 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1397 * src/main/java/org/glom/web/client/place/ListPlace.java
1398 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1399 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1400 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1401 * src/main/java/org/glom/web/client/ui/details/Group.java
1402 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1403 our StringUtils.isEmpty() function.
1405 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1407 Update to the latest java-libglom API.
1409 * pom.xml: Require java-libglom 1.21.4.
1410 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1411 getDocumentInfo(), getListViewLayoutGroup():
1412 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1414 * src/main/java/org/glom/web/server/database/DBAccess.java
1415 getFieldsToShowForSQLQueryAddGroup(),
1416 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1417 with either get_database_title_original() or
1418 get_database_title(localeID).
1420 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1422 ConfiguredDocument: Avoid a null pointer exception.
1424 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1425 Initialize localeID to "" to avoid returning a null String which
1426 causes a crash in java-libglom's swing-generated code.
1428 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1430 Some simple renaming.
1432 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1433 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1434 for localeChooser. This seems more appropriate and is less ambiguous
1435 particularly in the .css file.
1437 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1439 ConfiguredDocument: Rename the localedID private member variable.
1441 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1443 Adapt to the latest java-libglom API from git master.
1445 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1446 libglom now uses only Vector instead of List, which uses add() instead of
1449 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1451 ConfiguredDocument: Rename the localedID private member variable.
1453 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1455 Build a source tarball with mvn assembly:single
1457 * assembly.xml: Add this file.
1458 * pom.xml: Use the maven-assembly-plugin and tell it to use
1459 our assembly.xml file.
1461 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1463 OnlineGlomServiceImpl: Get .glom files recursively.
1465 * pom.xml: Depend on commons-io from org.apache.commons.
1466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1467 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1468 files recursively, and with the easier filter for the extension.
1469 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1470 simplify that code too.
1472 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1474 README: Mention that you must install java-libglom packages separately.
1476 But then it works, because java-libglom is now in the central maven
1479 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1481 locales drop-down: Show the correct selected locale when the URL changes.
1483 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1484 .java: setPlace(): Move some code into fillView().
1486 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1488 locales drop-down: Do not lose the primary key.
1490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1491 start(): onLocaleChange(): Pass the current primary key value,
1492 instead of an empty value.
1494 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1496 locales drop-down: Do not lose the drop-down selection.
1498 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1499 .java (TableSelectionActivity.fillView): Set the selected locale
1500 after changing the drop-down items (though we do not really need
1501 to change them just because the locale changes.)
1503 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1505 locales drop-down: Change the tables list when this changes.
1507 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1508 .java: TableSelectionActivity.start(): Move the async table titles
1509 retrieval into a private fillView() method and also call this when
1510 the chosen locale changes.
1511 Note that the document title is not actually translatable yet, but
1512 that is a problem that I should fix soon in libglom.
1514 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1516 Improve the placement of the locales drop-down.
1518 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1519 Put the title and locales drop-down in a div (gwt.FlowTable).
1520 * src/main/webapp/style.css: Add magic css properties to make this work.
1521 Also remove the left margin from the title so that it lines up with the
1524 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1526 locales selector: Show human-readable locale titles.
1528 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1529 getDocumentInfo(): Use java.util.Locale to show a real title of
1530 each locale, in the locale's own language.
1532 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1534 Add a language/locale selector drop-down.
1536 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1537 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1538 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1539 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1540 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1541 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1542 Add a ListBox to show the available locales. Add getLocaleSelector(),
1543 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1544 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1545 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1546 java: Add these classes.
1547 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1548 start(): Fill the locales ListBox. Handle its change event, firing a
1550 setPlace(): Show the selected locale as specified by the URL token.
1551 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1552 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1553 Handle LocaleChangeEvent, going to a new *Place with that locale.
1555 The placement of the ListBox is not pretty, and it currently uses the ID
1556 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1560 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1562 Search box: Show the search text from the URL token.
1564 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1565 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1566 Add setQuickFindText().
1567 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1568 .java: setPlace(): Store the queryText if the place is a ListPlace,
1569 and call TableSelectionView.setQuickFindText().
1571 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1573 Allow use of translations via, for instance, &lang=de in the URL.
1575 * pom.xml: Use the unstable java-libglom 1.21 version.
1577 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1578 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1580 init(): Instead of calling TranslatableItem.set_current_locale()
1581 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1582 However, this is only for default locales, which are not needed to
1583 change the locale in the URL.
1584 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1585 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1586 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1587 layout for a particular locale.
1588 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1589 Add get/setDefaultLocaleID().
1590 getDocumentInfo(), getListViewData(), getRelatedListData(),
1591 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1592 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1593 localeID parameter, so we can get the layout for a particular locale.
1595 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1596 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1597 * src/main/java/org/glom/web/client/place/ListPlace.java:
1598 Parse and construct a lang parameter too.
1600 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1601 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1602 passed to subsequent methods and constructors.
1603 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1604 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1605 Store the localeID from the *Place and pass it to other constructors
1606 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1608 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1609 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1610 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1611 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1612 * src/main/java/org/glom/web/client/ui/ListView.java:
1613 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1614 Take localeID parameters and pass them to subsequent constructors and
1615 methods, so that the layout is always retrieved for that locale.
1617 This is rather repetitive.
1619 Note that "" means the original (default) locale of the Glom document,
1620 which is usually English.
1622 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1624 Documents: Remove final keyword to fix startup configuration.
1626 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1627 final keywords on the private member variables because that breaks
1628 the startup, apparently (there are warnings) because it stops them
1629 from being serialized. I added these in the previous commit.
1631 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1633 Documents: Add some final keywords.
1635 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1638 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1640 OnlineGlomServiceImpl: Add to overview comments.
1642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1643 Note that this is where all the document are loaded. They are not
1644 loaded freshly for each page.
1646 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1650 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1651 Add a TextBox for the text of a quick find.
1652 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1654 setBackLink(): Add a String quickFind parameter.
1655 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1656 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1657 to the base interface, because that is how TableSelectionViewImpl is used.
1658 * src/main/webapp/style.css: Add style for the search box and its label.
1660 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1661 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1662 Add these files, based on the existing TableChangeEvent and
1663 TableChangeEventHandlers.
1664 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1665 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1666 a ListPlace() that the user should be taken to.
1667 * src/main/java/org/glom/web/client/activity/ListActivity.java
1668 start(): Handle it here too and adapt the TableChangeEvent handler to
1669 pass the extra "" quickFind parameter to ListPlace.
1670 * src/main/java/org/glom/web/client/place/ListPlace.java:
1671 Constructor: Take an extra String quickFind parameter and store it,
1672 returning it from a new getQuickFind() method.
1673 getToken(): Put the quickFind text in the URL token.
1674 getPlace(): Parse the quickFind text from the URL token.
1675 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1676 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1677 ListPlace constructor.
1678 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1679 .java: start(): Add a Change handler for the TableSelectionView's
1680 TextBox (via its base HasChangeHandlers interface), firing the new
1681 QuickFindChangeEvent.
1682 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1683 pass the extra "" quickFind parameter.
1685 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1686 setCellTable(): Add a String quickFind parameter and pass it to
1687 the ListViewTable() constructor.
1688 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1689 setCellTable() in the base interface, because that is how ListViewImpl
1692 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1693 Add a String quickFind member variable.
1694 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1695 Constructor: Add a String quickFind parameter, storing it in the
1696 base ListTable's member variable.
1697 onRangeChanged(): Pass quickFind to the
1698 OnlineGlomServiceAsync.getSortedListViewData() and
1699 OnlineGlomServiceAsync.getListViewData() methods.
1701 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1702 getListViewData(), getSortedListViewData(): Add a String quickFind
1703 parameter, passing it to ConfiguredDocument.getListViewData().
1704 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1705 Change getListViewData(), getSortedListViewData() in the base interface,
1706 because that is how OnlineGlomServiceImpl is used, via this:
1707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1708 Change getListViewData(), getSortedListViewData() here too.
1709 This class can apparently be used to asynchronously call methods on
1710 OnlineGlomService, and GWT seems to implement that after recognizing
1711 just the *Async name convention and the extra AsyncCallback parameters.
1713 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1714 getListViewData(): Add a String quickFind parameter, and pass it to
1715 ListViewDBAccess.getData().
1716 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1717 getListData(): Add a String quickFind parameter and pass it to
1719 getSelectQuery(): Add a String quickFind parameter.
1720 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1721 getSelectQuery(): Add a String quickFind parameter and use it with
1722 Glom.get_find_where_clause_quick() to pass a where_clause to
1723 Glom.build_sql_select_with_where_clause(), to actually filter the
1725 getData(): Add a String quickFind parameter, passing it to getListData().
1726 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1727 va: getData(): Pass an empty string to getListData() for the
1728 quickFind parameter.
1730 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1732 ListTable: Minor change.
1734 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1735 createCellTable(): Make this protected instead of public.
1737 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1739 Many files: Use final for the parameters and use the @override attribute.
1741 2012-01-22 Ben Konrath <ben@bagu.org>
1743 Add anchor links for single line text that starts with http, ftp and www.
1747 2012-01-22 Ben Konrath <ben@bagu.org>
1749 Add ellipsis to single line text in details view.
1753 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1755 Remove all javadoc author tags.
1757 Because they are awkward and meaningless when many people touch
1759 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1761 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1763 Revert the COPYING.LESSER to COPYING rename.
1765 Apparently both should be there if it is LGPL.
1767 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1769 *View: Remove unused imports.
1771 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1772 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1773 * src/main/java/org/glom/web/client/ui/ListView.java:
1774 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1775 Remove unused imports, as suggested by Eclipse.
1777 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1779 Move the *View::Presenter types, and some API into one base View.
1781 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1782 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1783 * src/main/java/org/glom/web/client/ui/ListView.java:
1784 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1785 Presenter, setPresenter() and clear() into a shared base interface,
1786 to avoid the unnecessary duplicate Presenter types and to more clearly
1787 show how the *Views share the same structure, even if they are not
1788 used polymorphically.
1790 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1791 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1793 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1794 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1795 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1797 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1800 Feel free to revert this if there is a good reason for the duplicate
1803 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1805 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1807 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1808 a class member instead of a local variable in the method.
1809 This lets us use it to get the view instances, for use in tests.
1810 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1811 beforeOnlineGlom(): Test some more details of the initial view.
1812 Again, this is not very useful.
1814 To really test gwt-glom we will need to start a local postgresql
1815 instance with local data, like the Glom tests in C++.
1817 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1819 pom.xml: Mention the LGPL license.
1821 * pom.xml: Add a licenses section.
1822 * COPYING.LESSER: Move this to COPYING, which
1823 previously contained the GPL. But gwt-glom is all LGPL.
1825 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1827 Add project information to README and pom.xml.
1829 * README: Add a brief description and mention some mvn
1831 * pom.xml: This extra information shows up in mvn site
1834 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1836 Use the latest java-libglom version.
1838 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1840 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1842 GwtTestOnlineGlom: Test a little more.
1844 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1845 protected rather than private, as suggested by the gwt-test-utils
1847 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1848 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1849 Test the initial visibility of the panels.
1851 However, this is not a very useful test.
1852 And I wonder how we should generally test using this idea for an
1853 activity/places app like ours where the real changes happen implicitly
1854 based on the history token/URL.
1856 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1858 Slight modification to *Mapper comments.
1860 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1861 (DataActivityMapper)
1862 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1864 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1866 Remove comments mentioning GIN because they are just copied from
1867 the example code and are apparently not helpful:
1868 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1869 Also change the mention of a class that is only in the example code.
1871 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1873 GwtTestOnlineGlom test: Minor changes.
1875 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1876 Avoid the long qualified class name and modify the comment
1877 because it is now obvious to me that the mocked class is the only
1878 custom one created via GWT.create().
1880 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1882 Tests: Added the beginnings of a test using gwt-test-utils.
1884 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1885 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1886 which tells gwt-test-utils what class will be tested.
1887 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1888 Add a simple (but empty) test case. One class, used by the OnlineGlom
1889 class, is mocked so that it can be created. However, I am not sure
1890 why only this class needs to be mocked.
1892 Note that mockito seems more popular, and clearer, than easymock,
1893 but I have not got that working yet. It might be a matter of the
1896 This test is run during mvn integration-test.
1898 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1900 Tests: Use junit4-style syntax instead of junit3-style.
1902 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1903 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1904 * src/test/java/org/glom/web/shared/DataItemTest.java:
1905 Use the @Test annotation rather than relying on the test*() prefix.
1906 Also no longer implement TestCase, to avoid triggering support for
1907 the junit3-way, which stops the annotations from working.
1908 Change the imports from import junit.framework.* to
1909 import org.junit.*, which is apparently the new way.
1911 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1913 Added a test for ListPlace token parsing and creation.
1915 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1916 This is much the same as DetailsPlaceTest.
1918 I wonder how we could test the other parts of the *Place API.
1920 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1922 DetailsPlace test: Also test getToken() and recreation via getPlace().
1924 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1925 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1926 recreate it, testing the recreated DetailsPlace for the same parameter
1929 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1931 Use the surefire-report plugin.
1933 * pom.xml: This generates a HTML report about the tests in
1934 target/site/surefire-report.html
1935 when you do mvn surefire-report:report. It seems to be popular/normal.
1937 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1939 Added a test for DetailsPlace.
1941 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1942 Test the getPlace() token parsing.
1944 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1946 Added a first unit test.
1948 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1949 * src/test/java/org/glom/web/shared/DataItemTest.java:
1950 This is a silly test but it is just to get things started. Note that
1951 maven/junit finds the test because it looks in src/test by default.
1953 2011-12-22 Ben Konrath <ben@bagu.org>
1955 Change charsetName to "UTF-8" when replacing line breaks.
1957 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1958 that work in Java (such as "UTF8") will not work when compiled to
1961 This fixes a problem with multi-line details view fields that have hard
1962 line breaks. The "License Text" field on this page demonstrates the
1965 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1967 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1969 2011-12-22 Ben Konrath <ben@bagu.org>
1971 Fix another bug with related list navigation.
1973 I've tested all the navigation buttons in all of the related lists
1974 so things should be good now.
1976 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1978 2011-12-22 Ben Konrath <ben@bagu.org>
1980 Fix a crasher when refreshing the list view with the default table.
1982 This crash will also happen when loading the list view with the default
1983 table from a link or bookmark.
1985 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1986 to the main document selection page when the document id hasn't been
1988 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1989 the main document selection page when the document id hasn't been
1991 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1992 values for the details place when the document id hasn't been set.
1993 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1994 values for the list place when the document id hasn't been set.
1996 2011-12-21 Ben Konrath <ben@bagu.org>
1998 Protect against NPE when glom.document.locale is not in config.
2000 This patch protects against an NPE when glom.document.locale is not in
2001 the config file. This NPE will also happen if glom.document.locale is
2004 The patch also updates the error message to display the class name when
2005 the getMessage() returns null. This was happening when the NPE was
2006 thrown and I had "Configuration Error: null". If an NPE is encountered
2007 with this patch, "Configuration Error: NullPointerException " will be
2010 This commit closes this bug:
2012 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2014 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2016 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2018 Rename onlineglom.properties to onlineglom.properties.sample.
2020 * src/main/resources/onlineglom.properties: Rename to:
2021 * src/main/resources/onlineglom.properties.sample:
2022 * src/main/resources/README: And add this file explaining that people
2023 should rename it back when deploying.
2025 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2027 Allow choosing the translation in the .properties file.
2029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2030 init(): Read a glom.document.locale value from the configuration file
2031 and call Glom's TransatableItem::set_current_locale() method.
2032 * src/main/resources/onlineglom.properties: Add a commented-out
2033 example of this new setting.
2035 It would be better to add &lang=de_DE to the URL, but the current
2036 libglom API does not allow us to do this easily. I am working on that.
2038 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2040 Avoid a crash in parsing of token parameters.
2042 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2043 ava: getTokenParams(): Do not crash if a parameter has a key but no
2044 value, and ignore parameters with neither.
2046 2011-12-17 Murray Cumming <murrayc@murayc.com>
2048 History token building/handling: Improve use of token parameters.
2050 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2051 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2052 and buildParamsToken(HashMap), for use by derived classes.
2053 Make the separator private because it is no longer be needed.
2054 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2055 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2056 instead of manual string concatenation.
2057 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2058 of hardcoded indices and awkward splitting code.
2059 * src/main/java/org/glom/web/client/place/ListPlace.java
2060 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2061 instead of manual string concatenation.
2062 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2063 of hardcoded indices and awkward splitting code.
2064 This should fix bug #666420
2066 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2068 Fix a Navgiation->Navigation typo in the code.
2070 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2071 Rename processNavgiation() to processNavigation().
2073 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2075 Fix a seperator->separator typo in the code.
2077 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2078 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2079 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2082 2011-12-15 Ben Konrath <ben@bagu.org>
2084 Cleanup some comments.
2086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2088 2011-12-14 Ben Konrath <ben@bagu.org>
2090 Replace \n with <br/> for multiline text in the details view.
2092 Vertical scrollbars are added when needed as well.
2094 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2096 2011-12-14 Ben Konrath <ben@bagu.org>
2098 Specify the font for document selection links.
2100 * src/main/webapp/style.css:
2102 2011-12-14 Ben Konrath <ben@bagu.org>
2104 Fix bouncy CellTable while paging.
2106 This doesn't currently work with related list tables in unselected
2109 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2111 2011-12-14 Ben Konrath <ben@bagu.org>
2113 Revamp the appearance of the document selection page.
2115 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2116 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2117 * src/main/webapp/style.css:
2119 2011-12-13 Ben Konrath <ben@bagu.org>
2121 Set navigation button column to the smallest size possible.
2123 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2125 2011-12-13 Ben Konrath <ben@bagu.org>
2127 Change OpenButton nomenclature to NavigationButton.
2129 Using NavigtionButton makes things more generic. Classes, methods and
2130 variables have been changed.
2132 This is a rename-only refactor.
2134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2135 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2136 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2137 Renamed from OpenButtonCell.
2138 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2139 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2140 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2142 2011-12-12 Ben Konrath <ben@bagu.org>
2144 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2146 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2147 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2148 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2149 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2151 2011-12-12 Ben Konrath <ben@bagu.org>
2153 Update variable names and comments.
2155 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2156 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2158 2011-12-12 Ben Konrath <ben@bagu.org>
2160 Properly initialize numNonEmptyRows variable to zero.
2162 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2163 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2165 2011-12-05 Ben Konrath <ben@bagu.org>
2167 Add latest mockup with HTML tables.
2169 Features of this mockup:
2171 -> HTML table for flowtable
2172 -> HTML table for flowtable column
2173 -> Example of how related lists would look
2174 -> Not using text entries for data items
2176 The current version of Online Glom doesn't use HTML tables for the
2179 This mockup has been sent to the glom-devel mailing list but it's good
2180 to have it here as well.
2182 * mockups/details-view-html-tables.html:
2184 2011-12-05 Ben Konrath <ben@bagu.org>
2186 Remove unnecessary getPrimaryKeyField() method.
2188 getPrimaryKeyFieldForTable(String) has been renamed to
2189 getPrimaryKeyField(String).
2191 * src/main/java/org/glom/web/server/database/DBAccess.java:
2192 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2193 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2195 2011-12-05 Ben Konrath <ben@bagu.org>
2197 Add string representation of TypedDataItem value to conversion error message.
2199 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2200 message was extracted into its own method to avoid duplication.
2202 2011-12-05 Ben Konrath <ben@bagu.org>
2204 Add type checking to navigation primary key value creation.
2206 Create navigation primary key only if the expected type from the Glom
2207 document matches the type returned by the SQL query.
2209 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2211 2011-12-05 Ben Konrath <ben@bagu.org>
2213 Rename a couple of variables in RelatedListNavigation.
2215 This is a rename-only refactor.
2217 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2219 2011-12-05 Ben Konrath <ben@bagu.org>
2221 Move getListLayoutGroup() into getListViewLayoutGroup().
2223 This removes getListLayoutGroup(). It was only being called by
2224 getListViewLayoutGroup().
2226 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2228 2011-12-05 Ben Konrath <ben@bagu.org>
2230 Remove check for LayoutItem_Portal in list table method.
2232 This check is no longer necessary because the method isn't being used
2233 to create the LayoutItemPortal DTO.
2235 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2237 2011-12-05 Ben Konrath <ben@bagu.org>
2239 Properly support related list navigation.
2241 Navigation from the "Repository Analyzer -> Package Scans ->
2242 Dependencies" related table wasn't working because the primary key for
2243 related tables wasn't being set properly. This commit fixes the
2246 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2247 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2248 doesn't set the primary key properly for related list tables.
2249 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2250 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2251 useful for getting the primary key for list view tables and for related
2253 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2254 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2255 Move code to set the primary key for the table from the abstract
2256 ListDBAccess class to ListViewDBAccess as it's only correct for list
2258 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2259 Properly add primary key to related list tables.
2261 2011-12-02 Ben Konrath <ben@bagu.org>
2263 Properly set the horizontal alignment of fields.
2265 This fix is for both the list tables and the details view.
2267 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2268 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2269 to set the horizontal alignment of fields.
2271 2011-12-02 Ben Konrath <ben@bagu.org>
2273 Display currency codes in the details view.
2275 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2277 2011-12-02 Ben Konrath <ben@bagu.org>
2279 Avoid duplicate JNI call.
2281 JNI is not as efficient as pure Java and this is an easy (and small)
2284 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2285 Use previously retrieved value for whereClauseToTableName instead of
2288 2011-12-02 Ben Konrath <ben@bagu.org>
2290 Rename a couple of variables in RelatedListNavigation.
2292 This is a rename-only refactor.
2294 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2296 2011-12-02 Ben Konrath <ben@bagu.org>
2298 Indicate clearly that a mismatched primary key type is a bug.
2300 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2301 warning to error. Add 'This is a bug.' to message.
2303 2011-12-02 Ben Konrath <ben@bagu.org>
2305 Update / fix some comments.
2307 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2309 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2311 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2312 Fix comments. Add some TODOs.
2314 2011-12-02 Ben Konrath <ben@bagu.org>
2316 Enable navigation to details view with string primary key from related list.
2318 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2319 Create a text primary key value when return type of result is
2320 java.sql.Types.VARCHAR.
2322 2011-12-02 Ben Konrath <ben@bagu.org>
2324 Use checkboxes for booleans in the details view.
2326 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2328 2011-12-01 Ben Konrath <ben@bagu.org>
2330 Improve performance of related list height calculation.
2332 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2333 Put code to calculate the expected height in a static initializer so
2334 that that it's only called once.
2336 2011-12-01 Ben Konrath <ben@bagu.org>
2338 Show related list tables in notebooks (again).
2340 Calculate the height of the related list tables so the Notebook can be
2341 set the correct height. The height of the related list table is also needed by
2342 FlowTable to be able decide how to create the layout.
2344 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2345 and set the Portal height based on the height of the related list
2346 table and the Portal container.
2347 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2348 Add method to calculate the height of the related list tables.
2349 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2350 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2351 calculate the height of the Pager widget.
2353 2011-12-01 Ben Konrath <ben@bagu.org>
2355 Use CellTable API for table property instead of setting style on Element.
2357 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2359 2011-12-01 Ben Konrath <ben@bagu.org>
2361 Make ListViewTable and RelatedListTable a consistent height.
2363 The tables are now a consistent height regardless of the contents of
2364 the table. A hidden button is added to empty rows to ensure that the
2365 height of these rows will match the height of rows with data.
2367 A navigation button column is now added to every table. The width of
2368 the navigation column is set to 0px when a RelatedListTable shouldn't
2369 have navigation buttons. This maintains the a consistent row height in
2370 tables that don't show the navigation buttons.
2372 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2373 navigation column when not needed.
2374 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2375 arguments for navigation button to constructor of ListViewTable.
2376 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2377 hidden button for empty data rows.
2378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2379 arguments for navigation button to constructor.
2380 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2381 create navigation buttons. Add hideNavigationButtons() method.
2382 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2383 arguments for navigation button to constructor.
2385 2011-12-01 Ben Konrath <ben@bagu.org>
2387 Use 'visibility: hidden' in Utils.getWidgetHeight().
2389 This is better choice because hidden elements are invisible, don't
2390 respond to events and are not part of the tab order. They will,
2391 however, take up space which is required to be able to calculate the
2392 height of the widget.
2394 * src/main/java/org/glom/web/client/Utils.java:
2396 2011-12-01 Ben Konrath <ben@bagu.org>
2398 Use Utils.getWidgetHeight() in FlowTable.
2400 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2402 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2404 2011-12-01 Ben Konrath <ben@bagu.org>
2406 Put the details css class name on the correct table column.
2408 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2410 2011-11-30 Ben Konrath <ben@bagu.org>
2412 Update for java-libglom API change.
2414 The getters and setters on FieldFormatting and NumericFormat were
2415 changed to remove the 'M'.
2417 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2419 2011-11-29 Ben Konrath <ben@bagu.org>
2421 Only allow RelatedListTables in Portals.
2423 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2425 2011-11-29 Ben Konrath <ben@bagu.org>
2427 Only create a contents panel for Portals when title is being set.
2429 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2431 2011-11-29 Ben Konrath <ben@bagu.org>
2433 Set TabLayoutPanel height based on calculated height its widgets.
2435 This is a potential fix for this bug:
2437 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2439 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2441 2011-11-29 Ben Konrath <ben@bagu.org>
2443 Align details field labels and data with the Open buttons.
2445 * src/main/webapp/style.css:
2447 2011-11-29 Ben Konrath <ben@bagu.org>
2449 Remove unnecessary <div> in the Notebook widget.
2451 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2452 method to get container FlowPanel (<div>).
2453 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2454 initWidget() method directly on the TabLayoutPanel widget instead of
2455 Group's container widget.
2457 2011-11-29 Ben Konrath <ben@bagu.org>
2459 Don't add group titles for Portals in Notebooks.
2461 This reverts the previous patch and fixes a bug I introduced with
2462 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2464 * src/main/java/org/glom/web/client/ui/details/Group.java:
2465 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2467 2011-11-28 Ben Konrath <ben@bagu.org>
2469 Remove unused boolean argument in Portal constructor.
2471 Just a code cleanup.
2473 * src/main/java/org/glom/web/client/ui/details/Group.java:
2474 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2476 2011-11-28 Ben Konrath <ben@bagu.org>
2478 Remove hack for glom 1.18 style glom files.
2480 * src/main/java/org/glom/web/client/ui/details/Group.java:
2481 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2482 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2484 2011-11-28 Ben Konrath <ben@bagu.org>
2486 Use Gda Value version of primary key to log result too large error.
2488 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2490 2011-11-28 Ben Konrath <ben@bagu.org>
2492 Don't use TypedDataItem.getText() for Unknown types from the URL.
2494 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2495 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2496 instead of getText().
2497 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2498 String field and getUnknown() method.
2500 2011-11-28 Ben Konrath <ben@bagu.org>
2502 Log an error message when the java-libglom .so is not present.
2504 The error message was being set in the exception but not logged.
2506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2508 2011-11-28 Ben Konrath <ben@bagu.org>
2510 Ignore LayoutItem_CalendarPortals.
2512 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2513 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2515 2011-11-28 Ben Konrath <ben@bagu.org>
2517 Extract method for creating the LayoutItemPortal DTO.
2519 Just breaking the code up into smaller chunks.
2521 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2523 2011-11-28 Ben Konrath <ben@bagu.org>
2527 This should have been added with the refactor. Oops!
2529 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2531 2011-11-28 Ben Konrath <ben@bagu.org>
2533 Create primary key value from URL string using type from Glom document.
2535 See this bug, comments 19 - 25:
2537 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2539 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2540 create a TypeDataItem for the primary key here when loading from a
2541 URL. Show the same string for the primary key value as was received
2542 from the URL string (when loading from a URL).
2543 * src/main/java/org/glom/web/server/Utils.java: Update method for
2544 creating the Gda Value from the TypeDataItem to properly deal with
2545 creating a Gda Value based on the Glom document type for the primary
2546 key value string when loading from a URL.
2547 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2548 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2549 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2550 Update for changed method name.
2552 2011-11-27 Ben Konrath <ben@bagu.org>
2554 Rename PrimaryKeyItem to TypedDataItem.
2556 The name PrimaryKeyItem suggests what the class should be used for.
2557 TypedDataItem is a neutral name that describes the class better.
2559 This is a rename-only refactor.
2561 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2562 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2563 * src/main/java/org/glom/web/client/Utils.java:
2564 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2565 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2566 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2567 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2568 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2569 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2571 * src/main/java/org/glom/web/server/Utils.java:
2572 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2573 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2574 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2575 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2577 2011-11-25 Ben Konrath <ben@bagu.org>
2579 Improve Gda Value conversion from PrimaryKeyItem.
2581 The value from the PrimaryKeyItem is only used if its type match the
2582 type from the glom document.
2584 * src/main/java/org/glom/web/server/Utils.java:
2586 2011-11-25 Ben Konrath <ben@bagu.org>
2588 Manually check if the java-liblgom .so is visible to the JVM.
2590 It seems that Tomcat has problems when a static initializer throws an
2591 exception. This check is done before the first method call into
2592 java-libglom so that execution doesn't continue if the .so is not
2595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2597 2011-11-25 Ben Konrath <ben@bagu.org>
2599 Improve browser configuration error messages.
2603 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2605 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2606 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2607 getConfigurationErrorMessage() method.
2608 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2609 Get and display a specific configuration error message when no Glom
2610 documents are found.
2611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2612 Implement getConfigurationErrorMessage() method. Surround configuration
2613 code in the init() method with a try/catch block. This allows the
2614 errors to be caught while keeping the servlet available to retrieve the
2615 configuration error message.
2617 2011-11-25 Ben Konrath <ben@bagu.org>
2619 Don't use Strings to hold primary key values.
2621 The primary key values are now held in a new data object
2622 (PrimaryKeyItem) that holds type information and the primary key value
2623 using the correct type.
2625 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2626 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2628 PrimaryKeyItem instead of String to hold the primary key value.
2629 * src/main/java/org/glom/web/client/Utils.java: Remove
2630 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2631 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2633 PrimaryKeyItem instead of String to hold the primary key value. Load
2634 document selection page when the documentID has not been set correctly.
2635 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2636 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2638 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2639 Return empty string for URL instead of "null".
2640 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2641 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2642 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2643 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2644 PrimaryKeyItem instead of String to hold primary key values.
2645 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2646 PrimaryKeyValue to a Gda Value.
2647 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2648 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2649 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2650 Replace temporary database access code that uses the PrimaryKeyValue to
2651 Gda Value conversion.
2652 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2653 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2654 PrimaryKeyItem instead of String.
2655 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2656 hold primary key values.
2658 2011-11-24 Ben Konrath <ben@bagu.org>
2660 Use newly added java-libglom API to create queries.
2662 This isn't finished. I still need to stop using Strings for primary key
2663 values in the client code.
2665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2666 libglom to use fake connections so that retrieving the query string will
2668 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2669 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2670 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2671 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2672 Use the newly added libglom sql methods and classes to create the
2673 query. Add temporary hack to convert primary value strings to Gda
2676 2011-11-23 Ben Konrath <ben@bagu.org>
2678 Don't explicitly set the height of Portals.
2680 See comments 6 - 10 of this bug for details:
2682 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2684 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2686 2011-11-23 Ben Konrath <ben@bagu.org>
2688 Use an HTML table instead of CSS for the FlowTable layout.
2690 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2691 GWT's FlexTable to implement the FlowTable.
2692 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2694 2011-11-18 Ben Konrath <ben@bagu.org>
2696 Add boolean example to HTML table mockup.
2698 * mockups/details-view-html-tables-text-entries.html:
2700 2011-11-17 Ben Konrath <ben@bagu.org>
2702 Ensure the pager buttons are always visible for related lists.
2704 To accomplish this, I've turned off text wrapping in the list view and
2705 related list tables for both the header and data text. The related list
2706 table now has a fixed layout so the it doesn't overflow its container.
2707 This is required to ensure that the cell text is clipped when it
2708 overflows the cell and an ellipsis is added to the right side of the
2709 cell when text is clipped.
2711 A fixed table layout for the related list table in the details view
2712 seems what we want for the details view anyway, so the side-effect is
2715 The ellipsis will only be displayed in Firefox >= 7.
2719 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2721 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2722 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2723 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2725 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2726 Set the 'table-layout: fixed' CSS property to the related list table.
2727 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2728 'white-space: nowrap;' CSS property on both the list view and the
2729 related list tables.
2731 2011-11-16 Ben Konrath <ben@bagu.org>
2733 Rework the fix for empty notebook tab labels.
2735 Setting the empty group titles with its name caused problems for the
2736 details layout. Instead of using libglom's
2737 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2738 to the client when the title is empty. This allows the Notebook to use
2739 the name when the title is empty without affecting anything else.
2741 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2742 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2744 2011-11-16 Ben Konrath <ben@bagu.org>
2746 Set group titles with name when title is empty.
2748 This fixes a problem with an empty notebook tab label in the Lesson
2749 Planner document. The forth tab in the notebook should be "Internet":
2751 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2753 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2754 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2757 2011-11-16 Ben Konrath <ben@bagu.org>
2759 Remove whitespace from the configured username properties.
2761 This assumes that usernames won't have whitespace at the beginning
2762 or end. But I think this is a reasonable assumption.
2764 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2765 String.trim() to remove the whitespace from the username properties.
2767 2011-11-15 Ben Konrath <ben@bagu.org>
2769 Add details view mockup with HTML tables and text entries.
2771 This is from the attachment on this bug:
2773 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2775 * mockups/details-view-html-tables-text-entries.html:
2777 2011-11-15 Ben Konrath <ben@bagu.org>
2779 Add space between the columns of the flow table.
2783 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2785 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2786 space between columns in the flow table.
2788 2011-11-15 Ben Konrath <ben@bagu.org>
2790 Add backup files to the .gitignore.
2792 * .gitignore: Ignore files that end with ~.
2794 2011-11-09 Ben Konrath <ben@bagu.org>
2796 Use latest release of gwt-log.
2798 Gwt-log releases are now being submitted to the maven central
2799 repository so manual installation of the jar is no longer required.
2801 * pom.xml: Update version and groupId of gwt-log dependency.
2803 2011-10-31 Ben Konrath <ben@bagu.org>
2805 Don't use GWT numeric formatting to override the glom currency formatting.
2807 Currencies are now displayed like they are in Glom. See this bug:
2809 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2811 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2813 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2814 currency code to constructor and set it when the cell is rendered.
2815 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2816 currency code to the constructor of the NumericCell.
2818 2011-10-27 Ben Konrath <ben@bagu.org>
2820 Require the latest release of java-libglom (1.17.4).
2824 2011-10-26 Ben Konrath <ben@bagu.org>
2826 Add style to Notebook that matches current theme.
2828 It's not the best style in the world but it's better than the default.
2830 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2831 padding at the bottom of the child widgets.
2832 * src/main/webapp/style.css: Add style for the Notebook.
2834 2011-10-26 Ben Konrath <ben@bagu.org>
2836 Move servlet initialization code to overridden init method.
2838 This is half of the solution to getting proper error messages
2839 displayed when configuration errors occur. Here's the relevant bug:
2841 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2843 The rest of the solution involves surrounding the init method with a
2844 try/catch block and setting a global variable with the error /
2845 exception. A new async method should be created to retrieve and display
2846 the error message / exception.
2848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2849 code from constructor to init method adding exceptions as needed.
2851 2011-10-26 Ben Konrath <ben@bagu.org>
2853 Add script to monitor and restart tomcat if required.
2855 * utils/check-and-recover-tomcat.py: New file.
2857 2011-10-26 Ben Konrath <ben@bagu.org>
2859 Display the correct number of data items in the pager.
2863 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2865 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2866 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2867 The implementation is the same for both tables: Keep track of the
2868 number of non-empty rows and fire and RowCountChangeEvent after the data has
2870 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2871 custom Pager class that subclasses SimplePager to handle displaying
2872 the correct number when empty rows have been added.
2874 2011-10-26 Ben Konrath <ben@bagu.org>
2876 Correct error in previous commit.
2878 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2879 eventBus parameter from listView.setCellTable().
2881 2011-10-26 Ben Konrath <ben@bagu.org>
2883 Fix error in TODO comment.
2885 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2887 2011-10-24 Ben Konrath <ben@bagu.org>
2889 Create Notebook widgets to the details view.
2891 This isn't finished just yet - I still need to create a reasonable
2892 style to match the current theme.
2894 * src/main/java/org/glom/web/client/Utils.java: Add method for
2895 calculating the height of a widget. This is used in the Notebook class.
2896 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2897 new constructor method in Group.
2898 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2899 method for creating child widget that can be used by subclasses
2900 like Notebook. New constructor that allows disabling the group
2901 titles - Notebooks don't set a group title for their child groups.
2902 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2903 to make Notebooks using GWT's TabLayoutPanel.
2904 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2905 constructor that allows disabling the group titles.
2906 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2907 LayoutItemNotebook DTO.
2908 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2909 DTO for Notebooks. It's just an empty class for now but we might need
2910 it to transfer some specific information in the future.
2912 2011-10-21 Ben Konrath <ben@bagu.org>
2914 Add navigation buttons to related list tables.
2916 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2917 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2919 method getSuitableRecordToViewDetails() for getting the table name
2920 and primary key value for related list navigation buttons.
2921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2922 private cell renderer class to get the navigation information for
2923 related list tables from the server. Extract the navigation
2924 processing code from the details cell navigation and use it for the
2925 related list navigation as well.
2926 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2927 cell renderer class for the details open buttons. This was needed
2928 because the related list navigation buttons and the list view
2929 navigation buttons need to react differently when clicked.
2930 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2931 the onEnterKeyDown() method because it's now overriden in the
2932 subclasses that are specific to the related list tables and the list
2934 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2935 the vertical size a little because the buttons add a bit of vertical
2936 space to table. This is not a perfect solution because the vertical
2937 size of with table fewer than 5 rows will be a little smaller.
2938 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2939 changes in how navigation buttons are handled.
2940 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2941 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2942 database access object.
2943 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2944 to find the portal for a given relationship name from
2945 RelatedListDBAccess. Add method to find a primary key field for a
2947 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2948 Move code to find the portal for a given relationship name to
2950 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2951 New file: database access object for getting the related list
2952 navigation information (the table name and the primary key value).
2953 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2954 DTO for transferring a table name to navigate to and a primary key
2956 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2957 boolean and getter/setter to specifies if the related list should add
2960 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2962 Use the master branch of java-libglom
2964 * pom.xml: Depend on java-libglom 1.19 instead.
2966 This is the master branch. See also the libglom-1-18 branch.
2968 2011-10-11 Ben Konrath <ben@bagu.org>
2970 Enable the open navigation button when the data has been set.
2972 This avoids having active buttons that don't do anything when the data
2975 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2977 2011-10-11 Ben Konrath <ben@bagu.org>
2979 Use IsWidget interface for FlowTableItem.
2981 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2982 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2984 2011-10-11 Ben Konrath <ben@bagu.org>
2986 Remove GWT styling from open button in details view.
2988 There are still some issues with how the details cell is arranged but
2989 this should be made to match Glom 1.20. I'm going to leave fixing this
2990 until I have Glom 1.20 up and running.
2992 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2993 style name on open button.
2994 * src/main/webapp/style.css: Move and edit details-navigation class.
2995 Re-arrange some classes to make them appear in the same order as the
2998 2011-10-07 Ben Konrath <ben@bagu.org>
3000 Update to GWT 2.4.0.
3002 * .gitignore: Ignore new cache directory.
3003 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3004 * pom.xml: Change GWT and maven plugin to 2.4.0.
3005 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3007 * src/main/java/org/glom/web/client/ClientFactory.java:
3008 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3009 * src/main/java/org/glom/web/client/OnlineGlom.java:
3010 Update source for API changes.
3011 * utils/build-onlineglom-war.sh: Remove cache directory before the
3014 2011-10-07 Ben Konrath <ben@bagu.org>
3016 Add navigation buttons in the details view.
3018 This isn't finished but I thought I'd commit what I have as it's a
3019 pretty good start. I still need to:
3021 1. Change the style so that it fits better into the current theme
3022 2. Adjust the details cell to expand as much as possible.
3024 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3025 click handlers to navigation buttons in the DetailsCells. Create a
3026 refreshData() method to get just the data from the server without the
3028 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3029 Update the tableSelector and browser title when the table name
3030 changes without using the tableSelector.
3031 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3032 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3033 getDetailsCells() to getCells(). Update variable names.
3034 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3035 method to set click handler on navigation button. Rename a few
3036 variables. Add navigation buttons where needed.
3037 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3038 variables and methods.
3039 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3040 navigation boolean and navigation table as required in the
3041 LayoutItemField DTO.
3042 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3043 variables for navigation along with getter/setter methods.
3045 2011-10-07 Ben Konrath <ben@bagu.org>
3047 Rename Field to DetailsCell.
3049 This is a refactor-only commit. No functionality has been added or
3052 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3053 Update variable and method names.
3054 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3055 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3056 variable and method names.
3057 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3059 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3060 variable and method names.
3062 2011-10-07 Ben Konrath <ben@bagu.org>
3064 Create separate methods for layout and data the details view.
3066 This is a refactor-only commit. No functionality has been added or
3069 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3070 private methods: setData(), createLayout().
3072 2011-10-07 Ben Konrath <ben@bagu.org>
3074 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3076 This is part of a change to get navigation buttons in the details view
3077 but it should have been done this way from the start.
3079 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3080 for method name change in TableSelectionView.
3081 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3082 Create TableChangeEvent and set the browser title using the
3083 TableSelectionView API.
3084 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3085 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3086 Change getSelectedTable() to getSelectedTableName(). Add
3087 getSelectedTableTitle().
3089 2011-10-07 Ben Konrath <ben@bagu.org>
3091 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3093 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3095 2011-10-07 Ben Konrath <ben@bagu.org>
3097 Update TableChangeEvent to use newTableName naming convention.
3099 This makes the class more consistent with GWT naming conventions.
3101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3102 Update for method name change in TableChangeEvent.
3103 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3104 for method name change in TableChangeEvent.
3105 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3106 newTableName variable and getter method. Make toDebugString()
3109 2011-09-30 Ben Konrath <ben@bagu.org>
3111 Disable the pager in the list tables when the data row count is less than the minimum.
3113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3116 2011-09-30 Ben Konrath <ben@bagu.org>
3118 Add empty rows to the end of related list and list view tables.
3120 I also extracted the cell rendering classes from the ListTable because
3121 the code was becoming a little crazy with all the anonymous inner
3122 classes. My plan is to use these cell rendering classes in the details
3123 view as well so this refactor will be needed for that change.
3125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3126 set the row count in related list tables if the data has more rows
3127 than the minimum number of rows visible.
3128 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3129 row count in list view tables if the data has more rows than the
3130 minimum number of rows visible.
3131 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3132 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3134 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3135 for rendering TYPE_NUMERIC cells. The code was extracted from the
3137 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3138 class for rendering cells with buttons in list views. The code was
3139 extracted from the ListTable class.
3140 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3141 for rendering TYPE_TEXT cells. The code was extracted from the
3143 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3144 Add empty rows to the end of the data if required. Implement
3145 ListTable.getMinNumVisibleRows().
3146 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3147 cell renderer code to public classes. Return null in
3148 Column.getValue() for empty rows. Add new abstract method:
3149 getMinNumVisibleRows(). Move code to set the row count of the list view
3150 table to ListViewImpl.
3151 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3152 empty rows to the end of the data if required. Implement
3153 ListTable.getMinNumVisibleRows().
3156 2011-09-27 Ben Konrath <ben@bagu.org>
3158 Use GWT.log for client-side debugging statements.
3160 These are optimized out when deployed so I should have used this method
3161 in the first place. These statements will eventually be replaced with some sort
3162 of notification in the browser.
3164 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3165 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3166 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3167 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3168 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3170 2011-09-27 Ben Konrath <ben@bagu.org>
3172 Put tableselector on the right, back to list link on right.
3174 The idea is that the table selector is acting like a label for the
3175 currently displayed table so it should be placed below the document title. This
3176 puts the table title in a similar position to where it is in Glom.
3178 * mockups/details-contacts.html:
3179 * mockups/details-projects.html:
3180 * mockups/listview-contacts.html:
3181 * mockups/listview-projects.html:
3182 * mockups/style.css:
3183 Update mockups to match how the interfaces currently look.
3184 * src/main/webapp/style.css: Swap positions of backlink with the table
3185 selector. Add some space on the left side of the table selector to
3186 line things up with the document title.
3188 2011-09-27 Ben Konrath <ben@bagu.org>
3190 Add field colouring to details view.
3192 This change re-works how field colouring works. The colour formatting
3193 information is now set to the client with the layout information instead of
3194 with the data. This eliminates the need to send the same colour strings for
3195 data in list view column when colour information is set.
3197 In order to set an alternate colour for negative numeric values, the
3198 number is now sent to client and formatted with the GWT NumberFormat class.
3200 This change also fixes:
3202 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3204 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3205 internationalization framework which is needed for client side numeric
3207 * src/main/java/org/glom/web/client/Utils.java: New file for some
3208 client static utility methods.
3209 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3210 the DataItem object to the Field class. Use a utility method to
3211 create the foreignKeyValue string.
3212 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3213 alignment and text colours in the constructor. Add setData(DataItem)
3214 method. Remove setText(String) method.
3215 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3216 colour information to GlomTextCell. Create and use GlomNumberCell for
3217 rendering numbers. Use utility method to get the string for the
3218 primary key of the key provider. Re-work how the horizontal alignment
3220 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3221 formatting to layout information. Methods for converting the libglom
3222 formatting information were moved from DBAccess.
3223 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3224 numeric formatting (it's now done on the client side). Don't set text
3225 colours in DataItem. Move libglom formatting conversion methods to
3227 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3228 getters/setters for text colour information.
3229 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3230 for transferring the libglom NumericFormat information to the client.
3231 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3232 and getters/setters for: GlomNumericFormat, background colour and
3233 foreground colour strings.
3235 2011-09-26 Ben Konrath <ben@bagu.org>
3237 Simplify code that iterates through the LayoutGroup.
3239 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3241 2011-09-26 Ben Konrath <ben@bagu.org>
3243 Accept Eclipse formatting for OnlineGlomServiceAsync.
3245 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3247 2011-09-26 Ben Konrath <ben@bagu.org>
3249 Don't use the ListDBAccess classes to get the primary key layout information.
3251 This was causing a bug where the wrong index for the hidden primary key
3252 was being sent to the client.
3254 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3255 primary key while creating the LayoutGroup DTO. Create a
3256 LayoutItemField DTO for hidden primary keys. Don't use the
3257 RelatedListDBAccess because it was only used for getting the primary
3259 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3260 access modifier from public to protected for getPrimaryKeyField() and
3261 getPrimaryKeyLayoutItemField().
3262 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3263 abstract method getExpectedResultSize() because RelatedListDBAccess