1 2012-06-08 Murray Cumming <murrayc@murrayc.com>
3 SelfHoster: Wait until the server is really ready.
5 * src/test/java/org/glom/web/server/SelfHoster.java
6 selfHost(): Attempt the connection after starting the server, retrying
7 a few times if necessary, so that the server is really ready already when
8 we return from this method.
9 The regular Glom code does this too because pg_ctl reports success too soon.
11 2012-06-08 Murray Cumming <murrayc@murrayc.com>
13 ConfiguredDocument: Do not add a primary key to portals each time.
15 * src/main/java/org/glom/web/server/ConfiguredDocument.java
16 updatePortalsExtras(): Only add an extra primary key field if there is
17 none, to avoid adding one each time we retrieve the details layout from the
19 This should fix bug #676986 (Ben Konrath)
21 2012-05-25 Murray Cumming <murrayc@murrayc.com>
23 Document.load(): Support version 7 documents.
25 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
26 database_title attribute if the title attribute is not there.
29 2012-05-24 Ben Konrath <ben@bagu.org>
31 Add configuration for auto-generating mvn:i18n from with Eclipse.
33 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
35 2012-05-24 Murray Cumming <murrayc@murrayc.com>
37 Update translations, adding French.
39 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
40 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
41 Add a French translation, using the translation from Glom.
43 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
44 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
45 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
46 Update these based on the translations from Glom.
48 2012-05-24 Murray Cumming <murrayc@murrayc.com>
50 SelfHoster: Add some debug println messages to help when things fail.
52 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
53 System.out.println() lines.
55 2012-05-23 Murray Cumming <murrayc@murrayc.com>
57 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
59 * src/test/java/org/glom/web/server/SelfHoster.java:
60 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
61 instance) instead of just /usr/bin (as on Fedora). Check the result when
64 2012-05-23 Murray Cumming <murrayc@murrayc.com>
66 Remove LayoutItemPortal.get/setNavigationTable().
68 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
69 Remove get/setNavigationTable(), which is only a cache, because it is not
70 used, and does not need to be used, because that decision should be made on
72 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
73 updatePortalsExtras():
74 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
75 getNavigationRecord():
76 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
79 2012-05-21 Murray Cumming <murrayc@murrayc.com>
81 Initial self-hosting for tests.
83 * pom.xml: Change the scope for log4j, to hopefully make it
84 available to the test code which uses it indirectly via jOOQ.
85 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
86 self-hosting, though we only use it for testing.
88 * src/main/java/org/glom/web/server/libglom/Document.java:
89 example rows: Use a map instead of a list for each row of values,
90 so we know what field they are for, instead of relying on the sequence
91 being correct. This is not very efficient, but it does not really need
93 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
94 testReadTableExampleRows(): Adapted.
96 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
97 that returns an Object, for generic use. Note that Object seems to be
98 the implicit base even of double.
99 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
100 for use in CREATE TABLE SQL queries.
101 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
102 to do self-hosting of PostgreSQL databases via its command-line
103 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
104 backends/postgres_self.cc. This is incomplete - it needs more
105 warnings about failures and it needs to clean up properly when things
107 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
108 test of this new class.
110 2012-05-21 Murray Cumming <murrayc@murrayc.com>
112 Document: loading example data: Handle exceptions.
114 * src/main/java/org/glom/web/server/libglom/Document.java:
115 DateFormat.parse() and Double.valueOf() can throw exceptions, though
116 Eclipse did not warn about that.
118 2012-05-20 Murray Cumming <murrayc@murrayc.com>
120 Document: load(), save(): Handle the example rows.
122 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
124 * src/main/java/org/glom/web/server/libglom/Document.java:
125 load(), save(): Load and save the example rows, though the date, time
126 and image types are not handled properly yet.
127 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
128 Add testReadTableExampleRows() just to check that something is read.
130 2012-05-20 Murray Cumming <murrayc@murrayc.com>
132 Document: Add save().
134 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
135 Added getTranslationsMap() for use while saving.
136 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
137 Adedd getUseDefaultFormatting() for use while saving.
138 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
139 and several private methods that it uses.
141 This will be useful while testing via self-hosting.
142 It is not complete, but should be complete enough for testing.
144 2012-05-17 Murray Cumming <murrayc@murrayc.com>
146 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
148 * src/main/java/org/glom/web/client/OnlineGlomService.java
149 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
151 Remove getSortedListViewData() and getSortedRelatedListData(), adding
152 the sort column index and ascending bool to the regular method.
153 Instead, a sort column index of -1 now means no sort.
154 This is less explicit, but it's fairly simple, reduces the amount of
155 code, and makes the OnlineGlomService API slightly smaller.
156 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
157 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
159 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
160 getListViewData(), getRelatedListData():
161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
162 getListViewData(), getRelatedListData():
163 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
165 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
167 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
172 2012-05-16 Murray Cumming <murrayc@murrayc.com>
174 Use translations for top-level groups too.
176 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
177 updateTitlesForLocale(): Use the translation for the group
178 as well as for child items.
182 Just recompiled to fix a problem in the released .tar.gz file.
186 2012-05-15 Murray Cumming <murrayc@murrayc.com>
188 Corrections to navigation to related records.
190 * src/main/java/org/glom/web/client/OnlineGlomService.java:
191 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
193 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
194 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
195 relationship name, because the relationship name is not necessarily unique
197 TOOD: This is inefficient, because it passes the whole list of
198 child field items back to the server, but it is more correct, and happens
199 to fix a bug with the primary key being lost after a few navigations.
200 There is probably a chance to make this more efficient anyway in some
203 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
204 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
205 * src/main/java/org/glom/web/server/ConfiguredDocument.java
206 * src/main/java/org/glom/web/server/database/DBAccess.java
207 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
208 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
211 2012-05-15 Murray Cumming <murrayc@murrayc.com>
213 Fix the use of translations.
215 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
216 Add updateTitlesForLocale().
217 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
218 Call it to discard unwanted translations and to make getTitle() return
219 the wanted translation wihout the need for the client code to specify a locale.
220 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
221 getTitle(): Fallback to the original title, as libglom does.
223 2012-05-15 Murray Cumming <murrayc@murrayc.com>
225 Document: Correctly report the number of available translation locales.
227 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
228 the available locale IDs list.
229 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
230 testLocales: Test this.
232 2012-05-15 Murray Cumming <murrayc@murrayc.com>
234 SqlUtils: Use camelCase.
236 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
237 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
238 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
239 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
240 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
241 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
243 2012-05-15 Murray Cumming <murrayc@murrayc.com>
245 Use jOOQ's tableByName() and fieldByName.
247 * pom.xml: Use jOOQ 2.3.1 to get the new API.
248 * src/main/java/org/glom/web/server/SqlUtils.java:
249 build_sql_select_step_with_where_clause(), .createField(),
250 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
251 so we can get correct quoting and escaping. Thanks to Lukas Eder for
252 adding this, and other things, to jOOQ.
254 2012-05-15 Murray Cumming <murrayc@murrayc.com>
256 SqlUtils: Remove the Connection parameters.
258 * src/main/java/org/glom/web/server/SqlUtils.java:
259 build_sql_select_with_key(), build_sql_select_with_where_clause(),
260 createSelect(), build_sql_select_step_with_where_clause(),
261 build_sql_count_select_with_where_clause(),
262 build_sql_select_count_rows(): Remove the Connection parameter because
263 jOOQ does not actually need a connectionwhen it is just used to build
265 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
267 * src/main/java/org/glom/web/server/ReportGenerator.java:
269 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
271 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
272 Constructor, getListData(), getResultSizeOfSQLQuery():
273 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
274 getSelectQuery(), getCountQuery():
275 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
276 getSelectQuery(), getCountQuery():
277 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
278 getNavigationRecord(): Adapted.
280 2012-05-14 Murray Cumming <murrayc@murrayc.com>
284 * src/main/java/org/glom/web/server/SqlUtils.java:
285 get_find_where_clause_quick(): Use a comparison of
286 lowercase values, instead of a simple equals. Regular Glom
287 uses the PostgreSQL ILIKE operator but jOOQ does not
288 support that just yet, though it will soon.
290 2012-05-14 Murray Cumming <murrayc@murrayc.com>
292 TableToViewDetails: Use a real serialization ID.
294 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
295 Though this does not fix the serialization problem.
297 2012-05-12 Murray Cumming <murrayc@murrayc.com>
299 Added LayoutItemPortalDeepCloneTest.
301 2012-05-11 Murray Cumming <murrayc@murrayc.com>
303 Make navigation work again.
305 * src/main/java/org/glom/web/server/libglom/Document.java:
306 Add getLayoutItemFieldShouldHaveNavigation().
307 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
308 Replace get/setAddNavigation() with the partly-existing
309 get/setNavigationTableName(), with an empty string being no navigation,
310 because this is simpler. Use the new
311 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
313 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
314 Add updateFieldsExtras() and call setNavigationTableName in it.
315 getDetailsLayoutGroup(),
316 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
317 createLayout(): Adapted.
318 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
319 Constructor: Adapted.
321 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
322 Replace get/setAddNavigation() with get/setNavigation(), returning a
323 TableToViewDetails class with both the table name and UsesRelationship,
324 because both are need. The previous code used java-libglom's output
325 variable (strangely, via sharedptr) to return both, but we cannot really
327 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
328 getNavigationRecord(): Adapt. However, we cannot actually use the cache
329 here because it somehow gets set to null during deepCopy(). I must test this.
330 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
331 testGetSuitableTableToViewDetails(): Adapted.
333 TODO: Find out why deepClone() is not quite working.
335 2012-05-11 Murray Cumming <murrayc@murrayc.com>
337 DBAccess: Simplify the retrievel of full field details.
339 * src/main/java/org/glom/web/server/database/DBAccess.java
340 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
341 because the Document loading should have done this.
343 2012-05-11 Murray Cumming <murrayc@murrayc.com>
345 Document: Correct loading of doubly-related layout fields.
347 * src/main/java/org/glom/web/server/libglom/Document.java:
348 loadUsesRelationship(): Actually set the related relationship, instead
349 of only setting it if it's not found.
351 2012-05-09 Murray Cumming <murrayc@murrayc.com>
353 Replace all appearances of Colour with color.
355 Because US English is dominant.
357 2012-05-09 Murray Cumming <murrayc@murrayc.com>
359 Use colors in HTML format, solving a warning about an unused function.
361 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
362 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
363 Add *asHTMLColor() versions of methods.
364 TODO: However, we should create and cache the results on the server.
365 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
366 * src/main/java/org/glom/web/client/ui/list/ListTable.java
367 * src/main/java/org/glom/web/server/ConfiguredDocument.java
368 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
369 Use the asHTMLcolor() versions.
371 2012-05-09 Murray Cumming <murrayc@murrayc.com>
373 ListViewTable: Constructor: Take the table name as a parameter.
375 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
376 Constructor: Take the tableName, and set the member variable, because
378 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
379 setCellTable(): Pass the table name.
380 This makes navigation to non-default tables work again. I don't know
381 why it worked before in the master branch.
383 2012-05-07 Murray Cumming <murrayc@murrayc.com>
385 ConfiguredDocument: Restore correct addition of hidden primary key items.
387 * src/main/java/org/glom/web/client/ui/list/ListTable.java
388 (ListTable.createCellTable): Uncomment out the check for the hidden
390 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
391 add primary key items for top-level lists and portals, as before,
392 instead of adding them to each group.
393 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
394 Actually implement the extra methods such as setHiddenPrimaryKey() and
395 comment that these are used only for top-level list groups and in portals.
396 This strangeness suggests even more that this should not be squeezed
397 into the LayoutGroup class.
399 2012-05-07 Murray Cumming <murrayc@murrayc.com>
401 Fix Formatting loading.
403 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
404 getFormattingUsed(): Remove the duplicate Formatting member variable
405 in favour of the one from the base class.
406 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
407 Initialize a new Formatting instead of using null by default, so we
408 have some defaults, instead of having to initialize one later just to
409 get the same defaults. This also makes loading of formatting from the
410 document work, because that expected a non-null.
412 2012-05-07 Murray Cumming <murrayc@murrayc.com>
414 RelatedListTable: Make sure that the tableName is set.
416 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
417 Constructor: Take the tableName so it is available later. Otherwise,
418 the server assumes that we mean the default table and cannot find the
420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
421 setData(): Pass the tableName to the RelatedListTable constructor.
423 2012-05-07 Murray Cumming <murrayc@murrayc.com>
427 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
428 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
429 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
431 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
433 * src/main/java/org/glom/web/server/database/DBAccess.java:
434 convertResultSetToDTO(), getPortal():
435 * src/main/java/org/glom/web/server/database/ListDBAccess.java
437 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
438 Add checks for null objects and out of range access, with log messages to
439 give hints so we can fix these properly.
441 2012-05-07 Murray Cumming <murrayc@murrayc.com>
443 Portals: some corrections.
445 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
447 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
448 constructor: Use getRelationshipNameUsed() instead of getName(), because
449 that is what is meant.
450 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
451 getFromField(): Fix a typo, to get the field name, not the table name.
452 * src/main/java/org/glom/web/server/database/DBAccess.java:
453 getPortal(): Fix a typo that stopped this from working.
455 2012-05-07 Murray Cumming <murrayc@murrayc.com>
457 LayoutItemPortal: Also override getTitleOriginal().
459 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
460 This lets the base getTitle() with no parameters work.
461 TODO: Test this properly.
463 2012-05-06 Murray Cumming <murrayc@murrayc.com>
465 LayoutItemPortal: getTitle*(): Use the relationship title.
467 2012-05-06 Murray Cumming <murrayc@murrayc.com>
469 LayoutItemField: Fix loading of custom titles.
471 * src/main/java/org/glom/web/server/libglom/Document.java
472 loadDataLayoutItemField(): The title, if any, instead of the field
473 title, is stored in a title_custom node. Load it from there.
474 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
476 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
477 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
478 getTitle*() overrides.
479 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
482 2012-05-06 Murray Cumming <murrayc@murrayc.com>
484 LayoutItemField: Fall back to field titles, so some are really shown.
486 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
487 Override getTitleOriginal() and getTitle(), as in java-libglom.
488 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
491 2012-05-06 Murray Cumming <murrayc@murrayc.com>
493 Correct use of setExpectedResultSize().
495 * src/main/java/org/glom/web/server/ConfiguredDocument.java
496 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
497 Use setExpectedResultSize only on top-level groups (for instance, the
498 list layout) or on child portals (in details views).
499 Use the correct table name for portals to avoid SQL errors.
500 Update the expected counts when returning cached layouts.
502 2012-05-06 Murray Cumming <murrayc@murrayc.com>
504 Document: Interpret no group column count as 1.
506 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
507 default, though we now check for this in the UI code anyway.
509 2012-05-06 Murray Cumming <murrayc@murrayc.com>
513 2012-05-06 Murray Cumming <murrayc@murrayc.com>
515 Translatable: Use Hashmap instead of Treemap because GWT supports it.
517 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
518 The use of Treemap lead to this error from async methods, with no
520 "The response could not be deserialized"
522 2012-05-06 Murray Cumming <murrayc@murrayc.com>
524 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
526 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
527 when using the Google -> GWT Compile, or
528 g toolbar button -> GWT Compile Project... feature in Eclipse.
530 2012-05-06 Murray Cumming <murrayc@murrayc.com>
532 ListTable.addColumn(): Protect against a null Formatting.
534 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
535 Create a default Formatting if it is null, because that is the simplest
538 2012-05-06 Murray Cumming <murrayc@murrayc.com>
540 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
542 * src/main/java/org/glom/web/server/ConfiguredDocument.java
543 updateLayoutGroup(): Check that the field is not null.
545 2012-05-06 Murray Cumming <murrayc@murrayc.com>
547 ListViewImpl: Protected against a bad cast error.
549 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
550 onEnterKeyDown(): Do not cast without an instanceof check.
552 2012-05-06 Murray Cumming <murrayc@murrayc.com>
554 ListTable: Protect against an out of range error.
556 * src/main/java/org/glom/web/client/ui/list/ListTable.java
557 createCellTable(): This is unlikely, but can happen while debugging.
559 2012-05-06 Murray Cumming <murrayc@murrayc.com>
561 AsyncMessage onFailure() callbacks: Log the exception message.
563 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
564 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
565 * src/main/java/org/glom/web/client/activity/ListActivity.java:
566 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
567 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
568 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
569 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
570 These are useful clues when something is wrong.
572 2012-05-06 Murray Cumming <murrayc@murrayc.com>
574 ConfiguredDocument: Avoid a null dereference.
576 * src/main/java/org/glom/web/server/ConfiguredDocument.java
577 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
578 details maps are created.
580 2012-05-06 Murray Cumming <murrayc@murrayc.com>
582 Document: Correct the port number parsing.
584 * src/main/java/org/glom/web/server/libglom/Document.java:
585 This lets us actually connect to the database and show the document.
587 2012-05-05 Murray Cumming <murrayc@murrayc.com>
591 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
592 user-interaction, asking us to load a temporary URL in a browser.s
593 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
594 which is apparently necessary for testing the service. See the comment.
595 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
596 Show the exception, if any. This is how I saw the 404 in the HTML in
599 2012-05-05 Murray Cumming <murrayc@murrayc.com>
601 DocumentTest: Move the .glom files into the resources directory.
603 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
604 URI via getResource().
606 2012-05-05 Murray Cumming <murrayc@murrayc.com>
608 Document: Remove the FieldIdentifies inner class.
610 * src/main/java/org/glom/web/server/libglom/Document.java: We only
611 use the Relationship (though the same function in libglom is maybe
612 used in other ways) and so this removes a compiler warning.
614 2012-05-05 Murray Cumming <murrayc@murrayc.com>
616 Document.load() Remove the error code parameter.
618 * src/main/java/org/glom/web/server/libglom/Document.java: load():
619 Remove the parameter. We do not set it yet and it could never have
620 worked as an output parameter (though maybe it did in java-libglom).
621 We could use an exception if we really want the failure reason.
622 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
624 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
625 setUp(), testGetSuitableTableToViewDetails(): Adapt.
627 2012-05-05 Murray Cumming <murrayc@murrayc.com>
629 Make some inner classes static.
631 * src/main/java/org/glom/web/server/ConfiguredDocument.java
632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
633 * src/main/java/org/glom/web/server/ReportGenerator.java
634 * src/main/java/org/glom/web/server/libglom/Document.java
635 Make all inner classes static that can be static.
637 2012-05-05 Murray Cumming <murrayc@murrayc.com>
639 OnlineGlomServiceImpl: Do not load and check for java-libglom.
641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
642 init(): We do not use java-libglom any more.
644 2012-05-05 Murray Cumming <murrayc@murrayc.com>
646 Remove mentions of java-libglom.
648 * README: Remove mention of java-libglom, because it no longer needed.
649 * utils/build-onlineglom-war.sh:
650 * utils/check-and-recover-tomcat.py:
651 * utils/install-onlineglom-war.sh: Remove these as they are no longer
652 useful. Building is now far easier, with no need for jhbuild.
654 2012-05-05 Murray Cumming <murrayc@murrayc.com>
656 Fix the build (mvn package)
658 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
659 (LayoutGroup): Make the LayoutItemList inner class static and protected.
660 Otherwise the GWT Java->Javascript compilation fails with just this
661 error, during mvn package or when attempting to view in a browser,
662 in the GWT developer mode in Eclipse.
664 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
665 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
666 [INFO] Compiling module org.glom.web.OnlineGlom
667 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
668 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
669 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
670 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
671 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
672 [INFO] [ERROR] Cannot proceed due to previous errors
674 It has taken me 2 days to find out what was causing that. After reducing
675 the code, the compiler eventually showed me the full error message.
677 2012-05-04 Murray Cumming <murrayc@murrayc.com>
679 ConfiguredDocument: Cache the cloned and stripped layouts.
681 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
682 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
683 layout in a map, so we can retrieve it again without rebuilding it.
685 2012-05-04 Murray Cumming <murrayc@murrayc.com>
687 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
689 2012-05-04 Murray Cumming <murrayc@murrayc.com>
691 libglom classes: Implement some auto-generated emthods.
693 2012-05-04 Murray Cumming <murrayc@murrayc.com>
695 Add GwtTestOnlineGlomService.
697 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
698 However, this (and the other GwtTest*) does not seem to run during
701 2012-05-04 Murray Cumming <murrayc@murrayc.com>
703 Remove use of unsupported features from client code.
705 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
706 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
707 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
708 Use our client version of StringUtils instead of the apache commons one.
710 However, the GWT Javascript compliation still fails.
712 2012-04-25 Murray Cumming <murrayc@murrayc.com>
714 Add a Field class and implement some loading of it in Document.
716 2012-04-25 Murray Cumming <murrayc@murrayc.com>
718 Initial Document loading implementation, instead of libglom.
720 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
721 and Translatable classes, and adapt the rest of the code to use them.
722 However, this is still missing Layout and Field classes and loading.
724 2012-04-24 Murray Cumming <murrayc@murrayc.com>
726 Use of jOOQ: Move Field creation into a utility method.
728 * src/main/java/org/glom/web/server/SqlUtils.java:
729 This lets us improve it more easily.
731 2012-04-24 Murray Cumming <murrayc@murrayc.com>
733 Use of jOOQ: Improve the code to COUNT a sub-select.
735 * src/main/java/org/glom/web/server/SqlUtils.java:
736 Move initial query creation into
737 build_sql_select_step_with_where_clause().
738 build_sql_select_count_rows(): Use the jOOQ API instead of
739 concatentating text, because a jOOQ Select*Step is a TableLike,
740 which is what from() takes.
742 2012-04-23 Murray Cumming <murrayc@murrayc.com>
744 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
746 * pom.xml: Depend on jooq.
747 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
748 methods with jOOQ, based on the C++ implementations in libglom,
749 with some changes to the logic required by jooQ.
750 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
752 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
753 * src/main/java/org/glom/web/server/ReportGenerator.java:
754 * src/main/java/org/glom/web/server/SqlUtils.java:
755 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
756 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
757 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
758 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
759 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
760 Adapt. In particular, the SqlUtils methods now need to take a Connection,
761 because jOOQ needs that, though it seems unnecessary.
763 This is not quite finished. Ideally jOOQ would help us to build
764 table_name.field_name names, quoting and escaping them properly.
765 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
767 2012-04-21 Murray Cumming <murrayc@murrayc.com>
769 Move use of Glom.build_sql*() into a new SqlUtils class.
771 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
772 to wrap Glom.build_sql*(). The parameter types are still Glom one,
773 but this will make it easier to start using something other than
774 libglom or SqlBuilder.
776 2012-04-21 Murray Cumming <murrayc@murrayc.com>
778 Update the project URL.
780 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
782 2012-04-21 Murray Cumming <murrayc@murrayc.com>
784 Main layout: Use a FlowTable instead of absolute positioning.
786 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
787 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
788 child panels/widgets must have an absolute position. But that is annoying, so
789 this adds a FlowTable and puts the child panels in there.
791 2012-04-21 Murray Cumming <murrayc@murrayc.com>
793 GwtTestOnlineGlom: Comment out unused code.
795 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
796 Eclipse has started to say that some code is unused.
798 2012-04-21 Murray Cumming <murrayc@murrayc.com>
800 Update to the latest versions of dependencies.
802 * pom.xml: Update version numbers of dependencies to the latest
804 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
806 * src/main/java/org/glom/web/server/ReportGenerator.java:
807 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
808 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
809 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
811 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
812 Modify the imports where necessary.
814 2012-04-17 Murray Cumming <murrayc@murrayc.com>
816 Style: Remove overflow:hidden from searchbox
818 * src/main/webapp/style.css: Because this pushes the Back To Link
819 label/link on to the next row, which is then hidden due to the
820 hard-coded (in ems) height.
822 2012-04-20 Murray Cumming <murrayc@murrayc.com>
824 Remove some duplicate code.
826 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
827 getDocumentInfo(): This must have been duplicated during the merge from the
832 2012-04-19 Murray Cumming <murrayc@murrayc.com>
834 Reports: Localize the waiting for report message.
836 * src/main/java/org/glom/web/client/activity/ReportActivity.java
837 start(): Get the message from the contants.
838 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
840 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
841 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
842 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
843 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
844 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
845 Update these files with the English text for newer strings for now.
847 2012-04-19 Murray Cumming <murrayc@murrayc.com>
849 Reports: Show a message while waiting for the report.
851 * src/main/java/org/glom/web/client/ui/ReportView.java
852 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
853 Add setWaitingText(), to show a message saying that we are
854 waiting for the report to be ready.
855 * src/main/java/org/glom/web/client/activity/ReportActivity.java
856 start(): Call setWaitingText() before calling the async
859 2012-04-19 Murray Cumming <murrayc@murrayc.com>
861 ReportGenerator: Specify date and time formats.
863 * src/main/java/org/glom/web/server/ReportGenerator.java:
864 createFieldValueElement(): Use the default (and localized)
865 short formats, though we still need a way to show 4-digit
866 years without providing the format for every locale.
867 * src/main/java/org/glom/web/server/database/DBAccess.java:
868 convertResultSetToDTO(): Use the short formats here too.
870 2012-04-18 Murray Cumming <murrayc@murrayc.com>
872 ReportGenerator: Use the correct numeric formatting.
874 * src/main/java/org/glom/web/server/ReportGenerator.java
875 createFieldExpression(), createFieldValueElement(): Take the
876 whole LayoutItem_Field instead of just the field name, so
877 we have access to the formatting.
878 createFieldValueElement(): Use JRTextField.setPattern() to
879 specify the numeric formatting, with the help of a
880 regular DecimalFormat.
882 2012-04-18 Murray Cumming <murrayc@murrayc.com>
884 ReportGenerator: Avoid showing null for group by titles.
886 * src/main/java/org/glom/web/server/ReportGenerator.java
887 generateReport(): Use setBlankWhenNull() on the field title
888 style too, because this is used for values in group by
891 2012-04-18 Murray Cumming <murrayc@murrayc.com>
893 ReportGenerator: Add a colon to titles in vertical groups.
895 * src/main/java/org/glom/web/server/ReportGenerator.java
896 addFieldToDetailBandVertical(): Pass true for the withColon
899 2012-04-18 Murray Cumming <murrayc@murrayc.com>
901 ReportGenerator: Simplify the code by using Position more.
903 2012-04-18 Murray Cumming <murrayc@murrayc.com>
905 Reports: Support vertical groups, roughly.
907 * src/main/java/org/glom/web/server/ReportGenerator.java:
908 addToReport(): Rename to addGroupToReport() and, if necessary,
909 call the new addVerticalGroupToReport() method.
910 createFieldValueElement(): Let the caller specify the Y position
913 2012-04-17 Murray Cumming <murrayc@murrayc.com>
915 Reports: Allow a second report to be shown.
917 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
918 clear(): Do not remove the HTML widget, which broke the whole layout.
920 2012-04-17 Murray Cumming <murrayc@murrayc.com>
922 Locales drop-down: Show that we use English by default.
924 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
925 fillView(): When we use English, just because that is the default, when
926 no locale is specified, show that in the Locales drop-down instead of
927 just showing the first item.
929 2012-04-17 Murray Cumming <murrayc@murrayc.com>
931 Unselect the Report/Locale/Table combo item when appropriate.
933 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
934 setPlace(): clear reportName if this is not a ReportPlace.
935 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
936 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
937 When the provided name is empty, unselect all items, so that none are
938 indicated. This uses a for loop because I cannot find a single method
941 2012-04-17 Murray Cumming <murrayc@murrayc.com>
943 Report: Give the user a way to get back to the list.
945 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
946 start(), setPlace(): Show the Back To List link on reports, and also
947 interpret selecting the empty report item as back to list.
949 2012-04-13 Murray Cumming <murrayc@murrayc.com>
951 Really show the selected Report name.
953 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
954 setPlace(): Store the reportName here, if it is that kind of Place.
955 fillView(): Set the selected Report after filling the list of reports.
956 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
957 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
958 null Strings, though we need some way to unselect all ListBox items
961 2012-04-13 Murray Cumming <murrayc@murrayc.com>
963 ReportGenerator: Try to avoid some problems.
965 * src/main/java/org/glom/web/server/ReportGenerator.java
966 addField(): Try to avoid duplicates, and avoid using a null
969 2012-04-13 Murray Cumming <murrayc@murrayc.com>
971 Reports: Use quickFind.
973 * src/main/java/org/glom/web/client/OnlineGlomService.java;
974 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
976 getReportHTML(): Add a quickFind parameter.
977 * src/main/java/org/glom/web/client/activity/ReportActivity.java
978 start(): Pass the quickFind parameter.
979 * src/main/java/org/glom/web/server/ReportGenerator.java
980 generateReport(): Take a quickFind parameter.
982 2012-04-13 Murray Cumming <murrayc@murrayc.com>
984 ReportPlace: Actually use the report name.
986 * src/main/java/org/glom/web/client/place/ReportPlace.java
987 getPlace(): Do not assign the report name to the quickfind.
989 2012-04-13 Murray Cumming <murrayc@murrayc.com>
991 Show java.library.path when complaining.
993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
994 init(): When telling us to check java.library.path, show the
997 2012-03-06 Murray Cumming <murrayc@murrayc.com>
999 ReportGenerator: Do not show nulls.
1001 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1003 ReportGenerator: Make the title font larger.
1005 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1007 ReportGenerator: Put field titles inside groups, if there are groups.
1009 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1011 ReportGenerator: Take the Report itself instead of the name and group.
1013 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1014 Remove getReportLayoutGroup().
1015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1016 getReportHTML(): Pass the report instead
1017 of its name and layout group.
1018 * src/main/java/org/glom/web/server/ReportGenerator.java
1019 generateReport(): Use the report object to use the title
1020 instead of the name.
1022 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1024 ReportGenerator: Remove designBand parameters.
1026 * src/main/java/org/glom/web/server/ReportGenerator.java:
1027 Make designBand a class member instead of passing it to all
1030 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1032 ReportGenerator: Add lines, a bit like in the desktop version.
1034 * src/main/java/org/glom/web/server/ReportGenerator.java
1035 addToReport(): Use JRDesignLine.
1037 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1039 ReportGenerator: Correct the title positions and use some bold style.
1041 * src/main/java/org/glom/web/server/ReportGenerator.java:
1042 Break the code up into reusable functions, correct the placement of
1043 titles, and use normal/bold styles as in the reports in the desktop
1046 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1048 ReportGenerator: Add a header band to show the field titles.
1050 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1051 getReportHTML(): Pass the localeId to the ReportGenerator
1053 * src/main/java/org/glom/web/server/ReportGenerator.java
1054 constructor: Take the localeID so we can get translated field
1056 generateReport(), addToReport(), addFieldToBand(): Add field
1057 titles in a column header band.
1059 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1061 Reports drop-down list: Some improvement.
1063 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1064 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1065 Adedd setSelectedReport(),
1066 setReportList(): Add a blank line so that the user can select the
1068 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1069 start(): Show the current report by calling setSelectedReport().
1070 This does not seem to work yet.
1072 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1074 DetailsActivity, ListActivity: Move some variables into a base class.
1076 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1077 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1078 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1079 the clientFactory, documentID, tableName and authenticationPopup into
1080 a base class, to avoid duplication.
1082 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1084 Translate the Reports label.
1086 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1087 Get the "Reports" label string from the constants.
1088 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1089 perties: Add Reports to the constants.
1091 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1093 Reports: Implement grouping.
1095 * src/main/java/org/glom/web/server/ReportGenerator.java:
1096 Handle LayoutItem_GroupBy items and try to do the right thing
1097 with JRDesignGroup. It seems to work.
1099 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1101 Actually show some data with JasperReports.
1103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1104 getReportHTML(): Move most code into a ReportGenerator class.
1105 * src/main/java/org/glom/web/server/ReportGenerator.java:
1106 Recurse into sub-groups, adding fields to the JasperDesign's details
1107 band. Note that we must set an arbitrary width and height, or it just
1108 will not show any data.
1110 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1112 Reports Chooser: Show the titles, not the names.
1114 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1115 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1116 and the names as the values.
1117 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1118 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1119 group now that we provide the report name, so it should always
1122 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1124 Depend on jasperreports.
1126 * pom.xml: Add the dependency. My plan is to use this on the
1129 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1131 Implement navigation to report places.
1133 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1134 start(): Do not bother to handle all events here.
1135 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1136 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1137 Added getSelectedReport().
1138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1139 .java: start(): When handling a change to the reports chooser,
1140 call getSelectedReport() and goTo() its ReportPlace.
1141 * src/main/java/org/glom/web/client/ui/ReportView.java
1142 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1143 Added setReportHTML() which puts the html in a gwt HTML widget.
1144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1145 getReportHTML(): Return "TODO" just to show that this works.
1147 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1149 Make ReportPlace usable.
1151 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1152 Mention ReportPlace.
1153 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1154 Correct the @prefix annotation.
1156 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1158 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1160 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1161 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1163 Change getReportLayout() to getReportHMTL() because we will not need to
1164 parse or render the report layout on the client side.
1165 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1166 getReportLayout(): Return the libglom LayoutGroup type because we will
1167 not need to convert to a shared type, because this will not be used on
1169 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1172 Note that there is still no implementation for this.
1175 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1177 Add a (empty) Report Place, View, and Activity.
1179 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1181 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1182 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1183 this into a superclass:
1184 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1185 and also use it as the base of this new ReportPlace:
1186 * src/main/java/org/glom/web/client/place/ReportPlace.java
1188 * src/main/java/org/glom/web/client/ui/ReportView.java
1189 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1190 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1191 Add these, containing mostly boiler-plate for now.
1193 * src/main/java/org/glom/web/client/OnlineGlomService.java
1194 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1195 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1197 Add API to get the LayoutGroup for the report.
1199 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1201 Add and fill a Reports drop-down list box.
1203 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1205 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1206 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1208 Added getReports(document, table, localeID), calling
1209 ConfiguredDocument.getReports().
1210 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1211 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1212 Added setReportsList() and a list widget.
1213 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1214 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1219 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1221 Translations: Add Esperanto.
1223 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1224 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1225 properties: Add this translation because someone took the time to make it.
1227 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1229 Adapt to the java-libglom 1.21.7 API.
1231 * src/main/java/org/glom/web/server/ReportGenerator.java:
1232 addToReport(): get_group_secondary_fields() is now
1233 get_secondary_fields().
1236 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1238 Use the latest java-libglom version.
1240 * pom.xml: Use java-libglom 1.21.7.
1242 2012-03-03 Ben Konrath <ben@bagu.org>
1244 Display date and time in details view.
1246 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1248 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1250 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1252 Require the latest java-libglom.
1254 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1256 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1258 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1260 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1261 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1262 an empty quickfind string. I also corrected libglom to create only
1263 empty where clauses for empty quickfind strings, but this avoids the
1266 2012-02-24 Ben Konrath <ben@bagu.org>
1268 Improve the tabs in the Notebook widget.
1272 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1274 Translations: Try to translate the strings.
1276 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1277 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1278 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1279 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1280 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1281 Take the Open translation from GTK+'s .po files.
1282 Take the Details translation from Glom's po files.
1283 I have added the other strings to Glom so we can get translations that way:
1284 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1286 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1288 TableSelectionViewImpl: Put the search label and entry in a div.
1290 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1291 Put the search widgets in a FlowTable so that the CSS can be used to
1292 style them while keeping them together.
1293 * src/main/webapp/style.css: Mention the new div.
1295 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1297 Translate more strings in more locales.
1299 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1300 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1301 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1302 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1303 Translate the "Details" and "Open" string too.
1305 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1306 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1307 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1308 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1309 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1310 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1311 Add these new locales as placeholders though they currently contain English.
1313 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1315 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1317 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1318 Check the ConfiguredDocument* for null before using it.
1320 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1322 Tell Eclipse about the generated java files.
1324 * .classpath: This lets it find OnlineGlomConstants.java.
1325 It would be nice if Eclipse just used the maven build files.
1327 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1329 Prevent a crash when no locale is specified in the URL.
1331 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1332 Avoid returning a null string, obtained from
1333 Window.Location.getParameter(). This caused a crash when it was
1334 later passed to libglom's API.
1335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1336 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1337 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1338 guard against future null strings.
1340 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1342 Use the ?locale= query param instead of the &lang= token param.
1344 * src/main/java/org/glom/web/client/place/ListPlace.java
1345 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1346 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1347 Remove the lang token key and value.
1349 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1350 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1351 When the user selects a different locale from the chooser, use
1352 Window.Location.assign() to change the URL, which then causes a reload.
1354 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1355 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1356 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1357 * src/main/java/org/glom/web/client/activity/ListActivity.java
1358 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1359 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1360 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1361 * src/main/java/org/glom/web/client/ui/ListView.java:
1362 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1364 Remove localeID member variables and method/constructor parameters, instead
1365 using Utils.getCurrentLocaleID() when we need a localID to pass to
1368 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1370 Internationalize the UI strings.
1372 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1373 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1374 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1375 because it is unused. Messages are apparently strings that can have
1376 parameters, but we do not need that yet, so Contants will be enough for now.
1377 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1378 to say that we support the en and de locales.
1379 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1380 The original English strings.
1381 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1382 Some German translations of the English strings.
1383 The i18n goal then uses the .properties file to generate an
1384 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1385 returns an implementation that returns the translated strings.
1386 The documentation suggests putting these in src/java/*/client/, but it seems
1387 best to put it in src/resources/*/client/.
1388 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1389 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1390 instead of hard-coding them.
1391 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1392 but that does not seem to stop the build, though it confuses Eclipse.
1394 You can see the translated string by adding ?locale=de to the URL, like so:
1395 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1397 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1399 Improve null/empty String checks.
1401 * pom.xml: Add a dependency on commons-lang, to use
1402 org.apache.commons.lang.StringUtils.
1403 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1404 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1405 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1406 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1407 Use StringUtils.isEmpty().
1409 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1410 StringUtils class with a static isEmpty() function because we
1411 cannot use org.apache.commons.lang.StringUtils in client-side
1412 GWT code because it (apparently) cannot be compiled to javascript.
1413 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1414 * src/main/java/org/glom/web/client/activity/ListActivity.java
1415 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1416 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1417 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1418 * src/main/java/org/glom/web/client/place/ListPlace.java
1419 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1420 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1421 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1422 * src/main/java/org/glom/web/client/ui/details/Group.java
1423 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1424 our StringUtils.isEmpty() function.
1426 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1428 Update to the latest java-libglom API.
1430 * pom.xml: Require java-libglom 1.21.4.
1431 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1432 getDocumentInfo(), getListViewLayoutGroup():
1433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1435 * src/main/java/org/glom/web/server/database/DBAccess.java
1436 getFieldsToShowForSQLQueryAddGroup(),
1437 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1438 with either get_database_title_original() or
1439 get_database_title(localeID).
1441 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1443 ConfiguredDocument: Avoid a null pointer exception.
1445 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1446 Initialize localeID to "" to avoid returning a null String which
1447 causes a crash in java-libglom's swing-generated code.
1449 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1451 Some simple renaming.
1453 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1454 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1455 for localeChooser. This seems more appropriate and is less ambiguous
1456 particularly in the .css file.
1458 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1460 ConfiguredDocument: Rename the localedID private member variable.
1462 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1464 Adapt to the latest java-libglom API from git master.
1466 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1467 libglom now uses only Vector instead of List, which uses add() instead of
1470 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1472 ConfiguredDocument: Rename the localedID private member variable.
1474 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1476 Build a source tarball with mvn assembly:single
1478 * assembly.xml: Add this file.
1479 * pom.xml: Use the maven-assembly-plugin and tell it to use
1480 our assembly.xml file.
1482 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1484 OnlineGlomServiceImpl: Get .glom files recursively.
1486 * pom.xml: Depend on commons-io from org.apache.commons.
1487 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1488 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1489 files recursively, and with the easier filter for the extension.
1490 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1491 simplify that code too.
1493 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1495 README: Mention that you must install java-libglom packages separately.
1497 But then it works, because java-libglom is now in the central maven
1500 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1502 locales drop-down: Show the correct selected locale when the URL changes.
1504 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1505 .java: setPlace(): Move some code into fillView().
1507 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1509 locales drop-down: Do not lose the primary key.
1511 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1512 start(): onLocaleChange(): Pass the current primary key value,
1513 instead of an empty value.
1515 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1517 locales drop-down: Do not lose the drop-down selection.
1519 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1520 .java (TableSelectionActivity.fillView): Set the selected locale
1521 after changing the drop-down items (though we do not really need
1522 to change them just because the locale changes.)
1524 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1526 locales drop-down: Change the tables list when this changes.
1528 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1529 .java: TableSelectionActivity.start(): Move the async table titles
1530 retrieval into a private fillView() method and also call this when
1531 the chosen locale changes.
1532 Note that the document title is not actually translatable yet, but
1533 that is a problem that I should fix soon in libglom.
1535 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1537 Improve the placement of the locales drop-down.
1539 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1540 Put the title and locales drop-down in a div (gwt.FlowTable).
1541 * src/main/webapp/style.css: Add magic css properties to make this work.
1542 Also remove the left margin from the title so that it lines up with the
1545 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1547 locales selector: Show human-readable locale titles.
1549 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1550 getDocumentInfo(): Use java.util.Locale to show a real title of
1551 each locale, in the locale's own language.
1553 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1555 Add a language/locale selector drop-down.
1557 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1558 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1559 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1560 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1561 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1562 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1563 Add a ListBox to show the available locales. Add getLocaleSelector(),
1564 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1565 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1566 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1567 java: Add these classes.
1568 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1569 start(): Fill the locales ListBox. Handle its change event, firing a
1571 setPlace(): Show the selected locale as specified by the URL token.
1572 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1573 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1574 Handle LocaleChangeEvent, going to a new *Place with that locale.
1576 The placement of the ListBox is not pretty, and it currently uses the ID
1577 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1581 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1583 Search box: Show the search text from the URL token.
1585 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1586 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1587 Add setQuickFindText().
1588 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1589 .java: setPlace(): Store the queryText if the place is a ListPlace,
1590 and call TableSelectionView.setQuickFindText().
1592 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1594 Allow use of translations via, for instance, &lang=de in the URL.
1596 * pom.xml: Use the unstable java-libglom 1.21 version.
1598 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1599 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1601 init(): Instead of calling TranslatableItem.set_current_locale()
1602 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1603 However, this is only for default locales, which are not needed to
1604 change the locale in the URL.
1605 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1606 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1607 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1608 layout for a particular locale.
1609 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1610 Add get/setDefaultLocaleID().
1611 getDocumentInfo(), getListViewData(), getRelatedListData(),
1612 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1613 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1614 localeID parameter, so we can get the layout for a particular locale.
1616 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1617 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1618 * src/main/java/org/glom/web/client/place/ListPlace.java:
1619 Parse and construct a lang parameter too.
1621 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1622 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1623 passed to subsequent methods and constructors.
1624 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1625 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1626 Store the localeID from the *Place and pass it to other constructors
1627 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1629 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1630 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1631 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1632 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1633 * src/main/java/org/glom/web/client/ui/ListView.java:
1634 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1635 Take localeID parameters and pass them to subsequent constructors and
1636 methods, so that the layout is always retrieved for that locale.
1638 This is rather repetitive.
1640 Note that "" means the original (default) locale of the Glom document,
1641 which is usually English.
1643 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1645 Documents: Remove final keyword to fix startup configuration.
1647 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1648 final keywords on the private member variables because that breaks
1649 the startup, apparently (there are warnings) because it stops them
1650 from being serialized. I added these in the previous commit.
1652 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1654 Documents: Add some final keywords.
1656 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1659 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1661 OnlineGlomServiceImpl: Add to overview comments.
1663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1664 Note that this is where all the document are loaded. They are not
1665 loaded freshly for each page.
1667 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1671 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1672 Add a TextBox for the text of a quick find.
1673 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1675 setBackLink(): Add a String quickFind parameter.
1676 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1677 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1678 to the base interface, because that is how TableSelectionViewImpl is used.
1679 * src/main/webapp/style.css: Add style for the search box and its label.
1681 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1682 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1683 Add these files, based on the existing TableChangeEvent and
1684 TableChangeEventHandlers.
1685 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1686 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1687 a ListPlace() that the user should be taken to.
1688 * src/main/java/org/glom/web/client/activity/ListActivity.java
1689 start(): Handle it here too and adapt the TableChangeEvent handler to
1690 pass the extra "" quickFind parameter to ListPlace.
1691 * src/main/java/org/glom/web/client/place/ListPlace.java:
1692 Constructor: Take an extra String quickFind parameter and store it,
1693 returning it from a new getQuickFind() method.
1694 getToken(): Put the quickFind text in the URL token.
1695 getPlace(): Parse the quickFind text from the URL token.
1696 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1697 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1698 ListPlace constructor.
1699 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1700 .java: start(): Add a Change handler for the TableSelectionView's
1701 TextBox (via its base HasChangeHandlers interface), firing the new
1702 QuickFindChangeEvent.
1703 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1704 pass the extra "" quickFind parameter.
1706 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1707 setCellTable(): Add a String quickFind parameter and pass it to
1708 the ListViewTable() constructor.
1709 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1710 setCellTable() in the base interface, because that is how ListViewImpl
1713 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1714 Add a String quickFind member variable.
1715 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1716 Constructor: Add a String quickFind parameter, storing it in the
1717 base ListTable's member variable.
1718 onRangeChanged(): Pass quickFind to the
1719 OnlineGlomServiceAsync.getSortedListViewData() and
1720 OnlineGlomServiceAsync.getListViewData() methods.
1722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1723 getListViewData(), getSortedListViewData(): Add a String quickFind
1724 parameter, passing it to ConfiguredDocument.getListViewData().
1725 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1726 Change getListViewData(), getSortedListViewData() in the base interface,
1727 because that is how OnlineGlomServiceImpl is used, via this:
1728 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1729 Change getListViewData(), getSortedListViewData() here too.
1730 This class can apparently be used to asynchronously call methods on
1731 OnlineGlomService, and GWT seems to implement that after recognizing
1732 just the *Async name convention and the extra AsyncCallback parameters.
1734 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1735 getListViewData(): Add a String quickFind parameter, and pass it to
1736 ListViewDBAccess.getData().
1737 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1738 getListData(): Add a String quickFind parameter and pass it to
1740 getSelectQuery(): Add a String quickFind parameter.
1741 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1742 getSelectQuery(): Add a String quickFind parameter and use it with
1743 Glom.get_find_where_clause_quick() to pass a where_clause to
1744 Glom.build_sql_select_with_where_clause(), to actually filter the
1746 getData(): Add a String quickFind parameter, passing it to getListData().
1747 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1748 va: getData(): Pass an empty string to getListData() for the
1749 quickFind parameter.
1751 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1753 ListTable: Minor change.
1755 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1756 createCellTable(): Make this protected instead of public.
1758 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1760 Many files: Use final for the parameters and use the @override attribute.
1762 2012-01-22 Ben Konrath <ben@bagu.org>
1764 Add anchor links for single line text that starts with http, ftp and www.
1768 2012-01-22 Ben Konrath <ben@bagu.org>
1770 Add ellipsis to single line text in details view.
1774 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1776 Remove all javadoc author tags.
1778 Because they are awkward and meaningless when many people touch
1780 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1782 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1784 Revert the COPYING.LESSER to COPYING rename.
1786 Apparently both should be there if it is LGPL.
1788 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1790 *View: Remove unused imports.
1792 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1793 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1794 * src/main/java/org/glom/web/client/ui/ListView.java:
1795 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1796 Remove unused imports, as suggested by Eclipse.
1798 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1800 Move the *View::Presenter types, and some API into one base View.
1802 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1803 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1804 * src/main/java/org/glom/web/client/ui/ListView.java:
1805 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1806 Presenter, setPresenter() and clear() into a shared base interface,
1807 to avoid the unnecessary duplicate Presenter types and to more clearly
1808 show how the *Views share the same structure, even if they are not
1809 used polymorphically.
1811 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1812 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1814 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1815 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1816 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1818 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1821 Feel free to revert this if there is a good reason for the duplicate
1824 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1826 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1828 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1829 a class member instead of a local variable in the method.
1830 This lets us use it to get the view instances, for use in tests.
1831 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1832 beforeOnlineGlom(): Test some more details of the initial view.
1833 Again, this is not very useful.
1835 To really test gwt-glom we will need to start a local postgresql
1836 instance with local data, like the Glom tests in C++.
1838 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1840 pom.xml: Mention the LGPL license.
1842 * pom.xml: Add a licenses section.
1843 * COPYING.LESSER: Move this to COPYING, which
1844 previously contained the GPL. But gwt-glom is all LGPL.
1846 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1848 Add project information to README and pom.xml.
1850 * README: Add a brief description and mention some mvn
1852 * pom.xml: This extra information shows up in mvn site
1855 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1857 Use the latest java-libglom version.
1859 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1861 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1863 GwtTestOnlineGlom: Test a little more.
1865 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1866 protected rather than private, as suggested by the gwt-test-utils
1868 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1869 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1870 Test the initial visibility of the panels.
1872 However, this is not a very useful test.
1873 And I wonder how we should generally test using this idea for an
1874 activity/places app like ours where the real changes happen implicitly
1875 based on the history token/URL.
1877 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1879 Slight modification to *Mapper comments.
1881 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1882 (DataActivityMapper)
1883 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1885 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1887 Remove comments mentioning GIN because they are just copied from
1888 the example code and are apparently not helpful:
1889 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1890 Also change the mention of a class that is only in the example code.
1892 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1894 GwtTestOnlineGlom test: Minor changes.
1896 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1897 Avoid the long qualified class name and modify the comment
1898 because it is now obvious to me that the mocked class is the only
1899 custom one created via GWT.create().
1901 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1903 Tests: Added the beginnings of a test using gwt-test-utils.
1905 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1906 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1907 which tells gwt-test-utils what class will be tested.
1908 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1909 Add a simple (but empty) test case. One class, used by the OnlineGlom
1910 class, is mocked so that it can be created. However, I am not sure
1911 why only this class needs to be mocked.
1913 Note that mockito seems more popular, and clearer, than easymock,
1914 but I have not got that working yet. It might be a matter of the
1917 This test is run during mvn integration-test.
1919 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1921 Tests: Use junit4-style syntax instead of junit3-style.
1923 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1924 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1925 * src/test/java/org/glom/web/shared/DataItemTest.java:
1926 Use the @Test annotation rather than relying on the test*() prefix.
1927 Also no longer implement TestCase, to avoid triggering support for
1928 the junit3-way, which stops the annotations from working.
1929 Change the imports from import junit.framework.* to
1930 import org.junit.*, which is apparently the new way.
1932 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1934 Added a test for ListPlace token parsing and creation.
1936 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1937 This is much the same as DetailsPlaceTest.
1939 I wonder how we could test the other parts of the *Place API.
1941 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1943 DetailsPlace test: Also test getToken() and recreation via getPlace().
1945 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1946 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1947 recreate it, testing the recreated DetailsPlace for the same parameter
1950 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1952 Use the surefire-report plugin.
1954 * pom.xml: This generates a HTML report about the tests in
1955 target/site/surefire-report.html
1956 when you do mvn surefire-report:report. It seems to be popular/normal.
1958 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1960 Added a test for DetailsPlace.
1962 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1963 Test the getPlace() token parsing.
1965 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1967 Added a first unit test.
1969 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1970 * src/test/java/org/glom/web/shared/DataItemTest.java:
1971 This is a silly test but it is just to get things started. Note that
1972 maven/junit finds the test because it looks in src/test by default.
1974 2011-12-22 Ben Konrath <ben@bagu.org>
1976 Change charsetName to "UTF-8" when replacing line breaks.
1978 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1979 that work in Java (such as "UTF8") will not work when compiled to
1982 This fixes a problem with multi-line details view fields that have hard
1983 line breaks. The "License Text" field on this page demonstrates the
1986 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1988 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1990 2011-12-22 Ben Konrath <ben@bagu.org>
1992 Fix another bug with related list navigation.
1994 I've tested all the navigation buttons in all of the related lists
1995 so things should be good now.
1997 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1999 2011-12-22 Ben Konrath <ben@bagu.org>
2001 Fix a crasher when refreshing the list view with the default table.
2003 This crash will also happen when loading the list view with the default
2004 table from a link or bookmark.
2006 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2007 to the main document selection page when the document id hasn't been
2009 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2010 the main document selection page when the document id hasn't been
2012 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2013 values for the details place when the document id hasn't been set.
2014 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2015 values for the list place when the document id hasn't been set.
2017 2011-12-21 Ben Konrath <ben@bagu.org>
2019 Protect against NPE when glom.document.locale is not in config.
2021 This patch protects against an NPE when glom.document.locale is not in
2022 the config file. This NPE will also happen if glom.document.locale is
2025 The patch also updates the error message to display the class name when
2026 the getMessage() returns null. This was happening when the NPE was
2027 thrown and I had "Configuration Error: null". If an NPE is encountered
2028 with this patch, "Configuration Error: NullPointerException " will be
2031 This commit closes this bug:
2033 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2037 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2039 Rename onlineglom.properties to onlineglom.properties.sample.
2041 * src/main/resources/onlineglom.properties: Rename to:
2042 * src/main/resources/onlineglom.properties.sample:
2043 * src/main/resources/README: And add this file explaining that people
2044 should rename it back when deploying.
2046 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2048 Allow choosing the translation in the .properties file.
2050 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2051 init(): Read a glom.document.locale value from the configuration file
2052 and call Glom's TransatableItem::set_current_locale() method.
2053 * src/main/resources/onlineglom.properties: Add a commented-out
2054 example of this new setting.
2056 It would be better to add &lang=de_DE to the URL, but the current
2057 libglom API does not allow us to do this easily. I am working on that.
2059 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2061 Avoid a crash in parsing of token parameters.
2063 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2064 ava: getTokenParams(): Do not crash if a parameter has a key but no
2065 value, and ignore parameters with neither.
2067 2011-12-17 Murray Cumming <murrayc@murayc.com>
2069 History token building/handling: Improve use of token parameters.
2071 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2072 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2073 and buildParamsToken(HashMap), for use by derived classes.
2074 Make the separator private because it is no longer be needed.
2075 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2076 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2077 instead of manual string concatenation.
2078 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2079 of hardcoded indices and awkward splitting code.
2080 * src/main/java/org/glom/web/client/place/ListPlace.java
2081 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2082 instead of manual string concatenation.
2083 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2084 of hardcoded indices and awkward splitting code.
2085 This should fix bug #666420
2087 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2089 Fix a Navgiation->Navigation typo in the code.
2091 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2092 Rename processNavgiation() to processNavigation().
2094 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2096 Fix a seperator->separator typo in the code.
2098 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2099 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2100 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2103 2011-12-15 Ben Konrath <ben@bagu.org>
2105 Cleanup some comments.
2107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2109 2011-12-14 Ben Konrath <ben@bagu.org>
2111 Replace \n with <br/> for multiline text in the details view.
2113 Vertical scrollbars are added when needed as well.
2115 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2117 2011-12-14 Ben Konrath <ben@bagu.org>
2119 Specify the font for document selection links.
2121 * src/main/webapp/style.css:
2123 2011-12-14 Ben Konrath <ben@bagu.org>
2125 Fix bouncy CellTable while paging.
2127 This doesn't currently work with related list tables in unselected
2130 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2132 2011-12-14 Ben Konrath <ben@bagu.org>
2134 Revamp the appearance of the document selection page.
2136 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2137 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2138 * src/main/webapp/style.css:
2140 2011-12-13 Ben Konrath <ben@bagu.org>
2142 Set navigation button column to the smallest size possible.
2144 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2146 2011-12-13 Ben Konrath <ben@bagu.org>
2148 Change OpenButton nomenclature to NavigationButton.
2150 Using NavigtionButton makes things more generic. Classes, methods and
2151 variables have been changed.
2153 This is a rename-only refactor.
2155 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2156 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2157 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2158 Renamed from OpenButtonCell.
2159 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2160 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2161 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2163 2011-12-12 Ben Konrath <ben@bagu.org>
2165 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2167 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2168 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2169 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2170 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2172 2011-12-12 Ben Konrath <ben@bagu.org>
2174 Update variable names and comments.
2176 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2177 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2179 2011-12-12 Ben Konrath <ben@bagu.org>
2181 Properly initialize numNonEmptyRows variable to zero.
2183 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2184 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2186 2011-12-05 Ben Konrath <ben@bagu.org>
2188 Add latest mockup with HTML tables.
2190 Features of this mockup:
2192 -> HTML table for flowtable
2193 -> HTML table for flowtable column
2194 -> Example of how related lists would look
2195 -> Not using text entries for data items
2197 The current version of Online Glom doesn't use HTML tables for the
2200 This mockup has been sent to the glom-devel mailing list but it's good
2201 to have it here as well.
2203 * mockups/details-view-html-tables.html:
2205 2011-12-05 Ben Konrath <ben@bagu.org>
2207 Remove unnecessary getPrimaryKeyField() method.
2209 getPrimaryKeyFieldForTable(String) has been renamed to
2210 getPrimaryKeyField(String).
2212 * src/main/java/org/glom/web/server/database/DBAccess.java:
2213 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2214 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2216 2011-12-05 Ben Konrath <ben@bagu.org>
2218 Add string representation of TypedDataItem value to conversion error message.
2220 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2221 message was extracted into its own method to avoid duplication.
2223 2011-12-05 Ben Konrath <ben@bagu.org>
2225 Add type checking to navigation primary key value creation.
2227 Create navigation primary key only if the expected type from the Glom
2228 document matches the type returned by the SQL query.
2230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2232 2011-12-05 Ben Konrath <ben@bagu.org>
2234 Rename a couple of variables in RelatedListNavigation.
2236 This is a rename-only refactor.
2238 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2240 2011-12-05 Ben Konrath <ben@bagu.org>
2242 Move getListLayoutGroup() into getListViewLayoutGroup().
2244 This removes getListLayoutGroup(). It was only being called by
2245 getListViewLayoutGroup().
2247 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2249 2011-12-05 Ben Konrath <ben@bagu.org>
2251 Remove check for LayoutItem_Portal in list table method.
2253 This check is no longer necessary because the method isn't being used
2254 to create the LayoutItemPortal DTO.
2256 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2258 2011-12-05 Ben Konrath <ben@bagu.org>
2260 Properly support related list navigation.
2262 Navigation from the "Repository Analyzer -> Package Scans ->
2263 Dependencies" related table wasn't working because the primary key for
2264 related tables wasn't being set properly. This commit fixes the
2267 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2268 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2269 doesn't set the primary key properly for related list tables.
2270 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2271 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2272 useful for getting the primary key for list view tables and for related
2274 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2275 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2276 Move code to set the primary key for the table from the abstract
2277 ListDBAccess class to ListViewDBAccess as it's only correct for list
2279 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2280 Properly add primary key to related list tables.
2282 2011-12-02 Ben Konrath <ben@bagu.org>
2284 Properly set the horizontal alignment of fields.
2286 This fix is for both the list tables and the details view.
2288 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2289 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2290 to set the horizontal alignment of fields.
2292 2011-12-02 Ben Konrath <ben@bagu.org>
2294 Display currency codes in the details view.
2296 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2298 2011-12-02 Ben Konrath <ben@bagu.org>
2300 Avoid duplicate JNI call.
2302 JNI is not as efficient as pure Java and this is an easy (and small)
2305 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2306 Use previously retrieved value for whereClauseToTableName instead of
2309 2011-12-02 Ben Konrath <ben@bagu.org>
2311 Rename a couple of variables in RelatedListNavigation.
2313 This is a rename-only refactor.
2315 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2317 2011-12-02 Ben Konrath <ben@bagu.org>
2319 Indicate clearly that a mismatched primary key type is a bug.
2321 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2322 warning to error. Add 'This is a bug.' to message.
2324 2011-12-02 Ben Konrath <ben@bagu.org>
2326 Update / fix some comments.
2328 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2330 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2332 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2333 Fix comments. Add some TODOs.
2335 2011-12-02 Ben Konrath <ben@bagu.org>
2337 Enable navigation to details view with string primary key from related list.
2339 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2340 Create a text primary key value when return type of result is
2341 java.sql.Types.VARCHAR.
2343 2011-12-02 Ben Konrath <ben@bagu.org>
2345 Use checkboxes for booleans in the details view.
2347 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2349 2011-12-01 Ben Konrath <ben@bagu.org>
2351 Improve performance of related list height calculation.
2353 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2354 Put code to calculate the expected height in a static initializer so
2355 that that it's only called once.
2357 2011-12-01 Ben Konrath <ben@bagu.org>
2359 Show related list tables in notebooks (again).
2361 Calculate the height of the related list tables so the Notebook can be
2362 set the correct height. The height of the related list table is also needed by
2363 FlowTable to be able decide how to create the layout.
2365 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2366 and set the Portal height based on the height of the related list
2367 table and the Portal container.
2368 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2369 Add method to calculate the height of the related list tables.
2370 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2371 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2372 calculate the height of the Pager widget.
2374 2011-12-01 Ben Konrath <ben@bagu.org>
2376 Use CellTable API for table property instead of setting style on Element.
2378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2380 2011-12-01 Ben Konrath <ben@bagu.org>
2382 Make ListViewTable and RelatedListTable a consistent height.
2384 The tables are now a consistent height regardless of the contents of
2385 the table. A hidden button is added to empty rows to ensure that the
2386 height of these rows will match the height of rows with data.
2388 A navigation button column is now added to every table. The width of
2389 the navigation column is set to 0px when a RelatedListTable shouldn't
2390 have navigation buttons. This maintains the a consistent row height in
2391 tables that don't show the navigation buttons.
2393 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2394 navigation column when not needed.
2395 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2396 arguments for navigation button to constructor of ListViewTable.
2397 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2398 hidden button for empty data rows.
2399 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2400 arguments for navigation button to constructor.
2401 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2402 create navigation buttons. Add hideNavigationButtons() method.
2403 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2404 arguments for navigation button to constructor.
2406 2011-12-01 Ben Konrath <ben@bagu.org>
2408 Use 'visibility: hidden' in Utils.getWidgetHeight().
2410 This is better choice because hidden elements are invisible, don't
2411 respond to events and are not part of the tab order. They will,
2412 however, take up space which is required to be able to calculate the
2413 height of the widget.
2415 * src/main/java/org/glom/web/client/Utils.java:
2417 2011-12-01 Ben Konrath <ben@bagu.org>
2419 Use Utils.getWidgetHeight() in FlowTable.
2421 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2423 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2425 2011-12-01 Ben Konrath <ben@bagu.org>
2427 Put the details css class name on the correct table column.
2429 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2431 2011-11-30 Ben Konrath <ben@bagu.org>
2433 Update for java-libglom API change.
2435 The getters and setters on FieldFormatting and NumericFormat were
2436 changed to remove the 'M'.
2438 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2440 2011-11-29 Ben Konrath <ben@bagu.org>
2442 Only allow RelatedListTables in Portals.
2444 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2446 2011-11-29 Ben Konrath <ben@bagu.org>
2448 Only create a contents panel for Portals when title is being set.
2450 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2452 2011-11-29 Ben Konrath <ben@bagu.org>
2454 Set TabLayoutPanel height based on calculated height its widgets.
2456 This is a potential fix for this bug:
2458 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2460 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2462 2011-11-29 Ben Konrath <ben@bagu.org>
2464 Align details field labels and data with the Open buttons.
2466 * src/main/webapp/style.css:
2468 2011-11-29 Ben Konrath <ben@bagu.org>
2470 Remove unnecessary <div> in the Notebook widget.
2472 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2473 method to get container FlowPanel (<div>).
2474 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2475 initWidget() method directly on the TabLayoutPanel widget instead of
2476 Group's container widget.
2478 2011-11-29 Ben Konrath <ben@bagu.org>
2480 Don't add group titles for Portals in Notebooks.
2482 This reverts the previous patch and fixes a bug I introduced with
2483 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2485 * src/main/java/org/glom/web/client/ui/details/Group.java:
2486 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2488 2011-11-28 Ben Konrath <ben@bagu.org>
2490 Remove unused boolean argument in Portal constructor.
2492 Just a code cleanup.
2494 * src/main/java/org/glom/web/client/ui/details/Group.java:
2495 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2497 2011-11-28 Ben Konrath <ben@bagu.org>
2499 Remove hack for glom 1.18 style glom files.
2501 * src/main/java/org/glom/web/client/ui/details/Group.java:
2502 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2503 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2505 2011-11-28 Ben Konrath <ben@bagu.org>
2507 Use Gda Value version of primary key to log result too large error.
2509 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2511 2011-11-28 Ben Konrath <ben@bagu.org>
2513 Don't use TypedDataItem.getText() for Unknown types from the URL.
2515 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2516 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2517 instead of getText().
2518 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2519 String field and getUnknown() method.
2521 2011-11-28 Ben Konrath <ben@bagu.org>
2523 Log an error message when the java-libglom .so is not present.
2525 The error message was being set in the exception but not logged.
2527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2529 2011-11-28 Ben Konrath <ben@bagu.org>
2531 Ignore LayoutItem_CalendarPortals.
2533 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2534 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2536 2011-11-28 Ben Konrath <ben@bagu.org>
2538 Extract method for creating the LayoutItemPortal DTO.
2540 Just breaking the code up into smaller chunks.
2542 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2544 2011-11-28 Ben Konrath <ben@bagu.org>
2548 This should have been added with the refactor. Oops!
2550 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2552 2011-11-28 Ben Konrath <ben@bagu.org>
2554 Create primary key value from URL string using type from Glom document.
2556 See this bug, comments 19 - 25:
2558 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2560 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2561 create a TypeDataItem for the primary key here when loading from a
2562 URL. Show the same string for the primary key value as was received
2563 from the URL string (when loading from a URL).
2564 * src/main/java/org/glom/web/server/Utils.java: Update method for
2565 creating the Gda Value from the TypeDataItem to properly deal with
2566 creating a Gda Value based on the Glom document type for the primary
2567 key value string when loading from a URL.
2568 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2569 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2570 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2571 Update for changed method name.
2573 2011-11-27 Ben Konrath <ben@bagu.org>
2575 Rename PrimaryKeyItem to TypedDataItem.
2577 The name PrimaryKeyItem suggests what the class should be used for.
2578 TypedDataItem is a neutral name that describes the class better.
2580 This is a rename-only refactor.
2582 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2583 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2584 * src/main/java/org/glom/web/client/Utils.java:
2585 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2586 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2587 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2588 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2589 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2590 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2591 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2592 * src/main/java/org/glom/web/server/Utils.java:
2593 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2594 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2595 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2596 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2598 2011-11-25 Ben Konrath <ben@bagu.org>
2600 Improve Gda Value conversion from PrimaryKeyItem.
2602 The value from the PrimaryKeyItem is only used if its type match the
2603 type from the glom document.
2605 * src/main/java/org/glom/web/server/Utils.java:
2607 2011-11-25 Ben Konrath <ben@bagu.org>
2609 Manually check if the java-liblgom .so is visible to the JVM.
2611 It seems that Tomcat has problems when a static initializer throws an
2612 exception. This check is done before the first method call into
2613 java-libglom so that execution doesn't continue if the .so is not
2616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2618 2011-11-25 Ben Konrath <ben@bagu.org>
2620 Improve browser configuration error messages.
2624 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2626 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2627 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2628 getConfigurationErrorMessage() method.
2629 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2630 Get and display a specific configuration error message when no Glom
2631 documents are found.
2632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2633 Implement getConfigurationErrorMessage() method. Surround configuration
2634 code in the init() method with a try/catch block. This allows the
2635 errors to be caught while keeping the servlet available to retrieve the
2636 configuration error message.
2638 2011-11-25 Ben Konrath <ben@bagu.org>
2640 Don't use Strings to hold primary key values.
2642 The primary key values are now held in a new data object
2643 (PrimaryKeyItem) that holds type information and the primary key value
2644 using the correct type.
2646 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2647 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2648 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2649 PrimaryKeyItem instead of String to hold the primary key value.
2650 * src/main/java/org/glom/web/client/Utils.java: Remove
2651 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2652 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2653 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2654 PrimaryKeyItem instead of String to hold the primary key value. Load
2655 document selection page when the documentID has not been set correctly.
2656 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2657 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2659 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2660 Return empty string for URL instead of "null".
2661 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2662 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2663 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2664 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2665 PrimaryKeyItem instead of String to hold primary key values.
2666 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2667 PrimaryKeyValue to a Gda Value.
2668 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2669 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2670 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2671 Replace temporary database access code that uses the PrimaryKeyValue to
2672 Gda Value conversion.
2673 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2674 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2675 PrimaryKeyItem instead of String.
2676 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2677 hold primary key values.
2679 2011-11-24 Ben Konrath <ben@bagu.org>
2681 Use newly added java-libglom API to create queries.
2683 This isn't finished. I still need to stop using Strings for primary key
2684 values in the client code.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2687 libglom to use fake connections so that retrieving the query string will
2689 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2690 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2691 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2692 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2693 Use the newly added libglom sql methods and classes to create the
2694 query. Add temporary hack to convert primary value strings to Gda
2697 2011-11-23 Ben Konrath <ben@bagu.org>
2699 Don't explicitly set the height of Portals.
2701 See comments 6 - 10 of this bug for details:
2703 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2705 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2707 2011-11-23 Ben Konrath <ben@bagu.org>
2709 Use an HTML table instead of CSS for the FlowTable layout.
2711 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2712 GWT's FlexTable to implement the FlowTable.
2713 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2715 2011-11-18 Ben Konrath <ben@bagu.org>
2717 Add boolean example to HTML table mockup.
2719 * mockups/details-view-html-tables-text-entries.html:
2721 2011-11-17 Ben Konrath <ben@bagu.org>
2723 Ensure the pager buttons are always visible for related lists.
2725 To accomplish this, I've turned off text wrapping in the list view and
2726 related list tables for both the header and data text. The related list
2727 table now has a fixed layout so the it doesn't overflow its container.
2728 This is required to ensure that the cell text is clipped when it
2729 overflows the cell and an ellipsis is added to the right side of the
2730 cell when text is clipped.
2732 A fixed table layout for the related list table in the details view
2733 seems what we want for the details view anyway, so the side-effect is
2736 The ellipsis will only be displayed in Firefox >= 7.
2740 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2742 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2743 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2744 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2746 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2747 Set the 'table-layout: fixed' CSS property to the related list table.
2748 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2749 'white-space: nowrap;' CSS property on both the list view and the
2750 related list tables.
2752 2011-11-16 Ben Konrath <ben@bagu.org>
2754 Rework the fix for empty notebook tab labels.
2756 Setting the empty group titles with its name caused problems for the
2757 details layout. Instead of using libglom's
2758 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2759 to the client when the title is empty. This allows the Notebook to use
2760 the name when the title is empty without affecting anything else.
2762 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2763 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2765 2011-11-16 Ben Konrath <ben@bagu.org>
2767 Set group titles with name when title is empty.
2769 This fixes a problem with an empty notebook tab label in the Lesson
2770 Planner document. The forth tab in the notebook should be "Internet":
2772 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2774 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2775 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2778 2011-11-16 Ben Konrath <ben@bagu.org>
2780 Remove whitespace from the configured username properties.
2782 This assumes that usernames won't have whitespace at the beginning
2783 or end. But I think this is a reasonable assumption.
2785 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2786 String.trim() to remove the whitespace from the username properties.
2788 2011-11-15 Ben Konrath <ben@bagu.org>
2790 Add details view mockup with HTML tables and text entries.
2792 This is from the attachment on this bug:
2794 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2796 * mockups/details-view-html-tables-text-entries.html:
2798 2011-11-15 Ben Konrath <ben@bagu.org>
2800 Add space between the columns of the flow table.
2804 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2806 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2807 space between columns in the flow table.
2809 2011-11-15 Ben Konrath <ben@bagu.org>
2811 Add backup files to the .gitignore.
2813 * .gitignore: Ignore files that end with ~.
2815 2011-11-09 Ben Konrath <ben@bagu.org>
2817 Use latest release of gwt-log.
2819 Gwt-log releases are now being submitted to the maven central
2820 repository so manual installation of the jar is no longer required.
2822 * pom.xml: Update version and groupId of gwt-log dependency.
2824 2011-10-31 Ben Konrath <ben@bagu.org>
2826 Don't use GWT numeric formatting to override the glom currency formatting.
2828 Currencies are now displayed like they are in Glom. See this bug:
2830 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2832 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2834 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2835 currency code to constructor and set it when the cell is rendered.
2836 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2837 currency code to the constructor of the NumericCell.
2839 2011-10-27 Ben Konrath <ben@bagu.org>
2841 Require the latest release of java-libglom (1.17.4).
2845 2011-10-26 Ben Konrath <ben@bagu.org>
2847 Add style to Notebook that matches current theme.
2849 It's not the best style in the world but it's better than the default.
2851 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2852 padding at the bottom of the child widgets.
2853 * src/main/webapp/style.css: Add style for the Notebook.
2855 2011-10-26 Ben Konrath <ben@bagu.org>
2857 Move servlet initialization code to overridden init method.
2859 This is half of the solution to getting proper error messages
2860 displayed when configuration errors occur. Here's the relevant bug:
2862 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2864 The rest of the solution involves surrounding the init method with a
2865 try/catch block and setting a global variable with the error /
2866 exception. A new async method should be created to retrieve and display
2867 the error message / exception.
2869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2870 code from constructor to init method adding exceptions as needed.
2872 2011-10-26 Ben Konrath <ben@bagu.org>
2874 Add script to monitor and restart tomcat if required.
2876 * utils/check-and-recover-tomcat.py: New file.
2878 2011-10-26 Ben Konrath <ben@bagu.org>
2880 Display the correct number of data items in the pager.
2884 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2886 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2887 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2888 The implementation is the same for both tables: Keep track of the
2889 number of non-empty rows and fire and RowCountChangeEvent after the data has
2891 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2892 custom Pager class that subclasses SimplePager to handle displaying
2893 the correct number when empty rows have been added.
2895 2011-10-26 Ben Konrath <ben@bagu.org>
2897 Correct error in previous commit.
2899 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2900 eventBus parameter from listView.setCellTable().
2902 2011-10-26 Ben Konrath <ben@bagu.org>
2904 Fix error in TODO comment.
2906 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2908 2011-10-24 Ben Konrath <ben@bagu.org>
2910 Create Notebook widgets to the details view.
2912 This isn't finished just yet - I still need to create a reasonable
2913 style to match the current theme.
2915 * src/main/java/org/glom/web/client/Utils.java: Add method for
2916 calculating the height of a widget. This is used in the Notebook class.
2917 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2918 new constructor method in Group.
2919 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2920 method for creating child widget that can be used by subclasses
2921 like Notebook. New constructor that allows disabling the group
2922 titles - Notebooks don't set a group title for their child groups.
2923 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2924 to make Notebooks using GWT's TabLayoutPanel.
2925 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2926 constructor that allows disabling the group titles.
2927 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2928 LayoutItemNotebook DTO.
2929 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2930 DTO for Notebooks. It's just an empty class for now but we might need
2931 it to transfer some specific information in the future.
2933 2011-10-21 Ben Konrath <ben@bagu.org>
2935 Add navigation buttons to related list tables.
2937 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2938 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2940 method getSuitableRecordToViewDetails() for getting the table name
2941 and primary key value for related list navigation buttons.
2942 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2943 private cell renderer class to get the navigation information for
2944 related list tables from the server. Extract the navigation
2945 processing code from the details cell navigation and use it for the
2946 related list navigation as well.
2947 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2948 cell renderer class for the details open buttons. This was needed
2949 because the related list navigation buttons and the list view
2950 navigation buttons need to react differently when clicked.
2951 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2952 the onEnterKeyDown() method because it's now overriden in the
2953 subclasses that are specific to the related list tables and the list
2955 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2956 the vertical size a little because the buttons add a bit of vertical
2957 space to table. This is not a perfect solution because the vertical
2958 size of with table fewer than 5 rows will be a little smaller.
2959 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2960 changes in how navigation buttons are handled.
2961 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2962 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2963 database access object.
2964 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2965 to find the portal for a given relationship name from
2966 RelatedListDBAccess. Add method to find a primary key field for a
2968 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2969 Move code to find the portal for a given relationship name to
2971 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2972 New file: database access object for getting the related list
2973 navigation information (the table name and the primary key value).
2974 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2975 DTO for transferring a table name to navigate to and a primary key
2977 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2978 boolean and getter/setter to specifies if the related list should add
2981 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2983 Use the master branch of java-libglom
2985 * pom.xml: Depend on java-libglom 1.19 instead.
2987 This is the master branch. See also the libglom-1-18 branch.
2989 2011-10-11 Ben Konrath <ben@bagu.org>
2991 Enable the open navigation button when the data has been set.
2993 This avoids having active buttons that don't do anything when the data
2996 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2998 2011-10-11 Ben Konrath <ben@bagu.org>
3000 Use IsWidget interface for FlowTableItem.
3002 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3003 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3005 2011-10-11 Ben Konrath <ben@bagu.org>
3007 Remove GWT styling from open button in details view.
3009 There are still some issues with how the details cell is arranged but
3010 this should be made to match Glom 1.20. I'm going to leave fixing this
3011 until I have Glom 1.20 up and running.
3013 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3014 style name on open button.
3015 * src/main/webapp/style.css: Move and edit details-navigation class.
3016 Re-arrange some classes to make them appear in the same order as the
3019 2011-10-07 Ben Konrath <ben@bagu.org>
3021 Update to GWT 2.4.0.
3023 * .gitignore: Ignore new cache directory.
3024 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3025 * pom.xml: Change GWT and maven plugin to 2.4.0.
3026 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3028 * src/main/java/org/glom/web/client/ClientFactory.java:
3029 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3030 * src/main/java/org/glom/web/client/OnlineGlom.java:
3031 Update source for API changes.
3032 * utils/build-onlineglom-war.sh: Remove cache directory before the
3035 2011-10-07 Ben Konrath <ben@bagu.org>
3037 Add navigation buttons in the details view.
3039 This isn't finished but I thought I'd commit what I have as it's a
3040 pretty good start. I still need to:
3042 1. Change the style so that it fits better into the current theme
3043 2. Adjust the details cell to expand as much as possible.
3045 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3046 click handlers to navigation buttons in the DetailsCells. Create a
3047 refreshData() method to get just the data from the server without the
3049 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3050 Update the tableSelector and browser title when the table name
3051 changes without using the tableSelector.
3052 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3053 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3054 getDetailsCells() to getCells(). Update variable names.
3055 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3056 method to set click handler on navigation button. Rename a few
3057 variables. Add navigation buttons where needed.
3058 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3059 variables and methods.
3060 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3061 navigation boolean and navigation table as required in the
3062 LayoutItemField DTO.
3063 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3064 variables for navigation along with getter/setter methods.
3066 2011-10-07 Ben Konrath <ben@bagu.org>
3068 Rename Field to DetailsCell.
3070 This is a refactor-only commit. No functionality has been added or
3073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3074 Update variable and method names.
3075 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3076 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3077 variable and method names.
3078 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3080 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3081 variable and method names.
3083 2011-10-07 Ben Konrath <ben@bagu.org>
3085 Create separate methods for layout and data the details view.
3087 This is a refactor-only commit. No functionality has been added or
3090 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3091 private methods: setData(), createLayout().
3093 2011-10-07 Ben Konrath <ben@bagu.org>
3095 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3097 This is part of a change to get navigation buttons in the details view
3098 but it should have been done this way from the start.
3100 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3101 for method name change in TableSelectionView.
3102 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3103 Create TableChangeEvent and set the browser title using the
3104 TableSelectionView API.
3105 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3106 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3107 Change getSelectedTable() to getSelectedTableName(). Add
3108 getSelectedTableTitle().
3110 2011-10-07 Ben Konrath <ben@bagu.org>
3112 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3114 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3116 2011-10-07 Ben Konrath <ben@bagu.org>
3118 Update TableChangeEvent to use newTableName naming convention.
3120 This makes the class more consistent with GWT naming conventions.
3122 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3123 Update for method name change in TableChangeEvent.
3124 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3125 for method name change in TableChangeEvent.
3126 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3127 newTableName variable and getter method. Make toDebugString()
3130 2011-09-30 Ben Konrath <ben@bagu.org>
3132 Disable the pager in the list tables when the data row count is less than the minimum.
3134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3135 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3137 2011-09-30 Ben Konrath <ben@bagu.org>
3139 Add empty rows to the end of related list and list view tables.
3141 I also extracted the cell rendering classes from the ListTable because
3142 the code was becoming a little crazy with all the anonymous inner
3143 classes. My plan is to use these cell rendering classes in the details
3144 view as well so this refactor will be needed for that change.
3146 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3147 set the row count in related list tables if the data has more rows
3148 than the minimum number of rows visible.
3149 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3150 row count in list view tables if the data has more rows than the
3151 minimum number of rows visible.
3152 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3153 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3155 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3156 for rendering TYPE_NUMERIC cells. The code was extracted from the
3158 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3159 class for rendering cells with buttons in list views. The code was
3160 extracted from the ListTable class.
3161 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3162 for rendering TYPE_TEXT cells. The code was extracted from the
3164 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3165 Add empty rows to the end of the data if required. Implement
3166 ListTable.getMinNumVisibleRows().
3167 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3168 cell renderer code to public classes. Return null in
3169 Column.getValue() for empty rows. Add new abstract method:
3170 getMinNumVisibleRows(). Move code to set the row count of the list view
3171 table to ListViewImpl.
3172 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3173 empty rows to the end of the data if required. Implement
3174 ListTable.getMinNumVisibleRows().
3177 2011-09-27 Ben Konrath <ben@bagu.org>
3179 Use GWT.log for client-side debugging statements.
3181 These are optimized out when deployed so I should have used this method
3182 in the first place. These statements will eventually be replaced with some sort
3183 of notification in the browser.
3185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3186 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3187 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3188 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3189 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3191 2011-09-27 Ben Konrath <ben@bagu.org>
3193 Put tableselector on the right, back to list link on right.
3195 The idea is that the table selector is acting like a label for the
3196 currently displayed table so it should be placed below the document title. This
3197 puts the table title in a similar position to where it is in Glom.
3199 * mockups/details-contacts.html:
3200 * mockups/details-projects.html:
3201 * mockups/listview-contacts.html:
3202 * mockups/listview-projects.html:
3203 * mockups/style.css:
3204 Update mockups to match how the interfaces currently look.
3205 * src/main/webapp/style.css: Swap positions of backlink with the table
3206 selector. Add some space on the left side of the table selector to
3207 line things up with the document title.
3209 2011-09-27 Ben Konrath <ben@bagu.org>
3211 Add field colouring to details view.
3213 This change re-works how field colouring works. The colour formatting
3214 information is now set to the client with the layout information instead of
3215 with the data. This eliminates the need to send the same colour strings for
3216 data in list view column when colour information is set.
3218 In order to set an alternate colour for negative numeric values, the
3219 number is now sent to client and formatted with the GWT NumberFormat class.
3221 This change also fixes:
3223 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3225 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3226 internationalization framework which is needed for client side numeric
3228 * src/main/java/org/glom/web/client/Utils.java: New file for some
3229 client static utility methods.
3230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3231 the DataItem object to the Field class. Use a utility method to
3232 create the foreignKeyValue string.
3233 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3234 alignment and text colours in the constructor. Add setData(DataItem)
3235 method. Remove setText(String) method.
3236 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3237 colour information to GlomTextCell. Create and use GlomNumberCell for
3238 rendering numbers. Use utility method to get the string for the
3239 primary key of the key provider. Re-work how the horizontal alignment
3241 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3242 formatting to layout information. Methods for converting the libglom
3243 formatting information were moved from DBAccess.
3244 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3245 numeric formatting (it's now done on the client side). Don't set text
3246 colours in DataItem. Move libglom formatting conversion methods to
3248 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3249 getters/setters for text colour information.
3250 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3251 for transferring the libglom NumericFormat information to the client.
3252 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3253 and getters/setters for: GlomNumericFormat, background colour and
3254 foreground colour strings.
3256 2011-09-26 Ben Konrath <ben@bagu.org>
3258 Simplify code that iterates through the LayoutGroup.
3260 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3262 2011-09-26 Ben Konrath <ben@bagu.org>
3264 Accept Eclipse formatting for OnlineGlomServiceAsync.