1 2012-05-11 Murray Cumming <murrayc@murrayc.com>
3 Make navigation work again.
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 Add getLayoutItemFieldShouldHaveNavigation().
7 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
8 Replace get/setAddNavigation() with the partly-existing
9 get/setNavigationTableName(), with an empty string being no navigation,
10 because this is simpler. Use the new
11 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
13 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
14 Add updateFieldsExtras() and call setNavigationTableName in it.
15 getDetailsLayoutGroup(),
16 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
17 createLayout(): Adapted.
18 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
21 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
22 Replace get/setAddNavigation() with get/setNavigation(), returning a
23 TableToViewDetails class with both the table name and UsesRelationship,
24 because both are need. The previous code used java-libglom's output
25 variable (strangely, via sharedptr) to return both, but we cannot really
27 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
28 getNavigationRecord(): Adapt. However, we cannot actually use the cache
29 here because it somehow gets set to null during deepCopy(). I must test this.
30 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
31 testGetSuitableTableToViewDetails(): Adapted.
33 TODO: Find out why deepClone() is not quite working.
35 2012-05-11 Murray Cumming <murrayc@murrayc.com>
37 DBAccess: Simplify the retrievel of full field details.
39 * src/main/java/org/glom/web/server/database/DBAccess.java
40 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
41 because the Document loading should have done this.
43 2012-05-11 Murray Cumming <murrayc@murrayc.com>
45 Document: Correct loading of doubly-related layout fields.
47 * src/main/java/org/glom/web/server/libglom/Document.java:
48 loadUsesRelationship(): Actually set the related relationship, instead
49 of only setting it if it's not found.
51 2012-05-07 Murray Cumming <murrayc@murrayc.com>
53 ConfiguredDocument: Restore correct addition of hidden primary key items.
55 * src/main/java/org/glom/web/client/ui/list/ListTable.java
56 (ListTable.createCellTable): Uncomment out the check for the hidden
58 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
59 add primary key items for top-level lists and portals, as before,
60 instead of adding them to each group.
61 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
62 Actually implement the extra methods such as setHiddenPrimaryKey() and
63 comment that these are used only for top-level list groups and in portals.
64 This strangeness suggests even more that this should not be squeezed
65 into the LayoutGroup class.
67 2012-05-07 Murray Cumming <murrayc@murrayc.com>
69 Fix Formatting loading.
71 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
72 getFormattingUsed(): Remove the duplicate Formatting member variable
73 in favour of the one from the base class.
74 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
75 Initialize a new Formatting instead of using null by default, so we
76 have some defaults, instead of having to initialize one later just to
77 get the same defaults. This also makes loading of formatting from the
78 document work, because that expected a non-null.
80 2012-05-07 Murray Cumming <murrayc@murrayc.com>
82 RelatedListTable: Make sure that the tableName is set.
84 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
85 Constructor: Take the tableName so it is available later. Otherwise,
86 the server assumes that we mean the default table and cannot find the
88 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
89 setData(): Pass the tableName to the RelatedListTable constructor.
91 2012-05-07 Murray Cumming <murrayc@murrayc.com>
95 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
96 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
97 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
99 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
101 * src/main/java/org/glom/web/server/database/DBAccess.java:
102 convertResultSetToDTO(), getPortal():
103 * src/main/java/org/glom/web/server/database/ListDBAccess.java
105 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
106 Add checks for null objects and out of range access, with log messages to
107 give hints so we can fix these properly.
109 2012-05-07 Murray Cumming <murrayc@murrayc.com>
111 Portals: some corrections.
113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
115 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
116 constructor: Use getRelationshipNameUsed() instead of getName(), because
117 that is what is meant.
118 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
119 getFromField(): Fix a typo, to get the field name, not the table name.
120 * src/main/java/org/glom/web/server/database/DBAccess.java:
121 getPortal(): Fix a typo that stopped this from working.
123 2012-05-07 Murray Cumming <murrayc@murrayc.com>
125 LayoutItemPortal: Also override getTitleOriginal().
127 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
128 This lets the base getTitle() with no parameters work.
129 TODO: Test this properly.
131 2012-05-06 Murray Cumming <murrayc@murrayc.com>
133 LayoutItemPortal: getTitle*(): Use the relationship title.
135 2012-05-06 Murray Cumming <murrayc@murrayc.com>
137 LayoutItemField: Fix loading of custom titles.
139 * src/main/java/org/glom/web/server/libglom/Document.java
140 loadDataLayoutItemField(): The title, if any, instead of the field
141 title, is stored in a title_custom node. Load it from there.
142 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
144 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
145 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
146 getTitle*() overrides.
147 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
150 2012-05-06 Murray Cumming <murrayc@murrayc.com>
152 LayoutItemField: Fall back to field titles, so some are really shown.
154 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
155 Override getTitleOriginal() and getTitle(), as in java-libglom.
156 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
159 2012-05-06 Murray Cumming <murrayc@murrayc.com>
161 Correct use of setExpectedResultSize().
163 * src/main/java/org/glom/web/server/ConfiguredDocument.java
164 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
165 Use setExpectedResultSize only on top-level groups (for instance, the
166 list layout) or on child portals (in details views).
167 Use the correct table name for portals to avoid SQL errors.
168 Update the expected counts when returning cached layouts.
170 2012-05-06 Murray Cumming <murrayc@murrayc.com>
172 Document: Interpret no group column count as 1.
174 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
175 default, though we now check for this in the UI code anyway.
177 2012-05-06 Murray Cumming <murrayc@murrayc.com>
181 2012-05-06 Murray Cumming <murrayc@murrayc.com>
183 Translatable: Use Hashmap instead of Treemap because GWT supports it.
185 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
186 The use of Treemap lead to this error from async methods, with no
188 "The response could not be deserialized"
190 2012-05-06 Murray Cumming <murrayc@murrayc.com>
192 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
194 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
195 when using the Google -> GWT Compile, or
196 g toolbar button -> GWT Compile Project... feature in Eclipse.
198 2012-05-06 Murray Cumming <murrayc@murrayc.com>
200 ListTable.addColumn(): Protect against a null Formatting.
202 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
203 Create a default Formatting if it is null, because that is the simplest
206 2012-05-06 Murray Cumming <murrayc@murrayc.com>
208 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
210 * src/main/java/org/glom/web/server/ConfiguredDocument.java
211 updateLayoutGroup(): Check that the field is not null.
213 2012-05-06 Murray Cumming <murrayc@murrayc.com>
215 ListViewImpl: Protected against a bad cast error.
217 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
218 onEnterKeyDown(): Do not cast without an instanceof check.
220 2012-05-06 Murray Cumming <murrayc@murrayc.com>
222 ListTable: Protect against an out of range error.
224 * src/main/java/org/glom/web/client/ui/list/ListTable.java
225 createCellTable(): This is unlikely, but can happen while debugging.
227 2012-05-06 Murray Cumming <murrayc@murrayc.com>
229 AsyncMessage onFailure() callbacks: Log the exception message.
231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
232 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
233 * src/main/java/org/glom/web/client/activity/ListActivity.java:
234 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
235 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
236 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
237 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
238 These are useful clues when something is wrong.
240 2012-05-06 Murray Cumming <murrayc@murrayc.com>
242 ConfiguredDocument: Avoid a null dereference.
244 * src/main/java/org/glom/web/server/ConfiguredDocument.java
245 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
246 details maps are created.
248 2012-05-06 Murray Cumming <murrayc@murrayc.com>
250 Document: Correct the port number parsing.
252 * src/main/java/org/glom/web/server/libglom/Document.java:
253 This lets us actually connect to the database and show the document.
255 2012-05-05 Murray Cumming <murrayc@murrayc.com>
259 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
260 user-interaction, asking us to load a temporary URL in a browser.s
261 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
262 which is apparently necessary for testing the service. See the comment.
263 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
264 Show the exception, if any. This is how I saw the 404 in the HTML in
267 2012-05-05 Murray Cumming <murrayc@murrayc.com>
269 DocumentTest: Move the .glom files into the resources directory.
271 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
272 URI via getResource().
274 2012-05-05 Murray Cumming <murrayc@murrayc.com>
276 Document: Remove the FieldIdentifies inner class.
278 * src/main/java/org/glom/web/server/libglom/Document.java: We only
279 use the Relationship (though the same function in libglom is maybe
280 used in other ways) and so this removes a compiler warning.
282 2012-05-05 Murray Cumming <murrayc@murrayc.com>
284 Document.load() Remove the error code parameter.
286 * src/main/java/org/glom/web/server/libglom/Document.java: load():
287 Remove the parameter. We do not set it yet and it could never have
288 worked as an output parameter (though maybe it did in java-libglom).
289 We could use an exception if we really want the failure reason.
290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
292 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
293 setUp(), testGetSuitableTableToViewDetails(): Adapt.
295 2012-05-05 Murray Cumming <murrayc@murrayc.com>
297 Make some inner classes static.
299 * src/main/java/org/glom/web/server/ConfiguredDocument.java
300 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
301 * src/main/java/org/glom/web/server/ReportGenerator.java
302 * src/main/java/org/glom/web/server/libglom/Document.java
303 Make all inner classes static that can be static.
305 2012-05-05 Murray Cumming <murrayc@murrayc.com>
307 OnlineGlomServiceImpl: Do not load and check for java-libglom.
309 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
310 init(): We do not use java-libglom any more.
312 2012-05-05 Murray Cumming <murrayc@murrayc.com>
314 Remove mentions of java-libglom.
316 * README: Remove mention of java-libglom, because it no longer needed.
317 * utils/build-onlineglom-war.sh:
318 * utils/check-and-recover-tomcat.py:
319 * utils/install-onlineglom-war.sh: Remove these as they are no longer
320 useful. Building is now far easier, with no need for jhbuild.
322 2012-05-05 Murray Cumming <murrayc@murrayc.com>
324 Fix the build (mvn package)
326 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
327 (LayoutGroup): Make the LayoutItemList inner class static and protected.
328 Otherwise the GWT Java->Javascript compilation fails with just this
329 error, during mvn package or when attempting to view in a browser,
330 in the GWT developer mode in Eclipse.
332 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
333 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
334 [INFO] Compiling module org.glom.web.OnlineGlom
335 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
336 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
337 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
338 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
339 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
340 [INFO] [ERROR] Cannot proceed due to previous errors
342 It has taken me 2 days to find out what was causing that. After reducing
343 the code, the compiler eventually showed me the full error message.
345 2012-05-04 Murray Cumming <murrayc@murrayc.com>
347 ConfiguredDocument: Cache the cloned and stripped layouts.
349 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
350 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
351 layout in a map, so we can retrieve it again without rebuilding it.
353 2012-05-04 Murray Cumming <murrayc@murrayc.com>
355 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
357 2012-05-04 Murray Cumming <murrayc@murrayc.com>
359 libglom classes: Implement some auto-generated emthods.
361 2012-05-04 Murray Cumming <murrayc@murrayc.com>
363 Add GwtTestOnlineGlomService.
365 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
366 However, this (and the other GwtTest*) does not seem to run during
369 2012-05-04 Murray Cumming <murrayc@murrayc.com>
371 Remove use of unsupported features from client code.
373 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
374 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
375 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
376 Use our client version of StringUtils instead of the apache commons one.
378 However, the GWT Javascript compliation still fails.
380 2012-04-25 Murray Cumming <murrayc@murrayc.com>
382 Add a Field class and implement some loading of it in Document.
384 2012-04-25 Murray Cumming <murrayc@murrayc.com>
386 Initial Document loading implementation, instead of libglom.
388 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
389 and Translatable classes, and adapt the rest of the code to use them.
390 However, this is still missing Layout and Field classes and loading.
392 2012-04-24 Murray Cumming <murrayc@murrayc.com>
394 Use of jOOQ: Move Field creation into a utility method.
396 * src/main/java/org/glom/web/server/SqlUtils.java:
397 This lets us improve it more easily.
399 2012-04-24 Murray Cumming <murrayc@murrayc.com>
401 Use of jOOQ: Improve the code to COUNT a sub-select.
403 * src/main/java/org/glom/web/server/SqlUtils.java:
404 Move initial query creation into
405 build_sql_select_step_with_where_clause().
406 build_sql_select_count_rows(): Use the jOOQ API instead of
407 concatentating text, because a jOOQ Select*Step is a TableLike,
408 which is what from() takes.
410 2012-04-23 Murray Cumming <murrayc@murrayc.com>
412 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
414 * pom.xml: Depend on jooq.
415 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
416 methods with jOOQ, based on the C++ implementations in libglom,
417 with some changes to the logic required by jooQ.
418 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
420 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
421 * src/main/java/org/glom/web/server/ReportGenerator.java:
422 * src/main/java/org/glom/web/server/SqlUtils.java:
423 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
424 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
425 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
426 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
427 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
428 Adapt. In particular, the SqlUtils methods now need to take a Connection,
429 because jOOQ needs that, though it seems unnecessary.
431 This is not quite finished. Ideally jOOQ would help us to build
432 table_name.field_name names, quoting and escaping them properly.
433 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
435 2012-04-21 Murray Cumming <murrayc@murrayc.com>
437 Move use of Glom.build_sql*() into a new SqlUtils class.
439 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
440 to wrap Glom.build_sql*(). The parameter types are still Glom one,
441 but this will make it easier to start using something other than
442 libglom or SqlBuilder.
444 2012-04-21 Murray Cumming <murrayc@murrayc.com>
446 Update the project URL.
448 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
450 2012-04-21 Murray Cumming <murrayc@murrayc.com>
452 Main layout: Use a FlowTable instead of absolute positioning.
454 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
455 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
456 child panels/widgets must have an absolute position. But that is annoying, so
457 this adds a FlowTable and puts the child panels in there.
459 2012-04-21 Murray Cumming <murrayc@murrayc.com>
461 GwtTestOnlineGlom: Comment out unused code.
463 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
464 Eclipse has started to say that some code is unused.
466 2012-04-21 Murray Cumming <murrayc@murrayc.com>
468 Update to the latest versions of dependencies.
470 * pom.xml: Update version numbers of dependencies to the latest
472 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
474 * src/main/java/org/glom/web/server/ReportGenerator.java:
475 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
476 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
477 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
479 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
480 Modify the imports where necessary.
482 2012-04-17 Murray Cumming <murrayc@murrayc.com>
484 Style: Remove overflow:hidden from searchbox
486 * src/main/webapp/style.css: Because this pushes the Back To Link
487 label/link on to the next row, which is then hidden due to the
488 hard-coded (in ems) height.
490 2012-04-20 Murray Cumming <murrayc@murrayc.com>
492 Remove some duplicate code.
494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
495 getDocumentInfo(): This must have been duplicated during the merge from the
500 2012-04-19 Murray Cumming <murrayc@murrayc.com>
502 Reports: Localize the waiting for report message.
504 * src/main/java/org/glom/web/client/activity/ReportActivity.java
505 start(): Get the message from the contants.
506 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
508 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
509 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
510 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
511 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
512 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
513 Update these files with the English text for newer strings for now.
515 2012-04-19 Murray Cumming <murrayc@murrayc.com>
517 Reports: Show a message while waiting for the report.
519 * src/main/java/org/glom/web/client/ui/ReportView.java
520 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
521 Add setWaitingText(), to show a message saying that we are
522 waiting for the report to be ready.
523 * src/main/java/org/glom/web/client/activity/ReportActivity.java
524 start(): Call setWaitingText() before calling the async
527 2012-04-19 Murray Cumming <murrayc@murrayc.com>
529 ReportGenerator: Specify date and time formats.
531 * src/main/java/org/glom/web/server/ReportGenerator.java:
532 createFieldValueElement(): Use the default (and localized)
533 short formats, though we still need a way to show 4-digit
534 years without providing the format for every locale.
535 * src/main/java/org/glom/web/server/database/DBAccess.java:
536 convertResultSetToDTO(): Use the short formats here too.
538 2012-04-18 Murray Cumming <murrayc@murrayc.com>
540 ReportGenerator: Use the correct numeric formatting.
542 * src/main/java/org/glom/web/server/ReportGenerator.java
543 createFieldExpression(), createFieldValueElement(): Take the
544 whole LayoutItem_Field instead of just the field name, so
545 we have access to the formatting.
546 createFieldValueElement(): Use JRTextField.setPattern() to
547 specify the numeric formatting, with the help of a
548 regular DecimalFormat.
550 2012-04-18 Murray Cumming <murrayc@murrayc.com>
552 ReportGenerator: Avoid showing null for group by titles.
554 * src/main/java/org/glom/web/server/ReportGenerator.java
555 generateReport(): Use setBlankWhenNull() on the field title
556 style too, because this is used for values in group by
559 2012-04-18 Murray Cumming <murrayc@murrayc.com>
561 ReportGenerator: Add a colon to titles in vertical groups.
563 * src/main/java/org/glom/web/server/ReportGenerator.java
564 addFieldToDetailBandVertical(): Pass true for the withColon
567 2012-04-18 Murray Cumming <murrayc@murrayc.com>
569 ReportGenerator: Simplify the code by using Position more.
571 2012-04-18 Murray Cumming <murrayc@murrayc.com>
573 Reports: Support vertical groups, roughly.
575 * src/main/java/org/glom/web/server/ReportGenerator.java:
576 addToReport(): Rename to addGroupToReport() and, if necessary,
577 call the new addVerticalGroupToReport() method.
578 createFieldValueElement(): Let the caller specify the Y position
581 2012-04-17 Murray Cumming <murrayc@murrayc.com>
583 Reports: Allow a second report to be shown.
585 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
586 clear(): Do not remove the HTML widget, which broke the whole layout.
588 2012-04-17 Murray Cumming <murrayc@murrayc.com>
590 Locales drop-down: Show that we use English by default.
592 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
593 fillView(): When we use English, just because that is the default, when
594 no locale is specified, show that in the Locales drop-down instead of
595 just showing the first item.
597 2012-04-17 Murray Cumming <murrayc@murrayc.com>
599 Unselect the Report/Locale/Table combo item when appropriate.
601 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
602 setPlace(): clear reportName if this is not a ReportPlace.
603 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
604 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
605 When the provided name is empty, unselect all items, so that none are
606 indicated. This uses a for loop because I cannot find a single method
609 2012-04-17 Murray Cumming <murrayc@murrayc.com>
611 Report: Give the user a way to get back to the list.
613 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
614 start(), setPlace(): Show the Back To List link on reports, and also
615 interpret selecting the empty report item as back to list.
617 2012-04-13 Murray Cumming <murrayc@murrayc.com>
619 Really show the selected Report name.
621 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
622 setPlace(): Store the reportName here, if it is that kind of Place.
623 fillView(): Set the selected Report after filling the list of reports.
624 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
625 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
626 null Strings, though we need some way to unselect all ListBox items
629 2012-04-13 Murray Cumming <murrayc@murrayc.com>
631 ReportGenerator: Try to avoid some problems.
633 * src/main/java/org/glom/web/server/ReportGenerator.java
634 addField(): Try to avoid duplicates, and avoid using a null
637 2012-04-13 Murray Cumming <murrayc@murrayc.com>
639 Reports: Use quickFind.
641 * src/main/java/org/glom/web/client/OnlineGlomService.java;
642 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
644 getReportHTML(): Add a quickFind parameter.
645 * src/main/java/org/glom/web/client/activity/ReportActivity.java
646 start(): Pass the quickFind parameter.
647 * src/main/java/org/glom/web/server/ReportGenerator.java
648 generateReport(): Take a quickFind parameter.
650 2012-04-13 Murray Cumming <murrayc@murrayc.com>
652 ReportPlace: Actually use the report name.
654 * src/main/java/org/glom/web/client/place/ReportPlace.java
655 getPlace(): Do not assign the report name to the quickfind.
657 2012-04-13 Murray Cumming <murrayc@murrayc.com>
659 Show java.library.path when complaining.
661 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
662 init(): When telling us to check java.library.path, show the
665 2012-03-06 Murray Cumming <murrayc@murrayc.com>
667 ReportGenerator: Do not show nulls.
669 2012-03-06 Murray Cumming <murrayc@murrayc.com>
671 ReportGenerator: Make the title font larger.
673 2012-03-06 Murray Cumming <murrayc@murrayc.com>
675 ReportGenerator: Put field titles inside groups, if there are groups.
677 2012-03-06 Murray Cumming <murrayc@murrayc.com>
679 ReportGenerator: Take the Report itself instead of the name and group.
681 * src/main/java/org/glom/web/server/ConfiguredDocument.java
682 Remove getReportLayoutGroup().
683 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
684 getReportHTML(): Pass the report instead
685 of its name and layout group.
686 * src/main/java/org/glom/web/server/ReportGenerator.java
687 generateReport(): Use the report object to use the title
690 2012-03-06 Murray Cumming <murrayc@murrayc.com>
692 ReportGenerator: Remove designBand parameters.
694 * src/main/java/org/glom/web/server/ReportGenerator.java:
695 Make designBand a class member instead of passing it to all
698 2012-03-06 Murray Cumming <murrayc@murrayc.com>
700 ReportGenerator: Add lines, a bit like in the desktop version.
702 * src/main/java/org/glom/web/server/ReportGenerator.java
703 addToReport(): Use JRDesignLine.
705 2012-03-06 Murray Cumming <murrayc@murrayc.com>
707 ReportGenerator: Correct the title positions and use some bold style.
709 * src/main/java/org/glom/web/server/ReportGenerator.java:
710 Break the code up into reusable functions, correct the placement of
711 titles, and use normal/bold styles as in the reports in the desktop
714 2012-03-06 Murray Cumming <murrayc@murrayc.com>
716 ReportGenerator: Add a header band to show the field titles.
718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
719 getReportHTML(): Pass the localeId to the ReportGenerator
721 * src/main/java/org/glom/web/server/ReportGenerator.java
722 constructor: Take the localeID so we can get translated field
724 generateReport(), addToReport(), addFieldToBand(): Add field
725 titles in a column header band.
727 2012-03-05 Murray Cumming <murrayc@murrayc.com>
729 Reports drop-down list: Some improvement.
731 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
732 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
733 Adedd setSelectedReport(),
734 setReportList(): Add a blank line so that the user can select the
736 * src/main/java/org/glom/web/client/activity/ReportActivity.java
737 start(): Show the current report by calling setSelectedReport().
738 This does not seem to work yet.
740 2012-03-05 Murray Cumming <murrayc@murrayc.com>
742 DetailsActivity, ListActivity: Move some variables into a base class.
744 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
745 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
746 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
747 the clientFactory, documentID, tableName and authenticationPopup into
748 a base class, to avoid duplication.
750 2012-03-05 Murray Cumming <murrayc@murrayc.com>
752 Translate the Reports label.
754 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
755 Get the "Reports" label string from the constants.
756 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
757 perties: Add Reports to the constants.
759 2012-03-05 Murray Cumming <murrayc@murrayc.com>
761 Reports: Implement grouping.
763 * src/main/java/org/glom/web/server/ReportGenerator.java:
764 Handle LayoutItem_GroupBy items and try to do the right thing
765 with JRDesignGroup. It seems to work.
767 2012-03-04 Murray Cumming <murrayc@murrayc.com>
769 Actually show some data with JasperReports.
771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
772 getReportHTML(): Move most code into a ReportGenerator class.
773 * src/main/java/org/glom/web/server/ReportGenerator.java:
774 Recurse into sub-groups, adding fields to the JasperDesign's details
775 band. Note that we must set an arbitrary width and height, or it just
776 will not show any data.
778 2012-03-04 Murray Cumming <murrayc@murrayc.com>
780 Reports Chooser: Show the titles, not the names.
782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
783 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
784 and the names as the values.
785 * src/main/java/org/glom/web/server/ConfiguredDocument.java
786 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
787 group now that we provide the report name, so it should always
790 2012-02-15 Murray Cumming <murrayc@murrayc.com>
792 Depend on jasperreports.
794 * pom.xml: Add the dependency. My plan is to use this on the
797 2012-01-31 Murray Cumming <murrayc@murrayc.com>
799 Implement navigation to report places.
801 * src/main/java/org/glom/web/client/activity/ReportActivity.java
802 start(): Do not bother to handle all events here.
803 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
804 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
805 Added getSelectedReport().
806 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
807 .java: start(): When handling a change to the reports chooser,
808 call getSelectedReport() and goTo() its ReportPlace.
809 * src/main/java/org/glom/web/client/ui/ReportView.java
810 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
811 Added setReportHTML() which puts the html in a gwt HTML widget.
812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
813 getReportHTML(): Return "TODO" just to show that this works.
815 2012-01-31 Murray Cumming <murrayc@murrayc.com>
817 Make ReportPlace usable.
819 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
821 * src/main/java/org/glom/web/client/place/ReportPlace.java:
822 Correct the @prefix annotation.
824 2012-01-31 Murray Cumming <murrayc@murrayc.com>
826 OnlineGlomService: Return report HTML rather than the LayoutGroup.
828 * src/main/java/org/glom/web/client/OnlineGlomService.java:
829 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
831 Change getReportLayout() to getReportHMTL() because we will not need to
832 parse or render the report layout on the client side.
833 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
834 getReportLayout(): Return the libglom LayoutGroup type because we will
835 not need to convert to a shared type, because this will not be used on
837 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
840 Note that there is still no implementation for this.
843 2012-01-27 Murray Cumming <murrayc@murrayc.com>
845 Add a (empty) Report Place, View, and Activity.
847 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
849 * src/main/java/org/glom/web/client/place/HasTablePlace.java
850 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
851 this into a superclass:
852 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
853 and also use it as the base of this new ReportPlace:
854 * src/main/java/org/glom/web/client/place/ReportPlace.java
856 * src/main/java/org/glom/web/client/ui/ReportView.java
857 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
858 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
859 Add these, containing mostly boiler-plate for now.
861 * src/main/java/org/glom/web/client/OnlineGlomService.java
862 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
863 * src/main/java/org/glom/web/server/ConfiguredDocument.java
864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
865 Add API to get the LayoutGroup for the report.
867 2012-01-23 Murray Cumming <murrayc@murrayc.com>
869 Add and fill a Reports drop-down list box.
871 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
873 * src/main/java/org/glom/web/client/OnlineGlomService.java:
874 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
876 Added getReports(document, table, localeID), calling
877 ConfiguredDocument.getReports().
878 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
879 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
880 Added setReportsList() and a list widget.
881 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
882 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
887 2012-04-12 Murray Cumming <murrayc@murrayc.com>
889 Translations: Add Esperanto.
891 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
892 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
893 properties: Add this translation because someone took the time to make it.
895 2012-03-15 Murray Cumming <murrayc@murrayc.com>
897 Adapt to the java-libglom 1.21.7 API.
899 * src/main/java/org/glom/web/server/ReportGenerator.java:
900 addToReport(): get_group_secondary_fields() is now
901 get_secondary_fields().
904 2012-03-15 Murray Cumming <murrayc@murrayc.com>
906 Use the latest java-libglom version.
908 * pom.xml: Use java-libglom 1.21.7.
910 2012-03-03 Ben Konrath <ben@bagu.org>
912 Display date and time in details view.
914 https://bugzilla.gnome.org/show_bug.cgi?id=671257
916 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
918 2012-03-05 Murray Cumming <murrayc@murrayc.com>
920 Require the latest java-libglom.
922 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
924 2012-03-04 Murray Cumming <murrayc@murrayc.com>
926 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
928 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
929 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
930 an empty quickfind string. I also corrected libglom to create only
931 empty where clauses for empty quickfind strings, but this avoids the
934 2012-02-24 Ben Konrath <ben@bagu.org>
936 Improve the tabs in the Notebook widget.
940 2012-01-30 Murray Cumming <murrayc@murrayc.com>
942 Translations: Try to translate the strings.
944 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
945 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
946 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
947 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
948 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
949 Take the Open translation from GTK+'s .po files.
950 Take the Details translation from Glom's po files.
951 I have added the other strings to Glom so we can get translations that way:
952 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
954 2012-01-27 Murray Cumming <murrayc@murrayc.com>
956 TableSelectionViewImpl: Put the search label and entry in a div.
958 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
959 Put the search widgets in a FlowTable so that the CSS can be used to
960 style them while keeping them together.
961 * src/main/webapp/style.css: Mention the new div.
963 2012-01-27 Murray Cumming <murrayc@murrayc.com>
965 Translate more strings in more locales.
967 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
968 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
969 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
970 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
971 Translate the "Details" and "Open" string too.
973 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
974 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
975 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
976 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
977 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
978 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
979 Add these new locales as placeholders though they currently contain English.
981 2012-01-27 Murray Cumming <murrayc@murrayc.com>
983 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
985 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
986 Check the ConfiguredDocument* for null before using it.
988 2012-01-26 Murray Cumming <murrayc@murrayc.com>
990 Tell Eclipse about the generated java files.
992 * .classpath: This lets it find OnlineGlomConstants.java.
993 It would be nice if Eclipse just used the maven build files.
995 2012-01-26 Murray Cumming <murrayc@murrayc.com>
997 Prevent a crash when no locale is specified in the URL.
999 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1000 Avoid returning a null string, obtained from
1001 Window.Location.getParameter(). This caused a crash when it was
1002 later passed to libglom's API.
1003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1004 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1005 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1006 guard against future null strings.
1008 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1010 Use the ?locale= query param instead of the &lang= token param.
1012 * src/main/java/org/glom/web/client/place/ListPlace.java
1013 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1014 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1015 Remove the lang token key and value.
1017 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1018 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1019 When the user selects a different locale from the chooser, use
1020 Window.Location.assign() to change the URL, which then causes a reload.
1022 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1023 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1024 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1025 * src/main/java/org/glom/web/client/activity/ListActivity.java
1026 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1027 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1028 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1029 * src/main/java/org/glom/web/client/ui/ListView.java:
1030 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1032 Remove localeID member variables and method/constructor parameters, instead
1033 using Utils.getCurrentLocaleID() when we need a localID to pass to
1036 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1038 Internationalize the UI strings.
1040 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1041 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1042 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1043 because it is unused. Messages are apparently strings that can have
1044 parameters, but we do not need that yet, so Contants will be enough for now.
1045 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1046 to say that we support the en and de locales.
1047 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1048 The original English strings.
1049 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1050 Some German translations of the English strings.
1051 The i18n goal then uses the .properties file to generate an
1052 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1053 returns an implementation that returns the translated strings.
1054 The documentation suggests putting these in src/java/*/client/, but it seems
1055 best to put it in src/resources/*/client/.
1056 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1057 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1058 instead of hard-coding them.
1059 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1060 but that does not seem to stop the build, though it confuses Eclipse.
1062 You can see the translated string by adding ?locale=de to the URL, like so:
1063 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1065 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1067 Improve null/empty String checks.
1069 * pom.xml: Add a dependency on commons-lang, to use
1070 org.apache.commons.lang.StringUtils.
1071 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1073 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1074 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1075 Use StringUtils.isEmpty().
1077 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1078 StringUtils class with a static isEmpty() function because we
1079 cannot use org.apache.commons.lang.StringUtils in client-side
1080 GWT code because it (apparently) cannot be compiled to javascript.
1081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1082 * src/main/java/org/glom/web/client/activity/ListActivity.java
1083 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1084 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1085 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1086 * src/main/java/org/glom/web/client/place/ListPlace.java
1087 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1088 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1089 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1090 * src/main/java/org/glom/web/client/ui/details/Group.java
1091 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1092 our StringUtils.isEmpty() function.
1094 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1096 Update to the latest java-libglom API.
1098 * pom.xml: Require java-libglom 1.21.4.
1099 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1100 getDocumentInfo(), getListViewLayoutGroup():
1101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1103 * src/main/java/org/glom/web/server/database/DBAccess.java
1104 getFieldsToShowForSQLQueryAddGroup(),
1105 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1106 with either get_database_title_original() or
1107 get_database_title(localeID).
1109 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1111 ConfiguredDocument: Avoid a null pointer exception.
1113 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1114 Initialize localeID to "" to avoid returning a null String which
1115 causes a crash in java-libglom's swing-generated code.
1117 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1119 Some simple renaming.
1121 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1122 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1123 for localeChooser. This seems more appropriate and is less ambiguous
1124 particularly in the .css file.
1126 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1128 ConfiguredDocument: Rename the localedID private member variable.
1130 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1132 Adapt to the latest java-libglom API from git master.
1134 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1135 libglom now uses only Vector instead of List, which uses add() instead of
1138 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1140 ConfiguredDocument: Rename the localedID private member variable.
1142 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1144 Build a source tarball with mvn assembly:single
1146 * assembly.xml: Add this file.
1147 * pom.xml: Use the maven-assembly-plugin and tell it to use
1148 our assembly.xml file.
1150 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1152 OnlineGlomServiceImpl: Get .glom files recursively.
1154 * pom.xml: Depend on commons-io from org.apache.commons.
1155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1156 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1157 files recursively, and with the easier filter for the extension.
1158 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1159 simplify that code too.
1161 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1163 README: Mention that you must install java-libglom packages separately.
1165 But then it works, because java-libglom is now in the central maven
1168 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1170 locales drop-down: Show the correct selected locale when the URL changes.
1172 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1173 .java: setPlace(): Move some code into fillView().
1175 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1177 locales drop-down: Do not lose the primary key.
1179 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1180 start(): onLocaleChange(): Pass the current primary key value,
1181 instead of an empty value.
1183 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1185 locales drop-down: Do not lose the drop-down selection.
1187 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1188 .java (TableSelectionActivity.fillView): Set the selected locale
1189 after changing the drop-down items (though we do not really need
1190 to change them just because the locale changes.)
1192 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1194 locales drop-down: Change the tables list when this changes.
1196 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1197 .java: TableSelectionActivity.start(): Move the async table titles
1198 retrieval into a private fillView() method and also call this when
1199 the chosen locale changes.
1200 Note that the document title is not actually translatable yet, but
1201 that is a problem that I should fix soon in libglom.
1203 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1205 Improve the placement of the locales drop-down.
1207 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1208 Put the title and locales drop-down in a div (gwt.FlowTable).
1209 * src/main/webapp/style.css: Add magic css properties to make this work.
1210 Also remove the left margin from the title so that it lines up with the
1213 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1215 locales selector: Show human-readable locale titles.
1217 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1218 getDocumentInfo(): Use java.util.Locale to show a real title of
1219 each locale, in the locale's own language.
1221 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1223 Add a language/locale selector drop-down.
1225 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1226 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1227 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1228 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1229 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1230 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1231 Add a ListBox to show the available locales. Add getLocaleSelector(),
1232 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1233 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1234 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1235 java: Add these classes.
1236 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1237 start(): Fill the locales ListBox. Handle its change event, firing a
1239 setPlace(): Show the selected locale as specified by the URL token.
1240 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1241 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1242 Handle LocaleChangeEvent, going to a new *Place with that locale.
1244 The placement of the ListBox is not pretty, and it currently uses the ID
1245 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1249 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1251 Search box: Show the search text from the URL token.
1253 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1254 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1255 Add setQuickFindText().
1256 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1257 .java: setPlace(): Store the queryText if the place is a ListPlace,
1258 and call TableSelectionView.setQuickFindText().
1260 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1262 Allow use of translations via, for instance, &lang=de in the URL.
1264 * pom.xml: Use the unstable java-libglom 1.21 version.
1266 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1267 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1269 init(): Instead of calling TranslatableItem.set_current_locale()
1270 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1271 However, this is only for default locales, which are not needed to
1272 change the locale in the URL.
1273 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1274 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1275 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1276 layout for a particular locale.
1277 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1278 Add get/setDefaultLocaleID().
1279 getDocumentInfo(), getListViewData(), getRelatedListData(),
1280 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1281 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1282 localeID parameter, so we can get the layout for a particular locale.
1284 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1285 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1286 * src/main/java/org/glom/web/client/place/ListPlace.java:
1287 Parse and construct a lang parameter too.
1289 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1290 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1291 passed to subsequent methods and constructors.
1292 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1293 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1294 Store the localeID from the *Place and pass it to other constructors
1295 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1297 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1298 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1299 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1300 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1301 * src/main/java/org/glom/web/client/ui/ListView.java:
1302 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1303 Take localeID parameters and pass them to subsequent constructors and
1304 methods, so that the layout is always retrieved for that locale.
1306 This is rather repetitive.
1308 Note that "" means the original (default) locale of the Glom document,
1309 which is usually English.
1311 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1313 Documents: Remove final keyword to fix startup configuration.
1315 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1316 final keywords on the private member variables because that breaks
1317 the startup, apparently (there are warnings) because it stops them
1318 from being serialized. I added these in the previous commit.
1320 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1322 Documents: Add some final keywords.
1324 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1327 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1329 OnlineGlomServiceImpl: Add to overview comments.
1331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1332 Note that this is where all the document are loaded. They are not
1333 loaded freshly for each page.
1335 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1339 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1340 Add a TextBox for the text of a quick find.
1341 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1343 setBackLink(): Add a String quickFind parameter.
1344 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1345 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1346 to the base interface, because that is how TableSelectionViewImpl is used.
1347 * src/main/webapp/style.css: Add style for the search box and its label.
1349 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1350 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1351 Add these files, based on the existing TableChangeEvent and
1352 TableChangeEventHandlers.
1353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1354 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1355 a ListPlace() that the user should be taken to.
1356 * src/main/java/org/glom/web/client/activity/ListActivity.java
1357 start(): Handle it here too and adapt the TableChangeEvent handler to
1358 pass the extra "" quickFind parameter to ListPlace.
1359 * src/main/java/org/glom/web/client/place/ListPlace.java:
1360 Constructor: Take an extra String quickFind parameter and store it,
1361 returning it from a new getQuickFind() method.
1362 getToken(): Put the quickFind text in the URL token.
1363 getPlace(): Parse the quickFind text from the URL token.
1364 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1365 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1366 ListPlace constructor.
1367 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1368 .java: start(): Add a Change handler for the TableSelectionView's
1369 TextBox (via its base HasChangeHandlers interface), firing the new
1370 QuickFindChangeEvent.
1371 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1372 pass the extra "" quickFind parameter.
1374 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1375 setCellTable(): Add a String quickFind parameter and pass it to
1376 the ListViewTable() constructor.
1377 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1378 setCellTable() in the base interface, because that is how ListViewImpl
1381 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1382 Add a String quickFind member variable.
1383 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1384 Constructor: Add a String quickFind parameter, storing it in the
1385 base ListTable's member variable.
1386 onRangeChanged(): Pass quickFind to the
1387 OnlineGlomServiceAsync.getSortedListViewData() and
1388 OnlineGlomServiceAsync.getListViewData() methods.
1390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1391 getListViewData(), getSortedListViewData(): Add a String quickFind
1392 parameter, passing it to ConfiguredDocument.getListViewData().
1393 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1394 Change getListViewData(), getSortedListViewData() in the base interface,
1395 because that is how OnlineGlomServiceImpl is used, via this:
1396 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1397 Change getListViewData(), getSortedListViewData() here too.
1398 This class can apparently be used to asynchronously call methods on
1399 OnlineGlomService, and GWT seems to implement that after recognizing
1400 just the *Async name convention and the extra AsyncCallback parameters.
1402 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1403 getListViewData(): Add a String quickFind parameter, and pass it to
1404 ListViewDBAccess.getData().
1405 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1406 getListData(): Add a String quickFind parameter and pass it to
1408 getSelectQuery(): Add a String quickFind parameter.
1409 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1410 getSelectQuery(): Add a String quickFind parameter and use it with
1411 Glom.get_find_where_clause_quick() to pass a where_clause to
1412 Glom.build_sql_select_with_where_clause(), to actually filter the
1414 getData(): Add a String quickFind parameter, passing it to getListData().
1415 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1416 va: getData(): Pass an empty string to getListData() for the
1417 quickFind parameter.
1419 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1421 ListTable: Minor change.
1423 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1424 createCellTable(): Make this protected instead of public.
1426 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1428 Many files: Use final for the parameters and use the @override attribute.
1430 2012-01-22 Ben Konrath <ben@bagu.org>
1432 Add anchor links for single line text that starts with http, ftp and www.
1436 2012-01-22 Ben Konrath <ben@bagu.org>
1438 Add ellipsis to single line text in details view.
1442 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1444 Remove all javadoc author tags.
1446 Because they are awkward and meaningless when many people touch
1448 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1450 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1452 Revert the COPYING.LESSER to COPYING rename.
1454 Apparently both should be there if it is LGPL.
1456 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1458 *View: Remove unused imports.
1460 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1461 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1462 * src/main/java/org/glom/web/client/ui/ListView.java:
1463 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1464 Remove unused imports, as suggested by Eclipse.
1466 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1468 Move the *View::Presenter types, and some API into one base View.
1470 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1471 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1472 * src/main/java/org/glom/web/client/ui/ListView.java:
1473 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1474 Presenter, setPresenter() and clear() into a shared base interface,
1475 to avoid the unnecessary duplicate Presenter types and to more clearly
1476 show how the *Views share the same structure, even if they are not
1477 used polymorphically.
1479 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1480 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1482 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1483 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1484 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1486 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1489 Feel free to revert this if there is a good reason for the duplicate
1492 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1494 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1496 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1497 a class member instead of a local variable in the method.
1498 This lets us use it to get the view instances, for use in tests.
1499 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1500 beforeOnlineGlom(): Test some more details of the initial view.
1501 Again, this is not very useful.
1503 To really test gwt-glom we will need to start a local postgresql
1504 instance with local data, like the Glom tests in C++.
1506 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1508 pom.xml: Mention the LGPL license.
1510 * pom.xml: Add a licenses section.
1511 * COPYING.LESSER: Move this to COPYING, which
1512 previously contained the GPL. But gwt-glom is all LGPL.
1514 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1516 Add project information to README and pom.xml.
1518 * README: Add a brief description and mention some mvn
1520 * pom.xml: This extra information shows up in mvn site
1523 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1525 Use the latest java-libglom version.
1527 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1529 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1531 GwtTestOnlineGlom: Test a little more.
1533 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1534 protected rather than private, as suggested by the gwt-test-utils
1536 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1537 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1538 Test the initial visibility of the panels.
1540 However, this is not a very useful test.
1541 And I wonder how we should generally test using this idea for an
1542 activity/places app like ours where the real changes happen implicitly
1543 based on the history token/URL.
1545 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1547 Slight modification to *Mapper comments.
1549 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1550 (DataActivityMapper)
1551 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1553 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1555 Remove comments mentioning GIN because they are just copied from
1556 the example code and are apparently not helpful:
1557 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1558 Also change the mention of a class that is only in the example code.
1560 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1562 GwtTestOnlineGlom test: Minor changes.
1564 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1565 Avoid the long qualified class name and modify the comment
1566 because it is now obvious to me that the mocked class is the only
1567 custom one created via GWT.create().
1569 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1571 Tests: Added the beginnings of a test using gwt-test-utils.
1573 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1574 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1575 which tells gwt-test-utils what class will be tested.
1576 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1577 Add a simple (but empty) test case. One class, used by the OnlineGlom
1578 class, is mocked so that it can be created. However, I am not sure
1579 why only this class needs to be mocked.
1581 Note that mockito seems more popular, and clearer, than easymock,
1582 but I have not got that working yet. It might be a matter of the
1585 This test is run during mvn integration-test.
1587 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1589 Tests: Use junit4-style syntax instead of junit3-style.
1591 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1592 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1593 * src/test/java/org/glom/web/shared/DataItemTest.java:
1594 Use the @Test annotation rather than relying on the test*() prefix.
1595 Also no longer implement TestCase, to avoid triggering support for
1596 the junit3-way, which stops the annotations from working.
1597 Change the imports from import junit.framework.* to
1598 import org.junit.*, which is apparently the new way.
1600 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1602 Added a test for ListPlace token parsing and creation.
1604 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1605 This is much the same as DetailsPlaceTest.
1607 I wonder how we could test the other parts of the *Place API.
1609 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1611 DetailsPlace test: Also test getToken() and recreation via getPlace().
1613 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1614 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1615 recreate it, testing the recreated DetailsPlace for the same parameter
1618 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1620 Use the surefire-report plugin.
1622 * pom.xml: This generates a HTML report about the tests in
1623 target/site/surefire-report.html
1624 when you do mvn surefire-report:report. It seems to be popular/normal.
1626 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1628 Added a test for DetailsPlace.
1630 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1631 Test the getPlace() token parsing.
1633 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1635 Added a first unit test.
1637 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1638 * src/test/java/org/glom/web/shared/DataItemTest.java:
1639 This is a silly test but it is just to get things started. Note that
1640 maven/junit finds the test because it looks in src/test by default.
1642 2011-12-22 Ben Konrath <ben@bagu.org>
1644 Change charsetName to "UTF-8" when replacing line breaks.
1646 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1647 that work in Java (such as "UTF8") will not work when compiled to
1650 This fixes a problem with multi-line details view fields that have hard
1651 line breaks. The "License Text" field on this page demonstrates the
1654 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1656 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1658 2011-12-22 Ben Konrath <ben@bagu.org>
1660 Fix another bug with related list navigation.
1662 I've tested all the navigation buttons in all of the related lists
1663 so things should be good now.
1665 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1667 2011-12-22 Ben Konrath <ben@bagu.org>
1669 Fix a crasher when refreshing the list view with the default table.
1671 This crash will also happen when loading the list view with the default
1672 table from a link or bookmark.
1674 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1675 to the main document selection page when the document id hasn't been
1677 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1678 the main document selection page when the document id hasn't been
1680 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1681 values for the details place when the document id hasn't been set.
1682 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1683 values for the list place when the document id hasn't been set.
1685 2011-12-21 Ben Konrath <ben@bagu.org>
1687 Protect against NPE when glom.document.locale is not in config.
1689 This patch protects against an NPE when glom.document.locale is not in
1690 the config file. This NPE will also happen if glom.document.locale is
1693 The patch also updates the error message to display the class name when
1694 the getMessage() returns null. This was happening when the NPE was
1695 thrown and I had "Configuration Error: null". If an NPE is encountered
1696 with this patch, "Configuration Error: NullPointerException " will be
1699 This commit closes this bug:
1701 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1703 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1705 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1707 Rename onlineglom.properties to onlineglom.properties.sample.
1709 * src/main/resources/onlineglom.properties: Rename to:
1710 * src/main/resources/onlineglom.properties.sample:
1711 * src/main/resources/README: And add this file explaining that people
1712 should rename it back when deploying.
1714 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1716 Allow choosing the translation in the .properties file.
1718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1719 init(): Read a glom.document.locale value from the configuration file
1720 and call Glom's TransatableItem::set_current_locale() method.
1721 * src/main/resources/onlineglom.properties: Add a commented-out
1722 example of this new setting.
1724 It would be better to add &lang=de_DE to the URL, but the current
1725 libglom API does not allow us to do this easily. I am working on that.
1727 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1729 Avoid a crash in parsing of token parameters.
1731 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1732 ava: getTokenParams(): Do not crash if a parameter has a key but no
1733 value, and ignore parameters with neither.
1735 2011-12-17 Murray Cumming <murrayc@murayc.com>
1737 History token building/handling: Improve use of token parameters.
1739 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1740 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1741 and buildParamsToken(HashMap), for use by derived classes.
1742 Make the separator private because it is no longer be needed.
1743 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1744 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1745 instead of manual string concatenation.
1746 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1747 of hardcoded indices and awkward splitting code.
1748 * src/main/java/org/glom/web/client/place/ListPlace.java
1749 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1750 instead of manual string concatenation.
1751 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1752 of hardcoded indices and awkward splitting code.
1753 This should fix bug #666420
1755 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1757 Fix a Navgiation->Navigation typo in the code.
1759 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1760 Rename processNavgiation() to processNavigation().
1762 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1764 Fix a seperator->separator typo in the code.
1766 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1767 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1768 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1771 2011-12-15 Ben Konrath <ben@bagu.org>
1773 Cleanup some comments.
1775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1777 2011-12-14 Ben Konrath <ben@bagu.org>
1779 Replace \n with <br/> for multiline text in the details view.
1781 Vertical scrollbars are added when needed as well.
1783 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1785 2011-12-14 Ben Konrath <ben@bagu.org>
1787 Specify the font for document selection links.
1789 * src/main/webapp/style.css:
1791 2011-12-14 Ben Konrath <ben@bagu.org>
1793 Fix bouncy CellTable while paging.
1795 This doesn't currently work with related list tables in unselected
1798 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1800 2011-12-14 Ben Konrath <ben@bagu.org>
1802 Revamp the appearance of the document selection page.
1804 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1805 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1806 * src/main/webapp/style.css:
1808 2011-12-13 Ben Konrath <ben@bagu.org>
1810 Set navigation button column to the smallest size possible.
1812 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1814 2011-12-13 Ben Konrath <ben@bagu.org>
1816 Change OpenButton nomenclature to NavigationButton.
1818 Using NavigtionButton makes things more generic. Classes, methods and
1819 variables have been changed.
1821 This is a rename-only refactor.
1823 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1824 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1825 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1826 Renamed from OpenButtonCell.
1827 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1828 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1829 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1831 2011-12-12 Ben Konrath <ben@bagu.org>
1833 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1836 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1837 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1838 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1840 2011-12-12 Ben Konrath <ben@bagu.org>
1842 Update variable names and comments.
1844 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1845 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1847 2011-12-12 Ben Konrath <ben@bagu.org>
1849 Properly initialize numNonEmptyRows variable to zero.
1851 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1852 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1854 2011-12-05 Ben Konrath <ben@bagu.org>
1856 Add latest mockup with HTML tables.
1858 Features of this mockup:
1860 -> HTML table for flowtable
1861 -> HTML table for flowtable column
1862 -> Example of how related lists would look
1863 -> Not using text entries for data items
1865 The current version of Online Glom doesn't use HTML tables for the
1868 This mockup has been sent to the glom-devel mailing list but it's good
1869 to have it here as well.
1871 * mockups/details-view-html-tables.html:
1873 2011-12-05 Ben Konrath <ben@bagu.org>
1875 Remove unnecessary getPrimaryKeyField() method.
1877 getPrimaryKeyFieldForTable(String) has been renamed to
1878 getPrimaryKeyField(String).
1880 * src/main/java/org/glom/web/server/database/DBAccess.java:
1881 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1882 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1884 2011-12-05 Ben Konrath <ben@bagu.org>
1886 Add string representation of TypedDataItem value to conversion error message.
1888 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1889 message was extracted into its own method to avoid duplication.
1891 2011-12-05 Ben Konrath <ben@bagu.org>
1893 Add type checking to navigation primary key value creation.
1895 Create navigation primary key only if the expected type from the Glom
1896 document matches the type returned by the SQL query.
1898 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1900 2011-12-05 Ben Konrath <ben@bagu.org>
1902 Rename a couple of variables in RelatedListNavigation.
1904 This is a rename-only refactor.
1906 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1908 2011-12-05 Ben Konrath <ben@bagu.org>
1910 Move getListLayoutGroup() into getListViewLayoutGroup().
1912 This removes getListLayoutGroup(). It was only being called by
1913 getListViewLayoutGroup().
1915 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1917 2011-12-05 Ben Konrath <ben@bagu.org>
1919 Remove check for LayoutItem_Portal in list table method.
1921 This check is no longer necessary because the method isn't being used
1922 to create the LayoutItemPortal DTO.
1924 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1926 2011-12-05 Ben Konrath <ben@bagu.org>
1928 Properly support related list navigation.
1930 Navigation from the "Repository Analyzer -> Package Scans ->
1931 Dependencies" related table wasn't working because the primary key for
1932 related tables wasn't being set properly. This commit fixes the
1935 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1936 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1937 doesn't set the primary key properly for related list tables.
1938 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1939 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1940 useful for getting the primary key for list view tables and for related
1942 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1943 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1944 Move code to set the primary key for the table from the abstract
1945 ListDBAccess class to ListViewDBAccess as it's only correct for list
1947 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1948 Properly add primary key to related list tables.
1950 2011-12-02 Ben Konrath <ben@bagu.org>
1952 Properly set the horizontal alignment of fields.
1954 This fix is for both the list tables and the details view.
1956 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1957 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1958 to set the horizontal alignment of fields.
1960 2011-12-02 Ben Konrath <ben@bagu.org>
1962 Display currency codes in the details view.
1964 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1966 2011-12-02 Ben Konrath <ben@bagu.org>
1968 Avoid duplicate JNI call.
1970 JNI is not as efficient as pure Java and this is an easy (and small)
1973 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1974 Use previously retrieved value for whereClauseToTableName instead of
1977 2011-12-02 Ben Konrath <ben@bagu.org>
1979 Rename a couple of variables in RelatedListNavigation.
1981 This is a rename-only refactor.
1983 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1985 2011-12-02 Ben Konrath <ben@bagu.org>
1987 Indicate clearly that a mismatched primary key type is a bug.
1989 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1990 warning to error. Add 'This is a bug.' to message.
1992 2011-12-02 Ben Konrath <ben@bagu.org>
1994 Update / fix some comments.
1996 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1998 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2000 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2001 Fix comments. Add some TODOs.
2003 2011-12-02 Ben Konrath <ben@bagu.org>
2005 Enable navigation to details view with string primary key from related list.
2007 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2008 Create a text primary key value when return type of result is
2009 java.sql.Types.VARCHAR.
2011 2011-12-02 Ben Konrath <ben@bagu.org>
2013 Use checkboxes for booleans in the details view.
2015 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2017 2011-12-01 Ben Konrath <ben@bagu.org>
2019 Improve performance of related list height calculation.
2021 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2022 Put code to calculate the expected height in a static initializer so
2023 that that it's only called once.
2025 2011-12-01 Ben Konrath <ben@bagu.org>
2027 Show related list tables in notebooks (again).
2029 Calculate the height of the related list tables so the Notebook can be
2030 set the correct height. The height of the related list table is also needed by
2031 FlowTable to be able decide how to create the layout.
2033 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2034 and set the Portal height based on the height of the related list
2035 table and the Portal container.
2036 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2037 Add method to calculate the height of the related list tables.
2038 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2039 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2040 calculate the height of the Pager widget.
2042 2011-12-01 Ben Konrath <ben@bagu.org>
2044 Use CellTable API for table property instead of setting style on Element.
2046 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2048 2011-12-01 Ben Konrath <ben@bagu.org>
2050 Make ListViewTable and RelatedListTable a consistent height.
2052 The tables are now a consistent height regardless of the contents of
2053 the table. A hidden button is added to empty rows to ensure that the
2054 height of these rows will match the height of rows with data.
2056 A navigation button column is now added to every table. The width of
2057 the navigation column is set to 0px when a RelatedListTable shouldn't
2058 have navigation buttons. This maintains the a consistent row height in
2059 tables that don't show the navigation buttons.
2061 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2062 navigation column when not needed.
2063 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2064 arguments for navigation button to constructor of ListViewTable.
2065 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2066 hidden button for empty data rows.
2067 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2068 arguments for navigation button to constructor.
2069 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2070 create navigation buttons. Add hideNavigationButtons() method.
2071 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2072 arguments for navigation button to constructor.
2074 2011-12-01 Ben Konrath <ben@bagu.org>
2076 Use 'visibility: hidden' in Utils.getWidgetHeight().
2078 This is better choice because hidden elements are invisible, don't
2079 respond to events and are not part of the tab order. They will,
2080 however, take up space which is required to be able to calculate the
2081 height of the widget.
2083 * src/main/java/org/glom/web/client/Utils.java:
2085 2011-12-01 Ben Konrath <ben@bagu.org>
2087 Use Utils.getWidgetHeight() in FlowTable.
2089 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2091 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2093 2011-12-01 Ben Konrath <ben@bagu.org>
2095 Put the details css class name on the correct table column.
2097 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2099 2011-11-30 Ben Konrath <ben@bagu.org>
2101 Update for java-libglom API change.
2103 The getters and setters on FieldFormatting and NumericFormat were
2104 changed to remove the 'M'.
2106 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2108 2011-11-29 Ben Konrath <ben@bagu.org>
2110 Only allow RelatedListTables in Portals.
2112 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2114 2011-11-29 Ben Konrath <ben@bagu.org>
2116 Only create a contents panel for Portals when title is being set.
2118 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2120 2011-11-29 Ben Konrath <ben@bagu.org>
2122 Set TabLayoutPanel height based on calculated height its widgets.
2124 This is a potential fix for this bug:
2126 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2128 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2130 2011-11-29 Ben Konrath <ben@bagu.org>
2132 Align details field labels and data with the Open buttons.
2134 * src/main/webapp/style.css:
2136 2011-11-29 Ben Konrath <ben@bagu.org>
2138 Remove unnecessary <div> in the Notebook widget.
2140 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2141 method to get container FlowPanel (<div>).
2142 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2143 initWidget() method directly on the TabLayoutPanel widget instead of
2144 Group's container widget.
2146 2011-11-29 Ben Konrath <ben@bagu.org>
2148 Don't add group titles for Portals in Notebooks.
2150 This reverts the previous patch and fixes a bug I introduced with
2151 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2153 * src/main/java/org/glom/web/client/ui/details/Group.java:
2154 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2156 2011-11-28 Ben Konrath <ben@bagu.org>
2158 Remove unused boolean argument in Portal constructor.
2160 Just a code cleanup.
2162 * src/main/java/org/glom/web/client/ui/details/Group.java:
2163 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2165 2011-11-28 Ben Konrath <ben@bagu.org>
2167 Remove hack for glom 1.18 style glom files.
2169 * src/main/java/org/glom/web/client/ui/details/Group.java:
2170 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2171 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2173 2011-11-28 Ben Konrath <ben@bagu.org>
2175 Use Gda Value version of primary key to log result too large error.
2177 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2179 2011-11-28 Ben Konrath <ben@bagu.org>
2181 Don't use TypedDataItem.getText() for Unknown types from the URL.
2183 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2184 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2185 instead of getText().
2186 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2187 String field and getUnknown() method.
2189 2011-11-28 Ben Konrath <ben@bagu.org>
2191 Log an error message when the java-libglom .so is not present.
2193 The error message was being set in the exception but not logged.
2195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2197 2011-11-28 Ben Konrath <ben@bagu.org>
2199 Ignore LayoutItem_CalendarPortals.
2201 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2202 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2204 2011-11-28 Ben Konrath <ben@bagu.org>
2206 Extract method for creating the LayoutItemPortal DTO.
2208 Just breaking the code up into smaller chunks.
2210 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2212 2011-11-28 Ben Konrath <ben@bagu.org>
2216 This should have been added with the refactor. Oops!
2218 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2220 2011-11-28 Ben Konrath <ben@bagu.org>
2222 Create primary key value from URL string using type from Glom document.
2224 See this bug, comments 19 - 25:
2226 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2228 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2229 create a TypeDataItem for the primary key here when loading from a
2230 URL. Show the same string for the primary key value as was received
2231 from the URL string (when loading from a URL).
2232 * src/main/java/org/glom/web/server/Utils.java: Update method for
2233 creating the Gda Value from the TypeDataItem to properly deal with
2234 creating a Gda Value based on the Glom document type for the primary
2235 key value string when loading from a URL.
2236 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2237 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2238 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2239 Update for changed method name.
2241 2011-11-27 Ben Konrath <ben@bagu.org>
2243 Rename PrimaryKeyItem to TypedDataItem.
2245 The name PrimaryKeyItem suggests what the class should be used for.
2246 TypedDataItem is a neutral name that describes the class better.
2248 This is a rename-only refactor.
2250 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2251 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2252 * src/main/java/org/glom/web/client/Utils.java:
2253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2254 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2255 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2257 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2258 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2259 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2260 * src/main/java/org/glom/web/server/Utils.java:
2261 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2262 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2263 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2264 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2266 2011-11-25 Ben Konrath <ben@bagu.org>
2268 Improve Gda Value conversion from PrimaryKeyItem.
2270 The value from the PrimaryKeyItem is only used if its type match the
2271 type from the glom document.
2273 * src/main/java/org/glom/web/server/Utils.java:
2275 2011-11-25 Ben Konrath <ben@bagu.org>
2277 Manually check if the java-liblgom .so is visible to the JVM.
2279 It seems that Tomcat has problems when a static initializer throws an
2280 exception. This check is done before the first method call into
2281 java-libglom so that execution doesn't continue if the .so is not
2284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2286 2011-11-25 Ben Konrath <ben@bagu.org>
2288 Improve browser configuration error messages.
2292 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2294 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2295 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2296 getConfigurationErrorMessage() method.
2297 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2298 Get and display a specific configuration error message when no Glom
2299 documents are found.
2300 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2301 Implement getConfigurationErrorMessage() method. Surround configuration
2302 code in the init() method with a try/catch block. This allows the
2303 errors to be caught while keeping the servlet available to retrieve the
2304 configuration error message.
2306 2011-11-25 Ben Konrath <ben@bagu.org>
2308 Don't use Strings to hold primary key values.
2310 The primary key values are now held in a new data object
2311 (PrimaryKeyItem) that holds type information and the primary key value
2312 using the correct type.
2314 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2315 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2317 PrimaryKeyItem instead of String to hold the primary key value.
2318 * src/main/java/org/glom/web/client/Utils.java: Remove
2319 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2320 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2321 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2322 PrimaryKeyItem instead of String to hold the primary key value. Load
2323 document selection page when the documentID has not been set correctly.
2324 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2325 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2327 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2328 Return empty string for URL instead of "null".
2329 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2330 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2331 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2332 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2333 PrimaryKeyItem instead of String to hold primary key values.
2334 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2335 PrimaryKeyValue to a Gda Value.
2336 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2337 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2338 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2339 Replace temporary database access code that uses the PrimaryKeyValue to
2340 Gda Value conversion.
2341 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2342 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2343 PrimaryKeyItem instead of String.
2344 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2345 hold primary key values.
2347 2011-11-24 Ben Konrath <ben@bagu.org>
2349 Use newly added java-libglom API to create queries.
2351 This isn't finished. I still need to stop using Strings for primary key
2352 values in the client code.
2354 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2355 libglom to use fake connections so that retrieving the query string will
2357 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2358 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2359 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2360 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2361 Use the newly added libglom sql methods and classes to create the
2362 query. Add temporary hack to convert primary value strings to Gda
2365 2011-11-23 Ben Konrath <ben@bagu.org>
2367 Don't explicitly set the height of Portals.
2369 See comments 6 - 10 of this bug for details:
2371 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2373 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2375 2011-11-23 Ben Konrath <ben@bagu.org>
2377 Use an HTML table instead of CSS for the FlowTable layout.
2379 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2380 GWT's FlexTable to implement the FlowTable.
2381 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2383 2011-11-18 Ben Konrath <ben@bagu.org>
2385 Add boolean example to HTML table mockup.
2387 * mockups/details-view-html-tables-text-entries.html:
2389 2011-11-17 Ben Konrath <ben@bagu.org>
2391 Ensure the pager buttons are always visible for related lists.
2393 To accomplish this, I've turned off text wrapping in the list view and
2394 related list tables for both the header and data text. The related list
2395 table now has a fixed layout so the it doesn't overflow its container.
2396 This is required to ensure that the cell text is clipped when it
2397 overflows the cell and an ellipsis is added to the right side of the
2398 cell when text is clipped.
2400 A fixed table layout for the related list table in the details view
2401 seems what we want for the details view anyway, so the side-effect is
2404 The ellipsis will only be displayed in Firefox >= 7.
2408 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2410 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2411 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2412 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2414 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2415 Set the 'table-layout: fixed' CSS property to the related list table.
2416 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2417 'white-space: nowrap;' CSS property on both the list view and the
2418 related list tables.
2420 2011-11-16 Ben Konrath <ben@bagu.org>
2422 Rework the fix for empty notebook tab labels.
2424 Setting the empty group titles with its name caused problems for the
2425 details layout. Instead of using libglom's
2426 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2427 to the client when the title is empty. This allows the Notebook to use
2428 the name when the title is empty without affecting anything else.
2430 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2431 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2433 2011-11-16 Ben Konrath <ben@bagu.org>
2435 Set group titles with name when title is empty.
2437 This fixes a problem with an empty notebook tab label in the Lesson
2438 Planner document. The forth tab in the notebook should be "Internet":
2440 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2442 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2443 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2446 2011-11-16 Ben Konrath <ben@bagu.org>
2448 Remove whitespace from the configured username properties.
2450 This assumes that usernames won't have whitespace at the beginning
2451 or end. But I think this is a reasonable assumption.
2453 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2454 String.trim() to remove the whitespace from the username properties.
2456 2011-11-15 Ben Konrath <ben@bagu.org>
2458 Add details view mockup with HTML tables and text entries.
2460 This is from the attachment on this bug:
2462 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2464 * mockups/details-view-html-tables-text-entries.html:
2466 2011-11-15 Ben Konrath <ben@bagu.org>
2468 Add space between the columns of the flow table.
2472 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2474 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2475 space between columns in the flow table.
2477 2011-11-15 Ben Konrath <ben@bagu.org>
2479 Add backup files to the .gitignore.
2481 * .gitignore: Ignore files that end with ~.
2483 2011-11-09 Ben Konrath <ben@bagu.org>
2485 Use latest release of gwt-log.
2487 Gwt-log releases are now being submitted to the maven central
2488 repository so manual installation of the jar is no longer required.
2490 * pom.xml: Update version and groupId of gwt-log dependency.
2492 2011-10-31 Ben Konrath <ben@bagu.org>
2494 Don't use GWT numeric formatting to override the glom currency formatting.
2496 Currencies are now displayed like they are in Glom. See this bug:
2498 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2500 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2502 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2503 currency code to constructor and set it when the cell is rendered.
2504 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2505 currency code to the constructor of the NumericCell.
2507 2011-10-27 Ben Konrath <ben@bagu.org>
2509 Require the latest release of java-libglom (1.17.4).
2513 2011-10-26 Ben Konrath <ben@bagu.org>
2515 Add style to Notebook that matches current theme.
2517 It's not the best style in the world but it's better than the default.
2519 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2520 padding at the bottom of the child widgets.
2521 * src/main/webapp/style.css: Add style for the Notebook.
2523 2011-10-26 Ben Konrath <ben@bagu.org>
2525 Move servlet initialization code to overridden init method.
2527 This is half of the solution to getting proper error messages
2528 displayed when configuration errors occur. Here's the relevant bug:
2530 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2532 The rest of the solution involves surrounding the init method with a
2533 try/catch block and setting a global variable with the error /
2534 exception. A new async method should be created to retrieve and display
2535 the error message / exception.
2537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2538 code from constructor to init method adding exceptions as needed.
2540 2011-10-26 Ben Konrath <ben@bagu.org>
2542 Add script to monitor and restart tomcat if required.
2544 * utils/check-and-recover-tomcat.py: New file.
2546 2011-10-26 Ben Konrath <ben@bagu.org>
2548 Display the correct number of data items in the pager.
2552 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2554 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2555 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2556 The implementation is the same for both tables: Keep track of the
2557 number of non-empty rows and fire and RowCountChangeEvent after the data has
2559 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2560 custom Pager class that subclasses SimplePager to handle displaying
2561 the correct number when empty rows have been added.
2563 2011-10-26 Ben Konrath <ben@bagu.org>
2565 Correct error in previous commit.
2567 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2568 eventBus parameter from listView.setCellTable().
2570 2011-10-26 Ben Konrath <ben@bagu.org>
2572 Fix error in TODO comment.
2574 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2576 2011-10-24 Ben Konrath <ben@bagu.org>
2578 Create Notebook widgets to the details view.
2580 This isn't finished just yet - I still need to create a reasonable
2581 style to match the current theme.
2583 * src/main/java/org/glom/web/client/Utils.java: Add method for
2584 calculating the height of a widget. This is used in the Notebook class.
2585 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2586 new constructor method in Group.
2587 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2588 method for creating child widget that can be used by subclasses
2589 like Notebook. New constructor that allows disabling the group
2590 titles - Notebooks don't set a group title for their child groups.
2591 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2592 to make Notebooks using GWT's TabLayoutPanel.
2593 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2594 constructor that allows disabling the group titles.
2595 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2596 LayoutItemNotebook DTO.
2597 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2598 DTO for Notebooks. It's just an empty class for now but we might need
2599 it to transfer some specific information in the future.
2601 2011-10-21 Ben Konrath <ben@bagu.org>
2603 Add navigation buttons to related list tables.
2605 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2606 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2608 method getSuitableRecordToViewDetails() for getting the table name
2609 and primary key value for related list navigation buttons.
2610 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2611 private cell renderer class to get the navigation information for
2612 related list tables from the server. Extract the navigation
2613 processing code from the details cell navigation and use it for the
2614 related list navigation as well.
2615 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2616 cell renderer class for the details open buttons. This was needed
2617 because the related list navigation buttons and the list view
2618 navigation buttons need to react differently when clicked.
2619 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2620 the onEnterKeyDown() method because it's now overriden in the
2621 subclasses that are specific to the related list tables and the list
2623 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2624 the vertical size a little because the buttons add a bit of vertical
2625 space to table. This is not a perfect solution because the vertical
2626 size of with table fewer than 5 rows will be a little smaller.
2627 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2628 changes in how navigation buttons are handled.
2629 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2630 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2631 database access object.
2632 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2633 to find the portal for a given relationship name from
2634 RelatedListDBAccess. Add method to find a primary key field for a
2636 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2637 Move code to find the portal for a given relationship name to
2639 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2640 New file: database access object for getting the related list
2641 navigation information (the table name and the primary key value).
2642 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2643 DTO for transferring a table name to navigate to and a primary key
2645 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2646 boolean and getter/setter to specifies if the related list should add
2649 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2651 Use the master branch of java-libglom
2653 * pom.xml: Depend on java-libglom 1.19 instead.
2655 This is the master branch. See also the libglom-1-18 branch.
2657 2011-10-11 Ben Konrath <ben@bagu.org>
2659 Enable the open navigation button when the data has been set.
2661 This avoids having active buttons that don't do anything when the data
2664 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2666 2011-10-11 Ben Konrath <ben@bagu.org>
2668 Use IsWidget interface for FlowTableItem.
2670 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2671 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2673 2011-10-11 Ben Konrath <ben@bagu.org>
2675 Remove GWT styling from open button in details view.
2677 There are still some issues with how the details cell is arranged but
2678 this should be made to match Glom 1.20. I'm going to leave fixing this
2679 until I have Glom 1.20 up and running.
2681 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2682 style name on open button.
2683 * src/main/webapp/style.css: Move and edit details-navigation class.
2684 Re-arrange some classes to make them appear in the same order as the
2687 2011-10-07 Ben Konrath <ben@bagu.org>
2689 Update to GWT 2.4.0.
2691 * .gitignore: Ignore new cache directory.
2692 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2693 * pom.xml: Change GWT and maven plugin to 2.4.0.
2694 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2696 * src/main/java/org/glom/web/client/ClientFactory.java:
2697 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2698 * src/main/java/org/glom/web/client/OnlineGlom.java:
2699 Update source for API changes.
2700 * utils/build-onlineglom-war.sh: Remove cache directory before the
2703 2011-10-07 Ben Konrath <ben@bagu.org>
2705 Add navigation buttons in the details view.
2707 This isn't finished but I thought I'd commit what I have as it's a
2708 pretty good start. I still need to:
2710 1. Change the style so that it fits better into the current theme
2711 2. Adjust the details cell to expand as much as possible.
2713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2714 click handlers to navigation buttons in the DetailsCells. Create a
2715 refreshData() method to get just the data from the server without the
2717 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2718 Update the tableSelector and browser title when the table name
2719 changes without using the tableSelector.
2720 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2721 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2722 getDetailsCells() to getCells(). Update variable names.
2723 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2724 method to set click handler on navigation button. Rename a few
2725 variables. Add navigation buttons where needed.
2726 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2727 variables and methods.
2728 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2729 navigation boolean and navigation table as required in the
2730 LayoutItemField DTO.
2731 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2732 variables for navigation along with getter/setter methods.
2734 2011-10-07 Ben Konrath <ben@bagu.org>
2736 Rename Field to DetailsCell.
2738 This is a refactor-only commit. No functionality has been added or
2741 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2742 Update variable and method names.
2743 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2744 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2745 variable and method names.
2746 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2748 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2749 variable and method names.
2751 2011-10-07 Ben Konrath <ben@bagu.org>
2753 Create separate methods for layout and data the details view.
2755 This is a refactor-only commit. No functionality has been added or
2758 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2759 private methods: setData(), createLayout().
2761 2011-10-07 Ben Konrath <ben@bagu.org>
2763 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2765 This is part of a change to get navigation buttons in the details view
2766 but it should have been done this way from the start.
2768 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2769 for method name change in TableSelectionView.
2770 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2771 Create TableChangeEvent and set the browser title using the
2772 TableSelectionView API.
2773 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2774 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2775 Change getSelectedTable() to getSelectedTableName(). Add
2776 getSelectedTableTitle().
2778 2011-10-07 Ben Konrath <ben@bagu.org>
2780 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2782 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2784 2011-10-07 Ben Konrath <ben@bagu.org>
2786 Update TableChangeEvent to use newTableName naming convention.
2788 This makes the class more consistent with GWT naming conventions.
2790 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2791 Update for method name change in TableChangeEvent.
2792 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2793 for method name change in TableChangeEvent.
2794 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2795 newTableName variable and getter method. Make toDebugString()
2798 2011-09-30 Ben Konrath <ben@bagu.org>
2800 Disable the pager in the list tables when the data row count is less than the minimum.
2802 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2803 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2805 2011-09-30 Ben Konrath <ben@bagu.org>
2807 Add empty rows to the end of related list and list view tables.
2809 I also extracted the cell rendering classes from the ListTable because
2810 the code was becoming a little crazy with all the anonymous inner
2811 classes. My plan is to use these cell rendering classes in the details
2812 view as well so this refactor will be needed for that change.
2814 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2815 set the row count in related list tables if the data has more rows
2816 than the minimum number of rows visible.
2817 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2818 row count in list view tables if the data has more rows than the
2819 minimum number of rows visible.
2820 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2821 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2823 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2824 for rendering TYPE_NUMERIC cells. The code was extracted from the
2826 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2827 class for rendering cells with buttons in list views. The code was
2828 extracted from the ListTable class.
2829 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2830 for rendering TYPE_TEXT cells. The code was extracted from the
2832 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2833 Add empty rows to the end of the data if required. Implement
2834 ListTable.getMinNumVisibleRows().
2835 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2836 cell renderer code to public classes. Return null in
2837 Column.getValue() for empty rows. Add new abstract method:
2838 getMinNumVisibleRows(). Move code to set the row count of the list view
2839 table to ListViewImpl.
2840 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2841 empty rows to the end of the data if required. Implement
2842 ListTable.getMinNumVisibleRows().
2845 2011-09-27 Ben Konrath <ben@bagu.org>
2847 Use GWT.log for client-side debugging statements.
2849 These are optimized out when deployed so I should have used this method
2850 in the first place. These statements will eventually be replaced with some sort
2851 of notification in the browser.
2853 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2854 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2855 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2856 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2857 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2859 2011-09-27 Ben Konrath <ben@bagu.org>
2861 Put tableselector on the right, back to list link on right.
2863 The idea is that the table selector is acting like a label for the
2864 currently displayed table so it should be placed below the document title. This
2865 puts the table title in a similar position to where it is in Glom.
2867 * mockups/details-contacts.html:
2868 * mockups/details-projects.html:
2869 * mockups/listview-contacts.html:
2870 * mockups/listview-projects.html:
2871 * mockups/style.css:
2872 Update mockups to match how the interfaces currently look.
2873 * src/main/webapp/style.css: Swap positions of backlink with the table
2874 selector. Add some space on the left side of the table selector to
2875 line things up with the document title.
2877 2011-09-27 Ben Konrath <ben@bagu.org>
2879 Add field colouring to details view.
2881 This change re-works how field colouring works. The colour formatting
2882 information is now set to the client with the layout information instead of
2883 with the data. This eliminates the need to send the same colour strings for
2884 data in list view column when colour information is set.
2886 In order to set an alternate colour for negative numeric values, the
2887 number is now sent to client and formatted with the GWT NumberFormat class.
2889 This change also fixes:
2891 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2893 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2894 internationalization framework which is needed for client side numeric
2896 * src/main/java/org/glom/web/client/Utils.java: New file for some
2897 client static utility methods.
2898 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2899 the DataItem object to the Field class. Use a utility method to
2900 create the foreignKeyValue string.
2901 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2902 alignment and text colours in the constructor. Add setData(DataItem)
2903 method. Remove setText(String) method.
2904 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2905 colour information to GlomTextCell. Create and use GlomNumberCell for
2906 rendering numbers. Use utility method to get the string for the
2907 primary key of the key provider. Re-work how the horizontal alignment
2909 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2910 formatting to layout information. Methods for converting the libglom
2911 formatting information were moved from DBAccess.
2912 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2913 numeric formatting (it's now done on the client side). Don't set text
2914 colours in DataItem. Move libglom formatting conversion methods to
2916 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2917 getters/setters for text colour information.
2918 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2919 for transferring the libglom NumericFormat information to the client.
2920 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2921 and getters/setters for: GlomNumericFormat, background colour and
2922 foreground colour strings.
2924 2011-09-26 Ben Konrath <ben@bagu.org>
2926 Simplify code that iterates through the LayoutGroup.
2928 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2930 2011-09-26 Ben Konrath <ben@bagu.org>
2932 Accept Eclipse formatting for OnlineGlomServiceAsync.
2934 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2936 2011-09-26 Ben Konrath <ben@bagu.org>
2938 Don't use the ListDBAccess classes to get the primary key layout information.
2940 This was causing a bug where the wrong index for the hidden primary key
2941 was being sent to the client.
2943 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2944 primary key while creating the LayoutGroup DTO. Create a
2945 LayoutItemField DTO for hidden primary keys. Don't use the
2946 RelatedListDBAccess because it was only used for getting the primary
2948 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2949 access modifier from public to protected for getPrimaryKeyField() and
2950 getPrimaryKeyLayoutItemField().
2951 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2952 abstract method getExpectedResultSize() because RelatedListDBAccess
2953 doesn't have enough info to implement it.
2954 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2955 Remove @Override for getExpectedResultSize().
2956 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2957 Remove method getExpectedResultSize().
2959 2011-09-23 Ben Konrath <ben@bagu.org>
2961 Log which layout (list or details) the ignored item is from.
2963 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2965 2011-09-23 Ben Konrath <ben@bagu.org>
2967 Remove annotations that turn off code formatting in DataItem.
2969 * src/main/java/org/glom/web/shared/DataItem.java:
2971 2011-09-23 Ben Konrath <ben@bagu.org>
2973 Rename GlomField to DataItem and update associated methods.
2975 This is a rename-only refactor. No functionality has been added or
2978 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2979 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2980 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2981 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2982 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2983 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2984 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2985 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2987 * src/main/java/org/glom/web/server/database/DBAccess.java:
2988 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2989 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2990 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2991 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2992 * src/main/java/org/glom/web/shared/DataItem.java:
2993 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2994 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2996 2011-09-23 Ben Konrath <ben@bagu.org>
2998 Rename GlomDocument to DocumentInfo and update associated methods.
3000 This is a rename-only refactor. No functionality has been added or
3003 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3004 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3005 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3006 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3007 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3008 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3009 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3011 2011-09-20 Ben Konrath <ben@bagu.org>
3013 Require java-libglom 1.17.3.
3015 This picks up the fix for the seg fault problem with the Scenes table
3016 in the Openismus Film Manager example.
3020 2011-09-20 Ben Konrath <ben@bagu.org>
3022 Change the way sort clause is added for primary key when no sort clause is requested.
3024 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3025 before the sort clause is created. When a sort clause is not requested, the
3026 sort clause is created by finding the primary key in the LayoutFieldVector
3029 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3031 2011-09-20 Ben Konrath <ben@bagu.org>
3033 Log error message if no documents are found in the configured directory.
3035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3036 Extract the glom file extension string to a private static final class
3037 variable (mostly as syntactic sugar). Accept a minor formatting change.
3038 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3039 the example glom.document.directory configuration property to make it
3040 more clear that it can any directory, not just the home directory.
3042 2011-09-18 Ben Konrath <ben@bagu.org>
3044 Add related lists to details view.
3046 The related list table has support for paging and sorting just like the
3047 table in the list view.
3049 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3050 SQL queries for the related list tables.
3051 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3052 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3054 Rename getList methods to getListView and add comments. Remove
3055 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3056 it being unused. Add methods: getDetailsLayoutAndData(),
3057 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3058 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3059 Create the layout and set the data for the fields in one async call
3060 instead of two. Create related lists where appropriate.
3061 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3062 for method name changes in OnlineGlomService.
3063 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3064 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3065 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3067 * src/main/java/org/glom/web/client/ui/ListView.java:
3068 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3069 tableName from setCellTable(). Create a ListViewTable instead of
3071 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3072 represent a data field in the details view.
3073 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3074 from addDetailsCell() to Field class. Keep track of the Fields and
3075 Portals in the details view.
3076 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3077 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3078 and add a method to get it. Add method to set the contents of the
3080 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3081 New class for related list tables. This class has the data provider
3082 for the related list table.
3083 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3084 abstract class which is the base class for the ListViewTable and the
3086 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3087 New class for list view tables. This class has the data provider for
3088 the list view table.
3089 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3090 methods for related list tables. Add more information to the
3091 LayoutItemField and LayoutItemPortal DTOs.
3092 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3093 Remove debugging print statement.
3094 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3095 Remove debugging print statements. Add primary key field to SQL count
3097 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3098 Remove unnecessary LayoutFieldVector parameter from
3099 getResultSizeOfSQLQuery() method.
3100 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3101 New class for related list table database access.
3102 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3103 class that is a wrapper DTO for details view layout and data.
3104 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3105 new 'fromField' string to this DTO.
3106 * src/main/webapp/style.css: Remove bottom margin and override top
3109 2011-09-15 Ben Konrath <ben@bagu.org>
3111 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3113 This sets things up to make it easier to add the data retrieval for
3114 related lists (portals). No user noticeable changes were made with
3117 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3118 class has the code to retrieve the layouts and access the
3119 database using the new database helper classes.
3120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3121 Most of the functionality has been removed from this class. This
3122 class now represents the public interface for the client side
3123 code. It also deals with configuring the servlet and cleaning
3124 things up when the servlet is stopped.
3125 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3126 of static methods into this utility class.
3127 * src/main/java/org/glom/web/server/database/DBAccess.java:
3128 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3129 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3130 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3131 These classes have the database retrieval code. The class hierarchy
3132 has been setup to make it easy to reuse code for similar
3135 2011-09-06 Ben Konrath <ben@bagu.org>
3137 Create separate classes for list table code and the data provider.
3139 As part of this refactor, I also split up the code a bit to make it
3142 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3143 table code to two new classes (below).
3144 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3145 with code from ListViewImpl.
3146 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3147 New file with code from ListViewImpl.
3149 2011-09-06 Ben Konrath <ben@bagu.org>
3151 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3153 This fixes the LayoutItemPortal DTO to match the libglom layout object
3156 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3158 2011-09-01 Ben Konrath <ben@bagu.org>
3160 Set title of Portals in the Details View.
3162 * pom.xml: Bump required version of java-libglom to 1.17.1.
3163 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3164 widget creation to its own class. Add comments to constructor.
3165 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3166 The code is mostly from the Group class with the title now set.
3167 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3168 title of Portal. Update some comments. Fix some code formatting.
3170 2011-09-01 Ben Konrath <ben@bagu.org>
3172 Remove TODO comment for the flow table column width.
3174 The flow table column width is working correctly and doesn't need to be
3175 changed. See this mailing list post for more info:
3177 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3179 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3181 2011-08-27 Ben Konrath <ben@bagu.org>
3183 Add document title (database name) to top of the browser page.
3185 I added the document title to the TableSelecitonView but that will
3186 change if / when we add a view that doesn't require table selection.
3188 * mockups/details-contacts.html:
3189 * mockups/details-projects.html:
3190 * mockups/listview-contacts.html:
3191 * mockups/listview-projects.html:
3192 * mockups/style.css: Add document title to mockups to keep things
3194 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3195 sizes to account for the document title.
3196 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3197 Set the document title when it has been retrieved from the server.
3198 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3199 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3200 and implement setDocumentTitle(String) method.
3201 * src/main/webapp/style.css: Add ID for document title style.
3203 2011-08-25 Ben Konrath <ben@bagu.org>
3205 Add NavigationType enum to LayoutItemPortal DTO.
3207 This is the start of adding support for Portals to the Details View.
3209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3210 LayoutItem_Portal.navigation_type enum from libglom to
3211 LayoutItemPortal.NavigationType enum.
3212 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3213 NavigationType enum, field for storing the NavigationType and getter
3216 2011-08-25 Ben Konrath <ben@bagu.org>
3218 Implement the flow table layout in the Details View.
3220 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3221 FlowTable to Group to account for the renamed class.
3222 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3223 File. This is a container widget that implements the Glom details view
3224 flow table behaviour.
3225 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3226 org/glom/web/client/ui/FlowTable.java.
3227 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3228 so that the size of the subgroups are a closer match to the size of
3229 the Glom subgroups. This makes the flowtable layout match the layout
3230 in Glom for the Music Collection example file.
3232 2011-08-16 Ben Konrath <ben@bagu.org>
3234 Create container element for LayoutItemPortal in Details View.
3236 This will help me develop the layout for the FlowTable.
3238 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3239 fieldPanel variable to detailsCell.
3241 2011-08-15 Ben Konrath <ben@bagu.org>
3243 Set the height of the data element in the Details View.
3245 I changed the InlineLabels (text in a span element) to Labels (text in
3246 a div element) so that I could set the height of the details-data
3247 elements instead of the details-cell parent elements. This allows the
3248 the details-data element to display the correct height if style is
3249 applied that shows the height.
3251 This change has the added benefit of allowing the order of the labels
3252 and data elements to be changed for right-to-left languages.
3254 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3255 InlineLabels to Labels.