1 2012-07-19 Murray Cumming <murrayc@murrayc.com>
3 Avoid another code warning in Eclipse Juno.
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
6 Do instanceof checks on the FileUtils.listFiles() result and its
9 2012-07-13 Murray Cumming <murrayc@murrayc.com>
11 Avoid some code warnings in Eclipse Juno
13 * src/main/java/org/glom/web/server/libglom/Document.java:
14 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
15 * src/test/java/org/glom/web/server/SelfHoster.java
16 createTextFile(): Make sure that the FileOutputStream is closed.
18 2012-06-22 Murray Cumming <murrayc@murrayc.com>
20 Added OnlineGlomPropertiesTest.
22 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
23 Make sure we never return a null string.
24 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
25 Added tests of the OnlineGlomProperties API, using our sample file.
27 2012-06-20 Murray Cumming <murrayc@murrayc.com>
29 Make OnlineGlomProperties be a normal class.
31 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
32 Move OnlineGlomProperties into its own file to be a regular class:
33 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
34 This makes testing simpler.
36 2012-06-15 Murray Cumming <murrayc@murrayc.com>
38 OnlineGlomServiceImpl.init(): Move some code into a new method.
40 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
43 2012-06-15 Murray Cumming <murrayc@murrayc.com>
45 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
47 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
48 OnlineGlomProperties.getKey(): Make this more robust by moving the
49 check for *.*.filename to here.
51 2012-06-15 Murray Cumming <murrayc@murrayc.com>
53 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
55 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
56 init(): Move knowledge of the config file format into the
57 OnlineGlomProperties inner class.
59 2012-06-15 Murray Cumming <murrayc@murrayc.com>
61 SelfHostExampleTest: Make sure we cleanup on failure.
63 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
64 the use of cleanup() to a tearDown() JUnit method.
66 2012-06-12 Murray Cumming <murrayc@murrayc.com>
68 ConfiguredDocument: Add a primary key to portals at least once.
70 * src/main/java/org/glom/web/server/ConfiguredDocument.java
71 updatePortalsExtras): Fix a typo so that we add the primary key
73 This is a fix for the previous commit:
74 ConfiguredDocument: Do not add a primary key to portals each time.
76 2012-06-08 Murray Cumming <murrayc@murrayc.com>
78 SelfHoster: Avoid some compiler warnings.
80 * src/test/java/org/glom/web/server/SelfHoster.java
81 executeCommandLineAndWait():
82 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
83 the now-unused streams for stdout and stderr from the command Processes.
84 These are not used because readln() hangs while waiting for a new line,
85 where there may be no next line. The commented out code is still there
86 to help us figure out how to do this properly.
88 2012-06-08 Murray Cumming <murrayc@murrayc.com>
90 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
92 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
93 Make this actually test the cloning again, though it is not very useful
94 now that we do not use the part that had a problem with cloning before.
96 2012-06-08 Murray Cumming <murrayc@murrayc.com>
98 SelfHoster: Keep trying pg_ctl after starting postgres.
100 * src/test/java/org/glom/web/server/SelfHoster.java
101 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
102 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
103 regular Glom. This seems mad but it seems to work because the first
104 command would fail if pg_ctl would eventually fail.
106 2012-06-08 Murray Cumming <murrayc@murrayc.com>
108 SelfHoster: Wait until the server is really ready.
110 * src/test/java/org/glom/web/server/SelfHoster.java
111 selfHost(): Attempt the connection after starting the server, retrying
112 a few times if necessary, so that the server is really ready already when
113 we return from this method.
114 The regular Glom code does this too because pg_ctl reports success too soon.
116 2012-06-08 Murray Cumming <murrayc@murrayc.com>
118 ConfiguredDocument: Do not add a primary key to portals each time.
120 * src/main/java/org/glom/web/server/ConfiguredDocument.java
121 updatePortalsExtras(): Only add an extra primary key field if there is
122 none, to avoid adding one each time we retrieve the details layout from the
124 This should fix bug #676986 (Ben Konrath)
126 2012-05-25 Murray Cumming <murrayc@murrayc.com>
128 Document.load(): Support version 7 documents.
130 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
131 database_title attribute if the title attribute is not there.
134 2012-05-24 Ben Konrath <ben@bagu.org>
136 Add configuration for auto-generating mvn:i18n from with Eclipse.
138 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
140 2012-05-24 Murray Cumming <murrayc@murrayc.com>
142 Update translations, adding French.
144 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
145 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
146 Add a French translation, using the translation from Glom.
148 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
149 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
150 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
151 Update these based on the translations from Glom.
153 2012-05-24 Murray Cumming <murrayc@murrayc.com>
155 SelfHoster: Add some debug println messages to help when things fail.
157 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
158 System.out.println() lines.
160 2012-05-23 Murray Cumming <murrayc@murrayc.com>
162 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
164 * src/test/java/org/glom/web/server/SelfHoster.java:
165 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
166 instance) instead of just /usr/bin (as on Fedora). Check the result when
169 2012-05-23 Murray Cumming <murrayc@murrayc.com>
171 Remove LayoutItemPortal.get/setNavigationTable().
173 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
174 Remove get/setNavigationTable(), which is only a cache, because it is not
175 used, and does not need to be used, because that decision should be made on
177 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
178 updatePortalsExtras():
179 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
180 getNavigationRecord():
181 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
184 2012-05-21 Murray Cumming <murrayc@murrayc.com>
186 Initial self-hosting for tests.
188 * pom.xml: Change the scope for log4j, to hopefully make it
189 available to the test code which uses it indirectly via jOOQ.
190 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
191 self-hosting, though we only use it for testing.
193 * src/main/java/org/glom/web/server/libglom/Document.java:
194 example rows: Use a map instead of a list for each row of values,
195 so we know what field they are for, instead of relying on the sequence
196 being correct. This is not very efficient, but it does not really need
198 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
199 testReadTableExampleRows(): Adapted.
201 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
202 that returns an Object, for generic use. Note that Object seems to be
203 the implicit base even of double.
204 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
205 for use in CREATE TABLE SQL queries.
206 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
207 to do self-hosting of PostgreSQL databases via its command-line
208 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
209 backends/postgres_self.cc. This is incomplete - it needs more
210 warnings about failures and it needs to clean up properly when things
212 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
213 test of this new class.
215 2012-05-21 Murray Cumming <murrayc@murrayc.com>
217 Document: loading example data: Handle exceptions.
219 * src/main/java/org/glom/web/server/libglom/Document.java:
220 DateFormat.parse() and Double.valueOf() can throw exceptions, though
221 Eclipse did not warn about that.
223 2012-05-20 Murray Cumming <murrayc@murrayc.com>
225 Document: load(), save(): Handle the example rows.
227 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
229 * src/main/java/org/glom/web/server/libglom/Document.java:
230 load(), save(): Load and save the example rows, though the date, time
231 and image types are not handled properly yet.
232 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
233 Add testReadTableExampleRows() just to check that something is read.
235 2012-05-20 Murray Cumming <murrayc@murrayc.com>
237 Document: Add save().
239 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
240 Added getTranslationsMap() for use while saving.
241 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
242 Adedd getUseDefaultFormatting() for use while saving.
243 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
244 and several private methods that it uses.
246 This will be useful while testing via self-hosting.
247 It is not complete, but should be complete enough for testing.
249 2012-05-17 Murray Cumming <murrayc@murrayc.com>
251 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
253 * src/main/java/org/glom/web/client/OnlineGlomService.java
254 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
256 Remove getSortedListViewData() and getSortedRelatedListData(), adding
257 the sort column index and ascending bool to the regular method.
258 Instead, a sort column index of -1 now means no sort.
259 This is less explicit, but it's fairly simple, reduces the amount of
260 code, and makes the OnlineGlomService API slightly smaller.
261 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
262 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
264 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
265 getListViewData(), getRelatedListData():
266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
267 getListViewData(), getRelatedListData():
268 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
270 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
272 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
277 2012-05-16 Murray Cumming <murrayc@murrayc.com>
279 Use translations for top-level groups too.
281 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
282 updateTitlesForLocale(): Use the translation for the group
283 as well as for child items.
287 Just recompiled to fix a problem in the released .tar.gz file.
291 2012-05-15 Murray Cumming <murrayc@murrayc.com>
293 Corrections to navigation to related records.
295 * src/main/java/org/glom/web/client/OnlineGlomService.java:
296 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
298 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
299 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
300 relationship name, because the relationship name is not necessarily unique
302 TOOD: This is inefficient, because it passes the whole list of
303 child field items back to the server, but it is more correct, and happens
304 to fix a bug with the primary key being lost after a few navigations.
305 There is probably a chance to make this more efficient anyway in some
308 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
309 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
310 * src/main/java/org/glom/web/server/ConfiguredDocument.java
311 * src/main/java/org/glom/web/server/database/DBAccess.java
312 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
313 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
316 2012-05-15 Murray Cumming <murrayc@murrayc.com>
318 Fix the use of translations.
320 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
321 Add updateTitlesForLocale().
322 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
323 Call it to discard unwanted translations and to make getTitle() return
324 the wanted translation wihout the need for the client code to specify a locale.
325 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
326 getTitle(): Fallback to the original title, as libglom does.
328 2012-05-15 Murray Cumming <murrayc@murrayc.com>
330 Document: Correctly report the number of available translation locales.
332 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
333 the available locale IDs list.
334 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
335 testLocales: Test this.
337 2012-05-15 Murray Cumming <murrayc@murrayc.com>
339 SqlUtils: Use camelCase.
341 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
342 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
343 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
344 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
345 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
346 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
348 2012-05-15 Murray Cumming <murrayc@murrayc.com>
350 Use jOOQ's tableByName() and fieldByName.
352 * pom.xml: Use jOOQ 2.3.1 to get the new API.
353 * src/main/java/org/glom/web/server/SqlUtils.java:
354 build_sql_select_step_with_where_clause(), .createField(),
355 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
356 so we can get correct quoting and escaping. Thanks to Lukas Eder for
357 adding this, and other things, to jOOQ.
359 2012-05-15 Murray Cumming <murrayc@murrayc.com>
361 SqlUtils: Remove the Connection parameters.
363 * src/main/java/org/glom/web/server/SqlUtils.java:
364 build_sql_select_with_key(), build_sql_select_with_where_clause(),
365 createSelect(), build_sql_select_step_with_where_clause(),
366 build_sql_count_select_with_where_clause(),
367 build_sql_select_count_rows(): Remove the Connection parameter because
368 jOOQ does not actually need a connectionwhen it is just used to build
370 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
372 * src/main/java/org/glom/web/server/ReportGenerator.java:
374 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
376 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
377 Constructor, getListData(), getResultSizeOfSQLQuery():
378 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
379 getSelectQuery(), getCountQuery():
380 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
381 getSelectQuery(), getCountQuery():
382 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
383 getNavigationRecord(): Adapted.
385 2012-05-14 Murray Cumming <murrayc@murrayc.com>
389 * src/main/java/org/glom/web/server/SqlUtils.java:
390 get_find_where_clause_quick(): Use a comparison of
391 lowercase values, instead of a simple equals. Regular Glom
392 uses the PostgreSQL ILIKE operator but jOOQ does not
393 support that just yet, though it will soon.
395 2012-05-14 Murray Cumming <murrayc@murrayc.com>
397 TableToViewDetails: Use a real serialization ID.
399 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
400 Though this does not fix the serialization problem.
402 2012-05-12 Murray Cumming <murrayc@murrayc.com>
404 Added LayoutItemPortalDeepCloneTest.
406 2012-05-11 Murray Cumming <murrayc@murrayc.com>
408 Make navigation work again.
410 * src/main/java/org/glom/web/server/libglom/Document.java:
411 Add getLayoutItemFieldShouldHaveNavigation().
412 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
413 Replace get/setAddNavigation() with the partly-existing
414 get/setNavigationTableName(), with an empty string being no navigation,
415 because this is simpler. Use the new
416 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
418 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
419 Add updateFieldsExtras() and call setNavigationTableName in it.
420 getDetailsLayoutGroup(),
421 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
422 createLayout(): Adapted.
423 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
424 Constructor: Adapted.
426 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
427 Replace get/setAddNavigation() with get/setNavigation(), returning a
428 TableToViewDetails class with both the table name and UsesRelationship,
429 because both are need. The previous code used java-libglom's output
430 variable (strangely, via sharedptr) to return both, but we cannot really
432 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
433 getNavigationRecord(): Adapt. However, we cannot actually use the cache
434 here because it somehow gets set to null during deepCopy(). I must test this.
435 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
436 testGetSuitableTableToViewDetails(): Adapted.
438 TODO: Find out why deepClone() is not quite working.
440 2012-05-11 Murray Cumming <murrayc@murrayc.com>
442 DBAccess: Simplify the retrievel of full field details.
444 * src/main/java/org/glom/web/server/database/DBAccess.java
445 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
446 because the Document loading should have done this.
448 2012-05-11 Murray Cumming <murrayc@murrayc.com>
450 Document: Correct loading of doubly-related layout fields.
452 * src/main/java/org/glom/web/server/libglom/Document.java:
453 loadUsesRelationship(): Actually set the related relationship, instead
454 of only setting it if it's not found.
456 2012-05-09 Murray Cumming <murrayc@murrayc.com>
458 Replace all appearances of Colour with color.
460 Because US English is dominant.
462 2012-05-09 Murray Cumming <murrayc@murrayc.com>
464 Use colors in HTML format, solving a warning about an unused function.
466 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
467 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
468 Add *asHTMLColor() versions of methods.
469 TODO: However, we should create and cache the results on the server.
470 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
471 * src/main/java/org/glom/web/client/ui/list/ListTable.java
472 * src/main/java/org/glom/web/server/ConfiguredDocument.java
473 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
474 Use the asHTMLcolor() versions.
476 2012-05-09 Murray Cumming <murrayc@murrayc.com>
478 ListViewTable: Constructor: Take the table name as a parameter.
480 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
481 Constructor: Take the tableName, and set the member variable, because
483 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
484 setCellTable(): Pass the table name.
485 This makes navigation to non-default tables work again. I don't know
486 why it worked before in the master branch.
488 2012-05-07 Murray Cumming <murrayc@murrayc.com>
490 ConfiguredDocument: Restore correct addition of hidden primary key items.
492 * src/main/java/org/glom/web/client/ui/list/ListTable.java
493 (ListTable.createCellTable): Uncomment out the check for the hidden
495 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
496 add primary key items for top-level lists and portals, as before,
497 instead of adding them to each group.
498 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
499 Actually implement the extra methods such as setHiddenPrimaryKey() and
500 comment that these are used only for top-level list groups and in portals.
501 This strangeness suggests even more that this should not be squeezed
502 into the LayoutGroup class.
504 2012-05-07 Murray Cumming <murrayc@murrayc.com>
506 Fix Formatting loading.
508 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
509 getFormattingUsed(): Remove the duplicate Formatting member variable
510 in favour of the one from the base class.
511 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
512 Initialize a new Formatting instead of using null by default, so we
513 have some defaults, instead of having to initialize one later just to
514 get the same defaults. This also makes loading of formatting from the
515 document work, because that expected a non-null.
517 2012-05-07 Murray Cumming <murrayc@murrayc.com>
519 RelatedListTable: Make sure that the tableName is set.
521 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
522 Constructor: Take the tableName so it is available later. Otherwise,
523 the server assumes that we mean the default table and cannot find the
525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
526 setData(): Pass the tableName to the RelatedListTable constructor.
528 2012-05-07 Murray Cumming <murrayc@murrayc.com>
532 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
533 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
534 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
536 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
538 * src/main/java/org/glom/web/server/database/DBAccess.java:
539 convertResultSetToDTO(), getPortal():
540 * src/main/java/org/glom/web/server/database/ListDBAccess.java
542 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
543 Add checks for null objects and out of range access, with log messages to
544 give hints so we can fix these properly.
546 2012-05-07 Murray Cumming <murrayc@murrayc.com>
548 Portals: some corrections.
550 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
552 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
553 constructor: Use getRelationshipNameUsed() instead of getName(), because
554 that is what is meant.
555 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
556 getFromField(): Fix a typo, to get the field name, not the table name.
557 * src/main/java/org/glom/web/server/database/DBAccess.java:
558 getPortal(): Fix a typo that stopped this from working.
560 2012-05-07 Murray Cumming <murrayc@murrayc.com>
562 LayoutItemPortal: Also override getTitleOriginal().
564 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
565 This lets the base getTitle() with no parameters work.
566 TODO: Test this properly.
568 2012-05-06 Murray Cumming <murrayc@murrayc.com>
570 LayoutItemPortal: getTitle*(): Use the relationship title.
572 2012-05-06 Murray Cumming <murrayc@murrayc.com>
574 LayoutItemField: Fix loading of custom titles.
576 * src/main/java/org/glom/web/server/libglom/Document.java
577 loadDataLayoutItemField(): The title, if any, instead of the field
578 title, is stored in a title_custom node. Load it from there.
579 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
581 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
582 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
583 getTitle*() overrides.
584 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
587 2012-05-06 Murray Cumming <murrayc@murrayc.com>
589 LayoutItemField: Fall back to field titles, so some are really shown.
591 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
592 Override getTitleOriginal() and getTitle(), as in java-libglom.
593 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
596 2012-05-06 Murray Cumming <murrayc@murrayc.com>
598 Correct use of setExpectedResultSize().
600 * src/main/java/org/glom/web/server/ConfiguredDocument.java
601 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
602 Use setExpectedResultSize only on top-level groups (for instance, the
603 list layout) or on child portals (in details views).
604 Use the correct table name for portals to avoid SQL errors.
605 Update the expected counts when returning cached layouts.
607 2012-05-06 Murray Cumming <murrayc@murrayc.com>
609 Document: Interpret no group column count as 1.
611 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
612 default, though we now check for this in the UI code anyway.
614 2012-05-06 Murray Cumming <murrayc@murrayc.com>
618 2012-05-06 Murray Cumming <murrayc@murrayc.com>
620 Translatable: Use Hashmap instead of Treemap because GWT supports it.
622 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
623 The use of Treemap lead to this error from async methods, with no
625 "The response could not be deserialized"
627 2012-05-06 Murray Cumming <murrayc@murrayc.com>
629 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
631 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
632 when using the Google -> GWT Compile, or
633 g toolbar button -> GWT Compile Project... feature in Eclipse.
635 2012-05-06 Murray Cumming <murrayc@murrayc.com>
637 ListTable.addColumn(): Protect against a null Formatting.
639 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
640 Create a default Formatting if it is null, because that is the simplest
643 2012-05-06 Murray Cumming <murrayc@murrayc.com>
645 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
647 * src/main/java/org/glom/web/server/ConfiguredDocument.java
648 updateLayoutGroup(): Check that the field is not null.
650 2012-05-06 Murray Cumming <murrayc@murrayc.com>
652 ListViewImpl: Protected against a bad cast error.
654 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
655 onEnterKeyDown(): Do not cast without an instanceof check.
657 2012-05-06 Murray Cumming <murrayc@murrayc.com>
659 ListTable: Protect against an out of range error.
661 * src/main/java/org/glom/web/client/ui/list/ListTable.java
662 createCellTable(): This is unlikely, but can happen while debugging.
664 2012-05-06 Murray Cumming <murrayc@murrayc.com>
666 AsyncMessage onFailure() callbacks: Log the exception message.
668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
669 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
670 * src/main/java/org/glom/web/client/activity/ListActivity.java:
671 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
672 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
673 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
674 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
675 These are useful clues when something is wrong.
677 2012-05-06 Murray Cumming <murrayc@murrayc.com>
679 ConfiguredDocument: Avoid a null dereference.
681 * src/main/java/org/glom/web/server/ConfiguredDocument.java
682 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
683 details maps are created.
685 2012-05-06 Murray Cumming <murrayc@murrayc.com>
687 Document: Correct the port number parsing.
689 * src/main/java/org/glom/web/server/libglom/Document.java:
690 This lets us actually connect to the database and show the document.
692 2012-05-05 Murray Cumming <murrayc@murrayc.com>
696 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
697 user-interaction, asking us to load a temporary URL in a browser.s
698 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
699 which is apparently necessary for testing the service. See the comment.
700 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
701 Show the exception, if any. This is how I saw the 404 in the HTML in
704 2012-05-05 Murray Cumming <murrayc@murrayc.com>
706 DocumentTest: Move the .glom files into the resources directory.
708 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
709 URI via getResource().
711 2012-05-05 Murray Cumming <murrayc@murrayc.com>
713 Document: Remove the FieldIdentifies inner class.
715 * src/main/java/org/glom/web/server/libglom/Document.java: We only
716 use the Relationship (though the same function in libglom is maybe
717 used in other ways) and so this removes a compiler warning.
719 2012-05-05 Murray Cumming <murrayc@murrayc.com>
721 Document.load() Remove the error code parameter.
723 * src/main/java/org/glom/web/server/libglom/Document.java: load():
724 Remove the parameter. We do not set it yet and it could never have
725 worked as an output parameter (though maybe it did in java-libglom).
726 We could use an exception if we really want the failure reason.
727 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
729 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
730 setUp(), testGetSuitableTableToViewDetails(): Adapt.
732 2012-05-05 Murray Cumming <murrayc@murrayc.com>
734 Make some inner classes static.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java
737 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
738 * src/main/java/org/glom/web/server/ReportGenerator.java
739 * src/main/java/org/glom/web/server/libglom/Document.java
740 Make all inner classes static that can be static.
742 2012-05-05 Murray Cumming <murrayc@murrayc.com>
744 OnlineGlomServiceImpl: Do not load and check for java-libglom.
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
747 init(): We do not use java-libglom any more.
749 2012-05-05 Murray Cumming <murrayc@murrayc.com>
751 Remove mentions of java-libglom.
753 * README: Remove mention of java-libglom, because it no longer needed.
754 * utils/build-onlineglom-war.sh:
755 * utils/check-and-recover-tomcat.py:
756 * utils/install-onlineglom-war.sh: Remove these as they are no longer
757 useful. Building is now far easier, with no need for jhbuild.
759 2012-05-05 Murray Cumming <murrayc@murrayc.com>
761 Fix the build (mvn package)
763 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
764 (LayoutGroup): Make the LayoutItemList inner class static and protected.
765 Otherwise the GWT Java->Javascript compilation fails with just this
766 error, during mvn package or when attempting to view in a browser,
767 in the GWT developer mode in Eclipse.
769 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
770 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
771 [INFO] Compiling module org.glom.web.OnlineGlom
772 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
773 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
774 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
775 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
776 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
777 [INFO] [ERROR] Cannot proceed due to previous errors
779 It has taken me 2 days to find out what was causing that. After reducing
780 the code, the compiler eventually showed me the full error message.
782 2012-05-04 Murray Cumming <murrayc@murrayc.com>
784 ConfiguredDocument: Cache the cloned and stripped layouts.
786 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
787 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
788 layout in a map, so we can retrieve it again without rebuilding it.
790 2012-05-04 Murray Cumming <murrayc@murrayc.com>
792 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
794 2012-05-04 Murray Cumming <murrayc@murrayc.com>
796 libglom classes: Implement some auto-generated emthods.
798 2012-05-04 Murray Cumming <murrayc@murrayc.com>
800 Add GwtTestOnlineGlomService.
802 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
803 However, this (and the other GwtTest*) does not seem to run during
806 2012-05-04 Murray Cumming <murrayc@murrayc.com>
808 Remove use of unsupported features from client code.
810 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
811 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
812 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
813 Use our client version of StringUtils instead of the apache commons one.
815 However, the GWT Javascript compliation still fails.
817 2012-04-25 Murray Cumming <murrayc@murrayc.com>
819 Add a Field class and implement some loading of it in Document.
821 2012-04-25 Murray Cumming <murrayc@murrayc.com>
823 Initial Document loading implementation, instead of libglom.
825 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
826 and Translatable classes, and adapt the rest of the code to use them.
827 However, this is still missing Layout and Field classes and loading.
829 2012-04-24 Murray Cumming <murrayc@murrayc.com>
831 Use of jOOQ: Move Field creation into a utility method.
833 * src/main/java/org/glom/web/server/SqlUtils.java:
834 This lets us improve it more easily.
836 2012-04-24 Murray Cumming <murrayc@murrayc.com>
838 Use of jOOQ: Improve the code to COUNT a sub-select.
840 * src/main/java/org/glom/web/server/SqlUtils.java:
841 Move initial query creation into
842 build_sql_select_step_with_where_clause().
843 build_sql_select_count_rows(): Use the jOOQ API instead of
844 concatentating text, because a jOOQ Select*Step is a TableLike,
845 which is what from() takes.
847 2012-04-23 Murray Cumming <murrayc@murrayc.com>
849 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
851 * pom.xml: Depend on jooq.
852 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
853 methods with jOOQ, based on the C++ implementations in libglom,
854 with some changes to the logic required by jooQ.
855 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
857 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
858 * src/main/java/org/glom/web/server/ReportGenerator.java:
859 * src/main/java/org/glom/web/server/SqlUtils.java:
860 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
861 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
862 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
863 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
864 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
865 Adapt. In particular, the SqlUtils methods now need to take a Connection,
866 because jOOQ needs that, though it seems unnecessary.
868 This is not quite finished. Ideally jOOQ would help us to build
869 table_name.field_name names, quoting and escaping them properly.
870 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
872 2012-04-21 Murray Cumming <murrayc@murrayc.com>
874 Move use of Glom.build_sql*() into a new SqlUtils class.
876 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
877 to wrap Glom.build_sql*(). The parameter types are still Glom one,
878 but this will make it easier to start using something other than
879 libglom or SqlBuilder.
881 2012-04-21 Murray Cumming <murrayc@murrayc.com>
883 Update the project URL.
885 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
887 2012-04-21 Murray Cumming <murrayc@murrayc.com>
889 Main layout: Use a FlowTable instead of absolute positioning.
891 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
892 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
893 child panels/widgets must have an absolute position. But that is annoying, so
894 this adds a FlowTable and puts the child panels in there.
896 2012-04-21 Murray Cumming <murrayc@murrayc.com>
898 GwtTestOnlineGlom: Comment out unused code.
900 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
901 Eclipse has started to say that some code is unused.
903 2012-04-21 Murray Cumming <murrayc@murrayc.com>
905 Update to the latest versions of dependencies.
907 * pom.xml: Update version numbers of dependencies to the latest
909 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
911 * src/main/java/org/glom/web/server/ReportGenerator.java:
912 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
913 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
914 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
916 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
917 Modify the imports where necessary.
919 2012-04-17 Murray Cumming <murrayc@murrayc.com>
921 Style: Remove overflow:hidden from searchbox
923 * src/main/webapp/style.css: Because this pushes the Back To Link
924 label/link on to the next row, which is then hidden due to the
925 hard-coded (in ems) height.
927 2012-04-20 Murray Cumming <murrayc@murrayc.com>
929 Remove some duplicate code.
931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
932 getDocumentInfo(): This must have been duplicated during the merge from the
937 2012-04-19 Murray Cumming <murrayc@murrayc.com>
939 Reports: Localize the waiting for report message.
941 * src/main/java/org/glom/web/client/activity/ReportActivity.java
942 start(): Get the message from the contants.
943 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
945 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
946 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
947 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
948 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
949 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
950 Update these files with the English text for newer strings for now.
952 2012-04-19 Murray Cumming <murrayc@murrayc.com>
954 Reports: Show a message while waiting for the report.
956 * src/main/java/org/glom/web/client/ui/ReportView.java
957 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
958 Add setWaitingText(), to show a message saying that we are
959 waiting for the report to be ready.
960 * src/main/java/org/glom/web/client/activity/ReportActivity.java
961 start(): Call setWaitingText() before calling the async
964 2012-04-19 Murray Cumming <murrayc@murrayc.com>
966 ReportGenerator: Specify date and time formats.
968 * src/main/java/org/glom/web/server/ReportGenerator.java:
969 createFieldValueElement(): Use the default (and localized)
970 short formats, though we still need a way to show 4-digit
971 years without providing the format for every locale.
972 * src/main/java/org/glom/web/server/database/DBAccess.java:
973 convertResultSetToDTO(): Use the short formats here too.
975 2012-04-18 Murray Cumming <murrayc@murrayc.com>
977 ReportGenerator: Use the correct numeric formatting.
979 * src/main/java/org/glom/web/server/ReportGenerator.java
980 createFieldExpression(), createFieldValueElement(): Take the
981 whole LayoutItem_Field instead of just the field name, so
982 we have access to the formatting.
983 createFieldValueElement(): Use JRTextField.setPattern() to
984 specify the numeric formatting, with the help of a
985 regular DecimalFormat.
987 2012-04-18 Murray Cumming <murrayc@murrayc.com>
989 ReportGenerator: Avoid showing null for group by titles.
991 * src/main/java/org/glom/web/server/ReportGenerator.java
992 generateReport(): Use setBlankWhenNull() on the field title
993 style too, because this is used for values in group by
996 2012-04-18 Murray Cumming <murrayc@murrayc.com>
998 ReportGenerator: Add a colon to titles in vertical groups.
1000 * src/main/java/org/glom/web/server/ReportGenerator.java
1001 addFieldToDetailBandVertical(): Pass true for the withColon
1004 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1006 ReportGenerator: Simplify the code by using Position more.
1008 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1010 Reports: Support vertical groups, roughly.
1012 * src/main/java/org/glom/web/server/ReportGenerator.java:
1013 addToReport(): Rename to addGroupToReport() and, if necessary,
1014 call the new addVerticalGroupToReport() method.
1015 createFieldValueElement(): Let the caller specify the Y position
1018 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1020 Reports: Allow a second report to be shown.
1022 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1023 clear(): Do not remove the HTML widget, which broke the whole layout.
1025 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1027 Locales drop-down: Show that we use English by default.
1029 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1030 fillView(): When we use English, just because that is the default, when
1031 no locale is specified, show that in the Locales drop-down instead of
1032 just showing the first item.
1034 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1036 Unselect the Report/Locale/Table combo item when appropriate.
1038 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1039 setPlace(): clear reportName if this is not a ReportPlace.
1040 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1041 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1042 When the provided name is empty, unselect all items, so that none are
1043 indicated. This uses a for loop because I cannot find a single method
1046 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1048 Report: Give the user a way to get back to the list.
1050 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1051 start(), setPlace(): Show the Back To List link on reports, and also
1052 interpret selecting the empty report item as back to list.
1054 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1056 Really show the selected Report name.
1058 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1059 setPlace(): Store the reportName here, if it is that kind of Place.
1060 fillView(): Set the selected Report after filling the list of reports.
1061 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1062 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1063 null Strings, though we need some way to unselect all ListBox items
1066 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1068 ReportGenerator: Try to avoid some problems.
1070 * src/main/java/org/glom/web/server/ReportGenerator.java
1071 addField(): Try to avoid duplicates, and avoid using a null
1074 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1076 Reports: Use quickFind.
1078 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1079 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1080 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1081 getReportHTML(): Add a quickFind parameter.
1082 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1083 start(): Pass the quickFind parameter.
1084 * src/main/java/org/glom/web/server/ReportGenerator.java
1085 generateReport(): Take a quickFind parameter.
1087 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1089 ReportPlace: Actually use the report name.
1091 * src/main/java/org/glom/web/client/place/ReportPlace.java
1092 getPlace(): Do not assign the report name to the quickfind.
1094 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1096 Show java.library.path when complaining.
1098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1099 init(): When telling us to check java.library.path, show the
1102 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1104 ReportGenerator: Do not show nulls.
1106 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1108 ReportGenerator: Make the title font larger.
1110 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1112 ReportGenerator: Put field titles inside groups, if there are groups.
1114 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1116 ReportGenerator: Take the Report itself instead of the name and group.
1118 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1119 Remove getReportLayoutGroup().
1120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1121 getReportHTML(): Pass the report instead
1122 of its name and layout group.
1123 * src/main/java/org/glom/web/server/ReportGenerator.java
1124 generateReport(): Use the report object to use the title
1125 instead of the name.
1127 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1129 ReportGenerator: Remove designBand parameters.
1131 * src/main/java/org/glom/web/server/ReportGenerator.java:
1132 Make designBand a class member instead of passing it to all
1135 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1137 ReportGenerator: Add lines, a bit like in the desktop version.
1139 * src/main/java/org/glom/web/server/ReportGenerator.java
1140 addToReport(): Use JRDesignLine.
1142 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1144 ReportGenerator: Correct the title positions and use some bold style.
1146 * src/main/java/org/glom/web/server/ReportGenerator.java:
1147 Break the code up into reusable functions, correct the placement of
1148 titles, and use normal/bold styles as in the reports in the desktop
1151 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1153 ReportGenerator: Add a header band to show the field titles.
1155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1156 getReportHTML(): Pass the localeId to the ReportGenerator
1158 * src/main/java/org/glom/web/server/ReportGenerator.java
1159 constructor: Take the localeID so we can get translated field
1161 generateReport(), addToReport(), addFieldToBand(): Add field
1162 titles in a column header band.
1164 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1166 Reports drop-down list: Some improvement.
1168 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1169 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1170 Adedd setSelectedReport(),
1171 setReportList(): Add a blank line so that the user can select the
1173 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1174 start(): Show the current report by calling setSelectedReport().
1175 This does not seem to work yet.
1177 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1179 DetailsActivity, ListActivity: Move some variables into a base class.
1181 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1182 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1183 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1184 the clientFactory, documentID, tableName and authenticationPopup into
1185 a base class, to avoid duplication.
1187 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1189 Translate the Reports label.
1191 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1192 Get the "Reports" label string from the constants.
1193 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1194 perties: Add Reports to the constants.
1196 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1198 Reports: Implement grouping.
1200 * src/main/java/org/glom/web/server/ReportGenerator.java:
1201 Handle LayoutItem_GroupBy items and try to do the right thing
1202 with JRDesignGroup. It seems to work.
1204 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1206 Actually show some data with JasperReports.
1208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1209 getReportHTML(): Move most code into a ReportGenerator class.
1210 * src/main/java/org/glom/web/server/ReportGenerator.java:
1211 Recurse into sub-groups, adding fields to the JasperDesign's details
1212 band. Note that we must set an arbitrary width and height, or it just
1213 will not show any data.
1215 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1217 Reports Chooser: Show the titles, not the names.
1219 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1220 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1221 and the names as the values.
1222 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1223 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1224 group now that we provide the report name, so it should always
1227 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1229 Depend on jasperreports.
1231 * pom.xml: Add the dependency. My plan is to use this on the
1234 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1236 Implement navigation to report places.
1238 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1239 start(): Do not bother to handle all events here.
1240 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1241 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1242 Added getSelectedReport().
1243 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1244 .java: start(): When handling a change to the reports chooser,
1245 call getSelectedReport() and goTo() its ReportPlace.
1246 * src/main/java/org/glom/web/client/ui/ReportView.java
1247 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1248 Added setReportHTML() which puts the html in a gwt HTML widget.
1249 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1250 getReportHTML(): Return "TODO" just to show that this works.
1252 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1254 Make ReportPlace usable.
1256 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1257 Mention ReportPlace.
1258 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1259 Correct the @prefix annotation.
1261 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1263 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1265 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1266 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1267 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1268 Change getReportLayout() to getReportHMTL() because we will not need to
1269 parse or render the report layout on the client side.
1270 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1271 getReportLayout(): Return the libglom LayoutGroup type because we will
1272 not need to convert to a shared type, because this will not be used on
1274 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1277 Note that there is still no implementation for this.
1280 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1282 Add a (empty) Report Place, View, and Activity.
1284 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1286 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1287 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1288 this into a superclass:
1289 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1290 and also use it as the base of this new ReportPlace:
1291 * src/main/java/org/glom/web/client/place/ReportPlace.java
1293 * src/main/java/org/glom/web/client/ui/ReportView.java
1294 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1295 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1296 Add these, containing mostly boiler-plate for now.
1298 * src/main/java/org/glom/web/client/OnlineGlomService.java
1299 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1300 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1301 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1302 Add API to get the LayoutGroup for the report.
1304 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1306 Add and fill a Reports drop-down list box.
1308 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1310 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1311 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1313 Added getReports(document, table, localeID), calling
1314 ConfiguredDocument.getReports().
1315 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1316 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1317 Added setReportsList() and a list widget.
1318 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1319 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1324 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1326 Translations: Add Esperanto.
1328 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1329 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1330 properties: Add this translation because someone took the time to make it.
1332 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1334 Adapt to the java-libglom 1.21.7 API.
1336 * src/main/java/org/glom/web/server/ReportGenerator.java:
1337 addToReport(): get_group_secondary_fields() is now
1338 get_secondary_fields().
1341 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1343 Use the latest java-libglom version.
1345 * pom.xml: Use java-libglom 1.21.7.
1347 2012-03-03 Ben Konrath <ben@bagu.org>
1349 Display date and time in details view.
1351 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1353 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1355 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1357 Require the latest java-libglom.
1359 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1361 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1363 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1365 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1366 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1367 an empty quickfind string. I also corrected libglom to create only
1368 empty where clauses for empty quickfind strings, but this avoids the
1371 2012-02-24 Ben Konrath <ben@bagu.org>
1373 Improve the tabs in the Notebook widget.
1377 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1379 Translations: Try to translate the strings.
1381 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1382 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1383 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1384 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1385 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1386 Take the Open translation from GTK+'s .po files.
1387 Take the Details translation from Glom's po files.
1388 I have added the other strings to Glom so we can get translations that way:
1389 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1391 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1393 TableSelectionViewImpl: Put the search label and entry in a div.
1395 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1396 Put the search widgets in a FlowTable so that the CSS can be used to
1397 style them while keeping them together.
1398 * src/main/webapp/style.css: Mention the new div.
1400 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1402 Translate more strings in more locales.
1404 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1405 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1406 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1407 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1408 Translate the "Details" and "Open" string too.
1410 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1411 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1412 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1413 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1414 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1415 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1416 Add these new locales as placeholders though they currently contain English.
1418 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1420 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1423 Check the ConfiguredDocument* for null before using it.
1425 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1427 Tell Eclipse about the generated java files.
1429 * .classpath: This lets it find OnlineGlomConstants.java.
1430 It would be nice if Eclipse just used the maven build files.
1432 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1434 Prevent a crash when no locale is specified in the URL.
1436 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1437 Avoid returning a null string, obtained from
1438 Window.Location.getParameter(). This caused a crash when it was
1439 later passed to libglom's API.
1440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1441 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1442 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1443 guard against future null strings.
1445 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1447 Use the ?locale= query param instead of the &lang= token param.
1449 * src/main/java/org/glom/web/client/place/ListPlace.java
1450 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1451 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1452 Remove the lang token key and value.
1454 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1455 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1456 When the user selects a different locale from the chooser, use
1457 Window.Location.assign() to change the URL, which then causes a reload.
1459 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1460 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1461 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1462 * src/main/java/org/glom/web/client/activity/ListActivity.java
1463 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1464 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1465 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1466 * src/main/java/org/glom/web/client/ui/ListView.java:
1467 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1469 Remove localeID member variables and method/constructor parameters, instead
1470 using Utils.getCurrentLocaleID() when we need a localID to pass to
1473 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1475 Internationalize the UI strings.
1477 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1478 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1479 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1480 because it is unused. Messages are apparently strings that can have
1481 parameters, but we do not need that yet, so Contants will be enough for now.
1482 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1483 to say that we support the en and de locales.
1484 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1485 The original English strings.
1486 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1487 Some German translations of the English strings.
1488 The i18n goal then uses the .properties file to generate an
1489 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1490 returns an implementation that returns the translated strings.
1491 The documentation suggests putting these in src/java/*/client/, but it seems
1492 best to put it in src/resources/*/client/.
1493 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1494 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1495 instead of hard-coding them.
1496 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1497 but that does not seem to stop the build, though it confuses Eclipse.
1499 You can see the translated string by adding ?locale=de to the URL, like so:
1500 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1502 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1504 Improve null/empty String checks.
1506 * pom.xml: Add a dependency on commons-lang, to use
1507 org.apache.commons.lang.StringUtils.
1508 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1509 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1510 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1511 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1512 Use StringUtils.isEmpty().
1514 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1515 StringUtils class with a static isEmpty() function because we
1516 cannot use org.apache.commons.lang.StringUtils in client-side
1517 GWT code because it (apparently) cannot be compiled to javascript.
1518 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1519 * src/main/java/org/glom/web/client/activity/ListActivity.java
1520 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1521 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1522 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1523 * src/main/java/org/glom/web/client/place/ListPlace.java
1524 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1525 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1526 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1527 * src/main/java/org/glom/web/client/ui/details/Group.java
1528 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1529 our StringUtils.isEmpty() function.
1531 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1533 Update to the latest java-libglom API.
1535 * pom.xml: Require java-libglom 1.21.4.
1536 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1537 getDocumentInfo(), getListViewLayoutGroup():
1538 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1540 * src/main/java/org/glom/web/server/database/DBAccess.java
1541 getFieldsToShowForSQLQueryAddGroup(),
1542 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1543 with either get_database_title_original() or
1544 get_database_title(localeID).
1546 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1548 ConfiguredDocument: Avoid a null pointer exception.
1550 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1551 Initialize localeID to "" to avoid returning a null String which
1552 causes a crash in java-libglom's swing-generated code.
1554 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1556 Some simple renaming.
1558 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1559 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1560 for localeChooser. This seems more appropriate and is less ambiguous
1561 particularly in the .css file.
1563 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1565 ConfiguredDocument: Rename the localedID private member variable.
1567 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1569 Adapt to the latest java-libglom API from git master.
1571 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1572 libglom now uses only Vector instead of List, which uses add() instead of
1575 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1577 ConfiguredDocument: Rename the localedID private member variable.
1579 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1581 Build a source tarball with mvn assembly:single
1583 * assembly.xml: Add this file.
1584 * pom.xml: Use the maven-assembly-plugin and tell it to use
1585 our assembly.xml file.
1587 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1589 OnlineGlomServiceImpl: Get .glom files recursively.
1591 * pom.xml: Depend on commons-io from org.apache.commons.
1592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1593 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1594 files recursively, and with the easier filter for the extension.
1595 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1596 simplify that code too.
1598 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1600 README: Mention that you must install java-libglom packages separately.
1602 But then it works, because java-libglom is now in the central maven
1605 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1607 locales drop-down: Show the correct selected locale when the URL changes.
1609 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1610 .java: setPlace(): Move some code into fillView().
1612 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1614 locales drop-down: Do not lose the primary key.
1616 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1617 start(): onLocaleChange(): Pass the current primary key value,
1618 instead of an empty value.
1620 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1622 locales drop-down: Do not lose the drop-down selection.
1624 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1625 .java (TableSelectionActivity.fillView): Set the selected locale
1626 after changing the drop-down items (though we do not really need
1627 to change them just because the locale changes.)
1629 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1631 locales drop-down: Change the tables list when this changes.
1633 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1634 .java: TableSelectionActivity.start(): Move the async table titles
1635 retrieval into a private fillView() method and also call this when
1636 the chosen locale changes.
1637 Note that the document title is not actually translatable yet, but
1638 that is a problem that I should fix soon in libglom.
1640 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1642 Improve the placement of the locales drop-down.
1644 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1645 Put the title and locales drop-down in a div (gwt.FlowTable).
1646 * src/main/webapp/style.css: Add magic css properties to make this work.
1647 Also remove the left margin from the title so that it lines up with the
1650 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1652 locales selector: Show human-readable locale titles.
1654 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1655 getDocumentInfo(): Use java.util.Locale to show a real title of
1656 each locale, in the locale's own language.
1658 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1660 Add a language/locale selector drop-down.
1662 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1663 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1664 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1665 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1666 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1667 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1668 Add a ListBox to show the available locales. Add getLocaleSelector(),
1669 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1670 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1671 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1672 java: Add these classes.
1673 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1674 start(): Fill the locales ListBox. Handle its change event, firing a
1676 setPlace(): Show the selected locale as specified by the URL token.
1677 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1678 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1679 Handle LocaleChangeEvent, going to a new *Place with that locale.
1681 The placement of the ListBox is not pretty, and it currently uses the ID
1682 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1686 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1688 Search box: Show the search text from the URL token.
1690 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1691 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1692 Add setQuickFindText().
1693 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1694 .java: setPlace(): Store the queryText if the place is a ListPlace,
1695 and call TableSelectionView.setQuickFindText().
1697 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1699 Allow use of translations via, for instance, &lang=de in the URL.
1701 * pom.xml: Use the unstable java-libglom 1.21 version.
1703 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1704 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1705 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1706 init(): Instead of calling TranslatableItem.set_current_locale()
1707 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1708 However, this is only for default locales, which are not needed to
1709 change the locale in the URL.
1710 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1711 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1712 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1713 layout for a particular locale.
1714 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1715 Add get/setDefaultLocaleID().
1716 getDocumentInfo(), getListViewData(), getRelatedListData(),
1717 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1718 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1719 localeID parameter, so we can get the layout for a particular locale.
1721 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1722 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1723 * src/main/java/org/glom/web/client/place/ListPlace.java:
1724 Parse and construct a lang parameter too.
1726 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1727 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1728 passed to subsequent methods and constructors.
1729 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1730 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1731 Store the localeID from the *Place and pass it to other constructors
1732 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1734 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1735 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1736 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1737 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1738 * src/main/java/org/glom/web/client/ui/ListView.java:
1739 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1740 Take localeID parameters and pass them to subsequent constructors and
1741 methods, so that the layout is always retrieved for that locale.
1743 This is rather repetitive.
1745 Note that "" means the original (default) locale of the Glom document,
1746 which is usually English.
1748 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1750 Documents: Remove final keyword to fix startup configuration.
1752 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1753 final keywords on the private member variables because that breaks
1754 the startup, apparently (there are warnings) because it stops them
1755 from being serialized. I added these in the previous commit.
1757 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1759 Documents: Add some final keywords.
1761 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1764 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1766 OnlineGlomServiceImpl: Add to overview comments.
1768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1769 Note that this is where all the document are loaded. They are not
1770 loaded freshly for each page.
1772 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1776 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1777 Add a TextBox for the text of a quick find.
1778 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1780 setBackLink(): Add a String quickFind parameter.
1781 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1782 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1783 to the base interface, because that is how TableSelectionViewImpl is used.
1784 * src/main/webapp/style.css: Add style for the search box and its label.
1786 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1787 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1788 Add these files, based on the existing TableChangeEvent and
1789 TableChangeEventHandlers.
1790 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1791 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1792 a ListPlace() that the user should be taken to.
1793 * src/main/java/org/glom/web/client/activity/ListActivity.java
1794 start(): Handle it here too and adapt the TableChangeEvent handler to
1795 pass the extra "" quickFind parameter to ListPlace.
1796 * src/main/java/org/glom/web/client/place/ListPlace.java:
1797 Constructor: Take an extra String quickFind parameter and store it,
1798 returning it from a new getQuickFind() method.
1799 getToken(): Put the quickFind text in the URL token.
1800 getPlace(): Parse the quickFind text from the URL token.
1801 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1802 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1803 ListPlace constructor.
1804 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1805 .java: start(): Add a Change handler for the TableSelectionView's
1806 TextBox (via its base HasChangeHandlers interface), firing the new
1807 QuickFindChangeEvent.
1808 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1809 pass the extra "" quickFind parameter.
1811 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1812 setCellTable(): Add a String quickFind parameter and pass it to
1813 the ListViewTable() constructor.
1814 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1815 setCellTable() in the base interface, because that is how ListViewImpl
1818 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1819 Add a String quickFind member variable.
1820 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1821 Constructor: Add a String quickFind parameter, storing it in the
1822 base ListTable's member variable.
1823 onRangeChanged(): Pass quickFind to the
1824 OnlineGlomServiceAsync.getSortedListViewData() and
1825 OnlineGlomServiceAsync.getListViewData() methods.
1827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1828 getListViewData(), getSortedListViewData(): Add a String quickFind
1829 parameter, passing it to ConfiguredDocument.getListViewData().
1830 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1831 Change getListViewData(), getSortedListViewData() in the base interface,
1832 because that is how OnlineGlomServiceImpl is used, via this:
1833 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1834 Change getListViewData(), getSortedListViewData() here too.
1835 This class can apparently be used to asynchronously call methods on
1836 OnlineGlomService, and GWT seems to implement that after recognizing
1837 just the *Async name convention and the extra AsyncCallback parameters.
1839 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1840 getListViewData(): Add a String quickFind parameter, and pass it to
1841 ListViewDBAccess.getData().
1842 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1843 getListData(): Add a String quickFind parameter and pass it to
1845 getSelectQuery(): Add a String quickFind parameter.
1846 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1847 getSelectQuery(): Add a String quickFind parameter and use it with
1848 Glom.get_find_where_clause_quick() to pass a where_clause to
1849 Glom.build_sql_select_with_where_clause(), to actually filter the
1851 getData(): Add a String quickFind parameter, passing it to getListData().
1852 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1853 va: getData(): Pass an empty string to getListData() for the
1854 quickFind parameter.
1856 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1858 ListTable: Minor change.
1860 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1861 createCellTable(): Make this protected instead of public.
1863 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1865 Many files: Use final for the parameters and use the @override attribute.
1867 2012-01-22 Ben Konrath <ben@bagu.org>
1869 Add anchor links for single line text that starts with http, ftp and www.
1873 2012-01-22 Ben Konrath <ben@bagu.org>
1875 Add ellipsis to single line text in details view.
1879 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1881 Remove all javadoc author tags.
1883 Because they are awkward and meaningless when many people touch
1885 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1887 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1889 Revert the COPYING.LESSER to COPYING rename.
1891 Apparently both should be there if it is LGPL.
1893 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1895 *View: Remove unused imports.
1897 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1898 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1899 * src/main/java/org/glom/web/client/ui/ListView.java:
1900 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1901 Remove unused imports, as suggested by Eclipse.
1903 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1905 Move the *View::Presenter types, and some API into one base View.
1907 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1908 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1909 * src/main/java/org/glom/web/client/ui/ListView.java:
1910 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1911 Presenter, setPresenter() and clear() into a shared base interface,
1912 to avoid the unnecessary duplicate Presenter types and to more clearly
1913 show how the *Views share the same structure, even if they are not
1914 used polymorphically.
1916 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1917 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1920 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1921 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1923 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1926 Feel free to revert this if there is a good reason for the duplicate
1929 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1931 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1933 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1934 a class member instead of a local variable in the method.
1935 This lets us use it to get the view instances, for use in tests.
1936 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1937 beforeOnlineGlom(): Test some more details of the initial view.
1938 Again, this is not very useful.
1940 To really test gwt-glom we will need to start a local postgresql
1941 instance with local data, like the Glom tests in C++.
1943 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1945 pom.xml: Mention the LGPL license.
1947 * pom.xml: Add a licenses section.
1948 * COPYING.LESSER: Move this to COPYING, which
1949 previously contained the GPL. But gwt-glom is all LGPL.
1951 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1953 Add project information to README and pom.xml.
1955 * README: Add a brief description and mention some mvn
1957 * pom.xml: This extra information shows up in mvn site
1960 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1962 Use the latest java-libglom version.
1964 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1966 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1968 GwtTestOnlineGlom: Test a little more.
1970 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1971 protected rather than private, as suggested by the gwt-test-utils
1973 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1974 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1975 Test the initial visibility of the panels.
1977 However, this is not a very useful test.
1978 And I wonder how we should generally test using this idea for an
1979 activity/places app like ours where the real changes happen implicitly
1980 based on the history token/URL.
1982 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1984 Slight modification to *Mapper comments.
1986 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1987 (DataActivityMapper)
1988 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1990 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1992 Remove comments mentioning GIN because they are just copied from
1993 the example code and are apparently not helpful:
1994 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1995 Also change the mention of a class that is only in the example code.
1997 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1999 GwtTestOnlineGlom test: Minor changes.
2001 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2002 Avoid the long qualified class name and modify the comment
2003 because it is now obvious to me that the mocked class is the only
2004 custom one created via GWT.create().
2006 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2008 Tests: Added the beginnings of a test using gwt-test-utils.
2010 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2011 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2012 which tells gwt-test-utils what class will be tested.
2013 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2014 Add a simple (but empty) test case. One class, used by the OnlineGlom
2015 class, is mocked so that it can be created. However, I am not sure
2016 why only this class needs to be mocked.
2018 Note that mockito seems more popular, and clearer, than easymock,
2019 but I have not got that working yet. It might be a matter of the
2022 This test is run during mvn integration-test.
2024 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2026 Tests: Use junit4-style syntax instead of junit3-style.
2028 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2029 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2030 * src/test/java/org/glom/web/shared/DataItemTest.java:
2031 Use the @Test annotation rather than relying on the test*() prefix.
2032 Also no longer implement TestCase, to avoid triggering support for
2033 the junit3-way, which stops the annotations from working.
2034 Change the imports from import junit.framework.* to
2035 import org.junit.*, which is apparently the new way.
2037 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2039 Added a test for ListPlace token parsing and creation.
2041 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2042 This is much the same as DetailsPlaceTest.
2044 I wonder how we could test the other parts of the *Place API.
2046 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2048 DetailsPlace test: Also test getToken() and recreation via getPlace().
2050 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2051 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2052 recreate it, testing the recreated DetailsPlace for the same parameter
2055 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2057 Use the surefire-report plugin.
2059 * pom.xml: This generates a HTML report about the tests in
2060 target/site/surefire-report.html
2061 when you do mvn surefire-report:report. It seems to be popular/normal.
2063 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2065 Added a test for DetailsPlace.
2067 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2068 Test the getPlace() token parsing.
2070 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2072 Added a first unit test.
2074 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2075 * src/test/java/org/glom/web/shared/DataItemTest.java:
2076 This is a silly test but it is just to get things started. Note that
2077 maven/junit finds the test because it looks in src/test by default.
2079 2011-12-22 Ben Konrath <ben@bagu.org>
2081 Change charsetName to "UTF-8" when replacing line breaks.
2083 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2084 that work in Java (such as "UTF8") will not work when compiled to
2087 This fixes a problem with multi-line details view fields that have hard
2088 line breaks. The "License Text" field on this page demonstrates the
2091 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2093 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2095 2011-12-22 Ben Konrath <ben@bagu.org>
2097 Fix another bug with related list navigation.
2099 I've tested all the navigation buttons in all of the related lists
2100 so things should be good now.
2102 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2104 2011-12-22 Ben Konrath <ben@bagu.org>
2106 Fix a crasher when refreshing the list view with the default table.
2108 This crash will also happen when loading the list view with the default
2109 table from a link or bookmark.
2111 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2112 to the main document selection page when the document id hasn't been
2114 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2115 the main document selection page when the document id hasn't been
2117 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2118 values for the details place when the document id hasn't been set.
2119 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2120 values for the list place when the document id hasn't been set.
2122 2011-12-21 Ben Konrath <ben@bagu.org>
2124 Protect against NPE when glom.document.locale is not in config.
2126 This patch protects against an NPE when glom.document.locale is not in
2127 the config file. This NPE will also happen if glom.document.locale is
2130 The patch also updates the error message to display the class name when
2131 the getMessage() returns null. This was happening when the NPE was
2132 thrown and I had "Configuration Error: null". If an NPE is encountered
2133 with this patch, "Configuration Error: NullPointerException " will be
2136 This commit closes this bug:
2138 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2142 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2144 Rename onlineglom.properties to onlineglom.properties.sample.
2146 * src/main/resources/onlineglom.properties: Rename to:
2147 * src/main/resources/onlineglom.properties.sample:
2148 * src/main/resources/README: And add this file explaining that people
2149 should rename it back when deploying.
2151 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2153 Allow choosing the translation in the .properties file.
2155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2156 init(): Read a glom.document.locale value from the configuration file
2157 and call Glom's TransatableItem::set_current_locale() method.
2158 * src/main/resources/onlineglom.properties: Add a commented-out
2159 example of this new setting.
2161 It would be better to add &lang=de_DE to the URL, but the current
2162 libglom API does not allow us to do this easily. I am working on that.
2164 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2166 Avoid a crash in parsing of token parameters.
2168 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2169 ava: getTokenParams(): Do not crash if a parameter has a key but no
2170 value, and ignore parameters with neither.
2172 2011-12-17 Murray Cumming <murrayc@murayc.com>
2174 History token building/handling: Improve use of token parameters.
2176 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2177 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2178 and buildParamsToken(HashMap), for use by derived classes.
2179 Make the separator private because it is no longer be needed.
2180 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2181 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2182 instead of manual string concatenation.
2183 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2184 of hardcoded indices and awkward splitting code.
2185 * src/main/java/org/glom/web/client/place/ListPlace.java
2186 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2187 instead of manual string concatenation.
2188 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2189 of hardcoded indices and awkward splitting code.
2190 This should fix bug #666420
2192 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2194 Fix a Navgiation->Navigation typo in the code.
2196 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2197 Rename processNavgiation() to processNavigation().
2199 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2201 Fix a seperator->separator typo in the code.
2203 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2204 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2205 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2208 2011-12-15 Ben Konrath <ben@bagu.org>
2210 Cleanup some comments.
2212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2214 2011-12-14 Ben Konrath <ben@bagu.org>
2216 Replace \n with <br/> for multiline text in the details view.
2218 Vertical scrollbars are added when needed as well.
2220 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2222 2011-12-14 Ben Konrath <ben@bagu.org>
2224 Specify the font for document selection links.
2226 * src/main/webapp/style.css:
2228 2011-12-14 Ben Konrath <ben@bagu.org>
2230 Fix bouncy CellTable while paging.
2232 This doesn't currently work with related list tables in unselected
2235 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2237 2011-12-14 Ben Konrath <ben@bagu.org>
2239 Revamp the appearance of the document selection page.
2241 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2242 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2243 * src/main/webapp/style.css:
2245 2011-12-13 Ben Konrath <ben@bagu.org>
2247 Set navigation button column to the smallest size possible.
2249 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2251 2011-12-13 Ben Konrath <ben@bagu.org>
2253 Change OpenButton nomenclature to NavigationButton.
2255 Using NavigtionButton makes things more generic. Classes, methods and
2256 variables have been changed.
2258 This is a rename-only refactor.
2260 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2261 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2262 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2263 Renamed from OpenButtonCell.
2264 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2265 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2266 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2268 2011-12-12 Ben Konrath <ben@bagu.org>
2270 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2272 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2273 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2274 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2275 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2277 2011-12-12 Ben Konrath <ben@bagu.org>
2279 Update variable names and comments.
2281 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2282 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2284 2011-12-12 Ben Konrath <ben@bagu.org>
2286 Properly initialize numNonEmptyRows variable to zero.
2288 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2289 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2291 2011-12-05 Ben Konrath <ben@bagu.org>
2293 Add latest mockup with HTML tables.
2295 Features of this mockup:
2297 -> HTML table for flowtable
2298 -> HTML table for flowtable column
2299 -> Example of how related lists would look
2300 -> Not using text entries for data items
2302 The current version of Online Glom doesn't use HTML tables for the
2305 This mockup has been sent to the glom-devel mailing list but it's good
2306 to have it here as well.
2308 * mockups/details-view-html-tables.html:
2310 2011-12-05 Ben Konrath <ben@bagu.org>
2312 Remove unnecessary getPrimaryKeyField() method.
2314 getPrimaryKeyFieldForTable(String) has been renamed to
2315 getPrimaryKeyField(String).
2317 * src/main/java/org/glom/web/server/database/DBAccess.java:
2318 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2319 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2321 2011-12-05 Ben Konrath <ben@bagu.org>
2323 Add string representation of TypedDataItem value to conversion error message.
2325 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2326 message was extracted into its own method to avoid duplication.
2328 2011-12-05 Ben Konrath <ben@bagu.org>
2330 Add type checking to navigation primary key value creation.
2332 Create navigation primary key only if the expected type from the Glom
2333 document matches the type returned by the SQL query.
2335 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2337 2011-12-05 Ben Konrath <ben@bagu.org>
2339 Rename a couple of variables in RelatedListNavigation.
2341 This is a rename-only refactor.
2343 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2345 2011-12-05 Ben Konrath <ben@bagu.org>
2347 Move getListLayoutGroup() into getListViewLayoutGroup().
2349 This removes getListLayoutGroup(). It was only being called by
2350 getListViewLayoutGroup().
2352 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2354 2011-12-05 Ben Konrath <ben@bagu.org>
2356 Remove check for LayoutItem_Portal in list table method.
2358 This check is no longer necessary because the method isn't being used
2359 to create the LayoutItemPortal DTO.
2361 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2363 2011-12-05 Ben Konrath <ben@bagu.org>
2365 Properly support related list navigation.
2367 Navigation from the "Repository Analyzer -> Package Scans ->
2368 Dependencies" related table wasn't working because the primary key for
2369 related tables wasn't being set properly. This commit fixes the
2372 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2373 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2374 doesn't set the primary key properly for related list tables.
2375 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2376 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2377 useful for getting the primary key for list view tables and for related
2379 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2380 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2381 Move code to set the primary key for the table from the abstract
2382 ListDBAccess class to ListViewDBAccess as it's only correct for list
2384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2385 Properly add primary key to related list tables.
2387 2011-12-02 Ben Konrath <ben@bagu.org>
2389 Properly set the horizontal alignment of fields.
2391 This fix is for both the list tables and the details view.
2393 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2394 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2395 to set the horizontal alignment of fields.
2397 2011-12-02 Ben Konrath <ben@bagu.org>
2399 Display currency codes in the details view.
2401 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2403 2011-12-02 Ben Konrath <ben@bagu.org>
2405 Avoid duplicate JNI call.
2407 JNI is not as efficient as pure Java and this is an easy (and small)
2410 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2411 Use previously retrieved value for whereClauseToTableName instead of
2414 2011-12-02 Ben Konrath <ben@bagu.org>
2416 Rename a couple of variables in RelatedListNavigation.
2418 This is a rename-only refactor.
2420 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2422 2011-12-02 Ben Konrath <ben@bagu.org>
2424 Indicate clearly that a mismatched primary key type is a bug.
2426 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2427 warning to error. Add 'This is a bug.' to message.
2429 2011-12-02 Ben Konrath <ben@bagu.org>
2431 Update / fix some comments.
2433 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2435 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2437 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2438 Fix comments. Add some TODOs.
2440 2011-12-02 Ben Konrath <ben@bagu.org>
2442 Enable navigation to details view with string primary key from related list.
2444 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2445 Create a text primary key value when return type of result is
2446 java.sql.Types.VARCHAR.
2448 2011-12-02 Ben Konrath <ben@bagu.org>
2450 Use checkboxes for booleans in the details view.
2452 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2454 2011-12-01 Ben Konrath <ben@bagu.org>
2456 Improve performance of related list height calculation.
2458 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2459 Put code to calculate the expected height in a static initializer so
2460 that that it's only called once.
2462 2011-12-01 Ben Konrath <ben@bagu.org>
2464 Show related list tables in notebooks (again).
2466 Calculate the height of the related list tables so the Notebook can be
2467 set the correct height. The height of the related list table is also needed by
2468 FlowTable to be able decide how to create the layout.
2470 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2471 and set the Portal height based on the height of the related list
2472 table and the Portal container.
2473 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2474 Add method to calculate the height of the related list tables.
2475 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2476 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2477 calculate the height of the Pager widget.
2479 2011-12-01 Ben Konrath <ben@bagu.org>
2481 Use CellTable API for table property instead of setting style on Element.
2483 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2485 2011-12-01 Ben Konrath <ben@bagu.org>
2487 Make ListViewTable and RelatedListTable a consistent height.
2489 The tables are now a consistent height regardless of the contents of
2490 the table. A hidden button is added to empty rows to ensure that the
2491 height of these rows will match the height of rows with data.
2493 A navigation button column is now added to every table. The width of
2494 the navigation column is set to 0px when a RelatedListTable shouldn't
2495 have navigation buttons. This maintains the a consistent row height in
2496 tables that don't show the navigation buttons.
2498 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2499 navigation column when not needed.
2500 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2501 arguments for navigation button to constructor of ListViewTable.
2502 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2503 hidden button for empty data rows.
2504 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2505 arguments for navigation button to constructor.
2506 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2507 create navigation buttons. Add hideNavigationButtons() method.
2508 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2509 arguments for navigation button to constructor.
2511 2011-12-01 Ben Konrath <ben@bagu.org>
2513 Use 'visibility: hidden' in Utils.getWidgetHeight().
2515 This is better choice because hidden elements are invisible, don't
2516 respond to events and are not part of the tab order. They will,