1 2011-12-30 Murray Cumming <murrayc@murrayc.com>
3 Use the surefire-report plugin.
5 * pom.xml: This generates a HTML report about the tests in
6 target/site/surefire-report.html
7 when you do mvn surefire-report:report. It seems to be popular/normal.
9 2011-12-30 Murray Cumming <murrayc@murrayc.com>
11 Added a test for DetailsPlace.
13 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
14 Test the getPlace() token parsing.
16 2011-12-30 Murray Cumming <murrayc@murrayc.com>
18 Added a first unit test.
20 * pom.xml: Add a test goal, and a dependency on junit in that scope.
21 * src/test/java/org/glom/web/shared/DataItemTest.java:
22 This is a silly test but it is just to get things started. Note that
23 maven/junit finds the test because it looks in src/test by default.
25 2011-12-22 Ben Konrath <ben@bagu.org>
27 Change charsetName to "UTF-8" when replacing line breaks.
29 JavaScript requires the charsetName to be "UTF-8". CharsetName values
30 that work in Java (such as "UTF8") will not work when compiled to
33 This fixes a problem with multi-line details view fields that have hard
34 line breaks. The "License Text" field on this page demonstrates the
37 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
39 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
41 2011-12-22 Ben Konrath <ben@bagu.org>
43 Fix another bug with related list navigation.
45 I've tested all the navigation buttons in all of the related lists
46 so things should be good now.
48 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
50 2011-12-22 Ben Konrath <ben@bagu.org>
52 Fix a crasher when refreshing the list view with the default table.
54 This crash will also happen when loading the list view with the default
55 table from a link or bookmark.
57 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
58 to the main document selection page when the document id hasn't been
60 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
61 the main document selection page when the document id hasn't been
63 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
64 values for the details place when the document id hasn't been set.
65 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
66 values for the list place when the document id hasn't been set.
68 2011-12-21 Ben Konrath <ben@bagu.org>
70 Protect against NPE when glom.document.locale is not in config.
72 This patch protects against an NPE when glom.document.locale is not in
73 the config file. This NPE will also happen if glom.document.locale is
76 The patch also updates the error message to display the class name when
77 the getMessage() returns null. This was happening when the NPE was
78 thrown and I had "Configuration Error: null". If an NPE is encountered
79 with this patch, "Configuration Error: NullPointerException " will be
82 This commit closes this bug:
84 https://bugzilla.gnome.org/show_bug.cgi?id=666669
86 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
88 2011-12-20 Murray Cumming <murrayc@murrayc.com>
90 Rename onlineglom.properties to onlineglom.properties.sample.
92 * src/main/resources/onlineglom.properties: Rename to:
93 * src/main/resources/onlineglom.properties.sample:
94 * src/main/resources/README: And add this file explaining that people
95 should rename it back when deploying.
97 2011-12-20 Murray Cumming <murrayc@murrayc.com>
99 Allow choosing the translation in the .properties file.
101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
102 init(): Read a glom.document.locale value from the configuration file
103 and call Glom's TransatableItem::set_current_locale() method.
104 * src/main/resources/onlineglom.properties: Add a commented-out
105 example of this new setting.
107 It would be better to add &lang=de_DE to the URL, but the current
108 libglom API does not allow us to do this easily. I am working on that.
110 2011-12-19 Murray Cumming <murrayc@murrayc.com>
112 Avoid a crash in parsing of token parameters.
114 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
115 ava: getTokenParams(): Do not crash if a parameter has a key but no
116 value, and ignore parameters with neither.
118 2011-12-17 Murray Cumming <murrayc@murayc.com>
120 History token building/handling: Improve use of token parameters.
122 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
123 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
124 and buildParamsToken(HashMap), for use by derived classes.
125 Make the separator private because it is no longer be needed.
126 * src/main/java/org/glom/web/client/place/DetailsPlace.java
127 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
128 instead of manual string concatenation.
129 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
130 of hardcoded indices and awkward splitting code.
131 * src/main/java/org/glom/web/client/place/ListPlace.java
132 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
133 instead of manual string concatenation.
134 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
135 of hardcoded indices and awkward splitting code.
136 This should fix bug #666420
138 2011-12-16 Murray Cumming <murrayc@murrayc.com>
140 Fix a Navgiation->Navigation typo in the code.
142 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
143 Rename processNavgiation() to processNavigation().
145 2011-12-16 Murray Cumming <murrayc@murrayc.com>
147 Fix a seperator->separator typo in the code.
149 * src/main/java/org/glom/web/client/place/DetailsPlace.java
150 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
151 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
154 2011-12-15 Ben Konrath <ben@bagu.org>
156 Cleanup some comments.
158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
160 2011-12-14 Ben Konrath <ben@bagu.org>
162 Replace \n with <br/> for multiline text in the details view.
164 Vertical scrollbars are added when needed as well.
166 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
168 2011-12-14 Ben Konrath <ben@bagu.org>
170 Specify the font for document selection links.
172 * src/main/webapp/style.css:
174 2011-12-14 Ben Konrath <ben@bagu.org>
176 Fix bouncy CellTable while paging.
178 This doesn't currently work with related list tables in unselected
181 * src/main/java/org/glom/web/client/ui/list/ListTable.java
183 2011-12-14 Ben Konrath <ben@bagu.org>
185 Revamp the appearance of the document selection page.
187 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
188 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
189 * src/main/webapp/style.css:
191 2011-12-13 Ben Konrath <ben@bagu.org>
193 Set navigation button column to the smallest size possible.
195 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
197 2011-12-13 Ben Konrath <ben@bagu.org>
199 Change OpenButton nomenclature to NavigationButton.
201 Using NavigtionButton makes things more generic. Classes, methods and
202 variables have been changed.
204 This is a rename-only refactor.
206 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
207 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
208 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
209 Renamed from OpenButtonCell.
210 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
211 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
212 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
214 2011-12-12 Ben Konrath <ben@bagu.org>
216 Remove unnecessary String argument in RelatedListTable and ListViewTable.
218 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
220 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
221 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
223 2011-12-12 Ben Konrath <ben@bagu.org>
225 Update variable names and comments.
227 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
228 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
230 2011-12-12 Ben Konrath <ben@bagu.org>
232 Properly initialize numNonEmptyRows variable to zero.
234 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
235 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
237 2011-12-05 Ben Konrath <ben@bagu.org>
239 Add latest mockup with HTML tables.
241 Features of this mockup:
243 -> HTML table for flowtable
244 -> HTML table for flowtable column
245 -> Example of how related lists would look
246 -> Not using text entries for data items
248 The current version of Online Glom doesn't use HTML tables for the
251 This mockup has been sent to the glom-devel mailing list but it's good
252 to have it here as well.
254 * mockups/details-view-html-tables.html:
256 2011-12-05 Ben Konrath <ben@bagu.org>
258 Remove unnecessary getPrimaryKeyField() method.
260 getPrimaryKeyFieldForTable(String) has been renamed to
261 getPrimaryKeyField(String).
263 * src/main/java/org/glom/web/server/database/DBAccess.java:
264 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
265 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
267 2011-12-05 Ben Konrath <ben@bagu.org>
269 Add string representation of TypedDataItem value to conversion error message.
271 * src/main/java/org/glom/web/server/Utils.java: Logging the error
272 message was extracted into its own method to avoid duplication.
274 2011-12-05 Ben Konrath <ben@bagu.org>
276 Add type checking to navigation primary key value creation.
278 Create navigation primary key only if the expected type from the Glom
279 document matches the type returned by the SQL query.
281 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
283 2011-12-05 Ben Konrath <ben@bagu.org>
285 Rename a couple of variables in RelatedListNavigation.
287 This is a rename-only refactor.
289 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
291 2011-12-05 Ben Konrath <ben@bagu.org>
293 Move getListLayoutGroup() into getListViewLayoutGroup().
295 This removes getListLayoutGroup(). It was only being called by
296 getListViewLayoutGroup().
298 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
300 2011-12-05 Ben Konrath <ben@bagu.org>
302 Remove check for LayoutItem_Portal in list table method.
304 This check is no longer necessary because the method isn't being used
305 to create the LayoutItemPortal DTO.
307 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
309 2011-12-05 Ben Konrath <ben@bagu.org>
311 Properly support related list navigation.
313 Navigation from the "Repository Analyzer -> Package Scans ->
314 Dependencies" related table wasn't working because the primary key for
315 related tables wasn't being set properly. This commit fixes the
318 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
319 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
320 doesn't set the primary key properly for related list tables.
321 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
322 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
323 useful for getting the primary key for list view tables and for related
325 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
326 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
327 Move code to set the primary key for the table from the abstract
328 ListDBAccess class to ListViewDBAccess as it's only correct for list
330 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
331 Properly add primary key to related list tables.
333 2011-12-02 Ben Konrath <ben@bagu.org>
335 Properly set the horizontal alignment of fields.
337 This fix is for both the list tables and the details view.
339 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
340 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
341 to set the horizontal alignment of fields.
343 2011-12-02 Ben Konrath <ben@bagu.org>
345 Display currency codes in the details view.
347 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
349 2011-12-02 Ben Konrath <ben@bagu.org>
351 Avoid duplicate JNI call.
353 JNI is not as efficient as pure Java and this is an easy (and small)
356 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
357 Use previously retrieved value for whereClauseToTableName instead of
360 2011-12-02 Ben Konrath <ben@bagu.org>
362 Rename a couple of variables in RelatedListNavigation.
364 This is a rename-only refactor.
366 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
368 2011-12-02 Ben Konrath <ben@bagu.org>
370 Indicate clearly that a mismatched primary key type is a bug.
372 * src/main/java/org/glom/web/server/Utils.java: Change log level from
373 warning to error. Add 'This is a bug.' to message.
375 2011-12-02 Ben Konrath <ben@bagu.org>
377 Update / fix some comments.
379 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
381 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
383 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
384 Fix comments. Add some TODOs.
386 2011-12-02 Ben Konrath <ben@bagu.org>
388 Enable navigation to details view with string primary key from related list.
390 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
391 Create a text primary key value when return type of result is
392 java.sql.Types.VARCHAR.
394 2011-12-02 Ben Konrath <ben@bagu.org>
396 Use checkboxes for booleans in the details view.
398 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
400 2011-12-01 Ben Konrath <ben@bagu.org>
402 Improve performance of related list height calculation.
404 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
405 Put code to calculate the expected height in a static initializer so
406 that that it's only called once.
408 2011-12-01 Ben Konrath <ben@bagu.org>
410 Show related list tables in notebooks (again).
412 Calculate the height of the related list tables so the Notebook can be
413 set the correct height. The height of the related list table is also needed by
414 FlowTable to be able decide how to create the layout.
416 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
417 and set the Portal height based on the height of the related list
418 table and the Portal container.
419 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
420 Add method to calculate the height of the related list tables.
421 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
422 * src/main/webapp/style.css: Add css class for Pager. This is needed to
423 calculate the height of the Pager widget.
425 2011-12-01 Ben Konrath <ben@bagu.org>
427 Use CellTable API for table property instead of setting style on Element.
429 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
431 2011-12-01 Ben Konrath <ben@bagu.org>
433 Make ListViewTable and RelatedListTable a consistent height.
435 The tables are now a consistent height regardless of the contents of
436 the table. A hidden button is added to empty rows to ensure that the
437 height of these rows will match the height of rows with data.
439 A navigation button column is now added to every table. The width of
440 the navigation column is set to 0px when a RelatedListTable shouldn't
441 have navigation buttons. This maintains the a consistent row height in
442 tables that don't show the navigation buttons.
444 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
445 navigation column when not needed.
446 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
447 arguments for navigation button to constructor of ListViewTable.
448 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
449 hidden button for empty data rows.
450 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
451 arguments for navigation button to constructor.
452 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
453 create navigation buttons. Add hideNavigationButtons() method.
454 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
455 arguments for navigation button to constructor.
457 2011-12-01 Ben Konrath <ben@bagu.org>
459 Use 'visibility: hidden' in Utils.getWidgetHeight().
461 This is better choice because hidden elements are invisible, don't
462 respond to events and are not part of the tab order. They will,
463 however, take up space which is required to be able to calculate the
464 height of the widget.
466 * src/main/java/org/glom/web/client/Utils.java:
468 2011-12-01 Ben Konrath <ben@bagu.org>
470 Use Utils.getWidgetHeight() in FlowTable.
472 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
474 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
476 2011-12-01 Ben Konrath <ben@bagu.org>
478 Put the details css class name on the correct table column.
480 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
482 2011-11-30 Ben Konrath <ben@bagu.org>
484 Update for java-libglom API change.
486 The getters and setters on FieldFormatting and NumericFormat were
487 changed to remove the 'M'.
489 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
491 2011-11-29 Ben Konrath <ben@bagu.org>
493 Only allow RelatedListTables in Portals.
495 * src/main/java/org/glom/web/client/ui/details/Portal.java:
497 2011-11-29 Ben Konrath <ben@bagu.org>
499 Only create a contents panel for Portals when title is being set.
501 * src/main/java/org/glom/web/client/ui/details/Portal.java:
503 2011-11-29 Ben Konrath <ben@bagu.org>
505 Set TabLayoutPanel height based on calculated height its widgets.
507 This is a potential fix for this bug:
509 https://bugzilla.gnome.org/show_bug.cgi?id=665133
511 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
513 2011-11-29 Ben Konrath <ben@bagu.org>
515 Align details field labels and data with the Open buttons.
517 * src/main/webapp/style.css:
519 2011-11-29 Ben Konrath <ben@bagu.org>
521 Remove unnecessary <div> in the Notebook widget.
523 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
524 method to get container FlowPanel (<div>).
525 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
526 initWidget() method directly on the TabLayoutPanel widget instead of
527 Group's container widget.
529 2011-11-29 Ben Konrath <ben@bagu.org>
531 Don't add group titles for Portals in Notebooks.
533 This reverts the previous patch and fixes a bug I introduced with
534 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
536 * src/main/java/org/glom/web/client/ui/details/Group.java:
537 * src/main/java/org/glom/web/client/ui/details/Portal.java:
539 2011-11-28 Ben Konrath <ben@bagu.org>
541 Remove unused boolean argument in Portal constructor.
545 * src/main/java/org/glom/web/client/ui/details/Group.java:
546 * src/main/java/org/glom/web/client/ui/details/Portal.java:
548 2011-11-28 Ben Konrath <ben@bagu.org>
550 Remove hack for glom 1.18 style glom files.
552 * src/main/java/org/glom/web/client/ui/details/Group.java:
553 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
554 * src/main/java/org/glom/web/client/ui/details/Portal.java:
556 2011-11-28 Ben Konrath <ben@bagu.org>
558 Use Gda Value version of primary key to log result too large error.
560 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
562 2011-11-28 Ben Konrath <ben@bagu.org>
564 Don't use TypedDataItem.getText() for Unknown types from the URL.
566 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
567 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
568 instead of getText().
569 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
570 String field and getUnknown() method.
572 2011-11-28 Ben Konrath <ben@bagu.org>
574 Log an error message when the java-libglom .so is not present.
576 The error message was being set in the exception but not logged.
578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
580 2011-11-28 Ben Konrath <ben@bagu.org>
582 Ignore LayoutItem_CalendarPortals.
584 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
585 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
587 2011-11-28 Ben Konrath <ben@bagu.org>
589 Extract method for creating the LayoutItemPortal DTO.
591 Just breaking the code up into smaller chunks.
593 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
595 2011-11-28 Ben Konrath <ben@bagu.org>
599 This should have been added with the refactor. Oops!
601 * src/main/java/org/glom/web/shared/TypedDataItem.java:
603 2011-11-28 Ben Konrath <ben@bagu.org>
605 Create primary key value from URL string using type from Glom document.
607 See this bug, comments 19 - 25:
609 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
611 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
612 create a TypeDataItem for the primary key here when loading from a
613 URL. Show the same string for the primary key value as was received
614 from the URL string (when loading from a URL).
615 * src/main/java/org/glom/web/server/Utils.java: Update method for
616 creating the Gda Value from the TypeDataItem to properly deal with
617 creating a Gda Value based on the Glom document type for the primary
618 key value string when loading from a URL.
619 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
620 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
621 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
622 Update for changed method name.
624 2011-11-27 Ben Konrath <ben@bagu.org>
626 Rename PrimaryKeyItem to TypedDataItem.
628 The name PrimaryKeyItem suggests what the class should be used for.
629 TypedDataItem is a neutral name that describes the class better.
631 This is a rename-only refactor.
633 * src/main/java/org/glom/web/client/OnlineGlomService.java:
634 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
635 * src/main/java/org/glom/web/client/Utils.java:
636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
637 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
638 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
639 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
640 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
641 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
643 * src/main/java/org/glom/web/server/Utils.java:
644 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
645 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
646 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
647 * src/main/java/org/glom/web/shared/NavigationRecord.java:
649 2011-11-25 Ben Konrath <ben@bagu.org>
651 Improve Gda Value conversion from PrimaryKeyItem.
653 The value from the PrimaryKeyItem is only used if its type match the
654 type from the glom document.
656 * src/main/java/org/glom/web/server/Utils.java:
658 2011-11-25 Ben Konrath <ben@bagu.org>
660 Manually check if the java-liblgom .so is visible to the JVM.
662 It seems that Tomcat has problems when a static initializer throws an
663 exception. This check is done before the first method call into
664 java-libglom so that execution doesn't continue if the .so is not
667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
669 2011-11-25 Ben Konrath <ben@bagu.org>
671 Improve browser configuration error messages.
675 https://bugzilla.gnome.org/show_bug.cgi?id=662792
677 * src/main/java/org/glom/web/client/OnlineGlomService.java:
678 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
679 getConfigurationErrorMessage() method.
680 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
681 Get and display a specific configuration error message when no Glom
683 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
684 Implement getConfigurationErrorMessage() method. Surround configuration
685 code in the init() method with a try/catch block. This allows the
686 errors to be caught while keeping the servlet available to retrieve the
687 configuration error message.
689 2011-11-25 Ben Konrath <ben@bagu.org>
691 Don't use Strings to hold primary key values.
693 The primary key values are now held in a new data object
694 (PrimaryKeyItem) that holds type information and the primary key value
695 using the correct type.
697 * src/main/java/org/glom/web/client/OnlineGlomService.java:
698 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
700 PrimaryKeyItem instead of String to hold the primary key value.
701 * src/main/java/org/glom/web/client/Utils.java: Remove
702 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
703 PrimaryKeyItem based on the GlomFieldType and the DataItem.
704 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
705 PrimaryKeyItem instead of String to hold the primary key value. Load
706 document selection page when the documentID has not been set correctly.
707 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
708 DetailsPlace -> URL and URL -> DetailsPlace conversion with
710 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
711 Return empty string for URL instead of "null".
712 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
713 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
714 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
715 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
716 PrimaryKeyItem instead of String to hold primary key values.
717 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
718 PrimaryKeyValue to a Gda Value.
719 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
720 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
721 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
722 Replace temporary database access code that uses the PrimaryKeyValue to
723 Gda Value conversion.
724 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
725 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
726 PrimaryKeyItem instead of String.
727 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
728 hold primary key values.
730 2011-11-24 Ben Konrath <ben@bagu.org>
732 Use newly added java-libglom API to create queries.
734 This isn't finished. I still need to stop using Strings for primary key
735 values in the client code.
737 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
738 libglom to use fake connections so that retrieving the query string will
740 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
741 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
742 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
743 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
744 Use the newly added libglom sql methods and classes to create the
745 query. Add temporary hack to convert primary value strings to Gda
748 2011-11-23 Ben Konrath <ben@bagu.org>
750 Don't explicitly set the height of Portals.
752 See comments 6 - 10 of this bug for details:
754 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
756 * src/main/java/org/glom/web/client/ui/details/Portal.java:
758 2011-11-23 Ben Konrath <ben@bagu.org>
760 Use an HTML table instead of CSS for the FlowTable layout.
762 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
763 GWT's FlexTable to implement the FlowTable.
764 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
766 2011-11-18 Ben Konrath <ben@bagu.org>
768 Add boolean example to HTML table mockup.
770 * mockups/details-view-html-tables-text-entries.html:
772 2011-11-17 Ben Konrath <ben@bagu.org>
774 Ensure the pager buttons are always visible for related lists.
776 To accomplish this, I've turned off text wrapping in the list view and
777 related list tables for both the header and data text. The related list
778 table now has a fixed layout so the it doesn't overflow its container.
779 This is required to ensure that the cell text is clipped when it
780 overflows the cell and an ellipsis is added to the right side of the
781 cell when text is clipped.
783 A fixed table layout for the related list table in the details view
784 seems what we want for the details view anyway, so the side-effect is
787 The ellipsis will only be displayed in Firefox >= 7.
791 https://bugzilla.gnome.org/show_bug.cgi?id=662930
793 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
794 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
795 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
797 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
798 Set the 'table-layout: fixed' CSS property to the related list table.
799 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
800 'white-space: nowrap;' CSS property on both the list view and the
803 2011-11-16 Ben Konrath <ben@bagu.org>
805 Rework the fix for empty notebook tab labels.
807 Setting the empty group titles with its name caused problems for the
808 details layout. Instead of using libglom's
809 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
810 to the client when the title is empty. This allows the Notebook to use
811 the name when the title is empty without affecting anything else.
813 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
814 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
816 2011-11-16 Ben Konrath <ben@bagu.org>
818 Set group titles with name when title is empty.
820 This fixes a problem with an empty notebook tab label in the Lesson
821 Planner document. The forth tab in the notebook should be "Internet":
823 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
825 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
826 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
829 2011-11-16 Ben Konrath <ben@bagu.org>
831 Remove whitespace from the configured username properties.
833 This assumes that usernames won't have whitespace at the beginning
834 or end. But I think this is a reasonable assumption.
836 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
837 String.trim() to remove the whitespace from the username properties.
839 2011-11-15 Ben Konrath <ben@bagu.org>
841 Add details view mockup with HTML tables and text entries.
843 This is from the attachment on this bug:
845 https://bugzilla.gnome.org/show_bug.cgi?id=663109
847 * mockups/details-view-html-tables-text-entries.html:
849 2011-11-15 Ben Konrath <ben@bagu.org>
851 Add space between the columns of the flow table.
855 https://bugzilla.gnome.org/show_bug.cgi?id=662918
857 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
858 space between columns in the flow table.
860 2011-11-15 Ben Konrath <ben@bagu.org>
862 Add backup files to the .gitignore.
864 * .gitignore: Ignore files that end with ~.
866 2011-11-09 Ben Konrath <ben@bagu.org>
868 Use latest release of gwt-log.
870 Gwt-log releases are now being submitted to the maven central
871 repository so manual installation of the jar is no longer required.
873 * pom.xml: Update version and groupId of gwt-log dependency.
875 2011-10-31 Ben Konrath <ben@bagu.org>
877 Don't use GWT numeric formatting to override the glom currency formatting.
879 Currencies are now displayed like they are in Glom. See this bug:
881 https://bugzilla.gnome.org/show_bug.cgi?id=646216
883 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
885 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
886 currency code to constructor and set it when the cell is rendered.
887 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
888 currency code to the constructor of the NumericCell.
890 2011-10-27 Ben Konrath <ben@bagu.org>
892 Require the latest release of java-libglom (1.17.4).
896 2011-10-26 Ben Konrath <ben@bagu.org>
898 Add style to Notebook that matches current theme.
900 It's not the best style in the world but it's better than the default.
902 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
903 padding at the bottom of the child widgets.
904 * src/main/webapp/style.css: Add style for the Notebook.
906 2011-10-26 Ben Konrath <ben@bagu.org>
908 Move servlet initialization code to overridden init method.
910 This is half of the solution to getting proper error messages
911 displayed when configuration errors occur. Here's the relevant bug:
913 https://bugzilla.gnome.org/show_bug.cgi?id=662792
915 The rest of the solution involves surrounding the init method with a
916 try/catch block and setting a global variable with the error /
917 exception. A new async method should be created to retrieve and display
918 the error message / exception.
920 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
921 code from constructor to init method adding exceptions as needed.
923 2011-10-26 Ben Konrath <ben@bagu.org>
925 Add script to monitor and restart tomcat if required.
927 * utils/check-and-recover-tomcat.py: New file.
929 2011-10-26 Ben Konrath <ben@bagu.org>
931 Display the correct number of data items in the pager.
935 https://bugzilla.gnome.org/show_bug.cgi?id=661441
937 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
938 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
939 The implementation is the same for both tables: Keep track of the
940 number of non-empty rows and fire and RowCountChangeEvent after the data has
942 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
943 custom Pager class that subclasses SimplePager to handle displaying
944 the correct number when empty rows have been added.
946 2011-10-26 Ben Konrath <ben@bagu.org>
948 Correct error in previous commit.
950 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
951 eventBus parameter from listView.setCellTable().
953 2011-10-26 Ben Konrath <ben@bagu.org>
955 Fix error in TODO comment.
957 * src/main/java/org/glom/web/client/activity/ListActivity.java:
959 2011-10-24 Ben Konrath <ben@bagu.org>
961 Create Notebook widgets to the details view.
963 This isn't finished just yet - I still need to create a reasonable
964 style to match the current theme.
966 * src/main/java/org/glom/web/client/Utils.java: Add method for
967 calculating the height of a widget. This is used in the Notebook class.
968 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
969 new constructor method in Group.
970 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
971 method for creating child widget that can be used by subclasses
972 like Notebook. New constructor that allows disabling the group
973 titles - Notebooks don't set a group title for their child groups.
974 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
975 to make Notebooks using GWT's TabLayoutPanel.
976 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
977 constructor that allows disabling the group titles.
978 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
979 LayoutItemNotebook DTO.
980 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
981 DTO for Notebooks. It's just an empty class for now but we might need
982 it to transfer some specific information in the future.
984 2011-10-21 Ben Konrath <ben@bagu.org>
986 Add navigation buttons to related list tables.
988 * src/main/java/org/glom/web/client/OnlineGlomService.java:
989 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
991 method getSuitableRecordToViewDetails() for getting the table name
992 and primary key value for related list navigation buttons.
993 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
994 private cell renderer class to get the navigation information for
995 related list tables from the server. Extract the navigation
996 processing code from the details cell navigation and use it for the
997 related list navigation as well.
998 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
999 cell renderer class for the details open buttons. This was needed
1000 because the related list navigation buttons and the list view
1001 navigation buttons need to react differently when clicked.
1002 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1003 the onEnterKeyDown() method because it's now overriden in the
1004 subclasses that are specific to the related list tables and the list
1006 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1007 the vertical size a little because the buttons add a bit of vertical
1008 space to table. This is not a perfect solution because the vertical
1009 size of with table fewer than 5 rows will be a little smaller.
1010 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1011 changes in how navigation buttons are handled.
1012 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1013 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1014 database access object.
1015 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1016 to find the portal for a given relationship name from
1017 RelatedListDBAccess. Add method to find a primary key field for a
1019 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1020 Move code to find the portal for a given relationship name to
1022 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1023 New file: database access object for getting the related list
1024 navigation information (the table name and the primary key value).
1025 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1026 DTO for transferring a table name to navigate to and a primary key
1028 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1029 boolean and getter/setter to specifies if the related list should add
1032 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1034 Use the master branch of java-libglom
1036 * pom.xml: Depend on java-libglom 1.19 instead.
1038 This is the master branch. See also the libglom-1-18 branch.
1040 2011-10-11 Ben Konrath <ben@bagu.org>
1042 Enable the open navigation button when the data has been set.
1044 This avoids having active buttons that don't do anything when the data
1047 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1049 2011-10-11 Ben Konrath <ben@bagu.org>
1051 Use IsWidget interface for FlowTableItem.
1053 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1054 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1056 2011-10-11 Ben Konrath <ben@bagu.org>
1058 Remove GWT styling from open button in details view.
1060 There are still some issues with how the details cell is arranged but
1061 this should be made to match Glom 1.20. I'm going to leave fixing this
1062 until I have Glom 1.20 up and running.
1064 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1065 style name on open button.
1066 * src/main/webapp/style.css: Move and edit details-navigation class.
1067 Re-arrange some classes to make them appear in the same order as the
1070 2011-10-07 Ben Konrath <ben@bagu.org>
1072 Update to GWT 2.4.0.
1074 * .gitignore: Ignore new cache directory.
1075 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1076 * pom.xml: Change GWT and maven plugin to 2.4.0.
1077 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1079 * src/main/java/org/glom/web/client/ClientFactory.java:
1080 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1081 * src/main/java/org/glom/web/client/OnlineGlom.java:
1082 Update source for API changes.
1083 * utils/build-onlineglom-war.sh: Remove cache directory before the
1086 2011-10-07 Ben Konrath <ben@bagu.org>
1088 Add navigation buttons in the details view.
1090 This isn't finished but I thought I'd commit what I have as it's a
1091 pretty good start. I still need to:
1093 1. Change the style so that it fits better into the current theme
1094 2. Adjust the details cell to expand as much as possible.
1096 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1097 click handlers to navigation buttons in the DetailsCells. Create a
1098 refreshData() method to get just the data from the server without the
1100 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1101 Update the tableSelector and browser title when the table name
1102 changes without using the tableSelector.
1103 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1104 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1105 getDetailsCells() to getCells(). Update variable names.
1106 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1107 method to set click handler on navigation button. Rename a few
1108 variables. Add navigation buttons where needed.
1109 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1110 variables and methods.
1111 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1112 navigation boolean and navigation table as required in the
1113 LayoutItemField DTO.
1114 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1115 variables for navigation along with getter/setter methods.
1117 2011-10-07 Ben Konrath <ben@bagu.org>
1119 Rename Field to DetailsCell.
1121 This is a refactor-only commit. No functionality has been added or
1124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1125 Update variable and method names.
1126 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1127 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1128 variable and method names.
1129 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1131 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1132 variable and method names.
1134 2011-10-07 Ben Konrath <ben@bagu.org>
1136 Create separate methods for layout and data the details view.
1138 This is a refactor-only commit. No functionality has been added or
1141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1142 private methods: setData(), createLayout().
1144 2011-10-07 Ben Konrath <ben@bagu.org>
1146 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1148 This is part of a change to get navigation buttons in the details view
1149 but it should have been done this way from the start.
1151 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1152 for method name change in TableSelectionView.
1153 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1154 Create TableChangeEvent and set the browser title using the
1155 TableSelectionView API.
1156 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1158 Change getSelectedTable() to getSelectedTableName(). Add
1159 getSelectedTableTitle().
1161 2011-10-07 Ben Konrath <ben@bagu.org>
1163 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1165 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1167 2011-10-07 Ben Konrath <ben@bagu.org>
1169 Update TableChangeEvent to use newTableName naming convention.
1171 This makes the class more consistent with GWT naming conventions.
1173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1174 Update for method name change in TableChangeEvent.
1175 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1176 for method name change in TableChangeEvent.
1177 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1178 newTableName variable and getter method. Make toDebugString()
1181 2011-09-30 Ben Konrath <ben@bagu.org>
1183 Disable the pager in the list tables when the data row count is less than the minimum.
1185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1186 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1188 2011-09-30 Ben Konrath <ben@bagu.org>
1190 Add empty rows to the end of related list and list view tables.
1192 I also extracted the cell rendering classes from the ListTable because
1193 the code was becoming a little crazy with all the anonymous inner
1194 classes. My plan is to use these cell rendering classes in the details
1195 view as well so this refactor will be needed for that change.
1197 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1198 set the row count in related list tables if the data has more rows
1199 than the minimum number of rows visible.
1200 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1201 row count in list view tables if the data has more rows than the
1202 minimum number of rows visible.
1203 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1204 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1206 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1207 for rendering TYPE_NUMERIC cells. The code was extracted from the
1209 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1210 class for rendering cells with buttons in list views. The code was
1211 extracted from the ListTable class.
1212 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1213 for rendering TYPE_TEXT cells. The code was extracted from the
1215 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1216 Add empty rows to the end of the data if required. Implement
1217 ListTable.getMinNumVisibleRows().
1218 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1219 cell renderer code to public classes. Return null in
1220 Column.getValue() for empty rows. Add new abstract method:
1221 getMinNumVisibleRows(). Move code to set the row count of the list view
1222 table to ListViewImpl.
1223 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1224 empty rows to the end of the data if required. Implement
1225 ListTable.getMinNumVisibleRows().
1228 2011-09-27 Ben Konrath <ben@bagu.org>
1230 Use GWT.log for client-side debugging statements.
1232 These are optimized out when deployed so I should have used this method
1233 in the first place. These statements will eventually be replaced with some sort
1234 of notification in the browser.
1236 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1237 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1238 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1239 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1240 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1242 2011-09-27 Ben Konrath <ben@bagu.org>
1244 Put tableselector on the right, back to list link on right.
1246 The idea is that the table selector is acting like a label for the
1247 currently displayed table so it should be placed below the document title. This
1248 puts the table title in a similar position to where it is in Glom.
1250 * mockups/details-contacts.html:
1251 * mockups/details-projects.html:
1252 * mockups/listview-contacts.html:
1253 * mockups/listview-projects.html:
1254 * mockups/style.css:
1255 Update mockups to match how the interfaces currently look.
1256 * src/main/webapp/style.css: Swap positions of backlink with the table
1257 selector. Add some space on the left side of the table selector to
1258 line things up with the document title.
1260 2011-09-27 Ben Konrath <ben@bagu.org>
1262 Add field colouring to details view.
1264 This change re-works how field colouring works. The colour formatting
1265 information is now set to the client with the layout information instead of
1266 with the data. This eliminates the need to send the same colour strings for
1267 data in list view column when colour information is set.
1269 In order to set an alternate colour for negative numeric values, the
1270 number is now sent to client and formatted with the GWT NumberFormat class.
1272 This change also fixes:
1274 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1276 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1277 internationalization framework which is needed for client side numeric
1279 * src/main/java/org/glom/web/client/Utils.java: New file for some
1280 client static utility methods.
1281 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1282 the DataItem object to the Field class. Use a utility method to
1283 create the foreignKeyValue string.
1284 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1285 alignment and text colours in the constructor. Add setData(DataItem)
1286 method. Remove setText(String) method.
1287 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1288 colour information to GlomTextCell. Create and use GlomNumberCell for
1289 rendering numbers. Use utility method to get the string for the
1290 primary key of the key provider. Re-work how the horizontal alignment
1292 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1293 formatting to layout information. Methods for converting the libglom
1294 formatting information were moved from DBAccess.
1295 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1296 numeric formatting (it's now done on the client side). Don't set text
1297 colours in DataItem. Move libglom formatting conversion methods to
1299 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1300 getters/setters for text colour information.
1301 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1302 for transferring the libglom NumericFormat information to the client.
1303 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1304 and getters/setters for: GlomNumericFormat, background colour and
1305 foreground colour strings.
1307 2011-09-26 Ben Konrath <ben@bagu.org>
1309 Simplify code that iterates through the LayoutGroup.
1311 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1313 2011-09-26 Ben Konrath <ben@bagu.org>
1315 Accept Eclipse formatting for OnlineGlomServiceAsync.
1317 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1319 2011-09-26 Ben Konrath <ben@bagu.org>
1321 Don't use the ListDBAccess classes to get the primary key layout information.
1323 This was causing a bug where the wrong index for the hidden primary key
1324 was being sent to the client.
1326 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1327 primary key while creating the LayoutGroup DTO. Create a
1328 LayoutItemField DTO for hidden primary keys. Don't use the
1329 RelatedListDBAccess because it was only used for getting the primary
1331 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1332 access modifier from public to protected for getPrimaryKeyField() and
1333 getPrimaryKeyLayoutItemField().
1334 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1335 abstract method getExpectedResultSize() because RelatedListDBAccess
1336 doesn't have enough info to implement it.
1337 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1338 Remove @Override for getExpectedResultSize().
1339 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1340 Remove method getExpectedResultSize().
1342 2011-09-23 Ben Konrath <ben@bagu.org>
1344 Log which layout (list or details) the ignored item is from.
1346 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1348 2011-09-23 Ben Konrath <ben@bagu.org>
1350 Remove annotations that turn off code formatting in DataItem.
1352 * src/main/java/org/glom/web/shared/DataItem.java:
1354 2011-09-23 Ben Konrath <ben@bagu.org>
1356 Rename GlomField to DataItem and update associated methods.
1358 This is a rename-only refactor. No functionality has been added or
1361 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1362 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1363 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1364 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1365 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1366 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1367 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1368 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1370 * src/main/java/org/glom/web/server/database/DBAccess.java:
1371 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1372 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1373 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1374 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1375 * src/main/java/org/glom/web/shared/DataItem.java:
1376 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1377 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1379 2011-09-23 Ben Konrath <ben@bagu.org>
1381 Rename GlomDocument to DocumentInfo and update associated methods.
1383 This is a rename-only refactor. No functionality has been added or
1386 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1387 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1388 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1389 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1390 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1391 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1392 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1394 2011-09-20 Ben Konrath <ben@bagu.org>
1396 Require java-libglom 1.17.3.
1398 This picks up the fix for the seg fault problem with the Scenes table
1399 in the Openismus Film Manager example.
1403 2011-09-20 Ben Konrath <ben@bagu.org>
1405 Change the way sort clause is added for primary key when no sort clause is requested.
1407 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1408 before the sort clause is created. When a sort clause is not requested, the
1409 sort clause is created by finding the primary key in the LayoutFieldVector
1412 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1414 2011-09-20 Ben Konrath <ben@bagu.org>
1416 Log error message if no documents are found in the configured directory.
1418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1419 Extract the glom file extension string to a private static final class
1420 variable (mostly as syntactic sugar). Accept a minor formatting change.
1421 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1422 the example glom.document.directory configuration property to make it
1423 more clear that it can any directory, not just the home directory.
1425 2011-09-18 Ben Konrath <ben@bagu.org>
1427 Add related lists to details view.
1429 The related list table has support for paging and sorting just like the
1430 table in the list view.
1432 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1433 SQL queries for the related list tables.
1434 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1435 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1436 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1437 Rename getList methods to getListView and add comments. Remove
1438 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1439 it being unused. Add methods: getDetailsLayoutAndData(),
1440 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1441 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1442 Create the layout and set the data for the fields in one async call
1443 instead of two. Create related lists where appropriate.
1444 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1445 for method name changes in OnlineGlomService.
1446 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1447 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1448 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1450 * src/main/java/org/glom/web/client/ui/ListView.java:
1451 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1452 tableName from setCellTable(). Create a ListViewTable instead of
1454 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1455 represent a data field in the details view.
1456 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1457 from addDetailsCell() to Field class. Keep track of the Fields and
1458 Portals in the details view.
1459 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1460 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1461 and add a method to get it. Add method to set the contents of the
1463 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1464 New class for related list tables. This class has the data provider
1465 for the related list table.
1466 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1467 abstract class which is the base class for the ListViewTable and the
1469 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1470 New class for list view tables. This class has the data provider for
1471 the list view table.
1472 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1473 methods for related list tables. Add more information to the
1474 LayoutItemField and LayoutItemPortal DTOs.
1475 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1476 Remove debugging print statement.
1477 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1478 Remove debugging print statements. Add primary key field to SQL count
1480 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1481 Remove unnecessary LayoutFieldVector parameter from
1482 getResultSizeOfSQLQuery() method.
1483 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1484 New class for related list table database access.
1485 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1486 class that is a wrapper DTO for details view layout and data.
1487 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1488 new 'fromField' string to this DTO.
1489 * src/main/webapp/style.css: Remove bottom margin and override top
1492 2011-09-15 Ben Konrath <ben@bagu.org>
1494 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1496 This sets things up to make it easier to add the data retrieval for
1497 related lists (portals). No user noticeable changes were made with
1500 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1501 class has the code to retrieve the layouts and access the
1502 database using the new database helper classes.
1503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1504 Most of the functionality has been removed from this class. This
1505 class now represents the public interface for the client side
1506 code. It also deals with configuring the servlet and cleaning
1507 things up when the servlet is stopped.
1508 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1509 of static methods into this utility class.
1510 * src/main/java/org/glom/web/server/database/DBAccess.java:
1511 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1512 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1513 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1514 These classes have the database retrieval code. The class hierarchy
1515 has been setup to make it easy to reuse code for similar
1518 2011-09-06 Ben Konrath <ben@bagu.org>
1520 Create separate classes for list table code and the data provider.
1522 As part of this refactor, I also split up the code a bit to make it
1525 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1526 table code to two new classes (below).
1527 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1528 with code from ListViewImpl.
1529 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1530 New file with code from ListViewImpl.
1532 2011-09-06 Ben Konrath <ben@bagu.org>
1534 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1536 This fixes the LayoutItemPortal DTO to match the libglom layout object
1539 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1541 2011-09-01 Ben Konrath <ben@bagu.org>
1543 Set title of Portals in the Details View.
1545 * pom.xml: Bump required version of java-libglom to 1.17.1.
1546 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1547 widget creation to its own class. Add comments to constructor.
1548 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1549 The code is mostly from the Group class with the title now set.
1550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1551 title of Portal. Update some comments. Fix some code formatting.
1553 2011-09-01 Ben Konrath <ben@bagu.org>
1555 Remove TODO comment for the flow table column width.
1557 The flow table column width is working correctly and doesn't need to be
1558 changed. See this mailing list post for more info:
1560 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1562 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1564 2011-08-27 Ben Konrath <ben@bagu.org>
1566 Add document title (database name) to top of the browser page.
1568 I added the document title to the TableSelecitonView but that will
1569 change if / when we add a view that doesn't require table selection.
1571 * mockups/details-contacts.html:
1572 * mockups/details-projects.html:
1573 * mockups/listview-contacts.html:
1574 * mockups/listview-projects.html:
1575 * mockups/style.css: Add document title to mockups to keep things
1577 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1578 sizes to account for the document title.
1579 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1580 Set the document title when it has been retrieved from the server.
1581 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1582 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1583 and implement setDocumentTitle(String) method.
1584 * src/main/webapp/style.css: Add ID for document title style.
1586 2011-08-25 Ben Konrath <ben@bagu.org>
1588 Add NavigationType enum to LayoutItemPortal DTO.
1590 This is the start of adding support for Portals to the Details View.
1592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1593 LayoutItem_Portal.navigation_type enum from libglom to
1594 LayoutItemPortal.NavigationType enum.
1595 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1596 NavigationType enum, field for storing the NavigationType and getter
1599 2011-08-25 Ben Konrath <ben@bagu.org>
1601 Implement the flow table layout in the Details View.
1603 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1604 FlowTable to Group to account for the renamed class.
1605 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1606 File. This is a container widget that implements the Glom details view
1607 flow table behaviour.
1608 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1609 org/glom/web/client/ui/FlowTable.java.
1610 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1611 so that the size of the subgroups are a closer match to the size of
1612 the Glom subgroups. This makes the flowtable layout match the layout
1613 in Glom for the Music Collection example file.
1615 2011-08-16 Ben Konrath <ben@bagu.org>
1617 Create container element for LayoutItemPortal in Details View.
1619 This will help me develop the layout for the FlowTable.
1621 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1622 fieldPanel variable to detailsCell.
1624 2011-08-15 Ben Konrath <ben@bagu.org>
1626 Set the height of the data element in the Details View.
1628 I changed the InlineLabels (text in a span element) to Labels (text in
1629 a div element) so that I could set the height of the details-data
1630 elements instead of the details-cell parent elements. This allows the
1631 the details-data element to display the correct height if style is
1632 applied that shows the height.
1634 This change has the added benefit of allowing the order of the labels
1635 and data elements to be changed for right-to-left languages.
1637 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1638 InlineLabels to Labels.
1639 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1640 InlineLabels to Labels. Set the height of the data element.
1641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1642 multiline text height in the Formatting DTO.
1643 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1644 for multiline height along with getter and setter methods.
1645 * src/main/webapp/style.css: Adjust style to account for the change
1646 from span elements to div elements in the details cell.
1648 2011-08-15 Ben Konrath <ben@bagu.org>
1650 Make the List View appearance match the mockups.
1652 It doesn't match exactly but it's much better than it was.
1654 * mockups/listview-contacts.html: Remove unused css classes.
1655 * mockups/listview-projects.html: Remove unused css classes.
1656 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1657 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1658 for mainPanel instead of VerticalPanel (table). Set style name on
1659 CellTable. Set style name on Details column. Right-align Details
1661 * src/main/webapp/style.css: Adjust properties to match the mockups.
1663 2011-08-12 Ben Konrath <ben@bagu.org>
1665 Add better support for subgroups in the details view.
1667 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1668 changed FlowTable constructor.
1669 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1670 support for subgroups and subgroup-titles.
1671 * src/main/webapp/style.css: Add CSS class for subgroups and
1674 2011-08-12 Ben Konrath <ben@bagu.org>
1676 Return the top level LayoutGroup title.
1678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1680 2011-08-11 Ben Konrath <ben@bagu.org>
1682 Make the TableSelector header match the mockup.
1684 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1685 the layout panel. Properly lineup the table selection header with
1686 the list and details view.
1687 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1688 margin around the details view.
1689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1690 Rename listBox variable to tableSelector. Set id for the style sheet.
1691 Use a FlowPanel instead of a HorizontalPanel.
1692 * src/main/webapp/style.css: Add properties to make the TableSelector
1693 box match the mockups.
1695 2011-07-13 Ben Konrath <ben@bagu.org>
1697 Update install script for java-libglom version change.
1699 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1702 2011-07-13 Ben Konrath <ben@bagu.org>
1704 Add support sub-group in the details view.
1706 I also removed the code that special-cased the default details view
1709 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1711 I still have to make a proper flowtable.
1713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1714 Don't special-case default details view layout.
1715 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1716 addLayoutField() as I'm going to use it.
1717 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1718 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1720 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1721 extracted from DetailsViewImpl.GroupPanel. Add support for
1723 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1724 column count when getting the details layout.
1726 2011-07-12 Ben Konrath <ben@bagu.org>
1728 Set browser title with database and table titles.
1730 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1731 Set the browser title when the table changes and when the activity
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1734 title when retrieving document info (the GlomDocument object).
1735 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1736 with getter and setter methods. Remove unused convenience constructor.
1737 Use default code formatting.
1739 2011-07-12 Ben Konrath <ben@bagu.org>
1741 Ignore LayoutItemPortals in the details view.
1743 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1746 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1747 LayoutItemPortal layout objects.
1748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1749 LayoutItemPortal objects when retrieving the details layout.
1750 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1751 file. This is an empty class and just used to get type information for
1754 2011-07-12 Ben Konrath <ben@bagu.org>
1756 Use java-libglom 1.17.0.
1760 2011-07-11 Ben Konrath <ben@bagu.org>
1762 Remove "Table:" label from table selector.
1764 This matches a recent change in the Glom UI.
1766 * mockups/details-contacts.html:
1767 * mockups/details-projects.html:
1768 * mockups/listview-contacts.html:
1769 * mockups/listview-projects.html: Remove the "Table:" label from the
1771 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1773 2011-07-11 Ben Konrath <ben@bagu.org>
1775 Add main groups to the details view.
1777 This makes things look a little nicer in the details view. The next step
1778 is to implement the flowtable.
1780 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1781 resources from the standard gwt css theme. Standard.css is now
1782 included in OnlineGlom.html so that the online glom css rules have
1783 precedence over the gwt theme.
1784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1785 the whole LayoutGroup to the DetailsView instead of just the titles.
1786 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1787 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1788 details layout with a helper class (GroupPanel). I might extract this
1789 class when I make the full flowtable.
1790 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1791 string as default so I don't have to worry about NPEs when processing
1793 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1794 note beside OnlineGlom.gwt.xml above).
1795 * src/main/webapp/style.css: Add default font-size to body to override
1796 the font-size set by the standard theme. Don't use h2 tags for
1797 group-title. Create new details-cell class.
1799 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1801 ConfiguredDocument: Set the port number too.
1803 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1804 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1805 Glom document. Presumably this worked sometimes so far because there is a
1806 default port number.
1808 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1810 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1812 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1813 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1814 correct, though we should throw an exception too.
1816 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1818 Fix a addDocuemnt typo.
1820 * src/main/java/org/glom/web/shared/Documents.java
1821 (Documents.addDocuemnt): Rename to addDocument().
1822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1823 (OnlineGlomServiceImpl.getDocuments): Adapt.
1825 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1827 Slightly improved log output when connection fails.
1829 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1830 (ConfiguredDocument.setUsernameAndPassword):
1831 We don't know for sure if it' the username/password that's wrong, so
1832 rephrase the message.
1833 Also ouput the exception message, though it's generic in this case.
1835 2011-07-08 Ben Konrath <ben@bagu.org>
1839 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1840 added braces to a one line if statement because the Eclipse formatter
1841 was getting confused.
1843 2011-07-07 Ben Konrath <ben@bagu.org>
1845 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1847 These should really be two separate tasks but I counldn't get things to
1848 work with GWT 2.2.0 and Eclipse 3.7.
1852 * .settings/org.eclipse.jdt.core.prefs:
1853 * .settings/org.eclipse.jdt.ui.prefs:
1854 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1855 * .settings/org.eclipse.m2e.core.prefs:
1856 Add new config files. Update current files. Remove references to the
1857 webtools plugins as we're not using any of the webtools features.
1858 * .gitignore: Add logs directory which is created when running with
1860 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1861 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1862 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1864 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1866 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1868 onlineglom.properties: Add explanatory comments.
1870 * src/main/resources/onlineglom.properties: Also change the default user
1871 from ben to someuser, to avoid the risk of people thinking we just
1872 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1874 2011-06-28 Ben Konrath <ben@bagu.org>
1876 Use filename in Log for incorrect passwords.
1878 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1879 getFileName(String) method to get the filename from the URI.
1881 2011-06-28 Ben Konrath <ben@bagu.org>
1883 Add the table name to the URL token for the ListPlace.
1885 This makes things consistent between the DetailsPlace and the
1886 ListPlace. It also allows the the ListPlace to be bookmarked.
1888 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1889 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1891 Remove getDefaultListLayout(). The default layout is now returned
1892 by the getListLayout() method when the table name is an empty string.
1893 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1894 Add table name field. Change to a new ListPlace when the table
1895 has been changed. Use getListLayout() for getting the default
1897 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1898 Add table name field. Set the correct table name in the list box
1899 when loading from bookmark. This corrects a problem for the
1901 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1902 Move table name to super-class (HasSelectableTable). Move document
1903 and table URL keys to super-class in HasSelectableTable.
1904 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1905 Add table name field. Add Tokenizer class with URL key common to
1906 the subclasses (DetailsPlace and ListPlace).
1907 * src/main/java/org/glom/web/client/place/ListPlace.java:
1908 Add table name. Add code to parse the URL token.
1909 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1910 Update ListPlace construction with empty table name string.
1911 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1912 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1913 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1914 Update ListPlace construction with table name string.
1915 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1916 Change defaultTableName field to tableName to reflect how it's now
1917 used. Update the getter and setter methods.
1919 2011-06-28 Ben Konrath <ben@bagu.org>
1921 Enable the table selector in the DetailsView.
1923 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1924 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1926 Remove getDefaultDetailsLayout(). The default layout is now returned
1927 by the getDetailsLayout() method when the table name is an empty
1929 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1930 event handler for table change event. Change to using
1931 getDetailsLayout() for the default details layout.
1932 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1935 when navigating to the details place.
1937 2011-06-27 Ben Konrath <ben@bagu.org>
1939 Use filename based unique document ID in URL and for RPC.
1941 The document ID is the glom document name with spaces (' ') replaced
1942 with pluses ('+') and without the .glom extension.
1944 This change is mostly a string substitution of 'documentTitle' for
1945 'documentID'. The only code change is the addition of a Documents DTO to get the
1946 filename to document title mappings as indicated below.
1948 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1949 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1950 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1951 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1952 Use Documents DTO to create the document links in the document
1954 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1955 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1956 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1957 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1958 * src/main/java/org/glom/web/client/place/ListPlace.java:
1959 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1960 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1961 * src/main/java/org/glom/web/client/ui/ListView.java:
1962 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1963 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1964 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1965 * src/main/java/org/glom/web/server/Log.java:
1966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
1967 getDocumentTitles() to getDocuments() and return the Documents DTO.
1968 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
1969 transferring the filename to document title mappings.
1971 2011-06-25 Ben Konrath <ben@bagu.org>
1973 Make the authentication popup work again.
1975 This bug was introduced when I extracted ConfiguredDocument to its own class.
1977 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
1978 correct success / fail status in setUsernameAndPassword().
1980 2011-06-25 Ben Konrath <ben@bagu.org>
1982 Use filename as unique key for configuring database usernames and passwords.
1984 This replaces the use of the Glom document title which could change
1985 depending on the locale. Thanks to Murray Cumming for pointing out this
1988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1989 * src/main/resources/onlineglom.properties:
1991 2011-06-24 Ben Konrath <ben@bagu.org>
1993 Pass primary key value to DetailsView.
1995 This enables the DetailsView to load the correct data.
1997 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1998 primary key value field and set in constructor. Pass primary key
1999 value to getDetailsData().
2000 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2001 variables for document title and primary key value.
2002 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2003 key value to the DetailsPlace.
2005 2011-06-24 Ben Konrath <ben@bagu.org>
2007 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2009 This allows the primary key to be retrieved by the Details button. This
2010 functionality has not been implemented yet but it's in the works.
2012 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2013 the LayoutGroup result to ListView.setCellTable instead of all of its
2014 fields individually.
2015 * src/main/java/org/glom/web/client/ui/ListView.java:
2016 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2017 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2018 get the primary key for the table.
2019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2020 index of the primary key in the LayoutGroup accounting for hidden
2021 primary keys. Rename getJavaNumberFormat() to
2022 convertToJavaNumberFormat() for consistency. Cleanup / add some
2024 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2025 field for primary key index and a field to indicate whether the
2026 primary key is hidden or not.
2028 2011-06-23 Ben Konrath <ben@bagu.org>
2030 Rename getTableData methods to getListData.
2032 This is a rename refactor for consistency with other methods.
2034 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2035 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2036 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2039 2011-06-23 Ben Konrath <ben@bagu.org>
2041 Extract the ConfiguredDocument innerclass into its own class.
2043 This makes the servlet code more object oriented.
2045 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2046 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2048 new ConfiguredDocument class.
2050 2011-06-21 Ben Konrath <ben@bagu.org>
2052 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2054 This makes things more inline with how libglom works and reduces code
2055 duplication. This refactor lays the groundwork for adding the primary key to
2056 the LayoutGroup object.
2058 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2059 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2061 Change method names to getListLayout and getDefaultListLayout for
2062 consistency. Use LayoutGroup as the DTO for the list layout instead of
2063 ColumnInfo and LayoutListTable.
2064 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2065 new method names along with the LayoutGroup object for transferring the
2067 * src/main/java/org/glom/web/client/ui/ListView.java:
2068 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2069 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2070 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2072 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2073 Replaced with LayoutGroup.
2074 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2075 expectedResultSize and defaultTableName fields which are needed for
2077 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2078 type field which is needed for the list layout but will also be
2079 useful for the details layout as things progress.
2080 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2081 Make class abstract. Remove the unnecessary
2082 getFormattingHorizontalAlignment method. Add setFormatting method.
2084 2011-06-16 Ben Konrath <ben@bagu.org>
2086 Add scripts for building and installing war.
2088 These will help when updating OnlineGlom but they're also good
2089 supplemental documentation of the build and deployment proceeding.
2091 * utils/build-onlineglom-war.sh: New file.
2092 * utils/install-onlineglom-war.sh: New file.
2094 2011-06-16 Ben Konrath <ben@bagu.org>
2096 Create wrapper class to create consistent log messages.
2098 I wrapped methods in the Log class of gwt-log to add the method names
2099 from the servlet and create consistent formatting of the document title
2100 and table names in the log messages.
2102 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2104 log methods to use methods from wrapped Log class.
2106 2011-06-16 Ben Konrath <ben@bagu.org>
2108 Remove superfluous conditional return.
2110 Thanks to Murray Cumming for pointing this out!
2112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2114 2011-06-15 Ben Konrath <ben@bagu.org>
2116 Return an ArrayList of LayoutGroups for the Details layout.
2118 This corrects a problem with the details layout as it can have more
2119 than one top level LayoutGroup.
2121 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2122 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2123 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2124 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2126 with ArrayList of LayoutGroups for the details view layout.
2127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2128 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2129 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2130 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2131 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2132 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2134 2011-06-14 Ben Konrath <ben@bagu.org>
2136 Use cast_dynamic method to determine the libglom LayoutItem type.
2138 This is better than finding the LayoutItem type by using the string
2139 returned from the get_part_type_name() method.
2141 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2143 2011-06-14 Ben Konrath <ben@bagu.org>
2145 Add method names to log entries in the servlet.
2147 This helps when tracking down deployment problems.
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2151 2011-06-14 Ben Konrath <ben@bagu.org>
2153 Add data to the DetailsView using a hard-coded primary key value.
2155 The layout and functionality of the DetailsView is not complete. This
2156 is just a checkpoint so the patch doesn't get too big.
2158 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2159 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2160 Add getDetailsData() servlet method.
2161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2162 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2163 LayoutFields are added to the DetailsView.
2164 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2165 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2166 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2167 take the string for the title instead of the object.
2168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2169 Add implementation getDetailsData() along with some private helper
2171 * src/main/webapp/style.css: Add padding to details-data class. Add a
2172 details-label class with the same padding as the details-data class.
2174 2011-06-03 Ben Konrath <ben@bagu.org>
2176 Use presenter.goTo() to change to the DetailsPlace.
2178 This will make things easier when we need to open the DetailsView with
2179 data specific to the row that was clicked.
2181 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2183 2011-06-02 Ben Konrath <ben@bagu.org>
2185 Add CSS file from mockups.
2187 I'm adding this now because it's going to be useful to have when
2188 developing the DetailsView. The TableSelectionView and ListView aren't
2191 * src/main/webapp/OnlineGlom.html:
2192 * src/main/webapp/style.css:
2194 2011-06-02 Ben Konrath <ben@bagu.org>
2196 Use String.isEmpty() to check for empty string.
2198 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2200 2011-06-02 Ben Konrath <ben@bagu.org>
2202 Display main layout group titles in the DetailsView.
2204 This is the start of the DetailsActivity/DetailsView implementation.
2206 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2207 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2208 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2209 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2210 Get the layout information for the details view from the server and set
2211 the main layout group titles.
2212 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2213 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2214 Add addLayoutGroup() and addLayoutField() methods. This are just
2215 temporary methods for creating the the details view that will change
2217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2218 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2220 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2221 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2222 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2223 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2224 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2225 Data Transfer Objects that mimic the libglom object structure. These are
2226 used for transferring the details layout but could also be used for
2227 transferring the list layout.
2229 2011-05-27 Ben Konrath <ben@bagu.org>
2231 Reset the AuthenticationPopup when clearing the ListView.
2233 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2235 2011-05-27 Ben Konrath <ben@bagu.org>
2237 Fix problem with onlineglom.properties file loading.
2239 The old way worked in Eclipse but not on the server. Loading the
2240 onlineglom.properties file now works in Eclipse and on the server.
2242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2244 2011-05-24 Ben Konrath <ben@bagu.org>
2246 Update gwt-log from 3.1.0 to 3.1.2.
2248 Gwt-log 3.1.0 has been marked as depreciated.
2252 2011-05-24 Ben Konrath <ben@bagu.org>
2254 Add comment to ListActivity.goTo() method.
2256 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2258 2011-05-24 Ben Konrath <ben@bagu.org>
2260 Remove FIXME in convertGdkColorToHtmlColour()
2262 The Gdk::Color value returned by libglom is 16-bits per channel on both
2263 64 and 32-bit platforms.
2265 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2267 2011-05-19 Ben Konrath <ben@bagu.org>
2269 Improve performance of initial ListView load.
2271 I removed a round trip to the server for getting the default table name
2272 and then requesting information about that table. This also removes a potential
2273 problem with the table change handler not being setup in time to receive the
2274 table change event from the ListActivity.
2276 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2277 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2278 getDefaultLayoutListTable() method. Improve comments.
2279 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2280 getDefaultLayoutListTable() method instead of firing a table change
2281 event to get the table to load.
2282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2283 implementation of getDefaultLayoutListTable() method.
2284 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2287 2011-05-19 Ben Konrath <ben@bagu.org>
2289 Override toDebugString() in TableChangeEvent.
2291 This is useful to have for debugging.
2293 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2295 2011-05-19 Ben Konrath <ben@bagu.org>
2297 Add a "Back to List" link when at the DetailsPlace.
2299 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2300 Populate the CellTable based on the selected table of the ListBox if
2301 it's set otherwise use the default table. This allows the "Back to
2303 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2304 Remove Place from constructors. Add a setPlace() method. Add
2305 goToPlace() method. Set class as presenter for TableSelectionView.
2306 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2307 Use the same TableSelectionActivity when switching between the List and
2309 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2310 Subclass the new HasSelectableTablePlace. This removes some duplicate
2312 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2313 New class to represent Places that display the TableSelectionView.
2314 * src/main/java/org/glom/web/client/place/ListPlace.java:
2315 Subclass the new HasSelectableTablePlace. This removes some duplicate
2317 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2318 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2319 Add Presenter interface. Add setBackLinkVisible() method. Add
2320 setBackLink() method.
2322 2011-05-18 Ben Konrath <ben@bagu.org>
2324 Enable the "Details" buttons.
2326 Right now only an empty details view is displayed.
2328 * src/main/java/org/glom/web/client/ClientFactory.java:
2329 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2330 Add DetailsView to ClientFactory.
2331 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2332 A basic activity for the details view.
2333 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2334 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2336 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2337 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2339 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2340 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2341 unnecessary super() in constructor.
2342 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2343 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2344 really shouldn't create a new TableSelectionActivity for both the ListPlace
2345 and the DetailsPlace so this should be considered a temporary solution.
2346 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2347 New file. Represents a URL for the details view.
2348 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2349 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2350 A basic details view interface and implementation.
2351 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2352 Enable the "Details" buttons.
2354 2011-05-12 Ben Konrath <ben@bagu.org>
2356 Use a LayoutPanel with multiple display areas for main layout.
2358 This is mostly a refactor in that there are no changes from the user
2359 point of view. These changes are required so that we can swap out the list view
2360 with the details view when the user clicks the "Details" button.
2362 * src/main/java/org/glom/web/client/ClientFactory.java:
2363 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2364 OnlineGlomView. Add TableSelectionView, ListView and
2365 AuthenticationPopup.
2366 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2367 for main layout. Add display regions for main activities. Add
2368 activity manager for for main activities.
2369 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2370 file from parts of the deleted OnlineGlomActivity.
2371 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2372 New file from parts of the deleted OnlineGlomActivity.
2373 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2374 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2375 New files for app wide table change event.
2376 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2377 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2378 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2379 Activity mappers for the main activities replace the deleted app-wide
2381 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2382 Fix a spelling error in he comment.
2383 * src/main/java/org/glom/web/client/ui/ListView.java:
2384 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2385 Renamed from LayoutListView and modified for MVP. This still not a
2386 proper dumb view as prescribed by the MVP pattern but it works for now.
2387 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2388 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2389 New widget stripped out of the deleted OnlineGlomView.
2390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2391 Remove hack that is fixed by this patch.
2393 2011-05-06 Ben Konrath <ben@bagu.org>
2395 Rename OnlineGlomPlace to ListPlace.
2397 The only change besides the rename is that url will now display #list
2398 instead of #Document.
2400 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2401 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2402 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2403 * src/main/java/org/glom/web/client/place/ListPlace.java:
2404 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2406 2011-05-06 Ben Konrath <ben@bagu.org>
2408 Use Presenter for app navigation.
2410 This is the proper way to deal with Place (URL) changes with the MVP
2413 * src/main/java/org/glom/web/client/ClientFactory.java:
2414 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2415 PlaceHistoryMapper and PlaceHistoryHandler.
2416 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2417 PlaceHistoryMapper and PlaceHistoryHandler.
2418 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2419 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2420 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2421 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2422 Add Presenter interface and setPresenter methods. Rename addHyperLink
2423 to addDocumentLink taking only the document title as a parameter.
2425 2011-04-14 Ben Konrath <ben@bagu.org>
2427 Prompt for db username/password if they haven't been set.
2429 This is implemented with a popup widget that is contained within the
2430 OnlineGlomView and managed by the OnlineGlomActivity.
2432 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2433 methods for checking and setting the database username and password.
2434 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2435 new methods for checking and setting the database username and
2437 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2438 Display authentication popup if the JDBC connection to the database
2439 has not been authenticated.
2440 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2442 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2443 for dealing with the authentication popup.
2444 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2445 Implement the methods for dealing with the authentication popup.
2446 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2447 try to executed queries if the database connection hasn't been
2448 authenticated. Implement methods for checking and setting the
2449 database username and password.
2451 2011-04-12 Ben Konrath <ben@bagu.org>
2453 Make log messages a little clearer.
2455 Add a dash betweeen the document title and the table name.
2457 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2459 2011-04-12 Ben Konrath <ben@bagu.org>
2461 Protect against NPEs when cleaning up database resources.
2463 While this isn't strictly necessary because the exception is caught,
2464 not protecting against the NPEs makes it harder to find the real error
2467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2469 2011-04-12 Ben Konrath <ben@bagu.org>
2471 Move configuration of the servlet to the constructor.
2473 The servlet will be initialized even if the database authentication
2474 information is not set or correct. I still need to add the UI for prompting
2475 the user for the authentication information when it's required.
2477 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2478 javadocs for getDocumentTitles() method.
2479 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2480 Set error message when RPC fails.
2481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2482 glom files directory from the configuration file. Try to set the
2483 database authentication information for the specific document if it's
2484 set and works otherwise try to use the global authentication
2485 information set for the directory.
2486 * src/main/resources/onlineglom.properties: Moved from
2487 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2488 Added detailed comments for the new keys.
2490 2011-04-11 Ben Konrath <ben@bagu.org>
2492 Remove unnecessary @Override in DocumentSelectionViewImpl.
2494 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2496 2011-04-11 Ben Konrath <ben@bagu.org>
2498 Remove center alignment in DocumentSelectionView.
2500 The title element is still centred but the document titles and bottom
2501 sentence are both left-aligned.
2503 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2505 2011-04-11 Ben Konrath <ben@bagu.org>
2507 Change 'Demo' naming convention to 'Document'.
2509 This is just a rename refactor with no functional changes to the code.
2511 * src/main/java/org/glom/web/client/ClientFactory.java:
2512 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2513 * src/main/java/org/glom/web/client/OnlineGlom.java:
2514 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2515 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2516 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2517 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2518 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2519 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2520 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2521 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2522 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2523 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2525 2011-04-08 Ben Konrath <ben@bagu.org>
2527 Remove FIXME from safeLongToInt() method.
2529 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2532 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2534 2011-04-08 Ben Konrath <ben@bagu.org>
2536 Display an error if no glom documents are found in the specified directory.
2538 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2539 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2540 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2543 2011-04-08 Ben Konrath <ben@bagu.org>
2545 Add copyright header to one more file ... oops.
2547 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2549 2011-04-08 Ben Konrath <ben@bagu.org>
2551 Add copyright header to files without it.
2553 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2554 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2555 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2556 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2557 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2558 * src/main/java/org/glom/web/shared/GlomField.java:
2560 2011-04-08 Ben Konrath <ben@bagu.org>
2562 Add support for accessing multiple glom documents in the servlet.
2564 This completes the demo selection functionality.
2566 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2567 document title to methods.
2568 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2569 document title to methods.
2570 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2571 Set browser window title when the activity starts. Correct name of
2572 document title variable.
2573 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2574 Set browser window title when the activity starts. Set the table
2575 selector change handler after table selector has been set. Clear the
2576 OnlineGlomView when the activity has been stopped.
2577 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2578 document title as the place token. Use "#Document:" instead of
2579 "#OnlineGlomPlace:" in the URL.
2580 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2581 Change heading to "Online Glom"
2582 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2583 document title in RPC methods.
2584 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2585 setDocumentTitle() method. Add clear() method.
2586 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2587 setDocumentTitle() method. Implement clear() method which removes the
2588 change handler on the ListBox, clears the ListBox and clears the
2590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2591 Implement methods with document title. Keep track for the configured
2592 glom documents and their corresponding JDBC configurations in a hash
2593 table. This information is retrieved using the document title as the
2594 key in the hash table.
2595 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2596 document title field as it's no longer needed.
2598 2011-04-08 Ben Konrath <ben@bagu.org>
2600 Update the Eclipse JDT configuration.
2602 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2603 methods. Automatically add the copyright header to new files.
2605 2011-04-05 Ben Konrath <ben@bagu.org>
2607 Add new page for demo selection.
2609 This patch adds all the components required to view and start an
2610 OnlineGlom demo by clicking on the desired hyperlink. The user is
2611 able to return to the demo selection page with the browser's back
2612 button. I still need to modify the servlet to work with multiple
2613 documents so all demo links will load the file defined in the
2614 OnlineGlom.properties.
2616 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2617 This is only useful during development so we don't need to save it.
2618 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2619 get a reference to the DemoSelectionView.
2620 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2621 method to get a reference to the DemoSelectionView.
2622 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2623 default view to DemoSelectionView.
2624 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2625 to get glom document titles for glom files in a hard-coded directory.
2626 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2627 method to get glom document titles for glom files in a hard-coded
2629 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2630 Presenter for DemoSelectionView.
2631 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2632 for DemoSelectionView.
2633 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2634 Update for DemoSelectionView.
2635 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2636 Basic 'Place' implementation for the DemoSelectionView.
2637 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2638 The interface for the DemoSelectionView.
2639 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2640 The implementation of the DemoSelectionView.
2641 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2642 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2644 implementation of method to get glom document titles for glom files
2645 in a hard-coded directory.
2646 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2647 on longer being used.
2648 * src/main/webapp/glom.png: Glom logo.
2650 2011-04-05 Ben Konrath <ben@bagu.org>
2652 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2654 This is the forth and final commit of a refactor that will allow
2655 OnlineGlom to be used with multiple documents.
2657 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2658 Move RPC code from OnlineGlomViewImpl to this class.
2659 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2661 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2662 RPC code to the presenter class (the P in MVP).
2664 2011-04-04 Ben Konrath <ben@bagu.org>
2666 Start moving the existing OnlineGlom code to MVP.
2668 This work is based on the GWT MVP framework that is documented here:
2670 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2672 This is the third commit of a refactor that will allow OnlineGlom to
2673 be used with multiple documents.
2675 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2676 Interface for client factory which is used to get instances of various
2677 classes throughout the app.
2678 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2679 Implementation of client factory.
2680 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2681 initialize the MVP framework.
2682 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2683 New file. Activity manager for the main container widget. This is the
2685 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2686 Maps place (URL) to its corresponding activity.
2687 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2688 New file. This is just a place holder for a generated file.
2689 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2690 New file. Represents the URL for the main Online Glom app.
2691 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2692 for changes in LayoutListViewImpl.
2693 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2694 interface for View. Move code to OnlineGlomViewImpl class.
2695 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2696 file. Implementation of OnlineGlomView.
2697 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2698 Place resources. Use ClientFactoryImpl by default.
2700 2011-04-04 Ben Konrath <ben@bagu.org>
2702 Move View classes to their own package.
2704 This is the second commit of a refactor that will allow OnlineGlom to
2705 be used with multiple documents.
2707 * src/main/java/org/glom/web/client/OnlineGlom.java:
2708 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2709 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2711 2011-04-02 Ben Konrath <ben@bagu.org>
2713 Move UI code from the main module to its own class.
2715 This is the first commit of a refactor that will allow OnlineGlom to be
2716 used with multiple documents.
2718 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2719 references to OnlineGlom to OnlineGlomView.
2720 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2721 OnlineGlomView and instantiate it here.
2722 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2723 represents the main OnlineGlomView with one document.
2725 2011-04-01 Ben Konrath <ben@bagu.org>
2727 Fix formatting of gwt.xml and add DTD.
2729 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2731 2011-03-30 Ben Konrath <ben@bagu.org>
2733 Propperly convert gdkColor string to html colour string.
2735 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2737 2011-03-28 Ben Konrath <ben@bagu.org>
2739 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2741 This implementation matches
2742 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2743 readable and is not tied to Swig.
2745 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2747 2011-03-28 Ben Konrath <ben@bagu.org>
2749 Use read-only checkboxes for boolean field types.
2751 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2752 in the CellTable based on the field type. It currently only
2753 distinguishes between boolean and text columns but I'll need to add
2754 support for more types.
2755 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2756 column type in the ColumnInfo object. Add method to convert between the
2757 glom field type enum in ColumnInfo and the glom field type in libglom.
2758 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2760 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2761 getting and setting booleans.
2763 2011-03-25 Ben Konrath <ben@bagu.org>
2765 Don't get the Date twice from the ResultSet.
2767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2769 2011-03-25 Ben Konrath <ben@bagu.org>
2771 Cleanup code in the servlet.
2773 * TODO: Remove item about row count. Add item about testing row count
2774 query with large number of rows.
2775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2776 spelling mistakes, change method parameter to be consistent with
2779 2011-03-25 Ben Konrath <ben@bagu.org>
2781 Add server side logging with the gwt-log library.
2783 * .gitignore: Ignore the log file we're now producing.
2784 * TODO: Add a couple TODO item for logging.
2785 * pom.xml: Add gwt-log and log4j as a dependency.
2786 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2787 logging of errors, warnings and some important info.
2788 * src/main/resources/log4j.properties: New file to configure log4j.
2790 2011-03-24 Ben Konrath <ben@bagu.org>
2792 Add a disable button for the Details view.
2794 * src/main/java/org/glom/web/client/LayoutListView.java:
2796 2011-03-22 Ben Konrath <ben@bagu.org>
2798 Use a count query to get the number of rows for the list view pager.
2800 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2802 2011-03-22 Ben Konrath <ben@bagu.org>
2804 Add more TODO information about CellTable pager positioning.
2808 2011-03-19 Ben Konrath <ben@bagu.org>
2810 Add TODO item about CellTable pager positioning.
2814 2011-03-18 Ben Konrath <ben@bagu.org>
2816 Remove unneeded GlomFieldColumn class.
2818 This is just a small code cleanup.
2820 * src/main/java/org/glom/web/client/LayoutListView.java:
2822 2011-03-18 Ben Konrath <ben@bagu.org>
2824 Use cursor mode in the query that gets data for the list view.
2826 I still need to fix the potential memory problem when getting the row
2827 count for the list view.
2829 * TODO: Add note about testing memory usage with large data sets. Add
2830 item about fixing row counting with large data sets.
2831 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2832 PostgreSQL JDBC driver into cursor mode when getting data for the
2835 2011-03-15 Ben Konrath <ben@bagu.org>
2837 Remove the GWT Container from the Eclipse build classpath.
2839 The GWT dependencies are set by Maven so this isn't needed.
2843 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2845 Added some earlier mockups to git, but not to the tarball dist.
2847 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2848 Openismus. These hopefully show how we might structure the HTML so that
2849 it can be styled easily with CSS. However, we probably need to adapt them
2850 for the CSS structure that GWT dictates for common widgets.
2852 2011-03-14 Ben Konrath <ben@bagu.org>
2854 Locate OnlineGlom.properties using the ServletContext.
2856 This is required to be able to locate the file in the deployed servlet.
2858 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2859 Configure the database and glom document in in a helper method so
2860 that the ServletContext can be used to locate OnlineGlom.properties.
2861 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2862 src/main/webapp. This is the proper location for .properites files.
2864 2011-03-12 Ben Konrath <ben@bagu.org>
2866 Add note to README about why we're compiling down to obfuscated JavaScript.
2870 2011-03-11 Ben Konrath <ben@bagu.org>
2872 Use properties file to configure servlet.
2874 This allows people to change the glom file path, db username and db
2875 password without recompiling the code.
2877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2878 * src/main/webapp/OnlineGlom.properties:
2880 2011-03-11 Ben Konrath <ben@bagu.org>
2882 Use table fields in layout list view if the layout list is not defined.
2884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2885 Manually create a LayoutFieldVector for the query builder using the
2886 table fields when a layout list is not defined in the glom file.
2888 2011-03-11 Ben Konrath <ben@bagu.org>
2890 Only show FIXME string for images when there's an image.
2892 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2893 in this change are some small code cleanups.
2895 2011-03-11 Ben Konrath <ben@bagu.org>
2897 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2901 2011-03-11 Ben Konrath <ben@bagu.org>
2903 Correctly set the index of the default table.
2905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2906 Correctly set the index of the default table. Add commented out example
2909 2011-03-10 Ben Konrath <ben@bagu.org>
2911 Add comment to pom.xml about the previous change.
2913 * pom.xml: Add comment about the deployment issue so that it's obvious
2914 why java-libglom is set to the provided scope.
2916 2011-03-10 Ben Konrath <ben@bagu.org>
2918 Change java-libglom dependency from compile to provided in pom.xml.
2920 Since java-libglom uses jni it can only be loaded once and therefore
2921 must be placed in $CATALINA_HOME/lib and not included in each war.
2922 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2923 More information about this issue can be found in the Tomcat 6 release
2924 notes in the "JNI Based Applications" section:
2926 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2928 * README: Remove note about this issue. Deployment info should really
2929 be on the wiki anyway so I'll add it right now.
2930 * pom.xml: Change java-libglom dependency from compile to provided so
2931 that it's copied in to the packaged war.
2933 2011-03-09 Ben Konrath <ben@bagu.org>
2935 Change to using a neutral locale for currency, date and time formatting.
2937 This solves the problem of currency values being represented without a
2938 space between the currency code and the number (e.g. "EUR5.89" is now
2939 represented as "EUR 5.89"). More work is required when we implement
2940 a locale preference setting.
2942 * TODO: Add note about currency formatting issues with different
2944 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2945 to using the neutral ROOT locale.
2947 2011-03-09 Ben Konrath <ben@bagu.org>
2949 Add support for currency codes that are not ISO 4217 codes.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2952 the currency code defined in the glom file when it's not 3 characters
2953 long or when Java doesn't recognize the string as an ISO 4217 code.
2955 2011-03-08 Ben Konrath <ben@bagu.org>
2957 Remove test classes, launch configurations and configuration.
2959 The test stuff was getting in the way when creating the war. To make
2960 the war file you can now do 'mvn clean package'. The packaged war file
2961 will be in the target directory.
2963 * .classpath: Remove unused classpathentry for tests and i18n.
2964 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
2965 property. Don't run test or i18n goals when packaging the war.
2966 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
2971 * OnlineGlomTest-dev.launch:
2972 * OnlineGlomTest-prod.launch:
2973 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2974 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
2976 2011-03-07 Ben Konrath <ben@bagu.org>
2978 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
2980 These fixes allow me to use 'mvn deploy' to create the war file.
2982 * .classpath: This generated config has been updated by Eclipse. This
2983 change was probably triggered by me updating from Eclipse 3.6.1 to
2985 * .gitignore: Add entry to ignore the directory
2986 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
2987 * .project: The generated config has been updated by Eclipse. This
2988 change was probably triggered by me updating from Eclipse 3.6.1 to
2990 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
2991 so that Eclipse doesn't complain
2992 * pom.xml: Update to gwt-maven-plugin 2.2.0.
2993 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
2994 'tests' directory to 'client' directory. This is the new
2995 gwt-maven-plugin convension.
2996 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
2997 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
2999 2011-03-07 Ben Konrath <ben@bagu.org>
3001 Add support for horizontal alignment in the LayoutList columns.
3003 * TODO: Remove item about horizontal alignment. Add item about
3004 improvements to ColumnInfo.
3005 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3006 alignment on the columns. Use ColumnInfo RPC object get the column
3007 title and horizontal alignment.
3008 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3009 LayoutListView creation with ColumnInfo RPC object.
3010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3011 a ColumnInfo object for every LayoutList columnn. Convert the
3012 FieldFormatting.HorizontalAlignment to the correct
3013 ColumnnInfo.HorizontatlAlignment with the new
3014 getColumnInfoHorizontalAlignment helper method.
3015 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3016 to encapsulate column information like alignment and title. This
3017 could be used to set the colour instead of on a per cell field basis.
3018 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3019 column title storage and retrieval with ColumnInfo.
3021 2011-03-04 Ben Konrath <ben@bagu.org>
3023 Add support for column sorting.
3025 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3026 AsynDataProvider to be an anonymous inner class. Use new
3027 getSortedTableData RPC method when column sort is requested. Set all
3028 columns sortable and add an AsyncHandler to activate sorting in the
3030 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3031 method getSortedTableData(). Cleanup other method signatures.
3032 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3033 new method getSortedTableData(). Cleanup other method signatures.
3034 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3035 Implement getSortedTableData() and getTableData() methods by using a
3036 private helper method with the appropriate parameters filled in. Use
3037 user supplied sort clause when supplied, otherwise fall back to
3038 sorting by the primary key. Move destroy() method to be underneath
3039 constructor for readability. Cleanup comments.
3041 2011-03-03 Ben Konrath <ben@bagu.org>
3043 Add support for colour text and colour backgrounds to the layout list cells.
3045 Only the cell backgrounds are coloured which leaves a gap between the
3046 cells that isn't coloured. I need to figure out a way to set
3047 'style=background-colour:' on the whole column rather than just the
3050 * TODO: Add a note about colouring the background of the whole column.
3051 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3052 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3053 render the coloured text and backgrounds. Use GlomField[] for the row type.
3054 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3057 GlomField[] for the row type.
3058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3059 GlomField[] for the row type. Set the text, text colour and background
3060 colour in the GlomField objects as specified in the glom document. Add
3061 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3062 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3063 the glom field text, foreground colour and background colour.
3065 2011-03-02 Ben Konrath <ben@bagu.org>
3067 Don't display hidden tables in the combo box.
3069 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3071 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3072 code to ignore hidden tables using ArrayLists for the table names and
3074 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3075 tableNames to use ArrayLists instead of String[]. Update getter and setter
3078 2011-03-01 Ben Konrath <ben@bagu.org>
3080 Add support for Date and Time number types.
3082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3083 Implement formatting for Date and Time values. Change the default glom
3084 file to small business example.
3086 2011-03-01 Ben Konrath <ben@bagu.org>
3088 Add support for formatting glom types as specified in the glom file.
3090 Formatting isn't finished yet - I still need to add support for Date
3093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3094 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3095 checks for null values in JDBC cleanup code and catch all exceptions
3096 instead of just SQLExceptions.
3097 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3100 2011-03-01 Ben Konrath <ben@bagu.org>
3102 Use GWT 2.2.0 instead of 2.1.1.
3104 * pom.xml: Change GWT version numbers.
3106 2011-03-01 Ben Konrath <ben@bagu.org>
3108 A few small code cleanups.
3110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3112 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3113 unnecessary object creation in constructor.
3114 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3115 unnecessary object creation in constructor.
3117 2011-02-28 Ben Konrath <ben@bagu.org>
3119 Add file for TODO list.
3123 2011-02-18 Ben Konrath <ben@bagu.org>
3125 Enable the CellTable Pager when more than 20 rows need to be viewed.
3127 The Pager will automatically become active when the results are larger
3128 than the CellTable size which is currently set to 20 lines.
3130 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3131 name on debug statment in RPC call in LayoutListDataProvider, add
3132 numRows parameter to LayoutListView constructor, propperly set rowCount
3134 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3135 name on debug statment in RPC call, use LayoutListTable object in RPC
3136 calls, pass rowCount to LayoutListView.
3137 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3138 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3140 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3141 interface for changes in OnlineGlomService.
3142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3143 getLayoutListHeaders() to getLayoutListTable() and return
3144 LayoutListTable. Using this object allows me to pass other information
3145 about the LayoutList like the expected number of rows in the result set.
3146 The Connection object from the connection pool is now propperly closed.
3147 Only the requested number of lines are returned to the client in
3149 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3150 GlomTable and add columnTitles and numRows.
3152 2011-02-18 Ben Konrath <ben@bagu.org>
3154 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3156 This is a small performance boost. I'll use GlomTable to get the required
3157 layoutlist information.
3159 * src/main/java/org/glom/web/client/OnlineGlom.java:
3160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3161 * src/main/java/org/glom/web/shared/GlomDocument.java:
3163 2011-02-18 Ben Konrath <ben@bagu.org>
3165 Add option to turn off formatting in JDT formatter preferences.
3167 * .settings/org.eclipse.jdt.core.prefs:
3169 2011-02-18 Ben Konrath <ben@bagu.org>
3171 Rename LayoutList to LayoutListView.
3173 I'm working towards setting things up to easily use MVP when the time
3176 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3178 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3181 2011-02-17 Ben Konrath <ben@bagu.org>
3183 Move LayoutListDataProvider class into LayoutList.java.
3185 * src/main/java/org/glom/web/client/LayoutList.java:
3187 2011-02-17 Ben Konrath <ben@bagu.org>
3189 Rename RPC service classes from LibGlomService* to OnlineGlomService*.
3191 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Update
3193 * src/main/java/org/glom/web/client/OnlineGlom.java: Update references.
3194 * src/main/java/org/glom/web/client/OnlineGlomService.java: Rename
3195 from LibGlomServer.java.
3196 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3197 Rename from LibGlomServiceAsync.java.
3198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3199 Rename from LibGlomServiceImpl.java.
3200 * src/main/webapp/WEB-INF/web.xml: Update configuration.
3202 2011-02-17 Ben Konrath <ben@bagu.org>
3204 Update JDT settings.
3206 * .settings/org.eclipse.jdt.core.prefs:
3208 2011-02-17 Ben Konrath <ben@bagu.org>
3210 Move GWT-RPC objects to shared package (where they should be).
3212 * src/main/java/org/glom/web/client/LibGlomService.java: Update imports.
3213 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Update imports.
3214 * src/main/java/org/glom/web/client/OnlineGlom.java: Update imports.
3215 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Update imports.
3216 * src/main/java/org/glom/web/shared/GlomDocument.java: Move to
3217 org.glom.web.shared package.
3218 * src/main/java/org/glom/web/shared/GlomTable.java: Move to
3219 org.glom.web.shared package.
3220 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Included shared
3221 directory in compilation to javascript.
3223 2011-02-16 Ben Konrath <ben@bagu.org>
3225 Add sort clause to the sql query that grabs table information.
3227 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add sort clause
3228 if one of the columns is a primary key.
3230 2011-02-16 Ben Konrath <ben@bagu.org>
3232 Disable generateAsync feature of gwt-maven.
3234 The generated interface does not correctly match the methods in LibGlomService
3235 and the generated singleton Util inner-class doesn't respect the servlet