1 2012-05-21 Murray Cumming <murrayc@murrayc.com>
3 Document: loading example data: Handle exceptions.
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 DateFormat.parse() and Double.valueOf() can throw exceptions, though
7 Eclipse did not warn about that.
9 2012-05-20 Murray Cumming <murrayc@murrayc.com>
11 Document: load(), save(): Handle the example rows.
13 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
15 * src/main/java/org/glom/web/server/libglom/Document.java:
16 load(), save(): Load and save the example rows, though the date, time
17 and image types are not handled properly yet.
18 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
19 Add testReadTableExampleRows() just to check that something is read.
21 2012-05-20 Murray Cumming <murrayc@murrayc.com>
25 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
26 Added getTranslationsMap() for use while saving.
27 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
28 Adedd getUseDefaultFormatting() for use while saving.
29 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
30 and several private methods that it uses.
32 This will be useful while testing via self-hosting.
33 It is not complete, but should be complete enough for testing.
35 2012-05-17 Murray Cumming <murrayc@murrayc.com>
37 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
39 * src/main/java/org/glom/web/client/OnlineGlomService.java
40 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
41 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
42 Remove getSortedListViewData() and getSortedRelatedListData(), adding
43 the sort column index and ascending bool to the regular method.
44 Instead, a sort column index of -1 now means no sort.
45 This is less explicit, but it's fairly simple, reduces the amount of
46 code, and makes the OnlineGlomService API slightly smaller.
47 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
48 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
50 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
51 getListViewData(), getRelatedListData():
52 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
53 getListViewData(), getRelatedListData():
54 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
56 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
58 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
63 2012-05-16 Murray Cumming <murrayc@murrayc.com>
65 Use translations for top-level groups too.
67 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
68 updateTitlesForLocale(): Use the translation for the group
69 as well as for child items.
73 Just recompiled to fix a problem in the released .tar.gz file.
77 2012-05-15 Murray Cumming <murrayc@murrayc.com>
79 Corrections to navigation to related records.
81 * src/main/java/org/glom/web/client/OnlineGlomService.java:
82 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
83 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
84 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
85 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
86 relationship name, because the relationship name is not necessarily unique
88 TOOD: This is inefficient, because it passes the whole list of
89 child field items back to the server, but it is more correct, and happens
90 to fix a bug with the primary key being lost after a few navigations.
91 There is probably a chance to make this more efficient anyway in some
94 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
95 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
96 * src/main/java/org/glom/web/server/ConfiguredDocument.java
97 * src/main/java/org/glom/web/server/database/DBAccess.java
98 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
99 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
102 2012-05-15 Murray Cumming <murrayc@murrayc.com>
104 Fix the use of translations.
106 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
107 Add updateTitlesForLocale().
108 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
109 Call it to discard unwanted translations and to make getTitle() return
110 the wanted translation wihout the need for the client code to specify a locale.
111 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
112 getTitle(): Fallback to the original title, as libglom does.
114 2012-05-15 Murray Cumming <murrayc@murrayc.com>
116 Document: Correctly report the number of available translation locales.
118 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
119 the available locale IDs list.
120 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
121 testLocales: Test this.
123 2012-05-15 Murray Cumming <murrayc@murrayc.com>
125 SqlUtils: Use camelCase.
127 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
128 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
129 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
130 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
131 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
132 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
134 2012-05-15 Murray Cumming <murrayc@murrayc.com>
136 Use jOOQ's tableByName() and fieldByName.
138 * pom.xml: Use jOOQ 2.3.1 to get the new API.
139 * src/main/java/org/glom/web/server/SqlUtils.java:
140 build_sql_select_step_with_where_clause(), .createField(),
141 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
142 so we can get correct quoting and escaping. Thanks to Lukas Eder for
143 adding this, and other things, to jOOQ.
145 2012-05-15 Murray Cumming <murrayc@murrayc.com>
147 SqlUtils: Remove the Connection parameters.
149 * src/main/java/org/glom/web/server/SqlUtils.java:
150 build_sql_select_with_key(), build_sql_select_with_where_clause(),
151 createSelect(), build_sql_select_step_with_where_clause(),
152 build_sql_count_select_with_where_clause(),
153 build_sql_select_count_rows(): Remove the Connection parameter because
154 jOOQ does not actually need a connectionwhen it is just used to build
156 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
158 * src/main/java/org/glom/web/server/ReportGenerator.java:
160 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
162 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
163 Constructor, getListData(), getResultSizeOfSQLQuery():
164 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
165 getSelectQuery(), getCountQuery():
166 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
167 getSelectQuery(), getCountQuery():
168 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
169 getNavigationRecord(): Adapted.
171 2012-05-14 Murray Cumming <murrayc@murrayc.com>
175 * src/main/java/org/glom/web/server/SqlUtils.java:
176 get_find_where_clause_quick(): Use a comparison of
177 lowercase values, instead of a simple equals. Regular Glom
178 uses the PostgreSQL ILIKE operator but jOOQ does not
179 support that just yet, though it will soon.
181 2012-05-14 Murray Cumming <murrayc@murrayc.com>
183 TableToViewDetails: Use a real serialization ID.
185 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
186 Though this does not fix the serialization problem.
188 2012-05-12 Murray Cumming <murrayc@murrayc.com>
190 Added LayoutItemPortalDeepCloneTest.
192 2012-05-11 Murray Cumming <murrayc@murrayc.com>
194 Make navigation work again.
196 * src/main/java/org/glom/web/server/libglom/Document.java:
197 Add getLayoutItemFieldShouldHaveNavigation().
198 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
199 Replace get/setAddNavigation() with the partly-existing
200 get/setNavigationTableName(), with an empty string being no navigation,
201 because this is simpler. Use the new
202 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
204 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
205 Add updateFieldsExtras() and call setNavigationTableName in it.
206 getDetailsLayoutGroup(),
207 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
208 createLayout(): Adapted.
209 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
210 Constructor: Adapted.
212 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
213 Replace get/setAddNavigation() with get/setNavigation(), returning a
214 TableToViewDetails class with both the table name and UsesRelationship,
215 because both are need. The previous code used java-libglom's output
216 variable (strangely, via sharedptr) to return both, but we cannot really
218 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
219 getNavigationRecord(): Adapt. However, we cannot actually use the cache
220 here because it somehow gets set to null during deepCopy(). I must test this.
221 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
222 testGetSuitableTableToViewDetails(): Adapted.
224 TODO: Find out why deepClone() is not quite working.
226 2012-05-11 Murray Cumming <murrayc@murrayc.com>
228 DBAccess: Simplify the retrievel of full field details.
230 * src/main/java/org/glom/web/server/database/DBAccess.java
231 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
232 because the Document loading should have done this.
234 2012-05-11 Murray Cumming <murrayc@murrayc.com>
236 Document: Correct loading of doubly-related layout fields.
238 * src/main/java/org/glom/web/server/libglom/Document.java:
239 loadUsesRelationship(): Actually set the related relationship, instead
240 of only setting it if it's not found.
242 2012-05-09 Murray Cumming <murrayc@murrayc.com>
244 Replace all appearances of Colour with color.
246 Because US English is dominant.
248 2012-05-09 Murray Cumming <murrayc@murrayc.com>
250 Use colors in HTML format, solving a warning about an unused function.
252 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
253 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
254 Add *asHTMLColor() versions of methods.
255 TODO: However, we should create and cache the results on the server.
256 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
257 * src/main/java/org/glom/web/client/ui/list/ListTable.java
258 * src/main/java/org/glom/web/server/ConfiguredDocument.java
259 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
260 Use the asHTMLcolor() versions.
262 2012-05-09 Murray Cumming <murrayc@murrayc.com>
264 ListViewTable: Constructor: Take the table name as a parameter.
266 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
267 Constructor: Take the tableName, and set the member variable, because
269 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
270 setCellTable(): Pass the table name.
271 This makes navigation to non-default tables work again. I don't know
272 why it worked before in the master branch.
274 2012-05-07 Murray Cumming <murrayc@murrayc.com>
276 ConfiguredDocument: Restore correct addition of hidden primary key items.
278 * src/main/java/org/glom/web/client/ui/list/ListTable.java
279 (ListTable.createCellTable): Uncomment out the check for the hidden
281 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
282 add primary key items for top-level lists and portals, as before,
283 instead of adding them to each group.
284 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
285 Actually implement the extra methods such as setHiddenPrimaryKey() and
286 comment that these are used only for top-level list groups and in portals.
287 This strangeness suggests even more that this should not be squeezed
288 into the LayoutGroup class.
290 2012-05-07 Murray Cumming <murrayc@murrayc.com>
292 Fix Formatting loading.
294 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
295 getFormattingUsed(): Remove the duplicate Formatting member variable
296 in favour of the one from the base class.
297 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
298 Initialize a new Formatting instead of using null by default, so we
299 have some defaults, instead of having to initialize one later just to
300 get the same defaults. This also makes loading of formatting from the
301 document work, because that expected a non-null.
303 2012-05-07 Murray Cumming <murrayc@murrayc.com>
305 RelatedListTable: Make sure that the tableName is set.
307 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
308 Constructor: Take the tableName so it is available later. Otherwise,
309 the server assumes that we mean the default table and cannot find the
311 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
312 setData(): Pass the tableName to the RelatedListTable constructor.
314 2012-05-07 Murray Cumming <murrayc@murrayc.com>
318 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
319 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
320 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
322 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
324 * src/main/java/org/glom/web/server/database/DBAccess.java:
325 convertResultSetToDTO(), getPortal():
326 * src/main/java/org/glom/web/server/database/ListDBAccess.java
328 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
329 Add checks for null objects and out of range access, with log messages to
330 give hints so we can fix these properly.
332 2012-05-07 Murray Cumming <murrayc@murrayc.com>
334 Portals: some corrections.
336 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
339 constructor: Use getRelationshipNameUsed() instead of getName(), because
340 that is what is meant.
341 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
342 getFromField(): Fix a typo, to get the field name, not the table name.
343 * src/main/java/org/glom/web/server/database/DBAccess.java:
344 getPortal(): Fix a typo that stopped this from working.
346 2012-05-07 Murray Cumming <murrayc@murrayc.com>
348 LayoutItemPortal: Also override getTitleOriginal().
350 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
351 This lets the base getTitle() with no parameters work.
352 TODO: Test this properly.
354 2012-05-06 Murray Cumming <murrayc@murrayc.com>
356 LayoutItemPortal: getTitle*(): Use the relationship title.
358 2012-05-06 Murray Cumming <murrayc@murrayc.com>
360 LayoutItemField: Fix loading of custom titles.
362 * src/main/java/org/glom/web/server/libglom/Document.java
363 loadDataLayoutItemField(): The title, if any, instead of the field
364 title, is stored in a title_custom node. Load it from there.
365 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
367 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
368 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
369 getTitle*() overrides.
370 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
373 2012-05-06 Murray Cumming <murrayc@murrayc.com>
375 LayoutItemField: Fall back to field titles, so some are really shown.
377 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
378 Override getTitleOriginal() and getTitle(), as in java-libglom.
379 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
382 2012-05-06 Murray Cumming <murrayc@murrayc.com>
384 Correct use of setExpectedResultSize().
386 * src/main/java/org/glom/web/server/ConfiguredDocument.java
387 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
388 Use setExpectedResultSize only on top-level groups (for instance, the
389 list layout) or on child portals (in details views).
390 Use the correct table name for portals to avoid SQL errors.
391 Update the expected counts when returning cached layouts.
393 2012-05-06 Murray Cumming <murrayc@murrayc.com>
395 Document: Interpret no group column count as 1.
397 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
398 default, though we now check for this in the UI code anyway.
400 2012-05-06 Murray Cumming <murrayc@murrayc.com>
404 2012-05-06 Murray Cumming <murrayc@murrayc.com>
406 Translatable: Use Hashmap instead of Treemap because GWT supports it.
408 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
409 The use of Treemap lead to this error from async methods, with no
411 "The response could not be deserialized"
413 2012-05-06 Murray Cumming <murrayc@murrayc.com>
415 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
417 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
418 when using the Google -> GWT Compile, or
419 g toolbar button -> GWT Compile Project... feature in Eclipse.
421 2012-05-06 Murray Cumming <murrayc@murrayc.com>
423 ListTable.addColumn(): Protect against a null Formatting.
425 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
426 Create a default Formatting if it is null, because that is the simplest
429 2012-05-06 Murray Cumming <murrayc@murrayc.com>
431 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
433 * src/main/java/org/glom/web/server/ConfiguredDocument.java
434 updateLayoutGroup(): Check that the field is not null.
436 2012-05-06 Murray Cumming <murrayc@murrayc.com>
438 ListViewImpl: Protected against a bad cast error.
440 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
441 onEnterKeyDown(): Do not cast without an instanceof check.
443 2012-05-06 Murray Cumming <murrayc@murrayc.com>
445 ListTable: Protect against an out of range error.
447 * src/main/java/org/glom/web/client/ui/list/ListTable.java
448 createCellTable(): This is unlikely, but can happen while debugging.
450 2012-05-06 Murray Cumming <murrayc@murrayc.com>
452 AsyncMessage onFailure() callbacks: Log the exception message.
454 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
455 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
456 * src/main/java/org/glom/web/client/activity/ListActivity.java:
457 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
458 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
459 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
460 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
461 These are useful clues when something is wrong.
463 2012-05-06 Murray Cumming <murrayc@murrayc.com>
465 ConfiguredDocument: Avoid a null dereference.
467 * src/main/java/org/glom/web/server/ConfiguredDocument.java
468 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
469 details maps are created.
471 2012-05-06 Murray Cumming <murrayc@murrayc.com>
473 Document: Correct the port number parsing.
475 * src/main/java/org/glom/web/server/libglom/Document.java:
476 This lets us actually connect to the database and show the document.
478 2012-05-05 Murray Cumming <murrayc@murrayc.com>
482 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
483 user-interaction, asking us to load a temporary URL in a browser.s
484 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
485 which is apparently necessary for testing the service. See the comment.
486 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
487 Show the exception, if any. This is how I saw the 404 in the HTML in
490 2012-05-05 Murray Cumming <murrayc@murrayc.com>
492 DocumentTest: Move the .glom files into the resources directory.
494 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
495 URI via getResource().
497 2012-05-05 Murray Cumming <murrayc@murrayc.com>
499 Document: Remove the FieldIdentifies inner class.
501 * src/main/java/org/glom/web/server/libglom/Document.java: We only
502 use the Relationship (though the same function in libglom is maybe
503 used in other ways) and so this removes a compiler warning.
505 2012-05-05 Murray Cumming <murrayc@murrayc.com>
507 Document.load() Remove the error code parameter.
509 * src/main/java/org/glom/web/server/libglom/Document.java: load():
510 Remove the parameter. We do not set it yet and it could never have
511 worked as an output parameter (though maybe it did in java-libglom).
512 We could use an exception if we really want the failure reason.
513 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
515 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
516 setUp(), testGetSuitableTableToViewDetails(): Adapt.
518 2012-05-05 Murray Cumming <murrayc@murrayc.com>
520 Make some inner classes static.
522 * src/main/java/org/glom/web/server/ConfiguredDocument.java
523 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
524 * src/main/java/org/glom/web/server/ReportGenerator.java
525 * src/main/java/org/glom/web/server/libglom/Document.java
526 Make all inner classes static that can be static.
528 2012-05-05 Murray Cumming <murrayc@murrayc.com>
530 OnlineGlomServiceImpl: Do not load and check for java-libglom.
532 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
533 init(): We do not use java-libglom any more.
535 2012-05-05 Murray Cumming <murrayc@murrayc.com>
537 Remove mentions of java-libglom.
539 * README: Remove mention of java-libglom, because it no longer needed.
540 * utils/build-onlineglom-war.sh:
541 * utils/check-and-recover-tomcat.py:
542 * utils/install-onlineglom-war.sh: Remove these as they are no longer
543 useful. Building is now far easier, with no need for jhbuild.
545 2012-05-05 Murray Cumming <murrayc@murrayc.com>
547 Fix the build (mvn package)
549 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
550 (LayoutGroup): Make the LayoutItemList inner class static and protected.
551 Otherwise the GWT Java->Javascript compilation fails with just this
552 error, during mvn package or when attempting to view in a browser,
553 in the GWT developer mode in Eclipse.
555 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
556 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
557 [INFO] Compiling module org.glom.web.OnlineGlom
558 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
559 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
560 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
561 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
562 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
563 [INFO] [ERROR] Cannot proceed due to previous errors
565 It has taken me 2 days to find out what was causing that. After reducing
566 the code, the compiler eventually showed me the full error message.
568 2012-05-04 Murray Cumming <murrayc@murrayc.com>
570 ConfiguredDocument: Cache the cloned and stripped layouts.
572 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
573 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
574 layout in a map, so we can retrieve it again without rebuilding it.
576 2012-05-04 Murray Cumming <murrayc@murrayc.com>
578 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
580 2012-05-04 Murray Cumming <murrayc@murrayc.com>
582 libglom classes: Implement some auto-generated emthods.
584 2012-05-04 Murray Cumming <murrayc@murrayc.com>
586 Add GwtTestOnlineGlomService.
588 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
589 However, this (and the other GwtTest*) does not seem to run during
592 2012-05-04 Murray Cumming <murrayc@murrayc.com>
594 Remove use of unsupported features from client code.
596 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
597 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
598 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
599 Use our client version of StringUtils instead of the apache commons one.
601 However, the GWT Javascript compliation still fails.
603 2012-04-25 Murray Cumming <murrayc@murrayc.com>
605 Add a Field class and implement some loading of it in Document.
607 2012-04-25 Murray Cumming <murrayc@murrayc.com>
609 Initial Document loading implementation, instead of libglom.
611 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
612 and Translatable classes, and adapt the rest of the code to use them.
613 However, this is still missing Layout and Field classes and loading.
615 2012-04-24 Murray Cumming <murrayc@murrayc.com>
617 Use of jOOQ: Move Field creation into a utility method.
619 * src/main/java/org/glom/web/server/SqlUtils.java:
620 This lets us improve it more easily.
622 2012-04-24 Murray Cumming <murrayc@murrayc.com>
624 Use of jOOQ: Improve the code to COUNT a sub-select.
626 * src/main/java/org/glom/web/server/SqlUtils.java:
627 Move initial query creation into
628 build_sql_select_step_with_where_clause().
629 build_sql_select_count_rows(): Use the jOOQ API instead of
630 concatentating text, because a jOOQ Select*Step is a TableLike,
631 which is what from() takes.
633 2012-04-23 Murray Cumming <murrayc@murrayc.com>
635 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
637 * pom.xml: Depend on jooq.
638 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
639 methods with jOOQ, based on the C++ implementations in libglom,
640 with some changes to the logic required by jooQ.
641 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
643 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
644 * src/main/java/org/glom/web/server/ReportGenerator.java:
645 * src/main/java/org/glom/web/server/SqlUtils.java:
646 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
647 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
648 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
649 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
650 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
651 Adapt. In particular, the SqlUtils methods now need to take a Connection,
652 because jOOQ needs that, though it seems unnecessary.
654 This is not quite finished. Ideally jOOQ would help us to build
655 table_name.field_name names, quoting and escaping them properly.
656 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
658 2012-04-21 Murray Cumming <murrayc@murrayc.com>
660 Move use of Glom.build_sql*() into a new SqlUtils class.
662 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
663 to wrap Glom.build_sql*(). The parameter types are still Glom one,
664 but this will make it easier to start using something other than
665 libglom or SqlBuilder.
667 2012-04-21 Murray Cumming <murrayc@murrayc.com>
669 Update the project URL.
671 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
673 2012-04-21 Murray Cumming <murrayc@murrayc.com>
675 Main layout: Use a FlowTable instead of absolute positioning.
677 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
678 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
679 child panels/widgets must have an absolute position. But that is annoying, so
680 this adds a FlowTable and puts the child panels in there.
682 2012-04-21 Murray Cumming <murrayc@murrayc.com>
684 GwtTestOnlineGlom: Comment out unused code.
686 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
687 Eclipse has started to say that some code is unused.
689 2012-04-21 Murray Cumming <murrayc@murrayc.com>
691 Update to the latest versions of dependencies.
693 * pom.xml: Update version numbers of dependencies to the latest
695 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
697 * src/main/java/org/glom/web/server/ReportGenerator.java:
698 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
699 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
700 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
702 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
703 Modify the imports where necessary.
705 2012-04-17 Murray Cumming <murrayc@murrayc.com>
707 Style: Remove overflow:hidden from searchbox
709 * src/main/webapp/style.css: Because this pushes the Back To Link
710 label/link on to the next row, which is then hidden due to the
711 hard-coded (in ems) height.
713 2012-04-20 Murray Cumming <murrayc@murrayc.com>
715 Remove some duplicate code.
717 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
718 getDocumentInfo(): This must have been duplicated during the merge from the
723 2012-04-19 Murray Cumming <murrayc@murrayc.com>
725 Reports: Localize the waiting for report message.
727 * src/main/java/org/glom/web/client/activity/ReportActivity.java
728 start(): Get the message from the contants.
729 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
731 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
732 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
733 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
734 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
735 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
736 Update these files with the English text for newer strings for now.
738 2012-04-19 Murray Cumming <murrayc@murrayc.com>
740 Reports: Show a message while waiting for the report.
742 * src/main/java/org/glom/web/client/ui/ReportView.java
743 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
744 Add setWaitingText(), to show a message saying that we are
745 waiting for the report to be ready.
746 * src/main/java/org/glom/web/client/activity/ReportActivity.java
747 start(): Call setWaitingText() before calling the async
750 2012-04-19 Murray Cumming <murrayc@murrayc.com>
752 ReportGenerator: Specify date and time formats.
754 * src/main/java/org/glom/web/server/ReportGenerator.java:
755 createFieldValueElement(): Use the default (and localized)
756 short formats, though we still need a way to show 4-digit
757 years without providing the format for every locale.
758 * src/main/java/org/glom/web/server/database/DBAccess.java:
759 convertResultSetToDTO(): Use the short formats here too.
761 2012-04-18 Murray Cumming <murrayc@murrayc.com>
763 ReportGenerator: Use the correct numeric formatting.
765 * src/main/java/org/glom/web/server/ReportGenerator.java
766 createFieldExpression(), createFieldValueElement(): Take the
767 whole LayoutItem_Field instead of just the field name, so
768 we have access to the formatting.
769 createFieldValueElement(): Use JRTextField.setPattern() to
770 specify the numeric formatting, with the help of a
771 regular DecimalFormat.
773 2012-04-18 Murray Cumming <murrayc@murrayc.com>
775 ReportGenerator: Avoid showing null for group by titles.
777 * src/main/java/org/glom/web/server/ReportGenerator.java
778 generateReport(): Use setBlankWhenNull() on the field title
779 style too, because this is used for values in group by
782 2012-04-18 Murray Cumming <murrayc@murrayc.com>
784 ReportGenerator: Add a colon to titles in vertical groups.
786 * src/main/java/org/glom/web/server/ReportGenerator.java
787 addFieldToDetailBandVertical(): Pass true for the withColon
790 2012-04-18 Murray Cumming <murrayc@murrayc.com>
792 ReportGenerator: Simplify the code by using Position more.
794 2012-04-18 Murray Cumming <murrayc@murrayc.com>
796 Reports: Support vertical groups, roughly.
798 * src/main/java/org/glom/web/server/ReportGenerator.java:
799 addToReport(): Rename to addGroupToReport() and, if necessary,
800 call the new addVerticalGroupToReport() method.
801 createFieldValueElement(): Let the caller specify the Y position
804 2012-04-17 Murray Cumming <murrayc@murrayc.com>
806 Reports: Allow a second report to be shown.
808 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
809 clear(): Do not remove the HTML widget, which broke the whole layout.
811 2012-04-17 Murray Cumming <murrayc@murrayc.com>
813 Locales drop-down: Show that we use English by default.
815 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
816 fillView(): When we use English, just because that is the default, when
817 no locale is specified, show that in the Locales drop-down instead of
818 just showing the first item.
820 2012-04-17 Murray Cumming <murrayc@murrayc.com>
822 Unselect the Report/Locale/Table combo item when appropriate.
824 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
825 setPlace(): clear reportName if this is not a ReportPlace.
826 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
827 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
828 When the provided name is empty, unselect all items, so that none are
829 indicated. This uses a for loop because I cannot find a single method
832 2012-04-17 Murray Cumming <murrayc@murrayc.com>
834 Report: Give the user a way to get back to the list.
836 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
837 start(), setPlace(): Show the Back To List link on reports, and also
838 interpret selecting the empty report item as back to list.
840 2012-04-13 Murray Cumming <murrayc@murrayc.com>
842 Really show the selected Report name.
844 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
845 setPlace(): Store the reportName here, if it is that kind of Place.
846 fillView(): Set the selected Report after filling the list of reports.
847 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
848 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
849 null Strings, though we need some way to unselect all ListBox items
852 2012-04-13 Murray Cumming <murrayc@murrayc.com>
854 ReportGenerator: Try to avoid some problems.
856 * src/main/java/org/glom/web/server/ReportGenerator.java
857 addField(): Try to avoid duplicates, and avoid using a null
860 2012-04-13 Murray Cumming <murrayc@murrayc.com>
862 Reports: Use quickFind.
864 * src/main/java/org/glom/web/client/OnlineGlomService.java;
865 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
867 getReportHTML(): Add a quickFind parameter.
868 * src/main/java/org/glom/web/client/activity/ReportActivity.java
869 start(): Pass the quickFind parameter.
870 * src/main/java/org/glom/web/server/ReportGenerator.java
871 generateReport(): Take a quickFind parameter.
873 2012-04-13 Murray Cumming <murrayc@murrayc.com>
875 ReportPlace: Actually use the report name.
877 * src/main/java/org/glom/web/client/place/ReportPlace.java
878 getPlace(): Do not assign the report name to the quickfind.
880 2012-04-13 Murray Cumming <murrayc@murrayc.com>
882 Show java.library.path when complaining.
884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
885 init(): When telling us to check java.library.path, show the
888 2012-03-06 Murray Cumming <murrayc@murrayc.com>
890 ReportGenerator: Do not show nulls.
892 2012-03-06 Murray Cumming <murrayc@murrayc.com>
894 ReportGenerator: Make the title font larger.
896 2012-03-06 Murray Cumming <murrayc@murrayc.com>
898 ReportGenerator: Put field titles inside groups, if there are groups.
900 2012-03-06 Murray Cumming <murrayc@murrayc.com>
902 ReportGenerator: Take the Report itself instead of the name and group.
904 * src/main/java/org/glom/web/server/ConfiguredDocument.java
905 Remove getReportLayoutGroup().
906 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
907 getReportHTML(): Pass the report instead
908 of its name and layout group.
909 * src/main/java/org/glom/web/server/ReportGenerator.java
910 generateReport(): Use the report object to use the title
913 2012-03-06 Murray Cumming <murrayc@murrayc.com>
915 ReportGenerator: Remove designBand parameters.
917 * src/main/java/org/glom/web/server/ReportGenerator.java:
918 Make designBand a class member instead of passing it to all
921 2012-03-06 Murray Cumming <murrayc@murrayc.com>
923 ReportGenerator: Add lines, a bit like in the desktop version.
925 * src/main/java/org/glom/web/server/ReportGenerator.java
926 addToReport(): Use JRDesignLine.
928 2012-03-06 Murray Cumming <murrayc@murrayc.com>
930 ReportGenerator: Correct the title positions and use some bold style.
932 * src/main/java/org/glom/web/server/ReportGenerator.java:
933 Break the code up into reusable functions, correct the placement of
934 titles, and use normal/bold styles as in the reports in the desktop
937 2012-03-06 Murray Cumming <murrayc@murrayc.com>
939 ReportGenerator: Add a header band to show the field titles.
941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
942 getReportHTML(): Pass the localeId to the ReportGenerator
944 * src/main/java/org/glom/web/server/ReportGenerator.java
945 constructor: Take the localeID so we can get translated field
947 generateReport(), addToReport(), addFieldToBand(): Add field
948 titles in a column header band.
950 2012-03-05 Murray Cumming <murrayc@murrayc.com>
952 Reports drop-down list: Some improvement.
954 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
955 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
956 Adedd setSelectedReport(),
957 setReportList(): Add a blank line so that the user can select the
959 * src/main/java/org/glom/web/client/activity/ReportActivity.java
960 start(): Show the current report by calling setSelectedReport().
961 This does not seem to work yet.
963 2012-03-05 Murray Cumming <murrayc@murrayc.com>
965 DetailsActivity, ListActivity: Move some variables into a base class.
967 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
968 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
969 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
970 the clientFactory, documentID, tableName and authenticationPopup into
971 a base class, to avoid duplication.
973 2012-03-05 Murray Cumming <murrayc@murrayc.com>
975 Translate the Reports label.
977 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
978 Get the "Reports" label string from the constants.
979 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
980 perties: Add Reports to the constants.
982 2012-03-05 Murray Cumming <murrayc@murrayc.com>
984 Reports: Implement grouping.
986 * src/main/java/org/glom/web/server/ReportGenerator.java:
987 Handle LayoutItem_GroupBy items and try to do the right thing
988 with JRDesignGroup. It seems to work.
990 2012-03-04 Murray Cumming <murrayc@murrayc.com>
992 Actually show some data with JasperReports.
994 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
995 getReportHTML(): Move most code into a ReportGenerator class.
996 * src/main/java/org/glom/web/server/ReportGenerator.java:
997 Recurse into sub-groups, adding fields to the JasperDesign's details
998 band. Note that we must set an arbitrary width and height, or it just
999 will not show any data.
1001 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1003 Reports Chooser: Show the titles, not the names.
1005 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1006 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1007 and the names as the values.
1008 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1009 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1010 group now that we provide the report name, so it should always
1013 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1015 Depend on jasperreports.
1017 * pom.xml: Add the dependency. My plan is to use this on the
1020 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1022 Implement navigation to report places.
1024 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1025 start(): Do not bother to handle all events here.
1026 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1027 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1028 Added getSelectedReport().
1029 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1030 .java: start(): When handling a change to the reports chooser,
1031 call getSelectedReport() and goTo() its ReportPlace.
1032 * src/main/java/org/glom/web/client/ui/ReportView.java
1033 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1034 Added setReportHTML() which puts the html in a gwt HTML widget.
1035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1036 getReportHTML(): Return "TODO" just to show that this works.
1038 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1040 Make ReportPlace usable.
1042 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1043 Mention ReportPlace.
1044 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1045 Correct the @prefix annotation.
1047 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1049 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1051 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1052 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1054 Change getReportLayout() to getReportHMTL() because we will not need to
1055 parse or render the report layout on the client side.
1056 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1057 getReportLayout(): Return the libglom LayoutGroup type because we will
1058 not need to convert to a shared type, because this will not be used on
1060 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1063 Note that there is still no implementation for this.
1066 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1068 Add a (empty) Report Place, View, and Activity.
1070 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1072 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1073 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1074 this into a superclass:
1075 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1076 and also use it as the base of this new ReportPlace:
1077 * src/main/java/org/glom/web/client/place/ReportPlace.java
1079 * src/main/java/org/glom/web/client/ui/ReportView.java
1080 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1081 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1082 Add these, containing mostly boiler-plate for now.
1084 * src/main/java/org/glom/web/client/OnlineGlomService.java
1085 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1086 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1088 Add API to get the LayoutGroup for the report.
1090 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1092 Add and fill a Reports drop-down list box.
1094 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1096 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1097 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1099 Added getReports(document, table, localeID), calling
1100 ConfiguredDocument.getReports().
1101 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1102 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1103 Added setReportsList() and a list widget.
1104 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1105 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1110 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1112 Translations: Add Esperanto.
1114 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1115 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1116 properties: Add this translation because someone took the time to make it.
1118 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1120 Adapt to the java-libglom 1.21.7 API.
1122 * src/main/java/org/glom/web/server/ReportGenerator.java:
1123 addToReport(): get_group_secondary_fields() is now
1124 get_secondary_fields().
1127 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1129 Use the latest java-libglom version.
1131 * pom.xml: Use java-libglom 1.21.7.
1133 2012-03-03 Ben Konrath <ben@bagu.org>
1135 Display date and time in details view.
1137 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1139 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1141 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1143 Require the latest java-libglom.
1145 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1147 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1149 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1151 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1152 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1153 an empty quickfind string. I also corrected libglom to create only
1154 empty where clauses for empty quickfind strings, but this avoids the
1157 2012-02-24 Ben Konrath <ben@bagu.org>
1159 Improve the tabs in the Notebook widget.
1163 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1165 Translations: Try to translate the strings.
1167 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1168 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1169 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1170 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1171 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1172 Take the Open translation from GTK+'s .po files.
1173 Take the Details translation from Glom's po files.
1174 I have added the other strings to Glom so we can get translations that way:
1175 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1177 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1179 TableSelectionViewImpl: Put the search label and entry in a div.
1181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1182 Put the search widgets in a FlowTable so that the CSS can be used to
1183 style them while keeping them together.
1184 * src/main/webapp/style.css: Mention the new div.
1186 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1188 Translate more strings in more locales.
1190 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1191 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1192 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1193 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1194 Translate the "Details" and "Open" string too.
1196 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1197 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1198 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1199 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1201 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1202 Add these new locales as placeholders though they currently contain English.
1204 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1206 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1209 Check the ConfiguredDocument* for null before using it.
1211 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1213 Tell Eclipse about the generated java files.
1215 * .classpath: This lets it find OnlineGlomConstants.java.
1216 It would be nice if Eclipse just used the maven build files.
1218 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1220 Prevent a crash when no locale is specified in the URL.
1222 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1223 Avoid returning a null string, obtained from
1224 Window.Location.getParameter(). This caused a crash when it was
1225 later passed to libglom's API.
1226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1227 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1228 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1229 guard against future null strings.
1231 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1233 Use the ?locale= query param instead of the &lang= token param.
1235 * src/main/java/org/glom/web/client/place/ListPlace.java
1236 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1237 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1238 Remove the lang token key and value.
1240 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1241 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1242 When the user selects a different locale from the chooser, use
1243 Window.Location.assign() to change the URL, which then causes a reload.
1245 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1247 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1248 * src/main/java/org/glom/web/client/activity/ListActivity.java
1249 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1250 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1251 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1252 * src/main/java/org/glom/web/client/ui/ListView.java:
1253 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1255 Remove localeID member variables and method/constructor parameters, instead
1256 using Utils.getCurrentLocaleID() when we need a localID to pass to
1259 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1261 Internationalize the UI strings.
1263 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1264 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1265 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1266 because it is unused. Messages are apparently strings that can have
1267 parameters, but we do not need that yet, so Contants will be enough for now.
1268 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1269 to say that we support the en and de locales.
1270 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1271 The original English strings.
1272 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1273 Some German translations of the English strings.
1274 The i18n goal then uses the .properties file to generate an
1275 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1276 returns an implementation that returns the translated strings.
1277 The documentation suggests putting these in src/java/*/client/, but it seems
1278 best to put it in src/resources/*/client/.
1279 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1280 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1281 instead of hard-coding them.
1282 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1283 but that does not seem to stop the build, though it confuses Eclipse.
1285 You can see the translated string by adding ?locale=de to the URL, like so:
1286 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1288 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1290 Improve null/empty String checks.
1292 * pom.xml: Add a dependency on commons-lang, to use
1293 org.apache.commons.lang.StringUtils.
1294 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1296 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1297 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1298 Use StringUtils.isEmpty().
1300 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1301 StringUtils class with a static isEmpty() function because we
1302 cannot use org.apache.commons.lang.StringUtils in client-side
1303 GWT code because it (apparently) cannot be compiled to javascript.
1304 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1305 * src/main/java/org/glom/web/client/activity/ListActivity.java
1306 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1307 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1308 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1309 * src/main/java/org/glom/web/client/place/ListPlace.java
1310 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1311 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1312 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1313 * src/main/java/org/glom/web/client/ui/details/Group.java
1314 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1315 our StringUtils.isEmpty() function.
1317 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1319 Update to the latest java-libglom API.
1321 * pom.xml: Require java-libglom 1.21.4.
1322 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1323 getDocumentInfo(), getListViewLayoutGroup():
1324 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1326 * src/main/java/org/glom/web/server/database/DBAccess.java
1327 getFieldsToShowForSQLQueryAddGroup(),
1328 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1329 with either get_database_title_original() or
1330 get_database_title(localeID).
1332 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1334 ConfiguredDocument: Avoid a null pointer exception.
1336 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1337 Initialize localeID to "" to avoid returning a null String which
1338 causes a crash in java-libglom's swing-generated code.
1340 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1342 Some simple renaming.
1344 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1345 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1346 for localeChooser. This seems more appropriate and is less ambiguous
1347 particularly in the .css file.
1349 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1351 ConfiguredDocument: Rename the localedID private member variable.
1353 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1355 Adapt to the latest java-libglom API from git master.
1357 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1358 libglom now uses only Vector instead of List, which uses add() instead of
1361 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1363 ConfiguredDocument: Rename the localedID private member variable.
1365 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1367 Build a source tarball with mvn assembly:single
1369 * assembly.xml: Add this file.
1370 * pom.xml: Use the maven-assembly-plugin and tell it to use
1371 our assembly.xml file.
1373 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1375 OnlineGlomServiceImpl: Get .glom files recursively.
1377 * pom.xml: Depend on commons-io from org.apache.commons.
1378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1379 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1380 files recursively, and with the easier filter for the extension.
1381 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1382 simplify that code too.
1384 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1386 README: Mention that you must install java-libglom packages separately.
1388 But then it works, because java-libglom is now in the central maven
1391 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1393 locales drop-down: Show the correct selected locale when the URL changes.
1395 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1396 .java: setPlace(): Move some code into fillView().
1398 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1400 locales drop-down: Do not lose the primary key.
1402 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1403 start(): onLocaleChange(): Pass the current primary key value,
1404 instead of an empty value.
1406 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1408 locales drop-down: Do not lose the drop-down selection.
1410 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1411 .java (TableSelectionActivity.fillView): Set the selected locale
1412 after changing the drop-down items (though we do not really need
1413 to change them just because the locale changes.)
1415 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1417 locales drop-down: Change the tables list when this changes.
1419 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1420 .java: TableSelectionActivity.start(): Move the async table titles
1421 retrieval into a private fillView() method and also call this when
1422 the chosen locale changes.
1423 Note that the document title is not actually translatable yet, but
1424 that is a problem that I should fix soon in libglom.
1426 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1428 Improve the placement of the locales drop-down.
1430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1431 Put the title and locales drop-down in a div (gwt.FlowTable).
1432 * src/main/webapp/style.css: Add magic css properties to make this work.
1433 Also remove the left margin from the title so that it lines up with the
1436 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1438 locales selector: Show human-readable locale titles.
1440 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1441 getDocumentInfo(): Use java.util.Locale to show a real title of
1442 each locale, in the locale's own language.
1444 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1446 Add a language/locale selector drop-down.
1448 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1449 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1450 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1451 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1452 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1453 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1454 Add a ListBox to show the available locales. Add getLocaleSelector(),
1455 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1456 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1457 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1458 java: Add these classes.
1459 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1460 start(): Fill the locales ListBox. Handle its change event, firing a
1462 setPlace(): Show the selected locale as specified by the URL token.
1463 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1464 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1465 Handle LocaleChangeEvent, going to a new *Place with that locale.
1467 The placement of the ListBox is not pretty, and it currently uses the ID
1468 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1472 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1474 Search box: Show the search text from the URL token.
1476 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1477 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1478 Add setQuickFindText().
1479 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1480 .java: setPlace(): Store the queryText if the place is a ListPlace,
1481 and call TableSelectionView.setQuickFindText().
1483 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1485 Allow use of translations via, for instance, &lang=de in the URL.
1487 * pom.xml: Use the unstable java-libglom 1.21 version.
1489 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1490 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1491 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1492 init(): Instead of calling TranslatableItem.set_current_locale()
1493 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1494 However, this is only for default locales, which are not needed to
1495 change the locale in the URL.
1496 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1497 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1498 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1499 layout for a particular locale.
1500 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1501 Add get/setDefaultLocaleID().
1502 getDocumentInfo(), getListViewData(), getRelatedListData(),
1503 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1504 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1505 localeID parameter, so we can get the layout for a particular locale.
1507 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1508 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1509 * src/main/java/org/glom/web/client/place/ListPlace.java:
1510 Parse and construct a lang parameter too.
1512 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1513 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1514 passed to subsequent methods and constructors.
1515 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1516 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1517 Store the localeID from the *Place and pass it to other constructors
1518 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1520 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1521 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1522 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1523 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1524 * src/main/java/org/glom/web/client/ui/ListView.java:
1525 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1526 Take localeID parameters and pass them to subsequent constructors and
1527 methods, so that the layout is always retrieved for that locale.
1529 This is rather repetitive.
1531 Note that "" means the original (default) locale of the Glom document,
1532 which is usually English.
1534 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1536 Documents: Remove final keyword to fix startup configuration.
1538 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1539 final keywords on the private member variables because that breaks
1540 the startup, apparently (there are warnings) because it stops them
1541 from being serialized. I added these in the previous commit.
1543 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1545 Documents: Add some final keywords.
1547 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1550 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1552 OnlineGlomServiceImpl: Add to overview comments.
1554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1555 Note that this is where all the document are loaded. They are not
1556 loaded freshly for each page.
1558 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1562 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1563 Add a TextBox for the text of a quick find.
1564 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1566 setBackLink(): Add a String quickFind parameter.
1567 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1568 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1569 to the base interface, because that is how TableSelectionViewImpl is used.
1570 * src/main/webapp/style.css: Add style for the search box and its label.
1572 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1573 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1574 Add these files, based on the existing TableChangeEvent and
1575 TableChangeEventHandlers.
1576 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1577 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1578 a ListPlace() that the user should be taken to.
1579 * src/main/java/org/glom/web/client/activity/ListActivity.java
1580 start(): Handle it here too and adapt the TableChangeEvent handler to
1581 pass the extra "" quickFind parameter to ListPlace.
1582 * src/main/java/org/glom/web/client/place/ListPlace.java:
1583 Constructor: Take an extra String quickFind parameter and store it,
1584 returning it from a new getQuickFind() method.
1585 getToken(): Put the quickFind text in the URL token.
1586 getPlace(): Parse the quickFind text from the URL token.
1587 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1588 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1589 ListPlace constructor.
1590 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1591 .java: start(): Add a Change handler for the TableSelectionView's
1592 TextBox (via its base HasChangeHandlers interface), firing the new
1593 QuickFindChangeEvent.
1594 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1595 pass the extra "" quickFind parameter.
1597 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1598 setCellTable(): Add a String quickFind parameter and pass it to
1599 the ListViewTable() constructor.
1600 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1601 setCellTable() in the base interface, because that is how ListViewImpl
1604 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1605 Add a String quickFind member variable.
1606 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1607 Constructor: Add a String quickFind parameter, storing it in the
1608 base ListTable's member variable.
1609 onRangeChanged(): Pass quickFind to the
1610 OnlineGlomServiceAsync.getSortedListViewData() and
1611 OnlineGlomServiceAsync.getListViewData() methods.
1613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1614 getListViewData(), getSortedListViewData(): Add a String quickFind
1615 parameter, passing it to ConfiguredDocument.getListViewData().
1616 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1617 Change getListViewData(), getSortedListViewData() in the base interface,
1618 because that is how OnlineGlomServiceImpl is used, via this:
1619 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1620 Change getListViewData(), getSortedListViewData() here too.
1621 This class can apparently be used to asynchronously call methods on
1622 OnlineGlomService, and GWT seems to implement that after recognizing
1623 just the *Async name convention and the extra AsyncCallback parameters.
1625 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1626 getListViewData(): Add a String quickFind parameter, and pass it to
1627 ListViewDBAccess.getData().
1628 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1629 getListData(): Add a String quickFind parameter and pass it to
1631 getSelectQuery(): Add a String quickFind parameter.
1632 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1633 getSelectQuery(): Add a String quickFind parameter and use it with
1634 Glom.get_find_where_clause_quick() to pass a where_clause to
1635 Glom.build_sql_select_with_where_clause(), to actually filter the
1637 getData(): Add a String quickFind parameter, passing it to getListData().
1638 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1639 va: getData(): Pass an empty string to getListData() for the
1640 quickFind parameter.
1642 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1644 ListTable: Minor change.
1646 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1647 createCellTable(): Make this protected instead of public.
1649 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1651 Many files: Use final for the parameters and use the @override attribute.
1653 2012-01-22 Ben Konrath <ben@bagu.org>
1655 Add anchor links for single line text that starts with http, ftp and www.
1659 2012-01-22 Ben Konrath <ben@bagu.org>
1661 Add ellipsis to single line text in details view.
1665 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1667 Remove all javadoc author tags.
1669 Because they are awkward and meaningless when many people touch
1671 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1673 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1675 Revert the COPYING.LESSER to COPYING rename.
1677 Apparently both should be there if it is LGPL.
1679 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1681 *View: Remove unused imports.
1683 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1684 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1685 * src/main/java/org/glom/web/client/ui/ListView.java:
1686 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1687 Remove unused imports, as suggested by Eclipse.
1689 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1691 Move the *View::Presenter types, and some API into one base View.
1693 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1694 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1695 * src/main/java/org/glom/web/client/ui/ListView.java:
1696 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1697 Presenter, setPresenter() and clear() into a shared base interface,
1698 to avoid the unnecessary duplicate Presenter types and to more clearly
1699 show how the *Views share the same structure, even if they are not
1700 used polymorphically.
1702 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1703 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1705 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1706 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1707 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1709 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1712 Feel free to revert this if there is a good reason for the duplicate
1715 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1717 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1719 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1720 a class member instead of a local variable in the method.
1721 This lets us use it to get the view instances, for use in tests.
1722 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1723 beforeOnlineGlom(): Test some more details of the initial view.
1724 Again, this is not very useful.
1726 To really test gwt-glom we will need to start a local postgresql
1727 instance with local data, like the Glom tests in C++.
1729 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1731 pom.xml: Mention the LGPL license.
1733 * pom.xml: Add a licenses section.
1734 * COPYING.LESSER: Move this to COPYING, which
1735 previously contained the GPL. But gwt-glom is all LGPL.
1737 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1739 Add project information to README and pom.xml.
1741 * README: Add a brief description and mention some mvn
1743 * pom.xml: This extra information shows up in mvn site
1746 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1748 Use the latest java-libglom version.
1750 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1752 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1754 GwtTestOnlineGlom: Test a little more.
1756 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1757 protected rather than private, as suggested by the gwt-test-utils
1759 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1760 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1761 Test the initial visibility of the panels.
1763 However, this is not a very useful test.
1764 And I wonder how we should generally test using this idea for an
1765 activity/places app like ours where the real changes happen implicitly
1766 based on the history token/URL.
1768 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1770 Slight modification to *Mapper comments.
1772 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1773 (DataActivityMapper)
1774 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1776 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1778 Remove comments mentioning GIN because they are just copied from
1779 the example code and are apparently not helpful:
1780 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1781 Also change the mention of a class that is only in the example code.
1783 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1785 GwtTestOnlineGlom test: Minor changes.
1787 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1788 Avoid the long qualified class name and modify the comment
1789 because it is now obvious to me that the mocked class is the only
1790 custom one created via GWT.create().
1792 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1794 Tests: Added the beginnings of a test using gwt-test-utils.
1796 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1797 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1798 which tells gwt-test-utils what class will be tested.
1799 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1800 Add a simple (but empty) test case. One class, used by the OnlineGlom
1801 class, is mocked so that it can be created. However, I am not sure
1802 why only this class needs to be mocked.
1804 Note that mockito seems more popular, and clearer, than easymock,
1805 but I have not got that working yet. It might be a matter of the
1808 This test is run during mvn integration-test.
1810 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1812 Tests: Use junit4-style syntax instead of junit3-style.
1814 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1815 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1816 * src/test/java/org/glom/web/shared/DataItemTest.java:
1817 Use the @Test annotation rather than relying on the test*() prefix.
1818 Also no longer implement TestCase, to avoid triggering support for
1819 the junit3-way, which stops the annotations from working.
1820 Change the imports from import junit.framework.* to
1821 import org.junit.*, which is apparently the new way.
1823 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1825 Added a test for ListPlace token parsing and creation.
1827 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1828 This is much the same as DetailsPlaceTest.
1830 I wonder how we could test the other parts of the *Place API.
1832 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1834 DetailsPlace test: Also test getToken() and recreation via getPlace().
1836 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1837 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1838 recreate it, testing the recreated DetailsPlace for the same parameter
1841 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1843 Use the surefire-report plugin.
1845 * pom.xml: This generates a HTML report about the tests in
1846 target/site/surefire-report.html
1847 when you do mvn surefire-report:report. It seems to be popular/normal.
1849 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1851 Added a test for DetailsPlace.
1853 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1854 Test the getPlace() token parsing.
1856 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1858 Added a first unit test.
1860 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1861 * src/test/java/org/glom/web/shared/DataItemTest.java:
1862 This is a silly test but it is just to get things started. Note that
1863 maven/junit finds the test because it looks in src/test by default.
1865 2011-12-22 Ben Konrath <ben@bagu.org>
1867 Change charsetName to "UTF-8" when replacing line breaks.
1869 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1870 that work in Java (such as "UTF8") will not work when compiled to
1873 This fixes a problem with multi-line details view fields that have hard
1874 line breaks. The "License Text" field on this page demonstrates the
1877 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1879 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1881 2011-12-22 Ben Konrath <ben@bagu.org>
1883 Fix another bug with related list navigation.
1885 I've tested all the navigation buttons in all of the related lists
1886 so things should be good now.
1888 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1890 2011-12-22 Ben Konrath <ben@bagu.org>
1892 Fix a crasher when refreshing the list view with the default table.
1894 This crash will also happen when loading the list view with the default
1895 table from a link or bookmark.
1897 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1898 to the main document selection page when the document id hasn't been
1900 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1901 the main document selection page when the document id hasn't been
1903 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1904 values for the details place when the document id hasn't been set.
1905 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1906 values for the list place when the document id hasn't been set.
1908 2011-12-21 Ben Konrath <ben@bagu.org>
1910 Protect against NPE when glom.document.locale is not in config.
1912 This patch protects against an NPE when glom.document.locale is not in
1913 the config file. This NPE will also happen if glom.document.locale is
1916 The patch also updates the error message to display the class name when
1917 the getMessage() returns null. This was happening when the NPE was
1918 thrown and I had "Configuration Error: null". If an NPE is encountered
1919 with this patch, "Configuration Error: NullPointerException " will be
1922 This commit closes this bug:
1924 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1926 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1928 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1930 Rename onlineglom.properties to onlineglom.properties.sample.
1932 * src/main/resources/onlineglom.properties: Rename to:
1933 * src/main/resources/onlineglom.properties.sample:
1934 * src/main/resources/README: And add this file explaining that people
1935 should rename it back when deploying.
1937 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1939 Allow choosing the translation in the .properties file.
1941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1942 init(): Read a glom.document.locale value from the configuration file
1943 and call Glom's TransatableItem::set_current_locale() method.
1944 * src/main/resources/onlineglom.properties: Add a commented-out
1945 example of this new setting.
1947 It would be better to add &lang=de_DE to the URL, but the current
1948 libglom API does not allow us to do this easily. I am working on that.
1950 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1952 Avoid a crash in parsing of token parameters.
1954 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1955 ava: getTokenParams(): Do not crash if a parameter has a key but no
1956 value, and ignore parameters with neither.
1958 2011-12-17 Murray Cumming <murrayc@murayc.com>
1960 History token building/handling: Improve use of token parameters.
1962 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1963 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1964 and buildParamsToken(HashMap), for use by derived classes.
1965 Make the separator private because it is no longer be needed.
1966 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1967 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1968 instead of manual string concatenation.
1969 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1970 of hardcoded indices and awkward splitting code.
1971 * src/main/java/org/glom/web/client/place/ListPlace.java
1972 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1973 instead of manual string concatenation.
1974 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1975 of hardcoded indices and awkward splitting code.
1976 This should fix bug #666420
1978 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1980 Fix a Navgiation->Navigation typo in the code.
1982 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1983 Rename processNavgiation() to processNavigation().
1985 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1987 Fix a seperator->separator typo in the code.
1989 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1990 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1991 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1994 2011-12-15 Ben Konrath <ben@bagu.org>
1996 Cleanup some comments.
1998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2000 2011-12-14 Ben Konrath <ben@bagu.org>
2002 Replace \n with <br/> for multiline text in the details view.
2004 Vertical scrollbars are added when needed as well.
2006 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2008 2011-12-14 Ben Konrath <ben@bagu.org>
2010 Specify the font for document selection links.
2012 * src/main/webapp/style.css:
2014 2011-12-14 Ben Konrath <ben@bagu.org>
2016 Fix bouncy CellTable while paging.
2018 This doesn't currently work with related list tables in unselected
2021 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2023 2011-12-14 Ben Konrath <ben@bagu.org>
2025 Revamp the appearance of the document selection page.
2027 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2028 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2029 * src/main/webapp/style.css:
2031 2011-12-13 Ben Konrath <ben@bagu.org>
2033 Set navigation button column to the smallest size possible.
2035 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2037 2011-12-13 Ben Konrath <ben@bagu.org>
2039 Change OpenButton nomenclature to NavigationButton.
2041 Using NavigtionButton makes things more generic. Classes, methods and
2042 variables have been changed.
2044 This is a rename-only refactor.
2046 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2047 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2048 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2049 Renamed from OpenButtonCell.
2050 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2051 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2052 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2054 2011-12-12 Ben Konrath <ben@bagu.org>
2056 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2058 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2059 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2060 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2061 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2063 2011-12-12 Ben Konrath <ben@bagu.org>
2065 Update variable names and comments.
2067 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2068 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2070 2011-12-12 Ben Konrath <ben@bagu.org>
2072 Properly initialize numNonEmptyRows variable to zero.
2074 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2075 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2077 2011-12-05 Ben Konrath <ben@bagu.org>
2079 Add latest mockup with HTML tables.
2081 Features of this mockup:
2083 -> HTML table for flowtable
2084 -> HTML table for flowtable column
2085 -> Example of how related lists would look
2086 -> Not using text entries for data items
2088 The current version of Online Glom doesn't use HTML tables for the
2091 This mockup has been sent to the glom-devel mailing list but it's good
2092 to have it here as well.
2094 * mockups/details-view-html-tables.html:
2096 2011-12-05 Ben Konrath <ben@bagu.org>
2098 Remove unnecessary getPrimaryKeyField() method.
2100 getPrimaryKeyFieldForTable(String) has been renamed to
2101 getPrimaryKeyField(String).
2103 * src/main/java/org/glom/web/server/database/DBAccess.java:
2104 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2105 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2107 2011-12-05 Ben Konrath <ben@bagu.org>
2109 Add string representation of TypedDataItem value to conversion error message.
2111 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2112 message was extracted into its own method to avoid duplication.
2114 2011-12-05 Ben Konrath <ben@bagu.org>
2116 Add type checking to navigation primary key value creation.
2118 Create navigation primary key only if the expected type from the Glom
2119 document matches the type returned by the SQL query.
2121 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2123 2011-12-05 Ben Konrath <ben@bagu.org>
2125 Rename a couple of variables in RelatedListNavigation.
2127 This is a rename-only refactor.
2129 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2131 2011-12-05 Ben Konrath <ben@bagu.org>
2133 Move getListLayoutGroup() into getListViewLayoutGroup().
2135 This removes getListLayoutGroup(). It was only being called by
2136 getListViewLayoutGroup().
2138 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2140 2011-12-05 Ben Konrath <ben@bagu.org>
2142 Remove check for LayoutItem_Portal in list table method.
2144 This check is no longer necessary because the method isn't being used
2145 to create the LayoutItemPortal DTO.
2147 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2149 2011-12-05 Ben Konrath <ben@bagu.org>
2151 Properly support related list navigation.
2153 Navigation from the "Repository Analyzer -> Package Scans ->
2154 Dependencies" related table wasn't working because the primary key for
2155 related tables wasn't being set properly. This commit fixes the
2158 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2159 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2160 doesn't set the primary key properly for related list tables.
2161 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2162 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2163 useful for getting the primary key for list view tables and for related
2165 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2166 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2167 Move code to set the primary key for the table from the abstract
2168 ListDBAccess class to ListViewDBAccess as it's only correct for list
2170 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2171 Properly add primary key to related list tables.
2173 2011-12-02 Ben Konrath <ben@bagu.org>
2175 Properly set the horizontal alignment of fields.
2177 This fix is for both the list tables and the details view.
2179 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2180 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2181 to set the horizontal alignment of fields.
2183 2011-12-02 Ben Konrath <ben@bagu.org>
2185 Display currency codes in the details view.
2187 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2189 2011-12-02 Ben Konrath <ben@bagu.org>
2191 Avoid duplicate JNI call.
2193 JNI is not as efficient as pure Java and this is an easy (and small)
2196 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2197 Use previously retrieved value for whereClauseToTableName instead of
2200 2011-12-02 Ben Konrath <ben@bagu.org>
2202 Rename a couple of variables in RelatedListNavigation.
2204 This is a rename-only refactor.
2206 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2208 2011-12-02 Ben Konrath <ben@bagu.org>
2210 Indicate clearly that a mismatched primary key type is a bug.
2212 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2213 warning to error. Add 'This is a bug.' to message.
2215 2011-12-02 Ben Konrath <ben@bagu.org>
2217 Update / fix some comments.
2219 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2221 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2223 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2224 Fix comments. Add some TODOs.
2226 2011-12-02 Ben Konrath <ben@bagu.org>
2228 Enable navigation to details view with string primary key from related list.
2230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2231 Create a text primary key value when return type of result is
2232 java.sql.Types.VARCHAR.
2234 2011-12-02 Ben Konrath <ben@bagu.org>
2236 Use checkboxes for booleans in the details view.
2238 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2240 2011-12-01 Ben Konrath <ben@bagu.org>
2242 Improve performance of related list height calculation.
2244 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2245 Put code to calculate the expected height in a static initializer so
2246 that that it's only called once.
2248 2011-12-01 Ben Konrath <ben@bagu.org>
2250 Show related list tables in notebooks (again).
2252 Calculate the height of the related list tables so the Notebook can be
2253 set the correct height. The height of the related list table is also needed by
2254 FlowTable to be able decide how to create the layout.
2256 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2257 and set the Portal height based on the height of the related list
2258 table and the Portal container.
2259 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2260 Add method to calculate the height of the related list tables.
2261 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2262 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2263 calculate the height of the Pager widget.
2265 2011-12-01 Ben Konrath <ben@bagu.org>
2267 Use CellTable API for table property instead of setting style on Element.
2269 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2271 2011-12-01 Ben Konrath <ben@bagu.org>
2273 Make ListViewTable and RelatedListTable a consistent height.
2275 The tables are now a consistent height regardless of the contents of
2276 the table. A hidden button is added to empty rows to ensure that the
2277 height of these rows will match the height of rows with data.
2279 A navigation button column is now added to every table. The width of
2280 the navigation column is set to 0px when a RelatedListTable shouldn't
2281 have navigation buttons. This maintains the a consistent row height in
2282 tables that don't show the navigation buttons.
2284 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2285 navigation column when not needed.
2286 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2287 arguments for navigation button to constructor of ListViewTable.
2288 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2289 hidden button for empty data rows.
2290 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2291 arguments for navigation button to constructor.
2292 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2293 create navigation buttons. Add hideNavigationButtons() method.
2294 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2295 arguments for navigation button to constructor.
2297 2011-12-01 Ben Konrath <ben@bagu.org>
2299 Use 'visibility: hidden' in Utils.getWidgetHeight().
2301 This is better choice because hidden elements are invisible, don't
2302 respond to events and are not part of the tab order. They will,
2303 however, take up space which is required to be able to calculate the
2304 height of the widget.
2306 * src/main/java/org/glom/web/client/Utils.java:
2308 2011-12-01 Ben Konrath <ben@bagu.org>
2310 Use Utils.getWidgetHeight() in FlowTable.
2312 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2314 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2316 2011-12-01 Ben Konrath <ben@bagu.org>
2318 Put the details css class name on the correct table column.
2320 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2322 2011-11-30 Ben Konrath <ben@bagu.org>
2324 Update for java-libglom API change.
2326 The getters and setters on FieldFormatting and NumericFormat were
2327 changed to remove the 'M'.
2329 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2331 2011-11-29 Ben Konrath <ben@bagu.org>
2333 Only allow RelatedListTables in Portals.
2335 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2337 2011-11-29 Ben Konrath <ben@bagu.org>
2339 Only create a contents panel for Portals when title is being set.
2341 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2343 2011-11-29 Ben Konrath <ben@bagu.org>
2345 Set TabLayoutPanel height based on calculated height its widgets.
2347 This is a potential fix for this bug:
2349 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2351 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2353 2011-11-29 Ben Konrath <ben@bagu.org>
2355 Align details field labels and data with the Open buttons.
2357 * src/main/webapp/style.css:
2359 2011-11-29 Ben Konrath <ben@bagu.org>
2361 Remove unnecessary <div> in the Notebook widget.
2363 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2364 method to get container FlowPanel (<div>).
2365 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2366 initWidget() method directly on the TabLayoutPanel widget instead of
2367 Group's container widget.
2369 2011-11-29 Ben Konrath <ben@bagu.org>
2371 Don't add group titles for Portals in Notebooks.
2373 This reverts the previous patch and fixes a bug I introduced with
2374 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2376 * src/main/java/org/glom/web/client/ui/details/Group.java:
2377 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2379 2011-11-28 Ben Konrath <ben@bagu.org>
2381 Remove unused boolean argument in Portal constructor.
2383 Just a code cleanup.
2385 * src/main/java/org/glom/web/client/ui/details/Group.java:
2386 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2388 2011-11-28 Ben Konrath <ben@bagu.org>
2390 Remove hack for glom 1.18 style glom files.
2392 * src/main/java/org/glom/web/client/ui/details/Group.java:
2393 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2394 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2396 2011-11-28 Ben Konrath <ben@bagu.org>
2398 Use Gda Value version of primary key to log result too large error.
2400 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2402 2011-11-28 Ben Konrath <ben@bagu.org>
2404 Don't use TypedDataItem.getText() for Unknown types from the URL.
2406 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2407 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2408 instead of getText().
2409 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2410 String field and getUnknown() method.
2412 2011-11-28 Ben Konrath <ben@bagu.org>
2414 Log an error message when the java-libglom .so is not present.
2416 The error message was being set in the exception but not logged.
2418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2420 2011-11-28 Ben Konrath <ben@bagu.org>
2422 Ignore LayoutItem_CalendarPortals.
2424 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2425 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2427 2011-11-28 Ben Konrath <ben@bagu.org>
2429 Extract method for creating the LayoutItemPortal DTO.
2431 Just breaking the code up into smaller chunks.
2433 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2435 2011-11-28 Ben Konrath <ben@bagu.org>
2439 This should have been added with the refactor. Oops!
2441 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2443 2011-11-28 Ben Konrath <ben@bagu.org>
2445 Create primary key value from URL string using type from Glom document.
2447 See this bug, comments 19 - 25:
2449 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2451 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2452 create a TypeDataItem for the primary key here when loading from a
2453 URL. Show the same string for the primary key value as was received
2454 from the URL string (when loading from a URL).
2455 * src/main/java/org/glom/web/server/Utils.java: Update method for
2456 creating the Gda Value from the TypeDataItem to properly deal with
2457 creating a Gda Value based on the Glom document type for the primary
2458 key value string when loading from a URL.
2459 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2460 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2461 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2462 Update for changed method name.
2464 2011-11-27 Ben Konrath <ben@bagu.org>
2466 Rename PrimaryKeyItem to TypedDataItem.
2468 The name PrimaryKeyItem suggests what the class should be used for.
2469 TypedDataItem is a neutral name that describes the class better.
2471 This is a rename-only refactor.
2473 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2474 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2475 * src/main/java/org/glom/web/client/Utils.java:
2476 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2477 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2478 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2480 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2481 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2482 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2483 * src/main/java/org/glom/web/server/Utils.java:
2484 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2485 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2486 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2487 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2489 2011-11-25 Ben Konrath <ben@bagu.org>
2491 Improve Gda Value conversion from PrimaryKeyItem.
2493 The value from the PrimaryKeyItem is only used if its type match the
2494 type from the glom document.
2496 * src/main/java/org/glom/web/server/Utils.java:
2498 2011-11-25 Ben Konrath <ben@bagu.org>
2500 Manually check if the java-liblgom .so is visible to the JVM.
2502 It seems that Tomcat has problems when a static initializer throws an
2503 exception. This check is done before the first method call into
2504 java-libglom so that execution doesn't continue if the .so is not
2507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2509 2011-11-25 Ben Konrath <ben@bagu.org>
2511 Improve browser configuration error messages.
2515 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2517 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2518 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2519 getConfigurationErrorMessage() method.
2520 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2521 Get and display a specific configuration error message when no Glom
2522 documents are found.
2523 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2524 Implement getConfigurationErrorMessage() method. Surround configuration
2525 code in the init() method with a try/catch block. This allows the
2526 errors to be caught while keeping the servlet available to retrieve the
2527 configuration error message.
2529 2011-11-25 Ben Konrath <ben@bagu.org>
2531 Don't use Strings to hold primary key values.
2533 The primary key values are now held in a new data object
2534 (PrimaryKeyItem) that holds type information and the primary key value
2535 using the correct type.
2537 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2538 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2539 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2540 PrimaryKeyItem instead of String to hold the primary key value.
2541 * src/main/java/org/glom/web/client/Utils.java: Remove
2542 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2543 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2544 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2545 PrimaryKeyItem instead of String to hold the primary key value. Load
2546 document selection page when the documentID has not been set correctly.
2547 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2548 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2550 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2551 Return empty string for URL instead of "null".
2552 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2553 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2554 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2555 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2556 PrimaryKeyItem instead of String to hold primary key values.
2557 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2558 PrimaryKeyValue to a Gda Value.
2559 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2560 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2561 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2562 Replace temporary database access code that uses the PrimaryKeyValue to
2563 Gda Value conversion.
2564 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2565 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2566 PrimaryKeyItem instead of String.
2567 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2568 hold primary key values.
2570 2011-11-24 Ben Konrath <ben@bagu.org>
2572 Use newly added java-libglom API to create queries.
2574 This isn't finished. I still need to stop using Strings for primary key
2575 values in the client code.
2577 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2578 libglom to use fake connections so that retrieving the query string will
2580 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2581 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2582 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2583 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2584 Use the newly added libglom sql methods and classes to create the
2585 query. Add temporary hack to convert primary value strings to Gda
2588 2011-11-23 Ben Konrath <ben@bagu.org>
2590 Don't explicitly set the height of Portals.
2592 See comments 6 - 10 of this bug for details:
2594 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2596 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2598 2011-11-23 Ben Konrath <ben@bagu.org>
2600 Use an HTML table instead of CSS for the FlowTable layout.
2602 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2603 GWT's FlexTable to implement the FlowTable.
2604 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2606 2011-11-18 Ben Konrath <ben@bagu.org>
2608 Add boolean example to HTML table mockup.
2610 * mockups/details-view-html-tables-text-entries.html:
2612 2011-11-17 Ben Konrath <ben@bagu.org>
2614 Ensure the pager buttons are always visible for related lists.
2616 To accomplish this, I've turned off text wrapping in the list view and
2617 related list tables for both the header and data text. The related list
2618 table now has a fixed layout so the it doesn't overflow its container.
2619 This is required to ensure that the cell text is clipped when it
2620 overflows the cell and an ellipsis is added to the right side of the
2621 cell when text is clipped.
2623 A fixed table layout for the related list table in the details view
2624 seems what we want for the details view anyway, so the side-effect is
2627 The ellipsis will only be displayed in Firefox >= 7.
2631 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2633 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2634 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2635 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2637 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2638 Set the 'table-layout: fixed' CSS property to the related list table.
2639 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2640 'white-space: nowrap;' CSS property on both the list view and the
2641 related list tables.
2643 2011-11-16 Ben Konrath <ben@bagu.org>
2645 Rework the fix for empty notebook tab labels.
2647 Setting the empty group titles with its name caused problems for the
2648 details layout. Instead of using libglom's
2649 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2650 to the client when the title is empty. This allows the Notebook to use
2651 the name when the title is empty without affecting anything else.
2653 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2654 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2656 2011-11-16 Ben Konrath <ben@bagu.org>
2658 Set group titles with name when title is empty.
2660 This fixes a problem with an empty notebook tab label in the Lesson
2661 Planner document. The forth tab in the notebook should be "Internet":
2663 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2665 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2666 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2669 2011-11-16 Ben Konrath <ben@bagu.org>
2671 Remove whitespace from the configured username properties.
2673 This assumes that usernames won't have whitespace at the beginning
2674 or end. But I think this is a reasonable assumption.
2676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2677 String.trim() to remove the whitespace from the username properties.
2679 2011-11-15 Ben Konrath <ben@bagu.org>
2681 Add details view mockup with HTML tables and text entries.
2683 This is from the attachment on this bug:
2685 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2687 * mockups/details-view-html-tables-text-entries.html:
2689 2011-11-15 Ben Konrath <ben@bagu.org>
2691 Add space between the columns of the flow table.
2695 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2697 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2698 space between columns in the flow table.
2700 2011-11-15 Ben Konrath <ben@bagu.org>
2702 Add backup files to the .gitignore.
2704 * .gitignore: Ignore files that end with ~.
2706 2011-11-09 Ben Konrath <ben@bagu.org>
2708 Use latest release of gwt-log.
2710 Gwt-log releases are now being submitted to the maven central
2711 repository so manual installation of the jar is no longer required.
2713 * pom.xml: Update version and groupId of gwt-log dependency.
2715 2011-10-31 Ben Konrath <ben@bagu.org>
2717 Don't use GWT numeric formatting to override the glom currency formatting.
2719 Currencies are now displayed like they are in Glom. See this bug:
2721 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2723 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2725 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2726 currency code to constructor and set it when the cell is rendered.
2727 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2728 currency code to the constructor of the NumericCell.
2730 2011-10-27 Ben Konrath <ben@bagu.org>
2732 Require the latest release of java-libglom (1.17.4).
2736 2011-10-26 Ben Konrath <ben@bagu.org>
2738 Add style to Notebook that matches current theme.
2740 It's not the best style in the world but it's better than the default.
2742 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2743 padding at the bottom of the child widgets.
2744 * src/main/webapp/style.css: Add style for the Notebook.
2746 2011-10-26 Ben Konrath <ben@bagu.org>
2748 Move servlet initialization code to overridden init method.
2750 This is half of the solution to getting proper error messages
2751 displayed when configuration errors occur. Here's the relevant bug:
2753 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2755 The rest of the solution involves surrounding the init method with a
2756 try/catch block and setting a global variable with the error /
2757 exception. A new async method should be created to retrieve and display
2758 the error message / exception.
2760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2761 code from constructor to init method adding exceptions as needed.
2763 2011-10-26 Ben Konrath <ben@bagu.org>
2765 Add script to monitor and restart tomcat if required.
2767 * utils/check-and-recover-tomcat.py: New file.
2769 2011-10-26 Ben Konrath <ben@bagu.org>
2771 Display the correct number of data items in the pager.
2775 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2777 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2778 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2779 The implementation is the same for both tables: Keep track of the
2780 number of non-empty rows and fire and RowCountChangeEvent after the data has
2782 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2783 custom Pager class that subclasses SimplePager to handle displaying
2784 the correct number when empty rows have been added.
2786 2011-10-26 Ben Konrath <ben@bagu.org>
2788 Correct error in previous commit.
2790 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2791 eventBus parameter from listView.setCellTable().
2793 2011-10-26 Ben Konrath <ben@bagu.org>
2795 Fix error in TODO comment.
2797 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2799 2011-10-24 Ben Konrath <ben@bagu.org>
2801 Create Notebook widgets to the details view.
2803 This isn't finished just yet - I still need to create a reasonable
2804 style to match the current theme.
2806 * src/main/java/org/glom/web/client/Utils.java: Add method for
2807 calculating the height of a widget. This is used in the Notebook class.
2808 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2809 new constructor method in Group.
2810 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2811 method for creating child widget that can be used by subclasses
2812 like Notebook. New constructor that allows disabling the group
2813 titles - Notebooks don't set a group title for their child groups.
2814 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2815 to make Notebooks using GWT's TabLayoutPanel.
2816 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2817 constructor that allows disabling the group titles.
2818 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2819 LayoutItemNotebook DTO.
2820 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2821 DTO for Notebooks. It's just an empty class for now but we might need
2822 it to transfer some specific information in the future.
2824 2011-10-21 Ben Konrath <ben@bagu.org>
2826 Add navigation buttons to related list tables.
2828 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2829 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2831 method getSuitableRecordToViewDetails() for getting the table name
2832 and primary key value for related list navigation buttons.
2833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2834 private cell renderer class to get the navigation information for
2835 related list tables from the server. Extract the navigation
2836 processing code from the details cell navigation and use it for the
2837 related list navigation as well.
2838 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2839 cell renderer class for the details open buttons. This was needed
2840 because the related list navigation buttons and the list view
2841 navigation buttons need to react differently when clicked.
2842 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2843 the onEnterKeyDown() method because it's now overriden in the
2844 subclasses that are specific to the related list tables and the list
2846 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2847 the vertical size a little because the buttons add a bit of vertical
2848 space to table. This is not a perfect solution because the vertical
2849 size of with table fewer than 5 rows will be a little smaller.
2850 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2851 changes in how navigation buttons are handled.
2852 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2853 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2854 database access object.
2855 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2856 to find the portal for a given relationship name from
2857 RelatedListDBAccess. Add method to find a primary key field for a
2859 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2860 Move code to find the portal for a given relationship name to
2862 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2863 New file: database access object for getting the related list
2864 navigation information (the table name and the primary key value).
2865 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2866 DTO for transferring a table name to navigate to and a primary key
2868 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2869 boolean and getter/setter to specifies if the related list should add
2872 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2874 Use the master branch of java-libglom
2876 * pom.xml: Depend on java-libglom 1.19 instead.
2878 This is the master branch. See also the libglom-1-18 branch.
2880 2011-10-11 Ben Konrath <ben@bagu.org>
2882 Enable the open navigation button when the data has been set.
2884 This avoids having active buttons that don't do anything when the data
2887 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2889 2011-10-11 Ben Konrath <ben@bagu.org>
2891 Use IsWidget interface for FlowTableItem.
2893 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2894 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2896 2011-10-11 Ben Konrath <ben@bagu.org>
2898 Remove GWT styling from open button in details view.
2900 There are still some issues with how the details cell is arranged but
2901 this should be made to match Glom 1.20. I'm going to leave fixing this
2902 until I have Glom 1.20 up and running.
2904 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2905 style name on open button.
2906 * src/main/webapp/style.css: Move and edit details-navigation class.
2907 Re-arrange some classes to make them appear in the same order as the
2910 2011-10-07 Ben Konrath <ben@bagu.org>
2912 Update to GWT 2.4.0.
2914 * .gitignore: Ignore new cache directory.
2915 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2916 * pom.xml: Change GWT and maven plugin to 2.4.0.
2917 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2919 * src/main/java/org/glom/web/client/ClientFactory.java:
2920 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2921 * src/main/java/org/glom/web/client/OnlineGlom.java:
2922 Update source for API changes.
2923 * utils/build-onlineglom-war.sh: Remove cache directory before the
2926 2011-10-07 Ben Konrath <ben@bagu.org>
2928 Add navigation buttons in the details view.
2930 This isn't finished but I thought I'd commit what I have as it's a
2931 pretty good start. I still need to:
2933 1. Change the style so that it fits better into the current theme
2934 2. Adjust the details cell to expand as much as possible.
2936 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2937 click handlers to navigation buttons in the DetailsCells. Create a
2938 refreshData() method to get just the data from the server without the
2940 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2941 Update the tableSelector and browser title when the table name
2942 changes without using the tableSelector.
2943 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2944 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2945 getDetailsCells() to getCells(). Update variable names.
2946 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2947 method to set click handler on navigation button. Rename a few
2948 variables. Add navigation buttons where needed.
2949 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2950 variables and methods.
2951 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2952 navigation boolean and navigation table as required in the
2953 LayoutItemField DTO.
2954 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2955 variables for navigation along with getter/setter methods.
2957 2011-10-07 Ben Konrath <ben@bagu.org>
2959 Rename Field to DetailsCell.
2961 This is a refactor-only commit. No functionality has been added or
2964 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2965 Update variable and method names.
2966 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2967 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2968 variable and method names.
2969 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2971 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2972 variable and method names.
2974 2011-10-07 Ben Konrath <ben@bagu.org>
2976 Create separate methods for layout and data the details view.
2978 This is a refactor-only commit. No functionality has been added or
2981 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2982 private methods: setData(), createLayout().
2984 2011-10-07 Ben Konrath <ben@bagu.org>
2986 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2988 This is part of a change to get navigation buttons in the details view
2989 but it should have been done this way from the start.
2991 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2992 for method name change in TableSelectionView.
2993 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2994 Create TableChangeEvent and set the browser title using the
2995 TableSelectionView API.
2996 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2997 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2998 Change getSelectedTable() to getSelectedTableName(). Add
2999 getSelectedTableTitle().
3001 2011-10-07 Ben Konrath <ben@bagu.org>
3003 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3005 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3007 2011-10-07 Ben Konrath <ben@bagu.org>
3009 Update TableChangeEvent to use newTableName naming convention.
3011 This makes the class more consistent with GWT naming conventions.
3013 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3014 Update for method name change in TableChangeEvent.
3015 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3016 for method name change in TableChangeEvent.
3017 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3018 newTableName variable and getter method. Make toDebugString()
3021 2011-09-30 Ben Konrath <ben@bagu.org>
3023 Disable the pager in the list tables when the data row count is less than the minimum.
3025 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3026 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3028 2011-09-30 Ben Konrath <ben@bagu.org>
3030 Add empty rows to the end of related list and list view tables.
3032 I also extracted the cell rendering classes from the ListTable because
3033 the code was becoming a little crazy with all the anonymous inner
3034 classes. My plan is to use these cell rendering classes in the details
3035 view as well so this refactor will be needed for that change.
3037 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3038 set the row count in related list tables if the data has more rows
3039 than the minimum number of rows visible.
3040 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3041 row count in list view tables if the data has more rows than the
3042 minimum number of rows visible.
3043 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3044 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3046 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3047 for rendering TYPE_NUMERIC cells. The code was extracted from the
3049 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3050 class for rendering cells with buttons in list views. The code was
3051 extracted from the ListTable class.
3052 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3053 for rendering TYPE_TEXT cells. The code was extracted from the
3055 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3056 Add empty rows to the end of the data if required. Implement
3057 ListTable.getMinNumVisibleRows().
3058 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3059 cell renderer code to public classes. Return null in
3060 Column.getValue() for empty rows. Add new abstract method:
3061 getMinNumVisibleRows(). Move code to set the row count of the list view
3062 table to ListViewImpl.
3063 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3064 empty rows to the end of the data if required. Implement
3065 ListTable.getMinNumVisibleRows().
3068 2011-09-27 Ben Konrath <ben@bagu.org>
3070 Use GWT.log for client-side debugging statements.
3072 These are optimized out when deployed so I should have used this method
3073 in the first place. These statements will eventually be replaced with some sort
3074 of notification in the browser.
3076 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3077 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3078 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3079 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3080 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3082 2011-09-27 Ben Konrath <ben@bagu.org>
3084 Put tableselector on the right, back to list link on right.
3086 The idea is that the table selector is acting like a label for the
3087 currently displayed table so it should be placed below the document title. This
3088 puts the table title in a similar position to where it is in Glom.
3090 * mockups/details-contacts.html:
3091 * mockups/details-projects.html:
3092 * mockups/listview-contacts.html:
3093 * mockups/listview-projects.html:
3094 * mockups/style.css:
3095 Update mockups to match how the interfaces currently look.
3096 * src/main/webapp/style.css: Swap positions of backlink with the table
3097 selector. Add some space on the left side of the table selector to
3098 line things up with the document title.
3100 2011-09-27 Ben Konrath <ben@bagu.org>
3102 Add field colouring to details view.
3104 This change re-works how field colouring works. The colour formatting
3105 information is now set to the client with the layout information instead of
3106 with the data. This eliminates the need to send the same colour strings for
3107 data in list view column when colour information is set.
3109 In order to set an alternate colour for negative numeric values, the
3110 number is now sent to client and formatted with the GWT NumberFormat class.
3112 This change also fixes:
3114 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3116 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3117 internationalization framework which is needed for client side numeric
3119 * src/main/java/org/glom/web/client/Utils.java: New file for some
3120 client static utility methods.
3121 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3122 the DataItem object to the Field class. Use a utility method to
3123 create the foreignKeyValue string.
3124 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3125 alignment and text colours in the constructor. Add setData(DataItem)
3126 method. Remove setText(String) method.
3127 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3128 colour information to GlomTextCell. Create and use GlomNumberCell for
3129 rendering numbers. Use utility method to get the string for the
3130 primary key of the key provider. Re-work how the horizontal alignment
3132 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3133 formatting to layout information. Methods for converting the libglom
3134 formatting information were moved from DBAccess.
3135 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3136 numeric formatting (it's now done on the client side). Don't set text
3137 colours in DataItem. Move libglom formatting conversion methods to
3139 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3140 getters/setters for text colour information.
3141 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3142 for transferring the libglom NumericFormat information to the client.
3143 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3144 and getters/setters for: GlomNumericFormat, background colour and
3145 foreground colour strings.
3147 2011-09-26 Ben Konrath <ben@bagu.org>
3149 Simplify code that iterates through the LayoutGroup.
3151 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3153 2011-09-26 Ben Konrath <ben@bagu.org>
3155 Accept Eclipse formatting for OnlineGlomServiceAsync.
3157 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3159 2011-09-26 Ben Konrath <ben@bagu.org>
3161 Don't use the ListDBAccess classes to get the primary key layout information.
3163 This was causing a bug where the wrong index for the hidden primary key
3164 was being sent to the client.
3166 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3167 primary key while creating the LayoutGroup DTO. Create a
3168 LayoutItemField DTO for hidden primary keys. Don't use the
3169 RelatedListDBAccess because it was only used for getting the primary
3171 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3172 access modifier from public to protected for getPrimaryKeyField() and
3173 getPrimaryKeyLayoutItemField().
3174 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3175 abstract method getExpectedResultSize() because RelatedListDBAccess
3176 doesn't have enough info to implement it.
3177 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3178 Remove @Override for getExpectedResultSize().
3179 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3180 Remove method getExpectedResultSize().
3182 2011-09-23 Ben Konrath <ben@bagu.org>
3184 Log which layout (list or details) the ignored item is from.
3186 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3188 2011-09-23 Ben Konrath <ben@bagu.org>
3190 Remove annotations that turn off code formatting in DataItem.
3192 * src/main/java/org/glom/web/shared/DataItem.java:
3194 2011-09-23 Ben Konrath <ben@bagu.org>
3196 Rename GlomField to DataItem and update associated methods.
3198 This is a rename-only refactor. No functionality has been added or
3201 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3202 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3203 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3204 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3205 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3206 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3207 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3208 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3210 * src/main/java/org/glom/web/server/database/DBAccess.java:
3211 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3212 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3213 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3214 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3215 * src/main/java/org/glom/web/shared/DataItem.java:
3216 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3217 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3219 2011-09-23 Ben Konrath <ben@bagu.org>
3221 Rename GlomDocument to DocumentInfo and update associated methods.
3223 This is a rename-only refactor. No functionality has been added or
3226 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3227 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3228 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3229 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3230 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3232 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3234 2011-09-20 Ben Konrath <ben@bagu.org>
3236 Require java-libglom 1.17.3.
3238 This picks up the fix for the seg fault problem with the Scenes table
3239 in the Openismus Film Manager example.
3243 2011-09-20 Ben Konrath <ben@bagu.org>
3245 Change the way sort clause is added for primary key when no sort clause is requested.
3247 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3248 before the sort clause is created. When a sort clause is not requested, the
3249 sort clause is created by finding the primary key in the LayoutFieldVector
3252 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3254 2011-09-20 Ben Konrath <ben@bagu.org>
3256 Log error message if no documents are found in the configured directory.
3258 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3259 Extract the glom file extension string to a private static final class
3260 variable (mostly as syntactic sugar). Accept a minor formatting change.
3261 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3262 the example glom.document.directory configuration property to make it
3263 more clear that it can any directory, not just the home directory.
3265 2011-09-18 Ben Konrath <ben@bagu.org>