1 2012-01-18 Murray Cumming <murrayc@murrayc.com>
3 Improve the placement of the locales drop-down.
5 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
6 Put the title and locales drop-down in a div (gwt.FlowTable).
7 * src/main/webapp/style.css: Add magic css properties to make this work.
8 Also remove the left margin from the title so that it lines up with the
11 2012-01-18 Murray Cumming <murrayc@murrayc.com>
13 locales selector: Show human-readable locale titles.
15 * src/main/java/org/glom/web/server/ConfiguredDocument.java
16 getDocumentInfo(): Use java.util.Locale to show a real title of
17 each locale, in the locale's own language.
19 2012-01-17 Murray Cumming <murrayc@murrayc.com>
21 Add a language/locale selector drop-down.
23 * src/main/java/org/glom/web/shared/DocumentInfo.java:
24 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
25 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
26 getDocumentInfo(): Store the available Locales in the DocumentInfo.
27 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
28 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
29 Add a ListBox to show the available locales. Add getLocaleSelector(),
30 setLocaleList(), getSelectedLocale(), setSelectedLocale().
31 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
32 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
33 java: Add these classes.
34 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
35 start(): Fill the locales ListBox. Handle its change event, firing a
37 setPlace(): Show the selected locale as specified by the URL token.
38 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
39 * src/main/java/org/glom/web/client/activity/ListActivity.java:
40 Handle LocaleChangeEvent, going to a new *Place with that locale.
42 The placement of the ListBox is not pretty, and it currently uses the ID
43 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
47 2012-01-17 Murray Cumming <murrayc@murrayc.com>
49 Search box: Show the search text from the URL token.
51 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
52 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
53 Add setQuickFindText().
54 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
55 .java: setPlace(): Store the queryText if the place is a ListPlace,
56 and call TableSelectionView.setQuickFindText().
58 2012-01-17 Murray Cumming <murrayc@murrayc.com>
60 Allow use of translations via, for instance, &lang=de in the URL.
62 * pom.xml: Use the unstable java-libglom 1.21 version.
64 * src/main/java/org/glom/web/client/OnlineGlomService.java:
65 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
66 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
67 init(): Instead of calling TranslatableItem.set_current_locale()
68 (now removed), call ConfiguredDocument.setDefaultLocaleID().
69 However, this is only for default locales, which are not needed to
70 change the locale in the URL.
71 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
72 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
73 getSortedRelatedListData(): Add a localeID parameter, so we can get the
74 layout for a particular locale.
75 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
76 Add get/setDefaultLocaleID().
77 getDocumentInfo(), getListViewData(), getRelatedListData(),
78 getDetailsLayoutGroup(), getListViewLayoutGroup(),
79 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
80 localeID parameter, so we can get the layout for a particular locale.
82 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
83 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
84 * src/main/java/org/glom/web/client/place/ListPlace.java:
85 Parse and construct a lang parameter too.
87 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
88 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
89 passed to subsequent methods and constructors.
90 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
91 * src/main/java/org/glom/web/client/activity/ListActivity.java:
92 Store the localeID from the *Place and pass it to other constructors
93 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
95 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
96 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
97 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
98 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
99 * src/main/java/org/glom/web/client/ui/ListView.java:
100 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
101 Take localeID parameters and pass them to subsequent constructors and
102 methods, so that the layout is always retrieved for that locale.
104 This is rather repetitive.
106 Note that "" means the original (default) locale of the Glom document,
107 which is usually English.
109 2012-01-17 Murray Cumming <murrayc@murrayc.com>
111 Documents: Remove final keyword to fix startup configuration.
113 * src/main/java/org/glom/web/shared/Documents.java: Remove the
114 final keywords on the private member variables because that breaks
115 the startup, apparently (there are warnings) because it stops them
116 from being serialized. I added these in the previous commit.
118 2012-01-13 Murray Cumming <murrayc@murrayc.com>
120 Documents: Add some final keywords.
122 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
125 2012-01-13 Murray Cumming <murrayc@murrayc.com>
127 OnlineGlomServiceImpl: Add to overview comments.
129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
130 Note that this is where all the document are loaded. They are not
131 loaded freshly for each page.
133 2012-01-12 Murray Cumming <murrayc@murrayc.com>
137 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
138 Add a TextBox for the text of a quick find.
139 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
141 setBackLink(): Add a String quickFind parameter.
142 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
143 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
144 to the base interface, because that is how TableSelectionViewImpl is used.
145 * src/main/webapp/style.css: Add style for the search box and its label.
147 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
148 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
149 Add these files, based on the existing TableChangeEvent and
150 TableChangeEventHandlers.
151 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
152 start(): Handle QuickFindChangeEvent, passing its quickFind text to
153 a ListPlace() that the user should be taken to.
154 * src/main/java/org/glom/web/client/activity/ListActivity.java
155 start(): Handle it here too and adapt the TableChangeEvent handler to
156 pass the extra "" quickFind parameter to ListPlace.
157 * src/main/java/org/glom/web/client/place/ListPlace.java:
158 Constructor: Take an extra String quickFind parameter and store it,
159 returning it from a new getQuickFind() method.
160 getToken(): Put the quickFind text in the URL token.
161 getPlace(): Parse the quickFind text from the URL token.
162 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
163 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
164 ListPlace constructor.
165 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
166 .java: start(): Add a Change handler for the TableSelectionView's
167 TextBox (via its base HasChangeHandlers interface), firing the new
168 QuickFindChangeEvent.
169 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
170 pass the extra "" quickFind parameter.
172 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
173 setCellTable(): Add a String quickFind parameter and pass it to
174 the ListViewTable() constructor.
175 * src/main/java/org/glom/web/client/ui/ListView.java: Change
176 setCellTable() in the base interface, because that is how ListViewImpl
179 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
180 Add a String quickFind member variable.
181 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
182 Constructor: Add a String quickFind parameter, storing it in the
183 base ListTable's member variable.
184 onRangeChanged(): Pass quickFind to the
185 OnlineGlomServiceAsync.getSortedListViewData() and
186 OnlineGlomServiceAsync.getListViewData() methods.
188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
189 getListViewData(), getSortedListViewData(): Add a String quickFind
190 parameter, passing it to ConfiguredDocument.getListViewData().
191 * src/main/java/org/glom/web/client/OnlineGlomService.java:
192 Change getListViewData(), getSortedListViewData() in the base interface,
193 because that is how OnlineGlomServiceImpl is used, via this:
194 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
195 Change getListViewData(), getSortedListViewData() here too.
196 This class can apparently be used to asynchronously call methods on
197 OnlineGlomService, and GWT seems to implement that after recognizing
198 just the *Async name convention and the extra AsyncCallback parameters.
200 * src/main/java/org/glom/web/server/ConfiguredDocument.java
201 getListViewData(): Add a String quickFind parameter, and pass it to
202 ListViewDBAccess.getData().
203 * src/main/java/org/glom/web/server/database/ListDBAccess.java
204 getListData(): Add a String quickFind parameter and pass it to
206 getSelectQuery(): Add a String quickFind parameter.
207 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
208 getSelectQuery(): Add a String quickFind parameter and use it with
209 Glom.get_find_where_clause_quick() to pass a where_clause to
210 Glom.build_sql_select_with_where_clause(), to actually filter the
212 getData(): Add a String quickFind parameter, passing it to getListData().
213 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
214 va: getData(): Pass an empty string to getListData() for the
217 2012-01-12 Murray Cumming <murrayc@murrayc.com>
219 ListTable: Minor change.
221 * src/main/java/org/glom/web/client/ui/list/ListTable.java
222 createCellTable(): Make this protected instead of public.
224 2012-01-12 Murray Cumming <murrayc@murrayc.com>
226 Many files: Use final for the parameters and use the @override attribute.
228 2012-01-22 Ben Konrath <ben@bagu.org>
230 Add anchor links for single line text that starts with http, ftp and www.
234 2012-01-22 Ben Konrath <ben@bagu.org>
236 Add ellipsis to single line text in details view.
240 2012-01-04 Murray Cumming <murrayc@murrayc.com>
242 Remove all javadoc author tags.
244 Because they are awkward and meaningless when many people touch
246 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
248 2012-01-04 Murray Cumming <murrayc@murrayc.com>
250 Revert the COPYING.LESSER to COPYING rename.
252 Apparently both should be there if it is LGPL.
254 2012-01-03 Murray Cumming <murrayc@murrayc.com>
256 *View: Remove unused imports.
258 * src/main/java/org/glom/web/client/ui/DetailsView.java:
259 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
260 * src/main/java/org/glom/web/client/ui/ListView.java:
261 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
262 Remove unused imports, as suggested by Eclipse.
264 2012-01-02 Murray Cumming <murrayc@murrayc.com>
266 Move the *View::Presenter types, and some API into one base View.
268 * src/main/java/org/glom/web/client/ui/DetailsView.java:
269 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
270 * src/main/java/org/glom/web/client/ui/ListView.java:
271 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
272 Presenter, setPresenter() and clear() into a shared base interface,
273 to avoid the unnecessary duplicate Presenter types and to more clearly
274 show how the *Views share the same structure, even if they are not
275 used polymorphically.
277 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
278 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
280 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
281 * src/main/java/org/glom/web/client/activity/ListActivity.java:
282 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
284 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
287 Feel free to revert this if there is a good reason for the duplicate
290 2012-01-02 Murray Cumming <murrayc@murrayc.com>
292 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
294 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
295 a class member instead of a local variable in the method.
296 This lets us use it to get the view instances, for use in tests.
297 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
298 beforeOnlineGlom(): Test some more details of the initial view.
299 Again, this is not very useful.
301 To really test gwt-glom we will need to start a local postgresql
302 instance with local data, like the Glom tests in C++.
304 2012-01-02 Murray Cumming <murrayc@murrayc.com>
306 pom.xml: Mention the LGPL license.
308 * pom.xml: Add a licenses section.
309 * COPYING.LESSER: Move this to COPYING, which
310 previously contained the GPL. But gwt-glom is all LGPL.
312 2012-01-02 Murray Cumming <murrayc@murrayc.com>
314 Add project information to README and pom.xml.
316 * README: Add a brief description and mention some mvn
318 * pom.xml: This extra information shows up in mvn site
321 2011-01-02 Murray Cumming <murrayc@murrayc.com>
323 Use the latest java-libglom version.
325 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
327 2012-01-01 Murray Cumming <murrayc@murrayc.com>
329 GwtTestOnlineGlom: Test a little more.
331 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
332 protected rather than private, as suggested by the gwt-test-utils
334 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
335 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
336 Test the initial visibility of the panels.
338 However, this is not a very useful test.
339 And I wonder how we should generally test using this idea for an
340 activity/places app like ours where the real changes happen implicitly
341 based on the history token/URL.
343 2012-01-01 Murray Cumming <murrayc@murrayc.com>
345 Slight modification to *Mapper comments.
347 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
349 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
351 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
353 Remove comments mentioning GIN because they are just copied from
354 the example code and are apparently not helpful:
355 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
356 Also change the mention of a class that is only in the example code.
358 2012-01-01 Murray Cumming <murrayc@murrayc.com>
360 GwtTestOnlineGlom test: Minor changes.
362 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
363 Avoid the long qualified class name and modify the comment
364 because it is now obvious to me that the mocked class is the only
365 custom one created via GWT.create().
367 2012-01-01 Murray Cumming <murrayc@murrayc.com>
369 Tests: Added the beginnings of a test using gwt-test-utils.
371 * pom.xml: Add dependencies on gwt-test-utils and easymock.
372 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
373 which tells gwt-test-utils what class will be tested.
374 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
375 Add a simple (but empty) test case. One class, used by the OnlineGlom
376 class, is mocked so that it can be created. However, I am not sure
377 why only this class needs to be mocked.
379 Note that mockito seems more popular, and clearer, than easymock,
380 but I have not got that working yet. It might be a matter of the
383 This test is run during mvn integration-test.
385 2011-12-31 Murray Cumming <murrayc@murrayc.com>
387 Tests: Use junit4-style syntax instead of junit3-style.
389 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
390 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
391 * src/test/java/org/glom/web/shared/DataItemTest.java:
392 Use the @Test annotation rather than relying on the test*() prefix.
393 Also no longer implement TestCase, to avoid triggering support for
394 the junit3-way, which stops the annotations from working.
395 Change the imports from import junit.framework.* to
396 import org.junit.*, which is apparently the new way.
398 2011-12-31 Murray Cumming <murrayc@murrayc.com>
400 Added a test for ListPlace token parsing and creation.
402 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
403 This is much the same as DetailsPlaceTest.
405 I wonder how we could test the other parts of the *Place API.
407 2011-12-30 Murray Cumming <murrayc@murrayc.com>
409 DetailsPlace test: Also test getToken() and recreation via getPlace().
411 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
412 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
413 recreate it, testing the recreated DetailsPlace for the same parameter
416 2011-12-30 Murray Cumming <murrayc@murrayc.com>
418 Use the surefire-report plugin.
420 * pom.xml: This generates a HTML report about the tests in
421 target/site/surefire-report.html
422 when you do mvn surefire-report:report. It seems to be popular/normal.
424 2011-12-30 Murray Cumming <murrayc@murrayc.com>
426 Added a test for DetailsPlace.
428 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
429 Test the getPlace() token parsing.
431 2011-12-30 Murray Cumming <murrayc@murrayc.com>
433 Added a first unit test.
435 * pom.xml: Add a test goal, and a dependency on junit in that scope.
436 * src/test/java/org/glom/web/shared/DataItemTest.java:
437 This is a silly test but it is just to get things started. Note that
438 maven/junit finds the test because it looks in src/test by default.
440 2011-12-22 Ben Konrath <ben@bagu.org>
442 Change charsetName to "UTF-8" when replacing line breaks.
444 JavaScript requires the charsetName to be "UTF-8". CharsetName values
445 that work in Java (such as "UTF8") will not work when compiled to
448 This fixes a problem with multi-line details view fields that have hard
449 line breaks. The "License Text" field on this page demonstrates the
452 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
454 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
456 2011-12-22 Ben Konrath <ben@bagu.org>
458 Fix another bug with related list navigation.
460 I've tested all the navigation buttons in all of the related lists
461 so things should be good now.
463 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
465 2011-12-22 Ben Konrath <ben@bagu.org>
467 Fix a crasher when refreshing the list view with the default table.
469 This crash will also happen when loading the list view with the default
470 table from a link or bookmark.
472 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
473 to the main document selection page when the document id hasn't been
475 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
476 the main document selection page when the document id hasn't been
478 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
479 values for the details place when the document id hasn't been set.
480 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
481 values for the list place when the document id hasn't been set.
483 2011-12-21 Ben Konrath <ben@bagu.org>
485 Protect against NPE when glom.document.locale is not in config.
487 This patch protects against an NPE when glom.document.locale is not in
488 the config file. This NPE will also happen if glom.document.locale is
491 The patch also updates the error message to display the class name when
492 the getMessage() returns null. This was happening when the NPE was
493 thrown and I had "Configuration Error: null". If an NPE is encountered
494 with this patch, "Configuration Error: NullPointerException " will be
497 This commit closes this bug:
499 https://bugzilla.gnome.org/show_bug.cgi?id=666669
501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
503 2011-12-20 Murray Cumming <murrayc@murrayc.com>
505 Rename onlineglom.properties to onlineglom.properties.sample.
507 * src/main/resources/onlineglom.properties: Rename to:
508 * src/main/resources/onlineglom.properties.sample:
509 * src/main/resources/README: And add this file explaining that people
510 should rename it back when deploying.
512 2011-12-20 Murray Cumming <murrayc@murrayc.com>
514 Allow choosing the translation in the .properties file.
516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
517 init(): Read a glom.document.locale value from the configuration file
518 and call Glom's TransatableItem::set_current_locale() method.
519 * src/main/resources/onlineglom.properties: Add a commented-out
520 example of this new setting.
522 It would be better to add &lang=de_DE to the URL, but the current
523 libglom API does not allow us to do this easily. I am working on that.
525 2011-12-19 Murray Cumming <murrayc@murrayc.com>
527 Avoid a crash in parsing of token parameters.
529 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
530 ava: getTokenParams(): Do not crash if a parameter has a key but no
531 value, and ignore parameters with neither.
533 2011-12-17 Murray Cumming <murrayc@murayc.com>
535 History token building/handling: Improve use of token parameters.
537 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
538 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
539 and buildParamsToken(HashMap), for use by derived classes.
540 Make the separator private because it is no longer be needed.
541 * src/main/java/org/glom/web/client/place/DetailsPlace.java
542 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
543 instead of manual string concatenation.
544 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
545 of hardcoded indices and awkward splitting code.
546 * src/main/java/org/glom/web/client/place/ListPlace.java
547 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
548 instead of manual string concatenation.
549 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
550 of hardcoded indices and awkward splitting code.
551 This should fix bug #666420
553 2011-12-16 Murray Cumming <murrayc@murrayc.com>
555 Fix a Navgiation->Navigation typo in the code.
557 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
558 Rename processNavgiation() to processNavigation().
560 2011-12-16 Murray Cumming <murrayc@murrayc.com>
562 Fix a seperator->separator typo in the code.
564 * src/main/java/org/glom/web/client/place/DetailsPlace.java
565 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
566 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
569 2011-12-15 Ben Konrath <ben@bagu.org>
571 Cleanup some comments.
573 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
575 2011-12-14 Ben Konrath <ben@bagu.org>
577 Replace \n with <br/> for multiline text in the details view.
579 Vertical scrollbars are added when needed as well.
581 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
583 2011-12-14 Ben Konrath <ben@bagu.org>
585 Specify the font for document selection links.
587 * src/main/webapp/style.css:
589 2011-12-14 Ben Konrath <ben@bagu.org>
591 Fix bouncy CellTable while paging.
593 This doesn't currently work with related list tables in unselected
596 * src/main/java/org/glom/web/client/ui/list/ListTable.java
598 2011-12-14 Ben Konrath <ben@bagu.org>
600 Revamp the appearance of the document selection page.
602 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
603 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
604 * src/main/webapp/style.css:
606 2011-12-13 Ben Konrath <ben@bagu.org>
608 Set navigation button column to the smallest size possible.
610 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
612 2011-12-13 Ben Konrath <ben@bagu.org>
614 Change OpenButton nomenclature to NavigationButton.
616 Using NavigtionButton makes things more generic. Classes, methods and
617 variables have been changed.
619 This is a rename-only refactor.
621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
622 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
623 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
624 Renamed from OpenButtonCell.
625 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
626 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
627 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
629 2011-12-12 Ben Konrath <ben@bagu.org>
631 Remove unnecessary String argument in RelatedListTable and ListViewTable.
633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
634 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
635 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
636 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
638 2011-12-12 Ben Konrath <ben@bagu.org>
640 Update variable names and comments.
642 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
643 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
645 2011-12-12 Ben Konrath <ben@bagu.org>
647 Properly initialize numNonEmptyRows variable to zero.
649 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
650 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
652 2011-12-05 Ben Konrath <ben@bagu.org>
654 Add latest mockup with HTML tables.
656 Features of this mockup:
658 -> HTML table for flowtable
659 -> HTML table for flowtable column
660 -> Example of how related lists would look
661 -> Not using text entries for data items
663 The current version of Online Glom doesn't use HTML tables for the
666 This mockup has been sent to the glom-devel mailing list but it's good
667 to have it here as well.
669 * mockups/details-view-html-tables.html:
671 2011-12-05 Ben Konrath <ben@bagu.org>
673 Remove unnecessary getPrimaryKeyField() method.
675 getPrimaryKeyFieldForTable(String) has been renamed to
676 getPrimaryKeyField(String).
678 * src/main/java/org/glom/web/server/database/DBAccess.java:
679 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
680 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
682 2011-12-05 Ben Konrath <ben@bagu.org>
684 Add string representation of TypedDataItem value to conversion error message.
686 * src/main/java/org/glom/web/server/Utils.java: Logging the error
687 message was extracted into its own method to avoid duplication.
689 2011-12-05 Ben Konrath <ben@bagu.org>
691 Add type checking to navigation primary key value creation.
693 Create navigation primary key only if the expected type from the Glom
694 document matches the type returned by the SQL query.
696 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
698 2011-12-05 Ben Konrath <ben@bagu.org>
700 Rename a couple of variables in RelatedListNavigation.
702 This is a rename-only refactor.
704 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
706 2011-12-05 Ben Konrath <ben@bagu.org>
708 Move getListLayoutGroup() into getListViewLayoutGroup().
710 This removes getListLayoutGroup(). It was only being called by
711 getListViewLayoutGroup().
713 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
715 2011-12-05 Ben Konrath <ben@bagu.org>
717 Remove check for LayoutItem_Portal in list table method.
719 This check is no longer necessary because the method isn't being used
720 to create the LayoutItemPortal DTO.
722 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
724 2011-12-05 Ben Konrath <ben@bagu.org>
726 Properly support related list navigation.
728 Navigation from the "Repository Analyzer -> Package Scans ->
729 Dependencies" related table wasn't working because the primary key for
730 related tables wasn't being set properly. This commit fixes the
733 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
734 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
735 doesn't set the primary key properly for related list tables.
736 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
737 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
738 useful for getting the primary key for list view tables and for related
740 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
741 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
742 Move code to set the primary key for the table from the abstract
743 ListDBAccess class to ListViewDBAccess as it's only correct for list
745 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
746 Properly add primary key to related list tables.
748 2011-12-02 Ben Konrath <ben@bagu.org>
750 Properly set the horizontal alignment of fields.
752 This fix is for both the list tables and the details view.
754 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
755 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
756 to set the horizontal alignment of fields.
758 2011-12-02 Ben Konrath <ben@bagu.org>
760 Display currency codes in the details view.
762 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
764 2011-12-02 Ben Konrath <ben@bagu.org>
766 Avoid duplicate JNI call.
768 JNI is not as efficient as pure Java and this is an easy (and small)
771 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
772 Use previously retrieved value for whereClauseToTableName instead of
775 2011-12-02 Ben Konrath <ben@bagu.org>
777 Rename a couple of variables in RelatedListNavigation.
779 This is a rename-only refactor.
781 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
783 2011-12-02 Ben Konrath <ben@bagu.org>
785 Indicate clearly that a mismatched primary key type is a bug.
787 * src/main/java/org/glom/web/server/Utils.java: Change log level from
788 warning to error. Add 'This is a bug.' to message.
790 2011-12-02 Ben Konrath <ben@bagu.org>
792 Update / fix some comments.
794 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
796 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
798 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
799 Fix comments. Add some TODOs.
801 2011-12-02 Ben Konrath <ben@bagu.org>
803 Enable navigation to details view with string primary key from related list.
805 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
806 Create a text primary key value when return type of result is
807 java.sql.Types.VARCHAR.
809 2011-12-02 Ben Konrath <ben@bagu.org>
811 Use checkboxes for booleans in the details view.
813 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
815 2011-12-01 Ben Konrath <ben@bagu.org>
817 Improve performance of related list height calculation.
819 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
820 Put code to calculate the expected height in a static initializer so
821 that that it's only called once.
823 2011-12-01 Ben Konrath <ben@bagu.org>
825 Show related list tables in notebooks (again).
827 Calculate the height of the related list tables so the Notebook can be
828 set the correct height. The height of the related list table is also needed by
829 FlowTable to be able decide how to create the layout.
831 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
832 and set the Portal height based on the height of the related list
833 table and the Portal container.
834 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
835 Add method to calculate the height of the related list tables.
836 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
837 * src/main/webapp/style.css: Add css class for Pager. This is needed to
838 calculate the height of the Pager widget.
840 2011-12-01 Ben Konrath <ben@bagu.org>
842 Use CellTable API for table property instead of setting style on Element.
844 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
846 2011-12-01 Ben Konrath <ben@bagu.org>
848 Make ListViewTable and RelatedListTable a consistent height.
850 The tables are now a consistent height regardless of the contents of
851 the table. A hidden button is added to empty rows to ensure that the
852 height of these rows will match the height of rows with data.
854 A navigation button column is now added to every table. The width of
855 the navigation column is set to 0px when a RelatedListTable shouldn't
856 have navigation buttons. This maintains the a consistent row height in
857 tables that don't show the navigation buttons.
859 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
860 navigation column when not needed.
861 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
862 arguments for navigation button to constructor of ListViewTable.
863 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
864 hidden button for empty data rows.
865 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
866 arguments for navigation button to constructor.
867 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
868 create navigation buttons. Add hideNavigationButtons() method.
869 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
870 arguments for navigation button to constructor.
872 2011-12-01 Ben Konrath <ben@bagu.org>
874 Use 'visibility: hidden' in Utils.getWidgetHeight().
876 This is better choice because hidden elements are invisible, don't
877 respond to events and are not part of the tab order. They will,
878 however, take up space which is required to be able to calculate the
879 height of the widget.
881 * src/main/java/org/glom/web/client/Utils.java:
883 2011-12-01 Ben Konrath <ben@bagu.org>
885 Use Utils.getWidgetHeight() in FlowTable.
887 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
889 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
891 2011-12-01 Ben Konrath <ben@bagu.org>
893 Put the details css class name on the correct table column.
895 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
897 2011-11-30 Ben Konrath <ben@bagu.org>
899 Update for java-libglom API change.
901 The getters and setters on FieldFormatting and NumericFormat were
902 changed to remove the 'M'.
904 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
906 2011-11-29 Ben Konrath <ben@bagu.org>
908 Only allow RelatedListTables in Portals.
910 * src/main/java/org/glom/web/client/ui/details/Portal.java:
912 2011-11-29 Ben Konrath <ben@bagu.org>
914 Only create a contents panel for Portals when title is being set.
916 * src/main/java/org/glom/web/client/ui/details/Portal.java:
918 2011-11-29 Ben Konrath <ben@bagu.org>
920 Set TabLayoutPanel height based on calculated height its widgets.
922 This is a potential fix for this bug:
924 https://bugzilla.gnome.org/show_bug.cgi?id=665133
926 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
928 2011-11-29 Ben Konrath <ben@bagu.org>
930 Align details field labels and data with the Open buttons.
932 * src/main/webapp/style.css:
934 2011-11-29 Ben Konrath <ben@bagu.org>
936 Remove unnecessary <div> in the Notebook widget.
938 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
939 method to get container FlowPanel (<div>).
940 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
941 initWidget() method directly on the TabLayoutPanel widget instead of
942 Group's container widget.
944 2011-11-29 Ben Konrath <ben@bagu.org>
946 Don't add group titles for Portals in Notebooks.
948 This reverts the previous patch and fixes a bug I introduced with
949 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
951 * src/main/java/org/glom/web/client/ui/details/Group.java:
952 * src/main/java/org/glom/web/client/ui/details/Portal.java:
954 2011-11-28 Ben Konrath <ben@bagu.org>
956 Remove unused boolean argument in Portal constructor.
960 * src/main/java/org/glom/web/client/ui/details/Group.java:
961 * src/main/java/org/glom/web/client/ui/details/Portal.java:
963 2011-11-28 Ben Konrath <ben@bagu.org>
965 Remove hack for glom 1.18 style glom files.
967 * src/main/java/org/glom/web/client/ui/details/Group.java:
968 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
969 * src/main/java/org/glom/web/client/ui/details/Portal.java:
971 2011-11-28 Ben Konrath <ben@bagu.org>
973 Use Gda Value version of primary key to log result too large error.
975 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
977 2011-11-28 Ben Konrath <ben@bagu.org>
979 Don't use TypedDataItem.getText() for Unknown types from the URL.
981 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
982 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
983 instead of getText().
984 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
985 String field and getUnknown() method.
987 2011-11-28 Ben Konrath <ben@bagu.org>
989 Log an error message when the java-libglom .so is not present.
991 The error message was being set in the exception but not logged.
993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
995 2011-11-28 Ben Konrath <ben@bagu.org>
997 Ignore LayoutItem_CalendarPortals.
999 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1000 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1002 2011-11-28 Ben Konrath <ben@bagu.org>
1004 Extract method for creating the LayoutItemPortal DTO.
1006 Just breaking the code up into smaller chunks.
1008 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1010 2011-11-28 Ben Konrath <ben@bagu.org>
1014 This should have been added with the refactor. Oops!
1016 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1018 2011-11-28 Ben Konrath <ben@bagu.org>
1020 Create primary key value from URL string using type from Glom document.
1022 See this bug, comments 19 - 25:
1024 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1026 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1027 create a TypeDataItem for the primary key here when loading from a
1028 URL. Show the same string for the primary key value as was received
1029 from the URL string (when loading from a URL).
1030 * src/main/java/org/glom/web/server/Utils.java: Update method for
1031 creating the Gda Value from the TypeDataItem to properly deal with
1032 creating a Gda Value based on the Glom document type for the primary
1033 key value string when loading from a URL.
1034 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1035 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1036 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1037 Update for changed method name.
1039 2011-11-27 Ben Konrath <ben@bagu.org>
1041 Rename PrimaryKeyItem to TypedDataItem.
1043 The name PrimaryKeyItem suggests what the class should be used for.
1044 TypedDataItem is a neutral name that describes the class better.
1046 This is a rename-only refactor.
1048 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1049 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1050 * src/main/java/org/glom/web/client/Utils.java:
1051 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1052 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1053 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1054 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1055 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1056 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1057 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1058 * src/main/java/org/glom/web/server/Utils.java:
1059 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1060 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1061 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1062 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1064 2011-11-25 Ben Konrath <ben@bagu.org>
1066 Improve Gda Value conversion from PrimaryKeyItem.
1068 The value from the PrimaryKeyItem is only used if its type match the
1069 type from the glom document.
1071 * src/main/java/org/glom/web/server/Utils.java:
1073 2011-11-25 Ben Konrath <ben@bagu.org>
1075 Manually check if the java-liblgom .so is visible to the JVM.
1077 It seems that Tomcat has problems when a static initializer throws an
1078 exception. This check is done before the first method call into
1079 java-libglom so that execution doesn't continue if the .so is not
1082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1084 2011-11-25 Ben Konrath <ben@bagu.org>
1086 Improve browser configuration error messages.
1090 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1092 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1093 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1094 getConfigurationErrorMessage() method.
1095 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1096 Get and display a specific configuration error message when no Glom
1097 documents are found.
1098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1099 Implement getConfigurationErrorMessage() method. Surround configuration
1100 code in the init() method with a try/catch block. This allows the
1101 errors to be caught while keeping the servlet available to retrieve the
1102 configuration error message.
1104 2011-11-25 Ben Konrath <ben@bagu.org>
1106 Don't use Strings to hold primary key values.
1108 The primary key values are now held in a new data object
1109 (PrimaryKeyItem) that holds type information and the primary key value
1110 using the correct type.
1112 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1113 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1115 PrimaryKeyItem instead of String to hold the primary key value.
1116 * src/main/java/org/glom/web/client/Utils.java: Remove
1117 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1118 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1119 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1120 PrimaryKeyItem instead of String to hold the primary key value. Load
1121 document selection page when the documentID has not been set correctly.
1122 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1123 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1125 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1126 Return empty string for URL instead of "null".
1127 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1128 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1129 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1130 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1131 PrimaryKeyItem instead of String to hold primary key values.
1132 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1133 PrimaryKeyValue to a Gda Value.
1134 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1135 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1136 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1137 Replace temporary database access code that uses the PrimaryKeyValue to
1138 Gda Value conversion.
1139 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1140 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1141 PrimaryKeyItem instead of String.
1142 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1143 hold primary key values.
1145 2011-11-24 Ben Konrath <ben@bagu.org>
1147 Use newly added java-libglom API to create queries.
1149 This isn't finished. I still need to stop using Strings for primary key
1150 values in the client code.
1152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1153 libglom to use fake connections so that retrieving the query string will
1155 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1156 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1157 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1158 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1159 Use the newly added libglom sql methods and classes to create the
1160 query. Add temporary hack to convert primary value strings to Gda
1163 2011-11-23 Ben Konrath <ben@bagu.org>
1165 Don't explicitly set the height of Portals.
1167 See comments 6 - 10 of this bug for details:
1169 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1171 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1173 2011-11-23 Ben Konrath <ben@bagu.org>
1175 Use an HTML table instead of CSS for the FlowTable layout.
1177 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1178 GWT's FlexTable to implement the FlowTable.
1179 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1181 2011-11-18 Ben Konrath <ben@bagu.org>
1183 Add boolean example to HTML table mockup.
1185 * mockups/details-view-html-tables-text-entries.html:
1187 2011-11-17 Ben Konrath <ben@bagu.org>
1189 Ensure the pager buttons are always visible for related lists.
1191 To accomplish this, I've turned off text wrapping in the list view and
1192 related list tables for both the header and data text. The related list
1193 table now has a fixed layout so the it doesn't overflow its container.
1194 This is required to ensure that the cell text is clipped when it
1195 overflows the cell and an ellipsis is added to the right side of the
1196 cell when text is clipped.
1198 A fixed table layout for the related list table in the details view
1199 seems what we want for the details view anyway, so the side-effect is
1202 The ellipsis will only be displayed in Firefox >= 7.
1206 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1208 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1209 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1210 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1212 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1213 Set the 'table-layout: fixed' CSS property to the related list table.
1214 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1215 'white-space: nowrap;' CSS property on both the list view and the
1216 related list tables.
1218 2011-11-16 Ben Konrath <ben@bagu.org>
1220 Rework the fix for empty notebook tab labels.
1222 Setting the empty group titles with its name caused problems for the
1223 details layout. Instead of using libglom's
1224 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1225 to the client when the title is empty. This allows the Notebook to use
1226 the name when the title is empty without affecting anything else.
1228 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1229 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1231 2011-11-16 Ben Konrath <ben@bagu.org>
1233 Set group titles with name when title is empty.
1235 This fixes a problem with an empty notebook tab label in the Lesson
1236 Planner document. The forth tab in the notebook should be "Internet":
1238 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1240 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1241 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1244 2011-11-16 Ben Konrath <ben@bagu.org>
1246 Remove whitespace from the configured username properties.
1248 This assumes that usernames won't have whitespace at the beginning
1249 or end. But I think this is a reasonable assumption.
1251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1252 String.trim() to remove the whitespace from the username properties.
1254 2011-11-15 Ben Konrath <ben@bagu.org>
1256 Add details view mockup with HTML tables and text entries.
1258 This is from the attachment on this bug:
1260 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1262 * mockups/details-view-html-tables-text-entries.html:
1264 2011-11-15 Ben Konrath <ben@bagu.org>
1266 Add space between the columns of the flow table.
1270 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1272 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1273 space between columns in the flow table.
1275 2011-11-15 Ben Konrath <ben@bagu.org>
1277 Add backup files to the .gitignore.
1279 * .gitignore: Ignore files that end with ~.
1281 2011-11-09 Ben Konrath <ben@bagu.org>
1283 Use latest release of gwt-log.
1285 Gwt-log releases are now being submitted to the maven central
1286 repository so manual installation of the jar is no longer required.
1288 * pom.xml: Update version and groupId of gwt-log dependency.
1290 2011-10-31 Ben Konrath <ben@bagu.org>
1292 Don't use GWT numeric formatting to override the glom currency formatting.
1294 Currencies are now displayed like they are in Glom. See this bug:
1296 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1298 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1300 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1301 currency code to constructor and set it when the cell is rendered.
1302 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1303 currency code to the constructor of the NumericCell.
1305 2011-10-27 Ben Konrath <ben@bagu.org>
1307 Require the latest release of java-libglom (1.17.4).
1311 2011-10-26 Ben Konrath <ben@bagu.org>
1313 Add style to Notebook that matches current theme.
1315 It's not the best style in the world but it's better than the default.
1317 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1318 padding at the bottom of the child widgets.
1319 * src/main/webapp/style.css: Add style for the Notebook.
1321 2011-10-26 Ben Konrath <ben@bagu.org>
1323 Move servlet initialization code to overridden init method.
1325 This is half of the solution to getting proper error messages
1326 displayed when configuration errors occur. Here's the relevant bug:
1328 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1330 The rest of the solution involves surrounding the init method with a
1331 try/catch block and setting a global variable with the error /
1332 exception. A new async method should be created to retrieve and display
1333 the error message / exception.
1335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1336 code from constructor to init method adding exceptions as needed.
1338 2011-10-26 Ben Konrath <ben@bagu.org>
1340 Add script to monitor and restart tomcat if required.
1342 * utils/check-and-recover-tomcat.py: New file.
1344 2011-10-26 Ben Konrath <ben@bagu.org>
1346 Display the correct number of data items in the pager.
1350 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1352 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1353 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1354 The implementation is the same for both tables: Keep track of the
1355 number of non-empty rows and fire and RowCountChangeEvent after the data has
1357 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1358 custom Pager class that subclasses SimplePager to handle displaying
1359 the correct number when empty rows have been added.
1361 2011-10-26 Ben Konrath <ben@bagu.org>
1363 Correct error in previous commit.
1365 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1366 eventBus parameter from listView.setCellTable().
1368 2011-10-26 Ben Konrath <ben@bagu.org>
1370 Fix error in TODO comment.
1372 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1374 2011-10-24 Ben Konrath <ben@bagu.org>
1376 Create Notebook widgets to the details view.
1378 This isn't finished just yet - I still need to create a reasonable
1379 style to match the current theme.
1381 * src/main/java/org/glom/web/client/Utils.java: Add method for
1382 calculating the height of a widget. This is used in the Notebook class.
1383 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1384 new constructor method in Group.
1385 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1386 method for creating child widget that can be used by subclasses
1387 like Notebook. New constructor that allows disabling the group
1388 titles - Notebooks don't set a group title for their child groups.
1389 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1390 to make Notebooks using GWT's TabLayoutPanel.
1391 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1392 constructor that allows disabling the group titles.
1393 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1394 LayoutItemNotebook DTO.
1395 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1396 DTO for Notebooks. It's just an empty class for now but we might need
1397 it to transfer some specific information in the future.
1399 2011-10-21 Ben Konrath <ben@bagu.org>
1401 Add navigation buttons to related list tables.
1403 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1404 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1406 method getSuitableRecordToViewDetails() for getting the table name
1407 and primary key value for related list navigation buttons.
1408 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1409 private cell renderer class to get the navigation information for
1410 related list tables from the server. Extract the navigation
1411 processing code from the details cell navigation and use it for the
1412 related list navigation as well.
1413 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1414 cell renderer class for the details open buttons. This was needed
1415 because the related list navigation buttons and the list view
1416 navigation buttons need to react differently when clicked.
1417 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1418 the onEnterKeyDown() method because it's now overriden in the
1419 subclasses that are specific to the related list tables and the list
1421 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1422 the vertical size a little because the buttons add a bit of vertical
1423 space to table. This is not a perfect solution because the vertical
1424 size of with table fewer than 5 rows will be a little smaller.
1425 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1426 changes in how navigation buttons are handled.
1427 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1428 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1429 database access object.
1430 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1431 to find the portal for a given relationship name from
1432 RelatedListDBAccess. Add method to find a primary key field for a
1434 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1435 Move code to find the portal for a given relationship name to
1437 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1438 New file: database access object for getting the related list
1439 navigation information (the table name and the primary key value).
1440 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1441 DTO for transferring a table name to navigate to and a primary key
1443 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1444 boolean and getter/setter to specifies if the related list should add
1447 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1449 Use the master branch of java-libglom
1451 * pom.xml: Depend on java-libglom 1.19 instead.
1453 This is the master branch. See also the libglom-1-18 branch.
1455 2011-10-11 Ben Konrath <ben@bagu.org>
1457 Enable the open navigation button when the data has been set.
1459 This avoids having active buttons that don't do anything when the data
1462 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1464 2011-10-11 Ben Konrath <ben@bagu.org>
1466 Use IsWidget interface for FlowTableItem.
1468 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1469 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1471 2011-10-11 Ben Konrath <ben@bagu.org>
1473 Remove GWT styling from open button in details view.
1475 There are still some issues with how the details cell is arranged but
1476 this should be made to match Glom 1.20. I'm going to leave fixing this
1477 until I have Glom 1.20 up and running.
1479 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1480 style name on open button.
1481 * src/main/webapp/style.css: Move and edit details-navigation class.
1482 Re-arrange some classes to make them appear in the same order as the
1485 2011-10-07 Ben Konrath <ben@bagu.org>
1487 Update to GWT 2.4.0.
1489 * .gitignore: Ignore new cache directory.
1490 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1491 * pom.xml: Change GWT and maven plugin to 2.4.0.
1492 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1494 * src/main/java/org/glom/web/client/ClientFactory.java:
1495 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1496 * src/main/java/org/glom/web/client/OnlineGlom.java:
1497 Update source for API changes.
1498 * utils/build-onlineglom-war.sh: Remove cache directory before the
1501 2011-10-07 Ben Konrath <ben@bagu.org>
1503 Add navigation buttons in the details view.
1505 This isn't finished but I thought I'd commit what I have as it's a
1506 pretty good start. I still need to:
1508 1. Change the style so that it fits better into the current theme
1509 2. Adjust the details cell to expand as much as possible.
1511 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1512 click handlers to navigation buttons in the DetailsCells. Create a
1513 refreshData() method to get just the data from the server without the
1515 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1516 Update the tableSelector and browser title when the table name
1517 changes without using the tableSelector.
1518 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1519 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1520 getDetailsCells() to getCells(). Update variable names.
1521 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1522 method to set click handler on navigation button. Rename a few
1523 variables. Add navigation buttons where needed.
1524 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1525 variables and methods.
1526 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1527 navigation boolean and navigation table as required in the
1528 LayoutItemField DTO.
1529 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1530 variables for navigation along with getter/setter methods.
1532 2011-10-07 Ben Konrath <ben@bagu.org>
1534 Rename Field to DetailsCell.
1536 This is a refactor-only commit. No functionality has been added or
1539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1540 Update variable and method names.
1541 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1542 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1543 variable and method names.
1544 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1546 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1547 variable and method names.
1549 2011-10-07 Ben Konrath <ben@bagu.org>
1551 Create separate methods for layout and data the details view.
1553 This is a refactor-only commit. No functionality has been added or
1556 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1557 private methods: setData(), createLayout().
1559 2011-10-07 Ben Konrath <ben@bagu.org>
1561 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1563 This is part of a change to get navigation buttons in the details view
1564 but it should have been done this way from the start.
1566 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1567 for method name change in TableSelectionView.
1568 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1569 Create TableChangeEvent and set the browser title using the
1570 TableSelectionView API.
1571 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1572 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1573 Change getSelectedTable() to getSelectedTableName(). Add
1574 getSelectedTableTitle().
1576 2011-10-07 Ben Konrath <ben@bagu.org>
1578 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1580 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1582 2011-10-07 Ben Konrath <ben@bagu.org>
1584 Update TableChangeEvent to use newTableName naming convention.
1586 This makes the class more consistent with GWT naming conventions.
1588 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1589 Update for method name change in TableChangeEvent.
1590 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1591 for method name change in TableChangeEvent.
1592 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1593 newTableName variable and getter method. Make toDebugString()
1596 2011-09-30 Ben Konrath <ben@bagu.org>
1598 Disable the pager in the list tables when the data row count is less than the minimum.
1600 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1601 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1603 2011-09-30 Ben Konrath <ben@bagu.org>
1605 Add empty rows to the end of related list and list view tables.
1607 I also extracted the cell rendering classes from the ListTable because
1608 the code was becoming a little crazy with all the anonymous inner
1609 classes. My plan is to use these cell rendering classes in the details
1610 view as well so this refactor will be needed for that change.
1612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1613 set the row count in related list tables if the data has more rows
1614 than the minimum number of rows visible.
1615 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1616 row count in list view tables if the data has more rows than the
1617 minimum number of rows visible.
1618 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1619 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1621 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1622 for rendering TYPE_NUMERIC cells. The code was extracted from the
1624 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1625 class for rendering cells with buttons in list views. The code was
1626 extracted from the ListTable class.
1627 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1628 for rendering TYPE_TEXT cells. The code was extracted from the
1630 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1631 Add empty rows to the end of the data if required. Implement
1632 ListTable.getMinNumVisibleRows().
1633 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1634 cell renderer code to public classes. Return null in
1635 Column.getValue() for empty rows. Add new abstract method:
1636 getMinNumVisibleRows(). Move code to set the row count of the list view
1637 table to ListViewImpl.
1638 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1639 empty rows to the end of the data if required. Implement
1640 ListTable.getMinNumVisibleRows().
1643 2011-09-27 Ben Konrath <ben@bagu.org>
1645 Use GWT.log for client-side debugging statements.
1647 These are optimized out when deployed so I should have used this method
1648 in the first place. These statements will eventually be replaced with some sort
1649 of notification in the browser.
1651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1652 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1653 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1654 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1655 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1657 2011-09-27 Ben Konrath <ben@bagu.org>
1659 Put tableselector on the right, back to list link on right.
1661 The idea is that the table selector is acting like a label for the
1662 currently displayed table so it should be placed below the document title. This
1663 puts the table title in a similar position to where it is in Glom.
1665 * mockups/details-contacts.html:
1666 * mockups/details-projects.html:
1667 * mockups/listview-contacts.html:
1668 * mockups/listview-projects.html:
1669 * mockups/style.css:
1670 Update mockups to match how the interfaces currently look.
1671 * src/main/webapp/style.css: Swap positions of backlink with the table
1672 selector. Add some space on the left side of the table selector to
1673 line things up with the document title.
1675 2011-09-27 Ben Konrath <ben@bagu.org>
1677 Add field colouring to details view.
1679 This change re-works how field colouring works. The colour formatting
1680 information is now set to the client with the layout information instead of
1681 with the data. This eliminates the need to send the same colour strings for
1682 data in list view column when colour information is set.
1684 In order to set an alternate colour for negative numeric values, the
1685 number is now sent to client and formatted with the GWT NumberFormat class.
1687 This change also fixes:
1689 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1691 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1692 internationalization framework which is needed for client side numeric
1694 * src/main/java/org/glom/web/client/Utils.java: New file for some
1695 client static utility methods.
1696 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1697 the DataItem object to the Field class. Use a utility method to
1698 create the foreignKeyValue string.
1699 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1700 alignment and text colours in the constructor. Add setData(DataItem)
1701 method. Remove setText(String) method.
1702 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1703 colour information to GlomTextCell. Create and use GlomNumberCell for
1704 rendering numbers. Use utility method to get the string for the
1705 primary key of the key provider. Re-work how the horizontal alignment
1707 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1708 formatting to layout information. Methods for converting the libglom
1709 formatting information were moved from DBAccess.
1710 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1711 numeric formatting (it's now done on the client side). Don't set text
1712 colours in DataItem. Move libglom formatting conversion methods to
1714 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1715 getters/setters for text colour information.
1716 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1717 for transferring the libglom NumericFormat information to the client.
1718 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1719 and getters/setters for: GlomNumericFormat, background colour and
1720 foreground colour strings.
1722 2011-09-26 Ben Konrath <ben@bagu.org>
1724 Simplify code that iterates through the LayoutGroup.
1726 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1728 2011-09-26 Ben Konrath <ben@bagu.org>
1730 Accept Eclipse formatting for OnlineGlomServiceAsync.
1732 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1734 2011-09-26 Ben Konrath <ben@bagu.org>
1736 Don't use the ListDBAccess classes to get the primary key layout information.
1738 This was causing a bug where the wrong index for the hidden primary key
1739 was being sent to the client.
1741 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1742 primary key while creating the LayoutGroup DTO. Create a
1743 LayoutItemField DTO for hidden primary keys. Don't use the
1744 RelatedListDBAccess because it was only used for getting the primary
1746 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1747 access modifier from public to protected for getPrimaryKeyField() and
1748 getPrimaryKeyLayoutItemField().
1749 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1750 abstract method getExpectedResultSize() because RelatedListDBAccess
1751 doesn't have enough info to implement it.
1752 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1753 Remove @Override for getExpectedResultSize().
1754 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1755 Remove method getExpectedResultSize().
1757 2011-09-23 Ben Konrath <ben@bagu.org>
1759 Log which layout (list or details) the ignored item is from.
1761 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1763 2011-09-23 Ben Konrath <ben@bagu.org>
1765 Remove annotations that turn off code formatting in DataItem.
1767 * src/main/java/org/glom/web/shared/DataItem.java:
1769 2011-09-23 Ben Konrath <ben@bagu.org>
1771 Rename GlomField to DataItem and update associated methods.
1773 This is a rename-only refactor. No functionality has been added or
1776 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1777 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1778 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1779 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1780 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1781 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1782 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1783 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1785 * src/main/java/org/glom/web/server/database/DBAccess.java:
1786 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1787 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1788 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1789 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1790 * src/main/java/org/glom/web/shared/DataItem.java:
1791 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1792 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1794 2011-09-23 Ben Konrath <ben@bagu.org>
1796 Rename GlomDocument to DocumentInfo and update associated methods.
1798 This is a rename-only refactor. No functionality has been added or
1801 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1802 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1803 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1804 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1805 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1807 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1809 2011-09-20 Ben Konrath <ben@bagu.org>
1811 Require java-libglom 1.17.3.
1813 This picks up the fix for the seg fault problem with the Scenes table
1814 in the Openismus Film Manager example.
1818 2011-09-20 Ben Konrath <ben@bagu.org>
1820 Change the way sort clause is added for primary key when no sort clause is requested.
1822 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1823 before the sort clause is created. When a sort clause is not requested, the
1824 sort clause is created by finding the primary key in the LayoutFieldVector
1827 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1829 2011-09-20 Ben Konrath <ben@bagu.org>
1831 Log error message if no documents are found in the configured directory.
1833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1834 Extract the glom file extension string to a private static final class
1835 variable (mostly as syntactic sugar). Accept a minor formatting change.
1836 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1837 the example glom.document.directory configuration property to make it
1838 more clear that it can any directory, not just the home directory.
1840 2011-09-18 Ben Konrath <ben@bagu.org>
1842 Add related lists to details view.
1844 The related list table has support for paging and sorting just like the
1845 table in the list view.
1847 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1848 SQL queries for the related list tables.
1849 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1850 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1852 Rename getList methods to getListView and add comments. Remove
1853 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1854 it being unused. Add methods: getDetailsLayoutAndData(),
1855 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1856 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1857 Create the layout and set the data for the fields in one async call
1858 instead of two. Create related lists where appropriate.
1859 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1860 for method name changes in OnlineGlomService.
1861 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1862 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1863 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1865 * src/main/java/org/glom/web/client/ui/ListView.java:
1866 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1867 tableName from setCellTable(). Create a ListViewTable instead of
1869 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1870 represent a data field in the details view.
1871 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1872 from addDetailsCell() to Field class. Keep track of the Fields and
1873 Portals in the details view.
1874 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1875 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1876 and add a method to get it. Add method to set the contents of the
1878 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1879 New class for related list tables. This class has the data provider
1880 for the related list table.
1881 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1882 abstract class which is the base class for the ListViewTable and the
1884 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1885 New class for list view tables. This class has the data provider for
1886 the list view table.
1887 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1888 methods for related list tables. Add more information to the
1889 LayoutItemField and LayoutItemPortal DTOs.
1890 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1891 Remove debugging print statement.
1892 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1893 Remove debugging print statements. Add primary key field to SQL count
1895 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1896 Remove unnecessary LayoutFieldVector parameter from
1897 getResultSizeOfSQLQuery() method.
1898 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1899 New class for related list table database access.
1900 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1901 class that is a wrapper DTO for details view layout and data.
1902 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1903 new 'fromField' string to this DTO.
1904 * src/main/webapp/style.css: Remove bottom margin and override top
1907 2011-09-15 Ben Konrath <ben@bagu.org>
1909 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1911 This sets things up to make it easier to add the data retrieval for
1912 related lists (portals). No user noticeable changes were made with
1915 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1916 class has the code to retrieve the layouts and access the
1917 database using the new database helper classes.
1918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1919 Most of the functionality has been removed from this class. This
1920 class now represents the public interface for the client side
1921 code. It also deals with configuring the servlet and cleaning
1922 things up when the servlet is stopped.
1923 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1924 of static methods into this utility class.
1925 * src/main/java/org/glom/web/server/database/DBAccess.java:
1926 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1927 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1928 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1929 These classes have the database retrieval code. The class hierarchy
1930 has been setup to make it easy to reuse code for similar
1933 2011-09-06 Ben Konrath <ben@bagu.org>
1935 Create separate classes for list table code and the data provider.
1937 As part of this refactor, I also split up the code a bit to make it
1940 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1941 table code to two new classes (below).
1942 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1943 with code from ListViewImpl.
1944 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1945 New file with code from ListViewImpl.
1947 2011-09-06 Ben Konrath <ben@bagu.org>
1949 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1951 This fixes the LayoutItemPortal DTO to match the libglom layout object
1954 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1956 2011-09-01 Ben Konrath <ben@bagu.org>
1958 Set title of Portals in the Details View.
1960 * pom.xml: Bump required version of java-libglom to 1.17.1.
1961 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1962 widget creation to its own class. Add comments to constructor.
1963 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1964 The code is mostly from the Group class with the title now set.
1965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1966 title of Portal. Update some comments. Fix some code formatting.
1968 2011-09-01 Ben Konrath <ben@bagu.org>
1970 Remove TODO comment for the flow table column width.
1972 The flow table column width is working correctly and doesn't need to be
1973 changed. See this mailing list post for more info:
1975 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1977 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1979 2011-08-27 Ben Konrath <ben@bagu.org>
1981 Add document title (database name) to top of the browser page.
1983 I added the document title to the TableSelecitonView but that will
1984 change if / when we add a view that doesn't require table selection.
1986 * mockups/details-contacts.html:
1987 * mockups/details-projects.html:
1988 * mockups/listview-contacts.html:
1989 * mockups/listview-projects.html:
1990 * mockups/style.css: Add document title to mockups to keep things
1992 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1993 sizes to account for the document title.
1994 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1995 Set the document title when it has been retrieved from the server.
1996 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1997 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1998 and implement setDocumentTitle(String) method.
1999 * src/main/webapp/style.css: Add ID for document title style.
2001 2011-08-25 Ben Konrath <ben@bagu.org>
2003 Add NavigationType enum to LayoutItemPortal DTO.
2005 This is the start of adding support for Portals to the Details View.
2007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2008 LayoutItem_Portal.navigation_type enum from libglom to
2009 LayoutItemPortal.NavigationType enum.
2010 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2011 NavigationType enum, field for storing the NavigationType and getter
2014 2011-08-25 Ben Konrath <ben@bagu.org>
2016 Implement the flow table layout in the Details View.
2018 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2019 FlowTable to Group to account for the renamed class.
2020 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2021 File. This is a container widget that implements the Glom details view
2022 flow table behaviour.
2023 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2024 org/glom/web/client/ui/FlowTable.java.
2025 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2026 so that the size of the subgroups are a closer match to the size of
2027 the Glom subgroups. This makes the flowtable layout match the layout
2028 in Glom for the Music Collection example file.
2030 2011-08-16 Ben Konrath <ben@bagu.org>
2032 Create container element for LayoutItemPortal in Details View.
2034 This will help me develop the layout for the FlowTable.
2036 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2037 fieldPanel variable to detailsCell.
2039 2011-08-15 Ben Konrath <ben@bagu.org>
2041 Set the height of the data element in the Details View.
2043 I changed the InlineLabels (text in a span element) to Labels (text in
2044 a div element) so that I could set the height of the details-data
2045 elements instead of the details-cell parent elements. This allows the
2046 the details-data element to display the correct height if style is
2047 applied that shows the height.
2049 This change has the added benefit of allowing the order of the labels
2050 and data elements to be changed for right-to-left languages.
2052 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2053 InlineLabels to Labels.
2054 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2055 InlineLabels to Labels. Set the height of the data element.
2056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2057 multiline text height in the Formatting DTO.
2058 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2059 for multiline height along with getter and setter methods.
2060 * src/main/webapp/style.css: Adjust style to account for the change
2061 from span elements to div elements in the details cell.
2063 2011-08-15 Ben Konrath <ben@bagu.org>
2065 Make the List View appearance match the mockups.
2067 It doesn't match exactly but it's much better than it was.
2069 * mockups/listview-contacts.html: Remove unused css classes.
2070 * mockups/listview-projects.html: Remove unused css classes.
2071 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2072 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2073 for mainPanel instead of VerticalPanel (table). Set style name on
2074 CellTable. Set style name on Details column. Right-align Details
2076 * src/main/webapp/style.css: Adjust properties to match the mockups.
2078 2011-08-12 Ben Konrath <ben@bagu.org>
2080 Add better support for subgroups in the details view.
2082 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2083 changed FlowTable constructor.
2084 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2085 support for subgroups and subgroup-titles.
2086 * src/main/webapp/style.css: Add CSS class for subgroups and
2089 2011-08-12 Ben Konrath <ben@bagu.org>
2091 Return the top level LayoutGroup title.
2093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2095 2011-08-11 Ben Konrath <ben@bagu.org>
2097 Make the TableSelector header match the mockup.
2099 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2100 the layout panel. Properly lineup the table selection header with
2101 the list and details view.
2102 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2103 margin around the details view.
2104 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2105 Rename listBox variable to tableSelector. Set id for the style sheet.
2106 Use a FlowPanel instead of a HorizontalPanel.
2107 * src/main/webapp/style.css: Add properties to make the TableSelector
2108 box match the mockups.
2110 2011-07-13 Ben Konrath <ben@bagu.org>
2112 Update install script for java-libglom version change.
2114 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2117 2011-07-13 Ben Konrath <ben@bagu.org>
2119 Add support sub-group in the details view.
2121 I also removed the code that special-cased the default details view
2124 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2126 I still have to make a proper flowtable.
2128 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2129 Don't special-case default details view layout.
2130 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2131 addLayoutField() as I'm going to use it.
2132 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2133 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2135 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2136 extracted from DetailsViewImpl.GroupPanel. Add support for
2138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2139 column count when getting the details layout.
2141 2011-07-12 Ben Konrath <ben@bagu.org>
2143 Set browser title with database and table titles.
2145 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2146 Set the browser title when the table changes and when the activity
2148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2149 title when retrieving document info (the GlomDocument object).
2150 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2151 with getter and setter methods. Remove unused convenience constructor.
2152 Use default code formatting.
2154 2011-07-12 Ben Konrath <ben@bagu.org>
2156 Ignore LayoutItemPortals in the details view.
2158 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2161 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2162 LayoutItemPortal layout objects.
2163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2164 LayoutItemPortal objects when retrieving the details layout.
2165 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2166 file. This is an empty class and just used to get type information for
2169 2011-07-12 Ben Konrath <ben@bagu.org>
2171 Use java-libglom 1.17.0.
2175 2011-07-11 Ben Konrath <ben@bagu.org>
2177 Remove "Table:" label from table selector.
2179 This matches a recent change in the Glom UI.
2181 * mockups/details-contacts.html:
2182 * mockups/details-projects.html:
2183 * mockups/listview-contacts.html:
2184 * mockups/listview-projects.html: Remove the "Table:" label from the
2186 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2188 2011-07-11 Ben Konrath <ben@bagu.org>
2190 Add main groups to the details view.
2192 This makes things look a little nicer in the details view. The next step
2193 is to implement the flowtable.
2195 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2196 resources from the standard gwt css theme. Standard.css is now
2197 included in OnlineGlom.html so that the online glom css rules have
2198 precedence over the gwt theme.
2199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2200 the whole LayoutGroup to the DetailsView instead of just the titles.
2201 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2202 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2203 details layout with a helper class (GroupPanel). I might extract this
2204 class when I make the full flowtable.
2205 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2206 string as default so I don't have to worry about NPEs when processing
2208 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2209 note beside OnlineGlom.gwt.xml above).
2210 * src/main/webapp/style.css: Add default font-size to body to override
2211 the font-size set by the standard theme. Don't use h2 tags for
2212 group-title. Create new details-cell class.
2214 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2216 ConfiguredDocument: Set the port number too.
2218 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2219 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2220 Glom document. Presumably this worked sometimes so far because there is a
2221 default port number.
2223 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2225 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2227 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2228 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2229 correct, though we should throw an exception too.
2231 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2233 Fix a addDocuemnt typo.
2235 * src/main/java/org/glom/web/shared/Documents.java
2236 (Documents.addDocuemnt): Rename to addDocument().
2237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2238 (OnlineGlomServiceImpl.getDocuments): Adapt.
2240 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2242 Slightly improved log output when connection fails.
2244 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2245 (ConfiguredDocument.setUsernameAndPassword):
2246 We don't know for sure if it' the username/password that's wrong, so
2247 rephrase the message.
2248 Also ouput the exception message, though it's generic in this case.
2250 2011-07-08 Ben Konrath <ben@bagu.org>
2254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2255 added braces to a one line if statement because the Eclipse formatter
2256 was getting confused.
2258 2011-07-07 Ben Konrath <ben@bagu.org>
2260 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2262 These should really be two separate tasks but I counldn't get things to
2263 work with GWT 2.2.0 and Eclipse 3.7.
2267 * .settings/org.eclipse.jdt.core.prefs:
2268 * .settings/org.eclipse.jdt.ui.prefs:
2269 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2270 * .settings/org.eclipse.m2e.core.prefs:
2271 Add new config files. Update current files. Remove references to the
2272 webtools plugins as we're not using any of the webtools features.
2273 * .gitignore: Add logs directory which is created when running with
2275 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2276 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2277 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2279 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2281 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2283 onlineglom.properties: Add explanatory comments.
2285 * src/main/resources/onlineglom.properties: Also change the default user
2286 from ben to someuser, to avoid the risk of people thinking we just
2287 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2289 2011-06-28 Ben Konrath <ben@bagu.org>
2291 Use filename in Log for incorrect passwords.
2293 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2294 getFileName(String) method to get the filename from the URI.
2296 2011-06-28 Ben Konrath <ben@bagu.org>
2298 Add the table name to the URL token for the ListPlace.
2300 This makes things consistent between the DetailsPlace and the
2301 ListPlace. It also allows the the ListPlace to be bookmarked.
2303 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2304 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2305 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2306 Remove getDefaultListLayout(). The default layout is now returned
2307 by the getListLayout() method when the table name is an empty string.
2308 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2309 Add table name field. Change to a new ListPlace when the table
2310 has been changed. Use getListLayout() for getting the default
2312 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2313 Add table name field. Set the correct table name in the list box
2314 when loading from bookmark. This corrects a problem for the
2316 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2317 Move table name to super-class (HasSelectableTable). Move document
2318 and table URL keys to super-class in HasSelectableTable.
2319 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2320 Add table name field. Add Tokenizer class with URL key common to
2321 the subclasses (DetailsPlace and ListPlace).
2322 * src/main/java/org/glom/web/client/place/ListPlace.java:
2323 Add table name. Add code to parse the URL token.
2324 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2325 Update ListPlace construction with empty table name string.
2326 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2327 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2328 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2329 Update ListPlace construction with table name string.
2330 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2331 Change defaultTableName field to tableName to reflect how it's now
2332 used. Update the getter and setter methods.
2334 2011-06-28 Ben Konrath <ben@bagu.org>
2336 Enable the table selector in the DetailsView.
2338 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2339 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2341 Remove getDefaultDetailsLayout(). The default layout is now returned
2342 by the getDetailsLayout() method when the table name is an empty
2344 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2345 event handler for table change event. Change to using
2346 getDetailsLayout() for the default details layout.
2347 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2349 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2350 when navigating to the details place.
2352 2011-06-27 Ben Konrath <ben@bagu.org>
2354 Use filename based unique document ID in URL and for RPC.
2356 The document ID is the glom document name with spaces (' ') replaced
2357 with pluses ('+') and without the .glom extension.
2359 This change is mostly a string substitution of 'documentTitle' for
2360 'documentID'. The only code change is the addition of a Documents DTO to get the
2361 filename to document title mappings as indicated below.
2363 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2364 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2365 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2366 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2367 Use Documents DTO to create the document links in the document
2369 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2370 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2371 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2372 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2373 * src/main/java/org/glom/web/client/place/ListPlace.java:
2374 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2375 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2376 * src/main/java/org/glom/web/client/ui/ListView.java:
2377 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2378 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2379 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2380 * src/main/java/org/glom/web/server/Log.java:
2381 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2382 getDocumentTitles() to getDocuments() and return the Documents DTO.
2383 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2384 transferring the filename to document title mappings.
2386 2011-06-25 Ben Konrath <ben@bagu.org>
2388 Make the authentication popup work again.
2390 This bug was introduced when I extracted ConfiguredDocument to its own class.
2392 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2393 correct success / fail status in setUsernameAndPassword().
2395 2011-06-25 Ben Konrath <ben@bagu.org>
2397 Use filename as unique key for configuring database usernames and passwords.
2399 This replaces the use of the Glom document title which could change
2400 depending on the locale. Thanks to Murray Cumming for pointing out this
2403 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2404 * src/main/resources/onlineglom.properties:
2406 2011-06-24 Ben Konrath <ben@bagu.org>
2408 Pass primary key value to DetailsView.
2410 This enables the DetailsView to load the correct data.
2412 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2413 primary key value field and set in constructor. Pass primary key
2414 value to getDetailsData().
2415 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2416 variables for document title and primary key value.
2417 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2418 key value to the DetailsPlace.
2420 2011-06-24 Ben Konrath <ben@bagu.org>
2422 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2424 This allows the primary key to be retrieved by the Details button. This
2425 functionality has not been implemented yet but it's in the works.
2427 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2428 the LayoutGroup result to ListView.setCellTable instead of all of its
2429 fields individually.
2430 * src/main/java/org/glom/web/client/ui/ListView.java:
2431 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2432 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2433 get the primary key for the table.
2434 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2435 index of the primary key in the LayoutGroup accounting for hidden
2436 primary keys. Rename getJavaNumberFormat() to
2437 convertToJavaNumberFormat() for consistency. Cleanup / add some
2439 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2440 field for primary key index and a field to indicate whether the
2441 primary key is hidden or not.
2443 2011-06-23 Ben Konrath <ben@bagu.org>
2445 Rename getTableData methods to getListData.
2447 This is a rename refactor for consistency with other methods.
2449 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2450 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2451 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2454 2011-06-23 Ben Konrath <ben@bagu.org>
2456 Extract the ConfiguredDocument innerclass into its own class.
2458 This makes the servlet code more object oriented.
2460 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2461 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2462 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2463 new ConfiguredDocument class.
2465 2011-06-21 Ben Konrath <ben@bagu.org>
2467 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2469 This makes things more inline with how libglom works and reduces code
2470 duplication. This refactor lays the groundwork for adding the primary key to
2471 the LayoutGroup object.
2473 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2474 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2475 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2476 Change method names to getListLayout and getDefaultListLayout for
2477 consistency. Use LayoutGroup as the DTO for the list layout instead of
2478 ColumnInfo and LayoutListTable.
2479 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2480 new method names along with the LayoutGroup object for transferring the
2482 * src/main/java/org/glom/web/client/ui/ListView.java:
2483 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2484 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2485 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2487 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2488 Replaced with LayoutGroup.
2489 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2490 expectedResultSize and defaultTableName fields which are needed for
2492 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2493 type field which is needed for the list layout but will also be
2494 useful for the details layout as things progress.
2495 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2496 Make class abstract. Remove the unnecessary
2497 getFormattingHorizontalAlignment method. Add setFormatting method.
2499 2011-06-16 Ben Konrath <ben@bagu.org>
2501 Add scripts for building and installing war.
2503 These will help when updating OnlineGlom but they're also good
2504 supplemental documentation of the build and deployment proceeding.
2506 * utils/build-onlineglom-war.sh: New file.
2507 * utils/install-onlineglom-war.sh: New file.
2509 2011-06-16 Ben Konrath <ben@bagu.org>
2511 Create wrapper class to create consistent log messages.
2513 I wrapped methods in the Log class of gwt-log to add the method names
2514 from the servlet and create consistent formatting of the document title
2515 and table names in the log messages.
2517 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2518 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2519 log methods to use methods from wrapped Log class.
2521 2011-06-16 Ben Konrath <ben@bagu.org>
2523 Remove superfluous conditional return.
2525 Thanks to Murray Cumming for pointing this out!
2527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2529 2011-06-15 Ben Konrath <ben@bagu.org>
2531 Return an ArrayList of LayoutGroups for the Details layout.
2533 This corrects a problem with the details layout as it can have more
2534 than one top level LayoutGroup.
2536 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2537 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2538 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2539 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2540 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2541 with ArrayList of LayoutGroups for the details view layout.
2542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2543 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2544 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2545 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2546 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2547 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2549 2011-06-14 Ben Konrath <ben@bagu.org>
2551 Use cast_dynamic method to determine the libglom LayoutItem type.
2553 This is better than finding the LayoutItem type by using the string
2554 returned from the get_part_type_name() method.
2556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2558 2011-06-14 Ben Konrath <ben@bagu.org>
2560 Add method names to log entries in the servlet.
2562 This helps when tracking down deployment problems.
2564 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2566 2011-06-14 Ben Konrath <ben@bagu.org>
2568 Add data to the DetailsView using a hard-coded primary key value.
2570 The layout and functionality of the DetailsView is not complete. This
2571 is just a checkpoint so the patch doesn't get too big.
2573 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2574 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2575 Add getDetailsData() servlet method.
2576 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2577 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2578 LayoutFields are added to the DetailsView.
2579 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2580 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2581 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2582 take the string for the title instead of the object.
2583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2584 Add implementation getDetailsData() along with some private helper
2586 * src/main/webapp/style.css: Add padding to details-data class. Add a
2587 details-label class with the same padding as the details-data class.
2589 2011-06-03 Ben Konrath <ben@bagu.org>
2591 Use presenter.goTo() to change to the DetailsPlace.
2593 This will make things easier when we need to open the DetailsView with
2594 data specific to the row that was clicked.
2596 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2598 2011-06-02 Ben Konrath <ben@bagu.org>
2600 Add CSS file from mockups.
2602 I'm adding this now because it's going to be useful to have when
2603 developing the DetailsView. The TableSelectionView and ListView aren't
2606 * src/main/webapp/OnlineGlom.html:
2607 * src/main/webapp/style.css:
2609 2011-06-02 Ben Konrath <ben@bagu.org>
2611 Use String.isEmpty() to check for empty string.
2613 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2615 2011-06-02 Ben Konrath <ben@bagu.org>
2617 Display main layout group titles in the DetailsView.
2619 This is the start of the DetailsActivity/DetailsView implementation.
2621 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2622 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2623 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2624 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2625 Get the layout information for the details view from the server and set
2626 the main layout group titles.
2627 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2628 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2629 Add addLayoutGroup() and addLayoutField() methods. This are just
2630 temporary methods for creating the the details view that will change
2632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2633 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2635 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2636 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2637 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2638 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2639 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2640 Data Transfer Objects that mimic the libglom object structure. These are
2641 used for transferring the details layout but could also be used for
2642 transferring the list layout.
2644 2011-05-27 Ben Konrath <ben@bagu.org>
2646 Reset the AuthenticationPopup when clearing the ListView.
2648 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2650 2011-05-27 Ben Konrath <ben@bagu.org>
2652 Fix problem with onlineglom.properties file loading.
2654 The old way worked in Eclipse but not on the server. Loading the
2655 onlineglom.properties file now works in Eclipse and on the server.
2657 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2659 2011-05-24 Ben Konrath <ben@bagu.org>
2661 Update gwt-log from 3.1.0 to 3.1.2.
2663 Gwt-log 3.1.0 has been marked as depreciated.
2667 2011-05-24 Ben Konrath <ben@bagu.org>
2669 Add comment to ListActivity.goTo() method.
2671 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2673 2011-05-24 Ben Konrath <ben@bagu.org>
2675 Remove FIXME in convertGdkColorToHtmlColour()
2677 The Gdk::Color value returned by libglom is 16-bits per channel on both
2678 64 and 32-bit platforms.
2680 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2682 2011-05-19 Ben Konrath <ben@bagu.org>
2684 Improve performance of initial ListView load.
2686 I removed a round trip to the server for getting the default table name
2687 and then requesting information about that table. This also removes a potential
2688 problem with the table change handler not being setup in time to receive the
2689 table change event from the ListActivity.
2691 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2692 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2693 getDefaultLayoutListTable() method. Improve comments.
2694 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2695 getDefaultLayoutListTable() method instead of firing a table change
2696 event to get the table to load.
2697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2698 implementation of getDefaultLayoutListTable() method.
2699 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2702 2011-05-19 Ben Konrath <ben@bagu.org>
2704 Override toDebugString() in TableChangeEvent.
2706 This is useful to have for debugging.
2708 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2710 2011-05-19 Ben Konrath <ben@bagu.org>
2712 Add a "Back to List" link when at the DetailsPlace.
2714 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2715 Populate the CellTable based on the selected table of the ListBox if
2716 it's set otherwise use the default table. This allows the "Back to
2718 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2719 Remove Place from constructors. Add a setPlace() method. Add
2720 goToPlace() method. Set class as presenter for TableSelectionView.
2721 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2722 Use the same TableSelectionActivity when switching between the List and
2724 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2725 Subclass the new HasSelectableTablePlace. This removes some duplicate
2727 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2728 New class to represent Places that display the TableSelectionView.
2729 * src/main/java/org/glom/web/client/place/ListPlace.java:
2730 Subclass the new HasSelectableTablePlace. This removes some duplicate
2732 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2733 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2734 Add Presenter interface. Add setBackLinkVisible() method. Add
2735 setBackLink() method.
2737 2011-05-18 Ben Konrath <ben@bagu.org>
2739 Enable the "Details" buttons.
2741 Right now only an empty details view is displayed.
2743 * src/main/java/org/glom/web/client/ClientFactory.java:
2744 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2745 Add DetailsView to ClientFactory.
2746 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2747 A basic activity for the details view.
2748 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2749 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2751 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2752 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2754 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2755 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2756 unnecessary super() in constructor.
2757 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2758 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2759 really shouldn't create a new TableSelectionActivity for both the ListPlace
2760 and the DetailsPlace so this should be considered a temporary solution.
2761 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2762 New file. Represents a URL for the details view.
2763 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2764 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2765 A basic details view interface and implementation.
2766 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2767 Enable the "Details" buttons.
2769 2011-05-12 Ben Konrath <ben@bagu.org>
2771 Use a LayoutPanel with multiple display areas for main layout.
2773 This is mostly a refactor in that there are no changes from the user
2774 point of view. These changes are required so that we can swap out the list view
2775 with the details view when the user clicks the "Details" button.
2777 * src/main/java/org/glom/web/client/ClientFactory.java:
2778 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2779 OnlineGlomView. Add TableSelectionView, ListView and
2780 AuthenticationPopup.
2781 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2782 for main layout. Add display regions for main activities. Add
2783 activity manager for for main activities.
2784 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2785 file from parts of the deleted OnlineGlomActivity.
2786 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2787 New file from parts of the deleted OnlineGlomActivity.
2788 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2789 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2790 New files for app wide table change event.
2791 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2792 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2793 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2794 Activity mappers for the main activities replace the deleted app-wide
2796 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2797 Fix a spelling error in he comment.
2798 * src/main/java/org/glom/web/client/ui/ListView.java:
2799 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2800 Renamed from LayoutListView and modified for MVP. This still not a
2801 proper dumb view as prescribed by the MVP pattern but it works for now.
2802 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2803 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2804 New widget stripped out of the deleted OnlineGlomView.
2805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2806 Remove hack that is fixed by this patch.
2808 2011-05-06 Ben Konrath <ben@bagu.org>
2810 Rename OnlineGlomPlace to ListPlace.
2812 The only change besides the rename is that url will now display #list
2813 instead of #Document.
2815 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2816 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2817 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2818 * src/main/java/org/glom/web/client/place/ListPlace.java:
2819 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2821 2011-05-06 Ben Konrath <ben@bagu.org>
2823 Use Presenter for app navigation.
2825 This is the proper way to deal with Place (URL) changes with the MVP
2828 * src/main/java/org/glom/web/client/ClientFactory.java:
2829 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2830 PlaceHistoryMapper and PlaceHistoryHandler.
2831 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2832 PlaceHistoryMapper and PlaceHistoryHandler.
2833 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2834 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2835 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2836 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2837 Add Presenter interface and setPresenter methods. Rename addHyperLink
2838 to addDocumentLink taking only the document title as a parameter.
2840 2011-04-14 Ben Konrath <ben@bagu.org>
2842 Prompt for db username/password if they haven't been set.
2844 This is implemented with a popup widget that is contained within the
2845 OnlineGlomView and managed by the OnlineGlomActivity.
2847 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2848 methods for checking and setting the database username and password.
2849 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2850 new methods for checking and setting the database username and
2852 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2853 Display authentication popup if the JDBC connection to the database
2854 has not been authenticated.
2855 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2857 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2858 for dealing with the authentication popup.
2859 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2860 Implement the methods for dealing with the authentication popup.
2861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2862 try to executed queries if the database connection hasn't been
2863 authenticated. Implement methods for checking and setting the
2864 database username and password.
2866 2011-04-12 Ben Konrath <ben@bagu.org>
2868 Make log messages a little clearer.
2870 Add a dash betweeen the document title and the table name.
2872 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2874 2011-04-12 Ben Konrath <ben@bagu.org>
2876 Protect against NPEs when cleaning up database resources.
2878 While this isn't strictly necessary because the exception is caught,
2879 not protecting against the NPEs makes it harder to find the real error
2882 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2884 2011-04-12 Ben Konrath <ben@bagu.org>
2886 Move configuration of the servlet to the constructor.
2888 The servlet will be initialized even if the database authentication
2889 information is not set or correct. I still need to add the UI for prompting
2890 the user for the authentication information when it's required.
2892 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2893 javadocs for getDocumentTitles() method.
2894 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2895 Set error message when RPC fails.
2896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2897 glom files directory from the configuration file. Try to set the
2898 database authentication information for the specific document if it's
2899 set and works otherwise try to use the global authentication
2900 information set for the directory.
2901 * src/main/resources/onlineglom.properties: Moved from
2902 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2903 Added detailed comments for the new keys.
2905 2011-04-11 Ben Konrath <ben@bagu.org>
2907 Remove unnecessary @Override in DocumentSelectionViewImpl.
2909 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2911 2011-04-11 Ben Konrath <ben@bagu.org>
2913 Remove center alignment in DocumentSelectionView.
2915 The title element is still centred but the document titles and bottom
2916 sentence are both left-aligned.
2918 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2920 2011-04-11 Ben Konrath <ben@bagu.org>
2922 Change 'Demo' naming convention to 'Document'.
2924 This is just a rename refactor with no functional changes to the code.
2926 * src/main/java/org/glom/web/client/ClientFactory.java:
2927 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2928 * src/main/java/org/glom/web/client/OnlineGlom.java:
2929 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2930 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2931 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2932 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2933 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2934 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2935 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2936 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2937 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2940 2011-04-08 Ben Konrath <ben@bagu.org>
2942 Remove FIXME from safeLongToInt() method.
2944 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2947 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2949 2011-04-08 Ben Konrath <ben@bagu.org>
2951 Display an error if no glom documents are found in the specified directory.
2953 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2954 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2955 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2958 2011-04-08 Ben Konrath <ben@bagu.org>
2960 Add copyright header to one more file ... oops.
2962 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2964 2011-04-08 Ben Konrath <ben@bagu.org>
2966 Add copyright header to files without it.
2968 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2969 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2970 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2971 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2972 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2973 * src/main/java/org/glom/web/shared/GlomField.java:
2975 2011-04-08 Ben Konrath <ben@bagu.org>
2977 Add support for accessing multiple glom documents in the servlet.
2979 This completes the demo selection functionality.
2981 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2982 document title to methods.
2983 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2984 document title to methods.
2985 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2986 Set browser window title when the activity starts. Correct name of
2987 document title variable.
2988 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2989 Set browser window title when the activity starts. Set the table
2990 selector change handler after table selector has been set. Clear the
2991 OnlineGlomView when the activity has been stopped.
2992 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2993 document title as the place token. Use "#Document:" instead of
2994 "#OnlineGlomPlace:" in the URL.
2995 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2996 Change heading to "Online Glom"
2997 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2998 document title in RPC methods.
2999 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3000 setDocumentTitle() method. Add clear() method.
3001 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3002 setDocumentTitle() method. Implement clear() method which removes the
3003 change handler on the ListBox, clears the ListBox and clears the
3005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3006 Implement methods with document title. Keep track for the configured
3007 glom documents and their corresponding JDBC configurations in a hash
3008 table. This information is retrieved using the document title as the
3009 key in the hash table.
3010 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3011 document title field as it's no longer needed.
3013 2011-04-08 Ben Konrath <ben@bagu.org>
3015 Update the Eclipse JDT configuration.
3017 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3018 methods. Automatically add the copyright header to new files.
3020 2011-04-05 Ben Konrath <ben@bagu.org>
3022 Add new page for demo selection.
3024 This patch adds all the components required to view and start an
3025 OnlineGlom demo by clicking on the desired hyperlink. The user is
3026 able to return to the demo selection page with the browser's back
3027 button. I still need to modify the servlet to work with multiple
3028 documents so all demo links will load the file defined in the
3029 OnlineGlom.properties.
3031 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3032 This is only useful during development so we don't need to save it.
3033 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3034 get a reference to the DemoSelectionView.
3035 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3036 method to get a reference to the DemoSelectionView.
3037 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3038 default view to DemoSelectionView.
3039 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3040 to get glom document titles for glom files in a hard-coded directory.
3041 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3042 method to get glom document titles for glom files in a hard-coded
3044 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3045 Presenter for DemoSelectionView.
3046 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3047 for DemoSelectionView.
3048 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3049 Update for DemoSelectionView.
3050 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3051 Basic 'Place' implementation for the DemoSelectionView.
3052 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3053 The interface for the DemoSelectionView.
3054 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3055 The implementation of the DemoSelectionView.
3056 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3057 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3059 implementation of method to get glom document titles for glom files
3060 in a hard-coded directory.
3061 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3062 on longer being used.
3063 * src/main/webapp/glom.png: Glom logo.
3065 2011-04-05 Ben Konrath <ben@bagu.org>
3067 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3069 This is the forth and final commit of a refactor that will allow
3070 OnlineGlom to be used with multiple documents.
3072 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3073 Move RPC code from OnlineGlomViewImpl to this class.
3074 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3076 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3077 RPC code to the presenter class (the P in MVP).
3079 2011-04-04 Ben Konrath <ben@bagu.org>
3081 Start moving the existing OnlineGlom code to MVP.
3083 This work is based on the GWT MVP framework that is documented here:
3085 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3087 This is the third commit of a refactor that will allow OnlineGlom to
3088 be used with multiple documents.
3090 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3091 Interface for client factory which is used to get instances of various
3092 classes throughout the app.
3093 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3094 Implementation of client factory.
3095 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3096 initialize the MVP framework.
3097 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3098 New file. Activity manager for the main container widget. This is the
3100 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3101 Maps place (URL) to its corresponding activity.
3102 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3103 New file. This is just a place holder for a generated file.
3104 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3105 New file. Represents the URL for the main Online Glom app.
3106 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3107 for changes in LayoutListViewImpl.
3108 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3109 interface for View. Move code to OnlineGlomViewImpl class.
3110 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3111 file. Implementation of OnlineGlomView.
3112 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3113 Place resources. Use ClientFactoryImpl by default.
3115 2011-04-04 Ben Konrath <ben@bagu.org>
3117 Move View classes to their own package.
3119 This is the second commit of a refactor that will allow OnlineGlom to
3120 be used with multiple documents.
3122 * src/main/java/org/glom/web/client/OnlineGlom.java:
3123 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3124 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3126 2011-04-02 Ben Konrath <ben@bagu.org>
3128 Move UI code from the main module to its own class.
3130 This is the first commit of a refactor that will allow OnlineGlom to be
3131 used with multiple documents.
3133 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3134 references to OnlineGlom to OnlineGlomView.
3135 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3136 OnlineGlomView and instantiate it here.
3137 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3138 represents the main OnlineGlomView with one document.
3140 2011-04-01 Ben Konrath <ben@bagu.org>
3142 Fix formatting of gwt.xml and add DTD.
3144 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3146 2011-03-30 Ben Konrath <ben@bagu.org>
3148 Propperly convert gdkColor string to html colour string.
3150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3152 2011-03-28 Ben Konrath <ben@bagu.org>
3154 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
3156 This implementation matches
3157 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
3158 readable and is not tied to Swig.
3160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3162 2011-03-28 Ben Konrath <ben@bagu.org>
3164 Use read-only checkboxes for boolean field types.
3166 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
3167 in the CellTable based on the field type. It currently only
3168 distinguishes between boolean and text columns but I'll need to add
3169 support for more types.
3170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3171 column type in the ColumnInfo object. Add method to convert between the
3172 glom field type enum in ColumnInfo and the glom field type in libglom.
3173 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
3175 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
3176 getting and setting booleans.
3178 2011-03-25 Ben Konrath <ben@bagu.org>
3180 Don't get the Date twice from the ResultSet.
3182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3184 2011-03-25 Ben Konrath <ben@bagu.org>
3186 Cleanup code in the servlet.
3188 * TODO: Remove item about row count. Add item about testing row count
3189 query with large number of rows.
3190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
3191 spelling mistakes, change method parameter to be consistent with
3194 2011-03-25 Ben Konrath <ben@bagu.org>
3196 Add server side logging with the gwt-log library.
3198 * .gitignore: Ignore the log file we're now producing.
3199 * TODO: Add a couple TODO item for logging.
3200 * pom.xml: Add gwt-log and log4j as a dependency.
3201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3202 logging of errors, warnings and some important info.
3203 * src/main/resources/log4j.properties: New file to configure log4j.
3205 2011-03-24 Ben Konrath <ben@bagu.org>
3207 Add a disable button for the Details view.
3209 * src/main/java/org/glom/web/client/LayoutListView.java:
3211 2011-03-22 Ben Konrath <ben@bagu.org>
3213 Use a count query to get the number of rows for the list view pager.
3215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3217 2011-03-22 Ben Konrath <ben@bagu.org>
3219 Add more TODO information about CellTable pager positioning.
3223 2011-03-19 Ben Konrath <ben@bagu.org>
3225 Add TODO item about CellTable pager positioning.
3229 2011-03-18 Ben Konrath <ben@bagu.org>
3231 Remove unneeded GlomFieldColumn class.