1 2012-05-21 Murray Cumming <murrayc@murrayc.com>
3 Initial self-hosting for tests.
5 * pom.xml: Change the scope for log4j, to hopefully make it
6 available to the test code which uses it indirectly via jOOQ.
7 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
8 self-hosting, though we only use it for testing.
10 * src/main/java/org/glom/web/server/libglom/Document.java:
11 example rows: Use a map instead of a list for each row of values,
12 so we know what field they are for, instead of relying on the sequence
13 being correct. This is not very efficient, but it does not really need
15 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
16 testReadTableExampleRows(): Adapted.
18 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
19 that returns an Object, for generic use. Note that Object seems to be
20 the implicit base even of double.
21 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
22 for use in CREATE TABLE SQL queries.
23 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
24 to do self-hosting of PostgreSQL databases via its command-line
25 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
26 backends/postgres_self.cc. This is incomplete - it needs more
27 warnings about failures and it needs to clean up properly when things
29 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
30 test of this new class.
32 2012-05-21 Murray Cumming <murrayc@murrayc.com>
34 Document: loading example data: Handle exceptions.
36 * src/main/java/org/glom/web/server/libglom/Document.java:
37 DateFormat.parse() and Double.valueOf() can throw exceptions, though
38 Eclipse did not warn about that.
40 2012-05-20 Murray Cumming <murrayc@murrayc.com>
42 Document: load(), save(): Handle the example rows.
44 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
46 * src/main/java/org/glom/web/server/libglom/Document.java:
47 load(), save(): Load and save the example rows, though the date, time
48 and image types are not handled properly yet.
49 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
50 Add testReadTableExampleRows() just to check that something is read.
52 2012-05-20 Murray Cumming <murrayc@murrayc.com>
56 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
57 Added getTranslationsMap() for use while saving.
58 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
59 Adedd getUseDefaultFormatting() for use while saving.
60 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
61 and several private methods that it uses.
63 This will be useful while testing via self-hosting.
64 It is not complete, but should be complete enough for testing.
66 2012-05-17 Murray Cumming <murrayc@murrayc.com>
68 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
70 * src/main/java/org/glom/web/client/OnlineGlomService.java
71 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
72 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
73 Remove getSortedListViewData() and getSortedRelatedListData(), adding
74 the sort column index and ascending bool to the regular method.
75 Instead, a sort column index of -1 now means no sort.
76 This is less explicit, but it's fairly simple, reduces the amount of
77 code, and makes the OnlineGlomService API slightly smaller.
78 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
79 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
81 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
82 getListViewData(), getRelatedListData():
83 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
84 getListViewData(), getRelatedListData():
85 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
87 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
89 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
94 2012-05-16 Murray Cumming <murrayc@murrayc.com>
96 Use translations for top-level groups too.
98 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
99 updateTitlesForLocale(): Use the translation for the group
100 as well as for child items.
104 Just recompiled to fix a problem in the released .tar.gz file.
108 2012-05-15 Murray Cumming <murrayc@murrayc.com>
110 Corrections to navigation to related records.
112 * src/main/java/org/glom/web/client/OnlineGlomService.java:
113 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
115 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
116 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
117 relationship name, because the relationship name is not necessarily unique
119 TOOD: This is inefficient, because it passes the whole list of
120 child field items back to the server, but it is more correct, and happens
121 to fix a bug with the primary key being lost after a few navigations.
122 There is probably a chance to make this more efficient anyway in some
125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
126 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
127 * src/main/java/org/glom/web/server/ConfiguredDocument.java
128 * src/main/java/org/glom/web/server/database/DBAccess.java
129 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
130 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
133 2012-05-15 Murray Cumming <murrayc@murrayc.com>
135 Fix the use of translations.
137 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
138 Add updateTitlesForLocale().
139 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
140 Call it to discard unwanted translations and to make getTitle() return
141 the wanted translation wihout the need for the client code to specify a locale.
142 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
143 getTitle(): Fallback to the original title, as libglom does.
145 2012-05-15 Murray Cumming <murrayc@murrayc.com>
147 Document: Correctly report the number of available translation locales.
149 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
150 the available locale IDs list.
151 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
152 testLocales: Test this.
154 2012-05-15 Murray Cumming <murrayc@murrayc.com>
156 SqlUtils: Use camelCase.
158 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
159 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
160 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
161 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
162 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
163 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
165 2012-05-15 Murray Cumming <murrayc@murrayc.com>
167 Use jOOQ's tableByName() and fieldByName.
169 * pom.xml: Use jOOQ 2.3.1 to get the new API.
170 * src/main/java/org/glom/web/server/SqlUtils.java:
171 build_sql_select_step_with_where_clause(), .createField(),
172 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
173 so we can get correct quoting and escaping. Thanks to Lukas Eder for
174 adding this, and other things, to jOOQ.
176 2012-05-15 Murray Cumming <murrayc@murrayc.com>
178 SqlUtils: Remove the Connection parameters.
180 * src/main/java/org/glom/web/server/SqlUtils.java:
181 build_sql_select_with_key(), build_sql_select_with_where_clause(),
182 createSelect(), build_sql_select_step_with_where_clause(),
183 build_sql_count_select_with_where_clause(),
184 build_sql_select_count_rows(): Remove the Connection parameter because
185 jOOQ does not actually need a connectionwhen it is just used to build
187 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
189 * src/main/java/org/glom/web/server/ReportGenerator.java:
191 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
193 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
194 Constructor, getListData(), getResultSizeOfSQLQuery():
195 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
196 getSelectQuery(), getCountQuery():
197 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
198 getSelectQuery(), getCountQuery():
199 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
200 getNavigationRecord(): Adapted.
202 2012-05-14 Murray Cumming <murrayc@murrayc.com>
206 * src/main/java/org/glom/web/server/SqlUtils.java:
207 get_find_where_clause_quick(): Use a comparison of
208 lowercase values, instead of a simple equals. Regular Glom
209 uses the PostgreSQL ILIKE operator but jOOQ does not
210 support that just yet, though it will soon.
212 2012-05-14 Murray Cumming <murrayc@murrayc.com>
214 TableToViewDetails: Use a real serialization ID.
216 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
217 Though this does not fix the serialization problem.
219 2012-05-12 Murray Cumming <murrayc@murrayc.com>
221 Added LayoutItemPortalDeepCloneTest.
223 2012-05-11 Murray Cumming <murrayc@murrayc.com>
225 Make navigation work again.
227 * src/main/java/org/glom/web/server/libglom/Document.java:
228 Add getLayoutItemFieldShouldHaveNavigation().
229 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
230 Replace get/setAddNavigation() with the partly-existing
231 get/setNavigationTableName(), with an empty string being no navigation,
232 because this is simpler. Use the new
233 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
235 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
236 Add updateFieldsExtras() and call setNavigationTableName in it.
237 getDetailsLayoutGroup(),
238 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
239 createLayout(): Adapted.
240 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
241 Constructor: Adapted.
243 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
244 Replace get/setAddNavigation() with get/setNavigation(), returning a
245 TableToViewDetails class with both the table name and UsesRelationship,
246 because both are need. The previous code used java-libglom's output
247 variable (strangely, via sharedptr) to return both, but we cannot really
249 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
250 getNavigationRecord(): Adapt. However, we cannot actually use the cache
251 here because it somehow gets set to null during deepCopy(). I must test this.
252 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
253 testGetSuitableTableToViewDetails(): Adapted.
255 TODO: Find out why deepClone() is not quite working.
257 2012-05-11 Murray Cumming <murrayc@murrayc.com>
259 DBAccess: Simplify the retrievel of full field details.
261 * src/main/java/org/glom/web/server/database/DBAccess.java
262 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
263 because the Document loading should have done this.
265 2012-05-11 Murray Cumming <murrayc@murrayc.com>
267 Document: Correct loading of doubly-related layout fields.
269 * src/main/java/org/glom/web/server/libglom/Document.java:
270 loadUsesRelationship(): Actually set the related relationship, instead
271 of only setting it if it's not found.
273 2012-05-09 Murray Cumming <murrayc@murrayc.com>
275 Replace all appearances of Colour with color.
277 Because US English is dominant.
279 2012-05-09 Murray Cumming <murrayc@murrayc.com>
281 Use colors in HTML format, solving a warning about an unused function.
283 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
284 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
285 Add *asHTMLColor() versions of methods.
286 TODO: However, we should create and cache the results on the server.
287 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
288 * src/main/java/org/glom/web/client/ui/list/ListTable.java
289 * src/main/java/org/glom/web/server/ConfiguredDocument.java
290 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
291 Use the asHTMLcolor() versions.
293 2012-05-09 Murray Cumming <murrayc@murrayc.com>
295 ListViewTable: Constructor: Take the table name as a parameter.
297 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
298 Constructor: Take the tableName, and set the member variable, because
300 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
301 setCellTable(): Pass the table name.
302 This makes navigation to non-default tables work again. I don't know
303 why it worked before in the master branch.
305 2012-05-07 Murray Cumming <murrayc@murrayc.com>
307 ConfiguredDocument: Restore correct addition of hidden primary key items.
309 * src/main/java/org/glom/web/client/ui/list/ListTable.java
310 (ListTable.createCellTable): Uncomment out the check for the hidden
312 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
313 add primary key items for top-level lists and portals, as before,
314 instead of adding them to each group.
315 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
316 Actually implement the extra methods such as setHiddenPrimaryKey() and
317 comment that these are used only for top-level list groups and in portals.
318 This strangeness suggests even more that this should not be squeezed
319 into the LayoutGroup class.
321 2012-05-07 Murray Cumming <murrayc@murrayc.com>
323 Fix Formatting loading.
325 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
326 getFormattingUsed(): Remove the duplicate Formatting member variable
327 in favour of the one from the base class.
328 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
329 Initialize a new Formatting instead of using null by default, so we
330 have some defaults, instead of having to initialize one later just to
331 get the same defaults. This also makes loading of formatting from the
332 document work, because that expected a non-null.
334 2012-05-07 Murray Cumming <murrayc@murrayc.com>
336 RelatedListTable: Make sure that the tableName is set.
338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
339 Constructor: Take the tableName so it is available later. Otherwise,
340 the server assumes that we mean the default table and cannot find the
342 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
343 setData(): Pass the tableName to the RelatedListTable constructor.
345 2012-05-07 Murray Cumming <murrayc@murrayc.com>
349 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
350 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
351 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
353 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
355 * src/main/java/org/glom/web/server/database/DBAccess.java:
356 convertResultSetToDTO(), getPortal():
357 * src/main/java/org/glom/web/server/database/ListDBAccess.java
359 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
360 Add checks for null objects and out of range access, with log messages to
361 give hints so we can fix these properly.
363 2012-05-07 Murray Cumming <murrayc@murrayc.com>
365 Portals: some corrections.
367 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
369 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
370 constructor: Use getRelationshipNameUsed() instead of getName(), because
371 that is what is meant.
372 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
373 getFromField(): Fix a typo, to get the field name, not the table name.
374 * src/main/java/org/glom/web/server/database/DBAccess.java:
375 getPortal(): Fix a typo that stopped this from working.
377 2012-05-07 Murray Cumming <murrayc@murrayc.com>
379 LayoutItemPortal: Also override getTitleOriginal().
381 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
382 This lets the base getTitle() with no parameters work.
383 TODO: Test this properly.
385 2012-05-06 Murray Cumming <murrayc@murrayc.com>
387 LayoutItemPortal: getTitle*(): Use the relationship title.
389 2012-05-06 Murray Cumming <murrayc@murrayc.com>
391 LayoutItemField: Fix loading of custom titles.
393 * src/main/java/org/glom/web/server/libglom/Document.java
394 loadDataLayoutItemField(): The title, if any, instead of the field
395 title, is stored in a title_custom node. Load it from there.
396 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
398 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
399 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
400 getTitle*() overrides.
401 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
404 2012-05-06 Murray Cumming <murrayc@murrayc.com>
406 LayoutItemField: Fall back to field titles, so some are really shown.
408 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
409 Override getTitleOriginal() and getTitle(), as in java-libglom.
410 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
413 2012-05-06 Murray Cumming <murrayc@murrayc.com>
415 Correct use of setExpectedResultSize().
417 * src/main/java/org/glom/web/server/ConfiguredDocument.java
418 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
419 Use setExpectedResultSize only on top-level groups (for instance, the
420 list layout) or on child portals (in details views).
421 Use the correct table name for portals to avoid SQL errors.
422 Update the expected counts when returning cached layouts.
424 2012-05-06 Murray Cumming <murrayc@murrayc.com>
426 Document: Interpret no group column count as 1.
428 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
429 default, though we now check for this in the UI code anyway.
431 2012-05-06 Murray Cumming <murrayc@murrayc.com>
435 2012-05-06 Murray Cumming <murrayc@murrayc.com>
437 Translatable: Use Hashmap instead of Treemap because GWT supports it.
439 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
440 The use of Treemap lead to this error from async methods, with no
442 "The response could not be deserialized"
444 2012-05-06 Murray Cumming <murrayc@murrayc.com>
446 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
448 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
449 when using the Google -> GWT Compile, or
450 g toolbar button -> GWT Compile Project... feature in Eclipse.
452 2012-05-06 Murray Cumming <murrayc@murrayc.com>
454 ListTable.addColumn(): Protect against a null Formatting.
456 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
457 Create a default Formatting if it is null, because that is the simplest
460 2012-05-06 Murray Cumming <murrayc@murrayc.com>
462 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
464 * src/main/java/org/glom/web/server/ConfiguredDocument.java
465 updateLayoutGroup(): Check that the field is not null.
467 2012-05-06 Murray Cumming <murrayc@murrayc.com>
469 ListViewImpl: Protected against a bad cast error.
471 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
472 onEnterKeyDown(): Do not cast without an instanceof check.
474 2012-05-06 Murray Cumming <murrayc@murrayc.com>
476 ListTable: Protect against an out of range error.
478 * src/main/java/org/glom/web/client/ui/list/ListTable.java
479 createCellTable(): This is unlikely, but can happen while debugging.
481 2012-05-06 Murray Cumming <murrayc@murrayc.com>
483 AsyncMessage onFailure() callbacks: Log the exception message.
485 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
486 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
487 * src/main/java/org/glom/web/client/activity/ListActivity.java:
488 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
489 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
490 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
491 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
492 These are useful clues when something is wrong.
494 2012-05-06 Murray Cumming <murrayc@murrayc.com>
496 ConfiguredDocument: Avoid a null dereference.
498 * src/main/java/org/glom/web/server/ConfiguredDocument.java
499 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
500 details maps are created.
502 2012-05-06 Murray Cumming <murrayc@murrayc.com>
504 Document: Correct the port number parsing.
506 * src/main/java/org/glom/web/server/libglom/Document.java:
507 This lets us actually connect to the database and show the document.
509 2012-05-05 Murray Cumming <murrayc@murrayc.com>
513 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
514 user-interaction, asking us to load a temporary URL in a browser.s
515 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
516 which is apparently necessary for testing the service. See the comment.
517 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
518 Show the exception, if any. This is how I saw the 404 in the HTML in
521 2012-05-05 Murray Cumming <murrayc@murrayc.com>
523 DocumentTest: Move the .glom files into the resources directory.
525 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
526 URI via getResource().
528 2012-05-05 Murray Cumming <murrayc@murrayc.com>
530 Document: Remove the FieldIdentifies inner class.
532 * src/main/java/org/glom/web/server/libglom/Document.java: We only
533 use the Relationship (though the same function in libglom is maybe
534 used in other ways) and so this removes a compiler warning.
536 2012-05-05 Murray Cumming <murrayc@murrayc.com>
538 Document.load() Remove the error code parameter.
540 * src/main/java/org/glom/web/server/libglom/Document.java: load():
541 Remove the parameter. We do not set it yet and it could never have
542 worked as an output parameter (though maybe it did in java-libglom).
543 We could use an exception if we really want the failure reason.
544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
546 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
547 setUp(), testGetSuitableTableToViewDetails(): Adapt.
549 2012-05-05 Murray Cumming <murrayc@murrayc.com>
551 Make some inner classes static.
553 * src/main/java/org/glom/web/server/ConfiguredDocument.java
554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
555 * src/main/java/org/glom/web/server/ReportGenerator.java
556 * src/main/java/org/glom/web/server/libglom/Document.java
557 Make all inner classes static that can be static.
559 2012-05-05 Murray Cumming <murrayc@murrayc.com>
561 OnlineGlomServiceImpl: Do not load and check for java-libglom.
563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
564 init(): We do not use java-libglom any more.
566 2012-05-05 Murray Cumming <murrayc@murrayc.com>
568 Remove mentions of java-libglom.
570 * README: Remove mention of java-libglom, because it no longer needed.
571 * utils/build-onlineglom-war.sh:
572 * utils/check-and-recover-tomcat.py:
573 * utils/install-onlineglom-war.sh: Remove these as they are no longer
574 useful. Building is now far easier, with no need for jhbuild.
576 2012-05-05 Murray Cumming <murrayc@murrayc.com>
578 Fix the build (mvn package)
580 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
581 (LayoutGroup): Make the LayoutItemList inner class static and protected.
582 Otherwise the GWT Java->Javascript compilation fails with just this
583 error, during mvn package or when attempting to view in a browser,
584 in the GWT developer mode in Eclipse.
586 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
587 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
588 [INFO] Compiling module org.glom.web.OnlineGlom
589 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
590 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
591 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
592 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
593 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
594 [INFO] [ERROR] Cannot proceed due to previous errors
596 It has taken me 2 days to find out what was causing that. After reducing
597 the code, the compiler eventually showed me the full error message.
599 2012-05-04 Murray Cumming <murrayc@murrayc.com>
601 ConfiguredDocument: Cache the cloned and stripped layouts.
603 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
604 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
605 layout in a map, so we can retrieve it again without rebuilding it.
607 2012-05-04 Murray Cumming <murrayc@murrayc.com>
609 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
611 2012-05-04 Murray Cumming <murrayc@murrayc.com>
613 libglom classes: Implement some auto-generated emthods.
615 2012-05-04 Murray Cumming <murrayc@murrayc.com>
617 Add GwtTestOnlineGlomService.
619 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
620 However, this (and the other GwtTest*) does not seem to run during
623 2012-05-04 Murray Cumming <murrayc@murrayc.com>
625 Remove use of unsupported features from client code.
627 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
628 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
629 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
630 Use our client version of StringUtils instead of the apache commons one.
632 However, the GWT Javascript compliation still fails.
634 2012-04-25 Murray Cumming <murrayc@murrayc.com>
636 Add a Field class and implement some loading of it in Document.
638 2012-04-25 Murray Cumming <murrayc@murrayc.com>
640 Initial Document loading implementation, instead of libglom.
642 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
643 and Translatable classes, and adapt the rest of the code to use them.
644 However, this is still missing Layout and Field classes and loading.
646 2012-04-24 Murray Cumming <murrayc@murrayc.com>
648 Use of jOOQ: Move Field creation into a utility method.
650 * src/main/java/org/glom/web/server/SqlUtils.java:
651 This lets us improve it more easily.
653 2012-04-24 Murray Cumming <murrayc@murrayc.com>
655 Use of jOOQ: Improve the code to COUNT a sub-select.
657 * src/main/java/org/glom/web/server/SqlUtils.java:
658 Move initial query creation into
659 build_sql_select_step_with_where_clause().
660 build_sql_select_count_rows(): Use the jOOQ API instead of
661 concatentating text, because a jOOQ Select*Step is a TableLike,
662 which is what from() takes.
664 2012-04-23 Murray Cumming <murrayc@murrayc.com>
666 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
668 * pom.xml: Depend on jooq.
669 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
670 methods with jOOQ, based on the C++ implementations in libglom,
671 with some changes to the logic required by jooQ.
672 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
675 * src/main/java/org/glom/web/server/ReportGenerator.java:
676 * src/main/java/org/glom/web/server/SqlUtils.java:
677 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
678 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
679 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
680 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
681 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
682 Adapt. In particular, the SqlUtils methods now need to take a Connection,
683 because jOOQ needs that, though it seems unnecessary.
685 This is not quite finished. Ideally jOOQ would help us to build
686 table_name.field_name names, quoting and escaping them properly.
687 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
689 2012-04-21 Murray Cumming <murrayc@murrayc.com>
691 Move use of Glom.build_sql*() into a new SqlUtils class.
693 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
694 to wrap Glom.build_sql*(). The parameter types are still Glom one,
695 but this will make it easier to start using something other than
696 libglom or SqlBuilder.
698 2012-04-21 Murray Cumming <murrayc@murrayc.com>
700 Update the project URL.
702 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
704 2012-04-21 Murray Cumming <murrayc@murrayc.com>
706 Main layout: Use a FlowTable instead of absolute positioning.
708 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
709 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
710 child panels/widgets must have an absolute position. But that is annoying, so
711 this adds a FlowTable and puts the child panels in there.
713 2012-04-21 Murray Cumming <murrayc@murrayc.com>
715 GwtTestOnlineGlom: Comment out unused code.
717 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
718 Eclipse has started to say that some code is unused.
720 2012-04-21 Murray Cumming <murrayc@murrayc.com>
722 Update to the latest versions of dependencies.
724 * pom.xml: Update version numbers of dependencies to the latest
726 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
727 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
728 * src/main/java/org/glom/web/server/ReportGenerator.java:
729 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
730 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
731 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
733 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
734 Modify the imports where necessary.
736 2012-04-17 Murray Cumming <murrayc@murrayc.com>
738 Style: Remove overflow:hidden from searchbox
740 * src/main/webapp/style.css: Because this pushes the Back To Link
741 label/link on to the next row, which is then hidden due to the
742 hard-coded (in ems) height.
744 2012-04-20 Murray Cumming <murrayc@murrayc.com>
746 Remove some duplicate code.
748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
749 getDocumentInfo(): This must have been duplicated during the merge from the
754 2012-04-19 Murray Cumming <murrayc@murrayc.com>
756 Reports: Localize the waiting for report message.
758 * src/main/java/org/glom/web/client/activity/ReportActivity.java
759 start(): Get the message from the contants.
760 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
762 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
763 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
764 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
765 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
766 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
767 Update these files with the English text for newer strings for now.
769 2012-04-19 Murray Cumming <murrayc@murrayc.com>
771 Reports: Show a message while waiting for the report.
773 * src/main/java/org/glom/web/client/ui/ReportView.java
774 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
775 Add setWaitingText(), to show a message saying that we are
776 waiting for the report to be ready.
777 * src/main/java/org/glom/web/client/activity/ReportActivity.java
778 start(): Call setWaitingText() before calling the async
781 2012-04-19 Murray Cumming <murrayc@murrayc.com>
783 ReportGenerator: Specify date and time formats.
785 * src/main/java/org/glom/web/server/ReportGenerator.java:
786 createFieldValueElement(): Use the default (and localized)
787 short formats, though we still need a way to show 4-digit
788 years without providing the format for every locale.
789 * src/main/java/org/glom/web/server/database/DBAccess.java:
790 convertResultSetToDTO(): Use the short formats here too.
792 2012-04-18 Murray Cumming <murrayc@murrayc.com>
794 ReportGenerator: Use the correct numeric formatting.
796 * src/main/java/org/glom/web/server/ReportGenerator.java
797 createFieldExpression(), createFieldValueElement(): Take the
798 whole LayoutItem_Field instead of just the field name, so
799 we have access to the formatting.
800 createFieldValueElement(): Use JRTextField.setPattern() to
801 specify the numeric formatting, with the help of a
802 regular DecimalFormat.
804 2012-04-18 Murray Cumming <murrayc@murrayc.com>
806 ReportGenerator: Avoid showing null for group by titles.
808 * src/main/java/org/glom/web/server/ReportGenerator.java
809 generateReport(): Use setBlankWhenNull() on the field title
810 style too, because this is used for values in group by
813 2012-04-18 Murray Cumming <murrayc@murrayc.com>
815 ReportGenerator: Add a colon to titles in vertical groups.
817 * src/main/java/org/glom/web/server/ReportGenerator.java
818 addFieldToDetailBandVertical(): Pass true for the withColon
821 2012-04-18 Murray Cumming <murrayc@murrayc.com>
823 ReportGenerator: Simplify the code by using Position more.
825 2012-04-18 Murray Cumming <murrayc@murrayc.com>
827 Reports: Support vertical groups, roughly.
829 * src/main/java/org/glom/web/server/ReportGenerator.java:
830 addToReport(): Rename to addGroupToReport() and, if necessary,
831 call the new addVerticalGroupToReport() method.
832 createFieldValueElement(): Let the caller specify the Y position
835 2012-04-17 Murray Cumming <murrayc@murrayc.com>
837 Reports: Allow a second report to be shown.
839 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
840 clear(): Do not remove the HTML widget, which broke the whole layout.
842 2012-04-17 Murray Cumming <murrayc@murrayc.com>
844 Locales drop-down: Show that we use English by default.
846 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
847 fillView(): When we use English, just because that is the default, when
848 no locale is specified, show that in the Locales drop-down instead of
849 just showing the first item.
851 2012-04-17 Murray Cumming <murrayc@murrayc.com>
853 Unselect the Report/Locale/Table combo item when appropriate.
855 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
856 setPlace(): clear reportName if this is not a ReportPlace.
857 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
858 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
859 When the provided name is empty, unselect all items, so that none are
860 indicated. This uses a for loop because I cannot find a single method
863 2012-04-17 Murray Cumming <murrayc@murrayc.com>
865 Report: Give the user a way to get back to the list.
867 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
868 start(), setPlace(): Show the Back To List link on reports, and also
869 interpret selecting the empty report item as back to list.
871 2012-04-13 Murray Cumming <murrayc@murrayc.com>
873 Really show the selected Report name.
875 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
876 setPlace(): Store the reportName here, if it is that kind of Place.
877 fillView(): Set the selected Report after filling the list of reports.
878 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
879 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
880 null Strings, though we need some way to unselect all ListBox items
883 2012-04-13 Murray Cumming <murrayc@murrayc.com>
885 ReportGenerator: Try to avoid some problems.
887 * src/main/java/org/glom/web/server/ReportGenerator.java
888 addField(): Try to avoid duplicates, and avoid using a null
891 2012-04-13 Murray Cumming <murrayc@murrayc.com>
893 Reports: Use quickFind.
895 * src/main/java/org/glom/web/client/OnlineGlomService.java;
896 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
898 getReportHTML(): Add a quickFind parameter.
899 * src/main/java/org/glom/web/client/activity/ReportActivity.java
900 start(): Pass the quickFind parameter.
901 * src/main/java/org/glom/web/server/ReportGenerator.java
902 generateReport(): Take a quickFind parameter.
904 2012-04-13 Murray Cumming <murrayc@murrayc.com>
906 ReportPlace: Actually use the report name.
908 * src/main/java/org/glom/web/client/place/ReportPlace.java
909 getPlace(): Do not assign the report name to the quickfind.
911 2012-04-13 Murray Cumming <murrayc@murrayc.com>
913 Show java.library.path when complaining.
915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
916 init(): When telling us to check java.library.path, show the
919 2012-03-06 Murray Cumming <murrayc@murrayc.com>
921 ReportGenerator: Do not show nulls.
923 2012-03-06 Murray Cumming <murrayc@murrayc.com>
925 ReportGenerator: Make the title font larger.
927 2012-03-06 Murray Cumming <murrayc@murrayc.com>
929 ReportGenerator: Put field titles inside groups, if there are groups.
931 2012-03-06 Murray Cumming <murrayc@murrayc.com>
933 ReportGenerator: Take the Report itself instead of the name and group.
935 * src/main/java/org/glom/web/server/ConfiguredDocument.java
936 Remove getReportLayoutGroup().
937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
938 getReportHTML(): Pass the report instead
939 of its name and layout group.
940 * src/main/java/org/glom/web/server/ReportGenerator.java
941 generateReport(): Use the report object to use the title
944 2012-03-06 Murray Cumming <murrayc@murrayc.com>
946 ReportGenerator: Remove designBand parameters.
948 * src/main/java/org/glom/web/server/ReportGenerator.java:
949 Make designBand a class member instead of passing it to all
952 2012-03-06 Murray Cumming <murrayc@murrayc.com>
954 ReportGenerator: Add lines, a bit like in the desktop version.
956 * src/main/java/org/glom/web/server/ReportGenerator.java
957 addToReport(): Use JRDesignLine.
959 2012-03-06 Murray Cumming <murrayc@murrayc.com>
961 ReportGenerator: Correct the title positions and use some bold style.
963 * src/main/java/org/glom/web/server/ReportGenerator.java:
964 Break the code up into reusable functions, correct the placement of
965 titles, and use normal/bold styles as in the reports in the desktop
968 2012-03-06 Murray Cumming <murrayc@murrayc.com>
970 ReportGenerator: Add a header band to show the field titles.
972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
973 getReportHTML(): Pass the localeId to the ReportGenerator
975 * src/main/java/org/glom/web/server/ReportGenerator.java
976 constructor: Take the localeID so we can get translated field
978 generateReport(), addToReport(), addFieldToBand(): Add field
979 titles in a column header band.
981 2012-03-05 Murray Cumming <murrayc@murrayc.com>
983 Reports drop-down list: Some improvement.
985 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
986 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
987 Adedd setSelectedReport(),
988 setReportList(): Add a blank line so that the user can select the
990 * src/main/java/org/glom/web/client/activity/ReportActivity.java
991 start(): Show the current report by calling setSelectedReport().
992 This does not seem to work yet.
994 2012-03-05 Murray Cumming <murrayc@murrayc.com>
996 DetailsActivity, ListActivity: Move some variables into a base class.
998 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
999 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1000 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1001 the clientFactory, documentID, tableName and authenticationPopup into
1002 a base class, to avoid duplication.
1004 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1006 Translate the Reports label.
1008 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1009 Get the "Reports" label string from the constants.
1010 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1011 perties: Add Reports to the constants.
1013 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1015 Reports: Implement grouping.
1017 * src/main/java/org/glom/web/server/ReportGenerator.java:
1018 Handle LayoutItem_GroupBy items and try to do the right thing
1019 with JRDesignGroup. It seems to work.
1021 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1023 Actually show some data with JasperReports.
1025 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1026 getReportHTML(): Move most code into a ReportGenerator class.
1027 * src/main/java/org/glom/web/server/ReportGenerator.java:
1028 Recurse into sub-groups, adding fields to the JasperDesign's details
1029 band. Note that we must set an arbitrary width and height, or it just
1030 will not show any data.
1032 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1034 Reports Chooser: Show the titles, not the names.
1036 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1037 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1038 and the names as the values.
1039 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1040 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1041 group now that we provide the report name, so it should always
1044 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1046 Depend on jasperreports.
1048 * pom.xml: Add the dependency. My plan is to use this on the
1051 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1053 Implement navigation to report places.
1055 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1056 start(): Do not bother to handle all events here.
1057 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1058 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1059 Added getSelectedReport().
1060 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1061 .java: start(): When handling a change to the reports chooser,
1062 call getSelectedReport() and goTo() its ReportPlace.
1063 * src/main/java/org/glom/web/client/ui/ReportView.java
1064 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1065 Added setReportHTML() which puts the html in a gwt HTML widget.
1066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1067 getReportHTML(): Return "TODO" just to show that this works.
1069 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1071 Make ReportPlace usable.
1073 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1074 Mention ReportPlace.
1075 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1076 Correct the @prefix annotation.
1078 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1080 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1082 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1083 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1085 Change getReportLayout() to getReportHMTL() because we will not need to
1086 parse or render the report layout on the client side.
1087 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1088 getReportLayout(): Return the libglom LayoutGroup type because we will
1089 not need to convert to a shared type, because this will not be used on
1091 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1094 Note that there is still no implementation for this.
1097 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1099 Add a (empty) Report Place, View, and Activity.
1101 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1103 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1104 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1105 this into a superclass:
1106 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1107 and also use it as the base of this new ReportPlace:
1108 * src/main/java/org/glom/web/client/place/ReportPlace.java
1110 * src/main/java/org/glom/web/client/ui/ReportView.java
1111 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1112 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1113 Add these, containing mostly boiler-plate for now.
1115 * src/main/java/org/glom/web/client/OnlineGlomService.java
1116 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1117 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1119 Add API to get the LayoutGroup for the report.
1121 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1123 Add and fill a Reports drop-down list box.
1125 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1127 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1128 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1130 Added getReports(document, table, localeID), calling
1131 ConfiguredDocument.getReports().
1132 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1133 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1134 Added setReportsList() and a list widget.
1135 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1136 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1141 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1143 Translations: Add Esperanto.
1145 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1146 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1147 properties: Add this translation because someone took the time to make it.
1149 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1151 Adapt to the java-libglom 1.21.7 API.
1153 * src/main/java/org/glom/web/server/ReportGenerator.java:
1154 addToReport(): get_group_secondary_fields() is now
1155 get_secondary_fields().
1158 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1160 Use the latest java-libglom version.
1162 * pom.xml: Use java-libglom 1.21.7.
1164 2012-03-03 Ben Konrath <ben@bagu.org>
1166 Display date and time in details view.
1168 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1170 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1172 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1174 Require the latest java-libglom.
1176 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1178 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1180 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1182 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1183 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1184 an empty quickfind string. I also corrected libglom to create only
1185 empty where clauses for empty quickfind strings, but this avoids the
1188 2012-02-24 Ben Konrath <ben@bagu.org>
1190 Improve the tabs in the Notebook widget.
1194 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1196 Translations: Try to translate the strings.
1198 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1199 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1201 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1202 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1203 Take the Open translation from GTK+'s .po files.
1204 Take the Details translation from Glom's po files.
1205 I have added the other strings to Glom so we can get translations that way:
1206 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1208 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1210 TableSelectionViewImpl: Put the search label and entry in a div.
1212 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1213 Put the search widgets in a FlowTable so that the CSS can be used to
1214 style them while keeping them together.
1215 * src/main/webapp/style.css: Mention the new div.
1217 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1219 Translate more strings in more locales.
1221 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1222 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1223 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1224 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1225 Translate the "Details" and "Open" string too.
1227 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1228 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1229 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1230 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1231 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1232 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1233 Add these new locales as placeholders though they currently contain English.
1235 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1237 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1240 Check the ConfiguredDocument* for null before using it.
1242 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1244 Tell Eclipse about the generated java files.
1246 * .classpath: This lets it find OnlineGlomConstants.java.
1247 It would be nice if Eclipse just used the maven build files.
1249 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1251 Prevent a crash when no locale is specified in the URL.
1253 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1254 Avoid returning a null string, obtained from
1255 Window.Location.getParameter(). This caused a crash when it was
1256 later passed to libglom's API.
1257 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1258 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1259 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1260 guard against future null strings.
1262 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1264 Use the ?locale= query param instead of the &lang= token param.
1266 * src/main/java/org/glom/web/client/place/ListPlace.java
1267 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1268 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1269 Remove the lang token key and value.
1271 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1272 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1273 When the user selects a different locale from the chooser, use
1274 Window.Location.assign() to change the URL, which then causes a reload.
1276 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1278 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1279 * src/main/java/org/glom/web/client/activity/ListActivity.java
1280 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1281 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1282 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1283 * src/main/java/org/glom/web/client/ui/ListView.java:
1284 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1286 Remove localeID member variables and method/constructor parameters, instead
1287 using Utils.getCurrentLocaleID() when we need a localID to pass to
1290 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1292 Internationalize the UI strings.
1294 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1295 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1296 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1297 because it is unused. Messages are apparently strings that can have
1298 parameters, but we do not need that yet, so Contants will be enough for now.
1299 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1300 to say that we support the en and de locales.
1301 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1302 The original English strings.
1303 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1304 Some German translations of the English strings.
1305 The i18n goal then uses the .properties file to generate an
1306 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1307 returns an implementation that returns the translated strings.
1308 The documentation suggests putting these in src/java/*/client/, but it seems
1309 best to put it in src/resources/*/client/.
1310 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1311 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1312 instead of hard-coding them.
1313 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1314 but that does not seem to stop the build, though it confuses Eclipse.
1316 You can see the translated string by adding ?locale=de to the URL, like so:
1317 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1319 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1321 Improve null/empty String checks.
1323 * pom.xml: Add a dependency on commons-lang, to use
1324 org.apache.commons.lang.StringUtils.
1325 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1327 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1328 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1329 Use StringUtils.isEmpty().
1331 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1332 StringUtils class with a static isEmpty() function because we
1333 cannot use org.apache.commons.lang.StringUtils in client-side
1334 GWT code because it (apparently) cannot be compiled to javascript.
1335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1336 * src/main/java/org/glom/web/client/activity/ListActivity.java
1337 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1338 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1339 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1340 * src/main/java/org/glom/web/client/place/ListPlace.java
1341 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1342 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1343 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1344 * src/main/java/org/glom/web/client/ui/details/Group.java
1345 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1346 our StringUtils.isEmpty() function.
1348 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1350 Update to the latest java-libglom API.
1352 * pom.xml: Require java-libglom 1.21.4.
1353 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1354 getDocumentInfo(), getListViewLayoutGroup():
1355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1357 * src/main/java/org/glom/web/server/database/DBAccess.java
1358 getFieldsToShowForSQLQueryAddGroup(),
1359 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1360 with either get_database_title_original() or
1361 get_database_title(localeID).
1363 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1365 ConfiguredDocument: Avoid a null pointer exception.
1367 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1368 Initialize localeID to "" to avoid returning a null String which
1369 causes a crash in java-libglom's swing-generated code.
1371 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1373 Some simple renaming.
1375 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1376 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1377 for localeChooser. This seems more appropriate and is less ambiguous
1378 particularly in the .css file.
1380 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1382 ConfiguredDocument: Rename the localedID private member variable.
1384 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1386 Adapt to the latest java-libglom API from git master.
1388 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1389 libglom now uses only Vector instead of List, which uses add() instead of
1392 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1394 ConfiguredDocument: Rename the localedID private member variable.
1396 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1398 Build a source tarball with mvn assembly:single
1400 * assembly.xml: Add this file.
1401 * pom.xml: Use the maven-assembly-plugin and tell it to use
1402 our assembly.xml file.
1404 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1406 OnlineGlomServiceImpl: Get .glom files recursively.
1408 * pom.xml: Depend on commons-io from org.apache.commons.
1409 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1410 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1411 files recursively, and with the easier filter for the extension.
1412 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1413 simplify that code too.
1415 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1417 README: Mention that you must install java-libglom packages separately.
1419 But then it works, because java-libglom is now in the central maven
1422 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1424 locales drop-down: Show the correct selected locale when the URL changes.
1426 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1427 .java: setPlace(): Move some code into fillView().
1429 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1431 locales drop-down: Do not lose the primary key.
1433 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1434 start(): onLocaleChange(): Pass the current primary key value,
1435 instead of an empty value.
1437 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1439 locales drop-down: Do not lose the drop-down selection.
1441 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1442 .java (TableSelectionActivity.fillView): Set the selected locale
1443 after changing the drop-down items (though we do not really need
1444 to change them just because the locale changes.)
1446 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1448 locales drop-down: Change the tables list when this changes.
1450 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1451 .java: TableSelectionActivity.start(): Move the async table titles
1452 retrieval into a private fillView() method and also call this when
1453 the chosen locale changes.
1454 Note that the document title is not actually translatable yet, but
1455 that is a problem that I should fix soon in libglom.
1457 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1459 Improve the placement of the locales drop-down.
1461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1462 Put the title and locales drop-down in a div (gwt.FlowTable).
1463 * src/main/webapp/style.css: Add magic css properties to make this work.
1464 Also remove the left margin from the title so that it lines up with the
1467 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1469 locales selector: Show human-readable locale titles.
1471 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1472 getDocumentInfo(): Use java.util.Locale to show a real title of
1473 each locale, in the locale's own language.
1475 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1477 Add a language/locale selector drop-down.
1479 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1480 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1481 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1482 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1483 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1484 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1485 Add a ListBox to show the available locales. Add getLocaleSelector(),
1486 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1487 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1488 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1489 java: Add these classes.
1490 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1491 start(): Fill the locales ListBox. Handle its change event, firing a
1493 setPlace(): Show the selected locale as specified by the URL token.
1494 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1495 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1496 Handle LocaleChangeEvent, going to a new *Place with that locale.
1498 The placement of the ListBox is not pretty, and it currently uses the ID
1499 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1503 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1505 Search box: Show the search text from the URL token.
1507 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1508 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1509 Add setQuickFindText().
1510 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1511 .java: setPlace(): Store the queryText if the place is a ListPlace,
1512 and call TableSelectionView.setQuickFindText().
1514 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1516 Allow use of translations via, for instance, &lang=de in the URL.
1518 * pom.xml: Use the unstable java-libglom 1.21 version.
1520 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1521 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1522 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1523 init(): Instead of calling TranslatableItem.set_current_locale()
1524 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1525 However, this is only for default locales, which are not needed to
1526 change the locale in the URL.
1527 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1528 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1529 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1530 layout for a particular locale.
1531 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1532 Add get/setDefaultLocaleID().
1533 getDocumentInfo(), getListViewData(), getRelatedListData(),
1534 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1535 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1536 localeID parameter, so we can get the layout for a particular locale.
1538 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1539 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1540 * src/main/java/org/glom/web/client/place/ListPlace.java:
1541 Parse and construct a lang parameter too.
1543 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1544 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1545 passed to subsequent methods and constructors.
1546 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1547 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1548 Store the localeID from the *Place and pass it to other constructors
1549 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1551 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1552 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1553 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1554 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1555 * src/main/java/org/glom/web/client/ui/ListView.java:
1556 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1557 Take localeID parameters and pass them to subsequent constructors and
1558 methods, so that the layout is always retrieved for that locale.
1560 This is rather repetitive.
1562 Note that "" means the original (default) locale of the Glom document,
1563 which is usually English.
1565 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1567 Documents: Remove final keyword to fix startup configuration.
1569 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1570 final keywords on the private member variables because that breaks
1571 the startup, apparently (there are warnings) because it stops them
1572 from being serialized. I added these in the previous commit.
1574 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1576 Documents: Add some final keywords.
1578 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1581 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1583 OnlineGlomServiceImpl: Add to overview comments.
1585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1586 Note that this is where all the document are loaded. They are not
1587 loaded freshly for each page.
1589 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1593 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1594 Add a TextBox for the text of a quick find.
1595 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1597 setBackLink(): Add a String quickFind parameter.
1598 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1599 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1600 to the base interface, because that is how TableSelectionViewImpl is used.
1601 * src/main/webapp/style.css: Add style for the search box and its label.
1603 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1604 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1605 Add these files, based on the existing TableChangeEvent and
1606 TableChangeEventHandlers.
1607 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1608 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1609 a ListPlace() that the user should be taken to.
1610 * src/main/java/org/glom/web/client/activity/ListActivity.java
1611 start(): Handle it here too and adapt the TableChangeEvent handler to
1612 pass the extra "" quickFind parameter to ListPlace.
1613 * src/main/java/org/glom/web/client/place/ListPlace.java:
1614 Constructor: Take an extra String quickFind parameter and store it,
1615 returning it from a new getQuickFind() method.
1616 getToken(): Put the quickFind text in the URL token.
1617 getPlace(): Parse the quickFind text from the URL token.
1618 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1619 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1620 ListPlace constructor.
1621 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1622 .java: start(): Add a Change handler for the TableSelectionView's
1623 TextBox (via its base HasChangeHandlers interface), firing the new
1624 QuickFindChangeEvent.
1625 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1626 pass the extra "" quickFind parameter.
1628 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1629 setCellTable(): Add a String quickFind parameter and pass it to
1630 the ListViewTable() constructor.
1631 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1632 setCellTable() in the base interface, because that is how ListViewImpl
1635 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1636 Add a String quickFind member variable.
1637 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1638 Constructor: Add a String quickFind parameter, storing it in the
1639 base ListTable's member variable.
1640 onRangeChanged(): Pass quickFind to the
1641 OnlineGlomServiceAsync.getSortedListViewData() and
1642 OnlineGlomServiceAsync.getListViewData() methods.
1644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1645 getListViewData(), getSortedListViewData(): Add a String quickFind
1646 parameter, passing it to ConfiguredDocument.getListViewData().
1647 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1648 Change getListViewData(), getSortedListViewData() in the base interface,
1649 because that is how OnlineGlomServiceImpl is used, via this:
1650 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1651 Change getListViewData(), getSortedListViewData() here too.
1652 This class can apparently be used to asynchronously call methods on
1653 OnlineGlomService, and GWT seems to implement that after recognizing
1654 just the *Async name convention and the extra AsyncCallback parameters.
1656 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1657 getListViewData(): Add a String quickFind parameter, and pass it to
1658 ListViewDBAccess.getData().
1659 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1660 getListData(): Add a String quickFind parameter and pass it to
1662 getSelectQuery(): Add a String quickFind parameter.
1663 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1664 getSelectQuery(): Add a String quickFind parameter and use it with
1665 Glom.get_find_where_clause_quick() to pass a where_clause to
1666 Glom.build_sql_select_with_where_clause(), to actually filter the
1668 getData(): Add a String quickFind parameter, passing it to getListData().
1669 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1670 va: getData(): Pass an empty string to getListData() for the
1671 quickFind parameter.
1673 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1675 ListTable: Minor change.
1677 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1678 createCellTable(): Make this protected instead of public.
1680 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1682 Many files: Use final for the parameters and use the @override attribute.
1684 2012-01-22 Ben Konrath <ben@bagu.org>
1686 Add anchor links for single line text that starts with http, ftp and www.
1690 2012-01-22 Ben Konrath <ben@bagu.org>
1692 Add ellipsis to single line text in details view.
1696 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1698 Remove all javadoc author tags.
1700 Because they are awkward and meaningless when many people touch
1702 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1704 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1706 Revert the COPYING.LESSER to COPYING rename.
1708 Apparently both should be there if it is LGPL.
1710 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1712 *View: Remove unused imports.
1714 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1715 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1716 * src/main/java/org/glom/web/client/ui/ListView.java:
1717 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1718 Remove unused imports, as suggested by Eclipse.
1720 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1722 Move the *View::Presenter types, and some API into one base View.
1724 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1725 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1726 * src/main/java/org/glom/web/client/ui/ListView.java:
1727 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1728 Presenter, setPresenter() and clear() into a shared base interface,
1729 to avoid the unnecessary duplicate Presenter types and to more clearly
1730 show how the *Views share the same structure, even if they are not
1731 used polymorphically.
1733 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1734 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1736 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1737 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1738 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1740 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1743 Feel free to revert this if there is a good reason for the duplicate
1746 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1748 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1750 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1751 a class member instead of a local variable in the method.
1752 This lets us use it to get the view instances, for use in tests.
1753 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1754 beforeOnlineGlom(): Test some more details of the initial view.
1755 Again, this is not very useful.
1757 To really test gwt-glom we will need to start a local postgresql
1758 instance with local data, like the Glom tests in C++.
1760 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1762 pom.xml: Mention the LGPL license.
1764 * pom.xml: Add a licenses section.
1765 * COPYING.LESSER: Move this to COPYING, which
1766 previously contained the GPL. But gwt-glom is all LGPL.
1768 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1770 Add project information to README and pom.xml.
1772 * README: Add a brief description and mention some mvn
1774 * pom.xml: This extra information shows up in mvn site
1777 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1779 Use the latest java-libglom version.
1781 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1783 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1785 GwtTestOnlineGlom: Test a little more.
1787 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1788 protected rather than private, as suggested by the gwt-test-utils
1790 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1791 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1792 Test the initial visibility of the panels.
1794 However, this is not a very useful test.
1795 And I wonder how we should generally test using this idea for an
1796 activity/places app like ours where the real changes happen implicitly
1797 based on the history token/URL.
1799 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1801 Slight modification to *Mapper comments.
1803 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1804 (DataActivityMapper)
1805 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1807 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1809 Remove comments mentioning GIN because they are just copied from
1810 the example code and are apparently not helpful:
1811 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1812 Also change the mention of a class that is only in the example code.
1814 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1816 GwtTestOnlineGlom test: Minor changes.
1818 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1819 Avoid the long qualified class name and modify the comment
1820 because it is now obvious to me that the mocked class is the only
1821 custom one created via GWT.create().
1823 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1825 Tests: Added the beginnings of a test using gwt-test-utils.
1827 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1828 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1829 which tells gwt-test-utils what class will be tested.
1830 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1831 Add a simple (but empty) test case. One class, used by the OnlineGlom
1832 class, is mocked so that it can be created. However, I am not sure
1833 why only this class needs to be mocked.
1835 Note that mockito seems more popular, and clearer, than easymock,
1836 but I have not got that working yet. It might be a matter of the
1839 This test is run during mvn integration-test.
1841 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1843 Tests: Use junit4-style syntax instead of junit3-style.
1845 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1846 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1847 * src/test/java/org/glom/web/shared/DataItemTest.java:
1848 Use the @Test annotation rather than relying on the test*() prefix.
1849 Also no longer implement TestCase, to avoid triggering support for
1850 the junit3-way, which stops the annotations from working.
1851 Change the imports from import junit.framework.* to
1852 import org.junit.*, which is apparently the new way.
1854 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1856 Added a test for ListPlace token parsing and creation.
1858 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1859 This is much the same as DetailsPlaceTest.
1861 I wonder how we could test the other parts of the *Place API.
1863 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1865 DetailsPlace test: Also test getToken() and recreation via getPlace().
1867 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1868 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1869 recreate it, testing the recreated DetailsPlace for the same parameter
1872 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1874 Use the surefire-report plugin.
1876 * pom.xml: This generates a HTML report about the tests in
1877 target/site/surefire-report.html
1878 when you do mvn surefire-report:report. It seems to be popular/normal.
1880 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1882 Added a test for DetailsPlace.
1884 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1885 Test the getPlace() token parsing.
1887 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1889 Added a first unit test.
1891 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1892 * src/test/java/org/glom/web/shared/DataItemTest.java:
1893 This is a silly test but it is just to get things started. Note that
1894 maven/junit finds the test because it looks in src/test by default.
1896 2011-12-22 Ben Konrath <ben@bagu.org>
1898 Change charsetName to "UTF-8" when replacing line breaks.
1900 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1901 that work in Java (such as "UTF8") will not work when compiled to
1904 This fixes a problem with multi-line details view fields that have hard
1905 line breaks. The "License Text" field on this page demonstrates the
1908 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1910 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1912 2011-12-22 Ben Konrath <ben@bagu.org>
1914 Fix another bug with related list navigation.
1916 I've tested all the navigation buttons in all of the related lists
1917 so things should be good now.
1919 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1921 2011-12-22 Ben Konrath <ben@bagu.org>
1923 Fix a crasher when refreshing the list view with the default table.
1925 This crash will also happen when loading the list view with the default
1926 table from a link or bookmark.
1928 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1929 to the main document selection page when the document id hasn't been
1931 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1932 the main document selection page when the document id hasn't been
1934 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1935 values for the details place when the document id hasn't been set.
1936 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1937 values for the list place when the document id hasn't been set.
1939 2011-12-21 Ben Konrath <ben@bagu.org>
1941 Protect against NPE when glom.document.locale is not in config.
1943 This patch protects against an NPE when glom.document.locale is not in
1944 the config file. This NPE will also happen if glom.document.locale is
1947 The patch also updates the error message to display the class name when
1948 the getMessage() returns null. This was happening when the NPE was
1949 thrown and I had "Configuration Error: null". If an NPE is encountered
1950 with this patch, "Configuration Error: NullPointerException " will be
1953 This commit closes this bug:
1955 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1957 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1959 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1961 Rename onlineglom.properties to onlineglom.properties.sample.
1963 * src/main/resources/onlineglom.properties: Rename to:
1964 * src/main/resources/onlineglom.properties.sample:
1965 * src/main/resources/README: And add this file explaining that people
1966 should rename it back when deploying.
1968 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1970 Allow choosing the translation in the .properties file.
1972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1973 init(): Read a glom.document.locale value from the configuration file
1974 and call Glom's TransatableItem::set_current_locale() method.
1975 * src/main/resources/onlineglom.properties: Add a commented-out
1976 example of this new setting.
1978 It would be better to add &lang=de_DE to the URL, but the current
1979 libglom API does not allow us to do this easily. I am working on that.
1981 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1983 Avoid a crash in parsing of token parameters.
1985 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1986 ava: getTokenParams(): Do not crash if a parameter has a key but no
1987 value, and ignore parameters with neither.
1989 2011-12-17 Murray Cumming <murrayc@murayc.com>
1991 History token building/handling: Improve use of token parameters.
1993 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1994 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1995 and buildParamsToken(HashMap), for use by derived classes.
1996 Make the separator private because it is no longer be needed.
1997 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1998 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1999 instead of manual string concatenation.
2000 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2001 of hardcoded indices and awkward splitting code.
2002 * src/main/java/org/glom/web/client/place/ListPlace.java
2003 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2004 instead of manual string concatenation.
2005 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2006 of hardcoded indices and awkward splitting code.
2007 This should fix bug #666420
2009 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2011 Fix a Navgiation->Navigation typo in the code.
2013 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2014 Rename processNavgiation() to processNavigation().
2016 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2018 Fix a seperator->separator typo in the code.
2020 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2021 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2022 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2025 2011-12-15 Ben Konrath <ben@bagu.org>
2027 Cleanup some comments.
2029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2031 2011-12-14 Ben Konrath <ben@bagu.org>
2033 Replace \n with <br/> for multiline text in the details view.
2035 Vertical scrollbars are added when needed as well.
2037 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2039 2011-12-14 Ben Konrath <ben@bagu.org>
2041 Specify the font for document selection links.
2043 * src/main/webapp/style.css:
2045 2011-12-14 Ben Konrath <ben@bagu.org>
2047 Fix bouncy CellTable while paging.
2049 This doesn't currently work with related list tables in unselected
2052 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2054 2011-12-14 Ben Konrath <ben@bagu.org>
2056 Revamp the appearance of the document selection page.
2058 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2059 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2060 * src/main/webapp/style.css:
2062 2011-12-13 Ben Konrath <ben@bagu.org>
2064 Set navigation button column to the smallest size possible.
2066 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2068 2011-12-13 Ben Konrath <ben@bagu.org>
2070 Change OpenButton nomenclature to NavigationButton.
2072 Using NavigtionButton makes things more generic. Classes, methods and
2073 variables have been changed.
2075 This is a rename-only refactor.
2077 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2078 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2079 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2080 Renamed from OpenButtonCell.
2081 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2082 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2083 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2085 2011-12-12 Ben Konrath <ben@bagu.org>
2087 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2089 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2090 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2091 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2092 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2094 2011-12-12 Ben Konrath <ben@bagu.org>
2096 Update variable names and comments.
2098 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2099 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2101 2011-12-12 Ben Konrath <ben@bagu.org>
2103 Properly initialize numNonEmptyRows variable to zero.
2105 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2106 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2108 2011-12-05 Ben Konrath <ben@bagu.org>
2110 Add latest mockup with HTML tables.
2112 Features of this mockup:
2114 -> HTML table for flowtable
2115 -> HTML table for flowtable column
2116 -> Example of how related lists would look
2117 -> Not using text entries for data items
2119 The current version of Online Glom doesn't use HTML tables for the
2122 This mockup has been sent to the glom-devel mailing list but it's good
2123 to have it here as well.
2125 * mockups/details-view-html-tables.html:
2127 2011-12-05 Ben Konrath <ben@bagu.org>
2129 Remove unnecessary getPrimaryKeyField() method.
2131 getPrimaryKeyFieldForTable(String) has been renamed to
2132 getPrimaryKeyField(String).
2134 * src/main/java/org/glom/web/server/database/DBAccess.java:
2135 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2136 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2138 2011-12-05 Ben Konrath <ben@bagu.org>
2140 Add string representation of TypedDataItem value to conversion error message.
2142 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2143 message was extracted into its own method to avoid duplication.
2145 2011-12-05 Ben Konrath <ben@bagu.org>
2147 Add type checking to navigation primary key value creation.
2149 Create navigation primary key only if the expected type from the Glom
2150 document matches the type returned by the SQL query.
2152 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2154 2011-12-05 Ben Konrath <ben@bagu.org>
2156 Rename a couple of variables in RelatedListNavigation.
2158 This is a rename-only refactor.
2160 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2162 2011-12-05 Ben Konrath <ben@bagu.org>
2164 Move getListLayoutGroup() into getListViewLayoutGroup().
2166 This removes getListLayoutGroup(). It was only being called by
2167 getListViewLayoutGroup().
2169 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2171 2011-12-05 Ben Konrath <ben@bagu.org>
2173 Remove check for LayoutItem_Portal in list table method.
2175 This check is no longer necessary because the method isn't being used
2176 to create the LayoutItemPortal DTO.
2178 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2180 2011-12-05 Ben Konrath <ben@bagu.org>
2182 Properly support related list navigation.
2184 Navigation from the "Repository Analyzer -> Package Scans ->
2185 Dependencies" related table wasn't working because the primary key for
2186 related tables wasn't being set properly. This commit fixes the
2189 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2190 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2191 doesn't set the primary key properly for related list tables.
2192 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2193 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2194 useful for getting the primary key for list view tables and for related
2196 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2197 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2198 Move code to set the primary key for the table from the abstract
2199 ListDBAccess class to ListViewDBAccess as it's only correct for list
2201 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2202 Properly add primary key to related list tables.
2204 2011-12-02 Ben Konrath <ben@bagu.org>
2206 Properly set the horizontal alignment of fields.
2208 This fix is for both the list tables and the details view.
2210 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2211 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2212 to set the horizontal alignment of fields.
2214 2011-12-02 Ben Konrath <ben@bagu.org>
2216 Display currency codes in the details view.
2218 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2220 2011-12-02 Ben Konrath <ben@bagu.org>
2222 Avoid duplicate JNI call.
2224 JNI is not as efficient as pure Java and this is an easy (and small)
2227 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2228 Use previously retrieved value for whereClauseToTableName instead of
2231 2011-12-02 Ben Konrath <ben@bagu.org>
2233 Rename a couple of variables in RelatedListNavigation.
2235 This is a rename-only refactor.
2237 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2239 2011-12-02 Ben Konrath <ben@bagu.org>
2241 Indicate clearly that a mismatched primary key type is a bug.
2243 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2244 warning to error. Add 'This is a bug.' to message.
2246 2011-12-02 Ben Konrath <ben@bagu.org>
2248 Update / fix some comments.
2250 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2252 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2254 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2255 Fix comments. Add some TODOs.
2257 2011-12-02 Ben Konrath <ben@bagu.org>
2259 Enable navigation to details view with string primary key from related list.
2261 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2262 Create a text primary key value when return type of result is
2263 java.sql.Types.VARCHAR.
2265 2011-12-02 Ben Konrath <ben@bagu.org>
2267 Use checkboxes for booleans in the details view.
2269 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2271 2011-12-01 Ben Konrath <ben@bagu.org>
2273 Improve performance of related list height calculation.
2275 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2276 Put code to calculate the expected height in a static initializer so
2277 that that it's only called once.
2279 2011-12-01 Ben Konrath <ben@bagu.org>
2281 Show related list tables in notebooks (again).
2283 Calculate the height of the related list tables so the Notebook can be
2284 set the correct height. The height of the related list table is also needed by
2285 FlowTable to be able decide how to create the layout.
2287 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2288 and set the Portal height based on the height of the related list
2289 table and the Portal container.
2290 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2291 Add method to calculate the height of the related list tables.
2292 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2293 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2294 calculate the height of the Pager widget.
2296 2011-12-01 Ben Konrath <ben@bagu.org>
2298 Use CellTable API for table property instead of setting style on Element.
2300 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2302 2011-12-01 Ben Konrath <ben@bagu.org>
2304 Make ListViewTable and RelatedListTable a consistent height.
2306 The tables are now a consistent height regardless of the contents of
2307 the table. A hidden button is added to empty rows to ensure that the
2308 height of these rows will match the height of rows with data.
2310 A navigation button column is now added to every table. The width of
2311 the navigation column is set to 0px when a RelatedListTable shouldn't
2312 have navigation buttons. This maintains the a consistent row height in
2313 tables that don't show the navigation buttons.
2315 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2316 navigation column when not needed.
2317 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2318 arguments for navigation button to constructor of ListViewTable.
2319 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2320 hidden button for empty data rows.
2321 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2322 arguments for navigation button to constructor.
2323 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2324 create navigation buttons. Add hideNavigationButtons() method.
2325 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2326 arguments for navigation button to constructor.
2328 2011-12-01 Ben Konrath <ben@bagu.org>
2330 Use 'visibility: hidden' in Utils.getWidgetHeight().
2332 This is better choice because hidden elements are invisible, don't
2333 respond to events and are not part of the tab order. They will,
2334 however, take up space which is required to be able to calculate the
2335 height of the widget.
2337 * src/main/java/org/glom/web/client/Utils.java:
2339 2011-12-01 Ben Konrath <ben@bagu.org>
2341 Use Utils.getWidgetHeight() in FlowTable.
2343 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2345 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2347 2011-12-01 Ben Konrath <ben@bagu.org>
2349 Put the details css class name on the correct table column.
2351 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2353 2011-11-30 Ben Konrath <ben@bagu.org>
2355 Update for java-libglom API change.
2357 The getters and setters on FieldFormatting and NumericFormat were
2358 changed to remove the 'M'.
2360 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2362 2011-11-29 Ben Konrath <ben@bagu.org>
2364 Only allow RelatedListTables in Portals.
2366 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2368 2011-11-29 Ben Konrath <ben@bagu.org>
2370 Only create a contents panel for Portals when title is being set.
2372 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2374 2011-11-29 Ben Konrath <ben@bagu.org>
2376 Set TabLayoutPanel height based on calculated height its widgets.
2378 This is a potential fix for this bug:
2380 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2382 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2384 2011-11-29 Ben Konrath <ben@bagu.org>
2386 Align details field labels and data with the Open buttons.
2388 * src/main/webapp/style.css:
2390 2011-11-29 Ben Konrath <ben@bagu.org>
2392 Remove unnecessary <div> in the Notebook widget.
2394 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2395 method to get container FlowPanel (<div>).
2396 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2397 initWidget() method directly on the TabLayoutPanel widget instead of
2398 Group's container widget.
2400 2011-11-29 Ben Konrath <ben@bagu.org>
2402 Don't add group titles for Portals in Notebooks.
2404 This reverts the previous patch and fixes a bug I introduced with
2405 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2407 * src/main/java/org/glom/web/client/ui/details/Group.java:
2408 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2410 2011-11-28 Ben Konrath <ben@bagu.org>
2412 Remove unused boolean argument in Portal constructor.
2414 Just a code cleanup.
2416 * src/main/java/org/glom/web/client/ui/details/Group.java:
2417 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2419 2011-11-28 Ben Konrath <ben@bagu.org>
2421 Remove hack for glom 1.18 style glom files.
2423 * src/main/java/org/glom/web/client/ui/details/Group.java:
2424 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2425 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2427 2011-11-28 Ben Konrath <ben@bagu.org>
2429 Use Gda Value version of primary key to log result too large error.
2431 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2433 2011-11-28 Ben Konrath <ben@bagu.org>
2435 Don't use TypedDataItem.getText() for Unknown types from the URL.
2437 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2438 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2439 instead of getText().
2440 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2441 String field and getUnknown() method.
2443 2011-11-28 Ben Konrath <ben@bagu.org>
2445 Log an error message when the java-libglom .so is not present.
2447 The error message was being set in the exception but not logged.
2449 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2451 2011-11-28 Ben Konrath <ben@bagu.org>
2453 Ignore LayoutItem_CalendarPortals.
2455 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2456 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2458 2011-11-28 Ben Konrath <ben@bagu.org>
2460 Extract method for creating the LayoutItemPortal DTO.
2462 Just breaking the code up into smaller chunks.
2464 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2466 2011-11-28 Ben Konrath <ben@bagu.org>
2470 This should have been added with the refactor. Oops!
2472 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2474 2011-11-28 Ben Konrath <ben@bagu.org>
2476 Create primary key value from URL string using type from Glom document.
2478 See this bug, comments 19 - 25:
2480 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2482 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2483 create a TypeDataItem for the primary key here when loading from a
2484 URL. Show the same string for the primary key value as was received
2485 from the URL string (when loading from a URL).
2486 * src/main/java/org/glom/web/server/Utils.java: Update method for
2487 creating the Gda Value from the TypeDataItem to properly deal with
2488 creating a Gda Value based on the Glom document type for the primary
2489 key value string when loading from a URL.
2490 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2491 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2492 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2493 Update for changed method name.
2495 2011-11-27 Ben Konrath <ben@bagu.org>
2497 Rename PrimaryKeyItem to TypedDataItem.
2499 The name PrimaryKeyItem suggests what the class should be used for.
2500 TypedDataItem is a neutral name that describes the class better.
2502 This is a rename-only refactor.
2504 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2505 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2506 * src/main/java/org/glom/web/client/Utils.java:
2507 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2508 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2509 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2510 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2511 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2512 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2513 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2514 * src/main/java/org/glom/web/server/Utils.java:
2515 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2516 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2517 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2518 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2520 2011-11-25 Ben Konrath <ben@bagu.org>
2522 Improve Gda Value conversion from PrimaryKeyItem.
2524 The value from the PrimaryKeyItem is only used if its type match the
2525 type from the glom document.
2527 * src/main/java/org/glom/web/server/Utils.java:
2529 2011-11-25 Ben Konrath <ben@bagu.org>
2531 Manually check if the java-liblgom .so is visible to the JVM.
2533 It seems that Tomcat has problems when a static initializer throws an
2534 exception. This check is done before the first method call into
2535 java-libglom so that execution doesn't continue if the .so is not
2538 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2540 2011-11-25 Ben Konrath <ben@bagu.org>
2542 Improve browser configuration error messages.
2546 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2548 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2549 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2550 getConfigurationErrorMessage() method.
2551 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2552 Get and display a specific configuration error message when no Glom
2553 documents are found.
2554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2555 Implement getConfigurationErrorMessage() method. Surround configuration
2556 code in the init() method with a try/catch block. This allows the
2557 errors to be caught while keeping the servlet available to retrieve the
2558 configuration error message.
2560 2011-11-25 Ben Konrath <ben@bagu.org>
2562 Don't use Strings to hold primary key values.
2564 The primary key values are now held in a new data object
2565 (PrimaryKeyItem) that holds type information and the primary key value
2566 using the correct type.
2568 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2569 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2571 PrimaryKeyItem instead of String to hold the primary key value.
2572 * src/main/java/org/glom/web/client/Utils.java: Remove
2573 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2574 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2575 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2576 PrimaryKeyItem instead of String to hold the primary key value. Load
2577 document selection page when the documentID has not been set correctly.
2578 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2579 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2581 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2582 Return empty string for URL instead of "null".
2583 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2584 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2585 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2586 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2587 PrimaryKeyItem instead of String to hold primary key values.
2588 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2589 PrimaryKeyValue to a Gda Value.
2590 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2591 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2592 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2593 Replace temporary database access code that uses the PrimaryKeyValue to
2594 Gda Value conversion.
2595 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2596 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2597 PrimaryKeyItem instead of String.
2598 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2599 hold primary key values.
2601 2011-11-24 Ben Konrath <ben@bagu.org>
2603 Use newly added java-libglom API to create queries.
2605 This isn't finished. I still need to stop using Strings for primary key
2606 values in the client code.
2608 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2609 libglom to use fake connections so that retrieving the query string will
2611 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2612 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2613 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2614 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2615 Use the newly added libglom sql methods and classes to create the
2616 query. Add temporary hack to convert primary value strings to Gda
2619 2011-11-23 Ben Konrath <ben@bagu.org>
2621 Don't explicitly set the height of Portals.
2623 See comments 6 - 10 of this bug for details:
2625 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2627 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2629 2011-11-23 Ben Konrath <ben@bagu.org>
2631 Use an HTML table instead of CSS for the FlowTable layout.
2633 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2634 GWT's FlexTable to implement the FlowTable.
2635 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2637 2011-11-18 Ben Konrath <ben@bagu.org>
2639 Add boolean example to HTML table mockup.
2641 * mockups/details-view-html-tables-text-entries.html:
2643 2011-11-17 Ben Konrath <ben@bagu.org>
2645 Ensure the pager buttons are always visible for related lists.
2647 To accomplish this, I've turned off text wrapping in the list view and
2648 related list tables for both the header and data text. The related list
2649 table now has a fixed layout so the it doesn't overflow its container.
2650 This is required to ensure that the cell text is clipped when it
2651 overflows the cell and an ellipsis is added to the right side of the
2652 cell when text is clipped.
2654 A fixed table layout for the related list table in the details view
2655 seems what we want for the details view anyway, so the side-effect is
2658 The ellipsis will only be displayed in Firefox >= 7.
2662 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2664 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2665 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2666 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2668 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2669 Set the 'table-layout: fixed' CSS property to the related list table.
2670 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2671 'white-space: nowrap;' CSS property on both the list view and the
2672 related list tables.
2674 2011-11-16 Ben Konrath <ben@bagu.org>
2676 Rework the fix for empty notebook tab labels.
2678 Setting the empty group titles with its name caused problems for the
2679 details layout. Instead of using libglom's
2680 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2681 to the client when the title is empty. This allows the Notebook to use
2682 the name when the title is empty without affecting anything else.
2684 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2685 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2687 2011-11-16 Ben Konrath <ben@bagu.org>
2689 Set group titles with name when title is empty.
2691 This fixes a problem with an empty notebook tab label in the Lesson
2692 Planner document. The forth tab in the notebook should be "Internet":
2694 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2696 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2697 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2700 2011-11-16 Ben Konrath <ben@bagu.org>
2702 Remove whitespace from the configured username properties.
2704 This assumes that usernames won't have whitespace at the beginning
2705 or end. But I think this is a reasonable assumption.
2707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2708 String.trim() to remove the whitespace from the username properties.
2710 2011-11-15 Ben Konrath <ben@bagu.org>
2712 Add details view mockup with HTML tables and text entries.
2714 This is from the attachment on this bug:
2716 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2718 * mockups/details-view-html-tables-text-entries.html:
2720 2011-11-15 Ben Konrath <ben@bagu.org>
2722 Add space between the columns of the flow table.
2726 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2728 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2729 space between columns in the flow table.
2731 2011-11-15 Ben Konrath <ben@bagu.org>
2733 Add backup files to the .gitignore.
2735 * .gitignore: Ignore files that end with ~.
2737 2011-11-09 Ben Konrath <ben@bagu.org>
2739 Use latest release of gwt-log.
2741 Gwt-log releases are now being submitted to the maven central
2742 repository so manual installation of the jar is no longer required.
2744 * pom.xml: Update version and groupId of gwt-log dependency.
2746 2011-10-31 Ben Konrath <ben@bagu.org>
2748 Don't use GWT numeric formatting to override the glom currency formatting.
2750 Currencies are now displayed like they are in Glom. See this bug:
2752 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2754 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2756 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2757 currency code to constructor and set it when the cell is rendered.
2758 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2759 currency code to the constructor of the NumericCell.
2761 2011-10-27 Ben Konrath <ben@bagu.org>
2763 Require the latest release of java-libglom (1.17.4).
2767 2011-10-26 Ben Konrath <ben@bagu.org>
2769 Add style to Notebook that matches current theme.
2771 It's not the best style in the world but it's better than the default.
2773 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2774 padding at the bottom of the child widgets.
2775 * src/main/webapp/style.css: Add style for the Notebook.
2777 2011-10-26 Ben Konrath <ben@bagu.org>
2779 Move servlet initialization code to overridden init method.
2781 This is half of the solution to getting proper error messages
2782 displayed when configuration errors occur. Here's the relevant bug:
2784 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2786 The rest of the solution involves surrounding the init method with a
2787 try/catch block and setting a global variable with the error /
2788 exception. A new async method should be created to retrieve and display
2789 the error message / exception.
2791 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2792 code from constructor to init method adding exceptions as needed.
2794 2011-10-26 Ben Konrath <ben@bagu.org>
2796 Add script to monitor and restart tomcat if required.
2798 * utils/check-and-recover-tomcat.py: New file.
2800 2011-10-26 Ben Konrath <ben@bagu.org>
2802 Display the correct number of data items in the pager.
2806 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2808 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2809 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2810 The implementation is the same for both tables: Keep track of the
2811 number of non-empty rows and fire and RowCountChangeEvent after the data has
2813 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2814 custom Pager class that subclasses SimplePager to handle displaying
2815 the correct number when empty rows have been added.
2817 2011-10-26 Ben Konrath <ben@bagu.org>
2819 Correct error in previous commit.
2821 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2822 eventBus parameter from listView.setCellTable().
2824 2011-10-26 Ben Konrath <ben@bagu.org>
2826 Fix error in TODO comment.
2828 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2830 2011-10-24 Ben Konrath <ben@bagu.org>
2832 Create Notebook widgets to the details view.
2834 This isn't finished just yet - I still need to create a reasonable
2835 style to match the current theme.
2837 * src/main/java/org/glom/web/client/Utils.java: Add method for
2838 calculating the height of a widget. This is used in the Notebook class.
2839 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2840 new constructor method in Group.
2841 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2842 method for creating child widget that can be used by subclasses
2843 like Notebook. New constructor that allows disabling the group
2844 titles - Notebooks don't set a group title for their child groups.
2845 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2846 to make Notebooks using GWT's TabLayoutPanel.
2847 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2848 constructor that allows disabling the group titles.
2849 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2850 LayoutItemNotebook DTO.
2851 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2852 DTO for Notebooks. It's just an empty class for now but we might need
2853 it to transfer some specific information in the future.
2855 2011-10-21 Ben Konrath <ben@bagu.org>
2857 Add navigation buttons to related list tables.
2859 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2860 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2862 method getSuitableRecordToViewDetails() for getting the table name
2863 and primary key value for related list navigation buttons.
2864 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2865 private cell renderer class to get the navigation information for
2866 related list tables from the server. Extract the navigation
2867 processing code from the details cell navigation and use it for the
2868 related list navigation as well.
2869 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2870 cell renderer class for the details open buttons. This was needed
2871 because the related list navigation buttons and the list view
2872 navigation buttons need to react differently when clicked.
2873 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2874 the onEnterKeyDown() method because it's now overriden in the
2875 subclasses that are specific to the related list tables and the list
2877 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2878 the vertical size a little because the buttons add a bit of vertical
2879 space to table. This is not a perfect solution because the vertical
2880 size of with table fewer than 5 rows will be a little smaller.
2881 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2882 changes in how navigation buttons are handled.
2883 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2884 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2885 database access object.
2886 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2887 to find the portal for a given relationship name from
2888 RelatedListDBAccess. Add method to find a primary key field for a
2890 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2891 Move code to find the portal for a given relationship name to
2893 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2894 New file: database access object for getting the related list
2895 navigation information (the table name and the primary key value).
2896 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2897 DTO for transferring a table name to navigate to and a primary key
2899 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2900 boolean and getter/setter to specifies if the related list should add
2903 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2905 Use the master branch of java-libglom
2907 * pom.xml: Depend on java-libglom 1.19 instead.
2909 This is the master branch. See also the libglom-1-18 branch.
2911 2011-10-11 Ben Konrath <ben@bagu.org>
2913 Enable the open navigation button when the data has been set.
2915 This avoids having active buttons that don't do anything when the data
2918 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2920 2011-10-11 Ben Konrath <ben@bagu.org>
2922 Use IsWidget interface for FlowTableItem.
2924 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2925 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2927 2011-10-11 Ben Konrath <ben@bagu.org>
2929 Remove GWT styling from open button in details view.
2931 There are still some issues with how the details cell is arranged but
2932 this should be made to match Glom 1.20. I'm going to leave fixing this
2933 until I have Glom 1.20 up and running.
2935 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2936 style name on open button.
2937 * src/main/webapp/style.css: Move and edit details-navigation class.
2938 Re-arrange some classes to make them appear in the same order as the
2941 2011-10-07 Ben Konrath <ben@bagu.org>
2943 Update to GWT 2.4.0.
2945 * .gitignore: Ignore new cache directory.
2946 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2947 * pom.xml: Change GWT and maven plugin to 2.4.0.
2948 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2950 * src/main/java/org/glom/web/client/ClientFactory.java:
2951 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2952 * src/main/java/org/glom/web/client/OnlineGlom.java:
2953 Update source for API changes.
2954 * utils/build-onlineglom-war.sh: Remove cache directory before the
2957 2011-10-07 Ben Konrath <ben@bagu.org>
2959 Add navigation buttons in the details view.
2961 This isn't finished but I thought I'd commit what I have as it's a
2962 pretty good start. I still need to:
2964 1. Change the style so that it fits better into the current theme
2965 2. Adjust the details cell to expand as much as possible.
2967 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2968 click handlers to navigation buttons in the DetailsCells. Create a
2969 refreshData() method to get just the data from the server without the
2971 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2972 Update the tableSelector and browser title when the table name
2973 changes without using the tableSelector.
2974 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2975 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2976 getDetailsCells() to getCells(). Update variable names.
2977 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2978 method to set click handler on navigation button. Rename a few
2979 variables. Add navigation buttons where needed.
2980 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2981 variables and methods.
2982 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2983 navigation boolean and navigation table as required in the
2984 LayoutItemField DTO.
2985 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2986 variables for navigation along with getter/setter methods.
2988 2011-10-07 Ben Konrath <ben@bagu.org>
2990 Rename Field to DetailsCell.
2992 This is a refactor-only commit. No functionality has been added or
2995 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2996 Update variable and method names.
2997 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2998 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2999 variable and method names.
3000 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3002 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3003 variable and method names.
3005 2011-10-07 Ben Konrath <ben@bagu.org>
3007 Create separate methods for layout and data the details view.
3009 This is a refactor-only commit. No functionality has been added or
3012 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3013 private methods: setData(), createLayout().
3015 2011-10-07 Ben Konrath <ben@bagu.org>
3017 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3019 This is part of a change to get navigation buttons in the details view
3020 but it should have been done this way from the start.
3022 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3023 for method name change in TableSelectionView.
3024 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3025 Create TableChangeEvent and set the browser title using the
3026 TableSelectionView API.
3027 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3028 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3029 Change getSelectedTable() to getSelectedTableName(). Add
3030 getSelectedTableTitle().
3032 2011-10-07 Ben Konrath <ben@bagu.org>
3034 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3036 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3038 2011-10-07 Ben Konrath <ben@bagu.org>
3040 Update TableChangeEvent to use newTableName naming convention.
3042 This makes the class more consistent with GWT naming conventions.
3044 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3045 Update for method name change in TableChangeEvent.
3046 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3047 for method name change in TableChangeEvent.
3048 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3049 newTableName variable and getter method. Make toDebugString()
3052 2011-09-30 Ben Konrath <ben@bagu.org>
3054 Disable the pager in the list tables when the data row count is less than the minimum.
3056 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3057 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3059 2011-09-30 Ben Konrath <ben@bagu.org>
3061 Add empty rows to the end of related list and list view tables.
3063 I also extracted the cell rendering classes from the ListTable because
3064 the code was becoming a little crazy with all the anonymous inner
3065 classes. My plan is to use these cell rendering classes in the details
3066 view as well so this refactor will be needed for that change.
3068 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3069 set the row count in related list tables if the data has more rows
3070 than the minimum number of rows visible.
3071 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3072 row count in list view tables if the data has more rows than the
3073 minimum number of rows visible.
3074 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3075 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3077 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3078 for rendering TYPE_NUMERIC cells. The code was extracted from the
3080 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3081 class for rendering cells with buttons in list views. The code was
3082 extracted from the ListTable class.
3083 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3084 for rendering TYPE_TEXT cells. The code was extracted from the
3086 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3087 Add empty rows to the end of the data if required. Implement
3088 ListTable.getMinNumVisibleRows().
3089 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3090 cell renderer code to public classes. Return null in
3091 Column.getValue() for empty rows. Add new abstract method:
3092 getMinNumVisibleRows(). Move code to set the row count of the list view
3093 table to ListViewImpl.
3094 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3095 empty rows to the end of the data if required. Implement
3096 ListTable.getMinNumVisibleRows().
3099 2011-09-27 Ben Konrath <ben@bagu.org>
3101 Use GWT.log for client-side debugging statements.
3103 These are optimized out when deployed so I should have used this method
3104 in the first place. These statements will eventually be replaced with some sort
3105 of notification in the browser.
3107 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3108 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3109 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3110 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3111 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3113 2011-09-27 Ben Konrath <ben@bagu.org>
3115 Put tableselector on the right, back to list link on right.
3117 The idea is that the table selector is acting like a label for the
3118 currently displayed table so it should be placed below the document title. This
3119 puts the table title in a similar position to where it is in Glom.
3121 * mockups/details-contacts.html:
3122 * mockups/details-projects.html:
3123 * mockups/listview-contacts.html:
3124 * mockups/listview-projects.html:
3125 * mockups/style.css:
3126 Update mockups to match how the interfaces currently look.
3127 * src/main/webapp/style.css: Swap positions of backlink with the table
3128 selector. Add some space on the left side of the table selector to
3129 line things up with the document title.
3131 2011-09-27 Ben Konrath <ben@bagu.org>
3133 Add field colouring to details view.
3135 This change re-works how field colouring works. The colour formatting
3136 information is now set to the client with the layout information instead of
3137 with the data. This eliminates the need to send the same colour strings for
3138 data in list view column when colour information is set.
3140 In order to set an alternate colour for negative numeric values, the
3141 number is now sent to client and formatted with the GWT NumberFormat class.
3143 This change also fixes:
3145 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3147 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3148 internationalization framework which is needed for client side numeric
3150 * src/main/java/org/glom/web/client/Utils.java: New file for some
3151 client static utility methods.
3152 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3153 the DataItem object to the Field class. Use a utility method to
3154 create the foreignKeyValue string.
3155 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3156 alignment and text colours in the constructor. Add setData(DataItem)
3157 method. Remove setText(String) method.
3158 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3159 colour information to GlomTextCell. Create and use GlomNumberCell for
3160 rendering numbers. Use utility method to get the string for the
3161 primary key of the key provider. Re-work how the horizontal alignment
3163 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3164 formatting to layout information. Methods for converting the libglom
3165 formatting information were moved from DBAccess.
3166 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3167 numeric formatting (it's now done on the client side). Don't set text
3168 colours in DataItem. Move libglom formatting conversion methods to
3170 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3171 getters/setters for text colour information.
3172 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3173 for transferring the libglom NumericFormat information to the client.
3174 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3175 and getters/setters for: GlomNumericFormat, background colour and
3176 foreground colour strings.
3178 2011-09-26 Ben Konrath <ben@bagu.org>
3180 Simplify code that iterates through the LayoutGroup.
3182 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3184 2011-09-26 Ben Konrath <ben@bagu.org>
3186 Accept Eclipse formatting for OnlineGlomServiceAsync.
3188 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3190 2011-09-26 Ben Konrath <ben@bagu.org>
3192 Don't use the ListDBAccess classes to get the primary key layout information.
3194 This was causing a bug where the wrong index for the hidden primary key
3195 was being sent to the client.
3197 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3198 primary key while creating the LayoutGroup DTO. Create a
3199 LayoutItemField DTO for hidden primary keys. Don't use the
3200 RelatedListDBAccess because it was only used for getting the primary
3202 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3203 access modifier from public to protected for getPrimaryKeyField() and
3204 getPrimaryKeyLayoutItemField().
3205 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3206 abstract method getExpectedResultSize() because RelatedListDBAccess
3207 doesn't have enough info to implement it.
3208 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3209 Remove @Override for getExpectedResultSize().
3210 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3211 Remove method getExpectedResultSize().
3213 2011-09-23 Ben Konrath <ben@bagu.org>
3215 Log which layout (list or details) the ignored item is from.
3217 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3219 2011-09-23 Ben Konrath <ben@bagu.org>
3221 Remove annotations that turn off code formatting in DataItem.
3223 * src/main/java/org/glom/web/shared/DataItem.java:
3225 2011-09-23 Ben Konrath <ben@bagu.org>
3227 Rename GlomField to DataItem and update associated methods.
3229 This is a rename-only refactor. No functionality has been added or
3232 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3233 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3235 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3236 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3237 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3238 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3239 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3241 * src/main/java/org/glom/web/server/database/DBAccess.java:
3242 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3243 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3244 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3245 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3246 * src/main/java/org/glom/web/shared/DataItem.java:
3247 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3248 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3250 2011-09-23 Ben Konrath <ben@bagu.org>
3252 Rename GlomDocument to DocumentInfo and update associated methods.
3254 This is a rename-only refactor. No functionality has been added or
3257 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3258 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3259 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3260 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3261 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: