1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
5 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
6 when using the Google -> GWT Compile, or
7 g toolbar button -> GWT Compile Project... feature in Eclipse.
9 2012-05-06 Murray Cumming <murrayc@murrayc.com>
11 ListTable.addColumn(): Protect against a null Formatting.
13 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
14 Create a default Formatting if it is null, because that is the simplest
17 2012-05-06 Murray Cumming <murrayc@murrayc.com>
19 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
21 * src/main/java/org/glom/web/server/ConfiguredDocument.java
22 updateLayoutGroup(): Check that the field is not null.
24 2012-05-06 Murray Cumming <murrayc@murrayc.com>
26 ListViewImpl: Protected against a bad cast error.
28 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
29 onEnterKeyDown(): Do not cast without an instanceof check.
31 2012-05-06 Murray Cumming <murrayc@murrayc.com>
33 ListTable: Protect against an out of range error.
35 * src/main/java/org/glom/web/client/ui/list/ListTable.java
36 createCellTable(): This is unlikely, but can happen while debugging.
38 2012-05-06 Murray Cumming <murrayc@murrayc.com>
40 AsyncMessage onFailure() callbacks: Log the exception message.
42 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
43 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
44 * src/main/java/org/glom/web/client/activity/ListActivity.java:
45 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
46 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
47 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
48 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
49 These are useful clues when something is wrong.
51 2012-05-06 Murray Cumming <murrayc@murrayc.com>
53 ConfiguredDocument: Avoid a null dereference.
55 * src/main/java/org/glom/web/server/ConfiguredDocument.java
56 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
57 details maps are created.
59 2012-05-06 Murray Cumming <murrayc@murrayc.com>
61 Document: Correct the port number parsing.
63 * src/main/java/org/glom/web/server/libglom/Document.java:
64 This lets us actually connect to the database and show the document.
66 2012-05-05 Murray Cumming <murrayc@murrayc.com>
70 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
71 user-interaction, asking us to load a temporary URL in a browser.s
72 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
73 which is apparently necessary for testing the service. See the comment.
74 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
75 Show the exception, if any. This is how I saw the 404 in the HTML in
78 2012-05-05 Murray Cumming <murrayc@murrayc.com>
80 DocumentTest: Move the .glom files into the resources directory.
82 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
83 URI via getResource().
85 2012-05-05 Murray Cumming <murrayc@murrayc.com>
87 Document: Remove the FieldIdentifies inner class.
89 * src/main/java/org/glom/web/server/libglom/Document.java: We only
90 use the Relationship (though the same function in libglom is maybe
91 used in other ways) and so this removes a compiler warning.
93 2012-05-05 Murray Cumming <murrayc@murrayc.com>
95 Document.load() Remove the error code parameter.
97 * src/main/java/org/glom/web/server/libglom/Document.java: load():
98 Remove the parameter. We do not set it yet and it could never have
99 worked as an output parameter (though maybe it did in java-libglom).
100 We could use an exception if we really want the failure reason.
101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
103 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
104 setUp(), testGetSuitableTableToViewDetails(): Adapt.
106 2012-05-05 Murray Cumming <murrayc@murrayc.com>
108 Make some inner classes static.
110 * src/main/java/org/glom/web/server/ConfiguredDocument.java
111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
112 * src/main/java/org/glom/web/server/ReportGenerator.java
113 * src/main/java/org/glom/web/server/libglom/Document.java
114 Make all inner classes static that can be static.
116 2012-05-05 Murray Cumming <murrayc@murrayc.com>
118 OnlineGlomServiceImpl: Do not load and check for java-libglom.
120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
121 init(): We do not use java-libglom any more.
123 2012-05-05 Murray Cumming <murrayc@murrayc.com>
125 Remove mentions of java-libglom.
127 * README: Remove mention of java-libglom, because it no longer needed.
128 * utils/build-onlineglom-war.sh:
129 * utils/check-and-recover-tomcat.py:
130 * utils/install-onlineglom-war.sh: Remove these as they are no longer
131 useful. Building is now far easier, with no need for jhbuild.
133 2012-05-05 Murray Cumming <murrayc@murrayc.com>
135 Fix the build (mvn package)
137 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
138 (LayoutGroup): Make the LayoutItemList inner class static and protected.
139 Otherwise the GWT Java->Javascript compilation fails with just this
140 error, during mvn package or when attempting to view in a browser,
141 in the GWT developer mode in Eclipse.
143 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
144 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
145 [INFO] Compiling module org.glom.web.OnlineGlom
146 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
147 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
148 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
149 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
150 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
151 [INFO] [ERROR] Cannot proceed due to previous errors
153 It has taken me 2 days to find out what was causing that. After reducing
154 the code, the compiler eventually showed me the full error message.
156 2012-05-04 Murray Cumming <murrayc@murrayc.com>
158 ConfiguredDocument: Cache the cloned and stripped layouts.
160 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
161 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
162 layout in a map, so we can retrieve it again without rebuilding it.
164 2012-05-04 Murray Cumming <murrayc@murrayc.com>
166 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
168 2012-05-04 Murray Cumming <murrayc@murrayc.com>
170 libglom classes: Implement some auto-generated emthods.
172 2012-05-04 Murray Cumming <murrayc@murrayc.com>
174 Add GwtTestOnlineGlomService.
176 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
177 However, this (and the other GwtTest*) does not seem to run during
180 2012-05-04 Murray Cumming <murrayc@murrayc.com>
182 Remove use of unsupported features from client code.
184 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
185 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
186 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
187 Use our client version of StringUtils instead of the apache commons one.
189 However, the GWT Javascript compliation still fails.
191 2012-04-25 Murray Cumming <murrayc@murrayc.com>
193 Add a Field class and implement some loading of it in Document.
195 2012-04-25 Murray Cumming <murrayc@murrayc.com>
197 Initial Document loading implementation, instead of libglom.
199 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
200 and Translatable classes, and adapt the rest of the code to use them.
201 However, this is still missing Layout and Field classes and loading.
203 2012-04-24 Murray Cumming <murrayc@murrayc.com>
205 Use of jOOQ: Move Field creation into a utility method.
207 * src/main/java/org/glom/web/server/SqlUtils.java:
208 This lets us improve it more easily.
210 2012-04-24 Murray Cumming <murrayc@murrayc.com>
212 Use of jOOQ: Improve the code to COUNT a sub-select.
214 * src/main/java/org/glom/web/server/SqlUtils.java:
215 Move initial query creation into
216 build_sql_select_step_with_where_clause().
217 build_sql_select_count_rows(): Use the jOOQ API instead of
218 concatentating text, because a jOOQ Select*Step is a TableLike,
219 which is what from() takes.
221 2012-04-23 Murray Cumming <murrayc@murrayc.com>
223 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
225 * pom.xml: Depend on jooq.
226 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
227 methods with jOOQ, based on the C++ implementations in libglom,
228 with some changes to the logic required by jooQ.
229 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
231 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
232 * src/main/java/org/glom/web/server/ReportGenerator.java:
233 * src/main/java/org/glom/web/server/SqlUtils.java:
234 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
235 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
236 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
237 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
238 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
239 Adapt. In particular, the SqlUtils methods now need to take a Connection,
240 because jOOQ needs that, though it seems unnecessary.
242 This is not quite finished. Ideally jOOQ would help us to build
243 table_name.field_name names, quoting and escaping them properly.
244 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
246 2012-04-21 Murray Cumming <murrayc@murrayc.com>
248 Move use of Glom.build_sql*() into a new SqlUtils class.
250 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
251 to wrap Glom.build_sql*(). The parameter types are still Glom one,
252 but this will make it easier to start using something other than
253 libglom or SqlBuilder.
255 2012-04-21 Murray Cumming <murrayc@murrayc.com>
257 Update the project URL.
259 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
261 2012-04-21 Murray Cumming <murrayc@murrayc.com>
263 Main layout: Use a FlowTable instead of absolute positioning.
265 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
266 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
267 child panels/widgets must have an absolute position. But that is annoying, so
268 this adds a FlowTable and puts the child panels in there.
270 2012-04-21 Murray Cumming <murrayc@murrayc.com>
272 GwtTestOnlineGlom: Comment out unused code.
274 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
275 Eclipse has started to say that some code is unused.
277 2012-04-21 Murray Cumming <murrayc@murrayc.com>
279 Update to the latest versions of dependencies.
281 * pom.xml: Update version numbers of dependencies to the latest
283 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
285 * src/main/java/org/glom/web/server/ReportGenerator.java:
286 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
287 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
288 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
290 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
291 Modify the imports where necessary.
293 2012-04-17 Murray Cumming <murrayc@murrayc.com>
295 Style: Remove overflow:hidden from searchbox
297 * src/main/webapp/style.css: Because this pushes the Back To Link
298 label/link on to the next row, which is then hidden due to the
299 hard-coded (in ems) height.
301 2012-04-20 Murray Cumming <murrayc@murrayc.com>
303 Remove some duplicate code.
305 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
306 getDocumentInfo(): This must have been duplicated during the merge from the
311 2012-04-19 Murray Cumming <murrayc@murrayc.com>
313 Reports: Localize the waiting for report message.
315 * src/main/java/org/glom/web/client/activity/ReportActivity.java
316 start(): Get the message from the contants.
317 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
319 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
320 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
321 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
322 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
323 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
324 Update these files with the English text for newer strings for now.
326 2012-04-19 Murray Cumming <murrayc@murrayc.com>
328 Reports: Show a message while waiting for the report.
330 * src/main/java/org/glom/web/client/ui/ReportView.java
331 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
332 Add setWaitingText(), to show a message saying that we are
333 waiting for the report to be ready.
334 * src/main/java/org/glom/web/client/activity/ReportActivity.java
335 start(): Call setWaitingText() before calling the async
338 2012-04-19 Murray Cumming <murrayc@murrayc.com>
340 ReportGenerator: Specify date and time formats.
342 * src/main/java/org/glom/web/server/ReportGenerator.java:
343 createFieldValueElement(): Use the default (and localized)
344 short formats, though we still need a way to show 4-digit
345 years without providing the format for every locale.
346 * src/main/java/org/glom/web/server/database/DBAccess.java:
347 convertResultSetToDTO(): Use the short formats here too.
349 2012-04-18 Murray Cumming <murrayc@murrayc.com>
351 ReportGenerator: Use the correct numeric formatting.
353 * src/main/java/org/glom/web/server/ReportGenerator.java
354 createFieldExpression(), createFieldValueElement(): Take the
355 whole LayoutItem_Field instead of just the field name, so
356 we have access to the formatting.
357 createFieldValueElement(): Use JRTextField.setPattern() to
358 specify the numeric formatting, with the help of a
359 regular DecimalFormat.
361 2012-04-18 Murray Cumming <murrayc@murrayc.com>
363 ReportGenerator: Avoid showing null for group by titles.
365 * src/main/java/org/glom/web/server/ReportGenerator.java
366 generateReport(): Use setBlankWhenNull() on the field title
367 style too, because this is used for values in group by
370 2012-04-18 Murray Cumming <murrayc@murrayc.com>
372 ReportGenerator: Add a colon to titles in vertical groups.
374 * src/main/java/org/glom/web/server/ReportGenerator.java
375 addFieldToDetailBandVertical(): Pass true for the withColon
378 2012-04-18 Murray Cumming <murrayc@murrayc.com>
380 ReportGenerator: Simplify the code by using Position more.
382 2012-04-18 Murray Cumming <murrayc@murrayc.com>
384 Reports: Support vertical groups, roughly.
386 * src/main/java/org/glom/web/server/ReportGenerator.java:
387 addToReport(): Rename to addGroupToReport() and, if necessary,
388 call the new addVerticalGroupToReport() method.
389 createFieldValueElement(): Let the caller specify the Y position
392 2012-04-17 Murray Cumming <murrayc@murrayc.com>
394 Reports: Allow a second report to be shown.
396 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
397 clear(): Do not remove the HTML widget, which broke the whole layout.
399 2012-04-17 Murray Cumming <murrayc@murrayc.com>
401 Locales drop-down: Show that we use English by default.
403 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
404 fillView(): When we use English, just because that is the default, when
405 no locale is specified, show that in the Locales drop-down instead of
406 just showing the first item.
408 2012-04-17 Murray Cumming <murrayc@murrayc.com>
410 Unselect the Report/Locale/Table combo item when appropriate.
412 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
413 setPlace(): clear reportName if this is not a ReportPlace.
414 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
415 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
416 When the provided name is empty, unselect all items, so that none are
417 indicated. This uses a for loop because I cannot find a single method
420 2012-04-17 Murray Cumming <murrayc@murrayc.com>
422 Report: Give the user a way to get back to the list.
424 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
425 start(), setPlace(): Show the Back To List link on reports, and also
426 interpret selecting the empty report item as back to list.
428 2012-04-13 Murray Cumming <murrayc@murrayc.com>
430 Really show the selected Report name.
432 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
433 setPlace(): Store the reportName here, if it is that kind of Place.
434 fillView(): Set the selected Report after filling the list of reports.
435 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
436 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
437 null Strings, though we need some way to unselect all ListBox items
440 2012-04-13 Murray Cumming <murrayc@murrayc.com>
442 ReportGenerator: Try to avoid some problems.
444 * src/main/java/org/glom/web/server/ReportGenerator.java
445 addField(): Try to avoid duplicates, and avoid using a null
448 2012-04-13 Murray Cumming <murrayc@murrayc.com>
450 Reports: Use quickFind.
452 * src/main/java/org/glom/web/client/OnlineGlomService.java;
453 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
455 getReportHTML(): Add a quickFind parameter.
456 * src/main/java/org/glom/web/client/activity/ReportActivity.java
457 start(): Pass the quickFind parameter.
458 * src/main/java/org/glom/web/server/ReportGenerator.java
459 generateReport(): Take a quickFind parameter.
461 2012-04-13 Murray Cumming <murrayc@murrayc.com>
463 ReportPlace: Actually use the report name.
465 * src/main/java/org/glom/web/client/place/ReportPlace.java
466 getPlace(): Do not assign the report name to the quickfind.
468 2012-04-13 Murray Cumming <murrayc@murrayc.com>
470 Show java.library.path when complaining.
472 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
473 init(): When telling us to check java.library.path, show the
476 2012-03-06 Murray Cumming <murrayc@murrayc.com>
478 ReportGenerator: Do not show nulls.
480 2012-03-06 Murray Cumming <murrayc@murrayc.com>
482 ReportGenerator: Make the title font larger.
484 2012-03-06 Murray Cumming <murrayc@murrayc.com>
486 ReportGenerator: Put field titles inside groups, if there are groups.
488 2012-03-06 Murray Cumming <murrayc@murrayc.com>
490 ReportGenerator: Take the Report itself instead of the name and group.
492 * src/main/java/org/glom/web/server/ConfiguredDocument.java
493 Remove getReportLayoutGroup().
494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
495 getReportHTML(): Pass the report instead
496 of its name and layout group.
497 * src/main/java/org/glom/web/server/ReportGenerator.java
498 generateReport(): Use the report object to use the title
501 2012-03-06 Murray Cumming <murrayc@murrayc.com>
503 ReportGenerator: Remove designBand parameters.
505 * src/main/java/org/glom/web/server/ReportGenerator.java:
506 Make designBand a class member instead of passing it to all
509 2012-03-06 Murray Cumming <murrayc@murrayc.com>
511 ReportGenerator: Add lines, a bit like in the desktop version.
513 * src/main/java/org/glom/web/server/ReportGenerator.java
514 addToReport(): Use JRDesignLine.
516 2012-03-06 Murray Cumming <murrayc@murrayc.com>
518 ReportGenerator: Correct the title positions and use some bold style.
520 * src/main/java/org/glom/web/server/ReportGenerator.java:
521 Break the code up into reusable functions, correct the placement of
522 titles, and use normal/bold styles as in the reports in the desktop
525 2012-03-06 Murray Cumming <murrayc@murrayc.com>
527 ReportGenerator: Add a header band to show the field titles.
529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
530 getReportHTML(): Pass the localeId to the ReportGenerator
532 * src/main/java/org/glom/web/server/ReportGenerator.java
533 constructor: Take the localeID so we can get translated field
535 generateReport(), addToReport(), addFieldToBand(): Add field
536 titles in a column header band.
538 2012-03-05 Murray Cumming <murrayc@murrayc.com>
540 Reports drop-down list: Some improvement.
542 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
543 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
544 Adedd setSelectedReport(),
545 setReportList(): Add a blank line so that the user can select the
547 * src/main/java/org/glom/web/client/activity/ReportActivity.java
548 start(): Show the current report by calling setSelectedReport().
549 This does not seem to work yet.
551 2012-03-05 Murray Cumming <murrayc@murrayc.com>
553 DetailsActivity, ListActivity: Move some variables into a base class.
555 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
556 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
557 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
558 the clientFactory, documentID, tableName and authenticationPopup into
559 a base class, to avoid duplication.
561 2012-03-05 Murray Cumming <murrayc@murrayc.com>
563 Translate the Reports label.
565 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
566 Get the "Reports" label string from the constants.
567 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
568 perties: Add Reports to the constants.
570 2012-03-05 Murray Cumming <murrayc@murrayc.com>
572 Reports: Implement grouping.
574 * src/main/java/org/glom/web/server/ReportGenerator.java:
575 Handle LayoutItem_GroupBy items and try to do the right thing
576 with JRDesignGroup. It seems to work.
578 2012-03-04 Murray Cumming <murrayc@murrayc.com>
580 Actually show some data with JasperReports.
582 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
583 getReportHTML(): Move most code into a ReportGenerator class.
584 * src/main/java/org/glom/web/server/ReportGenerator.java:
585 Recurse into sub-groups, adding fields to the JasperDesign's details
586 band. Note that we must set an arbitrary width and height, or it just
587 will not show any data.
589 2012-03-04 Murray Cumming <murrayc@murrayc.com>
591 Reports Chooser: Show the titles, not the names.
593 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
594 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
595 and the names as the values.
596 * src/main/java/org/glom/web/server/ConfiguredDocument.java
597 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
598 group now that we provide the report name, so it should always
601 2012-02-15 Murray Cumming <murrayc@murrayc.com>
603 Depend on jasperreports.
605 * pom.xml: Add the dependency. My plan is to use this on the
608 2012-01-31 Murray Cumming <murrayc@murrayc.com>
610 Implement navigation to report places.
612 * src/main/java/org/glom/web/client/activity/ReportActivity.java
613 start(): Do not bother to handle all events here.
614 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
615 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
616 Added getSelectedReport().
617 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
618 .java: start(): When handling a change to the reports chooser,
619 call getSelectedReport() and goTo() its ReportPlace.
620 * src/main/java/org/glom/web/client/ui/ReportView.java
621 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
622 Added setReportHTML() which puts the html in a gwt HTML widget.
623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
624 getReportHTML(): Return "TODO" just to show that this works.
626 2012-01-31 Murray Cumming <murrayc@murrayc.com>
628 Make ReportPlace usable.
630 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
632 * src/main/java/org/glom/web/client/place/ReportPlace.java:
633 Correct the @prefix annotation.
635 2012-01-31 Murray Cumming <murrayc@murrayc.com>
637 OnlineGlomService: Return report HTML rather than the LayoutGroup.
639 * src/main/java/org/glom/web/client/OnlineGlomService.java:
640 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
642 Change getReportLayout() to getReportHMTL() because we will not need to
643 parse or render the report layout on the client side.
644 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
645 getReportLayout(): Return the libglom LayoutGroup type because we will
646 not need to convert to a shared type, because this will not be used on
648 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
651 Note that there is still no implementation for this.
654 2012-01-27 Murray Cumming <murrayc@murrayc.com>
656 Add a (empty) Report Place, View, and Activity.
658 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
660 * src/main/java/org/glom/web/client/place/HasTablePlace.java
661 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
662 this into a superclass:
663 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
664 and also use it as the base of this new ReportPlace:
665 * src/main/java/org/glom/web/client/place/ReportPlace.java
667 * src/main/java/org/glom/web/client/ui/ReportView.java
668 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
669 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
670 Add these, containing mostly boiler-plate for now.
672 * src/main/java/org/glom/web/client/OnlineGlomService.java
673 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
674 * src/main/java/org/glom/web/server/ConfiguredDocument.java
675 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
676 Add API to get the LayoutGroup for the report.
678 2012-01-23 Murray Cumming <murrayc@murrayc.com>
680 Add and fill a Reports drop-down list box.
682 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
684 * src/main/java/org/glom/web/client/OnlineGlomService.java:
685 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
687 Added getReports(document, table, localeID), calling
688 ConfiguredDocument.getReports().
689 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
690 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
691 Added setReportsList() and a list widget.
692 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
693 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
698 2012-04-12 Murray Cumming <murrayc@murrayc.com>
700 Translations: Add Esperanto.
702 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
703 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
704 properties: Add this translation because someone took the time to make it.
706 2012-03-15 Murray Cumming <murrayc@murrayc.com>
708 Adapt to the java-libglom 1.21.7 API.
710 * src/main/java/org/glom/web/server/ReportGenerator.java:
711 addToReport(): get_group_secondary_fields() is now
712 get_secondary_fields().
715 2012-03-15 Murray Cumming <murrayc@murrayc.com>
717 Use the latest java-libglom version.
719 * pom.xml: Use java-libglom 1.21.7.
721 2012-03-03 Ben Konrath <ben@bagu.org>
723 Display date and time in details view.
725 https://bugzilla.gnome.org/show_bug.cgi?id=671257
727 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
729 2012-03-05 Murray Cumming <murrayc@murrayc.com>
731 Require the latest java-libglom.
733 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
735 2012-03-04 Murray Cumming <murrayc@murrayc.com>
737 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
739 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
740 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
741 an empty quickfind string. I also corrected libglom to create only
742 empty where clauses for empty quickfind strings, but this avoids the
745 2012-02-24 Ben Konrath <ben@bagu.org>
747 Improve the tabs in the Notebook widget.
751 2012-01-30 Murray Cumming <murrayc@murrayc.com>
753 Translations: Try to translate the strings.
755 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
756 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
757 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
758 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
759 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
760 Take the Open translation from GTK+'s .po files.
761 Take the Details translation from Glom's po files.
762 I have added the other strings to Glom so we can get translations that way:
763 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
765 2012-01-27 Murray Cumming <murrayc@murrayc.com>
767 TableSelectionViewImpl: Put the search label and entry in a div.
769 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
770 Put the search widgets in a FlowTable so that the CSS can be used to
771 style them while keeping them together.
772 * src/main/webapp/style.css: Mention the new div.
774 2012-01-27 Murray Cumming <murrayc@murrayc.com>
776 Translate more strings in more locales.
778 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
779 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
780 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
781 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
782 Translate the "Details" and "Open" string too.
784 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
785 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
786 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
787 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
788 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
789 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
790 Add these new locales as placeholders though they currently contain English.
792 2012-01-27 Murray Cumming <murrayc@murrayc.com>
794 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
796 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
797 Check the ConfiguredDocument* for null before using it.
799 2012-01-26 Murray Cumming <murrayc@murrayc.com>
801 Tell Eclipse about the generated java files.
803 * .classpath: This lets it find OnlineGlomConstants.java.
804 It would be nice if Eclipse just used the maven build files.
806 2012-01-26 Murray Cumming <murrayc@murrayc.com>
808 Prevent a crash when no locale is specified in the URL.
810 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
811 Avoid returning a null string, obtained from
812 Window.Location.getParameter(). This caused a crash when it was
813 later passed to libglom's API.
814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
815 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
816 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
817 guard against future null strings.
819 2012-01-26 Murray Cumming <murrayc@murrayc.com>
821 Use the ?locale= query param instead of the &lang= token param.
823 * src/main/java/org/glom/web/client/place/ListPlace.java
824 * src/main/java/org/glom/web/client/place/DetailsPlace.java
825 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
826 Remove the lang token key and value.
828 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
829 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
830 When the user selects a different locale from the chooser, use
831 Window.Location.assign() to change the URL, which then causes a reload.
833 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
834 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
835 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
836 * src/main/java/org/glom/web/client/activity/ListActivity.java
837 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
838 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
839 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
840 * src/main/java/org/glom/web/client/ui/ListView.java:
841 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
843 Remove localeID member variables and method/constructor parameters, instead
844 using Utils.getCurrentLocaleID() when we need a localID to pass to
847 2012-01-26 Murray Cumming <murrayc@murrayc.com>
849 Internationalize the UI strings.
851 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
852 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
853 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
854 because it is unused. Messages are apparently strings that can have
855 parameters, but we do not need that yet, so Contants will be enough for now.
856 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
857 to say that we support the en and de locales.
858 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
859 The original English strings.
860 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
861 Some German translations of the English strings.
862 The i18n goal then uses the .properties file to generate an
863 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
864 returns an implementation that returns the translated strings.
865 The documentation suggests putting these in src/java/*/client/, but it seems
866 best to put it in src/resources/*/client/.
867 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
868 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
869 instead of hard-coding them.
870 Note that we cannot import OnlineGlomConstants because it does not exist yet,
871 but that does not seem to stop the build, though it confuses Eclipse.
873 You can see the translated string by adding ?locale=de to the URL, like so:
874 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
876 2012-01-24 Murray Cumming <murrayc@murrayc.com>
878 Improve null/empty String checks.
880 * pom.xml: Add a dependency on commons-lang, to use
881 org.apache.commons.lang.StringUtils.
882 * src/main/java/org/glom/web/server/ConfiguredDocument.java
883 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
884 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
885 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
886 Use StringUtils.isEmpty().
888 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
889 StringUtils class with a static isEmpty() function because we
890 cannot use org.apache.commons.lang.StringUtils in client-side
891 GWT code because it (apparently) cannot be compiled to javascript.
892 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
893 * src/main/java/org/glom/web/client/activity/ListActivity.java
894 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
895 * src/main/java/org/glom/web/client/place/DetailsPlace.java
896 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
897 * src/main/java/org/glom/web/client/place/ListPlace.java
898 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
899 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
900 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
901 * src/main/java/org/glom/web/client/ui/details/Group.java
902 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
903 our StringUtils.isEmpty() function.
905 2012-01-24 Murray Cumming <murrayc@murrayc.com>
907 Update to the latest java-libglom API.
909 * pom.xml: Require java-libglom 1.21.4.
910 * src/main/java/org/glom/web/server/ConfiguredDocument.java
911 getDocumentInfo(), getListViewLayoutGroup():
912 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
914 * src/main/java/org/glom/web/server/database/DBAccess.java
915 getFieldsToShowForSQLQueryAddGroup(),
916 getPrimaryKeyLayoutItemField(): Replace get_database_title()
917 with either get_database_title_original() or
918 get_database_title(localeID).
920 2012-01-24 Murray Cumming <murrayc@murrayc.com>
922 ConfiguredDocument: Avoid a null pointer exception.
924 * src/main/java/org/glom/web/server/ConfiguredDocument.java
925 Initialize localeID to "" to avoid returning a null String which
926 causes a crash in java-libglom's swing-generated code.
928 2012-01-23 Murray Cumming <murrayc@murrayc.com>
930 Some simple renaming.
932 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
933 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
934 for localeChooser. This seems more appropriate and is less ambiguous
935 particularly in the .css file.
937 2012-01-23 Murray Cumming <murrayc@murrayc.com>
939 ConfiguredDocument: Rename the localedID private member variable.
941 2012-01-23 Murray Cumming <murrayc@murrayc.com>
943 Adapt to the latest java-libglom API from git master.
945 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
946 libglom now uses only Vector instead of List, which uses add() instead of
949 2012-01-22 Murray Cumming <murrayc@murrayc.com>
951 ConfiguredDocument: Rename the localedID private member variable.
953 2012-01-20 Murray Cumming <murrayc@murrayc.com>
955 Build a source tarball with mvn assembly:single
957 * assembly.xml: Add this file.
958 * pom.xml: Use the maven-assembly-plugin and tell it to use
959 our assembly.xml file.
961 2012-01-19 Murray Cumming <murrayc@murrayc.com>
963 OnlineGlomServiceImpl: Get .glom files recursively.
965 * pom.xml: Depend on commons-io from org.apache.commons.
966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
967 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
968 files recursively, and with the easier filter for the extension.
969 Use org.apache.commons.io.FilenameUtils.removeExtension() to
970 simplify that code too.
972 2012-01-19 Murray Cumming <murrayc@murrayc.com>
974 README: Mention that you must install java-libglom packages separately.
976 But then it works, because java-libglom is now in the central maven
979 2012-01-18 Murray Cumming <murrayc@murrayc.com>
981 locales drop-down: Show the correct selected locale when the URL changes.
983 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
984 .java: setPlace(): Move some code into fillView().
986 2012-01-18 Murray Cumming <murrayc@murrayc.com>
988 locales drop-down: Do not lose the primary key.
990 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
991 start(): onLocaleChange(): Pass the current primary key value,
992 instead of an empty value.
994 2012-01-18 Murray Cumming <murrayc@murrayc.com>
996 locales drop-down: Do not lose the drop-down selection.
998 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
999 .java (TableSelectionActivity.fillView): Set the selected locale
1000 after changing the drop-down items (though we do not really need
1001 to change them just because the locale changes.)
1003 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1005 locales drop-down: Change the tables list when this changes.
1007 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1008 .java: TableSelectionActivity.start(): Move the async table titles
1009 retrieval into a private fillView() method and also call this when
1010 the chosen locale changes.
1011 Note that the document title is not actually translatable yet, but
1012 that is a problem that I should fix soon in libglom.
1014 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1016 Improve the placement of the locales drop-down.
1018 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1019 Put the title and locales drop-down in a div (gwt.FlowTable).
1020 * src/main/webapp/style.css: Add magic css properties to make this work.
1021 Also remove the left margin from the title so that it lines up with the
1024 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1026 locales selector: Show human-readable locale titles.
1028 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1029 getDocumentInfo(): Use java.util.Locale to show a real title of
1030 each locale, in the locale's own language.
1032 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1034 Add a language/locale selector drop-down.
1036 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1037 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1038 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1039 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1040 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1041 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1042 Add a ListBox to show the available locales. Add getLocaleSelector(),
1043 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1044 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1045 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1046 java: Add these classes.
1047 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1048 start(): Fill the locales ListBox. Handle its change event, firing a
1050 setPlace(): Show the selected locale as specified by the URL token.
1051 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1052 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1053 Handle LocaleChangeEvent, going to a new *Place with that locale.
1055 The placement of the ListBox is not pretty, and it currently uses the ID
1056 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1060 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1062 Search box: Show the search text from the URL token.
1064 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1065 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1066 Add setQuickFindText().
1067 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1068 .java: setPlace(): Store the queryText if the place is a ListPlace,
1069 and call TableSelectionView.setQuickFindText().
1071 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1073 Allow use of translations via, for instance, &lang=de in the URL.
1075 * pom.xml: Use the unstable java-libglom 1.21 version.
1077 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1078 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1080 init(): Instead of calling TranslatableItem.set_current_locale()
1081 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1082 However, this is only for default locales, which are not needed to
1083 change the locale in the URL.
1084 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1085 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1086 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1087 layout for a particular locale.
1088 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1089 Add get/setDefaultLocaleID().
1090 getDocumentInfo(), getListViewData(), getRelatedListData(),
1091 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1092 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1093 localeID parameter, so we can get the layout for a particular locale.
1095 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1096 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1097 * src/main/java/org/glom/web/client/place/ListPlace.java:
1098 Parse and construct a lang parameter too.
1100 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1101 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1102 passed to subsequent methods and constructors.
1103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1104 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1105 Store the localeID from the *Place and pass it to other constructors
1106 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1108 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1109 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1110 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1111 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1112 * src/main/java/org/glom/web/client/ui/ListView.java:
1113 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1114 Take localeID parameters and pass them to subsequent constructors and
1115 methods, so that the layout is always retrieved for that locale.
1117 This is rather repetitive.
1119 Note that "" means the original (default) locale of the Glom document,
1120 which is usually English.
1122 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1124 Documents: Remove final keyword to fix startup configuration.
1126 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1127 final keywords on the private member variables because that breaks
1128 the startup, apparently (there are warnings) because it stops them
1129 from being serialized. I added these in the previous commit.
1131 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1133 Documents: Add some final keywords.
1135 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1138 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1140 OnlineGlomServiceImpl: Add to overview comments.
1142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1143 Note that this is where all the document are loaded. They are not
1144 loaded freshly for each page.
1146 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1150 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1151 Add a TextBox for the text of a quick find.
1152 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1154 setBackLink(): Add a String quickFind parameter.
1155 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1156 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1157 to the base interface, because that is how TableSelectionViewImpl is used.
1158 * src/main/webapp/style.css: Add style for the search box and its label.
1160 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1161 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1162 Add these files, based on the existing TableChangeEvent and
1163 TableChangeEventHandlers.
1164 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1165 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1166 a ListPlace() that the user should be taken to.
1167 * src/main/java/org/glom/web/client/activity/ListActivity.java
1168 start(): Handle it here too and adapt the TableChangeEvent handler to
1169 pass the extra "" quickFind parameter to ListPlace.
1170 * src/main/java/org/glom/web/client/place/ListPlace.java:
1171 Constructor: Take an extra String quickFind parameter and store it,
1172 returning it from a new getQuickFind() method.
1173 getToken(): Put the quickFind text in the URL token.
1174 getPlace(): Parse the quickFind text from the URL token.
1175 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1176 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1177 ListPlace constructor.
1178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1179 .java: start(): Add a Change handler for the TableSelectionView's
1180 TextBox (via its base HasChangeHandlers interface), firing the new
1181 QuickFindChangeEvent.
1182 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1183 pass the extra "" quickFind parameter.
1185 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1186 setCellTable(): Add a String quickFind parameter and pass it to
1187 the ListViewTable() constructor.
1188 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1189 setCellTable() in the base interface, because that is how ListViewImpl
1192 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1193 Add a String quickFind member variable.
1194 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1195 Constructor: Add a String quickFind parameter, storing it in the
1196 base ListTable's member variable.
1197 onRangeChanged(): Pass quickFind to the
1198 OnlineGlomServiceAsync.getSortedListViewData() and
1199 OnlineGlomServiceAsync.getListViewData() methods.
1201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1202 getListViewData(), getSortedListViewData(): Add a String quickFind
1203 parameter, passing it to ConfiguredDocument.getListViewData().
1204 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1205 Change getListViewData(), getSortedListViewData() in the base interface,
1206 because that is how OnlineGlomServiceImpl is used, via this:
1207 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1208 Change getListViewData(), getSortedListViewData() here too.
1209 This class can apparently be used to asynchronously call methods on
1210 OnlineGlomService, and GWT seems to implement that after recognizing
1211 just the *Async name convention and the extra AsyncCallback parameters.
1213 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1214 getListViewData(): Add a String quickFind parameter, and pass it to
1215 ListViewDBAccess.getData().
1216 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1217 getListData(): Add a String quickFind parameter and pass it to
1219 getSelectQuery(): Add a String quickFind parameter.
1220 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1221 getSelectQuery(): Add a String quickFind parameter and use it with
1222 Glom.get_find_where_clause_quick() to pass a where_clause to
1223 Glom.build_sql_select_with_where_clause(), to actually filter the
1225 getData(): Add a String quickFind parameter, passing it to getListData().
1226 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1227 va: getData(): Pass an empty string to getListData() for the
1228 quickFind parameter.
1230 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1232 ListTable: Minor change.
1234 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1235 createCellTable(): Make this protected instead of public.
1237 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1239 Many files: Use final for the parameters and use the @override attribute.
1241 2012-01-22 Ben Konrath <ben@bagu.org>
1243 Add anchor links for single line text that starts with http, ftp and www.
1247 2012-01-22 Ben Konrath <ben@bagu.org>
1249 Add ellipsis to single line text in details view.
1253 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1255 Remove all javadoc author tags.
1257 Because they are awkward and meaningless when many people touch
1259 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1261 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1263 Revert the COPYING.LESSER to COPYING rename.
1265 Apparently both should be there if it is LGPL.
1267 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1269 *View: Remove unused imports.
1271 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1272 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1273 * src/main/java/org/glom/web/client/ui/ListView.java:
1274 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1275 Remove unused imports, as suggested by Eclipse.
1277 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1279 Move the *View::Presenter types, and some API into one base View.
1281 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1282 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1283 * src/main/java/org/glom/web/client/ui/ListView.java:
1284 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1285 Presenter, setPresenter() and clear() into a shared base interface,
1286 to avoid the unnecessary duplicate Presenter types and to more clearly
1287 show how the *Views share the same structure, even if they are not
1288 used polymorphically.
1290 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1291 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1293 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1294 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1295 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1297 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1300 Feel free to revert this if there is a good reason for the duplicate
1303 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1305 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1307 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1308 a class member instead of a local variable in the method.
1309 This lets us use it to get the view instances, for use in tests.
1310 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1311 beforeOnlineGlom(): Test some more details of the initial view.
1312 Again, this is not very useful.
1314 To really test gwt-glom we will need to start a local postgresql
1315 instance with local data, like the Glom tests in C++.
1317 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1319 pom.xml: Mention the LGPL license.
1321 * pom.xml: Add a licenses section.
1322 * COPYING.LESSER: Move this to COPYING, which
1323 previously contained the GPL. But gwt-glom is all LGPL.
1325 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1327 Add project information to README and pom.xml.
1329 * README: Add a brief description and mention some mvn
1331 * pom.xml: This extra information shows up in mvn site
1334 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1336 Use the latest java-libglom version.
1338 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1340 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1342 GwtTestOnlineGlom: Test a little more.
1344 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1345 protected rather than private, as suggested by the gwt-test-utils
1347 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1348 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1349 Test the initial visibility of the panels.
1351 However, this is not a very useful test.
1352 And I wonder how we should generally test using this idea for an
1353 activity/places app like ours where the real changes happen implicitly
1354 based on the history token/URL.
1356 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1358 Slight modification to *Mapper comments.
1360 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1361 (DataActivityMapper)
1362 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1364 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1366 Remove comments mentioning GIN because they are just copied from
1367 the example code and are apparently not helpful:
1368 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1369 Also change the mention of a class that is only in the example code.
1371 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1373 GwtTestOnlineGlom test: Minor changes.
1375 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1376 Avoid the long qualified class name and modify the comment
1377 because it is now obvious to me that the mocked class is the only
1378 custom one created via GWT.create().
1380 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1382 Tests: Added the beginnings of a test using gwt-test-utils.
1384 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1385 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1386 which tells gwt-test-utils what class will be tested.
1387 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1388 Add a simple (but empty) test case. One class, used by the OnlineGlom
1389 class, is mocked so that it can be created. However, I am not sure
1390 why only this class needs to be mocked.
1392 Note that mockito seems more popular, and clearer, than easymock,
1393 but I have not got that working yet. It might be a matter of the
1396 This test is run during mvn integration-test.
1398 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1400 Tests: Use junit4-style syntax instead of junit3-style.
1402 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1403 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1404 * src/test/java/org/glom/web/shared/DataItemTest.java:
1405 Use the @Test annotation rather than relying on the test*() prefix.
1406 Also no longer implement TestCase, to avoid triggering support for
1407 the junit3-way, which stops the annotations from working.
1408 Change the imports from import junit.framework.* to
1409 import org.junit.*, which is apparently the new way.
1411 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1413 Added a test for ListPlace token parsing and creation.
1415 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1416 This is much the same as DetailsPlaceTest.
1418 I wonder how we could test the other parts of the *Place API.
1420 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1422 DetailsPlace test: Also test getToken() and recreation via getPlace().
1424 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1425 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1426 recreate it, testing the recreated DetailsPlace for the same parameter
1429 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1431 Use the surefire-report plugin.
1433 * pom.xml: This generates a HTML report about the tests in
1434 target/site/surefire-report.html
1435 when you do mvn surefire-report:report. It seems to be popular/normal.
1437 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1439 Added a test for DetailsPlace.
1441 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1442 Test the getPlace() token parsing.
1444 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1446 Added a first unit test.
1448 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1449 * src/test/java/org/glom/web/shared/DataItemTest.java:
1450 This is a silly test but it is just to get things started. Note that
1451 maven/junit finds the test because it looks in src/test by default.
1453 2011-12-22 Ben Konrath <ben@bagu.org>
1455 Change charsetName to "UTF-8" when replacing line breaks.
1457 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1458 that work in Java (such as "UTF8") will not work when compiled to
1461 This fixes a problem with multi-line details view fields that have hard
1462 line breaks. The "License Text" field on this page demonstrates the
1465 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1467 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1469 2011-12-22 Ben Konrath <ben@bagu.org>
1471 Fix another bug with related list navigation.
1473 I've tested all the navigation buttons in all of the related lists
1474 so things should be good now.
1476 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1478 2011-12-22 Ben Konrath <ben@bagu.org>
1480 Fix a crasher when refreshing the list view with the default table.
1482 This crash will also happen when loading the list view with the default
1483 table from a link or bookmark.
1485 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1486 to the main document selection page when the document id hasn't been
1488 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1489 the main document selection page when the document id hasn't been
1491 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1492 values for the details place when the document id hasn't been set.
1493 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1494 values for the list place when the document id hasn't been set.
1496 2011-12-21 Ben Konrath <ben@bagu.org>
1498 Protect against NPE when glom.document.locale is not in config.
1500 This patch protects against an NPE when glom.document.locale is not in
1501 the config file. This NPE will also happen if glom.document.locale is
1504 The patch also updates the error message to display the class name when
1505 the getMessage() returns null. This was happening when the NPE was
1506 thrown and I had "Configuration Error: null". If an NPE is encountered
1507 with this patch, "Configuration Error: NullPointerException " will be
1510 This commit closes this bug:
1512 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1516 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1518 Rename onlineglom.properties to onlineglom.properties.sample.
1520 * src/main/resources/onlineglom.properties: Rename to:
1521 * src/main/resources/onlineglom.properties.sample:
1522 * src/main/resources/README: And add this file explaining that people
1523 should rename it back when deploying.
1525 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1527 Allow choosing the translation in the .properties file.
1529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1530 init(): Read a glom.document.locale value from the configuration file
1531 and call Glom's TransatableItem::set_current_locale() method.
1532 * src/main/resources/onlineglom.properties: Add a commented-out
1533 example of this new setting.
1535 It would be better to add &lang=de_DE to the URL, but the current
1536 libglom API does not allow us to do this easily. I am working on that.
1538 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1540 Avoid a crash in parsing of token parameters.
1542 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1543 ava: getTokenParams(): Do not crash if a parameter has a key but no
1544 value, and ignore parameters with neither.
1546 2011-12-17 Murray Cumming <murrayc@murayc.com>
1548 History token building/handling: Improve use of token parameters.
1550 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1551 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1552 and buildParamsToken(HashMap), for use by derived classes.
1553 Make the separator private because it is no longer be needed.
1554 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1555 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1556 instead of manual string concatenation.
1557 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1558 of hardcoded indices and awkward splitting code.
1559 * src/main/java/org/glom/web/client/place/ListPlace.java
1560 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1561 instead of manual string concatenation.
1562 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1563 of hardcoded indices and awkward splitting code.
1564 This should fix bug #666420
1566 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1568 Fix a Navgiation->Navigation typo in the code.
1570 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1571 Rename processNavgiation() to processNavigation().
1573 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1575 Fix a seperator->separator typo in the code.
1577 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1578 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1579 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1582 2011-12-15 Ben Konrath <ben@bagu.org>
1584 Cleanup some comments.
1586 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1588 2011-12-14 Ben Konrath <ben@bagu.org>
1590 Replace \n with <br/> for multiline text in the details view.
1592 Vertical scrollbars are added when needed as well.
1594 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1596 2011-12-14 Ben Konrath <ben@bagu.org>
1598 Specify the font for document selection links.
1600 * src/main/webapp/style.css:
1602 2011-12-14 Ben Konrath <ben@bagu.org>
1604 Fix bouncy CellTable while paging.
1606 This doesn't currently work with related list tables in unselected
1609 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1611 2011-12-14 Ben Konrath <ben@bagu.org>
1613 Revamp the appearance of the document selection page.
1615 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1616 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1617 * src/main/webapp/style.css:
1619 2011-12-13 Ben Konrath <ben@bagu.org>
1621 Set navigation button column to the smallest size possible.
1623 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1625 2011-12-13 Ben Konrath <ben@bagu.org>
1627 Change OpenButton nomenclature to NavigationButton.
1629 Using NavigtionButton makes things more generic. Classes, methods and
1630 variables have been changed.
1632 This is a rename-only refactor.
1634 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1635 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1636 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1637 Renamed from OpenButtonCell.
1638 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1639 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1640 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1642 2011-12-12 Ben Konrath <ben@bagu.org>
1644 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1646 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1647 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1648 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1649 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1651 2011-12-12 Ben Konrath <ben@bagu.org>
1653 Update variable names and comments.
1655 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1656 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1658 2011-12-12 Ben Konrath <ben@bagu.org>
1660 Properly initialize numNonEmptyRows variable to zero.
1662 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1663 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1665 2011-12-05 Ben Konrath <ben@bagu.org>
1667 Add latest mockup with HTML tables.
1669 Features of this mockup:
1671 -> HTML table for flowtable
1672 -> HTML table for flowtable column
1673 -> Example of how related lists would look
1674 -> Not using text entries for data items
1676 The current version of Online Glom doesn't use HTML tables for the
1679 This mockup has been sent to the glom-devel mailing list but it's good
1680 to have it here as well.
1682 * mockups/details-view-html-tables.html:
1684 2011-12-05 Ben Konrath <ben@bagu.org>
1686 Remove unnecessary getPrimaryKeyField() method.
1688 getPrimaryKeyFieldForTable(String) has been renamed to
1689 getPrimaryKeyField(String).
1691 * src/main/java/org/glom/web/server/database/DBAccess.java:
1692 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1693 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1695 2011-12-05 Ben Konrath <ben@bagu.org>
1697 Add string representation of TypedDataItem value to conversion error message.
1699 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1700 message was extracted into its own method to avoid duplication.
1702 2011-12-05 Ben Konrath <ben@bagu.org>
1704 Add type checking to navigation primary key value creation.
1706 Create navigation primary key only if the expected type from the Glom
1707 document matches the type returned by the SQL query.
1709 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1711 2011-12-05 Ben Konrath <ben@bagu.org>
1713 Rename a couple of variables in RelatedListNavigation.
1715 This is a rename-only refactor.
1717 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1719 2011-12-05 Ben Konrath <ben@bagu.org>
1721 Move getListLayoutGroup() into getListViewLayoutGroup().
1723 This removes getListLayoutGroup(). It was only being called by
1724 getListViewLayoutGroup().
1726 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1728 2011-12-05 Ben Konrath <ben@bagu.org>
1730 Remove check for LayoutItem_Portal in list table method.
1732 This check is no longer necessary because the method isn't being used
1733 to create the LayoutItemPortal DTO.
1735 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1737 2011-12-05 Ben Konrath <ben@bagu.org>
1739 Properly support related list navigation.
1741 Navigation from the "Repository Analyzer -> Package Scans ->
1742 Dependencies" related table wasn't working because the primary key for
1743 related tables wasn't being set properly. This commit fixes the
1746 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1747 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1748 doesn't set the primary key properly for related list tables.
1749 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1750 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1751 useful for getting the primary key for list view tables and for related
1753 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1754 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1755 Move code to set the primary key for the table from the abstract
1756 ListDBAccess class to ListViewDBAccess as it's only correct for list
1758 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1759 Properly add primary key to related list tables.
1761 2011-12-02 Ben Konrath <ben@bagu.org>
1763 Properly set the horizontal alignment of fields.
1765 This fix is for both the list tables and the details view.
1767 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1768 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1769 to set the horizontal alignment of fields.
1771 2011-12-02 Ben Konrath <ben@bagu.org>
1773 Display currency codes in the details view.
1775 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1777 2011-12-02 Ben Konrath <ben@bagu.org>
1779 Avoid duplicate JNI call.
1781 JNI is not as efficient as pure Java and this is an easy (and small)
1784 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1785 Use previously retrieved value for whereClauseToTableName instead of
1788 2011-12-02 Ben Konrath <ben@bagu.org>
1790 Rename a couple of variables in RelatedListNavigation.
1792 This is a rename-only refactor.
1794 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1796 2011-12-02 Ben Konrath <ben@bagu.org>
1798 Indicate clearly that a mismatched primary key type is a bug.
1800 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1801 warning to error. Add 'This is a bug.' to message.
1803 2011-12-02 Ben Konrath <ben@bagu.org>
1805 Update / fix some comments.
1807 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1809 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1811 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1812 Fix comments. Add some TODOs.
1814 2011-12-02 Ben Konrath <ben@bagu.org>
1816 Enable navigation to details view with string primary key from related list.
1818 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1819 Create a text primary key value when return type of result is
1820 java.sql.Types.VARCHAR.
1822 2011-12-02 Ben Konrath <ben@bagu.org>
1824 Use checkboxes for booleans in the details view.
1826 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1828 2011-12-01 Ben Konrath <ben@bagu.org>
1830 Improve performance of related list height calculation.
1832 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1833 Put code to calculate the expected height in a static initializer so
1834 that that it's only called once.
1836 2011-12-01 Ben Konrath <ben@bagu.org>
1838 Show related list tables in notebooks (again).
1840 Calculate the height of the related list tables so the Notebook can be
1841 set the correct height. The height of the related list table is also needed by
1842 FlowTable to be able decide how to create the layout.
1844 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1845 and set the Portal height based on the height of the related list
1846 table and the Portal container.
1847 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1848 Add method to calculate the height of the related list tables.
1849 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1850 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1851 calculate the height of the Pager widget.
1853 2011-12-01 Ben Konrath <ben@bagu.org>
1855 Use CellTable API for table property instead of setting style on Element.
1857 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1859 2011-12-01 Ben Konrath <ben@bagu.org>
1861 Make ListViewTable and RelatedListTable a consistent height.
1863 The tables are now a consistent height regardless of the contents of
1864 the table. A hidden button is added to empty rows to ensure that the
1865 height of these rows will match the height of rows with data.
1867 A navigation button column is now added to every table. The width of
1868 the navigation column is set to 0px when a RelatedListTable shouldn't
1869 have navigation buttons. This maintains the a consistent row height in
1870 tables that don't show the navigation buttons.
1872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1873 navigation column when not needed.
1874 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1875 arguments for navigation button to constructor of ListViewTable.
1876 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1877 hidden button for empty data rows.
1878 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1879 arguments for navigation button to constructor.
1880 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1881 create navigation buttons. Add hideNavigationButtons() method.
1882 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1883 arguments for navigation button to constructor.
1885 2011-12-01 Ben Konrath <ben@bagu.org>
1887 Use 'visibility: hidden' in Utils.getWidgetHeight().
1889 This is better choice because hidden elements are invisible, don't
1890 respond to events and are not part of the tab order. They will,
1891 however, take up space which is required to be able to calculate the
1892 height of the widget.
1894 * src/main/java/org/glom/web/client/Utils.java:
1896 2011-12-01 Ben Konrath <ben@bagu.org>
1898 Use Utils.getWidgetHeight() in FlowTable.
1900 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1902 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1904 2011-12-01 Ben Konrath <ben@bagu.org>
1906 Put the details css class name on the correct table column.
1908 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1910 2011-11-30 Ben Konrath <ben@bagu.org>
1912 Update for java-libglom API change.
1914 The getters and setters on FieldFormatting and NumericFormat were
1915 changed to remove the 'M'.
1917 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1919 2011-11-29 Ben Konrath <ben@bagu.org>
1921 Only allow RelatedListTables in Portals.
1923 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1925 2011-11-29 Ben Konrath <ben@bagu.org>
1927 Only create a contents panel for Portals when title is being set.
1929 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1931 2011-11-29 Ben Konrath <ben@bagu.org>
1933 Set TabLayoutPanel height based on calculated height its widgets.
1935 This is a potential fix for this bug:
1937 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1939 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1941 2011-11-29 Ben Konrath <ben@bagu.org>
1943 Align details field labels and data with the Open buttons.
1945 * src/main/webapp/style.css:
1947 2011-11-29 Ben Konrath <ben@bagu.org>
1949 Remove unnecessary <div> in the Notebook widget.
1951 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1952 method to get container FlowPanel (<div>).
1953 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1954 initWidget() method directly on the TabLayoutPanel widget instead of
1955 Group's container widget.
1957 2011-11-29 Ben Konrath <ben@bagu.org>
1959 Don't add group titles for Portals in Notebooks.
1961 This reverts the previous patch and fixes a bug I introduced with
1962 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1964 * src/main/java/org/glom/web/client/ui/details/Group.java:
1965 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1967 2011-11-28 Ben Konrath <ben@bagu.org>
1969 Remove unused boolean argument in Portal constructor.
1971 Just a code cleanup.
1973 * src/main/java/org/glom/web/client/ui/details/Group.java:
1974 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1976 2011-11-28 Ben Konrath <ben@bagu.org>
1978 Remove hack for glom 1.18 style glom files.
1980 * src/main/java/org/glom/web/client/ui/details/Group.java:
1981 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1982 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1984 2011-11-28 Ben Konrath <ben@bagu.org>
1986 Use Gda Value version of primary key to log result too large error.
1988 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1990 2011-11-28 Ben Konrath <ben@bagu.org>
1992 Don't use TypedDataItem.getText() for Unknown types from the URL.
1994 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1995 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1996 instead of getText().
1997 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1998 String field and getUnknown() method.
2000 2011-11-28 Ben Konrath <ben@bagu.org>
2002 Log an error message when the java-libglom .so is not present.
2004 The error message was being set in the exception but not logged.
2006 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2008 2011-11-28 Ben Konrath <ben@bagu.org>
2010 Ignore LayoutItem_CalendarPortals.
2012 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2013 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2015 2011-11-28 Ben Konrath <ben@bagu.org>
2017 Extract method for creating the LayoutItemPortal DTO.
2019 Just breaking the code up into smaller chunks.
2021 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2023 2011-11-28 Ben Konrath <ben@bagu.org>
2027 This should have been added with the refactor. Oops!
2029 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2031 2011-11-28 Ben Konrath <ben@bagu.org>
2033 Create primary key value from URL string using type from Glom document.
2035 See this bug, comments 19 - 25:
2037 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2039 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2040 create a TypeDataItem for the primary key here when loading from a
2041 URL. Show the same string for the primary key value as was received
2042 from the URL string (when loading from a URL).
2043 * src/main/java/org/glom/web/server/Utils.java: Update method for
2044 creating the Gda Value from the TypeDataItem to properly deal with
2045 creating a Gda Value based on the Glom document type for the primary
2046 key value string when loading from a URL.
2047 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2048 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2049 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2050 Update for changed method name.
2052 2011-11-27 Ben Konrath <ben@bagu.org>
2054 Rename PrimaryKeyItem to TypedDataItem.
2056 The name PrimaryKeyItem suggests what the class should be used for.
2057 TypedDataItem is a neutral name that describes the class better.
2059 This is a rename-only refactor.
2061 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2062 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2063 * src/main/java/org/glom/web/client/Utils.java:
2064 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2065 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2067 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2068 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2069 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2070 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2071 * src/main/java/org/glom/web/server/Utils.java:
2072 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2073 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2074 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2075 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2077 2011-11-25 Ben Konrath <ben@bagu.org>
2079 Improve Gda Value conversion from PrimaryKeyItem.
2081 The value from the PrimaryKeyItem is only used if its type match the
2082 type from the glom document.
2084 * src/main/java/org/glom/web/server/Utils.java:
2086 2011-11-25 Ben Konrath <ben@bagu.org>
2088 Manually check if the java-liblgom .so is visible to the JVM.
2090 It seems that Tomcat has problems when a static initializer throws an
2091 exception. This check is done before the first method call into
2092 java-libglom so that execution doesn't continue if the .so is not
2095 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2097 2011-11-25 Ben Konrath <ben@bagu.org>
2099 Improve browser configuration error messages.
2103 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2105 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2106 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2107 getConfigurationErrorMessage() method.
2108 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2109 Get and display a specific configuration error message when no Glom
2110 documents are found.
2111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2112 Implement getConfigurationErrorMessage() method. Surround configuration
2113 code in the init() method with a try/catch block. This allows the
2114 errors to be caught while keeping the servlet available to retrieve the
2115 configuration error message.
2117 2011-11-25 Ben Konrath <ben@bagu.org>
2119 Don't use Strings to hold primary key values.
2121 The primary key values are now held in a new data object
2122 (PrimaryKeyItem) that holds type information and the primary key value
2123 using the correct type.
2125 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2126 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2128 PrimaryKeyItem instead of String to hold the primary key value.
2129 * src/main/java/org/glom/web/client/Utils.java: Remove
2130 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2131 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2133 PrimaryKeyItem instead of String to hold the primary key value. Load
2134 document selection page when the documentID has not been set correctly.
2135 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2136 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2138 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2139 Return empty string for URL instead of "null".
2140 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2141 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2142 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2143 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2144 PrimaryKeyItem instead of String to hold primary key values.
2145 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2146 PrimaryKeyValue to a Gda Value.
2147 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2148 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2149 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2150 Replace temporary database access code that uses the PrimaryKeyValue to
2151 Gda Value conversion.
2152 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2153 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2154 PrimaryKeyItem instead of String.
2155 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2156 hold primary key values.
2158 2011-11-24 Ben Konrath <ben@bagu.org>
2160 Use newly added java-libglom API to create queries.
2162 This isn't finished. I still need to stop using Strings for primary key
2163 values in the client code.
2165 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2166 libglom to use fake connections so that retrieving the query string will
2168 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2169 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2170 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2171 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2172 Use the newly added libglom sql methods and classes to create the
2173 query. Add temporary hack to convert primary value strings to Gda
2176 2011-11-23 Ben Konrath <ben@bagu.org>
2178 Don't explicitly set the height of Portals.
2180 See comments 6 - 10 of this bug for details:
2182 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2184 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2186 2011-11-23 Ben Konrath <ben@bagu.org>
2188 Use an HTML table instead of CSS for the FlowTable layout.
2190 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2191 GWT's FlexTable to implement the FlowTable.
2192 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2194 2011-11-18 Ben Konrath <ben@bagu.org>
2196 Add boolean example to HTML table mockup.
2198 * mockups/details-view-html-tables-text-entries.html:
2200 2011-11-17 Ben Konrath <ben@bagu.org>
2202 Ensure the pager buttons are always visible for related lists.
2204 To accomplish this, I've turned off text wrapping in the list view and
2205 related list tables for both the header and data text. The related list
2206 table now has a fixed layout so the it doesn't overflow its container.
2207 This is required to ensure that the cell text is clipped when it
2208 overflows the cell and an ellipsis is added to the right side of the
2209 cell when text is clipped.
2211 A fixed table layout for the related list table in the details view
2212 seems what we want for the details view anyway, so the side-effect is
2215 The ellipsis will only be displayed in Firefox >= 7.
2219 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2221 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2222 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2223 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2225 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2226 Set the 'table-layout: fixed' CSS property to the related list table.
2227 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2228 'white-space: nowrap;' CSS property on both the list view and the
2229 related list tables.
2231 2011-11-16 Ben Konrath <ben@bagu.org>
2233 Rework the fix for empty notebook tab labels.
2235 Setting the empty group titles with its name caused problems for the
2236 details layout. Instead of using libglom's
2237 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2238 to the client when the title is empty. This allows the Notebook to use
2239 the name when the title is empty without affecting anything else.
2241 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2242 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2244 2011-11-16 Ben Konrath <ben@bagu.org>
2246 Set group titles with name when title is empty.
2248 This fixes a problem with an empty notebook tab label in the Lesson
2249 Planner document. The forth tab in the notebook should be "Internet":
2251 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2253 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2254 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2257 2011-11-16 Ben Konrath <ben@bagu.org>
2259 Remove whitespace from the configured username properties.
2261 This assumes that usernames won't have whitespace at the beginning
2262 or end. But I think this is a reasonable assumption.
2264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2265 String.trim() to remove the whitespace from the username properties.
2267 2011-11-15 Ben Konrath <ben@bagu.org>
2269 Add details view mockup with HTML tables and text entries.
2271 This is from the attachment on this bug:
2273 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2275 * mockups/details-view-html-tables-text-entries.html:
2277 2011-11-15 Ben Konrath <ben@bagu.org>
2279 Add space between the columns of the flow table.
2283 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2285 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2286 space between columns in the flow table.
2288 2011-11-15 Ben Konrath <ben@bagu.org>
2290 Add backup files to the .gitignore.
2292 * .gitignore: Ignore files that end with ~.
2294 2011-11-09 Ben Konrath <ben@bagu.org>
2296 Use latest release of gwt-log.
2298 Gwt-log releases are now being submitted to the maven central
2299 repository so manual installation of the jar is no longer required.
2301 * pom.xml: Update version and groupId of gwt-log dependency.
2303 2011-10-31 Ben Konrath <ben@bagu.org>
2305 Don't use GWT numeric formatting to override the glom currency formatting.
2307 Currencies are now displayed like they are in Glom. See this bug:
2309 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2311 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2313 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2314 currency code to constructor and set it when the cell is rendered.
2315 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2316 currency code to the constructor of the NumericCell.
2318 2011-10-27 Ben Konrath <ben@bagu.org>
2320 Require the latest release of java-libglom (1.17.4).
2324 2011-10-26 Ben Konrath <ben@bagu.org>
2326 Add style to Notebook that matches current theme.
2328 It's not the best style in the world but it's better than the default.
2330 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2331 padding at the bottom of the child widgets.
2332 * src/main/webapp/style.css: Add style for the Notebook.
2334 2011-10-26 Ben Konrath <ben@bagu.org>
2336 Move servlet initialization code to overridden init method.
2338 This is half of the solution to getting proper error messages
2339 displayed when configuration errors occur. Here's the relevant bug:
2341 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2343 The rest of the solution involves surrounding the init method with a
2344 try/catch block and setting a global variable with the error /
2345 exception. A new async method should be created to retrieve and display
2346 the error message / exception.
2348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2349 code from constructor to init method adding exceptions as needed.
2351 2011-10-26 Ben Konrath <ben@bagu.org>
2353 Add script to monitor and restart tomcat if required.
2355 * utils/check-and-recover-tomcat.py: New file.
2357 2011-10-26 Ben Konrath <ben@bagu.org>
2359 Display the correct number of data items in the pager.
2363 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2365 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2366 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2367 The implementation is the same for both tables: Keep track of the
2368 number of non-empty rows and fire and RowCountChangeEvent after the data has
2370 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2371 custom Pager class that subclasses SimplePager to handle displaying
2372 the correct number when empty rows have been added.
2374 2011-10-26 Ben Konrath <ben@bagu.org>
2376 Correct error in previous commit.
2378 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2379 eventBus parameter from listView.setCellTable().
2381 2011-10-26 Ben Konrath <ben@bagu.org>
2383 Fix error in TODO comment.
2385 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2387 2011-10-24 Ben Konrath <ben@bagu.org>
2389 Create Notebook widgets to the details view.
2391 This isn't finished just yet - I still need to create a reasonable
2392 style to match the current theme.
2394 * src/main/java/org/glom/web/client/Utils.java: Add method for
2395 calculating the height of a widget. This is used in the Notebook class.
2396 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2397 new constructor method in Group.
2398 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2399 method for creating child widget that can be used by subclasses
2400 like Notebook. New constructor that allows disabling the group
2401 titles - Notebooks don't set a group title for their child groups.
2402 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2403 to make Notebooks using GWT's TabLayoutPanel.
2404 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2405 constructor that allows disabling the group titles.
2406 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2407 LayoutItemNotebook DTO.
2408 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2409 DTO for Notebooks. It's just an empty class for now but we might need
2410 it to transfer some specific information in the future.
2412 2011-10-21 Ben Konrath <ben@bagu.org>
2414 Add navigation buttons to related list tables.
2416 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2417 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2419 method getSuitableRecordToViewDetails() for getting the table name
2420 and primary key value for related list navigation buttons.
2421 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2422 private cell renderer class to get the navigation information for
2423 related list tables from the server. Extract the navigation
2424 processing code from the details cell navigation and use it for the
2425 related list navigation as well.
2426 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2427 cell renderer class for the details open buttons. This was needed
2428 because the related list navigation buttons and the list view
2429 navigation buttons need to react differently when clicked.
2430 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2431 the onEnterKeyDown() method because it's now overriden in the
2432 subclasses that are specific to the related list tables and the list
2434 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2435 the vertical size a little because the buttons add a bit of vertical
2436 space to table. This is not a perfect solution because the vertical
2437 size of with table fewer than 5 rows will be a little smaller.
2438 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2439 changes in how navigation buttons are handled.
2440 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2441 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2442 database access object.
2443 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2444 to find the portal for a given relationship name from
2445 RelatedListDBAccess. Add method to find a primary key field for a
2447 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2448 Move code to find the portal for a given relationship name to
2450 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2451 New file: database access object for getting the related list
2452 navigation information (the table name and the primary key value).
2453 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2454 DTO for transferring a table name to navigate to and a primary key
2456 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2457 boolean and getter/setter to specifies if the related list should add
2460 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2462 Use the master branch of java-libglom
2464 * pom.xml: Depend on java-libglom 1.19 instead.
2466 This is the master branch. See also the libglom-1-18 branch.
2468 2011-10-11 Ben Konrath <ben@bagu.org>
2470 Enable the open navigation button when the data has been set.
2472 This avoids having active buttons that don't do anything when the data
2475 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2477 2011-10-11 Ben Konrath <ben@bagu.org>
2479 Use IsWidget interface for FlowTableItem.
2481 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2482 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2484 2011-10-11 Ben Konrath <ben@bagu.org>
2486 Remove GWT styling from open button in details view.
2488 There are still some issues with how the details cell is arranged but
2489 this should be made to match Glom 1.20. I'm going to leave fixing this
2490 until I have Glom 1.20 up and running.
2492 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2493 style name on open button.
2494 * src/main/webapp/style.css: Move and edit details-navigation class.
2495 Re-arrange some classes to make them appear in the same order as the
2498 2011-10-07 Ben Konrath <ben@bagu.org>
2500 Update to GWT 2.4.0.
2502 * .gitignore: Ignore new cache directory.
2503 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2504 * pom.xml: Change GWT and maven plugin to 2.4.0.
2505 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2507 * src/main/java/org/glom/web/client/ClientFactory.java:
2508 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2509 * src/main/java/org/glom/web/client/OnlineGlom.java:
2510 Update source for API changes.
2511 * utils/build-onlineglom-war.sh: Remove cache directory before the
2514 2011-10-07 Ben Konrath <ben@bagu.org>
2516 Add navigation buttons in the details view.
2518 This isn't finished but I thought I'd commit what I have as it's a
2519 pretty good start. I still need to:
2521 1. Change the style so that it fits better into the current theme
2522 2. Adjust the details cell to expand as much as possible.
2524 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2525 click handlers to navigation buttons in the DetailsCells. Create a
2526 refreshData() method to get just the data from the server without the
2528 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2529 Update the tableSelector and browser title when the table name
2530 changes without using the tableSelector.
2531 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2532 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2533 getDetailsCells() to getCells(). Update variable names.
2534 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2535 method to set click handler on navigation button. Rename a few
2536 variables. Add navigation buttons where needed.
2537 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2538 variables and methods.
2539 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2540 navigation boolean and navigation table as required in the
2541 LayoutItemField DTO.
2542 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2543 variables for navigation along with getter/setter methods.
2545 2011-10-07 Ben Konrath <ben@bagu.org>
2547 Rename Field to DetailsCell.
2549 This is a refactor-only commit. No functionality has been added or
2552 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2553 Update variable and method names.
2554 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2555 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2556 variable and method names.
2557 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2559 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2560 variable and method names.
2562 2011-10-07 Ben Konrath <ben@bagu.org>
2564 Create separate methods for layout and data the details view.
2566 This is a refactor-only commit. No functionality has been added or
2569 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2570 private methods: setData(), createLayout().
2572 2011-10-07 Ben Konrath <ben@bagu.org>
2574 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2576 This is part of a change to get navigation buttons in the details view
2577 but it should have been done this way from the start.
2579 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2580 for method name change in TableSelectionView.
2581 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2582 Create TableChangeEvent and set the browser title using the
2583 TableSelectionView API.
2584 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2585 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2586 Change getSelectedTable() to getSelectedTableName(). Add
2587 getSelectedTableTitle().
2589 2011-10-07 Ben Konrath <ben@bagu.org>
2591 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2593 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2595 2011-10-07 Ben Konrath <ben@bagu.org>
2597 Update TableChangeEvent to use newTableName naming convention.
2599 This makes the class more consistent with GWT naming conventions.
2601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2602 Update for method name change in TableChangeEvent.
2603 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2604 for method name change in TableChangeEvent.
2605 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2606 newTableName variable and getter method. Make toDebugString()
2609 2011-09-30 Ben Konrath <ben@bagu.org>
2611 Disable the pager in the list tables when the data row count is less than the minimum.
2613 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2616 2011-09-30 Ben Konrath <ben@bagu.org>
2618 Add empty rows to the end of related list and list view tables.
2620 I also extracted the cell rendering classes from the ListTable because
2621 the code was becoming a little crazy with all the anonymous inner
2622 classes. My plan is to use these cell rendering classes in the details
2623 view as well so this refactor will be needed for that change.
2625 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2626 set the row count in related list tables if the data has more rows
2627 than the minimum number of rows visible.
2628 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2629 row count in list view tables if the data has more rows than the
2630 minimum number of rows visible.
2631 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2632 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2634 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2635 for rendering TYPE_NUMERIC cells. The code was extracted from the
2637 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2638 class for rendering cells with buttons in list views. The code was
2639 extracted from the ListTable class.
2640 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2641 for rendering TYPE_TEXT cells. The code was extracted from the
2643 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2644 Add empty rows to the end of the data if required. Implement
2645 ListTable.getMinNumVisibleRows().
2646 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2647 cell renderer code to public classes. Return null in
2648 Column.getValue() for empty rows. Add new abstract method:
2649 getMinNumVisibleRows(). Move code to set the row count of the list view
2650 table to ListViewImpl.
2651 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2652 empty rows to the end of the data if required. Implement
2653 ListTable.getMinNumVisibleRows().
2656 2011-09-27 Ben Konrath <ben@bagu.org>
2658 Use GWT.log for client-side debugging statements.
2660 These are optimized out when deployed so I should have used this method
2661 in the first place. These statements will eventually be replaced with some sort
2662 of notification in the browser.
2664 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2665 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2666 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2667 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2668 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2670 2011-09-27 Ben Konrath <ben@bagu.org>
2672 Put tableselector on the right, back to list link on right.
2674 The idea is that the table selector is acting like a label for the
2675 currently displayed table so it should be placed below the document title. This
2676 puts the table title in a similar position to where it is in Glom.
2678 * mockups/details-contacts.html:
2679 * mockups/details-projects.html:
2680 * mockups/listview-contacts.html:
2681 * mockups/listview-projects.html:
2682 * mockups/style.css:
2683 Update mockups to match how the interfaces currently look.
2684 * src/main/webapp/style.css: Swap positions of backlink with the table
2685 selector. Add some space on the left side of the table selector to
2686 line things up with the document title.
2688 2011-09-27 Ben Konrath <ben@bagu.org>
2690 Add field colouring to details view.
2692 This change re-works how field colouring works. The colour formatting
2693 information is now set to the client with the layout information instead of
2694 with the data. This eliminates the need to send the same colour strings for
2695 data in list view column when colour information is set.
2697 In order to set an alternate colour for negative numeric values, the
2698 number is now sent to client and formatted with the GWT NumberFormat class.
2700 This change also fixes:
2702 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2704 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2705 internationalization framework which is needed for client side numeric
2707 * src/main/java/org/glom/web/client/Utils.java: New file for some
2708 client static utility methods.
2709 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2710 the DataItem object to the Field class. Use a utility method to
2711 create the foreignKeyValue string.
2712 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2713 alignment and text colours in the constructor. Add setData(DataItem)
2714 method. Remove setText(String) method.
2715 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2716 colour information to GlomTextCell. Create and use GlomNumberCell for
2717 rendering numbers. Use utility method to get the string for the
2718 primary key of the key provider. Re-work how the horizontal alignment
2720 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2721 formatting to layout information. Methods for converting the libglom
2722 formatting information were moved from DBAccess.
2723 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2724 numeric formatting (it's now done on the client side). Don't set text
2725 colours in DataItem. Move libglom formatting conversion methods to
2727 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2728 getters/setters for text colour information.
2729 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2730 for transferring the libglom NumericFormat information to the client.
2731 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2732 and getters/setters for: GlomNumericFormat, background colour and
2733 foreground colour strings.
2735 2011-09-26 Ben Konrath <ben@bagu.org>
2737 Simplify code that iterates through the LayoutGroup.
2739 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2741 2011-09-26 Ben Konrath <ben@bagu.org>
2743 Accept Eclipse formatting for OnlineGlomServiceAsync.
2745 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2747 2011-09-26 Ben Konrath <ben@bagu.org>
2749 Don't use the ListDBAccess classes to get the primary key layout information.
2751 This was causing a bug where the wrong index for the hidden primary key
2752 was being sent to the client.
2754 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2755 primary key while creating the LayoutGroup DTO. Create a
2756 LayoutItemField DTO for hidden primary keys. Don't use the
2757 RelatedListDBAccess because it was only used for getting the primary
2759 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2760 access modifier from public to protected for getPrimaryKeyField() and
2761 getPrimaryKeyLayoutItemField().
2762 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2763 abstract method getExpectedResultSize() because RelatedListDBAccess
2764 doesn't have enough info to implement it.
2765 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2766 Remove @Override for getExpectedResultSize().
2767 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2768 Remove method getExpectedResultSize().
2770 2011-09-23 Ben Konrath <ben@bagu.org>
2772 Log which layout (list or details) the ignored item is from.
2774 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2776 2011-09-23 Ben Konrath <ben@bagu.org>
2778 Remove annotations that turn off code formatting in DataItem.
2780 * src/main/java/org/glom/web/shared/DataItem.java:
2782 2011-09-23 Ben Konrath <ben@bagu.org>
2784 Rename GlomField to DataItem and update associated methods.
2786 This is a rename-only refactor. No functionality has been added or
2789 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2790 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2792 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2793 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2794 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2795 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2796 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2797 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2798 * src/main/java/org/glom/web/server/database/DBAccess.java:
2799 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2800 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2801 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2802 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2803 * src/main/java/org/glom/web/shared/DataItem.java:
2804 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2805 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2807 2011-09-23 Ben Konrath <ben@bagu.org>
2809 Rename GlomDocument to DocumentInfo and update associated methods.
2811 This is a rename-only refactor. No functionality has been added or
2814 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2815 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2816 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2817 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2818 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2820 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2822 2011-09-20 Ben Konrath <ben@bagu.org>
2824 Require java-libglom 1.17.3.
2826 This picks up the fix for the seg fault problem with the Scenes table
2827 in the Openismus Film Manager example.
2831 2011-09-20 Ben Konrath <ben@bagu.org>
2833 Change the way sort clause is added for primary key when no sort clause is requested.
2835 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2836 before the sort clause is created. When a sort clause is not requested, the
2837 sort clause is created by finding the primary key in the LayoutFieldVector
2840 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2842 2011-09-20 Ben Konrath <ben@bagu.org>
2844 Log error message if no documents are found in the configured directory.
2846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2847 Extract the glom file extension string to a private static final class
2848 variable (mostly as syntactic sugar). Accept a minor formatting change.
2849 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2850 the example glom.document.directory configuration property to make it
2851 more clear that it can any directory, not just the home directory.
2853 2011-09-18 Ben Konrath <ben@bagu.org>
2855 Add related lists to details view.
2857 The related list table has support for paging and sorting just like the
2858 table in the list view.
2860 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2861 SQL queries for the related list tables.
2862 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2863 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2865 Rename getList methods to getListView and add comments. Remove
2866 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2867 it being unused. Add methods: getDetailsLayoutAndData(),
2868 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2869 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2870 Create the layout and set the data for the fields in one async call
2871 instead of two. Create related lists where appropriate.
2872 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2873 for method name changes in OnlineGlomService.
2874 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2875 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2876 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2878 * src/main/java/org/glom/web/client/ui/ListView.java:
2879 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2880 tableName from setCellTable(). Create a ListViewTable instead of
2882 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2883 represent a data field in the details view.
2884 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2885 from addDetailsCell() to Field class. Keep track of the Fields and
2886 Portals in the details view.
2887 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2888 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2889 and add a method to get it. Add method to set the contents of the
2891 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2892 New class for related list tables. This class has the data provider
2893 for the related list table.
2894 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2895 abstract class which is the base class for the ListViewTable and the
2897 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2898 New class for list view tables. This class has the data provider for
2899 the list view table.
2900 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2901 methods for related list tables. Add more information to the
2902 LayoutItemField and LayoutItemPortal DTOs.
2903 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2904 Remove debugging print statement.
2905 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2906 Remove debugging print statements. Add primary key field to SQL count
2908 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2909 Remove unnecessary LayoutFieldVector parameter from
2910 getResultSizeOfSQLQuery() method.
2911 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2912 New class for related list table database access.
2913 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2914 class that is a wrapper DTO for details view layout and data.
2915 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2916 new 'fromField' string to this DTO.
2917 * src/main/webapp/style.css: Remove bottom margin and override top
2920 2011-09-15 Ben Konrath <ben@bagu.org>
2922 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2924 This sets things up to make it easier to add the data retrieval for
2925 related lists (portals). No user noticeable changes were made with
2928 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2929 class has the code to retrieve the layouts and access the
2930 database using the new database helper classes.
2931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2932 Most of the functionality has been removed from this class. This
2933 class now represents the public interface for the client side
2934 code. It also deals with configuring the servlet and cleaning
2935 things up when the servlet is stopped.
2936 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2937 of static methods into this utility class.
2938 * src/main/java/org/glom/web/server/database/DBAccess.java:
2939 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2940 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2941 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2942 These classes have the database retrieval code. The class hierarchy
2943 has been setup to make it easy to reuse code for similar
2946 2011-09-06 Ben Konrath <ben@bagu.org>
2948 Create separate classes for list table code and the data provider.
2950 As part of this refactor, I also split up the code a bit to make it
2953 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2954 table code to two new classes (below).
2955 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2956 with code from ListViewImpl.
2957 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2958 New file with code from ListViewImpl.
2960 2011-09-06 Ben Konrath <ben@bagu.org>
2962 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2964 This fixes the LayoutItemPortal DTO to match the libglom layout object
2967 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2969 2011-09-01 Ben Konrath <ben@bagu.org>
2971 Set title of Portals in the Details View.
2973 * pom.xml: Bump required version of java-libglom to 1.17.1.
2974 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2975 widget creation to its own class. Add comments to constructor.
2976 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2977 The code is mostly from the Group class with the title now set.
2978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2979 title of Portal. Update some comments. Fix some code formatting.
2981 2011-09-01 Ben Konrath <ben@bagu.org>
2983 Remove TODO comment for the flow table column width.
2985 The flow table column width is working correctly and doesn't need to be
2986 changed. See this mailing list post for more info:
2988 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2990 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2992 2011-08-27 Ben Konrath <ben@bagu.org>
2994 Add document title (database name) to top of the browser page.
2996 I added the document title to the TableSelecitonView but that will
2997 change if / when we add a view that doesn't require table selection.
2999 * mockups/details-contacts.html:
3000 * mockups/details-projects.html:
3001 * mockups/listview-contacts.html:
3002 * mockups/listview-projects.html:
3003 * mockups/style.css: Add document title to mockups to keep things
3005 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3006 sizes to account for the document title.
3007 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3008 Set the document title when it has been retrieved from the server.
3009 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3010 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3011 and implement setDocumentTitle(String) method.
3012 * src/main/webapp/style.css: Add ID for document title style.
3014 2011-08-25 Ben Konrath <ben@bagu.org>
3016 Add NavigationType enum to LayoutItemPortal DTO.
3018 This is the start of adding support for Portals to the Details View.
3020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3021 LayoutItem_Portal.navigation_type enum from libglom to
3022 LayoutItemPortal.NavigationType enum.
3023 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3024 NavigationType enum, field for storing the NavigationType and getter
3027 2011-08-25 Ben Konrath <ben@bagu.org>
3029 Implement the flow table layout in the Details View.
3031 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3032 FlowTable to Group to account for the renamed class.
3033 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3034 File. This is a container widget that implements the Glom details view
3035 flow table behaviour.
3036 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3037 org/glom/web/client/ui/FlowTable.java.
3038 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3039 so that the size of the subgroups are a closer match to the size of
3040 the Glom subgroups. This makes the flowtable layout match the layout
3041 in Glom for the Music Collection example file.
3043 2011-08-16 Ben Konrath <ben@bagu.org>
3045 Create container element for LayoutItemPortal in Details View.
3047 This will help me develop the layout for the FlowTable.
3049 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3050 fieldPanel variable to detailsCell.
3052 2011-08-15 Ben Konrath <ben@bagu.org>
3054 Set the height of the data element in the Details View.
3056 I changed the InlineLabels (text in a span element) to Labels (text in
3057 a div element) so that I could set the height of the details-data
3058 elements instead of the details-cell parent elements. This allows the
3059 the details-data element to display the correct height if style is
3060 applied that shows the height.
3062 This change has the added benefit of allowing the order of the labels
3063 and data elements to be changed for right-to-left languages.
3065 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3066 InlineLabels to Labels.
3067 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3068 InlineLabels to Labels. Set the height of the data element.
3069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3070 multiline text height in the Formatting DTO.
3071 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3072 for multiline height along with getter and setter methods.
3073 * src/main/webapp/style.css: Adjust style to account for the change
3074 from span elements to div elements in the details cell.
3076 2011-08-15 Ben Konrath <ben@bagu.org>
3078 Make the List View appearance match the mockups.
3080 It doesn't match exactly but it's much better than it was.
3082 * mockups/listview-contacts.html: Remove unused css classes.
3083 * mockups/listview-projects.html: Remove unused css classes.
3084 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3085 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3086 for mainPanel instead of VerticalPanel (table). Set style name on
3087 CellTable. Set style name on Details column. Right-align Details
3089 * src/main/webapp/style.css: Adjust properties to match the mockups.
3091 2011-08-12 Ben Konrath <ben@bagu.org>
3093 Add better support for subgroups in the details view.
3095 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3096 changed FlowTable constructor.
3097 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3098 support for subgroups and subgroup-titles.
3099 * src/main/webapp/style.css: Add CSS class for subgroups and
3102 2011-08-12 Ben Konrath <ben@bagu.org>
3104 Return the top level LayoutGroup title.
3106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3108 2011-08-11 Ben Konrath <ben@bagu.org>
3110 Make the TableSelector header match the mockup.
3112 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3113 the layout panel. Properly lineup the table selection header with
3114 the list and details view.
3115 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3116 margin around the details view.
3117 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3118 Rename listBox variable to tableSelector. Set id for the style sheet.
3119 Use a FlowPanel instead of a HorizontalPanel.
3120 * src/main/webapp/style.css: Add properties to make the TableSelector
3121 box match the mockups.
3123 2011-07-13 Ben Konrath <ben@bagu.org>
3125 Update install script for java-libglom version change.
3127 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3130 2011-07-13 Ben Konrath <ben@bagu.org>
3132 Add support sub-group in the details view.
3134 I also removed the code that special-cased the default details view
3137 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3139 I still have to make a proper flowtable.
3141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3142 Don't special-case default details view layout.
3143 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3144 addLayoutField() as I'm going to use it.
3145 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3146 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3148 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3149 extracted from DetailsViewImpl.GroupPanel. Add support for
3151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3152 column count when getting the details layout.
3154 2011-07-12 Ben Konrath <ben@bagu.org>
3156 Set browser title with database and table titles.
3158 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3159 Set the browser title when the table changes and when the activity
3161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3162 title when retrieving document info (the GlomDocument object).
3163 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3164 with getter and setter methods. Remove unused convenience constructor.
3165 Use default code formatting.
3167 2011-07-12 Ben Konrath <ben@bagu.org>
3169 Ignore LayoutItemPortals in the details view.
3171 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3174 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3175 LayoutItemPortal layout objects.
3176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3177 LayoutItemPortal objects when retrieving the details layout.
3178 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3179 file. This is an empty class and just used to get type information for
3182 2011-07-12 Ben Konrath <ben@bagu.org>
3184 Use java-libglom 1.17.0.
3188 2011-07-11 Ben Konrath <ben@bagu.org>
3190 Remove "Table:" label from table selector.
3192 This matches a recent change in the Glom UI.
3194 * mockups/details-contacts.html:
3195 * mockups/details-projects.html:
3196 * mockups/listview-contacts.html:
3197 * mockups/listview-projects.html: Remove the "Table:" label from the
3199 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3201 2011-07-11 Ben Konrath <ben@bagu.org>
3203 Add main groups to the details view.
3205 This makes things look a little nicer in the details view. The next step
3206 is to implement the flowtable.
3208 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3209 resources from the standard gwt css theme. Standard.css is now
3210 included in OnlineGlom.html so that the online glom css rules have
3211 precedence over the gwt theme.
3212 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3213 the whole LayoutGroup to the DetailsView instead of just the titles.
3214 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3215 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3216 details layout with a helper class (GroupPanel). I might extract this
3217 class when I make the full flowtable.
3218 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3219 string as default so I don't have to worry about NPEs when processing
3221 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3222 note beside OnlineGlom.gwt.xml above).
3223 * src/main/webapp/style.css: Add default font-size to body to override
3224 the font-size set by the standard theme. Don't use h2 tags for
3225 group-title. Create new details-cell class.
3227 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3229 ConfiguredDocument: Set the port number too.
3231 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3232 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3233 Glom document. Presumably this worked sometimes so far because there is a
3234 default port number.
3236 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3238 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3240 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3241 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3242 correct, though we should throw an exception too.
3244 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3246 Fix a addDocuemnt typo.
3248 * src/main/java/org/glom/web/shared/Documents.java
3249 (Documents.addDocuemnt): Rename to addDocument().
3250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3251 (OnlineGlomServiceImpl.getDocuments): Adapt.
3253 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3255 Slightly improved log output when connection fails.