1 2012-07-20 Murray Cumming <murrayc@murrayc.com>
3 tests: SelfHoster: Test SqlUtils too.
5 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
6 Retrieve some data and check it too, as in the regular Glom
7 test_selfhosting_new_from_example.cc test.
8 * src/test/java/org/glom/web/server/SelfHoster.java:
9 createConnection(): Make this public.
11 2012-07-20 Murray Cumming <murrayc@murrayc.com>
13 tests: SelfHoster: createConnection(): Do not warn about expected failures.
15 Let the caller say if the connection is expected to fail, to avoid
16 irrelevant error output.
18 2012-07-20 Murray Cumming <murrayc@murrayc.com>
20 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
22 * src/test/java/org/glom/web/server/SelfHoster.java:
23 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
24 due to the inevitable need to retry the connection while the database server
27 2012-07-20 Murray Cumming <murrayc@murray.com>
29 tests: SelfHoster: createConnection(): Set a timeout.
31 * src/test/java/org/glom/web/server/SelfHoster.java:
32 createConnection(): Use setLoginTimeout() because it otherwise seems to take
33 ages to actually return when it fails.
35 2012-07-20 Murray Cumming <murrayc@murrayc.com>
37 tests: SelfHoster: selfHost(): Close the test connection.
39 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
40 When we check that the connection works, close the connection. This seems
41 to not be closed automatically otherwise.
43 2012-07-20 Murray Cumming <murrayc@murrayc.com>
45 Use slf4j-simple to see JDBC errors.
47 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
49 2012-07-19 Murray Cumming <murrayc@murrayc.com>
51 SelfHoster.discoverFirstFreePort(): Close the socket.
53 * src/test/java/org/glom/web/server/SelfHoster.java:
54 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
56 2012-07-19 Murray Cumming <murrayc@murrayc.com>
58 Avoid another code warning in Eclipse Juno.
60 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
61 Do instanceof checks on the FileUtils.listFiles() result and its
64 2012-07-13 Murray Cumming <murrayc@murrayc.com>
66 Avoid some code warnings in Eclipse Juno
68 * src/main/java/org/glom/web/server/libglom/Document.java:
69 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
70 * src/test/java/org/glom/web/server/SelfHoster.java
71 createTextFile(): Make sure that the FileOutputStream is closed.
73 2012-06-22 Murray Cumming <murrayc@murrayc.com>
75 Added OnlineGlomPropertiesTest.
77 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
78 Make sure we never return a null string.
79 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
80 Added tests of the OnlineGlomProperties API, using our sample file.
82 2012-06-20 Murray Cumming <murrayc@murrayc.com>
84 Make OnlineGlomProperties be a normal class.
86 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
87 Move OnlineGlomProperties into its own file to be a regular class:
88 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
89 This makes testing simpler.
91 2012-06-15 Murray Cumming <murrayc@murrayc.com>
93 OnlineGlomServiceImpl.init(): Move some code into a new method.
95 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
98 2012-06-15 Murray Cumming <murrayc@murrayc.com>
100 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
103 OnlineGlomProperties.getKey(): Make this more robust by moving the
104 check for *.*.filename to here.
106 2012-06-15 Murray Cumming <murrayc@murrayc.com>
108 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
111 init(): Move knowledge of the config file format into the
112 OnlineGlomProperties inner class.
114 2012-06-15 Murray Cumming <murrayc@murrayc.com>
116 SelfHostExampleTest: Make sure we cleanup on failure.
118 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
119 the use of cleanup() to a tearDown() JUnit method.
121 2012-06-12 Murray Cumming <murrayc@murrayc.com>
123 ConfiguredDocument: Add a primary key to portals at least once.
125 * src/main/java/org/glom/web/server/ConfiguredDocument.java
126 updatePortalsExtras): Fix a typo so that we add the primary key
127 column at least once.
128 This is a fix for the previous commit:
129 ConfiguredDocument: Do not add a primary key to portals each time.
131 2012-06-08 Murray Cumming <murrayc@murrayc.com>
133 SelfHoster: Avoid some compiler warnings.
135 * src/test/java/org/glom/web/server/SelfHoster.java
136 executeCommandLineAndWait():
137 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
138 the now-unused streams for stdout and stderr from the command Processes.
139 These are not used because readln() hangs while waiting for a new line,
140 where there may be no next line. The commented out code is still there
141 to help us figure out how to do this properly.
143 2012-06-08 Murray Cumming <murrayc@murrayc.com>
145 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
147 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
148 Make this actually test the cloning again, though it is not very useful
149 now that we do not use the part that had a problem with cloning before.
151 2012-06-08 Murray Cumming <murrayc@murrayc.com>
153 SelfHoster: Keep trying pg_ctl after starting postgres.
155 * src/test/java/org/glom/web/server/SelfHoster.java
156 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
157 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
158 regular Glom. This seems mad but it seems to work because the first
159 command would fail if pg_ctl would eventually fail.
161 2012-06-08 Murray Cumming <murrayc@murrayc.com>
163 SelfHoster: Wait until the server is really ready.
165 * src/test/java/org/glom/web/server/SelfHoster.java
166 selfHost(): Attempt the connection after starting the server, retrying
167 a few times if necessary, so that the server is really ready already when
168 we return from this method.
169 The regular Glom code does this too because pg_ctl reports success too soon.
171 2012-06-08 Murray Cumming <murrayc@murrayc.com>
173 ConfiguredDocument: Do not add a primary key to portals each time.
175 * src/main/java/org/glom/web/server/ConfiguredDocument.java
176 updatePortalsExtras(): Only add an extra primary key field if there is
177 none, to avoid adding one each time we retrieve the details layout from the
179 This should fix bug #676986 (Ben Konrath)
181 2012-05-25 Murray Cumming <murrayc@murrayc.com>
183 Document.load(): Support version 7 documents.
185 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
186 database_title attribute if the title attribute is not there.
189 2012-05-24 Ben Konrath <ben@bagu.org>
191 Add configuration for auto-generating mvn:i18n from with Eclipse.
193 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
195 2012-05-24 Murray Cumming <murrayc@murrayc.com>
197 Update translations, adding French.
199 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
201 Add a French translation, using the translation from Glom.
203 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
204 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
205 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
206 Update these based on the translations from Glom.
208 2012-05-24 Murray Cumming <murrayc@murrayc.com>
210 SelfHoster: Add some debug println messages to help when things fail.
212 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
213 System.out.println() lines.
215 2012-05-23 Murray Cumming <murrayc@murrayc.com>
217 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
219 * src/test/java/org/glom/web/server/SelfHoster.java:
220 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
221 instance) instead of just /usr/bin (as on Fedora). Check the result when
224 2012-05-23 Murray Cumming <murrayc@murrayc.com>
226 Remove LayoutItemPortal.get/setNavigationTable().
228 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
229 Remove get/setNavigationTable(), which is only a cache, because it is not
230 used, and does not need to be used, because that decision should be made on
232 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
233 updatePortalsExtras():
234 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
235 getNavigationRecord():
236 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
239 2012-05-21 Murray Cumming <murrayc@murrayc.com>
241 Initial self-hosting for tests.
243 * pom.xml: Change the scope for log4j, to hopefully make it
244 available to the test code which uses it indirectly via jOOQ.
245 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
246 self-hosting, though we only use it for testing.
248 * src/main/java/org/glom/web/server/libglom/Document.java:
249 example rows: Use a map instead of a list for each row of values,
250 so we know what field they are for, instead of relying on the sequence
251 being correct. This is not very efficient, but it does not really need
253 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
254 testReadTableExampleRows(): Adapted.
256 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
257 that returns an Object, for generic use. Note that Object seems to be
258 the implicit base even of double.
259 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
260 for use in CREATE TABLE SQL queries.
261 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
262 to do self-hosting of PostgreSQL databases via its command-line
263 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
264 backends/postgres_self.cc. This is incomplete - it needs more
265 warnings about failures and it needs to clean up properly when things
267 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
268 test of this new class.
270 2012-05-21 Murray Cumming <murrayc@murrayc.com>
272 Document: loading example data: Handle exceptions.
274 * src/main/java/org/glom/web/server/libglom/Document.java:
275 DateFormat.parse() and Double.valueOf() can throw exceptions, though
276 Eclipse did not warn about that.
278 2012-05-20 Murray Cumming <murrayc@murrayc.com>
280 Document: load(), save(): Handle the example rows.
282 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
284 * src/main/java/org/glom/web/server/libglom/Document.java:
285 load(), save(): Load and save the example rows, though the date, time
286 and image types are not handled properly yet.
287 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
288 Add testReadTableExampleRows() just to check that something is read.
290 2012-05-20 Murray Cumming <murrayc@murrayc.com>
292 Document: Add save().
294 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
295 Added getTranslationsMap() for use while saving.
296 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
297 Adedd getUseDefaultFormatting() for use while saving.
298 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
299 and several private methods that it uses.
301 This will be useful while testing via self-hosting.
302 It is not complete, but should be complete enough for testing.
304 2012-05-17 Murray Cumming <murrayc@murrayc.com>
306 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
308 * src/main/java/org/glom/web/client/OnlineGlomService.java
309 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
311 Remove getSortedListViewData() and getSortedRelatedListData(), adding
312 the sort column index and ascending bool to the regular method.
313 Instead, a sort column index of -1 now means no sort.
314 This is less explicit, but it's fairly simple, reduces the amount of
315 code, and makes the OnlineGlomService API slightly smaller.
316 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
317 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
319 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
320 getListViewData(), getRelatedListData():
321 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
322 getListViewData(), getRelatedListData():
323 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
325 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
327 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
332 2012-05-16 Murray Cumming <murrayc@murrayc.com>
334 Use translations for top-level groups too.
336 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
337 updateTitlesForLocale(): Use the translation for the group
338 as well as for child items.
342 Just recompiled to fix a problem in the released .tar.gz file.
346 2012-05-15 Murray Cumming <murrayc@murrayc.com>
348 Corrections to navigation to related records.
350 * src/main/java/org/glom/web/client/OnlineGlomService.java:
351 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
352 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
353 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
354 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
355 relationship name, because the relationship name is not necessarily unique
357 TOOD: This is inefficient, because it passes the whole list of
358 child field items back to the server, but it is more correct, and happens
359 to fix a bug with the primary key being lost after a few navigations.
360 There is probably a chance to make this more efficient anyway in some
363 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
364 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
365 * src/main/java/org/glom/web/server/ConfiguredDocument.java
366 * src/main/java/org/glom/web/server/database/DBAccess.java
367 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
368 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
371 2012-05-15 Murray Cumming <murrayc@murrayc.com>
373 Fix the use of translations.
375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
376 Add updateTitlesForLocale().
377 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
378 Call it to discard unwanted translations and to make getTitle() return
379 the wanted translation wihout the need for the client code to specify a locale.
380 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
381 getTitle(): Fallback to the original title, as libglom does.
383 2012-05-15 Murray Cumming <murrayc@murrayc.com>
385 Document: Correctly report the number of available translation locales.
387 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
388 the available locale IDs list.
389 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
390 testLocales: Test this.
392 2012-05-15 Murray Cumming <murrayc@murrayc.com>
394 SqlUtils: Use camelCase.
396 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
397 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
398 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
399 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
400 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
401 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
403 2012-05-15 Murray Cumming <murrayc@murrayc.com>
405 Use jOOQ's tableByName() and fieldByName.
407 * pom.xml: Use jOOQ 2.3.1 to get the new API.
408 * src/main/java/org/glom/web/server/SqlUtils.java:
409 build_sql_select_step_with_where_clause(), .createField(),
410 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
411 so we can get correct quoting and escaping. Thanks to Lukas Eder for
412 adding this, and other things, to jOOQ.
414 2012-05-15 Murray Cumming <murrayc@murrayc.com>
416 SqlUtils: Remove the Connection parameters.
418 * src/main/java/org/glom/web/server/SqlUtils.java:
419 build_sql_select_with_key(), build_sql_select_with_where_clause(),
420 createSelect(), build_sql_select_step_with_where_clause(),
421 build_sql_count_select_with_where_clause(),
422 build_sql_select_count_rows(): Remove the Connection parameter because
423 jOOQ does not actually need a connectionwhen it is just used to build
425 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
427 * src/main/java/org/glom/web/server/ReportGenerator.java:
429 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
431 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
432 Constructor, getListData(), getResultSizeOfSQLQuery():
433 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
434 getSelectQuery(), getCountQuery():
435 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
436 getSelectQuery(), getCountQuery():
437 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
438 getNavigationRecord(): Adapted.
440 2012-05-14 Murray Cumming <murrayc@murrayc.com>
444 * src/main/java/org/glom/web/server/SqlUtils.java:
445 get_find_where_clause_quick(): Use a comparison of
446 lowercase values, instead of a simple equals. Regular Glom
447 uses the PostgreSQL ILIKE operator but jOOQ does not
448 support that just yet, though it will soon.
450 2012-05-14 Murray Cumming <murrayc@murrayc.com>
452 TableToViewDetails: Use a real serialization ID.
454 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
455 Though this does not fix the serialization problem.
457 2012-05-12 Murray Cumming <murrayc@murrayc.com>
459 Added LayoutItemPortalDeepCloneTest.
461 2012-05-11 Murray Cumming <murrayc@murrayc.com>
463 Make navigation work again.
465 * src/main/java/org/glom/web/server/libglom/Document.java:
466 Add getLayoutItemFieldShouldHaveNavigation().
467 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
468 Replace get/setAddNavigation() with the partly-existing
469 get/setNavigationTableName(), with an empty string being no navigation,
470 because this is simpler. Use the new
471 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
473 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
474 Add updateFieldsExtras() and call setNavigationTableName in it.
475 getDetailsLayoutGroup(),
476 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
477 createLayout(): Adapted.
478 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
479 Constructor: Adapted.
481 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
482 Replace get/setAddNavigation() with get/setNavigation(), returning a
483 TableToViewDetails class with both the table name and UsesRelationship,
484 because both are need. The previous code used java-libglom's output
485 variable (strangely, via sharedptr) to return both, but we cannot really
487 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
488 getNavigationRecord(): Adapt. However, we cannot actually use the cache
489 here because it somehow gets set to null during deepCopy(). I must test this.
490 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
491 testGetSuitableTableToViewDetails(): Adapted.
493 TODO: Find out why deepClone() is not quite working.
495 2012-05-11 Murray Cumming <murrayc@murrayc.com>
497 DBAccess: Simplify the retrievel of full field details.
499 * src/main/java/org/glom/web/server/database/DBAccess.java
500 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
501 because the Document loading should have done this.
503 2012-05-11 Murray Cumming <murrayc@murrayc.com>
505 Document: Correct loading of doubly-related layout fields.
507 * src/main/java/org/glom/web/server/libglom/Document.java:
508 loadUsesRelationship(): Actually set the related relationship, instead
509 of only setting it if it's not found.
511 2012-05-09 Murray Cumming <murrayc@murrayc.com>
513 Replace all appearances of Colour with color.
515 Because US English is dominant.
517 2012-05-09 Murray Cumming <murrayc@murrayc.com>
519 Use colors in HTML format, solving a warning about an unused function.
521 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
522 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
523 Add *asHTMLColor() versions of methods.
524 TODO: However, we should create and cache the results on the server.
525 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
526 * src/main/java/org/glom/web/client/ui/list/ListTable.java
527 * src/main/java/org/glom/web/server/ConfiguredDocument.java
528 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
529 Use the asHTMLcolor() versions.
531 2012-05-09 Murray Cumming <murrayc@murrayc.com>
533 ListViewTable: Constructor: Take the table name as a parameter.
535 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
536 Constructor: Take the tableName, and set the member variable, because
538 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
539 setCellTable(): Pass the table name.
540 This makes navigation to non-default tables work again. I don't know
541 why it worked before in the master branch.
543 2012-05-07 Murray Cumming <murrayc@murrayc.com>
545 ConfiguredDocument: Restore correct addition of hidden primary key items.
547 * src/main/java/org/glom/web/client/ui/list/ListTable.java
548 (ListTable.createCellTable): Uncomment out the check for the hidden
550 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
551 add primary key items for top-level lists and portals, as before,
552 instead of adding them to each group.
553 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
554 Actually implement the extra methods such as setHiddenPrimaryKey() and
555 comment that these are used only for top-level list groups and in portals.
556 This strangeness suggests even more that this should not be squeezed
557 into the LayoutGroup class.
559 2012-05-07 Murray Cumming <murrayc@murrayc.com>
561 Fix Formatting loading.
563 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
564 getFormattingUsed(): Remove the duplicate Formatting member variable
565 in favour of the one from the base class.
566 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
567 Initialize a new Formatting instead of using null by default, so we
568 have some defaults, instead of having to initialize one later just to
569 get the same defaults. This also makes loading of formatting from the
570 document work, because that expected a non-null.
572 2012-05-07 Murray Cumming <murrayc@murrayc.com>
574 RelatedListTable: Make sure that the tableName is set.
576 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
577 Constructor: Take the tableName so it is available later. Otherwise,
578 the server assumes that we mean the default table and cannot find the
580 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
581 setData(): Pass the tableName to the RelatedListTable constructor.
583 2012-05-07 Murray Cumming <murrayc@murrayc.com>
587 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
588 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
589 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
591 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
593 * src/main/java/org/glom/web/server/database/DBAccess.java:
594 convertResultSetToDTO(), getPortal():
595 * src/main/java/org/glom/web/server/database/ListDBAccess.java
597 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
598 Add checks for null objects and out of range access, with log messages to
599 give hints so we can fix these properly.
601 2012-05-07 Murray Cumming <murrayc@murrayc.com>
603 Portals: some corrections.
605 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
607 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
608 constructor: Use getRelationshipNameUsed() instead of getName(), because
609 that is what is meant.
610 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
611 getFromField(): Fix a typo, to get the field name, not the table name.
612 * src/main/java/org/glom/web/server/database/DBAccess.java:
613 getPortal(): Fix a typo that stopped this from working.
615 2012-05-07 Murray Cumming <murrayc@murrayc.com>
617 LayoutItemPortal: Also override getTitleOriginal().
619 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
620 This lets the base getTitle() with no parameters work.
621 TODO: Test this properly.
623 2012-05-06 Murray Cumming <murrayc@murrayc.com>
625 LayoutItemPortal: getTitle*(): Use the relationship title.
627 2012-05-06 Murray Cumming <murrayc@murrayc.com>
629 LayoutItemField: Fix loading of custom titles.
631 * src/main/java/org/glom/web/server/libglom/Document.java
632 loadDataLayoutItemField(): The title, if any, instead of the field
633 title, is stored in a title_custom node. Load it from there.
634 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
636 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
637 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
638 getTitle*() overrides.
639 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
642 2012-05-06 Murray Cumming <murrayc@murrayc.com>
644 LayoutItemField: Fall back to field titles, so some are really shown.
646 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
647 Override getTitleOriginal() and getTitle(), as in java-libglom.
648 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
651 2012-05-06 Murray Cumming <murrayc@murrayc.com>
653 Correct use of setExpectedResultSize().
655 * src/main/java/org/glom/web/server/ConfiguredDocument.java
656 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
657 Use setExpectedResultSize only on top-level groups (for instance, the
658 list layout) or on child portals (in details views).
659 Use the correct table name for portals to avoid SQL errors.
660 Update the expected counts when returning cached layouts.
662 2012-05-06 Murray Cumming <murrayc@murrayc.com>
664 Document: Interpret no group column count as 1.
666 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
667 default, though we now check for this in the UI code anyway.
669 2012-05-06 Murray Cumming <murrayc@murrayc.com>
673 2012-05-06 Murray Cumming <murrayc@murrayc.com>
675 Translatable: Use Hashmap instead of Treemap because GWT supports it.
677 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
678 The use of Treemap lead to this error from async methods, with no
680 "The response could not be deserialized"
682 2012-05-06 Murray Cumming <murrayc@murrayc.com>
684 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
686 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
687 when using the Google -> GWT Compile, or
688 g toolbar button -> GWT Compile Project... feature in Eclipse.
690 2012-05-06 Murray Cumming <murrayc@murrayc.com>
692 ListTable.addColumn(): Protect against a null Formatting.
694 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
695 Create a default Formatting if it is null, because that is the simplest
698 2012-05-06 Murray Cumming <murrayc@murrayc.com>
700 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
702 * src/main/java/org/glom/web/server/ConfiguredDocument.java
703 updateLayoutGroup(): Check that the field is not null.
705 2012-05-06 Murray Cumming <murrayc@murrayc.com>
707 ListViewImpl: Protected against a bad cast error.
709 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
710 onEnterKeyDown(): Do not cast without an instanceof check.
712 2012-05-06 Murray Cumming <murrayc@murrayc.com>
714 ListTable: Protect against an out of range error.
716 * src/main/java/org/glom/web/client/ui/list/ListTable.java
717 createCellTable(): This is unlikely, but can happen while debugging.
719 2012-05-06 Murray Cumming <murrayc@murrayc.com>
721 AsyncMessage onFailure() callbacks: Log the exception message.
723 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
724 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
725 * src/main/java/org/glom/web/client/activity/ListActivity.java:
726 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
727 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
728 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
729 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
730 These are useful clues when something is wrong.
732 2012-05-06 Murray Cumming <murrayc@murrayc.com>
734 ConfiguredDocument: Avoid a null dereference.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java
737 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
738 details maps are created.
740 2012-05-06 Murray Cumming <murrayc@murrayc.com>
742 Document: Correct the port number parsing.
744 * src/main/java/org/glom/web/server/libglom/Document.java:
745 This lets us actually connect to the database and show the document.
747 2012-05-05 Murray Cumming <murrayc@murrayc.com>
751 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
752 user-interaction, asking us to load a temporary URL in a browser.s
753 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
754 which is apparently necessary for testing the service. See the comment.
755 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
756 Show the exception, if any. This is how I saw the 404 in the HTML in
759 2012-05-05 Murray Cumming <murrayc@murrayc.com>
761 DocumentTest: Move the .glom files into the resources directory.
763 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
764 URI via getResource().
766 2012-05-05 Murray Cumming <murrayc@murrayc.com>
768 Document: Remove the FieldIdentifies inner class.
770 * src/main/java/org/glom/web/server/libglom/Document.java: We only
771 use the Relationship (though the same function in libglom is maybe
772 used in other ways) and so this removes a compiler warning.
774 2012-05-05 Murray Cumming <murrayc@murrayc.com>
776 Document.load() Remove the error code parameter.
778 * src/main/java/org/glom/web/server/libglom/Document.java: load():
779 Remove the parameter. We do not set it yet and it could never have
780 worked as an output parameter (though maybe it did in java-libglom).
781 We could use an exception if we really want the failure reason.
782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
784 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
785 setUp(), testGetSuitableTableToViewDetails(): Adapt.
787 2012-05-05 Murray Cumming <murrayc@murrayc.com>
789 Make some inner classes static.
791 * src/main/java/org/glom/web/server/ConfiguredDocument.java
792 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
793 * src/main/java/org/glom/web/server/ReportGenerator.java
794 * src/main/java/org/glom/web/server/libglom/Document.java
795 Make all inner classes static that can be static.
797 2012-05-05 Murray Cumming <murrayc@murrayc.com>
799 OnlineGlomServiceImpl: Do not load and check for java-libglom.
801 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
802 init(): We do not use java-libglom any more.
804 2012-05-05 Murray Cumming <murrayc@murrayc.com>
806 Remove mentions of java-libglom.
808 * README: Remove mention of java-libglom, because it no longer needed.
809 * utils/build-onlineglom-war.sh:
810 * utils/check-and-recover-tomcat.py:
811 * utils/install-onlineglom-war.sh: Remove these as they are no longer
812 useful. Building is now far easier, with no need for jhbuild.
814 2012-05-05 Murray Cumming <murrayc@murrayc.com>
816 Fix the build (mvn package)
818 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
819 (LayoutGroup): Make the LayoutItemList inner class static and protected.
820 Otherwise the GWT Java->Javascript compilation fails with just this
821 error, during mvn package or when attempting to view in a browser,
822 in the GWT developer mode in Eclipse.
824 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
825 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
826 [INFO] Compiling module org.glom.web.OnlineGlom
827 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
828 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
829 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
830 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
831 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
832 [INFO] [ERROR] Cannot proceed due to previous errors
834 It has taken me 2 days to find out what was causing that. After reducing
835 the code, the compiler eventually showed me the full error message.
837 2012-05-04 Murray Cumming <murrayc@murrayc.com>
839 ConfiguredDocument: Cache the cloned and stripped layouts.
841 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
842 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
843 layout in a map, so we can retrieve it again without rebuilding it.
845 2012-05-04 Murray Cumming <murrayc@murrayc.com>
847 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
849 2012-05-04 Murray Cumming <murrayc@murrayc.com>
851 libglom classes: Implement some auto-generated emthods.
853 2012-05-04 Murray Cumming <murrayc@murrayc.com>
855 Add GwtTestOnlineGlomService.
857 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
858 However, this (and the other GwtTest*) does not seem to run during
861 2012-05-04 Murray Cumming <murrayc@murrayc.com>
863 Remove use of unsupported features from client code.
865 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
866 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
867 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
868 Use our client version of StringUtils instead of the apache commons one.
870 However, the GWT Javascript compliation still fails.
872 2012-04-25 Murray Cumming <murrayc@murrayc.com>
874 Add a Field class and implement some loading of it in Document.
876 2012-04-25 Murray Cumming <murrayc@murrayc.com>
878 Initial Document loading implementation, instead of libglom.
880 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
881 and Translatable classes, and adapt the rest of the code to use them.
882 However, this is still missing Layout and Field classes and loading.
884 2012-04-24 Murray Cumming <murrayc@murrayc.com>
886 Use of jOOQ: Move Field creation into a utility method.
888 * src/main/java/org/glom/web/server/SqlUtils.java:
889 This lets us improve it more easily.
891 2012-04-24 Murray Cumming <murrayc@murrayc.com>
893 Use of jOOQ: Improve the code to COUNT a sub-select.
895 * src/main/java/org/glom/web/server/SqlUtils.java:
896 Move initial query creation into
897 build_sql_select_step_with_where_clause().
898 build_sql_select_count_rows(): Use the jOOQ API instead of
899 concatentating text, because a jOOQ Select*Step is a TableLike,
900 which is what from() takes.
902 2012-04-23 Murray Cumming <murrayc@murrayc.com>
904 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
906 * pom.xml: Depend on jooq.
907 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
908 methods with jOOQ, based on the C++ implementations in libglom,
909 with some changes to the logic required by jooQ.
910 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
912 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
913 * src/main/java/org/glom/web/server/ReportGenerator.java:
914 * src/main/java/org/glom/web/server/SqlUtils.java:
915 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
916 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
917 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
918 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
919 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
920 Adapt. In particular, the SqlUtils methods now need to take a Connection,
921 because jOOQ needs that, though it seems unnecessary.
923 This is not quite finished. Ideally jOOQ would help us to build
924 table_name.field_name names, quoting and escaping them properly.
925 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
927 2012-04-21 Murray Cumming <murrayc@murrayc.com>
929 Move use of Glom.build_sql*() into a new SqlUtils class.
931 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
932 to wrap Glom.build_sql*(). The parameter types are still Glom one,
933 but this will make it easier to start using something other than
934 libglom or SqlBuilder.
936 2012-04-21 Murray Cumming <murrayc@murrayc.com>
938 Update the project URL.
940 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
942 2012-04-21 Murray Cumming <murrayc@murrayc.com>
944 Main layout: Use a FlowTable instead of absolute positioning.
946 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
947 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
948 child panels/widgets must have an absolute position. But that is annoying, so
949 this adds a FlowTable and puts the child panels in there.
951 2012-04-21 Murray Cumming <murrayc@murrayc.com>
953 GwtTestOnlineGlom: Comment out unused code.
955 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
956 Eclipse has started to say that some code is unused.
958 2012-04-21 Murray Cumming <murrayc@murrayc.com>
960 Update to the latest versions of dependencies.
962 * pom.xml: Update version numbers of dependencies to the latest
964 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
966 * src/main/java/org/glom/web/server/ReportGenerator.java:
967 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
968 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
969 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
971 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
972 Modify the imports where necessary.
974 2012-04-17 Murray Cumming <murrayc@murrayc.com>
976 Style: Remove overflow:hidden from searchbox
978 * src/main/webapp/style.css: Because this pushes the Back To Link
979 label/link on to the next row, which is then hidden due to the
980 hard-coded (in ems) height.
982 2012-04-20 Murray Cumming <murrayc@murrayc.com>
984 Remove some duplicate code.
986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
987 getDocumentInfo(): This must have been duplicated during the merge from the
992 2012-04-19 Murray Cumming <murrayc@murrayc.com>
994 Reports: Localize the waiting for report message.
996 * src/main/java/org/glom/web/client/activity/ReportActivity.java
997 start(): Get the message from the contants.
998 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1000 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1001 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1002 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1003 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1004 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1005 Update these files with the English text for newer strings for now.
1007 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1009 Reports: Show a message while waiting for the report.
1011 * src/main/java/org/glom/web/client/ui/ReportView.java
1012 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1013 Add setWaitingText(), to show a message saying that we are
1014 waiting for the report to be ready.
1015 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1016 start(): Call setWaitingText() before calling the async
1019 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1021 ReportGenerator: Specify date and time formats.
1023 * src/main/java/org/glom/web/server/ReportGenerator.java:
1024 createFieldValueElement(): Use the default (and localized)
1025 short formats, though we still need a way to show 4-digit
1026 years without providing the format for every locale.
1027 * src/main/java/org/glom/web/server/database/DBAccess.java:
1028 convertResultSetToDTO(): Use the short formats here too.
1030 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1032 ReportGenerator: Use the correct numeric formatting.
1034 * src/main/java/org/glom/web/server/ReportGenerator.java
1035 createFieldExpression(), createFieldValueElement(): Take the
1036 whole LayoutItem_Field instead of just the field name, so
1037 we have access to the formatting.
1038 createFieldValueElement(): Use JRTextField.setPattern() to
1039 specify the numeric formatting, with the help of a
1040 regular DecimalFormat.
1042 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1044 ReportGenerator: Avoid showing null for group by titles.
1046 * src/main/java/org/glom/web/server/ReportGenerator.java
1047 generateReport(): Use setBlankWhenNull() on the field title
1048 style too, because this is used for values in group by
1051 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1053 ReportGenerator: Add a colon to titles in vertical groups.
1055 * src/main/java/org/glom/web/server/ReportGenerator.java
1056 addFieldToDetailBandVertical(): Pass true for the withColon
1059 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1061 ReportGenerator: Simplify the code by using Position more.
1063 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1065 Reports: Support vertical groups, roughly.
1067 * src/main/java/org/glom/web/server/ReportGenerator.java:
1068 addToReport(): Rename to addGroupToReport() and, if necessary,
1069 call the new addVerticalGroupToReport() method.
1070 createFieldValueElement(): Let the caller specify the Y position
1073 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1075 Reports: Allow a second report to be shown.
1077 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1078 clear(): Do not remove the HTML widget, which broke the whole layout.
1080 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1082 Locales drop-down: Show that we use English by default.
1084 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1085 fillView(): When we use English, just because that is the default, when
1086 no locale is specified, show that in the Locales drop-down instead of
1087 just showing the first item.
1089 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1091 Unselect the Report/Locale/Table combo item when appropriate.
1093 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1094 setPlace(): clear reportName if this is not a ReportPlace.
1095 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1096 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1097 When the provided name is empty, unselect all items, so that none are
1098 indicated. This uses a for loop because I cannot find a single method
1101 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1103 Report: Give the user a way to get back to the list.
1105 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1106 start(), setPlace(): Show the Back To List link on reports, and also
1107 interpret selecting the empty report item as back to list.
1109 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1111 Really show the selected Report name.
1113 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1114 setPlace(): Store the reportName here, if it is that kind of Place.
1115 fillView(): Set the selected Report after filling the list of reports.
1116 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1117 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1118 null Strings, though we need some way to unselect all ListBox items
1121 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1123 ReportGenerator: Try to avoid some problems.
1125 * src/main/java/org/glom/web/server/ReportGenerator.java
1126 addField(): Try to avoid duplicates, and avoid using a null
1129 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1131 Reports: Use quickFind.
1133 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1134 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1136 getReportHTML(): Add a quickFind parameter.
1137 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1138 start(): Pass the quickFind parameter.
1139 * src/main/java/org/glom/web/server/ReportGenerator.java
1140 generateReport(): Take a quickFind parameter.
1142 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1144 ReportPlace: Actually use the report name.
1146 * src/main/java/org/glom/web/client/place/ReportPlace.java
1147 getPlace(): Do not assign the report name to the quickfind.
1149 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1151 Show java.library.path when complaining.
1153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1154 init(): When telling us to check java.library.path, show the
1157 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1159 ReportGenerator: Do not show nulls.
1161 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1163 ReportGenerator: Make the title font larger.
1165 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1167 ReportGenerator: Put field titles inside groups, if there are groups.
1169 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1171 ReportGenerator: Take the Report itself instead of the name and group.
1173 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1174 Remove getReportLayoutGroup().
1175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1176 getReportHTML(): Pass the report instead
1177 of its name and layout group.
1178 * src/main/java/org/glom/web/server/ReportGenerator.java
1179 generateReport(): Use the report object to use the title
1180 instead of the name.
1182 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1184 ReportGenerator: Remove designBand parameters.
1186 * src/main/java/org/glom/web/server/ReportGenerator.java:
1187 Make designBand a class member instead of passing it to all
1190 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1192 ReportGenerator: Add lines, a bit like in the desktop version.
1194 * src/main/java/org/glom/web/server/ReportGenerator.java
1195 addToReport(): Use JRDesignLine.
1197 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1199 ReportGenerator: Correct the title positions and use some bold style.
1201 * src/main/java/org/glom/web/server/ReportGenerator.java:
1202 Break the code up into reusable functions, correct the placement of
1203 titles, and use normal/bold styles as in the reports in the desktop
1206 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1208 ReportGenerator: Add a header band to show the field titles.
1210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1211 getReportHTML(): Pass the localeId to the ReportGenerator
1213 * src/main/java/org/glom/web/server/ReportGenerator.java
1214 constructor: Take the localeID so we can get translated field
1216 generateReport(), addToReport(), addFieldToBand(): Add field
1217 titles in a column header band.
1219 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1221 Reports drop-down list: Some improvement.
1223 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1224 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1225 Adedd setSelectedReport(),
1226 setReportList(): Add a blank line so that the user can select the
1228 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1229 start(): Show the current report by calling setSelectedReport().
1230 This does not seem to work yet.
1232 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1234 DetailsActivity, ListActivity: Move some variables into a base class.
1236 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1237 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1238 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1239 the clientFactory, documentID, tableName and authenticationPopup into
1240 a base class, to avoid duplication.
1242 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1244 Translate the Reports label.
1246 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1247 Get the "Reports" label string from the constants.
1248 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1249 perties: Add Reports to the constants.
1251 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1253 Reports: Implement grouping.
1255 * src/main/java/org/glom/web/server/ReportGenerator.java:
1256 Handle LayoutItem_GroupBy items and try to do the right thing
1257 with JRDesignGroup. It seems to work.
1259 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1261 Actually show some data with JasperReports.
1263 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1264 getReportHTML(): Move most code into a ReportGenerator class.
1265 * src/main/java/org/glom/web/server/ReportGenerator.java:
1266 Recurse into sub-groups, adding fields to the JasperDesign's details
1267 band. Note that we must set an arbitrary width and height, or it just
1268 will not show any data.
1270 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1272 Reports Chooser: Show the titles, not the names.
1274 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1275 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1276 and the names as the values.
1277 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1278 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1279 group now that we provide the report name, so it should always
1282 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1284 Depend on jasperreports.
1286 * pom.xml: Add the dependency. My plan is to use this on the
1289 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1291 Implement navigation to report places.
1293 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1294 start(): Do not bother to handle all events here.
1295 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1296 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1297 Added getSelectedReport().
1298 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1299 .java: start(): When handling a change to the reports chooser,
1300 call getSelectedReport() and goTo() its ReportPlace.
1301 * src/main/java/org/glom/web/client/ui/ReportView.java
1302 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1303 Added setReportHTML() which puts the html in a gwt HTML widget.
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1305 getReportHTML(): Return "TODO" just to show that this works.
1307 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1309 Make ReportPlace usable.
1311 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1312 Mention ReportPlace.
1313 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1314 Correct the @prefix annotation.
1316 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1318 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1320 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1321 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1323 Change getReportLayout() to getReportHMTL() because we will not need to
1324 parse or render the report layout on the client side.
1325 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1326 getReportLayout(): Return the libglom LayoutGroup type because we will
1327 not need to convert to a shared type, because this will not be used on
1329 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1332 Note that there is still no implementation for this.
1335 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1337 Add a (empty) Report Place, View, and Activity.
1339 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1341 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1342 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1343 this into a superclass:
1344 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1345 and also use it as the base of this new ReportPlace:
1346 * src/main/java/org/glom/web/client/place/ReportPlace.java
1348 * src/main/java/org/glom/web/client/ui/ReportView.java
1349 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1350 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1351 Add these, containing mostly boiler-plate for now.
1353 * src/main/java/org/glom/web/client/OnlineGlomService.java
1354 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1355 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1356 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1357 Add API to get the LayoutGroup for the report.
1359 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1361 Add and fill a Reports drop-down list box.
1363 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1365 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1366 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1367 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1368 Added getReports(document, table, localeID), calling
1369 ConfiguredDocument.getReports().
1370 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1371 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1372 Added setReportsList() and a list widget.
1373 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1374 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1379 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1381 Translations: Add Esperanto.
1383 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1384 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1385 properties: Add this translation because someone took the time to make it.
1387 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1389 Adapt to the java-libglom 1.21.7 API.
1391 * src/main/java/org/glom/web/server/ReportGenerator.java:
1392 addToReport(): get_group_secondary_fields() is now
1393 get_secondary_fields().
1396 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1398 Use the latest java-libglom version.
1400 * pom.xml: Use java-libglom 1.21.7.
1402 2012-03-03 Ben Konrath <ben@bagu.org>
1404 Display date and time in details view.
1406 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1408 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1410 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1412 Require the latest java-libglom.
1414 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1416 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1418 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1420 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1421 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1422 an empty quickfind string. I also corrected libglom to create only
1423 empty where clauses for empty quickfind strings, but this avoids the
1426 2012-02-24 Ben Konrath <ben@bagu.org>
1428 Improve the tabs in the Notebook widget.
1432 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1434 Translations: Try to translate the strings.
1436 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1437 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1438 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1439 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1440 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1441 Take the Open translation from GTK+'s .po files.
1442 Take the Details translation from Glom's po files.
1443 I have added the other strings to Glom so we can get translations that way:
1444 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1446 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1448 TableSelectionViewImpl: Put the search label and entry in a div.
1450 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1451 Put the search widgets in a FlowTable so that the CSS can be used to
1452 style them while keeping them together.
1453 * src/main/webapp/style.css: Mention the new div.
1455 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1457 Translate more strings in more locales.
1459 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1460 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1461 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1462 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1463 Translate the "Details" and "Open" string too.
1465 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1466 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1467 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1468 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1469 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1470 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1471 Add these new locales as placeholders though they currently contain English.
1473 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1475 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1477 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1478 Check the ConfiguredDocument* for null before using it.
1480 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1482 Tell Eclipse about the generated java files.
1484 * .classpath: This lets it find OnlineGlomConstants.java.
1485 It would be nice if Eclipse just used the maven build files.
1487 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1489 Prevent a crash when no locale is specified in the URL.
1491 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1492 Avoid returning a null string, obtained from
1493 Window.Location.getParameter(). This caused a crash when it was
1494 later passed to libglom's API.
1495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1496 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1497 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1498 guard against future null strings.
1500 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1502 Use the ?locale= query param instead of the &lang= token param.
1504 * src/main/java/org/glom/web/client/place/ListPlace.java
1505 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1506 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1507 Remove the lang token key and value.
1509 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1510 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1511 When the user selects a different locale from the chooser, use
1512 Window.Location.assign() to change the URL, which then causes a reload.
1514 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1515 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1516 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1517 * src/main/java/org/glom/web/client/activity/ListActivity.java
1518 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1519 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1520 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1521 * src/main/java/org/glom/web/client/ui/ListView.java:
1522 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1524 Remove localeID member variables and method/constructor parameters, instead
1525 using Utils.getCurrentLocaleID() when we need a localID to pass to
1528 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1530 Internationalize the UI strings.
1532 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1533 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1534 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1535 because it is unused. Messages are apparently strings that can have
1536 parameters, but we do not need that yet, so Contants will be enough for now.
1537 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1538 to say that we support the en and de locales.
1539 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1540 The original English strings.
1541 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1542 Some German translations of the English strings.
1543 The i18n goal then uses the .properties file to generate an
1544 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1545 returns an implementation that returns the translated strings.
1546 The documentation suggests putting these in src/java/*/client/, but it seems
1547 best to put it in src/resources/*/client/.
1548 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1549 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1550 instead of hard-coding them.
1551 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1552 but that does not seem to stop the build, though it confuses Eclipse.
1554 You can see the translated string by adding ?locale=de to the URL, like so:
1555 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1557 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1559 Improve null/empty String checks.
1561 * pom.xml: Add a dependency on commons-lang, to use
1562 org.apache.commons.lang.StringUtils.
1563 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1564 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1565 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1566 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1567 Use StringUtils.isEmpty().
1569 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1570 StringUtils class with a static isEmpty() function because we
1571 cannot use org.apache.commons.lang.StringUtils in client-side
1572 GWT code because it (apparently) cannot be compiled to javascript.
1573 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1574 * src/main/java/org/glom/web/client/activity/ListActivity.java
1575 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1576 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1577 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1578 * src/main/java/org/glom/web/client/place/ListPlace.java
1579 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1580 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1581 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1582 * src/main/java/org/glom/web/client/ui/details/Group.java
1583 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1584 our StringUtils.isEmpty() function.
1586 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1588 Update to the latest java-libglom API.
1590 * pom.xml: Require java-libglom 1.21.4.
1591 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1592 getDocumentInfo(), getListViewLayoutGroup():
1593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1595 * src/main/java/org/glom/web/server/database/DBAccess.java
1596 getFieldsToShowForSQLQueryAddGroup(),
1597 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1598 with either get_database_title_original() or
1599 get_database_title(localeID).
1601 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1603 ConfiguredDocument: Avoid a null pointer exception.
1605 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1606 Initialize localeID to "" to avoid returning a null String which
1607 causes a crash in java-libglom's swing-generated code.
1609 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1611 Some simple renaming.
1613 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1614 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1615 for localeChooser. This seems more appropriate and is less ambiguous
1616 particularly in the .css file.
1618 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1620 ConfiguredDocument: Rename the localedID private member variable.
1622 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1624 Adapt to the latest java-libglom API from git master.
1626 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1627 libglom now uses only Vector instead of List, which uses add() instead of
1630 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1632 ConfiguredDocument: Rename the localedID private member variable.
1634 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1636 Build a source tarball with mvn assembly:single
1638 * assembly.xml: Add this file.
1639 * pom.xml: Use the maven-assembly-plugin and tell it to use
1640 our assembly.xml file.
1642 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1644 OnlineGlomServiceImpl: Get .glom files recursively.
1646 * pom.xml: Depend on commons-io from org.apache.commons.
1647 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1648 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1649 files recursively, and with the easier filter for the extension.
1650 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1651 simplify that code too.
1653 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1655 README: Mention that you must install java-libglom packages separately.
1657 But then it works, because java-libglom is now in the central maven
1660 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1662 locales drop-down: Show the correct selected locale when the URL changes.
1664 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1665 .java: setPlace(): Move some code into fillView().
1667 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1669 locales drop-down: Do not lose the primary key.
1671 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1672 start(): onLocaleChange(): Pass the current primary key value,
1673 instead of an empty value.
1675 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1677 locales drop-down: Do not lose the drop-down selection.
1679 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1680 .java (TableSelectionActivity.fillView): Set the selected locale
1681 after changing the drop-down items (though we do not really need
1682 to change them just because the locale changes.)
1684 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1686 locales drop-down: Change the tables list when this changes.
1688 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1689 .java: TableSelectionActivity.start(): Move the async table titles
1690 retrieval into a private fillView() method and also call this when
1691 the chosen locale changes.
1692 Note that the document title is not actually translatable yet, but
1693 that is a problem that I should fix soon in libglom.
1695 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1697 Improve the placement of the locales drop-down.
1699 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1700 Put the title and locales drop-down in a div (gwt.FlowTable).
1701 * src/main/webapp/style.css: Add magic css properties to make this work.
1702 Also remove the left margin from the title so that it lines up with the
1705 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1707 locales selector: Show human-readable locale titles.
1709 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1710 getDocumentInfo(): Use java.util.Locale to show a real title of
1711 each locale, in the locale's own language.
1713 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1715 Add a language/locale selector drop-down.
1717 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1718 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1719 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1720 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1721 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1722 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1723 Add a ListBox to show the available locales. Add getLocaleSelector(),
1724 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1725 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1726 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1727 java: Add these classes.
1728 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1729 start(): Fill the locales ListBox. Handle its change event, firing a
1731 setPlace(): Show the selected locale as specified by the URL token.
1732 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1733 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1734 Handle LocaleChangeEvent, going to a new *Place with that locale.
1736 The placement of the ListBox is not pretty, and it currently uses the ID
1737 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1741 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1743 Search box: Show the search text from the URL token.
1745 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1746 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1747 Add setQuickFindText().
1748 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1749 .java: setPlace(): Store the queryText if the place is a ListPlace,
1750 and call TableSelectionView.setQuickFindText().
1752 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1754 Allow use of translations via, for instance, &lang=de in the URL.
1756 * pom.xml: Use the unstable java-libglom 1.21 version.
1758 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1759 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1761 init(): Instead of calling TranslatableItem.set_current_locale()
1762 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1763 However, this is only for default locales, which are not needed to
1764 change the locale in the URL.
1765 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1766 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1767 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1768 layout for a particular locale.
1769 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1770 Add get/setDefaultLocaleID().
1771 getDocumentInfo(), getListViewData(), getRelatedListData(),
1772 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1773 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1774 localeID parameter, so we can get the layout for a particular locale.
1776 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1777 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1778 * src/main/java/org/glom/web/client/place/ListPlace.java:
1779 Parse and construct a lang parameter too.
1781 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1782 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1783 passed to subsequent methods and constructors.
1784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1785 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1786 Store the localeID from the *Place and pass it to other constructors
1787 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1789 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1790 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1791 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1792 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1793 * src/main/java/org/glom/web/client/ui/ListView.java:
1794 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1795 Take localeID parameters and pass them to subsequent constructors and
1796 methods, so that the layout is always retrieved for that locale.
1798 This is rather repetitive.
1800 Note that "" means the original (default) locale of the Glom document,
1801 which is usually English.
1803 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1805 Documents: Remove final keyword to fix startup configuration.
1807 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1808 final keywords on the private member variables because that breaks
1809 the startup, apparently (there are warnings) because it stops them
1810 from being serialized. I added these in the previous commit.
1812 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1814 Documents: Add some final keywords.
1816 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1819 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1821 OnlineGlomServiceImpl: Add to overview comments.
1823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1824 Note that this is where all the document are loaded. They are not
1825 loaded freshly for each page.
1827 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1831 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1832 Add a TextBox for the text of a quick find.
1833 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1835 setBackLink(): Add a String quickFind parameter.
1836 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1837 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1838 to the base interface, because that is how TableSelectionViewImpl is used.
1839 * src/main/webapp/style.css: Add style for the search box and its label.
1841 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1842 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1843 Add these files, based on the existing TableChangeEvent and
1844 TableChangeEventHandlers.
1845 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1846 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1847 a ListPlace() that the user should be taken to.
1848 * src/main/java/org/glom/web/client/activity/ListActivity.java
1849 start(): Handle it here too and adapt the TableChangeEvent handler to
1850 pass the extra "" quickFind parameter to ListPlace.
1851 * src/main/java/org/glom/web/client/place/ListPlace.java:
1852 Constructor: Take an extra String quickFind parameter and store it,
1853 returning it from a new getQuickFind() method.
1854 getToken(): Put the quickFind text in the URL token.
1855 getPlace(): Parse the quickFind text from the URL token.
1856 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1857 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1858 ListPlace constructor.
1859 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1860 .java: start(): Add a Change handler for the TableSelectionView's
1861 TextBox (via its base HasChangeHandlers interface), firing the new
1862 QuickFindChangeEvent.
1863 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1864 pass the extra "" quickFind parameter.
1866 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1867 setCellTable(): Add a String quickFind parameter and pass it to
1868 the ListViewTable() constructor.
1869 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1870 setCellTable() in the base interface, because that is how ListViewImpl
1873 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1874 Add a String quickFind member variable.
1875 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1876 Constructor: Add a String quickFind parameter, storing it in the
1877 base ListTable's member variable.
1878 onRangeChanged(): Pass quickFind to the
1879 OnlineGlomServiceAsync.getSortedListViewData() and
1880 OnlineGlomServiceAsync.getListViewData() methods.
1882 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1883 getListViewData(), getSortedListViewData(): Add a String quickFind
1884 parameter, passing it to ConfiguredDocument.getListViewData().
1885 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1886 Change getListViewData(), getSortedListViewData() in the base interface,
1887 because that is how OnlineGlomServiceImpl is used, via this:
1888 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1889 Change getListViewData(), getSortedListViewData() here too.
1890 This class can apparently be used to asynchronously call methods on
1891 OnlineGlomService, and GWT seems to implement that after recognizing
1892 just the *Async name convention and the extra AsyncCallback parameters.
1894 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1895 getListViewData(): Add a String quickFind parameter, and pass it to
1896 ListViewDBAccess.getData().
1897 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1898 getListData(): Add a String quickFind parameter and pass it to
1900 getSelectQuery(): Add a String quickFind parameter.
1901 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1902 getSelectQuery(): Add a String quickFind parameter and use it with
1903 Glom.get_find_where_clause_quick() to pass a where_clause to
1904 Glom.build_sql_select_with_where_clause(), to actually filter the
1906 getData(): Add a String quickFind parameter, passing it to getListData().
1907 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1908 va: getData(): Pass an empty string to getListData() for the
1909 quickFind parameter.
1911 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1913 ListTable: Minor change.
1915 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1916 createCellTable(): Make this protected instead of public.
1918 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1920 Many files: Use final for the parameters and use the @override attribute.
1922 2012-01-22 Ben Konrath <ben@bagu.org>
1924 Add anchor links for single line text that starts with http, ftp and www.
1928 2012-01-22 Ben Konrath <ben@bagu.org>
1930 Add ellipsis to single line text in details view.
1934 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1936 Remove all javadoc author tags.
1938 Because they are awkward and meaningless when many people touch
1940 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1942 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1944 Revert the COPYING.LESSER to COPYING rename.
1946 Apparently both should be there if it is LGPL.
1948 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1950 *View: Remove unused imports.
1952 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1953 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1954 * src/main/java/org/glom/web/client/ui/ListView.java:
1955 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1956 Remove unused imports, as suggested by Eclipse.
1958 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1960 Move the *View::Presenter types, and some API into one base View.
1962 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1963 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1964 * src/main/java/org/glom/web/client/ui/ListView.java:
1965 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1966 Presenter, setPresenter() and clear() into a shared base interface,
1967 to avoid the unnecessary duplicate Presenter types and to more clearly
1968 show how the *Views share the same structure, even if they are not
1969 used polymorphically.
1971 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1972 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1974 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1975 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1976 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1978 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1981 Feel free to revert this if there is a good reason for the duplicate
1984 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1986 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1988 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1989 a class member instead of a local variable in the method.
1990 This lets us use it to get the view instances, for use in tests.
1991 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1992 beforeOnlineGlom(): Test some more details of the initial view.
1993 Again, this is not very useful.
1995 To really test gwt-glom we will need to start a local postgresql
1996 instance with local data, like the Glom tests in C++.
1998 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2000 pom.xml: Mention the LGPL license.
2002 * pom.xml: Add a licenses section.
2003 * COPYING.LESSER: Move this to COPYING, which
2004 previously contained the GPL. But gwt-glom is all LGPL.
2006 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2008 Add project information to README and pom.xml.
2010 * README: Add a brief description and mention some mvn
2012 * pom.xml: This extra information shows up in mvn site
2015 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2017 Use the latest java-libglom version.
2019 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2021 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2023 GwtTestOnlineGlom: Test a little more.
2025 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2026 protected rather than private, as suggested by the gwt-test-utils
2028 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2029 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2030 Test the initial visibility of the panels.
2032 However, this is not a very useful test.
2033 And I wonder how we should generally test using this idea for an
2034 activity/places app like ours where the real changes happen implicitly
2035 based on the history token/URL.
2037 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2039 Slight modification to *Mapper comments.
2041 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2042 (DataActivityMapper)
2043 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2045 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2047 Remove comments mentioning GIN because they are just copied from
2048 the example code and are apparently not helpful:
2049 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2050 Also change the mention of a class that is only in the example code.
2052 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2054 GwtTestOnlineGlom test: Minor changes.
2056 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2057 Avoid the long qualified class name and modify the comment
2058 because it is now obvious to me that the mocked class is the only
2059 custom one created via GWT.create().
2061 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2063 Tests: Added the beginnings of a test using gwt-test-utils.
2065 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2066 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2067 which tells gwt-test-utils what class will be tested.
2068 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2069 Add a simple (but empty) test case. One class, used by the OnlineGlom
2070 class, is mocked so that it can be created. However, I am not sure
2071 why only this class needs to be mocked.
2073 Note that mockito seems more popular, and clearer, than easymock,
2074 but I have not got that working yet. It might be a matter of the
2077 This test is run during mvn integration-test.
2079 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2081 Tests: Use junit4-style syntax instead of junit3-style.
2083 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2084 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2085 * src/test/java/org/glom/web/shared/DataItemTest.java:
2086 Use the @Test annotation rather than relying on the test*() prefix.
2087 Also no longer implement TestCase, to avoid triggering support for
2088 the junit3-way, which stops the annotations from working.
2089 Change the imports from import junit.framework.* to
2090 import org.junit.*, which is apparently the new way.
2092 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2094 Added a test for ListPlace token parsing and creation.
2096 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2097 This is much the same as DetailsPlaceTest.
2099 I wonder how we could test the other parts of the *Place API.
2101 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2103 DetailsPlace test: Also test getToken() and recreation via getPlace().
2105 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2106 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2107 recreate it, testing the recreated DetailsPlace for the same parameter
2110 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2112 Use the surefire-report plugin.
2114 * pom.xml: This generates a HTML report about the tests in
2115 target/site/surefire-report.html
2116 when you do mvn surefire-report:report. It seems to be popular/normal.
2118 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2120 Added a test for DetailsPlace.
2122 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2123 Test the getPlace() token parsing.
2125 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2127 Added a first unit test.
2129 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2130 * src/test/java/org/glom/web/shared/DataItemTest.java:
2131 This is a silly test but it is just to get things started. Note that
2132 maven/junit finds the test because it looks in src/test by default.
2134 2011-12-22 Ben Konrath <ben@bagu.org>
2136 Change charsetName to "UTF-8" when replacing line breaks.
2138 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2139 that work in Java (such as "UTF8") will not work when compiled to
2142 This fixes a problem with multi-line details view fields that have hard
2143 line breaks. The "License Text" field on this page demonstrates the
2146 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2148 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2150 2011-12-22 Ben Konrath <ben@bagu.org>
2152 Fix another bug with related list navigation.
2154 I've tested all the navigation buttons in all of the related lists
2155 so things should be good now.
2157 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2159 2011-12-22 Ben Konrath <ben@bagu.org>
2161 Fix a crasher when refreshing the list view with the default table.
2163 This crash will also happen when loading the list view with the default
2164 table from a link or bookmark.
2166 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2167 to the main document selection page when the document id hasn't been
2169 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2170 the main document selection page when the document id hasn't been
2172 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2173 values for the details place when the document id hasn't been set.
2174 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2175 values for the list place when the document id hasn't been set.
2177 2011-12-21 Ben Konrath <ben@bagu.org>
2179 Protect against NPE when glom.document.locale is not in config.
2181 This patch protects against an NPE when glom.document.locale is not in
2182 the config file. This NPE will also happen if glom.document.locale is
2185 The patch also updates the error message to display the class name when
2186 the getMessage() returns null. This was happening when the NPE was
2187 thrown and I had "Configuration Error: null". If an NPE is encountered
2188 with this patch, "Configuration Error: NullPointerException " will be
2191 This commit closes this bug:
2193 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2197 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2199 Rename onlineglom.properties to onlineglom.properties.sample.
2201 * src/main/resources/onlineglom.properties: Rename to:
2202 * src/main/resources/onlineglom.properties.sample:
2203 * src/main/resources/README: And add this file explaining that people
2204 should rename it back when deploying.
2206 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2208 Allow choosing the translation in the .properties file.
2210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2211 init(): Read a glom.document.locale value from the configuration file
2212 and call Glom's TransatableItem::set_current_locale() method.
2213 * src/main/resources/onlineglom.properties: Add a commented-out
2214 example of this new setting.
2216 It would be better to add &lang=de_DE to the URL, but the current
2217 libglom API does not allow us to do this easily. I am working on that.
2219 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2221 Avoid a crash in parsing of token parameters.
2223 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2224 ava: getTokenParams(): Do not crash if a parameter has a key but no
2225 value, and ignore parameters with neither.
2227 2011-12-17 Murray Cumming <murrayc@murayc.com>
2229 History token building/handling: Improve use of token parameters.
2231 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2232 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2233 and buildParamsToken(HashMap), for use by derived classes.
2234 Make the separator private because it is no longer be needed.
2235 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2236 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2237 instead of manual string concatenation.
2238 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2239 of hardcoded indices and awkward splitting code.
2240 * src/main/java/org/glom/web/client/place/ListPlace.java
2241 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2242 instead of manual string concatenation.
2243 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2244 of hardcoded indices and awkward splitting code.
2245 This should fix bug #666420
2247 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2249 Fix a Navgiation->Navigation typo in the code.
2251 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2252 Rename processNavgiation() to processNavigation().
2254 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2256 Fix a seperator->separator typo in the code.
2258 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2259 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2260 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2263 2011-12-15 Ben Konrath <ben@bagu.org>
2265 Cleanup some comments.
2267 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2269 2011-12-14 Ben Konrath <ben@bagu.org>
2271 Replace \n with <br/> for multiline text in the details view.
2273 Vertical scrollbars are added when needed as well.
2275 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2277 2011-12-14 Ben Konrath <ben@bagu.org>
2279 Specify the font for document selection links.
2281 * src/main/webapp/style.css:
2283 2011-12-14 Ben Konrath <ben@bagu.org>
2285 Fix bouncy CellTable while paging.
2287 This doesn't currently work with related list tables in unselected
2290 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2292 2011-12-14 Ben Konrath <ben@bagu.org>
2294 Revamp the appearance of the document selection page.
2296 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2297 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2298 * src/main/webapp/style.css:
2300 2011-12-13 Ben Konrath <ben@bagu.org>
2302 Set navigation button column to the smallest size possible.
2304 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2306 2011-12-13 Ben Konrath <ben@bagu.org>
2308 Change OpenButton nomenclature to NavigationButton.
2310 Using NavigtionButton makes things more generic. Classes, methods and
2311 variables have been changed.
2313 This is a rename-only refactor.
2315 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2316 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2317 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2318 Renamed from OpenButtonCell.
2319 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2320 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2321 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2323 2011-12-12 Ben Konrath <ben@bagu.org>
2325 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2327 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2328 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2329 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2330 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2332 2011-12-12 Ben Konrath <ben@bagu.org>
2334 Update variable names and comments.
2336 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2337 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2339 2011-12-12 Ben Konrath <ben@bagu.org>
2341 Properly initialize numNonEmptyRows variable to zero.
2343 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2344 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2346 2011-12-05 Ben Konrath <ben@bagu.org>
2348 Add latest mockup with HTML tables.
2350 Features of this mockup:
2352 -> HTML table for flowtable
2353 -> HTML table for flowtable column
2354 -> Example of how related lists would look
2355 -> Not using text entries for data items
2357 The current version of Online Glom doesn't use HTML tables for the
2360 This mockup has been sent to the glom-devel mailing list but it's good
2361 to have it here as well.
2363 * mockups/details-view-html-tables.html:
2365 2011-12-05 Ben Konrath <ben@bagu.org>
2367 Remove unnecessary getPrimaryKeyField() method.
2369 getPrimaryKeyFieldForTable(String) has been renamed to
2370 getPrimaryKeyField(String).
2372 * src/main/java/org/glom/web/server/database/DBAccess.java:
2373 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2374 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2376 2011-12-05 Ben Konrath <ben@bagu.org>
2378 Add string representation of TypedDataItem value to conversion error message.
2380 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2381 message was extracted into its own method to avoid duplication.
2383 2011-12-05 Ben Konrath <ben@bagu.org>
2385 Add type checking to navigation primary key value creation.
2387 Create navigation primary key only if the expected type from the Glom
2388 document matches the type returned by the SQL query.
2390 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2392 2011-12-05 Ben Konrath <ben@bagu.org>
2394 Rename a couple of variables in RelatedListNavigation.
2396 This is a rename-only refactor.
2398 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2400 2011-12-05 Ben Konrath <ben@bagu.org>
2402 Move getListLayoutGroup() into getListViewLayoutGroup().
2404 This removes getListLayoutGroup(). It was only being called by
2405 getListViewLayoutGroup().
2407 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2409 2011-12-05 Ben Konrath <ben@bagu.org>
2411 Remove check for LayoutItem_Portal in list table method.
2413 This check is no longer necessary because the method isn't being used
2414 to create the LayoutItemPortal DTO.
2416 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2418 2011-12-05 Ben Konrath <ben@bagu.org>
2420 Properly support related list navigation.
2422 Navigation from the "Repository Analyzer -> Package Scans ->
2423 Dependencies" related table wasn't working because the primary key for
2424 related tables wasn't being set properly. This commit fixes the
2427 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2428 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2429 doesn't set the primary key properly for related list tables.
2430 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2431 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2432 useful for getting the primary key for list view tables and for related
2434 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2435 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2436 Move code to set the primary key for the table from the abstract
2437 ListDBAccess class to ListViewDBAccess as it's only correct for list
2439 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2440 Properly add primary key to related list tables.
2442 2011-12-02 Ben Konrath <ben@bagu.org>
2444 Properly set the horizontal alignment of fields.
2446 This fix is for both the list tables and the details view.
2448 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2449 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2450 to set the horizontal alignment of fields.
2452 2011-12-02 Ben Konrath <ben@bagu.org>
2454 Display currency codes in the details view.
2456 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2458 2011-12-02 Ben Konrath <ben@bagu.org>
2460 Avoid duplicate JNI call.
2462 JNI is not as efficient as pure Java and this is an easy (and small)
2465 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2466 Use previously retrieved value for whereClauseToTableName instead of
2469 2011-12-02 Ben Konrath <ben@bagu.org>
2471 Rename a couple of variables in RelatedListNavigation.
2473 This is a rename-only refactor.
2475 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2477 2011-12-02 Ben Konrath <ben@bagu.org>
2479 Indicate clearly that a mismatched primary key type is a bug.
2481 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2482 warning to error. Add 'This is a bug.' to message.
2484 2011-12-02 Ben Konrath <ben@bagu.org>
2486 Update / fix some comments.
2488 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2490 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2492 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2493 Fix comments. Add some TODOs.
2495 2011-12-02 Ben Konrath <ben@bagu.org>
2497 Enable navigation to details view with string primary key from related list.
2499 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2500 Create a text primary key value when return type of result is
2501 java.sql.Types.VARCHAR.
2503 2011-12-02 Ben Konrath <ben@bagu.org>
2505 Use checkboxes for booleans in the details view.
2507 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2509 2011-12-01 Ben Konrath <ben@bagu.org>
2511 Improve performance of related list height calculation.
2513 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2514 Put code to calculate the expected height in a static initializer so
2515 that that it's only called once.
2517 2011-12-01 Ben Konrath <ben@bagu.org>
2519 Show related list tables in notebooks (again).
2521 Calculate the height of the related list tables so the Notebook can be
2522 set the correct height. The height of the related list table is also needed by
2523 FlowTable to be able decide how to create the layout.
2525 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2526 and set the Portal height based on the height of the related list
2527 table and the Portal container.
2528 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2529 Add method to calculate the height of the related list tables.
2530 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2531 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2532 calculate the height of the Pager widget.
2534 2011-12-01 Ben Konrath <ben@bagu.org>
2536 Use CellTable API for table property instead of setting style on Element.
2538 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2540 2011-12-01 Ben Konrath <ben@bagu.org>
2542 Make ListViewTable and RelatedListTable a consistent height.
2544 The tables are now a consistent height regardless of the contents of
2545 the table. A hidden button is added to empty rows to ensure that the
2546 height of these rows will match the height of rows with data.
2548 A navigation button column is now added to every table. The width of
2549 the navigation column is set to 0px when a RelatedListTable shouldn't
2550 have navigation buttons. This maintains the a consistent row height in
2551 tables that don't show the navigation buttons.
2553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2554 navigation column when not needed.
2555 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2556 arguments for navigation button to constructor of ListViewTable.
2557 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2558 hidden button for empty data rows.
2559 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2560 arguments for navigation button to constructor.
2561 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2562 create navigation buttons. Add hideNavigationButtons() method.
2563 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2564 arguments for navigation button to constructor.
2566 2011-12-01 Ben Konrath <ben@bagu.org>
2568 Use 'visibility: hidden' in Utils.getWidgetHeight().
2570 This is better choice because hidden elements are invisible, don't
2571 respond to events and are not part of the tab order. They will,