1 2012-05-11 Murray Cumming <murrayc@murrayc.com>
3 Make navigation work again.
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 Add getLayoutItemFieldShouldHaveNavigation().
7 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
8 Replace get/setAddNavigation() with the partly-existing
9 get/setNavigationTableName(), with an empty string being no navigation,
10 because this is simpler. Use the new
11 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
13 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
14 Add updateFieldsExtras() and call setNavigationTableName in it.
15 getDetailsLayoutGroup(),
16 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
17 createLayout(): Adapted.
18 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
21 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
22 Replace get/setAddNavigation() with get/setNavigation(), returning a
23 TableToViewDetails class with both the table name and UsesRelationship,
24 because both are need. The previous code used java-libglom's output
25 variable (strangely, via sharedptr) to return both, but we cannot really
27 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
28 getNavigationRecord(): Adapt. However, we cannot actually use the cache
29 here because it somehow gets set to null during deepCopy(). I must test this.
30 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
31 testGetSuitableTableToViewDetails(): Adapted.
33 TODO: Find out why deepClone() is not quite working.
35 2012-05-11 Murray Cumming <murrayc@murrayc.com>
37 DBAccess: Simplify the retrievel of full field details.
39 * src/main/java/org/glom/web/server/database/DBAccess.java
40 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
41 because the Document loading should have done this.
43 2012-05-11 Murray Cumming <murrayc@murrayc.com>
45 Document: Correct loading of doubly-related layout fields.
47 * src/main/java/org/glom/web/server/libglom/Document.java:
48 loadUsesRelationship(): Actually set the related relationship, instead
49 of only setting it if it's not found.
51 2012-05-09 Murray Cumming <murrayc@murrayc.com>
53 Use colors in HTML format, solving a warning about an unused function.
55 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
56 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
57 Add *asHTMLColor() versions of methods.
58 TODO: However, we should create and cache the results on the server.
59 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
60 * src/main/java/org/glom/web/client/ui/list/ListTable.java
61 * src/main/java/org/glom/web/server/ConfiguredDocument.java
62 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
63 Use the asHTMLcolor() versions.
65 2012-05-09 Murray Cumming <murrayc@murrayc.com>
67 ListViewTable: Constructor: Take the table name as a parameter.
69 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
70 Constructor: Take the tableName, and set the member variable, because
72 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
73 setCellTable(): Pass the table name.
74 This makes navigation to non-default tables work again. I don't know
75 why it worked before in the master branch.
77 2012-05-07 Murray Cumming <murrayc@murrayc.com>
79 ConfiguredDocument: Restore correct addition of hidden primary key items.
81 * src/main/java/org/glom/web/client/ui/list/ListTable.java
82 (ListTable.createCellTable): Uncomment out the check for the hidden
84 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
85 add primary key items for top-level lists and portals, as before,
86 instead of adding them to each group.
87 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
88 Actually implement the extra methods such as setHiddenPrimaryKey() and
89 comment that these are used only for top-level list groups and in portals.
90 This strangeness suggests even more that this should not be squeezed
91 into the LayoutGroup class.
93 2012-05-07 Murray Cumming <murrayc@murrayc.com>
95 Fix Formatting loading.
97 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
98 getFormattingUsed(): Remove the duplicate Formatting member variable
99 in favour of the one from the base class.
100 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
101 Initialize a new Formatting instead of using null by default, so we
102 have some defaults, instead of having to initialize one later just to
103 get the same defaults. This also makes loading of formatting from the
104 document work, because that expected a non-null.
106 2012-05-07 Murray Cumming <murrayc@murrayc.com>
108 RelatedListTable: Make sure that the tableName is set.
110 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
111 Constructor: Take the tableName so it is available later. Otherwise,
112 the server assumes that we mean the default table and cannot find the
114 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
115 setData(): Pass the tableName to the RelatedListTable constructor.
117 2012-05-07 Murray Cumming <murrayc@murrayc.com>
121 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
122 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
123 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
125 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
127 * src/main/java/org/glom/web/server/database/DBAccess.java:
128 convertResultSetToDTO(), getPortal():
129 * src/main/java/org/glom/web/server/database/ListDBAccess.java
131 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
132 Add checks for null objects and out of range access, with log messages to
133 give hints so we can fix these properly.
135 2012-05-07 Murray Cumming <murrayc@murrayc.com>
137 Portals: some corrections.
139 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
141 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
142 constructor: Use getRelationshipNameUsed() instead of getName(), because
143 that is what is meant.
144 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
145 getFromField(): Fix a typo, to get the field name, not the table name.
146 * src/main/java/org/glom/web/server/database/DBAccess.java:
147 getPortal(): Fix a typo that stopped this from working.
149 2012-05-07 Murray Cumming <murrayc@murrayc.com>
151 LayoutItemPortal: Also override getTitleOriginal().
153 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
154 This lets the base getTitle() with no parameters work.
155 TODO: Test this properly.
157 2012-05-06 Murray Cumming <murrayc@murrayc.com>
159 LayoutItemPortal: getTitle*(): Use the relationship title.
161 2012-05-06 Murray Cumming <murrayc@murrayc.com>
163 LayoutItemField: Fix loading of custom titles.
165 * src/main/java/org/glom/web/server/libglom/Document.java
166 loadDataLayoutItemField(): The title, if any, instead of the field
167 title, is stored in a title_custom node. Load it from there.
168 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
170 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
171 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
172 getTitle*() overrides.
173 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
176 2012-05-06 Murray Cumming <murrayc@murrayc.com>
178 LayoutItemField: Fall back to field titles, so some are really shown.
180 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
181 Override getTitleOriginal() and getTitle(), as in java-libglom.
182 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
185 2012-05-06 Murray Cumming <murrayc@murrayc.com>
187 Correct use of setExpectedResultSize().
189 * src/main/java/org/glom/web/server/ConfiguredDocument.java
190 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
191 Use setExpectedResultSize only on top-level groups (for instance, the
192 list layout) or on child portals (in details views).
193 Use the correct table name for portals to avoid SQL errors.
194 Update the expected counts when returning cached layouts.
196 2012-05-06 Murray Cumming <murrayc@murrayc.com>
198 Document: Interpret no group column count as 1.
200 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
201 default, though we now check for this in the UI code anyway.
203 2012-05-06 Murray Cumming <murrayc@murrayc.com>
207 2012-05-06 Murray Cumming <murrayc@murrayc.com>
209 Translatable: Use Hashmap instead of Treemap because GWT supports it.
211 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
212 The use of Treemap lead to this error from async methods, with no
214 "The response could not be deserialized"
216 2012-05-06 Murray Cumming <murrayc@murrayc.com>
218 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
220 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
221 when using the Google -> GWT Compile, or
222 g toolbar button -> GWT Compile Project... feature in Eclipse.
224 2012-05-06 Murray Cumming <murrayc@murrayc.com>
226 ListTable.addColumn(): Protect against a null Formatting.
228 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
229 Create a default Formatting if it is null, because that is the simplest
232 2012-05-06 Murray Cumming <murrayc@murrayc.com>
234 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
236 * src/main/java/org/glom/web/server/ConfiguredDocument.java
237 updateLayoutGroup(): Check that the field is not null.
239 2012-05-06 Murray Cumming <murrayc@murrayc.com>
241 ListViewImpl: Protected against a bad cast error.
243 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
244 onEnterKeyDown(): Do not cast without an instanceof check.
246 2012-05-06 Murray Cumming <murrayc@murrayc.com>
248 ListTable: Protect against an out of range error.
250 * src/main/java/org/glom/web/client/ui/list/ListTable.java
251 createCellTable(): This is unlikely, but can happen while debugging.
253 2012-05-06 Murray Cumming <murrayc@murrayc.com>
255 AsyncMessage onFailure() callbacks: Log the exception message.
257 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
258 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
259 * src/main/java/org/glom/web/client/activity/ListActivity.java:
260 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
261 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
262 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
263 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
264 These are useful clues when something is wrong.
266 2012-05-06 Murray Cumming <murrayc@murrayc.com>
268 ConfiguredDocument: Avoid a null dereference.
270 * src/main/java/org/glom/web/server/ConfiguredDocument.java
271 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
272 details maps are created.
274 2012-05-06 Murray Cumming <murrayc@murrayc.com>
276 Document: Correct the port number parsing.
278 * src/main/java/org/glom/web/server/libglom/Document.java:
279 This lets us actually connect to the database and show the document.
281 2012-05-05 Murray Cumming <murrayc@murrayc.com>
285 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
286 user-interaction, asking us to load a temporary URL in a browser.s
287 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
288 which is apparently necessary for testing the service. See the comment.
289 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
290 Show the exception, if any. This is how I saw the 404 in the HTML in
293 2012-05-05 Murray Cumming <murrayc@murrayc.com>
295 DocumentTest: Move the .glom files into the resources directory.
297 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
298 URI via getResource().
300 2012-05-05 Murray Cumming <murrayc@murrayc.com>
302 Document: Remove the FieldIdentifies inner class.
304 * src/main/java/org/glom/web/server/libglom/Document.java: We only
305 use the Relationship (though the same function in libglom is maybe
306 used in other ways) and so this removes a compiler warning.
308 2012-05-05 Murray Cumming <murrayc@murrayc.com>
310 Document.load() Remove the error code parameter.
312 * src/main/java/org/glom/web/server/libglom/Document.java: load():
313 Remove the parameter. We do not set it yet and it could never have
314 worked as an output parameter (though maybe it did in java-libglom).
315 We could use an exception if we really want the failure reason.
316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
318 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
319 setUp(), testGetSuitableTableToViewDetails(): Adapt.
321 2012-05-05 Murray Cumming <murrayc@murrayc.com>
323 Make some inner classes static.
325 * src/main/java/org/glom/web/server/ConfiguredDocument.java
326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
327 * src/main/java/org/glom/web/server/ReportGenerator.java
328 * src/main/java/org/glom/web/server/libglom/Document.java
329 Make all inner classes static that can be static.
331 2012-05-05 Murray Cumming <murrayc@murrayc.com>
333 OnlineGlomServiceImpl: Do not load and check for java-libglom.
335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
336 init(): We do not use java-libglom any more.
338 2012-05-05 Murray Cumming <murrayc@murrayc.com>
340 Remove mentions of java-libglom.
342 * README: Remove mention of java-libglom, because it no longer needed.
343 * utils/build-onlineglom-war.sh:
344 * utils/check-and-recover-tomcat.py:
345 * utils/install-onlineglom-war.sh: Remove these as they are no longer
346 useful. Building is now far easier, with no need for jhbuild.
348 2012-05-05 Murray Cumming <murrayc@murrayc.com>
350 Fix the build (mvn package)
352 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
353 (LayoutGroup): Make the LayoutItemList inner class static and protected.
354 Otherwise the GWT Java->Javascript compilation fails with just this
355 error, during mvn package or when attempting to view in a browser,
356 in the GWT developer mode in Eclipse.
358 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
359 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
360 [INFO] Compiling module org.glom.web.OnlineGlom
361 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
362 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
363 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
364 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
365 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
366 [INFO] [ERROR] Cannot proceed due to previous errors
368 It has taken me 2 days to find out what was causing that. After reducing
369 the code, the compiler eventually showed me the full error message.
371 2012-05-04 Murray Cumming <murrayc@murrayc.com>
373 ConfiguredDocument: Cache the cloned and stripped layouts.
375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
376 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
377 layout in a map, so we can retrieve it again without rebuilding it.
379 2012-05-04 Murray Cumming <murrayc@murrayc.com>
381 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
383 2012-05-04 Murray Cumming <murrayc@murrayc.com>
385 libglom classes: Implement some auto-generated emthods.
387 2012-05-04 Murray Cumming <murrayc@murrayc.com>
389 Add GwtTestOnlineGlomService.
391 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
392 However, this (and the other GwtTest*) does not seem to run during
395 2012-05-04 Murray Cumming <murrayc@murrayc.com>
397 Remove use of unsupported features from client code.
399 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
400 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
401 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
402 Use our client version of StringUtils instead of the apache commons one.
404 However, the GWT Javascript compliation still fails.
406 2012-04-25 Murray Cumming <murrayc@murrayc.com>
408 Add a Field class and implement some loading of it in Document.
410 2012-04-25 Murray Cumming <murrayc@murrayc.com>
412 Initial Document loading implementation, instead of libglom.
414 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
415 and Translatable classes, and adapt the rest of the code to use them.
416 However, this is still missing Layout and Field classes and loading.
418 2012-04-24 Murray Cumming <murrayc@murrayc.com>
420 Use of jOOQ: Move Field creation into a utility method.
422 * src/main/java/org/glom/web/server/SqlUtils.java:
423 This lets us improve it more easily.
425 2012-04-24 Murray Cumming <murrayc@murrayc.com>
427 Use of jOOQ: Improve the code to COUNT a sub-select.
429 * src/main/java/org/glom/web/server/SqlUtils.java:
430 Move initial query creation into
431 build_sql_select_step_with_where_clause().
432 build_sql_select_count_rows(): Use the jOOQ API instead of
433 concatentating text, because a jOOQ Select*Step is a TableLike,
434 which is what from() takes.
436 2012-04-23 Murray Cumming <murrayc@murrayc.com>
438 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
440 * pom.xml: Depend on jooq.
441 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
442 methods with jOOQ, based on the C++ implementations in libglom,
443 with some changes to the logic required by jooQ.
444 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
446 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
447 * src/main/java/org/glom/web/server/ReportGenerator.java:
448 * src/main/java/org/glom/web/server/SqlUtils.java:
449 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
450 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
451 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
452 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
453 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
454 Adapt. In particular, the SqlUtils methods now need to take a Connection,
455 because jOOQ needs that, though it seems unnecessary.
457 This is not quite finished. Ideally jOOQ would help us to build
458 table_name.field_name names, quoting and escaping them properly.
459 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
461 2012-04-21 Murray Cumming <murrayc@murrayc.com>
463 Move use of Glom.build_sql*() into a new SqlUtils class.
465 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
466 to wrap Glom.build_sql*(). The parameter types are still Glom one,
467 but this will make it easier to start using something other than
468 libglom or SqlBuilder.
470 2012-04-21 Murray Cumming <murrayc@murrayc.com>
472 Update the project URL.
474 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
476 2012-04-21 Murray Cumming <murrayc@murrayc.com>
478 Main layout: Use a FlowTable instead of absolute positioning.
480 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
481 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
482 child panels/widgets must have an absolute position. But that is annoying, so
483 this adds a FlowTable and puts the child panels in there.
485 2012-04-21 Murray Cumming <murrayc@murrayc.com>
487 GwtTestOnlineGlom: Comment out unused code.
489 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
490 Eclipse has started to say that some code is unused.
492 2012-04-21 Murray Cumming <murrayc@murrayc.com>
494 Update to the latest versions of dependencies.
496 * pom.xml: Update version numbers of dependencies to the latest
498 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
500 * src/main/java/org/glom/web/server/ReportGenerator.java:
501 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
502 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
503 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
505 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
506 Modify the imports where necessary.
508 2012-04-17 Murray Cumming <murrayc@murrayc.com>
510 Style: Remove overflow:hidden from searchbox
512 * src/main/webapp/style.css: Because this pushes the Back To Link
513 label/link on to the next row, which is then hidden due to the
514 hard-coded (in ems) height.
516 2012-04-20 Murray Cumming <murrayc@murrayc.com>
518 Remove some duplicate code.
520 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
521 getDocumentInfo(): This must have been duplicated during the merge from the
526 2012-04-19 Murray Cumming <murrayc@murrayc.com>
528 Reports: Localize the waiting for report message.
530 * src/main/java/org/glom/web/client/activity/ReportActivity.java
531 start(): Get the message from the contants.
532 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
534 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
535 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
536 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
537 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
538 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
539 Update these files with the English text for newer strings for now.
541 2012-04-19 Murray Cumming <murrayc@murrayc.com>
543 Reports: Show a message while waiting for the report.
545 * src/main/java/org/glom/web/client/ui/ReportView.java
546 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
547 Add setWaitingText(), to show a message saying that we are
548 waiting for the report to be ready.
549 * src/main/java/org/glom/web/client/activity/ReportActivity.java
550 start(): Call setWaitingText() before calling the async
553 2012-04-19 Murray Cumming <murrayc@murrayc.com>
555 ReportGenerator: Specify date and time formats.
557 * src/main/java/org/glom/web/server/ReportGenerator.java:
558 createFieldValueElement(): Use the default (and localized)
559 short formats, though we still need a way to show 4-digit
560 years without providing the format for every locale.
561 * src/main/java/org/glom/web/server/database/DBAccess.java:
562 convertResultSetToDTO(): Use the short formats here too.
564 2012-04-18 Murray Cumming <murrayc@murrayc.com>
566 ReportGenerator: Use the correct numeric formatting.
568 * src/main/java/org/glom/web/server/ReportGenerator.java
569 createFieldExpression(), createFieldValueElement(): Take the
570 whole LayoutItem_Field instead of just the field name, so
571 we have access to the formatting.
572 createFieldValueElement(): Use JRTextField.setPattern() to
573 specify the numeric formatting, with the help of a
574 regular DecimalFormat.
576 2012-04-18 Murray Cumming <murrayc@murrayc.com>
578 ReportGenerator: Avoid showing null for group by titles.
580 * src/main/java/org/glom/web/server/ReportGenerator.java
581 generateReport(): Use setBlankWhenNull() on the field title
582 style too, because this is used for values in group by
585 2012-04-18 Murray Cumming <murrayc@murrayc.com>
587 ReportGenerator: Add a colon to titles in vertical groups.
589 * src/main/java/org/glom/web/server/ReportGenerator.java
590 addFieldToDetailBandVertical(): Pass true for the withColon
593 2012-04-18 Murray Cumming <murrayc@murrayc.com>
595 ReportGenerator: Simplify the code by using Position more.
597 2012-04-18 Murray Cumming <murrayc@murrayc.com>
599 Reports: Support vertical groups, roughly.
601 * src/main/java/org/glom/web/server/ReportGenerator.java:
602 addToReport(): Rename to addGroupToReport() and, if necessary,
603 call the new addVerticalGroupToReport() method.
604 createFieldValueElement(): Let the caller specify the Y position
607 2012-04-17 Murray Cumming <murrayc@murrayc.com>
609 Reports: Allow a second report to be shown.
611 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
612 clear(): Do not remove the HTML widget, which broke the whole layout.
614 2012-04-17 Murray Cumming <murrayc@murrayc.com>
616 Locales drop-down: Show that we use English by default.
618 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
619 fillView(): When we use English, just because that is the default, when
620 no locale is specified, show that in the Locales drop-down instead of
621 just showing the first item.
623 2012-04-17 Murray Cumming <murrayc@murrayc.com>
625 Unselect the Report/Locale/Table combo item when appropriate.
627 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
628 setPlace(): clear reportName if this is not a ReportPlace.
629 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
630 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
631 When the provided name is empty, unselect all items, so that none are
632 indicated. This uses a for loop because I cannot find a single method
635 2012-04-17 Murray Cumming <murrayc@murrayc.com>
637 Report: Give the user a way to get back to the list.
639 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
640 start(), setPlace(): Show the Back To List link on reports, and also
641 interpret selecting the empty report item as back to list.
643 2012-04-13 Murray Cumming <murrayc@murrayc.com>
645 Really show the selected Report name.
647 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
648 setPlace(): Store the reportName here, if it is that kind of Place.
649 fillView(): Set the selected Report after filling the list of reports.
650 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
651 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
652 null Strings, though we need some way to unselect all ListBox items
655 2012-04-13 Murray Cumming <murrayc@murrayc.com>
657 ReportGenerator: Try to avoid some problems.
659 * src/main/java/org/glom/web/server/ReportGenerator.java
660 addField(): Try to avoid duplicates, and avoid using a null
663 2012-04-13 Murray Cumming <murrayc@murrayc.com>
665 Reports: Use quickFind.
667 * src/main/java/org/glom/web/client/OnlineGlomService.java;
668 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
669 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
670 getReportHTML(): Add a quickFind parameter.
671 * src/main/java/org/glom/web/client/activity/ReportActivity.java
672 start(): Pass the quickFind parameter.
673 * src/main/java/org/glom/web/server/ReportGenerator.java
674 generateReport(): Take a quickFind parameter.
676 2012-04-13 Murray Cumming <murrayc@murrayc.com>
678 ReportPlace: Actually use the report name.
680 * src/main/java/org/glom/web/client/place/ReportPlace.java
681 getPlace(): Do not assign the report name to the quickfind.
683 2012-04-13 Murray Cumming <murrayc@murrayc.com>
685 Show java.library.path when complaining.
687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
688 init(): When telling us to check java.library.path, show the
691 2012-03-06 Murray Cumming <murrayc@murrayc.com>
693 ReportGenerator: Do not show nulls.
695 2012-03-06 Murray Cumming <murrayc@murrayc.com>
697 ReportGenerator: Make the title font larger.
699 2012-03-06 Murray Cumming <murrayc@murrayc.com>
701 ReportGenerator: Put field titles inside groups, if there are groups.
703 2012-03-06 Murray Cumming <murrayc@murrayc.com>
705 ReportGenerator: Take the Report itself instead of the name and group.
707 * src/main/java/org/glom/web/server/ConfiguredDocument.java
708 Remove getReportLayoutGroup().
709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
710 getReportHTML(): Pass the report instead
711 of its name and layout group.
712 * src/main/java/org/glom/web/server/ReportGenerator.java
713 generateReport(): Use the report object to use the title
716 2012-03-06 Murray Cumming <murrayc@murrayc.com>
718 ReportGenerator: Remove designBand parameters.
720 * src/main/java/org/glom/web/server/ReportGenerator.java:
721 Make designBand a class member instead of passing it to all
724 2012-03-06 Murray Cumming <murrayc@murrayc.com>
726 ReportGenerator: Add lines, a bit like in the desktop version.
728 * src/main/java/org/glom/web/server/ReportGenerator.java
729 addToReport(): Use JRDesignLine.
731 2012-03-06 Murray Cumming <murrayc@murrayc.com>
733 ReportGenerator: Correct the title positions and use some bold style.
735 * src/main/java/org/glom/web/server/ReportGenerator.java:
736 Break the code up into reusable functions, correct the placement of
737 titles, and use normal/bold styles as in the reports in the desktop
740 2012-03-06 Murray Cumming <murrayc@murrayc.com>
742 ReportGenerator: Add a header band to show the field titles.
744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
745 getReportHTML(): Pass the localeId to the ReportGenerator
747 * src/main/java/org/glom/web/server/ReportGenerator.java
748 constructor: Take the localeID so we can get translated field
750 generateReport(), addToReport(), addFieldToBand(): Add field
751 titles in a column header band.
753 2012-03-05 Murray Cumming <murrayc@murrayc.com>
755 Reports drop-down list: Some improvement.
757 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
758 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
759 Adedd setSelectedReport(),
760 setReportList(): Add a blank line so that the user can select the
762 * src/main/java/org/glom/web/client/activity/ReportActivity.java
763 start(): Show the current report by calling setSelectedReport().
764 This does not seem to work yet.
766 2012-03-05 Murray Cumming <murrayc@murrayc.com>
768 DetailsActivity, ListActivity: Move some variables into a base class.
770 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
771 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
772 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
773 the clientFactory, documentID, tableName and authenticationPopup into
774 a base class, to avoid duplication.
776 2012-03-05 Murray Cumming <murrayc@murrayc.com>
778 Translate the Reports label.
780 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
781 Get the "Reports" label string from the constants.
782 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
783 perties: Add Reports to the constants.
785 2012-03-05 Murray Cumming <murrayc@murrayc.com>
787 Reports: Implement grouping.
789 * src/main/java/org/glom/web/server/ReportGenerator.java:
790 Handle LayoutItem_GroupBy items and try to do the right thing
791 with JRDesignGroup. It seems to work.
793 2012-03-04 Murray Cumming <murrayc@murrayc.com>
795 Actually show some data with JasperReports.
797 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
798 getReportHTML(): Move most code into a ReportGenerator class.
799 * src/main/java/org/glom/web/server/ReportGenerator.java:
800 Recurse into sub-groups, adding fields to the JasperDesign's details
801 band. Note that we must set an arbitrary width and height, or it just
802 will not show any data.
804 2012-03-04 Murray Cumming <murrayc@murrayc.com>
806 Reports Chooser: Show the titles, not the names.
808 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
809 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
810 and the names as the values.
811 * src/main/java/org/glom/web/server/ConfiguredDocument.java
812 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
813 group now that we provide the report name, so it should always
816 2012-02-15 Murray Cumming <murrayc@murrayc.com>
818 Depend on jasperreports.
820 * pom.xml: Add the dependency. My plan is to use this on the
823 2012-01-31 Murray Cumming <murrayc@murrayc.com>
825 Implement navigation to report places.
827 * src/main/java/org/glom/web/client/activity/ReportActivity.java
828 start(): Do not bother to handle all events here.
829 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
830 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
831 Added getSelectedReport().
832 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
833 .java: start(): When handling a change to the reports chooser,
834 call getSelectedReport() and goTo() its ReportPlace.
835 * src/main/java/org/glom/web/client/ui/ReportView.java
836 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
837 Added setReportHTML() which puts the html in a gwt HTML widget.
838 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
839 getReportHTML(): Return "TODO" just to show that this works.
841 2012-01-31 Murray Cumming <murrayc@murrayc.com>
843 Make ReportPlace usable.
845 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
847 * src/main/java/org/glom/web/client/place/ReportPlace.java:
848 Correct the @prefix annotation.
850 2012-01-31 Murray Cumming <murrayc@murrayc.com>
852 OnlineGlomService: Return report HTML rather than the LayoutGroup.
854 * src/main/java/org/glom/web/client/OnlineGlomService.java:
855 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
857 Change getReportLayout() to getReportHMTL() because we will not need to
858 parse or render the report layout on the client side.
859 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
860 getReportLayout(): Return the libglom LayoutGroup type because we will
861 not need to convert to a shared type, because this will not be used on
863 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
866 Note that there is still no implementation for this.
869 2012-01-27 Murray Cumming <murrayc@murrayc.com>
871 Add a (empty) Report Place, View, and Activity.
873 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
875 * src/main/java/org/glom/web/client/place/HasTablePlace.java
876 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
877 this into a superclass:
878 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
879 and also use it as the base of this new ReportPlace:
880 * src/main/java/org/glom/web/client/place/ReportPlace.java
882 * src/main/java/org/glom/web/client/ui/ReportView.java
883 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
884 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
885 Add these, containing mostly boiler-plate for now.
887 * src/main/java/org/glom/web/client/OnlineGlomService.java
888 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
889 * src/main/java/org/glom/web/server/ConfiguredDocument.java
890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
891 Add API to get the LayoutGroup for the report.
893 2012-01-23 Murray Cumming <murrayc@murrayc.com>
895 Add and fill a Reports drop-down list box.
897 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
899 * src/main/java/org/glom/web/client/OnlineGlomService.java:
900 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
902 Added getReports(document, table, localeID), calling
903 ConfiguredDocument.getReports().
904 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
905 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
906 Added setReportsList() and a list widget.
907 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
908 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
913 2012-04-12 Murray Cumming <murrayc@murrayc.com>
915 Translations: Add Esperanto.
917 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
918 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
919 properties: Add this translation because someone took the time to make it.
921 2012-03-15 Murray Cumming <murrayc@murrayc.com>
923 Adapt to the java-libglom 1.21.7 API.
925 * src/main/java/org/glom/web/server/ReportGenerator.java:
926 addToReport(): get_group_secondary_fields() is now
927 get_secondary_fields().
930 2012-03-15 Murray Cumming <murrayc@murrayc.com>
932 Use the latest java-libglom version.
934 * pom.xml: Use java-libglom 1.21.7.
936 2012-03-03 Ben Konrath <ben@bagu.org>
938 Display date and time in details view.
940 https://bugzilla.gnome.org/show_bug.cgi?id=671257
942 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
944 2012-03-05 Murray Cumming <murrayc@murrayc.com>
946 Require the latest java-libglom.
948 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
950 2012-03-04 Murray Cumming <murrayc@murrayc.com>
952 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
954 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
955 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
956 an empty quickfind string. I also corrected libglom to create only
957 empty where clauses for empty quickfind strings, but this avoids the
960 2012-02-24 Ben Konrath <ben@bagu.org>
962 Improve the tabs in the Notebook widget.
966 2012-01-30 Murray Cumming <murrayc@murrayc.com>
968 Translations: Try to translate the strings.
970 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
971 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
972 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
973 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
974 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
975 Take the Open translation from GTK+'s .po files.
976 Take the Details translation from Glom's po files.
977 I have added the other strings to Glom so we can get translations that way:
978 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
980 2012-01-27 Murray Cumming <murrayc@murrayc.com>
982 TableSelectionViewImpl: Put the search label and entry in a div.
984 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
985 Put the search widgets in a FlowTable so that the CSS can be used to
986 style them while keeping them together.
987 * src/main/webapp/style.css: Mention the new div.
989 2012-01-27 Murray Cumming <murrayc@murrayc.com>
991 Translate more strings in more locales.
993 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
994 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
995 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
996 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
997 Translate the "Details" and "Open" string too.
999 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1000 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1001 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1002 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1003 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1004 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1005 Add these new locales as placeholders though they currently contain English.
1007 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1009 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1012 Check the ConfiguredDocument* for null before using it.
1014 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1016 Tell Eclipse about the generated java files.
1018 * .classpath: This lets it find OnlineGlomConstants.java.
1019 It would be nice if Eclipse just used the maven build files.
1021 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1023 Prevent a crash when no locale is specified in the URL.
1025 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1026 Avoid returning a null string, obtained from
1027 Window.Location.getParameter(). This caused a crash when it was
1028 later passed to libglom's API.
1029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1030 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1031 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1032 guard against future null strings.
1034 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1036 Use the ?locale= query param instead of the &lang= token param.
1038 * src/main/java/org/glom/web/client/place/ListPlace.java
1039 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1040 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1041 Remove the lang token key and value.
1043 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1044 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1045 When the user selects a different locale from the chooser, use
1046 Window.Location.assign() to change the URL, which then causes a reload.
1048 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1049 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1050 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1051 * src/main/java/org/glom/web/client/activity/ListActivity.java
1052 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1053 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1054 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1055 * src/main/java/org/glom/web/client/ui/ListView.java:
1056 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1058 Remove localeID member variables and method/constructor parameters, instead
1059 using Utils.getCurrentLocaleID() when we need a localID to pass to
1062 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1064 Internationalize the UI strings.
1066 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1067 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1068 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1069 because it is unused. Messages are apparently strings that can have
1070 parameters, but we do not need that yet, so Contants will be enough for now.
1071 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1072 to say that we support the en and de locales.
1073 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1074 The original English strings.
1075 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1076 Some German translations of the English strings.
1077 The i18n goal then uses the .properties file to generate an
1078 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1079 returns an implementation that returns the translated strings.
1080 The documentation suggests putting these in src/java/*/client/, but it seems
1081 best to put it in src/resources/*/client/.
1082 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1083 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1084 instead of hard-coding them.
1085 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1086 but that does not seem to stop the build, though it confuses Eclipse.
1088 You can see the translated string by adding ?locale=de to the URL, like so:
1089 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1091 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1093 Improve null/empty String checks.
1095 * pom.xml: Add a dependency on commons-lang, to use
1096 org.apache.commons.lang.StringUtils.
1097 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1099 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1100 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1101 Use StringUtils.isEmpty().
1103 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1104 StringUtils class with a static isEmpty() function because we
1105 cannot use org.apache.commons.lang.StringUtils in client-side
1106 GWT code because it (apparently) cannot be compiled to javascript.
1107 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1108 * src/main/java/org/glom/web/client/activity/ListActivity.java
1109 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1110 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1111 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1112 * src/main/java/org/glom/web/client/place/ListPlace.java
1113 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1114 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1115 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1116 * src/main/java/org/glom/web/client/ui/details/Group.java
1117 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1118 our StringUtils.isEmpty() function.
1120 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1122 Update to the latest java-libglom API.
1124 * pom.xml: Require java-libglom 1.21.4.
1125 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1126 getDocumentInfo(), getListViewLayoutGroup():
1127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1129 * src/main/java/org/glom/web/server/database/DBAccess.java
1130 getFieldsToShowForSQLQueryAddGroup(),
1131 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1132 with either get_database_title_original() or
1133 get_database_title(localeID).
1135 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1137 ConfiguredDocument: Avoid a null pointer exception.
1139 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1140 Initialize localeID to "" to avoid returning a null String which
1141 causes a crash in java-libglom's swing-generated code.
1143 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1145 Some simple renaming.
1147 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1148 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1149 for localeChooser. This seems more appropriate and is less ambiguous
1150 particularly in the .css file.
1152 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1154 ConfiguredDocument: Rename the localedID private member variable.
1156 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1158 Adapt to the latest java-libglom API from git master.
1160 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1161 libglom now uses only Vector instead of List, which uses add() instead of
1164 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1166 ConfiguredDocument: Rename the localedID private member variable.
1168 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1170 Build a source tarball with mvn assembly:single
1172 * assembly.xml: Add this file.
1173 * pom.xml: Use the maven-assembly-plugin and tell it to use
1174 our assembly.xml file.
1176 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1178 OnlineGlomServiceImpl: Get .glom files recursively.
1180 * pom.xml: Depend on commons-io from org.apache.commons.
1181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1182 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1183 files recursively, and with the easier filter for the extension.
1184 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1185 simplify that code too.
1187 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1189 README: Mention that you must install java-libglom packages separately.
1191 But then it works, because java-libglom is now in the central maven
1194 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1196 locales drop-down: Show the correct selected locale when the URL changes.
1198 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1199 .java: setPlace(): Move some code into fillView().
1201 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1203 locales drop-down: Do not lose the primary key.
1205 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1206 start(): onLocaleChange(): Pass the current primary key value,
1207 instead of an empty value.
1209 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1211 locales drop-down: Do not lose the drop-down selection.
1213 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1214 .java (TableSelectionActivity.fillView): Set the selected locale
1215 after changing the drop-down items (though we do not really need
1216 to change them just because the locale changes.)
1218 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1220 locales drop-down: Change the tables list when this changes.
1222 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1223 .java: TableSelectionActivity.start(): Move the async table titles
1224 retrieval into a private fillView() method and also call this when
1225 the chosen locale changes.
1226 Note that the document title is not actually translatable yet, but
1227 that is a problem that I should fix soon in libglom.
1229 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1231 Improve the placement of the locales drop-down.
1233 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1234 Put the title and locales drop-down in a div (gwt.FlowTable).
1235 * src/main/webapp/style.css: Add magic css properties to make this work.
1236 Also remove the left margin from the title so that it lines up with the
1239 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1241 locales selector: Show human-readable locale titles.
1243 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1244 getDocumentInfo(): Use java.util.Locale to show a real title of
1245 each locale, in the locale's own language.
1247 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1249 Add a language/locale selector drop-down.
1251 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1252 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1253 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1254 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1255 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1256 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1257 Add a ListBox to show the available locales. Add getLocaleSelector(),
1258 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1259 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1260 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1261 java: Add these classes.
1262 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1263 start(): Fill the locales ListBox. Handle its change event, firing a
1265 setPlace(): Show the selected locale as specified by the URL token.
1266 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1267 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1268 Handle LocaleChangeEvent, going to a new *Place with that locale.
1270 The placement of the ListBox is not pretty, and it currently uses the ID
1271 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1275 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1277 Search box: Show the search text from the URL token.
1279 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1280 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1281 Add setQuickFindText().
1282 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1283 .java: setPlace(): Store the queryText if the place is a ListPlace,
1284 and call TableSelectionView.setQuickFindText().
1286 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1288 Allow use of translations via, for instance, &lang=de in the URL.
1290 * pom.xml: Use the unstable java-libglom 1.21 version.
1292 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1293 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1294 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1295 init(): Instead of calling TranslatableItem.set_current_locale()
1296 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1297 However, this is only for default locales, which are not needed to
1298 change the locale in the URL.
1299 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1300 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1301 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1302 layout for a particular locale.
1303 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1304 Add get/setDefaultLocaleID().
1305 getDocumentInfo(), getListViewData(), getRelatedListData(),
1306 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1307 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1308 localeID parameter, so we can get the layout for a particular locale.
1310 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1311 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1312 * src/main/java/org/glom/web/client/place/ListPlace.java:
1313 Parse and construct a lang parameter too.
1315 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1316 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1317 passed to subsequent methods and constructors.
1318 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1319 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1320 Store the localeID from the *Place and pass it to other constructors
1321 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1323 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1324 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1325 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1326 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1327 * src/main/java/org/glom/web/client/ui/ListView.java:
1328 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1329 Take localeID parameters and pass them to subsequent constructors and
1330 methods, so that the layout is always retrieved for that locale.
1332 This is rather repetitive.
1334 Note that "" means the original (default) locale of the Glom document,
1335 which is usually English.
1337 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1339 Documents: Remove final keyword to fix startup configuration.
1341 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1342 final keywords on the private member variables because that breaks
1343 the startup, apparently (there are warnings) because it stops them
1344 from being serialized. I added these in the previous commit.
1346 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1348 Documents: Add some final keywords.
1350 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1353 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1355 OnlineGlomServiceImpl: Add to overview comments.
1357 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1358 Note that this is where all the document are loaded. They are not
1359 loaded freshly for each page.
1361 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1365 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1366 Add a TextBox for the text of a quick find.
1367 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1369 setBackLink(): Add a String quickFind parameter.
1370 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1371 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1372 to the base interface, because that is how TableSelectionViewImpl is used.
1373 * src/main/webapp/style.css: Add style for the search box and its label.
1375 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1376 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1377 Add these files, based on the existing TableChangeEvent and
1378 TableChangeEventHandlers.
1379 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1380 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1381 a ListPlace() that the user should be taken to.
1382 * src/main/java/org/glom/web/client/activity/ListActivity.java
1383 start(): Handle it here too and adapt the TableChangeEvent handler to
1384 pass the extra "" quickFind parameter to ListPlace.
1385 * src/main/java/org/glom/web/client/place/ListPlace.java:
1386 Constructor: Take an extra String quickFind parameter and store it,
1387 returning it from a new getQuickFind() method.
1388 getToken(): Put the quickFind text in the URL token.
1389 getPlace(): Parse the quickFind text from the URL token.
1390 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1391 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1392 ListPlace constructor.
1393 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1394 .java: start(): Add a Change handler for the TableSelectionView's
1395 TextBox (via its base HasChangeHandlers interface), firing the new
1396 QuickFindChangeEvent.
1397 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1398 pass the extra "" quickFind parameter.
1400 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1401 setCellTable(): Add a String quickFind parameter and pass it to
1402 the ListViewTable() constructor.
1403 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1404 setCellTable() in the base interface, because that is how ListViewImpl
1407 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1408 Add a String quickFind member variable.
1409 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1410 Constructor: Add a String quickFind parameter, storing it in the
1411 base ListTable's member variable.
1412 onRangeChanged(): Pass quickFind to the
1413 OnlineGlomServiceAsync.getSortedListViewData() and
1414 OnlineGlomServiceAsync.getListViewData() methods.
1416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1417 getListViewData(), getSortedListViewData(): Add a String quickFind
1418 parameter, passing it to ConfiguredDocument.getListViewData().
1419 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1420 Change getListViewData(), getSortedListViewData() in the base interface,
1421 because that is how OnlineGlomServiceImpl is used, via this:
1422 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1423 Change getListViewData(), getSortedListViewData() here too.
1424 This class can apparently be used to asynchronously call methods on
1425 OnlineGlomService, and GWT seems to implement that after recognizing
1426 just the *Async name convention and the extra AsyncCallback parameters.
1428 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1429 getListViewData(): Add a String quickFind parameter, and pass it to
1430 ListViewDBAccess.getData().
1431 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1432 getListData(): Add a String quickFind parameter and pass it to
1434 getSelectQuery(): Add a String quickFind parameter.
1435 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1436 getSelectQuery(): Add a String quickFind parameter and use it with
1437 Glom.get_find_where_clause_quick() to pass a where_clause to
1438 Glom.build_sql_select_with_where_clause(), to actually filter the
1440 getData(): Add a String quickFind parameter, passing it to getListData().
1441 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1442 va: getData(): Pass an empty string to getListData() for the
1443 quickFind parameter.
1445 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1447 ListTable: Minor change.
1449 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1450 createCellTable(): Make this protected instead of public.
1452 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1454 Many files: Use final for the parameters and use the @override attribute.
1456 2012-01-22 Ben Konrath <ben@bagu.org>
1458 Add anchor links for single line text that starts with http, ftp and www.
1462 2012-01-22 Ben Konrath <ben@bagu.org>
1464 Add ellipsis to single line text in details view.
1468 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1470 Remove all javadoc author tags.
1472 Because they are awkward and meaningless when many people touch
1474 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1476 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1478 Revert the COPYING.LESSER to COPYING rename.
1480 Apparently both should be there if it is LGPL.
1482 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1484 *View: Remove unused imports.
1486 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1487 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1488 * src/main/java/org/glom/web/client/ui/ListView.java:
1489 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1490 Remove unused imports, as suggested by Eclipse.
1492 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1494 Move the *View::Presenter types, and some API into one base View.
1496 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1497 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1498 * src/main/java/org/glom/web/client/ui/ListView.java:
1499 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1500 Presenter, setPresenter() and clear() into a shared base interface,
1501 to avoid the unnecessary duplicate Presenter types and to more clearly
1502 show how the *Views share the same structure, even if they are not
1503 used polymorphically.
1505 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1506 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1508 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1509 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1510 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1512 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1515 Feel free to revert this if there is a good reason for the duplicate
1518 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1520 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1522 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1523 a class member instead of a local variable in the method.
1524 This lets us use it to get the view instances, for use in tests.
1525 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1526 beforeOnlineGlom(): Test some more details of the initial view.
1527 Again, this is not very useful.
1529 To really test gwt-glom we will need to start a local postgresql
1530 instance with local data, like the Glom tests in C++.
1532 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1534 pom.xml: Mention the LGPL license.
1536 * pom.xml: Add a licenses section.
1537 * COPYING.LESSER: Move this to COPYING, which
1538 previously contained the GPL. But gwt-glom is all LGPL.
1540 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1542 Add project information to README and pom.xml.
1544 * README: Add a brief description and mention some mvn
1546 * pom.xml: This extra information shows up in mvn site
1549 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1551 Use the latest java-libglom version.
1553 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1555 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1557 GwtTestOnlineGlom: Test a little more.
1559 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1560 protected rather than private, as suggested by the gwt-test-utils
1562 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1563 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1564 Test the initial visibility of the panels.
1566 However, this is not a very useful test.
1567 And I wonder how we should generally test using this idea for an
1568 activity/places app like ours where the real changes happen implicitly
1569 based on the history token/URL.
1571 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1573 Slight modification to *Mapper comments.
1575 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1576 (DataActivityMapper)
1577 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1579 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1581 Remove comments mentioning GIN because they are just copied from
1582 the example code and are apparently not helpful:
1583 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1584 Also change the mention of a class that is only in the example code.
1586 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1588 GwtTestOnlineGlom test: Minor changes.
1590 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1591 Avoid the long qualified class name and modify the comment
1592 because it is now obvious to me that the mocked class is the only
1593 custom one created via GWT.create().
1595 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1597 Tests: Added the beginnings of a test using gwt-test-utils.
1599 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1600 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1601 which tells gwt-test-utils what class will be tested.
1602 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1603 Add a simple (but empty) test case. One class, used by the OnlineGlom
1604 class, is mocked so that it can be created. However, I am not sure
1605 why only this class needs to be mocked.
1607 Note that mockito seems more popular, and clearer, than easymock,
1608 but I have not got that working yet. It might be a matter of the
1611 This test is run during mvn integration-test.
1613 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1615 Tests: Use junit4-style syntax instead of junit3-style.
1617 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1618 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1619 * src/test/java/org/glom/web/shared/DataItemTest.java:
1620 Use the @Test annotation rather than relying on the test*() prefix.
1621 Also no longer implement TestCase, to avoid triggering support for
1622 the junit3-way, which stops the annotations from working.
1623 Change the imports from import junit.framework.* to
1624 import org.junit.*, which is apparently the new way.
1626 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1628 Added a test for ListPlace token parsing and creation.
1630 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1631 This is much the same as DetailsPlaceTest.
1633 I wonder how we could test the other parts of the *Place API.
1635 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1637 DetailsPlace test: Also test getToken() and recreation via getPlace().
1639 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1640 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1641 recreate it, testing the recreated DetailsPlace for the same parameter
1644 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1646 Use the surefire-report plugin.
1648 * pom.xml: This generates a HTML report about the tests in
1649 target/site/surefire-report.html
1650 when you do mvn surefire-report:report. It seems to be popular/normal.
1652 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1654 Added a test for DetailsPlace.
1656 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1657 Test the getPlace() token parsing.
1659 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1661 Added a first unit test.
1663 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1664 * src/test/java/org/glom/web/shared/DataItemTest.java:
1665 This is a silly test but it is just to get things started. Note that
1666 maven/junit finds the test because it looks in src/test by default.
1668 2011-12-22 Ben Konrath <ben@bagu.org>
1670 Change charsetName to "UTF-8" when replacing line breaks.
1672 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1673 that work in Java (such as "UTF8") will not work when compiled to
1676 This fixes a problem with multi-line details view fields that have hard
1677 line breaks. The "License Text" field on this page demonstrates the
1680 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1682 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1684 2011-12-22 Ben Konrath <ben@bagu.org>
1686 Fix another bug with related list navigation.
1688 I've tested all the navigation buttons in all of the related lists
1689 so things should be good now.
1691 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1693 2011-12-22 Ben Konrath <ben@bagu.org>
1695 Fix a crasher when refreshing the list view with the default table.
1697 This crash will also happen when loading the list view with the default
1698 table from a link or bookmark.
1700 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1701 to the main document selection page when the document id hasn't been
1703 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1704 the main document selection page when the document id hasn't been
1706 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1707 values for the details place when the document id hasn't been set.
1708 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1709 values for the list place when the document id hasn't been set.
1711 2011-12-21 Ben Konrath <ben@bagu.org>
1713 Protect against NPE when glom.document.locale is not in config.
1715 This patch protects against an NPE when glom.document.locale is not in
1716 the config file. This NPE will also happen if glom.document.locale is
1719 The patch also updates the error message to display the class name when
1720 the getMessage() returns null. This was happening when the NPE was
1721 thrown and I had "Configuration Error: null". If an NPE is encountered
1722 with this patch, "Configuration Error: NullPointerException " will be
1725 This commit closes this bug:
1727 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1729 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1731 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1733 Rename onlineglom.properties to onlineglom.properties.sample.
1735 * src/main/resources/onlineglom.properties: Rename to:
1736 * src/main/resources/onlineglom.properties.sample:
1737 * src/main/resources/README: And add this file explaining that people
1738 should rename it back when deploying.
1740 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1742 Allow choosing the translation in the .properties file.
1744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1745 init(): Read a glom.document.locale value from the configuration file
1746 and call Glom's TransatableItem::set_current_locale() method.
1747 * src/main/resources/onlineglom.properties: Add a commented-out
1748 example of this new setting.
1750 It would be better to add &lang=de_DE to the URL, but the current
1751 libglom API does not allow us to do this easily. I am working on that.
1753 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1755 Avoid a crash in parsing of token parameters.
1757 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1758 ava: getTokenParams(): Do not crash if a parameter has a key but no
1759 value, and ignore parameters with neither.
1761 2011-12-17 Murray Cumming <murrayc@murayc.com>
1763 History token building/handling: Improve use of token parameters.
1765 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1766 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1767 and buildParamsToken(HashMap), for use by derived classes.
1768 Make the separator private because it is no longer be needed.
1769 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1770 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1771 instead of manual string concatenation.
1772 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1773 of hardcoded indices and awkward splitting code.
1774 * src/main/java/org/glom/web/client/place/ListPlace.java
1775 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1776 instead of manual string concatenation.
1777 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1778 of hardcoded indices and awkward splitting code.
1779 This should fix bug #666420
1781 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1783 Fix a Navgiation->Navigation typo in the code.
1785 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1786 Rename processNavgiation() to processNavigation().
1788 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1790 Fix a seperator->separator typo in the code.
1792 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1793 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1794 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1797 2011-12-15 Ben Konrath <ben@bagu.org>
1799 Cleanup some comments.
1801 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1803 2011-12-14 Ben Konrath <ben@bagu.org>
1805 Replace \n with <br/> for multiline text in the details view.
1807 Vertical scrollbars are added when needed as well.
1809 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1811 2011-12-14 Ben Konrath <ben@bagu.org>
1813 Specify the font for document selection links.
1815 * src/main/webapp/style.css:
1817 2011-12-14 Ben Konrath <ben@bagu.org>
1819 Fix bouncy CellTable while paging.
1821 This doesn't currently work with related list tables in unselected
1824 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1826 2011-12-14 Ben Konrath <ben@bagu.org>
1828 Revamp the appearance of the document selection page.
1830 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1831 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1832 * src/main/webapp/style.css:
1834 2011-12-13 Ben Konrath <ben@bagu.org>
1836 Set navigation button column to the smallest size possible.
1838 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1840 2011-12-13 Ben Konrath <ben@bagu.org>
1842 Change OpenButton nomenclature to NavigationButton.
1844 Using NavigtionButton makes things more generic. Classes, methods and
1845 variables have been changed.
1847 This is a rename-only refactor.
1849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1850 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1851 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1852 Renamed from OpenButtonCell.
1853 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1854 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1855 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1857 2011-12-12 Ben Konrath <ben@bagu.org>
1859 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1862 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1863 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1864 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1866 2011-12-12 Ben Konrath <ben@bagu.org>
1868 Update variable names and comments.
1870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1871 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1873 2011-12-12 Ben Konrath <ben@bagu.org>
1875 Properly initialize numNonEmptyRows variable to zero.
1877 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1878 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1880 2011-12-05 Ben Konrath <ben@bagu.org>
1882 Add latest mockup with HTML tables.
1884 Features of this mockup:
1886 -> HTML table for flowtable
1887 -> HTML table for flowtable column
1888 -> Example of how related lists would look
1889 -> Not using text entries for data items
1891 The current version of Online Glom doesn't use HTML tables for the
1894 This mockup has been sent to the glom-devel mailing list but it's good
1895 to have it here as well.
1897 * mockups/details-view-html-tables.html:
1899 2011-12-05 Ben Konrath <ben@bagu.org>
1901 Remove unnecessary getPrimaryKeyField() method.
1903 getPrimaryKeyFieldForTable(String) has been renamed to
1904 getPrimaryKeyField(String).
1906 * src/main/java/org/glom/web/server/database/DBAccess.java:
1907 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1908 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1910 2011-12-05 Ben Konrath <ben@bagu.org>
1912 Add string representation of TypedDataItem value to conversion error message.
1914 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1915 message was extracted into its own method to avoid duplication.
1917 2011-12-05 Ben Konrath <ben@bagu.org>
1919 Add type checking to navigation primary key value creation.
1921 Create navigation primary key only if the expected type from the Glom
1922 document matches the type returned by the SQL query.
1924 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1926 2011-12-05 Ben Konrath <ben@bagu.org>
1928 Rename a couple of variables in RelatedListNavigation.
1930 This is a rename-only refactor.
1932 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1934 2011-12-05 Ben Konrath <ben@bagu.org>
1936 Move getListLayoutGroup() into getListViewLayoutGroup().
1938 This removes getListLayoutGroup(). It was only being called by
1939 getListViewLayoutGroup().
1941 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1943 2011-12-05 Ben Konrath <ben@bagu.org>
1945 Remove check for LayoutItem_Portal in list table method.
1947 This check is no longer necessary because the method isn't being used
1948 to create the LayoutItemPortal DTO.
1950 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1952 2011-12-05 Ben Konrath <ben@bagu.org>
1954 Properly support related list navigation.
1956 Navigation from the "Repository Analyzer -> Package Scans ->
1957 Dependencies" related table wasn't working because the primary key for
1958 related tables wasn't being set properly. This commit fixes the
1961 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1962 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1963 doesn't set the primary key properly for related list tables.
1964 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1965 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1966 useful for getting the primary key for list view tables and for related
1968 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1969 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1970 Move code to set the primary key for the table from the abstract
1971 ListDBAccess class to ListViewDBAccess as it's only correct for list
1973 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1974 Properly add primary key to related list tables.
1976 2011-12-02 Ben Konrath <ben@bagu.org>
1978 Properly set the horizontal alignment of fields.
1980 This fix is for both the list tables and the details view.
1982 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1983 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1984 to set the horizontal alignment of fields.
1986 2011-12-02 Ben Konrath <ben@bagu.org>
1988 Display currency codes in the details view.
1990 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1992 2011-12-02 Ben Konrath <ben@bagu.org>
1994 Avoid duplicate JNI call.
1996 JNI is not as efficient as pure Java and this is an easy (and small)
1999 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2000 Use previously retrieved value for whereClauseToTableName instead of
2003 2011-12-02 Ben Konrath <ben@bagu.org>
2005 Rename a couple of variables in RelatedListNavigation.
2007 This is a rename-only refactor.
2009 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2011 2011-12-02 Ben Konrath <ben@bagu.org>
2013 Indicate clearly that a mismatched primary key type is a bug.
2015 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2016 warning to error. Add 'This is a bug.' to message.
2018 2011-12-02 Ben Konrath <ben@bagu.org>
2020 Update / fix some comments.
2022 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2024 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2026 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2027 Fix comments. Add some TODOs.
2029 2011-12-02 Ben Konrath <ben@bagu.org>
2031 Enable navigation to details view with string primary key from related list.
2033 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2034 Create a text primary key value when return type of result is
2035 java.sql.Types.VARCHAR.
2037 2011-12-02 Ben Konrath <ben@bagu.org>
2039 Use checkboxes for booleans in the details view.
2041 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2043 2011-12-01 Ben Konrath <ben@bagu.org>
2045 Improve performance of related list height calculation.
2047 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2048 Put code to calculate the expected height in a static initializer so
2049 that that it's only called once.
2051 2011-12-01 Ben Konrath <ben@bagu.org>
2053 Show related list tables in notebooks (again).
2055 Calculate the height of the related list tables so the Notebook can be
2056 set the correct height. The height of the related list table is also needed by
2057 FlowTable to be able decide how to create the layout.
2059 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2060 and set the Portal height based on the height of the related list
2061 table and the Portal container.
2062 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2063 Add method to calculate the height of the related list tables.
2064 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2065 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2066 calculate the height of the Pager widget.
2068 2011-12-01 Ben Konrath <ben@bagu.org>
2070 Use CellTable API for table property instead of setting style on Element.
2072 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2074 2011-12-01 Ben Konrath <ben@bagu.org>
2076 Make ListViewTable and RelatedListTable a consistent height.
2078 The tables are now a consistent height regardless of the contents of
2079 the table. A hidden button is added to empty rows to ensure that the
2080 height of these rows will match the height of rows with data.
2082 A navigation button column is now added to every table. The width of
2083 the navigation column is set to 0px when a RelatedListTable shouldn't
2084 have navigation buttons. This maintains the a consistent row height in
2085 tables that don't show the navigation buttons.
2087 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2088 navigation column when not needed.
2089 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2090 arguments for navigation button to constructor of ListViewTable.
2091 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2092 hidden button for empty data rows.
2093 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2094 arguments for navigation button to constructor.
2095 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2096 create navigation buttons. Add hideNavigationButtons() method.
2097 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2098 arguments for navigation button to constructor.
2100 2011-12-01 Ben Konrath <ben@bagu.org>
2102 Use 'visibility: hidden' in Utils.getWidgetHeight().
2104 This is better choice because hidden elements are invisible, don't
2105 respond to events and are not part of the tab order. They will,
2106 however, take up space which is required to be able to calculate the
2107 height of the widget.
2109 * src/main/java/org/glom/web/client/Utils.java:
2111 2011-12-01 Ben Konrath <ben@bagu.org>
2113 Use Utils.getWidgetHeight() in FlowTable.
2115 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2117 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2119 2011-12-01 Ben Konrath <ben@bagu.org>
2121 Put the details css class name on the correct table column.
2123 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2125 2011-11-30 Ben Konrath <ben@bagu.org>
2127 Update for java-libglom API change.
2129 The getters and setters on FieldFormatting and NumericFormat were
2130 changed to remove the 'M'.
2132 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2134 2011-11-29 Ben Konrath <ben@bagu.org>
2136 Only allow RelatedListTables in Portals.
2138 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2140 2011-11-29 Ben Konrath <ben@bagu.org>
2142 Only create a contents panel for Portals when title is being set.
2144 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2146 2011-11-29 Ben Konrath <ben@bagu.org>
2148 Set TabLayoutPanel height based on calculated height its widgets.
2150 This is a potential fix for this bug:
2152 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2154 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2156 2011-11-29 Ben Konrath <ben@bagu.org>
2158 Align details field labels and data with the Open buttons.
2160 * src/main/webapp/style.css:
2162 2011-11-29 Ben Konrath <ben@bagu.org>
2164 Remove unnecessary <div> in the Notebook widget.
2166 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2167 method to get container FlowPanel (<div>).
2168 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2169 initWidget() method directly on the TabLayoutPanel widget instead of
2170 Group's container widget.
2172 2011-11-29 Ben Konrath <ben@bagu.org>
2174 Don't add group titles for Portals in Notebooks.
2176 This reverts the previous patch and fixes a bug I introduced with
2177 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2179 * src/main/java/org/glom/web/client/ui/details/Group.java:
2180 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2182 2011-11-28 Ben Konrath <ben@bagu.org>
2184 Remove unused boolean argument in Portal constructor.
2186 Just a code cleanup.
2188 * src/main/java/org/glom/web/client/ui/details/Group.java:
2189 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2191 2011-11-28 Ben Konrath <ben@bagu.org>
2193 Remove hack for glom 1.18 style glom files.
2195 * src/main/java/org/glom/web/client/ui/details/Group.java:
2196 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2197 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2199 2011-11-28 Ben Konrath <ben@bagu.org>
2201 Use Gda Value version of primary key to log result too large error.
2203 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2205 2011-11-28 Ben Konrath <ben@bagu.org>
2207 Don't use TypedDataItem.getText() for Unknown types from the URL.
2209 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2210 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2211 instead of getText().
2212 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2213 String field and getUnknown() method.
2215 2011-11-28 Ben Konrath <ben@bagu.org>
2217 Log an error message when the java-libglom .so is not present.
2219 The error message was being set in the exception but not logged.
2221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2223 2011-11-28 Ben Konrath <ben@bagu.org>
2225 Ignore LayoutItem_CalendarPortals.
2227 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2228 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2230 2011-11-28 Ben Konrath <ben@bagu.org>
2232 Extract method for creating the LayoutItemPortal DTO.
2234 Just breaking the code up into smaller chunks.
2236 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2238 2011-11-28 Ben Konrath <ben@bagu.org>
2242 This should have been added with the refactor. Oops!
2244 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2246 2011-11-28 Ben Konrath <ben@bagu.org>
2248 Create primary key value from URL string using type from Glom document.
2250 See this bug, comments 19 - 25:
2252 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2254 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2255 create a TypeDataItem for the primary key here when loading from a
2256 URL. Show the same string for the primary key value as was received
2257 from the URL string (when loading from a URL).
2258 * src/main/java/org/glom/web/server/Utils.java: Update method for
2259 creating the Gda Value from the TypeDataItem to properly deal with
2260 creating a Gda Value based on the Glom document type for the primary
2261 key value string when loading from a URL.
2262 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2263 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2264 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2265 Update for changed method name.
2267 2011-11-27 Ben Konrath <ben@bagu.org>
2269 Rename PrimaryKeyItem to TypedDataItem.
2271 The name PrimaryKeyItem suggests what the class should be used for.
2272 TypedDataItem is a neutral name that describes the class better.
2274 This is a rename-only refactor.
2276 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2277 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2278 * src/main/java/org/glom/web/client/Utils.java:
2279 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2280 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2281 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2282 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2283 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2284 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2285 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2286 * src/main/java/org/glom/web/server/Utils.java:
2287 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2288 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2289 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2290 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2292 2011-11-25 Ben Konrath <ben@bagu.org>
2294 Improve Gda Value conversion from PrimaryKeyItem.
2296 The value from the PrimaryKeyItem is only used if its type match the
2297 type from the glom document.
2299 * src/main/java/org/glom/web/server/Utils.java:
2301 2011-11-25 Ben Konrath <ben@bagu.org>
2303 Manually check if the java-liblgom .so is visible to the JVM.
2305 It seems that Tomcat has problems when a static initializer throws an
2306 exception. This check is done before the first method call into
2307 java-libglom so that execution doesn't continue if the .so is not
2310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2312 2011-11-25 Ben Konrath <ben@bagu.org>
2314 Improve browser configuration error messages.
2318 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2320 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2321 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2322 getConfigurationErrorMessage() method.
2323 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2324 Get and display a specific configuration error message when no Glom
2325 documents are found.
2326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2327 Implement getConfigurationErrorMessage() method. Surround configuration
2328 code in the init() method with a try/catch block. This allows the
2329 errors to be caught while keeping the servlet available to retrieve the
2330 configuration error message.
2332 2011-11-25 Ben Konrath <ben@bagu.org>
2334 Don't use Strings to hold primary key values.
2336 The primary key values are now held in a new data object
2337 (PrimaryKeyItem) that holds type information and the primary key value
2338 using the correct type.
2340 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2341 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2342 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2343 PrimaryKeyItem instead of String to hold the primary key value.
2344 * src/main/java/org/glom/web/client/Utils.java: Remove
2345 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2346 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2347 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2348 PrimaryKeyItem instead of String to hold the primary key value. Load
2349 document selection page when the documentID has not been set correctly.
2350 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2351 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2353 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2354 Return empty string for URL instead of "null".
2355 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2356 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2357 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2358 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2359 PrimaryKeyItem instead of String to hold primary key values.
2360 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2361 PrimaryKeyValue to a Gda Value.
2362 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2363 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2364 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2365 Replace temporary database access code that uses the PrimaryKeyValue to
2366 Gda Value conversion.
2367 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2368 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2369 PrimaryKeyItem instead of String.
2370 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2371 hold primary key values.
2373 2011-11-24 Ben Konrath <ben@bagu.org>
2375 Use newly added java-libglom API to create queries.
2377 This isn't finished. I still need to stop using Strings for primary key
2378 values in the client code.
2380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2381 libglom to use fake connections so that retrieving the query string will
2383 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2384 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2385 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2386 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2387 Use the newly added libglom sql methods and classes to create the
2388 query. Add temporary hack to convert primary value strings to Gda
2391 2011-11-23 Ben Konrath <ben@bagu.org>
2393 Don't explicitly set the height of Portals.
2395 See comments 6 - 10 of this bug for details:
2397 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2399 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2401 2011-11-23 Ben Konrath <ben@bagu.org>
2403 Use an HTML table instead of CSS for the FlowTable layout.
2405 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2406 GWT's FlexTable to implement the FlowTable.
2407 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2409 2011-11-18 Ben Konrath <ben@bagu.org>
2411 Add boolean example to HTML table mockup.
2413 * mockups/details-view-html-tables-text-entries.html:
2415 2011-11-17 Ben Konrath <ben@bagu.org>
2417 Ensure the pager buttons are always visible for related lists.
2419 To accomplish this, I've turned off text wrapping in the list view and
2420 related list tables for both the header and data text. The related list
2421 table now has a fixed layout so the it doesn't overflow its container.
2422 This is required to ensure that the cell text is clipped when it
2423 overflows the cell and an ellipsis is added to the right side of the
2424 cell when text is clipped.
2426 A fixed table layout for the related list table in the details view
2427 seems what we want for the details view anyway, so the side-effect is
2430 The ellipsis will only be displayed in Firefox >= 7.
2434 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2436 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2437 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2438 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2440 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2441 Set the 'table-layout: fixed' CSS property to the related list table.
2442 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2443 'white-space: nowrap;' CSS property on both the list view and the
2444 related list tables.
2446 2011-11-16 Ben Konrath <ben@bagu.org>
2448 Rework the fix for empty notebook tab labels.
2450 Setting the empty group titles with its name caused problems for the
2451 details layout. Instead of using libglom's
2452 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2453 to the client when the title is empty. This allows the Notebook to use
2454 the name when the title is empty without affecting anything else.
2456 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2457 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2459 2011-11-16 Ben Konrath <ben@bagu.org>
2461 Set group titles with name when title is empty.
2463 This fixes a problem with an empty notebook tab label in the Lesson
2464 Planner document. The forth tab in the notebook should be "Internet":
2466 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2468 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2469 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2472 2011-11-16 Ben Konrath <ben@bagu.org>
2474 Remove whitespace from the configured username properties.
2476 This assumes that usernames won't have whitespace at the beginning
2477 or end. But I think this is a reasonable assumption.
2479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2480 String.trim() to remove the whitespace from the username properties.
2482 2011-11-15 Ben Konrath <ben@bagu.org>
2484 Add details view mockup with HTML tables and text entries.
2486 This is from the attachment on this bug:
2488 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2490 * mockups/details-view-html-tables-text-entries.html:
2492 2011-11-15 Ben Konrath <ben@bagu.org>
2494 Add space between the columns of the flow table.
2498 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2500 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2501 space between columns in the flow table.
2503 2011-11-15 Ben Konrath <ben@bagu.org>
2505 Add backup files to the .gitignore.
2507 * .gitignore: Ignore files that end with ~.
2509 2011-11-09 Ben Konrath <ben@bagu.org>
2511 Use latest release of gwt-log.
2513 Gwt-log releases are now being submitted to the maven central
2514 repository so manual installation of the jar is no longer required.
2516 * pom.xml: Update version and groupId of gwt-log dependency.
2518 2011-10-31 Ben Konrath <ben@bagu.org>
2520 Don't use GWT numeric formatting to override the glom currency formatting.
2522 Currencies are now displayed like they are in Glom. See this bug:
2524 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2526 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2528 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2529 currency code to constructor and set it when the cell is rendered.
2530 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2531 currency code to the constructor of the NumericCell.
2533 2011-10-27 Ben Konrath <ben@bagu.org>
2535 Require the latest release of java-libglom (1.17.4).
2539 2011-10-26 Ben Konrath <ben@bagu.org>
2541 Add style to Notebook that matches current theme.
2543 It's not the best style in the world but it's better than the default.
2545 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2546 padding at the bottom of the child widgets.
2547 * src/main/webapp/style.css: Add style for the Notebook.
2549 2011-10-26 Ben Konrath <ben@bagu.org>
2551 Move servlet initialization code to overridden init method.
2553 This is half of the solution to getting proper error messages
2554 displayed when configuration errors occur. Here's the relevant bug:
2556 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2558 The rest of the solution involves surrounding the init method with a
2559 try/catch block and setting a global variable with the error /
2560 exception. A new async method should be created to retrieve and display
2561 the error message / exception.
2563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2564 code from constructor to init method adding exceptions as needed.
2566 2011-10-26 Ben Konrath <ben@bagu.org>
2568 Add script to monitor and restart tomcat if required.
2570 * utils/check-and-recover-tomcat.py: New file.
2572 2011-10-26 Ben Konrath <ben@bagu.org>
2574 Display the correct number of data items in the pager.
2578 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2580 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2581 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2582 The implementation is the same for both tables: Keep track of the
2583 number of non-empty rows and fire and RowCountChangeEvent after the data has
2585 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2586 custom Pager class that subclasses SimplePager to handle displaying
2587 the correct number when empty rows have been added.
2589 2011-10-26 Ben Konrath <ben@bagu.org>
2591 Correct error in previous commit.
2593 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2594 eventBus parameter from listView.setCellTable().
2596 2011-10-26 Ben Konrath <ben@bagu.org>
2598 Fix error in TODO comment.
2600 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2602 2011-10-24 Ben Konrath <ben@bagu.org>
2604 Create Notebook widgets to the details view.
2606 This isn't finished just yet - I still need to create a reasonable
2607 style to match the current theme.
2609 * src/main/java/org/glom/web/client/Utils.java: Add method for
2610 calculating the height of a widget. This is used in the Notebook class.
2611 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2612 new constructor method in Group.
2613 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2614 method for creating child widget that can be used by subclasses
2615 like Notebook. New constructor that allows disabling the group
2616 titles - Notebooks don't set a group title for their child groups.
2617 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2618 to make Notebooks using GWT's TabLayoutPanel.
2619 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2620 constructor that allows disabling the group titles.
2621 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2622 LayoutItemNotebook DTO.
2623 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2624 DTO for Notebooks. It's just an empty class for now but we might need
2625 it to transfer some specific information in the future.
2627 2011-10-21 Ben Konrath <ben@bagu.org>
2629 Add navigation buttons to related list tables.
2631 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2632 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2633 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2634 method getSuitableRecordToViewDetails() for getting the table name
2635 and primary key value for related list navigation buttons.
2636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2637 private cell renderer class to get the navigation information for
2638 related list tables from the server. Extract the navigation
2639 processing code from the details cell navigation and use it for the
2640 related list navigation as well.
2641 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2642 cell renderer class for the details open buttons. This was needed
2643 because the related list navigation buttons and the list view
2644 navigation buttons need to react differently when clicked.
2645 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2646 the onEnterKeyDown() method because it's now overriden in the
2647 subclasses that are specific to the related list tables and the list
2649 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2650 the vertical size a little because the buttons add a bit of vertical
2651 space to table. This is not a perfect solution because the vertical
2652 size of with table fewer than 5 rows will be a little smaller.
2653 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2654 changes in how navigation buttons are handled.
2655 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2656 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2657 database access object.
2658 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2659 to find the portal for a given relationship name from
2660 RelatedListDBAccess. Add method to find a primary key field for a
2662 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2663 Move code to find the portal for a given relationship name to
2665 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2666 New file: database access object for getting the related list
2667 navigation information (the table name and the primary key value).
2668 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2669 DTO for transferring a table name to navigate to and a primary key
2671 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2672 boolean and getter/setter to specifies if the related list should add
2675 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2677 Use the master branch of java-libglom
2679 * pom.xml: Depend on java-libglom 1.19 instead.
2681 This is the master branch. See also the libglom-1-18 branch.
2683 2011-10-11 Ben Konrath <ben@bagu.org>
2685 Enable the open navigation button when the data has been set.
2687 This avoids having active buttons that don't do anything when the data
2690 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2692 2011-10-11 Ben Konrath <ben@bagu.org>
2694 Use IsWidget interface for FlowTableItem.
2696 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2697 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2699 2011-10-11 Ben Konrath <ben@bagu.org>
2701 Remove GWT styling from open button in details view.
2703 There are still some issues with how the details cell is arranged but
2704 this should be made to match Glom 1.20. I'm going to leave fixing this
2705 until I have Glom 1.20 up and running.
2707 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2708 style name on open button.
2709 * src/main/webapp/style.css: Move and edit details-navigation class.
2710 Re-arrange some classes to make them appear in the same order as the
2713 2011-10-07 Ben Konrath <ben@bagu.org>
2715 Update to GWT 2.4.0.
2717 * .gitignore: Ignore new cache directory.
2718 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2719 * pom.xml: Change GWT and maven plugin to 2.4.0.
2720 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2722 * src/main/java/org/glom/web/client/ClientFactory.java:
2723 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2724 * src/main/java/org/glom/web/client/OnlineGlom.java:
2725 Update source for API changes.
2726 * utils/build-onlineglom-war.sh: Remove cache directory before the
2729 2011-10-07 Ben Konrath <ben@bagu.org>
2731 Add navigation buttons in the details view.
2733 This isn't finished but I thought I'd commit what I have as it's a
2734 pretty good start. I still need to:
2736 1. Change the style so that it fits better into the current theme
2737 2. Adjust the details cell to expand as much as possible.
2739 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2740 click handlers to navigation buttons in the DetailsCells. Create a
2741 refreshData() method to get just the data from the server without the
2743 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2744 Update the tableSelector and browser title when the table name
2745 changes without using the tableSelector.
2746 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2747 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2748 getDetailsCells() to getCells(). Update variable names.
2749 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2750 method to set click handler on navigation button. Rename a few
2751 variables. Add navigation buttons where needed.
2752 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2753 variables and methods.
2754 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2755 navigation boolean and navigation table as required in the
2756 LayoutItemField DTO.
2757 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2758 variables for navigation along with getter/setter methods.
2760 2011-10-07 Ben Konrath <ben@bagu.org>
2762 Rename Field to DetailsCell.
2764 This is a refactor-only commit. No functionality has been added or
2767 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2768 Update variable and method names.
2769 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2770 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2771 variable and method names.
2772 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2774 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2775 variable and method names.
2777 2011-10-07 Ben Konrath <ben@bagu.org>
2779 Create separate methods for layout and data the details view.
2781 This is a refactor-only commit. No functionality has been added or
2784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2785 private methods: setData(), createLayout().
2787 2011-10-07 Ben Konrath <ben@bagu.org>
2789 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2791 This is part of a change to get navigation buttons in the details view
2792 but it should have been done this way from the start.
2794 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2795 for method name change in TableSelectionView.
2796 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2797 Create TableChangeEvent and set the browser title using the
2798 TableSelectionView API.
2799 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2800 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2801 Change getSelectedTable() to getSelectedTableName(). Add
2802 getSelectedTableTitle().
2804 2011-10-07 Ben Konrath <ben@bagu.org>
2806 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2808 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2810 2011-10-07 Ben Konrath <ben@bagu.org>
2812 Update TableChangeEvent to use newTableName naming convention.
2814 This makes the class more consistent with GWT naming conventions.
2816 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2817 Update for method name change in TableChangeEvent.
2818 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2819 for method name change in TableChangeEvent.
2820 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2821 newTableName variable and getter method. Make toDebugString()
2824 2011-09-30 Ben Konrath <ben@bagu.org>
2826 Disable the pager in the list tables when the data row count is less than the minimum.
2828 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2829 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2831 2011-09-30 Ben Konrath <ben@bagu.org>
2833 Add empty rows to the end of related list and list view tables.
2835 I also extracted the cell rendering classes from the ListTable because
2836 the code was becoming a little crazy with all the anonymous inner
2837 classes. My plan is to use these cell rendering classes in the details
2838 view as well so this refactor will be needed for that change.
2840 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2841 set the row count in related list tables if the data has more rows
2842 than the minimum number of rows visible.
2843 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2844 row count in list view tables if the data has more rows than the
2845 minimum number of rows visible.
2846 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2847 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2849 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2850 for rendering TYPE_NUMERIC cells. The code was extracted from the
2852 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2853 class for rendering cells with buttons in list views. The code was
2854 extracted from the ListTable class.
2855 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2856 for rendering TYPE_TEXT cells. The code was extracted from the
2858 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2859 Add empty rows to the end of the data if required. Implement
2860 ListTable.getMinNumVisibleRows().
2861 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2862 cell renderer code to public classes. Return null in
2863 Column.getValue() for empty rows. Add new abstract method:
2864 getMinNumVisibleRows(). Move code to set the row count of the list view
2865 table to ListViewImpl.
2866 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2867 empty rows to the end of the data if required. Implement
2868 ListTable.getMinNumVisibleRows().
2871 2011-09-27 Ben Konrath <ben@bagu.org>
2873 Use GWT.log for client-side debugging statements.
2875 These are optimized out when deployed so I should have used this method
2876 in the first place. These statements will eventually be replaced with some sort
2877 of notification in the browser.
2879 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2880 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2881 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2882 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2883 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2885 2011-09-27 Ben Konrath <ben@bagu.org>
2887 Put tableselector on the right, back to list link on right.
2889 The idea is that the table selector is acting like a label for the
2890 currently displayed table so it should be placed below the document title. This
2891 puts the table title in a similar position to where it is in Glom.
2893 * mockups/details-contacts.html:
2894 * mockups/details-projects.html:
2895 * mockups/listview-contacts.html:
2896 * mockups/listview-projects.html:
2897 * mockups/style.css:
2898 Update mockups to match how the interfaces currently look.
2899 * src/main/webapp/style.css: Swap positions of backlink with the table
2900 selector. Add some space on the left side of the table selector to
2901 line things up with the document title.
2903 2011-09-27 Ben Konrath <ben@bagu.org>
2905 Add field colouring to details view.
2907 This change re-works how field colouring works. The colour formatting
2908 information is now set to the client with the layout information instead of
2909 with the data. This eliminates the need to send the same colour strings for
2910 data in list view column when colour information is set.
2912 In order to set an alternate colour for negative numeric values, the
2913 number is now sent to client and formatted with the GWT NumberFormat class.
2915 This change also fixes:
2917 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2919 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2920 internationalization framework which is needed for client side numeric
2922 * src/main/java/org/glom/web/client/Utils.java: New file for some
2923 client static utility methods.
2924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2925 the DataItem object to the Field class. Use a utility method to
2926 create the foreignKeyValue string.
2927 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2928 alignment and text colours in the constructor. Add setData(DataItem)
2929 method. Remove setText(String) method.
2930 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2931 colour information to GlomTextCell. Create and use GlomNumberCell for
2932 rendering numbers. Use utility method to get the string for the
2933 primary key of the key provider. Re-work how the horizontal alignment
2935 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2936 formatting to layout information. Methods for converting the libglom
2937 formatting information were moved from DBAccess.
2938 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2939 numeric formatting (it's now done on the client side). Don't set text
2940 colours in DataItem. Move libglom formatting conversion methods to
2942 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2943 getters/setters for text colour information.
2944 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2945 for transferring the libglom NumericFormat information to the client.
2946 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2947 and getters/setters for: GlomNumericFormat, background colour and
2948 foreground colour strings.
2950 2011-09-26 Ben Konrath <ben@bagu.org>
2952 Simplify code that iterates through the LayoutGroup.
2954 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2956 2011-09-26 Ben Konrath <ben@bagu.org>
2958 Accept Eclipse formatting for OnlineGlomServiceAsync.
2960 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2962 2011-09-26 Ben Konrath <ben@bagu.org>
2964 Don't use the ListDBAccess classes to get the primary key layout information.
2966 This was causing a bug where the wrong index for the hidden primary key
2967 was being sent to the client.
2969 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2970 primary key while creating the LayoutGroup DTO. Create a
2971 LayoutItemField DTO for hidden primary keys. Don't use the
2972 RelatedListDBAccess because it was only used for getting the primary
2974 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2975 access modifier from public to protected for getPrimaryKeyField() and
2976 getPrimaryKeyLayoutItemField().
2977 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2978 abstract method getExpectedResultSize() because RelatedListDBAccess
2979 doesn't have enough info to implement it.
2980 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2981 Remove @Override for getExpectedResultSize().
2982 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2983 Remove method getExpectedResultSize().
2985 2011-09-23 Ben Konrath <ben@bagu.org>
2987 Log which layout (list or details) the ignored item is from.
2989 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2991 2011-09-23 Ben Konrath <ben@bagu.org>
2993 Remove annotations that turn off code formatting in DataItem.
2995 * src/main/java/org/glom/web/shared/DataItem.java:
2997 2011-09-23 Ben Konrath <ben@bagu.org>
2999 Rename GlomField to DataItem and update associated methods.
3001 This is a rename-only refactor. No functionality has been added or
3004 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3005 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3006 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3007 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3008 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3009 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3010 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3011 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3013 * src/main/java/org/glom/web/server/database/DBAccess.java:
3014 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3015 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3016 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3017 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3018 * src/main/java/org/glom/web/shared/DataItem.java:
3019 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3020 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3022 2011-09-23 Ben Konrath <ben@bagu.org>
3024 Rename GlomDocument to DocumentInfo and update associated methods.
3026 This is a rename-only refactor. No functionality has been added or
3029 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3030 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3031 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3032 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3033 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3034 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3035 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3037 2011-09-20 Ben Konrath <ben@bagu.org>
3039 Require java-libglom 1.17.3.
3041 This picks up the fix for the seg fault problem with the Scenes table
3042 in the Openismus Film Manager example.
3046 2011-09-20 Ben Konrath <ben@bagu.org>
3048 Change the way sort clause is added for primary key when no sort clause is requested.
3050 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3051 before the sort clause is created. When a sort clause is not requested, the
3052 sort clause is created by finding the primary key in the LayoutFieldVector
3055 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3057 2011-09-20 Ben Konrath <ben@bagu.org>
3059 Log error message if no documents are found in the configured directory.
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3062 Extract the glom file extension string to a private static final class
3063 variable (mostly as syntactic sugar). Accept a minor formatting change.
3064 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3065 the example glom.document.directory configuration property to make it
3066 more clear that it can any directory, not just the home directory.
3068 2011-09-18 Ben Konrath <ben@bagu.org>
3070 Add related lists to details view.
3072 The related list table has support for paging and sorting just like the
3073 table in the list view.
3075 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3076 SQL queries for the related list tables.
3077 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3078 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3080 Rename getList methods to getListView and add comments. Remove
3081 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3082 it being unused. Add methods: getDetailsLayoutAndData(),
3083 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3084 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3085 Create the layout and set the data for the fields in one async call
3086 instead of two. Create related lists where appropriate.
3087 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3088 for method name changes in OnlineGlomService.
3089 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3090 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3091 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3093 * src/main/java/org/glom/web/client/ui/ListView.java:
3094 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3095 tableName from setCellTable(). Create a ListViewTable instead of
3097 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3098 represent a data field in the details view.
3099 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3100 from addDetailsCell() to Field class. Keep track of the Fields and
3101 Portals in the details view.
3102 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3103 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3104 and add a method to get it. Add method to set the contents of the
3106 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3107 New class for related list tables. This class has the data provider
3108 for the related list table.
3109 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3110 abstract class which is the base class for the ListViewTable and the
3112 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3113 New class for list view tables. This class has the data provider for
3114 the list view table.
3115 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3116 methods for related list tables. Add more information to the
3117 LayoutItemField and LayoutItemPortal DTOs.
3118 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3119 Remove debugging print statement.
3120 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3121 Remove debugging print statements. Add primary key field to SQL count
3123 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3124 Remove unnecessary LayoutFieldVector parameter from
3125 getResultSizeOfSQLQuery() method.
3126 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3127 New class for related list table database access.
3128 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3129 class that is a wrapper DTO for details view layout and data.
3130 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3131 new 'fromField' string to this DTO.
3132 * src/main/webapp/style.css: Remove bottom margin and override top
3135 2011-09-15 Ben Konrath <ben@bagu.org>
3137 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3139 This sets things up to make it easier to add the data retrieval for
3140 related lists (portals). No user noticeable changes were made with
3143 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3144 class has the code to retrieve the layouts and access the
3145 database using the new database helper classes.
3146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3147 Most of the functionality has been removed from this class. This
3148 class now represents the public interface for the client side
3149 code. It also deals with configuring the servlet and cleaning
3150 things up when the servlet is stopped.
3151 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3152 of static methods into this utility class.
3153 * src/main/java/org/glom/web/server/database/DBAccess.java:
3154 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3155 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3156 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3157 These classes have the database retrieval code. The class hierarchy
3158 has been setup to make it easy to reuse code for similar
3161 2011-09-06 Ben Konrath <ben@bagu.org>
3163 Create separate classes for list table code and the data provider.
3165 As part of this refactor, I also split up the code a bit to make it
3168 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3169 table code to two new classes (below).
3170 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3171 with code from ListViewImpl.
3172 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3173 New file with code from ListViewImpl.
3175 2011-09-06 Ben Konrath <ben@bagu.org>
3177 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3179 This fixes the LayoutItemPortal DTO to match the libglom layout object
3182 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3184 2011-09-01 Ben Konrath <ben@bagu.org>
3186 Set title of Portals in the Details View.
3188 * pom.xml: Bump required version of java-libglom to 1.17.1.
3189 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3190 widget creation to its own class. Add comments to constructor.
3191 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3192 The code is mostly from the Group class with the title now set.
3193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3194 title of Portal. Update some comments. Fix some code formatting.
3196 2011-09-01 Ben Konrath <ben@bagu.org>
3198 Remove TODO comment for the flow table column width.
3200 The flow table column width is working correctly and doesn't need to be
3201 changed. See this mailing list post for more info:
3203 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3205 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3207 2011-08-27 Ben Konrath <ben@bagu.org>
3209 Add document title (database name) to top of the browser page.
3211 I added the document title to the TableSelecitonView but that will
3212 change if / when we add a view that doesn't require table selection.
3214 * mockups/details-contacts.html:
3215 * mockups/details-projects.html:
3216 * mockups/listview-contacts.html:
3217 * mockups/listview-projects.html:
3218 * mockups/style.css: Add document title to mockups to keep things
3220 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3221 sizes to account for the document title.
3222 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3223 Set the document title when it has been retrieved from the server.
3224 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3225 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3226 and implement setDocumentTitle(String) method.
3227 * src/main/webapp/style.css: Add ID for document title style.
3229 2011-08-25 Ben Konrath <ben@bagu.org>
3231 Add NavigationType enum to LayoutItemPortal DTO.
3233 This is the start of adding support for Portals to the Details View.
3235 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3236 LayoutItem_Portal.navigation_type enum from libglom to
3237 LayoutItemPortal.NavigationType enum.
3238 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3239 NavigationType enum, field for storing the NavigationType and getter
3242 2011-08-25 Ben Konrath <ben@bagu.org>
3244 Implement the flow table layout in the Details View.
3246 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3247 FlowTable to Group to account for the renamed class.
3248 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3249 File. This is a container widget that implements the Glom details view
3250 flow table behaviour.
3251 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3252 org/glom/web/client/ui/FlowTable.java.
3253 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3254 so that the size of the subgroups are a closer match to the size of