1 2012-11-15 Murray Cumming <murrayc@murrayc.com>
3 Document: Static image items: Store an image URL, using the layout path.
5 * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
6 * src/main/java/org/glom/web/server/libglom/Document.java:
7 Add a constructor that takes the documentID, for use in the
9 loadLayoutNode(): Pass a Path object to the helper methods, so we
10 can use it to create a URL for LayoutItemImage items.
11 This seems as good a way as any to specify a layout item in the document.
12 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
13 Pass the documentID to the constructor, for use in the LayoutItemImage
16 2012-11-15 Murray Cumming <murrayc@murrayc.com>
18 Document: Add getLayoutItemByPath().
20 * src/main/java/org/glom/web/server/Utils.java:
21 Add buildLayoutPath() and parseLayoutPath().
22 * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these
24 * src/main/java/org/glom/web/server/libglom/Document.java:
25 Add Add getLayoutItemByPath().
26 * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test
29 This will be useful in subsequent commits.
31 2012-11-15 Murray Cumming <murrayc@murrayc.com>
33 Need a short description (OOPS!).
34 Need the bug URL (OOPS!).
36 Reviewed by NOBODY (OOPS!).
38 Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
41 * .settings/com.google.gdt.eclipse.core.prefs:
42 * .settings/com.google.gwt.eclipse.core.prefs:
43 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
44 (DetailsActivity.createLayout):
45 (DetailsActivity.setData):
46 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
48 (DetailsCell.DetailsCell):
49 (DetailsCell.setupWidgets):
50 (DetailsCell.setData):
51 (DetailsCell.getLayoutItem):
52 * src/main/java/org/glom/web/client/ui/details/Group.java:
53 (Group.createChildWidget):
54 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
55 (ConfiguredDocument.getValidListViewLayoutGroup):
56 (ConfiguredDocument.getDetailsLayoutGroup):
58 (ConfiguredDocument.updateLayoutItemImages):
59 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
60 (ConfiguredDocumentSet.getDocumentIdForFilename):
61 (ConfiguredDocumentSet):
62 (ConfiguredDocumentSet.addDocument):
63 (ConfiguredDocumentSet.readConfiguration):
64 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
65 (OnlineGlomImages.OnlineGlomImages):
66 (OnlineGlomImages.doGet):
68 (OnlineGlomImages.getImageFromDocument):
69 (OnlineGlomImages.getImageFromDatabase):
70 * src/main/java/org/glom/web/server/Utils.java:
72 (Utils.buildImageDataUrl):
73 (Utils.buildImageDataUrlStart):
74 (Utils.buildLayoutPath):
75 (Utils.parseLayoutPath):
76 * src/main/java/org/glom/web/server/database/DBAccess.java:
77 (DBAccess.convertResultSetToDTO):
78 * src/main/java/org/glom/web/server/libglom/Document.java:
82 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
83 (DocumentTest.TestThread.run):
85 2012-11-15 Murray Cumming <murrayc@murrayc.com>
87 Document: Use a better base64 decoder to read static image data.
89 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
90 getNodeTextChildAsValue(): Use the apache commons base64 decoder
91 instead of the gwt one, because it correctly decodes the strings
92 from g_base64_encode(). It is probably more correct.
93 The newlines might be confusing the gwt decoder.
95 2012-11-14 Murray Cumming <murrayc@murrayc.com>
97 Document: Do not use == to compare strings. Use equals().
99 * src/main/java/org/glom/web/server/libglom/Document.java:
100 == only checks that they are the same object, so it can
103 2012-11-14 Murray Cumming <murrayc@murrayc.com>
105 Document: Add and use public constants for layout names.
107 * src/main/java/org/glom/web/server/libglom/Document.java:
108 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
109 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
110 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
111 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
112 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
113 them here instead of hard-coded the strings repeatedly.
115 2012-11-13 Murray Cumming <murrayc@murrayc.com>
117 Document: Load static text and image items too.
119 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
120 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
121 New LayoutItem classes to represent these layout items.
122 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
123 main text of a LayoutItemText.
124 * src/main/java/org/glom/web/server/libglom/Document.java:
125 load_after_layout_group(): Handle the node types and instantiate the
127 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
128 Add testLayoutItemText() to check that the text is loaded properly.
130 2012-11-13 Murray Cumming <murrayc@murrayc.com>
132 Do not use client.GWT for shared code.
134 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
135 Import shared.GWT instead of client.GWT, which seems to be appropriate.
137 2012-11-12 Murray Cumming <murrayc@murrayc.com>
139 Use image data when recreating databases for testing.
141 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
142 for use locally (not acrosss the network) when recreating databases
144 getValue(): Use it here instead of getImageDataUrl(), noting that
145 this method is only for use when recreating databases.
146 * src/main/java/org/glom/web/server/libglom/Document.java:
147 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
149 2012-11-09 Murray Cumming <murrayc@murrayc.com>
151 OnlineGlomImages: Detect the mime-type (content type).
153 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
154 doGet(): Instead of hard-coding image/png.
156 2012-11-09 Murray Cumming <murrayc@murrayc.com>
158 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
161 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
162 Java Compiler and Java Build path settings in the UI.
164 2012-11-09 Murray Cumming <murrayc@murrayc.com>
166 Use the latest (now stable) version of GWT.
168 * pom.xml: And the latest version of the gwt-maven-plugin.
170 2012-11-08 Murray Cumming <murrayc@murrayc.com>
172 Added an Indonesian translation.
174 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
175 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
176 This is from the new translation in Glom.
178 2012-07-23 Murray Cumming <murrayc@murrayc.com>
180 Details: Show images.
182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
184 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
185 so it can be used in:
186 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
187 for serving image data.
188 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
190 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
191 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
192 setData(): For image field types, add a GWT Image widget,
193 with the URL that was set in the DataItem.
195 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
196 * src/main/java/org/glom/web/server/database/DBAccess.java:
197 convertResultSetToDTO(): Set the URL for image data, so the client browser
198 can retrieve the image from our new servlet. This uses UriBuilder.
199 Move getPrimaryKeyField to:
200 * src/main/java/org/glom/web/server/libglom/Document.java:
201 Added getTablePrimaryKeyField().
203 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
204 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
205 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
208 2012-07-22 Murray Cumming <murrayc@murrayc.com>
212 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
213 * src/main/java/org/glom/web/client/OnlineGlomService.java:
214 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
215 to gwtGlom, which is more appropriate.
216 This servlet name does not seem to be visible to the client side anyway.
218 2012-07-22 Murray Cumming <murrayc@murrayc.com>
220 Tests: Make the imports of assert*() consistent.
222 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
223 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
224 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
225 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
226 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
227 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
228 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
229 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
230 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
231 * src/test/java/org/glom/web/shared/DataItemTest.java:
233 import static org.junit.Assert.*;
234 which seems fairly common.
238 2012-07-21 Murray Cumming <murrayc@murrayc.com>
240 tests: Move a test that needs a database connection.
242 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
243 Move testGetListViewLayoutGroup() to
244 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
245 because it needs a database connection.
247 2012-07-21 Murray Cumming <murrayc@murrayc.com>
249 tests: Use @BeforeClass on tearDown().
251 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
252 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
253 This avoids leaking a postgres process in SelfHostExampleTest.
255 2012-07-21 Murray Cumming <murrayc@murrayc.com>
257 tests: Test translations more.
259 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
260 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
261 Test titles in the non-default locale.
263 2012-07-21 Murray Cumming <murrayc@murrayc.com>
265 tests: Add SelfHostConfiguredDocumentTest
267 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
268 username and password, for use by ConfiguredDocument.
269 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
270 This tests some of the ConfiguredDocument API that requires a database connection.
272 2012-07-21 Murray Cumming <murrayc@murrayc.com>
274 Document: Load title translations and test them.
276 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
277 of titles. I am surprised that we do not do this yet.
278 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
279 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
280 Test translations more.
282 2012-07-20 Murray Cumming <murrayc@murrayc.com>
286 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
287 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
288 Set the timeout here too.
290 2012-07-20 Murray Cumming <murrayc@murrayc.com>
292 tests: ConfiguredDocumentTest: Make this pass.
294 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
295 Disable tests that need a database connection.
297 2012-07-20 Murray Cumming <murrayc@murrayc.com>
299 Use Java 1.7 instead of Java 1.6.
301 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
302 to do this twice, at least for Eclipse.
303 This seems OK because it is the current version.
305 2012-07-20 Murray Cumming <murrayc@murrayc.com>
309 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
310 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
311 Avoid using a null Connection.
313 2012-07-20 Murray Cumming <murrayc@murrayc.com>
315 tests: Add a ConfiguredDocument test.
317 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
320 2012-07-20 Murray Cumming <murrayc@murrayc.com>
322 LayoutItemFIeld: getName(): Use the Field if it is set.
324 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
325 getName(): If the full field details have been set, return its name, so that
326 callers do not need to set the name separately.
327 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
328 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
329 so we can count the rows.
331 2012-07-20 Murray Cumming <murrayc@murrayc.com>
333 tests: SelfHoster: Test SqlUtils too.
335 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
336 Retrieve some data and check it too, as in the regular Glom
337 test_selfhosting_new_from_example.cc test.
338 * src/test/java/org/glom/web/server/SelfHoster.java:
339 createConnection(): Make this public.
341 2012-07-20 Murray Cumming <murrayc@murrayc.com>
343 tests: SelfHoster: createConnection(): Do not warn about expected failures.
345 Let the caller say if the connection is expected to fail, to avoid
346 irrelevant error output.
348 2012-07-20 Murray Cumming <murrayc@murrayc.com>
350 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
352 * src/test/java/org/glom/web/server/SelfHoster.java:
353 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
354 due to the inevitable need to retry the connection while the database server
357 2012-07-20 Murray Cumming <murrayc@murray.com>
359 tests: SelfHoster: createConnection(): Set a timeout.
361 * src/test/java/org/glom/web/server/SelfHoster.java:
362 createConnection(): Use setLoginTimeout() because it otherwise seems to take
363 ages to actually return when it fails.
365 2012-07-20 Murray Cumming <murrayc@murrayc.com>
367 tests: SelfHoster: selfHost(): Close the test connection.
369 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
370 When we check that the connection works, close the connection. This seems
371 to not be closed automatically otherwise.
373 2012-07-20 Murray Cumming <murrayc@murrayc.com>
375 Use slf4j-simple to see JDBC errors.
377 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
379 2012-07-19 Murray Cumming <murrayc@murrayc.com>
381 SelfHoster.discoverFirstFreePort(): Close the socket.
383 * src/test/java/org/glom/web/server/SelfHoster.java:
384 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
386 2012-07-19 Murray Cumming <murrayc@murrayc.com>
388 Avoid another code warning in Eclipse Juno.
390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
391 Do instanceof checks on the FileUtils.listFiles() result and its
394 2012-07-13 Murray Cumming <murrayc@murrayc.com>
396 Avoid some code warnings in Eclipse Juno
398 * src/main/java/org/glom/web/server/libglom/Document.java:
399 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
400 * src/test/java/org/glom/web/server/SelfHoster.java
401 createTextFile(): Make sure that the FileOutputStream is closed.
403 2012-06-22 Murray Cumming <murrayc@murrayc.com>
405 Added OnlineGlomPropertiesTest.
407 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
408 Make sure we never return a null string.
409 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
410 Added tests of the OnlineGlomProperties API, using our sample file.
412 2012-06-20 Murray Cumming <murrayc@murrayc.com>
414 Make OnlineGlomProperties be a normal class.
416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
417 Move OnlineGlomProperties into its own file to be a regular class:
418 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
419 This makes testing simpler.
421 2012-06-15 Murray Cumming <murrayc@murrayc.com>
423 OnlineGlomServiceImpl.init(): Move some code into a new method.
425 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
426 Create addDocument().
428 2012-06-15 Murray Cumming <murrayc@murrayc.com>
430 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
432 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
433 OnlineGlomProperties.getKey(): Make this more robust by moving the
434 check for *.*.filename to here.
436 2012-06-15 Murray Cumming <murrayc@murrayc.com>
438 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
441 init(): Move knowledge of the config file format into the
442 OnlineGlomProperties inner class.
444 2012-06-15 Murray Cumming <murrayc@murrayc.com>
446 SelfHostExampleTest: Make sure we cleanup on failure.
448 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
449 the use of cleanup() to a tearDown() JUnit method.
453 2012-06-12 Murray Cumming <murrayc@murrayc.com>
455 ConfiguredDocument: Add a primary key to portals at least once.
457 * src/main/java/org/glom/web/server/ConfiguredDocument.java
458 updatePortalsExtras): Fix a typo so that we add the primary key
459 column at least once.
460 This is a fix for the previous commit:
461 ConfiguredDocument: Do not add a primary key to portals each time.
463 2012-06-08 Murray Cumming <murrayc@murrayc.com>
465 SelfHoster: Avoid some compiler warnings.
467 * src/test/java/org/glom/web/server/SelfHoster.java
468 executeCommandLineAndWait():
469 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
470 the now-unused streams for stdout and stderr from the command Processes.
471 These are not used because readln() hangs while waiting for a new line,
472 where there may be no next line. The commented out code is still there
473 to help us figure out how to do this properly.
475 2012-06-08 Murray Cumming <murrayc@murrayc.com>
477 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
479 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
480 Make this actually test the cloning again, though it is not very useful
481 now that we do not use the part that had a problem with cloning before.
483 2012-06-08 Murray Cumming <murrayc@murrayc.com>
485 SelfHoster: Keep trying pg_ctl after starting postgres.
487 * src/test/java/org/glom/web/server/SelfHoster.java
488 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
489 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
490 regular Glom. This seems mad but it seems to work because the first
491 command would fail if pg_ctl would eventually fail.
493 2012-06-08 Murray Cumming <murrayc@murrayc.com>
495 SelfHoster: Wait until the server is really ready.
497 * src/test/java/org/glom/web/server/SelfHoster.java
498 selfHost(): Attempt the connection after starting the server, retrying
499 a few times if necessary, so that the server is really ready already when
500 we return from this method.
501 The regular Glom code does this too because pg_ctl reports success too soon.
503 2012-06-08 Murray Cumming <murrayc@murrayc.com>
505 ConfiguredDocument: Do not add a primary key to portals each time.
507 * src/main/java/org/glom/web/server/ConfiguredDocument.java
508 updatePortalsExtras(): Only add an extra primary key field if there is
509 none, to avoid adding one each time we retrieve the details layout from the
511 This should fix bug #676986 (Ben Konrath)
513 2012-05-25 Murray Cumming <murrayc@murrayc.com>
515 Document.load(): Support version 7 documents.
517 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
518 database_title attribute if the title attribute is not there.
521 2012-05-24 Ben Konrath <ben@bagu.org>
523 Add configuration for auto-generating mvn:i18n from with Eclipse.
525 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
527 2012-05-24 Murray Cumming <murrayc@murrayc.com>
529 Update translations, adding French.
531 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
532 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
533 Add a French translation, using the translation from Glom.
535 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
536 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
537 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
538 Update these based on the translations from Glom.
540 2012-05-24 Murray Cumming <murrayc@murrayc.com>
542 SelfHoster: Add some debug println messages to help when things fail.
544 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
545 System.out.println() lines.
547 2012-05-23 Murray Cumming <murrayc@murrayc.com>
549 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
551 * src/test/java/org/glom/web/server/SelfHoster.java:
552 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
553 instance) instead of just /usr/bin (as on Fedora). Check the result when
556 2012-05-23 Murray Cumming <murrayc@murrayc.com>
558 Remove LayoutItemPortal.get/setNavigationTable().
560 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
561 Remove get/setNavigationTable(), which is only a cache, because it is not
562 used, and does not need to be used, because that decision should be made on
564 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
565 updatePortalsExtras():
566 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
567 getNavigationRecord():
568 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
571 2012-05-21 Murray Cumming <murrayc@murrayc.com>
573 Initial self-hosting for tests.
575 * pom.xml: Change the scope for log4j, to hopefully make it
576 available to the test code which uses it indirectly via jOOQ.
577 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
578 self-hosting, though we only use it for testing.
580 * src/main/java/org/glom/web/server/libglom/Document.java:
581 example rows: Use a map instead of a list for each row of values,
582 so we know what field they are for, instead of relying on the sequence
583 being correct. This is not very efficient, but it does not really need
585 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
586 testReadTableExampleRows(): Adapted.
588 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
589 that returns an Object, for generic use. Note that Object seems to be
590 the implicit base even of double.
591 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
592 for use in CREATE TABLE SQL queries.
593 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
594 to do self-hosting of PostgreSQL databases via its command-line
595 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
596 backends/postgres_self.cc. This is incomplete - it needs more
597 warnings about failures and it needs to clean up properly when things
599 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
600 test of this new class.
602 2012-05-21 Murray Cumming <murrayc@murrayc.com>
604 Document: loading example data: Handle exceptions.
606 * src/main/java/org/glom/web/server/libglom/Document.java:
607 DateFormat.parse() and Double.valueOf() can throw exceptions, though
608 Eclipse did not warn about that.
610 2012-05-20 Murray Cumming <murrayc@murrayc.com>
612 Document: load(), save(): Handle the example rows.
614 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
616 * src/main/java/org/glom/web/server/libglom/Document.java:
617 load(), save(): Load and save the example rows, though the date, time
618 and image types are not handled properly yet.
619 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
620 Add testReadTableExampleRows() just to check that something is read.
622 2012-05-20 Murray Cumming <murrayc@murrayc.com>
624 Document: Add save().
626 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
627 Added getTranslationsMap() for use while saving.
628 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
629 Adedd getUseDefaultFormatting() for use while saving.
630 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
631 and several private methods that it uses.
633 This will be useful while testing via self-hosting.
634 It is not complete, but should be complete enough for testing.
636 2012-05-17 Murray Cumming <murrayc@murrayc.com>
638 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
640 * src/main/java/org/glom/web/client/OnlineGlomService.java
641 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
643 Remove getSortedListViewData() and getSortedRelatedListData(), adding
644 the sort column index and ascending bool to the regular method.
645 Instead, a sort column index of -1 now means no sort.
646 This is less explicit, but it's fairly simple, reduces the amount of
647 code, and makes the OnlineGlomService API slightly smaller.
648 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
649 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
651 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
652 getListViewData(), getRelatedListData():
653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
654 getListViewData(), getRelatedListData():
655 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
657 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
659 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
664 2012-05-16 Murray Cumming <murrayc@murrayc.com>
666 Use translations for top-level groups too.
668 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
669 updateTitlesForLocale(): Use the translation for the group
670 as well as for child items.
674 Just recompiled to fix a problem in the released .tar.gz file.
678 2012-05-15 Murray Cumming <murrayc@murrayc.com>
680 Corrections to navigation to related records.
682 * src/main/java/org/glom/web/client/OnlineGlomService.java:
683 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
685 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
686 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
687 relationship name, because the relationship name is not necessarily unique
689 TOOD: This is inefficient, because it passes the whole list of
690 child field items back to the server, but it is more correct, and happens
691 to fix a bug with the primary key being lost after a few navigations.
692 There is probably a chance to make this more efficient anyway in some
695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
696 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
697 * src/main/java/org/glom/web/server/ConfiguredDocument.java
698 * src/main/java/org/glom/web/server/database/DBAccess.java
699 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
700 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
703 2012-05-15 Murray Cumming <murrayc@murrayc.com>
705 Fix the use of translations.
707 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
708 Add updateTitlesForLocale().
709 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
710 Call it to discard unwanted translations and to make getTitle() return
711 the wanted translation wihout the need for the client code to specify a locale.
712 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
713 getTitle(): Fallback to the original title, as libglom does.
715 2012-05-15 Murray Cumming <murrayc@murrayc.com>
717 Document: Correctly report the number of available translation locales.
719 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
720 the available locale IDs list.
721 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
722 testLocales: Test this.
724 2012-05-15 Murray Cumming <murrayc@murrayc.com>
726 SqlUtils: Use camelCase.
728 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
729 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
730 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
731 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
732 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
733 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
735 2012-05-15 Murray Cumming <murrayc@murrayc.com>
737 Use jOOQ's tableByName() and fieldByName.
739 * pom.xml: Use jOOQ 2.3.1 to get the new API.
740 * src/main/java/org/glom/web/server/SqlUtils.java:
741 build_sql_select_step_with_where_clause(), .createField(),
742 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
743 so we can get correct quoting and escaping. Thanks to Lukas Eder for
744 adding this, and other things, to jOOQ.
746 2012-05-15 Murray Cumming <murrayc@murrayc.com>
748 SqlUtils: Remove the Connection parameters.
750 * src/main/java/org/glom/web/server/SqlUtils.java:
751 build_sql_select_with_key(), build_sql_select_with_where_clause(),
752 createSelect(), build_sql_select_step_with_where_clause(),
753 build_sql_count_select_with_where_clause(),
754 build_sql_select_count_rows(): Remove the Connection parameter because
755 jOOQ does not actually need a connectionwhen it is just used to build
757 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
759 * src/main/java/org/glom/web/server/ReportGenerator.java:
761 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
763 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
764 Constructor, getListData(), getResultSizeOfSQLQuery():
765 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
766 getSelectQuery(), getCountQuery():
767 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
768 getSelectQuery(), getCountQuery():
769 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
770 getNavigationRecord(): Adapted.
772 2012-05-14 Murray Cumming <murrayc@murrayc.com>
776 * src/main/java/org/glom/web/server/SqlUtils.java:
777 get_find_where_clause_quick(): Use a comparison of
778 lowercase values, instead of a simple equals. Regular Glom
779 uses the PostgreSQL ILIKE operator but jOOQ does not
780 support that just yet, though it will soon.
782 2012-05-14 Murray Cumming <murrayc@murrayc.com>
784 TableToViewDetails: Use a real serialization ID.
786 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
787 Though this does not fix the serialization problem.
789 2012-05-12 Murray Cumming <murrayc@murrayc.com>
791 Added LayoutItemPortalDeepCloneTest.
793 2012-05-11 Murray Cumming <murrayc@murrayc.com>
795 Make navigation work again.
797 * src/main/java/org/glom/web/server/libglom/Document.java:
798 Add getLayoutItemFieldShouldHaveNavigation().
799 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
800 Replace get/setAddNavigation() with the partly-existing
801 get/setNavigationTableName(), with an empty string being no navigation,
802 because this is simpler. Use the new
803 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
805 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
806 Add updateFieldsExtras() and call setNavigationTableName in it.
807 getDetailsLayoutGroup(),
808 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
809 createLayout(): Adapted.
810 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
811 Constructor: Adapted.
813 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
814 Replace get/setAddNavigation() with get/setNavigation(), returning a
815 TableToViewDetails class with both the table name and UsesRelationship,
816 because both are need. The previous code used java-libglom's output
817 variable (strangely, via sharedptr) to return both, but we cannot really
819 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
820 getNavigationRecord(): Adapt. However, we cannot actually use the cache
821 here because it somehow gets set to null during deepCopy(). I must test this.
822 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
823 testGetSuitableTableToViewDetails(): Adapted.
825 TODO: Find out why deepClone() is not quite working.
827 2012-05-11 Murray Cumming <murrayc@murrayc.com>
829 DBAccess: Simplify the retrievel of full field details.
831 * src/main/java/org/glom/web/server/database/DBAccess.java
832 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
833 because the Document loading should have done this.
835 2012-05-11 Murray Cumming <murrayc@murrayc.com>
837 Document: Correct loading of doubly-related layout fields.
839 * src/main/java/org/glom/web/server/libglom/Document.java:
840 loadUsesRelationship(): Actually set the related relationship, instead
841 of only setting it if it's not found.
843 2012-05-09 Murray Cumming <murrayc@murrayc.com>
845 Replace all appearances of Colour with color.
847 Because US English is dominant.
849 2012-05-09 Murray Cumming <murrayc@murrayc.com>
851 Use colors in HTML format, solving a warning about an unused function.
853 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
854 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
855 Add *asHTMLColor() versions of methods.
856 TODO: However, we should create and cache the results on the server.
857 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
858 * src/main/java/org/glom/web/client/ui/list/ListTable.java
859 * src/main/java/org/glom/web/server/ConfiguredDocument.java
860 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
861 Use the asHTMLcolor() versions.
863 2012-05-09 Murray Cumming <murrayc@murrayc.com>
865 ListViewTable: Constructor: Take the table name as a parameter.
867 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
868 Constructor: Take the tableName, and set the member variable, because
870 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
871 setCellTable(): Pass the table name.
872 This makes navigation to non-default tables work again. I don't know
873 why it worked before in the master branch.
875 2012-05-07 Murray Cumming <murrayc@murrayc.com>
877 ConfiguredDocument: Restore correct addition of hidden primary key items.
879 * src/main/java/org/glom/web/client/ui/list/ListTable.java
880 (ListTable.createCellTable): Uncomment out the check for the hidden
882 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
883 add primary key items for top-level lists and portals, as before,
884 instead of adding them to each group.
885 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
886 Actually implement the extra methods such as setHiddenPrimaryKey() and
887 comment that these are used only for top-level list groups and in portals.
888 This strangeness suggests even more that this should not be squeezed
889 into the LayoutGroup class.
891 2012-05-07 Murray Cumming <murrayc@murrayc.com>
893 Fix Formatting loading.
895 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
896 getFormattingUsed(): Remove the duplicate Formatting member variable
897 in favour of the one from the base class.
898 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
899 Initialize a new Formatting instead of using null by default, so we
900 have some defaults, instead of having to initialize one later just to
901 get the same defaults. This also makes loading of formatting from the
902 document work, because that expected a non-null.
904 2012-05-07 Murray Cumming <murrayc@murrayc.com>
906 RelatedListTable: Make sure that the tableName is set.
908 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
909 Constructor: Take the tableName so it is available later. Otherwise,
910 the server assumes that we mean the default table and cannot find the
912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
913 setData(): Pass the tableName to the RelatedListTable constructor.
915 2012-05-07 Murray Cumming <murrayc@murrayc.com>
919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
920 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
921 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
923 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
925 * src/main/java/org/glom/web/server/database/DBAccess.java:
926 convertResultSetToDTO(), getPortal():
927 * src/main/java/org/glom/web/server/database/ListDBAccess.java
929 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
930 Add checks for null objects and out of range access, with log messages to
931 give hints so we can fix these properly.
933 2012-05-07 Murray Cumming <murrayc@murrayc.com>
935 Portals: some corrections.
937 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
939 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
940 constructor: Use getRelationshipNameUsed() instead of getName(), because
941 that is what is meant.
942 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
943 getFromField(): Fix a typo, to get the field name, not the table name.
944 * src/main/java/org/glom/web/server/database/DBAccess.java:
945 getPortal(): Fix a typo that stopped this from working.
947 2012-05-07 Murray Cumming <murrayc@murrayc.com>
949 LayoutItemPortal: Also override getTitleOriginal().
951 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
952 This lets the base getTitle() with no parameters work.
953 TODO: Test this properly.
955 2012-05-06 Murray Cumming <murrayc@murrayc.com>
957 LayoutItemPortal: getTitle*(): Use the relationship title.
959 2012-05-06 Murray Cumming <murrayc@murrayc.com>
961 LayoutItemField: Fix loading of custom titles.
963 * src/main/java/org/glom/web/server/libglom/Document.java
964 loadDataLayoutItemField(): The title, if any, instead of the field
965 title, is stored in a title_custom node. Load it from there.
966 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
968 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
969 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
970 getTitle*() overrides.
971 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
974 2012-05-06 Murray Cumming <murrayc@murrayc.com>
976 LayoutItemField: Fall back to field titles, so some are really shown.
978 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
979 Override getTitleOriginal() and getTitle(), as in java-libglom.
980 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
983 2012-05-06 Murray Cumming <murrayc@murrayc.com>
985 Correct use of setExpectedResultSize().
987 * src/main/java/org/glom/web/server/ConfiguredDocument.java
988 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
989 Use setExpectedResultSize only on top-level groups (for instance, the
990 list layout) or on child portals (in details views).
991 Use the correct table name for portals to avoid SQL errors.
992 Update the expected counts when returning cached layouts.
994 2012-05-06 Murray Cumming <murrayc@murrayc.com>
996 Document: Interpret no group column count as 1.
998 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
999 default, though we now check for this in the UI code anyway.
1001 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1005 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1007 Translatable: Use Hashmap instead of Treemap because GWT supports it.
1009 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1010 The use of Treemap lead to this error from async methods, with no
1012 "The response could not be deserialized"
1014 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1016 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1018 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
1019 when using the Google -> GWT Compile, or
1020 g toolbar button -> GWT Compile Project... feature in Eclipse.
1022 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1024 ListTable.addColumn(): Protect against a null Formatting.
1026 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1027 Create a default Formatting if it is null, because that is the simplest
1030 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1032 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1034 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1035 updateLayoutGroup(): Check that the field is not null.
1037 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1039 ListViewImpl: Protected against a bad cast error.
1041 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1042 onEnterKeyDown(): Do not cast without an instanceof check.
1044 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1046 ListTable: Protect against an out of range error.
1048 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1049 createCellTable(): This is unlikely, but can happen while debugging.
1051 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1053 AsyncMessage onFailure() callbacks: Log the exception message.
1055 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1056 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1057 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1058 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1060 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1061 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1062 These are useful clues when something is wrong.
1064 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1066 ConfiguredDocument: Avoid a null dereference.
1068 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1069 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
1070 details maps are created.
1072 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1074 Document: Correct the port number parsing.
1076 * src/main/java/org/glom/web/server/libglom/Document.java:
1077 This lets us actually connect to the database and show the document.
1079 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1083 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1084 user-interaction, asking us to load a temporary URL in a browser.s
1085 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1086 which is apparently necessary for testing the service. See the comment.
1087 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1088 Show the exception, if any. This is how I saw the 404 in the HTML in
1091 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1093 DocumentTest: Move the .glom files into the resources directory.
1095 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1096 URI via getResource().
1098 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1100 Document: Remove the FieldIdentifies inner class.
1102 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1103 use the Relationship (though the same function in libglom is maybe
1104 used in other ways) and so this removes a compiler warning.
1106 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1108 Document.load() Remove the error code parameter.
1110 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1111 Remove the parameter. We do not set it yet and it could never have
1112 worked as an output parameter (though maybe it did in java-libglom).
1113 We could use an exception if we really want the failure reason.
1114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1116 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1117 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1119 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1121 Make some inner classes static.
1123 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1125 * src/main/java/org/glom/web/server/ReportGenerator.java
1126 * src/main/java/org/glom/web/server/libglom/Document.java
1127 Make all inner classes static that can be static.
1129 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1131 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1134 init(): We do not use java-libglom any more.
1136 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1138 Remove mentions of java-libglom.
1140 * README: Remove mention of java-libglom, because it no longer needed.
1141 * utils/build-onlineglom-war.sh:
1142 * utils/check-and-recover-tomcat.py:
1143 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1144 useful. Building is now far easier, with no need for jhbuild.
1146 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1148 Fix the build (mvn package)
1150 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1151 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1152 Otherwise the GWT Java->Javascript compilation fails with just this
1153 error, during mvn package or when attempting to view in a browser,
1154 in the GWT developer mode in Eclipse.
1156 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1157 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1158 [INFO] Compiling module org.glom.web.OnlineGlom
1159 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1160 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1161 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1162 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1163 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1164 [INFO] [ERROR] Cannot proceed due to previous errors
1166 It has taken me 2 days to find out what was causing that. After reducing
1167 the code, the compiler eventually showed me the full error message.
1169 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1171 ConfiguredDocument: Cache the cloned and stripped layouts.
1173 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1174 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1175 layout in a map, so we can retrieve it again without rebuilding it.
1177 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1179 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1181 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1183 libglom classes: Implement some auto-generated emthods.
1185 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1187 Add GwtTestOnlineGlomService.
1189 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1190 However, this (and the other GwtTest*) does not seem to run during
1193 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1195 Remove use of unsupported features from client code.
1197 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1198 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1199 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1200 Use our client version of StringUtils instead of the apache commons one.
1202 However, the GWT Javascript compliation still fails.
1204 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1206 Add a Field class and implement some loading of it in Document.
1208 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1210 Initial Document loading implementation, instead of libglom.
1212 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1213 and Translatable classes, and adapt the rest of the code to use them.
1214 However, this is still missing Layout and Field classes and loading.
1216 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1218 Use of jOOQ: Move Field creation into a utility method.
1220 * src/main/java/org/glom/web/server/SqlUtils.java:
1221 This lets us improve it more easily.
1223 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1225 Use of jOOQ: Improve the code to COUNT a sub-select.
1227 * src/main/java/org/glom/web/server/SqlUtils.java:
1228 Move initial query creation into
1229 build_sql_select_step_with_where_clause().
1230 build_sql_select_count_rows(): Use the jOOQ API instead of
1231 concatentating text, because a jOOQ Select*Step is a TableLike,
1232 which is what from() takes.
1234 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1236 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1238 * pom.xml: Depend on jooq.
1239 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1240 methods with jOOQ, based on the C++ implementations in libglom,
1241 with some changes to the logic required by jooQ.
1242 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1244 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1245 * src/main/java/org/glom/web/server/ReportGenerator.java:
1246 * src/main/java/org/glom/web/server/SqlUtils.java:
1247 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1248 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1249 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1250 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1251 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1252 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1253 because jOOQ needs that, though it seems unnecessary.
1255 This is not quite finished. Ideally jOOQ would help us to build
1256 table_name.field_name names, quoting and escaping them properly.
1257 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1259 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1261 Move use of Glom.build_sql*() into a new SqlUtils class.
1263 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1264 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1265 but this will make it easier to start using something other than
1266 libglom or SqlBuilder.
1268 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1270 Update the project URL.
1272 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1274 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1276 Main layout: Use a FlowTable instead of absolute positioning.
1278 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1279 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1280 child panels/widgets must have an absolute position. But that is annoying, so
1281 this adds a FlowTable and puts the child panels in there.
1283 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1285 GwtTestOnlineGlom: Comment out unused code.
1287 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1288 Eclipse has started to say that some code is unused.
1290 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1292 Update to the latest versions of dependencies.
1294 * pom.xml: Update version numbers of dependencies to the latest
1296 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1298 * src/main/java/org/glom/web/server/ReportGenerator.java:
1299 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1300 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1301 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1303 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1304 Modify the imports where necessary.
1306 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1308 Style: Remove overflow:hidden from searchbox
1310 * src/main/webapp/style.css: Because this pushes the Back To Link
1311 label/link on to the next row, which is then hidden due to the
1312 hard-coded (in ems) height.
1314 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1316 Remove some duplicate code.
1318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1319 getDocumentInfo(): This must have been duplicated during the merge from the
1324 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1326 Reports: Localize the waiting for report message.
1328 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1329 start(): Get the message from the contants.
1330 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1331 Add the string here.
1332 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1333 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1334 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1335 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1336 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1337 Update these files with the English text for newer strings for now.
1339 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1341 Reports: Show a message while waiting for the report.
1343 * src/main/java/org/glom/web/client/ui/ReportView.java
1344 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1345 Add setWaitingText(), to show a message saying that we are
1346 waiting for the report to be ready.
1347 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1348 start(): Call setWaitingText() before calling the async
1351 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1353 ReportGenerator: Specify date and time formats.
1355 * src/main/java/org/glom/web/server/ReportGenerator.java:
1356 createFieldValueElement(): Use the default (and localized)
1357 short formats, though we still need a way to show 4-digit
1358 years without providing the format for every locale.
1359 * src/main/java/org/glom/web/server/database/DBAccess.java:
1360 convertResultSetToDTO(): Use the short formats here too.
1362 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1364 ReportGenerator: Use the correct numeric formatting.
1366 * src/main/java/org/glom/web/server/ReportGenerator.java
1367 createFieldExpression(), createFieldValueElement(): Take the
1368 whole LayoutItem_Field instead of just the field name, so
1369 we have access to the formatting.
1370 createFieldValueElement(): Use JRTextField.setPattern() to
1371 specify the numeric formatting, with the help of a
1372 regular DecimalFormat.
1374 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1376 ReportGenerator: Avoid showing null for group by titles.
1378 * src/main/java/org/glom/web/server/ReportGenerator.java
1379 generateReport(): Use setBlankWhenNull() on the field title
1380 style too, because this is used for values in group by
1383 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1385 ReportGenerator: Add a colon to titles in vertical groups.
1387 * src/main/java/org/glom/web/server/ReportGenerator.java
1388 addFieldToDetailBandVertical(): Pass true for the withColon
1391 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1393 ReportGenerator: Simplify the code by using Position more.
1395 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1397 Reports: Support vertical groups, roughly.
1399 * src/main/java/org/glom/web/server/ReportGenerator.java:
1400 addToReport(): Rename to addGroupToReport() and, if necessary,
1401 call the new addVerticalGroupToReport() method.
1402 createFieldValueElement(): Let the caller specify the Y position
1405 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1407 Reports: Allow a second report to be shown.
1409 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1410 clear(): Do not remove the HTML widget, which broke the whole layout.
1412 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1414 Locales drop-down: Show that we use English by default.
1416 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1417 fillView(): When we use English, just because that is the default, when
1418 no locale is specified, show that in the Locales drop-down instead of
1419 just showing the first item.
1421 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1423 Unselect the Report/Locale/Table combo item when appropriate.
1425 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1426 setPlace(): clear reportName if this is not a ReportPlace.
1427 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1428 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1429 When the provided name is empty, unselect all items, so that none are
1430 indicated. This uses a for loop because I cannot find a single method
1433 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1435 Report: Give the user a way to get back to the list.
1437 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1438 start(), setPlace(): Show the Back To List link on reports, and also
1439 interpret selecting the empty report item as back to list.
1441 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1443 Really show the selected Report name.
1445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1446 setPlace(): Store the reportName here, if it is that kind of Place.
1447 fillView(): Set the selected Report after filling the list of reports.
1448 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1449 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1450 null Strings, though we need some way to unselect all ListBox items
1453 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1455 ReportGenerator: Try to avoid some problems.
1457 * src/main/java/org/glom/web/server/ReportGenerator.java
1458 addField(): Try to avoid duplicates, and avoid using a null
1461 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1463 Reports: Use quickFind.
1465 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1466 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1468 getReportHTML(): Add a quickFind parameter.
1469 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1470 start(): Pass the quickFind parameter.
1471 * src/main/java/org/glom/web/server/ReportGenerator.java
1472 generateReport(): Take a quickFind parameter.
1474 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1476 ReportPlace: Actually use the report name.
1478 * src/main/java/org/glom/web/client/place/ReportPlace.java
1479 getPlace(): Do not assign the report name to the quickfind.
1481 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1483 Show java.library.path when complaining.
1485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1486 init(): When telling us to check java.library.path, show the
1489 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1491 ReportGenerator: Do not show nulls.
1493 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1495 ReportGenerator: Make the title font larger.
1497 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1499 ReportGenerator: Put field titles inside groups, if there are groups.
1501 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1503 ReportGenerator: Take the Report itself instead of the name and group.
1505 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1506 Remove getReportLayoutGroup().
1507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1508 getReportHTML(): Pass the report instead
1509 of its name and layout group.
1510 * src/main/java/org/glom/web/server/ReportGenerator.java
1511 generateReport(): Use the report object to use the title
1512 instead of the name.
1514 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1516 ReportGenerator: Remove designBand parameters.
1518 * src/main/java/org/glom/web/server/ReportGenerator.java:
1519 Make designBand a class member instead of passing it to all
1522 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1524 ReportGenerator: Add lines, a bit like in the desktop version.
1526 * src/main/java/org/glom/web/server/ReportGenerator.java
1527 addToReport(): Use JRDesignLine.
1529 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1531 ReportGenerator: Correct the title positions and use some bold style.
1533 * src/main/java/org/glom/web/server/ReportGenerator.java:
1534 Break the code up into reusable functions, correct the placement of
1535 titles, and use normal/bold styles as in the reports in the desktop
1538 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1540 ReportGenerator: Add a header band to show the field titles.
1542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1543 getReportHTML(): Pass the localeId to the ReportGenerator
1545 * src/main/java/org/glom/web/server/ReportGenerator.java
1546 constructor: Take the localeID so we can get translated field
1548 generateReport(), addToReport(), addFieldToBand(): Add field
1549 titles in a column header band.
1551 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1553 Reports drop-down list: Some improvement.
1555 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1556 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1557 Adedd setSelectedReport(),
1558 setReportList(): Add a blank line so that the user can select the
1560 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1561 start(): Show the current report by calling setSelectedReport().
1562 This does not seem to work yet.
1564 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1566 DetailsActivity, ListActivity: Move some variables into a base class.
1568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1569 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1570 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1571 the clientFactory, documentID, tableName and authenticationPopup into
1572 a base class, to avoid duplication.
1574 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1576 Translate the Reports label.
1578 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1579 Get the "Reports" label string from the constants.
1580 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1581 perties: Add Reports to the constants.
1583 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1585 Reports: Implement grouping.
1587 * src/main/java/org/glom/web/server/ReportGenerator.java:
1588 Handle LayoutItem_GroupBy items and try to do the right thing
1589 with JRDesignGroup. It seems to work.
1591 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1593 Actually show some data with JasperReports.
1595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1596 getReportHTML(): Move most code into a ReportGenerator class.
1597 * src/main/java/org/glom/web/server/ReportGenerator.java:
1598 Recurse into sub-groups, adding fields to the JasperDesign's details
1599 band. Note that we must set an arbitrary width and height, or it just
1600 will not show any data.
1602 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1604 Reports Chooser: Show the titles, not the names.
1606 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1607 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1608 and the names as the values.
1609 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1610 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1611 group now that we provide the report name, so it should always
1614 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1616 Depend on jasperreports.
1618 * pom.xml: Add the dependency. My plan is to use this on the
1621 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1623 Implement navigation to report places.
1625 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1626 start(): Do not bother to handle all events here.
1627 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1628 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1629 Added getSelectedReport().
1630 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1631 .java: start(): When handling a change to the reports chooser,
1632 call getSelectedReport() and goTo() its ReportPlace.
1633 * src/main/java/org/glom/web/client/ui/ReportView.java
1634 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1635 Added setReportHTML() which puts the html in a gwt HTML widget.
1636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1637 getReportHTML(): Return "TODO" just to show that this works.
1639 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1641 Make ReportPlace usable.
1643 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1644 Mention ReportPlace.
1645 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1646 Correct the @prefix annotation.
1648 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1650 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1652 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1653 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1655 Change getReportLayout() to getReportHMTL() because we will not need to
1656 parse or render the report layout on the client side.
1657 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1658 getReportLayout(): Return the libglom LayoutGroup type because we will
1659 not need to convert to a shared type, because this will not be used on
1661 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1664 Note that there is still no implementation for this.
1667 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1669 Add a (empty) Report Place, View, and Activity.
1671 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1673 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1674 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1675 this into a superclass:
1676 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1677 and also use it as the base of this new ReportPlace:
1678 * src/main/java/org/glom/web/client/place/ReportPlace.java
1680 * src/main/java/org/glom/web/client/ui/ReportView.java
1681 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1682 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1683 Add these, containing mostly boiler-plate for now.
1685 * src/main/java/org/glom/web/client/OnlineGlomService.java
1686 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1687 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1689 Add API to get the LayoutGroup for the report.
1691 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1693 Add and fill a Reports drop-down list box.
1695 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1697 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1698 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1700 Added getReports(document, table, localeID), calling
1701 ConfiguredDocument.getReports().
1702 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1703 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1704 Added setReportsList() and a list widget.
1705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1706 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1711 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1713 Translations: Add Esperanto.
1715 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1716 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1717 properties: Add this translation because someone took the time to make it.
1719 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1721 Adapt to the java-libglom 1.21.7 API.
1723 * src/main/java/org/glom/web/server/ReportGenerator.java:
1724 addToReport(): get_group_secondary_fields() is now
1725 get_secondary_fields().
1728 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1730 Use the latest java-libglom version.
1732 * pom.xml: Use java-libglom 1.21.7.
1734 2012-03-03 Ben Konrath <ben@bagu.org>
1736 Display date and time in details view.
1738 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1740 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1742 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1744 Require the latest java-libglom.
1746 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1748 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1750 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1752 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1753 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1754 an empty quickfind string. I also corrected libglom to create only
1755 empty where clauses for empty quickfind strings, but this avoids the
1758 2012-02-24 Ben Konrath <ben@bagu.org>
1760 Improve the tabs in the Notebook widget.
1764 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1766 Translations: Try to translate the strings.
1768 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1769 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1770 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1771 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1772 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1773 Take the Open translation from GTK+'s .po files.
1774 Take the Details translation from Glom's po files.
1775 I have added the other strings to Glom so we can get translations that way:
1776 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1778 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1780 TableSelectionViewImpl: Put the search label and entry in a div.
1782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1783 Put the search widgets in a FlowTable so that the CSS can be used to
1784 style them while keeping them together.
1785 * src/main/webapp/style.css: Mention the new div.
1787 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1789 Translate more strings in more locales.
1791 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1792 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1793 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1794 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1795 Translate the "Details" and "Open" string too.
1797 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1798 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1799 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1800 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1801 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1802 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1803 Add these new locales as placeholders though they currently contain English.
1805 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1807 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1810 Check the ConfiguredDocument* for null before using it.
1812 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1814 Tell Eclipse about the generated java files.
1816 * .classpath: This lets it find OnlineGlomConstants.java.
1817 It would be nice if Eclipse just used the maven build files.
1819 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1821 Prevent a crash when no locale is specified in the URL.
1823 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1824 Avoid returning a null string, obtained from
1825 Window.Location.getParameter(). This caused a crash when it was
1826 later passed to libglom's API.
1827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1828 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1829 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1830 guard against future null strings.
1832 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1834 Use the ?locale= query param instead of the &lang= token param.
1836 * src/main/java/org/glom/web/client/place/ListPlace.java
1837 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1838 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1839 Remove the lang token key and value.
1841 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1842 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1843 When the user selects a different locale from the chooser, use
1844 Window.Location.assign() to change the URL, which then causes a reload.
1846 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1847 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1848 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1849 * src/main/java/org/glom/web/client/activity/ListActivity.java
1850 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1851 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1852 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1853 * src/main/java/org/glom/web/client/ui/ListView.java:
1854 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1856 Remove localeID member variables and method/constructor parameters, instead
1857 using Utils.getCurrentLocaleID() when we need a localID to pass to
1860 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1862 Internationalize the UI strings.
1864 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1865 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1866 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1867 because it is unused. Messages are apparently strings that can have
1868 parameters, but we do not need that yet, so Contants will be enough for now.
1869 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1870 to say that we support the en and de locales.
1871 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1872 The original English strings.
1873 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1874 Some German translations of the English strings.
1875 The i18n goal then uses the .properties file to generate an
1876 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1877 returns an implementation that returns the translated strings.
1878 The documentation suggests putting these in src/java/*/client/, but it seems
1879 best to put it in src/resources/*/client/.
1880 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1881 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1882 instead of hard-coding them.
1883 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1884 but that does not seem to stop the build, though it confuses Eclipse.
1886 You can see the translated string by adding ?locale=de to the URL, like so:
1887 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1889 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1891 Improve null/empty String checks.
1893 * pom.xml: Add a dependency on commons-lang, to use
1894 org.apache.commons.lang.StringUtils.
1895 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1897 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1898 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1899 Use StringUtils.isEmpty().
1901 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1902 StringUtils class with a static isEmpty() function because we
1903 cannot use org.apache.commons.lang.StringUtils in client-side
1904 GWT code because it (apparently) cannot be compiled to javascript.
1905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1906 * src/main/java/org/glom/web/client/activity/ListActivity.java
1907 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1908 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1909 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1910 * src/main/java/org/glom/web/client/place/ListPlace.java
1911 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1912 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1913 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1914 * src/main/java/org/glom/web/client/ui/details/Group.java
1915 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1916 our StringUtils.isEmpty() function.
1918 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1920 Update to the latest java-libglom API.
1922 * pom.xml: Require java-libglom 1.21.4.
1923 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1924 getDocumentInfo(), getListViewLayoutGroup():
1925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1927 * src/main/java/org/glom/web/server/database/DBAccess.java
1928 getFieldsToShowForSQLQueryAddGroup(),
1929 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1930 with either get_database_title_original() or
1931 get_database_title(localeID).
1933 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1935 ConfiguredDocument: Avoid a null pointer exception.
1937 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1938 Initialize localeID to "" to avoid returning a null String which
1939 causes a crash in java-libglom's swing-generated code.
1941 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1943 Some simple renaming.
1945 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1946 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1947 for localeChooser. This seems more appropriate and is less ambiguous
1948 particularly in the .css file.
1950 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1952 ConfiguredDocument: Rename the localedID private member variable.
1954 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1956 Adapt to the latest java-libglom API from git master.
1958 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1959 libglom now uses only Vector instead of List, which uses add() instead of
1962 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1964 ConfiguredDocument: Rename the localedID private member variable.
1966 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1968 Build a source tarball with mvn assembly:single
1970 * assembly.xml: Add this file.
1971 * pom.xml: Use the maven-assembly-plugin and tell it to use
1972 our assembly.xml file.
1974 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1976 OnlineGlomServiceImpl: Get .glom files recursively.
1978 * pom.xml: Depend on commons-io from org.apache.commons.
1979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1980 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1981 files recursively, and with the easier filter for the extension.
1982 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1983 simplify that code too.
1985 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1987 README: Mention that you must install java-libglom packages separately.
1989 But then it works, because java-libglom is now in the central maven
1992 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1994 locales drop-down: Show the correct selected locale when the URL changes.
1996 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1997 .java: setPlace(): Move some code into fillView().
1999 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2001 locales drop-down: Do not lose the primary key.
2003 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2004 start(): onLocaleChange(): Pass the current primary key value,
2005 instead of an empty value.
2007 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2009 locales drop-down: Do not lose the drop-down selection.
2011 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2012 .java (TableSelectionActivity.fillView): Set the selected locale
2013 after changing the drop-down items (though we do not really need
2014 to change them just because the locale changes.)
2016 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2018 locales drop-down: Change the tables list when this changes.
2020 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2021 .java: TableSelectionActivity.start(): Move the async table titles
2022 retrieval into a private fillView() method and also call this when
2023 the chosen locale changes.
2024 Note that the document title is not actually translatable yet, but
2025 that is a problem that I should fix soon in libglom.
2027 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2029 Improve the placement of the locales drop-down.
2031 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2032 Put the title and locales drop-down in a div (gwt.FlowTable).
2033 * src/main/webapp/style.css: Add magic css properties to make this work.
2034 Also remove the left margin from the title so that it lines up with the
2037 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2039 locales selector: Show human-readable locale titles.
2041 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2042 getDocumentInfo(): Use java.util.Locale to show a real title of
2043 each locale, in the locale's own language.
2045 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2047 Add a language/locale selector drop-down.
2049 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2050 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2051 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2052 getDocumentInfo(): Store the available Locales in the DocumentInfo.
2053 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2054 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2055 Add a ListBox to show the available locales. Add getLocaleSelector(),
2056 setLocaleList(), getSelectedLocale(), setSelectedLocale().
2057 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2058 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2059 java: Add these classes.
2060 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2061 start(): Fill the locales ListBox. Handle its change event, firing a
2063 setPlace(): Show the selected locale as specified by the URL token.
2064 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2065 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2066 Handle LocaleChangeEvent, going to a new *Place with that locale.
2068 The placement of the ListBox is not pretty, and it currently uses the ID
2069 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
2073 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2075 Search box: Show the search text from the URL token.
2077 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2078 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2079 Add setQuickFindText().
2080 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2081 .java: setPlace(): Store the queryText if the place is a ListPlace,
2082 and call TableSelectionView.setQuickFindText().
2084 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2086 Allow use of translations via, for instance, &lang=de in the URL.
2088 * pom.xml: Use the unstable java-libglom 1.21 version.
2090 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2091 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2093 init(): Instead of calling TranslatableItem.set_current_locale()
2094 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2095 However, this is only for default locales, which are not needed to
2096 change the locale in the URL.
2097 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2098 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2099 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2100 layout for a particular locale.
2101 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2102 Add get/setDefaultLocaleID().
2103 getDocumentInfo(), getListViewData(), getRelatedListData(),
2104 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2105 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2106 localeID parameter, so we can get the layout for a particular locale.
2108 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2109 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2110 * src/main/java/org/glom/web/client/place/ListPlace.java:
2111 Parse and construct a lang parameter too.
2113 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2114 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2115 passed to subsequent methods and constructors.
2116 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2117 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2118 Store the localeID from the *Place and pass it to other constructors
2119 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2121 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2122 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2123 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2124 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2125 * src/main/java/org/glom/web/client/ui/ListView.java:
2126 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2127 Take localeID parameters and pass them to subsequent constructors and
2128 methods, so that the layout is always retrieved for that locale.
2130 This is rather repetitive.
2132 Note that "" means the original (default) locale of the Glom document,
2133 which is usually English.
2135 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2137 Documents: Remove final keyword to fix startup configuration.
2139 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2140 final keywords on the private member variables because that breaks
2141 the startup, apparently (there are warnings) because it stops them
2142 from being serialized. I added these in the previous commit.
2144 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2146 Documents: Add some final keywords.
2148 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2151 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2153 OnlineGlomServiceImpl: Add to overview comments.
2155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2156 Note that this is where all the document are loaded. They are not
2157 loaded freshly for each page.
2159 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2163 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2164 Add a TextBox for the text of a quick find.
2165 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2167 setBackLink(): Add a String quickFind parameter.
2168 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2169 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2170 to the base interface, because that is how TableSelectionViewImpl is used.
2171 * src/main/webapp/style.css: Add style for the search box and its label.
2173 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2174 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2175 Add these files, based on the existing TableChangeEvent and
2176 TableChangeEventHandlers.
2177 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2178 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2179 a ListPlace() that the user should be taken to.
2180 * src/main/java/org/glom/web/client/activity/ListActivity.java
2181 start(): Handle it here too and adapt the TableChangeEvent handler to
2182 pass the extra "" quickFind parameter to ListPlace.
2183 * src/main/java/org/glom/web/client/place/ListPlace.java:
2184 Constructor: Take an extra String quickFind parameter and store it,
2185 returning it from a new getQuickFind() method.
2186 getToken(): Put the quickFind text in the URL token.
2187 getPlace(): Parse the quickFind text from the URL token.
2188 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2189 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2190 ListPlace constructor.
2191 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2192 .java: start(): Add a Change handler for the TableSelectionView's
2193 TextBox (via its base HasChangeHandlers interface), firing the new
2194 QuickFindChangeEvent.
2195 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2196 pass the extra "" quickFind parameter.
2198 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2199 setCellTable(): Add a String quickFind parameter and pass it to
2200 the ListViewTable() constructor.
2201 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2202 setCellTable() in the base interface, because that is how ListViewImpl
2205 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2206 Add a String quickFind member variable.
2207 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2208 Constructor: Add a String quickFind parameter, storing it in the
2209 base ListTable's member variable.
2210 onRangeChanged(): Pass quickFind to the
2211 OnlineGlomServiceAsync.getSortedListViewData() and
2212 OnlineGlomServiceAsync.getListViewData() methods.
2214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2215 getListViewData(), getSortedListViewData(): Add a String quickFind
2216 parameter, passing it to ConfiguredDocument.getListViewData().
2217 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2218 Change getListViewData(), getSortedListViewData() in the base interface,
2219 because that is how OnlineGlomServiceImpl is used, via this:
2220 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2221 Change getListViewData(), getSortedListViewData() here too.
2222 This class can apparently be used to asynchronously call methods on
2223 OnlineGlomService, and GWT seems to implement that after recognizing
2224 just the *Async name convention and the extra AsyncCallback parameters.
2226 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2227 getListViewData(): Add a String quickFind parameter, and pass it to
2228 ListViewDBAccess.getData().
2229 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2230 getListData(): Add a String quickFind parameter and pass it to
2232 getSelectQuery(): Add a String quickFind parameter.
2233 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2234 getSelectQuery(): Add a String quickFind parameter and use it with
2235 Glom.get_find_where_clause_quick() to pass a where_clause to
2236 Glom.build_sql_select_with_where_clause(), to actually filter the
2238 getData(): Add a String quickFind parameter, passing it to getListData().
2239 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2240 va: getData(): Pass an empty string to getListData() for the
2241 quickFind parameter.
2243 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2245 ListTable: Minor change.
2247 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2248 createCellTable(): Make this protected instead of public.
2250 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2252 Many files: Use final for the parameters and use the @override attribute.
2254 2012-01-22 Ben Konrath <ben@bagu.org>
2256 Add anchor links for single line text that starts with http, ftp and www.
2260 2012-01-22 Ben Konrath <ben@bagu.org>
2262 Add ellipsis to single line text in details view.
2266 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2268 Remove all javadoc author tags.
2270 Because they are awkward and meaningless when many people touch
2272 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2274 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2276 Revert the COPYING.LESSER to COPYING rename.
2278 Apparently both should be there if it is LGPL.
2280 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2282 *View: Remove unused imports.
2284 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2285 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2286 * src/main/java/org/glom/web/client/ui/ListView.java:
2287 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2288 Remove unused imports, as suggested by Eclipse.
2290 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2292 Move the *View::Presenter types, and some API into one base View.
2294 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2295 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2296 * src/main/java/org/glom/web/client/ui/ListView.java:
2297 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2298 Presenter, setPresenter() and clear() into a shared base interface,
2299 to avoid the unnecessary duplicate Presenter types and to more clearly
2300 show how the *Views share the same structure, even if they are not
2301 used polymorphically.
2303 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2304 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2307 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2308 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2310 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2313 Feel free to revert this if there is a good reason for the duplicate
2316 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2318 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2320 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2321 a class member instead of a local variable in the method.
2322 This lets us use it to get the view instances, for use in tests.
2323 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2324 beforeOnlineGlom(): Test some more details of the initial view.
2325 Again, this is not very useful.
2327 To really test gwt-glom we will need to start a local postgresql
2328 instance with local data, like the Glom tests in C++.
2330 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2332 pom.xml: Mention the LGPL license.
2334 * pom.xml: Add a licenses section.
2335 * COPYING.LESSER: Move this to COPYING, which
2336 previously contained the GPL. But gwt-glom is all LGPL.
2338 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2340 Add project information to README and pom.xml.
2342 * README: Add a brief description and mention some mvn
2344 * pom.xml: This extra information shows up in mvn site
2347 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2349 Use the latest java-libglom version.
2351 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2353 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2355 GwtTestOnlineGlom: Test a little more.
2357 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2358 protected rather than private, as suggested by the gwt-test-utils
2360 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2361 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2362 Test the initial visibility of the panels.
2364 However, this is not a very useful test.
2365 And I wonder how we should generally test using this idea for an
2366 activity/places app like ours where the real changes happen implicitly
2367 based on the history token/URL.
2369 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2371 Slight modification to *Mapper comments.
2373 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2374 (DataActivityMapper)
2375 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2377 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2379 Remove comments mentioning GIN because they are just copied from
2380 the example code and are apparently not helpful:
2381 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2382 Also change the mention of a class that is only in the example code.
2384 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2386 GwtTestOnlineGlom test: Minor changes.
2388 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2389 Avoid the long qualified class name and modify the comment
2390 because it is now obvious to me that the mocked class is the only
2391 custom one created via GWT.create().
2393 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2395 Tests: Added the beginnings of a test using gwt-test-utils.
2397 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2398 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2399 which tells gwt-test-utils what class will be tested.
2400 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2401 Add a simple (but empty) test case. One class, used by the OnlineGlom
2402 class, is mocked so that it can be created. However, I am not sure
2403 why only this class needs to be mocked.
2405 Note that mockito seems more popular, and clearer, than easymock,
2406 but I have not got that working yet. It might be a matter of the
2409 This test is run during mvn integration-test.
2411 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2413 Tests: Use junit4-style syntax instead of junit3-style.
2415 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2416 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2417 * src/test/java/org/glom/web/shared/DataItemTest.java:
2418 Use the @Test annotation rather than relying on the test*() prefix.
2419 Also no longer implement TestCase, to avoid triggering support for
2420 the junit3-way, which stops the annotations from working.
2421 Change the imports from import junit.framework.* to
2422 import org.junit.*, which is apparently the new way.
2424 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2426 Added a test for ListPlace token parsing and creation.
2428 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2429 This is much the same as DetailsPlaceTest.
2431 I wonder how we could test the other parts of the *Place API.
2433 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2435 DetailsPlace test: Also test getToken() and recreation via getPlace().
2437 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2438 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2439 recreate it, testing the recreated DetailsPlace for the same parameter
2442 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2444 Use the surefire-report plugin.
2446 * pom.xml: This generates a HTML report about the tests in
2447 target/site/surefire-report.html
2448 when you do mvn surefire-report:report. It seems to be popular/normal.
2450 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2452 Added a test for DetailsPlace.
2454 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2455 Test the getPlace() token parsing.
2457 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2459 Added a first unit test.
2461 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2462 * src/test/java/org/glom/web/shared/DataItemTest.java:
2463 This is a silly test but it is just to get things started. Note that
2464 maven/junit finds the test because it looks in src/test by default.
2466 2011-12-22 Ben Konrath <ben@bagu.org>
2468 Change charsetName to "UTF-8" when replacing line breaks.
2470 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2471 that work in Java (such as "UTF8") will not work when compiled to
2474 This fixes a problem with multi-line details view fields that have hard
2475 line breaks. The "License Text" field on this page demonstrates the
2478 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2480 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2482 2011-12-22 Ben Konrath <ben@bagu.org>
2484 Fix another bug with related list navigation.
2486 I've tested all the navigation buttons in all of the related lists
2487 so things should be good now.
2489 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2491 2011-12-22 Ben Konrath <ben@bagu.org>
2493 Fix a crasher when refreshing the list view with the default table.
2495 This crash will also happen when loading the list view with the default
2496 table from a link or bookmark.
2498 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2499 to the main document selection page when the document id hasn't been
2501 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2502 the main document selection page when the document id hasn't been
2504 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2505 values for the details place when the document id hasn't been set.
2506 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2507 values for the list place when the document id hasn't been set.
2509 2011-12-21 Ben Konrath <ben@bagu.org>
2511 Protect against NPE when glom.document.locale is not in config.
2513 This patch protects against an NPE when glom.document.locale is not in
2514 the config file. This NPE will also happen if glom.document.locale is
2517 The patch also updates the error message to display the class name when
2518 the getMessage() returns null. This was happening when the NPE was
2519 thrown and I had "Configuration Error: null". If an NPE is encountered
2520 with this patch, "Configuration Error: NullPointerException " will be
2523 This commit closes this bug:
2525 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2529 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2531 Rename onlineglom.properties to onlineglom.properties.sample.
2533 * src/main/resources/onlineglom.properties: Rename to:
2534 * src/main/resources/onlineglom.properties.sample:
2535 * src/main/resources/README: And add this file explaining that people
2536 should rename it back when deploying.
2538 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2540 Allow choosing the translation in the .properties file.
2542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2543 init(): Read a glom.document.locale value from the configuration file
2544 and call Glom's TransatableItem::set_current_locale() method.
2545 * src/main/resources/onlineglom.properties: Add a commented-out
2546 example of this new setting.
2548 It would be better to add &lang=de_DE to the URL, but the current
2549 libglom API does not allow us to do this easily. I am working on that.
2551 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2553 Avoid a crash in parsing of token parameters.
2555 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2556 ava: getTokenParams(): Do not crash if a parameter has a key but no
2557 value, and ignore parameters with neither.
2559 2011-12-17 Murray Cumming <murrayc@murayc.com>
2561 History token building/handling: Improve use of token parameters.
2563 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2564 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2565 and buildParamsToken(HashMap), for use by derived classes.
2566 Make the separator private because it is no longer be needed.
2567 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2568 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2569 instead of manual string concatenation.
2570 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2571 of hardcoded indices and awkward splitting code.
2572 * src/main/java/org/glom/web/client/place/ListPlace.java
2573 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2574 instead of manual string concatenation.
2575 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2576 of hardcoded indices and awkward splitting code.
2577 This should fix bug #666420
2579 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2581 Fix a Navgiation->Navigation typo in the code.
2583 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2584 Rename processNavgiation() to processNavigation().
2586 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2588 Fix a seperator->separator typo in the code.
2590 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2591 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2592 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2595 2011-12-15 Ben Konrath <ben@bagu.org>
2597 Cleanup some comments.
2599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2601 2011-12-14 Ben Konrath <ben@bagu.org>
2603 Replace \n with <br/> for multiline text in the details view.
2605 Vertical scrollbars are added when needed as well.
2607 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2609 2011-12-14 Ben Konrath <ben@bagu.org>
2611 Specify the font for document selection links.
2613 * src/main/webapp/style.css:
2615 2011-12-14 Ben Konrath <ben@bagu.org>
2617 Fix bouncy CellTable while paging.
2619 This doesn't currently work with related list tables in unselected
2622 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2624 2011-12-14 Ben Konrath <ben@bagu.org>
2626 Revamp the appearance of the document selection page.
2628 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2629 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2630 * src/main/webapp/style.css:
2632 2011-12-13 Ben Konrath <ben@bagu.org>
2634 Set navigation button column to the smallest size possible.
2636 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2638 2011-12-13 Ben Konrath <ben@bagu.org>
2640 Change OpenButton nomenclature to NavigationButton.
2642 Using NavigtionButton makes things more generic. Classes, methods and
2643 variables have been changed.
2645 This is a rename-only refactor.
2647 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2648 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2649 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2650 Renamed from OpenButtonCell.
2651 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2652 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2653 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2655 2011-12-12 Ben Konrath <ben@bagu.org>
2657 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2659 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2660 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2661 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2662 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2664 2011-12-12 Ben Konrath <ben@bagu.org>
2666 Update variable names and comments.
2668 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2669 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2671 2011-12-12 Ben Konrath <ben@bagu.org>
2673 Properly initialize numNonEmptyRows variable to zero.
2675 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2676 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2678 2011-12-05 Ben Konrath <ben@bagu.org>
2680 Add latest mockup with HTML tables.
2682 Features of this mockup:
2684 -> HTML table for flowtable
2685 -> HTML table for flowtable column
2686 -> Example of how related lists would look
2687 -> Not using text entries for data items
2689 The current version of Online Glom doesn't use HTML tables for the
2692 This mockup has been sent to the glom-devel mailing list but it's good
2693 to have it here as well.
2695 * mockups/details-view-html-tables.html:
2697 2011-12-05 Ben Konrath <ben@bagu.org>
2699 Remove unnecessary getPrimaryKeyField() method.
2701 getPrimaryKeyFieldForTable(String) has been renamed to
2702 getPrimaryKeyField(String).
2704 * src/main/java/org/glom/web/server/database/DBAccess.java:
2705 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2706 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2708 2011-12-05 Ben Konrath <ben@bagu.org>
2710 Add string representation of TypedDataItem value to conversion error message.
2712 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2713 message was extracted into its own method to avoid duplication.
2715 2011-12-05 Ben Konrath <ben@bagu.org>
2717 Add type checking to navigation primary key value creation.
2719 Create navigation primary key only if the expected type from the Glom
2720 document matches the type returned by the SQL query.
2722 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2724 2011-12-05 Ben Konrath <ben@bagu.org>
2726 Rename a couple of variables in RelatedListNavigation.
2728 This is a rename-only refactor.
2730 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2732 2011-12-05 Ben Konrath <ben@bagu.org>
2734 Move getListLayoutGroup() into getListViewLayoutGroup().
2736 This removes getListLayoutGroup(). It was only being called by
2737 getListViewLayoutGroup().
2739 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2741 2011-12-05 Ben Konrath <ben@bagu.org>
2743 Remove check for LayoutItem_Portal in list table method.
2745 This check is no longer necessary because the method isn't being used
2746 to create the LayoutItemPortal DTO.
2748 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2750 2011-12-05 Ben Konrath <ben@bagu.org>
2752 Properly support related list navigation.
2754 Navigation from the "Repository Analyzer -> Package Scans ->
2755 Dependencies" related table wasn't working because the primary key for
2756 related tables wasn't being set properly. This commit fixes the
2759 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2760 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2761 doesn't set the primary key properly for related list tables.
2762 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2763 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2764 useful for getting the primary key for list view tables and for related
2766 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2767 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2768 Move code to set the primary key for the table from the abstract
2769 ListDBAccess class to ListViewDBAccess as it's only correct for list
2771 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2772 Properly add primary key to related list tables.
2774 2011-12-02 Ben Konrath <ben@bagu.org>
2776 Properly set the horizontal alignment of fields.
2778 This fix is for both the list tables and the details view.
2780 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2781 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2782 to set the horizontal alignment of fields.
2784 2011-12-02 Ben Konrath <ben@bagu.org>
2786 Display currency codes in the details view.
2788 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2790 2011-12-02 Ben Konrath <ben@bagu.org>
2792 Avoid duplicate JNI call.
2794 JNI is not as efficient as pure Java and this is an easy (and small)
2797 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2798 Use previously retrieved value for whereClauseToTableName instead of
2801 2011-12-02 Ben Konrath <ben@bagu.org>
2803 Rename a couple of variables in RelatedListNavigation.
2805 This is a rename-only refactor.
2807 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2809 2011-12-02 Ben Konrath <ben@bagu.org>
2811 Indicate clearly that a mismatched primary key type is a bug.
2813 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2814 warning to error. Add 'This is a bug.' to message.
2816 2011-12-02 Ben Konrath <ben@bagu.org>
2818 Update / fix some comments.
2820 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2822 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2824 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2825 Fix comments. Add some TODOs.
2827 2011-12-02 Ben Konrath <ben@bagu.org>
2829 Enable navigation to details view with string primary key from related list.
2831 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2832 Create a text primary key value when return type of result is
2833 java.sql.Types.VARCHAR.
2835 2011-12-02 Ben Konrath <ben@bagu.org>
2837 Use checkboxes for booleans in the details view.
2839 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2841 2011-12-01 Ben Konrath <ben@bagu.org>
2843 Improve performance of related list height calculation.
2845 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2846 Put code to calculate the expected height in a static initializer so
2847 that that it's only called once.
2849 2011-12-01 Ben Konrath <ben@bagu.org>
2851 Show related list tables in notebooks (again).
2853 Calculate the height of the related list tables so the Notebook can be
2854 set the correct height. The height of the related list table is also needed by
2855 FlowTable to be able decide how to create the layout.
2857 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2858 and set the Portal height based on the height of the related list
2859 table and the Portal container.
2860 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2861 Add method to calculate the height of the related list tables.
2862 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2863 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2864 calculate the height of the Pager widget.
2866 2011-12-01 Ben Konrath <ben@bagu.org>
2868 Use CellTable API for table property instead of setting style on Element.
2870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2872 2011-12-01 Ben Konrath <ben@bagu.org>
2874 Make ListViewTable and RelatedListTable a consistent height.
2876 The tables are now a consistent height regardless of the contents of
2877 the table. A hidden button is added to empty rows to ensure that the
2878 height of these rows will match the height of rows with data.
2880 A navigation button column is now added to every table. The width of
2881 the navigation column is set to 0px when a RelatedListTable shouldn't
2882 have navigation buttons. This maintains the a consistent row height in
2883 tables that don't show the navigation buttons.
2885 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2886 navigation column when not needed.
2887 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2888 arguments for navigation button to constructor of ListViewTable.
2889 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2890 hidden button for empty data rows.
2891 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2892 arguments for navigation button to constructor.
2893 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2894 create navigation buttons. Add hideNavigationButtons() method.
2895 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2896 arguments for navigation button to constructor.
2898 2011-12-01 Ben Konrath <ben@bagu.org>
2900 Use 'visibility: hidden' in Utils.getWidgetHeight().
2902 This is better choice because hidden elements are invisible, don't
2903 respond to events and are not part of the tab order. They will,