1 2011-12-30 Murray Cumming <murrayc@murrayc.com>
3 DetailsPlace test: Also test getToken() and recreation via getPlace().
5 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
6 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
7 recreate it, testing the recreated DetailsPlace for the same parameter
10 2011-12-30 Murray Cumming <murrayc@murrayc.com>
12 Use the surefire-report plugin.
14 * pom.xml: This generates a HTML report about the tests in
15 target/site/surefire-report.html
16 when you do mvn surefire-report:report. It seems to be popular/normal.
18 2011-12-30 Murray Cumming <murrayc@murrayc.com>
20 Added a test for DetailsPlace.
22 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
23 Test the getPlace() token parsing.
25 2011-12-30 Murray Cumming <murrayc@murrayc.com>
27 Added a first unit test.
29 * pom.xml: Add a test goal, and a dependency on junit in that scope.
30 * src/test/java/org/glom/web/shared/DataItemTest.java:
31 This is a silly test but it is just to get things started. Note that
32 maven/junit finds the test because it looks in src/test by default.
34 2011-12-22 Ben Konrath <ben@bagu.org>
36 Change charsetName to "UTF-8" when replacing line breaks.
38 JavaScript requires the charsetName to be "UTF-8". CharsetName values
39 that work in Java (such as "UTF8") will not work when compiled to
42 This fixes a problem with multi-line details view fields that have hard
43 line breaks. The "License Text" field on this page demonstrates the
46 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
48 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
50 2011-12-22 Ben Konrath <ben@bagu.org>
52 Fix another bug with related list navigation.
54 I've tested all the navigation buttons in all of the related lists
55 so things should be good now.
57 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
59 2011-12-22 Ben Konrath <ben@bagu.org>
61 Fix a crasher when refreshing the list view with the default table.
63 This crash will also happen when loading the list view with the default
64 table from a link or bookmark.
66 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
67 to the main document selection page when the document id hasn't been
69 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
70 the main document selection page when the document id hasn't been
72 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
73 values for the details place when the document id hasn't been set.
74 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
75 values for the list place when the document id hasn't been set.
77 2011-12-21 Ben Konrath <ben@bagu.org>
79 Protect against NPE when glom.document.locale is not in config.
81 This patch protects against an NPE when glom.document.locale is not in
82 the config file. This NPE will also happen if glom.document.locale is
85 The patch also updates the error message to display the class name when
86 the getMessage() returns null. This was happening when the NPE was
87 thrown and I had "Configuration Error: null". If an NPE is encountered
88 with this patch, "Configuration Error: NullPointerException " will be
91 This commit closes this bug:
93 https://bugzilla.gnome.org/show_bug.cgi?id=666669
95 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
97 2011-12-20 Murray Cumming <murrayc@murrayc.com>
99 Rename onlineglom.properties to onlineglom.properties.sample.
101 * src/main/resources/onlineglom.properties: Rename to:
102 * src/main/resources/onlineglom.properties.sample:
103 * src/main/resources/README: And add this file explaining that people
104 should rename it back when deploying.
106 2011-12-20 Murray Cumming <murrayc@murrayc.com>
108 Allow choosing the translation in the .properties file.
110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
111 init(): Read a glom.document.locale value from the configuration file
112 and call Glom's TransatableItem::set_current_locale() method.
113 * src/main/resources/onlineglom.properties: Add a commented-out
114 example of this new setting.
116 It would be better to add &lang=de_DE to the URL, but the current
117 libglom API does not allow us to do this easily. I am working on that.
119 2011-12-19 Murray Cumming <murrayc@murrayc.com>
121 Avoid a crash in parsing of token parameters.
123 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
124 ava: getTokenParams(): Do not crash if a parameter has a key but no
125 value, and ignore parameters with neither.
127 2011-12-17 Murray Cumming <murrayc@murayc.com>
129 History token building/handling: Improve use of token parameters.
131 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
132 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
133 and buildParamsToken(HashMap), for use by derived classes.
134 Make the separator private because it is no longer be needed.
135 * src/main/java/org/glom/web/client/place/DetailsPlace.java
136 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
137 instead of manual string concatenation.
138 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
139 of hardcoded indices and awkward splitting code.
140 * src/main/java/org/glom/web/client/place/ListPlace.java
141 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
142 instead of manual string concatenation.
143 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
144 of hardcoded indices and awkward splitting code.
145 This should fix bug #666420
147 2011-12-16 Murray Cumming <murrayc@murrayc.com>
149 Fix a Navgiation->Navigation typo in the code.
151 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
152 Rename processNavgiation() to processNavigation().
154 2011-12-16 Murray Cumming <murrayc@murrayc.com>
156 Fix a seperator->separator typo in the code.
158 * src/main/java/org/glom/web/client/place/DetailsPlace.java
159 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
160 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
163 2011-12-15 Ben Konrath <ben@bagu.org>
165 Cleanup some comments.
167 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
169 2011-12-14 Ben Konrath <ben@bagu.org>
171 Replace \n with <br/> for multiline text in the details view.
173 Vertical scrollbars are added when needed as well.
175 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
177 2011-12-14 Ben Konrath <ben@bagu.org>
179 Specify the font for document selection links.
181 * src/main/webapp/style.css:
183 2011-12-14 Ben Konrath <ben@bagu.org>
185 Fix bouncy CellTable while paging.
187 This doesn't currently work with related list tables in unselected
190 * src/main/java/org/glom/web/client/ui/list/ListTable.java
192 2011-12-14 Ben Konrath <ben@bagu.org>
194 Revamp the appearance of the document selection page.
196 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
197 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
198 * src/main/webapp/style.css:
200 2011-12-13 Ben Konrath <ben@bagu.org>
202 Set navigation button column to the smallest size possible.
204 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
206 2011-12-13 Ben Konrath <ben@bagu.org>
208 Change OpenButton nomenclature to NavigationButton.
210 Using NavigtionButton makes things more generic. Classes, methods and
211 variables have been changed.
213 This is a rename-only refactor.
215 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
216 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
217 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
218 Renamed from OpenButtonCell.
219 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
220 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
221 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
223 2011-12-12 Ben Konrath <ben@bagu.org>
225 Remove unnecessary String argument in RelatedListTable and ListViewTable.
227 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
228 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
229 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
230 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
232 2011-12-12 Ben Konrath <ben@bagu.org>
234 Update variable names and comments.
236 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
237 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
239 2011-12-12 Ben Konrath <ben@bagu.org>
241 Properly initialize numNonEmptyRows variable to zero.
243 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
244 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
246 2011-12-05 Ben Konrath <ben@bagu.org>
248 Add latest mockup with HTML tables.
250 Features of this mockup:
252 -> HTML table for flowtable
253 -> HTML table for flowtable column
254 -> Example of how related lists would look
255 -> Not using text entries for data items
257 The current version of Online Glom doesn't use HTML tables for the
260 This mockup has been sent to the glom-devel mailing list but it's good
261 to have it here as well.
263 * mockups/details-view-html-tables.html:
265 2011-12-05 Ben Konrath <ben@bagu.org>
267 Remove unnecessary getPrimaryKeyField() method.
269 getPrimaryKeyFieldForTable(String) has been renamed to
270 getPrimaryKeyField(String).
272 * src/main/java/org/glom/web/server/database/DBAccess.java:
273 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
274 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
276 2011-12-05 Ben Konrath <ben@bagu.org>
278 Add string representation of TypedDataItem value to conversion error message.
280 * src/main/java/org/glom/web/server/Utils.java: Logging the error
281 message was extracted into its own method to avoid duplication.
283 2011-12-05 Ben Konrath <ben@bagu.org>
285 Add type checking to navigation primary key value creation.
287 Create navigation primary key only if the expected type from the Glom
288 document matches the type returned by the SQL query.
290 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
292 2011-12-05 Ben Konrath <ben@bagu.org>
294 Rename a couple of variables in RelatedListNavigation.
296 This is a rename-only refactor.
298 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
300 2011-12-05 Ben Konrath <ben@bagu.org>
302 Move getListLayoutGroup() into getListViewLayoutGroup().
304 This removes getListLayoutGroup(). It was only being called by
305 getListViewLayoutGroup().
307 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
309 2011-12-05 Ben Konrath <ben@bagu.org>
311 Remove check for LayoutItem_Portal in list table method.
313 This check is no longer necessary because the method isn't being used
314 to create the LayoutItemPortal DTO.
316 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
318 2011-12-05 Ben Konrath <ben@bagu.org>
320 Properly support related list navigation.
322 Navigation from the "Repository Analyzer -> Package Scans ->
323 Dependencies" related table wasn't working because the primary key for
324 related tables wasn't being set properly. This commit fixes the
327 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
328 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
329 doesn't set the primary key properly for related list tables.
330 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
331 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
332 useful for getting the primary key for list view tables and for related
334 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
335 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
336 Move code to set the primary key for the table from the abstract
337 ListDBAccess class to ListViewDBAccess as it's only correct for list
339 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
340 Properly add primary key to related list tables.
342 2011-12-02 Ben Konrath <ben@bagu.org>
344 Properly set the horizontal alignment of fields.
346 This fix is for both the list tables and the details view.
348 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
349 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
350 to set the horizontal alignment of fields.
352 2011-12-02 Ben Konrath <ben@bagu.org>
354 Display currency codes in the details view.
356 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
358 2011-12-02 Ben Konrath <ben@bagu.org>
360 Avoid duplicate JNI call.
362 JNI is not as efficient as pure Java and this is an easy (and small)
365 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
366 Use previously retrieved value for whereClauseToTableName instead of
369 2011-12-02 Ben Konrath <ben@bagu.org>
371 Rename a couple of variables in RelatedListNavigation.
373 This is a rename-only refactor.
375 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
377 2011-12-02 Ben Konrath <ben@bagu.org>
379 Indicate clearly that a mismatched primary key type is a bug.
381 * src/main/java/org/glom/web/server/Utils.java: Change log level from
382 warning to error. Add 'This is a bug.' to message.
384 2011-12-02 Ben Konrath <ben@bagu.org>
386 Update / fix some comments.
388 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
390 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
392 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
393 Fix comments. Add some TODOs.
395 2011-12-02 Ben Konrath <ben@bagu.org>
397 Enable navigation to details view with string primary key from related list.
399 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
400 Create a text primary key value when return type of result is
401 java.sql.Types.VARCHAR.
403 2011-12-02 Ben Konrath <ben@bagu.org>
405 Use checkboxes for booleans in the details view.
407 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
409 2011-12-01 Ben Konrath <ben@bagu.org>
411 Improve performance of related list height calculation.
413 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
414 Put code to calculate the expected height in a static initializer so
415 that that it's only called once.
417 2011-12-01 Ben Konrath <ben@bagu.org>
419 Show related list tables in notebooks (again).
421 Calculate the height of the related list tables so the Notebook can be
422 set the correct height. The height of the related list table is also needed by
423 FlowTable to be able decide how to create the layout.
425 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
426 and set the Portal height based on the height of the related list
427 table and the Portal container.
428 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
429 Add method to calculate the height of the related list tables.
430 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
431 * src/main/webapp/style.css: Add css class for Pager. This is needed to
432 calculate the height of the Pager widget.
434 2011-12-01 Ben Konrath <ben@bagu.org>
436 Use CellTable API for table property instead of setting style on Element.
438 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
440 2011-12-01 Ben Konrath <ben@bagu.org>
442 Make ListViewTable and RelatedListTable a consistent height.
444 The tables are now a consistent height regardless of the contents of
445 the table. A hidden button is added to empty rows to ensure that the
446 height of these rows will match the height of rows with data.
448 A navigation button column is now added to every table. The width of
449 the navigation column is set to 0px when a RelatedListTable shouldn't
450 have navigation buttons. This maintains the a consistent row height in
451 tables that don't show the navigation buttons.
453 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
454 navigation column when not needed.
455 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
456 arguments for navigation button to constructor of ListViewTable.
457 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
458 hidden button for empty data rows.
459 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
460 arguments for navigation button to constructor.
461 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
462 create navigation buttons. Add hideNavigationButtons() method.
463 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
464 arguments for navigation button to constructor.
466 2011-12-01 Ben Konrath <ben@bagu.org>
468 Use 'visibility: hidden' in Utils.getWidgetHeight().
470 This is better choice because hidden elements are invisible, don't
471 respond to events and are not part of the tab order. They will,
472 however, take up space which is required to be able to calculate the
473 height of the widget.
475 * src/main/java/org/glom/web/client/Utils.java:
477 2011-12-01 Ben Konrath <ben@bagu.org>
479 Use Utils.getWidgetHeight() in FlowTable.
481 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
483 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
485 2011-12-01 Ben Konrath <ben@bagu.org>
487 Put the details css class name on the correct table column.
489 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
491 2011-11-30 Ben Konrath <ben@bagu.org>
493 Update for java-libglom API change.
495 The getters and setters on FieldFormatting and NumericFormat were
496 changed to remove the 'M'.
498 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
500 2011-11-29 Ben Konrath <ben@bagu.org>
502 Only allow RelatedListTables in Portals.
504 * src/main/java/org/glom/web/client/ui/details/Portal.java:
506 2011-11-29 Ben Konrath <ben@bagu.org>
508 Only create a contents panel for Portals when title is being set.
510 * src/main/java/org/glom/web/client/ui/details/Portal.java:
512 2011-11-29 Ben Konrath <ben@bagu.org>
514 Set TabLayoutPanel height based on calculated height its widgets.
516 This is a potential fix for this bug:
518 https://bugzilla.gnome.org/show_bug.cgi?id=665133
520 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
522 2011-11-29 Ben Konrath <ben@bagu.org>
524 Align details field labels and data with the Open buttons.
526 * src/main/webapp/style.css:
528 2011-11-29 Ben Konrath <ben@bagu.org>
530 Remove unnecessary <div> in the Notebook widget.
532 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
533 method to get container FlowPanel (<div>).
534 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
535 initWidget() method directly on the TabLayoutPanel widget instead of
536 Group's container widget.
538 2011-11-29 Ben Konrath <ben@bagu.org>
540 Don't add group titles for Portals in Notebooks.
542 This reverts the previous patch and fixes a bug I introduced with
543 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
545 * src/main/java/org/glom/web/client/ui/details/Group.java:
546 * src/main/java/org/glom/web/client/ui/details/Portal.java:
548 2011-11-28 Ben Konrath <ben@bagu.org>
550 Remove unused boolean argument in Portal constructor.
554 * src/main/java/org/glom/web/client/ui/details/Group.java:
555 * src/main/java/org/glom/web/client/ui/details/Portal.java:
557 2011-11-28 Ben Konrath <ben@bagu.org>
559 Remove hack for glom 1.18 style glom files.
561 * src/main/java/org/glom/web/client/ui/details/Group.java:
562 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
563 * src/main/java/org/glom/web/client/ui/details/Portal.java:
565 2011-11-28 Ben Konrath <ben@bagu.org>
567 Use Gda Value version of primary key to log result too large error.
569 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
571 2011-11-28 Ben Konrath <ben@bagu.org>
573 Don't use TypedDataItem.getText() for Unknown types from the URL.
575 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
576 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
577 instead of getText().
578 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
579 String field and getUnknown() method.
581 2011-11-28 Ben Konrath <ben@bagu.org>
583 Log an error message when the java-libglom .so is not present.
585 The error message was being set in the exception but not logged.
587 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
589 2011-11-28 Ben Konrath <ben@bagu.org>
591 Ignore LayoutItem_CalendarPortals.
593 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
594 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
596 2011-11-28 Ben Konrath <ben@bagu.org>
598 Extract method for creating the LayoutItemPortal DTO.
600 Just breaking the code up into smaller chunks.
602 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
604 2011-11-28 Ben Konrath <ben@bagu.org>
608 This should have been added with the refactor. Oops!
610 * src/main/java/org/glom/web/shared/TypedDataItem.java:
612 2011-11-28 Ben Konrath <ben@bagu.org>
614 Create primary key value from URL string using type from Glom document.
616 See this bug, comments 19 - 25:
618 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
620 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
621 create a TypeDataItem for the primary key here when loading from a
622 URL. Show the same string for the primary key value as was received
623 from the URL string (when loading from a URL).
624 * src/main/java/org/glom/web/server/Utils.java: Update method for
625 creating the Gda Value from the TypeDataItem to properly deal with
626 creating a Gda Value based on the Glom document type for the primary
627 key value string when loading from a URL.
628 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
629 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
630 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
631 Update for changed method name.
633 2011-11-27 Ben Konrath <ben@bagu.org>
635 Rename PrimaryKeyItem to TypedDataItem.
637 The name PrimaryKeyItem suggests what the class should be used for.
638 TypedDataItem is a neutral name that describes the class better.
640 This is a rename-only refactor.
642 * src/main/java/org/glom/web/client/OnlineGlomService.java:
643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
644 * src/main/java/org/glom/web/client/Utils.java:
645 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
646 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
647 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
648 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
649 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
650 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
651 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
652 * src/main/java/org/glom/web/server/Utils.java:
653 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
654 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
655 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
656 * src/main/java/org/glom/web/shared/NavigationRecord.java:
658 2011-11-25 Ben Konrath <ben@bagu.org>
660 Improve Gda Value conversion from PrimaryKeyItem.
662 The value from the PrimaryKeyItem is only used if its type match the
663 type from the glom document.
665 * src/main/java/org/glom/web/server/Utils.java:
667 2011-11-25 Ben Konrath <ben@bagu.org>
669 Manually check if the java-liblgom .so is visible to the JVM.
671 It seems that Tomcat has problems when a static initializer throws an
672 exception. This check is done before the first method call into
673 java-libglom so that execution doesn't continue if the .so is not
676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
678 2011-11-25 Ben Konrath <ben@bagu.org>
680 Improve browser configuration error messages.
684 https://bugzilla.gnome.org/show_bug.cgi?id=662792
686 * src/main/java/org/glom/web/client/OnlineGlomService.java:
687 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
688 getConfigurationErrorMessage() method.
689 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
690 Get and display a specific configuration error message when no Glom
692 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
693 Implement getConfigurationErrorMessage() method. Surround configuration
694 code in the init() method with a try/catch block. This allows the
695 errors to be caught while keeping the servlet available to retrieve the
696 configuration error message.
698 2011-11-25 Ben Konrath <ben@bagu.org>
700 Don't use Strings to hold primary key values.
702 The primary key values are now held in a new data object
703 (PrimaryKeyItem) that holds type information and the primary key value
704 using the correct type.
706 * src/main/java/org/glom/web/client/OnlineGlomService.java:
707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
709 PrimaryKeyItem instead of String to hold the primary key value.
710 * src/main/java/org/glom/web/client/Utils.java: Remove
711 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
712 PrimaryKeyItem based on the GlomFieldType and the DataItem.
713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
714 PrimaryKeyItem instead of String to hold the primary key value. Load
715 document selection page when the documentID has not been set correctly.
716 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
717 DetailsPlace -> URL and URL -> DetailsPlace conversion with
719 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
720 Return empty string for URL instead of "null".
721 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
722 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
723 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
724 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
725 PrimaryKeyItem instead of String to hold primary key values.
726 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
727 PrimaryKeyValue to a Gda Value.
728 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
729 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
730 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
731 Replace temporary database access code that uses the PrimaryKeyValue to
732 Gda Value conversion.
733 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
734 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
735 PrimaryKeyItem instead of String.
736 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
737 hold primary key values.
739 2011-11-24 Ben Konrath <ben@bagu.org>
741 Use newly added java-libglom API to create queries.
743 This isn't finished. I still need to stop using Strings for primary key
744 values in the client code.
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
747 libglom to use fake connections so that retrieving the query string will
749 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
750 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
751 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
752 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
753 Use the newly added libglom sql methods and classes to create the
754 query. Add temporary hack to convert primary value strings to Gda
757 2011-11-23 Ben Konrath <ben@bagu.org>
759 Don't explicitly set the height of Portals.
761 See comments 6 - 10 of this bug for details:
763 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
765 * src/main/java/org/glom/web/client/ui/details/Portal.java:
767 2011-11-23 Ben Konrath <ben@bagu.org>
769 Use an HTML table instead of CSS for the FlowTable layout.
771 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
772 GWT's FlexTable to implement the FlowTable.
773 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
775 2011-11-18 Ben Konrath <ben@bagu.org>
777 Add boolean example to HTML table mockup.
779 * mockups/details-view-html-tables-text-entries.html:
781 2011-11-17 Ben Konrath <ben@bagu.org>
783 Ensure the pager buttons are always visible for related lists.
785 To accomplish this, I've turned off text wrapping in the list view and
786 related list tables for both the header and data text. The related list
787 table now has a fixed layout so the it doesn't overflow its container.
788 This is required to ensure that the cell text is clipped when it
789 overflows the cell and an ellipsis is added to the right side of the
790 cell when text is clipped.
792 A fixed table layout for the related list table in the details view
793 seems what we want for the details view anyway, so the side-effect is
796 The ellipsis will only be displayed in Firefox >= 7.
800 https://bugzilla.gnome.org/show_bug.cgi?id=662930
802 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
803 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
804 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
806 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
807 Set the 'table-layout: fixed' CSS property to the related list table.
808 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
809 'white-space: nowrap;' CSS property on both the list view and the
812 2011-11-16 Ben Konrath <ben@bagu.org>
814 Rework the fix for empty notebook tab labels.
816 Setting the empty group titles with its name caused problems for the
817 details layout. Instead of using libglom's
818 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
819 to the client when the title is empty. This allows the Notebook to use
820 the name when the title is empty without affecting anything else.
822 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
823 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
825 2011-11-16 Ben Konrath <ben@bagu.org>
827 Set group titles with name when title is empty.
829 This fixes a problem with an empty notebook tab label in the Lesson
830 Planner document. The forth tab in the notebook should be "Internet":
832 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
834 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
835 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
838 2011-11-16 Ben Konrath <ben@bagu.org>
840 Remove whitespace from the configured username properties.
842 This assumes that usernames won't have whitespace at the beginning
843 or end. But I think this is a reasonable assumption.
845 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
846 String.trim() to remove the whitespace from the username properties.
848 2011-11-15 Ben Konrath <ben@bagu.org>
850 Add details view mockup with HTML tables and text entries.
852 This is from the attachment on this bug:
854 https://bugzilla.gnome.org/show_bug.cgi?id=663109
856 * mockups/details-view-html-tables-text-entries.html:
858 2011-11-15 Ben Konrath <ben@bagu.org>
860 Add space between the columns of the flow table.
864 https://bugzilla.gnome.org/show_bug.cgi?id=662918
866 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
867 space between columns in the flow table.
869 2011-11-15 Ben Konrath <ben@bagu.org>
871 Add backup files to the .gitignore.
873 * .gitignore: Ignore files that end with ~.
875 2011-11-09 Ben Konrath <ben@bagu.org>
877 Use latest release of gwt-log.
879 Gwt-log releases are now being submitted to the maven central
880 repository so manual installation of the jar is no longer required.
882 * pom.xml: Update version and groupId of gwt-log dependency.
884 2011-10-31 Ben Konrath <ben@bagu.org>
886 Don't use GWT numeric formatting to override the glom currency formatting.
888 Currencies are now displayed like they are in Glom. See this bug:
890 https://bugzilla.gnome.org/show_bug.cgi?id=646216
892 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
894 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
895 currency code to constructor and set it when the cell is rendered.
896 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
897 currency code to the constructor of the NumericCell.
899 2011-10-27 Ben Konrath <ben@bagu.org>
901 Require the latest release of java-libglom (1.17.4).
905 2011-10-26 Ben Konrath <ben@bagu.org>
907 Add style to Notebook that matches current theme.
909 It's not the best style in the world but it's better than the default.
911 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
912 padding at the bottom of the child widgets.
913 * src/main/webapp/style.css: Add style for the Notebook.
915 2011-10-26 Ben Konrath <ben@bagu.org>
917 Move servlet initialization code to overridden init method.
919 This is half of the solution to getting proper error messages
920 displayed when configuration errors occur. Here's the relevant bug:
922 https://bugzilla.gnome.org/show_bug.cgi?id=662792
924 The rest of the solution involves surrounding the init method with a
925 try/catch block and setting a global variable with the error /
926 exception. A new async method should be created to retrieve and display
927 the error message / exception.
929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
930 code from constructor to init method adding exceptions as needed.
932 2011-10-26 Ben Konrath <ben@bagu.org>
934 Add script to monitor and restart tomcat if required.
936 * utils/check-and-recover-tomcat.py: New file.
938 2011-10-26 Ben Konrath <ben@bagu.org>
940 Display the correct number of data items in the pager.
944 https://bugzilla.gnome.org/show_bug.cgi?id=661441
946 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
947 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
948 The implementation is the same for both tables: Keep track of the
949 number of non-empty rows and fire and RowCountChangeEvent after the data has
951 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
952 custom Pager class that subclasses SimplePager to handle displaying
953 the correct number when empty rows have been added.
955 2011-10-26 Ben Konrath <ben@bagu.org>
957 Correct error in previous commit.
959 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
960 eventBus parameter from listView.setCellTable().
962 2011-10-26 Ben Konrath <ben@bagu.org>
964 Fix error in TODO comment.
966 * src/main/java/org/glom/web/client/activity/ListActivity.java:
968 2011-10-24 Ben Konrath <ben@bagu.org>
970 Create Notebook widgets to the details view.
972 This isn't finished just yet - I still need to create a reasonable
973 style to match the current theme.
975 * src/main/java/org/glom/web/client/Utils.java: Add method for
976 calculating the height of a widget. This is used in the Notebook class.
977 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
978 new constructor method in Group.
979 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
980 method for creating child widget that can be used by subclasses
981 like Notebook. New constructor that allows disabling the group
982 titles - Notebooks don't set a group title for their child groups.
983 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
984 to make Notebooks using GWT's TabLayoutPanel.
985 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
986 constructor that allows disabling the group titles.
987 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
988 LayoutItemNotebook DTO.
989 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
990 DTO for Notebooks. It's just an empty class for now but we might need
991 it to transfer some specific information in the future.
993 2011-10-21 Ben Konrath <ben@bagu.org>
995 Add navigation buttons to related list tables.
997 * src/main/java/org/glom/web/client/OnlineGlomService.java:
998 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
999 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1000 method getSuitableRecordToViewDetails() for getting the table name
1001 and primary key value for related list navigation buttons.
1002 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1003 private cell renderer class to get the navigation information for
1004 related list tables from the server. Extract the navigation
1005 processing code from the details cell navigation and use it for the
1006 related list navigation as well.
1007 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1008 cell renderer class for the details open buttons. This was needed
1009 because the related list navigation buttons and the list view
1010 navigation buttons need to react differently when clicked.
1011 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1012 the onEnterKeyDown() method because it's now overriden in the
1013 subclasses that are specific to the related list tables and the list
1015 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1016 the vertical size a little because the buttons add a bit of vertical
1017 space to table. This is not a perfect solution because the vertical
1018 size of with table fewer than 5 rows will be a little smaller.
1019 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1020 changes in how navigation buttons are handled.
1021 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1022 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1023 database access object.
1024 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1025 to find the portal for a given relationship name from
1026 RelatedListDBAccess. Add method to find a primary key field for a
1028 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1029 Move code to find the portal for a given relationship name to
1031 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1032 New file: database access object for getting the related list
1033 navigation information (the table name and the primary key value).
1034 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1035 DTO for transferring a table name to navigate to and a primary key
1037 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1038 boolean and getter/setter to specifies if the related list should add
1041 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1043 Use the master branch of java-libglom
1045 * pom.xml: Depend on java-libglom 1.19 instead.
1047 This is the master branch. See also the libglom-1-18 branch.
1049 2011-10-11 Ben Konrath <ben@bagu.org>
1051 Enable the open navigation button when the data has been set.
1053 This avoids having active buttons that don't do anything when the data
1056 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1058 2011-10-11 Ben Konrath <ben@bagu.org>
1060 Use IsWidget interface for FlowTableItem.
1062 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1063 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1065 2011-10-11 Ben Konrath <ben@bagu.org>
1067 Remove GWT styling from open button in details view.
1069 There are still some issues with how the details cell is arranged but
1070 this should be made to match Glom 1.20. I'm going to leave fixing this
1071 until I have Glom 1.20 up and running.
1073 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1074 style name on open button.
1075 * src/main/webapp/style.css: Move and edit details-navigation class.
1076 Re-arrange some classes to make them appear in the same order as the
1079 2011-10-07 Ben Konrath <ben@bagu.org>
1081 Update to GWT 2.4.0.
1083 * .gitignore: Ignore new cache directory.
1084 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1085 * pom.xml: Change GWT and maven plugin to 2.4.0.
1086 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1088 * src/main/java/org/glom/web/client/ClientFactory.java:
1089 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1090 * src/main/java/org/glom/web/client/OnlineGlom.java:
1091 Update source for API changes.
1092 * utils/build-onlineglom-war.sh: Remove cache directory before the
1095 2011-10-07 Ben Konrath <ben@bagu.org>
1097 Add navigation buttons in the details view.
1099 This isn't finished but I thought I'd commit what I have as it's a
1100 pretty good start. I still need to:
1102 1. Change the style so that it fits better into the current theme
1103 2. Adjust the details cell to expand as much as possible.
1105 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1106 click handlers to navigation buttons in the DetailsCells. Create a
1107 refreshData() method to get just the data from the server without the
1109 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1110 Update the tableSelector and browser title when the table name
1111 changes without using the tableSelector.
1112 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1113 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1114 getDetailsCells() to getCells(). Update variable names.
1115 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1116 method to set click handler on navigation button. Rename a few
1117 variables. Add navigation buttons where needed.
1118 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1119 variables and methods.
1120 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1121 navigation boolean and navigation table as required in the
1122 LayoutItemField DTO.
1123 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1124 variables for navigation along with getter/setter methods.
1126 2011-10-07 Ben Konrath <ben@bagu.org>
1128 Rename Field to DetailsCell.
1130 This is a refactor-only commit. No functionality has been added or
1133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1134 Update variable and method names.
1135 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1136 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1137 variable and method names.
1138 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1140 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1141 variable and method names.
1143 2011-10-07 Ben Konrath <ben@bagu.org>
1145 Create separate methods for layout and data the details view.
1147 This is a refactor-only commit. No functionality has been added or
1150 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1151 private methods: setData(), createLayout().
1153 2011-10-07 Ben Konrath <ben@bagu.org>
1155 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1157 This is part of a change to get navigation buttons in the details view
1158 but it should have been done this way from the start.
1160 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1161 for method name change in TableSelectionView.
1162 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1163 Create TableChangeEvent and set the browser title using the
1164 TableSelectionView API.
1165 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1166 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1167 Change getSelectedTable() to getSelectedTableName(). Add
1168 getSelectedTableTitle().
1170 2011-10-07 Ben Konrath <ben@bagu.org>
1172 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1174 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1176 2011-10-07 Ben Konrath <ben@bagu.org>
1178 Update TableChangeEvent to use newTableName naming convention.
1180 This makes the class more consistent with GWT naming conventions.
1182 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1183 Update for method name change in TableChangeEvent.
1184 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1185 for method name change in TableChangeEvent.
1186 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1187 newTableName variable and getter method. Make toDebugString()
1190 2011-09-30 Ben Konrath <ben@bagu.org>
1192 Disable the pager in the list tables when the data row count is less than the minimum.
1194 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1195 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1197 2011-09-30 Ben Konrath <ben@bagu.org>
1199 Add empty rows to the end of related list and list view tables.
1201 I also extracted the cell rendering classes from the ListTable because
1202 the code was becoming a little crazy with all the anonymous inner
1203 classes. My plan is to use these cell rendering classes in the details
1204 view as well so this refactor will be needed for that change.
1206 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1207 set the row count in related list tables if the data has more rows
1208 than the minimum number of rows visible.
1209 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1210 row count in list view tables if the data has more rows than the
1211 minimum number of rows visible.
1212 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1213 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1215 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1216 for rendering TYPE_NUMERIC cells. The code was extracted from the
1218 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1219 class for rendering cells with buttons in list views. The code was
1220 extracted from the ListTable class.
1221 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1222 for rendering TYPE_TEXT cells. The code was extracted from the
1224 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1225 Add empty rows to the end of the data if required. Implement
1226 ListTable.getMinNumVisibleRows().
1227 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1228 cell renderer code to public classes. Return null in
1229 Column.getValue() for empty rows. Add new abstract method:
1230 getMinNumVisibleRows(). Move code to set the row count of the list view
1231 table to ListViewImpl.
1232 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1233 empty rows to the end of the data if required. Implement
1234 ListTable.getMinNumVisibleRows().
1237 2011-09-27 Ben Konrath <ben@bagu.org>
1239 Use GWT.log for client-side debugging statements.
1241 These are optimized out when deployed so I should have used this method
1242 in the first place. These statements will eventually be replaced with some sort
1243 of notification in the browser.
1245 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1246 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1247 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1248 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1249 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1251 2011-09-27 Ben Konrath <ben@bagu.org>
1253 Put tableselector on the right, back to list link on right.
1255 The idea is that the table selector is acting like a label for the
1256 currently displayed table so it should be placed below the document title. This
1257 puts the table title in a similar position to where it is in Glom.
1259 * mockups/details-contacts.html:
1260 * mockups/details-projects.html:
1261 * mockups/listview-contacts.html:
1262 * mockups/listview-projects.html:
1263 * mockups/style.css:
1264 Update mockups to match how the interfaces currently look.
1265 * src/main/webapp/style.css: Swap positions of backlink with the table
1266 selector. Add some space on the left side of the table selector to
1267 line things up with the document title.
1269 2011-09-27 Ben Konrath <ben@bagu.org>
1271 Add field colouring to details view.
1273 This change re-works how field colouring works. The colour formatting
1274 information is now set to the client with the layout information instead of
1275 with the data. This eliminates the need to send the same colour strings for
1276 data in list view column when colour information is set.
1278 In order to set an alternate colour for negative numeric values, the
1279 number is now sent to client and formatted with the GWT NumberFormat class.
1281 This change also fixes:
1283 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1285 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1286 internationalization framework which is needed for client side numeric
1288 * src/main/java/org/glom/web/client/Utils.java: New file for some
1289 client static utility methods.
1290 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1291 the DataItem object to the Field class. Use a utility method to
1292 create the foreignKeyValue string.
1293 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1294 alignment and text colours in the constructor. Add setData(DataItem)
1295 method. Remove setText(String) method.
1296 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1297 colour information to GlomTextCell. Create and use GlomNumberCell for
1298 rendering numbers. Use utility method to get the string for the
1299 primary key of the key provider. Re-work how the horizontal alignment
1301 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1302 formatting to layout information. Methods for converting the libglom
1303 formatting information were moved from DBAccess.
1304 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1305 numeric formatting (it's now done on the client side). Don't set text
1306 colours in DataItem. Move libglom formatting conversion methods to
1308 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1309 getters/setters for text colour information.
1310 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1311 for transferring the libglom NumericFormat information to the client.
1312 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1313 and getters/setters for: GlomNumericFormat, background colour and
1314 foreground colour strings.
1316 2011-09-26 Ben Konrath <ben@bagu.org>
1318 Simplify code that iterates through the LayoutGroup.
1320 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1322 2011-09-26 Ben Konrath <ben@bagu.org>
1324 Accept Eclipse formatting for OnlineGlomServiceAsync.
1326 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1328 2011-09-26 Ben Konrath <ben@bagu.org>
1330 Don't use the ListDBAccess classes to get the primary key layout information.
1332 This was causing a bug where the wrong index for the hidden primary key
1333 was being sent to the client.
1335 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1336 primary key while creating the LayoutGroup DTO. Create a
1337 LayoutItemField DTO for hidden primary keys. Don't use the
1338 RelatedListDBAccess because it was only used for getting the primary
1340 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1341 access modifier from public to protected for getPrimaryKeyField() and
1342 getPrimaryKeyLayoutItemField().
1343 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1344 abstract method getExpectedResultSize() because RelatedListDBAccess
1345 doesn't have enough info to implement it.
1346 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1347 Remove @Override for getExpectedResultSize().
1348 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1349 Remove method getExpectedResultSize().
1351 2011-09-23 Ben Konrath <ben@bagu.org>
1353 Log which layout (list or details) the ignored item is from.
1355 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1357 2011-09-23 Ben Konrath <ben@bagu.org>
1359 Remove annotations that turn off code formatting in DataItem.
1361 * src/main/java/org/glom/web/shared/DataItem.java:
1363 2011-09-23 Ben Konrath <ben@bagu.org>
1365 Rename GlomField to DataItem and update associated methods.
1367 This is a rename-only refactor. No functionality has been added or
1370 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1371 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1372 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1373 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1374 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1375 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1376 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1377 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1379 * src/main/java/org/glom/web/server/database/DBAccess.java:
1380 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1381 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1382 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1383 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1384 * src/main/java/org/glom/web/shared/DataItem.java:
1385 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1386 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1388 2011-09-23 Ben Konrath <ben@bagu.org>
1390 Rename GlomDocument to DocumentInfo and update associated methods.
1392 This is a rename-only refactor. No functionality has been added or
1395 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1396 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1397 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1398 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1399 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1400 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1401 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1403 2011-09-20 Ben Konrath <ben@bagu.org>
1405 Require java-libglom 1.17.3.
1407 This picks up the fix for the seg fault problem with the Scenes table
1408 in the Openismus Film Manager example.
1412 2011-09-20 Ben Konrath <ben@bagu.org>
1414 Change the way sort clause is added for primary key when no sort clause is requested.
1416 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1417 before the sort clause is created. When a sort clause is not requested, the
1418 sort clause is created by finding the primary key in the LayoutFieldVector
1421 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1423 2011-09-20 Ben Konrath <ben@bagu.org>
1425 Log error message if no documents are found in the configured directory.
1427 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1428 Extract the glom file extension string to a private static final class
1429 variable (mostly as syntactic sugar). Accept a minor formatting change.
1430 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1431 the example glom.document.directory configuration property to make it
1432 more clear that it can any directory, not just the home directory.
1434 2011-09-18 Ben Konrath <ben@bagu.org>
1436 Add related lists to details view.
1438 The related list table has support for paging and sorting just like the
1439 table in the list view.
1441 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1442 SQL queries for the related list tables.
1443 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1444 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1446 Rename getList methods to getListView and add comments. Remove
1447 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1448 it being unused. Add methods: getDetailsLayoutAndData(),
1449 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1450 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1451 Create the layout and set the data for the fields in one async call
1452 instead of two. Create related lists where appropriate.
1453 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1454 for method name changes in OnlineGlomService.
1455 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1456 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1457 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1459 * src/main/java/org/glom/web/client/ui/ListView.java:
1460 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1461 tableName from setCellTable(). Create a ListViewTable instead of
1463 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1464 represent a data field in the details view.
1465 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1466 from addDetailsCell() to Field class. Keep track of the Fields and
1467 Portals in the details view.
1468 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1469 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1470 and add a method to get it. Add method to set the contents of the
1472 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1473 New class for related list tables. This class has the data provider
1474 for the related list table.
1475 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1476 abstract class which is the base class for the ListViewTable and the
1478 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1479 New class for list view tables. This class has the data provider for
1480 the list view table.
1481 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1482 methods for related list tables. Add more information to the
1483 LayoutItemField and LayoutItemPortal DTOs.
1484 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1485 Remove debugging print statement.
1486 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1487 Remove debugging print statements. Add primary key field to SQL count
1489 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1490 Remove unnecessary LayoutFieldVector parameter from
1491 getResultSizeOfSQLQuery() method.
1492 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1493 New class for related list table database access.
1494 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1495 class that is a wrapper DTO for details view layout and data.
1496 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1497 new 'fromField' string to this DTO.
1498 * src/main/webapp/style.css: Remove bottom margin and override top
1501 2011-09-15 Ben Konrath <ben@bagu.org>
1503 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1505 This sets things up to make it easier to add the data retrieval for
1506 related lists (portals). No user noticeable changes were made with
1509 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1510 class has the code to retrieve the layouts and access the
1511 database using the new database helper classes.
1512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1513 Most of the functionality has been removed from this class. This
1514 class now represents the public interface for the client side
1515 code. It also deals with configuring the servlet and cleaning
1516 things up when the servlet is stopped.
1517 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1518 of static methods into this utility class.
1519 * src/main/java/org/glom/web/server/database/DBAccess.java:
1520 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1521 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1522 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1523 These classes have the database retrieval code. The class hierarchy
1524 has been setup to make it easy to reuse code for similar
1527 2011-09-06 Ben Konrath <ben@bagu.org>
1529 Create separate classes for list table code and the data provider.
1531 As part of this refactor, I also split up the code a bit to make it
1534 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1535 table code to two new classes (below).
1536 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1537 with code from ListViewImpl.
1538 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1539 New file with code from ListViewImpl.
1541 2011-09-06 Ben Konrath <ben@bagu.org>
1543 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1545 This fixes the LayoutItemPortal DTO to match the libglom layout object
1548 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1550 2011-09-01 Ben Konrath <ben@bagu.org>
1552 Set title of Portals in the Details View.
1554 * pom.xml: Bump required version of java-libglom to 1.17.1.
1555 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1556 widget creation to its own class. Add comments to constructor.
1557 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1558 The code is mostly from the Group class with the title now set.
1559 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1560 title of Portal. Update some comments. Fix some code formatting.
1562 2011-09-01 Ben Konrath <ben@bagu.org>
1564 Remove TODO comment for the flow table column width.
1566 The flow table column width is working correctly and doesn't need to be
1567 changed. See this mailing list post for more info:
1569 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1571 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1573 2011-08-27 Ben Konrath <ben@bagu.org>
1575 Add document title (database name) to top of the browser page.
1577 I added the document title to the TableSelecitonView but that will
1578 change if / when we add a view that doesn't require table selection.
1580 * mockups/details-contacts.html:
1581 * mockups/details-projects.html:
1582 * mockups/listview-contacts.html:
1583 * mockups/listview-projects.html:
1584 * mockups/style.css: Add document title to mockups to keep things
1586 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1587 sizes to account for the document title.
1588 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1589 Set the document title when it has been retrieved from the server.
1590 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1591 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1592 and implement setDocumentTitle(String) method.
1593 * src/main/webapp/style.css: Add ID for document title style.
1595 2011-08-25 Ben Konrath <ben@bagu.org>
1597 Add NavigationType enum to LayoutItemPortal DTO.
1599 This is the start of adding support for Portals to the Details View.
1601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1602 LayoutItem_Portal.navigation_type enum from libglom to
1603 LayoutItemPortal.NavigationType enum.
1604 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1605 NavigationType enum, field for storing the NavigationType and getter
1608 2011-08-25 Ben Konrath <ben@bagu.org>
1610 Implement the flow table layout in the Details View.
1612 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1613 FlowTable to Group to account for the renamed class.
1614 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1615 File. This is a container widget that implements the Glom details view
1616 flow table behaviour.
1617 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1618 org/glom/web/client/ui/FlowTable.java.
1619 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1620 so that the size of the subgroups are a closer match to the size of
1621 the Glom subgroups. This makes the flowtable layout match the layout
1622 in Glom for the Music Collection example file.
1624 2011-08-16 Ben Konrath <ben@bagu.org>
1626 Create container element for LayoutItemPortal in Details View.
1628 This will help me develop the layout for the FlowTable.
1630 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1631 fieldPanel variable to detailsCell.
1633 2011-08-15 Ben Konrath <ben@bagu.org>
1635 Set the height of the data element in the Details View.
1637 I changed the InlineLabels (text in a span element) to Labels (text in
1638 a div element) so that I could set the height of the details-data
1639 elements instead of the details-cell parent elements. This allows the
1640 the details-data element to display the correct height if style is
1641 applied that shows the height.
1643 This change has the added benefit of allowing the order of the labels
1644 and data elements to be changed for right-to-left languages.
1646 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1647 InlineLabels to Labels.
1648 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1649 InlineLabels to Labels. Set the height of the data element.
1650 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1651 multiline text height in the Formatting DTO.
1652 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1653 for multiline height along with getter and setter methods.
1654 * src/main/webapp/style.css: Adjust style to account for the change
1655 from span elements to div elements in the details cell.
1657 2011-08-15 Ben Konrath <ben@bagu.org>
1659 Make the List View appearance match the mockups.
1661 It doesn't match exactly but it's much better than it was.
1663 * mockups/listview-contacts.html: Remove unused css classes.
1664 * mockups/listview-projects.html: Remove unused css classes.
1665 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1666 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1667 for mainPanel instead of VerticalPanel (table). Set style name on
1668 CellTable. Set style name on Details column. Right-align Details
1670 * src/main/webapp/style.css: Adjust properties to match the mockups.
1672 2011-08-12 Ben Konrath <ben@bagu.org>
1674 Add better support for subgroups in the details view.
1676 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1677 changed FlowTable constructor.
1678 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1679 support for subgroups and subgroup-titles.
1680 * src/main/webapp/style.css: Add CSS class for subgroups and
1683 2011-08-12 Ben Konrath <ben@bagu.org>
1685 Return the top level LayoutGroup title.
1687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1689 2011-08-11 Ben Konrath <ben@bagu.org>
1691 Make the TableSelector header match the mockup.
1693 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1694 the layout panel. Properly lineup the table selection header with
1695 the list and details view.
1696 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1697 margin around the details view.
1698 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1699 Rename listBox variable to tableSelector. Set id for the style sheet.
1700 Use a FlowPanel instead of a HorizontalPanel.
1701 * src/main/webapp/style.css: Add properties to make the TableSelector
1702 box match the mockups.
1704 2011-07-13 Ben Konrath <ben@bagu.org>
1706 Update install script for java-libglom version change.
1708 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1711 2011-07-13 Ben Konrath <ben@bagu.org>
1713 Add support sub-group in the details view.
1715 I also removed the code that special-cased the default details view
1718 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1720 I still have to make a proper flowtable.
1722 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1723 Don't special-case default details view layout.
1724 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1725 addLayoutField() as I'm going to use it.
1726 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1727 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1729 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1730 extracted from DetailsViewImpl.GroupPanel. Add support for
1732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1733 column count when getting the details layout.
1735 2011-07-12 Ben Konrath <ben@bagu.org>
1737 Set browser title with database and table titles.
1739 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1740 Set the browser title when the table changes and when the activity
1742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1743 title when retrieving document info (the GlomDocument object).
1744 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1745 with getter and setter methods. Remove unused convenience constructor.
1746 Use default code formatting.
1748 2011-07-12 Ben Konrath <ben@bagu.org>
1750 Ignore LayoutItemPortals in the details view.
1752 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1755 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1756 LayoutItemPortal layout objects.
1757 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1758 LayoutItemPortal objects when retrieving the details layout.
1759 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1760 file. This is an empty class and just used to get type information for
1763 2011-07-12 Ben Konrath <ben@bagu.org>
1765 Use java-libglom 1.17.0.
1769 2011-07-11 Ben Konrath <ben@bagu.org>
1771 Remove "Table:" label from table selector.
1773 This matches a recent change in the Glom UI.
1775 * mockups/details-contacts.html:
1776 * mockups/details-projects.html:
1777 * mockups/listview-contacts.html:
1778 * mockups/listview-projects.html: Remove the "Table:" label from the
1780 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1782 2011-07-11 Ben Konrath <ben@bagu.org>
1784 Add main groups to the details view.
1786 This makes things look a little nicer in the details view. The next step
1787 is to implement the flowtable.
1789 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1790 resources from the standard gwt css theme. Standard.css is now
1791 included in OnlineGlom.html so that the online glom css rules have
1792 precedence over the gwt theme.
1793 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1794 the whole LayoutGroup to the DetailsView instead of just the titles.
1795 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1796 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1797 details layout with a helper class (GroupPanel). I might extract this
1798 class when I make the full flowtable.
1799 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1800 string as default so I don't have to worry about NPEs when processing
1802 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1803 note beside OnlineGlom.gwt.xml above).
1804 * src/main/webapp/style.css: Add default font-size to body to override
1805 the font-size set by the standard theme. Don't use h2 tags for
1806 group-title. Create new details-cell class.
1808 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1810 ConfiguredDocument: Set the port number too.
1812 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1813 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1814 Glom document. Presumably this worked sometimes so far because there is a
1815 default port number.
1817 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1819 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1821 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1822 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1823 correct, though we should throw an exception too.
1825 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1827 Fix a addDocuemnt typo.
1829 * src/main/java/org/glom/web/shared/Documents.java
1830 (Documents.addDocuemnt): Rename to addDocument().
1831 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1832 (OnlineGlomServiceImpl.getDocuments): Adapt.
1834 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1836 Slightly improved log output when connection fails.
1838 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1839 (ConfiguredDocument.setUsernameAndPassword):
1840 We don't know for sure if it' the username/password that's wrong, so
1841 rephrase the message.
1842 Also ouput the exception message, though it's generic in this case.
1844 2011-07-08 Ben Konrath <ben@bagu.org>
1848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1849 added braces to a one line if statement because the Eclipse formatter
1850 was getting confused.
1852 2011-07-07 Ben Konrath <ben@bagu.org>
1854 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1856 These should really be two separate tasks but I counldn't get things to
1857 work with GWT 2.2.0 and Eclipse 3.7.
1861 * .settings/org.eclipse.jdt.core.prefs:
1862 * .settings/org.eclipse.jdt.ui.prefs:
1863 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1864 * .settings/org.eclipse.m2e.core.prefs:
1865 Add new config files. Update current files. Remove references to the
1866 webtools plugins as we're not using any of the webtools features.
1867 * .gitignore: Add logs directory which is created when running with
1869 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1870 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1871 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1873 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1875 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1877 onlineglom.properties: Add explanatory comments.
1879 * src/main/resources/onlineglom.properties: Also change the default user
1880 from ben to someuser, to avoid the risk of people thinking we just
1881 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1883 2011-06-28 Ben Konrath <ben@bagu.org>
1885 Use filename in Log for incorrect passwords.
1887 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1888 getFileName(String) method to get the filename from the URI.
1890 2011-06-28 Ben Konrath <ben@bagu.org>
1892 Add the table name to the URL token for the ListPlace.
1894 This makes things consistent between the DetailsPlace and the
1895 ListPlace. It also allows the the ListPlace to be bookmarked.
1897 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1898 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1900 Remove getDefaultListLayout(). The default layout is now returned
1901 by the getListLayout() method when the table name is an empty string.
1902 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1903 Add table name field. Change to a new ListPlace when the table
1904 has been changed. Use getListLayout() for getting the default
1906 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1907 Add table name field. Set the correct table name in the list box
1908 when loading from bookmark. This corrects a problem for the
1910 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1911 Move table name to super-class (HasSelectableTable). Move document
1912 and table URL keys to super-class in HasSelectableTable.
1913 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1914 Add table name field. Add Tokenizer class with URL key common to
1915 the subclasses (DetailsPlace and ListPlace).
1916 * src/main/java/org/glom/web/client/place/ListPlace.java:
1917 Add table name. Add code to parse the URL token.
1918 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1919 Update ListPlace construction with empty table name string.
1920 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1921 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1922 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1923 Update ListPlace construction with table name string.
1924 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1925 Change defaultTableName field to tableName to reflect how it's now
1926 used. Update the getter and setter methods.
1928 2011-06-28 Ben Konrath <ben@bagu.org>
1930 Enable the table selector in the DetailsView.
1932 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1933 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1934 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1935 Remove getDefaultDetailsLayout(). The default layout is now returned
1936 by the getDetailsLayout() method when the table name is an empty
1938 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1939 event handler for table change event. Change to using
1940 getDetailsLayout() for the default details layout.
1941 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1943 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1944 when navigating to the details place.
1946 2011-06-27 Ben Konrath <ben@bagu.org>
1948 Use filename based unique document ID in URL and for RPC.
1950 The document ID is the glom document name with spaces (' ') replaced
1951 with pluses ('+') and without the .glom extension.
1953 This change is mostly a string substitution of 'documentTitle' for
1954 'documentID'. The only code change is the addition of a Documents DTO to get the
1955 filename to document title mappings as indicated below.
1957 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1958 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1959 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1960 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1961 Use Documents DTO to create the document links in the document
1963 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1964 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1965 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1966 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1967 * src/main/java/org/glom/web/client/place/ListPlace.java:
1968 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1969 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1970 * src/main/java/org/glom/web/client/ui/ListView.java:
1971 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1972 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1973 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1974 * src/main/java/org/glom/web/server/Log.java:
1975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
1976 getDocumentTitles() to getDocuments() and return the Documents DTO.
1977 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
1978 transferring the filename to document title mappings.
1980 2011-06-25 Ben Konrath <ben@bagu.org>
1982 Make the authentication popup work again.
1984 This bug was introduced when I extracted ConfiguredDocument to its own class.
1986 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
1987 correct success / fail status in setUsernameAndPassword().
1989 2011-06-25 Ben Konrath <ben@bagu.org>
1991 Use filename as unique key for configuring database usernames and passwords.
1993 This replaces the use of the Glom document title which could change
1994 depending on the locale. Thanks to Murray Cumming for pointing out this
1997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1998 * src/main/resources/onlineglom.properties:
2000 2011-06-24 Ben Konrath <ben@bagu.org>
2002 Pass primary key value to DetailsView.
2004 This enables the DetailsView to load the correct data.
2006 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2007 primary key value field and set in constructor. Pass primary key
2008 value to getDetailsData().
2009 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2010 variables for document title and primary key value.
2011 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2012 key value to the DetailsPlace.
2014 2011-06-24 Ben Konrath <ben@bagu.org>
2016 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2018 This allows the primary key to be retrieved by the Details button. This
2019 functionality has not been implemented yet but it's in the works.
2021 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2022 the LayoutGroup result to ListView.setCellTable instead of all of its
2023 fields individually.
2024 * src/main/java/org/glom/web/client/ui/ListView.java:
2025 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2026 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2027 get the primary key for the table.
2028 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2029 index of the primary key in the LayoutGroup accounting for hidden
2030 primary keys. Rename getJavaNumberFormat() to
2031 convertToJavaNumberFormat() for consistency. Cleanup / add some
2033 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2034 field for primary key index and a field to indicate whether the
2035 primary key is hidden or not.
2037 2011-06-23 Ben Konrath <ben@bagu.org>
2039 Rename getTableData methods to getListData.
2041 This is a rename refactor for consistency with other methods.
2043 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2044 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2045 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2046 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2048 2011-06-23 Ben Konrath <ben@bagu.org>
2050 Extract the ConfiguredDocument innerclass into its own class.
2052 This makes the servlet code more object oriented.
2054 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2055 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2057 new ConfiguredDocument class.
2059 2011-06-21 Ben Konrath <ben@bagu.org>
2061 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2063 This makes things more inline with how libglom works and reduces code
2064 duplication. This refactor lays the groundwork for adding the primary key to
2065 the LayoutGroup object.
2067 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2068 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2070 Change method names to getListLayout and getDefaultListLayout for
2071 consistency. Use LayoutGroup as the DTO for the list layout instead of
2072 ColumnInfo and LayoutListTable.
2073 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2074 new method names along with the LayoutGroup object for transferring the
2076 * src/main/java/org/glom/web/client/ui/ListView.java:
2077 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2078 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2079 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2081 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2082 Replaced with LayoutGroup.
2083 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2084 expectedResultSize and defaultTableName fields which are needed for
2086 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2087 type field which is needed for the list layout but will also be
2088 useful for the details layout as things progress.
2089 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2090 Make class abstract. Remove the unnecessary
2091 getFormattingHorizontalAlignment method. Add setFormatting method.
2093 2011-06-16 Ben Konrath <ben@bagu.org>
2095 Add scripts for building and installing war.
2097 These will help when updating OnlineGlom but they're also good
2098 supplemental documentation of the build and deployment proceeding.
2100 * utils/build-onlineglom-war.sh: New file.
2101 * utils/install-onlineglom-war.sh: New file.
2103 2011-06-16 Ben Konrath <ben@bagu.org>
2105 Create wrapper class to create consistent log messages.
2107 I wrapped methods in the Log class of gwt-log to add the method names
2108 from the servlet and create consistent formatting of the document title
2109 and table names in the log messages.
2111 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2113 log methods to use methods from wrapped Log class.
2115 2011-06-16 Ben Konrath <ben@bagu.org>
2117 Remove superfluous conditional return.
2119 Thanks to Murray Cumming for pointing this out!
2121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2123 2011-06-15 Ben Konrath <ben@bagu.org>
2125 Return an ArrayList of LayoutGroups for the Details layout.
2127 This corrects a problem with the details layout as it can have more
2128 than one top level LayoutGroup.
2130 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2131 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2132 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2133 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2135 with ArrayList of LayoutGroups for the details view layout.
2136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2137 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2138 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2139 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2140 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2141 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2143 2011-06-14 Ben Konrath <ben@bagu.org>
2145 Use cast_dynamic method to determine the libglom LayoutItem type.
2147 This is better than finding the LayoutItem type by using the string
2148 returned from the get_part_type_name() method.
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2152 2011-06-14 Ben Konrath <ben@bagu.org>
2154 Add method names to log entries in the servlet.
2156 This helps when tracking down deployment problems.
2158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2160 2011-06-14 Ben Konrath <ben@bagu.org>
2162 Add data to the DetailsView using a hard-coded primary key value.
2164 The layout and functionality of the DetailsView is not complete. This
2165 is just a checkpoint so the patch doesn't get too big.
2167 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2168 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2169 Add getDetailsData() servlet method.
2170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2171 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2172 LayoutFields are added to the DetailsView.
2173 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2174 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2175 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2176 take the string for the title instead of the object.
2177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2178 Add implementation getDetailsData() along with some private helper
2180 * src/main/webapp/style.css: Add padding to details-data class. Add a
2181 details-label class with the same padding as the details-data class.
2183 2011-06-03 Ben Konrath <ben@bagu.org>
2185 Use presenter.goTo() to change to the DetailsPlace.
2187 This will make things easier when we need to open the DetailsView with
2188 data specific to the row that was clicked.
2190 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2192 2011-06-02 Ben Konrath <ben@bagu.org>
2194 Add CSS file from mockups.
2196 I'm adding this now because it's going to be useful to have when
2197 developing the DetailsView. The TableSelectionView and ListView aren't
2200 * src/main/webapp/OnlineGlom.html:
2201 * src/main/webapp/style.css:
2203 2011-06-02 Ben Konrath <ben@bagu.org>
2205 Use String.isEmpty() to check for empty string.
2207 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2209 2011-06-02 Ben Konrath <ben@bagu.org>
2211 Display main layout group titles in the DetailsView.
2213 This is the start of the DetailsActivity/DetailsView implementation.
2215 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2216 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2217 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2218 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2219 Get the layout information for the details view from the server and set
2220 the main layout group titles.
2221 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2222 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2223 Add addLayoutGroup() and addLayoutField() methods. This are just
2224 temporary methods for creating the the details view that will change
2226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2227 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2229 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2230 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2231 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2232 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2233 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2234 Data Transfer Objects that mimic the libglom object structure. These are
2235 used for transferring the details layout but could also be used for
2236 transferring the list layout.
2238 2011-05-27 Ben Konrath <ben@bagu.org>
2240 Reset the AuthenticationPopup when clearing the ListView.
2242 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2244 2011-05-27 Ben Konrath <ben@bagu.org>
2246 Fix problem with onlineglom.properties file loading.
2248 The old way worked in Eclipse but not on the server. Loading the
2249 onlineglom.properties file now works in Eclipse and on the server.
2251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2253 2011-05-24 Ben Konrath <ben@bagu.org>
2255 Update gwt-log from 3.1.0 to 3.1.2.
2257 Gwt-log 3.1.0 has been marked as depreciated.
2261 2011-05-24 Ben Konrath <ben@bagu.org>
2263 Add comment to ListActivity.goTo() method.
2265 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2267 2011-05-24 Ben Konrath <ben@bagu.org>
2269 Remove FIXME in convertGdkColorToHtmlColour()
2271 The Gdk::Color value returned by libglom is 16-bits per channel on both
2272 64 and 32-bit platforms.
2274 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2276 2011-05-19 Ben Konrath <ben@bagu.org>
2278 Improve performance of initial ListView load.
2280 I removed a round trip to the server for getting the default table name
2281 and then requesting information about that table. This also removes a potential
2282 problem with the table change handler not being setup in time to receive the
2283 table change event from the ListActivity.
2285 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2286 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2287 getDefaultLayoutListTable() method. Improve comments.
2288 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2289 getDefaultLayoutListTable() method instead of firing a table change
2290 event to get the table to load.
2291 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2292 implementation of getDefaultLayoutListTable() method.
2293 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2296 2011-05-19 Ben Konrath <ben@bagu.org>
2298 Override toDebugString() in TableChangeEvent.
2300 This is useful to have for debugging.
2302 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2304 2011-05-19 Ben Konrath <ben@bagu.org>
2306 Add a "Back to List" link when at the DetailsPlace.
2308 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2309 Populate the CellTable based on the selected table of the ListBox if
2310 it's set otherwise use the default table. This allows the "Back to
2312 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2313 Remove Place from constructors. Add a setPlace() method. Add
2314 goToPlace() method. Set class as presenter for TableSelectionView.
2315 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2316 Use the same TableSelectionActivity when switching between the List and
2318 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2319 Subclass the new HasSelectableTablePlace. This removes some duplicate
2321 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2322 New class to represent Places that display the TableSelectionView.
2323 * src/main/java/org/glom/web/client/place/ListPlace.java:
2324 Subclass the new HasSelectableTablePlace. This removes some duplicate
2326 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2327 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2328 Add Presenter interface. Add setBackLinkVisible() method. Add
2329 setBackLink() method.
2331 2011-05-18 Ben Konrath <ben@bagu.org>
2333 Enable the "Details" buttons.
2335 Right now only an empty details view is displayed.
2337 * src/main/java/org/glom/web/client/ClientFactory.java:
2338 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2339 Add DetailsView to ClientFactory.
2340 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2341 A basic activity for the details view.
2342 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2343 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2345 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2346 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2348 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2349 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2350 unnecessary super() in constructor.
2351 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2352 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2353 really shouldn't create a new TableSelectionActivity for both the ListPlace
2354 and the DetailsPlace so this should be considered a temporary solution.
2355 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2356 New file. Represents a URL for the details view.
2357 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2358 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2359 A basic details view interface and implementation.
2360 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2361 Enable the "Details" buttons.
2363 2011-05-12 Ben Konrath <ben@bagu.org>
2365 Use a LayoutPanel with multiple display areas for main layout.
2367 This is mostly a refactor in that there are no changes from the user
2368 point of view. These changes are required so that we can swap out the list view
2369 with the details view when the user clicks the "Details" button.
2371 * src/main/java/org/glom/web/client/ClientFactory.java:
2372 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2373 OnlineGlomView. Add TableSelectionView, ListView and
2374 AuthenticationPopup.
2375 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2376 for main layout. Add display regions for main activities. Add
2377 activity manager for for main activities.
2378 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2379 file from parts of the deleted OnlineGlomActivity.
2380 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2381 New file from parts of the deleted OnlineGlomActivity.
2382 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2383 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2384 New files for app wide table change event.
2385 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2386 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2387 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2388 Activity mappers for the main activities replace the deleted app-wide
2390 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2391 Fix a spelling error in he comment.
2392 * src/main/java/org/glom/web/client/ui/ListView.java:
2393 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2394 Renamed from LayoutListView and modified for MVP. This still not a
2395 proper dumb view as prescribed by the MVP pattern but it works for now.
2396 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2397 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2398 New widget stripped out of the deleted OnlineGlomView.
2399 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2400 Remove hack that is fixed by this patch.
2402 2011-05-06 Ben Konrath <ben@bagu.org>
2404 Rename OnlineGlomPlace to ListPlace.
2406 The only change besides the rename is that url will now display #list
2407 instead of #Document.
2409 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2410 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2411 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2412 * src/main/java/org/glom/web/client/place/ListPlace.java:
2413 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2415 2011-05-06 Ben Konrath <ben@bagu.org>
2417 Use Presenter for app navigation.
2419 This is the proper way to deal with Place (URL) changes with the MVP
2422 * src/main/java/org/glom/web/client/ClientFactory.java:
2423 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2424 PlaceHistoryMapper and PlaceHistoryHandler.
2425 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2426 PlaceHistoryMapper and PlaceHistoryHandler.
2427 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2428 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2429 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2430 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2431 Add Presenter interface and setPresenter methods. Rename addHyperLink
2432 to addDocumentLink taking only the document title as a parameter.
2434 2011-04-14 Ben Konrath <ben@bagu.org>
2436 Prompt for db username/password if they haven't been set.
2438 This is implemented with a popup widget that is contained within the
2439 OnlineGlomView and managed by the OnlineGlomActivity.
2441 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2442 methods for checking and setting the database username and password.
2443 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2444 new methods for checking and setting the database username and
2446 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2447 Display authentication popup if the JDBC connection to the database
2448 has not been authenticated.
2449 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2451 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2452 for dealing with the authentication popup.
2453 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2454 Implement the methods for dealing with the authentication popup.
2455 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2456 try to executed queries if the database connection hasn't been
2457 authenticated. Implement methods for checking and setting the
2458 database username and password.
2460 2011-04-12 Ben Konrath <ben@bagu.org>
2462 Make log messages a little clearer.
2464 Add a dash betweeen the document title and the table name.
2466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2468 2011-04-12 Ben Konrath <ben@bagu.org>
2470 Protect against NPEs when cleaning up database resources.
2472 While this isn't strictly necessary because the exception is caught,
2473 not protecting against the NPEs makes it harder to find the real error
2476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2478 2011-04-12 Ben Konrath <ben@bagu.org>
2480 Move configuration of the servlet to the constructor.
2482 The servlet will be initialized even if the database authentication
2483 information is not set or correct. I still need to add the UI for prompting
2484 the user for the authentication information when it's required.
2486 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2487 javadocs for getDocumentTitles() method.
2488 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2489 Set error message when RPC fails.
2490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2491 glom files directory from the configuration file. Try to set the
2492 database authentication information for the specific document if it's
2493 set and works otherwise try to use the global authentication
2494 information set for the directory.
2495 * src/main/resources/onlineglom.properties: Moved from
2496 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2497 Added detailed comments for the new keys.
2499 2011-04-11 Ben Konrath <ben@bagu.org>
2501 Remove unnecessary @Override in DocumentSelectionViewImpl.
2503 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2505 2011-04-11 Ben Konrath <ben@bagu.org>
2507 Remove center alignment in DocumentSelectionView.
2509 The title element is still centred but the document titles and bottom
2510 sentence are both left-aligned.
2512 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2514 2011-04-11 Ben Konrath <ben@bagu.org>
2516 Change 'Demo' naming convention to 'Document'.
2518 This is just a rename refactor with no functional changes to the code.
2520 * src/main/java/org/glom/web/client/ClientFactory.java:
2521 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2522 * src/main/java/org/glom/web/client/OnlineGlom.java:
2523 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2524 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2525 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2526 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2527 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2528 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2529 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2530 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2531 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2532 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2534 2011-04-08 Ben Konrath <ben@bagu.org>
2536 Remove FIXME from safeLongToInt() method.
2538 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2543 2011-04-08 Ben Konrath <ben@bagu.org>
2545 Display an error if no glom documents are found in the specified directory.
2547 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2548 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2549 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2552 2011-04-08 Ben Konrath <ben@bagu.org>
2554 Add copyright header to one more file ... oops.
2556 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2558 2011-04-08 Ben Konrath <ben@bagu.org>
2560 Add copyright header to files without it.
2562 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2563 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2564 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2565 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2566 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2567 * src/main/java/org/glom/web/shared/GlomField.java:
2569 2011-04-08 Ben Konrath <ben@bagu.org>
2571 Add support for accessing multiple glom documents in the servlet.
2573 This completes the demo selection functionality.
2575 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2576 document title to methods.
2577 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2578 document title to methods.
2579 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2580 Set browser window title when the activity starts. Correct name of
2581 document title variable.
2582 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2583 Set browser window title when the activity starts. Set the table
2584 selector change handler after table selector has been set. Clear the
2585 OnlineGlomView when the activity has been stopped.
2586 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2587 document title as the place token. Use "#Document:" instead of
2588 "#OnlineGlomPlace:" in the URL.
2589 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2590 Change heading to "Online Glom"
2591 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2592 document title in RPC methods.
2593 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2594 setDocumentTitle() method. Add clear() method.
2595 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2596 setDocumentTitle() method. Implement clear() method which removes the
2597 change handler on the ListBox, clears the ListBox and clears the
2599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2600 Implement methods with document title. Keep track for the configured
2601 glom documents and their corresponding JDBC configurations in a hash
2602 table. This information is retrieved using the document title as the
2603 key in the hash table.
2604 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2605 document title field as it's no longer needed.
2607 2011-04-08 Ben Konrath <ben@bagu.org>
2609 Update the Eclipse JDT configuration.
2611 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2612 methods. Automatically add the copyright header to new files.
2614 2011-04-05 Ben Konrath <ben@bagu.org>
2616 Add new page for demo selection.
2618 This patch adds all the components required to view and start an
2619 OnlineGlom demo by clicking on the desired hyperlink. The user is
2620 able to return to the demo selection page with the browser's back
2621 button. I still need to modify the servlet to work with multiple
2622 documents so all demo links will load the file defined in the
2623 OnlineGlom.properties.
2625 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2626 This is only useful during development so we don't need to save it.
2627 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2628 get a reference to the DemoSelectionView.
2629 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2630 method to get a reference to the DemoSelectionView.
2631 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2632 default view to DemoSelectionView.
2633 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2634 to get glom document titles for glom files in a hard-coded directory.
2635 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2636 method to get glom document titles for glom files in a hard-coded
2638 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2639 Presenter for DemoSelectionView.
2640 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2641 for DemoSelectionView.
2642 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2643 Update for DemoSelectionView.
2644 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2645 Basic 'Place' implementation for the DemoSelectionView.
2646 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2647 The interface for the DemoSelectionView.
2648 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2649 The implementation of the DemoSelectionView.
2650 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2651 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2652 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2653 implementation of method to get glom document titles for glom files
2654 in a hard-coded directory.
2655 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2656 on longer being used.
2657 * src/main/webapp/glom.png: Glom logo.
2659 2011-04-05 Ben Konrath <ben@bagu.org>
2661 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2663 This is the forth and final commit of a refactor that will allow
2664 OnlineGlom to be used with multiple documents.
2666 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2667 Move RPC code from OnlineGlomViewImpl to this class.
2668 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2670 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2671 RPC code to the presenter class (the P in MVP).
2673 2011-04-04 Ben Konrath <ben@bagu.org>
2675 Start moving the existing OnlineGlom code to MVP.
2677 This work is based on the GWT MVP framework that is documented here:
2679 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2681 This is the third commit of a refactor that will allow OnlineGlom to
2682 be used with multiple documents.
2684 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2685 Interface for client factory which is used to get instances of various
2686 classes throughout the app.
2687 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2688 Implementation of client factory.
2689 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2690 initialize the MVP framework.
2691 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2692 New file. Activity manager for the main container widget. This is the
2694 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2695 Maps place (URL) to its corresponding activity.
2696 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2697 New file. This is just a place holder for a generated file.
2698 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2699 New file. Represents the URL for the main Online Glom app.
2700 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2701 for changes in LayoutListViewImpl.
2702 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2703 interface for View. Move code to OnlineGlomViewImpl class.
2704 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2705 file. Implementation of OnlineGlomView.
2706 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2707 Place resources. Use ClientFactoryImpl by default.
2709 2011-04-04 Ben Konrath <ben@bagu.org>
2711 Move View classes to their own package.
2713 This is the second commit of a refactor that will allow OnlineGlom to
2714 be used with multiple documents.
2716 * src/main/java/org/glom/web/client/OnlineGlom.java:
2717 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2718 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2720 2011-04-02 Ben Konrath <ben@bagu.org>
2722 Move UI code from the main module to its own class.
2724 This is the first commit of a refactor that will allow OnlineGlom to be
2725 used with multiple documents.
2727 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2728 references to OnlineGlom to OnlineGlomView.
2729 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2730 OnlineGlomView and instantiate it here.
2731 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2732 represents the main OnlineGlomView with one document.
2734 2011-04-01 Ben Konrath <ben@bagu.org>
2736 Fix formatting of gwt.xml and add DTD.
2738 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2740 2011-03-30 Ben Konrath <ben@bagu.org>
2742 Propperly convert gdkColor string to html colour string.
2744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2746 2011-03-28 Ben Konrath <ben@bagu.org>
2748 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2750 This implementation matches
2751 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2752 readable and is not tied to Swig.
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2756 2011-03-28 Ben Konrath <ben@bagu.org>
2758 Use read-only checkboxes for boolean field types.
2760 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2761 in the CellTable based on the field type. It currently only
2762 distinguishes between boolean and text columns but I'll need to add
2763 support for more types.
2764 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2765 column type in the ColumnInfo object. Add method to convert between the
2766 glom field type enum in ColumnInfo and the glom field type in libglom.
2767 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2769 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2770 getting and setting booleans.
2772 2011-03-25 Ben Konrath <ben@bagu.org>
2774 Don't get the Date twice from the ResultSet.
2776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2778 2011-03-25 Ben Konrath <ben@bagu.org>
2780 Cleanup code in the servlet.
2782 * TODO: Remove item about row count. Add item about testing row count
2783 query with large number of rows.
2784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2785 spelling mistakes, change method parameter to be consistent with
2788 2011-03-25 Ben Konrath <ben@bagu.org>
2790 Add server side logging with the gwt-log library.
2792 * .gitignore: Ignore the log file we're now producing.
2793 * TODO: Add a couple TODO item for logging.
2794 * pom.xml: Add gwt-log and log4j as a dependency.
2795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2796 logging of errors, warnings and some important info.
2797 * src/main/resources/log4j.properties: New file to configure log4j.
2799 2011-03-24 Ben Konrath <ben@bagu.org>
2801 Add a disable button for the Details view.
2803 * src/main/java/org/glom/web/client/LayoutListView.java:
2805 2011-03-22 Ben Konrath <ben@bagu.org>
2807 Use a count query to get the number of rows for the list view pager.
2809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2811 2011-03-22 Ben Konrath <ben@bagu.org>
2813 Add more TODO information about CellTable pager positioning.
2817 2011-03-19 Ben Konrath <ben@bagu.org>
2819 Add TODO item about CellTable pager positioning.
2823 2011-03-18 Ben Konrath <ben@bagu.org>
2825 Remove unneeded GlomFieldColumn class.
2827 This is just a small code cleanup.
2829 * src/main/java/org/glom/web/client/LayoutListView.java:
2831 2011-03-18 Ben Konrath <ben@bagu.org>
2833 Use cursor mode in the query that gets data for the list view.
2835 I still need to fix the potential memory problem when getting the row
2836 count for the list view.
2838 * TODO: Add note about testing memory usage with large data sets. Add
2839 item about fixing row counting with large data sets.
2840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2841 PostgreSQL JDBC driver into cursor mode when getting data for the
2844 2011-03-15 Ben Konrath <ben@bagu.org>
2846 Remove the GWT Container from the Eclipse build classpath.
2848 The GWT dependencies are set by Maven so this isn't needed.
2852 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2854 Added some earlier mockups to git, but not to the tarball dist.
2856 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2857 Openismus. These hopefully show how we might structure the HTML so that
2858 it can be styled easily with CSS. However, we probably need to adapt them
2859 for the CSS structure that GWT dictates for common widgets.
2861 2011-03-14 Ben Konrath <ben@bagu.org>
2863 Locate OnlineGlom.properties using the ServletContext.
2865 This is required to be able to locate the file in the deployed servlet.
2867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2868 Configure the database and glom document in in a helper method so
2869 that the ServletContext can be used to locate OnlineGlom.properties.
2870 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2871 src/main/webapp. This is the proper location for .properites files.
2873 2011-03-12 Ben Konrath <ben@bagu.org>
2875 Add note to README about why we're compiling down to obfuscated JavaScript.
2879 2011-03-11 Ben Konrath <ben@bagu.org>
2881 Use properties file to configure servlet.
2883 This allows people to change the glom file path, db username and db
2884 password without recompiling the code.
2886 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2887 * src/main/webapp/OnlineGlom.properties:
2889 2011-03-11 Ben Konrath <ben@bagu.org>
2891 Use table fields in layout list view if the layout list is not defined.
2893 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2894 Manually create a LayoutFieldVector for the query builder using the
2895 table fields when a layout list is not defined in the glom file.
2897 2011-03-11 Ben Konrath <ben@bagu.org>
2899 Only show FIXME string for images when there's an image.
2901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2902 in this change are some small code cleanups.
2904 2011-03-11 Ben Konrath <ben@bagu.org>
2906 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2908 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2910 2011-03-11 Ben Konrath <ben@bagu.org>
2912 Correctly set the index of the default table.
2914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2915 Correctly set the index of the default table. Add commented out example
2918 2011-03-10 Ben Konrath <ben@bagu.org>
2920 Add comment to pom.xml about the previous change.
2922 * pom.xml: Add comment about the deployment issue so that it's obvious
2923 why java-libglom is set to the provided scope.
2925 2011-03-10 Ben Konrath <ben@bagu.org>
2927 Change java-libglom dependency from compile to provided in pom.xml.
2929 Since java-libglom uses jni it can only be loaded once and therefore
2930 must be placed in $CATALINA_HOME/lib and not included in each war.
2931 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2932 More information about this issue can be found in the Tomcat 6 release
2933 notes in the "JNI Based Applications" section:
2935 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2937 * README: Remove note about this issue. Deployment info should really
2938 be on the wiki anyway so I'll add it right now.
2939 * pom.xml: Change java-libglom dependency from compile to provided so
2940 that it's copied in to the packaged war.
2942 2011-03-09 Ben Konrath <ben@bagu.org>
2944 Change to using a neutral locale for currency, date and time formatting.
2946 This solves the problem of currency values being represented without a
2947 space between the currency code and the number (e.g. "EUR5.89" is now
2948 represented as "EUR 5.89"). More work is required when we implement
2949 a locale preference setting.
2951 * TODO: Add note about currency formatting issues with different
2953 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2954 to using the neutral ROOT locale.
2956 2011-03-09 Ben Konrath <ben@bagu.org>
2958 Add support for currency codes that are not ISO 4217 codes.
2960 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2961 the currency code defined in the glom file when it's not 3 characters
2962 long or when Java doesn't recognize the string as an ISO 4217 code.
2964 2011-03-08 Ben Konrath <ben@bagu.org>
2966 Remove test classes, launch configurations and configuration.
2968 The test stuff was getting in the way when creating the war. To make
2969 the war file you can now do 'mvn clean package'. The packaged war file
2970 will be in the target directory.
2972 * .classpath: Remove unused classpathentry for tests and i18n.
2973 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
2974 property. Don't run test or i18n goals when packaging the war.
2975 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
2980 * OnlineGlomTest-dev.launch:
2981 * OnlineGlomTest-prod.launch:
2982 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2983 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
2985 2011-03-07 Ben Konrath <ben@bagu.org>
2987 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
2989 These fixes allow me to use 'mvn deploy' to create the war file.
2991 * .classpath: This generated config has been updated by Eclipse. This
2992 change was probably triggered by me updating from Eclipse 3.6.1 to
2994 * .gitignore: Add entry to ignore the directory
2995 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
2996 * .project: The generated config has been updated by Eclipse. This
2997 change was probably triggered by me updating from Eclipse 3.6.1 to
2999 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3000 so that Eclipse doesn't complain
3001 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3002 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3003 'tests' directory to 'client' directory. This is the new
3004 gwt-maven-plugin convension.
3005 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3006 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3008 2011-03-07 Ben Konrath <ben@bagu.org>
3010 Add support for horizontal alignment in the LayoutList columns.
3012 * TODO: Remove item about horizontal alignment. Add item about
3013 improvements to ColumnInfo.
3014 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3015 alignment on the columns. Use ColumnInfo RPC object get the column
3016 title and horizontal alignment.
3017 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3018 LayoutListView creation with ColumnInfo RPC object.
3019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3020 a ColumnInfo object for every LayoutList columnn. Convert the
3021 FieldFormatting.HorizontalAlignment to the correct
3022 ColumnnInfo.HorizontatlAlignment with the new
3023 getColumnInfoHorizontalAlignment helper method.
3024 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3025 to encapsulate column information like alignment and title. This
3026 could be used to set the colour instead of on a per cell field basis.
3027 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3028 column title storage and retrieval with ColumnInfo.
3030 2011-03-04 Ben Konrath <ben@bagu.org>
3032 Add support for column sorting.
3034 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3035 AsynDataProvider to be an anonymous inner class. Use new
3036 getSortedTableData RPC method when column sort is requested. Set all
3037 columns sortable and add an AsyncHandler to activate sorting in the
3039 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3040 method getSortedTableData(). Cleanup other method signatures.
3041 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3042 new method getSortedTableData(). Cleanup other method signatures.
3043 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3044 Implement getSortedTableData() and getTableData() methods by using a
3045 private helper method with the appropriate parameters filled in. Use
3046 user supplied sort clause when supplied, otherwise fall back to
3047 sorting by the primary key. Move destroy() method to be underneath
3048 constructor for readability. Cleanup comments.
3050 2011-03-03 Ben Konrath <ben@bagu.org>
3052 Add support for colour text and colour backgrounds to the layout list cells.
3054 Only the cell backgrounds are coloured which leaves a gap between the
3055 cells that isn't coloured. I need to figure out a way to set
3056 'style=background-colour:' on the whole column rather than just the
3059 * TODO: Add a note about colouring the background of the whole column.
3060 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3061 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3062 render the coloured text and backgrounds. Use GlomField[] for the row type.
3063 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3066 GlomField[] for the row type.
3067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3068 GlomField[] for the row type. Set the text, text colour and background
3069 colour in the GlomField objects as specified in the glom document. Add
3070 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3071 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3072 the glom field text, foreground colour and background colour.
3074 2011-03-02 Ben Konrath <ben@bagu.org>
3076 Don't display hidden tables in the combo box.
3078 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3080 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3081 code to ignore hidden tables using ArrayLists for the table names and
3083 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3084 tableNames to use ArrayLists instead of String[]. Update getter and setter
3087 2011-03-01 Ben Konrath <ben@bagu.org>
3089 Add support for Date and Time number types.
3091 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3092 Implement formatting for Date and Time values. Change the default glom
3093 file to small business example.
3095 2011-03-01 Ben Konrath <ben@bagu.org>
3097 Add support for formatting glom types as specified in the glom file.
3099 Formatting isn't finished yet - I still need to add support for Date
3102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3103 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3104 checks for null values in JDBC cleanup code and catch all exceptions
3105 instead of just SQLExceptions.
3106 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3109 2011-03-01 Ben Konrath <ben@bagu.org>
3111 Use GWT 2.2.0 instead of 2.1.1.
3113 * pom.xml: Change GWT version numbers.
3115 2011-03-01 Ben Konrath <ben@bagu.org>
3117 A few small code cleanups.
3119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3121 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3122 unnecessary object creation in constructor.
3123 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3124 unnecessary object creation in constructor.
3126 2011-02-28 Ben Konrath <ben@bagu.org>
3128 Add file for TODO list.
3132 2011-02-18 Ben Konrath <ben@bagu.org>
3134 Enable the CellTable Pager when more than 20 rows need to be viewed.
3136 The Pager will automatically become active when the results are larger
3137 than the CellTable size which is currently set to 20 lines.
3139 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3140 name on debug statment in RPC call in LayoutListDataProvider, add
3141 numRows parameter to LayoutListView constructor, propperly set rowCount
3143 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3144 name on debug statment in RPC call, use LayoutListTable object in RPC
3145 calls, pass rowCount to LayoutListView.
3146 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3147 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3149 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3150 interface for changes in OnlineGlomService.
3151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3152 getLayoutListHeaders() to getLayoutListTable() and return
3153 LayoutListTable. Using this object allows me to pass other information
3154 about the LayoutList like the expected number of rows in the result set.
3155 The Connection object from the connection pool is now propperly closed.
3156 Only the requested number of lines are returned to the client in
3158 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3159 GlomTable and add columnTitles and numRows.
3161 2011-02-18 Ben Konrath <ben@bagu.org>
3163 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3165 This is a small performance boost. I'll use GlomTable to get the required
3166 layoutlist information.
3168 * src/main/java/org/glom/web/client/OnlineGlom.java:
3169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3170 * src/main/java/org/glom/web/shared/GlomDocument.java:
3172 2011-02-18 Ben Konrath <ben@bagu.org>
3174 Add option to turn off formatting in JDT formatter preferences.
3176 * .settings/org.eclipse.jdt.core.prefs:
3178 2011-02-18 Ben Konrath <ben@bagu.org>
3180 Rename LayoutList to LayoutListView.
3182 I'm working towards setting things up to easily use MVP when the time
3185 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3187 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3190 2011-02-17 Ben Konrath <ben@bagu.org>
3192 Move LayoutListDataProvider class into LayoutList.java.
3194 * src/main/java/org/glom/web/client/LayoutList.java:
3196 2011-02-17 Ben Konrath <ben@bagu.org>
3198 Rename RPC service classes from LibGlomService* to OnlineGlomService*.
3200 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Update
3202 * src/main/java/org/glom/web/client/OnlineGlom.java: Update references.
3203 * src/main/java/org/glom/web/client/OnlineGlomService.java: Rename
3204 from LibGlomServer.java.
3205 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3206 Rename from LibGlomServiceAsync.java.
3207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3208 Rename from LibGlomServiceImpl.java.
3209 * src/main/webapp/WEB-INF/web.xml: Update configuration.
3211 2011-02-17 Ben Konrath <ben@bagu.org>
3213 Update JDT settings.
3215 * .settings/org.eclipse.jdt.core.prefs:
3217 2011-02-17 Ben Konrath <ben@bagu.org>
3219 Move GWT-RPC objects to shared package (where they should be).
3221 * src/main/java/org/glom/web/client/LibGlomService.java: Update imports.
3222 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Update imports.
3223 * src/main/java/org/glom/web/client/OnlineGlom.java: Update imports.
3224 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Update imports.
3225 * src/main/java/org/glom/web/shared/GlomDocument.java: Move to
3226 org.glom.web.shared package.
3227 * src/main/java/org/glom/web/shared/GlomTable.java: Move to
3228 org.glom.web.shared package.
3229 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Included shared
3230 directory in compilation to javascript.
3232 2011-02-16 Ben Konrath <ben@bagu.org>
3234 Add sort clause to the sql query that grabs table information.
3236 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add sort clause
3237 if one of the columns is a primary key.