1 2012-05-15 Murray Cumming <murrayc@murrayc.com>
3 Corrections to navigation to related records.
5 * src/main/java/org/glom/web/client/OnlineGlomService.java:
6 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
7 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
8 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
9 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
10 relationship name, because the relationship name is not necessarily unique
12 TOOD: This is inefficient, because it passes the whole list of
13 child field items back to the server, but it is more correct, and happens
14 to fix a bug with the primary key being lost after a few navigations.
15 There is probably a chance to make this more efficient anyway in some
18 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
19 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
20 * src/main/java/org/glom/web/server/ConfiguredDocument.java
21 * src/main/java/org/glom/web/server/database/DBAccess.java
22 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
23 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
26 2012-05-15 Murray Cumming <murrayc@murrayc.com>
28 Fix the use of translations.
30 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
31 Add updateTitlesForLocale().
32 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
33 Call it to discard unwanted translations and to make getTitle() return
34 the wanted translation wihout the need for the client code to specify a locale.
35 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
36 getTitle(): Fallback to the original title, as libglom does.
38 2012-05-15 Murray Cumming <murrayc@murrayc.com>
40 Document: Correctly report the number of available translation locales.
42 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
43 the available locale IDs list.
44 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
45 testLocales: Test this.
47 2012-05-15 Murray Cumming <murrayc@murrayc.com>
49 SqlUtils: Use camelCase.
51 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
52 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
53 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
54 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
55 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
56 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
58 2012-05-15 Murray Cumming <murrayc@murrayc.com>
60 Use jOOQ's tableByName() and fieldByName.
62 * pom.xml: Use jOOQ 2.3.1 to get the new API.
63 * src/main/java/org/glom/web/server/SqlUtils.java:
64 build_sql_select_step_with_where_clause(), .createField(),
65 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
66 so we can get correct quoting and escaping. Thanks to Lukas Eder for
67 adding this, and other things, to jOOQ.
69 2012-05-15 Murray Cumming <murrayc@murrayc.com>
71 SqlUtils: Remove the Connection parameters.
73 * src/main/java/org/glom/web/server/SqlUtils.java:
74 build_sql_select_with_key(), build_sql_select_with_where_clause(),
75 createSelect(), build_sql_select_step_with_where_clause(),
76 build_sql_count_select_with_where_clause(),
77 build_sql_select_count_rows(): Remove the Connection parameter because
78 jOOQ does not actually need a connectionwhen it is just used to build
80 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
82 * src/main/java/org/glom/web/server/ReportGenerator.java:
84 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
86 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
87 Constructor, getListData(), getResultSizeOfSQLQuery():
88 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
89 getSelectQuery(), getCountQuery():
90 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
91 getSelectQuery(), getCountQuery():
92 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
93 getNavigationRecord(): Adapted.
95 2012-05-14 Murray Cumming <murrayc@murrayc.com>
99 * src/main/java/org/glom/web/server/SqlUtils.java:
100 get_find_where_clause_quick(): Use a comparison of
101 lowercase values, instead of a simple equals. Regular Glom
102 uses the PostgreSQL ILIKE operator but jOOQ does not
103 support that just yet, though it will soon.
105 2012-05-14 Murray Cumming <murrayc@murrayc.com>
107 TableToViewDetails: Use a real serialization ID.
109 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
110 Though this does not fix the serialization problem.
112 2012-05-12 Murray Cumming <murrayc@murrayc.com>
114 Added LayoutItemPortalDeepCloneTest.
116 2012-05-11 Murray Cumming <murrayc@murrayc.com>
118 Make navigation work again.
120 * src/main/java/org/glom/web/server/libglom/Document.java:
121 Add getLayoutItemFieldShouldHaveNavigation().
122 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
123 Replace get/setAddNavigation() with the partly-existing
124 get/setNavigationTableName(), with an empty string being no navigation,
125 because this is simpler. Use the new
126 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
128 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
129 Add updateFieldsExtras() and call setNavigationTableName in it.
130 getDetailsLayoutGroup(),
131 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
132 createLayout(): Adapted.
133 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
134 Constructor: Adapted.
136 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
137 Replace get/setAddNavigation() with get/setNavigation(), returning a
138 TableToViewDetails class with both the table name and UsesRelationship,
139 because both are need. The previous code used java-libglom's output
140 variable (strangely, via sharedptr) to return both, but we cannot really
142 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
143 getNavigationRecord(): Adapt. However, we cannot actually use the cache
144 here because it somehow gets set to null during deepCopy(). I must test this.
145 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
146 testGetSuitableTableToViewDetails(): Adapted.
148 TODO: Find out why deepClone() is not quite working.
150 2012-05-11 Murray Cumming <murrayc@murrayc.com>
152 DBAccess: Simplify the retrievel of full field details.
154 * src/main/java/org/glom/web/server/database/DBAccess.java
155 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
156 because the Document loading should have done this.
158 2012-05-11 Murray Cumming <murrayc@murrayc.com>
160 Document: Correct loading of doubly-related layout fields.
162 * src/main/java/org/glom/web/server/libglom/Document.java:
163 loadUsesRelationship(): Actually set the related relationship, instead
164 of only setting it if it's not found.
166 2012-05-09 Murray Cumming <murrayc@murrayc.com>
168 Replace all appearances of Colour with color.
170 Because US English is dominant.
172 2012-05-09 Murray Cumming <murrayc@murrayc.com>
174 Use colors in HTML format, solving a warning about an unused function.
176 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
177 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
178 Add *asHTMLColor() versions of methods.
179 TODO: However, we should create and cache the results on the server.
180 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
181 * src/main/java/org/glom/web/client/ui/list/ListTable.java
182 * src/main/java/org/glom/web/server/ConfiguredDocument.java
183 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
184 Use the asHTMLcolor() versions.
186 2012-05-09 Murray Cumming <murrayc@murrayc.com>
188 ListViewTable: Constructor: Take the table name as a parameter.
190 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
191 Constructor: Take the tableName, and set the member variable, because
193 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
194 setCellTable(): Pass the table name.
195 This makes navigation to non-default tables work again. I don't know
196 why it worked before in the master branch.
198 2012-05-07 Murray Cumming <murrayc@murrayc.com>
200 ConfiguredDocument: Restore correct addition of hidden primary key items.
202 * src/main/java/org/glom/web/client/ui/list/ListTable.java
203 (ListTable.createCellTable): Uncomment out the check for the hidden
205 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
206 add primary key items for top-level lists and portals, as before,
207 instead of adding them to each group.
208 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
209 Actually implement the extra methods such as setHiddenPrimaryKey() and
210 comment that these are used only for top-level list groups and in portals.
211 This strangeness suggests even more that this should not be squeezed
212 into the LayoutGroup class.
214 2012-05-07 Murray Cumming <murrayc@murrayc.com>
216 Fix Formatting loading.
218 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
219 getFormattingUsed(): Remove the duplicate Formatting member variable
220 in favour of the one from the base class.
221 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
222 Initialize a new Formatting instead of using null by default, so we
223 have some defaults, instead of having to initialize one later just to
224 get the same defaults. This also makes loading of formatting from the
225 document work, because that expected a non-null.
227 2012-05-07 Murray Cumming <murrayc@murrayc.com>
229 RelatedListTable: Make sure that the tableName is set.
231 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
232 Constructor: Take the tableName so it is available later. Otherwise,
233 the server assumes that we mean the default table and cannot find the
235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
236 setData(): Pass the tableName to the RelatedListTable constructor.
238 2012-05-07 Murray Cumming <murrayc@murrayc.com>
242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
243 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
244 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
246 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
248 * src/main/java/org/glom/web/server/database/DBAccess.java:
249 convertResultSetToDTO(), getPortal():
250 * src/main/java/org/glom/web/server/database/ListDBAccess.java
252 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
253 Add checks for null objects and out of range access, with log messages to
254 give hints so we can fix these properly.
256 2012-05-07 Murray Cumming <murrayc@murrayc.com>
258 Portals: some corrections.
260 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
262 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
263 constructor: Use getRelationshipNameUsed() instead of getName(), because
264 that is what is meant.
265 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
266 getFromField(): Fix a typo, to get the field name, not the table name.
267 * src/main/java/org/glom/web/server/database/DBAccess.java:
268 getPortal(): Fix a typo that stopped this from working.
270 2012-05-07 Murray Cumming <murrayc@murrayc.com>
272 LayoutItemPortal: Also override getTitleOriginal().
274 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
275 This lets the base getTitle() with no parameters work.
276 TODO: Test this properly.
278 2012-05-06 Murray Cumming <murrayc@murrayc.com>
280 LayoutItemPortal: getTitle*(): Use the relationship title.
282 2012-05-06 Murray Cumming <murrayc@murrayc.com>
284 LayoutItemField: Fix loading of custom titles.
286 * src/main/java/org/glom/web/server/libglom/Document.java
287 loadDataLayoutItemField(): The title, if any, instead of the field
288 title, is stored in a title_custom node. Load it from there.
289 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
291 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
292 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
293 getTitle*() overrides.
294 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
297 2012-05-06 Murray Cumming <murrayc@murrayc.com>
299 LayoutItemField: Fall back to field titles, so some are really shown.
301 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
302 Override getTitleOriginal() and getTitle(), as in java-libglom.
303 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
306 2012-05-06 Murray Cumming <murrayc@murrayc.com>
308 Correct use of setExpectedResultSize().
310 * src/main/java/org/glom/web/server/ConfiguredDocument.java
311 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
312 Use setExpectedResultSize only on top-level groups (for instance, the
313 list layout) or on child portals (in details views).
314 Use the correct table name for portals to avoid SQL errors.
315 Update the expected counts when returning cached layouts.
317 2012-05-06 Murray Cumming <murrayc@murrayc.com>
319 Document: Interpret no group column count as 1.
321 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
322 default, though we now check for this in the UI code anyway.
324 2012-05-06 Murray Cumming <murrayc@murrayc.com>
328 2012-05-06 Murray Cumming <murrayc@murrayc.com>
330 Translatable: Use Hashmap instead of Treemap because GWT supports it.
332 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
333 The use of Treemap lead to this error from async methods, with no
335 "The response could not be deserialized"
337 2012-05-06 Murray Cumming <murrayc@murrayc.com>
339 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
341 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
342 when using the Google -> GWT Compile, or
343 g toolbar button -> GWT Compile Project... feature in Eclipse.
345 2012-05-06 Murray Cumming <murrayc@murrayc.com>
347 ListTable.addColumn(): Protect against a null Formatting.
349 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
350 Create a default Formatting if it is null, because that is the simplest
353 2012-05-06 Murray Cumming <murrayc@murrayc.com>
355 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
357 * src/main/java/org/glom/web/server/ConfiguredDocument.java
358 updateLayoutGroup(): Check that the field is not null.
360 2012-05-06 Murray Cumming <murrayc@murrayc.com>
362 ListViewImpl: Protected against a bad cast error.
364 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
365 onEnterKeyDown(): Do not cast without an instanceof check.
367 2012-05-06 Murray Cumming <murrayc@murrayc.com>
369 ListTable: Protect against an out of range error.
371 * src/main/java/org/glom/web/client/ui/list/ListTable.java
372 createCellTable(): This is unlikely, but can happen while debugging.
374 2012-05-06 Murray Cumming <murrayc@murrayc.com>
376 AsyncMessage onFailure() callbacks: Log the exception message.
378 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
379 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
380 * src/main/java/org/glom/web/client/activity/ListActivity.java:
381 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
382 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
383 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
384 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
385 These are useful clues when something is wrong.
387 2012-05-06 Murray Cumming <murrayc@murrayc.com>
389 ConfiguredDocument: Avoid a null dereference.
391 * src/main/java/org/glom/web/server/ConfiguredDocument.java
392 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
393 details maps are created.
395 2012-05-06 Murray Cumming <murrayc@murrayc.com>
397 Document: Correct the port number parsing.
399 * src/main/java/org/glom/web/server/libglom/Document.java:
400 This lets us actually connect to the database and show the document.
402 2012-05-05 Murray Cumming <murrayc@murrayc.com>
406 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
407 user-interaction, asking us to load a temporary URL in a browser.s
408 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
409 which is apparently necessary for testing the service. See the comment.
410 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
411 Show the exception, if any. This is how I saw the 404 in the HTML in
414 2012-05-05 Murray Cumming <murrayc@murrayc.com>
416 DocumentTest: Move the .glom files into the resources directory.
418 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
419 URI via getResource().
421 2012-05-05 Murray Cumming <murrayc@murrayc.com>
423 Document: Remove the FieldIdentifies inner class.
425 * src/main/java/org/glom/web/server/libglom/Document.java: We only
426 use the Relationship (though the same function in libglom is maybe
427 used in other ways) and so this removes a compiler warning.
429 2012-05-05 Murray Cumming <murrayc@murrayc.com>
431 Document.load() Remove the error code parameter.
433 * src/main/java/org/glom/web/server/libglom/Document.java: load():
434 Remove the parameter. We do not set it yet and it could never have
435 worked as an output parameter (though maybe it did in java-libglom).
436 We could use an exception if we really want the failure reason.
437 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
439 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
440 setUp(), testGetSuitableTableToViewDetails(): Adapt.
442 2012-05-05 Murray Cumming <murrayc@murrayc.com>
444 Make some inner classes static.
446 * src/main/java/org/glom/web/server/ConfiguredDocument.java
447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
448 * src/main/java/org/glom/web/server/ReportGenerator.java
449 * src/main/java/org/glom/web/server/libglom/Document.java
450 Make all inner classes static that can be static.
452 2012-05-05 Murray Cumming <murrayc@murrayc.com>
454 OnlineGlomServiceImpl: Do not load and check for java-libglom.
456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
457 init(): We do not use java-libglom any more.
459 2012-05-05 Murray Cumming <murrayc@murrayc.com>
461 Remove mentions of java-libglom.
463 * README: Remove mention of java-libglom, because it no longer needed.
464 * utils/build-onlineglom-war.sh:
465 * utils/check-and-recover-tomcat.py:
466 * utils/install-onlineglom-war.sh: Remove these as they are no longer
467 useful. Building is now far easier, with no need for jhbuild.
469 2012-05-05 Murray Cumming <murrayc@murrayc.com>
471 Fix the build (mvn package)
473 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
474 (LayoutGroup): Make the LayoutItemList inner class static and protected.
475 Otherwise the GWT Java->Javascript compilation fails with just this
476 error, during mvn package or when attempting to view in a browser,
477 in the GWT developer mode in Eclipse.
479 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
480 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
481 [INFO] Compiling module org.glom.web.OnlineGlom
482 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
483 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
484 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
485 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
486 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
487 [INFO] [ERROR] Cannot proceed due to previous errors
489 It has taken me 2 days to find out what was causing that. After reducing
490 the code, the compiler eventually showed me the full error message.
492 2012-05-04 Murray Cumming <murrayc@murrayc.com>
494 ConfiguredDocument: Cache the cloned and stripped layouts.
496 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
497 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
498 layout in a map, so we can retrieve it again without rebuilding it.
500 2012-05-04 Murray Cumming <murrayc@murrayc.com>
502 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
504 2012-05-04 Murray Cumming <murrayc@murrayc.com>
506 libglom classes: Implement some auto-generated emthods.
508 2012-05-04 Murray Cumming <murrayc@murrayc.com>
510 Add GwtTestOnlineGlomService.
512 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
513 However, this (and the other GwtTest*) does not seem to run during
516 2012-05-04 Murray Cumming <murrayc@murrayc.com>
518 Remove use of unsupported features from client code.
520 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
521 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
522 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
523 Use our client version of StringUtils instead of the apache commons one.
525 However, the GWT Javascript compliation still fails.
527 2012-04-25 Murray Cumming <murrayc@murrayc.com>
529 Add a Field class and implement some loading of it in Document.
531 2012-04-25 Murray Cumming <murrayc@murrayc.com>
533 Initial Document loading implementation, instead of libglom.
535 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
536 and Translatable classes, and adapt the rest of the code to use them.
537 However, this is still missing Layout and Field classes and loading.
539 2012-04-24 Murray Cumming <murrayc@murrayc.com>
541 Use of jOOQ: Move Field creation into a utility method.
543 * src/main/java/org/glom/web/server/SqlUtils.java:
544 This lets us improve it more easily.
546 2012-04-24 Murray Cumming <murrayc@murrayc.com>
548 Use of jOOQ: Improve the code to COUNT a sub-select.
550 * src/main/java/org/glom/web/server/SqlUtils.java:
551 Move initial query creation into
552 build_sql_select_step_with_where_clause().
553 build_sql_select_count_rows(): Use the jOOQ API instead of
554 concatentating text, because a jOOQ Select*Step is a TableLike,
555 which is what from() takes.
557 2012-04-23 Murray Cumming <murrayc@murrayc.com>
559 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
561 * pom.xml: Depend on jooq.
562 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
563 methods with jOOQ, based on the C++ implementations in libglom,
564 with some changes to the logic required by jooQ.
565 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
567 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
568 * src/main/java/org/glom/web/server/ReportGenerator.java:
569 * src/main/java/org/glom/web/server/SqlUtils.java:
570 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
571 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
572 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
573 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
574 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
575 Adapt. In particular, the SqlUtils methods now need to take a Connection,
576 because jOOQ needs that, though it seems unnecessary.
578 This is not quite finished. Ideally jOOQ would help us to build
579 table_name.field_name names, quoting and escaping them properly.
580 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
582 2012-04-21 Murray Cumming <murrayc@murrayc.com>
584 Move use of Glom.build_sql*() into a new SqlUtils class.
586 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
587 to wrap Glom.build_sql*(). The parameter types are still Glom one,
588 but this will make it easier to start using something other than
589 libglom or SqlBuilder.
591 2012-04-21 Murray Cumming <murrayc@murrayc.com>
593 Update the project URL.
595 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
597 2012-04-21 Murray Cumming <murrayc@murrayc.com>
599 Main layout: Use a FlowTable instead of absolute positioning.
601 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
602 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
603 child panels/widgets must have an absolute position. But that is annoying, so
604 this adds a FlowTable and puts the child panels in there.
606 2012-04-21 Murray Cumming <murrayc@murrayc.com>
608 GwtTestOnlineGlom: Comment out unused code.
610 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
611 Eclipse has started to say that some code is unused.
613 2012-04-21 Murray Cumming <murrayc@murrayc.com>
615 Update to the latest versions of dependencies.
617 * pom.xml: Update version numbers of dependencies to the latest
619 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
620 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
621 * src/main/java/org/glom/web/server/ReportGenerator.java:
622 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
623 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
624 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
626 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
627 Modify the imports where necessary.
629 2012-04-17 Murray Cumming <murrayc@murrayc.com>
631 Style: Remove overflow:hidden from searchbox
633 * src/main/webapp/style.css: Because this pushes the Back To Link
634 label/link on to the next row, which is then hidden due to the
635 hard-coded (in ems) height.
637 2012-04-20 Murray Cumming <murrayc@murrayc.com>
639 Remove some duplicate code.
641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
642 getDocumentInfo(): This must have been duplicated during the merge from the
647 2012-04-19 Murray Cumming <murrayc@murrayc.com>
649 Reports: Localize the waiting for report message.
651 * src/main/java/org/glom/web/client/activity/ReportActivity.java
652 start(): Get the message from the contants.
653 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
655 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
656 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
657 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
658 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
659 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
660 Update these files with the English text for newer strings for now.
662 2012-04-19 Murray Cumming <murrayc@murrayc.com>
664 Reports: Show a message while waiting for the report.
666 * src/main/java/org/glom/web/client/ui/ReportView.java
667 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
668 Add setWaitingText(), to show a message saying that we are
669 waiting for the report to be ready.
670 * src/main/java/org/glom/web/client/activity/ReportActivity.java
671 start(): Call setWaitingText() before calling the async
674 2012-04-19 Murray Cumming <murrayc@murrayc.com>
676 ReportGenerator: Specify date and time formats.
678 * src/main/java/org/glom/web/server/ReportGenerator.java:
679 createFieldValueElement(): Use the default (and localized)
680 short formats, though we still need a way to show 4-digit
681 years without providing the format for every locale.
682 * src/main/java/org/glom/web/server/database/DBAccess.java:
683 convertResultSetToDTO(): Use the short formats here too.
685 2012-04-18 Murray Cumming <murrayc@murrayc.com>
687 ReportGenerator: Use the correct numeric formatting.
689 * src/main/java/org/glom/web/server/ReportGenerator.java
690 createFieldExpression(), createFieldValueElement(): Take the
691 whole LayoutItem_Field instead of just the field name, so
692 we have access to the formatting.
693 createFieldValueElement(): Use JRTextField.setPattern() to
694 specify the numeric formatting, with the help of a
695 regular DecimalFormat.
697 2012-04-18 Murray Cumming <murrayc@murrayc.com>
699 ReportGenerator: Avoid showing null for group by titles.
701 * src/main/java/org/glom/web/server/ReportGenerator.java
702 generateReport(): Use setBlankWhenNull() on the field title
703 style too, because this is used for values in group by
706 2012-04-18 Murray Cumming <murrayc@murrayc.com>
708 ReportGenerator: Add a colon to titles in vertical groups.
710 * src/main/java/org/glom/web/server/ReportGenerator.java
711 addFieldToDetailBandVertical(): Pass true for the withColon
714 2012-04-18 Murray Cumming <murrayc@murrayc.com>
716 ReportGenerator: Simplify the code by using Position more.
718 2012-04-18 Murray Cumming <murrayc@murrayc.com>
720 Reports: Support vertical groups, roughly.
722 * src/main/java/org/glom/web/server/ReportGenerator.java:
723 addToReport(): Rename to addGroupToReport() and, if necessary,
724 call the new addVerticalGroupToReport() method.
725 createFieldValueElement(): Let the caller specify the Y position
728 2012-04-17 Murray Cumming <murrayc@murrayc.com>
730 Reports: Allow a second report to be shown.
732 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
733 clear(): Do not remove the HTML widget, which broke the whole layout.
735 2012-04-17 Murray Cumming <murrayc@murrayc.com>
737 Locales drop-down: Show that we use English by default.
739 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
740 fillView(): When we use English, just because that is the default, when
741 no locale is specified, show that in the Locales drop-down instead of
742 just showing the first item.
744 2012-04-17 Murray Cumming <murrayc@murrayc.com>
746 Unselect the Report/Locale/Table combo item when appropriate.
748 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
749 setPlace(): clear reportName if this is not a ReportPlace.
750 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
751 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
752 When the provided name is empty, unselect all items, so that none are
753 indicated. This uses a for loop because I cannot find a single method
756 2012-04-17 Murray Cumming <murrayc@murrayc.com>
758 Report: Give the user a way to get back to the list.
760 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
761 start(), setPlace(): Show the Back To List link on reports, and also
762 interpret selecting the empty report item as back to list.
764 2012-04-13 Murray Cumming <murrayc@murrayc.com>
766 Really show the selected Report name.
768 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
769 setPlace(): Store the reportName here, if it is that kind of Place.
770 fillView(): Set the selected Report after filling the list of reports.
771 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
772 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
773 null Strings, though we need some way to unselect all ListBox items
776 2012-04-13 Murray Cumming <murrayc@murrayc.com>
778 ReportGenerator: Try to avoid some problems.
780 * src/main/java/org/glom/web/server/ReportGenerator.java
781 addField(): Try to avoid duplicates, and avoid using a null
784 2012-04-13 Murray Cumming <murrayc@murrayc.com>
786 Reports: Use quickFind.
788 * src/main/java/org/glom/web/client/OnlineGlomService.java;
789 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
791 getReportHTML(): Add a quickFind parameter.
792 * src/main/java/org/glom/web/client/activity/ReportActivity.java
793 start(): Pass the quickFind parameter.
794 * src/main/java/org/glom/web/server/ReportGenerator.java
795 generateReport(): Take a quickFind parameter.
797 2012-04-13 Murray Cumming <murrayc@murrayc.com>
799 ReportPlace: Actually use the report name.
801 * src/main/java/org/glom/web/client/place/ReportPlace.java
802 getPlace(): Do not assign the report name to the quickfind.
804 2012-04-13 Murray Cumming <murrayc@murrayc.com>
806 Show java.library.path when complaining.
808 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
809 init(): When telling us to check java.library.path, show the
812 2012-03-06 Murray Cumming <murrayc@murrayc.com>
814 ReportGenerator: Do not show nulls.
816 2012-03-06 Murray Cumming <murrayc@murrayc.com>
818 ReportGenerator: Make the title font larger.
820 2012-03-06 Murray Cumming <murrayc@murrayc.com>
822 ReportGenerator: Put field titles inside groups, if there are groups.
824 2012-03-06 Murray Cumming <murrayc@murrayc.com>
826 ReportGenerator: Take the Report itself instead of the name and group.
828 * src/main/java/org/glom/web/server/ConfiguredDocument.java
829 Remove getReportLayoutGroup().
830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
831 getReportHTML(): Pass the report instead
832 of its name and layout group.
833 * src/main/java/org/glom/web/server/ReportGenerator.java
834 generateReport(): Use the report object to use the title
837 2012-03-06 Murray Cumming <murrayc@murrayc.com>
839 ReportGenerator: Remove designBand parameters.
841 * src/main/java/org/glom/web/server/ReportGenerator.java:
842 Make designBand a class member instead of passing it to all
845 2012-03-06 Murray Cumming <murrayc@murrayc.com>
847 ReportGenerator: Add lines, a bit like in the desktop version.
849 * src/main/java/org/glom/web/server/ReportGenerator.java
850 addToReport(): Use JRDesignLine.
852 2012-03-06 Murray Cumming <murrayc@murrayc.com>
854 ReportGenerator: Correct the title positions and use some bold style.
856 * src/main/java/org/glom/web/server/ReportGenerator.java:
857 Break the code up into reusable functions, correct the placement of
858 titles, and use normal/bold styles as in the reports in the desktop
861 2012-03-06 Murray Cumming <murrayc@murrayc.com>
863 ReportGenerator: Add a header band to show the field titles.
865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
866 getReportHTML(): Pass the localeId to the ReportGenerator
868 * src/main/java/org/glom/web/server/ReportGenerator.java
869 constructor: Take the localeID so we can get translated field
871 generateReport(), addToReport(), addFieldToBand(): Add field
872 titles in a column header band.
874 2012-03-05 Murray Cumming <murrayc@murrayc.com>
876 Reports drop-down list: Some improvement.
878 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
879 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
880 Adedd setSelectedReport(),
881 setReportList(): Add a blank line so that the user can select the
883 * src/main/java/org/glom/web/client/activity/ReportActivity.java
884 start(): Show the current report by calling setSelectedReport().
885 This does not seem to work yet.
887 2012-03-05 Murray Cumming <murrayc@murrayc.com>
889 DetailsActivity, ListActivity: Move some variables into a base class.
891 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
892 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
893 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
894 the clientFactory, documentID, tableName and authenticationPopup into
895 a base class, to avoid duplication.
897 2012-03-05 Murray Cumming <murrayc@murrayc.com>
899 Translate the Reports label.
901 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
902 Get the "Reports" label string from the constants.
903 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
904 perties: Add Reports to the constants.
906 2012-03-05 Murray Cumming <murrayc@murrayc.com>
908 Reports: Implement grouping.
910 * src/main/java/org/glom/web/server/ReportGenerator.java:
911 Handle LayoutItem_GroupBy items and try to do the right thing
912 with JRDesignGroup. It seems to work.
914 2012-03-04 Murray Cumming <murrayc@murrayc.com>
916 Actually show some data with JasperReports.
918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
919 getReportHTML(): Move most code into a ReportGenerator class.
920 * src/main/java/org/glom/web/server/ReportGenerator.java:
921 Recurse into sub-groups, adding fields to the JasperDesign's details
922 band. Note that we must set an arbitrary width and height, or it just
923 will not show any data.
925 2012-03-04 Murray Cumming <murrayc@murrayc.com>
927 Reports Chooser: Show the titles, not the names.
929 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
930 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
931 and the names as the values.
932 * src/main/java/org/glom/web/server/ConfiguredDocument.java
933 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
934 group now that we provide the report name, so it should always
937 2012-02-15 Murray Cumming <murrayc@murrayc.com>
939 Depend on jasperreports.
941 * pom.xml: Add the dependency. My plan is to use this on the
944 2012-01-31 Murray Cumming <murrayc@murrayc.com>
946 Implement navigation to report places.
948 * src/main/java/org/glom/web/client/activity/ReportActivity.java
949 start(): Do not bother to handle all events here.
950 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
951 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
952 Added getSelectedReport().
953 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
954 .java: start(): When handling a change to the reports chooser,
955 call getSelectedReport() and goTo() its ReportPlace.
956 * src/main/java/org/glom/web/client/ui/ReportView.java
957 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
958 Added setReportHTML() which puts the html in a gwt HTML widget.
959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
960 getReportHTML(): Return "TODO" just to show that this works.
962 2012-01-31 Murray Cumming <murrayc@murrayc.com>
964 Make ReportPlace usable.
966 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
968 * src/main/java/org/glom/web/client/place/ReportPlace.java:
969 Correct the @prefix annotation.
971 2012-01-31 Murray Cumming <murrayc@murrayc.com>
973 OnlineGlomService: Return report HTML rather than the LayoutGroup.
975 * src/main/java/org/glom/web/client/OnlineGlomService.java:
976 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
977 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
978 Change getReportLayout() to getReportHMTL() because we will not need to
979 parse or render the report layout on the client side.
980 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
981 getReportLayout(): Return the libglom LayoutGroup type because we will
982 not need to convert to a shared type, because this will not be used on
984 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
987 Note that there is still no implementation for this.
990 2012-01-27 Murray Cumming <murrayc@murrayc.com>
992 Add a (empty) Report Place, View, and Activity.
994 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
996 * src/main/java/org/glom/web/client/place/HasTablePlace.java
997 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
998 this into a superclass:
999 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1000 and also use it as the base of this new ReportPlace:
1001 * src/main/java/org/glom/web/client/place/ReportPlace.java
1003 * src/main/java/org/glom/web/client/ui/ReportView.java
1004 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1005 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1006 Add these, containing mostly boiler-plate for now.
1008 * src/main/java/org/glom/web/client/OnlineGlomService.java
1009 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1010 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1012 Add API to get the LayoutGroup for the report.
1014 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1016 Add and fill a Reports drop-down list box.
1018 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1020 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1021 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1023 Added getReports(document, table, localeID), calling
1024 ConfiguredDocument.getReports().
1025 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1026 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1027 Added setReportsList() and a list widget.
1028 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1029 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1034 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1036 Translations: Add Esperanto.
1038 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1039 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1040 properties: Add this translation because someone took the time to make it.
1042 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1044 Adapt to the java-libglom 1.21.7 API.
1046 * src/main/java/org/glom/web/server/ReportGenerator.java:
1047 addToReport(): get_group_secondary_fields() is now
1048 get_secondary_fields().
1051 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1053 Use the latest java-libglom version.
1055 * pom.xml: Use java-libglom 1.21.7.
1057 2012-03-03 Ben Konrath <ben@bagu.org>
1059 Display date and time in details view.
1061 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1063 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1065 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1067 Require the latest java-libglom.
1069 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1071 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1073 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1075 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1076 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1077 an empty quickfind string. I also corrected libglom to create only
1078 empty where clauses for empty quickfind strings, but this avoids the
1081 2012-02-24 Ben Konrath <ben@bagu.org>
1083 Improve the tabs in the Notebook widget.
1087 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1089 Translations: Try to translate the strings.
1091 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1092 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1093 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1094 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1095 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1096 Take the Open translation from GTK+'s .po files.
1097 Take the Details translation from Glom's po files.
1098 I have added the other strings to Glom so we can get translations that way:
1099 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1101 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1103 TableSelectionViewImpl: Put the search label and entry in a div.
1105 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1106 Put the search widgets in a FlowTable so that the CSS can be used to
1107 style them while keeping them together.
1108 * src/main/webapp/style.css: Mention the new div.
1110 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1112 Translate more strings in more locales.
1114 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1115 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1116 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1117 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1118 Translate the "Details" and "Open" string too.
1120 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1121 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1122 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1123 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1124 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1125 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1126 Add these new locales as placeholders though they currently contain English.
1128 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1130 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1133 Check the ConfiguredDocument* for null before using it.
1135 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1137 Tell Eclipse about the generated java files.
1139 * .classpath: This lets it find OnlineGlomConstants.java.
1140 It would be nice if Eclipse just used the maven build files.
1142 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1144 Prevent a crash when no locale is specified in the URL.
1146 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1147 Avoid returning a null string, obtained from
1148 Window.Location.getParameter(). This caused a crash when it was
1149 later passed to libglom's API.
1150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1151 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1152 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1153 guard against future null strings.
1155 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1157 Use the ?locale= query param instead of the &lang= token param.
1159 * src/main/java/org/glom/web/client/place/ListPlace.java
1160 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1161 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1162 Remove the lang token key and value.
1164 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1166 When the user selects a different locale from the chooser, use
1167 Window.Location.assign() to change the URL, which then causes a reload.
1169 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1171 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1172 * src/main/java/org/glom/web/client/activity/ListActivity.java
1173 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1174 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1175 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1176 * src/main/java/org/glom/web/client/ui/ListView.java:
1177 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1179 Remove localeID member variables and method/constructor parameters, instead
1180 using Utils.getCurrentLocaleID() when we need a localID to pass to
1183 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1185 Internationalize the UI strings.
1187 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1188 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1189 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1190 because it is unused. Messages are apparently strings that can have
1191 parameters, but we do not need that yet, so Contants will be enough for now.
1192 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1193 to say that we support the en and de locales.
1194 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1195 The original English strings.
1196 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1197 Some German translations of the English strings.
1198 The i18n goal then uses the .properties file to generate an
1199 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1200 returns an implementation that returns the translated strings.
1201 The documentation suggests putting these in src/java/*/client/, but it seems
1202 best to put it in src/resources/*/client/.
1203 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1204 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1205 instead of hard-coding them.
1206 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1207 but that does not seem to stop the build, though it confuses Eclipse.
1209 You can see the translated string by adding ?locale=de to the URL, like so:
1210 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1212 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1214 Improve null/empty String checks.
1216 * pom.xml: Add a dependency on commons-lang, to use
1217 org.apache.commons.lang.StringUtils.
1218 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1219 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1220 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1221 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1222 Use StringUtils.isEmpty().
1224 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1225 StringUtils class with a static isEmpty() function because we
1226 cannot use org.apache.commons.lang.StringUtils in client-side
1227 GWT code because it (apparently) cannot be compiled to javascript.
1228 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1229 * src/main/java/org/glom/web/client/activity/ListActivity.java
1230 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1231 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1232 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1233 * src/main/java/org/glom/web/client/place/ListPlace.java
1234 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1235 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1236 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1237 * src/main/java/org/glom/web/client/ui/details/Group.java
1238 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1239 our StringUtils.isEmpty() function.
1241 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1243 Update to the latest java-libglom API.
1245 * pom.xml: Require java-libglom 1.21.4.
1246 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1247 getDocumentInfo(), getListViewLayoutGroup():
1248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1250 * src/main/java/org/glom/web/server/database/DBAccess.java
1251 getFieldsToShowForSQLQueryAddGroup(),
1252 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1253 with either get_database_title_original() or
1254 get_database_title(localeID).
1256 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1258 ConfiguredDocument: Avoid a null pointer exception.
1260 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1261 Initialize localeID to "" to avoid returning a null String which
1262 causes a crash in java-libglom's swing-generated code.
1264 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1266 Some simple renaming.
1268 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1269 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1270 for localeChooser. This seems more appropriate and is less ambiguous
1271 particularly in the .css file.
1273 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1275 ConfiguredDocument: Rename the localedID private member variable.
1277 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1279 Adapt to the latest java-libglom API from git master.
1281 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1282 libglom now uses only Vector instead of List, which uses add() instead of
1285 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1287 ConfiguredDocument: Rename the localedID private member variable.
1289 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1291 Build a source tarball with mvn assembly:single
1293 * assembly.xml: Add this file.
1294 * pom.xml: Use the maven-assembly-plugin and tell it to use
1295 our assembly.xml file.
1297 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1299 OnlineGlomServiceImpl: Get .glom files recursively.
1301 * pom.xml: Depend on commons-io from org.apache.commons.
1302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1303 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1304 files recursively, and with the easier filter for the extension.
1305 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1306 simplify that code too.
1308 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1310 README: Mention that you must install java-libglom packages separately.
1312 But then it works, because java-libglom is now in the central maven
1315 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1317 locales drop-down: Show the correct selected locale when the URL changes.
1319 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1320 .java: setPlace(): Move some code into fillView().
1322 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1324 locales drop-down: Do not lose the primary key.
1326 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1327 start(): onLocaleChange(): Pass the current primary key value,
1328 instead of an empty value.
1330 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1332 locales drop-down: Do not lose the drop-down selection.
1334 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1335 .java (TableSelectionActivity.fillView): Set the selected locale
1336 after changing the drop-down items (though we do not really need
1337 to change them just because the locale changes.)
1339 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1341 locales drop-down: Change the tables list when this changes.
1343 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1344 .java: TableSelectionActivity.start(): Move the async table titles
1345 retrieval into a private fillView() method and also call this when
1346 the chosen locale changes.
1347 Note that the document title is not actually translatable yet, but
1348 that is a problem that I should fix soon in libglom.
1350 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1352 Improve the placement of the locales drop-down.
1354 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1355 Put the title and locales drop-down in a div (gwt.FlowTable).
1356 * src/main/webapp/style.css: Add magic css properties to make this work.
1357 Also remove the left margin from the title so that it lines up with the
1360 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1362 locales selector: Show human-readable locale titles.
1364 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1365 getDocumentInfo(): Use java.util.Locale to show a real title of
1366 each locale, in the locale's own language.
1368 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1370 Add a language/locale selector drop-down.
1372 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1373 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1374 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1375 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1376 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1377 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1378 Add a ListBox to show the available locales. Add getLocaleSelector(),
1379 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1380 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1381 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1382 java: Add these classes.
1383 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1384 start(): Fill the locales ListBox. Handle its change event, firing a
1386 setPlace(): Show the selected locale as specified by the URL token.
1387 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1388 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1389 Handle LocaleChangeEvent, going to a new *Place with that locale.
1391 The placement of the ListBox is not pretty, and it currently uses the ID
1392 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1396 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1398 Search box: Show the search text from the URL token.
1400 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1401 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1402 Add setQuickFindText().
1403 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1404 .java: setPlace(): Store the queryText if the place is a ListPlace,
1405 and call TableSelectionView.setQuickFindText().
1407 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1409 Allow use of translations via, for instance, &lang=de in the URL.
1411 * pom.xml: Use the unstable java-libglom 1.21 version.
1413 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1414 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1415 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1416 init(): Instead of calling TranslatableItem.set_current_locale()
1417 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1418 However, this is only for default locales, which are not needed to
1419 change the locale in the URL.
1420 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1421 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1422 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1423 layout for a particular locale.
1424 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1425 Add get/setDefaultLocaleID().
1426 getDocumentInfo(), getListViewData(), getRelatedListData(),
1427 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1428 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1429 localeID parameter, so we can get the layout for a particular locale.
1431 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1432 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1433 * src/main/java/org/glom/web/client/place/ListPlace.java:
1434 Parse and construct a lang parameter too.
1436 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1437 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1438 passed to subsequent methods and constructors.
1439 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1440 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1441 Store the localeID from the *Place and pass it to other constructors
1442 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1444 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1445 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1446 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1447 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1448 * src/main/java/org/glom/web/client/ui/ListView.java:
1449 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1450 Take localeID parameters and pass them to subsequent constructors and
1451 methods, so that the layout is always retrieved for that locale.
1453 This is rather repetitive.
1455 Note that "" means the original (default) locale of the Glom document,
1456 which is usually English.
1458 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1460 Documents: Remove final keyword to fix startup configuration.
1462 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1463 final keywords on the private member variables because that breaks
1464 the startup, apparently (there are warnings) because it stops them
1465 from being serialized. I added these in the previous commit.
1467 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1469 Documents: Add some final keywords.
1471 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1474 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1476 OnlineGlomServiceImpl: Add to overview comments.
1478 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1479 Note that this is where all the document are loaded. They are not
1480 loaded freshly for each page.
1482 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1486 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1487 Add a TextBox for the text of a quick find.
1488 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1490 setBackLink(): Add a String quickFind parameter.
1491 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1492 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1493 to the base interface, because that is how TableSelectionViewImpl is used.
1494 * src/main/webapp/style.css: Add style for the search box and its label.
1496 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1497 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1498 Add these files, based on the existing TableChangeEvent and
1499 TableChangeEventHandlers.
1500 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1501 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1502 a ListPlace() that the user should be taken to.
1503 * src/main/java/org/glom/web/client/activity/ListActivity.java
1504 start(): Handle it here too and adapt the TableChangeEvent handler to
1505 pass the extra "" quickFind parameter to ListPlace.
1506 * src/main/java/org/glom/web/client/place/ListPlace.java:
1507 Constructor: Take an extra String quickFind parameter and store it,
1508 returning it from a new getQuickFind() method.
1509 getToken(): Put the quickFind text in the URL token.
1510 getPlace(): Parse the quickFind text from the URL token.
1511 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1512 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1513 ListPlace constructor.
1514 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1515 .java: start(): Add a Change handler for the TableSelectionView's
1516 TextBox (via its base HasChangeHandlers interface), firing the new
1517 QuickFindChangeEvent.
1518 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1519 pass the extra "" quickFind parameter.
1521 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1522 setCellTable(): Add a String quickFind parameter and pass it to
1523 the ListViewTable() constructor.
1524 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1525 setCellTable() in the base interface, because that is how ListViewImpl
1528 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1529 Add a String quickFind member variable.
1530 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1531 Constructor: Add a String quickFind parameter, storing it in the
1532 base ListTable's member variable.
1533 onRangeChanged(): Pass quickFind to the
1534 OnlineGlomServiceAsync.getSortedListViewData() and
1535 OnlineGlomServiceAsync.getListViewData() methods.
1537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1538 getListViewData(), getSortedListViewData(): Add a String quickFind
1539 parameter, passing it to ConfiguredDocument.getListViewData().
1540 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1541 Change getListViewData(), getSortedListViewData() in the base interface,
1542 because that is how OnlineGlomServiceImpl is used, via this:
1543 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1544 Change getListViewData(), getSortedListViewData() here too.
1545 This class can apparently be used to asynchronously call methods on
1546 OnlineGlomService, and GWT seems to implement that after recognizing
1547 just the *Async name convention and the extra AsyncCallback parameters.
1549 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1550 getListViewData(): Add a String quickFind parameter, and pass it to
1551 ListViewDBAccess.getData().
1552 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1553 getListData(): Add a String quickFind parameter and pass it to
1555 getSelectQuery(): Add a String quickFind parameter.
1556 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1557 getSelectQuery(): Add a String quickFind parameter and use it with
1558 Glom.get_find_where_clause_quick() to pass a where_clause to
1559 Glom.build_sql_select_with_where_clause(), to actually filter the
1561 getData(): Add a String quickFind parameter, passing it to getListData().
1562 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1563 va: getData(): Pass an empty string to getListData() for the
1564 quickFind parameter.
1566 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1568 ListTable: Minor change.
1570 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1571 createCellTable(): Make this protected instead of public.
1573 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1575 Many files: Use final for the parameters and use the @override attribute.
1577 2012-01-22 Ben Konrath <ben@bagu.org>
1579 Add anchor links for single line text that starts with http, ftp and www.
1583 2012-01-22 Ben Konrath <ben@bagu.org>
1585 Add ellipsis to single line text in details view.
1589 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1591 Remove all javadoc author tags.
1593 Because they are awkward and meaningless when many people touch
1595 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1597 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1599 Revert the COPYING.LESSER to COPYING rename.
1601 Apparently both should be there if it is LGPL.
1603 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1605 *View: Remove unused imports.
1607 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1608 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1609 * src/main/java/org/glom/web/client/ui/ListView.java:
1610 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1611 Remove unused imports, as suggested by Eclipse.
1613 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1615 Move the *View::Presenter types, and some API into one base View.
1617 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1618 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1619 * src/main/java/org/glom/web/client/ui/ListView.java:
1620 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1621 Presenter, setPresenter() and clear() into a shared base interface,
1622 to avoid the unnecessary duplicate Presenter types and to more clearly
1623 show how the *Views share the same structure, even if they are not
1624 used polymorphically.
1626 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1627 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1629 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1630 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1631 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1633 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1636 Feel free to revert this if there is a good reason for the duplicate
1639 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1641 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1643 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1644 a class member instead of a local variable in the method.
1645 This lets us use it to get the view instances, for use in tests.
1646 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1647 beforeOnlineGlom(): Test some more details of the initial view.
1648 Again, this is not very useful.
1650 To really test gwt-glom we will need to start a local postgresql
1651 instance with local data, like the Glom tests in C++.
1653 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1655 pom.xml: Mention the LGPL license.
1657 * pom.xml: Add a licenses section.
1658 * COPYING.LESSER: Move this to COPYING, which
1659 previously contained the GPL. But gwt-glom is all LGPL.
1661 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1663 Add project information to README and pom.xml.
1665 * README: Add a brief description and mention some mvn
1667 * pom.xml: This extra information shows up in mvn site
1670 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1672 Use the latest java-libglom version.
1674 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1676 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1678 GwtTestOnlineGlom: Test a little more.
1680 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1681 protected rather than private, as suggested by the gwt-test-utils
1683 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1684 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1685 Test the initial visibility of the panels.
1687 However, this is not a very useful test.
1688 And I wonder how we should generally test using this idea for an
1689 activity/places app like ours where the real changes happen implicitly
1690 based on the history token/URL.
1692 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1694 Slight modification to *Mapper comments.
1696 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1697 (DataActivityMapper)
1698 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1700 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1702 Remove comments mentioning GIN because they are just copied from
1703 the example code and are apparently not helpful:
1704 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1705 Also change the mention of a class that is only in the example code.
1707 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1709 GwtTestOnlineGlom test: Minor changes.
1711 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1712 Avoid the long qualified class name and modify the comment
1713 because it is now obvious to me that the mocked class is the only
1714 custom one created via GWT.create().
1716 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1718 Tests: Added the beginnings of a test using gwt-test-utils.
1720 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1721 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1722 which tells gwt-test-utils what class will be tested.
1723 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1724 Add a simple (but empty) test case. One class, used by the OnlineGlom
1725 class, is mocked so that it can be created. However, I am not sure
1726 why only this class needs to be mocked.
1728 Note that mockito seems more popular, and clearer, than easymock,
1729 but I have not got that working yet. It might be a matter of the
1732 This test is run during mvn integration-test.
1734 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1736 Tests: Use junit4-style syntax instead of junit3-style.
1738 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1739 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1740 * src/test/java/org/glom/web/shared/DataItemTest.java:
1741 Use the @Test annotation rather than relying on the test*() prefix.
1742 Also no longer implement TestCase, to avoid triggering support for
1743 the junit3-way, which stops the annotations from working.
1744 Change the imports from import junit.framework.* to
1745 import org.junit.*, which is apparently the new way.
1747 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1749 Added a test for ListPlace token parsing and creation.
1751 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1752 This is much the same as DetailsPlaceTest.
1754 I wonder how we could test the other parts of the *Place API.
1756 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1758 DetailsPlace test: Also test getToken() and recreation via getPlace().
1760 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1761 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1762 recreate it, testing the recreated DetailsPlace for the same parameter
1765 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1767 Use the surefire-report plugin.
1769 * pom.xml: This generates a HTML report about the tests in
1770 target/site/surefire-report.html
1771 when you do mvn surefire-report:report. It seems to be popular/normal.
1773 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1775 Added a test for DetailsPlace.
1777 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1778 Test the getPlace() token parsing.
1780 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1782 Added a first unit test.
1784 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1785 * src/test/java/org/glom/web/shared/DataItemTest.java:
1786 This is a silly test but it is just to get things started. Note that
1787 maven/junit finds the test because it looks in src/test by default.
1789 2011-12-22 Ben Konrath <ben@bagu.org>
1791 Change charsetName to "UTF-8" when replacing line breaks.
1793 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1794 that work in Java (such as "UTF8") will not work when compiled to
1797 This fixes a problem with multi-line details view fields that have hard
1798 line breaks. The "License Text" field on this page demonstrates the
1801 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1803 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1805 2011-12-22 Ben Konrath <ben@bagu.org>
1807 Fix another bug with related list navigation.
1809 I've tested all the navigation buttons in all of the related lists
1810 so things should be good now.
1812 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1814 2011-12-22 Ben Konrath <ben@bagu.org>
1816 Fix a crasher when refreshing the list view with the default table.
1818 This crash will also happen when loading the list view with the default
1819 table from a link or bookmark.
1821 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1822 to the main document selection page when the document id hasn't been
1824 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1825 the main document selection page when the document id hasn't been
1827 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1828 values for the details place when the document id hasn't been set.
1829 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1830 values for the list place when the document id hasn't been set.
1832 2011-12-21 Ben Konrath <ben@bagu.org>
1834 Protect against NPE when glom.document.locale is not in config.
1836 This patch protects against an NPE when glom.document.locale is not in
1837 the config file. This NPE will also happen if glom.document.locale is
1840 The patch also updates the error message to display the class name when
1841 the getMessage() returns null. This was happening when the NPE was
1842 thrown and I had "Configuration Error: null". If an NPE is encountered
1843 with this patch, "Configuration Error: NullPointerException " will be
1846 This commit closes this bug:
1848 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1852 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1854 Rename onlineglom.properties to onlineglom.properties.sample.
1856 * src/main/resources/onlineglom.properties: Rename to:
1857 * src/main/resources/onlineglom.properties.sample:
1858 * src/main/resources/README: And add this file explaining that people
1859 should rename it back when deploying.
1861 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1863 Allow choosing the translation in the .properties file.
1865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1866 init(): Read a glom.document.locale value from the configuration file
1867 and call Glom's TransatableItem::set_current_locale() method.
1868 * src/main/resources/onlineglom.properties: Add a commented-out
1869 example of this new setting.
1871 It would be better to add &lang=de_DE to the URL, but the current
1872 libglom API does not allow us to do this easily. I am working on that.
1874 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1876 Avoid a crash in parsing of token parameters.
1878 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1879 ava: getTokenParams(): Do not crash if a parameter has a key but no
1880 value, and ignore parameters with neither.
1882 2011-12-17 Murray Cumming <murrayc@murayc.com>
1884 History token building/handling: Improve use of token parameters.
1886 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1887 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1888 and buildParamsToken(HashMap), for use by derived classes.
1889 Make the separator private because it is no longer be needed.
1890 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1891 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1892 instead of manual string concatenation.
1893 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1894 of hardcoded indices and awkward splitting code.
1895 * src/main/java/org/glom/web/client/place/ListPlace.java
1896 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1897 instead of manual string concatenation.
1898 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1899 of hardcoded indices and awkward splitting code.
1900 This should fix bug #666420
1902 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1904 Fix a Navgiation->Navigation typo in the code.
1906 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1907 Rename processNavgiation() to processNavigation().
1909 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1911 Fix a seperator->separator typo in the code.
1913 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1914 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1915 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1918 2011-12-15 Ben Konrath <ben@bagu.org>
1920 Cleanup some comments.
1922 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1924 2011-12-14 Ben Konrath <ben@bagu.org>
1926 Replace \n with <br/> for multiline text in the details view.
1928 Vertical scrollbars are added when needed as well.
1930 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1932 2011-12-14 Ben Konrath <ben@bagu.org>
1934 Specify the font for document selection links.
1936 * src/main/webapp/style.css:
1938 2011-12-14 Ben Konrath <ben@bagu.org>
1940 Fix bouncy CellTable while paging.
1942 This doesn't currently work with related list tables in unselected
1945 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1947 2011-12-14 Ben Konrath <ben@bagu.org>
1949 Revamp the appearance of the document selection page.
1951 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1952 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1953 * src/main/webapp/style.css:
1955 2011-12-13 Ben Konrath <ben@bagu.org>
1957 Set navigation button column to the smallest size possible.
1959 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1961 2011-12-13 Ben Konrath <ben@bagu.org>
1963 Change OpenButton nomenclature to NavigationButton.
1965 Using NavigtionButton makes things more generic. Classes, methods and
1966 variables have been changed.
1968 This is a rename-only refactor.
1970 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1971 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1972 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1973 Renamed from OpenButtonCell.
1974 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1975 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1976 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1978 2011-12-12 Ben Konrath <ben@bagu.org>
1980 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1982 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1983 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1984 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1985 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1987 2011-12-12 Ben Konrath <ben@bagu.org>
1989 Update variable names and comments.
1991 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1992 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1994 2011-12-12 Ben Konrath <ben@bagu.org>
1996 Properly initialize numNonEmptyRows variable to zero.
1998 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1999 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2001 2011-12-05 Ben Konrath <ben@bagu.org>
2003 Add latest mockup with HTML tables.
2005 Features of this mockup:
2007 -> HTML table for flowtable
2008 -> HTML table for flowtable column
2009 -> Example of how related lists would look
2010 -> Not using text entries for data items
2012 The current version of Online Glom doesn't use HTML tables for the
2015 This mockup has been sent to the glom-devel mailing list but it's good
2016 to have it here as well.
2018 * mockups/details-view-html-tables.html:
2020 2011-12-05 Ben Konrath <ben@bagu.org>
2022 Remove unnecessary getPrimaryKeyField() method.
2024 getPrimaryKeyFieldForTable(String) has been renamed to
2025 getPrimaryKeyField(String).
2027 * src/main/java/org/glom/web/server/database/DBAccess.java:
2028 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2029 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2031 2011-12-05 Ben Konrath <ben@bagu.org>
2033 Add string representation of TypedDataItem value to conversion error message.
2035 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2036 message was extracted into its own method to avoid duplication.
2038 2011-12-05 Ben Konrath <ben@bagu.org>
2040 Add type checking to navigation primary key value creation.
2042 Create navigation primary key only if the expected type from the Glom
2043 document matches the type returned by the SQL query.
2045 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2047 2011-12-05 Ben Konrath <ben@bagu.org>
2049 Rename a couple of variables in RelatedListNavigation.
2051 This is a rename-only refactor.
2053 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2055 2011-12-05 Ben Konrath <ben@bagu.org>
2057 Move getListLayoutGroup() into getListViewLayoutGroup().
2059 This removes getListLayoutGroup(). It was only being called by
2060 getListViewLayoutGroup().
2062 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2064 2011-12-05 Ben Konrath <ben@bagu.org>
2066 Remove check for LayoutItem_Portal in list table method.
2068 This check is no longer necessary because the method isn't being used
2069 to create the LayoutItemPortal DTO.
2071 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2073 2011-12-05 Ben Konrath <ben@bagu.org>
2075 Properly support related list navigation.
2077 Navigation from the "Repository Analyzer -> Package Scans ->
2078 Dependencies" related table wasn't working because the primary key for
2079 related tables wasn't being set properly. This commit fixes the
2082 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2083 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2084 doesn't set the primary key properly for related list tables.
2085 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2086 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2087 useful for getting the primary key for list view tables and for related
2089 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2090 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2091 Move code to set the primary key for the table from the abstract
2092 ListDBAccess class to ListViewDBAccess as it's only correct for list
2094 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2095 Properly add primary key to related list tables.
2097 2011-12-02 Ben Konrath <ben@bagu.org>
2099 Properly set the horizontal alignment of fields.
2101 This fix is for both the list tables and the details view.
2103 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2104 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2105 to set the horizontal alignment of fields.
2107 2011-12-02 Ben Konrath <ben@bagu.org>
2109 Display currency codes in the details view.
2111 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2113 2011-12-02 Ben Konrath <ben@bagu.org>
2115 Avoid duplicate JNI call.
2117 JNI is not as efficient as pure Java and this is an easy (and small)
2120 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2121 Use previously retrieved value for whereClauseToTableName instead of
2124 2011-12-02 Ben Konrath <ben@bagu.org>
2126 Rename a couple of variables in RelatedListNavigation.
2128 This is a rename-only refactor.
2130 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2132 2011-12-02 Ben Konrath <ben@bagu.org>
2134 Indicate clearly that a mismatched primary key type is a bug.
2136 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2137 warning to error. Add 'This is a bug.' to message.
2139 2011-12-02 Ben Konrath <ben@bagu.org>
2141 Update / fix some comments.
2143 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2145 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2147 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2148 Fix comments. Add some TODOs.
2150 2011-12-02 Ben Konrath <ben@bagu.org>
2152 Enable navigation to details view with string primary key from related list.
2154 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2155 Create a text primary key value when return type of result is
2156 java.sql.Types.VARCHAR.
2158 2011-12-02 Ben Konrath <ben@bagu.org>
2160 Use checkboxes for booleans in the details view.
2162 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2164 2011-12-01 Ben Konrath <ben@bagu.org>
2166 Improve performance of related list height calculation.
2168 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2169 Put code to calculate the expected height in a static initializer so
2170 that that it's only called once.
2172 2011-12-01 Ben Konrath <ben@bagu.org>
2174 Show related list tables in notebooks (again).
2176 Calculate the height of the related list tables so the Notebook can be
2177 set the correct height. The height of the related list table is also needed by
2178 FlowTable to be able decide how to create the layout.
2180 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2181 and set the Portal height based on the height of the related list
2182 table and the Portal container.
2183 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2184 Add method to calculate the height of the related list tables.
2185 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2186 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2187 calculate the height of the Pager widget.
2189 2011-12-01 Ben Konrath <ben@bagu.org>
2191 Use CellTable API for table property instead of setting style on Element.
2193 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2195 2011-12-01 Ben Konrath <ben@bagu.org>
2197 Make ListViewTable and RelatedListTable a consistent height.
2199 The tables are now a consistent height regardless of the contents of
2200 the table. A hidden button is added to empty rows to ensure that the
2201 height of these rows will match the height of rows with data.
2203 A navigation button column is now added to every table. The width of
2204 the navigation column is set to 0px when a RelatedListTable shouldn't
2205 have navigation buttons. This maintains the a consistent row height in
2206 tables that don't show the navigation buttons.
2208 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2209 navigation column when not needed.
2210 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2211 arguments for navigation button to constructor of ListViewTable.
2212 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2213 hidden button for empty data rows.
2214 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2215 arguments for navigation button to constructor.
2216 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2217 create navigation buttons. Add hideNavigationButtons() method.
2218 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2219 arguments for navigation button to constructor.
2221 2011-12-01 Ben Konrath <ben@bagu.org>
2223 Use 'visibility: hidden' in Utils.getWidgetHeight().
2225 This is better choice because hidden elements are invisible, don't
2226 respond to events and are not part of the tab order. They will,
2227 however, take up space which is required to be able to calculate the
2228 height of the widget.
2230 * src/main/java/org/glom/web/client/Utils.java:
2232 2011-12-01 Ben Konrath <ben@bagu.org>
2234 Use Utils.getWidgetHeight() in FlowTable.
2236 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2238 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2240 2011-12-01 Ben Konrath <ben@bagu.org>
2242 Put the details css class name on the correct table column.
2244 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2246 2011-11-30 Ben Konrath <ben@bagu.org>
2248 Update for java-libglom API change.
2250 The getters and setters on FieldFormatting and NumericFormat were
2251 changed to remove the 'M'.
2253 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2255 2011-11-29 Ben Konrath <ben@bagu.org>
2257 Only allow RelatedListTables in Portals.
2259 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2261 2011-11-29 Ben Konrath <ben@bagu.org>
2263 Only create a contents panel for Portals when title is being set.
2265 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2267 2011-11-29 Ben Konrath <ben@bagu.org>
2269 Set TabLayoutPanel height based on calculated height its widgets.
2271 This is a potential fix for this bug:
2273 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2275 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2277 2011-11-29 Ben Konrath <ben@bagu.org>
2279 Align details field labels and data with the Open buttons.
2281 * src/main/webapp/style.css:
2283 2011-11-29 Ben Konrath <ben@bagu.org>
2285 Remove unnecessary <div> in the Notebook widget.
2287 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2288 method to get container FlowPanel (<div>).
2289 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2290 initWidget() method directly on the TabLayoutPanel widget instead of
2291 Group's container widget.
2293 2011-11-29 Ben Konrath <ben@bagu.org>
2295 Don't add group titles for Portals in Notebooks.
2297 This reverts the previous patch and fixes a bug I introduced with
2298 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2300 * src/main/java/org/glom/web/client/ui/details/Group.java:
2301 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2303 2011-11-28 Ben Konrath <ben@bagu.org>
2305 Remove unused boolean argument in Portal constructor.
2307 Just a code cleanup.
2309 * src/main/java/org/glom/web/client/ui/details/Group.java:
2310 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2312 2011-11-28 Ben Konrath <ben@bagu.org>
2314 Remove hack for glom 1.18 style glom files.
2316 * src/main/java/org/glom/web/client/ui/details/Group.java:
2317 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2318 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2320 2011-11-28 Ben Konrath <ben@bagu.org>
2322 Use Gda Value version of primary key to log result too large error.
2324 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2326 2011-11-28 Ben Konrath <ben@bagu.org>
2328 Don't use TypedDataItem.getText() for Unknown types from the URL.
2330 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2331 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2332 instead of getText().
2333 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2334 String field and getUnknown() method.
2336 2011-11-28 Ben Konrath <ben@bagu.org>
2338 Log an error message when the java-libglom .so is not present.
2340 The error message was being set in the exception but not logged.
2342 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2344 2011-11-28 Ben Konrath <ben@bagu.org>
2346 Ignore LayoutItem_CalendarPortals.
2348 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2349 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2351 2011-11-28 Ben Konrath <ben@bagu.org>
2353 Extract method for creating the LayoutItemPortal DTO.
2355 Just breaking the code up into smaller chunks.
2357 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2359 2011-11-28 Ben Konrath <ben@bagu.org>
2363 This should have been added with the refactor. Oops!
2365 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2367 2011-11-28 Ben Konrath <ben@bagu.org>
2369 Create primary key value from URL string using type from Glom document.
2371 See this bug, comments 19 - 25:
2373 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2375 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2376 create a TypeDataItem for the primary key here when loading from a
2377 URL. Show the same string for the primary key value as was received
2378 from the URL string (when loading from a URL).
2379 * src/main/java/org/glom/web/server/Utils.java: Update method for
2380 creating the Gda Value from the TypeDataItem to properly deal with
2381 creating a Gda Value based on the Glom document type for the primary
2382 key value string when loading from a URL.
2383 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2385 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2386 Update for changed method name.
2388 2011-11-27 Ben Konrath <ben@bagu.org>
2390 Rename PrimaryKeyItem to TypedDataItem.
2392 The name PrimaryKeyItem suggests what the class should be used for.
2393 TypedDataItem is a neutral name that describes the class better.
2395 This is a rename-only refactor.
2397 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2398 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2399 * src/main/java/org/glom/web/client/Utils.java:
2400 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2401 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2402 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2403 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2404 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2405 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2406 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2407 * src/main/java/org/glom/web/server/Utils.java:
2408 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2409 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2410 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2411 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2413 2011-11-25 Ben Konrath <ben@bagu.org>
2415 Improve Gda Value conversion from PrimaryKeyItem.
2417 The value from the PrimaryKeyItem is only used if its type match the
2418 type from the glom document.
2420 * src/main/java/org/glom/web/server/Utils.java:
2422 2011-11-25 Ben Konrath <ben@bagu.org>
2424 Manually check if the java-liblgom .so is visible to the JVM.
2426 It seems that Tomcat has problems when a static initializer throws an
2427 exception. This check is done before the first method call into
2428 java-libglom so that execution doesn't continue if the .so is not
2431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2433 2011-11-25 Ben Konrath <ben@bagu.org>
2435 Improve browser configuration error messages.
2439 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2441 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2442 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2443 getConfigurationErrorMessage() method.
2444 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2445 Get and display a specific configuration error message when no Glom
2446 documents are found.
2447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2448 Implement getConfigurationErrorMessage() method. Surround configuration
2449 code in the init() method with a try/catch block. This allows the
2450 errors to be caught while keeping the servlet available to retrieve the
2451 configuration error message.
2453 2011-11-25 Ben Konrath <ben@bagu.org>
2455 Don't use Strings to hold primary key values.
2457 The primary key values are now held in a new data object
2458 (PrimaryKeyItem) that holds type information and the primary key value
2459 using the correct type.
2461 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2462 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2464 PrimaryKeyItem instead of String to hold the primary key value.
2465 * src/main/java/org/glom/web/client/Utils.java: Remove
2466 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2467 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2468 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2469 PrimaryKeyItem instead of String to hold the primary key value. Load
2470 document selection page when the documentID has not been set correctly.
2471 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2472 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2474 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2475 Return empty string for URL instead of "null".
2476 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2477 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2478 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2479 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2480 PrimaryKeyItem instead of String to hold primary key values.
2481 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2482 PrimaryKeyValue to a Gda Value.
2483 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2485 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2486 Replace temporary database access code that uses the PrimaryKeyValue to
2487 Gda Value conversion.
2488 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2489 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2490 PrimaryKeyItem instead of String.
2491 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2492 hold primary key values.
2494 2011-11-24 Ben Konrath <ben@bagu.org>
2496 Use newly added java-libglom API to create queries.
2498 This isn't finished. I still need to stop using Strings for primary key
2499 values in the client code.
2501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2502 libglom to use fake connections so that retrieving the query string will
2504 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2505 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2506 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2507 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2508 Use the newly added libglom sql methods and classes to create the
2509 query. Add temporary hack to convert primary value strings to Gda
2512 2011-11-23 Ben Konrath <ben@bagu.org>
2514 Don't explicitly set the height of Portals.
2516 See comments 6 - 10 of this bug for details:
2518 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2520 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2522 2011-11-23 Ben Konrath <ben@bagu.org>
2524 Use an HTML table instead of CSS for the FlowTable layout.
2526 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2527 GWT's FlexTable to implement the FlowTable.
2528 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2530 2011-11-18 Ben Konrath <ben@bagu.org>
2532 Add boolean example to HTML table mockup.
2534 * mockups/details-view-html-tables-text-entries.html:
2536 2011-11-17 Ben Konrath <ben@bagu.org>
2538 Ensure the pager buttons are always visible for related lists.
2540 To accomplish this, I've turned off text wrapping in the list view and
2541 related list tables for both the header and data text. The related list
2542 table now has a fixed layout so the it doesn't overflow its container.
2543 This is required to ensure that the cell text is clipped when it
2544 overflows the cell and an ellipsis is added to the right side of the
2545 cell when text is clipped.
2547 A fixed table layout for the related list table in the details view
2548 seems what we want for the details view anyway, so the side-effect is
2551 The ellipsis will only be displayed in Firefox >= 7.
2555 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2557 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2558 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2559 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2561 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2562 Set the 'table-layout: fixed' CSS property to the related list table.
2563 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2564 'white-space: nowrap;' CSS property on both the list view and the
2565 related list tables.
2567 2011-11-16 Ben Konrath <ben@bagu.org>
2569 Rework the fix for empty notebook tab labels.
2571 Setting the empty group titles with its name caused problems for the
2572 details layout. Instead of using libglom's
2573 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2574 to the client when the title is empty. This allows the Notebook to use
2575 the name when the title is empty without affecting anything else.
2577 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2578 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2580 2011-11-16 Ben Konrath <ben@bagu.org>
2582 Set group titles with name when title is empty.
2584 This fixes a problem with an empty notebook tab label in the Lesson
2585 Planner document. The forth tab in the notebook should be "Internet":
2587 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2589 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2590 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2593 2011-11-16 Ben Konrath <ben@bagu.org>
2595 Remove whitespace from the configured username properties.
2597 This assumes that usernames won't have whitespace at the beginning
2598 or end. But I think this is a reasonable assumption.
2600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2601 String.trim() to remove the whitespace from the username properties.
2603 2011-11-15 Ben Konrath <ben@bagu.org>
2605 Add details view mockup with HTML tables and text entries.
2607 This is from the attachment on this bug:
2609 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2611 * mockups/details-view-html-tables-text-entries.html:
2613 2011-11-15 Ben Konrath <ben@bagu.org>
2615 Add space between the columns of the flow table.
2619 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2621 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2622 space between columns in the flow table.
2624 2011-11-15 Ben Konrath <ben@bagu.org>
2626 Add backup files to the .gitignore.
2628 * .gitignore: Ignore files that end with ~.
2630 2011-11-09 Ben Konrath <ben@bagu.org>
2632 Use latest release of gwt-log.
2634 Gwt-log releases are now being submitted to the maven central
2635 repository so manual installation of the jar is no longer required.
2637 * pom.xml: Update version and groupId of gwt-log dependency.
2639 2011-10-31 Ben Konrath <ben@bagu.org>
2641 Don't use GWT numeric formatting to override the glom currency formatting.
2643 Currencies are now displayed like they are in Glom. See this bug:
2645 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2647 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2649 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2650 currency code to constructor and set it when the cell is rendered.
2651 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2652 currency code to the constructor of the NumericCell.
2654 2011-10-27 Ben Konrath <ben@bagu.org>
2656 Require the latest release of java-libglom (1.17.4).
2660 2011-10-26 Ben Konrath <ben@bagu.org>
2662 Add style to Notebook that matches current theme.
2664 It's not the best style in the world but it's better than the default.
2666 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2667 padding at the bottom of the child widgets.
2668 * src/main/webapp/style.css: Add style for the Notebook.
2670 2011-10-26 Ben Konrath <ben@bagu.org>
2672 Move servlet initialization code to overridden init method.
2674 This is half of the solution to getting proper error messages
2675 displayed when configuration errors occur. Here's the relevant bug:
2677 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2679 The rest of the solution involves surrounding the init method with a
2680 try/catch block and setting a global variable with the error /
2681 exception. A new async method should be created to retrieve and display
2682 the error message / exception.
2684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2685 code from constructor to init method adding exceptions as needed.
2687 2011-10-26 Ben Konrath <ben@bagu.org>
2689 Add script to monitor and restart tomcat if required.
2691 * utils/check-and-recover-tomcat.py: New file.
2693 2011-10-26 Ben Konrath <ben@bagu.org>
2695 Display the correct number of data items in the pager.
2699 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2701 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2702 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2703 The implementation is the same for both tables: Keep track of the
2704 number of non-empty rows and fire and RowCountChangeEvent after the data has
2706 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2707 custom Pager class that subclasses SimplePager to handle displaying
2708 the correct number when empty rows have been added.
2710 2011-10-26 Ben Konrath <ben@bagu.org>
2712 Correct error in previous commit.
2714 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2715 eventBus parameter from listView.setCellTable().
2717 2011-10-26 Ben Konrath <ben@bagu.org>
2719 Fix error in TODO comment.
2721 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2723 2011-10-24 Ben Konrath <ben@bagu.org>
2725 Create Notebook widgets to the details view.
2727 This isn't finished just yet - I still need to create a reasonable
2728 style to match the current theme.
2730 * src/main/java/org/glom/web/client/Utils.java: Add method for
2731 calculating the height of a widget. This is used in the Notebook class.
2732 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2733 new constructor method in Group.
2734 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2735 method for creating child widget that can be used by subclasses
2736 like Notebook. New constructor that allows disabling the group
2737 titles - Notebooks don't set a group title for their child groups.
2738 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2739 to make Notebooks using GWT's TabLayoutPanel.
2740 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2741 constructor that allows disabling the group titles.
2742 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2743 LayoutItemNotebook DTO.
2744 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2745 DTO for Notebooks. It's just an empty class for now but we might need
2746 it to transfer some specific information in the future.
2748 2011-10-21 Ben Konrath <ben@bagu.org>
2750 Add navigation buttons to related list tables.
2752 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2753 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2755 method getSuitableRecordToViewDetails() for getting the table name
2756 and primary key value for related list navigation buttons.
2757 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2758 private cell renderer class to get the navigation information for
2759 related list tables from the server. Extract the navigation
2760 processing code from the details cell navigation and use it for the
2761 related list navigation as well.
2762 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2763 cell renderer class for the details open buttons. This was needed
2764 because the related list navigation buttons and the list view
2765 navigation buttons need to react differently when clicked.
2766 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2767 the onEnterKeyDown() method because it's now overriden in the
2768 subclasses that are specific to the related list tables and the list
2770 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2771 the vertical size a little because the buttons add a bit of vertical
2772 space to table. This is not a perfect solution because the vertical
2773 size of with table fewer than 5 rows will be a little smaller.
2774 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2775 changes in how navigation buttons are handled.
2776 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2777 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2778 database access object.
2779 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2780 to find the portal for a given relationship name from
2781 RelatedListDBAccess. Add method to find a primary key field for a
2783 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2784 Move code to find the portal for a given relationship name to
2786 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2787 New file: database access object for getting the related list
2788 navigation information (the table name and the primary key value).
2789 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2790 DTO for transferring a table name to navigate to and a primary key
2792 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2793 boolean and getter/setter to specifies if the related list should add
2796 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2798 Use the master branch of java-libglom
2800 * pom.xml: Depend on java-libglom 1.19 instead.
2802 This is the master branch. See also the libglom-1-18 branch.
2804 2011-10-11 Ben Konrath <ben@bagu.org>
2806 Enable the open navigation button when the data has been set.
2808 This avoids having active buttons that don't do anything when the data
2811 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2813 2011-10-11 Ben Konrath <ben@bagu.org>
2815 Use IsWidget interface for FlowTableItem.
2817 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2818 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2820 2011-10-11 Ben Konrath <ben@bagu.org>
2822 Remove GWT styling from open button in details view.
2824 There are still some issues with how the details cell is arranged but
2825 this should be made to match Glom 1.20. I'm going to leave fixing this
2826 until I have Glom 1.20 up and running.
2828 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2829 style name on open button.
2830 * src/main/webapp/style.css: Move and edit details-navigation class.
2831 Re-arrange some classes to make them appear in the same order as the
2834 2011-10-07 Ben Konrath <ben@bagu.org>
2836 Update to GWT 2.4.0.
2838 * .gitignore: Ignore new cache directory.
2839 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2840 * pom.xml: Change GWT and maven plugin to 2.4.0.
2841 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2843 * src/main/java/org/glom/web/client/ClientFactory.java:
2844 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2845 * src/main/java/org/glom/web/client/OnlineGlom.java:
2846 Update source for API changes.
2847 * utils/build-onlineglom-war.sh: Remove cache directory before the
2850 2011-10-07 Ben Konrath <ben@bagu.org>
2852 Add navigation buttons in the details view.
2854 This isn't finished but I thought I'd commit what I have as it's a
2855 pretty good start. I still need to:
2857 1. Change the style so that it fits better into the current theme
2858 2. Adjust the details cell to expand as much as possible.
2860 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2861 click handlers to navigation buttons in the DetailsCells. Create a
2862 refreshData() method to get just the data from the server without the
2864 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2865 Update the tableSelector and browser title when the table name
2866 changes without using the tableSelector.
2867 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2868 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2869 getDetailsCells() to getCells(). Update variable names.
2870 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2871 method to set click handler on navigation button. Rename a few
2872 variables. Add navigation buttons where needed.
2873 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2874 variables and methods.
2875 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2876 navigation boolean and navigation table as required in the
2877 LayoutItemField DTO.
2878 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2879 variables for navigation along with getter/setter methods.
2881 2011-10-07 Ben Konrath <ben@bagu.org>
2883 Rename Field to DetailsCell.
2885 This is a refactor-only commit. No functionality has been added or
2888 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2889 Update variable and method names.
2890 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2891 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2892 variable and method names.
2893 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2895 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2896 variable and method names.
2898 2011-10-07 Ben Konrath <ben@bagu.org>
2900 Create separate methods for layout and data the details view.
2902 This is a refactor-only commit. No functionality has been added or
2905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2906 private methods: setData(), createLayout().
2908 2011-10-07 Ben Konrath <ben@bagu.org>
2910 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2912 This is part of a change to get navigation buttons in the details view
2913 but it should have been done this way from the start.
2915 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2916 for method name change in TableSelectionView.
2917 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2918 Create TableChangeEvent and set the browser title using the
2919 TableSelectionView API.
2920 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2921 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2922 Change getSelectedTable() to getSelectedTableName(). Add
2923 getSelectedTableTitle().
2925 2011-10-07 Ben Konrath <ben@bagu.org>
2927 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2929 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2931 2011-10-07 Ben Konrath <ben@bagu.org>
2933 Update TableChangeEvent to use newTableName naming convention.
2935 This makes the class more consistent with GWT naming conventions.
2937 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2938 Update for method name change in TableChangeEvent.
2939 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2940 for method name change in TableChangeEvent.
2941 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2942 newTableName variable and getter method. Make toDebugString()
2945 2011-09-30 Ben Konrath <ben@bagu.org>
2947 Disable the pager in the list tables when the data row count is less than the minimum.
2949 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2950 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2952 2011-09-30 Ben Konrath <ben@bagu.org>
2954 Add empty rows to the end of related list and list view tables.
2956 I also extracted the cell rendering classes from the ListTable because
2957 the code was becoming a little crazy with all the anonymous inner
2958 classes. My plan is to use these cell rendering classes in the details
2959 view as well so this refactor will be needed for that change.
2961 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2962 set the row count in related list tables if the data has more rows
2963 than the minimum number of rows visible.
2964 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2965 row count in list view tables if the data has more rows than the
2966 minimum number of rows visible.
2967 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2968 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2970 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2971 for rendering TYPE_NUMERIC cells. The code was extracted from the
2973 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2974 class for rendering cells with buttons in list views. The code was
2975 extracted from the ListTable class.
2976 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2977 for rendering TYPE_TEXT cells. The code was extracted from the
2979 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2980 Add empty rows to the end of the data if required. Implement
2981 ListTable.getMinNumVisibleRows().
2982 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2983 cell renderer code to public classes. Return null in
2984 Column.getValue() for empty rows. Add new abstract method:
2985 getMinNumVisibleRows(). Move code to set the row count of the list view
2986 table to ListViewImpl.
2987 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2988 empty rows to the end of the data if required. Implement
2989 ListTable.getMinNumVisibleRows().
2992 2011-09-27 Ben Konrath <ben@bagu.org>
2994 Use GWT.log for client-side debugging statements.
2996 These are optimized out when deployed so I should have used this method
2997 in the first place. These statements will eventually be replaced with some sort
2998 of notification in the browser.
3000 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3001 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3002 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3003 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3004 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3006 2011-09-27 Ben Konrath <ben@bagu.org>
3008 Put tableselector on the right, back to list link on right.
3010 The idea is that the table selector is acting like a label for the
3011 currently displayed table so it should be placed below the document title. This
3012 puts the table title in a similar position to where it is in Glom.
3014 * mockups/details-contacts.html:
3015 * mockups/details-projects.html:
3016 * mockups/listview-contacts.html:
3017 * mockups/listview-projects.html:
3018 * mockups/style.css:
3019 Update mockups to match how the interfaces currently look.
3020 * src/main/webapp/style.css: Swap positions of backlink with the table
3021 selector. Add some space on the left side of the table selector to
3022 line things up with the document title.
3024 2011-09-27 Ben Konrath <ben@bagu.org>
3026 Add field colouring to details view.
3028 This change re-works how field colouring works. The colour formatting
3029 information is now set to the client with the layout information instead of
3030 with the data. This eliminates the need to send the same colour strings for
3031 data in list view column when colour information is set.
3033 In order to set an alternate colour for negative numeric values, the
3034 number is now sent to client and formatted with the GWT NumberFormat class.
3036 This change also fixes:
3038 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3040 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3041 internationalization framework which is needed for client side numeric
3043 * src/main/java/org/glom/web/client/Utils.java: New file for some
3044 client static utility methods.
3045 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3046 the DataItem object to the Field class. Use a utility method to
3047 create the foreignKeyValue string.
3048 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3049 alignment and text colours in the constructor. Add setData(DataItem)
3050 method. Remove setText(String) method.
3051 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3052 colour information to GlomTextCell. Create and use GlomNumberCell for
3053 rendering numbers. Use utility method to get the string for the
3054 primary key of the key provider. Re-work how the horizontal alignment
3056 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3057 formatting to layout information. Methods for converting the libglom
3058 formatting information were moved from DBAccess.
3059 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3060 numeric formatting (it's now done on the client side). Don't set text
3061 colours in DataItem. Move libglom formatting conversion methods to
3063 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3064 getters/setters for text colour information.
3065 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3066 for transferring the libglom NumericFormat information to the client.
3067 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3068 and getters/setters for: GlomNumericFormat, background colour and
3069 foreground colour strings.
3071 2011-09-26 Ben Konrath <ben@bagu.org>
3073 Simplify code that iterates through the LayoutGroup.
3075 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3077 2011-09-26 Ben Konrath <ben@bagu.org>
3079 Accept Eclipse formatting for OnlineGlomServiceAsync.
3081 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3083 2011-09-26 Ben Konrath <ben@bagu.org>
3085 Don't use the ListDBAccess classes to get the primary key layout information.
3087 This was causing a bug where the wrong index for the hidden primary key
3088 was being sent to the client.
3090 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3091 primary key while creating the LayoutGroup DTO. Create a
3092 LayoutItemField DTO for hidden primary keys. Don't use the
3093 RelatedListDBAccess because it was only used for getting the primary
3095 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3096 access modifier from public to protected for getPrimaryKeyField() and
3097 getPrimaryKeyLayoutItemField().
3098 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3099 abstract method getExpectedResultSize() because RelatedListDBAccess
3100 doesn't have enough info to implement it.
3101 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3102 Remove @Override for getExpectedResultSize().
3103 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3104 Remove method getExpectedResultSize().
3106 2011-09-23 Ben Konrath <ben@bagu.org>
3108 Log which layout (list or details) the ignored item is from.
3110 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3112 2011-09-23 Ben Konrath <ben@bagu.org>
3114 Remove annotations that turn off code formatting in DataItem.
3116 * src/main/java/org/glom/web/shared/DataItem.java:
3118 2011-09-23 Ben Konrath <ben@bagu.org>
3120 Rename GlomField to DataItem and update associated methods.
3122 This is a rename-only refactor. No functionality has been added or
3125 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3126 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3127 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3128 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3129 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3130 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3131 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3132 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3134 * src/main/java/org/glom/web/server/database/DBAccess.java:
3135 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3136 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3137 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3138 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3139 * src/main/java/org/glom/web/shared/DataItem.java:
3140 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3141 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3143 2011-09-23 Ben Konrath <ben@bagu.org>
3145 Rename GlomDocument to DocumentInfo and update associated methods.
3147 This is a rename-only refactor. No functionality has been added or
3150 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3152 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3153 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3154 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3156 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3158 2011-09-20 Ben Konrath <ben@bagu.org>
3160 Require java-libglom 1.17.3.
3162 This picks up the fix for the seg fault problem with the Scenes table
3163 in the Openismus Film Manager example.
3167 2011-09-20 Ben Konrath <ben@bagu.org>
3169 Change the way sort clause is added for primary key when no sort clause is requested.
3171 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3172 before the sort clause is created. When a sort clause is not requested, the
3173 sort clause is created by finding the primary key in the LayoutFieldVector
3176 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3178 2011-09-20 Ben Konrath <ben@bagu.org>
3180 Log error message if no documents are found in the configured directory.
3182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3183 Extract the glom file extension string to a private static final class
3184 variable (mostly as syntactic sugar). Accept a minor formatting change.
3185 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3186 the example glom.document.directory configuration property to make it
3187 more clear that it can any directory, not just the home directory.
3189 2011-09-18 Ben Konrath <ben@bagu.org>
3191 Add related lists to details view.
3193 The related list table has support for paging and sorting just like the
3194 table in the list view.
3196 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3197 SQL queries for the related list tables.
3198 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3199 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3201 Rename getList methods to getListView and add comments. Remove
3202 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3203 it being unused. Add methods: getDetailsLayoutAndData(),
3204 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3205 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3206 Create the layout and set the data for the fields in one async call
3207 instead of two. Create related lists where appropriate.
3208 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3209 for method name changes in OnlineGlomService.
3210 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3211 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3212 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3214 * src/main/java/org/glom/web/client/ui/ListView.java:
3215 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3216 tableName from setCellTable(). Create a ListViewTable instead of
3218 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3219 represent a data field in the details view.
3220 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3221 from addDetailsCell() to Field class. Keep track of the Fields and
3222 Portals in the details view.
3223 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3224 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3225 and add a method to get it. Add method to set the contents of the
3227 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3228 New class for related list tables. This class has the data provider
3229 for the related list table.
3230 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3231 abstract class which is the base class for the ListViewTable and the
3233 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3234 New class for list view tables. This class has the data provider for
3235 the list view table.
3236 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3237 methods for related list tables. Add more information to the
3238 LayoutItemField and LayoutItemPortal DTOs.
3239 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3240 Remove debugging print statement.
3241 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3242 Remove debugging print statements. Add primary key field to SQL count
3244 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3245 Remove unnecessary LayoutFieldVector parameter from
3246 getResultSizeOfSQLQuery() method.
3247 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3248 New class for related list table database access.
3249 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3250 class that is a wrapper DTO for details view layout and data.
3251 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3252 new 'fromField' string to this DTO.
3253 * src/main/webapp/style.css: Remove bottom margin and override top
3256 2011-09-15 Ben Konrath <ben@bagu.org>