1 2012-05-20 Murray Cumming <murrayc@murrayc.com>
3 Document: load(), save(): Handle the example rows.
5 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
7 * src/main/java/org/glom/web/server/libglom/Document.java:
8 load(), save(): Load and save the example rows, though the date, time
9 and image types are not handled properly yet.
10 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
11 Add testReadTableExampleRows() just to check that something is read.
13 2012-05-20 Murray Cumming <murrayc@murrayc.com>
17 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
18 Added getTranslationsMap() for use while saving.
19 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
20 Adedd getUseDefaultFormatting() for use while saving.
21 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
22 and several private methods that it uses.
24 This will be useful while testing via self-hosting.
25 It is not complete, but should be complete enough for testing.
27 2012-05-17 Murray Cumming <murrayc@murrayc.com>
29 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
31 * src/main/java/org/glom/web/client/OnlineGlomService.java
32 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
33 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
34 Remove getSortedListViewData() and getSortedRelatedListData(), adding
35 the sort column index and ascending bool to the regular method.
36 Instead, a sort column index of -1 now means no sort.
37 This is less explicit, but it's fairly simple, reduces the amount of
38 code, and makes the OnlineGlomService API slightly smaller.
39 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
40 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
42 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
43 getListViewData(), getRelatedListData():
44 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
45 getListViewData(), getRelatedListData():
46 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
48 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
50 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
55 2012-05-16 Murray Cumming <murrayc@murrayc.com>
57 Use translations for top-level groups too.
59 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
60 updateTitlesForLocale(): Use the translation for the group
61 as well as for child items.
65 Just recompiled to fix a problem in the released .tar.gz file.
69 2012-05-15 Murray Cumming <murrayc@murrayc.com>
71 Corrections to navigation to related records.
73 * src/main/java/org/glom/web/client/OnlineGlomService.java:
74 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
75 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
76 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
77 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
78 relationship name, because the relationship name is not necessarily unique
80 TOOD: This is inefficient, because it passes the whole list of
81 child field items back to the server, but it is more correct, and happens
82 to fix a bug with the primary key being lost after a few navigations.
83 There is probably a chance to make this more efficient anyway in some
86 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
87 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
88 * src/main/java/org/glom/web/server/ConfiguredDocument.java
89 * src/main/java/org/glom/web/server/database/DBAccess.java
90 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
91 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
94 2012-05-15 Murray Cumming <murrayc@murrayc.com>
96 Fix the use of translations.
98 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
99 Add updateTitlesForLocale().
100 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
101 Call it to discard unwanted translations and to make getTitle() return
102 the wanted translation wihout the need for the client code to specify a locale.
103 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
104 getTitle(): Fallback to the original title, as libglom does.
106 2012-05-15 Murray Cumming <murrayc@murrayc.com>
108 Document: Correctly report the number of available translation locales.
110 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
111 the available locale IDs list.
112 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
113 testLocales: Test this.
115 2012-05-15 Murray Cumming <murrayc@murrayc.com>
117 SqlUtils: Use camelCase.
119 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
120 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
121 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
122 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
123 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
124 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
126 2012-05-15 Murray Cumming <murrayc@murrayc.com>
128 Use jOOQ's tableByName() and fieldByName.
130 * pom.xml: Use jOOQ 2.3.1 to get the new API.
131 * src/main/java/org/glom/web/server/SqlUtils.java:
132 build_sql_select_step_with_where_clause(), .createField(),
133 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
134 so we can get correct quoting and escaping. Thanks to Lukas Eder for
135 adding this, and other things, to jOOQ.
137 2012-05-15 Murray Cumming <murrayc@murrayc.com>
139 SqlUtils: Remove the Connection parameters.
141 * src/main/java/org/glom/web/server/SqlUtils.java:
142 build_sql_select_with_key(), build_sql_select_with_where_clause(),
143 createSelect(), build_sql_select_step_with_where_clause(),
144 build_sql_count_select_with_where_clause(),
145 build_sql_select_count_rows(): Remove the Connection parameter because
146 jOOQ does not actually need a connectionwhen it is just used to build
148 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
150 * src/main/java/org/glom/web/server/ReportGenerator.java:
152 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
154 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
155 Constructor, getListData(), getResultSizeOfSQLQuery():
156 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
157 getSelectQuery(), getCountQuery():
158 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
159 getSelectQuery(), getCountQuery():
160 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
161 getNavigationRecord(): Adapted.
163 2012-05-14 Murray Cumming <murrayc@murrayc.com>
167 * src/main/java/org/glom/web/server/SqlUtils.java:
168 get_find_where_clause_quick(): Use a comparison of
169 lowercase values, instead of a simple equals. Regular Glom
170 uses the PostgreSQL ILIKE operator but jOOQ does not
171 support that just yet, though it will soon.
173 2012-05-14 Murray Cumming <murrayc@murrayc.com>
175 TableToViewDetails: Use a real serialization ID.
177 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
178 Though this does not fix the serialization problem.
180 2012-05-12 Murray Cumming <murrayc@murrayc.com>
182 Added LayoutItemPortalDeepCloneTest.
184 2012-05-11 Murray Cumming <murrayc@murrayc.com>
186 Make navigation work again.
188 * src/main/java/org/glom/web/server/libglom/Document.java:
189 Add getLayoutItemFieldShouldHaveNavigation().
190 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
191 Replace get/setAddNavigation() with the partly-existing
192 get/setNavigationTableName(), with an empty string being no navigation,
193 because this is simpler. Use the new
194 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
196 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
197 Add updateFieldsExtras() and call setNavigationTableName in it.
198 getDetailsLayoutGroup(),
199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
200 createLayout(): Adapted.
201 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
202 Constructor: Adapted.
204 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
205 Replace get/setAddNavigation() with get/setNavigation(), returning a
206 TableToViewDetails class with both the table name and UsesRelationship,
207 because both are need. The previous code used java-libglom's output
208 variable (strangely, via sharedptr) to return both, but we cannot really
210 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
211 getNavigationRecord(): Adapt. However, we cannot actually use the cache
212 here because it somehow gets set to null during deepCopy(). I must test this.
213 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
214 testGetSuitableTableToViewDetails(): Adapted.
216 TODO: Find out why deepClone() is not quite working.
218 2012-05-11 Murray Cumming <murrayc@murrayc.com>
220 DBAccess: Simplify the retrievel of full field details.
222 * src/main/java/org/glom/web/server/database/DBAccess.java
223 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
224 because the Document loading should have done this.
226 2012-05-11 Murray Cumming <murrayc@murrayc.com>
228 Document: Correct loading of doubly-related layout fields.
230 * src/main/java/org/glom/web/server/libglom/Document.java:
231 loadUsesRelationship(): Actually set the related relationship, instead
232 of only setting it if it's not found.
234 2012-05-09 Murray Cumming <murrayc@murrayc.com>
236 Replace all appearances of Colour with color.
238 Because US English is dominant.
240 2012-05-09 Murray Cumming <murrayc@murrayc.com>
242 Use colors in HTML format, solving a warning about an unused function.
244 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
245 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
246 Add *asHTMLColor() versions of methods.
247 TODO: However, we should create and cache the results on the server.
248 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
249 * src/main/java/org/glom/web/client/ui/list/ListTable.java
250 * src/main/java/org/glom/web/server/ConfiguredDocument.java
251 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
252 Use the asHTMLcolor() versions.
254 2012-05-09 Murray Cumming <murrayc@murrayc.com>
256 ListViewTable: Constructor: Take the table name as a parameter.
258 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
259 Constructor: Take the tableName, and set the member variable, because
261 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
262 setCellTable(): Pass the table name.
263 This makes navigation to non-default tables work again. I don't know
264 why it worked before in the master branch.
266 2012-05-07 Murray Cumming <murrayc@murrayc.com>
268 ConfiguredDocument: Restore correct addition of hidden primary key items.
270 * src/main/java/org/glom/web/client/ui/list/ListTable.java
271 (ListTable.createCellTable): Uncomment out the check for the hidden
273 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
274 add primary key items for top-level lists and portals, as before,
275 instead of adding them to each group.
276 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
277 Actually implement the extra methods such as setHiddenPrimaryKey() and
278 comment that these are used only for top-level list groups and in portals.
279 This strangeness suggests even more that this should not be squeezed
280 into the LayoutGroup class.
282 2012-05-07 Murray Cumming <murrayc@murrayc.com>
284 Fix Formatting loading.
286 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
287 getFormattingUsed(): Remove the duplicate Formatting member variable
288 in favour of the one from the base class.
289 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
290 Initialize a new Formatting instead of using null by default, so we
291 have some defaults, instead of having to initialize one later just to
292 get the same defaults. This also makes loading of formatting from the
293 document work, because that expected a non-null.
295 2012-05-07 Murray Cumming <murrayc@murrayc.com>
297 RelatedListTable: Make sure that the tableName is set.
299 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
300 Constructor: Take the tableName so it is available later. Otherwise,
301 the server assumes that we mean the default table and cannot find the
303 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
304 setData(): Pass the tableName to the RelatedListTable constructor.
306 2012-05-07 Murray Cumming <murrayc@murrayc.com>
310 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
311 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
312 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
314 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
316 * src/main/java/org/glom/web/server/database/DBAccess.java:
317 convertResultSetToDTO(), getPortal():
318 * src/main/java/org/glom/web/server/database/ListDBAccess.java
320 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
321 Add checks for null objects and out of range access, with log messages to
322 give hints so we can fix these properly.
324 2012-05-07 Murray Cumming <murrayc@murrayc.com>
326 Portals: some corrections.
328 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
330 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
331 constructor: Use getRelationshipNameUsed() instead of getName(), because
332 that is what is meant.
333 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
334 getFromField(): Fix a typo, to get the field name, not the table name.
335 * src/main/java/org/glom/web/server/database/DBAccess.java:
336 getPortal(): Fix a typo that stopped this from working.
338 2012-05-07 Murray Cumming <murrayc@murrayc.com>
340 LayoutItemPortal: Also override getTitleOriginal().
342 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
343 This lets the base getTitle() with no parameters work.
344 TODO: Test this properly.
346 2012-05-06 Murray Cumming <murrayc@murrayc.com>
348 LayoutItemPortal: getTitle*(): Use the relationship title.
350 2012-05-06 Murray Cumming <murrayc@murrayc.com>
352 LayoutItemField: Fix loading of custom titles.
354 * src/main/java/org/glom/web/server/libglom/Document.java
355 loadDataLayoutItemField(): The title, if any, instead of the field
356 title, is stored in a title_custom node. Load it from there.
357 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
359 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
360 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
361 getTitle*() overrides.
362 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
365 2012-05-06 Murray Cumming <murrayc@murrayc.com>
367 LayoutItemField: Fall back to field titles, so some are really shown.
369 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
370 Override getTitleOriginal() and getTitle(), as in java-libglom.
371 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
374 2012-05-06 Murray Cumming <murrayc@murrayc.com>
376 Correct use of setExpectedResultSize().
378 * src/main/java/org/glom/web/server/ConfiguredDocument.java
379 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
380 Use setExpectedResultSize only on top-level groups (for instance, the
381 list layout) or on child portals (in details views).
382 Use the correct table name for portals to avoid SQL errors.
383 Update the expected counts when returning cached layouts.
385 2012-05-06 Murray Cumming <murrayc@murrayc.com>
387 Document: Interpret no group column count as 1.
389 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
390 default, though we now check for this in the UI code anyway.
392 2012-05-06 Murray Cumming <murrayc@murrayc.com>
396 2012-05-06 Murray Cumming <murrayc@murrayc.com>
398 Translatable: Use Hashmap instead of Treemap because GWT supports it.
400 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
401 The use of Treemap lead to this error from async methods, with no
403 "The response could not be deserialized"
405 2012-05-06 Murray Cumming <murrayc@murrayc.com>
407 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
409 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
410 when using the Google -> GWT Compile, or
411 g toolbar button -> GWT Compile Project... feature in Eclipse.
413 2012-05-06 Murray Cumming <murrayc@murrayc.com>
415 ListTable.addColumn(): Protect against a null Formatting.
417 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
418 Create a default Formatting if it is null, because that is the simplest
421 2012-05-06 Murray Cumming <murrayc@murrayc.com>
423 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
425 * src/main/java/org/glom/web/server/ConfiguredDocument.java
426 updateLayoutGroup(): Check that the field is not null.
428 2012-05-06 Murray Cumming <murrayc@murrayc.com>
430 ListViewImpl: Protected against a bad cast error.
432 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
433 onEnterKeyDown(): Do not cast without an instanceof check.
435 2012-05-06 Murray Cumming <murrayc@murrayc.com>
437 ListTable: Protect against an out of range error.
439 * src/main/java/org/glom/web/client/ui/list/ListTable.java
440 createCellTable(): This is unlikely, but can happen while debugging.
442 2012-05-06 Murray Cumming <murrayc@murrayc.com>
444 AsyncMessage onFailure() callbacks: Log the exception message.
446 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
447 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
448 * src/main/java/org/glom/web/client/activity/ListActivity.java:
449 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
450 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
451 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
452 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
453 These are useful clues when something is wrong.
455 2012-05-06 Murray Cumming <murrayc@murrayc.com>
457 ConfiguredDocument: Avoid a null dereference.
459 * src/main/java/org/glom/web/server/ConfiguredDocument.java
460 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
461 details maps are created.
463 2012-05-06 Murray Cumming <murrayc@murrayc.com>
465 Document: Correct the port number parsing.
467 * src/main/java/org/glom/web/server/libglom/Document.java:
468 This lets us actually connect to the database and show the document.
470 2012-05-05 Murray Cumming <murrayc@murrayc.com>
474 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
475 user-interaction, asking us to load a temporary URL in a browser.s
476 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
477 which is apparently necessary for testing the service. See the comment.
478 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
479 Show the exception, if any. This is how I saw the 404 in the HTML in
482 2012-05-05 Murray Cumming <murrayc@murrayc.com>
484 DocumentTest: Move the .glom files into the resources directory.
486 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
487 URI via getResource().
489 2012-05-05 Murray Cumming <murrayc@murrayc.com>
491 Document: Remove the FieldIdentifies inner class.
493 * src/main/java/org/glom/web/server/libglom/Document.java: We only
494 use the Relationship (though the same function in libglom is maybe
495 used in other ways) and so this removes a compiler warning.
497 2012-05-05 Murray Cumming <murrayc@murrayc.com>
499 Document.load() Remove the error code parameter.
501 * src/main/java/org/glom/web/server/libglom/Document.java: load():
502 Remove the parameter. We do not set it yet and it could never have
503 worked as an output parameter (though maybe it did in java-libglom).
504 We could use an exception if we really want the failure reason.
505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
507 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
508 setUp(), testGetSuitableTableToViewDetails(): Adapt.
510 2012-05-05 Murray Cumming <murrayc@murrayc.com>
512 Make some inner classes static.
514 * src/main/java/org/glom/web/server/ConfiguredDocument.java
515 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
516 * src/main/java/org/glom/web/server/ReportGenerator.java
517 * src/main/java/org/glom/web/server/libglom/Document.java
518 Make all inner classes static that can be static.
520 2012-05-05 Murray Cumming <murrayc@murrayc.com>
522 OnlineGlomServiceImpl: Do not load and check for java-libglom.
524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
525 init(): We do not use java-libglom any more.
527 2012-05-05 Murray Cumming <murrayc@murrayc.com>
529 Remove mentions of java-libglom.
531 * README: Remove mention of java-libglom, because it no longer needed.
532 * utils/build-onlineglom-war.sh:
533 * utils/check-and-recover-tomcat.py:
534 * utils/install-onlineglom-war.sh: Remove these as they are no longer
535 useful. Building is now far easier, with no need for jhbuild.
537 2012-05-05 Murray Cumming <murrayc@murrayc.com>
539 Fix the build (mvn package)
541 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
542 (LayoutGroup): Make the LayoutItemList inner class static and protected.
543 Otherwise the GWT Java->Javascript compilation fails with just this
544 error, during mvn package or when attempting to view in a browser,
545 in the GWT developer mode in Eclipse.
547 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
548 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
549 [INFO] Compiling module org.glom.web.OnlineGlom
550 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
551 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
552 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
553 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
554 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
555 [INFO] [ERROR] Cannot proceed due to previous errors
557 It has taken me 2 days to find out what was causing that. After reducing
558 the code, the compiler eventually showed me the full error message.
560 2012-05-04 Murray Cumming <murrayc@murrayc.com>
562 ConfiguredDocument: Cache the cloned and stripped layouts.
564 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
565 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
566 layout in a map, so we can retrieve it again without rebuilding it.
568 2012-05-04 Murray Cumming <murrayc@murrayc.com>
570 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
572 2012-05-04 Murray Cumming <murrayc@murrayc.com>
574 libglom classes: Implement some auto-generated emthods.
576 2012-05-04 Murray Cumming <murrayc@murrayc.com>
578 Add GwtTestOnlineGlomService.
580 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
581 However, this (and the other GwtTest*) does not seem to run during
584 2012-05-04 Murray Cumming <murrayc@murrayc.com>
586 Remove use of unsupported features from client code.
588 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
589 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
590 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
591 Use our client version of StringUtils instead of the apache commons one.
593 However, the GWT Javascript compliation still fails.
595 2012-04-25 Murray Cumming <murrayc@murrayc.com>
597 Add a Field class and implement some loading of it in Document.
599 2012-04-25 Murray Cumming <murrayc@murrayc.com>
601 Initial Document loading implementation, instead of libglom.
603 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
604 and Translatable classes, and adapt the rest of the code to use them.
605 However, this is still missing Layout and Field classes and loading.
607 2012-04-24 Murray Cumming <murrayc@murrayc.com>
609 Use of jOOQ: Move Field creation into a utility method.
611 * src/main/java/org/glom/web/server/SqlUtils.java:
612 This lets us improve it more easily.
614 2012-04-24 Murray Cumming <murrayc@murrayc.com>
616 Use of jOOQ: Improve the code to COUNT a sub-select.
618 * src/main/java/org/glom/web/server/SqlUtils.java:
619 Move initial query creation into
620 build_sql_select_step_with_where_clause().
621 build_sql_select_count_rows(): Use the jOOQ API instead of
622 concatentating text, because a jOOQ Select*Step is a TableLike,
623 which is what from() takes.
625 2012-04-23 Murray Cumming <murrayc@murrayc.com>
627 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
629 * pom.xml: Depend on jooq.
630 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
631 methods with jOOQ, based on the C++ implementations in libglom,
632 with some changes to the logic required by jooQ.
633 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
636 * src/main/java/org/glom/web/server/ReportGenerator.java:
637 * src/main/java/org/glom/web/server/SqlUtils.java:
638 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
639 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
640 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
641 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
642 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
643 Adapt. In particular, the SqlUtils methods now need to take a Connection,
644 because jOOQ needs that, though it seems unnecessary.
646 This is not quite finished. Ideally jOOQ would help us to build
647 table_name.field_name names, quoting and escaping them properly.
648 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
650 2012-04-21 Murray Cumming <murrayc@murrayc.com>
652 Move use of Glom.build_sql*() into a new SqlUtils class.
654 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
655 to wrap Glom.build_sql*(). The parameter types are still Glom one,
656 but this will make it easier to start using something other than
657 libglom or SqlBuilder.
659 2012-04-21 Murray Cumming <murrayc@murrayc.com>
661 Update the project URL.
663 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
665 2012-04-21 Murray Cumming <murrayc@murrayc.com>
667 Main layout: Use a FlowTable instead of absolute positioning.
669 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
670 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
671 child panels/widgets must have an absolute position. But that is annoying, so
672 this adds a FlowTable and puts the child panels in there.
674 2012-04-21 Murray Cumming <murrayc@murrayc.com>
676 GwtTestOnlineGlom: Comment out unused code.
678 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
679 Eclipse has started to say that some code is unused.
681 2012-04-21 Murray Cumming <murrayc@murrayc.com>
683 Update to the latest versions of dependencies.
685 * pom.xml: Update version numbers of dependencies to the latest
687 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
689 * src/main/java/org/glom/web/server/ReportGenerator.java:
690 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
691 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
692 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
694 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
695 Modify the imports where necessary.
697 2012-04-17 Murray Cumming <murrayc@murrayc.com>
699 Style: Remove overflow:hidden from searchbox
701 * src/main/webapp/style.css: Because this pushes the Back To Link
702 label/link on to the next row, which is then hidden due to the
703 hard-coded (in ems) height.
705 2012-04-20 Murray Cumming <murrayc@murrayc.com>
707 Remove some duplicate code.
709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
710 getDocumentInfo(): This must have been duplicated during the merge from the
715 2012-04-19 Murray Cumming <murrayc@murrayc.com>
717 Reports: Localize the waiting for report message.
719 * src/main/java/org/glom/web/client/activity/ReportActivity.java
720 start(): Get the message from the contants.
721 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
723 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
724 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
725 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
726 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
727 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
728 Update these files with the English text for newer strings for now.
730 2012-04-19 Murray Cumming <murrayc@murrayc.com>
732 Reports: Show a message while waiting for the report.
734 * src/main/java/org/glom/web/client/ui/ReportView.java
735 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
736 Add setWaitingText(), to show a message saying that we are
737 waiting for the report to be ready.
738 * src/main/java/org/glom/web/client/activity/ReportActivity.java
739 start(): Call setWaitingText() before calling the async
742 2012-04-19 Murray Cumming <murrayc@murrayc.com>
744 ReportGenerator: Specify date and time formats.
746 * src/main/java/org/glom/web/server/ReportGenerator.java:
747 createFieldValueElement(): Use the default (and localized)
748 short formats, though we still need a way to show 4-digit
749 years without providing the format for every locale.
750 * src/main/java/org/glom/web/server/database/DBAccess.java:
751 convertResultSetToDTO(): Use the short formats here too.
753 2012-04-18 Murray Cumming <murrayc@murrayc.com>
755 ReportGenerator: Use the correct numeric formatting.
757 * src/main/java/org/glom/web/server/ReportGenerator.java
758 createFieldExpression(), createFieldValueElement(): Take the
759 whole LayoutItem_Field instead of just the field name, so
760 we have access to the formatting.
761 createFieldValueElement(): Use JRTextField.setPattern() to
762 specify the numeric formatting, with the help of a
763 regular DecimalFormat.
765 2012-04-18 Murray Cumming <murrayc@murrayc.com>
767 ReportGenerator: Avoid showing null for group by titles.
769 * src/main/java/org/glom/web/server/ReportGenerator.java
770 generateReport(): Use setBlankWhenNull() on the field title
771 style too, because this is used for values in group by
774 2012-04-18 Murray Cumming <murrayc@murrayc.com>
776 ReportGenerator: Add a colon to titles in vertical groups.
778 * src/main/java/org/glom/web/server/ReportGenerator.java
779 addFieldToDetailBandVertical(): Pass true for the withColon
782 2012-04-18 Murray Cumming <murrayc@murrayc.com>
784 ReportGenerator: Simplify the code by using Position more.
786 2012-04-18 Murray Cumming <murrayc@murrayc.com>
788 Reports: Support vertical groups, roughly.
790 * src/main/java/org/glom/web/server/ReportGenerator.java:
791 addToReport(): Rename to addGroupToReport() and, if necessary,
792 call the new addVerticalGroupToReport() method.
793 createFieldValueElement(): Let the caller specify the Y position
796 2012-04-17 Murray Cumming <murrayc@murrayc.com>
798 Reports: Allow a second report to be shown.
800 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
801 clear(): Do not remove the HTML widget, which broke the whole layout.
803 2012-04-17 Murray Cumming <murrayc@murrayc.com>
805 Locales drop-down: Show that we use English by default.
807 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
808 fillView(): When we use English, just because that is the default, when
809 no locale is specified, show that in the Locales drop-down instead of
810 just showing the first item.
812 2012-04-17 Murray Cumming <murrayc@murrayc.com>
814 Unselect the Report/Locale/Table combo item when appropriate.
816 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
817 setPlace(): clear reportName if this is not a ReportPlace.
818 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
819 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
820 When the provided name is empty, unselect all items, so that none are
821 indicated. This uses a for loop because I cannot find a single method
824 2012-04-17 Murray Cumming <murrayc@murrayc.com>
826 Report: Give the user a way to get back to the list.
828 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
829 start(), setPlace(): Show the Back To List link on reports, and also
830 interpret selecting the empty report item as back to list.
832 2012-04-13 Murray Cumming <murrayc@murrayc.com>
834 Really show the selected Report name.
836 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
837 setPlace(): Store the reportName here, if it is that kind of Place.
838 fillView(): Set the selected Report after filling the list of reports.
839 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
840 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
841 null Strings, though we need some way to unselect all ListBox items
844 2012-04-13 Murray Cumming <murrayc@murrayc.com>
846 ReportGenerator: Try to avoid some problems.
848 * src/main/java/org/glom/web/server/ReportGenerator.java
849 addField(): Try to avoid duplicates, and avoid using a null
852 2012-04-13 Murray Cumming <murrayc@murrayc.com>
854 Reports: Use quickFind.
856 * src/main/java/org/glom/web/client/OnlineGlomService.java;
857 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
858 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
859 getReportHTML(): Add a quickFind parameter.
860 * src/main/java/org/glom/web/client/activity/ReportActivity.java
861 start(): Pass the quickFind parameter.
862 * src/main/java/org/glom/web/server/ReportGenerator.java
863 generateReport(): Take a quickFind parameter.
865 2012-04-13 Murray Cumming <murrayc@murrayc.com>
867 ReportPlace: Actually use the report name.
869 * src/main/java/org/glom/web/client/place/ReportPlace.java
870 getPlace(): Do not assign the report name to the quickfind.
872 2012-04-13 Murray Cumming <murrayc@murrayc.com>
874 Show java.library.path when complaining.
876 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
877 init(): When telling us to check java.library.path, show the
880 2012-03-06 Murray Cumming <murrayc@murrayc.com>
882 ReportGenerator: Do not show nulls.
884 2012-03-06 Murray Cumming <murrayc@murrayc.com>
886 ReportGenerator: Make the title font larger.
888 2012-03-06 Murray Cumming <murrayc@murrayc.com>
890 ReportGenerator: Put field titles inside groups, if there are groups.
892 2012-03-06 Murray Cumming <murrayc@murrayc.com>
894 ReportGenerator: Take the Report itself instead of the name and group.
896 * src/main/java/org/glom/web/server/ConfiguredDocument.java
897 Remove getReportLayoutGroup().
898 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
899 getReportHTML(): Pass the report instead
900 of its name and layout group.
901 * src/main/java/org/glom/web/server/ReportGenerator.java
902 generateReport(): Use the report object to use the title
905 2012-03-06 Murray Cumming <murrayc@murrayc.com>
907 ReportGenerator: Remove designBand parameters.
909 * src/main/java/org/glom/web/server/ReportGenerator.java:
910 Make designBand a class member instead of passing it to all
913 2012-03-06 Murray Cumming <murrayc@murrayc.com>
915 ReportGenerator: Add lines, a bit like in the desktop version.
917 * src/main/java/org/glom/web/server/ReportGenerator.java
918 addToReport(): Use JRDesignLine.
920 2012-03-06 Murray Cumming <murrayc@murrayc.com>
922 ReportGenerator: Correct the title positions and use some bold style.
924 * src/main/java/org/glom/web/server/ReportGenerator.java:
925 Break the code up into reusable functions, correct the placement of
926 titles, and use normal/bold styles as in the reports in the desktop
929 2012-03-06 Murray Cumming <murrayc@murrayc.com>
931 ReportGenerator: Add a header band to show the field titles.
933 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
934 getReportHTML(): Pass the localeId to the ReportGenerator
936 * src/main/java/org/glom/web/server/ReportGenerator.java
937 constructor: Take the localeID so we can get translated field
939 generateReport(), addToReport(), addFieldToBand(): Add field
940 titles in a column header band.
942 2012-03-05 Murray Cumming <murrayc@murrayc.com>
944 Reports drop-down list: Some improvement.
946 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
947 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
948 Adedd setSelectedReport(),
949 setReportList(): Add a blank line so that the user can select the
951 * src/main/java/org/glom/web/client/activity/ReportActivity.java
952 start(): Show the current report by calling setSelectedReport().
953 This does not seem to work yet.
955 2012-03-05 Murray Cumming <murrayc@murrayc.com>
957 DetailsActivity, ListActivity: Move some variables into a base class.
959 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
960 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
961 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
962 the clientFactory, documentID, tableName and authenticationPopup into
963 a base class, to avoid duplication.
965 2012-03-05 Murray Cumming <murrayc@murrayc.com>
967 Translate the Reports label.
969 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
970 Get the "Reports" label string from the constants.
971 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
972 perties: Add Reports to the constants.
974 2012-03-05 Murray Cumming <murrayc@murrayc.com>
976 Reports: Implement grouping.
978 * src/main/java/org/glom/web/server/ReportGenerator.java:
979 Handle LayoutItem_GroupBy items and try to do the right thing
980 with JRDesignGroup. It seems to work.
982 2012-03-04 Murray Cumming <murrayc@murrayc.com>
984 Actually show some data with JasperReports.
986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
987 getReportHTML(): Move most code into a ReportGenerator class.
988 * src/main/java/org/glom/web/server/ReportGenerator.java:
989 Recurse into sub-groups, adding fields to the JasperDesign's details
990 band. Note that we must set an arbitrary width and height, or it just
991 will not show any data.
993 2012-03-04 Murray Cumming <murrayc@murrayc.com>
995 Reports Chooser: Show the titles, not the names.
997 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
998 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
999 and the names as the values.
1000 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1001 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1002 group now that we provide the report name, so it should always
1005 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1007 Depend on jasperreports.
1009 * pom.xml: Add the dependency. My plan is to use this on the
1012 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1014 Implement navigation to report places.
1016 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1017 start(): Do not bother to handle all events here.
1018 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1019 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1020 Added getSelectedReport().
1021 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1022 .java: start(): When handling a change to the reports chooser,
1023 call getSelectedReport() and goTo() its ReportPlace.
1024 * src/main/java/org/glom/web/client/ui/ReportView.java
1025 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1026 Added setReportHTML() which puts the html in a gwt HTML widget.
1027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1028 getReportHTML(): Return "TODO" just to show that this works.
1030 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1032 Make ReportPlace usable.
1034 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1035 Mention ReportPlace.
1036 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1037 Correct the @prefix annotation.
1039 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1041 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1043 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1044 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1046 Change getReportLayout() to getReportHMTL() because we will not need to
1047 parse or render the report layout on the client side.
1048 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1049 getReportLayout(): Return the libglom LayoutGroup type because we will
1050 not need to convert to a shared type, because this will not be used on
1052 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1055 Note that there is still no implementation for this.
1058 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1060 Add a (empty) Report Place, View, and Activity.
1062 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1064 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1065 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1066 this into a superclass:
1067 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1068 and also use it as the base of this new ReportPlace:
1069 * src/main/java/org/glom/web/client/place/ReportPlace.java
1071 * src/main/java/org/glom/web/client/ui/ReportView.java
1072 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1073 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1074 Add these, containing mostly boiler-plate for now.
1076 * src/main/java/org/glom/web/client/OnlineGlomService.java
1077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1078 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1080 Add API to get the LayoutGroup for the report.
1082 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1084 Add and fill a Reports drop-down list box.
1086 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1088 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1089 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1091 Added getReports(document, table, localeID), calling
1092 ConfiguredDocument.getReports().
1093 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1094 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1095 Added setReportsList() and a list widget.
1096 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1097 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1102 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1104 Translations: Add Esperanto.
1106 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1107 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1108 properties: Add this translation because someone took the time to make it.
1110 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1112 Adapt to the java-libglom 1.21.7 API.
1114 * src/main/java/org/glom/web/server/ReportGenerator.java:
1115 addToReport(): get_group_secondary_fields() is now
1116 get_secondary_fields().
1119 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1121 Use the latest java-libglom version.
1123 * pom.xml: Use java-libglom 1.21.7.
1125 2012-03-03 Ben Konrath <ben@bagu.org>
1127 Display date and time in details view.
1129 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1131 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1133 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1135 Require the latest java-libglom.
1137 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1139 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1141 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1143 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1144 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1145 an empty quickfind string. I also corrected libglom to create only
1146 empty where clauses for empty quickfind strings, but this avoids the
1149 2012-02-24 Ben Konrath <ben@bagu.org>
1151 Improve the tabs in the Notebook widget.
1155 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1157 Translations: Try to translate the strings.
1159 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1160 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1161 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1162 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1163 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1164 Take the Open translation from GTK+'s .po files.
1165 Take the Details translation from Glom's po files.
1166 I have added the other strings to Glom so we can get translations that way:
1167 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1169 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1171 TableSelectionViewImpl: Put the search label and entry in a div.
1173 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1174 Put the search widgets in a FlowTable so that the CSS can be used to
1175 style them while keeping them together.
1176 * src/main/webapp/style.css: Mention the new div.
1178 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1180 Translate more strings in more locales.
1182 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1183 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1184 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1185 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1186 Translate the "Details" and "Open" string too.
1188 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1189 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1190 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1191 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1192 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1193 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1194 Add these new locales as placeholders though they currently contain English.
1196 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1198 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1201 Check the ConfiguredDocument* for null before using it.
1203 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1205 Tell Eclipse about the generated java files.
1207 * .classpath: This lets it find OnlineGlomConstants.java.
1208 It would be nice if Eclipse just used the maven build files.
1210 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1212 Prevent a crash when no locale is specified in the URL.
1214 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1215 Avoid returning a null string, obtained from
1216 Window.Location.getParameter(). This caused a crash when it was
1217 later passed to libglom's API.
1218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1219 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1220 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1221 guard against future null strings.
1223 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1225 Use the ?locale= query param instead of the &lang= token param.
1227 * src/main/java/org/glom/web/client/place/ListPlace.java
1228 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1229 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1230 Remove the lang token key and value.
1232 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1233 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1234 When the user selects a different locale from the chooser, use
1235 Window.Location.assign() to change the URL, which then causes a reload.
1237 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1238 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1239 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1240 * src/main/java/org/glom/web/client/activity/ListActivity.java
1241 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1242 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1243 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1244 * src/main/java/org/glom/web/client/ui/ListView.java:
1245 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1247 Remove localeID member variables and method/constructor parameters, instead
1248 using Utils.getCurrentLocaleID() when we need a localID to pass to
1251 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1253 Internationalize the UI strings.
1255 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1256 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1257 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1258 because it is unused. Messages are apparently strings that can have
1259 parameters, but we do not need that yet, so Contants will be enough for now.
1260 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1261 to say that we support the en and de locales.
1262 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1263 The original English strings.
1264 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1265 Some German translations of the English strings.
1266 The i18n goal then uses the .properties file to generate an
1267 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1268 returns an implementation that returns the translated strings.
1269 The documentation suggests putting these in src/java/*/client/, but it seems
1270 best to put it in src/resources/*/client/.
1271 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1272 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1273 instead of hard-coding them.
1274 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1275 but that does not seem to stop the build, though it confuses Eclipse.
1277 You can see the translated string by adding ?locale=de to the URL, like so:
1278 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1280 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1282 Improve null/empty String checks.
1284 * pom.xml: Add a dependency on commons-lang, to use
1285 org.apache.commons.lang.StringUtils.
1286 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1287 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1288 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1289 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1290 Use StringUtils.isEmpty().
1292 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1293 StringUtils class with a static isEmpty() function because we
1294 cannot use org.apache.commons.lang.StringUtils in client-side
1295 GWT code because it (apparently) cannot be compiled to javascript.
1296 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1297 * src/main/java/org/glom/web/client/activity/ListActivity.java
1298 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1299 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1300 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1301 * src/main/java/org/glom/web/client/place/ListPlace.java
1302 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1303 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1304 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1305 * src/main/java/org/glom/web/client/ui/details/Group.java
1306 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1307 our StringUtils.isEmpty() function.
1309 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1311 Update to the latest java-libglom API.
1313 * pom.xml: Require java-libglom 1.21.4.
1314 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1315 getDocumentInfo(), getListViewLayoutGroup():
1316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1318 * src/main/java/org/glom/web/server/database/DBAccess.java
1319 getFieldsToShowForSQLQueryAddGroup(),
1320 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1321 with either get_database_title_original() or
1322 get_database_title(localeID).
1324 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1326 ConfiguredDocument: Avoid a null pointer exception.
1328 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1329 Initialize localeID to "" to avoid returning a null String which
1330 causes a crash in java-libglom's swing-generated code.
1332 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1334 Some simple renaming.
1336 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1337 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1338 for localeChooser. This seems more appropriate and is less ambiguous
1339 particularly in the .css file.
1341 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1343 ConfiguredDocument: Rename the localedID private member variable.
1345 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1347 Adapt to the latest java-libglom API from git master.
1349 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1350 libglom now uses only Vector instead of List, which uses add() instead of
1353 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1355 ConfiguredDocument: Rename the localedID private member variable.
1357 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1359 Build a source tarball with mvn assembly:single
1361 * assembly.xml: Add this file.
1362 * pom.xml: Use the maven-assembly-plugin and tell it to use
1363 our assembly.xml file.
1365 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1367 OnlineGlomServiceImpl: Get .glom files recursively.
1369 * pom.xml: Depend on commons-io from org.apache.commons.
1370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1371 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1372 files recursively, and with the easier filter for the extension.
1373 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1374 simplify that code too.
1376 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1378 README: Mention that you must install java-libglom packages separately.
1380 But then it works, because java-libglom is now in the central maven
1383 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1385 locales drop-down: Show the correct selected locale when the URL changes.
1387 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1388 .java: setPlace(): Move some code into fillView().
1390 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1392 locales drop-down: Do not lose the primary key.
1394 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1395 start(): onLocaleChange(): Pass the current primary key value,
1396 instead of an empty value.
1398 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1400 locales drop-down: Do not lose the drop-down selection.
1402 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1403 .java (TableSelectionActivity.fillView): Set the selected locale
1404 after changing the drop-down items (though we do not really need
1405 to change them just because the locale changes.)
1407 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1409 locales drop-down: Change the tables list when this changes.
1411 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1412 .java: TableSelectionActivity.start(): Move the async table titles
1413 retrieval into a private fillView() method and also call this when
1414 the chosen locale changes.
1415 Note that the document title is not actually translatable yet, but
1416 that is a problem that I should fix soon in libglom.
1418 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1420 Improve the placement of the locales drop-down.
1422 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1423 Put the title and locales drop-down in a div (gwt.FlowTable).
1424 * src/main/webapp/style.css: Add magic css properties to make this work.
1425 Also remove the left margin from the title so that it lines up with the
1428 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1430 locales selector: Show human-readable locale titles.
1432 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1433 getDocumentInfo(): Use java.util.Locale to show a real title of
1434 each locale, in the locale's own language.
1436 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1438 Add a language/locale selector drop-down.
1440 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1441 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1442 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1443 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1444 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1445 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1446 Add a ListBox to show the available locales. Add getLocaleSelector(),
1447 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1448 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1449 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1450 java: Add these classes.
1451 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1452 start(): Fill the locales ListBox. Handle its change event, firing a
1454 setPlace(): Show the selected locale as specified by the URL token.
1455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1456 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1457 Handle LocaleChangeEvent, going to a new *Place with that locale.
1459 The placement of the ListBox is not pretty, and it currently uses the ID
1460 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1464 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1466 Search box: Show the search text from the URL token.
1468 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1469 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1470 Add setQuickFindText().
1471 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1472 .java: setPlace(): Store the queryText if the place is a ListPlace,
1473 and call TableSelectionView.setQuickFindText().
1475 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1477 Allow use of translations via, for instance, &lang=de in the URL.
1479 * pom.xml: Use the unstable java-libglom 1.21 version.
1481 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1482 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1484 init(): Instead of calling TranslatableItem.set_current_locale()
1485 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1486 However, this is only for default locales, which are not needed to
1487 change the locale in the URL.
1488 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1489 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1490 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1491 layout for a particular locale.
1492 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1493 Add get/setDefaultLocaleID().
1494 getDocumentInfo(), getListViewData(), getRelatedListData(),
1495 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1496 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1497 localeID parameter, so we can get the layout for a particular locale.
1499 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1500 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1501 * src/main/java/org/glom/web/client/place/ListPlace.java:
1502 Parse and construct a lang parameter too.
1504 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1505 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1506 passed to subsequent methods and constructors.
1507 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1508 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1509 Store the localeID from the *Place and pass it to other constructors
1510 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1512 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1513 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1514 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1515 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1516 * src/main/java/org/glom/web/client/ui/ListView.java:
1517 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1518 Take localeID parameters and pass them to subsequent constructors and
1519 methods, so that the layout is always retrieved for that locale.
1521 This is rather repetitive.
1523 Note that "" means the original (default) locale of the Glom document,
1524 which is usually English.
1526 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1528 Documents: Remove final keyword to fix startup configuration.
1530 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1531 final keywords on the private member variables because that breaks
1532 the startup, apparently (there are warnings) because it stops them
1533 from being serialized. I added these in the previous commit.
1535 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1537 Documents: Add some final keywords.
1539 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1542 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1544 OnlineGlomServiceImpl: Add to overview comments.
1546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1547 Note that this is where all the document are loaded. They are not
1548 loaded freshly for each page.
1550 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1554 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1555 Add a TextBox for the text of a quick find.
1556 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1558 setBackLink(): Add a String quickFind parameter.
1559 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1560 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1561 to the base interface, because that is how TableSelectionViewImpl is used.
1562 * src/main/webapp/style.css: Add style for the search box and its label.
1564 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1565 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1566 Add these files, based on the existing TableChangeEvent and
1567 TableChangeEventHandlers.
1568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1569 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1570 a ListPlace() that the user should be taken to.
1571 * src/main/java/org/glom/web/client/activity/ListActivity.java
1572 start(): Handle it here too and adapt the TableChangeEvent handler to
1573 pass the extra "" quickFind parameter to ListPlace.
1574 * src/main/java/org/glom/web/client/place/ListPlace.java:
1575 Constructor: Take an extra String quickFind parameter and store it,
1576 returning it from a new getQuickFind() method.
1577 getToken(): Put the quickFind text in the URL token.
1578 getPlace(): Parse the quickFind text from the URL token.
1579 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1580 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1581 ListPlace constructor.
1582 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1583 .java: start(): Add a Change handler for the TableSelectionView's
1584 TextBox (via its base HasChangeHandlers interface), firing the new
1585 QuickFindChangeEvent.
1586 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1587 pass the extra "" quickFind parameter.
1589 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1590 setCellTable(): Add a String quickFind parameter and pass it to
1591 the ListViewTable() constructor.
1592 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1593 setCellTable() in the base interface, because that is how ListViewImpl
1596 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1597 Add a String quickFind member variable.
1598 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1599 Constructor: Add a String quickFind parameter, storing it in the
1600 base ListTable's member variable.
1601 onRangeChanged(): Pass quickFind to the
1602 OnlineGlomServiceAsync.getSortedListViewData() and
1603 OnlineGlomServiceAsync.getListViewData() methods.
1605 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1606 getListViewData(), getSortedListViewData(): Add a String quickFind
1607 parameter, passing it to ConfiguredDocument.getListViewData().
1608 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1609 Change getListViewData(), getSortedListViewData() in the base interface,
1610 because that is how OnlineGlomServiceImpl is used, via this:
1611 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1612 Change getListViewData(), getSortedListViewData() here too.
1613 This class can apparently be used to asynchronously call methods on
1614 OnlineGlomService, and GWT seems to implement that after recognizing
1615 just the *Async name convention and the extra AsyncCallback parameters.
1617 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1618 getListViewData(): Add a String quickFind parameter, and pass it to
1619 ListViewDBAccess.getData().
1620 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1621 getListData(): Add a String quickFind parameter and pass it to
1623 getSelectQuery(): Add a String quickFind parameter.
1624 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1625 getSelectQuery(): Add a String quickFind parameter and use it with
1626 Glom.get_find_where_clause_quick() to pass a where_clause to
1627 Glom.build_sql_select_with_where_clause(), to actually filter the
1629 getData(): Add a String quickFind parameter, passing it to getListData().
1630 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1631 va: getData(): Pass an empty string to getListData() for the
1632 quickFind parameter.
1634 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1636 ListTable: Minor change.
1638 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1639 createCellTable(): Make this protected instead of public.
1641 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1643 Many files: Use final for the parameters and use the @override attribute.
1645 2012-01-22 Ben Konrath <ben@bagu.org>
1647 Add anchor links for single line text that starts with http, ftp and www.
1651 2012-01-22 Ben Konrath <ben@bagu.org>
1653 Add ellipsis to single line text in details view.
1657 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1659 Remove all javadoc author tags.
1661 Because they are awkward and meaningless when many people touch
1663 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1665 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1667 Revert the COPYING.LESSER to COPYING rename.
1669 Apparently both should be there if it is LGPL.
1671 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1673 *View: Remove unused imports.
1675 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1676 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1677 * src/main/java/org/glom/web/client/ui/ListView.java:
1678 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1679 Remove unused imports, as suggested by Eclipse.
1681 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1683 Move the *View::Presenter types, and some API into one base View.
1685 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1686 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1687 * src/main/java/org/glom/web/client/ui/ListView.java:
1688 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1689 Presenter, setPresenter() and clear() into a shared base interface,
1690 to avoid the unnecessary duplicate Presenter types and to more clearly
1691 show how the *Views share the same structure, even if they are not
1692 used polymorphically.
1694 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1695 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1697 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1698 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1699 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1701 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1704 Feel free to revert this if there is a good reason for the duplicate
1707 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1709 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1711 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1712 a class member instead of a local variable in the method.
1713 This lets us use it to get the view instances, for use in tests.
1714 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1715 beforeOnlineGlom(): Test some more details of the initial view.
1716 Again, this is not very useful.
1718 To really test gwt-glom we will need to start a local postgresql
1719 instance with local data, like the Glom tests in C++.
1721 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1723 pom.xml: Mention the LGPL license.
1725 * pom.xml: Add a licenses section.
1726 * COPYING.LESSER: Move this to COPYING, which
1727 previously contained the GPL. But gwt-glom is all LGPL.
1729 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1731 Add project information to README and pom.xml.
1733 * README: Add a brief description and mention some mvn
1735 * pom.xml: This extra information shows up in mvn site
1738 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1740 Use the latest java-libglom version.
1742 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1744 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1746 GwtTestOnlineGlom: Test a little more.
1748 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1749 protected rather than private, as suggested by the gwt-test-utils
1751 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1752 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1753 Test the initial visibility of the panels.
1755 However, this is not a very useful test.
1756 And I wonder how we should generally test using this idea for an
1757 activity/places app like ours where the real changes happen implicitly
1758 based on the history token/URL.
1760 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1762 Slight modification to *Mapper comments.
1764 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1765 (DataActivityMapper)
1766 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1768 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1770 Remove comments mentioning GIN because they are just copied from
1771 the example code and are apparently not helpful:
1772 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1773 Also change the mention of a class that is only in the example code.
1775 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1777 GwtTestOnlineGlom test: Minor changes.
1779 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1780 Avoid the long qualified class name and modify the comment
1781 because it is now obvious to me that the mocked class is the only
1782 custom one created via GWT.create().
1784 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1786 Tests: Added the beginnings of a test using gwt-test-utils.
1788 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1789 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1790 which tells gwt-test-utils what class will be tested.
1791 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1792 Add a simple (but empty) test case. One class, used by the OnlineGlom
1793 class, is mocked so that it can be created. However, I am not sure
1794 why only this class needs to be mocked.
1796 Note that mockito seems more popular, and clearer, than easymock,
1797 but I have not got that working yet. It might be a matter of the
1800 This test is run during mvn integration-test.
1802 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1804 Tests: Use junit4-style syntax instead of junit3-style.
1806 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1807 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1808 * src/test/java/org/glom/web/shared/DataItemTest.java:
1809 Use the @Test annotation rather than relying on the test*() prefix.
1810 Also no longer implement TestCase, to avoid triggering support for
1811 the junit3-way, which stops the annotations from working.
1812 Change the imports from import junit.framework.* to
1813 import org.junit.*, which is apparently the new way.
1815 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1817 Added a test for ListPlace token parsing and creation.
1819 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1820 This is much the same as DetailsPlaceTest.
1822 I wonder how we could test the other parts of the *Place API.
1824 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1826 DetailsPlace test: Also test getToken() and recreation via getPlace().
1828 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1829 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1830 recreate it, testing the recreated DetailsPlace for the same parameter
1833 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1835 Use the surefire-report plugin.
1837 * pom.xml: This generates a HTML report about the tests in
1838 target/site/surefire-report.html
1839 when you do mvn surefire-report:report. It seems to be popular/normal.
1841 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1843 Added a test for DetailsPlace.
1845 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1846 Test the getPlace() token parsing.
1848 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1850 Added a first unit test.
1852 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1853 * src/test/java/org/glom/web/shared/DataItemTest.java:
1854 This is a silly test but it is just to get things started. Note that
1855 maven/junit finds the test because it looks in src/test by default.
1857 2011-12-22 Ben Konrath <ben@bagu.org>
1859 Change charsetName to "UTF-8" when replacing line breaks.
1861 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1862 that work in Java (such as "UTF8") will not work when compiled to
1865 This fixes a problem with multi-line details view fields that have hard
1866 line breaks. The "License Text" field on this page demonstrates the
1869 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1871 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1873 2011-12-22 Ben Konrath <ben@bagu.org>
1875 Fix another bug with related list navigation.
1877 I've tested all the navigation buttons in all of the related lists
1878 so things should be good now.
1880 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1882 2011-12-22 Ben Konrath <ben@bagu.org>
1884 Fix a crasher when refreshing the list view with the default table.
1886 This crash will also happen when loading the list view with the default
1887 table from a link or bookmark.
1889 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1890 to the main document selection page when the document id hasn't been
1892 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1893 the main document selection page when the document id hasn't been
1895 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1896 values for the details place when the document id hasn't been set.
1897 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1898 values for the list place when the document id hasn't been set.
1900 2011-12-21 Ben Konrath <ben@bagu.org>
1902 Protect against NPE when glom.document.locale is not in config.
1904 This patch protects against an NPE when glom.document.locale is not in
1905 the config file. This NPE will also happen if glom.document.locale is
1908 The patch also updates the error message to display the class name when
1909 the getMessage() returns null. This was happening when the NPE was
1910 thrown and I had "Configuration Error: null". If an NPE is encountered
1911 with this patch, "Configuration Error: NullPointerException " will be
1914 This commit closes this bug:
1916 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1918 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1920 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1922 Rename onlineglom.properties to onlineglom.properties.sample.
1924 * src/main/resources/onlineglom.properties: Rename to:
1925 * src/main/resources/onlineglom.properties.sample:
1926 * src/main/resources/README: And add this file explaining that people
1927 should rename it back when deploying.
1929 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1931 Allow choosing the translation in the .properties file.
1933 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1934 init(): Read a glom.document.locale value from the configuration file
1935 and call Glom's TransatableItem::set_current_locale() method.
1936 * src/main/resources/onlineglom.properties: Add a commented-out
1937 example of this new setting.
1939 It would be better to add &lang=de_DE to the URL, but the current
1940 libglom API does not allow us to do this easily. I am working on that.
1942 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1944 Avoid a crash in parsing of token parameters.
1946 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1947 ava: getTokenParams(): Do not crash if a parameter has a key but no
1948 value, and ignore parameters with neither.
1950 2011-12-17 Murray Cumming <murrayc@murayc.com>
1952 History token building/handling: Improve use of token parameters.
1954 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1955 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1956 and buildParamsToken(HashMap), for use by derived classes.
1957 Make the separator private because it is no longer be needed.
1958 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1959 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1960 instead of manual string concatenation.
1961 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1962 of hardcoded indices and awkward splitting code.
1963 * src/main/java/org/glom/web/client/place/ListPlace.java
1964 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1965 instead of manual string concatenation.
1966 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1967 of hardcoded indices and awkward splitting code.
1968 This should fix bug #666420
1970 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1972 Fix a Navgiation->Navigation typo in the code.
1974 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1975 Rename processNavgiation() to processNavigation().
1977 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1979 Fix a seperator->separator typo in the code.
1981 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1982 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1983 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1986 2011-12-15 Ben Konrath <ben@bagu.org>
1988 Cleanup some comments.
1990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1992 2011-12-14 Ben Konrath <ben@bagu.org>
1994 Replace \n with <br/> for multiline text in the details view.
1996 Vertical scrollbars are added when needed as well.
1998 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2000 2011-12-14 Ben Konrath <ben@bagu.org>
2002 Specify the font for document selection links.
2004 * src/main/webapp/style.css:
2006 2011-12-14 Ben Konrath <ben@bagu.org>
2008 Fix bouncy CellTable while paging.
2010 This doesn't currently work with related list tables in unselected
2013 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2015 2011-12-14 Ben Konrath <ben@bagu.org>
2017 Revamp the appearance of the document selection page.
2019 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2020 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2021 * src/main/webapp/style.css:
2023 2011-12-13 Ben Konrath <ben@bagu.org>
2025 Set navigation button column to the smallest size possible.
2027 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2029 2011-12-13 Ben Konrath <ben@bagu.org>
2031 Change OpenButton nomenclature to NavigationButton.
2033 Using NavigtionButton makes things more generic. Classes, methods and
2034 variables have been changed.
2036 This is a rename-only refactor.
2038 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2039 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2040 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2041 Renamed from OpenButtonCell.
2042 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2043 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2044 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2046 2011-12-12 Ben Konrath <ben@bagu.org>
2048 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2050 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2051 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2052 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2053 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2055 2011-12-12 Ben Konrath <ben@bagu.org>
2057 Update variable names and comments.
2059 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2060 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2062 2011-12-12 Ben Konrath <ben@bagu.org>
2064 Properly initialize numNonEmptyRows variable to zero.
2066 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2067 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2069 2011-12-05 Ben Konrath <ben@bagu.org>
2071 Add latest mockup with HTML tables.
2073 Features of this mockup:
2075 -> HTML table for flowtable
2076 -> HTML table for flowtable column
2077 -> Example of how related lists would look
2078 -> Not using text entries for data items
2080 The current version of Online Glom doesn't use HTML tables for the
2083 This mockup has been sent to the glom-devel mailing list but it's good
2084 to have it here as well.
2086 * mockups/details-view-html-tables.html:
2088 2011-12-05 Ben Konrath <ben@bagu.org>
2090 Remove unnecessary getPrimaryKeyField() method.
2092 getPrimaryKeyFieldForTable(String) has been renamed to
2093 getPrimaryKeyField(String).
2095 * src/main/java/org/glom/web/server/database/DBAccess.java:
2096 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2097 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2099 2011-12-05 Ben Konrath <ben@bagu.org>
2101 Add string representation of TypedDataItem value to conversion error message.
2103 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2104 message was extracted into its own method to avoid duplication.
2106 2011-12-05 Ben Konrath <ben@bagu.org>
2108 Add type checking to navigation primary key value creation.
2110 Create navigation primary key only if the expected type from the Glom
2111 document matches the type returned by the SQL query.
2113 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2115 2011-12-05 Ben Konrath <ben@bagu.org>
2117 Rename a couple of variables in RelatedListNavigation.
2119 This is a rename-only refactor.
2121 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2123 2011-12-05 Ben Konrath <ben@bagu.org>
2125 Move getListLayoutGroup() into getListViewLayoutGroup().
2127 This removes getListLayoutGroup(). It was only being called by
2128 getListViewLayoutGroup().
2130 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2132 2011-12-05 Ben Konrath <ben@bagu.org>
2134 Remove check for LayoutItem_Portal in list table method.
2136 This check is no longer necessary because the method isn't being used
2137 to create the LayoutItemPortal DTO.
2139 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2141 2011-12-05 Ben Konrath <ben@bagu.org>
2143 Properly support related list navigation.
2145 Navigation from the "Repository Analyzer -> Package Scans ->
2146 Dependencies" related table wasn't working because the primary key for
2147 related tables wasn't being set properly. This commit fixes the
2150 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2151 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2152 doesn't set the primary key properly for related list tables.
2153 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2154 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2155 useful for getting the primary key for list view tables and for related
2157 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2158 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2159 Move code to set the primary key for the table from the abstract
2160 ListDBAccess class to ListViewDBAccess as it's only correct for list
2162 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2163 Properly add primary key to related list tables.
2165 2011-12-02 Ben Konrath <ben@bagu.org>
2167 Properly set the horizontal alignment of fields.
2169 This fix is for both the list tables and the details view.
2171 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2172 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2173 to set the horizontal alignment of fields.
2175 2011-12-02 Ben Konrath <ben@bagu.org>
2177 Display currency codes in the details view.
2179 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2181 2011-12-02 Ben Konrath <ben@bagu.org>
2183 Avoid duplicate JNI call.
2185 JNI is not as efficient as pure Java and this is an easy (and small)
2188 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2189 Use previously retrieved value for whereClauseToTableName instead of
2192 2011-12-02 Ben Konrath <ben@bagu.org>
2194 Rename a couple of variables in RelatedListNavigation.
2196 This is a rename-only refactor.
2198 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2200 2011-12-02 Ben Konrath <ben@bagu.org>
2202 Indicate clearly that a mismatched primary key type is a bug.
2204 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2205 warning to error. Add 'This is a bug.' to message.
2207 2011-12-02 Ben Konrath <ben@bagu.org>
2209 Update / fix some comments.
2211 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2213 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2215 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2216 Fix comments. Add some TODOs.
2218 2011-12-02 Ben Konrath <ben@bagu.org>
2220 Enable navigation to details view with string primary key from related list.
2222 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2223 Create a text primary key value when return type of result is
2224 java.sql.Types.VARCHAR.
2226 2011-12-02 Ben Konrath <ben@bagu.org>
2228 Use checkboxes for booleans in the details view.
2230 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2232 2011-12-01 Ben Konrath <ben@bagu.org>
2234 Improve performance of related list height calculation.
2236 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2237 Put code to calculate the expected height in a static initializer so
2238 that that it's only called once.
2240 2011-12-01 Ben Konrath <ben@bagu.org>
2242 Show related list tables in notebooks (again).
2244 Calculate the height of the related list tables so the Notebook can be
2245 set the correct height. The height of the related list table is also needed by
2246 FlowTable to be able decide how to create the layout.
2248 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2249 and set the Portal height based on the height of the related list
2250 table and the Portal container.
2251 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2252 Add method to calculate the height of the related list tables.
2253 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2254 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2255 calculate the height of the Pager widget.
2257 2011-12-01 Ben Konrath <ben@bagu.org>
2259 Use CellTable API for table property instead of setting style on Element.
2261 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2263 2011-12-01 Ben Konrath <ben@bagu.org>
2265 Make ListViewTable and RelatedListTable a consistent height.
2267 The tables are now a consistent height regardless of the contents of
2268 the table. A hidden button is added to empty rows to ensure that the
2269 height of these rows will match the height of rows with data.
2271 A navigation button column is now added to every table. The width of
2272 the navigation column is set to 0px when a RelatedListTable shouldn't
2273 have navigation buttons. This maintains the a consistent row height in
2274 tables that don't show the navigation buttons.
2276 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2277 navigation column when not needed.
2278 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2279 arguments for navigation button to constructor of ListViewTable.
2280 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2281 hidden button for empty data rows.
2282 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2283 arguments for navigation button to constructor.
2284 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2285 create navigation buttons. Add hideNavigationButtons() method.
2286 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2287 arguments for navigation button to constructor.
2289 2011-12-01 Ben Konrath <ben@bagu.org>
2291 Use 'visibility: hidden' in Utils.getWidgetHeight().
2293 This is better choice because hidden elements are invisible, don't
2294 respond to events and are not part of the tab order. They will,
2295 however, take up space which is required to be able to calculate the
2296 height of the widget.
2298 * src/main/java/org/glom/web/client/Utils.java:
2300 2011-12-01 Ben Konrath <ben@bagu.org>
2302 Use Utils.getWidgetHeight() in FlowTable.
2304 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2306 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2308 2011-12-01 Ben Konrath <ben@bagu.org>
2310 Put the details css class name on the correct table column.
2312 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2314 2011-11-30 Ben Konrath <ben@bagu.org>
2316 Update for java-libglom API change.
2318 The getters and setters on FieldFormatting and NumericFormat were
2319 changed to remove the 'M'.
2321 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2323 2011-11-29 Ben Konrath <ben@bagu.org>
2325 Only allow RelatedListTables in Portals.
2327 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2329 2011-11-29 Ben Konrath <ben@bagu.org>
2331 Only create a contents panel for Portals when title is being set.
2333 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2335 2011-11-29 Ben Konrath <ben@bagu.org>
2337 Set TabLayoutPanel height based on calculated height its widgets.
2339 This is a potential fix for this bug:
2341 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2343 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2345 2011-11-29 Ben Konrath <ben@bagu.org>
2347 Align details field labels and data with the Open buttons.
2349 * src/main/webapp/style.css:
2351 2011-11-29 Ben Konrath <ben@bagu.org>
2353 Remove unnecessary <div> in the Notebook widget.
2355 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2356 method to get container FlowPanel (<div>).
2357 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2358 initWidget() method directly on the TabLayoutPanel widget instead of
2359 Group's container widget.
2361 2011-11-29 Ben Konrath <ben@bagu.org>
2363 Don't add group titles for Portals in Notebooks.
2365 This reverts the previous patch and fixes a bug I introduced with
2366 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2368 * src/main/java/org/glom/web/client/ui/details/Group.java:
2369 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2371 2011-11-28 Ben Konrath <ben@bagu.org>
2373 Remove unused boolean argument in Portal constructor.
2375 Just a code cleanup.
2377 * src/main/java/org/glom/web/client/ui/details/Group.java:
2378 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2380 2011-11-28 Ben Konrath <ben@bagu.org>
2382 Remove hack for glom 1.18 style glom files.
2384 * src/main/java/org/glom/web/client/ui/details/Group.java:
2385 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2386 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2388 2011-11-28 Ben Konrath <ben@bagu.org>
2390 Use Gda Value version of primary key to log result too large error.
2392 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2394 2011-11-28 Ben Konrath <ben@bagu.org>
2396 Don't use TypedDataItem.getText() for Unknown types from the URL.
2398 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2399 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2400 instead of getText().
2401 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2402 String field and getUnknown() method.
2404 2011-11-28 Ben Konrath <ben@bagu.org>
2406 Log an error message when the java-libglom .so is not present.
2408 The error message was being set in the exception but not logged.
2410 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2412 2011-11-28 Ben Konrath <ben@bagu.org>
2414 Ignore LayoutItem_CalendarPortals.
2416 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2417 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2419 2011-11-28 Ben Konrath <ben@bagu.org>
2421 Extract method for creating the LayoutItemPortal DTO.
2423 Just breaking the code up into smaller chunks.
2425 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2427 2011-11-28 Ben Konrath <ben@bagu.org>
2431 This should have been added with the refactor. Oops!
2433 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2435 2011-11-28 Ben Konrath <ben@bagu.org>
2437 Create primary key value from URL string using type from Glom document.
2439 See this bug, comments 19 - 25:
2441 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2443 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2444 create a TypeDataItem for the primary key here when loading from a
2445 URL. Show the same string for the primary key value as was received
2446 from the URL string (when loading from a URL).
2447 * src/main/java/org/glom/web/server/Utils.java: Update method for
2448 creating the Gda Value from the TypeDataItem to properly deal with
2449 creating a Gda Value based on the Glom document type for the primary
2450 key value string when loading from a URL.
2451 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2452 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2453 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2454 Update for changed method name.
2456 2011-11-27 Ben Konrath <ben@bagu.org>
2458 Rename PrimaryKeyItem to TypedDataItem.
2460 The name PrimaryKeyItem suggests what the class should be used for.
2461 TypedDataItem is a neutral name that describes the class better.
2463 This is a rename-only refactor.
2465 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2466 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2467 * src/main/java/org/glom/web/client/Utils.java:
2468 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2469 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2470 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2471 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2472 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2473 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2475 * src/main/java/org/glom/web/server/Utils.java:
2476 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2477 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2478 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2479 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2481 2011-11-25 Ben Konrath <ben@bagu.org>
2483 Improve Gda Value conversion from PrimaryKeyItem.
2485 The value from the PrimaryKeyItem is only used if its type match the
2486 type from the glom document.
2488 * src/main/java/org/glom/web/server/Utils.java:
2490 2011-11-25 Ben Konrath <ben@bagu.org>
2492 Manually check if the java-liblgom .so is visible to the JVM.
2494 It seems that Tomcat has problems when a static initializer throws an
2495 exception. This check is done before the first method call into
2496 java-libglom so that execution doesn't continue if the .so is not
2499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2501 2011-11-25 Ben Konrath <ben@bagu.org>
2503 Improve browser configuration error messages.
2507 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2509 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2510 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2511 getConfigurationErrorMessage() method.
2512 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2513 Get and display a specific configuration error message when no Glom
2514 documents are found.
2515 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2516 Implement getConfigurationErrorMessage() method. Surround configuration
2517 code in the init() method with a try/catch block. This allows the
2518 errors to be caught while keeping the servlet available to retrieve the
2519 configuration error message.
2521 2011-11-25 Ben Konrath <ben@bagu.org>
2523 Don't use Strings to hold primary key values.
2525 The primary key values are now held in a new data object
2526 (PrimaryKeyItem) that holds type information and the primary key value
2527 using the correct type.
2529 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2530 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2531 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2532 PrimaryKeyItem instead of String to hold the primary key value.
2533 * src/main/java/org/glom/web/client/Utils.java: Remove
2534 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2535 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2536 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2537 PrimaryKeyItem instead of String to hold the primary key value. Load
2538 document selection page when the documentID has not been set correctly.
2539 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2540 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2542 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2543 Return empty string for URL instead of "null".
2544 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2545 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2546 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2547 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2548 PrimaryKeyItem instead of String to hold primary key values.
2549 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2550 PrimaryKeyValue to a Gda Value.
2551 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2552 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2553 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2554 Replace temporary database access code that uses the PrimaryKeyValue to
2555 Gda Value conversion.
2556 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2557 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2558 PrimaryKeyItem instead of String.
2559 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2560 hold primary key values.
2562 2011-11-24 Ben Konrath <ben@bagu.org>
2564 Use newly added java-libglom API to create queries.
2566 This isn't finished. I still need to stop using Strings for primary key
2567 values in the client code.
2569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2570 libglom to use fake connections so that retrieving the query string will
2572 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2573 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2574 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2575 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2576 Use the newly added libglom sql methods and classes to create the
2577 query. Add temporary hack to convert primary value strings to Gda
2580 2011-11-23 Ben Konrath <ben@bagu.org>
2582 Don't explicitly set the height of Portals.
2584 See comments 6 - 10 of this bug for details:
2586 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2588 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2590 2011-11-23 Ben Konrath <ben@bagu.org>
2592 Use an HTML table instead of CSS for the FlowTable layout.
2594 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2595 GWT's FlexTable to implement the FlowTable.
2596 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2598 2011-11-18 Ben Konrath <ben@bagu.org>
2600 Add boolean example to HTML table mockup.
2602 * mockups/details-view-html-tables-text-entries.html:
2604 2011-11-17 Ben Konrath <ben@bagu.org>
2606 Ensure the pager buttons are always visible for related lists.
2608 To accomplish this, I've turned off text wrapping in the list view and
2609 related list tables for both the header and data text. The related list
2610 table now has a fixed layout so the it doesn't overflow its container.
2611 This is required to ensure that the cell text is clipped when it
2612 overflows the cell and an ellipsis is added to the right side of the
2613 cell when text is clipped.
2615 A fixed table layout for the related list table in the details view
2616 seems what we want for the details view anyway, so the side-effect is
2619 The ellipsis will only be displayed in Firefox >= 7.
2623 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2625 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2626 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2627 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2629 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2630 Set the 'table-layout: fixed' CSS property to the related list table.
2631 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2632 'white-space: nowrap;' CSS property on both the list view and the
2633 related list tables.
2635 2011-11-16 Ben Konrath <ben@bagu.org>
2637 Rework the fix for empty notebook tab labels.
2639 Setting the empty group titles with its name caused problems for the
2640 details layout. Instead of using libglom's
2641 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2642 to the client when the title is empty. This allows the Notebook to use
2643 the name when the title is empty without affecting anything else.
2645 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2646 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2648 2011-11-16 Ben Konrath <ben@bagu.org>
2650 Set group titles with name when title is empty.
2652 This fixes a problem with an empty notebook tab label in the Lesson
2653 Planner document. The forth tab in the notebook should be "Internet":
2655 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2657 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2658 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2661 2011-11-16 Ben Konrath <ben@bagu.org>
2663 Remove whitespace from the configured username properties.
2665 This assumes that usernames won't have whitespace at the beginning
2666 or end. But I think this is a reasonable assumption.
2668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2669 String.trim() to remove the whitespace from the username properties.
2671 2011-11-15 Ben Konrath <ben@bagu.org>
2673 Add details view mockup with HTML tables and text entries.
2675 This is from the attachment on this bug:
2677 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2679 * mockups/details-view-html-tables-text-entries.html:
2681 2011-11-15 Ben Konrath <ben@bagu.org>
2683 Add space between the columns of the flow table.
2687 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2689 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2690 space between columns in the flow table.
2692 2011-11-15 Ben Konrath <ben@bagu.org>
2694 Add backup files to the .gitignore.
2696 * .gitignore: Ignore files that end with ~.
2698 2011-11-09 Ben Konrath <ben@bagu.org>
2700 Use latest release of gwt-log.
2702 Gwt-log releases are now being submitted to the maven central
2703 repository so manual installation of the jar is no longer required.
2705 * pom.xml: Update version and groupId of gwt-log dependency.
2707 2011-10-31 Ben Konrath <ben@bagu.org>
2709 Don't use GWT numeric formatting to override the glom currency formatting.
2711 Currencies are now displayed like they are in Glom. See this bug:
2713 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2715 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2717 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2718 currency code to constructor and set it when the cell is rendered.
2719 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2720 currency code to the constructor of the NumericCell.
2722 2011-10-27 Ben Konrath <ben@bagu.org>
2724 Require the latest release of java-libglom (1.17.4).
2728 2011-10-26 Ben Konrath <ben@bagu.org>
2730 Add style to Notebook that matches current theme.
2732 It's not the best style in the world but it's better than the default.
2734 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2735 padding at the bottom of the child widgets.
2736 * src/main/webapp/style.css: Add style for the Notebook.
2738 2011-10-26 Ben Konrath <ben@bagu.org>
2740 Move servlet initialization code to overridden init method.
2742 This is half of the solution to getting proper error messages
2743 displayed when configuration errors occur. Here's the relevant bug:
2745 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2747 The rest of the solution involves surrounding the init method with a
2748 try/catch block and setting a global variable with the error /
2749 exception. A new async method should be created to retrieve and display
2750 the error message / exception.
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2753 code from constructor to init method adding exceptions as needed.
2755 2011-10-26 Ben Konrath <ben@bagu.org>
2757 Add script to monitor and restart tomcat if required.
2759 * utils/check-and-recover-tomcat.py: New file.
2761 2011-10-26 Ben Konrath <ben@bagu.org>
2763 Display the correct number of data items in the pager.
2767 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2769 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2770 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2771 The implementation is the same for both tables: Keep track of the
2772 number of non-empty rows and fire and RowCountChangeEvent after the data has
2774 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2775 custom Pager class that subclasses SimplePager to handle displaying
2776 the correct number when empty rows have been added.
2778 2011-10-26 Ben Konrath <ben@bagu.org>
2780 Correct error in previous commit.
2782 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2783 eventBus parameter from listView.setCellTable().
2785 2011-10-26 Ben Konrath <ben@bagu.org>
2787 Fix error in TODO comment.
2789 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2791 2011-10-24 Ben Konrath <ben@bagu.org>
2793 Create Notebook widgets to the details view.
2795 This isn't finished just yet - I still need to create a reasonable
2796 style to match the current theme.
2798 * src/main/java/org/glom/web/client/Utils.java: Add method for
2799 calculating the height of a widget. This is used in the Notebook class.
2800 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2801 new constructor method in Group.
2802 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2803 method for creating child widget that can be used by subclasses
2804 like Notebook. New constructor that allows disabling the group
2805 titles - Notebooks don't set a group title for their child groups.
2806 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2807 to make Notebooks using GWT's TabLayoutPanel.
2808 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2809 constructor that allows disabling the group titles.
2810 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2811 LayoutItemNotebook DTO.
2812 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2813 DTO for Notebooks. It's just an empty class for now but we might need
2814 it to transfer some specific information in the future.
2816 2011-10-21 Ben Konrath <ben@bagu.org>
2818 Add navigation buttons to related list tables.
2820 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2821 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2823 method getSuitableRecordToViewDetails() for getting the table name
2824 and primary key value for related list navigation buttons.
2825 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2826 private cell renderer class to get the navigation information for
2827 related list tables from the server. Extract the navigation
2828 processing code from the details cell navigation and use it for the
2829 related list navigation as well.
2830 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2831 cell renderer class for the details open buttons. This was needed
2832 because the related list navigation buttons and the list view
2833 navigation buttons need to react differently when clicked.
2834 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2835 the onEnterKeyDown() method because it's now overriden in the
2836 subclasses that are specific to the related list tables and the list
2838 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2839 the vertical size a little because the buttons add a bit of vertical
2840 space to table. This is not a perfect solution because the vertical
2841 size of with table fewer than 5 rows will be a little smaller.
2842 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2843 changes in how navigation buttons are handled.
2844 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2845 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2846 database access object.
2847 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2848 to find the portal for a given relationship name from
2849 RelatedListDBAccess. Add method to find a primary key field for a
2851 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2852 Move code to find the portal for a given relationship name to
2854 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2855 New file: database access object for getting the related list
2856 navigation information (the table name and the primary key value).
2857 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2858 DTO for transferring a table name to navigate to and a primary key
2860 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2861 boolean and getter/setter to specifies if the related list should add
2864 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2866 Use the master branch of java-libglom
2868 * pom.xml: Depend on java-libglom 1.19 instead.
2870 This is the master branch. See also the libglom-1-18 branch.
2872 2011-10-11 Ben Konrath <ben@bagu.org>
2874 Enable the open navigation button when the data has been set.
2876 This avoids having active buttons that don't do anything when the data
2879 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2881 2011-10-11 Ben Konrath <ben@bagu.org>
2883 Use IsWidget interface for FlowTableItem.
2885 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2886 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2888 2011-10-11 Ben Konrath <ben@bagu.org>
2890 Remove GWT styling from open button in details view.
2892 There are still some issues with how the details cell is arranged but
2893 this should be made to match Glom 1.20. I'm going to leave fixing this
2894 until I have Glom 1.20 up and running.
2896 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2897 style name on open button.
2898 * src/main/webapp/style.css: Move and edit details-navigation class.
2899 Re-arrange some classes to make them appear in the same order as the
2902 2011-10-07 Ben Konrath <ben@bagu.org>
2904 Update to GWT 2.4.0.
2906 * .gitignore: Ignore new cache directory.
2907 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2908 * pom.xml: Change GWT and maven plugin to 2.4.0.
2909 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2911 * src/main/java/org/glom/web/client/ClientFactory.java:
2912 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2913 * src/main/java/org/glom/web/client/OnlineGlom.java:
2914 Update source for API changes.
2915 * utils/build-onlineglom-war.sh: Remove cache directory before the
2918 2011-10-07 Ben Konrath <ben@bagu.org>
2920 Add navigation buttons in the details view.
2922 This isn't finished but I thought I'd commit what I have as it's a
2923 pretty good start. I still need to:
2925 1. Change the style so that it fits better into the current theme
2926 2. Adjust the details cell to expand as much as possible.
2928 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2929 click handlers to navigation buttons in the DetailsCells. Create a
2930 refreshData() method to get just the data from the server without the
2932 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2933 Update the tableSelector and browser title when the table name
2934 changes without using the tableSelector.
2935 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2936 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2937 getDetailsCells() to getCells(). Update variable names.
2938 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2939 method to set click handler on navigation button. Rename a few
2940 variables. Add navigation buttons where needed.
2941 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2942 variables and methods.
2943 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2944 navigation boolean and navigation table as required in the
2945 LayoutItemField DTO.
2946 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2947 variables for navigation along with getter/setter methods.
2949 2011-10-07 Ben Konrath <ben@bagu.org>
2951 Rename Field to DetailsCell.
2953 This is a refactor-only commit. No functionality has been added or
2956 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2957 Update variable and method names.
2958 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2959 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2960 variable and method names.
2961 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2963 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2964 variable and method names.
2966 2011-10-07 Ben Konrath <ben@bagu.org>
2968 Create separate methods for layout and data the details view.
2970 This is a refactor-only commit. No functionality has been added or
2973 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2974 private methods: setData(), createLayout().
2976 2011-10-07 Ben Konrath <ben@bagu.org>
2978 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2980 This is part of a change to get navigation buttons in the details view
2981 but it should have been done this way from the start.
2983 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2984 for method name change in TableSelectionView.
2985 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2986 Create TableChangeEvent and set the browser title using the
2987 TableSelectionView API.
2988 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2989 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2990 Change getSelectedTable() to getSelectedTableName(). Add
2991 getSelectedTableTitle().
2993 2011-10-07 Ben Konrath <ben@bagu.org>
2995 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2997 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2999 2011-10-07 Ben Konrath <ben@bagu.org>
3001 Update TableChangeEvent to use newTableName naming convention.
3003 This makes the class more consistent with GWT naming conventions.
3005 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3006 Update for method name change in TableChangeEvent.
3007 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3008 for method name change in TableChangeEvent.
3009 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3010 newTableName variable and getter method. Make toDebugString()
3013 2011-09-30 Ben Konrath <ben@bagu.org>
3015 Disable the pager in the list tables when the data row count is less than the minimum.
3017 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3018 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3020 2011-09-30 Ben Konrath <ben@bagu.org>
3022 Add empty rows to the end of related list and list view tables.
3024 I also extracted the cell rendering classes from the ListTable because
3025 the code was becoming a little crazy with all the anonymous inner
3026 classes. My plan is to use these cell rendering classes in the details
3027 view as well so this refactor will be needed for that change.
3029 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3030 set the row count in related list tables if the data has more rows
3031 than the minimum number of rows visible.
3032 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3033 row count in list view tables if the data has more rows than the
3034 minimum number of rows visible.
3035 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3036 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3038 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3039 for rendering TYPE_NUMERIC cells. The code was extracted from the
3041 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3042 class for rendering cells with buttons in list views. The code was
3043 extracted from the ListTable class.
3044 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3045 for rendering TYPE_TEXT cells. The code was extracted from the
3047 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3048 Add empty rows to the end of the data if required. Implement
3049 ListTable.getMinNumVisibleRows().
3050 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3051 cell renderer code to public classes. Return null in
3052 Column.getValue() for empty rows. Add new abstract method:
3053 getMinNumVisibleRows(). Move code to set the row count of the list view
3054 table to ListViewImpl.
3055 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3056 empty rows to the end of the data if required. Implement
3057 ListTable.getMinNumVisibleRows().
3060 2011-09-27 Ben Konrath <ben@bagu.org>
3062 Use GWT.log for client-side debugging statements.
3064 These are optimized out when deployed so I should have used this method
3065 in the first place. These statements will eventually be replaced with some sort
3066 of notification in the browser.
3068 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3069 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3070 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3071 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3072 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3074 2011-09-27 Ben Konrath <ben@bagu.org>
3076 Put tableselector on the right, back to list link on right.
3078 The idea is that the table selector is acting like a label for the
3079 currently displayed table so it should be placed below the document title. This
3080 puts the table title in a similar position to where it is in Glom.
3082 * mockups/details-contacts.html:
3083 * mockups/details-projects.html:
3084 * mockups/listview-contacts.html:
3085 * mockups/listview-projects.html:
3086 * mockups/style.css:
3087 Update mockups to match how the interfaces currently look.
3088 * src/main/webapp/style.css: Swap positions of backlink with the table
3089 selector. Add some space on the left side of the table selector to
3090 line things up with the document title.
3092 2011-09-27 Ben Konrath <ben@bagu.org>
3094 Add field colouring to details view.
3096 This change re-works how field colouring works. The colour formatting
3097 information is now set to the client with the layout information instead of
3098 with the data. This eliminates the need to send the same colour strings for
3099 data in list view column when colour information is set.
3101 In order to set an alternate colour for negative numeric values, the
3102 number is now sent to client and formatted with the GWT NumberFormat class.
3104 This change also fixes:
3106 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3108 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3109 internationalization framework which is needed for client side numeric
3111 * src/main/java/org/glom/web/client/Utils.java: New file for some
3112 client static utility methods.
3113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3114 the DataItem object to the Field class. Use a utility method to
3115 create the foreignKeyValue string.
3116 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3117 alignment and text colours in the constructor. Add setData(DataItem)
3118 method. Remove setText(String) method.
3119 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3120 colour information to GlomTextCell. Create and use GlomNumberCell for
3121 rendering numbers. Use utility method to get the string for the
3122 primary key of the key provider. Re-work how the horizontal alignment
3124 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3125 formatting to layout information. Methods for converting the libglom
3126 formatting information were moved from DBAccess.
3127 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3128 numeric formatting (it's now done on the client side). Don't set text
3129 colours in DataItem. Move libglom formatting conversion methods to
3131 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3132 getters/setters for text colour information.
3133 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3134 for transferring the libglom NumericFormat information to the client.
3135 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3136 and getters/setters for: GlomNumericFormat, background colour and
3137 foreground colour strings.
3139 2011-09-26 Ben Konrath <ben@bagu.org>
3141 Simplify code that iterates through the LayoutGroup.
3143 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3145 2011-09-26 Ben Konrath <ben@bagu.org>
3147 Accept Eclipse formatting for OnlineGlomServiceAsync.
3149 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3151 2011-09-26 Ben Konrath <ben@bagu.org>
3153 Don't use the ListDBAccess classes to get the primary key layout information.
3155 This was causing a bug where the wrong index for the hidden primary key
3156 was being sent to the client.
3158 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3159 primary key while creating the LayoutGroup DTO. Create a
3160 LayoutItemField DTO for hidden primary keys. Don't use the
3161 RelatedListDBAccess because it was only used for getting the primary
3163 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3164 access modifier from public to protected for getPrimaryKeyField() and
3165 getPrimaryKeyLayoutItemField().
3166 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3167 abstract method getExpectedResultSize() because RelatedListDBAccess
3168 doesn't have enough info to implement it.
3169 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3170 Remove @Override for getExpectedResultSize().
3171 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3172 Remove method getExpectedResultSize().
3174 2011-09-23 Ben Konrath <ben@bagu.org>
3176 Log which layout (list or details) the ignored item is from.
3178 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3180 2011-09-23 Ben Konrath <ben@bagu.org>
3182 Remove annotations that turn off code formatting in DataItem.
3184 * src/main/java/org/glom/web/shared/DataItem.java:
3186 2011-09-23 Ben Konrath <ben@bagu.org>
3188 Rename GlomField to DataItem and update associated methods.
3190 This is a rename-only refactor. No functionality has been added or
3193 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3194 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3196 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3197 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3198 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3199 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3200 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3202 * src/main/java/org/glom/web/server/database/DBAccess.java:
3203 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3204 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3205 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3206 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3207 * src/main/java/org/glom/web/shared/DataItem.java:
3208 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3209 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3211 2011-09-23 Ben Konrath <ben@bagu.org>
3213 Rename GlomDocument to DocumentInfo and update associated methods.
3215 This is a rename-only refactor. No functionality has been added or
3218 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3219 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3220 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3221 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3222 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3224 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3226 2011-09-20 Ben Konrath <ben@bagu.org>
3228 Require java-libglom 1.17.3.
3230 This picks up the fix for the seg fault problem with the Scenes table
3231 in the Openismus Film Manager example.
3235 2011-09-20 Ben Konrath <ben@bagu.org>
3237 Change the way sort clause is added for primary key when no sort clause is requested.
3239 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3240 before the sort clause is created. When a sort clause is not requested, the
3241 sort clause is created by finding the primary key in the LayoutFieldVector
3244 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3246 2011-09-20 Ben Konrath <ben@bagu.org>
3248 Log error message if no documents are found in the configured directory.
3250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3251 Extract the glom file extension string to a private static final class
3252 variable (mostly as syntactic sugar). Accept a minor formatting change.
3253 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3254 the example glom.document.directory configuration property to make it
3255 more clear that it can any directory, not just the home directory.
3257 2011-09-18 Ben Konrath <ben@bagu.org>
3259 Add related lists to details view.
3261 The related list table has support for paging and sorting just like the
3262 table in the list view.
3264 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3265 SQL queries for the related list tables.