1 2012-07-20 Murray Cumming <murrayc@murray.com>
3 tests: SelfHoster: createConnection(): Set a timeout.
5 * src/test/java/org/glom/web/server/SelfHoster.java:
6 createConnection(): Use setLoginTimeout() because it otherwise seems to take
7 ages to actually return when it fails.
9 2012-07-20 Murray Cumming <murrayc@murrayc.com>
11 tests: SelfHoster: selfHost(): Close the test connection.
13 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
14 When we check that the connection works, close the connection. This seems
15 to not be closed automatically otherwise.
17 2012-07-20 Murray Cumming <murrayc@murrayc.com>
19 Use slf4j-simple to see JDBC errors.
21 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
23 2012-07-19 Murray Cumming <murrayc@murrayc.com>
25 SelfHoster.discoverFirstFreePort(): Close the socket.
27 * src/test/java/org/glom/web/server/SelfHoster.java:
28 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
30 2012-07-19 Murray Cumming <murrayc@murrayc.com>
32 Avoid another code warning in Eclipse Juno.
34 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
35 Do instanceof checks on the FileUtils.listFiles() result and its
38 2012-07-13 Murray Cumming <murrayc@murrayc.com>
40 Avoid some code warnings in Eclipse Juno
42 * src/main/java/org/glom/web/server/libglom/Document.java:
43 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
44 * src/test/java/org/glom/web/server/SelfHoster.java
45 createTextFile(): Make sure that the FileOutputStream is closed.
47 2012-06-22 Murray Cumming <murrayc@murrayc.com>
49 Added OnlineGlomPropertiesTest.
51 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
52 Make sure we never return a null string.
53 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
54 Added tests of the OnlineGlomProperties API, using our sample file.
56 2012-06-20 Murray Cumming <murrayc@murrayc.com>
58 Make OnlineGlomProperties be a normal class.
60 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
61 Move OnlineGlomProperties into its own file to be a regular class:
62 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
63 This makes testing simpler.
65 2012-06-15 Murray Cumming <murrayc@murrayc.com>
67 OnlineGlomServiceImpl.init(): Move some code into a new method.
69 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
72 2012-06-15 Murray Cumming <murrayc@murrayc.com>
74 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
76 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
77 OnlineGlomProperties.getKey(): Make this more robust by moving the
78 check for *.*.filename to here.
80 2012-06-15 Murray Cumming <murrayc@murrayc.com>
82 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
84 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
85 init(): Move knowledge of the config file format into the
86 OnlineGlomProperties inner class.
88 2012-06-15 Murray Cumming <murrayc@murrayc.com>
90 SelfHostExampleTest: Make sure we cleanup on failure.
92 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
93 the use of cleanup() to a tearDown() JUnit method.
95 2012-06-12 Murray Cumming <murrayc@murrayc.com>
97 ConfiguredDocument: Add a primary key to portals at least once.
99 * src/main/java/org/glom/web/server/ConfiguredDocument.java
100 updatePortalsExtras): Fix a typo so that we add the primary key
101 column at least once.
102 This is a fix for the previous commit:
103 ConfiguredDocument: Do not add a primary key to portals each time.
105 2012-06-08 Murray Cumming <murrayc@murrayc.com>
107 SelfHoster: Avoid some compiler warnings.
109 * src/test/java/org/glom/web/server/SelfHoster.java
110 executeCommandLineAndWait():
111 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
112 the now-unused streams for stdout and stderr from the command Processes.
113 These are not used because readln() hangs while waiting for a new line,
114 where there may be no next line. The commented out code is still there
115 to help us figure out how to do this properly.
117 2012-06-08 Murray Cumming <murrayc@murrayc.com>
119 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
121 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
122 Make this actually test the cloning again, though it is not very useful
123 now that we do not use the part that had a problem with cloning before.
125 2012-06-08 Murray Cumming <murrayc@murrayc.com>
127 SelfHoster: Keep trying pg_ctl after starting postgres.
129 * src/test/java/org/glom/web/server/SelfHoster.java
130 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
131 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
132 regular Glom. This seems mad but it seems to work because the first
133 command would fail if pg_ctl would eventually fail.
135 2012-06-08 Murray Cumming <murrayc@murrayc.com>
137 SelfHoster: Wait until the server is really ready.
139 * src/test/java/org/glom/web/server/SelfHoster.java
140 selfHost(): Attempt the connection after starting the server, retrying
141 a few times if necessary, so that the server is really ready already when
142 we return from this method.
143 The regular Glom code does this too because pg_ctl reports success too soon.
145 2012-06-08 Murray Cumming <murrayc@murrayc.com>
147 ConfiguredDocument: Do not add a primary key to portals each time.
149 * src/main/java/org/glom/web/server/ConfiguredDocument.java
150 updatePortalsExtras(): Only add an extra primary key field if there is
151 none, to avoid adding one each time we retrieve the details layout from the
153 This should fix bug #676986 (Ben Konrath)
155 2012-05-25 Murray Cumming <murrayc@murrayc.com>
157 Document.load(): Support version 7 documents.
159 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
160 database_title attribute if the title attribute is not there.
163 2012-05-24 Ben Konrath <ben@bagu.org>
165 Add configuration for auto-generating mvn:i18n from with Eclipse.
167 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
169 2012-05-24 Murray Cumming <murrayc@murrayc.com>
171 Update translations, adding French.
173 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
174 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
175 Add a French translation, using the translation from Glom.
177 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
178 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
179 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
180 Update these based on the translations from Glom.
182 2012-05-24 Murray Cumming <murrayc@murrayc.com>
184 SelfHoster: Add some debug println messages to help when things fail.
186 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
187 System.out.println() lines.
189 2012-05-23 Murray Cumming <murrayc@murrayc.com>
191 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
193 * src/test/java/org/glom/web/server/SelfHoster.java:
194 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
195 instance) instead of just /usr/bin (as on Fedora). Check the result when
198 2012-05-23 Murray Cumming <murrayc@murrayc.com>
200 Remove LayoutItemPortal.get/setNavigationTable().
202 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
203 Remove get/setNavigationTable(), which is only a cache, because it is not
204 used, and does not need to be used, because that decision should be made on
206 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
207 updatePortalsExtras():
208 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
209 getNavigationRecord():
210 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
213 2012-05-21 Murray Cumming <murrayc@murrayc.com>
215 Initial self-hosting for tests.
217 * pom.xml: Change the scope for log4j, to hopefully make it
218 available to the test code which uses it indirectly via jOOQ.
219 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
220 self-hosting, though we only use it for testing.
222 * src/main/java/org/glom/web/server/libglom/Document.java:
223 example rows: Use a map instead of a list for each row of values,
224 so we know what field they are for, instead of relying on the sequence
225 being correct. This is not very efficient, but it does not really need
227 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
228 testReadTableExampleRows(): Adapted.
230 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
231 that returns an Object, for generic use. Note that Object seems to be
232 the implicit base even of double.
233 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
234 for use in CREATE TABLE SQL queries.
235 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
236 to do self-hosting of PostgreSQL databases via its command-line
237 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
238 backends/postgres_self.cc. This is incomplete - it needs more
239 warnings about failures and it needs to clean up properly when things
241 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
242 test of this new class.
244 2012-05-21 Murray Cumming <murrayc@murrayc.com>
246 Document: loading example data: Handle exceptions.
248 * src/main/java/org/glom/web/server/libglom/Document.java:
249 DateFormat.parse() and Double.valueOf() can throw exceptions, though
250 Eclipse did not warn about that.
252 2012-05-20 Murray Cumming <murrayc@murrayc.com>
254 Document: load(), save(): Handle the example rows.
256 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
258 * src/main/java/org/glom/web/server/libglom/Document.java:
259 load(), save(): Load and save the example rows, though the date, time
260 and image types are not handled properly yet.
261 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
262 Add testReadTableExampleRows() just to check that something is read.
264 2012-05-20 Murray Cumming <murrayc@murrayc.com>
266 Document: Add save().
268 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
269 Added getTranslationsMap() for use while saving.
270 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
271 Adedd getUseDefaultFormatting() for use while saving.
272 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
273 and several private methods that it uses.
275 This will be useful while testing via self-hosting.
276 It is not complete, but should be complete enough for testing.
278 2012-05-17 Murray Cumming <murrayc@murrayc.com>
280 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
282 * src/main/java/org/glom/web/client/OnlineGlomService.java
283 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
285 Remove getSortedListViewData() and getSortedRelatedListData(), adding
286 the sort column index and ascending bool to the regular method.
287 Instead, a sort column index of -1 now means no sort.
288 This is less explicit, but it's fairly simple, reduces the amount of
289 code, and makes the OnlineGlomService API slightly smaller.
290 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
291 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
293 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
294 getListViewData(), getRelatedListData():
295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
296 getListViewData(), getRelatedListData():
297 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
299 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
301 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
306 2012-05-16 Murray Cumming <murrayc@murrayc.com>
308 Use translations for top-level groups too.
310 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
311 updateTitlesForLocale(): Use the translation for the group
312 as well as for child items.
316 Just recompiled to fix a problem in the released .tar.gz file.
320 2012-05-15 Murray Cumming <murrayc@murrayc.com>
322 Corrections to navigation to related records.
324 * src/main/java/org/glom/web/client/OnlineGlomService.java:
325 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
327 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
328 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
329 relationship name, because the relationship name is not necessarily unique
331 TOOD: This is inefficient, because it passes the whole list of
332 child field items back to the server, but it is more correct, and happens
333 to fix a bug with the primary key being lost after a few navigations.
334 There is probably a chance to make this more efficient anyway in some
337 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
339 * src/main/java/org/glom/web/server/ConfiguredDocument.java
340 * src/main/java/org/glom/web/server/database/DBAccess.java
341 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
342 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
345 2012-05-15 Murray Cumming <murrayc@murrayc.com>
347 Fix the use of translations.
349 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
350 Add updateTitlesForLocale().
351 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
352 Call it to discard unwanted translations and to make getTitle() return
353 the wanted translation wihout the need for the client code to specify a locale.
354 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
355 getTitle(): Fallback to the original title, as libglom does.
357 2012-05-15 Murray Cumming <murrayc@murrayc.com>
359 Document: Correctly report the number of available translation locales.
361 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
362 the available locale IDs list.
363 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
364 testLocales: Test this.
366 2012-05-15 Murray Cumming <murrayc@murrayc.com>
368 SqlUtils: Use camelCase.
370 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
371 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
372 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
373 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
374 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
375 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
377 2012-05-15 Murray Cumming <murrayc@murrayc.com>
379 Use jOOQ's tableByName() and fieldByName.
381 * pom.xml: Use jOOQ 2.3.1 to get the new API.
382 * src/main/java/org/glom/web/server/SqlUtils.java:
383 build_sql_select_step_with_where_clause(), .createField(),
384 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
385 so we can get correct quoting and escaping. Thanks to Lukas Eder for
386 adding this, and other things, to jOOQ.
388 2012-05-15 Murray Cumming <murrayc@murrayc.com>
390 SqlUtils: Remove the Connection parameters.
392 * src/main/java/org/glom/web/server/SqlUtils.java:
393 build_sql_select_with_key(), build_sql_select_with_where_clause(),
394 createSelect(), build_sql_select_step_with_where_clause(),
395 build_sql_count_select_with_where_clause(),
396 build_sql_select_count_rows(): Remove the Connection parameter because
397 jOOQ does not actually need a connectionwhen it is just used to build
399 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
401 * src/main/java/org/glom/web/server/ReportGenerator.java:
403 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
405 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
406 Constructor, getListData(), getResultSizeOfSQLQuery():
407 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
408 getSelectQuery(), getCountQuery():
409 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
410 getSelectQuery(), getCountQuery():
411 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
412 getNavigationRecord(): Adapted.
414 2012-05-14 Murray Cumming <murrayc@murrayc.com>
418 * src/main/java/org/glom/web/server/SqlUtils.java:
419 get_find_where_clause_quick(): Use a comparison of
420 lowercase values, instead of a simple equals. Regular Glom
421 uses the PostgreSQL ILIKE operator but jOOQ does not
422 support that just yet, though it will soon.
424 2012-05-14 Murray Cumming <murrayc@murrayc.com>
426 TableToViewDetails: Use a real serialization ID.
428 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
429 Though this does not fix the serialization problem.
431 2012-05-12 Murray Cumming <murrayc@murrayc.com>
433 Added LayoutItemPortalDeepCloneTest.
435 2012-05-11 Murray Cumming <murrayc@murrayc.com>
437 Make navigation work again.
439 * src/main/java/org/glom/web/server/libglom/Document.java:
440 Add getLayoutItemFieldShouldHaveNavigation().
441 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
442 Replace get/setAddNavigation() with the partly-existing
443 get/setNavigationTableName(), with an empty string being no navigation,
444 because this is simpler. Use the new
445 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
447 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
448 Add updateFieldsExtras() and call setNavigationTableName in it.
449 getDetailsLayoutGroup(),
450 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
451 createLayout(): Adapted.
452 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
453 Constructor: Adapted.
455 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
456 Replace get/setAddNavigation() with get/setNavigation(), returning a
457 TableToViewDetails class with both the table name and UsesRelationship,
458 because both are need. The previous code used java-libglom's output
459 variable (strangely, via sharedptr) to return both, but we cannot really
461 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
462 getNavigationRecord(): Adapt. However, we cannot actually use the cache
463 here because it somehow gets set to null during deepCopy(). I must test this.
464 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
465 testGetSuitableTableToViewDetails(): Adapted.
467 TODO: Find out why deepClone() is not quite working.
469 2012-05-11 Murray Cumming <murrayc@murrayc.com>
471 DBAccess: Simplify the retrievel of full field details.
473 * src/main/java/org/glom/web/server/database/DBAccess.java
474 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
475 because the Document loading should have done this.
477 2012-05-11 Murray Cumming <murrayc@murrayc.com>
479 Document: Correct loading of doubly-related layout fields.
481 * src/main/java/org/glom/web/server/libglom/Document.java:
482 loadUsesRelationship(): Actually set the related relationship, instead
483 of only setting it if it's not found.
485 2012-05-09 Murray Cumming <murrayc@murrayc.com>
487 Replace all appearances of Colour with color.
489 Because US English is dominant.
491 2012-05-09 Murray Cumming <murrayc@murrayc.com>
493 Use colors in HTML format, solving a warning about an unused function.
495 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
496 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
497 Add *asHTMLColor() versions of methods.
498 TODO: However, we should create and cache the results on the server.
499 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
500 * src/main/java/org/glom/web/client/ui/list/ListTable.java
501 * src/main/java/org/glom/web/server/ConfiguredDocument.java
502 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
503 Use the asHTMLcolor() versions.
505 2012-05-09 Murray Cumming <murrayc@murrayc.com>
507 ListViewTable: Constructor: Take the table name as a parameter.
509 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
510 Constructor: Take the tableName, and set the member variable, because
512 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
513 setCellTable(): Pass the table name.
514 This makes navigation to non-default tables work again. I don't know
515 why it worked before in the master branch.
517 2012-05-07 Murray Cumming <murrayc@murrayc.com>
519 ConfiguredDocument: Restore correct addition of hidden primary key items.
521 * src/main/java/org/glom/web/client/ui/list/ListTable.java
522 (ListTable.createCellTable): Uncomment out the check for the hidden
524 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
525 add primary key items for top-level lists and portals, as before,
526 instead of adding them to each group.
527 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
528 Actually implement the extra methods such as setHiddenPrimaryKey() and
529 comment that these are used only for top-level list groups and in portals.
530 This strangeness suggests even more that this should not be squeezed
531 into the LayoutGroup class.
533 2012-05-07 Murray Cumming <murrayc@murrayc.com>
535 Fix Formatting loading.
537 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
538 getFormattingUsed(): Remove the duplicate Formatting member variable
539 in favour of the one from the base class.
540 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
541 Initialize a new Formatting instead of using null by default, so we
542 have some defaults, instead of having to initialize one later just to
543 get the same defaults. This also makes loading of formatting from the
544 document work, because that expected a non-null.
546 2012-05-07 Murray Cumming <murrayc@murrayc.com>
548 RelatedListTable: Make sure that the tableName is set.
550 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
551 Constructor: Take the tableName so it is available later. Otherwise,
552 the server assumes that we mean the default table and cannot find the
554 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
555 setData(): Pass the tableName to the RelatedListTable constructor.
557 2012-05-07 Murray Cumming <murrayc@murrayc.com>
561 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
562 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
563 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
565 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
567 * src/main/java/org/glom/web/server/database/DBAccess.java:
568 convertResultSetToDTO(), getPortal():
569 * src/main/java/org/glom/web/server/database/ListDBAccess.java
571 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
572 Add checks for null objects and out of range access, with log messages to
573 give hints so we can fix these properly.
575 2012-05-07 Murray Cumming <murrayc@murrayc.com>
577 Portals: some corrections.
579 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
581 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
582 constructor: Use getRelationshipNameUsed() instead of getName(), because
583 that is what is meant.
584 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
585 getFromField(): Fix a typo, to get the field name, not the table name.
586 * src/main/java/org/glom/web/server/database/DBAccess.java:
587 getPortal(): Fix a typo that stopped this from working.
589 2012-05-07 Murray Cumming <murrayc@murrayc.com>
591 LayoutItemPortal: Also override getTitleOriginal().
593 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
594 This lets the base getTitle() with no parameters work.
595 TODO: Test this properly.
597 2012-05-06 Murray Cumming <murrayc@murrayc.com>
599 LayoutItemPortal: getTitle*(): Use the relationship title.
601 2012-05-06 Murray Cumming <murrayc@murrayc.com>
603 LayoutItemField: Fix loading of custom titles.
605 * src/main/java/org/glom/web/server/libglom/Document.java
606 loadDataLayoutItemField(): The title, if any, instead of the field
607 title, is stored in a title_custom node. Load it from there.
608 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
610 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
611 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
612 getTitle*() overrides.
613 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
616 2012-05-06 Murray Cumming <murrayc@murrayc.com>
618 LayoutItemField: Fall back to field titles, so some are really shown.
620 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
621 Override getTitleOriginal() and getTitle(), as in java-libglom.
622 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
625 2012-05-06 Murray Cumming <murrayc@murrayc.com>
627 Correct use of setExpectedResultSize().
629 * src/main/java/org/glom/web/server/ConfiguredDocument.java
630 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
631 Use setExpectedResultSize only on top-level groups (for instance, the
632 list layout) or on child portals (in details views).
633 Use the correct table name for portals to avoid SQL errors.
634 Update the expected counts when returning cached layouts.
636 2012-05-06 Murray Cumming <murrayc@murrayc.com>
638 Document: Interpret no group column count as 1.
640 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
641 default, though we now check for this in the UI code anyway.
643 2012-05-06 Murray Cumming <murrayc@murrayc.com>
647 2012-05-06 Murray Cumming <murrayc@murrayc.com>
649 Translatable: Use Hashmap instead of Treemap because GWT supports it.
651 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
652 The use of Treemap lead to this error from async methods, with no
654 "The response could not be deserialized"
656 2012-05-06 Murray Cumming <murrayc@murrayc.com>
658 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
660 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
661 when using the Google -> GWT Compile, or
662 g toolbar button -> GWT Compile Project... feature in Eclipse.
664 2012-05-06 Murray Cumming <murrayc@murrayc.com>
666 ListTable.addColumn(): Protect against a null Formatting.
668 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
669 Create a default Formatting if it is null, because that is the simplest
672 2012-05-06 Murray Cumming <murrayc@murrayc.com>
674 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
676 * src/main/java/org/glom/web/server/ConfiguredDocument.java
677 updateLayoutGroup(): Check that the field is not null.
679 2012-05-06 Murray Cumming <murrayc@murrayc.com>
681 ListViewImpl: Protected against a bad cast error.
683 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
684 onEnterKeyDown(): Do not cast without an instanceof check.
686 2012-05-06 Murray Cumming <murrayc@murrayc.com>
688 ListTable: Protect against an out of range error.
690 * src/main/java/org/glom/web/client/ui/list/ListTable.java
691 createCellTable(): This is unlikely, but can happen while debugging.
693 2012-05-06 Murray Cumming <murrayc@murrayc.com>
695 AsyncMessage onFailure() callbacks: Log the exception message.
697 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
698 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
699 * src/main/java/org/glom/web/client/activity/ListActivity.java:
700 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
701 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
702 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
703 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
704 These are useful clues when something is wrong.
706 2012-05-06 Murray Cumming <murrayc@murrayc.com>
708 ConfiguredDocument: Avoid a null dereference.
710 * src/main/java/org/glom/web/server/ConfiguredDocument.java
711 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
712 details maps are created.
714 2012-05-06 Murray Cumming <murrayc@murrayc.com>
716 Document: Correct the port number parsing.
718 * src/main/java/org/glom/web/server/libglom/Document.java:
719 This lets us actually connect to the database and show the document.
721 2012-05-05 Murray Cumming <murrayc@murrayc.com>
725 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
726 user-interaction, asking us to load a temporary URL in a browser.s
727 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
728 which is apparently necessary for testing the service. See the comment.
729 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
730 Show the exception, if any. This is how I saw the 404 in the HTML in
733 2012-05-05 Murray Cumming <murrayc@murrayc.com>
735 DocumentTest: Move the .glom files into the resources directory.
737 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
738 URI via getResource().
740 2012-05-05 Murray Cumming <murrayc@murrayc.com>
742 Document: Remove the FieldIdentifies inner class.
744 * src/main/java/org/glom/web/server/libglom/Document.java: We only
745 use the Relationship (though the same function in libglom is maybe
746 used in other ways) and so this removes a compiler warning.
748 2012-05-05 Murray Cumming <murrayc@murrayc.com>
750 Document.load() Remove the error code parameter.
752 * src/main/java/org/glom/web/server/libglom/Document.java: load():
753 Remove the parameter. We do not set it yet and it could never have
754 worked as an output parameter (though maybe it did in java-libglom).
755 We could use an exception if we really want the failure reason.
756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
758 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
759 setUp(), testGetSuitableTableToViewDetails(): Adapt.
761 2012-05-05 Murray Cumming <murrayc@murrayc.com>
763 Make some inner classes static.
765 * src/main/java/org/glom/web/server/ConfiguredDocument.java
766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
767 * src/main/java/org/glom/web/server/ReportGenerator.java
768 * src/main/java/org/glom/web/server/libglom/Document.java
769 Make all inner classes static that can be static.
771 2012-05-05 Murray Cumming <murrayc@murrayc.com>
773 OnlineGlomServiceImpl: Do not load and check for java-libglom.
775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
776 init(): We do not use java-libglom any more.
778 2012-05-05 Murray Cumming <murrayc@murrayc.com>
780 Remove mentions of java-libglom.
782 * README: Remove mention of java-libglom, because it no longer needed.
783 * utils/build-onlineglom-war.sh:
784 * utils/check-and-recover-tomcat.py:
785 * utils/install-onlineglom-war.sh: Remove these as they are no longer
786 useful. Building is now far easier, with no need for jhbuild.
788 2012-05-05 Murray Cumming <murrayc@murrayc.com>
790 Fix the build (mvn package)
792 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
793 (LayoutGroup): Make the LayoutItemList inner class static and protected.
794 Otherwise the GWT Java->Javascript compilation fails with just this
795 error, during mvn package or when attempting to view in a browser,
796 in the GWT developer mode in Eclipse.
798 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
799 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
800 [INFO] Compiling module org.glom.web.OnlineGlom
801 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
802 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
803 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
804 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
805 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
806 [INFO] [ERROR] Cannot proceed due to previous errors
808 It has taken me 2 days to find out what was causing that. After reducing
809 the code, the compiler eventually showed me the full error message.
811 2012-05-04 Murray Cumming <murrayc@murrayc.com>
813 ConfiguredDocument: Cache the cloned and stripped layouts.
815 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
816 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
817 layout in a map, so we can retrieve it again without rebuilding it.
819 2012-05-04 Murray Cumming <murrayc@murrayc.com>
821 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
823 2012-05-04 Murray Cumming <murrayc@murrayc.com>
825 libglom classes: Implement some auto-generated emthods.
827 2012-05-04 Murray Cumming <murrayc@murrayc.com>
829 Add GwtTestOnlineGlomService.
831 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
832 However, this (and the other GwtTest*) does not seem to run during
835 2012-05-04 Murray Cumming <murrayc@murrayc.com>
837 Remove use of unsupported features from client code.
839 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
840 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
841 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
842 Use our client version of StringUtils instead of the apache commons one.
844 However, the GWT Javascript compliation still fails.
846 2012-04-25 Murray Cumming <murrayc@murrayc.com>
848 Add a Field class and implement some loading of it in Document.
850 2012-04-25 Murray Cumming <murrayc@murrayc.com>
852 Initial Document loading implementation, instead of libglom.
854 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
855 and Translatable classes, and adapt the rest of the code to use them.
856 However, this is still missing Layout and Field classes and loading.
858 2012-04-24 Murray Cumming <murrayc@murrayc.com>
860 Use of jOOQ: Move Field creation into a utility method.
862 * src/main/java/org/glom/web/server/SqlUtils.java:
863 This lets us improve it more easily.
865 2012-04-24 Murray Cumming <murrayc@murrayc.com>
867 Use of jOOQ: Improve the code to COUNT a sub-select.
869 * src/main/java/org/glom/web/server/SqlUtils.java:
870 Move initial query creation into
871 build_sql_select_step_with_where_clause().
872 build_sql_select_count_rows(): Use the jOOQ API instead of
873 concatentating text, because a jOOQ Select*Step is a TableLike,
874 which is what from() takes.
876 2012-04-23 Murray Cumming <murrayc@murrayc.com>
878 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
880 * pom.xml: Depend on jooq.
881 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
882 methods with jOOQ, based on the C++ implementations in libglom,
883 with some changes to the logic required by jooQ.
884 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
886 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
887 * src/main/java/org/glom/web/server/ReportGenerator.java:
888 * src/main/java/org/glom/web/server/SqlUtils.java:
889 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
890 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
891 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
892 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
893 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
894 Adapt. In particular, the SqlUtils methods now need to take a Connection,
895 because jOOQ needs that, though it seems unnecessary.
897 This is not quite finished. Ideally jOOQ would help us to build
898 table_name.field_name names, quoting and escaping them properly.
899 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
901 2012-04-21 Murray Cumming <murrayc@murrayc.com>
903 Move use of Glom.build_sql*() into a new SqlUtils class.
905 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
906 to wrap Glom.build_sql*(). The parameter types are still Glom one,
907 but this will make it easier to start using something other than
908 libglom or SqlBuilder.
910 2012-04-21 Murray Cumming <murrayc@murrayc.com>
912 Update the project URL.
914 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
916 2012-04-21 Murray Cumming <murrayc@murrayc.com>
918 Main layout: Use a FlowTable instead of absolute positioning.
920 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
921 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
922 child panels/widgets must have an absolute position. But that is annoying, so
923 this adds a FlowTable and puts the child panels in there.
925 2012-04-21 Murray Cumming <murrayc@murrayc.com>
927 GwtTestOnlineGlom: Comment out unused code.
929 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
930 Eclipse has started to say that some code is unused.
932 2012-04-21 Murray Cumming <murrayc@murrayc.com>
934 Update to the latest versions of dependencies.
936 * pom.xml: Update version numbers of dependencies to the latest
938 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
940 * src/main/java/org/glom/web/server/ReportGenerator.java:
941 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
942 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
943 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
945 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
946 Modify the imports where necessary.
948 2012-04-17 Murray Cumming <murrayc@murrayc.com>
950 Style: Remove overflow:hidden from searchbox
952 * src/main/webapp/style.css: Because this pushes the Back To Link
953 label/link on to the next row, which is then hidden due to the
954 hard-coded (in ems) height.
956 2012-04-20 Murray Cumming <murrayc@murrayc.com>
958 Remove some duplicate code.
960 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
961 getDocumentInfo(): This must have been duplicated during the merge from the
966 2012-04-19 Murray Cumming <murrayc@murrayc.com>
968 Reports: Localize the waiting for report message.
970 * src/main/java/org/glom/web/client/activity/ReportActivity.java
971 start(): Get the message from the contants.
972 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
974 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
975 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
976 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
977 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
978 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
979 Update these files with the English text for newer strings for now.
981 2012-04-19 Murray Cumming <murrayc@murrayc.com>
983 Reports: Show a message while waiting for the report.
985 * src/main/java/org/glom/web/client/ui/ReportView.java
986 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
987 Add setWaitingText(), to show a message saying that we are
988 waiting for the report to be ready.
989 * src/main/java/org/glom/web/client/activity/ReportActivity.java
990 start(): Call setWaitingText() before calling the async
993 2012-04-19 Murray Cumming <murrayc@murrayc.com>
995 ReportGenerator: Specify date and time formats.
997 * src/main/java/org/glom/web/server/ReportGenerator.java:
998 createFieldValueElement(): Use the default (and localized)
999 short formats, though we still need a way to show 4-digit
1000 years without providing the format for every locale.
1001 * src/main/java/org/glom/web/server/database/DBAccess.java:
1002 convertResultSetToDTO(): Use the short formats here too.
1004 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1006 ReportGenerator: Use the correct numeric formatting.
1008 * src/main/java/org/glom/web/server/ReportGenerator.java
1009 createFieldExpression(), createFieldValueElement(): Take the
1010 whole LayoutItem_Field instead of just the field name, so
1011 we have access to the formatting.
1012 createFieldValueElement(): Use JRTextField.setPattern() to
1013 specify the numeric formatting, with the help of a
1014 regular DecimalFormat.
1016 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1018 ReportGenerator: Avoid showing null for group by titles.
1020 * src/main/java/org/glom/web/server/ReportGenerator.java
1021 generateReport(): Use setBlankWhenNull() on the field title
1022 style too, because this is used for values in group by
1025 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1027 ReportGenerator: Add a colon to titles in vertical groups.
1029 * src/main/java/org/glom/web/server/ReportGenerator.java
1030 addFieldToDetailBandVertical(): Pass true for the withColon
1033 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1035 ReportGenerator: Simplify the code by using Position more.
1037 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1039 Reports: Support vertical groups, roughly.
1041 * src/main/java/org/glom/web/server/ReportGenerator.java:
1042 addToReport(): Rename to addGroupToReport() and, if necessary,
1043 call the new addVerticalGroupToReport() method.
1044 createFieldValueElement(): Let the caller specify the Y position
1047 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1049 Reports: Allow a second report to be shown.
1051 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1052 clear(): Do not remove the HTML widget, which broke the whole layout.
1054 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1056 Locales drop-down: Show that we use English by default.
1058 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1059 fillView(): When we use English, just because that is the default, when
1060 no locale is specified, show that in the Locales drop-down instead of
1061 just showing the first item.
1063 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1065 Unselect the Report/Locale/Table combo item when appropriate.
1067 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1068 setPlace(): clear reportName if this is not a ReportPlace.
1069 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1070 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1071 When the provided name is empty, unselect all items, so that none are
1072 indicated. This uses a for loop because I cannot find a single method
1075 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1077 Report: Give the user a way to get back to the list.
1079 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1080 start(), setPlace(): Show the Back To List link on reports, and also
1081 interpret selecting the empty report item as back to list.
1083 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1085 Really show the selected Report name.
1087 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1088 setPlace(): Store the reportName here, if it is that kind of Place.
1089 fillView(): Set the selected Report after filling the list of reports.
1090 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1091 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1092 null Strings, though we need some way to unselect all ListBox items
1095 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1097 ReportGenerator: Try to avoid some problems.
1099 * src/main/java/org/glom/web/server/ReportGenerator.java
1100 addField(): Try to avoid duplicates, and avoid using a null
1103 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1105 Reports: Use quickFind.
1107 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1108 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1110 getReportHTML(): Add a quickFind parameter.
1111 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1112 start(): Pass the quickFind parameter.
1113 * src/main/java/org/glom/web/server/ReportGenerator.java
1114 generateReport(): Take a quickFind parameter.
1116 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1118 ReportPlace: Actually use the report name.
1120 * src/main/java/org/glom/web/client/place/ReportPlace.java
1121 getPlace(): Do not assign the report name to the quickfind.
1123 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1125 Show java.library.path when complaining.
1127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1128 init(): When telling us to check java.library.path, show the
1131 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1133 ReportGenerator: Do not show nulls.
1135 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1137 ReportGenerator: Make the title font larger.
1139 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1141 ReportGenerator: Put field titles inside groups, if there are groups.
1143 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1145 ReportGenerator: Take the Report itself instead of the name and group.
1147 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1148 Remove getReportLayoutGroup().
1149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1150 getReportHTML(): Pass the report instead
1151 of its name and layout group.
1152 * src/main/java/org/glom/web/server/ReportGenerator.java
1153 generateReport(): Use the report object to use the title
1154 instead of the name.
1156 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1158 ReportGenerator: Remove designBand parameters.
1160 * src/main/java/org/glom/web/server/ReportGenerator.java:
1161 Make designBand a class member instead of passing it to all
1164 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1166 ReportGenerator: Add lines, a bit like in the desktop version.
1168 * src/main/java/org/glom/web/server/ReportGenerator.java
1169 addToReport(): Use JRDesignLine.
1171 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1173 ReportGenerator: Correct the title positions and use some bold style.
1175 * src/main/java/org/glom/web/server/ReportGenerator.java:
1176 Break the code up into reusable functions, correct the placement of
1177 titles, and use normal/bold styles as in the reports in the desktop
1180 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1182 ReportGenerator: Add a header band to show the field titles.
1184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1185 getReportHTML(): Pass the localeId to the ReportGenerator
1187 * src/main/java/org/glom/web/server/ReportGenerator.java
1188 constructor: Take the localeID so we can get translated field
1190 generateReport(), addToReport(), addFieldToBand(): Add field
1191 titles in a column header band.
1193 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1195 Reports drop-down list: Some improvement.
1197 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1198 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1199 Adedd setSelectedReport(),
1200 setReportList(): Add a blank line so that the user can select the
1202 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1203 start(): Show the current report by calling setSelectedReport().
1204 This does not seem to work yet.
1206 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1208 DetailsActivity, ListActivity: Move some variables into a base class.
1210 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1211 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1212 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1213 the clientFactory, documentID, tableName and authenticationPopup into
1214 a base class, to avoid duplication.
1216 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1218 Translate the Reports label.
1220 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1221 Get the "Reports" label string from the constants.
1222 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1223 perties: Add Reports to the constants.
1225 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1227 Reports: Implement grouping.
1229 * src/main/java/org/glom/web/server/ReportGenerator.java:
1230 Handle LayoutItem_GroupBy items and try to do the right thing
1231 with JRDesignGroup. It seems to work.
1233 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1235 Actually show some data with JasperReports.
1237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1238 getReportHTML(): Move most code into a ReportGenerator class.
1239 * src/main/java/org/glom/web/server/ReportGenerator.java:
1240 Recurse into sub-groups, adding fields to the JasperDesign's details
1241 band. Note that we must set an arbitrary width and height, or it just
1242 will not show any data.
1244 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1246 Reports Chooser: Show the titles, not the names.
1248 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1249 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1250 and the names as the values.
1251 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1252 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1253 group now that we provide the report name, so it should always
1256 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1258 Depend on jasperreports.
1260 * pom.xml: Add the dependency. My plan is to use this on the
1263 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1265 Implement navigation to report places.
1267 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1268 start(): Do not bother to handle all events here.
1269 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1270 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1271 Added getSelectedReport().
1272 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1273 .java: start(): When handling a change to the reports chooser,
1274 call getSelectedReport() and goTo() its ReportPlace.
1275 * src/main/java/org/glom/web/client/ui/ReportView.java
1276 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1277 Added setReportHTML() which puts the html in a gwt HTML widget.
1278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1279 getReportHTML(): Return "TODO" just to show that this works.
1281 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1283 Make ReportPlace usable.
1285 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1286 Mention ReportPlace.
1287 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1288 Correct the @prefix annotation.
1290 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1292 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1294 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1295 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1297 Change getReportLayout() to getReportHMTL() because we will not need to
1298 parse or render the report layout on the client side.
1299 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1300 getReportLayout(): Return the libglom LayoutGroup type because we will
1301 not need to convert to a shared type, because this will not be used on
1303 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1306 Note that there is still no implementation for this.
1309 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1311 Add a (empty) Report Place, View, and Activity.
1313 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1315 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1316 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1317 this into a superclass:
1318 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1319 and also use it as the base of this new ReportPlace:
1320 * src/main/java/org/glom/web/client/place/ReportPlace.java
1322 * src/main/java/org/glom/web/client/ui/ReportView.java
1323 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1324 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1325 Add these, containing mostly boiler-plate for now.
1327 * src/main/java/org/glom/web/client/OnlineGlomService.java
1328 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1329 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1330 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1331 Add API to get the LayoutGroup for the report.
1333 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1335 Add and fill a Reports drop-down list box.
1337 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1339 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1340 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1342 Added getReports(document, table, localeID), calling
1343 ConfiguredDocument.getReports().
1344 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1345 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1346 Added setReportsList() and a list widget.
1347 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1348 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1353 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1355 Translations: Add Esperanto.
1357 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1358 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1359 properties: Add this translation because someone took the time to make it.
1361 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1363 Adapt to the java-libglom 1.21.7 API.
1365 * src/main/java/org/glom/web/server/ReportGenerator.java:
1366 addToReport(): get_group_secondary_fields() is now
1367 get_secondary_fields().
1370 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1372 Use the latest java-libglom version.
1374 * pom.xml: Use java-libglom 1.21.7.
1376 2012-03-03 Ben Konrath <ben@bagu.org>
1378 Display date and time in details view.
1380 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1382 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1384 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1386 Require the latest java-libglom.
1388 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1390 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1392 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1394 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1395 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1396 an empty quickfind string. I also corrected libglom to create only
1397 empty where clauses for empty quickfind strings, but this avoids the
1400 2012-02-24 Ben Konrath <ben@bagu.org>
1402 Improve the tabs in the Notebook widget.
1406 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1408 Translations: Try to translate the strings.
1410 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1411 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1412 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1413 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1414 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1415 Take the Open translation from GTK+'s .po files.
1416 Take the Details translation from Glom's po files.
1417 I have added the other strings to Glom so we can get translations that way:
1418 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1420 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1422 TableSelectionViewImpl: Put the search label and entry in a div.
1424 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1425 Put the search widgets in a FlowTable so that the CSS can be used to
1426 style them while keeping them together.
1427 * src/main/webapp/style.css: Mention the new div.
1429 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1431 Translate more strings in more locales.
1433 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1434 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1435 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1436 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1437 Translate the "Details" and "Open" string too.
1439 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1440 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1441 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1442 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1443 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1444 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1445 Add these new locales as placeholders though they currently contain English.
1447 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1449 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1452 Check the ConfiguredDocument* for null before using it.
1454 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1456 Tell Eclipse about the generated java files.
1458 * .classpath: This lets it find OnlineGlomConstants.java.
1459 It would be nice if Eclipse just used the maven build files.
1461 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1463 Prevent a crash when no locale is specified in the URL.
1465 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1466 Avoid returning a null string, obtained from
1467 Window.Location.getParameter(). This caused a crash when it was
1468 later passed to libglom's API.
1469 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1470 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1471 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1472 guard against future null strings.
1474 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1476 Use the ?locale= query param instead of the &lang= token param.
1478 * src/main/java/org/glom/web/client/place/ListPlace.java
1479 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1480 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1481 Remove the lang token key and value.
1483 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1484 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1485 When the user selects a different locale from the chooser, use
1486 Window.Location.assign() to change the URL, which then causes a reload.
1488 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1489 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1490 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1491 * src/main/java/org/glom/web/client/activity/ListActivity.java
1492 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1493 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1494 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1495 * src/main/java/org/glom/web/client/ui/ListView.java:
1496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1498 Remove localeID member variables and method/constructor parameters, instead
1499 using Utils.getCurrentLocaleID() when we need a localID to pass to
1502 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1504 Internationalize the UI strings.
1506 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1507 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1508 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1509 because it is unused. Messages are apparently strings that can have
1510 parameters, but we do not need that yet, so Contants will be enough for now.
1511 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1512 to say that we support the en and de locales.
1513 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1514 The original English strings.
1515 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1516 Some German translations of the English strings.
1517 The i18n goal then uses the .properties file to generate an
1518 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1519 returns an implementation that returns the translated strings.
1520 The documentation suggests putting these in src/java/*/client/, but it seems
1521 best to put it in src/resources/*/client/.
1522 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1523 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1524 instead of hard-coding them.
1525 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1526 but that does not seem to stop the build, though it confuses Eclipse.
1528 You can see the translated string by adding ?locale=de to the URL, like so:
1529 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1531 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1533 Improve null/empty String checks.
1535 * pom.xml: Add a dependency on commons-lang, to use
1536 org.apache.commons.lang.StringUtils.
1537 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1538 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1539 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1540 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1541 Use StringUtils.isEmpty().
1543 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1544 StringUtils class with a static isEmpty() function because we
1545 cannot use org.apache.commons.lang.StringUtils in client-side
1546 GWT code because it (apparently) cannot be compiled to javascript.
1547 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1548 * src/main/java/org/glom/web/client/activity/ListActivity.java
1549 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1550 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1551 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1552 * src/main/java/org/glom/web/client/place/ListPlace.java
1553 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1554 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1555 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1556 * src/main/java/org/glom/web/client/ui/details/Group.java
1557 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1558 our StringUtils.isEmpty() function.
1560 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1562 Update to the latest java-libglom API.
1564 * pom.xml: Require java-libglom 1.21.4.
1565 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1566 getDocumentInfo(), getListViewLayoutGroup():
1567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1569 * src/main/java/org/glom/web/server/database/DBAccess.java
1570 getFieldsToShowForSQLQueryAddGroup(),
1571 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1572 with either get_database_title_original() or
1573 get_database_title(localeID).
1575 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1577 ConfiguredDocument: Avoid a null pointer exception.
1579 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1580 Initialize localeID to "" to avoid returning a null String which
1581 causes a crash in java-libglom's swing-generated code.
1583 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1585 Some simple renaming.
1587 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1588 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1589 for localeChooser. This seems more appropriate and is less ambiguous
1590 particularly in the .css file.
1592 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1594 ConfiguredDocument: Rename the localedID private member variable.
1596 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1598 Adapt to the latest java-libglom API from git master.
1600 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1601 libglom now uses only Vector instead of List, which uses add() instead of
1604 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1606 ConfiguredDocument: Rename the localedID private member variable.
1608 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1610 Build a source tarball with mvn assembly:single
1612 * assembly.xml: Add this file.
1613 * pom.xml: Use the maven-assembly-plugin and tell it to use
1614 our assembly.xml file.
1616 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1618 OnlineGlomServiceImpl: Get .glom files recursively.
1620 * pom.xml: Depend on commons-io from org.apache.commons.
1621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1622 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1623 files recursively, and with the easier filter for the extension.
1624 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1625 simplify that code too.
1627 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1629 README: Mention that you must install java-libglom packages separately.
1631 But then it works, because java-libglom is now in the central maven
1634 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1636 locales drop-down: Show the correct selected locale when the URL changes.
1638 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1639 .java: setPlace(): Move some code into fillView().
1641 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1643 locales drop-down: Do not lose the primary key.
1645 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1646 start(): onLocaleChange(): Pass the current primary key value,
1647 instead of an empty value.
1649 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1651 locales drop-down: Do not lose the drop-down selection.
1653 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1654 .java (TableSelectionActivity.fillView): Set the selected locale
1655 after changing the drop-down items (though we do not really need
1656 to change them just because the locale changes.)
1658 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1660 locales drop-down: Change the tables list when this changes.
1662 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1663 .java: TableSelectionActivity.start(): Move the async table titles
1664 retrieval into a private fillView() method and also call this when
1665 the chosen locale changes.
1666 Note that the document title is not actually translatable yet, but
1667 that is a problem that I should fix soon in libglom.
1669 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1671 Improve the placement of the locales drop-down.
1673 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1674 Put the title and locales drop-down in a div (gwt.FlowTable).
1675 * src/main/webapp/style.css: Add magic css properties to make this work.
1676 Also remove the left margin from the title so that it lines up with the
1679 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1681 locales selector: Show human-readable locale titles.
1683 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1684 getDocumentInfo(): Use java.util.Locale to show a real title of
1685 each locale, in the locale's own language.
1687 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1689 Add a language/locale selector drop-down.
1691 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1692 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1693 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1694 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1695 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1696 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1697 Add a ListBox to show the available locales. Add getLocaleSelector(),
1698 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1699 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1700 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1701 java: Add these classes.
1702 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1703 start(): Fill the locales ListBox. Handle its change event, firing a
1705 setPlace(): Show the selected locale as specified by the URL token.
1706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1707 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1708 Handle LocaleChangeEvent, going to a new *Place with that locale.
1710 The placement of the ListBox is not pretty, and it currently uses the ID
1711 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1715 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1717 Search box: Show the search text from the URL token.
1719 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1720 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1721 Add setQuickFindText().
1722 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1723 .java: setPlace(): Store the queryText if the place is a ListPlace,
1724 and call TableSelectionView.setQuickFindText().
1726 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1728 Allow use of translations via, for instance, &lang=de in the URL.
1730 * pom.xml: Use the unstable java-libglom 1.21 version.
1732 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1733 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1734 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1735 init(): Instead of calling TranslatableItem.set_current_locale()
1736 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1737 However, this is only for default locales, which are not needed to
1738 change the locale in the URL.
1739 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1740 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1741 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1742 layout for a particular locale.
1743 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1744 Add get/setDefaultLocaleID().
1745 getDocumentInfo(), getListViewData(), getRelatedListData(),
1746 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1747 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1748 localeID parameter, so we can get the layout for a particular locale.
1750 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1751 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1752 * src/main/java/org/glom/web/client/place/ListPlace.java:
1753 Parse and construct a lang parameter too.
1755 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1756 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1757 passed to subsequent methods and constructors.
1758 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1759 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1760 Store the localeID from the *Place and pass it to other constructors
1761 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1763 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1764 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1765 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1766 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1767 * src/main/java/org/glom/web/client/ui/ListView.java:
1768 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1769 Take localeID parameters and pass them to subsequent constructors and
1770 methods, so that the layout is always retrieved for that locale.
1772 This is rather repetitive.
1774 Note that "" means the original (default) locale of the Glom document,
1775 which is usually English.
1777 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1779 Documents: Remove final keyword to fix startup configuration.
1781 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1782 final keywords on the private member variables because that breaks
1783 the startup, apparently (there are warnings) because it stops them
1784 from being serialized. I added these in the previous commit.
1786 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1788 Documents: Add some final keywords.
1790 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1793 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1795 OnlineGlomServiceImpl: Add to overview comments.
1797 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1798 Note that this is where all the document are loaded. They are not
1799 loaded freshly for each page.
1801 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1805 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1806 Add a TextBox for the text of a quick find.
1807 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1809 setBackLink(): Add a String quickFind parameter.
1810 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1811 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1812 to the base interface, because that is how TableSelectionViewImpl is used.
1813 * src/main/webapp/style.css: Add style for the search box and its label.
1815 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1816 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1817 Add these files, based on the existing TableChangeEvent and
1818 TableChangeEventHandlers.
1819 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1820 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1821 a ListPlace() that the user should be taken to.
1822 * src/main/java/org/glom/web/client/activity/ListActivity.java
1823 start(): Handle it here too and adapt the TableChangeEvent handler to
1824 pass the extra "" quickFind parameter to ListPlace.
1825 * src/main/java/org/glom/web/client/place/ListPlace.java:
1826 Constructor: Take an extra String quickFind parameter and store it,
1827 returning it from a new getQuickFind() method.
1828 getToken(): Put the quickFind text in the URL token.
1829 getPlace(): Parse the quickFind text from the URL token.
1830 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1831 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1832 ListPlace constructor.
1833 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1834 .java: start(): Add a Change handler for the TableSelectionView's
1835 TextBox (via its base HasChangeHandlers interface), firing the new
1836 QuickFindChangeEvent.
1837 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1838 pass the extra "" quickFind parameter.
1840 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1841 setCellTable(): Add a String quickFind parameter and pass it to
1842 the ListViewTable() constructor.
1843 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1844 setCellTable() in the base interface, because that is how ListViewImpl
1847 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1848 Add a String quickFind member variable.
1849 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1850 Constructor: Add a String quickFind parameter, storing it in the
1851 base ListTable's member variable.
1852 onRangeChanged(): Pass quickFind to the
1853 OnlineGlomServiceAsync.getSortedListViewData() and
1854 OnlineGlomServiceAsync.getListViewData() methods.
1856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1857 getListViewData(), getSortedListViewData(): Add a String quickFind
1858 parameter, passing it to ConfiguredDocument.getListViewData().
1859 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1860 Change getListViewData(), getSortedListViewData() in the base interface,
1861 because that is how OnlineGlomServiceImpl is used, via this:
1862 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1863 Change getListViewData(), getSortedListViewData() here too.
1864 This class can apparently be used to asynchronously call methods on
1865 OnlineGlomService, and GWT seems to implement that after recognizing
1866 just the *Async name convention and the extra AsyncCallback parameters.
1868 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1869 getListViewData(): Add a String quickFind parameter, and pass it to
1870 ListViewDBAccess.getData().
1871 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1872 getListData(): Add a String quickFind parameter and pass it to
1874 getSelectQuery(): Add a String quickFind parameter.
1875 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1876 getSelectQuery(): Add a String quickFind parameter and use it with
1877 Glom.get_find_where_clause_quick() to pass a where_clause to
1878 Glom.build_sql_select_with_where_clause(), to actually filter the
1880 getData(): Add a String quickFind parameter, passing it to getListData().
1881 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1882 va: getData(): Pass an empty string to getListData() for the
1883 quickFind parameter.
1885 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1887 ListTable: Minor change.
1889 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1890 createCellTable(): Make this protected instead of public.
1892 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1894 Many files: Use final for the parameters and use the @override attribute.
1896 2012-01-22 Ben Konrath <ben@bagu.org>
1898 Add anchor links for single line text that starts with http, ftp and www.
1902 2012-01-22 Ben Konrath <ben@bagu.org>
1904 Add ellipsis to single line text in details view.
1908 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1910 Remove all javadoc author tags.
1912 Because they are awkward and meaningless when many people touch
1914 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1916 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1918 Revert the COPYING.LESSER to COPYING rename.
1920 Apparently both should be there if it is LGPL.
1922 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1924 *View: Remove unused imports.
1926 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1927 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1928 * src/main/java/org/glom/web/client/ui/ListView.java:
1929 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1930 Remove unused imports, as suggested by Eclipse.
1932 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1934 Move the *View::Presenter types, and some API into one base View.
1936 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1937 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1938 * src/main/java/org/glom/web/client/ui/ListView.java:
1939 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1940 Presenter, setPresenter() and clear() into a shared base interface,
1941 to avoid the unnecessary duplicate Presenter types and to more clearly
1942 show how the *Views share the same structure, even if they are not
1943 used polymorphically.
1945 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1946 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1949 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1950 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1952 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1955 Feel free to revert this if there is a good reason for the duplicate
1958 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1960 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1962 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1963 a class member instead of a local variable in the method.
1964 This lets us use it to get the view instances, for use in tests.
1965 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1966 beforeOnlineGlom(): Test some more details of the initial view.
1967 Again, this is not very useful.
1969 To really test gwt-glom we will need to start a local postgresql
1970 instance with local data, like the Glom tests in C++.
1972 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1974 pom.xml: Mention the LGPL license.
1976 * pom.xml: Add a licenses section.
1977 * COPYING.LESSER: Move this to COPYING, which
1978 previously contained the GPL. But gwt-glom is all LGPL.
1980 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1982 Add project information to README and pom.xml.
1984 * README: Add a brief description and mention some mvn
1986 * pom.xml: This extra information shows up in mvn site
1989 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1991 Use the latest java-libglom version.
1993 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1995 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1997 GwtTestOnlineGlom: Test a little more.
1999 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2000 protected rather than private, as suggested by the gwt-test-utils
2002 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2003 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2004 Test the initial visibility of the panels.
2006 However, this is not a very useful test.
2007 And I wonder how we should generally test using this idea for an
2008 activity/places app like ours where the real changes happen implicitly
2009 based on the history token/URL.
2011 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2013 Slight modification to *Mapper comments.
2015 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2016 (DataActivityMapper)
2017 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2019 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2021 Remove comments mentioning GIN because they are just copied from
2022 the example code and are apparently not helpful:
2023 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2024 Also change the mention of a class that is only in the example code.
2026 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2028 GwtTestOnlineGlom test: Minor changes.
2030 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2031 Avoid the long qualified class name and modify the comment
2032 because it is now obvious to me that the mocked class is the only
2033 custom one created via GWT.create().
2035 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2037 Tests: Added the beginnings of a test using gwt-test-utils.
2039 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2040 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2041 which tells gwt-test-utils what class will be tested.
2042 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2043 Add a simple (but empty) test case. One class, used by the OnlineGlom
2044 class, is mocked so that it can be created. However, I am not sure
2045 why only this class needs to be mocked.
2047 Note that mockito seems more popular, and clearer, than easymock,
2048 but I have not got that working yet. It might be a matter of the
2051 This test is run during mvn integration-test.
2053 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2055 Tests: Use junit4-style syntax instead of junit3-style.
2057 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2058 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2059 * src/test/java/org/glom/web/shared/DataItemTest.java:
2060 Use the @Test annotation rather than relying on the test*() prefix.
2061 Also no longer implement TestCase, to avoid triggering support for
2062 the junit3-way, which stops the annotations from working.
2063 Change the imports from import junit.framework.* to
2064 import org.junit.*, which is apparently the new way.
2066 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2068 Added a test for ListPlace token parsing and creation.
2070 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2071 This is much the same as DetailsPlaceTest.
2073 I wonder how we could test the other parts of the *Place API.
2075 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2077 DetailsPlace test: Also test getToken() and recreation via getPlace().
2079 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2080 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2081 recreate it, testing the recreated DetailsPlace for the same parameter
2084 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2086 Use the surefire-report plugin.
2088 * pom.xml: This generates a HTML report about the tests in
2089 target/site/surefire-report.html
2090 when you do mvn surefire-report:report. It seems to be popular/normal.
2092 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2094 Added a test for DetailsPlace.
2096 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2097 Test the getPlace() token parsing.
2099 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2101 Added a first unit test.
2103 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2104 * src/test/java/org/glom/web/shared/DataItemTest.java:
2105 This is a silly test but it is just to get things started. Note that
2106 maven/junit finds the test because it looks in src/test by default.
2108 2011-12-22 Ben Konrath <ben@bagu.org>
2110 Change charsetName to "UTF-8" when replacing line breaks.
2112 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2113 that work in Java (such as "UTF8") will not work when compiled to
2116 This fixes a problem with multi-line details view fields that have hard
2117 line breaks. The "License Text" field on this page demonstrates the
2120 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2122 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2124 2011-12-22 Ben Konrath <ben@bagu.org>
2126 Fix another bug with related list navigation.
2128 I've tested all the navigation buttons in all of the related lists
2129 so things should be good now.
2131 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2133 2011-12-22 Ben Konrath <ben@bagu.org>
2135 Fix a crasher when refreshing the list view with the default table.
2137 This crash will also happen when loading the list view with the default
2138 table from a link or bookmark.
2140 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2141 to the main document selection page when the document id hasn't been
2143 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2144 the main document selection page when the document id hasn't been
2146 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2147 values for the details place when the document id hasn't been set.
2148 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2149 values for the list place when the document id hasn't been set.
2151 2011-12-21 Ben Konrath <ben@bagu.org>
2153 Protect against NPE when glom.document.locale is not in config.
2155 This patch protects against an NPE when glom.document.locale is not in
2156 the config file. This NPE will also happen if glom.document.locale is
2159 The patch also updates the error message to display the class name when
2160 the getMessage() returns null. This was happening when the NPE was
2161 thrown and I had "Configuration Error: null". If an NPE is encountered
2162 with this patch, "Configuration Error: NullPointerException " will be
2165 This commit closes this bug:
2167 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2171 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2173 Rename onlineglom.properties to onlineglom.properties.sample.
2175 * src/main/resources/onlineglom.properties: Rename to:
2176 * src/main/resources/onlineglom.properties.sample:
2177 * src/main/resources/README: And add this file explaining that people
2178 should rename it back when deploying.
2180 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2182 Allow choosing the translation in the .properties file.
2184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2185 init(): Read a glom.document.locale value from the configuration file
2186 and call Glom's TransatableItem::set_current_locale() method.
2187 * src/main/resources/onlineglom.properties: Add a commented-out
2188 example of this new setting.
2190 It would be better to add &lang=de_DE to the URL, but the current
2191 libglom API does not allow us to do this easily. I am working on that.
2193 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2195 Avoid a crash in parsing of token parameters.
2197 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2198 ava: getTokenParams(): Do not crash if a parameter has a key but no
2199 value, and ignore parameters with neither.
2201 2011-12-17 Murray Cumming <murrayc@murayc.com>
2203 History token building/handling: Improve use of token parameters.
2205 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2206 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2207 and buildParamsToken(HashMap), for use by derived classes.
2208 Make the separator private because it is no longer be needed.
2209 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2210 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2211 instead of manual string concatenation.
2212 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2213 of hardcoded indices and awkward splitting code.
2214 * src/main/java/org/glom/web/client/place/ListPlace.java
2215 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2216 instead of manual string concatenation.
2217 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2218 of hardcoded indices and awkward splitting code.
2219 This should fix bug #666420
2221 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2223 Fix a Navgiation->Navigation typo in the code.
2225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2226 Rename processNavgiation() to processNavigation().
2228 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2230 Fix a seperator->separator typo in the code.
2232 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2233 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2234 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2237 2011-12-15 Ben Konrath <ben@bagu.org>
2239 Cleanup some comments.
2241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2243 2011-12-14 Ben Konrath <ben@bagu.org>
2245 Replace \n with <br/> for multiline text in the details view.
2247 Vertical scrollbars are added when needed as well.
2249 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2251 2011-12-14 Ben Konrath <ben@bagu.org>
2253 Specify the font for document selection links.
2255 * src/main/webapp/style.css:
2257 2011-12-14 Ben Konrath <ben@bagu.org>
2259 Fix bouncy CellTable while paging.
2261 This doesn't currently work with related list tables in unselected
2264 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2266 2011-12-14 Ben Konrath <ben@bagu.org>
2268 Revamp the appearance of the document selection page.
2270 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2271 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2272 * src/main/webapp/style.css:
2274 2011-12-13 Ben Konrath <ben@bagu.org>
2276 Set navigation button column to the smallest size possible.
2278 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2280 2011-12-13 Ben Konrath <ben@bagu.org>
2282 Change OpenButton nomenclature to NavigationButton.
2284 Using NavigtionButton makes things more generic. Classes, methods and
2285 variables have been changed.
2287 This is a rename-only refactor.
2289 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2290 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2291 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2292 Renamed from OpenButtonCell.
2293 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2294 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2295 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2297 2011-12-12 Ben Konrath <ben@bagu.org>
2299 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2302 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2303 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2304 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2306 2011-12-12 Ben Konrath <ben@bagu.org>
2308 Update variable names and comments.
2310 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2311 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2313 2011-12-12 Ben Konrath <ben@bagu.org>
2315 Properly initialize numNonEmptyRows variable to zero.
2317 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2318 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2320 2011-12-05 Ben Konrath <ben@bagu.org>
2322 Add latest mockup with HTML tables.
2324 Features of this mockup:
2326 -> HTML table for flowtable
2327 -> HTML table for flowtable column
2328 -> Example of how related lists would look
2329 -> Not using text entries for data items
2331 The current version of Online Glom doesn't use HTML tables for the
2334 This mockup has been sent to the glom-devel mailing list but it's good
2335 to have it here as well.
2337 * mockups/details-view-html-tables.html:
2339 2011-12-05 Ben Konrath <ben@bagu.org>
2341 Remove unnecessary getPrimaryKeyField() method.
2343 getPrimaryKeyFieldForTable(String) has been renamed to
2344 getPrimaryKeyField(String).
2346 * src/main/java/org/glom/web/server/database/DBAccess.java:
2347 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2348 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2350 2011-12-05 Ben Konrath <ben@bagu.org>
2352 Add string representation of TypedDataItem value to conversion error message.
2354 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2355 message was extracted into its own method to avoid duplication.
2357 2011-12-05 Ben Konrath <ben@bagu.org>
2359 Add type checking to navigation primary key value creation.
2361 Create navigation primary key only if the expected type from the Glom
2362 document matches the type returned by the SQL query.
2364 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2366 2011-12-05 Ben Konrath <ben@bagu.org>
2368 Rename a couple of variables in RelatedListNavigation.
2370 This is a rename-only refactor.
2372 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2374 2011-12-05 Ben Konrath <ben@bagu.org>
2376 Move getListLayoutGroup() into getListViewLayoutGroup().
2378 This removes getListLayoutGroup(). It was only being called by
2379 getListViewLayoutGroup().
2381 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2383 2011-12-05 Ben Konrath <ben@bagu.org>
2385 Remove check for LayoutItem_Portal in list table method.
2387 This check is no longer necessary because the method isn't being used
2388 to create the LayoutItemPortal DTO.
2390 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2392 2011-12-05 Ben Konrath <ben@bagu.org>
2394 Properly support related list navigation.
2396 Navigation from the "Repository Analyzer -> Package Scans ->
2397 Dependencies" related table wasn't working because the primary key for
2398 related tables wasn't being set properly. This commit fixes the
2401 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2402 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2403 doesn't set the primary key properly for related list tables.
2404 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2405 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2406 useful for getting the primary key for list view tables and for related
2408 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2409 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2410 Move code to set the primary key for the table from the abstract
2411 ListDBAccess class to ListViewDBAccess as it's only correct for list
2413 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2414 Properly add primary key to related list tables.
2416 2011-12-02 Ben Konrath <ben@bagu.org>
2418 Properly set the horizontal alignment of fields.
2420 This fix is for both the list tables and the details view.
2422 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2423 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2424 to set the horizontal alignment of fields.
2426 2011-12-02 Ben Konrath <ben@bagu.org>
2428 Display currency codes in the details view.
2430 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2432 2011-12-02 Ben Konrath <ben@bagu.org>
2434 Avoid duplicate JNI call.
2436 JNI is not as efficient as pure Java and this is an easy (and small)
2439 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2440 Use previously retrieved value for whereClauseToTableName instead of
2443 2011-12-02 Ben Konrath <ben@bagu.org>
2445 Rename a couple of variables in RelatedListNavigation.
2447 This is a rename-only refactor.
2449 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2451 2011-12-02 Ben Konrath <ben@bagu.org>
2453 Indicate clearly that a mismatched primary key type is a bug.
2455 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2456 warning to error. Add 'This is a bug.' to message.
2458 2011-12-02 Ben Konrath <ben@bagu.org>
2460 Update / fix some comments.
2462 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2464 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2466 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2467 Fix comments. Add some TODOs.
2469 2011-12-02 Ben Konrath <ben@bagu.org>
2471 Enable navigation to details view with string primary key from related list.
2473 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2474 Create a text primary key value when return type of result is
2475 java.sql.Types.VARCHAR.
2477 2011-12-02 Ben Konrath <ben@bagu.org>
2479 Use checkboxes for booleans in the details view.
2481 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2483 2011-12-01 Ben Konrath <ben@bagu.org>
2485 Improve performance of related list height calculation.
2487 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2488 Put code to calculate the expected height in a static initializer so
2489 that that it's only called once.
2491 2011-12-01 Ben Konrath <ben@bagu.org>
2493 Show related list tables in notebooks (again).
2495 Calculate the height of the related list tables so the Notebook can be
2496 set the correct height. The height of the related list table is also needed by
2497 FlowTable to be able decide how to create the layout.
2499 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2500 and set the Portal height based on the height of the related list
2501 table and the Portal container.
2502 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2503 Add method to calculate the height of the related list tables.
2504 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2505 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2506 calculate the height of the Pager widget.
2508 2011-12-01 Ben Konrath <ben@bagu.org>
2510 Use CellTable API for table property instead of setting style on Element.
2512 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2514 2011-12-01 Ben Konrath <ben@bagu.org>
2516 Make ListViewTable and RelatedListTable a consistent height.
2518 The tables are now a consistent height regardless of the contents of
2519 the table. A hidden button is added to empty rows to ensure that the
2520 height of these rows will match the height of rows with data.
2522 A navigation button column is now added to every table. The width of
2523 the navigation column is set to 0px when a RelatedListTable shouldn't
2524 have navigation buttons. This maintains the a consistent row height in
2525 tables that don't show the navigation buttons.
2527 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2528 navigation column when not needed.
2529 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2530 arguments for navigation button to constructor of ListViewTable.
2531 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2532 hidden button for empty data rows.
2533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2534 arguments for navigation button to constructor.
2535 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2536 create navigation buttons. Add hideNavigationButtons() method.
2537 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2538 arguments for navigation button to constructor.
2540 2011-12-01 Ben Konrath <ben@bagu.org>
2542 Use 'visibility: hidden' in Utils.getWidgetHeight().
2544 This is better choice because hidden elements are invisible, don't
2545 respond to events and are not part of the tab order. They will,