1 2012-06-08 Murray Cumming <murrayc@murrayc.com>
3 SelfHoster: Keep trying pg_ctl after starting postgres.
5 * src/test/java/org/glom/web/server/SelfHoster.java
6 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
7 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
8 regular Glom. This seems mad but it seems to work because the first
9 command would fail if pg_ctl would eventually fail.
11 2012-06-08 Murray Cumming <murrayc@murrayc.com>
13 SelfHoster: Wait until the server is really ready.
15 * src/test/java/org/glom/web/server/SelfHoster.java
16 selfHost(): Attempt the connection after starting the server, retrying
17 a few times if necessary, so that the server is really ready already when
18 we return from this method.
19 The regular Glom code does this too because pg_ctl reports success too soon.
21 2012-06-08 Murray Cumming <murrayc@murrayc.com>
23 ConfiguredDocument: Do not add a primary key to portals each time.
25 * src/main/java/org/glom/web/server/ConfiguredDocument.java
26 updatePortalsExtras(): Only add an extra primary key field if there is
27 none, to avoid adding one each time we retrieve the details layout from the
29 This should fix bug #676986 (Ben Konrath)
31 2012-05-25 Murray Cumming <murrayc@murrayc.com>
33 Document.load(): Support version 7 documents.
35 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
36 database_title attribute if the title attribute is not there.
39 2012-05-24 Ben Konrath <ben@bagu.org>
41 Add configuration for auto-generating mvn:i18n from with Eclipse.
43 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
45 2012-05-24 Murray Cumming <murrayc@murrayc.com>
47 Update translations, adding French.
49 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
50 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
51 Add a French translation, using the translation from Glom.
53 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
54 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
55 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
56 Update these based on the translations from Glom.
58 2012-05-24 Murray Cumming <murrayc@murrayc.com>
60 SelfHoster: Add some debug println messages to help when things fail.
62 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
63 System.out.println() lines.
65 2012-05-23 Murray Cumming <murrayc@murrayc.com>
67 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
69 * src/test/java/org/glom/web/server/SelfHoster.java:
70 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
71 instance) instead of just /usr/bin (as on Fedora). Check the result when
74 2012-05-23 Murray Cumming <murrayc@murrayc.com>
76 Remove LayoutItemPortal.get/setNavigationTable().
78 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
79 Remove get/setNavigationTable(), which is only a cache, because it is not
80 used, and does not need to be used, because that decision should be made on
82 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
83 updatePortalsExtras():
84 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
85 getNavigationRecord():
86 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
89 2012-05-21 Murray Cumming <murrayc@murrayc.com>
91 Initial self-hosting for tests.
93 * pom.xml: Change the scope for log4j, to hopefully make it
94 available to the test code which uses it indirectly via jOOQ.
95 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
96 self-hosting, though we only use it for testing.
98 * src/main/java/org/glom/web/server/libglom/Document.java:
99 example rows: Use a map instead of a list for each row of values,
100 so we know what field they are for, instead of relying on the sequence
101 being correct. This is not very efficient, but it does not really need
103 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
104 testReadTableExampleRows(): Adapted.
106 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
107 that returns an Object, for generic use. Note that Object seems to be
108 the implicit base even of double.
109 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
110 for use in CREATE TABLE SQL queries.
111 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
112 to do self-hosting of PostgreSQL databases via its command-line
113 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
114 backends/postgres_self.cc. This is incomplete - it needs more
115 warnings about failures and it needs to clean up properly when things
117 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
118 test of this new class.
120 2012-05-21 Murray Cumming <murrayc@murrayc.com>
122 Document: loading example data: Handle exceptions.
124 * src/main/java/org/glom/web/server/libglom/Document.java:
125 DateFormat.parse() and Double.valueOf() can throw exceptions, though
126 Eclipse did not warn about that.
128 2012-05-20 Murray Cumming <murrayc@murrayc.com>
130 Document: load(), save(): Handle the example rows.
132 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
134 * src/main/java/org/glom/web/server/libglom/Document.java:
135 load(), save(): Load and save the example rows, though the date, time
136 and image types are not handled properly yet.
137 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
138 Add testReadTableExampleRows() just to check that something is read.
140 2012-05-20 Murray Cumming <murrayc@murrayc.com>
142 Document: Add save().
144 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
145 Added getTranslationsMap() for use while saving.
146 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
147 Adedd getUseDefaultFormatting() for use while saving.
148 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
149 and several private methods that it uses.
151 This will be useful while testing via self-hosting.
152 It is not complete, but should be complete enough for testing.
154 2012-05-17 Murray Cumming <murrayc@murrayc.com>
156 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
158 * src/main/java/org/glom/web/client/OnlineGlomService.java
159 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
161 Remove getSortedListViewData() and getSortedRelatedListData(), adding
162 the sort column index and ascending bool to the regular method.
163 Instead, a sort column index of -1 now means no sort.
164 This is less explicit, but it's fairly simple, reduces the amount of
165 code, and makes the OnlineGlomService API slightly smaller.
166 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
167 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
169 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
170 getListViewData(), getRelatedListData():
171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
172 getListViewData(), getRelatedListData():
173 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
175 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
177 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
182 2012-05-16 Murray Cumming <murrayc@murrayc.com>
184 Use translations for top-level groups too.
186 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
187 updateTitlesForLocale(): Use the translation for the group
188 as well as for child items.
192 Just recompiled to fix a problem in the released .tar.gz file.
196 2012-05-15 Murray Cumming <murrayc@murrayc.com>
198 Corrections to navigation to related records.
200 * src/main/java/org/glom/web/client/OnlineGlomService.java:
201 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
203 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
204 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
205 relationship name, because the relationship name is not necessarily unique
207 TOOD: This is inefficient, because it passes the whole list of
208 child field items back to the server, but it is more correct, and happens
209 to fix a bug with the primary key being lost after a few navigations.
210 There is probably a chance to make this more efficient anyway in some
213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
214 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
215 * src/main/java/org/glom/web/server/ConfiguredDocument.java
216 * src/main/java/org/glom/web/server/database/DBAccess.java
217 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
218 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
221 2012-05-15 Murray Cumming <murrayc@murrayc.com>
223 Fix the use of translations.
225 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
226 Add updateTitlesForLocale().
227 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
228 Call it to discard unwanted translations and to make getTitle() return
229 the wanted translation wihout the need for the client code to specify a locale.
230 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
231 getTitle(): Fallback to the original title, as libglom does.
233 2012-05-15 Murray Cumming <murrayc@murrayc.com>
235 Document: Correctly report the number of available translation locales.
237 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
238 the available locale IDs list.
239 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
240 testLocales: Test this.
242 2012-05-15 Murray Cumming <murrayc@murrayc.com>
244 SqlUtils: Use camelCase.
246 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
247 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
248 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
249 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
250 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
251 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
253 2012-05-15 Murray Cumming <murrayc@murrayc.com>
255 Use jOOQ's tableByName() and fieldByName.
257 * pom.xml: Use jOOQ 2.3.1 to get the new API.
258 * src/main/java/org/glom/web/server/SqlUtils.java:
259 build_sql_select_step_with_where_clause(), .createField(),
260 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
261 so we can get correct quoting and escaping. Thanks to Lukas Eder for
262 adding this, and other things, to jOOQ.
264 2012-05-15 Murray Cumming <murrayc@murrayc.com>
266 SqlUtils: Remove the Connection parameters.
268 * src/main/java/org/glom/web/server/SqlUtils.java:
269 build_sql_select_with_key(), build_sql_select_with_where_clause(),
270 createSelect(), build_sql_select_step_with_where_clause(),
271 build_sql_count_select_with_where_clause(),
272 build_sql_select_count_rows(): Remove the Connection parameter because
273 jOOQ does not actually need a connectionwhen it is just used to build
275 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
277 * src/main/java/org/glom/web/server/ReportGenerator.java:
279 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
281 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
282 Constructor, getListData(), getResultSizeOfSQLQuery():
283 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
284 getSelectQuery(), getCountQuery():
285 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
286 getSelectQuery(), getCountQuery():
287 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
288 getNavigationRecord(): Adapted.
290 2012-05-14 Murray Cumming <murrayc@murrayc.com>
294 * src/main/java/org/glom/web/server/SqlUtils.java:
295 get_find_where_clause_quick(): Use a comparison of
296 lowercase values, instead of a simple equals. Regular Glom
297 uses the PostgreSQL ILIKE operator but jOOQ does not
298 support that just yet, though it will soon.
300 2012-05-14 Murray Cumming <murrayc@murrayc.com>
302 TableToViewDetails: Use a real serialization ID.
304 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
305 Though this does not fix the serialization problem.
307 2012-05-12 Murray Cumming <murrayc@murrayc.com>
309 Added LayoutItemPortalDeepCloneTest.
311 2012-05-11 Murray Cumming <murrayc@murrayc.com>
313 Make navigation work again.
315 * src/main/java/org/glom/web/server/libglom/Document.java:
316 Add getLayoutItemFieldShouldHaveNavigation().
317 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
318 Replace get/setAddNavigation() with the partly-existing
319 get/setNavigationTableName(), with an empty string being no navigation,
320 because this is simpler. Use the new
321 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
323 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
324 Add updateFieldsExtras() and call setNavigationTableName in it.
325 getDetailsLayoutGroup(),
326 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
327 createLayout(): Adapted.
328 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
329 Constructor: Adapted.
331 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
332 Replace get/setAddNavigation() with get/setNavigation(), returning a
333 TableToViewDetails class with both the table name and UsesRelationship,
334 because both are need. The previous code used java-libglom's output
335 variable (strangely, via sharedptr) to return both, but we cannot really
337 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
338 getNavigationRecord(): Adapt. However, we cannot actually use the cache
339 here because it somehow gets set to null during deepCopy(). I must test this.
340 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
341 testGetSuitableTableToViewDetails(): Adapted.
343 TODO: Find out why deepClone() is not quite working.
345 2012-05-11 Murray Cumming <murrayc@murrayc.com>
347 DBAccess: Simplify the retrievel of full field details.
349 * src/main/java/org/glom/web/server/database/DBAccess.java
350 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
351 because the Document loading should have done this.
353 2012-05-11 Murray Cumming <murrayc@murrayc.com>
355 Document: Correct loading of doubly-related layout fields.
357 * src/main/java/org/glom/web/server/libglom/Document.java:
358 loadUsesRelationship(): Actually set the related relationship, instead
359 of only setting it if it's not found.
361 2012-05-09 Murray Cumming <murrayc@murrayc.com>
363 Replace all appearances of Colour with color.
365 Because US English is dominant.
367 2012-05-09 Murray Cumming <murrayc@murrayc.com>
369 Use colors in HTML format, solving a warning about an unused function.
371 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
372 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
373 Add *asHTMLColor() versions of methods.
374 TODO: However, we should create and cache the results on the server.
375 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
376 * src/main/java/org/glom/web/client/ui/list/ListTable.java
377 * src/main/java/org/glom/web/server/ConfiguredDocument.java
378 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
379 Use the asHTMLcolor() versions.
381 2012-05-09 Murray Cumming <murrayc@murrayc.com>
383 ListViewTable: Constructor: Take the table name as a parameter.
385 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
386 Constructor: Take the tableName, and set the member variable, because
388 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
389 setCellTable(): Pass the table name.
390 This makes navigation to non-default tables work again. I don't know
391 why it worked before in the master branch.
393 2012-05-07 Murray Cumming <murrayc@murrayc.com>
395 ConfiguredDocument: Restore correct addition of hidden primary key items.
397 * src/main/java/org/glom/web/client/ui/list/ListTable.java
398 (ListTable.createCellTable): Uncomment out the check for the hidden
400 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
401 add primary key items for top-level lists and portals, as before,
402 instead of adding them to each group.
403 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
404 Actually implement the extra methods such as setHiddenPrimaryKey() and
405 comment that these are used only for top-level list groups and in portals.
406 This strangeness suggests even more that this should not be squeezed
407 into the LayoutGroup class.
409 2012-05-07 Murray Cumming <murrayc@murrayc.com>
411 Fix Formatting loading.
413 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
414 getFormattingUsed(): Remove the duplicate Formatting member variable
415 in favour of the one from the base class.
416 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
417 Initialize a new Formatting instead of using null by default, so we
418 have some defaults, instead of having to initialize one later just to
419 get the same defaults. This also makes loading of formatting from the
420 document work, because that expected a non-null.
422 2012-05-07 Murray Cumming <murrayc@murrayc.com>
424 RelatedListTable: Make sure that the tableName is set.
426 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
427 Constructor: Take the tableName so it is available later. Otherwise,
428 the server assumes that we mean the default table and cannot find the
430 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
431 setData(): Pass the tableName to the RelatedListTable constructor.
433 2012-05-07 Murray Cumming <murrayc@murrayc.com>
437 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
438 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
439 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
441 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
443 * src/main/java/org/glom/web/server/database/DBAccess.java:
444 convertResultSetToDTO(), getPortal():
445 * src/main/java/org/glom/web/server/database/ListDBAccess.java
447 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
448 Add checks for null objects and out of range access, with log messages to
449 give hints so we can fix these properly.
451 2012-05-07 Murray Cumming <murrayc@murrayc.com>
453 Portals: some corrections.
455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
457 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
458 constructor: Use getRelationshipNameUsed() instead of getName(), because
459 that is what is meant.
460 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
461 getFromField(): Fix a typo, to get the field name, not the table name.
462 * src/main/java/org/glom/web/server/database/DBAccess.java:
463 getPortal(): Fix a typo that stopped this from working.
465 2012-05-07 Murray Cumming <murrayc@murrayc.com>
467 LayoutItemPortal: Also override getTitleOriginal().
469 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
470 This lets the base getTitle() with no parameters work.
471 TODO: Test this properly.
473 2012-05-06 Murray Cumming <murrayc@murrayc.com>
475 LayoutItemPortal: getTitle*(): Use the relationship title.
477 2012-05-06 Murray Cumming <murrayc@murrayc.com>
479 LayoutItemField: Fix loading of custom titles.
481 * src/main/java/org/glom/web/server/libglom/Document.java
482 loadDataLayoutItemField(): The title, if any, instead of the field
483 title, is stored in a title_custom node. Load it from there.
484 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
486 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
487 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
488 getTitle*() overrides.
489 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
492 2012-05-06 Murray Cumming <murrayc@murrayc.com>
494 LayoutItemField: Fall back to field titles, so some are really shown.
496 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
497 Override getTitleOriginal() and getTitle(), as in java-libglom.
498 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
501 2012-05-06 Murray Cumming <murrayc@murrayc.com>
503 Correct use of setExpectedResultSize().
505 * src/main/java/org/glom/web/server/ConfiguredDocument.java
506 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
507 Use setExpectedResultSize only on top-level groups (for instance, the
508 list layout) or on child portals (in details views).
509 Use the correct table name for portals to avoid SQL errors.
510 Update the expected counts when returning cached layouts.
512 2012-05-06 Murray Cumming <murrayc@murrayc.com>
514 Document: Interpret no group column count as 1.
516 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
517 default, though we now check for this in the UI code anyway.
519 2012-05-06 Murray Cumming <murrayc@murrayc.com>
523 2012-05-06 Murray Cumming <murrayc@murrayc.com>
525 Translatable: Use Hashmap instead of Treemap because GWT supports it.
527 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
528 The use of Treemap lead to this error from async methods, with no
530 "The response could not be deserialized"
532 2012-05-06 Murray Cumming <murrayc@murrayc.com>
534 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
536 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
537 when using the Google -> GWT Compile, or
538 g toolbar button -> GWT Compile Project... feature in Eclipse.
540 2012-05-06 Murray Cumming <murrayc@murrayc.com>
542 ListTable.addColumn(): Protect against a null Formatting.
544 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
545 Create a default Formatting if it is null, because that is the simplest
548 2012-05-06 Murray Cumming <murrayc@murrayc.com>
550 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
552 * src/main/java/org/glom/web/server/ConfiguredDocument.java
553 updateLayoutGroup(): Check that the field is not null.
555 2012-05-06 Murray Cumming <murrayc@murrayc.com>
557 ListViewImpl: Protected against a bad cast error.
559 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
560 onEnterKeyDown(): Do not cast without an instanceof check.
562 2012-05-06 Murray Cumming <murrayc@murrayc.com>
564 ListTable: Protect against an out of range error.
566 * src/main/java/org/glom/web/client/ui/list/ListTable.java
567 createCellTable(): This is unlikely, but can happen while debugging.
569 2012-05-06 Murray Cumming <murrayc@murrayc.com>
571 AsyncMessage onFailure() callbacks: Log the exception message.
573 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
574 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
575 * src/main/java/org/glom/web/client/activity/ListActivity.java:
576 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
577 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
579 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
580 These are useful clues when something is wrong.
582 2012-05-06 Murray Cumming <murrayc@murrayc.com>
584 ConfiguredDocument: Avoid a null dereference.
586 * src/main/java/org/glom/web/server/ConfiguredDocument.java
587 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
588 details maps are created.
590 2012-05-06 Murray Cumming <murrayc@murrayc.com>
592 Document: Correct the port number parsing.
594 * src/main/java/org/glom/web/server/libglom/Document.java:
595 This lets us actually connect to the database and show the document.
597 2012-05-05 Murray Cumming <murrayc@murrayc.com>
601 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
602 user-interaction, asking us to load a temporary URL in a browser.s
603 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
604 which is apparently necessary for testing the service. See the comment.
605 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
606 Show the exception, if any. This is how I saw the 404 in the HTML in
609 2012-05-05 Murray Cumming <murrayc@murrayc.com>
611 DocumentTest: Move the .glom files into the resources directory.
613 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
614 URI via getResource().
616 2012-05-05 Murray Cumming <murrayc@murrayc.com>
618 Document: Remove the FieldIdentifies inner class.
620 * src/main/java/org/glom/web/server/libglom/Document.java: We only
621 use the Relationship (though the same function in libglom is maybe
622 used in other ways) and so this removes a compiler warning.
624 2012-05-05 Murray Cumming <murrayc@murrayc.com>
626 Document.load() Remove the error code parameter.
628 * src/main/java/org/glom/web/server/libglom/Document.java: load():
629 Remove the parameter. We do not set it yet and it could never have
630 worked as an output parameter (though maybe it did in java-libglom).
631 We could use an exception if we really want the failure reason.
632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
634 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
635 setUp(), testGetSuitableTableToViewDetails(): Adapt.
637 2012-05-05 Murray Cumming <murrayc@murrayc.com>
639 Make some inner classes static.
641 * src/main/java/org/glom/web/server/ConfiguredDocument.java
642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
643 * src/main/java/org/glom/web/server/ReportGenerator.java
644 * src/main/java/org/glom/web/server/libglom/Document.java
645 Make all inner classes static that can be static.
647 2012-05-05 Murray Cumming <murrayc@murrayc.com>
649 OnlineGlomServiceImpl: Do not load and check for java-libglom.
651 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
652 init(): We do not use java-libglom any more.
654 2012-05-05 Murray Cumming <murrayc@murrayc.com>
656 Remove mentions of java-libglom.
658 * README: Remove mention of java-libglom, because it no longer needed.
659 * utils/build-onlineglom-war.sh:
660 * utils/check-and-recover-tomcat.py:
661 * utils/install-onlineglom-war.sh: Remove these as they are no longer
662 useful. Building is now far easier, with no need for jhbuild.
664 2012-05-05 Murray Cumming <murrayc@murrayc.com>
666 Fix the build (mvn package)
668 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
669 (LayoutGroup): Make the LayoutItemList inner class static and protected.
670 Otherwise the GWT Java->Javascript compilation fails with just this
671 error, during mvn package or when attempting to view in a browser,
672 in the GWT developer mode in Eclipse.
674 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
675 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
676 [INFO] Compiling module org.glom.web.OnlineGlom
677 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
678 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
679 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
680 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
681 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
682 [INFO] [ERROR] Cannot proceed due to previous errors
684 It has taken me 2 days to find out what was causing that. After reducing
685 the code, the compiler eventually showed me the full error message.
687 2012-05-04 Murray Cumming <murrayc@murrayc.com>
689 ConfiguredDocument: Cache the cloned and stripped layouts.
691 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
692 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
693 layout in a map, so we can retrieve it again without rebuilding it.
695 2012-05-04 Murray Cumming <murrayc@murrayc.com>
697 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
699 2012-05-04 Murray Cumming <murrayc@murrayc.com>
701 libglom classes: Implement some auto-generated emthods.
703 2012-05-04 Murray Cumming <murrayc@murrayc.com>
705 Add GwtTestOnlineGlomService.
707 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
708 However, this (and the other GwtTest*) does not seem to run during
711 2012-05-04 Murray Cumming <murrayc@murrayc.com>
713 Remove use of unsupported features from client code.
715 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
716 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
717 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
718 Use our client version of StringUtils instead of the apache commons one.
720 However, the GWT Javascript compliation still fails.
722 2012-04-25 Murray Cumming <murrayc@murrayc.com>
724 Add a Field class and implement some loading of it in Document.
726 2012-04-25 Murray Cumming <murrayc@murrayc.com>
728 Initial Document loading implementation, instead of libglom.
730 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
731 and Translatable classes, and adapt the rest of the code to use them.
732 However, this is still missing Layout and Field classes and loading.
734 2012-04-24 Murray Cumming <murrayc@murrayc.com>
736 Use of jOOQ: Move Field creation into a utility method.
738 * src/main/java/org/glom/web/server/SqlUtils.java:
739 This lets us improve it more easily.
741 2012-04-24 Murray Cumming <murrayc@murrayc.com>
743 Use of jOOQ: Improve the code to COUNT a sub-select.
745 * src/main/java/org/glom/web/server/SqlUtils.java:
746 Move initial query creation into
747 build_sql_select_step_with_where_clause().
748 build_sql_select_count_rows(): Use the jOOQ API instead of
749 concatentating text, because a jOOQ Select*Step is a TableLike,
750 which is what from() takes.
752 2012-04-23 Murray Cumming <murrayc@murrayc.com>
754 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
756 * pom.xml: Depend on jooq.
757 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
758 methods with jOOQ, based on the C++ implementations in libglom,
759 with some changes to the logic required by jooQ.
760 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
762 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
763 * src/main/java/org/glom/web/server/ReportGenerator.java:
764 * src/main/java/org/glom/web/server/SqlUtils.java:
765 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
766 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
767 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
768 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
769 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
770 Adapt. In particular, the SqlUtils methods now need to take a Connection,
771 because jOOQ needs that, though it seems unnecessary.
773 This is not quite finished. Ideally jOOQ would help us to build
774 table_name.field_name names, quoting and escaping them properly.
775 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
777 2012-04-21 Murray Cumming <murrayc@murrayc.com>
779 Move use of Glom.build_sql*() into a new SqlUtils class.
781 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
782 to wrap Glom.build_sql*(). The parameter types are still Glom one,
783 but this will make it easier to start using something other than
784 libglom or SqlBuilder.
786 2012-04-21 Murray Cumming <murrayc@murrayc.com>
788 Update the project URL.
790 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
792 2012-04-21 Murray Cumming <murrayc@murrayc.com>
794 Main layout: Use a FlowTable instead of absolute positioning.
796 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
797 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
798 child panels/widgets must have an absolute position. But that is annoying, so
799 this adds a FlowTable and puts the child panels in there.
801 2012-04-21 Murray Cumming <murrayc@murrayc.com>
803 GwtTestOnlineGlom: Comment out unused code.
805 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
806 Eclipse has started to say that some code is unused.
808 2012-04-21 Murray Cumming <murrayc@murrayc.com>
810 Update to the latest versions of dependencies.
812 * pom.xml: Update version numbers of dependencies to the latest
814 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
816 * src/main/java/org/glom/web/server/ReportGenerator.java:
817 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
818 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
819 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
821 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
822 Modify the imports where necessary.
824 2012-04-17 Murray Cumming <murrayc@murrayc.com>
826 Style: Remove overflow:hidden from searchbox
828 * src/main/webapp/style.css: Because this pushes the Back To Link
829 label/link on to the next row, which is then hidden due to the
830 hard-coded (in ems) height.
832 2012-04-20 Murray Cumming <murrayc@murrayc.com>
834 Remove some duplicate code.
836 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
837 getDocumentInfo(): This must have been duplicated during the merge from the
842 2012-04-19 Murray Cumming <murrayc@murrayc.com>
844 Reports: Localize the waiting for report message.
846 * src/main/java/org/glom/web/client/activity/ReportActivity.java
847 start(): Get the message from the contants.
848 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
850 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
851 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
852 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
853 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
854 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
855 Update these files with the English text for newer strings for now.
857 2012-04-19 Murray Cumming <murrayc@murrayc.com>
859 Reports: Show a message while waiting for the report.
861 * src/main/java/org/glom/web/client/ui/ReportView.java
862 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
863 Add setWaitingText(), to show a message saying that we are
864 waiting for the report to be ready.
865 * src/main/java/org/glom/web/client/activity/ReportActivity.java
866 start(): Call setWaitingText() before calling the async
869 2012-04-19 Murray Cumming <murrayc@murrayc.com>
871 ReportGenerator: Specify date and time formats.
873 * src/main/java/org/glom/web/server/ReportGenerator.java:
874 createFieldValueElement(): Use the default (and localized)
875 short formats, though we still need a way to show 4-digit
876 years without providing the format for every locale.
877 * src/main/java/org/glom/web/server/database/DBAccess.java:
878 convertResultSetToDTO(): Use the short formats here too.
880 2012-04-18 Murray Cumming <murrayc@murrayc.com>
882 ReportGenerator: Use the correct numeric formatting.
884 * src/main/java/org/glom/web/server/ReportGenerator.java
885 createFieldExpression(), createFieldValueElement(): Take the
886 whole LayoutItem_Field instead of just the field name, so
887 we have access to the formatting.
888 createFieldValueElement(): Use JRTextField.setPattern() to
889 specify the numeric formatting, with the help of a
890 regular DecimalFormat.
892 2012-04-18 Murray Cumming <murrayc@murrayc.com>
894 ReportGenerator: Avoid showing null for group by titles.
896 * src/main/java/org/glom/web/server/ReportGenerator.java
897 generateReport(): Use setBlankWhenNull() on the field title
898 style too, because this is used for values in group by
901 2012-04-18 Murray Cumming <murrayc@murrayc.com>
903 ReportGenerator: Add a colon to titles in vertical groups.
905 * src/main/java/org/glom/web/server/ReportGenerator.java
906 addFieldToDetailBandVertical(): Pass true for the withColon
909 2012-04-18 Murray Cumming <murrayc@murrayc.com>
911 ReportGenerator: Simplify the code by using Position more.
913 2012-04-18 Murray Cumming <murrayc@murrayc.com>
915 Reports: Support vertical groups, roughly.
917 * src/main/java/org/glom/web/server/ReportGenerator.java:
918 addToReport(): Rename to addGroupToReport() and, if necessary,
919 call the new addVerticalGroupToReport() method.
920 createFieldValueElement(): Let the caller specify the Y position
923 2012-04-17 Murray Cumming <murrayc@murrayc.com>
925 Reports: Allow a second report to be shown.
927 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
928 clear(): Do not remove the HTML widget, which broke the whole layout.
930 2012-04-17 Murray Cumming <murrayc@murrayc.com>
932 Locales drop-down: Show that we use English by default.
934 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
935 fillView(): When we use English, just because that is the default, when
936 no locale is specified, show that in the Locales drop-down instead of
937 just showing the first item.
939 2012-04-17 Murray Cumming <murrayc@murrayc.com>
941 Unselect the Report/Locale/Table combo item when appropriate.
943 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
944 setPlace(): clear reportName if this is not a ReportPlace.
945 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
946 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
947 When the provided name is empty, unselect all items, so that none are
948 indicated. This uses a for loop because I cannot find a single method
951 2012-04-17 Murray Cumming <murrayc@murrayc.com>
953 Report: Give the user a way to get back to the list.
955 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
956 start(), setPlace(): Show the Back To List link on reports, and also
957 interpret selecting the empty report item as back to list.
959 2012-04-13 Murray Cumming <murrayc@murrayc.com>
961 Really show the selected Report name.
963 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
964 setPlace(): Store the reportName here, if it is that kind of Place.
965 fillView(): Set the selected Report after filling the list of reports.
966 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
967 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
968 null Strings, though we need some way to unselect all ListBox items
971 2012-04-13 Murray Cumming <murrayc@murrayc.com>
973 ReportGenerator: Try to avoid some problems.
975 * src/main/java/org/glom/web/server/ReportGenerator.java
976 addField(): Try to avoid duplicates, and avoid using a null
979 2012-04-13 Murray Cumming <murrayc@murrayc.com>
981 Reports: Use quickFind.
983 * src/main/java/org/glom/web/client/OnlineGlomService.java;
984 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
985 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
986 getReportHTML(): Add a quickFind parameter.
987 * src/main/java/org/glom/web/client/activity/ReportActivity.java
988 start(): Pass the quickFind parameter.
989 * src/main/java/org/glom/web/server/ReportGenerator.java
990 generateReport(): Take a quickFind parameter.
992 2012-04-13 Murray Cumming <murrayc@murrayc.com>
994 ReportPlace: Actually use the report name.
996 * src/main/java/org/glom/web/client/place/ReportPlace.java
997 getPlace(): Do not assign the report name to the quickfind.
999 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1001 Show java.library.path when complaining.
1003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1004 init(): When telling us to check java.library.path, show the
1007 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1009 ReportGenerator: Do not show nulls.
1011 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1013 ReportGenerator: Make the title font larger.
1015 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1017 ReportGenerator: Put field titles inside groups, if there are groups.
1019 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1021 ReportGenerator: Take the Report itself instead of the name and group.
1023 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1024 Remove getReportLayoutGroup().
1025 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1026 getReportHTML(): Pass the report instead
1027 of its name and layout group.
1028 * src/main/java/org/glom/web/server/ReportGenerator.java
1029 generateReport(): Use the report object to use the title
1030 instead of the name.
1032 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1034 ReportGenerator: Remove designBand parameters.
1036 * src/main/java/org/glom/web/server/ReportGenerator.java:
1037 Make designBand a class member instead of passing it to all
1040 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1042 ReportGenerator: Add lines, a bit like in the desktop version.
1044 * src/main/java/org/glom/web/server/ReportGenerator.java
1045 addToReport(): Use JRDesignLine.
1047 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1049 ReportGenerator: Correct the title positions and use some bold style.
1051 * src/main/java/org/glom/web/server/ReportGenerator.java:
1052 Break the code up into reusable functions, correct the placement of
1053 titles, and use normal/bold styles as in the reports in the desktop
1056 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1058 ReportGenerator: Add a header band to show the field titles.
1060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1061 getReportHTML(): Pass the localeId to the ReportGenerator
1063 * src/main/java/org/glom/web/server/ReportGenerator.java
1064 constructor: Take the localeID so we can get translated field
1066 generateReport(), addToReport(), addFieldToBand(): Add field
1067 titles in a column header band.
1069 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1071 Reports drop-down list: Some improvement.
1073 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1074 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1075 Adedd setSelectedReport(),
1076 setReportList(): Add a blank line so that the user can select the
1078 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1079 start(): Show the current report by calling setSelectedReport().
1080 This does not seem to work yet.
1082 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1084 DetailsActivity, ListActivity: Move some variables into a base class.
1086 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1087 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1088 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1089 the clientFactory, documentID, tableName and authenticationPopup into
1090 a base class, to avoid duplication.
1092 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1094 Translate the Reports label.
1096 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1097 Get the "Reports" label string from the constants.
1098 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1099 perties: Add Reports to the constants.
1101 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1103 Reports: Implement grouping.
1105 * src/main/java/org/glom/web/server/ReportGenerator.java:
1106 Handle LayoutItem_GroupBy items and try to do the right thing
1107 with JRDesignGroup. It seems to work.
1109 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1111 Actually show some data with JasperReports.
1113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1114 getReportHTML(): Move most code into a ReportGenerator class.
1115 * src/main/java/org/glom/web/server/ReportGenerator.java:
1116 Recurse into sub-groups, adding fields to the JasperDesign's details
1117 band. Note that we must set an arbitrary width and height, or it just
1118 will not show any data.
1120 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1122 Reports Chooser: Show the titles, not the names.
1124 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1125 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1126 and the names as the values.
1127 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1128 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1129 group now that we provide the report name, so it should always
1132 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1134 Depend on jasperreports.
1136 * pom.xml: Add the dependency. My plan is to use this on the
1139 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1141 Implement navigation to report places.
1143 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1144 start(): Do not bother to handle all events here.
1145 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1146 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1147 Added getSelectedReport().
1148 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1149 .java: start(): When handling a change to the reports chooser,
1150 call getSelectedReport() and goTo() its ReportPlace.
1151 * src/main/java/org/glom/web/client/ui/ReportView.java
1152 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1153 Added setReportHTML() which puts the html in a gwt HTML widget.
1154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1155 getReportHTML(): Return "TODO" just to show that this works.
1157 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1159 Make ReportPlace usable.
1161 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1162 Mention ReportPlace.
1163 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1164 Correct the @prefix annotation.
1166 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1168 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1170 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1171 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1173 Change getReportLayout() to getReportHMTL() because we will not need to
1174 parse or render the report layout on the client side.
1175 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1176 getReportLayout(): Return the libglom LayoutGroup type because we will
1177 not need to convert to a shared type, because this will not be used on
1179 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1182 Note that there is still no implementation for this.
1185 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1187 Add a (empty) Report Place, View, and Activity.
1189 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1191 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1192 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1193 this into a superclass:
1194 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1195 and also use it as the base of this new ReportPlace:
1196 * src/main/java/org/glom/web/client/place/ReportPlace.java
1198 * src/main/java/org/glom/web/client/ui/ReportView.java
1199 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1200 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1201 Add these, containing mostly boiler-plate for now.
1203 * src/main/java/org/glom/web/client/OnlineGlomService.java
1204 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1205 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1206 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1207 Add API to get the LayoutGroup for the report.
1209 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1211 Add and fill a Reports drop-down list box.
1213 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1215 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1216 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1218 Added getReports(document, table, localeID), calling
1219 ConfiguredDocument.getReports().
1220 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1221 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1222 Added setReportsList() and a list widget.
1223 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1224 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1229 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1231 Translations: Add Esperanto.
1233 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1234 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1235 properties: Add this translation because someone took the time to make it.
1237 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1239 Adapt to the java-libglom 1.21.7 API.
1241 * src/main/java/org/glom/web/server/ReportGenerator.java:
1242 addToReport(): get_group_secondary_fields() is now
1243 get_secondary_fields().
1246 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1248 Use the latest java-libglom version.
1250 * pom.xml: Use java-libglom 1.21.7.
1252 2012-03-03 Ben Konrath <ben@bagu.org>
1254 Display date and time in details view.
1256 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1258 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1260 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1262 Require the latest java-libglom.
1264 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1266 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1268 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1270 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1271 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1272 an empty quickfind string. I also corrected libglom to create only
1273 empty where clauses for empty quickfind strings, but this avoids the
1276 2012-02-24 Ben Konrath <ben@bagu.org>
1278 Improve the tabs in the Notebook widget.
1282 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1284 Translations: Try to translate the strings.
1286 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1287 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1288 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1289 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1290 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1291 Take the Open translation from GTK+'s .po files.
1292 Take the Details translation from Glom's po files.
1293 I have added the other strings to Glom so we can get translations that way:
1294 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1296 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1298 TableSelectionViewImpl: Put the search label and entry in a div.
1300 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1301 Put the search widgets in a FlowTable so that the CSS can be used to
1302 style them while keeping them together.
1303 * src/main/webapp/style.css: Mention the new div.
1305 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1307 Translate more strings in more locales.
1309 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1310 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1311 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1312 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1313 Translate the "Details" and "Open" string too.
1315 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1316 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1317 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1318 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1319 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1320 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1321 Add these new locales as placeholders though they currently contain English.
1323 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1325 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1327 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1328 Check the ConfiguredDocument* for null before using it.
1330 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1332 Tell Eclipse about the generated java files.
1334 * .classpath: This lets it find OnlineGlomConstants.java.
1335 It would be nice if Eclipse just used the maven build files.
1337 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1339 Prevent a crash when no locale is specified in the URL.
1341 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1342 Avoid returning a null string, obtained from
1343 Window.Location.getParameter(). This caused a crash when it was
1344 later passed to libglom's API.
1345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1346 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1347 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1348 guard against future null strings.
1350 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1352 Use the ?locale= query param instead of the &lang= token param.
1354 * src/main/java/org/glom/web/client/place/ListPlace.java
1355 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1356 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1357 Remove the lang token key and value.
1359 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1360 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1361 When the user selects a different locale from the chooser, use
1362 Window.Location.assign() to change the URL, which then causes a reload.
1364 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1365 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1366 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1367 * src/main/java/org/glom/web/client/activity/ListActivity.java
1368 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1369 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1370 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1371 * src/main/java/org/glom/web/client/ui/ListView.java:
1372 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1374 Remove localeID member variables and method/constructor parameters, instead
1375 using Utils.getCurrentLocaleID() when we need a localID to pass to
1378 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1380 Internationalize the UI strings.
1382 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1383 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1384 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1385 because it is unused. Messages are apparently strings that can have
1386 parameters, but we do not need that yet, so Contants will be enough for now.
1387 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1388 to say that we support the en and de locales.
1389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1390 The original English strings.
1391 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1392 Some German translations of the English strings.
1393 The i18n goal then uses the .properties file to generate an
1394 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1395 returns an implementation that returns the translated strings.
1396 The documentation suggests putting these in src/java/*/client/, but it seems
1397 best to put it in src/resources/*/client/.
1398 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1399 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1400 instead of hard-coding them.
1401 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1402 but that does not seem to stop the build, though it confuses Eclipse.
1404 You can see the translated string by adding ?locale=de to the URL, like so:
1405 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1407 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1409 Improve null/empty String checks.
1411 * pom.xml: Add a dependency on commons-lang, to use
1412 org.apache.commons.lang.StringUtils.
1413 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1415 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1416 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1417 Use StringUtils.isEmpty().
1419 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1420 StringUtils class with a static isEmpty() function because we
1421 cannot use org.apache.commons.lang.StringUtils in client-side
1422 GWT code because it (apparently) cannot be compiled to javascript.
1423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1424 * src/main/java/org/glom/web/client/activity/ListActivity.java
1425 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1426 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1427 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1428 * src/main/java/org/glom/web/client/place/ListPlace.java
1429 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1430 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1431 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1432 * src/main/java/org/glom/web/client/ui/details/Group.java
1433 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1434 our StringUtils.isEmpty() function.
1436 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1438 Update to the latest java-libglom API.
1440 * pom.xml: Require java-libglom 1.21.4.
1441 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1442 getDocumentInfo(), getListViewLayoutGroup():
1443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1445 * src/main/java/org/glom/web/server/database/DBAccess.java
1446 getFieldsToShowForSQLQueryAddGroup(),
1447 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1448 with either get_database_title_original() or
1449 get_database_title(localeID).
1451 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1453 ConfiguredDocument: Avoid a null pointer exception.
1455 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1456 Initialize localeID to "" to avoid returning a null String which
1457 causes a crash in java-libglom's swing-generated code.
1459 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1461 Some simple renaming.
1463 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1464 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1465 for localeChooser. This seems more appropriate and is less ambiguous
1466 particularly in the .css file.
1468 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1470 ConfiguredDocument: Rename the localedID private member variable.
1472 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1474 Adapt to the latest java-libglom API from git master.
1476 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1477 libglom now uses only Vector instead of List, which uses add() instead of
1480 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1482 ConfiguredDocument: Rename the localedID private member variable.
1484 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1486 Build a source tarball with mvn assembly:single
1488 * assembly.xml: Add this file.
1489 * pom.xml: Use the maven-assembly-plugin and tell it to use
1490 our assembly.xml file.
1492 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1494 OnlineGlomServiceImpl: Get .glom files recursively.
1496 * pom.xml: Depend on commons-io from org.apache.commons.
1497 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1498 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1499 files recursively, and with the easier filter for the extension.
1500 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1501 simplify that code too.
1503 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1505 README: Mention that you must install java-libglom packages separately.
1507 But then it works, because java-libglom is now in the central maven
1510 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1512 locales drop-down: Show the correct selected locale when the URL changes.
1514 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1515 .java: setPlace(): Move some code into fillView().
1517 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1519 locales drop-down: Do not lose the primary key.
1521 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1522 start(): onLocaleChange(): Pass the current primary key value,
1523 instead of an empty value.
1525 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1527 locales drop-down: Do not lose the drop-down selection.
1529 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1530 .java (TableSelectionActivity.fillView): Set the selected locale
1531 after changing the drop-down items (though we do not really need
1532 to change them just because the locale changes.)
1534 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1536 locales drop-down: Change the tables list when this changes.
1538 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1539 .java: TableSelectionActivity.start(): Move the async table titles
1540 retrieval into a private fillView() method and also call this when
1541 the chosen locale changes.
1542 Note that the document title is not actually translatable yet, but
1543 that is a problem that I should fix soon in libglom.
1545 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1547 Improve the placement of the locales drop-down.
1549 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1550 Put the title and locales drop-down in a div (gwt.FlowTable).
1551 * src/main/webapp/style.css: Add magic css properties to make this work.
1552 Also remove the left margin from the title so that it lines up with the
1555 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1557 locales selector: Show human-readable locale titles.
1559 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1560 getDocumentInfo(): Use java.util.Locale to show a real title of
1561 each locale, in the locale's own language.
1563 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1565 Add a language/locale selector drop-down.
1567 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1568 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1569 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1570 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1571 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1572 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1573 Add a ListBox to show the available locales. Add getLocaleSelector(),
1574 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1575 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1576 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1577 java: Add these classes.
1578 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1579 start(): Fill the locales ListBox. Handle its change event, firing a
1581 setPlace(): Show the selected locale as specified by the URL token.
1582 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1583 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1584 Handle LocaleChangeEvent, going to a new *Place with that locale.
1586 The placement of the ListBox is not pretty, and it currently uses the ID
1587 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1591 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1593 Search box: Show the search text from the URL token.
1595 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1596 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1597 Add setQuickFindText().
1598 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1599 .java: setPlace(): Store the queryText if the place is a ListPlace,
1600 and call TableSelectionView.setQuickFindText().
1602 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1604 Allow use of translations via, for instance, &lang=de in the URL.
1606 * pom.xml: Use the unstable java-libglom 1.21 version.
1608 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1609 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1611 init(): Instead of calling TranslatableItem.set_current_locale()
1612 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1613 However, this is only for default locales, which are not needed to
1614 change the locale in the URL.
1615 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1616 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1617 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1618 layout for a particular locale.
1619 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1620 Add get/setDefaultLocaleID().
1621 getDocumentInfo(), getListViewData(), getRelatedListData(),
1622 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1623 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1624 localeID parameter, so we can get the layout for a particular locale.
1626 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1627 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1628 * src/main/java/org/glom/web/client/place/ListPlace.java:
1629 Parse and construct a lang parameter too.
1631 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1632 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1633 passed to subsequent methods and constructors.
1634 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1635 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1636 Store the localeID from the *Place and pass it to other constructors
1637 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1639 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1640 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1641 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1642 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1643 * src/main/java/org/glom/web/client/ui/ListView.java:
1644 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1645 Take localeID parameters and pass them to subsequent constructors and
1646 methods, so that the layout is always retrieved for that locale.
1648 This is rather repetitive.
1650 Note that "" means the original (default) locale of the Glom document,
1651 which is usually English.
1653 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1655 Documents: Remove final keyword to fix startup configuration.
1657 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1658 final keywords on the private member variables because that breaks
1659 the startup, apparently (there are warnings) because it stops them
1660 from being serialized. I added these in the previous commit.
1662 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1664 Documents: Add some final keywords.
1666 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1669 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1671 OnlineGlomServiceImpl: Add to overview comments.
1673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1674 Note that this is where all the document are loaded. They are not
1675 loaded freshly for each page.
1677 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1681 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1682 Add a TextBox for the text of a quick find.
1683 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1685 setBackLink(): Add a String quickFind parameter.
1686 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1687 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1688 to the base interface, because that is how TableSelectionViewImpl is used.
1689 * src/main/webapp/style.css: Add style for the search box and its label.
1691 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1692 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1693 Add these files, based on the existing TableChangeEvent and
1694 TableChangeEventHandlers.
1695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1696 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1697 a ListPlace() that the user should be taken to.
1698 * src/main/java/org/glom/web/client/activity/ListActivity.java
1699 start(): Handle it here too and adapt the TableChangeEvent handler to
1700 pass the extra "" quickFind parameter to ListPlace.
1701 * src/main/java/org/glom/web/client/place/ListPlace.java:
1702 Constructor: Take an extra String quickFind parameter and store it,
1703 returning it from a new getQuickFind() method.
1704 getToken(): Put the quickFind text in the URL token.
1705 getPlace(): Parse the quickFind text from the URL token.
1706 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1707 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1708 ListPlace constructor.
1709 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1710 .java: start(): Add a Change handler for the TableSelectionView's
1711 TextBox (via its base HasChangeHandlers interface), firing the new
1712 QuickFindChangeEvent.
1713 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1714 pass the extra "" quickFind parameter.
1716 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1717 setCellTable(): Add a String quickFind parameter and pass it to
1718 the ListViewTable() constructor.
1719 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1720 setCellTable() in the base interface, because that is how ListViewImpl
1723 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1724 Add a String quickFind member variable.
1725 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1726 Constructor: Add a String quickFind parameter, storing it in the
1727 base ListTable's member variable.
1728 onRangeChanged(): Pass quickFind to the
1729 OnlineGlomServiceAsync.getSortedListViewData() and
1730 OnlineGlomServiceAsync.getListViewData() methods.
1732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1733 getListViewData(), getSortedListViewData(): Add a String quickFind
1734 parameter, passing it to ConfiguredDocument.getListViewData().
1735 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1736 Change getListViewData(), getSortedListViewData() in the base interface,
1737 because that is how OnlineGlomServiceImpl is used, via this:
1738 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1739 Change getListViewData(), getSortedListViewData() here too.
1740 This class can apparently be used to asynchronously call methods on
1741 OnlineGlomService, and GWT seems to implement that after recognizing
1742 just the *Async name convention and the extra AsyncCallback parameters.
1744 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1745 getListViewData(): Add a String quickFind parameter, and pass it to
1746 ListViewDBAccess.getData().
1747 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1748 getListData(): Add a String quickFind parameter and pass it to
1750 getSelectQuery(): Add a String quickFind parameter.
1751 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1752 getSelectQuery(): Add a String quickFind parameter and use it with
1753 Glom.get_find_where_clause_quick() to pass a where_clause to
1754 Glom.build_sql_select_with_where_clause(), to actually filter the
1756 getData(): Add a String quickFind parameter, passing it to getListData().
1757 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1758 va: getData(): Pass an empty string to getListData() for the
1759 quickFind parameter.
1761 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1763 ListTable: Minor change.
1765 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1766 createCellTable(): Make this protected instead of public.
1768 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1770 Many files: Use final for the parameters and use the @override attribute.
1772 2012-01-22 Ben Konrath <ben@bagu.org>
1774 Add anchor links for single line text that starts with http, ftp and www.
1778 2012-01-22 Ben Konrath <ben@bagu.org>
1780 Add ellipsis to single line text in details view.
1784 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1786 Remove all javadoc author tags.
1788 Because they are awkward and meaningless when many people touch
1790 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1792 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1794 Revert the COPYING.LESSER to COPYING rename.
1796 Apparently both should be there if it is LGPL.
1798 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1800 *View: Remove unused imports.
1802 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1803 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1804 * src/main/java/org/glom/web/client/ui/ListView.java:
1805 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1806 Remove unused imports, as suggested by Eclipse.
1808 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1810 Move the *View::Presenter types, and some API into one base View.
1812 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1813 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1814 * src/main/java/org/glom/web/client/ui/ListView.java:
1815 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1816 Presenter, setPresenter() and clear() into a shared base interface,
1817 to avoid the unnecessary duplicate Presenter types and to more clearly
1818 show how the *Views share the same structure, even if they are not
1819 used polymorphically.
1821 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1822 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1824 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1825 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1826 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1828 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1831 Feel free to revert this if there is a good reason for the duplicate
1834 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1836 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1838 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1839 a class member instead of a local variable in the method.
1840 This lets us use it to get the view instances, for use in tests.
1841 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1842 beforeOnlineGlom(): Test some more details of the initial view.
1843 Again, this is not very useful.
1845 To really test gwt-glom we will need to start a local postgresql
1846 instance with local data, like the Glom tests in C++.
1848 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1850 pom.xml: Mention the LGPL license.
1852 * pom.xml: Add a licenses section.
1853 * COPYING.LESSER: Move this to COPYING, which
1854 previously contained the GPL. But gwt-glom is all LGPL.
1856 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1858 Add project information to README and pom.xml.
1860 * README: Add a brief description and mention some mvn
1862 * pom.xml: This extra information shows up in mvn site
1865 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1867 Use the latest java-libglom version.
1869 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1871 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1873 GwtTestOnlineGlom: Test a little more.
1875 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1876 protected rather than private, as suggested by the gwt-test-utils
1878 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1879 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1880 Test the initial visibility of the panels.
1882 However, this is not a very useful test.
1883 And I wonder how we should generally test using this idea for an
1884 activity/places app like ours where the real changes happen implicitly
1885 based on the history token/URL.
1887 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1889 Slight modification to *Mapper comments.
1891 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1892 (DataActivityMapper)
1893 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1895 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1897 Remove comments mentioning GIN because they are just copied from
1898 the example code and are apparently not helpful:
1899 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1900 Also change the mention of a class that is only in the example code.
1902 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1904 GwtTestOnlineGlom test: Minor changes.
1906 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1907 Avoid the long qualified class name and modify the comment
1908 because it is now obvious to me that the mocked class is the only
1909 custom one created via GWT.create().
1911 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1913 Tests: Added the beginnings of a test using gwt-test-utils.
1915 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1916 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1917 which tells gwt-test-utils what class will be tested.
1918 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1919 Add a simple (but empty) test case. One class, used by the OnlineGlom
1920 class, is mocked so that it can be created. However, I am not sure
1921 why only this class needs to be mocked.
1923 Note that mockito seems more popular, and clearer, than easymock,
1924 but I have not got that working yet. It might be a matter of the
1927 This test is run during mvn integration-test.
1929 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1931 Tests: Use junit4-style syntax instead of junit3-style.
1933 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1934 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1935 * src/test/java/org/glom/web/shared/DataItemTest.java:
1936 Use the @Test annotation rather than relying on the test*() prefix.
1937 Also no longer implement TestCase, to avoid triggering support for
1938 the junit3-way, which stops the annotations from working.
1939 Change the imports from import junit.framework.* to
1940 import org.junit.*, which is apparently the new way.
1942 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1944 Added a test for ListPlace token parsing and creation.
1946 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1947 This is much the same as DetailsPlaceTest.
1949 I wonder how we could test the other parts of the *Place API.
1951 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1953 DetailsPlace test: Also test getToken() and recreation via getPlace().
1955 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1956 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1957 recreate it, testing the recreated DetailsPlace for the same parameter
1960 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1962 Use the surefire-report plugin.
1964 * pom.xml: This generates a HTML report about the tests in
1965 target/site/surefire-report.html
1966 when you do mvn surefire-report:report. It seems to be popular/normal.
1968 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1970 Added a test for DetailsPlace.
1972 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1973 Test the getPlace() token parsing.
1975 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1977 Added a first unit test.
1979 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1980 * src/test/java/org/glom/web/shared/DataItemTest.java:
1981 This is a silly test but it is just to get things started. Note that
1982 maven/junit finds the test because it looks in src/test by default.
1984 2011-12-22 Ben Konrath <ben@bagu.org>
1986 Change charsetName to "UTF-8" when replacing line breaks.
1988 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1989 that work in Java (such as "UTF8") will not work when compiled to
1992 This fixes a problem with multi-line details view fields that have hard
1993 line breaks. The "License Text" field on this page demonstrates the
1996 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1998 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2000 2011-12-22 Ben Konrath <ben@bagu.org>
2002 Fix another bug with related list navigation.
2004 I've tested all the navigation buttons in all of the related lists
2005 so things should be good now.
2007 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2009 2011-12-22 Ben Konrath <ben@bagu.org>
2011 Fix a crasher when refreshing the list view with the default table.
2013 This crash will also happen when loading the list view with the default
2014 table from a link or bookmark.
2016 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2017 to the main document selection page when the document id hasn't been
2019 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2020 the main document selection page when the document id hasn't been
2022 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2023 values for the details place when the document id hasn't been set.
2024 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2025 values for the list place when the document id hasn't been set.
2027 2011-12-21 Ben Konrath <ben@bagu.org>
2029 Protect against NPE when glom.document.locale is not in config.
2031 This patch protects against an NPE when glom.document.locale is not in
2032 the config file. This NPE will also happen if glom.document.locale is
2035 The patch also updates the error message to display the class name when
2036 the getMessage() returns null. This was happening when the NPE was
2037 thrown and I had "Configuration Error: null". If an NPE is encountered
2038 with this patch, "Configuration Error: NullPointerException " will be
2041 This commit closes this bug:
2043 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2047 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2049 Rename onlineglom.properties to onlineglom.properties.sample.
2051 * src/main/resources/onlineglom.properties: Rename to:
2052 * src/main/resources/onlineglom.properties.sample:
2053 * src/main/resources/README: And add this file explaining that people
2054 should rename it back when deploying.
2056 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2058 Allow choosing the translation in the .properties file.
2060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2061 init(): Read a glom.document.locale value from the configuration file
2062 and call Glom's TransatableItem::set_current_locale() method.
2063 * src/main/resources/onlineglom.properties: Add a commented-out
2064 example of this new setting.
2066 It would be better to add &lang=de_DE to the URL, but the current
2067 libglom API does not allow us to do this easily. I am working on that.
2069 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2071 Avoid a crash in parsing of token parameters.
2073 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2074 ava: getTokenParams(): Do not crash if a parameter has a key but no
2075 value, and ignore parameters with neither.
2077 2011-12-17 Murray Cumming <murrayc@murayc.com>
2079 History token building/handling: Improve use of token parameters.
2081 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2082 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2083 and buildParamsToken(HashMap), for use by derived classes.
2084 Make the separator private because it is no longer be needed.
2085 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2086 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2087 instead of manual string concatenation.
2088 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2089 of hardcoded indices and awkward splitting code.
2090 * src/main/java/org/glom/web/client/place/ListPlace.java
2091 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2092 instead of manual string concatenation.
2093 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2094 of hardcoded indices and awkward splitting code.
2095 This should fix bug #666420
2097 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2099 Fix a Navgiation->Navigation typo in the code.
2101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2102 Rename processNavgiation() to processNavigation().
2104 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2106 Fix a seperator->separator typo in the code.
2108 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2109 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2110 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2113 2011-12-15 Ben Konrath <ben@bagu.org>
2115 Cleanup some comments.
2117 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2119 2011-12-14 Ben Konrath <ben@bagu.org>
2121 Replace \n with <br/> for multiline text in the details view.
2123 Vertical scrollbars are added when needed as well.
2125 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2127 2011-12-14 Ben Konrath <ben@bagu.org>
2129 Specify the font for document selection links.
2131 * src/main/webapp/style.css:
2133 2011-12-14 Ben Konrath <ben@bagu.org>
2135 Fix bouncy CellTable while paging.
2137 This doesn't currently work with related list tables in unselected
2140 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2142 2011-12-14 Ben Konrath <ben@bagu.org>
2144 Revamp the appearance of the document selection page.
2146 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2147 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2148 * src/main/webapp/style.css:
2150 2011-12-13 Ben Konrath <ben@bagu.org>
2152 Set navigation button column to the smallest size possible.
2154 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2156 2011-12-13 Ben Konrath <ben@bagu.org>
2158 Change OpenButton nomenclature to NavigationButton.
2160 Using NavigtionButton makes things more generic. Classes, methods and
2161 variables have been changed.
2163 This is a rename-only refactor.
2165 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2166 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2167 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2168 Renamed from OpenButtonCell.
2169 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2170 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2171 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2173 2011-12-12 Ben Konrath <ben@bagu.org>
2175 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2177 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2178 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2179 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2180 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2182 2011-12-12 Ben Konrath <ben@bagu.org>
2184 Update variable names and comments.
2186 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2187 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2189 2011-12-12 Ben Konrath <ben@bagu.org>
2191 Properly initialize numNonEmptyRows variable to zero.
2193 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2194 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2196 2011-12-05 Ben Konrath <ben@bagu.org>
2198 Add latest mockup with HTML tables.
2200 Features of this mockup:
2202 -> HTML table for flowtable
2203 -> HTML table for flowtable column
2204 -> Example of how related lists would look
2205 -> Not using text entries for data items
2207 The current version of Online Glom doesn't use HTML tables for the
2210 This mockup has been sent to the glom-devel mailing list but it's good
2211 to have it here as well.
2213 * mockups/details-view-html-tables.html:
2215 2011-12-05 Ben Konrath <ben@bagu.org>
2217 Remove unnecessary getPrimaryKeyField() method.
2219 getPrimaryKeyFieldForTable(String) has been renamed to
2220 getPrimaryKeyField(String).
2222 * src/main/java/org/glom/web/server/database/DBAccess.java:
2223 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2224 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2226 2011-12-05 Ben Konrath <ben@bagu.org>
2228 Add string representation of TypedDataItem value to conversion error message.
2230 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2231 message was extracted into its own method to avoid duplication.
2233 2011-12-05 Ben Konrath <ben@bagu.org>
2235 Add type checking to navigation primary key value creation.
2237 Create navigation primary key only if the expected type from the Glom
2238 document matches the type returned by the SQL query.
2240 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2242 2011-12-05 Ben Konrath <ben@bagu.org>
2244 Rename a couple of variables in RelatedListNavigation.
2246 This is a rename-only refactor.
2248 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2250 2011-12-05 Ben Konrath <ben@bagu.org>
2252 Move getListLayoutGroup() into getListViewLayoutGroup().
2254 This removes getListLayoutGroup(). It was only being called by
2255 getListViewLayoutGroup().
2257 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2259 2011-12-05 Ben Konrath <ben@bagu.org>
2261 Remove check for LayoutItem_Portal in list table method.
2263 This check is no longer necessary because the method isn't being used
2264 to create the LayoutItemPortal DTO.
2266 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2268 2011-12-05 Ben Konrath <ben@bagu.org>
2270 Properly support related list navigation.
2272 Navigation from the "Repository Analyzer -> Package Scans ->
2273 Dependencies" related table wasn't working because the primary key for
2274 related tables wasn't being set properly. This commit fixes the
2277 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2278 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2279 doesn't set the primary key properly for related list tables.
2280 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2281 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2282 useful for getting the primary key for list view tables and for related
2284 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2285 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2286 Move code to set the primary key for the table from the abstract
2287 ListDBAccess class to ListViewDBAccess as it's only correct for list
2289 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2290 Properly add primary key to related list tables.
2292 2011-12-02 Ben Konrath <ben@bagu.org>
2294 Properly set the horizontal alignment of fields.
2296 This fix is for both the list tables and the details view.
2298 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2299 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2300 to set the horizontal alignment of fields.
2302 2011-12-02 Ben Konrath <ben@bagu.org>
2304 Display currency codes in the details view.
2306 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2308 2011-12-02 Ben Konrath <ben@bagu.org>
2310 Avoid duplicate JNI call.
2312 JNI is not as efficient as pure Java and this is an easy (and small)
2315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2316 Use previously retrieved value for whereClauseToTableName instead of
2319 2011-12-02 Ben Konrath <ben@bagu.org>
2321 Rename a couple of variables in RelatedListNavigation.
2323 This is a rename-only refactor.
2325 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2327 2011-12-02 Ben Konrath <ben@bagu.org>
2329 Indicate clearly that a mismatched primary key type is a bug.
2331 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2332 warning to error. Add 'This is a bug.' to message.
2334 2011-12-02 Ben Konrath <ben@bagu.org>
2336 Update / fix some comments.
2338 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2340 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2342 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2343 Fix comments. Add some TODOs.
2345 2011-12-02 Ben Konrath <ben@bagu.org>
2347 Enable navigation to details view with string primary key from related list.
2349 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2350 Create a text primary key value when return type of result is
2351 java.sql.Types.VARCHAR.
2353 2011-12-02 Ben Konrath <ben@bagu.org>
2355 Use checkboxes for booleans in the details view.
2357 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2359 2011-12-01 Ben Konrath <ben@bagu.org>
2361 Improve performance of related list height calculation.
2363 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2364 Put code to calculate the expected height in a static initializer so
2365 that that it's only called once.
2367 2011-12-01 Ben Konrath <ben@bagu.org>
2369 Show related list tables in notebooks (again).
2371 Calculate the height of the related list tables so the Notebook can be
2372 set the correct height. The height of the related list table is also needed by
2373 FlowTable to be able decide how to create the layout.
2375 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2376 and set the Portal height based on the height of the related list
2377 table and the Portal container.
2378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2379 Add method to calculate the height of the related list tables.
2380 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2381 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2382 calculate the height of the Pager widget.
2384 2011-12-01 Ben Konrath <ben@bagu.org>
2386 Use CellTable API for table property instead of setting style on Element.
2388 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2390 2011-12-01 Ben Konrath <ben@bagu.org>
2392 Make ListViewTable and RelatedListTable a consistent height.
2394 The tables are now a consistent height regardless of the contents of
2395 the table. A hidden button is added to empty rows to ensure that the
2396 height of these rows will match the height of rows with data.
2398 A navigation button column is now added to every table. The width of
2399 the navigation column is set to 0px when a RelatedListTable shouldn't
2400 have navigation buttons. This maintains the a consistent row height in
2401 tables that don't show the navigation buttons.
2403 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2404 navigation column when not needed.
2405 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2406 arguments for navigation button to constructor of ListViewTable.
2407 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2408 hidden button for empty data rows.
2409 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2410 arguments for navigation button to constructor.
2411 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2412 create navigation buttons. Add hideNavigationButtons() method.
2413 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2414 arguments for navigation button to constructor.
2416 2011-12-01 Ben Konrath <ben@bagu.org>
2418 Use 'visibility: hidden' in Utils.getWidgetHeight().
2420 This is better choice because hidden elements are invisible, don't
2421 respond to events and are not part of the tab order. They will,
2422 however, take up space which is required to be able to calculate the
2423 height of the widget.
2425 * src/main/java/org/glom/web/client/Utils.java:
2427 2011-12-01 Ben Konrath <ben@bagu.org>
2429 Use Utils.getWidgetHeight() in FlowTable.
2431 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2433 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2435 2011-12-01 Ben Konrath <ben@bagu.org>
2437 Put the details css class name on the correct table column.
2439 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2441 2011-11-30 Ben Konrath <ben@bagu.org>
2443 Update for java-libglom API change.
2445 The getters and setters on FieldFormatting and NumericFormat were
2446 changed to remove the 'M'.
2448 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2450 2011-11-29 Ben Konrath <ben@bagu.org>
2452 Only allow RelatedListTables in Portals.
2454 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2456 2011-11-29 Ben Konrath <ben@bagu.org>
2458 Only create a contents panel for Portals when title is being set.
2460 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2462 2011-11-29 Ben Konrath <ben@bagu.org>
2464 Set TabLayoutPanel height based on calculated height its widgets.
2466 This is a potential fix for this bug:
2468 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2470 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2472 2011-11-29 Ben Konrath <ben@bagu.org>
2474 Align details field labels and data with the Open buttons.
2476 * src/main/webapp/style.css:
2478 2011-11-29 Ben Konrath <ben@bagu.org>
2480 Remove unnecessary <div> in the Notebook widget.
2482 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2483 method to get container FlowPanel (<div>).
2484 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2485 initWidget() method directly on the TabLayoutPanel widget instead of
2486 Group's container widget.
2488 2011-11-29 Ben Konrath <ben@bagu.org>
2490 Don't add group titles for Portals in Notebooks.
2492 This reverts the previous patch and fixes a bug I introduced with
2493 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2495 * src/main/java/org/glom/web/client/ui/details/Group.java:
2496 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2498 2011-11-28 Ben Konrath <ben@bagu.org>
2500 Remove unused boolean argument in Portal constructor.
2502 Just a code cleanup.
2504 * src/main/java/org/glom/web/client/ui/details/Group.java:
2505 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2507 2011-11-28 Ben Konrath <ben@bagu.org>
2509 Remove hack for glom 1.18 style glom files.
2511 * src/main/java/org/glom/web/client/ui/details/Group.java:
2512 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2513 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2515 2011-11-28 Ben Konrath <ben@bagu.org>
2517 Use Gda Value version of primary key to log result too large error.
2519 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2521 2011-11-28 Ben Konrath <ben@bagu.org>
2523 Don't use TypedDataItem.getText() for Unknown types from the URL.
2525 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2526 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2527 instead of getText().
2528 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2529 String field and getUnknown() method.
2531 2011-11-28 Ben Konrath <ben@bagu.org>
2533 Log an error message when the java-libglom .so is not present.
2535 The error message was being set in the exception but not logged.
2537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2539 2011-11-28 Ben Konrath <ben@bagu.org>
2541 Ignore LayoutItem_CalendarPortals.
2543 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2544 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2546 2011-11-28 Ben Konrath <ben@bagu.org>
2548 Extract method for creating the LayoutItemPortal DTO.
2550 Just breaking the code up into smaller chunks.
2552 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2554 2011-11-28 Ben Konrath <ben@bagu.org>
2558 This should have been added with the refactor. Oops!
2560 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2562 2011-11-28 Ben Konrath <ben@bagu.org>
2564 Create primary key value from URL string using type from Glom document.
2566 See this bug, comments 19 - 25:
2568 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2570 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2571 create a TypeDataItem for the primary key here when loading from a
2572 URL. Show the same string for the primary key value as was received
2573 from the URL string (when loading from a URL).
2574 * src/main/java/org/glom/web/server/Utils.java: Update method for
2575 creating the Gda Value from the TypeDataItem to properly deal with
2576 creating a Gda Value based on the Glom document type for the primary
2577 key value string when loading from a URL.
2578 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2579 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2580 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2581 Update for changed method name.
2583 2011-11-27 Ben Konrath <ben@bagu.org>
2585 Rename PrimaryKeyItem to TypedDataItem.
2587 The name PrimaryKeyItem suggests what the class should be used for.
2588 TypedDataItem is a neutral name that describes the class better.
2590 This is a rename-only refactor.
2592 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2593 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2594 * src/main/java/org/glom/web/client/Utils.java:
2595 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2596 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2597 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2598 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2599 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2600 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2602 * src/main/java/org/glom/web/server/Utils.java:
2603 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2604 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2605 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2606 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2608 2011-11-25 Ben Konrath <ben@bagu.org>
2610 Improve Gda Value conversion from PrimaryKeyItem.
2612 The value from the PrimaryKeyItem is only used if its type match the
2613 type from the glom document.
2615 * src/main/java/org/glom/web/server/Utils.java:
2617 2011-11-25 Ben Konrath <ben@bagu.org>
2619 Manually check if the java-liblgom .so is visible to the JVM.
2621 It seems that Tomcat has problems when a static initializer throws an
2622 exception. This check is done before the first method call into
2623 java-libglom so that execution doesn't continue if the .so is not
2626 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2628 2011-11-25 Ben Konrath <ben@bagu.org>
2630 Improve browser configuration error messages.
2634 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2636 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2637 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2638 getConfigurationErrorMessage() method.
2639 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2640 Get and display a specific configuration error message when no Glom
2641 documents are found.
2642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2643 Implement getConfigurationErrorMessage() method. Surround configuration
2644 code in the init() method with a try/catch block. This allows the
2645 errors to be caught while keeping the servlet available to retrieve the
2646 configuration error message.
2648 2011-11-25 Ben Konrath <ben@bagu.org>
2650 Don't use Strings to hold primary key values.
2652 The primary key values are now held in a new data object
2653 (PrimaryKeyItem) that holds type information and the primary key value
2654 using the correct type.
2656 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2657 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2658 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2659 PrimaryKeyItem instead of String to hold the primary key value.
2660 * src/main/java/org/glom/web/client/Utils.java: Remove
2661 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2662 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2663 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2664 PrimaryKeyItem instead of String to hold the primary key value. Load
2665 document selection page when the documentID has not been set correctly.
2666 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2667 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2669 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2670 Return empty string for URL instead of "null".
2671 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2672 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2673 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2674 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2675 PrimaryKeyItem instead of String to hold primary key values.
2676 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2677 PrimaryKeyValue to a Gda Value.
2678 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2679 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2680 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2681 Replace temporary database access code that uses the PrimaryKeyValue to
2682 Gda Value conversion.
2683 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2684 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2685 PrimaryKeyItem instead of String.
2686 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2687 hold primary key values.
2689 2011-11-24 Ben Konrath <ben@bagu.org>
2691 Use newly added java-libglom API to create queries.
2693 This isn't finished. I still need to stop using Strings for primary key
2694 values in the client code.
2696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2697 libglom to use fake connections so that retrieving the query string will
2699 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2700 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2701 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2702 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2703 Use the newly added libglom sql methods and classes to create the
2704 query. Add temporary hack to convert primary value strings to Gda
2707 2011-11-23 Ben Konrath <ben@bagu.org>
2709 Don't explicitly set the height of Portals.
2711 See comments 6 - 10 of this bug for details:
2713 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2715 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2717 2011-11-23 Ben Konrath <ben@bagu.org>
2719 Use an HTML table instead of CSS for the FlowTable layout.
2721 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2722 GWT's FlexTable to implement the FlowTable.
2723 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2725 2011-11-18 Ben Konrath <ben@bagu.org>
2727 Add boolean example to HTML table mockup.
2729 * mockups/details-view-html-tables-text-entries.html:
2731 2011-11-17 Ben Konrath <ben@bagu.org>
2733 Ensure the pager buttons are always visible for related lists.
2735 To accomplish this, I've turned off text wrapping in the list view and
2736 related list tables for both the header and data text. The related list
2737 table now has a fixed layout so the it doesn't overflow its container.
2738 This is required to ensure that the cell text is clipped when it
2739 overflows the cell and an ellipsis is added to the right side of the
2740 cell when text is clipped.
2742 A fixed table layout for the related list table in the details view
2743 seems what we want for the details view anyway, so the side-effect is
2746 The ellipsis will only be displayed in Firefox >= 7.
2750 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2752 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2753 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2754 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2756 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2757 Set the 'table-layout: fixed' CSS property to the related list table.
2758 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2759 'white-space: nowrap;' CSS property on both the list view and the
2760 related list tables.
2762 2011-11-16 Ben Konrath <ben@bagu.org>
2764 Rework the fix for empty notebook tab labels.
2766 Setting the empty group titles with its name caused problems for the
2767 details layout. Instead of using libglom's
2768 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2769 to the client when the title is empty. This allows the Notebook to use
2770 the name when the title is empty without affecting anything else.
2772 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2773 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2775 2011-11-16 Ben Konrath <ben@bagu.org>
2777 Set group titles with name when title is empty.
2779 This fixes a problem with an empty notebook tab label in the Lesson
2780 Planner document. The forth tab in the notebook should be "Internet":
2782 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2784 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2785 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2788 2011-11-16 Ben Konrath <ben@bagu.org>
2790 Remove whitespace from the configured username properties.
2792 This assumes that usernames won't have whitespace at the beginning
2793 or end. But I think this is a reasonable assumption.
2795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2796 String.trim() to remove the whitespace from the username properties.
2798 2011-11-15 Ben Konrath <ben@bagu.org>
2800 Add details view mockup with HTML tables and text entries.
2802 This is from the attachment on this bug:
2804 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2806 * mockups/details-view-html-tables-text-entries.html:
2808 2011-11-15 Ben Konrath <ben@bagu.org>
2810 Add space between the columns of the flow table.
2814 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2816 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2817 space between columns in the flow table.
2819 2011-11-15 Ben Konrath <ben@bagu.org>
2821 Add backup files to the .gitignore.
2823 * .gitignore: Ignore files that end with ~.
2825 2011-11-09 Ben Konrath <ben@bagu.org>
2827 Use latest release of gwt-log.
2829 Gwt-log releases are now being submitted to the maven central
2830 repository so manual installation of the jar is no longer required.
2832 * pom.xml: Update version and groupId of gwt-log dependency.
2834 2011-10-31 Ben Konrath <ben@bagu.org>
2836 Don't use GWT numeric formatting to override the glom currency formatting.
2838 Currencies are now displayed like they are in Glom. See this bug:
2840 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2842 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2844 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2845 currency code to constructor and set it when the cell is rendered.
2846 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2847 currency code to the constructor of the NumericCell.
2849 2011-10-27 Ben Konrath <ben@bagu.org>
2851 Require the latest release of java-libglom (1.17.4).
2855 2011-10-26 Ben Konrath <ben@bagu.org>
2857 Add style to Notebook that matches current theme.
2859 It's not the best style in the world but it's better than the default.
2861 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2862 padding at the bottom of the child widgets.
2863 * src/main/webapp/style.css: Add style for the Notebook.
2865 2011-10-26 Ben Konrath <ben@bagu.org>
2867 Move servlet initialization code to overridden init method.
2869 This is half of the solution to getting proper error messages
2870 displayed when configuration errors occur. Here's the relevant bug:
2872 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2874 The rest of the solution involves surrounding the init method with a
2875 try/catch block and setting a global variable with the error /
2876 exception. A new async method should be created to retrieve and display
2877 the error message / exception.
2879 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2880 code from constructor to init method adding exceptions as needed.
2882 2011-10-26 Ben Konrath <ben@bagu.org>
2884 Add script to monitor and restart tomcat if required.
2886 * utils/check-and-recover-tomcat.py: New file.
2888 2011-10-26 Ben Konrath <ben@bagu.org>
2890 Display the correct number of data items in the pager.
2894 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2896 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2897 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2898 The implementation is the same for both tables: Keep track of the
2899 number of non-empty rows and fire and RowCountChangeEvent after the data has
2901 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2902 custom Pager class that subclasses SimplePager to handle displaying
2903 the correct number when empty rows have been added.
2905 2011-10-26 Ben Konrath <ben@bagu.org>
2907 Correct error in previous commit.
2909 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2910 eventBus parameter from listView.setCellTable().
2912 2011-10-26 Ben Konrath <ben@bagu.org>
2914 Fix error in TODO comment.
2916 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2918 2011-10-24 Ben Konrath <ben@bagu.org>
2920 Create Notebook widgets to the details view.
2922 This isn't finished just yet - I still need to create a reasonable
2923 style to match the current theme.
2925 * src/main/java/org/glom/web/client/Utils.java: Add method for
2926 calculating the height of a widget. This is used in the Notebook class.
2927 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2928 new constructor method in Group.
2929 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2930 method for creating child widget that can be used by subclasses
2931 like Notebook. New constructor that allows disabling the group
2932 titles - Notebooks don't set a group title for their child groups.
2933 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2934 to make Notebooks using GWT's TabLayoutPanel.
2935 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2936 constructor that allows disabling the group titles.
2937 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2938 LayoutItemNotebook DTO.
2939 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2940 DTO for Notebooks. It's just an empty class for now but we might need
2941 it to transfer some specific information in the future.
2943 2011-10-21 Ben Konrath <ben@bagu.org>
2945 Add navigation buttons to related list tables.
2947 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2948 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2949 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2950 method getSuitableRecordToViewDetails() for getting the table name
2951 and primary key value for related list navigation buttons.
2952 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2953 private cell renderer class to get the navigation information for
2954 related list tables from the server. Extract the navigation
2955 processing code from the details cell navigation and use it for the
2956 related list navigation as well.
2957 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2958 cell renderer class for the details open buttons. This was needed
2959 because the related list navigation buttons and the list view
2960 navigation buttons need to react differently when clicked.
2961 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2962 the onEnterKeyDown() method because it's now overriden in the
2963 subclasses that are specific to the related list tables and the list
2965 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2966 the vertical size a little because the buttons add a bit of vertical
2967 space to table. This is not a perfect solution because the vertical
2968 size of with table fewer than 5 rows will be a little smaller.
2969 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2970 changes in how navigation buttons are handled.
2971 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2972 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2973 database access object.
2974 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2975 to find the portal for a given relationship name from
2976 RelatedListDBAccess. Add method to find a primary key field for a
2978 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2979 Move code to find the portal for a given relationship name to
2981 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2982 New file: database access object for getting the related list
2983 navigation information (the table name and the primary key value).
2984 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2985 DTO for transferring a table name to navigate to and a primary key
2987 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2988 boolean and getter/setter to specifies if the related list should add
2991 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2993 Use the master branch of java-libglom
2995 * pom.xml: Depend on java-libglom 1.19 instead.
2997 This is the master branch. See also the libglom-1-18 branch.
2999 2011-10-11 Ben Konrath <ben@bagu.org>
3001 Enable the open navigation button when the data has been set.
3003 This avoids having active buttons that don't do anything when the data
3006 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3008 2011-10-11 Ben Konrath <ben@bagu.org>
3010 Use IsWidget interface for FlowTableItem.
3012 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3013 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3015 2011-10-11 Ben Konrath <ben@bagu.org>
3017 Remove GWT styling from open button in details view.
3019 There are still some issues with how the details cell is arranged but
3020 this should be made to match Glom 1.20. I'm going to leave fixing this
3021 until I have Glom 1.20 up and running.
3023 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3024 style name on open button.
3025 * src/main/webapp/style.css: Move and edit details-navigation class.
3026 Re-arrange some classes to make them appear in the same order as the
3029 2011-10-07 Ben Konrath <ben@bagu.org>
3031 Update to GWT 2.4.0.
3033 * .gitignore: Ignore new cache directory.
3034 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3035 * pom.xml: Change GWT and maven plugin to 2.4.0.
3036 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3038 * src/main/java/org/glom/web/client/ClientFactory.java:
3039 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3040 * src/main/java/org/glom/web/client/OnlineGlom.java:
3041 Update source for API changes.
3042 * utils/build-onlineglom-war.sh: Remove cache directory before the
3045 2011-10-07 Ben Konrath <ben@bagu.org>
3047 Add navigation buttons in the details view.
3049 This isn't finished but I thought I'd commit what I have as it's a
3050 pretty good start. I still need to:
3052 1. Change the style so that it fits better into the current theme
3053 2. Adjust the details cell to expand as much as possible.
3055 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3056 click handlers to navigation buttons in the DetailsCells. Create a
3057 refreshData() method to get just the data from the server without the
3059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3060 Update the tableSelector and browser title when the table name
3061 changes without using the tableSelector.
3062 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3063 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3064 getDetailsCells() to getCells(). Update variable names.
3065 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3066 method to set click handler on navigation button. Rename a few
3067 variables. Add navigation buttons where needed.
3068 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3069 variables and methods.
3070 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3071 navigation boolean and navigation table as required in the
3072 LayoutItemField DTO.
3073 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3074 variables for navigation along with getter/setter methods.
3076 2011-10-07 Ben Konrath <ben@bagu.org>
3078 Rename Field to DetailsCell.
3080 This is a refactor-only commit. No functionality has been added or
3083 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3084 Update variable and method names.
3085 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3086 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3087 variable and method names.
3088 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3090 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3091 variable and method names.
3093 2011-10-07 Ben Konrath <ben@bagu.org>
3095 Create separate methods for layout and data the details view.
3097 This is a refactor-only commit. No functionality has been added or
3100 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3101 private methods: setData(), createLayout().
3103 2011-10-07 Ben Konrath <ben@bagu.org>
3105 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3107 This is part of a change to get navigation buttons in the details view
3108 but it should have been done this way from the start.
3110 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3111 for method name change in TableSelectionView.
3112 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3113 Create TableChangeEvent and set the browser title using the
3114 TableSelectionView API.
3115 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3116 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3117 Change getSelectedTable() to getSelectedTableName(). Add
3118 getSelectedTableTitle().
3120 2011-10-07 Ben Konrath <ben@bagu.org>
3122 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3124 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3126 2011-10-07 Ben Konrath <ben@bagu.org>
3128 Update TableChangeEvent to use newTableName naming convention.
3130 This makes the class more consistent with GWT naming conventions.
3132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3133 Update for method name change in TableChangeEvent.
3134 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3135 for method name change in TableChangeEvent.
3136 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3137 newTableName variable and getter method. Make toDebugString()
3140 2011-09-30 Ben Konrath <ben@bagu.org>
3142 Disable the pager in the list tables when the data row count is less than the minimum.
3144 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3145 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3147 2011-09-30 Ben Konrath <ben@bagu.org>
3149 Add empty rows to the end of related list and list view tables.
3151 I also extracted the cell rendering classes from the ListTable because
3152 the code was becoming a little crazy with all the anonymous inner
3153 classes. My plan is to use these cell rendering classes in the details
3154 view as well so this refactor will be needed for that change.
3156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3157 set the row count in related list tables if the data has more rows
3158 than the minimum number of rows visible.
3159 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3160 row count in list view tables if the data has more rows than the
3161 minimum number of rows visible.
3162 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3163 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3165 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3166 for rendering TYPE_NUMERIC cells. The code was extracted from the
3168 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3169 class for rendering cells with buttons in list views. The code was
3170 extracted from the ListTable class.
3171 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3172 for rendering TYPE_TEXT cells. The code was extracted from the
3174 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3175 Add empty rows to the end of the data if required. Implement
3176 ListTable.getMinNumVisibleRows().
3177 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3178 cell renderer code to public classes. Return null in
3179 Column.getValue() for empty rows. Add new abstract method:
3180 getMinNumVisibleRows(). Move code to set the row count of the list view
3181 table to ListViewImpl.
3182 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3183 empty rows to the end of the data if required. Implement
3184 ListTable.getMinNumVisibleRows().
3187 2011-09-27 Ben Konrath <ben@bagu.org>
3189 Use GWT.log for client-side debugging statements.
3191 These are optimized out when deployed so I should have used this method
3192 in the first place. These statements will eventually be replaced with some sort
3193 of notification in the browser.
3195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3196 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3197 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3198 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3199 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3201 2011-09-27 Ben Konrath <ben@bagu.org>
3203 Put tableselector on the right, back to list link on right.
3205 The idea is that the table selector is acting like a label for the
3206 currently displayed table so it should be placed below the document title. This
3207 puts the table title in a similar position to where it is in Glom.
3209 * mockups/details-contacts.html:
3210 * mockups/details-projects.html:
3211 * mockups/listview-contacts.html:
3212 * mockups/listview-projects.html:
3213 * mockups/style.css:
3214 Update mockups to match how the interfaces currently look.
3215 * src/main/webapp/style.css: Swap positions of backlink with the table
3216 selector. Add some space on the left side of the table selector to
3217 line things up with the document title.
3219 2011-09-27 Ben Konrath <ben@bagu.org>
3221 Add field colouring to details view.
3223 This change re-works how field colouring works. The colour formatting
3224 information is now set to the client with the layout information instead of
3225 with the data. This eliminates the need to send the same colour strings for
3226 data in list view column when colour information is set.
3228 In order to set an alternate colour for negative numeric values, the
3229 number is now sent to client and formatted with the GWT NumberFormat class.
3231 This change also fixes:
3233 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3235 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3236 internationalization framework which is needed for client side numeric
3238 * src/main/java/org/glom/web/client/Utils.java: New file for some
3239 client static utility methods.
3240 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3241 the DataItem object to the Field class. Use a utility method to
3242 create the foreignKeyValue string.
3243 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3244 alignment and text colours in the constructor. Add setData(DataItem)
3245 method. Remove setText(String) method.
3246 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3247 colour information to GlomTextCell. Create and use GlomNumberCell for
3248 rendering numbers. Use utility method to get the string for the
3249 primary key of the key provider. Re-work how the horizontal alignment
3251 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3252 formatting to layout information. Methods for converting the libglom
3253 formatting information were moved from DBAccess.
3254 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3255 numeric formatting (it's now done on the client side). Don't set text
3256 colours in DataItem. Move libglom formatting conversion methods to
3258 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3259 getters/setters for text colour information.
3260 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3261 for transferring the libglom NumericFormat information to the client.
3262 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3263 and getters/setters for: GlomNumericFormat,&n