1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
5 2012-05-06 Murray Cumming <murrayc@murrayc.com>
7 Translatable: Use Hashmap instead of Treemap because GWT supports it.
9 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
10 The use of Treemap lead to this error from async methods, with no
12 "The response could not be deserialized"
14 2012-05-06 Murray Cumming <murrayc@murrayc.com>
16 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
18 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
19 when using the Google -> GWT Compile, or
20 g toolbar button -> GWT Compile Project... feature in Eclipse.
22 2012-05-06 Murray Cumming <murrayc@murrayc.com>
24 ListTable.addColumn(): Protect against a null Formatting.
26 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
27 Create a default Formatting if it is null, because that is the simplest
30 2012-05-06 Murray Cumming <murrayc@murrayc.com>
32 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
34 * src/main/java/org/glom/web/server/ConfiguredDocument.java
35 updateLayoutGroup(): Check that the field is not null.
37 2012-05-06 Murray Cumming <murrayc@murrayc.com>
39 ListViewImpl: Protected against a bad cast error.
41 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
42 onEnterKeyDown(): Do not cast without an instanceof check.
44 2012-05-06 Murray Cumming <murrayc@murrayc.com>
46 ListTable: Protect against an out of range error.
48 * src/main/java/org/glom/web/client/ui/list/ListTable.java
49 createCellTable(): This is unlikely, but can happen while debugging.
51 2012-05-06 Murray Cumming <murrayc@murrayc.com>
53 AsyncMessage onFailure() callbacks: Log the exception message.
55 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
56 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
57 * src/main/java/org/glom/web/client/activity/ListActivity.java:
58 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
59 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
60 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
61 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
62 These are useful clues when something is wrong.
64 2012-05-06 Murray Cumming <murrayc@murrayc.com>
66 ConfiguredDocument: Avoid a null dereference.
68 * src/main/java/org/glom/web/server/ConfiguredDocument.java
69 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
70 details maps are created.
72 2012-05-06 Murray Cumming <murrayc@murrayc.com>
74 Document: Correct the port number parsing.
76 * src/main/java/org/glom/web/server/libglom/Document.java:
77 This lets us actually connect to the database and show the document.
79 2012-05-05 Murray Cumming <murrayc@murrayc.com>
83 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
84 user-interaction, asking us to load a temporary URL in a browser.s
85 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
86 which is apparently necessary for testing the service. See the comment.
87 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
88 Show the exception, if any. This is how I saw the 404 in the HTML in
91 2012-05-05 Murray Cumming <murrayc@murrayc.com>
93 DocumentTest: Move the .glom files into the resources directory.
95 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
96 URI via getResource().
98 2012-05-05 Murray Cumming <murrayc@murrayc.com>
100 Document: Remove the FieldIdentifies inner class.
102 * src/main/java/org/glom/web/server/libglom/Document.java: We only
103 use the Relationship (though the same function in libglom is maybe
104 used in other ways) and so this removes a compiler warning.
106 2012-05-05 Murray Cumming <murrayc@murrayc.com>
108 Document.load() Remove the error code parameter.
110 * src/main/java/org/glom/web/server/libglom/Document.java: load():
111 Remove the parameter. We do not set it yet and it could never have
112 worked as an output parameter (though maybe it did in java-libglom).
113 We could use an exception if we really want the failure reason.
114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
116 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
117 setUp(), testGetSuitableTableToViewDetails(): Adapt.
119 2012-05-05 Murray Cumming <murrayc@murrayc.com>
121 Make some inner classes static.
123 * src/main/java/org/glom/web/server/ConfiguredDocument.java
124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
125 * src/main/java/org/glom/web/server/ReportGenerator.java
126 * src/main/java/org/glom/web/server/libglom/Document.java
127 Make all inner classes static that can be static.
129 2012-05-05 Murray Cumming <murrayc@murrayc.com>
131 OnlineGlomServiceImpl: Do not load and check for java-libglom.
133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
134 init(): We do not use java-libglom any more.
136 2012-05-05 Murray Cumming <murrayc@murrayc.com>
138 Remove mentions of java-libglom.
140 * README: Remove mention of java-libglom, because it no longer needed.
141 * utils/build-onlineglom-war.sh:
142 * utils/check-and-recover-tomcat.py:
143 * utils/install-onlineglom-war.sh: Remove these as they are no longer
144 useful. Building is now far easier, with no need for jhbuild.
146 2012-05-05 Murray Cumming <murrayc@murrayc.com>
148 Fix the build (mvn package)
150 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
151 (LayoutGroup): Make the LayoutItemList inner class static and protected.
152 Otherwise the GWT Java->Javascript compilation fails with just this
153 error, during mvn package or when attempting to view in a browser,
154 in the GWT developer mode in Eclipse.
156 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
157 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
158 [INFO] Compiling module org.glom.web.OnlineGlom
159 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
160 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
161 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
162 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
163 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
164 [INFO] [ERROR] Cannot proceed due to previous errors
166 It has taken me 2 days to find out what was causing that. After reducing
167 the code, the compiler eventually showed me the full error message.
169 2012-05-04 Murray Cumming <murrayc@murrayc.com>
171 ConfiguredDocument: Cache the cloned and stripped layouts.
173 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
174 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
175 layout in a map, so we can retrieve it again without rebuilding it.
177 2012-05-04 Murray Cumming <murrayc@murrayc.com>
179 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
181 2012-05-04 Murray Cumming <murrayc@murrayc.com>
183 libglom classes: Implement some auto-generated emthods.
185 2012-05-04 Murray Cumming <murrayc@murrayc.com>
187 Add GwtTestOnlineGlomService.
189 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
190 However, this (and the other GwtTest*) does not seem to run during
193 2012-05-04 Murray Cumming <murrayc@murrayc.com>
195 Remove use of unsupported features from client code.
197 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
198 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
199 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
200 Use our client version of StringUtils instead of the apache commons one.
202 However, the GWT Javascript compliation still fails.
204 2012-04-25 Murray Cumming <murrayc@murrayc.com>
206 Add a Field class and implement some loading of it in Document.
208 2012-04-25 Murray Cumming <murrayc@murrayc.com>
210 Initial Document loading implementation, instead of libglom.
212 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
213 and Translatable classes, and adapt the rest of the code to use them.
214 However, this is still missing Layout and Field classes and loading.
216 2012-04-24 Murray Cumming <murrayc@murrayc.com>
218 Use of jOOQ: Move Field creation into a utility method.
220 * src/main/java/org/glom/web/server/SqlUtils.java:
221 This lets us improve it more easily.
223 2012-04-24 Murray Cumming <murrayc@murrayc.com>
225 Use of jOOQ: Improve the code to COUNT a sub-select.
227 * src/main/java/org/glom/web/server/SqlUtils.java:
228 Move initial query creation into
229 build_sql_select_step_with_where_clause().
230 build_sql_select_count_rows(): Use the jOOQ API instead of
231 concatentating text, because a jOOQ Select*Step is a TableLike,
232 which is what from() takes.
234 2012-04-23 Murray Cumming <murrayc@murrayc.com>
236 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
238 * pom.xml: Depend on jooq.
239 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
240 methods with jOOQ, based on the C++ implementations in libglom,
241 with some changes to the logic required by jooQ.
242 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
244 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
245 * src/main/java/org/glom/web/server/ReportGenerator.java:
246 * src/main/java/org/glom/web/server/SqlUtils.java:
247 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
248 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
249 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
250 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
251 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
252 Adapt. In particular, the SqlUtils methods now need to take a Connection,
253 because jOOQ needs that, though it seems unnecessary.
255 This is not quite finished. Ideally jOOQ would help us to build
256 table_name.field_name names, quoting and escaping them properly.
257 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
259 2012-04-21 Murray Cumming <murrayc@murrayc.com>
261 Move use of Glom.build_sql*() into a new SqlUtils class.
263 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
264 to wrap Glom.build_sql*(). The parameter types are still Glom one,
265 but this will make it easier to start using something other than
266 libglom or SqlBuilder.
268 2012-04-21 Murray Cumming <murrayc@murrayc.com>
270 Update the project URL.
272 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
274 2012-04-21 Murray Cumming <murrayc@murrayc.com>
276 Main layout: Use a FlowTable instead of absolute positioning.
278 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
279 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
280 child panels/widgets must have an absolute position. But that is annoying, so
281 this adds a FlowTable and puts the child panels in there.
283 2012-04-21 Murray Cumming <murrayc@murrayc.com>
285 GwtTestOnlineGlom: Comment out unused code.
287 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
288 Eclipse has started to say that some code is unused.
290 2012-04-21 Murray Cumming <murrayc@murrayc.com>
292 Update to the latest versions of dependencies.
294 * pom.xml: Update version numbers of dependencies to the latest
296 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
298 * src/main/java/org/glom/web/server/ReportGenerator.java:
299 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
300 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
301 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
303 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
304 Modify the imports where necessary.
306 2012-04-17 Murray Cumming <murrayc@murrayc.com>
308 Style: Remove overflow:hidden from searchbox
310 * src/main/webapp/style.css: Because this pushes the Back To Link
311 label/link on to the next row, which is then hidden due to the
312 hard-coded (in ems) height.
314 2012-04-20 Murray Cumming <murrayc@murrayc.com>
316 Remove some duplicate code.
318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
319 getDocumentInfo(): This must have been duplicated during the merge from the
324 2012-04-19 Murray Cumming <murrayc@murrayc.com>
326 Reports: Localize the waiting for report message.
328 * src/main/java/org/glom/web/client/activity/ReportActivity.java
329 start(): Get the message from the contants.
330 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
332 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
333 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
334 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
335 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
336 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
337 Update these files with the English text for newer strings for now.
339 2012-04-19 Murray Cumming <murrayc@murrayc.com>
341 Reports: Show a message while waiting for the report.
343 * src/main/java/org/glom/web/client/ui/ReportView.java
344 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
345 Add setWaitingText(), to show a message saying that we are
346 waiting for the report to be ready.
347 * src/main/java/org/glom/web/client/activity/ReportActivity.java
348 start(): Call setWaitingText() before calling the async
351 2012-04-19 Murray Cumming <murrayc@murrayc.com>
353 ReportGenerator: Specify date and time formats.
355 * src/main/java/org/glom/web/server/ReportGenerator.java:
356 createFieldValueElement(): Use the default (and localized)
357 short formats, though we still need a way to show 4-digit
358 years without providing the format for every locale.
359 * src/main/java/org/glom/web/server/database/DBAccess.java:
360 convertResultSetToDTO(): Use the short formats here too.
362 2012-04-18 Murray Cumming <murrayc@murrayc.com>
364 ReportGenerator: Use the correct numeric formatting.
366 * src/main/java/org/glom/web/server/ReportGenerator.java
367 createFieldExpression(), createFieldValueElement(): Take the
368 whole LayoutItem_Field instead of just the field name, so
369 we have access to the formatting.
370 createFieldValueElement(): Use JRTextField.setPattern() to
371 specify the numeric formatting, with the help of a
372 regular DecimalFormat.
374 2012-04-18 Murray Cumming <murrayc@murrayc.com>
376 ReportGenerator: Avoid showing null for group by titles.
378 * src/main/java/org/glom/web/server/ReportGenerator.java
379 generateReport(): Use setBlankWhenNull() on the field title
380 style too, because this is used for values in group by
383 2012-04-18 Murray Cumming <murrayc@murrayc.com>
385 ReportGenerator: Add a colon to titles in vertical groups.
387 * src/main/java/org/glom/web/server/ReportGenerator.java
388 addFieldToDetailBandVertical(): Pass true for the withColon
391 2012-04-18 Murray Cumming <murrayc@murrayc.com>
393 ReportGenerator: Simplify the code by using Position more.
395 2012-04-18 Murray Cumming <murrayc@murrayc.com>
397 Reports: Support vertical groups, roughly.
399 * src/main/java/org/glom/web/server/ReportGenerator.java:
400 addToReport(): Rename to addGroupToReport() and, if necessary,
401 call the new addVerticalGroupToReport() method.
402 createFieldValueElement(): Let the caller specify the Y position
405 2012-04-17 Murray Cumming <murrayc@murrayc.com>
407 Reports: Allow a second report to be shown.
409 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
410 clear(): Do not remove the HTML widget, which broke the whole layout.
412 2012-04-17 Murray Cumming <murrayc@murrayc.com>
414 Locales drop-down: Show that we use English by default.
416 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
417 fillView(): When we use English, just because that is the default, when
418 no locale is specified, show that in the Locales drop-down instead of
419 just showing the first item.
421 2012-04-17 Murray Cumming <murrayc@murrayc.com>
423 Unselect the Report/Locale/Table combo item when appropriate.
425 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
426 setPlace(): clear reportName if this is not a ReportPlace.
427 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
428 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
429 When the provided name is empty, unselect all items, so that none are
430 indicated. This uses a for loop because I cannot find a single method
433 2012-04-17 Murray Cumming <murrayc@murrayc.com>
435 Report: Give the user a way to get back to the list.
437 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
438 start(), setPlace(): Show the Back To List link on reports, and also
439 interpret selecting the empty report item as back to list.
441 2012-04-13 Murray Cumming <murrayc@murrayc.com>
443 Really show the selected Report name.
445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
446 setPlace(): Store the reportName here, if it is that kind of Place.
447 fillView(): Set the selected Report after filling the list of reports.
448 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
449 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
450 null Strings, though we need some way to unselect all ListBox items
453 2012-04-13 Murray Cumming <murrayc@murrayc.com>
455 ReportGenerator: Try to avoid some problems.
457 * src/main/java/org/glom/web/server/ReportGenerator.java
458 addField(): Try to avoid duplicates, and avoid using a null
461 2012-04-13 Murray Cumming <murrayc@murrayc.com>
463 Reports: Use quickFind.
465 * src/main/java/org/glom/web/client/OnlineGlomService.java;
466 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
468 getReportHTML(): Add a quickFind parameter.
469 * src/main/java/org/glom/web/client/activity/ReportActivity.java
470 start(): Pass the quickFind parameter.
471 * src/main/java/org/glom/web/server/ReportGenerator.java
472 generateReport(): Take a quickFind parameter.
474 2012-04-13 Murray Cumming <murrayc@murrayc.com>
476 ReportPlace: Actually use the report name.
478 * src/main/java/org/glom/web/client/place/ReportPlace.java
479 getPlace(): Do not assign the report name to the quickfind.
481 2012-04-13 Murray Cumming <murrayc@murrayc.com>
483 Show java.library.path when complaining.
485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
486 init(): When telling us to check java.library.path, show the
489 2012-03-06 Murray Cumming <murrayc@murrayc.com>
491 ReportGenerator: Do not show nulls.
493 2012-03-06 Murray Cumming <murrayc@murrayc.com>
495 ReportGenerator: Make the title font larger.
497 2012-03-06 Murray Cumming <murrayc@murrayc.com>
499 ReportGenerator: Put field titles inside groups, if there are groups.
501 2012-03-06 Murray Cumming <murrayc@murrayc.com>
503 ReportGenerator: Take the Report itself instead of the name and group.
505 * src/main/java/org/glom/web/server/ConfiguredDocument.java
506 Remove getReportLayoutGroup().
507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
508 getReportHTML(): Pass the report instead
509 of its name and layout group.
510 * src/main/java/org/glom/web/server/ReportGenerator.java
511 generateReport(): Use the report object to use the title
514 2012-03-06 Murray Cumming <murrayc@murrayc.com>
516 ReportGenerator: Remove designBand parameters.
518 * src/main/java/org/glom/web/server/ReportGenerator.java:
519 Make designBand a class member instead of passing it to all
522 2012-03-06 Murray Cumming <murrayc@murrayc.com>
524 ReportGenerator: Add lines, a bit like in the desktop version.
526 * src/main/java/org/glom/web/server/ReportGenerator.java
527 addToReport(): Use JRDesignLine.
529 2012-03-06 Murray Cumming <murrayc@murrayc.com>
531 ReportGenerator: Correct the title positions and use some bold style.
533 * src/main/java/org/glom/web/server/ReportGenerator.java:
534 Break the code up into reusable functions, correct the placement of
535 titles, and use normal/bold styles as in the reports in the desktop
538 2012-03-06 Murray Cumming <murrayc@murrayc.com>
540 ReportGenerator: Add a header band to show the field titles.
542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
543 getReportHTML(): Pass the localeId to the ReportGenerator
545 * src/main/java/org/glom/web/server/ReportGenerator.java
546 constructor: Take the localeID so we can get translated field
548 generateReport(), addToReport(), addFieldToBand(): Add field
549 titles in a column header band.
551 2012-03-05 Murray Cumming <murrayc@murrayc.com>
553 Reports drop-down list: Some improvement.
555 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
556 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
557 Adedd setSelectedReport(),
558 setReportList(): Add a blank line so that the user can select the
560 * src/main/java/org/glom/web/client/activity/ReportActivity.java
561 start(): Show the current report by calling setSelectedReport().
562 This does not seem to work yet.
564 2012-03-05 Murray Cumming <murrayc@murrayc.com>
566 DetailsActivity, ListActivity: Move some variables into a base class.
568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
569 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
570 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
571 the clientFactory, documentID, tableName and authenticationPopup into
572 a base class, to avoid duplication.
574 2012-03-05 Murray Cumming <murrayc@murrayc.com>
576 Translate the Reports label.
578 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
579 Get the "Reports" label string from the constants.
580 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
581 perties: Add Reports to the constants.
583 2012-03-05 Murray Cumming <murrayc@murrayc.com>
585 Reports: Implement grouping.
587 * src/main/java/org/glom/web/server/ReportGenerator.java:
588 Handle LayoutItem_GroupBy items and try to do the right thing
589 with JRDesignGroup. It seems to work.
591 2012-03-04 Murray Cumming <murrayc@murrayc.com>
593 Actually show some data with JasperReports.
595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
596 getReportHTML(): Move most code into a ReportGenerator class.
597 * src/main/java/org/glom/web/server/ReportGenerator.java:
598 Recurse into sub-groups, adding fields to the JasperDesign's details
599 band. Note that we must set an arbitrary width and height, or it just
600 will not show any data.
602 2012-03-04 Murray Cumming <murrayc@murrayc.com>
604 Reports Chooser: Show the titles, not the names.
606 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
607 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
608 and the names as the values.
609 * src/main/java/org/glom/web/server/ConfiguredDocument.java
610 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
611 group now that we provide the report name, so it should always
614 2012-02-15 Murray Cumming <murrayc@murrayc.com>
616 Depend on jasperreports.
618 * pom.xml: Add the dependency. My plan is to use this on the
621 2012-01-31 Murray Cumming <murrayc@murrayc.com>
623 Implement navigation to report places.
625 * src/main/java/org/glom/web/client/activity/ReportActivity.java
626 start(): Do not bother to handle all events here.
627 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
628 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
629 Added getSelectedReport().
630 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
631 .java: start(): When handling a change to the reports chooser,
632 call getSelectedReport() and goTo() its ReportPlace.
633 * src/main/java/org/glom/web/client/ui/ReportView.java
634 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
635 Added setReportHTML() which puts the html in a gwt HTML widget.
636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
637 getReportHTML(): Return "TODO" just to show that this works.
639 2012-01-31 Murray Cumming <murrayc@murrayc.com>
641 Make ReportPlace usable.
643 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
645 * src/main/java/org/glom/web/client/place/ReportPlace.java:
646 Correct the @prefix annotation.
648 2012-01-31 Murray Cumming <murrayc@murrayc.com>
650 OnlineGlomService: Return report HTML rather than the LayoutGroup.
652 * src/main/java/org/glom/web/client/OnlineGlomService.java:
653 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
655 Change getReportLayout() to getReportHMTL() because we will not need to
656 parse or render the report layout on the client side.
657 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
658 getReportLayout(): Return the libglom LayoutGroup type because we will
659 not need to convert to a shared type, because this will not be used on
661 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
664 Note that there is still no implementation for this.
667 2012-01-27 Murray Cumming <murrayc@murrayc.com>
669 Add a (empty) Report Place, View, and Activity.
671 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
673 * src/main/java/org/glom/web/client/place/HasTablePlace.java
674 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
675 this into a superclass:
676 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
677 and also use it as the base of this new ReportPlace:
678 * src/main/java/org/glom/web/client/place/ReportPlace.java
680 * src/main/java/org/glom/web/client/ui/ReportView.java
681 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
682 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
683 Add these, containing mostly boiler-plate for now.
685 * src/main/java/org/glom/web/client/OnlineGlomService.java
686 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
687 * src/main/java/org/glom/web/server/ConfiguredDocument.java
688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
689 Add API to get the LayoutGroup for the report.
691 2012-01-23 Murray Cumming <murrayc@murrayc.com>
693 Add and fill a Reports drop-down list box.
695 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
697 * src/main/java/org/glom/web/client/OnlineGlomService.java:
698 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
700 Added getReports(document, table, localeID), calling
701 ConfiguredDocument.getReports().
702 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
703 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
704 Added setReportsList() and a list widget.
705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
706 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
711 2012-04-12 Murray Cumming <murrayc@murrayc.com>
713 Translations: Add Esperanto.
715 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
716 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
717 properties: Add this translation because someone took the time to make it.
719 2012-03-15 Murray Cumming <murrayc@murrayc.com>
721 Adapt to the java-libglom 1.21.7 API.
723 * src/main/java/org/glom/web/server/ReportGenerator.java:
724 addToReport(): get_group_secondary_fields() is now
725 get_secondary_fields().
728 2012-03-15 Murray Cumming <murrayc@murrayc.com>
730 Use the latest java-libglom version.
732 * pom.xml: Use java-libglom 1.21.7.
734 2012-03-03 Ben Konrath <ben@bagu.org>
736 Display date and time in details view.
738 https://bugzilla.gnome.org/show_bug.cgi?id=671257
740 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
742 2012-03-05 Murray Cumming <murrayc@murrayc.com>
744 Require the latest java-libglom.
746 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
748 2012-03-04 Murray Cumming <murrayc@murrayc.com>
750 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
752 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
753 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
754 an empty quickfind string. I also corrected libglom to create only
755 empty where clauses for empty quickfind strings, but this avoids the
758 2012-02-24 Ben Konrath <ben@bagu.org>
760 Improve the tabs in the Notebook widget.
764 2012-01-30 Murray Cumming <murrayc@murrayc.com>
766 Translations: Try to translate the strings.
768 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
769 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
770 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
771 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
772 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
773 Take the Open translation from GTK+'s .po files.
774 Take the Details translation from Glom's po files.
775 I have added the other strings to Glom so we can get translations that way:
776 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
778 2012-01-27 Murray Cumming <murrayc@murrayc.com>
780 TableSelectionViewImpl: Put the search label and entry in a div.
782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
783 Put the search widgets in a FlowTable so that the CSS can be used to
784 style them while keeping them together.
785 * src/main/webapp/style.css: Mention the new div.
787 2012-01-27 Murray Cumming <murrayc@murrayc.com>
789 Translate more strings in more locales.
791 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
792 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
793 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
794 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
795 Translate the "Details" and "Open" string too.
797 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
798 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
799 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
800 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
801 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
802 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
803 Add these new locales as placeholders though they currently contain English.
805 2012-01-27 Murray Cumming <murrayc@murrayc.com>
807 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
810 Check the ConfiguredDocument* for null before using it.
812 2012-01-26 Murray Cumming <murrayc@murrayc.com>
814 Tell Eclipse about the generated java files.
816 * .classpath: This lets it find OnlineGlomConstants.java.
817 It would be nice if Eclipse just used the maven build files.
819 2012-01-26 Murray Cumming <murrayc@murrayc.com>
821 Prevent a crash when no locale is specified in the URL.
823 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
824 Avoid returning a null string, obtained from
825 Window.Location.getParameter(). This caused a crash when it was
826 later passed to libglom's API.
827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
828 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
829 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
830 guard against future null strings.
832 2012-01-26 Murray Cumming <murrayc@murrayc.com>
834 Use the ?locale= query param instead of the &lang= token param.
836 * src/main/java/org/glom/web/client/place/ListPlace.java
837 * src/main/java/org/glom/web/client/place/DetailsPlace.java
838 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
839 Remove the lang token key and value.
841 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
842 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
843 When the user selects a different locale from the chooser, use
844 Window.Location.assign() to change the URL, which then causes a reload.
846 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
847 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
848 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
849 * src/main/java/org/glom/web/client/activity/ListActivity.java
850 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
851 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
852 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
853 * src/main/java/org/glom/web/client/ui/ListView.java:
854 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
856 Remove localeID member variables and method/constructor parameters, instead
857 using Utils.getCurrentLocaleID() when we need a localID to pass to
860 2012-01-26 Murray Cumming <murrayc@murrayc.com>
862 Internationalize the UI strings.
864 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
865 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
866 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
867 because it is unused. Messages are apparently strings that can have
868 parameters, but we do not need that yet, so Contants will be enough for now.
869 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
870 to say that we support the en and de locales.
871 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
872 The original English strings.
873 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
874 Some German translations of the English strings.
875 The i18n goal then uses the .properties file to generate an
876 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
877 returns an implementation that returns the translated strings.
878 The documentation suggests putting these in src/java/*/client/, but it seems
879 best to put it in src/resources/*/client/.
880 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
881 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
882 instead of hard-coding them.
883 Note that we cannot import OnlineGlomConstants because it does not exist yet,
884 but that does not seem to stop the build, though it confuses Eclipse.
886 You can see the translated string by adding ?locale=de to the URL, like so:
887 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
889 2012-01-24 Murray Cumming <murrayc@murrayc.com>
891 Improve null/empty String checks.
893 * pom.xml: Add a dependency on commons-lang, to use
894 org.apache.commons.lang.StringUtils.
895 * src/main/java/org/glom/web/server/ConfiguredDocument.java
896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
897 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
898 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
899 Use StringUtils.isEmpty().
901 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
902 StringUtils class with a static isEmpty() function because we
903 cannot use org.apache.commons.lang.StringUtils in client-side
904 GWT code because it (apparently) cannot be compiled to javascript.
905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
906 * src/main/java/org/glom/web/client/activity/ListActivity.java
907 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
908 * src/main/java/org/glom/web/client/place/DetailsPlace.java
909 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
910 * src/main/java/org/glom/web/client/place/ListPlace.java
911 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
912 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
913 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
914 * src/main/java/org/glom/web/client/ui/details/Group.java
915 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
916 our StringUtils.isEmpty() function.
918 2012-01-24 Murray Cumming <murrayc@murrayc.com>
920 Update to the latest java-libglom API.
922 * pom.xml: Require java-libglom 1.21.4.
923 * src/main/java/org/glom/web/server/ConfiguredDocument.java
924 getDocumentInfo(), getListViewLayoutGroup():
925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
927 * src/main/java/org/glom/web/server/database/DBAccess.java
928 getFieldsToShowForSQLQueryAddGroup(),
929 getPrimaryKeyLayoutItemField(): Replace get_database_title()
930 with either get_database_title_original() or
931 get_database_title(localeID).
933 2012-01-24 Murray Cumming <murrayc@murrayc.com>
935 ConfiguredDocument: Avoid a null pointer exception.
937 * src/main/java/org/glom/web/server/ConfiguredDocument.java
938 Initialize localeID to "" to avoid returning a null String which
939 causes a crash in java-libglom's swing-generated code.
941 2012-01-23 Murray Cumming <murrayc@murrayc.com>
943 Some simple renaming.
945 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
946 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
947 for localeChooser. This seems more appropriate and is less ambiguous
948 particularly in the .css file.
950 2012-01-23 Murray Cumming <murrayc@murrayc.com>
952 ConfiguredDocument: Rename the localedID private member variable.
954 2012-01-23 Murray Cumming <murrayc@murrayc.com>
956 Adapt to the latest java-libglom API from git master.
958 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
959 libglom now uses only Vector instead of List, which uses add() instead of
962 2012-01-22 Murray Cumming <murrayc@murrayc.com>
964 ConfiguredDocument: Rename the localedID private member variable.
966 2012-01-20 Murray Cumming <murrayc@murrayc.com>
968 Build a source tarball with mvn assembly:single
970 * assembly.xml: Add this file.
971 * pom.xml: Use the maven-assembly-plugin and tell it to use
972 our assembly.xml file.
974 2012-01-19 Murray Cumming <murrayc@murrayc.com>
976 OnlineGlomServiceImpl: Get .glom files recursively.
978 * pom.xml: Depend on commons-io from org.apache.commons.
979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
980 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
981 files recursively, and with the easier filter for the extension.
982 Use org.apache.commons.io.FilenameUtils.removeExtension() to
983 simplify that code too.
985 2012-01-19 Murray Cumming <murrayc@murrayc.com>
987 README: Mention that you must install java-libglom packages separately.
989 But then it works, because java-libglom is now in the central maven
992 2012-01-18 Murray Cumming <murrayc@murrayc.com>
994 locales drop-down: Show the correct selected locale when the URL changes.
996 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
997 .java: setPlace(): Move some code into fillView().
999 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1001 locales drop-down: Do not lose the primary key.
1003 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1004 start(): onLocaleChange(): Pass the current primary key value,
1005 instead of an empty value.
1007 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1009 locales drop-down: Do not lose the drop-down selection.
1011 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1012 .java (TableSelectionActivity.fillView): Set the selected locale
1013 after changing the drop-down items (though we do not really need
1014 to change them just because the locale changes.)
1016 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1018 locales drop-down: Change the tables list when this changes.
1020 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1021 .java: TableSelectionActivity.start(): Move the async table titles
1022 retrieval into a private fillView() method and also call this when
1023 the chosen locale changes.
1024 Note that the document title is not actually translatable yet, but
1025 that is a problem that I should fix soon in libglom.
1027 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1029 Improve the placement of the locales drop-down.
1031 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1032 Put the title and locales drop-down in a div (gwt.FlowTable).
1033 * src/main/webapp/style.css: Add magic css properties to make this work.
1034 Also remove the left margin from the title so that it lines up with the
1037 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1039 locales selector: Show human-readable locale titles.
1041 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1042 getDocumentInfo(): Use java.util.Locale to show a real title of
1043 each locale, in the locale's own language.
1045 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1047 Add a language/locale selector drop-down.
1049 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1050 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1051 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1052 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1053 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1054 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1055 Add a ListBox to show the available locales. Add getLocaleSelector(),
1056 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1057 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1058 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1059 java: Add these classes.
1060 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1061 start(): Fill the locales ListBox. Handle its change event, firing a
1063 setPlace(): Show the selected locale as specified by the URL token.
1064 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1065 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1066 Handle LocaleChangeEvent, going to a new *Place with that locale.
1068 The placement of the ListBox is not pretty, and it currently uses the ID
1069 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1073 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1075 Search box: Show the search text from the URL token.
1077 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1078 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1079 Add setQuickFindText().
1080 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1081 .java: setPlace(): Store the queryText if the place is a ListPlace,
1082 and call TableSelectionView.setQuickFindText().
1084 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1086 Allow use of translations via, for instance, &lang=de in the URL.
1088 * pom.xml: Use the unstable java-libglom 1.21 version.
1090 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1091 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1093 init(): Instead of calling TranslatableItem.set_current_locale()
1094 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1095 However, this is only for default locales, which are not needed to
1096 change the locale in the URL.
1097 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1098 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1099 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1100 layout for a particular locale.
1101 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1102 Add get/setDefaultLocaleID().
1103 getDocumentInfo(), getListViewData(), getRelatedListData(),
1104 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1105 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1106 localeID parameter, so we can get the layout for a particular locale.
1108 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1109 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1110 * src/main/java/org/glom/web/client/place/ListPlace.java:
1111 Parse and construct a lang parameter too.
1113 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1114 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1115 passed to subsequent methods and constructors.
1116 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1117 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1118 Store the localeID from the *Place and pass it to other constructors
1119 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1121 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1122 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1123 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1124 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1125 * src/main/java/org/glom/web/client/ui/ListView.java:
1126 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1127 Take localeID parameters and pass them to subsequent constructors and
1128 methods, so that the layout is always retrieved for that locale.
1130 This is rather repetitive.
1132 Note that "" means the original (default) locale of the Glom document,
1133 which is usually English.
1135 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1137 Documents: Remove final keyword to fix startup configuration.
1139 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1140 final keywords on the private member variables because that breaks
1141 the startup, apparently (there are warnings) because it stops them
1142 from being serialized. I added these in the previous commit.
1144 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1146 Documents: Add some final keywords.
1148 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1151 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1153 OnlineGlomServiceImpl: Add to overview comments.
1155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1156 Note that this is where all the document are loaded. They are not
1157 loaded freshly for each page.
1159 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1163 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1164 Add a TextBox for the text of a quick find.
1165 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1167 setBackLink(): Add a String quickFind parameter.
1168 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1169 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1170 to the base interface, because that is how TableSelectionViewImpl is used.
1171 * src/main/webapp/style.css: Add style for the search box and its label.
1173 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1174 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1175 Add these files, based on the existing TableChangeEvent and
1176 TableChangeEventHandlers.
1177 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1178 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1179 a ListPlace() that the user should be taken to.
1180 * src/main/java/org/glom/web/client/activity/ListActivity.java
1181 start(): Handle it here too and adapt the TableChangeEvent handler to
1182 pass the extra "" quickFind parameter to ListPlace.
1183 * src/main/java/org/glom/web/client/place/ListPlace.java:
1184 Constructor: Take an extra String quickFind parameter and store it,
1185 returning it from a new getQuickFind() method.
1186 getToken(): Put the quickFind text in the URL token.
1187 getPlace(): Parse the quickFind text from the URL token.
1188 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1189 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1190 ListPlace constructor.
1191 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1192 .java: start(): Add a Change handler for the TableSelectionView's
1193 TextBox (via its base HasChangeHandlers interface), firing the new
1194 QuickFindChangeEvent.
1195 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1196 pass the extra "" quickFind parameter.
1198 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1199 setCellTable(): Add a String quickFind parameter and pass it to
1200 the ListViewTable() constructor.
1201 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1202 setCellTable() in the base interface, because that is how ListViewImpl
1205 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1206 Add a String quickFind member variable.
1207 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1208 Constructor: Add a String quickFind parameter, storing it in the
1209 base ListTable's member variable.
1210 onRangeChanged(): Pass quickFind to the
1211 OnlineGlomServiceAsync.getSortedListViewData() and
1212 OnlineGlomServiceAsync.getListViewData() methods.
1214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1215 getListViewData(), getSortedListViewData(): Add a String quickFind
1216 parameter, passing it to ConfiguredDocument.getListViewData().
1217 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1218 Change getListViewData(), getSortedListViewData() in the base interface,
1219 because that is how OnlineGlomServiceImpl is used, via this:
1220 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1221 Change getListViewData(), getSortedListViewData() here too.
1222 This class can apparently be used to asynchronously call methods on
1223 OnlineGlomService, and GWT seems to implement that after recognizing
1224 just the *Async name convention and the extra AsyncCallback parameters.
1226 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1227 getListViewData(): Add a String quickFind parameter, and pass it to
1228 ListViewDBAccess.getData().
1229 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1230 getListData(): Add a String quickFind parameter and pass it to
1232 getSelectQuery(): Add a String quickFind parameter.
1233 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1234 getSelectQuery(): Add a String quickFind parameter and use it with
1235 Glom.get_find_where_clause_quick() to pass a where_clause to
1236 Glom.build_sql_select_with_where_clause(), to actually filter the
1238 getData(): Add a String quickFind parameter, passing it to getListData().
1239 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1240 va: getData(): Pass an empty string to getListData() for the
1241 quickFind parameter.
1243 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1245 ListTable: Minor change.
1247 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1248 createCellTable(): Make this protected instead of public.
1250 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1252 Many files: Use final for the parameters and use the @override attribute.
1254 2012-01-22 Ben Konrath <ben@bagu.org>
1256 Add anchor links for single line text that starts with http, ftp and www.
1260 2012-01-22 Ben Konrath <ben@bagu.org>
1262 Add ellipsis to single line text in details view.
1266 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1268 Remove all javadoc author tags.
1270 Because they are awkward and meaningless when many people touch
1272 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1274 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1276 Revert the COPYING.LESSER to COPYING rename.
1278 Apparently both should be there if it is LGPL.
1280 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1282 *View: Remove unused imports.
1284 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1285 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1286 * src/main/java/org/glom/web/client/ui/ListView.java:
1287 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1288 Remove unused imports, as suggested by Eclipse.
1290 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1292 Move the *View::Presenter types, and some API into one base View.
1294 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1295 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1296 * src/main/java/org/glom/web/client/ui/ListView.java:
1297 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1298 Presenter, setPresenter() and clear() into a shared base interface,
1299 to avoid the unnecessary duplicate Presenter types and to more clearly
1300 show how the *Views share the same structure, even if they are not
1301 used polymorphically.
1303 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1304 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1307 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1308 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1310 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1313 Feel free to revert this if there is a good reason for the duplicate
1316 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1318 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1320 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1321 a class member instead of a local variable in the method.
1322 This lets us use it to get the view instances, for use in tests.
1323 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1324 beforeOnlineGlom(): Test some more details of the initial view.
1325 Again, this is not very useful.
1327 To really test gwt-glom we will need to start a local postgresql
1328 instance with local data, like the Glom tests in C++.
1330 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1332 pom.xml: Mention the LGPL license.
1334 * pom.xml: Add a licenses section.
1335 * COPYING.LESSER: Move this to COPYING, which
1336 previously contained the GPL. But gwt-glom is all LGPL.
1338 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1340 Add project information to README and pom.xml.
1342 * README: Add a brief description and mention some mvn
1344 * pom.xml: This extra information shows up in mvn site
1347 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1349 Use the latest java-libglom version.
1351 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1353 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1355 GwtTestOnlineGlom: Test a little more.
1357 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1358 protected rather than private, as suggested by the gwt-test-utils
1360 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1361 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1362 Test the initial visibility of the panels.
1364 However, this is not a very useful test.
1365 And I wonder how we should generally test using this idea for an
1366 activity/places app like ours where the real changes happen implicitly
1367 based on the history token/URL.
1369 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1371 Slight modification to *Mapper comments.
1373 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1374 (DataActivityMapper)
1375 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1377 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1379 Remove comments mentioning GIN because they are just copied from
1380 the example code and are apparently not helpful:
1381 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1382 Also change the mention of a class that is only in the example code.
1384 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1386 GwtTestOnlineGlom test: Minor changes.
1388 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1389 Avoid the long qualified class name and modify the comment
1390 because it is now obvious to me that the mocked class is the only
1391 custom one created via GWT.create().
1393 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1395 Tests: Added the beginnings of a test using gwt-test-utils.
1397 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1398 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1399 which tells gwt-test-utils what class will be tested.
1400 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1401 Add a simple (but empty) test case. One class, used by the OnlineGlom
1402 class, is mocked so that it can be created. However, I am not sure
1403 why only this class needs to be mocked.
1405 Note that mockito seems more popular, and clearer, than easymock,
1406 but I have not got that working yet. It might be a matter of the
1409 This test is run during mvn integration-test.
1411 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1413 Tests: Use junit4-style syntax instead of junit3-style.
1415 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1416 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1417 * src/test/java/org/glom/web/shared/DataItemTest.java:
1418 Use the @Test annotation rather than relying on the test*() prefix.
1419 Also no longer implement TestCase, to avoid triggering support for
1420 the junit3-way, which stops the annotations from working.
1421 Change the imports from import junit.framework.* to
1422 import org.junit.*, which is apparently the new way.
1424 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1426 Added a test for ListPlace token parsing and creation.
1428 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1429 This is much the same as DetailsPlaceTest.
1431 I wonder how we could test the other parts of the *Place API.
1433 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1435 DetailsPlace test: Also test getToken() and recreation via getPlace().
1437 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1438 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1439 recreate it, testing the recreated DetailsPlace for the same parameter
1442 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1444 Use the surefire-report plugin.
1446 * pom.xml: This generates a HTML report about the tests in
1447 target/site/surefire-report.html
1448 when you do mvn surefire-report:report. It seems to be popular/normal.
1450 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1452 Added a test for DetailsPlace.
1454 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1455 Test the getPlace() token parsing.
1457 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1459 Added a first unit test.
1461 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1462 * src/test/java/org/glom/web/shared/DataItemTest.java:
1463 This is a silly test but it is just to get things started. Note that
1464 maven/junit finds the test because it looks in src/test by default.
1466 2011-12-22 Ben Konrath <ben@bagu.org>
1468 Change charsetName to "UTF-8" when replacing line breaks.
1470 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1471 that work in Java (such as "UTF8") will not work when compiled to
1474 This fixes a problem with multi-line details view fields that have hard
1475 line breaks. The "License Text" field on this page demonstrates the
1478 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1480 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1482 2011-12-22 Ben Konrath <ben@bagu.org>
1484 Fix another bug with related list navigation.
1486 I've tested all the navigation buttons in all of the related lists
1487 so things should be good now.
1489 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1491 2011-12-22 Ben Konrath <ben@bagu.org>
1493 Fix a crasher when refreshing the list view with the default table.
1495 This crash will also happen when loading the list view with the default
1496 table from a link or bookmark.
1498 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1499 to the main document selection page when the document id hasn't been
1501 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1502 the main document selection page when the document id hasn't been
1504 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1505 values for the details place when the document id hasn't been set.
1506 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1507 values for the list place when the document id hasn't been set.
1509 2011-12-21 Ben Konrath <ben@bagu.org>
1511 Protect against NPE when glom.document.locale is not in config.
1513 This patch protects against an NPE when glom.document.locale is not in
1514 the config file. This NPE will also happen if glom.document.locale is
1517 The patch also updates the error message to display the class name when
1518 the getMessage() returns null. This was happening when the NPE was
1519 thrown and I had "Configuration Error: null". If an NPE is encountered
1520 with this patch, "Configuration Error: NullPointerException " will be
1523 This commit closes this bug:
1525 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1529 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1531 Rename onlineglom.properties to onlineglom.properties.sample.
1533 * src/main/resources/onlineglom.properties: Rename to:
1534 * src/main/resources/onlineglom.properties.sample:
1535 * src/main/resources/README: And add this file explaining that people
1536 should rename it back when deploying.
1538 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1540 Allow choosing the translation in the .properties file.
1542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1543 init(): Read a glom.document.locale value from the configuration file
1544 and call Glom's TransatableItem::set_current_locale() method.
1545 * src/main/resources/onlineglom.properties: Add a commented-out
1546 example of this new setting.
1548 It would be better to add &lang=de_DE to the URL, but the current
1549 libglom API does not allow us to do this easily. I am working on that.
1551 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1553 Avoid a crash in parsing of token parameters.
1555 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1556 ava: getTokenParams(): Do not crash if a parameter has a key but no
1557 value, and ignore parameters with neither.
1559 2011-12-17 Murray Cumming <murrayc@murayc.com>
1561 History token building/handling: Improve use of token parameters.
1563 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1564 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1565 and buildParamsToken(HashMap), for use by derived classes.
1566 Make the separator private because it is no longer be needed.
1567 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1568 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1569 instead of manual string concatenation.
1570 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1571 of hardcoded indices and awkward splitting code.
1572 * src/main/java/org/glom/web/client/place/ListPlace.java
1573 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1574 instead of manual string concatenation.
1575 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1576 of hardcoded indices and awkward splitting code.
1577 This should fix bug #666420
1579 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1581 Fix a Navgiation->Navigation typo in the code.
1583 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1584 Rename processNavgiation() to processNavigation().
1586 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1588 Fix a seperator->separator typo in the code.
1590 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1591 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1592 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1595 2011-12-15 Ben Konrath <ben@bagu.org>
1597 Cleanup some comments.
1599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1601 2011-12-14 Ben Konrath <ben@bagu.org>
1603 Replace \n with <br/> for multiline text in the details view.
1605 Vertical scrollbars are added when needed as well.
1607 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1609 2011-12-14 Ben Konrath <ben@bagu.org>
1611 Specify the font for document selection links.
1613 * src/main/webapp/style.css:
1615 2011-12-14 Ben Konrath <ben@bagu.org>
1617 Fix bouncy CellTable while paging.
1619 This doesn't currently work with related list tables in unselected
1622 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1624 2011-12-14 Ben Konrath <ben@bagu.org>
1626 Revamp the appearance of the document selection page.
1628 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1629 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1630 * src/main/webapp/style.css:
1632 2011-12-13 Ben Konrath <ben@bagu.org>
1634 Set navigation button column to the smallest size possible.
1636 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1638 2011-12-13 Ben Konrath <ben@bagu.org>
1640 Change OpenButton nomenclature to NavigationButton.
1642 Using NavigtionButton makes things more generic. Classes, methods and
1643 variables have been changed.
1645 This is a rename-only refactor.
1647 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1648 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1649 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1650 Renamed from OpenButtonCell.
1651 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1652 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1653 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1655 2011-12-12 Ben Konrath <ben@bagu.org>
1657 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1659 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1660 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1661 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1662 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1664 2011-12-12 Ben Konrath <ben@bagu.org>
1666 Update variable names and comments.
1668 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1669 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1671 2011-12-12 Ben Konrath <ben@bagu.org>
1673 Properly initialize numNonEmptyRows variable to zero.
1675 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1676 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1678 2011-12-05 Ben Konrath <ben@bagu.org>
1680 Add latest mockup with HTML tables.
1682 Features of this mockup:
1684 -> HTML table for flowtable
1685 -> HTML table for flowtable column
1686 -> Example of how related lists would look
1687 -> Not using text entries for data items
1689 The current version of Online Glom doesn't use HTML tables for the
1692 This mockup has been sent to the glom-devel mailing list but it's good
1693 to have it here as well.
1695 * mockups/details-view-html-tables.html:
1697 2011-12-05 Ben Konrath <ben@bagu.org>
1699 Remove unnecessary getPrimaryKeyField() method.
1701 getPrimaryKeyFieldForTable(String) has been renamed to
1702 getPrimaryKeyField(String).
1704 * src/main/java/org/glom/web/server/database/DBAccess.java:
1705 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1706 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1708 2011-12-05 Ben Konrath <ben@bagu.org>
1710 Add string representation of TypedDataItem value to conversion error message.
1712 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1713 message was extracted into its own method to avoid duplication.
1715 2011-12-05 Ben Konrath <ben@bagu.org>
1717 Add type checking to navigation primary key value creation.
1719 Create navigation primary key only if the expected type from the Glom
1720 document matches the type returned by the SQL query.
1722 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1724 2011-12-05 Ben Konrath <ben@bagu.org>
1726 Rename a couple of variables in RelatedListNavigation.
1728 This is a rename-only refactor.
1730 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1732 2011-12-05 Ben Konrath <ben@bagu.org>
1734 Move getListLayoutGroup() into getListViewLayoutGroup().
1736 This removes getListLayoutGroup(). It was only being called by
1737 getListViewLayoutGroup().
1739 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1741 2011-12-05 Ben Konrath <ben@bagu.org>
1743 Remove check for LayoutItem_Portal in list table method.
1745 This check is no longer necessary because the method isn't being used
1746 to create the LayoutItemPortal DTO.
1748 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1750 2011-12-05 Ben Konrath <ben@bagu.org>
1752 Properly support related list navigation.
1754 Navigation from the "Repository Analyzer -> Package Scans ->
1755 Dependencies" related table wasn't working because the primary key for
1756 related tables wasn't being set properly. This commit fixes the
1759 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1760 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1761 doesn't set the primary key properly for related list tables.
1762 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1763 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1764 useful for getting the primary key for list view tables and for related
1766 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1767 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1768 Move code to set the primary key for the table from the abstract
1769 ListDBAccess class to ListViewDBAccess as it's only correct for list
1771 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1772 Properly add primary key to related list tables.
1774 2011-12-02 Ben Konrath <ben@bagu.org>
1776 Properly set the horizontal alignment of fields.
1778 This fix is for both the list tables and the details view.
1780 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1781 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1782 to set the horizontal alignment of fields.
1784 2011-12-02 Ben Konrath <ben@bagu.org>
1786 Display currency codes in the details view.
1788 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1790 2011-12-02 Ben Konrath <ben@bagu.org>
1792 Avoid duplicate JNI call.
1794 JNI is not as efficient as pure Java and this is an easy (and small)
1797 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1798 Use previously retrieved value for whereClauseToTableName instead of
1801 2011-12-02 Ben Konrath <ben@bagu.org>
1803 Rename a couple of variables in RelatedListNavigation.
1805 This is a rename-only refactor.
1807 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1809 2011-12-02 Ben Konrath <ben@bagu.org>
1811 Indicate clearly that a mismatched primary key type is a bug.
1813 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1814 warning to error. Add 'This is a bug.' to message.
1816 2011-12-02 Ben Konrath <ben@bagu.org>
1818 Update / fix some comments.
1820 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1822 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1824 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1825 Fix comments. Add some TODOs.
1827 2011-12-02 Ben Konrath <ben@bagu.org>
1829 Enable navigation to details view with string primary key from related list.
1831 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1832 Create a text primary key value when return type of result is
1833 java.sql.Types.VARCHAR.
1835 2011-12-02 Ben Konrath <ben@bagu.org>
1837 Use checkboxes for booleans in the details view.
1839 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1841 2011-12-01 Ben Konrath <ben@bagu.org>
1843 Improve performance of related list height calculation.
1845 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1846 Put code to calculate the expected height in a static initializer so
1847 that that it's only called once.
1849 2011-12-01 Ben Konrath <ben@bagu.org>
1851 Show related list tables in notebooks (again).
1853 Calculate the height of the related list tables so the Notebook can be
1854 set the correct height. The height of the related list table is also needed by
1855 FlowTable to be able decide how to create the layout.
1857 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1858 and set the Portal height based on the height of the related list
1859 table and the Portal container.
1860 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1861 Add method to calculate the height of the related list tables.
1862 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1863 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1864 calculate the height of the Pager widget.
1866 2011-12-01 Ben Konrath <ben@bagu.org>
1868 Use CellTable API for table property instead of setting style on Element.
1870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1872 2011-12-01 Ben Konrath <ben@bagu.org>
1874 Make ListViewTable and RelatedListTable a consistent height.
1876 The tables are now a consistent height regardless of the contents of
1877 the table. A hidden button is added to empty rows to ensure that the
1878 height of these rows will match the height of rows with data.
1880 A navigation button column is now added to every table. The width of
1881 the navigation column is set to 0px when a RelatedListTable shouldn't
1882 have navigation buttons. This maintains the a consistent row height in
1883 tables that don't show the navigation buttons.
1885 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1886 navigation column when not needed.
1887 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1888 arguments for navigation button to constructor of ListViewTable.
1889 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1890 hidden button for empty data rows.
1891 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1892 arguments for navigation button to constructor.
1893 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1894 create navigation buttons. Add hideNavigationButtons() method.
1895 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1896 arguments for navigation button to constructor.
1898 2011-12-01 Ben Konrath <ben@bagu.org>
1900 Use 'visibility: hidden' in Utils.getWidgetHeight().
1902 This is better choice because hidden elements are invisible, don't
1903 respond to events and are not part of the tab order. They will,
1904 however, take up space which is required to be able to calculate the
1905 height of the widget.
1907 * src/main/java/org/glom/web/client/Utils.java:
1909 2011-12-01 Ben Konrath <ben@bagu.org>
1911 Use Utils.getWidgetHeight() in FlowTable.
1913 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1915 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1917 2011-12-01 Ben Konrath <ben@bagu.org>
1919 Put the details css class name on the correct table column.
1921 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1923 2011-11-30 Ben Konrath <ben@bagu.org>
1925 Update for java-libglom API change.
1927 The getters and setters on FieldFormatting and NumericFormat were
1928 changed to remove the 'M'.
1930 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1932 2011-11-29 Ben Konrath <ben@bagu.org>
1934 Only allow RelatedListTables in Portals.
1936 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1938 2011-11-29 Ben Konrath <ben@bagu.org>
1940 Only create a contents panel for Portals when title is being set.
1942 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1944 2011-11-29 Ben Konrath <ben@bagu.org>
1946 Set TabLayoutPanel height based on calculated height its widgets.
1948 This is a potential fix for this bug:
1950 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1952 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1954 2011-11-29 Ben Konrath <ben@bagu.org>
1956 Align details field labels and data with the Open buttons.
1958 * src/main/webapp/style.css:
1960 2011-11-29 Ben Konrath <ben@bagu.org>
1962 Remove unnecessary <div> in the Notebook widget.
1964 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1965 method to get container FlowPanel (<div>).
1966 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1967 initWidget() method directly on the TabLayoutPanel widget instead of
1968 Group's container widget.
1970 2011-11-29 Ben Konrath <ben@bagu.org>
1972 Don't add group titles for Portals in Notebooks.
1974 This reverts the previous patch and fixes a bug I introduced with
1975 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1977 * src/main/java/org/glom/web/client/ui/details/Group.java:
1978 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1980 2011-11-28 Ben Konrath <ben@bagu.org>
1982 Remove unused boolean argument in Portal constructor.
1984 Just a code cleanup.
1986 * src/main/java/org/glom/web/client/ui/details/Group.java:
1987 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1989 2011-11-28 Ben Konrath <ben@bagu.org>
1991 Remove hack for glom 1.18 style glom files.
1993 * src/main/java/org/glom/web/client/ui/details/Group.java:
1994 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1995 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1997 2011-11-28 Ben Konrath <ben@bagu.org>
1999 Use Gda Value version of primary key to log result too large error.
2001 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2003 2011-11-28 Ben Konrath <ben@bagu.org>
2005 Don't use TypedDataItem.getText() for Unknown types from the URL.
2007 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2008 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2009 instead of getText().
2010 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2011 String field and getUnknown() method.
2013 2011-11-28 Ben Konrath <ben@bagu.org>
2015 Log an error message when the java-libglom .so is not present.
2017 The error message was being set in the exception but not logged.
2019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2021 2011-11-28 Ben Konrath <ben@bagu.org>
2023 Ignore LayoutItem_CalendarPortals.
2025 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2026 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2028 2011-11-28 Ben Konrath <ben@bagu.org>
2030 Extract method for creating the LayoutItemPortal DTO.
2032 Just breaking the code up into smaller chunks.
2034 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2036 2011-11-28 Ben Konrath <ben@bagu.org>
2040 This should have been added with the refactor. Oops!
2042 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2044 2011-11-28 Ben Konrath <ben@bagu.org>
2046 Create primary key value from URL string using type from Glom document.
2048 See this bug, comments 19 - 25:
2050 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2052 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2053 create a TypeDataItem for the primary key here when loading from a
2054 URL. Show the same string for the primary key value as was received
2055 from the URL string (when loading from a URL).
2056 * src/main/java/org/glom/web/server/Utils.java: Update method for
2057 creating the Gda Value from the TypeDataItem to properly deal with
2058 creating a Gda Value based on the Glom document type for the primary
2059 key value string when loading from a URL.
2060 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2061 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2062 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2063 Update for changed method name.
2065 2011-11-27 Ben Konrath <ben@bagu.org>
2067 Rename PrimaryKeyItem to TypedDataItem.
2069 The name PrimaryKeyItem suggests what the class should be used for.
2070 TypedDataItem is a neutral name that describes the class better.
2072 This is a rename-only refactor.
2074 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2075 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2076 * src/main/java/org/glom/web/client/Utils.java:
2077 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2078 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2079 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2080 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2081 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2082 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2083 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2084 * src/main/java/org/glom/web/server/Utils.java:
2085 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2086 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2087 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2088 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2090 2011-11-25 Ben Konrath <ben@bagu.org>
2092 Improve Gda Value conversion from PrimaryKeyItem.
2094 The value from the PrimaryKeyItem is only used if its type match the
2095 type from the glom document.
2097 * src/main/java/org/glom/web/server/Utils.java:
2099 2011-11-25 Ben Konrath <ben@bagu.org>
2101 Manually check if the java-liblgom .so is visible to the JVM.
2103 It seems that Tomcat has problems when a static initializer throws an
2104 exception. This check is done before the first method call into
2105 java-libglom so that execution doesn't continue if the .so is not
2108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2110 2011-11-25 Ben Konrath <ben@bagu.org>
2112 Improve browser configuration error messages.
2116 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2118 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2119 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2120 getConfigurationErrorMessage() method.
2121 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2122 Get and display a specific configuration error message when no Glom
2123 documents are found.
2124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2125 Implement getConfigurationErrorMessage() method. Surround configuration
2126 code in the init() method with a try/catch block. This allows the
2127 errors to be caught while keeping the servlet available to retrieve the
2128 configuration error message.
2130 2011-11-25 Ben Konrath <ben@bagu.org>
2132 Don't use Strings to hold primary key values.
2134 The primary key values are now held in a new data object
2135 (PrimaryKeyItem) that holds type information and the primary key value
2136 using the correct type.
2138 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2141 PrimaryKeyItem instead of String to hold the primary key value.
2142 * src/main/java/org/glom/web/client/Utils.java: Remove
2143 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2144 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2146 PrimaryKeyItem instead of String to hold the primary key value. Load
2147 document selection page when the documentID has not been set correctly.
2148 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2149 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2151 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2152 Return empty string for URL instead of "null".
2153 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2154 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2155 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2156 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2157 PrimaryKeyItem instead of String to hold primary key values.
2158 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2159 PrimaryKeyValue to a Gda Value.
2160 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2161 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2162 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2163 Replace temporary database access code that uses the PrimaryKeyValue to
2164 Gda Value conversion.
2165 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2166 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2167 PrimaryKeyItem instead of String.
2168 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2169 hold primary key values.
2171 2011-11-24 Ben Konrath <ben@bagu.org>
2173 Use newly added java-libglom API to create queries.
2175 This isn't finished. I still need to stop using Strings for primary key
2176 values in the client code.
2178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2179 libglom to use fake connections so that retrieving the query string will
2181 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2182 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2183 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2184 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2185 Use the newly added libglom sql methods and classes to create the
2186 query. Add temporary hack to convert primary value strings to Gda
2189 2011-11-23 Ben Konrath <ben@bagu.org>
2191 Don't explicitly set the height of Portals.
2193 See comments 6 - 10 of this bug for details:
2195 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2197 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2199 2011-11-23 Ben Konrath <ben@bagu.org>
2201 Use an HTML table instead of CSS for the FlowTable layout.
2203 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2204 GWT's FlexTable to implement the FlowTable.
2205 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2207 2011-11-18 Ben Konrath <ben@bagu.org>
2209 Add boolean example to HTML table mockup.
2211 * mockups/details-view-html-tables-text-entries.html:
2213 2011-11-17 Ben Konrath <ben@bagu.org>
2215 Ensure the pager buttons are always visible for related lists.
2217 To accomplish this, I've turned off text wrapping in the list view and
2218 related list tables for both the header and data text. The related list
2219 table now has a fixed layout so the it doesn't overflow its container.
2220 This is required to ensure that the cell text is clipped when it
2221 overflows the cell and an ellipsis is added to the right side of the
2222 cell when text is clipped.
2224 A fixed table layout for the related list table in the details view
2225 seems what we want for the details view anyway, so the side-effect is
2228 The ellipsis will only be displayed in Firefox >= 7.
2232 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2234 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2235 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2236 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2238 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2239 Set the 'table-layout: fixed' CSS property to the related list table.
2240 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2241 'white-space: nowrap;' CSS property on both the list view and the
2242 related list tables.
2244 2011-11-16 Ben Konrath <ben@bagu.org>
2246 Rework the fix for empty notebook tab labels.
2248 Setting the empty group titles with its name caused problems for the
2249 details layout. Instead of using libglom's
2250 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2251 to the client when the title is empty. This allows the Notebook to use
2252 the name when the title is empty without affecting anything else.
2254 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2255 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2257 2011-11-16 Ben Konrath <ben@bagu.org>
2259 Set group titles with name when title is empty.
2261 This fixes a problem with an empty notebook tab label in the Lesson
2262 Planner document. The forth tab in the notebook should be "Internet":
2264 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2266 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2267 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2270 2011-11-16 Ben Konrath <ben@bagu.org>
2272 Remove whitespace from the configured username properties.
2274 This assumes that usernames won't have whitespace at the beginning
2275 or end. But I think this is a reasonable assumption.
2277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2278 String.trim() to remove the whitespace from the username properties.
2280 2011-11-15 Ben Konrath <ben@bagu.org>
2282 Add details view mockup with HTML tables and text entries.
2284 This is from the attachment on this bug:
2286 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2288 * mockups/details-view-html-tables-text-entries.html:
2290 2011-11-15 Ben Konrath <ben@bagu.org>
2292 Add space between the columns of the flow table.
2296 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2298 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2299 space between columns in the flow table.
2301 2011-11-15 Ben Konrath <ben@bagu.org>
2303 Add backup files to the .gitignore.
2305 * .gitignore: Ignore files that end with ~.
2307 2011-11-09 Ben Konrath <ben@bagu.org>
2309 Use latest release of gwt-log.
2311 Gwt-log releases are now being submitted to the maven central
2312 repository so manual installation of the jar is no longer required.
2314 * pom.xml: Update version and groupId of gwt-log dependency.
2316 2011-10-31 Ben Konrath <ben@bagu.org>
2318 Don't use GWT numeric formatting to override the glom currency formatting.
2320 Currencies are now displayed like they are in Glom. See this bug:
2322 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2324 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2326 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2327 currency code to constructor and set it when the cell is rendered.
2328 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2329 currency code to the constructor of the NumericCell.
2331 2011-10-27 Ben Konrath <ben@bagu.org>
2333 Require the latest release of java-libglom (1.17.4).
2337 2011-10-26 Ben Konrath <ben@bagu.org>
2339 Add style to Notebook that matches current theme.
2341 It's not the best style in the world but it's better than the default.
2343 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2344 padding at the bottom of the child widgets.
2345 * src/main/webapp/style.css: Add style for the Notebook.
2347 2011-10-26 Ben Konrath <ben@bagu.org>
2349 Move servlet initialization code to overridden init method.
2351 This is half of the solution to getting proper error messages
2352 displayed when configuration errors occur. Here's the relevant bug:
2354 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2356 The rest of the solution involves surrounding the init method with a
2357 try/catch block and setting a global variable with the error /
2358 exception. A new async method should be created to retrieve and display
2359 the error message / exception.
2361 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2362 code from constructor to init method adding exceptions as needed.
2364 2011-10-26 Ben Konrath <ben@bagu.org>
2366 Add script to monitor and restart tomcat if required.
2368 * utils/check-and-recover-tomcat.py: New file.
2370 2011-10-26 Ben Konrath <ben@bagu.org>
2372 Display the correct number of data items in the pager.
2376 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2378 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2379 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2380 The implementation is the same for both tables: Keep track of the
2381 number of non-empty rows and fire and RowCountChangeEvent after the data has
2383 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2384 custom Pager class that subclasses SimplePager to handle displaying
2385 the correct number when empty rows have been added.
2387 2011-10-26 Ben Konrath <ben@bagu.org>
2389 Correct error in previous commit.
2391 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2392 eventBus parameter from listView.setCellTable().
2394 2011-10-26 Ben Konrath <ben@bagu.org>
2396 Fix error in TODO comment.
2398 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2400 2011-10-24 Ben Konrath <ben@bagu.org>
2402 Create Notebook widgets to the details view.
2404 This isn't finished just yet - I still need to create a reasonable
2405 style to match the current theme.
2407 * src/main/java/org/glom/web/client/Utils.java: Add method for
2408 calculating the height of a widget. This is used in the Notebook class.
2409 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2410 new constructor method in Group.
2411 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2412 method for creating child widget that can be used by subclasses
2413 like Notebook. New constructor that allows disabling the group
2414 titles - Notebooks don't set a group title for their child groups.
2415 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2416 to make Notebooks using GWT's TabLayoutPanel.
2417 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2418 constructor that allows disabling the group titles.
2419 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2420 LayoutItemNotebook DTO.
2421 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2422 DTO for Notebooks. It's just an empty class for now but we might need
2423 it to transfer some specific information in the future.
2425 2011-10-21 Ben Konrath <ben@bagu.org>
2427 Add navigation buttons to related list tables.
2429 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2430 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2432 method getSuitableRecordToViewDetails() for getting the table name
2433 and primary key value for related list navigation buttons.
2434 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2435 private cell renderer class to get the navigation information for
2436 related list tables from the server. Extract the navigation
2437 processing code from the details cell navigation and use it for the
2438 related list navigation as well.
2439 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2440 cell renderer class for the details open buttons. This was needed
2441 because the related list navigation buttons and the list view
2442 navigation buttons need to react differently when clicked.
2443 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2444 the onEnterKeyDown() method because it's now overriden in the
2445 subclasses that are specific to the related list tables and the list
2447 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2448 the vertical size a little because the buttons add a bit of vertical
2449 space to table. This is not a perfect solution because the vertical
2450 size of with table fewer than 5 rows will be a little smaller.
2451 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2452 changes in how navigation buttons are handled.
2453 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2454 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2455 database access object.
2456 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2457 to find the portal for a given relationship name from
2458 RelatedListDBAccess. Add method to find a primary key field for a
2460 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2461 Move code to find the portal for a given relationship name to
2463 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2464 New file: database access object for getting the related list
2465 navigation information (the table name and the primary key value).
2466 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2467 DTO for transferring a table name to navigate to and a primary key
2469 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2470 boolean and getter/setter to specifies if the related list should add
2473 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2475 Use the master branch of java-libglom
2477 * pom.xml: Depend on java-libglom 1.19 instead.
2479 This is the master branch. See also the libglom-1-18 branch.
2481 2011-10-11 Ben Konrath <ben@bagu.org>
2483 Enable the open navigation button when the data has been set.
2485 This avoids having active buttons that don't do anything when the data
2488 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2490 2011-10-11 Ben Konrath <ben@bagu.org>
2492 Use IsWidget interface for FlowTableItem.
2494 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2495 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2497 2011-10-11 Ben Konrath <ben@bagu.org>
2499 Remove GWT styling from open button in details view.
2501 There are still some issues with how the details cell is arranged but
2502 this should be made to match Glom 1.20. I'm going to leave fixing this
2503 until I have Glom 1.20 up and running.
2505 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2506 style name on open button.
2507 * src/main/webapp/style.css: Move and edit details-navigation class.
2508 Re-arrange some classes to make them appear in the same order as the
2511 2011-10-07 Ben Konrath <ben@bagu.org>
2513 Update to GWT 2.4.0.
2515 * .gitignore: Ignore new cache directory.
2516 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2517 * pom.xml: Change GWT and maven plugin to 2.4.0.
2518 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2520 * src/main/java/org/glom/web/client/ClientFactory.java:
2521 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2522 * src/main/java/org/glom/web/client/OnlineGlom.java:
2523 Update source for API changes.
2524 * utils/build-onlineglom-war.sh: Remove cache directory before the
2527 2011-10-07 Ben Konrath <ben@bagu.org>
2529 Add navigation buttons in the details view.
2531 This isn't finished but I thought I'd commit what I have as it's a
2532 pretty good start. I still need to:
2534 1. Change the style so that it fits better into the current theme
2535 2. Adjust the details cell to expand as much as possible.
2537 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2538 click handlers to navigation buttons in the DetailsCells. Create a
2539 refreshData() method to get just the data from the server without the
2541 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2542 Update the tableSelector and browser title when the table name
2543 changes without using the tableSelector.
2544 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2545 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2546 getDetailsCells() to getCells(). Update variable names.
2547 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2548 method to set click handler on navigation button. Rename a few
2549 variables. Add navigation buttons where needed.
2550 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2551 variables and methods.
2552 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2553 navigation boolean and navigation table as required in the
2554 LayoutItemField DTO.
2555 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2556 variables for navigation along with getter/setter methods.
2558 2011-10-07 Ben Konrath <ben@bagu.org>
2560 Rename Field to DetailsCell.
2562 This is a refactor-only commit. No functionality has been added or
2565 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2566 Update variable and method names.
2567 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2568 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2569 variable and method names.
2570 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2572 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2573 variable and method names.
2575 2011-10-07 Ben Konrath <ben@bagu.org>
2577 Create separate methods for layout and data the details view.
2579 This is a refactor-only commit. No functionality has been added or
2582 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2583 private methods: setData(), createLayout().
2585 2011-10-07 Ben Konrath <ben@bagu.org>
2587 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2589 This is part of a change to get navigation buttons in the details view
2590 but it should have been done this way from the start.
2592 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2593 for method name change in TableSelectionView.
2594 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2595 Create TableChangeEvent and set the browser title using the
2596 TableSelectionView API.
2597 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2598 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2599 Change getSelectedTable() to getSelectedTableName(). Add
2600 getSelectedTableTitle().
2602 2011-10-07 Ben Konrath <ben@bagu.org>
2604 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2606 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2608 2011-10-07 Ben Konrath <ben@bagu.org>
2610 Update TableChangeEvent to use newTableName naming convention.
2612 This makes the class more consistent with GWT naming conventions.
2614 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2615 Update for method name change in TableChangeEvent.
2616 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2617 for method name change in TableChangeEvent.
2618 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2619 newTableName variable and getter method. Make toDebugString()
2622 2011-09-30 Ben Konrath <ben@bagu.org>
2624 Disable the pager in the list tables when the data row count is less than the minimum.
2626 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2627 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2629 2011-09-30 Ben Konrath <ben@bagu.org>
2631 Add empty rows to the end of related list and list view tables.
2633 I also extracted the cell rendering classes from the ListTable because
2634 the code was becoming a little crazy with all the anonymous inner
2635 classes. My plan is to use these cell rendering classes in the details
2636 view as well so this refactor will be needed for that change.
2638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2639 set the row count in related list tables if the data has more rows
2640 than the minimum number of rows visible.
2641 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2642 row count in list view tables if the data has more rows than the
2643 minimum number of rows visible.
2644 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2645 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2647 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2648 for rendering TYPE_NUMERIC cells. The code was extracted from the
2650 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2651 class for rendering cells with buttons in list views. The code was
2652 extracted from the ListTable class.
2653 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2654 for rendering TYPE_TEXT cells. The code was extracted from the
2656 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2657 Add empty rows to the end of the data if required. Implement
2658 ListTable.getMinNumVisibleRows().
2659 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2660 cell renderer code to public classes. Return null in
2661 Column.getValue() for empty rows. Add new abstract method:
2662 getMinNumVisibleRows(). Move code to set the row count of the list view
2663 table to ListViewImpl.
2664 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2665 empty rows to the end of the data if required. Implement
2666 ListTable.getMinNumVisibleRows().
2669 2011-09-27 Ben Konrath <ben@bagu.org>
2671 Use GWT.log for client-side debugging statements.
2673 These are optimized out when deployed so I should have used this method
2674 in the first place. These statements will eventually be replaced with some sort
2675 of notification in the browser.
2677 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2678 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2679 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2680 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2681 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2683 2011-09-27 Ben Konrath <ben@bagu.org>
2685 Put tableselector on the right, back to list link on right.
2687 The idea is that the table selector is acting like a label for the
2688 currently displayed table so it should be placed below the document title. This
2689 puts the table title in a similar position to where it is in Glom.
2691 * mockups/details-contacts.html:
2692 * mockups/details-projects.html:
2693 * mockups/listview-contacts.html:
2694 * mockups/listview-projects.html:
2695 * mockups/style.css:
2696 Update mockups to match how the interfaces currently look.
2697 * src/main/webapp/style.css: Swap positions of backlink with the table
2698 selector. Add some space on the left side of the table selector to
2699 line things up with the document title.
2701 2011-09-27 Ben Konrath <ben@bagu.org>
2703 Add field colouring to details view.
2705 This change re-works how field colouring works. The colour formatting
2706 information is now set to the client with the layout information instead of
2707 with the data. This eliminates the need to send the same colour strings for
2708 data in list view column when colour information is set.
2710 In order to set an alternate colour for negative numeric values, the
2711 number is now sent to client and formatted with the GWT NumberFormat class.
2713 This change also fixes:
2715 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2717 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2718 internationalization framework which is needed for client side numeric
2720 * src/main/java/org/glom/web/client/Utils.java: New file for some
2721 client static utility methods.
2722 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2723 the DataItem object to the Field class. Use a utility method to
2724 create the foreignKeyValue string.
2725 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2726 alignment and text colours in the constructor. Add setData(DataItem)
2727 method. Remove setText(String) method.
2728 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2729 colour information to GlomTextCell. Create and use GlomNumberCell for
2730 rendering numbers. Use utility method to get the string for the
2731 primary key of the key provider. Re-work how the horizontal alignment
2733 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2734 formatting to layout information. Methods for converting the libglom
2735 formatting information were moved from DBAccess.
2736 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2737 numeric formatting (it's now done on the client side). Don't set text
2738 colours in DataItem. Move libglom formatting conversion methods to
2740 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2741 getters/setters for text colour information.
2742 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2743 for transferring the libglom NumericFormat information to the client.
2744 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2745 and getters/setters for: GlomNumericFormat, background colour and
2746 foreground colour strings.
2748 2011-09-26 Ben Konrath <ben@bagu.org>
2750 Simplify code that iterates through the LayoutGroup.
2752 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2754 2011-09-26 Ben Konrath <ben@bagu.org>
2756 Accept Eclipse formatting for OnlineGlomServiceAsync.
2758 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2760 2011-09-26 Ben Konrath <ben@bagu.org>
2762 Don't use the ListDBAccess classes to get the primary key layout information.
2764 This was causing a bug where the wrong index for the hidden primary key
2765 was being sent to the client.
2767 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2768 primary key while creating the LayoutGroup DTO. Create a
2769 LayoutItemField DTO for hidden primary keys. Don't use the
2770 RelatedListDBAccess because it was only used for getting the primary
2772 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2773 access modifier from public to protected for getPrimaryKeyField() and
2774 getPrimaryKeyLayoutItemField().
2775 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2776 abstract method getExpectedResultSize() because RelatedListDBAccess
2777 doesn't have enough info to implement it.
2778 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2779 Remove @Override for getExpectedResultSize().
2780 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2781 Remove method getExpectedResultSize().
2783 2011-09-23 Ben Konrath <ben@bagu.org>
2785 Log which layout (list or details) the ignored item is from.
2787 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2789 2011-09-23 Ben Konrath <ben@bagu.org>
2791 Remove annotations that turn off code formatting in DataItem.
2793 * src/main/java/org/glom/web/shared/DataItem.java:
2795 2011-09-23 Ben Konrath <ben@bagu.org>
2797 Rename GlomField to DataItem and update associated methods.
2799 This is a rename-only refactor. No functionality has been added or
2802 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2803 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2804 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2805 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2806 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2807 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2808 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2809 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2811 * src/main/java/org/glom/web/server/database/DBAccess.java:
2812 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2813 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2814 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2815 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2816 * src/main/java/org/glom/web/shared/DataItem.java:
2817 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2818 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2820 2011-09-23 Ben Konrath <ben@bagu.org>
2822 Rename GlomDocument to DocumentInfo and update associated methods.
2824 This is a rename-only refactor. No functionality has been added or
2827 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2828 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2829 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2830 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2831 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2833 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2835 2011-09-20 Ben Konrath <ben@bagu.org>
2837 Require java-libglom 1.17.3.
2839 This picks up the fix for the seg fault problem with the Scenes table
2840 in the Openismus Film Manager example.
2844 2011-09-20 Ben Konrath <ben@bagu.org>
2846 Change the way sort clause is added for primary key when no sort clause is requested.
2848 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2849 before the sort clause is created. When a sort clause is not requested, the
2850 sort clause is created by finding the primary key in the LayoutFieldVector
2853 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2855 2011-09-20 Ben Konrath <ben@bagu.org>
2857 Log error message if no documents are found in the configured directory.
2859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2860 Extract the glom file extension string to a private static final class
2861 variable (mostly as syntactic sugar). Accept a minor formatting change.
2862 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2863 the example glom.document.directory configuration property to make it
2864 more clear that it can any directory, not just the home directory.
2866 2011-09-18 Ben Konrath <ben@bagu.org>
2868 Add related lists to details view.
2870 The related list table has support for paging and sorting just like the
2871 table in the list view.
2873 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2874 SQL queries for the related list tables.
2875 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2876 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2878 Rename getList methods to getListView and add comments. Remove
2879 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2880 it being unused. Add methods: getDetailsLayoutAndData(),
2881 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2882 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2883 Create the layout and set the data for the fields in one async call
2884 instead of two. Create related lists where appropriate.
2885 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2886 for method name changes in OnlineGlomService.
2887 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2888 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2889 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2891 * src/main/java/org/glom/web/client/ui/ListView.java:
2892 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2893 tableName from setCellTable(). Create a ListViewTable instead of
2895 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2896 represent a data field in the details view.
2897 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2898 from addDetailsCell() to Field class. Keep track of the Fields and
2899 Portals in the details view.
2900 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2901 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2902 and add a method to get it. Add method to set the contents of the
2904 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2905 New class for related list tables. This class has the data provider
2906 for the related list table.
2907 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2908 abstract class which is the base class for the ListViewTable and the
2910 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2911 New class for list view tables. This class has the data provider for
2912 the list view table.
2913 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2914 methods for related list tables. Add more information to the
2915 LayoutItemField and LayoutItemPortal DTOs.
2916 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2917 Remove debugging print statement.
2918 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2919 Remove debugging print statements. Add primary key field to SQL count
2921 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2922 Remove unnecessary LayoutFieldVector parameter from
2923 getResultSizeOfSQLQuery() method.
2924 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2925 New class for related list table database access.
2926 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2927 class that is a wrapper DTO for details view layout and data.
2928 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2929 new 'fromField' string to this DTO.
2930 * src/main/webapp/style.css: Remove bottom margin and override top
2933 2011-09-15 Ben Konrath <ben@bagu.org>
2935 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2937 This sets things up to make it easier to add the data retrieval for
2938 related lists (portals). No user noticeable changes were made with
2941 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2942 class has the code to retrieve the layouts and access the
2943 database using the new database helper classes.
2944 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2945 Most of the functionality has been removed from this class. This
2946 class now represents the public interface for the client side
2947 code. It also deals with configuring the servlet and cleaning
2948 things up when the servlet is stopped.
2949 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2950 of static methods into this utility class.
2951 * src/main/java/org/glom/web/server/database/DBAccess.java:
2952 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2953 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2954 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2955 These classes have the database retrieval code. The class hierarchy
2956 has been setup to make it easy to reuse code for similar
2959 2011-09-06 Ben Konrath <ben@bagu.org>
2961 Create separate classes for list table code and the data provider.
2963 As part of this refactor, I also split up the code a bit to make it
2966 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2967 table code to two new classes (below).
2968 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2969 with code from ListViewImpl.
2970 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2971 New file with code from ListViewImpl.
2973 2011-09-06 Ben Konrath <ben@bagu.org>
2975 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2977 This fixes the LayoutItemPortal DTO to match the libglom layout object
2980 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2982 2011-09-01 Ben Konrath <ben@bagu.org>
2984 Set title of Portals in the Details View.
2986 * pom.xml: Bump required version of java-libglom to 1.17.1.
2987 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2988 widget creation to its own class. Add comments to constructor.
2989 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2990 The code is mostly from the Group class with the title now set.
2991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2992 title of Portal. Update some comments. Fix some code formatting.
2994 2011-09-01 Ben Konrath <ben@bagu.org>
2996 Remove TODO comment for the flow table column width.
2998 The flow table column width is working correctly and doesn't need to be
2999 changed. See this mailing list post for more info:
3001 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3003 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3005 2011-08-27 Ben Konrath <ben@bagu.org>
3007 Add document title (database name) to top of the browser page.
3009 I added the document title to the TableSelecitonView but that will
3010 change if / when we add a view that doesn't require table selection.
3012 * mockups/details-contacts.html:
3013 * mockups/details-projects.html:
3014 * mockups/listview-contacts.html:
3015 * mockups/listview-projects.html:
3016 * mockups/style.css: Add document title to mockups to keep things
3018 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3019 sizes to account for the document title.
3020 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3021 Set the document title when it has been retrieved from the server.
3022 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3023 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3024 and implement setDocumentTitle(String) method.
3025 * src/main/webapp/style.css: Add ID for document title style.
3027 2011-08-25 Ben Konrath <ben@bagu.org>
3029 Add NavigationType enum to LayoutItemPortal DTO.
3031 This is the start of adding support for Portals to the Details View.
3033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3034 LayoutItem_Portal.navigation_type enum from libglom to
3035 LayoutItemPortal.NavigationType enum.
3036 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3037 NavigationType enum, field for storing the NavigationType and getter
3040 2011-08-25 Ben Konrath <ben@bagu.org>
3042 Implement the flow table layout in the Details View.
3044 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3045 FlowTable to Group to account for the renamed class.
3046 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3047 File. This is a container widget that implements the Glom details view
3048 flow table behaviour.
3049 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3050 org/glom/web/client/ui/FlowTable.java.
3051 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3052 so that the size of the subgroups are a closer match to the size of
3053 the Glom subgroups. This makes the flowtable layout match the layout
3054 in Glom for the Music Collection example file.
3056 2011-08-16 Ben Konrath <ben@bagu.org>
3058 Create container element for LayoutItemPortal in Details View.
3060 This will help me develop the layout for the FlowTable.
3062 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3063 fieldPanel variable to detailsCell.
3065 2011-08-15 Ben Konrath <ben@bagu.org>
3067 Set the height of the data element in the Details View.
3069 I changed the InlineLabels (text in a span element) to Labels (text in
3070 a div element) so that I could set the height of the details-data
3071 elements instead of the details-cell parent elements. This allows the
3072 the details-data element to display the correct height if style is
3073 applied that shows the height.
3075 This change has the added benefit of allowing the order of the labels
3076 and data elements to be changed for right-to-left languages.
3078 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3079 InlineLabels to Labels.
3080 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3081 InlineLabels to Labels. Set the height of the data element.
3082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3083 multiline text height in the Formatting DTO.
3084 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3085 for multiline height along with getter and setter methods.
3086 * src/main/webapp/style.css: Adjust style to account for the change
3087 from span elements to div elements in the details cell.
3089 2011-08-15 Ben Konrath <ben@bagu.org>
3091 Make the List View appearance match the mockups.
3093 It doesn't match exactly but it's much better than it was.
3095 * mockups/listview-contacts.html: Remove unused css classes.
3096 * mockups/listview-projects.html: Remove unused css classes.
3097 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3098 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3099 for mainPanel instead of VerticalPanel (table). Set style name on
3100 CellTable. Set style name on Details column. Right-align Details
3102 * src/main/webapp/style.css: Adjust properties to match the mockups.
3104 2011-08-12 Ben Konrath <ben@bagu.org>
3106 Add better support for subgroups in the details view.
3108 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3109 changed FlowTable constructor.
3110 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3111 support for subgroups and subgroup-titles.
3112 * src/main/webapp/style.css: Add CSS class for subgroups and
3115 2011-08-12 Ben Konrath <ben@bagu.org>
3117 Return the top level LayoutGroup title.
3119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3121 2011-08-11 Ben Konrath <ben@bagu.org>
3123 Make the TableSelector header match the mockup.
3125 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3126 the layout panel. Properly lineup the table selection header with
3127 the list and details view.
3128 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3129 margin around the details view.
3130 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3131 Rename listBox variable to tableSelector. Set id for the style sheet.
3132 Use a FlowPanel instead of a HorizontalPanel.
3133 * src/main/webapp/style.css: Add properties to make the TableSelector
3134 box match the mockups.
3136 2011-07-13 Ben Konrath <ben@bagu.org>
3138 Update install script for java-libglom version change.
3140 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3143 2011-07-13 Ben Konrath <ben@bagu.org>
3145 Add support sub-group in the details view.
3147 I also removed the code that special-cased the default details view
3150 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3152 I still have to make a proper flowtable.
3154 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3155 Don't special-case default details view layout.
3156 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3157 addLayoutField() as I'm going to use it.
3158 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3159 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3161 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3162 extracted from DetailsViewImpl.GroupPanel. Add support for
3164 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3165 column count when getting the details layout.
3167 2011-07-12 Ben Konrath <ben@bagu.org>
3169 Set browser title with database and table titles.
3171 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3172 Set the browser title when the table changes and when the activity
3174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3175 title when retrieving document info (the GlomDocument object).
3176 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3177 with getter and setter methods. Remove unused convenience constructor.
3178 Use default code formatting.
3180 2011-07-12 Ben Konrath <ben@bagu.org>
3182 Ignore LayoutItemPortals in the details view.
3184 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3187 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3188 LayoutItemPortal layout objects.
3189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3190 LayoutItemPortal objects when retrieving the details layout.
3191 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3192 file. This is an empty class and just used to get type information for
3195 2011-07-12 Ben Konrath <ben@bagu.org>
3197 Use java-libglom 1.17.0.
3201 2011-07-11 Ben Konrath <ben@bagu.org>
3203 Remove "Table:" label from table selector.
3205 This matches a recent change in the Glom UI.
3207 * mockups/details-contacts.html:
3208 * mockups/details-projects.html:
3209 * mockups/listview-contacts.html:
3210 * mockups/listview-projects.html: Remove the "Table:" label from the
3212 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3214 2011-07-11 Ben Konrath <ben@bagu.org>
3216 Add main groups to the details view.
3218 This makes things look a little nicer in the details view. The next step
3219 is to implement the flowtable.
3221 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3222 resources from the standard gwt css theme. Standard.css is now
3223 included in OnlineGlom.html so that the online glom css rules have
3224 precedence over the gwt theme.
3225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3226 the whole LayoutGroup to the DetailsView instead of just the titles.
3227 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3228 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3229 details layout with a helper class (GroupPanel). I might extract this
3230 class when I make the full flowtable.
3231 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3232 string as default so I don't have to worry about NPEs when processing
3234 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3235 note beside OnlineGlom.gwt.xml above).
3236 * src/main/webapp/style.css: Add default font-size to body to override
3237 the font-size set by the standard theme. Don't use h2 tags for
3238 group-title. Create new details-cell class.
3240 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3242 ConfiguredDocument: Set the port number too.
3244 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3245 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3246 Glom document. Presumably this worked sometimes so far because there is a
3247 default port number.
3249 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3251 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3253 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3254 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3255 correct, though we should throw an exception too.