1 2012-01-02 Murray Cumming <murrayc@murrayc.com>
3 Revert the COPYING.LESSER to COPYING rename.
5 Apparently both should be there if it is LGPL.
7 2012-01-03 Murray Cumming <murrayc@murrayc.com>
9 *View: Remove unused imports.
11 * src/main/java/org/glom/web/client/ui/DetailsView.java:
12 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
13 * src/main/java/org/glom/web/client/ui/ListView.java:
14 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
15 Remove unused imports, as suggested by Eclipse.
17 2012-01-02 Murray Cumming <murrayc@murrayc.com>
19 Move the *View::Presenter types, and some API into one base View.
21 * src/main/java/org/glom/web/client/ui/DetailsView.java:
22 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
23 * src/main/java/org/glom/web/client/ui/ListView.java:
24 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
25 Presenter, setPresenter() and clear() into a shared base interface,
26 to avoid the unnecessary duplicate Presenter types and to more clearly
27 show how the *Views share the same structure, even if they are not
30 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
31 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
33 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
34 * src/main/java/org/glom/web/client/activity/ListActivity.java:
35 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
37 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
40 Feel free to revert this if there is a good reason for the duplicate
43 2012-01-02 Murray Cumming <murrayc@murrayc.com>
45 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
47 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
48 a class member instead of a local variable in the method.
49 This lets us use it to get the view instances, for use in tests.
50 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
51 beforeOnlineGlom(): Test some more details of the initial view.
52 Again, this is not very useful.
54 To really test gwt-glom we will need to start a local postgresql
55 instance with local data, like the Glom tests in C++.
57 2012-01-02 Murray Cumming <murrayc@murrayc.com>
59 pom.xml: Mention the LGPL license.
61 * pom.xml: Add a licenses section.
62 * COPYING.LESSER: Move this to COPYING, which
63 previously contained the GPL. But gwt-glom is all LGPL.
65 2012-01-02 Murray Cumming <murrayc@murrayc.com>
67 Add project information to README and pom.xml.
69 * README: Add a brief description and mention some mvn
71 * pom.xml: This extra information shows up in mvn site
74 2011-01-02 Murray Cumming <murrayc@murrayc.com>
76 Use the latest java-libglom version.
78 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
80 2012-01-01 Murray Cumming <murrayc@murrayc.com>
82 GwtTestOnlineGlom: Test a little more.
84 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
85 protected rather than private, as suggested by the gwt-test-utils
87 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
88 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
89 Test the initial visibility of the panels.
91 However, this is not a very useful test.
92 And I wonder how we should generally test using this idea for an
93 activity/places app like ours where the real changes happen implicitly
94 based on the history token/URL.
96 2012-01-01 Murray Cumming <murrayc@murrayc.com>
98 Slight modification to *Mapper comments.
100 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
102 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
104 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
106 Remove comments mentioning GIN because they are just copied from
107 the example code and are apparently not helpful:
108 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
109 Also change the mention of a class that is only in the example code.
111 2012-01-01 Murray Cumming <murrayc@murrayc.com>
113 GwtTestOnlineGlom test: Minor changes.
115 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
116 Avoid the long qualified class name and modify the comment
117 because it is now obvious to me that the mocked class is the only
118 custom one created via GWT.create().
120 2012-01-01 Murray Cumming <murrayc@murrayc.com>
122 Tests: Added the beginnings of a test using gwt-test-utils.
124 * pom.xml: Add dependencies on gwt-test-utils and easymock.
125 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
126 which tells gwt-test-utils what class will be tested.
127 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
128 Add a simple (but empty) test case. One class, used by the OnlineGlom
129 class, is mocked so that it can be created. However, I am not sure
130 why only this class needs to be mocked.
132 Note that mockito seems more popular, and clearer, than easymock,
133 but I have not got that working yet. It might be a matter of the
136 This test is run during mvn integration-test.
138 2011-12-31 Murray Cumming <murrayc@murrayc.com>
140 Tests: Use junit4-style syntax instead of junit3-style.
142 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
143 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
144 * src/test/java/org/glom/web/shared/DataItemTest.java:
145 Use the @Test annotation rather than relying on the test*() prefix.
146 Also no longer implement TestCase, to avoid triggering support for
147 the junit3-way, which stops the annotations from working.
148 Change the imports from import junit.framework.* to
149 import org.junit.*, which is apparently the new way.
151 2011-12-31 Murray Cumming <murrayc@murrayc.com>
153 Added a test for ListPlace token parsing and creation.
155 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
156 This is much the same as DetailsPlaceTest.
158 I wonder how we could test the other parts of the *Place API.
160 2011-12-30 Murray Cumming <murrayc@murrayc.com>
162 DetailsPlace test: Also test getToken() and recreation via getPlace().
164 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
165 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
166 recreate it, testing the recreated DetailsPlace for the same parameter
169 2011-12-30 Murray Cumming <murrayc@murrayc.com>
171 Use the surefire-report plugin.
173 * pom.xml: This generates a HTML report about the tests in
174 target/site/surefire-report.html
175 when you do mvn surefire-report:report. It seems to be popular/normal.
177 2011-12-30 Murray Cumming <murrayc@murrayc.com>
179 Added a test for DetailsPlace.
181 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
182 Test the getPlace() token parsing.
184 2011-12-30 Murray Cumming <murrayc@murrayc.com>
186 Added a first unit test.
188 * pom.xml: Add a test goal, and a dependency on junit in that scope.
189 * src/test/java/org/glom/web/shared/DataItemTest.java:
190 This is a silly test but it is just to get things started. Note that
191 maven/junit finds the test because it looks in src/test by default.
193 2011-12-22 Ben Konrath <ben@bagu.org>
195 Change charsetName to "UTF-8" when replacing line breaks.
197 JavaScript requires the charsetName to be "UTF-8". CharsetName values
198 that work in Java (such as "UTF8") will not work when compiled to
201 This fixes a problem with multi-line details view fields that have hard
202 line breaks. The "License Text" field on this page demonstrates the
205 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
207 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
209 2011-12-22 Ben Konrath <ben@bagu.org>
211 Fix another bug with related list navigation.
213 I've tested all the navigation buttons in all of the related lists
214 so things should be good now.
216 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
218 2011-12-22 Ben Konrath <ben@bagu.org>
220 Fix a crasher when refreshing the list view with the default table.
222 This crash will also happen when loading the list view with the default
223 table from a link or bookmark.
225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
226 to the main document selection page when the document id hasn't been
228 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
229 the main document selection page when the document id hasn't been
231 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
232 values for the details place when the document id hasn't been set.
233 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
234 values for the list place when the document id hasn't been set.
236 2011-12-21 Ben Konrath <ben@bagu.org>
238 Protect against NPE when glom.document.locale is not in config.
240 This patch protects against an NPE when glom.document.locale is not in
241 the config file. This NPE will also happen if glom.document.locale is
244 The patch also updates the error message to display the class name when
245 the getMessage() returns null. This was happening when the NPE was
246 thrown and I had "Configuration Error: null". If an NPE is encountered
247 with this patch, "Configuration Error: NullPointerException " will be
250 This commit closes this bug:
252 https://bugzilla.gnome.org/show_bug.cgi?id=666669
254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
256 2011-12-20 Murray Cumming <murrayc@murrayc.com>
258 Rename onlineglom.properties to onlineglom.properties.sample.
260 * src/main/resources/onlineglom.properties: Rename to:
261 * src/main/resources/onlineglom.properties.sample:
262 * src/main/resources/README: And add this file explaining that people
263 should rename it back when deploying.
265 2011-12-20 Murray Cumming <murrayc@murrayc.com>
267 Allow choosing the translation in the .properties file.
269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
270 init(): Read a glom.document.locale value from the configuration file
271 and call Glom's TransatableItem::set_current_locale() method.
272 * src/main/resources/onlineglom.properties: Add a commented-out
273 example of this new setting.
275 It would be better to add &lang=de_DE to the URL, but the current
276 libglom API does not allow us to do this easily. I am working on that.
278 2011-12-19 Murray Cumming <murrayc@murrayc.com>
280 Avoid a crash in parsing of token parameters.
282 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
283 ava: getTokenParams(): Do not crash if a parameter has a key but no
284 value, and ignore parameters with neither.
286 2011-12-17 Murray Cumming <murrayc@murayc.com>
288 History token building/handling: Improve use of token parameters.
290 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
291 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
292 and buildParamsToken(HashMap), for use by derived classes.
293 Make the separator private because it is no longer be needed.
294 * src/main/java/org/glom/web/client/place/DetailsPlace.java
295 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
296 instead of manual string concatenation.
297 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
298 of hardcoded indices and awkward splitting code.
299 * src/main/java/org/glom/web/client/place/ListPlace.java
300 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
301 instead of manual string concatenation.
302 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
303 of hardcoded indices and awkward splitting code.
304 This should fix bug #666420
306 2011-12-16 Murray Cumming <murrayc@murrayc.com>
308 Fix a Navgiation->Navigation typo in the code.
310 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
311 Rename processNavgiation() to processNavigation().
313 2011-12-16 Murray Cumming <murrayc@murrayc.com>
315 Fix a seperator->separator typo in the code.
317 * src/main/java/org/glom/web/client/place/DetailsPlace.java
318 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
319 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
322 2011-12-15 Ben Konrath <ben@bagu.org>
324 Cleanup some comments.
326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
328 2011-12-14 Ben Konrath <ben@bagu.org>
330 Replace \n with <br/> for multiline text in the details view.
332 Vertical scrollbars are added when needed as well.
334 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
336 2011-12-14 Ben Konrath <ben@bagu.org>
338 Specify the font for document selection links.
340 * src/main/webapp/style.css:
342 2011-12-14 Ben Konrath <ben@bagu.org>
344 Fix bouncy CellTable while paging.
346 This doesn't currently work with related list tables in unselected
349 * src/main/java/org/glom/web/client/ui/list/ListTable.java
351 2011-12-14 Ben Konrath <ben@bagu.org>
353 Revamp the appearance of the document selection page.
355 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
356 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
357 * src/main/webapp/style.css:
359 2011-12-13 Ben Konrath <ben@bagu.org>
361 Set navigation button column to the smallest size possible.
363 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
365 2011-12-13 Ben Konrath <ben@bagu.org>
367 Change OpenButton nomenclature to NavigationButton.
369 Using NavigtionButton makes things more generic. Classes, methods and
370 variables have been changed.
372 This is a rename-only refactor.
374 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
375 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
376 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
377 Renamed from OpenButtonCell.
378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
379 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
380 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
382 2011-12-12 Ben Konrath <ben@bagu.org>
384 Remove unnecessary String argument in RelatedListTable and ListViewTable.
386 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
387 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
388 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
389 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
391 2011-12-12 Ben Konrath <ben@bagu.org>
393 Update variable names and comments.
395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
396 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
398 2011-12-12 Ben Konrath <ben@bagu.org>
400 Properly initialize numNonEmptyRows variable to zero.
402 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
403 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
405 2011-12-05 Ben Konrath <ben@bagu.org>
407 Add latest mockup with HTML tables.
409 Features of this mockup:
411 -> HTML table for flowtable
412 -> HTML table for flowtable column
413 -> Example of how related lists would look
414 -> Not using text entries for data items
416 The current version of Online Glom doesn't use HTML tables for the
419 This mockup has been sent to the glom-devel mailing list but it's good
420 to have it here as well.
422 * mockups/details-view-html-tables.html:
424 2011-12-05 Ben Konrath <ben@bagu.org>
426 Remove unnecessary getPrimaryKeyField() method.
428 getPrimaryKeyFieldForTable(String) has been renamed to
429 getPrimaryKeyField(String).
431 * src/main/java/org/glom/web/server/database/DBAccess.java:
432 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
433 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
435 2011-12-05 Ben Konrath <ben@bagu.org>
437 Add string representation of TypedDataItem value to conversion error message.
439 * src/main/java/org/glom/web/server/Utils.java: Logging the error
440 message was extracted into its own method to avoid duplication.
442 2011-12-05 Ben Konrath <ben@bagu.org>
444 Add type checking to navigation primary key value creation.
446 Create navigation primary key only if the expected type from the Glom
447 document matches the type returned by the SQL query.
449 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
451 2011-12-05 Ben Konrath <ben@bagu.org>
453 Rename a couple of variables in RelatedListNavigation.
455 This is a rename-only refactor.
457 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
459 2011-12-05 Ben Konrath <ben@bagu.org>
461 Move getListLayoutGroup() into getListViewLayoutGroup().
463 This removes getListLayoutGroup(). It was only being called by
464 getListViewLayoutGroup().
466 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
468 2011-12-05 Ben Konrath <ben@bagu.org>
470 Remove check for LayoutItem_Portal in list table method.
472 This check is no longer necessary because the method isn't being used
473 to create the LayoutItemPortal DTO.
475 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
477 2011-12-05 Ben Konrath <ben@bagu.org>
479 Properly support related list navigation.
481 Navigation from the "Repository Analyzer -> Package Scans ->
482 Dependencies" related table wasn't working because the primary key for
483 related tables wasn't being set properly. This commit fixes the
486 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
487 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
488 doesn't set the primary key properly for related list tables.
489 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
490 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
491 useful for getting the primary key for list view tables and for related
493 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
494 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
495 Move code to set the primary key for the table from the abstract
496 ListDBAccess class to ListViewDBAccess as it's only correct for list
498 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
499 Properly add primary key to related list tables.
501 2011-12-02 Ben Konrath <ben@bagu.org>
503 Properly set the horizontal alignment of fields.
505 This fix is for both the list tables and the details view.
507 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
508 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
509 to set the horizontal alignment of fields.
511 2011-12-02 Ben Konrath <ben@bagu.org>
513 Display currency codes in the details view.
515 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
517 2011-12-02 Ben Konrath <ben@bagu.org>
519 Avoid duplicate JNI call.
521 JNI is not as efficient as pure Java and this is an easy (and small)
524 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
525 Use previously retrieved value for whereClauseToTableName instead of
528 2011-12-02 Ben Konrath <ben@bagu.org>
530 Rename a couple of variables in RelatedListNavigation.
532 This is a rename-only refactor.
534 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
536 2011-12-02 Ben Konrath <ben@bagu.org>
538 Indicate clearly that a mismatched primary key type is a bug.
540 * src/main/java/org/glom/web/server/Utils.java: Change log level from
541 warning to error. Add 'This is a bug.' to message.
543 2011-12-02 Ben Konrath <ben@bagu.org>
545 Update / fix some comments.
547 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
549 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
551 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
552 Fix comments. Add some TODOs.
554 2011-12-02 Ben Konrath <ben@bagu.org>
556 Enable navigation to details view with string primary key from related list.
558 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
559 Create a text primary key value when return type of result is
560 java.sql.Types.VARCHAR.
562 2011-12-02 Ben Konrath <ben@bagu.org>
564 Use checkboxes for booleans in the details view.
566 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
568 2011-12-01 Ben Konrath <ben@bagu.org>
570 Improve performance of related list height calculation.
572 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
573 Put code to calculate the expected height in a static initializer so
574 that that it's only called once.
576 2011-12-01 Ben Konrath <ben@bagu.org>
578 Show related list tables in notebooks (again).
580 Calculate the height of the related list tables so the Notebook can be
581 set the correct height. The height of the related list table is also needed by
582 FlowTable to be able decide how to create the layout.
584 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
585 and set the Portal height based on the height of the related list
586 table and the Portal container.
587 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
588 Add method to calculate the height of the related list tables.
589 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
590 * src/main/webapp/style.css: Add css class for Pager. This is needed to
591 calculate the height of the Pager widget.
593 2011-12-01 Ben Konrath <ben@bagu.org>
595 Use CellTable API for table property instead of setting style on Element.
597 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
599 2011-12-01 Ben Konrath <ben@bagu.org>
601 Make ListViewTable and RelatedListTable a consistent height.
603 The tables are now a consistent height regardless of the contents of
604 the table. A hidden button is added to empty rows to ensure that the
605 height of these rows will match the height of rows with data.
607 A navigation button column is now added to every table. The width of
608 the navigation column is set to 0px when a RelatedListTable shouldn't
609 have navigation buttons. This maintains the a consistent row height in
610 tables that don't show the navigation buttons.
612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
613 navigation column when not needed.
614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
615 arguments for navigation button to constructor of ListViewTable.
616 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
617 hidden button for empty data rows.
618 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
619 arguments for navigation button to constructor.
620 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
621 create navigation buttons. Add hideNavigationButtons() method.
622 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
623 arguments for navigation button to constructor.
625 2011-12-01 Ben Konrath <ben@bagu.org>
627 Use 'visibility: hidden' in Utils.getWidgetHeight().
629 This is better choice because hidden elements are invisible, don't
630 respond to events and are not part of the tab order. They will,
631 however, take up space which is required to be able to calculate the
632 height of the widget.
634 * src/main/java/org/glom/web/client/Utils.java:
636 2011-12-01 Ben Konrath <ben@bagu.org>
638 Use Utils.getWidgetHeight() in FlowTable.
640 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
642 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
644 2011-12-01 Ben Konrath <ben@bagu.org>
646 Put the details css class name on the correct table column.
648 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
650 2011-11-30 Ben Konrath <ben@bagu.org>
652 Update for java-libglom API change.
654 The getters and setters on FieldFormatting and NumericFormat were
655 changed to remove the 'M'.
657 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
659 2011-11-29 Ben Konrath <ben@bagu.org>
661 Only allow RelatedListTables in Portals.
663 * src/main/java/org/glom/web/client/ui/details/Portal.java:
665 2011-11-29 Ben Konrath <ben@bagu.org>
667 Only create a contents panel for Portals when title is being set.
669 * src/main/java/org/glom/web/client/ui/details/Portal.java:
671 2011-11-29 Ben Konrath <ben@bagu.org>
673 Set TabLayoutPanel height based on calculated height its widgets.
675 This is a potential fix for this bug:
677 https://bugzilla.gnome.org/show_bug.cgi?id=665133
679 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
681 2011-11-29 Ben Konrath <ben@bagu.org>
683 Align details field labels and data with the Open buttons.
685 * src/main/webapp/style.css:
687 2011-11-29 Ben Konrath <ben@bagu.org>
689 Remove unnecessary <div> in the Notebook widget.
691 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
692 method to get container FlowPanel (<div>).
693 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
694 initWidget() method directly on the TabLayoutPanel widget instead of
695 Group's container widget.
697 2011-11-29 Ben Konrath <ben@bagu.org>
699 Don't add group titles for Portals in Notebooks.
701 This reverts the previous patch and fixes a bug I introduced with
702 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
704 * src/main/java/org/glom/web/client/ui/details/Group.java:
705 * src/main/java/org/glom/web/client/ui/details/Portal.java:
707 2011-11-28 Ben Konrath <ben@bagu.org>
709 Remove unused boolean argument in Portal constructor.
713 * src/main/java/org/glom/web/client/ui/details/Group.java:
714 * src/main/java/org/glom/web/client/ui/details/Portal.java:
716 2011-11-28 Ben Konrath <ben@bagu.org>
718 Remove hack for glom 1.18 style glom files.
720 * src/main/java/org/glom/web/client/ui/details/Group.java:
721 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
722 * src/main/java/org/glom/web/client/ui/details/Portal.java:
724 2011-11-28 Ben Konrath <ben@bagu.org>
726 Use Gda Value version of primary key to log result too large error.
728 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
730 2011-11-28 Ben Konrath <ben@bagu.org>
732 Don't use TypedDataItem.getText() for Unknown types from the URL.
734 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
735 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
736 instead of getText().
737 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
738 String field and getUnknown() method.
740 2011-11-28 Ben Konrath <ben@bagu.org>
742 Log an error message when the java-libglom .so is not present.
744 The error message was being set in the exception but not logged.
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
748 2011-11-28 Ben Konrath <ben@bagu.org>
750 Ignore LayoutItem_CalendarPortals.
752 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
753 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
755 2011-11-28 Ben Konrath <ben@bagu.org>
757 Extract method for creating the LayoutItemPortal DTO.
759 Just breaking the code up into smaller chunks.
761 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
763 2011-11-28 Ben Konrath <ben@bagu.org>
767 This should have been added with the refactor. Oops!
769 * src/main/java/org/glom/web/shared/TypedDataItem.java:
771 2011-11-28 Ben Konrath <ben@bagu.org>
773 Create primary key value from URL string using type from Glom document.
775 See this bug, comments 19 - 25:
777 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
779 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
780 create a TypeDataItem for the primary key here when loading from a
781 URL. Show the same string for the primary key value as was received
782 from the URL string (when loading from a URL).
783 * src/main/java/org/glom/web/server/Utils.java: Update method for
784 creating the Gda Value from the TypeDataItem to properly deal with
785 creating a Gda Value based on the Glom document type for the primary
786 key value string when loading from a URL.
787 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
788 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
789 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
790 Update for changed method name.
792 2011-11-27 Ben Konrath <ben@bagu.org>
794 Rename PrimaryKeyItem to TypedDataItem.
796 The name PrimaryKeyItem suggests what the class should be used for.
797 TypedDataItem is a neutral name that describes the class better.
799 This is a rename-only refactor.
801 * src/main/java/org/glom/web/client/OnlineGlomService.java:
802 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
803 * src/main/java/org/glom/web/client/Utils.java:
804 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
805 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
806 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
807 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
808 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
809 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
811 * src/main/java/org/glom/web/server/Utils.java:
812 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
813 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
814 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
815 * src/main/java/org/glom/web/shared/NavigationRecord.java:
817 2011-11-25 Ben Konrath <ben@bagu.org>
819 Improve Gda Value conversion from PrimaryKeyItem.
821 The value from the PrimaryKeyItem is only used if its type match the
822 type from the glom document.
824 * src/main/java/org/glom/web/server/Utils.java:
826 2011-11-25 Ben Konrath <ben@bagu.org>
828 Manually check if the java-liblgom .so is visible to the JVM.
830 It seems that Tomcat has problems when a static initializer throws an
831 exception. This check is done before the first method call into
832 java-libglom so that execution doesn't continue if the .so is not
835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
837 2011-11-25 Ben Konrath <ben@bagu.org>
839 Improve browser configuration error messages.
843 https://bugzilla.gnome.org/show_bug.cgi?id=662792
845 * src/main/java/org/glom/web/client/OnlineGlomService.java:
846 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
847 getConfigurationErrorMessage() method.
848 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
849 Get and display a specific configuration error message when no Glom
851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
852 Implement getConfigurationErrorMessage() method. Surround configuration
853 code in the init() method with a try/catch block. This allows the
854 errors to be caught while keeping the servlet available to retrieve the
855 configuration error message.
857 2011-11-25 Ben Konrath <ben@bagu.org>
859 Don't use Strings to hold primary key values.
861 The primary key values are now held in a new data object
862 (PrimaryKeyItem) that holds type information and the primary key value
863 using the correct type.
865 * src/main/java/org/glom/web/client/OnlineGlomService.java:
866 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
868 PrimaryKeyItem instead of String to hold the primary key value.
869 * src/main/java/org/glom/web/client/Utils.java: Remove
870 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
871 PrimaryKeyItem based on the GlomFieldType and the DataItem.
872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
873 PrimaryKeyItem instead of String to hold the primary key value. Load
874 document selection page when the documentID has not been set correctly.
875 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
876 DetailsPlace -> URL and URL -> DetailsPlace conversion with
878 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
879 Return empty string for URL instead of "null".
880 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
881 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
882 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
883 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
884 PrimaryKeyItem instead of String to hold primary key values.
885 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
886 PrimaryKeyValue to a Gda Value.
887 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
888 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
889 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
890 Replace temporary database access code that uses the PrimaryKeyValue to
891 Gda Value conversion.
892 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
893 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
894 PrimaryKeyItem instead of String.
895 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
896 hold primary key values.
898 2011-11-24 Ben Konrath <ben@bagu.org>
900 Use newly added java-libglom API to create queries.
902 This isn't finished. I still need to stop using Strings for primary key
903 values in the client code.
905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
906 libglom to use fake connections so that retrieving the query string will
908 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
909 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
910 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
911 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
912 Use the newly added libglom sql methods and classes to create the
913 query. Add temporary hack to convert primary value strings to Gda
916 2011-11-23 Ben Konrath <ben@bagu.org>
918 Don't explicitly set the height of Portals.
920 See comments 6 - 10 of this bug for details:
922 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
924 * src/main/java/org/glom/web/client/ui/details/Portal.java:
926 2011-11-23 Ben Konrath <ben@bagu.org>
928 Use an HTML table instead of CSS for the FlowTable layout.
930 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
931 GWT's FlexTable to implement the FlowTable.
932 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
934 2011-11-18 Ben Konrath <ben@bagu.org>
936 Add boolean example to HTML table mockup.
938 * mockups/details-view-html-tables-text-entries.html:
940 2011-11-17 Ben Konrath <ben@bagu.org>
942 Ensure the pager buttons are always visible for related lists.
944 To accomplish this, I've turned off text wrapping in the list view and
945 related list tables for both the header and data text. The related list
946 table now has a fixed layout so the it doesn't overflow its container.
947 This is required to ensure that the cell text is clipped when it
948 overflows the cell and an ellipsis is added to the right side of the
949 cell when text is clipped.
951 A fixed table layout for the related list table in the details view
952 seems what we want for the details view anyway, so the side-effect is
955 The ellipsis will only be displayed in Firefox >= 7.
959 https://bugzilla.gnome.org/show_bug.cgi?id=662930
961 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
962 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
963 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
965 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
966 Set the 'table-layout: fixed' CSS property to the related list table.
967 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
968 'white-space: nowrap;' CSS property on both the list view and the
971 2011-11-16 Ben Konrath <ben@bagu.org>
973 Rework the fix for empty notebook tab labels.
975 Setting the empty group titles with its name caused problems for the
976 details layout. Instead of using libglom's
977 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
978 to the client when the title is empty. This allows the Notebook to use
979 the name when the title is empty without affecting anything else.
981 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
982 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
984 2011-11-16 Ben Konrath <ben@bagu.org>
986 Set group titles with name when title is empty.
988 This fixes a problem with an empty notebook tab label in the Lesson
989 Planner document. The forth tab in the notebook should be "Internet":
991 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
993 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
994 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
997 2011-11-16 Ben Konrath <ben@bagu.org>
999 Remove whitespace from the configured username properties.
1001 This assumes that usernames won't have whitespace at the beginning
1002 or end. But I think this is a reasonable assumption.
1004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1005 String.trim() to remove the whitespace from the username properties.
1007 2011-11-15 Ben Konrath <ben@bagu.org>
1009 Add details view mockup with HTML tables and text entries.
1011 This is from the attachment on this bug:
1013 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1015 * mockups/details-view-html-tables-text-entries.html:
1017 2011-11-15 Ben Konrath <ben@bagu.org>
1019 Add space between the columns of the flow table.
1023 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1025 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1026 space between columns in the flow table.
1028 2011-11-15 Ben Konrath <ben@bagu.org>
1030 Add backup files to the .gitignore.
1032 * .gitignore: Ignore files that end with ~.
1034 2011-11-09 Ben Konrath <ben@bagu.org>
1036 Use latest release of gwt-log.
1038 Gwt-log releases are now being submitted to the maven central
1039 repository so manual installation of the jar is no longer required.
1041 * pom.xml: Update version and groupId of gwt-log dependency.
1043 2011-10-31 Ben Konrath <ben@bagu.org>
1045 Don't use GWT numeric formatting to override the glom currency formatting.
1047 Currencies are now displayed like they are in Glom. See this bug:
1049 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1051 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1053 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1054 currency code to constructor and set it when the cell is rendered.
1055 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1056 currency code to the constructor of the NumericCell.
1058 2011-10-27 Ben Konrath <ben@bagu.org>
1060 Require the latest release of java-libglom (1.17.4).
1064 2011-10-26 Ben Konrath <ben@bagu.org>
1066 Add style to Notebook that matches current theme.
1068 It's not the best style in the world but it's better than the default.
1070 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1071 padding at the bottom of the child widgets.
1072 * src/main/webapp/style.css: Add style for the Notebook.
1074 2011-10-26 Ben Konrath <ben@bagu.org>
1076 Move servlet initialization code to overridden init method.
1078 This is half of the solution to getting proper error messages
1079 displayed when configuration errors occur. Here's the relevant bug:
1081 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1083 The rest of the solution involves surrounding the init method with a
1084 try/catch block and setting a global variable with the error /
1085 exception. A new async method should be created to retrieve and display
1086 the error message / exception.
1088 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1089 code from constructor to init method adding exceptions as needed.
1091 2011-10-26 Ben Konrath <ben@bagu.org>
1093 Add script to monitor and restart tomcat if required.
1095 * utils/check-and-recover-tomcat.py: New file.
1097 2011-10-26 Ben Konrath <ben@bagu.org>
1099 Display the correct number of data items in the pager.
1103 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1105 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1106 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1107 The implementation is the same for both tables: Keep track of the
1108 number of non-empty rows and fire and RowCountChangeEvent after the data has
1110 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1111 custom Pager class that subclasses SimplePager to handle displaying
1112 the correct number when empty rows have been added.
1114 2011-10-26 Ben Konrath <ben@bagu.org>
1116 Correct error in previous commit.
1118 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1119 eventBus parameter from listView.setCellTable().
1121 2011-10-26 Ben Konrath <ben@bagu.org>
1123 Fix error in TODO comment.
1125 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1127 2011-10-24 Ben Konrath <ben@bagu.org>
1129 Create Notebook widgets to the details view.
1131 This isn't finished just yet - I still need to create a reasonable
1132 style to match the current theme.
1134 * src/main/java/org/glom/web/client/Utils.java: Add method for
1135 calculating the height of a widget. This is used in the Notebook class.
1136 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1137 new constructor method in Group.
1138 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1139 method for creating child widget that can be used by subclasses
1140 like Notebook. New constructor that allows disabling the group
1141 titles - Notebooks don't set a group title for their child groups.
1142 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1143 to make Notebooks using GWT's TabLayoutPanel.
1144 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1145 constructor that allows disabling the group titles.
1146 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1147 LayoutItemNotebook DTO.
1148 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1149 DTO for Notebooks. It's just an empty class for now but we might need
1150 it to transfer some specific information in the future.
1152 2011-10-21 Ben Konrath <ben@bagu.org>
1154 Add navigation buttons to related list tables.
1156 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1157 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1159 method getSuitableRecordToViewDetails() for getting the table name
1160 and primary key value for related list navigation buttons.
1161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1162 private cell renderer class to get the navigation information for
1163 related list tables from the server. Extract the navigation
1164 processing code from the details cell navigation and use it for the
1165 related list navigation as well.
1166 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1167 cell renderer class for the details open buttons. This was needed
1168 because the related list navigation buttons and the list view
1169 navigation buttons need to react differently when clicked.
1170 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1171 the onEnterKeyDown() method because it's now overriden in the
1172 subclasses that are specific to the related list tables and the list
1174 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1175 the vertical size a little because the buttons add a bit of vertical
1176 space to table. This is not a perfect solution because the vertical
1177 size of with table fewer than 5 rows will be a little smaller.
1178 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1179 changes in how navigation buttons are handled.
1180 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1181 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1182 database access object.
1183 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1184 to find the portal for a given relationship name from
1185 RelatedListDBAccess. Add method to find a primary key field for a
1187 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1188 Move code to find the portal for a given relationship name to
1190 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1191 New file: database access object for getting the related list
1192 navigation information (the table name and the primary key value).
1193 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1194 DTO for transferring a table name to navigate to and a primary key
1196 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1197 boolean and getter/setter to specifies if the related list should add
1200 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1202 Use the master branch of java-libglom
1204 * pom.xml: Depend on java-libglom 1.19 instead.
1206 This is the master branch. See also the libglom-1-18 branch.
1208 2011-10-11 Ben Konrath <ben@bagu.org>
1210 Enable the open navigation button when the data has been set.
1212 This avoids having active buttons that don't do anything when the data
1215 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1217 2011-10-11 Ben Konrath <ben@bagu.org>
1219 Use IsWidget interface for FlowTableItem.
1221 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1222 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1224 2011-10-11 Ben Konrath <ben@bagu.org>
1226 Remove GWT styling from open button in details view.
1228 There are still some issues with how the details cell is arranged but
1229 this should be made to match Glom 1.20. I'm going to leave fixing this
1230 until I have Glom 1.20 up and running.
1232 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1233 style name on open button.
1234 * src/main/webapp/style.css: Move and edit details-navigation class.
1235 Re-arrange some classes to make them appear in the same order as the
1238 2011-10-07 Ben Konrath <ben@bagu.org>
1240 Update to GWT 2.4.0.
1242 * .gitignore: Ignore new cache directory.
1243 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1244 * pom.xml: Change GWT and maven plugin to 2.4.0.
1245 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1247 * src/main/java/org/glom/web/client/ClientFactory.java:
1248 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1249 * src/main/java/org/glom/web/client/OnlineGlom.java:
1250 Update source for API changes.
1251 * utils/build-onlineglom-war.sh: Remove cache directory before the
1254 2011-10-07 Ben Konrath <ben@bagu.org>
1256 Add navigation buttons in the details view.
1258 This isn't finished but I thought I'd commit what I have as it's a
1259 pretty good start. I still need to:
1261 1. Change the style so that it fits better into the current theme
1262 2. Adjust the details cell to expand as much as possible.
1264 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1265 click handlers to navigation buttons in the DetailsCells. Create a
1266 refreshData() method to get just the data from the server without the
1268 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1269 Update the tableSelector and browser title when the table name
1270 changes without using the tableSelector.
1271 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1272 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1273 getDetailsCells() to getCells(). Update variable names.
1274 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1275 method to set click handler on navigation button. Rename a few
1276 variables. Add navigation buttons where needed.
1277 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1278 variables and methods.
1279 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1280 navigation boolean and navigation table as required in the
1281 LayoutItemField DTO.
1282 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1283 variables for navigation along with getter/setter methods.
1285 2011-10-07 Ben Konrath <ben@bagu.org>
1287 Rename Field to DetailsCell.
1289 This is a refactor-only commit. No functionality has been added or
1292 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1293 Update variable and method names.
1294 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1295 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1296 variable and method names.
1297 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1299 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1300 variable and method names.
1302 2011-10-07 Ben Konrath <ben@bagu.org>
1304 Create separate methods for layout and data the details view.
1306 This is a refactor-only commit. No functionality has been added or
1309 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1310 private methods: setData(), createLayout().
1312 2011-10-07 Ben Konrath <ben@bagu.org>
1314 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1316 This is part of a change to get navigation buttons in the details view
1317 but it should have been done this way from the start.
1319 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1320 for method name change in TableSelectionView.
1321 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1322 Create TableChangeEvent and set the browser title using the
1323 TableSelectionView API.
1324 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1325 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1326 Change getSelectedTable() to getSelectedTableName(). Add
1327 getSelectedTableTitle().
1329 2011-10-07 Ben Konrath <ben@bagu.org>
1331 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1333 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1335 2011-10-07 Ben Konrath <ben@bagu.org>
1337 Update TableChangeEvent to use newTableName naming convention.
1339 This makes the class more consistent with GWT naming conventions.
1341 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1342 Update for method name change in TableChangeEvent.
1343 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1344 for method name change in TableChangeEvent.
1345 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1346 newTableName variable and getter method. Make toDebugString()
1349 2011-09-30 Ben Konrath <ben@bagu.org>
1351 Disable the pager in the list tables when the data row count is less than the minimum.
1353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1354 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1356 2011-09-30 Ben Konrath <ben@bagu.org>
1358 Add empty rows to the end of related list and list view tables.
1360 I also extracted the cell rendering classes from the ListTable because
1361 the code was becoming a little crazy with all the anonymous inner
1362 classes. My plan is to use these cell rendering classes in the details
1363 view as well so this refactor will be needed for that change.
1365 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1366 set the row count in related list tables if the data has more rows
1367 than the minimum number of rows visible.
1368 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1369 row count in list view tables if the data has more rows than the
1370 minimum number of rows visible.
1371 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1372 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1374 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1375 for rendering TYPE_NUMERIC cells. The code was extracted from the
1377 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1378 class for rendering cells with buttons in list views. The code was
1379 extracted from the ListTable class.
1380 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1381 for rendering TYPE_TEXT cells. The code was extracted from the
1383 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1384 Add empty rows to the end of the data if required. Implement
1385 ListTable.getMinNumVisibleRows().
1386 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1387 cell renderer code to public classes. Return null in
1388 Column.getValue() for empty rows. Add new abstract method:
1389 getMinNumVisibleRows(). Move code to set the row count of the list view
1390 table to ListViewImpl.
1391 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1392 empty rows to the end of the data if required. Implement
1393 ListTable.getMinNumVisibleRows().
1396 2011-09-27 Ben Konrath <ben@bagu.org>
1398 Use GWT.log for client-side debugging statements.
1400 These are optimized out when deployed so I should have used this method
1401 in the first place. These statements will eventually be replaced with some sort
1402 of notification in the browser.
1404 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1405 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1407 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1408 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1410 2011-09-27 Ben Konrath <ben@bagu.org>
1412 Put tableselector on the right, back to list link on right.
1414 The idea is that the table selector is acting like a label for the
1415 currently displayed table so it should be placed below the document title. This
1416 puts the table title in a similar position to where it is in Glom.
1418 * mockups/details-contacts.html:
1419 * mockups/details-projects.html:
1420 * mockups/listview-contacts.html:
1421 * mockups/listview-projects.html:
1422 * mockups/style.css:
1423 Update mockups to match how the interfaces currently look.
1424 * src/main/webapp/style.css: Swap positions of backlink with the table
1425 selector. Add some space on the left side of the table selector to
1426 line things up with the document title.
1428 2011-09-27 Ben Konrath <ben@bagu.org>
1430 Add field colouring to details view.
1432 This change re-works how field colouring works. The colour formatting
1433 information is now set to the client with the layout information instead of
1434 with the data. This eliminates the need to send the same colour strings for
1435 data in list view column when colour information is set.
1437 In order to set an alternate colour for negative numeric values, the
1438 number is now sent to client and formatted with the GWT NumberFormat class.
1440 This change also fixes:
1442 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1444 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1445 internationalization framework which is needed for client side numeric
1447 * src/main/java/org/glom/web/client/Utils.java: New file for some
1448 client static utility methods.
1449 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1450 the DataItem object to the Field class. Use a utility method to
1451 create the foreignKeyValue string.
1452 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1453 alignment and text colours in the constructor. Add setData(DataItem)
1454 method. Remove setText(String) method.
1455 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1456 colour information to GlomTextCell. Create and use GlomNumberCell for
1457 rendering numbers. Use utility method to get the string for the
1458 primary key of the key provider. Re-work how the horizontal alignment
1460 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1461 formatting to layout information. Methods for converting the libglom
1462 formatting information were moved from DBAccess.
1463 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1464 numeric formatting (it's now done on the client side). Don't set text
1465 colours in DataItem. Move libglom formatting conversion methods to
1467 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1468 getters/setters for text colour information.
1469 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1470 for transferring the libglom NumericFormat information to the client.
1471 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1472 and getters/setters for: GlomNumericFormat, background colour and
1473 foreground colour strings.
1475 2011-09-26 Ben Konrath <ben@bagu.org>
1477 Simplify code that iterates through the LayoutGroup.
1479 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1481 2011-09-26 Ben Konrath <ben@bagu.org>
1483 Accept Eclipse formatting for OnlineGlomServiceAsync.
1485 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1487 2011-09-26 Ben Konrath <ben@bagu.org>
1489 Don't use the ListDBAccess classes to get the primary key layout information.
1491 This was causing a bug where the wrong index for the hidden primary key
1492 was being sent to the client.
1494 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1495 primary key while creating the LayoutGroup DTO. Create a
1496 LayoutItemField DTO for hidden primary keys. Don't use the
1497 RelatedListDBAccess because it was only used for getting the primary
1499 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1500 access modifier from public to protected for getPrimaryKeyField() and
1501 getPrimaryKeyLayoutItemField().
1502 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1503 abstract method getExpectedResultSize() because RelatedListDBAccess
1504 doesn't have enough info to implement it.
1505 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1506 Remove @Override for getExpectedResultSize().
1507 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1508 Remove method getExpectedResultSize().
1510 2011-09-23 Ben Konrath <ben@bagu.org>
1512 Log which layout (list or details) the ignored item is from.
1514 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1516 2011-09-23 Ben Konrath <ben@bagu.org>
1518 Remove annotations that turn off code formatting in DataItem.
1520 * src/main/java/org/glom/web/shared/DataItem.java:
1522 2011-09-23 Ben Konrath <ben@bagu.org>
1524 Rename GlomField to DataItem and update associated methods.
1526 This is a rename-only refactor. No functionality has been added or
1529 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1530 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1531 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1532 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1534 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1535 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1536 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1538 * src/main/java/org/glom/web/server/database/DBAccess.java:
1539 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1540 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1541 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1542 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1543 * src/main/java/org/glom/web/shared/DataItem.java:
1544 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1545 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1547 2011-09-23 Ben Konrath <ben@bagu.org>
1549 Rename GlomDocument to DocumentInfo and update associated methods.
1551 This is a rename-only refactor. No functionality has been added or
1554 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1555 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1556 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1557 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1558 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1559 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1560 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1562 2011-09-20 Ben Konrath <ben@bagu.org>
1564 Require java-libglom 1.17.3.
1566 This picks up the fix for the seg fault problem with the Scenes table
1567 in the Openismus Film Manager example.
1571 2011-09-20 Ben Konrath <ben@bagu.org>
1573 Change the way sort clause is added for primary key when no sort clause is requested.
1575 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1576 before the sort clause is created. When a sort clause is not requested, the
1577 sort clause is created by finding the primary key in the LayoutFieldVector
1580 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1582 2011-09-20 Ben Konrath <ben@bagu.org>
1584 Log error message if no documents are found in the configured directory.
1586 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1587 Extract the glom file extension string to a private static final class
1588 variable (mostly as syntactic sugar). Accept a minor formatting change.
1589 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1590 the example glom.document.directory configuration property to make it
1591 more clear that it can any directory, not just the home directory.
1593 2011-09-18 Ben Konrath <ben@bagu.org>
1595 Add related lists to details view.
1597 The related list table has support for paging and sorting just like the
1598 table in the list view.
1600 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1601 SQL queries for the related list tables.
1602 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1603 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1604 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1605 Rename getList methods to getListView and add comments. Remove
1606 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1607 it being unused. Add methods: getDetailsLayoutAndData(),
1608 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1609 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1610 Create the layout and set the data for the fields in one async call
1611 instead of two. Create related lists where appropriate.
1612 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1613 for method name changes in OnlineGlomService.
1614 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1615 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1616 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1618 * src/main/java/org/glom/web/client/ui/ListView.java:
1619 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1620 tableName from setCellTable(). Create a ListViewTable instead of
1622 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1623 represent a data field in the details view.
1624 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1625 from addDetailsCell() to Field class. Keep track of the Fields and
1626 Portals in the details view.
1627 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1628 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1629 and add a method to get it. Add method to set the contents of the
1631 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1632 New class for related list tables. This class has the data provider
1633 for the related list table.
1634 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1635 abstract class which is the base class for the ListViewTable and the
1637 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1638 New class for list view tables. This class has the data provider for
1639 the list view table.
1640 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1641 methods for related list tables. Add more information to the
1642 LayoutItemField and LayoutItemPortal DTOs.
1643 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1644 Remove debugging print statement.
1645 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1646 Remove debugging print statements. Add primary key field to SQL count
1648 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1649 Remove unnecessary LayoutFieldVector parameter from
1650 getResultSizeOfSQLQuery() method.
1651 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1652 New class for related list table database access.
1653 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1654 class that is a wrapper DTO for details view layout and data.
1655 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1656 new 'fromField' string to this DTO.
1657 * src/main/webapp/style.css: Remove bottom margin and override top
1660 2011-09-15 Ben Konrath <ben@bagu.org>
1662 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1664 This sets things up to make it easier to add the data retrieval for
1665 related lists (portals). No user noticeable changes were made with
1668 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1669 class has the code to retrieve the layouts and access the
1670 database using the new database helper classes.
1671 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1672 Most of the functionality has been removed from this class. This
1673 class now represents the public interface for the client side
1674 code. It also deals with configuring the servlet and cleaning
1675 things up when the servlet is stopped.
1676 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1677 of static methods into this utility class.
1678 * src/main/java/org/glom/web/server/database/DBAccess.java:
1679 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1680 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1681 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1682 These classes have the database retrieval code. The class hierarchy
1683 has been setup to make it easy to reuse code for similar
1686 2011-09-06 Ben Konrath <ben@bagu.org>
1688 Create separate classes for list table code and the data provider.
1690 As part of this refactor, I also split up the code a bit to make it
1693 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1694 table code to two new classes (below).
1695 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1696 with code from ListViewImpl.
1697 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1698 New file with code from ListViewImpl.
1700 2011-09-06 Ben Konrath <ben@bagu.org>
1702 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1704 This fixes the LayoutItemPortal DTO to match the libglom layout object
1707 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1709 2011-09-01 Ben Konrath <ben@bagu.org>
1711 Set title of Portals in the Details View.
1713 * pom.xml: Bump required version of java-libglom to 1.17.1.
1714 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1715 widget creation to its own class. Add comments to constructor.
1716 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1717 The code is mostly from the Group class with the title now set.
1718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1719 title of Portal. Update some comments. Fix some code formatting.
1721 2011-09-01 Ben Konrath <ben@bagu.org>
1723 Remove TODO comment for the flow table column width.
1725 The flow table column width is working correctly and doesn't need to be
1726 changed. See this mailing list post for more info:
1728 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1730 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1732 2011-08-27 Ben Konrath <ben@bagu.org>
1734 Add document title (database name) to top of the browser page.
1736 I added the document title to the TableSelecitonView but that will
1737 change if / when we add a view that doesn't require table selection.
1739 * mockups/details-contacts.html:
1740 * mockups/details-projects.html:
1741 * mockups/listview-contacts.html:
1742 * mockups/listview-projects.html:
1743 * mockups/style.css: Add document title to mockups to keep things
1745 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1746 sizes to account for the document title.
1747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1748 Set the document title when it has been retrieved from the server.
1749 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1750 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1751 and implement setDocumentTitle(String) method.
1752 * src/main/webapp/style.css: Add ID for document title style.
1754 2011-08-25 Ben Konrath <ben@bagu.org>
1756 Add NavigationType enum to LayoutItemPortal DTO.
1758 This is the start of adding support for Portals to the Details View.
1760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1761 LayoutItem_Portal.navigation_type enum from libglom to
1762 LayoutItemPortal.NavigationType enum.
1763 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1764 NavigationType enum, field for storing the NavigationType and getter
1767 2011-08-25 Ben Konrath <ben@bagu.org>
1769 Implement the flow table layout in the Details View.
1771 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1772 FlowTable to Group to account for the renamed class.
1773 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1774 File. This is a container widget that implements the Glom details view
1775 flow table behaviour.
1776 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1777 org/glom/web/client/ui/FlowTable.java.
1778 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1779 so that the size of the subgroups are a closer match to the size of
1780 the Glom subgroups. This makes the flowtable layout match the layout
1781 in Glom for the Music Collection example file.
1783 2011-08-16 Ben Konrath <ben@bagu.org>
1785 Create container element for LayoutItemPortal in Details View.
1787 This will help me develop the layout for the FlowTable.
1789 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1790 fieldPanel variable to detailsCell.
1792 2011-08-15 Ben Konrath <ben@bagu.org>
1794 Set the height of the data element in the Details View.
1796 I changed the InlineLabels (text in a span element) to Labels (text in
1797 a div element) so that I could set the height of the details-data
1798 elements instead of the details-cell parent elements. This allows the
1799 the details-data element to display the correct height if style is
1800 applied that shows the height.
1802 This change has the added benefit of allowing the order of the labels
1803 and data elements to be changed for right-to-left languages.
1805 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1806 InlineLabels to Labels.
1807 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1808 InlineLabels to Labels. Set the height of the data element.
1809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1810 multiline text height in the Formatting DTO.
1811 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1812 for multiline height along with getter and setter methods.
1813 * src/main/webapp/style.css: Adjust style to account for the change
1814 from span elements to div elements in the details cell.
1816 2011-08-15 Ben Konrath <ben@bagu.org>
1818 Make the List View appearance match the mockups.
1820 It doesn't match exactly but it's much better than it was.
1822 * mockups/listview-contacts.html: Remove unused css classes.
1823 * mockups/listview-projects.html: Remove unused css classes.
1824 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1825 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1826 for mainPanel instead of VerticalPanel (table). Set style name on
1827 CellTable. Set style name on Details column. Right-align Details
1829 * src/main/webapp/style.css: Adjust properties to match the mockups.
1831 2011-08-12 Ben Konrath <ben@bagu.org>
1833 Add better support for subgroups in the details view.
1835 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1836 changed FlowTable constructor.
1837 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1838 support for subgroups and subgroup-titles.
1839 * src/main/webapp/style.css: Add CSS class for subgroups and
1842 2011-08-12 Ben Konrath <ben@bagu.org>
1844 Return the top level LayoutGroup title.
1846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1848 2011-08-11 Ben Konrath <ben@bagu.org>
1850 Make the TableSelector header match the mockup.
1852 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1853 the layout panel. Properly lineup the table selection header with
1854 the list and details view.
1855 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1856 margin around the details view.
1857 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1858 Rename listBox variable to tableSelector. Set id for the style sheet.
1859 Use a FlowPanel instead of a HorizontalPanel.
1860 * src/main/webapp/style.css: Add properties to make the TableSelector
1861 box match the mockups.
1863 2011-07-13 Ben Konrath <ben@bagu.org>
1865 Update install script for java-libglom version change.
1867 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1870 2011-07-13 Ben Konrath <ben@bagu.org>
1872 Add support sub-group in the details view.
1874 I also removed the code that special-cased the default details view
1877 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1879 I still have to make a proper flowtable.
1881 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1882 Don't special-case default details view layout.
1883 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1884 addLayoutField() as I'm going to use it.
1885 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1886 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1888 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1889 extracted from DetailsViewImpl.GroupPanel. Add support for
1891 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1892 column count when getting the details layout.
1894 2011-07-12 Ben Konrath <ben@bagu.org>
1896 Set browser title with database and table titles.
1898 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1899 Set the browser title when the table changes and when the activity
1901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1902 title when retrieving document info (the GlomDocument object).
1903 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1904 with getter and setter methods. Remove unused convenience constructor.
1905 Use default code formatting.
1907 2011-07-12 Ben Konrath <ben@bagu.org>
1909 Ignore LayoutItemPortals in the details view.
1911 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1914 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1915 LayoutItemPortal layout objects.
1916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1917 LayoutItemPortal objects when retrieving the details layout.
1918 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1919 file. This is an empty class and just used to get type information for
1922 2011-07-12 Ben Konrath <ben@bagu.org>
1924 Use java-libglom 1.17.0.
1928 2011-07-11 Ben Konrath <ben@bagu.org>
1930 Remove "Table:" label from table selector.
1932 This matches a recent change in the Glom UI.
1934 * mockups/details-contacts.html:
1935 * mockups/details-projects.html:
1936 * mockups/listview-contacts.html:
1937 * mockups/listview-projects.html: Remove the "Table:" label from the
1939 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1941 2011-07-11 Ben Konrath <ben@bagu.org>
1943 Add main groups to the details view.
1945 This makes things look a little nicer in the details view. The next step
1946 is to implement the flowtable.
1948 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1949 resources from the standard gwt css theme. Standard.css is now
1950 included in OnlineGlom.html so that the online glom css rules have
1951 precedence over the gwt theme.
1952 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1953 the whole LayoutGroup to the DetailsView instead of just the titles.
1954 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1955 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1956 details layout with a helper class (GroupPanel). I might extract this
1957 class when I make the full flowtable.
1958 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1959 string as default so I don't have to worry about NPEs when processing
1961 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1962 note beside OnlineGlom.gwt.xml above).
1963 * src/main/webapp/style.css: Add default font-size to body to override
1964 the font-size set by the standard theme. Don't use h2 tags for
1965 group-title. Create new details-cell class.
1967 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1969 ConfiguredDocument: Set the port number too.
1971 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1972 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1973 Glom document. Presumably this worked sometimes so far because there is a
1974 default port number.
1976 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1978 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1980 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1981 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1982 correct, though we should throw an exception too.
1984 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1986 Fix a addDocuemnt typo.
1988 * src/main/java/org/glom/web/shared/Documents.java
1989 (Documents.addDocuemnt): Rename to addDocument().
1990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1991 (OnlineGlomServiceImpl.getDocuments): Adapt.
1993 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1995 Slightly improved log output when connection fails.
1997 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1998 (ConfiguredDocument.setUsernameAndPassword):
1999 We don't know for sure if it' the username/password that's wrong, so
2000 rephrase the message.
2001 Also ouput the exception message, though it's generic in this case.
2003 2011-07-08 Ben Konrath <ben@bagu.org>
2007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2008 added braces to a one line if statement because the Eclipse formatter
2009 was getting confused.
2011 2011-07-07 Ben Konrath <ben@bagu.org>
2013 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2015 These should really be two separate tasks but I counldn't get things to
2016 work with GWT 2.2.0 and Eclipse 3.7.
2020 * .settings/org.eclipse.jdt.core.prefs:
2021 * .settings/org.eclipse.jdt.ui.prefs:
2022 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2023 * .settings/org.eclipse.m2e.core.prefs:
2024 Add new config files. Update current files. Remove references to the
2025 webtools plugins as we're not using any of the webtools features.
2026 * .gitignore: Add logs directory which is created when running with
2028 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2029 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2030 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2032 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2034 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2036 onlineglom.properties: Add explanatory comments.
2038 * src/main/resources/onlineglom.properties: Also change the default user
2039 from ben to someuser, to avoid the risk of people thinking we just
2040 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2042 2011-06-28 Ben Konrath <ben@bagu.org>
2044 Use filename in Log for incorrect passwords.
2046 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2047 getFileName(String) method to get the filename from the URI.
2049 2011-06-28 Ben Konrath <ben@bagu.org>
2051 Add the table name to the URL token for the ListPlace.
2053 This makes things consistent between the DetailsPlace and the
2054 ListPlace. It also allows the the ListPlace to be bookmarked.
2056 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2057 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2059 Remove getDefaultListLayout(). The default layout is now returned
2060 by the getListLayout() method when the table name is an empty string.
2061 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2062 Add table name field. Change to a new ListPlace when the table
2063 has been changed. Use getListLayout() for getting the default
2065 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2066 Add table name field. Set the correct table name in the list box
2067 when loading from bookmark. This corrects a problem for the
2069 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2070 Move table name to super-class (HasSelectableTable). Move document
2071 and table URL keys to super-class in HasSelectableTable.
2072 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2073 Add table name field. Add Tokenizer class with URL key common to
2074 the subclasses (DetailsPlace and ListPlace).
2075 * src/main/java/org/glom/web/client/place/ListPlace.java:
2076 Add table name. Add code to parse the URL token.
2077 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2078 Update ListPlace construction with empty table name string.
2079 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2080 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2081 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2082 Update ListPlace construction with table name string.
2083 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2084 Change defaultTableName field to tableName to reflect how it's now
2085 used. Update the getter and setter methods.
2087 2011-06-28 Ben Konrath <ben@bagu.org>
2089 Enable the table selector in the DetailsView.
2091 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2092 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2094 Remove getDefaultDetailsLayout(). The default layout is now returned
2095 by the getDetailsLayout() method when the table name is an empty
2097 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2098 event handler for table change event. Change to using
2099 getDetailsLayout() for the default details layout.
2100 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2102 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2103 when navigating to the details place.
2105 2011-06-27 Ben Konrath <ben@bagu.org>
2107 Use filename based unique document ID in URL and for RPC.
2109 The document ID is the glom document name with spaces (' ') replaced
2110 with pluses ('+') and without the .glom extension.
2112 This change is mostly a string substitution of 'documentTitle' for
2113 'documentID'. The only code change is the addition of a Documents DTO to get the
2114 filename to document title mappings as indicated below.
2116 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2117 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2119 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2120 Use Documents DTO to create the document links in the document
2122 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2123 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2124 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2125 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2126 * src/main/java/org/glom/web/client/place/ListPlace.java:
2127 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2128 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2129 * src/main/java/org/glom/web/client/ui/ListView.java:
2130 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2131 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2132 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2133 * src/main/java/org/glom/web/server/Log.java:
2134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2135 getDocumentTitles() to getDocuments() and return the Documents DTO.
2136 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2137 transferring the filename to document title mappings.
2139 2011-06-25 Ben Konrath <ben@bagu.org>
2141 Make the authentication popup work again.
2143 This bug was introduced when I extracted ConfiguredDocument to its own class.
2145 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2146 correct success / fail status in setUsernameAndPassword().
2148 2011-06-25 Ben Konrath <ben@bagu.org>
2150 Use filename as unique key for configuring database usernames and passwords.
2152 This replaces the use of the Glom document title which could change
2153 depending on the locale. Thanks to Murray Cumming for pointing out this
2156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2157 * src/main/resources/onlineglom.properties:
2159 2011-06-24 Ben Konrath <ben@bagu.org>
2161 Pass primary key value to DetailsView.
2163 This enables the DetailsView to load the correct data.
2165 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2166 primary key value field and set in constructor. Pass primary key
2167 value to getDetailsData().
2168 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2169 variables for document title and primary key value.
2170 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2171 key value to the DetailsPlace.
2173 2011-06-24 Ben Konrath <ben@bagu.org>
2175 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2177 This allows the primary key to be retrieved by the Details button. This
2178 functionality has not been implemented yet but it's in the works.
2180 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2181 the LayoutGroup result to ListView.setCellTable instead of all of its
2182 fields individually.
2183 * src/main/java/org/glom/web/client/ui/ListView.java:
2184 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2185 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2186 get the primary key for the table.
2187 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2188 index of the primary key in the LayoutGroup accounting for hidden
2189 primary keys. Rename getJavaNumberFormat() to
2190 convertToJavaNumberFormat() for consistency. Cleanup / add some
2192 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2193 field for primary key index and a field to indicate whether the
2194 primary key is hidden or not.
2196 2011-06-23 Ben Konrath <ben@bagu.org>
2198 Rename getTableData methods to getListData.
2200 This is a rename refactor for consistency with other methods.
2202 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2203 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2204 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2207 2011-06-23 Ben Konrath <ben@bagu.org>
2209 Extract the ConfiguredDocument innerclass into its own class.
2211 This makes the servlet code more object oriented.
2213 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2214 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2216 new ConfiguredDocument class.
2218 2011-06-21 Ben Konrath <ben@bagu.org>
2220 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2222 This makes things more inline with how libglom works and reduces code
2223 duplication. This refactor lays the groundwork for adding the primary key to
2224 the LayoutGroup object.
2226 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2227 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2229 Change method names to getListLayout and getDefaultListLayout for
2230 consistency. Use LayoutGroup as the DTO for the list layout instead of
2231 ColumnInfo and LayoutListTable.
2232 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2233 new method names along with the LayoutGroup object for transferring the
2235 * src/main/java/org/glom/web/client/ui/ListView.java:
2236 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2237 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2238 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2240 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2241 Replaced with LayoutGroup.
2242 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2243 expectedResultSize and defaultTableName fields which are needed for
2245 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2246 type field which is needed for the list layout but will also be
2247 useful for the details layout as things progress.
2248 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2249 Make class abstract. Remove the unnecessary
2250 getFormattingHorizontalAlignment method. Add setFormatting method.
2252 2011-06-16 Ben Konrath <ben@bagu.org>
2254 Add scripts for building and installing war.
2256 These will help when updating OnlineGlom but they're also good
2257 supplemental documentation of the build and deployment proceeding.
2259 * utils/build-onlineglom-war.sh: New file.
2260 * utils/install-onlineglom-war.sh: New file.
2262 2011-06-16 Ben Konrath <ben@bagu.org>
2264 Create wrapper class to create consistent log messages.
2266 I wrapped methods in the Log class of gwt-log to add the method names
2267 from the servlet and create consistent formatting of the document title
2268 and table names in the log messages.
2270 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2271 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2272 log methods to use methods from wrapped Log class.
2274 2011-06-16 Ben Konrath <ben@bagu.org>
2276 Remove superfluous conditional return.
2278 Thanks to Murray Cumming for pointing this out!
2280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2282 2011-06-15 Ben Konrath <ben@bagu.org>
2284 Return an ArrayList of LayoutGroups for the Details layout.
2286 This corrects a problem with the details layout as it can have more
2287 than one top level LayoutGroup.
2289 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2290 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2291 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2292 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2293 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2294 with ArrayList of LayoutGroups for the details view layout.
2295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2296 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2297 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2298 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2299 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2300 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2302 2011-06-14 Ben Konrath <ben@bagu.org>
2304 Use cast_dynamic method to determine the libglom LayoutItem type.
2306 This is better than finding the LayoutItem type by using the string
2307 returned from the get_part_type_name() method.
2309 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2311 2011-06-14 Ben Konrath <ben@bagu.org>
2313 Add method names to log entries in the servlet.
2315 This helps when tracking down deployment problems.
2317 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2319 2011-06-14 Ben Konrath <ben@bagu.org>
2321 Add data to the DetailsView using a hard-coded primary key value.
2323 The layout and functionality of the DetailsView is not complete. This
2324 is just a checkpoint so the patch doesn't get too big.
2326 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2327 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2328 Add getDetailsData() servlet method.
2329 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2330 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2331 LayoutFields are added to the DetailsView.
2332 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2333 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2334 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2335 take the string for the title instead of the object.
2336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2337 Add implementation getDetailsData() along with some private helper
2339 * src/main/webapp/style.css: Add padding to details-data class. Add a
2340 details-label class with the same padding as the details-data class.
2342 2011-06-03 Ben Konrath <ben@bagu.org>
2344 Use presenter.goTo() to change to the DetailsPlace.
2346 This will make things easier when we need to open the DetailsView with
2347 data specific to the row that was clicked.
2349 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2351 2011-06-02 Ben Konrath <ben@bagu.org>
2353 Add CSS file from mockups.
2355 I'm adding this now because it's going to be useful to have when
2356 developing the DetailsView. The TableSelectionView and ListView aren't
2359 * src/main/webapp/OnlineGlom.html:
2360 * src/main/webapp/style.css:
2362 2011-06-02 Ben Konrath <ben@bagu.org>
2364 Use String.isEmpty() to check for empty string.
2366 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2368 2011-06-02 Ben Konrath <ben@bagu.org>
2370 Display main layout group titles in the DetailsView.
2372 This is the start of the DetailsActivity/DetailsView implementation.
2374 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2375 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2376 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2377 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2378 Get the layout information for the details view from the server and set
2379 the main layout group titles.
2380 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2381 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2382 Add addLayoutGroup() and addLayoutField() methods. This are just
2383 temporary methods for creating the the details view that will change
2385 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2386 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2388 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2389 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2390 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2391 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2392 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2393 Data Transfer Objects that mimic the libglom object structure. These are
2394 used for transferring the details layout but could also be used for
2395 transferring the list layout.
2397 2011-05-27 Ben Konrath <ben@bagu.org>
2399 Reset the AuthenticationPopup when clearing the ListView.
2401 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2403 2011-05-27 Ben Konrath <ben@bagu.org>
2405 Fix problem with onlineglom.properties file loading.
2407 The old way worked in Eclipse but not on the server. Loading the
2408 onlineglom.properties file now works in Eclipse and on the server.
2410 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2412 2011-05-24 Ben Konrath <ben@bagu.org>
2414 Update gwt-log from 3.1.0 to 3.1.2.
2416 Gwt-log 3.1.0 has been marked as depreciated.
2420 2011-05-24 Ben Konrath <ben@bagu.org>
2422 Add comment to ListActivity.goTo() method.
2424 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2426 2011-05-24 Ben Konrath <ben@bagu.org>
2428 Remove FIXME in convertGdkColorToHtmlColour()
2430 The Gdk::Color value returned by libglom is 16-bits per channel on both
2431 64 and 32-bit platforms.
2433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2435 2011-05-19 Ben Konrath <ben@bagu.org>
2437 Improve performance of initial ListView load.
2439 I removed a round trip to the server for getting the default table name
2440 and then requesting information about that table. This also removes a potential
2441 problem with the table change handler not being setup in time to receive the
2442 table change event from the ListActivity.
2444 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2445 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2446 getDefaultLayoutListTable() method. Improve comments.
2447 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2448 getDefaultLayoutListTable() method instead of firing a table change
2449 event to get the table to load.
2450 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2451 implementation of getDefaultLayoutListTable() method.
2452 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2455 2011-05-19 Ben Konrath <ben@bagu.org>
2457 Override toDebugString() in TableChangeEvent.
2459 This is useful to have for debugging.
2461 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2463 2011-05-19 Ben Konrath <ben@bagu.org>
2465 Add a "Back to List" link when at the DetailsPlace.
2467 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2468 Populate the CellTable based on the selected table of the ListBox if
2469 it's set otherwise use the default table. This allows the "Back to
2471 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2472 Remove Place from constructors. Add a setPlace() method. Add
2473 goToPlace() method. Set class as presenter for TableSelectionView.
2474 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2475 Use the same TableSelectionActivity when switching between the List and
2477 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2478 Subclass the new HasSelectableTablePlace. This removes some duplicate
2480 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2481 New class to represent Places that display the TableSelectionView.
2482 * src/main/java/org/glom/web/client/place/ListPlace.java:
2483 Subclass the new HasSelectableTablePlace. This removes some duplicate
2485 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2486 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2487 Add Presenter interface. Add setBackLinkVisible() method. Add
2488 setBackLink() method.
2490 2011-05-18 Ben Konrath <ben@bagu.org>
2492 Enable the "Details" buttons.
2494 Right now only an empty details view is displayed.
2496 * src/main/java/org/glom/web/client/ClientFactory.java:
2497 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2498 Add DetailsView to ClientFactory.
2499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2500 A basic activity for the details view.
2501 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2502 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2504 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2505 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2507 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2508 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2509 unnecessary super() in constructor.
2510 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2511 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2512 really shouldn't create a new TableSelectionActivity for both the ListPlace
2513 and the DetailsPlace so this should be considered a temporary solution.
2514 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2515 New file. Represents a URL for the details view.
2516 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2517 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2518 A basic details view interface and implementation.
2519 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2520 Enable the "Details" buttons.
2522 2011-05-12 Ben Konrath <ben@bagu.org>
2524 Use a LayoutPanel with multiple display areas for main layout.
2526 This is mostly a refactor in that there are no changes from the user
2527 point of view. These changes are required so that we can swap out the list view
2528 with the details view when the user clicks the "Details" button.
2530 * src/main/java/org/glom/web/client/ClientFactory.java:
2531 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2532 OnlineGlomView. Add TableSelectionView, ListView and
2533 AuthenticationPopup.
2534 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2535 for main layout. Add display regions for main activities. Add
2536 activity manager for for main activities.
2537 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2538 file from parts of the deleted OnlineGlomActivity.
2539 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2540 New file from parts of the deleted OnlineGlomActivity.
2541 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2542 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2543 New files for app wide table change event.
2544 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2545 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2546 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2547 Activity mappers for the main activities replace the deleted app-wide
2549 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2550 Fix a spelling error in he comment.
2551 * src/main/java/org/glom/web/client/ui/ListView.java:
2552 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2553 Renamed from LayoutListView and modified for MVP. This still not a
2554 proper dumb view as prescribed by the MVP pattern but it works for now.
2555 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2556 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2557 New widget stripped out of the deleted OnlineGlomView.
2558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2559 Remove hack that is fixed by this patch.
2561 2011-05-06 Ben Konrath <ben@bagu.org>
2563 Rename OnlineGlomPlace to ListPlace.
2565 The only change besides the rename is that url will now display #list
2566 instead of #Document.
2568 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2569 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2570 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2571 * src/main/java/org/glom/web/client/place/ListPlace.java:
2572 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2574 2011-05-06 Ben Konrath <ben@bagu.org>
2576 Use Presenter for app navigation.
2578 This is the proper way to deal with Place (URL) changes with the MVP
2581 * src/main/java/org/glom/web/client/ClientFactory.java:
2582 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2583 PlaceHistoryMapper and PlaceHistoryHandler.
2584 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2585 PlaceHistoryMapper and PlaceHistoryHandler.
2586 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2587 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2588 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2589 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2590 Add Presenter interface and setPresenter methods. Rename addHyperLink
2591 to addDocumentLink taking only the document title as a parameter.
2593 2011-04-14 Ben Konrath <ben@bagu.org>
2595 Prompt for db username/password if they haven't been set.
2597 This is implemented with a popup widget that is contained within the
2598 OnlineGlomView and managed by the OnlineGlomActivity.
2600 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2601 methods for checking and setting the database username and password.
2602 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2603 new methods for checking and setting the database username and
2605 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2606 Display authentication popup if the JDBC connection to the database
2607 has not been authenticated.
2608 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2610 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2611 for dealing with the authentication popup.
2612 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2613 Implement the methods for dealing with the authentication popup.
2614 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2615 try to executed queries if the database connection hasn't been
2616 authenticated. Implement methods for checking and setting the
2617 database username and password.
2619 2011-04-12 Ben Konrath <ben@bagu.org>
2621 Make log messages a little clearer.
2623 Add a dash betweeen the document title and the table name.
2625 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2627 2011-04-12 Ben Konrath <ben@bagu.org>
2629 Protect against NPEs when cleaning up database resources.
2631 While this isn't strictly necessary because the exception is caught,
2632 not protecting against the NPEs makes it harder to find the real error
2635 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2637 2011-04-12 Ben Konrath <ben@bagu.org>
2639 Move configuration of the servlet to the constructor.
2641 The servlet will be initialized even if the database authentication
2642 information is not set or correct. I still need to add the UI for prompting
2643 the user for the authentication information when it's required.
2645 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2646 javadocs for getDocumentTitles() method.
2647 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2648 Set error message when RPC fails.
2649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2650 glom files directory from the configuration file. Try to set the
2651 database authentication information for the specific document if it's
2652 set and works otherwise try to use the global authentication
2653 information set for the directory.
2654 * src/main/resources/onlineglom.properties: Moved from
2655 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2656 Added detailed comments for the new keys.
2658 2011-04-11 Ben Konrath <ben@bagu.org>
2660 Remove unnecessary @Override in DocumentSelectionViewImpl.
2662 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2664 2011-04-11 Ben Konrath <ben@bagu.org>
2666 Remove center alignment in DocumentSelectionView.
2668 The title element is still centred but the document titles and bottom
2669 sentence are both left-aligned.
2671 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2673 2011-04-11 Ben Konrath <ben@bagu.org>
2675 Change 'Demo' naming convention to 'Document'.
2677 This is just a rename refactor with no functional changes to the code.
2679 * src/main/java/org/glom/web/client/ClientFactory.java:
2680 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2681 * src/main/java/org/glom/web/client/OnlineGlom.java:
2682 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2683 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2684 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2685 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2686 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2687 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2688 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2689 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2690 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2693 2011-04-08 Ben Konrath <ben@bagu.org>
2695 Remove FIXME from safeLongToInt() method.
2697 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2702 2011-04-08 Ben Konrath <ben@bagu.org>
2704 Display an error if no glom documents are found in the specified directory.
2706 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2707 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2708 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2711 2011-04-08 Ben Konrath <ben@bagu.org>
2713 Add copyright header to one more file ... oops.
2715 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2717 2011-04-08 Ben Konrath <ben@bagu.org>
2719 Add copyright header to files without it.
2721 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2722 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2723 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2724 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2725 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2726 * src/main/java/org/glom/web/shared/GlomField.java:
2728 2011-04-08 Ben Konrath <ben@bagu.org>
2730 Add support for accessing multiple glom documents in the servlet.
2732 This completes the demo selection functionality.
2734 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2735 document title to methods.
2736 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2737 document title to methods.
2738 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2739 Set browser window title when the activity starts. Correct name of
2740 document title variable.
2741 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2742 Set browser window title when the activity starts. Set the table
2743 selector change handler after table selector has been set. Clear the
2744 OnlineGlomView when the activity has been stopped.
2745 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2746 document title as the place token. Use "#Document:" instead of
2747 "#OnlineGlomPlace:" in the URL.
2748 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2749 Change heading to "Online Glom"
2750 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2751 document title in RPC methods.
2752 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2753 setDocumentTitle() method. Add clear() method.
2754 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2755 setDocumentTitle() method. Implement clear() method which removes the
2756 change handler on the ListBox, clears the ListBox and clears the
2758 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2759 Implement methods with document title. Keep track for the configured
2760 glom documents and their corresponding JDBC configurations in a hash
2761 table. This information is retrieved using the document title as the
2762 key in the hash table.
2763 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2764 document title field as it's no longer needed.
2766 2011-04-08 Ben Konrath <ben@bagu.org>
2768 Update the Eclipse JDT configuration.
2770 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2771 methods. Automatically add the copyright header to new files.
2773 2011-04-05 Ben Konrath <ben@bagu.org>
2775 Add new page for demo selection.
2777 This patch adds all the components required to view and start an
2778 OnlineGlom demo by clicking on the desired hyperlink. The user is
2779 able to return to the demo selection page with the browser's back
2780 button. I still need to modify the servlet to work with multiple
2781 documents so all demo links will load the file defined in the
2782 OnlineGlom.properties.
2784 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2785 This is only useful during development so we don't need to save it.
2786 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2787 get a reference to the DemoSelectionView.
2788 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2789 method to get a reference to the DemoSelectionView.
2790 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2791 default view to DemoSelectionView.
2792 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2793 to get glom document titles for glom files in a hard-coded directory.
2794 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2795 method to get glom document titles for glom files in a hard-coded
2797 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2798 Presenter for DemoSelectionView.
2799 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2800 for DemoSelectionView.
2801 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2802 Update for DemoSelectionView.
2803 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2804 Basic 'Place' implementation for the DemoSelectionView.
2805 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2806 The interface for the DemoSelectionView.
2807 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2808 The implementation of the DemoSelectionView.
2809 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2810 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2812 implementation of method to get glom document titles for glom files
2813 in a hard-coded directory.
2814 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2815 on longer being used.
2816 * src/main/webapp/glom.png: Glom logo.
2818 2011-04-05 Ben Konrath <ben@bagu.org>
2820 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2822 This is the forth and final commit of a refactor that will allow
2823 OnlineGlom to be used with multiple documents.
2825 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2826 Move RPC code from OnlineGlomViewImpl to this class.
2827 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2829 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2830 RPC code to the presenter class (the P in MVP).
2832 2011-04-04 Ben Konrath <ben@bagu.org>
2834 Start moving the existing OnlineGlom code to MVP.
2836 This work is based on the GWT MVP framework that is documented here:
2838 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2840 This is the third commit of a refactor that will allow OnlineGlom to
2841 be used with multiple documents.
2843 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2844 Interface for client factory which is used to get instances of various
2845 classes throughout the app.
2846 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2847 Implementation of client factory.
2848 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2849 initialize the MVP framework.
2850 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2851 New file. Activity manager for the main container widget. This is the
2853 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2854 Maps place (URL) to its corresponding activity.
2855 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2856 New file. This is just a place holder for a generated file.
2857 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2858 New file. Represents the URL for the main Online Glom app.
2859 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2860 for changes in LayoutListViewImpl.
2861 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2862 interface for View. Move code to OnlineGlomViewImpl class.
2863 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2864 file. Implementation of OnlineGlomView.
2865 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2866 Place resources. Use ClientFactoryImpl by default.
2868 2011-04-04 Ben Konrath <ben@bagu.org>
2870 Move View classes to their own package.
2872 This is the second commit of a refactor that will allow OnlineGlom to
2873 be used with multiple documents.
2875 * src/main/java/org/glom/web/client/OnlineGlom.java:
2876 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2877 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2879 2011-04-02 Ben Konrath <ben@bagu.org>
2881 Move UI code from the main module to its own class.
2883 This is the first commit of a refactor that will allow OnlineGlom to be
2884 used with multiple documents.
2886 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2887 references to OnlineGlom to OnlineGlomView.
2888 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2889 OnlineGlomView and instantiate it here.
2890 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2891 represents the main OnlineGlomView with one document.
2893 2011-04-01 Ben Konrath <ben@bagu.org>
2895 Fix formatting of gwt.xml and add DTD.
2897 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2899 2011-03-30 Ben Konrath <ben@bagu.org>
2901 Propperly convert gdkColor string to html colour string.
2903 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2905 2011-03-28 Ben Konrath <ben@bagu.org>
2907 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2909 This implementation matches
2910 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2911 readable and is not tied to Swig.
2913 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2915 2011-03-28 Ben Konrath <ben@bagu.org>
2917 Use read-only checkboxes for boolean field types.
2919 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2920 in the CellTable based on the field type. It currently only
2921 distinguishes between boolean and text columns but I'll need to add
2922 support for more types.
2923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2924 column type in the ColumnInfo object. Add method to convert between the
2925 glom field type enum in ColumnInfo and the glom field type in libglom.
2926 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2928 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2929 getting and setting booleans.
2931 2011-03-25 Ben Konrath <ben@bagu.org>
2933 Don't get the Date twice from the ResultSet.
2935 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2937 2011-03-25 Ben Konrath <ben@bagu.org>
2939 Cleanup code in the servlet.
2941 * TODO: Remove item about row count. Add item about testing row count
2942 query with large number of rows.
2943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2944 spelling mistakes, change method parameter to be consistent with
2947 2011-03-25 Ben Konrath <ben@bagu.org>
2949 Add server side logging with the gwt-log library.
2951 * .gitignore: Ignore the log file we're now producing.
2952 * TODO: Add a couple TODO item for logging.
2953 * pom.xml: Add gwt-log and log4j as a dependency.
2954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2955 logging of errors, warnings and some important info.
2956 * src/main/resources/log4j.properties: New file to configure log4j.
2958 2011-03-24 Ben Konrath <ben@bagu.org>
2960 Add a disable button for the Details view.
2962 * src/main/java/org/glom/web/client/LayoutListView.java:
2964 2011-03-22 Ben Konrath <ben@bagu.org>
2966 Use a count query to get the number of rows for the list view pager.
2968 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2970 2011-03-22 Ben Konrath <ben@bagu.org>
2972 Add more TODO information about CellTable pager positioning.
2976 2011-03-19 Ben Konrath <ben@bagu.org>
2978 Add TODO item about CellTable pager positioning.
2982 2011-03-18 Ben Konrath <ben@bagu.org>
2984 Remove unneeded GlomFieldColumn class.
2986 This is just a small code cleanup.
2988 * src/main/java/org/glom/web/client/LayoutListView.java:
2990 2011-03-18 Ben Konrath <ben@bagu.org>
2992 Use cursor mode in the query that gets data for the list view.
2994 I still need to fix the potential memory problem when getting the row
2995 count for the list view.
2997 * TODO: Add note about testing memory usage with large data sets. Add
2998 item about fixing row counting with large data sets.
2999 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
3000 PostgreSQL JDBC driver into cursor mode when getting data for the
3003 2011-03-15 Ben Konrath <ben@bagu.org>
3005 Remove the GWT Container from the Eclipse build classpath.
3007 The GWT dependencies are set by Maven so this isn't needed.
3011 2011-03-15 Murray Cumming <murrayc@murrayc.com>
3013 Added some earlier mockups to git, but not to the tarball dist.
3015 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
3016 Openismus. These hopefully show how we might structure the HTML so that
3017 it can be styled easily with CSS. However, we probably need to adapt them
3018 for the CSS structure that GWT dictates for common widgets.
3020 2011-03-14 Ben Konrath <ben@bagu.org>
3022 Locate OnlineGlom.properties using the ServletContext.
3024 This is required to be able to locate the file in the deployed servlet.
3026 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3027 Configure the database and glom document in in a helper method so
3028 that the ServletContext can be used to locate OnlineGlom.properties.
3029 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
3030 src/main/webapp. This is the proper location for .properites files.
3032 2011-03-12 Ben Konrath <ben@bagu.org>
3034 Add note to README about why we're compiling down to obfuscated JavaScript.
3038 2011-03-11 Ben Konrath <ben@bagu.org>
3040 Use properties file to configure servlet.
3042 This allows people to change the glom file path, db username and db
3043 password without recompiling the code.
3045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3046 * src/main/webapp/OnlineGlom.properties:
3048 2011-03-11 Ben Konrath <ben@bagu.org>
3050 Use table fields in layout list view if the layout list is not defined.
3052 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3053 Manually create a LayoutFieldVector for the query builder using the
3054 table fields when a layout list is not defined in the glom file.
3056 2011-03-11 Ben Konrath <ben@bagu.org>
3058 Only show FIXME string for images when there's an image.
3060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
3061 in this change are some small code cleanups.
3063 2011-03-11 Ben Konrath <ben@bagu.org>
3065 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3069 2011-03-11 Ben Konrath <ben@bagu.org>
3071 Correctly set the index of the default table.
3073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3074 Correctly set the index of the default table. Add commented out example
3077 2011-03-10 Ben Konrath <ben@bagu.org>
3079 Add comment to pom.xml about the previous change.
3081 * pom.xml: Add comment about the deployment issue so that it's obvious
3082 why java-libglom is set to the provided scope.
3084 2011-03-10 Ben Konrath <ben@bagu.org>
3086 Change java-libglom dependency from compile to provided in pom.xml.
3088 Since java-libglom uses jni it can only be loaded once and therefore
3089 must be placed in $CATALINA_HOME/lib and not included in each war.
3090 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3091 More information about this issue can be found in the Tomcat 6 release
3092 notes in the "JNI Based Applications" section:
3094 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3096 * README: Remove note about this issue. Deployment info should really
3097 be on the wiki anyway so I'll add it right now.
3098 * pom.xml: Change java-libglom dependency from compile to provided so
3099 that it's copied in to the packaged war.
3101 2011-03-09 Ben Konrath <ben@bagu.org>
3103 Change to using a neutral locale for currency, date and time formatting.
3105 This solves the problem of currency values being represented without a
3106 space between the currency code and the number (e.g. "EUR5.89" is now
3107 represented as "EUR 5.89"). More work is required when we implement
3108 a locale preference setting.
3110 * TODO: Add note about currency formatting issues with different
3112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3113 to using the neutral ROOT locale.
3115 2011-03-09 Ben Konrath <ben@bagu.org>
3117 Add support for currency codes that are not ISO 4217 codes.
3119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3120 the currency code defined in the glom file when it's not 3 characters
3121 long or when Java doesn't recognize the string as an ISO 4217 code.
3123 2011-03-08 Ben Konrath <ben@bagu.org>
3125 Remove test classes, launch configurations and configuration.
3127 The test stuff was getting in the way when creating the war. To make
3128 the war file you can now do 'mvn clean package'. The packaged war file
3129 will be in the target directory.
3131 * .classpath: Remove unused classpathentry for tests and i18n.
3132 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3133 property. Don't run test or i18n goals when packaging the war.
3134 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3139 * OnlineGlomTest-dev.launch:
3140 * OnlineGlomTest-prod.launch:
3141 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3142 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3144 2011-03-07 Ben Konrath <ben@bagu.org>
3146 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3148 These fixes allow me to use 'mvn deploy' to create the war file.
3150 * .classpath: This generated config has been updated by Eclipse. This
3151 change was probably triggered by me updating from Eclipse 3.6.1 to
3153 * .gitignore: Add entry to ignore the directory
3154 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3155 * .project: The generated config has been updated by Eclipse. This
3156 change was probably triggered by me updating from Eclipse 3.6.1 to
3158 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3159 so that Eclipse doesn't complain
3160 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3161 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3162 'tests' directory to 'client' directory. This is the new
3163 gwt-maven-plugin convension.
3164 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3165 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3167 2011-03-07 Ben Konrath <ben@bagu.org>
3169 Add support for horizontal alignment in the LayoutList columns.
3171 * TODO: Remove item about horizontal alignment. Add item about
3172 improvements to ColumnInfo.
3173 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3174 alignment on the columns. Use ColumnInfo RPC object get the column
3175 title and horizontal alignment.
3176 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3177 LayoutListView creation with ColumnInfo RPC object.
3178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3179 a ColumnInfo object for every LayoutList columnn. Convert the
3180 FieldFormatting.HorizontalAlignment to the correct
3181 ColumnnInfo.HorizontatlAlignment with the new
3182 getColumnInfoHorizontalAlignment helper method.
3183 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3184 to encapsulate column information like alignment and title. This
3185 could be used to set the colour instead of on a per cell field basis.
3186 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3187 column title storage and retrieval with ColumnInfo.
3189 2011-03-04 Ben Konrath <ben@bagu.org>
3191 Add support for column sorting.
3193 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3194 AsynDataProvider to be an anonymous inner class. Use new
3195 getSortedTableData RPC method when column sort is requested. Set all
3196 columns sortable and add an AsyncHandler to activate sorting in the
3198 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3199 method getSortedTableData(). Cleanup other method signatures.
3200 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3201 new method getSortedTableData(). Cleanup other method signatures.
3202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3203 Implement getSortedTableData() and getTableData() methods by using a
3204 private helper method with the appropriate parameters filled in. Use
3205 user supplied sort clause when supplied, otherwise fall back to
3206 sorting by the primary key. Move destroy() method to be underneath
3207 constructor for readability. Cleanup comments.
3209 2011-03-03 Ben Konrath <ben@bagu.org>
3211 Add support for colour text and colour backgrounds to the layout list cells.
3213 Only the cell backgrounds are coloured which leaves a gap between the
3214 cells that isn't coloured. I need to figure out a way to set
3215 'style=background-colour:' on the whole column rather than just the
3218 * TODO: Add a note about colouring the background of the whole column.
3219 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3220 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3221 render the coloured text and backgrounds. Use GlomField[] for the row type.
3222 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3224 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3225 GlomField[] for the row type.
3226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3227 GlomField[] for the row type. Set the text, text colour and background
3228 colour in the GlomField objects as specified in the glom document. Add
3229 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3230 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3231 the glom field text, foreground colour and background colour.
3233 2011-03-02 Ben Konrath <ben@bagu.org>
3235 Don't display hidden tables in the combo box.