1 2011-12-22 Ben Konrath <ben@bagu.org>
3 Fix a crasher when refreshing the list view with the default table.
5 This crash will also happen when loading the list view with the default
6 table from a link or bookmark.
8 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
9 to the main document selection page when the document id hasn't been
11 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
12 the main document selection page when the document id hasn't been
14 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
15 values for the details place when the document id hasn't been set.
16 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
17 values for the list place when the document id hasn't been set.
19 2011-12-21 Ben Konrath <ben@bagu.org>
21 Protect against NPE when glom.document.locale is not in config.
23 This patch protects against an NPE when glom.document.locale is not in
24 the config file. This NPE will also happen if glom.document.locale is
27 The patch also updates the error message to display the class name when
28 the getMessage() returns null. This was happening when the NPE was
29 thrown and I had "Configuration Error: null". If an NPE is encountered
30 with this patch, "Configuration Error: NullPointerException " will be
33 This commit closes this bug:
35 https://bugzilla.gnome.org/show_bug.cgi?id=666669
37 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
39 2011-12-20 Murray Cumming <murrayc@murrayc.com>
41 Rename onlineglom.properties to onlineglom.properties.sample.
43 * src/main/resources/onlineglom.properties: Rename to:
44 * src/main/resources/onlineglom.properties.sample:
45 * src/main/resources/README: And add this file explaining that people
46 should rename it back when deploying.
48 2011-12-20 Murray Cumming <murrayc@murrayc.com>
50 Allow choosing the translation in the .properties file.
52 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
53 init(): Read a glom.document.locale value from the configuration file
54 and call Glom's TransatableItem::set_current_locale() method.
55 * src/main/resources/onlineglom.properties: Add a commented-out
56 example of this new setting.
58 It would be better to add &lang=de_DE to the URL, but the current
59 libglom API does not allow us to do this easily. I am working on that.
61 2011-12-19 Murray Cumming <murrayc@murrayc.com>
63 Avoid a crash in parsing of token parameters.
65 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
66 ava: getTokenParams(): Do not crash if a parameter has a key but no
67 value, and ignore parameters with neither.
69 2011-12-17 Murray Cumming <murrayc@murayc.com>
71 History token building/handling: Improve use of token parameters.
73 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
74 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
75 and buildParamsToken(HashMap), for use by derived classes.
76 Make the separator private because it is no longer be needed.
77 * src/main/java/org/glom/web/client/place/DetailsPlace.java
78 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
79 instead of manual string concatenation.
80 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
81 of hardcoded indices and awkward splitting code.
82 * src/main/java/org/glom/web/client/place/ListPlace.java
83 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
84 instead of manual string concatenation.
85 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
86 of hardcoded indices and awkward splitting code.
87 This should fix bug #666420
89 2011-12-16 Murray Cumming <murrayc@murrayc.com>
91 Fix a Navgiation->Navigation typo in the code.
93 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
94 Rename processNavgiation() to processNavigation().
96 2011-12-16 Murray Cumming <murrayc@murrayc.com>
98 Fix a seperator->separator typo in the code.
100 * src/main/java/org/glom/web/client/place/DetailsPlace.java
101 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
102 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
105 2011-12-15 Ben Konrath <ben@bagu.org>
107 Cleanup some comments.
109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
111 2011-12-14 Ben Konrath <ben@bagu.org>
113 Replace \n with <br/> for multiline text in the details view.
115 Vertical scrollbars are added when needed as well.
117 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
119 2011-12-14 Ben Konrath <ben@bagu.org>
121 Specify the font for document selection links.
123 * src/main/webapp/style.css:
125 2011-12-14 Ben Konrath <ben@bagu.org>
127 Fix bouncy CellTable while paging.
129 This doesn't currently work with related list tables in unselected
132 * src/main/java/org/glom/web/client/ui/list/ListTable.java
134 2011-12-14 Ben Konrath <ben@bagu.org>
136 Revamp the appearance of the document selection page.
138 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
139 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
140 * src/main/webapp/style.css:
142 2011-12-13 Ben Konrath <ben@bagu.org>
144 Set navigation button column to the smallest size possible.
146 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
148 2011-12-13 Ben Konrath <ben@bagu.org>
150 Change OpenButton nomenclature to NavigationButton.
152 Using NavigtionButton makes things more generic. Classes, methods and
153 variables have been changed.
155 This is a rename-only refactor.
157 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
158 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
159 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
160 Renamed from OpenButtonCell.
161 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
162 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
163 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
165 2011-12-12 Ben Konrath <ben@bagu.org>
167 Remove unnecessary String argument in RelatedListTable and ListViewTable.
169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
170 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
171 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
172 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
174 2011-12-12 Ben Konrath <ben@bagu.org>
176 Update variable names and comments.
178 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
179 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
181 2011-12-12 Ben Konrath <ben@bagu.org>
183 Properly initialize numNonEmptyRows variable to zero.
185 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
186 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
188 2011-12-05 Ben Konrath <ben@bagu.org>
190 Add latest mockup with HTML tables.
192 Features of this mockup:
194 -> HTML table for flowtable
195 -> HTML table for flowtable column
196 -> Example of how related lists would look
197 -> Not using text entries for data items
199 The current version of Online Glom doesn't use HTML tables for the
202 This mockup has been sent to the glom-devel mailing list but it's good
203 to have it here as well.
205 * mockups/details-view-html-tables.html:
207 2011-12-05 Ben Konrath <ben@bagu.org>
209 Remove unnecessary getPrimaryKeyField() method.
211 getPrimaryKeyFieldForTable(String) has been renamed to
212 getPrimaryKeyField(String).
214 * src/main/java/org/glom/web/server/database/DBAccess.java:
215 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
216 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
218 2011-12-05 Ben Konrath <ben@bagu.org>
220 Add string representation of TypedDataItem value to conversion error message.
222 * src/main/java/org/glom/web/server/Utils.java: Logging the error
223 message was extracted into its own method to avoid duplication.
225 2011-12-05 Ben Konrath <ben@bagu.org>
227 Add type checking to navigation primary key value creation.
229 Create navigation primary key only if the expected type from the Glom
230 document matches the type returned by the SQL query.
232 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
234 2011-12-05 Ben Konrath <ben@bagu.org>
236 Rename a couple of variables in RelatedListNavigation.
238 This is a rename-only refactor.
240 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
242 2011-12-05 Ben Konrath <ben@bagu.org>
244 Move getListLayoutGroup() into getListViewLayoutGroup().
246 This removes getListLayoutGroup(). It was only being called by
247 getListViewLayoutGroup().
249 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
251 2011-12-05 Ben Konrath <ben@bagu.org>
253 Remove check for LayoutItem_Portal in list table method.
255 This check is no longer necessary because the method isn't being used
256 to create the LayoutItemPortal DTO.
258 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
260 2011-12-05 Ben Konrath <ben@bagu.org>
262 Properly support related list navigation.
264 Navigation from the "Repository Analyzer -> Package Scans ->
265 Dependencies" related table wasn't working because the primary key for
266 related tables wasn't being set properly. This commit fixes the
269 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
270 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
271 doesn't set the primary key properly for related list tables.
272 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
273 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
274 useful for getting the primary key for list view tables and for related
276 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
277 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
278 Move code to set the primary key for the table from the abstract
279 ListDBAccess class to ListViewDBAccess as it's only correct for list
281 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
282 Properly add primary key to related list tables.
284 2011-12-02 Ben Konrath <ben@bagu.org>
286 Properly set the horizontal alignment of fields.
288 This fix is for both the list tables and the details view.
290 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
291 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
292 to set the horizontal alignment of fields.
294 2011-12-02 Ben Konrath <ben@bagu.org>
296 Display currency codes in the details view.
298 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
300 2011-12-02 Ben Konrath <ben@bagu.org>
302 Avoid duplicate JNI call.
304 JNI is not as efficient as pure Java and this is an easy (and small)
307 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
308 Use previously retrieved value for whereClauseToTableName instead of
311 2011-12-02 Ben Konrath <ben@bagu.org>
313 Rename a couple of variables in RelatedListNavigation.
315 This is a rename-only refactor.
317 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
319 2011-12-02 Ben Konrath <ben@bagu.org>
321 Indicate clearly that a mismatched primary key type is a bug.
323 * src/main/java/org/glom/web/server/Utils.java: Change log level from
324 warning to error. Add 'This is a bug.' to message.
326 2011-12-02 Ben Konrath <ben@bagu.org>
328 Update / fix some comments.
330 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
332 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
334 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
335 Fix comments. Add some TODOs.
337 2011-12-02 Ben Konrath <ben@bagu.org>
339 Enable navigation to details view with string primary key from related list.
341 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
342 Create a text primary key value when return type of result is
343 java.sql.Types.VARCHAR.
345 2011-12-02 Ben Konrath <ben@bagu.org>
347 Use checkboxes for booleans in the details view.
349 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
351 2011-12-01 Ben Konrath <ben@bagu.org>
353 Improve performance of related list height calculation.
355 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
356 Put code to calculate the expected height in a static initializer so
357 that that it's only called once.
359 2011-12-01 Ben Konrath <ben@bagu.org>
361 Show related list tables in notebooks (again).
363 Calculate the height of the related list tables so the Notebook can be
364 set the correct height. The height of the related list table is also needed by
365 FlowTable to be able decide how to create the layout.
367 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
368 and set the Portal height based on the height of the related list
369 table and the Portal container.
370 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
371 Add method to calculate the height of the related list tables.
372 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
373 * src/main/webapp/style.css: Add css class for Pager. This is needed to
374 calculate the height of the Pager widget.
376 2011-12-01 Ben Konrath <ben@bagu.org>
378 Use CellTable API for table property instead of setting style on Element.
380 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
382 2011-12-01 Ben Konrath <ben@bagu.org>
384 Make ListViewTable and RelatedListTable a consistent height.
386 The tables are now a consistent height regardless of the contents of
387 the table. A hidden button is added to empty rows to ensure that the
388 height of these rows will match the height of rows with data.
390 A navigation button column is now added to every table. The width of
391 the navigation column is set to 0px when a RelatedListTable shouldn't
392 have navigation buttons. This maintains the a consistent row height in
393 tables that don't show the navigation buttons.
395 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
396 navigation column when not needed.
397 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
398 arguments for navigation button to constructor of ListViewTable.
399 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
400 hidden button for empty data rows.
401 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
402 arguments for navigation button to constructor.
403 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
404 create navigation buttons. Add hideNavigationButtons() method.
405 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
406 arguments for navigation button to constructor.
408 2011-12-01 Ben Konrath <ben@bagu.org>
410 Use 'visibility: hidden' in Utils.getWidgetHeight().
412 This is better choice because hidden elements are invisible, don't
413 respond to events and are not part of the tab order. They will,
414 however, take up space which is required to be able to calculate the
415 height of the widget.
417 * src/main/java/org/glom/web/client/Utils.java:
419 2011-12-01 Ben Konrath <ben@bagu.org>
421 Use Utils.getWidgetHeight() in FlowTable.
423 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
425 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
427 2011-12-01 Ben Konrath <ben@bagu.org>
429 Put the details css class name on the correct table column.
431 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
433 2011-11-30 Ben Konrath <ben@bagu.org>
435 Update for java-libglom API change.
437 The getters and setters on FieldFormatting and NumericFormat were
438 changed to remove the 'M'.
440 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
442 2011-11-29 Ben Konrath <ben@bagu.org>
444 Only allow RelatedListTables in Portals.
446 * src/main/java/org/glom/web/client/ui/details/Portal.java:
448 2011-11-29 Ben Konrath <ben@bagu.org>
450 Only create a contents panel for Portals when title is being set.
452 * src/main/java/org/glom/web/client/ui/details/Portal.java:
454 2011-11-29 Ben Konrath <ben@bagu.org>
456 Set TabLayoutPanel height based on calculated height its widgets.
458 This is a potential fix for this bug:
460 https://bugzilla.gnome.org/show_bug.cgi?id=665133
462 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
464 2011-11-29 Ben Konrath <ben@bagu.org>
466 Align details field labels and data with the Open buttons.
468 * src/main/webapp/style.css:
470 2011-11-29 Ben Konrath <ben@bagu.org>
472 Remove unnecessary <div> in the Notebook widget.
474 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
475 method to get container FlowPanel (<div>).
476 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
477 initWidget() method directly on the TabLayoutPanel widget instead of
478 Group's container widget.
480 2011-11-29 Ben Konrath <ben@bagu.org>
482 Don't add group titles for Portals in Notebooks.
484 This reverts the previous patch and fixes a bug I introduced with
485 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
487 * src/main/java/org/glom/web/client/ui/details/Group.java:
488 * src/main/java/org/glom/web/client/ui/details/Portal.java:
490 2011-11-28 Ben Konrath <ben@bagu.org>
492 Remove unused boolean argument in Portal constructor.
496 * src/main/java/org/glom/web/client/ui/details/Group.java:
497 * src/main/java/org/glom/web/client/ui/details/Portal.java:
499 2011-11-28 Ben Konrath <ben@bagu.org>
501 Remove hack for glom 1.18 style glom files.
503 * src/main/java/org/glom/web/client/ui/details/Group.java:
504 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
505 * src/main/java/org/glom/web/client/ui/details/Portal.java:
507 2011-11-28 Ben Konrath <ben@bagu.org>
509 Use Gda Value version of primary key to log result too large error.
511 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
513 2011-11-28 Ben Konrath <ben@bagu.org>
515 Don't use TypedDataItem.getText() for Unknown types from the URL.
517 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
518 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
519 instead of getText().
520 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
521 String field and getUnknown() method.
523 2011-11-28 Ben Konrath <ben@bagu.org>
525 Log an error message when the java-libglom .so is not present.
527 The error message was being set in the exception but not logged.
529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
531 2011-11-28 Ben Konrath <ben@bagu.org>
533 Ignore LayoutItem_CalendarPortals.
535 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
536 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
538 2011-11-28 Ben Konrath <ben@bagu.org>
540 Extract method for creating the LayoutItemPortal DTO.
542 Just breaking the code up into smaller chunks.
544 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
546 2011-11-28 Ben Konrath <ben@bagu.org>
550 This should have been added with the refactor. Oops!
552 * src/main/java/org/glom/web/shared/TypedDataItem.java:
554 2011-11-28 Ben Konrath <ben@bagu.org>
556 Create primary key value from URL string using type from Glom document.
558 See this bug, comments 19 - 25:
560 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
562 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
563 create a TypeDataItem for the primary key here when loading from a
564 URL. Show the same string for the primary key value as was received
565 from the URL string (when loading from a URL).
566 * src/main/java/org/glom/web/server/Utils.java: Update method for
567 creating the Gda Value from the TypeDataItem to properly deal with
568 creating a Gda Value based on the Glom document type for the primary
569 key value string when loading from a URL.
570 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
571 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
572 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
573 Update for changed method name.
575 2011-11-27 Ben Konrath <ben@bagu.org>
577 Rename PrimaryKeyItem to TypedDataItem.
579 The name PrimaryKeyItem suggests what the class should be used for.
580 TypedDataItem is a neutral name that describes the class better.
582 This is a rename-only refactor.
584 * src/main/java/org/glom/web/client/OnlineGlomService.java:
585 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
586 * src/main/java/org/glom/web/client/Utils.java:
587 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
588 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
589 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
590 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
591 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
592 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
594 * src/main/java/org/glom/web/server/Utils.java:
595 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
596 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
597 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
598 * src/main/java/org/glom/web/shared/NavigationRecord.java:
600 2011-11-25 Ben Konrath <ben@bagu.org>
602 Improve Gda Value conversion from PrimaryKeyItem.
604 The value from the PrimaryKeyItem is only used if its type match the
605 type from the glom document.
607 * src/main/java/org/glom/web/server/Utils.java:
609 2011-11-25 Ben Konrath <ben@bagu.org>
611 Manually check if the java-liblgom .so is visible to the JVM.
613 It seems that Tomcat has problems when a static initializer throws an
614 exception. This check is done before the first method call into
615 java-libglom so that execution doesn't continue if the .so is not
618 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
620 2011-11-25 Ben Konrath <ben@bagu.org>
622 Improve browser configuration error messages.
626 https://bugzilla.gnome.org/show_bug.cgi?id=662792
628 * src/main/java/org/glom/web/client/OnlineGlomService.java:
629 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
630 getConfigurationErrorMessage() method.
631 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
632 Get and display a specific configuration error message when no Glom
634 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
635 Implement getConfigurationErrorMessage() method. Surround configuration
636 code in the init() method with a try/catch block. This allows the
637 errors to be caught while keeping the servlet available to retrieve the
638 configuration error message.
640 2011-11-25 Ben Konrath <ben@bagu.org>
642 Don't use Strings to hold primary key values.
644 The primary key values are now held in a new data object
645 (PrimaryKeyItem) that holds type information and the primary key value
646 using the correct type.
648 * src/main/java/org/glom/web/client/OnlineGlomService.java:
649 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
650 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
651 PrimaryKeyItem instead of String to hold the primary key value.
652 * src/main/java/org/glom/web/client/Utils.java: Remove
653 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
654 PrimaryKeyItem based on the GlomFieldType and the DataItem.
655 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
656 PrimaryKeyItem instead of String to hold the primary key value. Load
657 document selection page when the documentID has not been set correctly.
658 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
659 DetailsPlace -> URL and URL -> DetailsPlace conversion with
661 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
662 Return empty string for URL instead of "null".
663 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
664 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
665 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
666 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
667 PrimaryKeyItem instead of String to hold primary key values.
668 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
669 PrimaryKeyValue to a Gda Value.
670 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
671 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
672 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
673 Replace temporary database access code that uses the PrimaryKeyValue to
674 Gda Value conversion.
675 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
676 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
677 PrimaryKeyItem instead of String.
678 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
679 hold primary key values.
681 2011-11-24 Ben Konrath <ben@bagu.org>
683 Use newly added java-libglom API to create queries.
685 This isn't finished. I still need to stop using Strings for primary key
686 values in the client code.
688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
689 libglom to use fake connections so that retrieving the query string will
691 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
692 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
693 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
694 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
695 Use the newly added libglom sql methods and classes to create the
696 query. Add temporary hack to convert primary value strings to Gda
699 2011-11-23 Ben Konrath <ben@bagu.org>
701 Don't explicitly set the height of Portals.
703 See comments 6 - 10 of this bug for details:
705 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
707 * src/main/java/org/glom/web/client/ui/details/Portal.java:
709 2011-11-23 Ben Konrath <ben@bagu.org>
711 Use an HTML table instead of CSS for the FlowTable layout.
713 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
714 GWT's FlexTable to implement the FlowTable.
715 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
717 2011-11-18 Ben Konrath <ben@bagu.org>
719 Add boolean example to HTML table mockup.
721 * mockups/details-view-html-tables-text-entries.html:
723 2011-11-17 Ben Konrath <ben@bagu.org>
725 Ensure the pager buttons are always visible for related lists.
727 To accomplish this, I've turned off text wrapping in the list view and
728 related list tables for both the header and data text. The related list
729 table now has a fixed layout so the it doesn't overflow its container.
730 This is required to ensure that the cell text is clipped when it
731 overflows the cell and an ellipsis is added to the right side of the
732 cell when text is clipped.
734 A fixed table layout for the related list table in the details view
735 seems what we want for the details view anyway, so the side-effect is
738 The ellipsis will only be displayed in Firefox >= 7.
742 https://bugzilla.gnome.org/show_bug.cgi?id=662930
744 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
745 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
746 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
748 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
749 Set the 'table-layout: fixed' CSS property to the related list table.
750 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
751 'white-space: nowrap;' CSS property on both the list view and the
754 2011-11-16 Ben Konrath <ben@bagu.org>
756 Rework the fix for empty notebook tab labels.
758 Setting the empty group titles with its name caused problems for the
759 details layout. Instead of using libglom's
760 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
761 to the client when the title is empty. This allows the Notebook to use
762 the name when the title is empty without affecting anything else.
764 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
765 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
767 2011-11-16 Ben Konrath <ben@bagu.org>
769 Set group titles with name when title is empty.
771 This fixes a problem with an empty notebook tab label in the Lesson
772 Planner document. The forth tab in the notebook should be "Internet":
774 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
776 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
777 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
780 2011-11-16 Ben Konrath <ben@bagu.org>
782 Remove whitespace from the configured username properties.
784 This assumes that usernames won't have whitespace at the beginning
785 or end. But I think this is a reasonable assumption.
787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
788 String.trim() to remove the whitespace from the username properties.
790 2011-11-15 Ben Konrath <ben@bagu.org>
792 Add details view mockup with HTML tables and text entries.
794 This is from the attachment on this bug:
796 https://bugzilla.gnome.org/show_bug.cgi?id=663109
798 * mockups/details-view-html-tables-text-entries.html:
800 2011-11-15 Ben Konrath <ben@bagu.org>
802 Add space between the columns of the flow table.
806 https://bugzilla.gnome.org/show_bug.cgi?id=662918
808 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
809 space between columns in the flow table.
811 2011-11-15 Ben Konrath <ben@bagu.org>
813 Add backup files to the .gitignore.
815 * .gitignore: Ignore files that end with ~.
817 2011-11-09 Ben Konrath <ben@bagu.org>
819 Use latest release of gwt-log.
821 Gwt-log releases are now being submitted to the maven central
822 repository so manual installation of the jar is no longer required.
824 * pom.xml: Update version and groupId of gwt-log dependency.
826 2011-10-31 Ben Konrath <ben@bagu.org>
828 Don't use GWT numeric formatting to override the glom currency formatting.
830 Currencies are now displayed like they are in Glom. See this bug:
832 https://bugzilla.gnome.org/show_bug.cgi?id=646216
834 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
836 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
837 currency code to constructor and set it when the cell is rendered.
838 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
839 currency code to the constructor of the NumericCell.
841 2011-10-27 Ben Konrath <ben@bagu.org>
843 Require the latest release of java-libglom (1.17.4).
847 2011-10-26 Ben Konrath <ben@bagu.org>
849 Add style to Notebook that matches current theme.
851 It's not the best style in the world but it's better than the default.
853 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
854 padding at the bottom of the child widgets.
855 * src/main/webapp/style.css: Add style for the Notebook.
857 2011-10-26 Ben Konrath <ben@bagu.org>
859 Move servlet initialization code to overridden init method.
861 This is half of the solution to getting proper error messages
862 displayed when configuration errors occur. Here's the relevant bug:
864 https://bugzilla.gnome.org/show_bug.cgi?id=662792
866 The rest of the solution involves surrounding the init method with a
867 try/catch block and setting a global variable with the error /
868 exception. A new async method should be created to retrieve and display
869 the error message / exception.
871 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
872 code from constructor to init method adding exceptions as needed.
874 2011-10-26 Ben Konrath <ben@bagu.org>
876 Add script to monitor and restart tomcat if required.
878 * utils/check-and-recover-tomcat.py: New file.
880 2011-10-26 Ben Konrath <ben@bagu.org>
882 Display the correct number of data items in the pager.
886 https://bugzilla.gnome.org/show_bug.cgi?id=661441
888 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
889 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
890 The implementation is the same for both tables: Keep track of the
891 number of non-empty rows and fire and RowCountChangeEvent after the data has
893 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
894 custom Pager class that subclasses SimplePager to handle displaying
895 the correct number when empty rows have been added.
897 2011-10-26 Ben Konrath <ben@bagu.org>
899 Correct error in previous commit.
901 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
902 eventBus parameter from listView.setCellTable().
904 2011-10-26 Ben Konrath <ben@bagu.org>
906 Fix error in TODO comment.
908 * src/main/java/org/glom/web/client/activity/ListActivity.java:
910 2011-10-24 Ben Konrath <ben@bagu.org>
912 Create Notebook widgets to the details view.
914 This isn't finished just yet - I still need to create a reasonable
915 style to match the current theme.
917 * src/main/java/org/glom/web/client/Utils.java: Add method for
918 calculating the height of a widget. This is used in the Notebook class.
919 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
920 new constructor method in Group.
921 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
922 method for creating child widget that can be used by subclasses
923 like Notebook. New constructor that allows disabling the group
924 titles - Notebooks don't set a group title for their child groups.
925 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
926 to make Notebooks using GWT's TabLayoutPanel.
927 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
928 constructor that allows disabling the group titles.
929 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
930 LayoutItemNotebook DTO.
931 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
932 DTO for Notebooks. It's just an empty class for now but we might need
933 it to transfer some specific information in the future.
935 2011-10-21 Ben Konrath <ben@bagu.org>
937 Add navigation buttons to related list tables.
939 * src/main/java/org/glom/web/client/OnlineGlomService.java:
940 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
942 method getSuitableRecordToViewDetails() for getting the table name
943 and primary key value for related list navigation buttons.
944 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
945 private cell renderer class to get the navigation information for
946 related list tables from the server. Extract the navigation
947 processing code from the details cell navigation and use it for the
948 related list navigation as well.
949 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
950 cell renderer class for the details open buttons. This was needed
951 because the related list navigation buttons and the list view
952 navigation buttons need to react differently when clicked.
953 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
954 the onEnterKeyDown() method because it's now overriden in the
955 subclasses that are specific to the related list tables and the list
957 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
958 the vertical size a little because the buttons add a bit of vertical
959 space to table. This is not a perfect solution because the vertical
960 size of with table fewer than 5 rows will be a little smaller.
961 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
962 changes in how navigation buttons are handled.
963 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
964 getSuitableRecordToViewDetails() using the new RelatedListNavigation
965 database access object.
966 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
967 to find the portal for a given relationship name from
968 RelatedListDBAccess. Add method to find a primary key field for a
970 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
971 Move code to find the portal for a given relationship name to
973 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
974 New file: database access object for getting the related list
975 navigation information (the table name and the primary key value).
976 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
977 DTO for transferring a table name to navigate to and a primary key
979 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
980 boolean and getter/setter to specifies if the related list should add
983 2011-10-24 Murray Cumming <murrayc@murrayc.com>
985 Use the master branch of java-libglom
987 * pom.xml: Depend on java-libglom 1.19 instead.
989 This is the master branch. See also the libglom-1-18 branch.
991 2011-10-11 Ben Konrath <ben@bagu.org>
993 Enable the open navigation button when the data has been set.
995 This avoids having active buttons that don't do anything when the data
998 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1000 2011-10-11 Ben Konrath <ben@bagu.org>
1002 Use IsWidget interface for FlowTableItem.
1004 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1005 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1007 2011-10-11 Ben Konrath <ben@bagu.org>
1009 Remove GWT styling from open button in details view.
1011 There are still some issues with how the details cell is arranged but
1012 this should be made to match Glom 1.20. I'm going to leave fixing this
1013 until I have Glom 1.20 up and running.
1015 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1016 style name on open button.
1017 * src/main/webapp/style.css: Move and edit details-navigation class.
1018 Re-arrange some classes to make them appear in the same order as the
1021 2011-10-07 Ben Konrath <ben@bagu.org>
1023 Update to GWT 2.4.0.
1025 * .gitignore: Ignore new cache directory.
1026 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1027 * pom.xml: Change GWT and maven plugin to 2.4.0.
1028 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1030 * src/main/java/org/glom/web/client/ClientFactory.java:
1031 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1032 * src/main/java/org/glom/web/client/OnlineGlom.java:
1033 Update source for API changes.
1034 * utils/build-onlineglom-war.sh: Remove cache directory before the
1037 2011-10-07 Ben Konrath <ben@bagu.org>
1039 Add navigation buttons in the details view.
1041 This isn't finished but I thought I'd commit what I have as it's a
1042 pretty good start. I still need to:
1044 1. Change the style so that it fits better into the current theme
1045 2. Adjust the details cell to expand as much as possible.
1047 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1048 click handlers to navigation buttons in the DetailsCells. Create a
1049 refreshData() method to get just the data from the server without the
1051 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1052 Update the tableSelector and browser title when the table name
1053 changes without using the tableSelector.
1054 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1055 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1056 getDetailsCells() to getCells(). Update variable names.
1057 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1058 method to set click handler on navigation button. Rename a few
1059 variables. Add navigation buttons where needed.
1060 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1061 variables and methods.
1062 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1063 navigation boolean and navigation table as required in the
1064 LayoutItemField DTO.
1065 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1066 variables for navigation along with getter/setter methods.
1068 2011-10-07 Ben Konrath <ben@bagu.org>
1070 Rename Field to DetailsCell.
1072 This is a refactor-only commit. No functionality has been added or
1075 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1076 Update variable and method names.
1077 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1078 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1079 variable and method names.
1080 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1082 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1083 variable and method names.
1085 2011-10-07 Ben Konrath <ben@bagu.org>
1087 Create separate methods for layout and data the details view.
1089 This is a refactor-only commit. No functionality has been added or
1092 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1093 private methods: setData(), createLayout().
1095 2011-10-07 Ben Konrath <ben@bagu.org>
1097 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1099 This is part of a change to get navigation buttons in the details view
1100 but it should have been done this way from the start.
1102 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1103 for method name change in TableSelectionView.
1104 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1105 Create TableChangeEvent and set the browser title using the
1106 TableSelectionView API.
1107 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1108 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1109 Change getSelectedTable() to getSelectedTableName(). Add
1110 getSelectedTableTitle().
1112 2011-10-07 Ben Konrath <ben@bagu.org>
1114 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1116 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1118 2011-10-07 Ben Konrath <ben@bagu.org>
1120 Update TableChangeEvent to use newTableName naming convention.
1122 This makes the class more consistent with GWT naming conventions.
1124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1125 Update for method name change in TableChangeEvent.
1126 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1127 for method name change in TableChangeEvent.
1128 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1129 newTableName variable and getter method. Make toDebugString()
1132 2011-09-30 Ben Konrath <ben@bagu.org>
1134 Disable the pager in the list tables when the data row count is less than the minimum.
1136 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1137 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1139 2011-09-30 Ben Konrath <ben@bagu.org>
1141 Add empty rows to the end of related list and list view tables.
1143 I also extracted the cell rendering classes from the ListTable because
1144 the code was becoming a little crazy with all the anonymous inner
1145 classes. My plan is to use these cell rendering classes in the details
1146 view as well so this refactor will be needed for that change.
1148 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1149 set the row count in related list tables if the data has more rows
1150 than the minimum number of rows visible.
1151 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1152 row count in list view tables if the data has more rows than the
1153 minimum number of rows visible.
1154 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1155 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1157 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1158 for rendering TYPE_NUMERIC cells. The code was extracted from the
1160 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1161 class for rendering cells with buttons in list views. The code was
1162 extracted from the ListTable class.
1163 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1164 for rendering TYPE_TEXT cells. The code was extracted from the
1166 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1167 Add empty rows to the end of the data if required. Implement
1168 ListTable.getMinNumVisibleRows().
1169 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1170 cell renderer code to public classes. Return null in
1171 Column.getValue() for empty rows. Add new abstract method:
1172 getMinNumVisibleRows(). Move code to set the row count of the list view
1173 table to ListViewImpl.
1174 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1175 empty rows to the end of the data if required. Implement
1176 ListTable.getMinNumVisibleRows().
1179 2011-09-27 Ben Konrath <ben@bagu.org>
1181 Use GWT.log for client-side debugging statements.
1183 These are optimized out when deployed so I should have used this method
1184 in the first place. These statements will eventually be replaced with some sort
1185 of notification in the browser.
1187 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1188 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1189 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1190 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1191 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1193 2011-09-27 Ben Konrath <ben@bagu.org>
1195 Put tableselector on the right, back to list link on right.
1197 The idea is that the table selector is acting like a label for the
1198 currently displayed table so it should be placed below the document title. This
1199 puts the table title in a similar position to where it is in Glom.
1201 * mockups/details-contacts.html:
1202 * mockups/details-projects.html:
1203 * mockups/listview-contacts.html:
1204 * mockups/listview-projects.html:
1205 * mockups/style.css:
1206 Update mockups to match how the interfaces currently look.
1207 * src/main/webapp/style.css: Swap positions of backlink with the table
1208 selector. Add some space on the left side of the table selector to
1209 line things up with the document title.
1211 2011-09-27 Ben Konrath <ben@bagu.org>
1213 Add field colouring to details view.
1215 This change re-works how field colouring works. The colour formatting
1216 information is now set to the client with the layout information instead of
1217 with the data. This eliminates the need to send the same colour strings for
1218 data in list view column when colour information is set.
1220 In order to set an alternate colour for negative numeric values, the
1221 number is now sent to client and formatted with the GWT NumberFormat class.
1223 This change also fixes:
1225 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1227 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1228 internationalization framework which is needed for client side numeric
1230 * src/main/java/org/glom/web/client/Utils.java: New file for some
1231 client static utility methods.
1232 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1233 the DataItem object to the Field class. Use a utility method to
1234 create the foreignKeyValue string.
1235 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1236 alignment and text colours in the constructor. Add setData(DataItem)
1237 method. Remove setText(String) method.
1238 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1239 colour information to GlomTextCell. Create and use GlomNumberCell for
1240 rendering numbers. Use utility method to get the string for the
1241 primary key of the key provider. Re-work how the horizontal alignment
1243 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1244 formatting to layout information. Methods for converting the libglom
1245 formatting information were moved from DBAccess.
1246 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1247 numeric formatting (it's now done on the client side). Don't set text
1248 colours in DataItem. Move libglom formatting conversion methods to
1250 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1251 getters/setters for text colour information.
1252 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1253 for transferring the libglom NumericFormat information to the client.
1254 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1255 and getters/setters for: GlomNumericFormat, background colour and
1256 foreground colour strings.
1258 2011-09-26 Ben Konrath <ben@bagu.org>
1260 Simplify code that iterates through the LayoutGroup.
1262 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1264 2011-09-26 Ben Konrath <ben@bagu.org>
1266 Accept Eclipse formatting for OnlineGlomServiceAsync.
1268 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1270 2011-09-26 Ben Konrath <ben@bagu.org>
1272 Don't use the ListDBAccess classes to get the primary key layout information.
1274 This was causing a bug where the wrong index for the hidden primary key
1275 was being sent to the client.
1277 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1278 primary key while creating the LayoutGroup DTO. Create a
1279 LayoutItemField DTO for hidden primary keys. Don't use the
1280 RelatedListDBAccess because it was only used for getting the primary
1282 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1283 access modifier from public to protected for getPrimaryKeyField() and
1284 getPrimaryKeyLayoutItemField().
1285 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1286 abstract method getExpectedResultSize() because RelatedListDBAccess
1287 doesn't have enough info to implement it.
1288 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1289 Remove @Override for getExpectedResultSize().
1290 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1291 Remove method getExpectedResultSize().
1293 2011-09-23 Ben Konrath <ben@bagu.org>
1295 Log which layout (list or details) the ignored item is from.
1297 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1299 2011-09-23 Ben Konrath <ben@bagu.org>
1301 Remove annotations that turn off code formatting in DataItem.
1303 * src/main/java/org/glom/web/shared/DataItem.java:
1305 2011-09-23 Ben Konrath <ben@bagu.org>
1307 Rename GlomField to DataItem and update associated methods.
1309 This is a rename-only refactor. No functionality has been added or
1312 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1313 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1314 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1315 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1316 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1317 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1318 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1319 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1321 * src/main/java/org/glom/web/server/database/DBAccess.java:
1322 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1323 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1324 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1325 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1326 * src/main/java/org/glom/web/shared/DataItem.java:
1327 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1328 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1330 2011-09-23 Ben Konrath <ben@bagu.org>
1332 Rename GlomDocument to DocumentInfo and update associated methods.
1334 This is a rename-only refactor. No functionality has been added or
1337 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1338 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1339 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1340 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1341 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1342 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1343 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1345 2011-09-20 Ben Konrath <ben@bagu.org>
1347 Require java-libglom 1.17.3.
1349 This picks up the fix for the seg fault problem with the Scenes table
1350 in the Openismus Film Manager example.
1354 2011-09-20 Ben Konrath <ben@bagu.org>
1356 Change the way sort clause is added for primary key when no sort clause is requested.
1358 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1359 before the sort clause is created. When a sort clause is not requested, the
1360 sort clause is created by finding the primary key in the LayoutFieldVector
1363 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1365 2011-09-20 Ben Konrath <ben@bagu.org>
1367 Log error message if no documents are found in the configured directory.
1369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1370 Extract the glom file extension string to a private static final class
1371 variable (mostly as syntactic sugar). Accept a minor formatting change.
1372 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1373 the example glom.document.directory configuration property to make it
1374 more clear that it can any directory, not just the home directory.
1376 2011-09-18 Ben Konrath <ben@bagu.org>
1378 Add related lists to details view.
1380 The related list table has support for paging and sorting just like the
1381 table in the list view.
1383 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1384 SQL queries for the related list tables.
1385 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1386 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1388 Rename getList methods to getListView and add comments. Remove
1389 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1390 it being unused. Add methods: getDetailsLayoutAndData(),
1391 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1393 Create the layout and set the data for the fields in one async call
1394 instead of two. Create related lists where appropriate.
1395 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1396 for method name changes in OnlineGlomService.
1397 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1398 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1399 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1401 * src/main/java/org/glom/web/client/ui/ListView.java:
1402 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1403 tableName from setCellTable(). Create a ListViewTable instead of
1405 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1406 represent a data field in the details view.
1407 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1408 from addDetailsCell() to Field class. Keep track of the Fields and
1409 Portals in the details view.
1410 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1411 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1412 and add a method to get it. Add method to set the contents of the
1414 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1415 New class for related list tables. This class has the data provider
1416 for the related list table.
1417 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1418 abstract class which is the base class for the ListViewTable and the
1420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1421 New class for list view tables. This class has the data provider for
1422 the list view table.
1423 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1424 methods for related list tables. Add more information to the
1425 LayoutItemField and LayoutItemPortal DTOs.
1426 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1427 Remove debugging print statement.
1428 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1429 Remove debugging print statements. Add primary key field to SQL count
1431 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1432 Remove unnecessary LayoutFieldVector parameter from
1433 getResultSizeOfSQLQuery() method.
1434 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1435 New class for related list table database access.
1436 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1437 class that is a wrapper DTO for details view layout and data.
1438 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1439 new 'fromField' string to this DTO.
1440 * src/main/webapp/style.css: Remove bottom margin and override top
1443 2011-09-15 Ben Konrath <ben@bagu.org>
1445 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1447 This sets things up to make it easier to add the data retrieval for
1448 related lists (portals). No user noticeable changes were made with
1451 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1452 class has the code to retrieve the layouts and access the
1453 database using the new database helper classes.
1454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1455 Most of the functionality has been removed from this class. This
1456 class now represents the public interface for the client side
1457 code. It also deals with configuring the servlet and cleaning
1458 things up when the servlet is stopped.
1459 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1460 of static methods into this utility class.
1461 * src/main/java/org/glom/web/server/database/DBAccess.java:
1462 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1463 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1464 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1465 These classes have the database retrieval code. The class hierarchy
1466 has been setup to make it easy to reuse code for similar
1469 2011-09-06 Ben Konrath <ben@bagu.org>
1471 Create separate classes for list table code and the data provider.
1473 As part of this refactor, I also split up the code a bit to make it
1476 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1477 table code to two new classes (below).
1478 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1479 with code from ListViewImpl.
1480 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1481 New file with code from ListViewImpl.
1483 2011-09-06 Ben Konrath <ben@bagu.org>
1485 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1487 This fixes the LayoutItemPortal DTO to match the libglom layout object
1490 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1492 2011-09-01 Ben Konrath <ben@bagu.org>
1494 Set title of Portals in the Details View.
1496 * pom.xml: Bump required version of java-libglom to 1.17.1.
1497 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1498 widget creation to its own class. Add comments to constructor.
1499 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1500 The code is mostly from the Group class with the title now set.
1501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1502 title of Portal. Update some comments. Fix some code formatting.
1504 2011-09-01 Ben Konrath <ben@bagu.org>
1506 Remove TODO comment for the flow table column width.
1508 The flow table column width is working correctly and doesn't need to be
1509 changed. See this mailing list post for more info:
1511 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1513 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1515 2011-08-27 Ben Konrath <ben@bagu.org>
1517 Add document title (database name) to top of the browser page.
1519 I added the document title to the TableSelecitonView but that will
1520 change if / when we add a view that doesn't require table selection.
1522 * mockups/details-contacts.html:
1523 * mockups/details-projects.html:
1524 * mockups/listview-contacts.html:
1525 * mockups/listview-projects.html:
1526 * mockups/style.css: Add document title to mockups to keep things
1528 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1529 sizes to account for the document title.
1530 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1531 Set the document title when it has been retrieved from the server.
1532 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1533 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1534 and implement setDocumentTitle(String) method.
1535 * src/main/webapp/style.css: Add ID for document title style.
1537 2011-08-25 Ben Konrath <ben@bagu.org>
1539 Add NavigationType enum to LayoutItemPortal DTO.
1541 This is the start of adding support for Portals to the Details View.
1543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1544 LayoutItem_Portal.navigation_type enum from libglom to
1545 LayoutItemPortal.NavigationType enum.
1546 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1547 NavigationType enum, field for storing the NavigationType and getter
1550 2011-08-25 Ben Konrath <ben@bagu.org>
1552 Implement the flow table layout in the Details View.
1554 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1555 FlowTable to Group to account for the renamed class.
1556 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1557 File. This is a container widget that implements the Glom details view
1558 flow table behaviour.
1559 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1560 org/glom/web/client/ui/FlowTable.java.
1561 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1562 so that the size of the subgroups are a closer match to the size of
1563 the Glom subgroups. This makes the flowtable layout match the layout
1564 in Glom for the Music Collection example file.
1566 2011-08-16 Ben Konrath <ben@bagu.org>
1568 Create container element for LayoutItemPortal in Details View.
1570 This will help me develop the layout for the FlowTable.
1572 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1573 fieldPanel variable to detailsCell.
1575 2011-08-15 Ben Konrath <ben@bagu.org>
1577 Set the height of the data element in the Details View.
1579 I changed the InlineLabels (text in a span element) to Labels (text in
1580 a div element) so that I could set the height of the details-data
1581 elements instead of the details-cell parent elements. This allows the
1582 the details-data element to display the correct height if style is
1583 applied that shows the height.
1585 This change has the added benefit of allowing the order of the labels
1586 and data elements to be changed for right-to-left languages.
1588 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1589 InlineLabels to Labels.
1590 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1591 InlineLabels to Labels. Set the height of the data element.
1592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1593 multiline text height in the Formatting DTO.
1594 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1595 for multiline height along with getter and setter methods.
1596 * src/main/webapp/style.css: Adjust style to account for the change
1597 from span elements to div elements in the details cell.
1599 2011-08-15 Ben Konrath <ben@bagu.org>
1601 Make the List View appearance match the mockups.
1603 It doesn't match exactly but it's much better than it was.
1605 * mockups/listview-contacts.html: Remove unused css classes.
1606 * mockups/listview-projects.html: Remove unused css classes.
1607 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1608 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1609 for mainPanel instead of VerticalPanel (table). Set style name on
1610 CellTable. Set style name on Details column. Right-align Details
1612 * src/main/webapp/style.css: Adjust properties to match the mockups.
1614 2011-08-12 Ben Konrath <ben@bagu.org>
1616 Add better support for subgroups in the details view.
1618 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1619 changed FlowTable constructor.
1620 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1621 support for subgroups and subgroup-titles.
1622 * src/main/webapp/style.css: Add CSS class for subgroups and
1625 2011-08-12 Ben Konrath <ben@bagu.org>
1627 Return the top level LayoutGroup title.
1629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1631 2011-08-11 Ben Konrath <ben@bagu.org>
1633 Make the TableSelector header match the mockup.
1635 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1636 the layout panel. Properly lineup the table selection header with
1637 the list and details view.
1638 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1639 margin around the details view.
1640 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1641 Rename listBox variable to tableSelector. Set id for the style sheet.
1642 Use a FlowPanel instead of a HorizontalPanel.
1643 * src/main/webapp/style.css: Add properties to make the TableSelector
1644 box match the mockups.
1646 2011-07-13 Ben Konrath <ben@bagu.org>
1648 Update install script for java-libglom version change.
1650 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1653 2011-07-13 Ben Konrath <ben@bagu.org>
1655 Add support sub-group in the details view.
1657 I also removed the code that special-cased the default details view
1660 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1662 I still have to make a proper flowtable.
1664 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1665 Don't special-case default details view layout.
1666 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1667 addLayoutField() as I'm going to use it.
1668 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1669 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1671 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1672 extracted from DetailsViewImpl.GroupPanel. Add support for
1674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1675 column count when getting the details layout.
1677 2011-07-12 Ben Konrath <ben@bagu.org>
1679 Set browser title with database and table titles.
1681 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1682 Set the browser title when the table changes and when the activity
1684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1685 title when retrieving document info (the GlomDocument object).
1686 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1687 with getter and setter methods. Remove unused convenience constructor.
1688 Use default code formatting.
1690 2011-07-12 Ben Konrath <ben@bagu.org>
1692 Ignore LayoutItemPortals in the details view.
1694 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1697 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1698 LayoutItemPortal layout objects.
1699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1700 LayoutItemPortal objects when retrieving the details layout.
1701 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1702 file. This is an empty class and just used to get type information for
1705 2011-07-12 Ben Konrath <ben@bagu.org>
1707 Use java-libglom 1.17.0.
1711 2011-07-11 Ben Konrath <ben@bagu.org>
1713 Remove "Table:" label from table selector.
1715 This matches a recent change in the Glom UI.
1717 * mockups/details-contacts.html:
1718 * mockups/details-projects.html:
1719 * mockups/listview-contacts.html:
1720 * mockups/listview-projects.html: Remove the "Table:" label from the
1722 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1724 2011-07-11 Ben Konrath <ben@bagu.org>
1726 Add main groups to the details view.
1728 This makes things look a little nicer in the details view. The next step
1729 is to implement the flowtable.
1731 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1732 resources from the standard gwt css theme. Standard.css is now
1733 included in OnlineGlom.html so that the online glom css rules have
1734 precedence over the gwt theme.
1735 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1736 the whole LayoutGroup to the DetailsView instead of just the titles.
1737 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1738 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1739 details layout with a helper class (GroupPanel). I might extract this
1740 class when I make the full flowtable.
1741 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1742 string as default so I don't have to worry about NPEs when processing
1744 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1745 note beside OnlineGlom.gwt.xml above).
1746 * src/main/webapp/style.css: Add default font-size to body to override
1747 the font-size set by the standard theme. Don't use h2 tags for
1748 group-title. Create new details-cell class.
1750 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1752 ConfiguredDocument: Set the port number too.
1754 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1755 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1756 Glom document. Presumably this worked sometimes so far because there is a
1757 default port number.
1759 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1761 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1763 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1764 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1765 correct, though we should throw an exception too.
1767 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1769 Fix a addDocuemnt typo.
1771 * src/main/java/org/glom/web/shared/Documents.java
1772 (Documents.addDocuemnt): Rename to addDocument().
1773 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1774 (OnlineGlomServiceImpl.getDocuments): Adapt.
1776 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1778 Slightly improved log output when connection fails.
1780 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1781 (ConfiguredDocument.setUsernameAndPassword):
1782 We don't know for sure if it' the username/password that's wrong, so
1783 rephrase the message.
1784 Also ouput the exception message, though it's generic in this case.
1786 2011-07-08 Ben Konrath <ben@bagu.org>
1790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1791 added braces to a one line if statement because the Eclipse formatter
1792 was getting confused.
1794 2011-07-07 Ben Konrath <ben@bagu.org>
1796 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1798 These should really be two separate tasks but I counldn't get things to
1799 work with GWT 2.2.0 and Eclipse 3.7.
1803 * .settings/org.eclipse.jdt.core.prefs:
1804 * .settings/org.eclipse.jdt.ui.prefs:
1805 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1806 * .settings/org.eclipse.m2e.core.prefs:
1807 Add new config files. Update current files. Remove references to the
1808 webtools plugins as we're not using any of the webtools features.
1809 * .gitignore: Add logs directory which is created when running with
1811 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1812 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1813 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1815 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1817 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1819 onlineglom.properties: Add explanatory comments.
1821 * src/main/resources/onlineglom.properties: Also change the default user
1822 from ben to someuser, to avoid the risk of people thinking we just
1823 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1825 2011-06-28 Ben Konrath <ben@bagu.org>
1827 Use filename in Log for incorrect passwords.
1829 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1830 getFileName(String) method to get the filename from the URI.
1832 2011-06-28 Ben Konrath <ben@bagu.org>
1834 Add the table name to the URL token for the ListPlace.
1836 This makes things consistent between the DetailsPlace and the
1837 ListPlace. It also allows the the ListPlace to be bookmarked.
1839 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1840 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1842 Remove getDefaultListLayout(). The default layout is now returned
1843 by the getListLayout() method when the table name is an empty string.
1844 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1845 Add table name field. Change to a new ListPlace when the table
1846 has been changed. Use getListLayout() for getting the default
1848 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1849 Add table name field. Set the correct table name in the list box
1850 when loading from bookmark. This corrects a problem for the
1852 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1853 Move table name to super-class (HasSelectableTable). Move document
1854 and table URL keys to super-class in HasSelectableTable.
1855 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1856 Add table name field. Add Tokenizer class with URL key common to
1857 the subclasses (DetailsPlace and ListPlace).
1858 * src/main/java/org/glom/web/client/place/ListPlace.java:
1859 Add table name. Add code to parse the URL token.
1860 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1861 Update ListPlace construction with empty table name string.
1862 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1863 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1864 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1865 Update ListPlace construction with table name string.
1866 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1867 Change defaultTableName field to tableName to reflect how it's now
1868 used. Update the getter and setter methods.
1870 2011-06-28 Ben Konrath <ben@bagu.org>
1872 Enable the table selector in the DetailsView.
1874 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1875 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1876 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1877 Remove getDefaultDetailsLayout(). The default layout is now returned
1878 by the getDetailsLayout() method when the table name is an empty
1880 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1881 event handler for table change event. Change to using
1882 getDetailsLayout() for the default details layout.
1883 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1885 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1886 when navigating to the details place.
1888 2011-06-27 Ben Konrath <ben@bagu.org>
1890 Use filename based unique document ID in URL and for RPC.
1892 The document ID is the glom document name with spaces (' ') replaced
1893 with pluses ('+') and without the .glom extension.
1895 This change is mostly a string substitution of 'documentTitle' for
1896 'documentID'. The only code change is the addition of a Documents DTO to get the
1897 filename to document title mappings as indicated below.
1899 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1900 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1902 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1903 Use Documents DTO to create the document links in the document
1905 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1906 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1907 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1908 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1909 * src/main/java/org/glom/web/client/place/ListPlace.java:
1910 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1911 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1912 * src/main/java/org/glom/web/client/ui/ListView.java:
1913 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1914 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1915 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1916 * src/main/java/org/glom/web/server/Log.java:
1917 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
1918 getDocumentTitles() to getDocuments() and return the Documents DTO.
1919 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
1920 transferring the filename to document title mappings.
1922 2011-06-25 Ben Konrath <ben@bagu.org>
1924 Make the authentication popup work again.
1926 This bug was introduced when I extracted ConfiguredDocument to its own class.
1928 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
1929 correct success / fail status in setUsernameAndPassword().
1931 2011-06-25 Ben Konrath <ben@bagu.org>
1933 Use filename as unique key for configuring database usernames and passwords.
1935 This replaces the use of the Glom document title which could change
1936 depending on the locale. Thanks to Murray Cumming for pointing out this
1939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1940 * src/main/resources/onlineglom.properties:
1942 2011-06-24 Ben Konrath <ben@bagu.org>
1944 Pass primary key value to DetailsView.
1946 This enables the DetailsView to load the correct data.
1948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1949 primary key value field and set in constructor. Pass primary key
1950 value to getDetailsData().
1951 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
1952 variables for document title and primary key value.
1953 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
1954 key value to the DetailsPlace.
1956 2011-06-24 Ben Konrath <ben@bagu.org>
1958 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
1960 This allows the primary key to be retrieved by the Details button. This
1961 functionality has not been implemented yet but it's in the works.
1963 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
1964 the LayoutGroup result to ListView.setCellTable instead of all of its
1965 fields individually.
1966 * src/main/java/org/glom/web/client/ui/ListView.java:
1967 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
1968 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
1969 get the primary key for the table.
1970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1971 index of the primary key in the LayoutGroup accounting for hidden
1972 primary keys. Rename getJavaNumberFormat() to
1973 convertToJavaNumberFormat() for consistency. Cleanup / add some
1975 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
1976 field for primary key index and a field to indicate whether the
1977 primary key is hidden or not.
1979 2011-06-23 Ben Konrath <ben@bagu.org>
1981 Rename getTableData methods to getListData.
1983 This is a rename refactor for consistency with other methods.
1985 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1986 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1987 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1990 2011-06-23 Ben Konrath <ben@bagu.org>
1992 Extract the ConfiguredDocument innerclass into its own class.
1994 This makes the servlet code more object oriented.
1996 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
1997 from private ConfiguredDocument class in OnlineGlomServiceImpl.
1998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
1999 new ConfiguredDocument class.
2001 2011-06-21 Ben Konrath <ben@bagu.org>
2003 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2005 This makes things more inline with how libglom works and reduces code
2006 duplication. This refactor lays the groundwork for adding the primary key to
2007 the LayoutGroup object.
2009 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2010 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2012 Change method names to getListLayout and getDefaultListLayout for
2013 consistency. Use LayoutGroup as the DTO for the list layout instead of
2014 ColumnInfo and LayoutListTable.
2015 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2016 new method names along with the LayoutGroup object for transferring the
2018 * src/main/java/org/glom/web/client/ui/ListView.java:
2019 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2020 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2021 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2023 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2024 Replaced with LayoutGroup.
2025 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2026 expectedResultSize and defaultTableName fields which are needed for
2028 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2029 type field which is needed for the list layout but will also be
2030 useful for the details layout as things progress.
2031 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2032 Make class abstract. Remove the unnecessary
2033 getFormattingHorizontalAlignment method. Add setFormatting method.
2035 2011-06-16 Ben Konrath <ben@bagu.org>
2037 Add scripts for building and installing war.
2039 These will help when updating OnlineGlom but they're also good
2040 supplemental documentation of the build and deployment proceeding.
2042 * utils/build-onlineglom-war.sh: New file.
2043 * utils/install-onlineglom-war.sh: New file.
2045 2011-06-16 Ben Konrath <ben@bagu.org>
2047 Create wrapper class to create consistent log messages.
2049 I wrapped methods in the Log class of gwt-log to add the method names
2050 from the servlet and create consistent formatting of the document title
2051 and table names in the log messages.
2053 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2055 log methods to use methods from wrapped Log class.
2057 2011-06-16 Ben Konrath <ben@bagu.org>
2059 Remove superfluous conditional return.
2061 Thanks to Murray Cumming for pointing this out!
2063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2065 2011-06-15 Ben Konrath <ben@bagu.org>
2067 Return an ArrayList of LayoutGroups for the Details layout.
2069 This corrects a problem with the details layout as it can have more
2070 than one top level LayoutGroup.
2072 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2073 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2074 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2075 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2076 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2077 with ArrayList of LayoutGroups for the details view layout.
2078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2079 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2080 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2081 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2082 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2083 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2085 2011-06-14 Ben Konrath <ben@bagu.org>
2087 Use cast_dynamic method to determine the libglom LayoutItem type.
2089 This is better than finding the LayoutItem type by using the string
2090 returned from the get_part_type_name() method.
2092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2094 2011-06-14 Ben Konrath <ben@bagu.org>
2096 Add method names to log entries in the servlet.
2098 This helps when tracking down deployment problems.
2100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2102 2011-06-14 Ben Konrath <ben@bagu.org>
2104 Add data to the DetailsView using a hard-coded primary key value.
2106 The layout and functionality of the DetailsView is not complete. This
2107 is just a checkpoint so the patch doesn't get too big.
2109 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2110 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2111 Add getDetailsData() servlet method.
2112 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2113 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2114 LayoutFields are added to the DetailsView.
2115 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2116 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2117 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2118 take the string for the title instead of the object.
2119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2120 Add implementation getDetailsData() along with some private helper
2122 * src/main/webapp/style.css: Add padding to details-data class. Add a
2123 details-label class with the same padding as the details-data class.
2125 2011-06-03 Ben Konrath <ben@bagu.org>
2127 Use presenter.goTo() to change to the DetailsPlace.
2129 This will make things easier when we need to open the DetailsView with
2130 data specific to the row that was clicked.
2132 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2134 2011-06-02 Ben Konrath <ben@bagu.org>
2136 Add CSS file from mockups.
2138 I'm adding this now because it's going to be useful to have when
2139 developing the DetailsView. The TableSelectionView and ListView aren't
2142 * src/main/webapp/OnlineGlom.html:
2143 * src/main/webapp/style.css:
2145 2011-06-02 Ben Konrath <ben@bagu.org>
2147 Use String.isEmpty() to check for empty string.
2149 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2151 2011-06-02 Ben Konrath <ben@bagu.org>
2153 Display main layout group titles in the DetailsView.
2155 This is the start of the DetailsActivity/DetailsView implementation.
2157 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2158 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2159 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2160 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2161 Get the layout information for the details view from the server and set
2162 the main layout group titles.
2163 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2164 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2165 Add addLayoutGroup() and addLayoutField() methods. This are just
2166 temporary methods for creating the the details view that will change
2168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2169 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2171 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2172 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2173 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2174 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2175 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2176 Data Transfer Objects that mimic the libglom object structure. These are
2177 used for transferring the details layout but could also be used for
2178 transferring the list layout.
2180 2011-05-27 Ben Konrath <ben@bagu.org>
2182 Reset the AuthenticationPopup when clearing the ListView.
2184 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2186 2011-05-27 Ben Konrath <ben@bagu.org>
2188 Fix problem with onlineglom.properties file loading.
2190 The old way worked in Eclipse but not on the server. Loading the
2191 onlineglom.properties file now works in Eclipse and on the server.
2193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2195 2011-05-24 Ben Konrath <ben@bagu.org>
2197 Update gwt-log from 3.1.0 to 3.1.2.
2199 Gwt-log 3.1.0 has been marked as depreciated.
2203 2011-05-24 Ben Konrath <ben@bagu.org>
2205 Add comment to ListActivity.goTo() method.
2207 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2209 2011-05-24 Ben Konrath <ben@bagu.org>
2211 Remove FIXME in convertGdkColorToHtmlColour()
2213 The Gdk::Color value returned by libglom is 16-bits per channel on both
2214 64 and 32-bit platforms.
2216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2218 2011-05-19 Ben Konrath <ben@bagu.org>
2220 Improve performance of initial ListView load.
2222 I removed a round trip to the server for getting the default table name
2223 and then requesting information about that table. This also removes a potential
2224 problem with the table change handler not being setup in time to receive the
2225 table change event from the ListActivity.
2227 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2228 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2229 getDefaultLayoutListTable() method. Improve comments.
2230 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2231 getDefaultLayoutListTable() method instead of firing a table change
2232 event to get the table to load.
2233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2234 implementation of getDefaultLayoutListTable() method.
2235 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2238 2011-05-19 Ben Konrath <ben@bagu.org>
2240 Override toDebugString() in TableChangeEvent.
2242 This is useful to have for debugging.
2244 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2246 2011-05-19 Ben Konrath <ben@bagu.org>
2248 Add a "Back to List" link when at the DetailsPlace.
2250 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2251 Populate the CellTable based on the selected table of the ListBox if
2252 it's set otherwise use the default table. This allows the "Back to
2254 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2255 Remove Place from constructors. Add a setPlace() method. Add
2256 goToPlace() method. Set class as presenter for TableSelectionView.
2257 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2258 Use the same TableSelectionActivity when switching between the List and
2260 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2261 Subclass the new HasSelectableTablePlace. This removes some duplicate
2263 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2264 New class to represent Places that display the TableSelectionView.
2265 * src/main/java/org/glom/web/client/place/ListPlace.java:
2266 Subclass the new HasSelectableTablePlace. This removes some duplicate
2268 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2269 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2270 Add Presenter interface. Add setBackLinkVisible() method. Add
2271 setBackLink() method.
2273 2011-05-18 Ben Konrath <ben@bagu.org>
2275 Enable the "Details" buttons.
2277 Right now only an empty details view is displayed.
2279 * src/main/java/org/glom/web/client/ClientFactory.java:
2280 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2281 Add DetailsView to ClientFactory.
2282 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2283 A basic activity for the details view.
2284 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2285 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2287 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2288 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2290 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2291 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2292 unnecessary super() in constructor.
2293 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2294 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2295 really shouldn't create a new TableSelectionActivity for both the ListPlace
2296 and the DetailsPlace so this should be considered a temporary solution.
2297 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2298 New file. Represents a URL for the details view.
2299 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2300 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2301 A basic details view interface and implementation.
2302 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2303 Enable the "Details" buttons.
2305 2011-05-12 Ben Konrath <ben@bagu.org>
2307 Use a LayoutPanel with multiple display areas for main layout.
2309 This is mostly a refactor in that there are no changes from the user
2310 point of view. These changes are required so that we can swap out the list view
2311 with the details view when the user clicks the "Details" button.
2313 * src/main/java/org/glom/web/client/ClientFactory.java:
2314 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2315 OnlineGlomView. Add TableSelectionView, ListView and
2316 AuthenticationPopup.
2317 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2318 for main layout. Add display regions for main activities. Add
2319 activity manager for for main activities.
2320 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2321 file from parts of the deleted OnlineGlomActivity.
2322 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2323 New file from parts of the deleted OnlineGlomActivity.
2324 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2325 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2326 New files for app wide table change event.
2327 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2328 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2329 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2330 Activity mappers for the main activities replace the deleted app-wide
2332 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2333 Fix a spelling error in he comment.
2334 * src/main/java/org/glom/web/client/ui/ListView.java:
2335 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2336 Renamed from LayoutListView and modified for MVP. This still not a
2337 proper dumb view as prescribed by the MVP pattern but it works for now.
2338 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2339 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2340 New widget stripped out of the deleted OnlineGlomView.
2341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2342 Remove hack that is fixed by this patch.
2344 2011-05-06 Ben Konrath <ben@bagu.org>
2346 Rename OnlineGlomPlace to ListPlace.
2348 The only change besides the rename is that url will now display #list
2349 instead of #Document.
2351 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2352 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2353 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2354 * src/main/java/org/glom/web/client/place/ListPlace.java:
2355 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2357 2011-05-06 Ben Konrath <ben@bagu.org>
2359 Use Presenter for app navigation.
2361 This is the proper way to deal with Place (URL) changes with the MVP
2364 * src/main/java/org/glom/web/client/ClientFactory.java:
2365 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2366 PlaceHistoryMapper and PlaceHistoryHandler.
2367 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2368 PlaceHistoryMapper and PlaceHistoryHandler.
2369 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2370 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2371 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2372 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2373 Add Presenter interface and setPresenter methods. Rename addHyperLink
2374 to addDocumentLink taking only the document title as a parameter.
2376 2011-04-14 Ben Konrath <ben@bagu.org>
2378 Prompt for db username/password if they haven't been set.
2380 This is implemented with a popup widget that is contained within the
2381 OnlineGlomView and managed by the OnlineGlomActivity.
2383 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2384 methods for checking and setting the database username and password.
2385 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2386 new methods for checking and setting the database username and
2388 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2389 Display authentication popup if the JDBC connection to the database
2390 has not been authenticated.
2391 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2393 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2394 for dealing with the authentication popup.
2395 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2396 Implement the methods for dealing with the authentication popup.
2397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2398 try to executed queries if the database connection hasn't been
2399 authenticated. Implement methods for checking and setting the
2400 database username and password.
2402 2011-04-12 Ben Konrath <ben@bagu.org>
2404 Make log messages a little clearer.
2406 Add a dash betweeen the document title and the table name.
2408 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2410 2011-04-12 Ben Konrath <ben@bagu.org>
2412 Protect against NPEs when cleaning up database resources.
2414 While this isn't strictly necessary because the exception is caught,
2415 not protecting against the NPEs makes it harder to find the real error
2418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2420 2011-04-12 Ben Konrath <ben@bagu.org>
2422 Move configuration of the servlet to the constructor.
2424 The servlet will be initialized even if the database authentication
2425 information is not set or correct. I still need to add the UI for prompting
2426 the user for the authentication information when it's required.
2428 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2429 javadocs for getDocumentTitles() method.
2430 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2431 Set error message when RPC fails.
2432 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2433 glom files directory from the configuration file. Try to set the
2434 database authentication information for the specific document if it's
2435 set and works otherwise try to use the global authentication
2436 information set for the directory.
2437 * src/main/resources/onlineglom.properties: Moved from
2438 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2439 Added detailed comments for the new keys.
2441 2011-04-11 Ben Konrath <ben@bagu.org>
2443 Remove unnecessary @Override in DocumentSelectionViewImpl.
2445 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2447 2011-04-11 Ben Konrath <ben@bagu.org>
2449 Remove center alignment in DocumentSelectionView.
2451 The title element is still centred but the document titles and bottom
2452 sentence are both left-aligned.
2454 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2456 2011-04-11 Ben Konrath <ben@bagu.org>
2458 Change 'Demo' naming convention to 'Document'.
2460 This is just a rename refactor with no functional changes to the code.
2462 * src/main/java/org/glom/web/client/ClientFactory.java:
2463 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2464 * src/main/java/org/glom/web/client/OnlineGlom.java:
2465 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2466 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2467 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2468 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2469 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2470 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2471 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2472 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2473 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2476 2011-04-08 Ben Konrath <ben@bagu.org>
2478 Remove FIXME from safeLongToInt() method.
2480 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2485 2011-04-08 Ben Konrath <ben@bagu.org>
2487 Display an error if no glom documents are found in the specified directory.
2489 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2490 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2491 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2492 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2494 2011-04-08 Ben Konrath <ben@bagu.org>
2496 Add copyright header to one more file ... oops.
2498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2500 2011-04-08 Ben Konrath <ben@bagu.org>
2502 Add copyright header to files without it.
2504 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2505 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2506 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2507 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2508 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2509 * src/main/java/org/glom/web/shared/GlomField.java:
2511 2011-04-08 Ben Konrath <ben@bagu.org>
2513 Add support for accessing multiple glom documents in the servlet.
2515 This completes the demo selection functionality.
2517 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2518 document title to methods.
2519 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2520 document title to methods.
2521 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2522 Set browser window title when the activity starts. Correct name of
2523 document title variable.
2524 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2525 Set browser window title when the activity starts. Set the table
2526 selector change handler after table selector has been set. Clear the
2527 OnlineGlomView when the activity has been stopped.
2528 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2529 document title as the place token. Use "#Document:" instead of
2530 "#OnlineGlomPlace:" in the URL.
2531 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2532 Change heading to "Online Glom"
2533 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2534 document title in RPC methods.
2535 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2536 setDocumentTitle() method. Add clear() method.
2537 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2538 setDocumentTitle() method. Implement clear() method which removes the
2539 change handler on the ListBox, clears the ListBox and clears the
2541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2542 Implement methods with document title. Keep track for the configured
2543 glom documents and their corresponding JDBC configurations in a hash
2544 table. This information is retrieved using the document title as the
2545 key in the hash table.
2546 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2547 document title field as it's no longer needed.
2549 2011-04-08 Ben Konrath <ben@bagu.org>
2551 Update the Eclipse JDT configuration.
2553 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2554 methods. Automatically add the copyright header to new files.
2556 2011-04-05 Ben Konrath <ben@bagu.org>
2558 Add new page for demo selection.
2560 This patch adds all the components required to view and start an
2561 OnlineGlom demo by clicking on the desired hyperlink. The user is
2562 able to return to the demo selection page with the browser's back
2563 button. I still need to modify the servlet to work with multiple
2564 documents so all demo links will load the file defined in the
2565 OnlineGlom.properties.
2567 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2568 This is only useful during development so we don't need to save it.
2569 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2570 get a reference to the DemoSelectionView.
2571 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2572 method to get a reference to the DemoSelectionView.
2573 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2574 default view to DemoSelectionView.
2575 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2576 to get glom document titles for glom files in a hard-coded directory.
2577 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2578 method to get glom document titles for glom files in a hard-coded
2580 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2581 Presenter for DemoSelectionView.
2582 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2583 for DemoSelectionView.
2584 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2585 Update for DemoSelectionView.
2586 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2587 Basic 'Place' implementation for the DemoSelectionView.
2588 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2589 The interface for the DemoSelectionView.
2590 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2591 The implementation of the DemoSelectionView.
2592 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2593 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2595 implementation of method to get glom document titles for glom files
2596 in a hard-coded directory.
2597 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2598 on longer being used.
2599 * src/main/webapp/glom.png: Glom logo.
2601 2011-04-05 Ben Konrath <ben@bagu.org>
2603 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2605 This is the forth and final commit of a refactor that will allow
2606 OnlineGlom to be used with multiple documents.
2608 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2609 Move RPC code from OnlineGlomViewImpl to this class.
2610 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2612 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2613 RPC code to the presenter class (the P in MVP).
2615 2011-04-04 Ben Konrath <ben@bagu.org>
2617 Start moving the existing OnlineGlom code to MVP.
2619 This work is based on the GWT MVP framework that is documented here:
2621 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2623 This is the third commit of a refactor that will allow OnlineGlom to
2624 be used with multiple documents.
2626 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2627 Interface for client factory which is used to get instances of various
2628 classes throughout the app.
2629 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2630 Implementation of client factory.
2631 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2632 initialize the MVP framework.
2633 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2634 New file. Activity manager for the main container widget. This is the
2636 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2637 Maps place (URL) to its corresponding activity.
2638 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2639 New file. This is just a place holder for a generated file.
2640 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2641 New file. Represents the URL for the main Online Glom app.
2642 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2643 for changes in LayoutListViewImpl.
2644 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2645 interface for View. Move code to OnlineGlomViewImpl class.
2646 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2647 file. Implementation of OnlineGlomView.
2648 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2649 Place resources. Use ClientFactoryImpl by default.
2651 2011-04-04 Ben Konrath <ben@bagu.org>
2653 Move View classes to their own package.
2655 This is the second commit of a refactor that will allow OnlineGlom to
2656 be used with multiple documents.
2658 * src/main/java/org/glom/web/client/OnlineGlom.java:
2659 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2660 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2662 2011-04-02 Ben Konrath <ben@bagu.org>
2664 Move UI code from the main module to its own class.
2666 This is the first commit of a refactor that will allow OnlineGlom to be
2667 used with multiple documents.
2669 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2670 references to OnlineGlom to OnlineGlomView.
2671 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2672 OnlineGlomView and instantiate it here.
2673 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2674 represents the main OnlineGlomView with one document.
2676 2011-04-01 Ben Konrath <ben@bagu.org>
2678 Fix formatting of gwt.xml and add DTD.
2680 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2682 2011-03-30 Ben Konrath <ben@bagu.org>
2684 Propperly convert gdkColor string to html colour string.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2688 2011-03-28 Ben Konrath <ben@bagu.org>
2690 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2692 This implementation matches
2693 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2694 readable and is not tied to Swig.
2696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2698 2011-03-28 Ben Konrath <ben@bagu.org>
2700 Use read-only checkboxes for boolean field types.
2702 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2703 in the CellTable based on the field type. It currently only
2704 distinguishes between boolean and text columns but I'll need to add
2705 support for more types.
2706 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2707 column type in the ColumnInfo object. Add method to convert between the
2708 glom field type enum in ColumnInfo and the glom field type in libglom.
2709 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2711 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2712 getting and setting booleans.
2714 2011-03-25 Ben Konrath <ben@bagu.org>
2716 Don't get the Date twice from the ResultSet.
2718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2720 2011-03-25 Ben Konrath <ben@bagu.org>
2722 Cleanup code in the servlet.
2724 * TODO: Remove item about row count. Add item about testing row count
2725 query with large number of rows.
2726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2727 spelling mistakes, change method parameter to be consistent with
2730 2011-03-25 Ben Konrath <ben@bagu.org>
2732 Add server side logging with the gwt-log library.
2734 * .gitignore: Ignore the log file we're now producing.
2735 * TODO: Add a couple TODO item for logging.
2736 * pom.xml: Add gwt-log and log4j as a dependency.
2737 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2738 logging of errors, warnings and some important info.
2739 * src/main/resources/log4j.properties: New file to configure log4j.
2741 2011-03-24 Ben Konrath <ben@bagu.org>
2743 Add a disable button for the Details view.
2745 * src/main/java/org/glom/web/client/LayoutListView.java:
2747 2011-03-22 Ben Konrath <ben@bagu.org>
2749 Use a count query to get the number of rows for the list view pager.
2751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2753 2011-03-22 Ben Konrath <ben@bagu.org>
2755 Add more TODO information about CellTable pager positioning.
2759 2011-03-19 Ben Konrath <ben@bagu.org>
2761 Add TODO item about CellTable pager positioning.
2765 2011-03-18 Ben Konrath <ben@bagu.org>
2767 Remove unneeded GlomFieldColumn class.
2769 This is just a small code cleanup.
2771 * src/main/java/org/glom/web/client/LayoutListView.java:
2773 2011-03-18 Ben Konrath <ben@bagu.org>
2775 Use cursor mode in the query that gets data for the list view.
2777 I still need to fix the potential memory problem when getting the row
2778 count for the list view.
2780 * TODO: Add note about testing memory usage with large data sets. Add
2781 item about fixing row counting with large data sets.
2782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2783 PostgreSQL JDBC driver into cursor mode when getting data for the
2786 2011-03-15 Ben Konrath <ben@bagu.org>
2788 Remove the GWT Container from the Eclipse build classpath.
2790 The GWT dependencies are set by Maven so this isn't needed.
2794 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2796 Added some earlier mockups to git, but not to the tarball dist.
2798 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2799 Openismus. These hopefully show how we might structure the HTML so that
2800 it can be styled easily with CSS. However, we probably need to adapt them
2801 for the CSS structure that GWT dictates for common widgets.
2803 2011-03-14 Ben Konrath <ben@bagu.org>
2805 Locate OnlineGlom.properties using the ServletContext.
2807 This is required to be able to locate the file in the deployed servlet.
2809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2810 Configure the database and glom document in in a helper method so
2811 that the ServletContext can be used to locate OnlineGlom.properties.
2812 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2813 src/main/webapp. This is the proper location for .properites files.
2815 2011-03-12 Ben Konrath <ben@bagu.org>
2817 Add note to README about why we're compiling down to obfuscated JavaScript.
2821 2011-03-11 Ben Konrath <ben@bagu.org>
2823 Use properties file to configure servlet.
2825 This allows people to change the glom file path, db username and db
2826 password without recompiling the code.
2828 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2829 * src/main/webapp/OnlineGlom.properties:
2831 2011-03-11 Ben Konrath <ben@bagu.org>
2833 Use table fields in layout list view if the layout list is not defined.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2836 Manually create a LayoutFieldVector for the query builder using the
2837 table fields when a layout list is not defined in the glom file.
2839 2011-03-11 Ben Konrath <ben@bagu.org>
2841 Only show FIXME string for images when there's an image.
2843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2844 in this change are some small code cleanups.
2846 2011-03-11 Ben Konrath <ben@bagu.org>
2848 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2852 2011-03-11 Ben Konrath <ben@bagu.org>
2854 Correctly set the index of the default table.
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2857 Correctly set the index of the default table. Add commented out example
2860 2011-03-10 Ben Konrath <ben@bagu.org>
2862 Add comment to pom.xml about the previous change.
2864 * pom.xml: Add comment about the deployment issue so that it's obvious
2865 why java-libglom is set to the provided scope.
2867 2011-03-10 Ben Konrath <ben@bagu.org>
2869 Change java-libglom dependency from compile to provided in pom.xml.
2871 Since java-libglom uses jni it can only be loaded once and therefore
2872 must be placed in $CATALINA_HOME/lib and not included in each war.
2873 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2874 More information about this issue can be found in the Tomcat 6 release
2875 notes in the "JNI Based Applications" section:
2877 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2879 * README: Remove note about this issue. Deployment info should really
2880 be on the wiki anyway so I'll add it right now.
2881 * pom.xml: Change java-libglom dependency from compile to provided so
2882 that it's copied in to the packaged war.
2884 2011-03-09 Ben Konrath <ben@bagu.org>
2886 Change to using a neutral locale for currency, date and time formatting.
2888 This solves the problem of currency values being represented without a
2889 space between the currency code and the number (e.g. "EUR5.89" is now
2890 represented as "EUR 5.89"). More work is required when we implement
2891 a locale preference setting.
2893 * TODO: Add note about currency formatting issues with different
2895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2896 to using the neutral ROOT locale.
2898 2011-03-09 Ben Konrath <ben@bagu.org>
2900 Add support for currency codes that are not ISO 4217 codes.
2902 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2903 the currency code defined in the glom file when it's not 3 characters
2904 long or when Java doesn't recognize the string as an ISO 4217 code.
2906 2011-03-08 Ben Konrath <ben@bagu.org>
2908 Remove test classes, launch configurations and configuration.
2910 The test stuff was getting in the way when creating the war. To make
2911 the war file you can now do 'mvn clean package'. The packaged war file
2912 will be in the target directory.
2914 * .classpath: Remove unused classpathentry for tests and i18n.
2915 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
2916 property. Don't run test or i18n goals when packaging the war.
2917 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
2922 * OnlineGlomTest-dev.launch:
2923 * OnlineGlomTest-prod.launch:
2924 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2925 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
2927 2011-03-07 Ben Konrath <ben@bagu.org>
2929 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
2931 These fixes allow me to use 'mvn deploy' to create the war file.
2933 * .classpath: This generated config has been updated by Eclipse. This
2934 change was probably triggered by me updating from Eclipse 3.6.1 to
2936 * .gitignore: Add entry to ignore the directory
2937 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
2938 * .project: The generated config has been updated by Eclipse. This
2939 change was probably triggered by me updating from Eclipse 3.6.1 to
2941 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
2942 so that Eclipse doesn't complain
2943 * pom.xml: Update to gwt-maven-plugin 2.2.0.
2944 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
2945 'tests' directory to 'client' directory. This is the new
2946 gwt-maven-plugin convension.
2947 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
2948 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
2950 2011-03-07 Ben Konrath <ben@bagu.org>
2952 Add support for horizontal alignment in the LayoutList columns.
2954 * TODO: Remove item about horizontal alignment. Add item about
2955 improvements to ColumnInfo.
2956 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
2957 alignment on the columns. Use ColumnInfo RPC object get the column
2958 title and horizontal alignment.
2959 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
2960 LayoutListView creation with ColumnInfo RPC object.
2961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2962 a ColumnInfo object for every LayoutList columnn. Convert the
2963 FieldFormatting.HorizontalAlignment to the correct
2964 ColumnnInfo.HorizontatlAlignment with the new
2965 getColumnInfoHorizontalAlignment helper method.
2966 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
2967 to encapsulate column information like alignment and title. This
2968 could be used to set the colour instead of on a per cell field basis.
2969 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
2970 column title storage and retrieval with ColumnInfo.
2972 2011-03-04 Ben Konrath <ben@bagu.org>
2974 Add support for column sorting.
2976 * src/main/java/org/glom/web/client/LayoutListView.java: Change
2977 AsynDataProvider to be an anonymous inner class. Use new
2978 getSortedTableData RPC method when column sort is requested. Set all
2979 columns sortable and add an AsyncHandler to activate sorting in the
2981 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
2982 method getSortedTableData(). Cleanup other method signatures.
2983 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2984 new method getSortedTableData(). Cleanup other method signatures.
2985 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2986 Implement getSortedTableData() and getTableData() methods by using a
2987 private helper method with the appropriate parameters filled in. Use
2988 user supplied sort clause when supplied, otherwise fall back to
2989 sorting by the primary key. Move destroy() method to be underneath
2990 constructor for readability. Cleanup comments.
2992 2011-03-03 Ben Konrath <ben@bagu.org>
2994 Add support for colour text and colour backgrounds to the layout list cells.
2996 Only the cell backgrounds are coloured which leaves a gap between the
2997 cells that isn't coloured. I need to figure out a way to set
2998 'style=background-colour:' on the whole column rather than just the
3001 * TODO: Add a note about colouring the background of the whole column.
3002 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3003 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3004 render the coloured text and backgrounds. Use GlomField[] for the row type.
3005 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3007 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3008 GlomField[] for the row type.
3009 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3010 GlomField[] for the row type. Set the text, text colour and background
3011 colour in the GlomField objects as specified in the glom document. Add
3012 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3013 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3014 the glom field text, foreground colour and background colour.
3016 2011-03-02 Ben Konrath <ben@bagu.org>
3018 Don't display hidden tables in the combo box.
3020 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3023 code to ignore hidden tables using ArrayLists for the table names and
3025 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3026 tableNames to use ArrayLists instead of String[]. Update getter and setter
3029 2011-03-01 Ben Konrath <ben@bagu.org>
3031 Add support for Date and Time number types.
3033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3034 Implement formatting for Date and Time values. Change the default glom
3035 file to small business example.
3037 2011-03-01 Ben Konrath <ben@bagu.org>
3039 Add support for formatting glom types as specified in the glom file.
3041 Formatting isn't finished yet - I still need to add support for Date
3044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3045 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3046 checks for null values in JDBC cleanup code and catch all exceptions
3047 instead of just SQLExceptions.
3048 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3051 2011-03-01 Ben Konrath <ben@bagu.org>
3053 Use GWT 2.2.0 instead of 2.1.1.
3055 * pom.xml: Change GWT version numbers.
3057 2011-03-01 Ben Konrath <ben@bagu.org>
3059 A few small code cleanups.
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3063 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3064 unnecessary object creation in constructor.
3065 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3066 unnecessary object creation in constructor.
3068 2011-02-28 Ben Konrath <ben@bagu.org>
3070 Add file for TODO list.
3074 2011-02-18 Ben Konrath <ben@bagu.org>
3076 Enable the CellTable Pager when more than 20 rows need to be viewed.
3078 The Pager will automatically become active when the results are larger
3079 than the CellTable size which is currently set to 20 lines.
3081 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3082 name on debug statment in RPC call in LayoutListDataProvider, add
3083 numRows parameter to LayoutListView constructor, propperly set rowCount
3085 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3086 name on debug statment in RPC call, use LayoutListTable object in RPC
3087 calls, pass rowCount to LayoutListView.
3088 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3089 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3091 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3092 interface for changes in OnlineGlomService.
3093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3094 getLayoutListHeaders() to getLayoutListTable() and return
3095 LayoutListTable. Using this object allows me to pass other information
3096 about the LayoutList like the expected number of rows in the result set.
3097 The Connection object from the connection pool is now propperly closed.
3098 Only the requested number of lines are returned to the client in
3100 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3101 GlomTable and add columnTitles and numRows.
3103 2011-02-18 Ben Konrath <ben@bagu.org>
3105 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3107 This is a small performance boost. I'll use GlomTable to get the required
3108 layoutlist information.
3110 * src/main/java/org/glom/web/client/OnlineGlom.java:
3111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3112 * src/main/java/org/glom/web/shared/GlomDocument.java:
3114 2011-02-18 Ben Konrath <ben@bagu.org>
3116 Add option to turn off formatting in JDT formatter preferences.
3118 * .settings/org.eclipse.jdt.core.prefs:
3120 2011-02-18 Ben Konrath <ben@bagu.org>
3122 Rename LayoutList to LayoutListView.
3124 I'm working towards setting things up to easily use MVP when the time
3127 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3129 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3132 2011-02-17 Ben Konrath <ben@bagu.org>
3134 Move LayoutListDataProvider class into LayoutList.java.
3136 * src/main/java/org/glom/web/client/LayoutList.java:
3138 2011-02-17 Ben Konrath <ben@bagu.org>
3140 Rename RPC service classes from LibGlomService* to OnlineGlomService*.
3142 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Update
3144 * src/main/java/org/glom/web/client/OnlineGlom.java: Update references.
3145 * src/main/java/org/glom/web/client/OnlineGlomService.java: Rename
3146 from LibGlomServer.java.
3147 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3148 Rename from LibGlomServiceAsync.java.
3149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3150 Rename from LibGlomServiceImpl.java.
3151 * src/main/webapp/WEB-INF/web.xml: Update configuration.
3153 2011-02-17 Ben Konrath <ben@bagu.org>
3155 Update JDT settings.
3157 * .settings/org.eclipse.jdt.core.prefs:
3159 2011-02-17 Ben Konrath <ben@bagu.org>
3161 Move GWT-RPC objects to shared package (where they should be).
3163 * src/main/java/org/glom/web/client/LibGlomService.java: Update imports.
3164 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Update imports.
3165 * src/main/java/org/glom/web/client/OnlineGlom.java: Update imports.
3166 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Update imports.
3167 * src/main/java/org/glom/web/shared/GlomDocument.java: Move to
3168 org.glom.web.shared package.
3169 * src/main/java/org/glom/web/shared/GlomTable.java: Move to
3170 org.glom.web.shared package.
3171 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Included shared
3172 directory in compilation to javascript.
3174 2011-02-16 Ben Konrath <ben@bagu.org>
3176 Add sort clause to the sql query that grabs table information.
3178 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add sort clause
3179 if one of the columns is a primary key.
3181 2011-02-16 Ben Konrath <ben@bagu.org>
3183 Disable generateAsync feature of gwt-maven.
3185 The generated interface does not correctly match the methods in LibGlomService
3186 and the generated singleton Util inner-class doesn't respect the servlet
3189 * pom.xml: Turn off generateAsync feature.
3190 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Re-add file
3191 with singleton Util inner-class.
3193 2011-02-14 Ben Konrath <ben@bagu.org>
3195 Add LGPL v3 licence notices.
3197 Followed directions listed here:
3198 http://www.gnu.org/licenses/gpl-howto.html
3200 * COPYING: This file is a copy of the GPL v3.
3201 * COPYING.LESSER: This file is a copy of the LGPL v3.
3202 * src/main/java/org/glom/web/client/GlomDocument.java: Add licence
3204 * src/main/java/org/glom/web/client/GlomTable.java: Add licence
3206 * src/main/java/org/glom/web/client/LayoutList.java: Add licence
3208 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Add
3210 * src/main/java/org/glom/web/client/LibGlomService.java: Add licence
3212 * src/main/java/org/glom/web/client/OnlineGlom.java: Add licence
3214 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add
3217 2011-02-14 Ben Konrath <ben@bagu.org>
3219 Use ArrayList instead of Array in GWT-RPC calls.
3221 Apparently this gives a slight performance boost to the compiled
3224 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Use ArrayList
3226 * src/main/java/org/glom/web/client/LibGlomService.java: Use ArrayList instead
3229 2011-02-14 Ben Konrath <ben@bagu.org>
3231 Access data from a postgres db rather than the example glom file.
3233 * .settings/com.google.gwt.eclipse.core.prefs: Change GWT setting to
3234 compile down to obfuscated javascript.
3235 * pom.xml: Add c3p0 and postgres JDBC libraries.
3236 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Return data