1 2012-04-21 Murray Cumming <murrayc@murrayc.com>
3 Move use of Glom.build_sql*() into a new SqlUtils class.
5 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
6 to wrap Glom.build_sql*(). The parameter types are still Glom one,
7 but this will make it easier to start using something other than
10 2012-04-21 Murray Cumming <murrayc@murrayc.com>
12 Update the project URL.
14 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
16 2012-04-21 Murray Cumming <murrayc@murrayc.com>
18 Main layout: Use a FlowTable instead of absolute positioning.
20 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
21 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
22 child panels/widgets must have an absolute position. But that is annoying, so
23 this adds a FlowTable and puts the child panels in there.
25 2012-04-21 Murray Cumming <murrayc@murrayc.com>
27 GwtTestOnlineGlom: Comment out unused code.
29 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
30 Eclipse has started to say that some code is unused.
32 2012-04-21 Murray Cumming <murrayc@murrayc.com>
34 Update to the latest versions of dependencies.
36 * pom.xml: Update version numbers of dependencies to the latest
38 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
39 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
40 * src/main/java/org/glom/web/server/ReportGenerator.java:
41 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
42 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
43 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
45 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
46 Modify the imports where necessary.
48 2012-04-17 Murray Cumming <murrayc@murrayc.com>
50 Style: Remove overflow:hidden from searchbox
52 * src/main/webapp/style.css: Because this pushes the Back To Link
53 label/link on to the next row, which is then hidden due to the
54 hard-coded (in ems) height.
56 2012-04-20 Murray Cumming <murrayc@murrayc.com>
58 Remove some duplicate code.
60 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
61 getDocumentInfo(): This must have been duplicated during the merge from the
66 2012-04-19 Murray Cumming <murrayc@murrayc.com>
68 Reports: Localize the waiting for report message.
70 * src/main/java/org/glom/web/client/activity/ReportActivity.java
71 start(): Get the message from the contants.
72 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
74 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
75 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
76 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
77 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
78 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
79 Update these files with the English text for newer strings for now.
81 2012-04-19 Murray Cumming <murrayc@murrayc.com>
83 Reports: Show a message while waiting for the report.
85 * src/main/java/org/glom/web/client/ui/ReportView.java
86 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
87 Add setWaitingText(), to show a message saying that we are
88 waiting for the report to be ready.
89 * src/main/java/org/glom/web/client/activity/ReportActivity.java
90 start(): Call setWaitingText() before calling the async
93 2012-04-19 Murray Cumming <murrayc@murrayc.com>
95 ReportGenerator: Specify date and time formats.
97 * src/main/java/org/glom/web/server/ReportGenerator.java:
98 createFieldValueElement(): Use the default (and localized)
99 short formats, though we still need a way to show 4-digit
100 years without providing the format for every locale.
101 * src/main/java/org/glom/web/server/database/DBAccess.java:
102 convertResultSetToDTO(): Use the short formats here too.
104 2012-04-18 Murray Cumming <murrayc@murrayc.com>
106 ReportGenerator: Use the correct numeric formatting.
108 * src/main/java/org/glom/web/server/ReportGenerator.java
109 createFieldExpression(), createFieldValueElement(): Take the
110 whole LayoutItem_Field instead of just the field name, so
111 we have access to the formatting.
112 createFieldValueElement(): Use JRTextField.setPattern() to
113 specify the numeric formatting, with the help of a
114 regular DecimalFormat.
116 2012-04-18 Murray Cumming <murrayc@murrayc.com>
118 ReportGenerator: Avoid showing null for group by titles.
120 * src/main/java/org/glom/web/server/ReportGenerator.java
121 generateReport(): Use setBlankWhenNull() on the field title
122 style too, because this is used for values in group by
125 2012-04-18 Murray Cumming <murrayc@murrayc.com>
127 ReportGenerator: Add a colon to titles in vertical groups.
129 * src/main/java/org/glom/web/server/ReportGenerator.java
130 addFieldToDetailBandVertical(): Pass true for the withColon
133 2012-04-18 Murray Cumming <murrayc@murrayc.com>
135 ReportGenerator: Simplify the code by using Position more.
137 2012-04-18 Murray Cumming <murrayc@murrayc.com>
139 Reports: Support vertical groups, roughly.
141 * src/main/java/org/glom/web/server/ReportGenerator.java:
142 addToReport(): Rename to addGroupToReport() and, if necessary,
143 call the new addVerticalGroupToReport() method.
144 createFieldValueElement(): Let the caller specify the Y position
147 2012-04-17 Murray Cumming <murrayc@murrayc.com>
149 Reports: Allow a second report to be shown.
151 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
152 clear(): Do not remove the HTML widget, which broke the whole layout.
154 2012-04-17 Murray Cumming <murrayc@murrayc.com>
156 Locales drop-down: Show that we use English by default.
158 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
159 fillView(): When we use English, just because that is the default, when
160 no locale is specified, show that in the Locales drop-down instead of
161 just showing the first item.
163 2012-04-17 Murray Cumming <murrayc@murrayc.com>
165 Unselect the Report/Locale/Table combo item when appropriate.
167 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
168 setPlace(): clear reportName if this is not a ReportPlace.
169 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
170 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
171 When the provided name is empty, unselect all items, so that none are
172 indicated. This uses a for loop because I cannot find a single method
175 2012-04-17 Murray Cumming <murrayc@murrayc.com>
177 Report: Give the user a way to get back to the list.
179 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
180 start(), setPlace(): Show the Back To List link on reports, and also
181 interpret selecting the empty report item as back to list.
183 2012-04-13 Murray Cumming <murrayc@murrayc.com>
185 Really show the selected Report name.
187 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
188 setPlace(): Store the reportName here, if it is that kind of Place.
189 fillView(): Set the selected Report after filling the list of reports.
190 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
191 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
192 null Strings, though we need some way to unselect all ListBox items
195 2012-04-13 Murray Cumming <murrayc@murrayc.com>
197 ReportGenerator: Try to avoid some problems.
199 * src/main/java/org/glom/web/server/ReportGenerator.java
200 addField(): Try to avoid duplicates, and avoid using a null
203 2012-04-13 Murray Cumming <murrayc@murrayc.com>
205 Reports: Use quickFind.
207 * src/main/java/org/glom/web/client/OnlineGlomService.java;
208 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
210 getReportHTML(): Add a quickFind parameter.
211 * src/main/java/org/glom/web/client/activity/ReportActivity.java
212 start(): Pass the quickFind parameter.
213 * src/main/java/org/glom/web/server/ReportGenerator.java
214 generateReport(): Take a quickFind parameter.
216 2012-04-13 Murray Cumming <murrayc@murrayc.com>
218 ReportPlace: Actually use the report name.
220 * src/main/java/org/glom/web/client/place/ReportPlace.java
221 getPlace(): Do not assign the report name to the quickfind.
223 2012-04-13 Murray Cumming <murrayc@murrayc.com>
225 Show java.library.path when complaining.
227 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
228 init(): When telling us to check java.library.path, show the
231 2012-03-06 Murray Cumming <murrayc@murrayc.com>
233 ReportGenerator: Do not show nulls.
235 2012-03-06 Murray Cumming <murrayc@murrayc.com>
237 ReportGenerator: Make the title font larger.
239 2012-03-06 Murray Cumming <murrayc@murrayc.com>
241 ReportGenerator: Put field titles inside groups, if there are groups.
243 2012-03-06 Murray Cumming <murrayc@murrayc.com>
245 ReportGenerator: Take the Report itself instead of the name and group.
247 * src/main/java/org/glom/web/server/ConfiguredDocument.java
248 Remove getReportLayoutGroup().
249 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
250 getReportHTML(): Pass the report instead
251 of its name and layout group.
252 * src/main/java/org/glom/web/server/ReportGenerator.java
253 generateReport(): Use the report object to use the title
256 2012-03-06 Murray Cumming <murrayc@murrayc.com>
258 ReportGenerator: Remove designBand parameters.
260 * src/main/java/org/glom/web/server/ReportGenerator.java:
261 Make designBand a class member instead of passing it to all
264 2012-03-06 Murray Cumming <murrayc@murrayc.com>
266 ReportGenerator: Add lines, a bit like in the desktop version.
268 * src/main/java/org/glom/web/server/ReportGenerator.java
269 addToReport(): Use JRDesignLine.
271 2012-03-06 Murray Cumming <murrayc@murrayc.com>
273 ReportGenerator: Correct the title positions and use some bold style.
275 * src/main/java/org/glom/web/server/ReportGenerator.java:
276 Break the code up into reusable functions, correct the placement of
277 titles, and use normal/bold styles as in the reports in the desktop
280 2012-03-06 Murray Cumming <murrayc@murrayc.com>
282 ReportGenerator: Add a header band to show the field titles.
284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
285 getReportHTML(): Pass the localeId to the ReportGenerator
287 * src/main/java/org/glom/web/server/ReportGenerator.java
288 constructor: Take the localeID so we can get translated field
290 generateReport(), addToReport(), addFieldToBand(): Add field
291 titles in a column header band.
293 2012-03-05 Murray Cumming <murrayc@murrayc.com>
295 Reports drop-down list: Some improvement.
297 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
298 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
299 Adedd setSelectedReport(),
300 setReportList(): Add a blank line so that the user can select the
302 * src/main/java/org/glom/web/client/activity/ReportActivity.java
303 start(): Show the current report by calling setSelectedReport().
304 This does not seem to work yet.
306 2012-03-05 Murray Cumming <murrayc@murrayc.com>
308 DetailsActivity, ListActivity: Move some variables into a base class.
310 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
311 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
312 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
313 the clientFactory, documentID, tableName and authenticationPopup into
314 a base class, to avoid duplication.
316 2012-03-05 Murray Cumming <murrayc@murrayc.com>
318 Translate the Reports label.
320 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
321 Get the "Reports" label string from the constants.
322 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
323 perties: Add Reports to the constants.
325 2012-03-05 Murray Cumming <murrayc@murrayc.com>
327 Reports: Implement grouping.
329 * src/main/java/org/glom/web/server/ReportGenerator.java:
330 Handle LayoutItem_GroupBy items and try to do the right thing
331 with JRDesignGroup. It seems to work.
333 2012-03-04 Murray Cumming <murrayc@murrayc.com>
335 Actually show some data with JasperReports.
337 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
338 getReportHTML(): Move most code into a ReportGenerator class.
339 * src/main/java/org/glom/web/server/ReportGenerator.java:
340 Recurse into sub-groups, adding fields to the JasperDesign's details
341 band. Note that we must set an arbitrary width and height, or it just
342 will not show any data.
344 2012-03-04 Murray Cumming <murrayc@murrayc.com>
346 Reports Chooser: Show the titles, not the names.
348 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
349 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
350 and the names as the values.
351 * src/main/java/org/glom/web/server/ConfiguredDocument.java
352 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
353 group now that we provide the report name, so it should always
356 2012-02-15 Murray Cumming <murrayc@murrayc.com>
358 Depend on jasperreports.
360 * pom.xml: Add the dependency. My plan is to use this on the
363 2012-01-31 Murray Cumming <murrayc@murrayc.com>
365 Implement navigation to report places.
367 * src/main/java/org/glom/web/client/activity/ReportActivity.java
368 start(): Do not bother to handle all events here.
369 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
370 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
371 Added getSelectedReport().
372 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
373 .java: start(): When handling a change to the reports chooser,
374 call getSelectedReport() and goTo() its ReportPlace.
375 * src/main/java/org/glom/web/client/ui/ReportView.java
376 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
377 Added setReportHTML() which puts the html in a gwt HTML widget.
378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
379 getReportHTML(): Return "TODO" just to show that this works.
381 2012-01-31 Murray Cumming <murrayc@murrayc.com>
383 Make ReportPlace usable.
385 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
387 * src/main/java/org/glom/web/client/place/ReportPlace.java:
388 Correct the @prefix annotation.
390 2012-01-31 Murray Cumming <murrayc@murrayc.com>
392 OnlineGlomService: Return report HTML rather than the LayoutGroup.
394 * src/main/java/org/glom/web/client/OnlineGlomService.java:
395 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
396 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
397 Change getReportLayout() to getReportHMTL() because we will not need to
398 parse or render the report layout on the client side.
399 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
400 getReportLayout(): Return the libglom LayoutGroup type because we will
401 not need to convert to a shared type, because this will not be used on
403 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
406 Note that there is still no implementation for this.
409 2012-01-27 Murray Cumming <murrayc@murrayc.com>
411 Add a (empty) Report Place, View, and Activity.
413 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
415 * src/main/java/org/glom/web/client/place/HasTablePlace.java
416 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
417 this into a superclass:
418 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
419 and also use it as the base of this new ReportPlace:
420 * src/main/java/org/glom/web/client/place/ReportPlace.java
422 * src/main/java/org/glom/web/client/ui/ReportView.java
423 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
424 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
425 Add these, containing mostly boiler-plate for now.
427 * src/main/java/org/glom/web/client/OnlineGlomService.java
428 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
429 * src/main/java/org/glom/web/server/ConfiguredDocument.java
430 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
431 Add API to get the LayoutGroup for the report.
433 2012-01-23 Murray Cumming <murrayc@murrayc.com>
435 Add and fill a Reports drop-down list box.
437 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
439 * src/main/java/org/glom/web/client/OnlineGlomService.java:
440 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
441 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
442 Added getReports(document, table, localeID), calling
443 ConfiguredDocument.getReports().
444 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
445 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
446 Added setReportsList() and a list widget.
447 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
448 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
453 2012-04-12 Murray Cumming <murrayc@murrayc.com>
455 Translations: Add Esperanto.
457 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
458 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
459 properties: Add this translation because someone took the time to make it.
461 2012-03-15 Murray Cumming <murrayc@murrayc.com>
463 Adapt to the java-libglom 1.21.7 API.
465 * src/main/java/org/glom/web/server/ReportGenerator.java:
466 addToReport(): get_group_secondary_fields() is now
467 get_secondary_fields().
470 2012-03-15 Murray Cumming <murrayc@murrayc.com>
472 Use the latest java-libglom version.
474 * pom.xml: Use java-libglom 1.21.7.
476 2012-03-03 Ben Konrath <ben@bagu.org>
478 Display date and time in details view.
480 https://bugzilla.gnome.org/show_bug.cgi?id=671257
482 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
484 2012-03-05 Murray Cumming <murrayc@murrayc.com>
486 Require the latest java-libglom.
488 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
490 2012-03-04 Murray Cumming <murrayc@murrayc.com>
492 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
494 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
495 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
496 an empty quickfind string. I also corrected libglom to create only
497 empty where clauses for empty quickfind strings, but this avoids the
500 2012-02-24 Ben Konrath <ben@bagu.org>
502 Improve the tabs in the Notebook widget.
506 2012-01-30 Murray Cumming <murrayc@murrayc.com>
508 Translations: Try to translate the strings.
510 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
511 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
512 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
513 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
514 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
515 Take the Open translation from GTK+'s .po files.
516 Take the Details translation from Glom's po files.
517 I have added the other strings to Glom so we can get translations that way:
518 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
520 2012-01-27 Murray Cumming <murrayc@murrayc.com>
522 TableSelectionViewImpl: Put the search label and entry in a div.
524 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
525 Put the search widgets in a FlowTable so that the CSS can be used to
526 style them while keeping them together.
527 * src/main/webapp/style.css: Mention the new div.
529 2012-01-27 Murray Cumming <murrayc@murrayc.com>
531 Translate more strings in more locales.
533 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
534 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
535 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
536 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
537 Translate the "Details" and "Open" string too.
539 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
540 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
541 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
542 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
543 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
544 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
545 Add these new locales as placeholders though they currently contain English.
547 2012-01-27 Murray Cumming <murrayc@murrayc.com>
549 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
551 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
552 Check the ConfiguredDocument* for null before using it.
554 2012-01-26 Murray Cumming <murrayc@murrayc.com>
556 Tell Eclipse about the generated java files.
558 * .classpath: This lets it find OnlineGlomConstants.java.
559 It would be nice if Eclipse just used the maven build files.
561 2012-01-26 Murray Cumming <murrayc@murrayc.com>
563 Prevent a crash when no locale is specified in the URL.
565 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
566 Avoid returning a null string, obtained from
567 Window.Location.getParameter(). This caused a crash when it was
568 later passed to libglom's API.
569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
570 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
571 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
572 guard against future null strings.
574 2012-01-26 Murray Cumming <murrayc@murrayc.com>
576 Use the ?locale= query param instead of the &lang= token param.
578 * src/main/java/org/glom/web/client/place/ListPlace.java
579 * src/main/java/org/glom/web/client/place/DetailsPlace.java
580 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
581 Remove the lang token key and value.
583 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
584 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
585 When the user selects a different locale from the chooser, use
586 Window.Location.assign() to change the URL, which then causes a reload.
588 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
589 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
590 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
591 * src/main/java/org/glom/web/client/activity/ListActivity.java
592 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
593 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
594 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
595 * src/main/java/org/glom/web/client/ui/ListView.java:
596 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
598 Remove localeID member variables and method/constructor parameters, instead
599 using Utils.getCurrentLocaleID() when we need a localID to pass to
602 2012-01-26 Murray Cumming <murrayc@murrayc.com>
604 Internationalize the UI strings.
606 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
607 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
608 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
609 because it is unused. Messages are apparently strings that can have
610 parameters, but we do not need that yet, so Contants will be enough for now.
611 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
612 to say that we support the en and de locales.
613 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
614 The original English strings.
615 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
616 Some German translations of the English strings.
617 The i18n goal then uses the .properties file to generate an
618 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
619 returns an implementation that returns the translated strings.
620 The documentation suggests putting these in src/java/*/client/, but it seems
621 best to put it in src/resources/*/client/.
622 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
623 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
624 instead of hard-coding them.
625 Note that we cannot import OnlineGlomConstants because it does not exist yet,
626 but that does not seem to stop the build, though it confuses Eclipse.
628 You can see the translated string by adding ?locale=de to the URL, like so:
629 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
631 2012-01-24 Murray Cumming <murrayc@murrayc.com>
633 Improve null/empty String checks.
635 * pom.xml: Add a dependency on commons-lang, to use
636 org.apache.commons.lang.StringUtils.
637 * src/main/java/org/glom/web/server/ConfiguredDocument.java
638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
639 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
640 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
641 Use StringUtils.isEmpty().
643 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
644 StringUtils class with a static isEmpty() function because we
645 cannot use org.apache.commons.lang.StringUtils in client-side
646 GWT code because it (apparently) cannot be compiled to javascript.
647 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
648 * src/main/java/org/glom/web/client/activity/ListActivity.java
649 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
650 * src/main/java/org/glom/web/client/place/DetailsPlace.java
651 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
652 * src/main/java/org/glom/web/client/place/ListPlace.java
653 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
654 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
655 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
656 * src/main/java/org/glom/web/client/ui/details/Group.java
657 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
658 our StringUtils.isEmpty() function.
660 2012-01-24 Murray Cumming <murrayc@murrayc.com>
662 Update to the latest java-libglom API.
664 * pom.xml: Require java-libglom 1.21.4.
665 * src/main/java/org/glom/web/server/ConfiguredDocument.java
666 getDocumentInfo(), getListViewLayoutGroup():
667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
669 * src/main/java/org/glom/web/server/database/DBAccess.java
670 getFieldsToShowForSQLQueryAddGroup(),
671 getPrimaryKeyLayoutItemField(): Replace get_database_title()
672 with either get_database_title_original() or
673 get_database_title(localeID).
675 2012-01-24 Murray Cumming <murrayc@murrayc.com>
677 ConfiguredDocument: Avoid a null pointer exception.
679 * src/main/java/org/glom/web/server/ConfiguredDocument.java
680 Initialize localeID to "" to avoid returning a null String which
681 causes a crash in java-libglom's swing-generated code.
683 2012-01-23 Murray Cumming <murrayc@murrayc.com>
685 Some simple renaming.
687 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
688 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
689 for localeChooser. This seems more appropriate and is less ambiguous
690 particularly in the .css file.
692 2012-01-23 Murray Cumming <murrayc@murrayc.com>
694 ConfiguredDocument: Rename the localedID private member variable.
696 2012-01-23 Murray Cumming <murrayc@murrayc.com>
698 Adapt to the latest java-libglom API from git master.
700 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
701 libglom now uses only Vector instead of List, which uses add() instead of
704 2012-01-22 Murray Cumming <murrayc@murrayc.com>
706 ConfiguredDocument: Rename the localedID private member variable.
708 2012-01-20 Murray Cumming <murrayc@murrayc.com>
710 Build a source tarball with mvn assembly:single
712 * assembly.xml: Add this file.
713 * pom.xml: Use the maven-assembly-plugin and tell it to use
714 our assembly.xml file.
716 2012-01-19 Murray Cumming <murrayc@murrayc.com>
718 OnlineGlomServiceImpl: Get .glom files recursively.
720 * pom.xml: Depend on commons-io from org.apache.commons.
721 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
722 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
723 files recursively, and with the easier filter for the extension.
724 Use org.apache.commons.io.FilenameUtils.removeExtension() to
725 simplify that code too.
727 2012-01-19 Murray Cumming <murrayc@murrayc.com>
729 README: Mention that you must install java-libglom packages separately.
731 But then it works, because java-libglom is now in the central maven
734 2012-01-18 Murray Cumming <murrayc@murrayc.com>
736 locales drop-down: Show the correct selected locale when the URL changes.
738 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
739 .java: setPlace(): Move some code into fillView().
741 2012-01-18 Murray Cumming <murrayc@murrayc.com>
743 locales drop-down: Do not lose the primary key.
745 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
746 start(): onLocaleChange(): Pass the current primary key value,
747 instead of an empty value.
749 2012-01-18 Murray Cumming <murrayc@murrayc.com>
751 locales drop-down: Do not lose the drop-down selection.
753 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
754 .java (TableSelectionActivity.fillView): Set the selected locale
755 after changing the drop-down items (though we do not really need
756 to change them just because the locale changes.)
758 2012-01-18 Murray Cumming <murrayc@murrayc.com>
760 locales drop-down: Change the tables list when this changes.
762 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
763 .java: TableSelectionActivity.start(): Move the async table titles
764 retrieval into a private fillView() method and also call this when
765 the chosen locale changes.
766 Note that the document title is not actually translatable yet, but
767 that is a problem that I should fix soon in libglom.
769 2012-01-18 Murray Cumming <murrayc@murrayc.com>
771 Improve the placement of the locales drop-down.
773 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
774 Put the title and locales drop-down in a div (gwt.FlowTable).
775 * src/main/webapp/style.css: Add magic css properties to make this work.
776 Also remove the left margin from the title so that it lines up with the
779 2012-01-18 Murray Cumming <murrayc@murrayc.com>
781 locales selector: Show human-readable locale titles.
783 * src/main/java/org/glom/web/server/ConfiguredDocument.java
784 getDocumentInfo(): Use java.util.Locale to show a real title of
785 each locale, in the locale's own language.
787 2012-01-17 Murray Cumming <murrayc@murrayc.com>
789 Add a language/locale selector drop-down.
791 * src/main/java/org/glom/web/shared/DocumentInfo.java:
792 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
793 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
794 getDocumentInfo(): Store the available Locales in the DocumentInfo.
795 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
796 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
797 Add a ListBox to show the available locales. Add getLocaleSelector(),
798 setLocaleList(), getSelectedLocale(), setSelectedLocale().
799 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
800 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
801 java: Add these classes.
802 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
803 start(): Fill the locales ListBox. Handle its change event, firing a
805 setPlace(): Show the selected locale as specified by the URL token.
806 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
807 * src/main/java/org/glom/web/client/activity/ListActivity.java:
808 Handle LocaleChangeEvent, going to a new *Place with that locale.
810 The placement of the ListBox is not pretty, and it currently uses the ID
811 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
815 2012-01-17 Murray Cumming <murrayc@murrayc.com>
817 Search box: Show the search text from the URL token.
819 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
820 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
821 Add setQuickFindText().
822 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
823 .java: setPlace(): Store the queryText if the place is a ListPlace,
824 and call TableSelectionView.setQuickFindText().
826 2012-01-17 Murray Cumming <murrayc@murrayc.com>
828 Allow use of translations via, for instance, &lang=de in the URL.
830 * pom.xml: Use the unstable java-libglom 1.21 version.
832 * src/main/java/org/glom/web/client/OnlineGlomService.java:
833 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
835 init(): Instead of calling TranslatableItem.set_current_locale()
836 (now removed), call ConfiguredDocument.setDefaultLocaleID().
837 However, this is only for default locales, which are not needed to
838 change the locale in the URL.
839 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
840 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
841 getSortedRelatedListData(): Add a localeID parameter, so we can get the
842 layout for a particular locale.
843 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
844 Add get/setDefaultLocaleID().
845 getDocumentInfo(), getListViewData(), getRelatedListData(),
846 getDetailsLayoutGroup(), getListViewLayoutGroup(),
847 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
848 localeID parameter, so we can get the layout for a particular locale.
850 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
851 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
852 * src/main/java/org/glom/web/client/place/ListPlace.java:
853 Parse and construct a lang parameter too.
855 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
856 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
857 passed to subsequent methods and constructors.
858 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
859 * src/main/java/org/glom/web/client/activity/ListActivity.java:
860 Store the localeID from the *Place and pass it to other constructors
861 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
863 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
864 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
865 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
866 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
867 * src/main/java/org/glom/web/client/ui/ListView.java:
868 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
869 Take localeID parameters and pass them to subsequent constructors and
870 methods, so that the layout is always retrieved for that locale.
872 This is rather repetitive.
874 Note that "" means the original (default) locale of the Glom document,
875 which is usually English.
877 2012-01-17 Murray Cumming <murrayc@murrayc.com>
879 Documents: Remove final keyword to fix startup configuration.
881 * src/main/java/org/glom/web/shared/Documents.java: Remove the
882 final keywords on the private member variables because that breaks
883 the startup, apparently (there are warnings) because it stops them
884 from being serialized. I added these in the previous commit.
886 2012-01-13 Murray Cumming <murrayc@murrayc.com>
888 Documents: Add some final keywords.
890 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
893 2012-01-13 Murray Cumming <murrayc@murrayc.com>
895 OnlineGlomServiceImpl: Add to overview comments.
897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
898 Note that this is where all the document are loaded. They are not
899 loaded freshly for each page.
901 2012-01-12 Murray Cumming <murrayc@murrayc.com>
905 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
906 Add a TextBox for the text of a quick find.
907 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
909 setBackLink(): Add a String quickFind parameter.
910 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
911 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
912 to the base interface, because that is how TableSelectionViewImpl is used.
913 * src/main/webapp/style.css: Add style for the search box and its label.
915 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
916 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
917 Add these files, based on the existing TableChangeEvent and
918 TableChangeEventHandlers.
919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
920 start(): Handle QuickFindChangeEvent, passing its quickFind text to
921 a ListPlace() that the user should be taken to.
922 * src/main/java/org/glom/web/client/activity/ListActivity.java
923 start(): Handle it here too and adapt the TableChangeEvent handler to
924 pass the extra "" quickFind parameter to ListPlace.
925 * src/main/java/org/glom/web/client/place/ListPlace.java:
926 Constructor: Take an extra String quickFind parameter and store it,
927 returning it from a new getQuickFind() method.
928 getToken(): Put the quickFind text in the URL token.
929 getPlace(): Parse the quickFind text from the URL token.
930 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
931 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
932 ListPlace constructor.
933 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
934 .java: start(): Add a Change handler for the TableSelectionView's
935 TextBox (via its base HasChangeHandlers interface), firing the new
936 QuickFindChangeEvent.
937 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
938 pass the extra "" quickFind parameter.
940 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
941 setCellTable(): Add a String quickFind parameter and pass it to
942 the ListViewTable() constructor.
943 * src/main/java/org/glom/web/client/ui/ListView.java: Change
944 setCellTable() in the base interface, because that is how ListViewImpl
947 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
948 Add a String quickFind member variable.
949 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
950 Constructor: Add a String quickFind parameter, storing it in the
951 base ListTable's member variable.
952 onRangeChanged(): Pass quickFind to the
953 OnlineGlomServiceAsync.getSortedListViewData() and
954 OnlineGlomServiceAsync.getListViewData() methods.
956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
957 getListViewData(), getSortedListViewData(): Add a String quickFind
958 parameter, passing it to ConfiguredDocument.getListViewData().
959 * src/main/java/org/glom/web/client/OnlineGlomService.java:
960 Change getListViewData(), getSortedListViewData() in the base interface,
961 because that is how OnlineGlomServiceImpl is used, via this:
962 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
963 Change getListViewData(), getSortedListViewData() here too.
964 This class can apparently be used to asynchronously call methods on
965 OnlineGlomService, and GWT seems to implement that after recognizing
966 just the *Async name convention and the extra AsyncCallback parameters.
968 * src/main/java/org/glom/web/server/ConfiguredDocument.java
969 getListViewData(): Add a String quickFind parameter, and pass it to
970 ListViewDBAccess.getData().
971 * src/main/java/org/glom/web/server/database/ListDBAccess.java
972 getListData(): Add a String quickFind parameter and pass it to
974 getSelectQuery(): Add a String quickFind parameter.
975 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
976 getSelectQuery(): Add a String quickFind parameter and use it with
977 Glom.get_find_where_clause_quick() to pass a where_clause to
978 Glom.build_sql_select_with_where_clause(), to actually filter the
980 getData(): Add a String quickFind parameter, passing it to getListData().
981 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
982 va: getData(): Pass an empty string to getListData() for the
985 2012-01-12 Murray Cumming <murrayc@murrayc.com>
987 ListTable: Minor change.
989 * src/main/java/org/glom/web/client/ui/list/ListTable.java
990 createCellTable(): Make this protected instead of public.
992 2012-01-12 Murray Cumming <murrayc@murrayc.com>
994 Many files: Use final for the parameters and use the @override attribute.
996 2012-01-22 Ben Konrath <ben@bagu.org>
998 Add anchor links for single line text that starts with http, ftp and www.
1002 2012-01-22 Ben Konrath <ben@bagu.org>
1004 Add ellipsis to single line text in details view.
1008 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1010 Remove all javadoc author tags.
1012 Because they are awkward and meaningless when many people touch
1014 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1016 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1018 Revert the COPYING.LESSER to COPYING rename.
1020 Apparently both should be there if it is LGPL.
1022 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1024 *View: Remove unused imports.
1026 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1027 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1028 * src/main/java/org/glom/web/client/ui/ListView.java:
1029 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1030 Remove unused imports, as suggested by Eclipse.
1032 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1034 Move the *View::Presenter types, and some API into one base View.
1036 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1037 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1038 * src/main/java/org/glom/web/client/ui/ListView.java:
1039 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1040 Presenter, setPresenter() and clear() into a shared base interface,
1041 to avoid the unnecessary duplicate Presenter types and to more clearly
1042 show how the *Views share the same structure, even if they are not
1043 used polymorphically.
1045 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1046 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1048 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1049 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1050 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1052 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1055 Feel free to revert this if there is a good reason for the duplicate
1058 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1060 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1062 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1063 a class member instead of a local variable in the method.
1064 This lets us use it to get the view instances, for use in tests.
1065 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1066 beforeOnlineGlom(): Test some more details of the initial view.
1067 Again, this is not very useful.
1069 To really test gwt-glom we will need to start a local postgresql
1070 instance with local data, like the Glom tests in C++.
1072 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1074 pom.xml: Mention the LGPL license.
1076 * pom.xml: Add a licenses section.
1077 * COPYING.LESSER: Move this to COPYING, which
1078 previously contained the GPL. But gwt-glom is all LGPL.
1080 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1082 Add project information to README and pom.xml.
1084 * README: Add a brief description and mention some mvn
1086 * pom.xml: This extra information shows up in mvn site
1089 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1091 Use the latest java-libglom version.
1093 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1095 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1097 GwtTestOnlineGlom: Test a little more.
1099 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1100 protected rather than private, as suggested by the gwt-test-utils
1102 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1103 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1104 Test the initial visibility of the panels.
1106 However, this is not a very useful test.
1107 And I wonder how we should generally test using this idea for an
1108 activity/places app like ours where the real changes happen implicitly
1109 based on the history token/URL.
1111 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1113 Slight modification to *Mapper comments.
1115 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1116 (DataActivityMapper)
1117 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1119 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1121 Remove comments mentioning GIN because they are just copied from
1122 the example code and are apparently not helpful:
1123 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1124 Also change the mention of a class that is only in the example code.
1126 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1128 GwtTestOnlineGlom test: Minor changes.
1130 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1131 Avoid the long qualified class name and modify the comment
1132 because it is now obvious to me that the mocked class is the only
1133 custom one created via GWT.create().
1135 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1137 Tests: Added the beginnings of a test using gwt-test-utils.
1139 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1140 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1141 which tells gwt-test-utils what class will be tested.
1142 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1143 Add a simple (but empty) test case. One class, used by the OnlineGlom
1144 class, is mocked so that it can be created. However, I am not sure
1145 why only this class needs to be mocked.
1147 Note that mockito seems more popular, and clearer, than easymock,
1148 but I have not got that working yet. It might be a matter of the
1151 This test is run during mvn integration-test.
1153 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1155 Tests: Use junit4-style syntax instead of junit3-style.
1157 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1158 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1159 * src/test/java/org/glom/web/shared/DataItemTest.java:
1160 Use the @Test annotation rather than relying on the test*() prefix.
1161 Also no longer implement TestCase, to avoid triggering support for
1162 the junit3-way, which stops the annotations from working.
1163 Change the imports from import junit.framework.* to
1164 import org.junit.*, which is apparently the new way.
1166 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1168 Added a test for ListPlace token parsing and creation.
1170 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1171 This is much the same as DetailsPlaceTest.
1173 I wonder how we could test the other parts of the *Place API.
1175 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1177 DetailsPlace test: Also test getToken() and recreation via getPlace().
1179 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1180 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1181 recreate it, testing the recreated DetailsPlace for the same parameter
1184 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1186 Use the surefire-report plugin.
1188 * pom.xml: This generates a HTML report about the tests in
1189 target/site/surefire-report.html
1190 when you do mvn surefire-report:report. It seems to be popular/normal.
1192 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1194 Added a test for DetailsPlace.
1196 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1197 Test the getPlace() token parsing.
1199 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1201 Added a first unit test.
1203 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1204 * src/test/java/org/glom/web/shared/DataItemTest.java:
1205 This is a silly test but it is just to get things started. Note that
1206 maven/junit finds the test because it looks in src/test by default.
1208 2011-12-22 Ben Konrath <ben@bagu.org>
1210 Change charsetName to "UTF-8" when replacing line breaks.
1212 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1213 that work in Java (such as "UTF8") will not work when compiled to
1216 This fixes a problem with multi-line details view fields that have hard
1217 line breaks. The "License Text" field on this page demonstrates the
1220 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1222 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1224 2011-12-22 Ben Konrath <ben@bagu.org>
1226 Fix another bug with related list navigation.
1228 I've tested all the navigation buttons in all of the related lists
1229 so things should be good now.
1231 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1233 2011-12-22 Ben Konrath <ben@bagu.org>
1235 Fix a crasher when refreshing the list view with the default table.
1237 This crash will also happen when loading the list view with the default
1238 table from a link or bookmark.
1240 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1241 to the main document selection page when the document id hasn't been
1243 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1244 the main document selection page when the document id hasn't been
1246 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1247 values for the details place when the document id hasn't been set.
1248 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1249 values for the list place when the document id hasn't been set.
1251 2011-12-21 Ben Konrath <ben@bagu.org>
1253 Protect against NPE when glom.document.locale is not in config.
1255 This patch protects against an NPE when glom.document.locale is not in
1256 the config file. This NPE will also happen if glom.document.locale is
1259 The patch also updates the error message to display the class name when
1260 the getMessage() returns null. This was happening when the NPE was
1261 thrown and I had "Configuration Error: null". If an NPE is encountered
1262 with this patch, "Configuration Error: NullPointerException " will be
1265 This commit closes this bug:
1267 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1271 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1273 Rename onlineglom.properties to onlineglom.properties.sample.
1275 * src/main/resources/onlineglom.properties: Rename to:
1276 * src/main/resources/onlineglom.properties.sample:
1277 * src/main/resources/README: And add this file explaining that people
1278 should rename it back when deploying.
1280 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1282 Allow choosing the translation in the .properties file.
1284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1285 init(): Read a glom.document.locale value from the configuration file
1286 and call Glom's TransatableItem::set_current_locale() method.
1287 * src/main/resources/onlineglom.properties: Add a commented-out
1288 example of this new setting.
1290 It would be better to add &lang=de_DE to the URL, but the current
1291 libglom API does not allow us to do this easily. I am working on that.
1293 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1295 Avoid a crash in parsing of token parameters.
1297 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1298 ava: getTokenParams(): Do not crash if a parameter has a key but no
1299 value, and ignore parameters with neither.
1301 2011-12-17 Murray Cumming <murrayc@murayc.com>
1303 History token building/handling: Improve use of token parameters.
1305 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1306 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1307 and buildParamsToken(HashMap), for use by derived classes.
1308 Make the separator private because it is no longer be needed.
1309 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1310 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1311 instead of manual string concatenation.
1312 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1313 of hardcoded indices and awkward splitting code.
1314 * src/main/java/org/glom/web/client/place/ListPlace.java
1315 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1316 instead of manual string concatenation.
1317 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1318 of hardcoded indices and awkward splitting code.
1319 This should fix bug #666420
1321 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1323 Fix a Navgiation->Navigation typo in the code.
1325 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1326 Rename processNavgiation() to processNavigation().
1328 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1330 Fix a seperator->separator typo in the code.
1332 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1333 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1334 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1337 2011-12-15 Ben Konrath <ben@bagu.org>
1339 Cleanup some comments.
1341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1343 2011-12-14 Ben Konrath <ben@bagu.org>
1345 Replace \n with <br/> for multiline text in the details view.
1347 Vertical scrollbars are added when needed as well.
1349 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1351 2011-12-14 Ben Konrath <ben@bagu.org>
1353 Specify the font for document selection links.
1355 * src/main/webapp/style.css:
1357 2011-12-14 Ben Konrath <ben@bagu.org>
1359 Fix bouncy CellTable while paging.
1361 This doesn't currently work with related list tables in unselected
1364 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1366 2011-12-14 Ben Konrath <ben@bagu.org>
1368 Revamp the appearance of the document selection page.
1370 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1371 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1372 * src/main/webapp/style.css:
1374 2011-12-13 Ben Konrath <ben@bagu.org>
1376 Set navigation button column to the smallest size possible.
1378 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1380 2011-12-13 Ben Konrath <ben@bagu.org>
1382 Change OpenButton nomenclature to NavigationButton.
1384 Using NavigtionButton makes things more generic. Classes, methods and
1385 variables have been changed.
1387 This is a rename-only refactor.
1389 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1390 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1391 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1392 Renamed from OpenButtonCell.
1393 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1394 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1395 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1397 2011-12-12 Ben Konrath <ben@bagu.org>
1399 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1401 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1402 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1403 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1404 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1406 2011-12-12 Ben Konrath <ben@bagu.org>
1408 Update variable names and comments.
1410 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1411 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1413 2011-12-12 Ben Konrath <ben@bagu.org>
1415 Properly initialize numNonEmptyRows variable to zero.
1417 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1418 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1420 2011-12-05 Ben Konrath <ben@bagu.org>
1422 Add latest mockup with HTML tables.
1424 Features of this mockup:
1426 -> HTML table for flowtable
1427 -> HTML table for flowtable column
1428 -> Example of how related lists would look
1429 -> Not using text entries for data items
1431 The current version of Online Glom doesn't use HTML tables for the
1434 This mockup has been sent to the glom-devel mailing list but it's good
1435 to have it here as well.
1437 * mockups/details-view-html-tables.html:
1439 2011-12-05 Ben Konrath <ben@bagu.org>
1441 Remove unnecessary getPrimaryKeyField() method.
1443 getPrimaryKeyFieldForTable(String) has been renamed to
1444 getPrimaryKeyField(String).
1446 * src/main/java/org/glom/web/server/database/DBAccess.java:
1447 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1448 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1450 2011-12-05 Ben Konrath <ben@bagu.org>
1452 Add string representation of TypedDataItem value to conversion error message.
1454 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1455 message was extracted into its own method to avoid duplication.
1457 2011-12-05 Ben Konrath <ben@bagu.org>
1459 Add type checking to navigation primary key value creation.
1461 Create navigation primary key only if the expected type from the Glom
1462 document matches the type returned by the SQL query.
1464 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1466 2011-12-05 Ben Konrath <ben@bagu.org>
1468 Rename a couple of variables in RelatedListNavigation.
1470 This is a rename-only refactor.
1472 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1474 2011-12-05 Ben Konrath <ben@bagu.org>
1476 Move getListLayoutGroup() into getListViewLayoutGroup().
1478 This removes getListLayoutGroup(). It was only being called by
1479 getListViewLayoutGroup().
1481 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1483 2011-12-05 Ben Konrath <ben@bagu.org>
1485 Remove check for LayoutItem_Portal in list table method.
1487 This check is no longer necessary because the method isn't being used
1488 to create the LayoutItemPortal DTO.
1490 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1492 2011-12-05 Ben Konrath <ben@bagu.org>
1494 Properly support related list navigation.
1496 Navigation from the "Repository Analyzer -> Package Scans ->
1497 Dependencies" related table wasn't working because the primary key for
1498 related tables wasn't being set properly. This commit fixes the
1501 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1502 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1503 doesn't set the primary key properly for related list tables.
1504 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1505 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1506 useful for getting the primary key for list view tables and for related
1508 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1509 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1510 Move code to set the primary key for the table from the abstract
1511 ListDBAccess class to ListViewDBAccess as it's only correct for list
1513 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1514 Properly add primary key to related list tables.
1516 2011-12-02 Ben Konrath <ben@bagu.org>
1518 Properly set the horizontal alignment of fields.
1520 This fix is for both the list tables and the details view.
1522 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1523 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1524 to set the horizontal alignment of fields.
1526 2011-12-02 Ben Konrath <ben@bagu.org>
1528 Display currency codes in the details view.
1530 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1532 2011-12-02 Ben Konrath <ben@bagu.org>
1534 Avoid duplicate JNI call.
1536 JNI is not as efficient as pure Java and this is an easy (and small)
1539 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1540 Use previously retrieved value for whereClauseToTableName instead of
1543 2011-12-02 Ben Konrath <ben@bagu.org>
1545 Rename a couple of variables in RelatedListNavigation.
1547 This is a rename-only refactor.
1549 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1551 2011-12-02 Ben Konrath <ben@bagu.org>
1553 Indicate clearly that a mismatched primary key type is a bug.
1555 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1556 warning to error. Add 'This is a bug.' to message.
1558 2011-12-02 Ben Konrath <ben@bagu.org>
1560 Update / fix some comments.
1562 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1564 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1566 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1567 Fix comments. Add some TODOs.
1569 2011-12-02 Ben Konrath <ben@bagu.org>
1571 Enable navigation to details view with string primary key from related list.
1573 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1574 Create a text primary key value when return type of result is
1575 java.sql.Types.VARCHAR.
1577 2011-12-02 Ben Konrath <ben@bagu.org>
1579 Use checkboxes for booleans in the details view.
1581 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1583 2011-12-01 Ben Konrath <ben@bagu.org>
1585 Improve performance of related list height calculation.
1587 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1588 Put code to calculate the expected height in a static initializer so
1589 that that it's only called once.
1591 2011-12-01 Ben Konrath <ben@bagu.org>
1593 Show related list tables in notebooks (again).
1595 Calculate the height of the related list tables so the Notebook can be
1596 set the correct height. The height of the related list table is also needed by
1597 FlowTable to be able decide how to create the layout.
1599 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1600 and set the Portal height based on the height of the related list
1601 table and the Portal container.
1602 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1603 Add method to calculate the height of the related list tables.
1604 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1605 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1606 calculate the height of the Pager widget.
1608 2011-12-01 Ben Konrath <ben@bagu.org>
1610 Use CellTable API for table property instead of setting style on Element.
1612 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1614 2011-12-01 Ben Konrath <ben@bagu.org>
1616 Make ListViewTable and RelatedListTable a consistent height.
1618 The tables are now a consistent height regardless of the contents of
1619 the table. A hidden button is added to empty rows to ensure that the
1620 height of these rows will match the height of rows with data.
1622 A navigation button column is now added to every table. The width of
1623 the navigation column is set to 0px when a RelatedListTable shouldn't
1624 have navigation buttons. This maintains the a consistent row height in
1625 tables that don't show the navigation buttons.
1627 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1628 navigation column when not needed.
1629 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1630 arguments for navigation button to constructor of ListViewTable.
1631 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1632 hidden button for empty data rows.
1633 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1634 arguments for navigation button to constructor.
1635 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1636 create navigation buttons. Add hideNavigationButtons() method.
1637 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1638 arguments for navigation button to constructor.
1640 2011-12-01 Ben Konrath <ben@bagu.org>
1642 Use 'visibility: hidden' in Utils.getWidgetHeight().
1644 This is better choice because hidden elements are invisible, don't
1645 respond to events and are not part of the tab order. They will,
1646 however, take up space which is required to be able to calculate the
1647 height of the widget.
1649 * src/main/java/org/glom/web/client/Utils.java:
1651 2011-12-01 Ben Konrath <ben@bagu.org>
1653 Use Utils.getWidgetHeight() in FlowTable.
1655 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1657 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1659 2011-12-01 Ben Konrath <ben@bagu.org>
1661 Put the details css class name on the correct table column.
1663 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1665 2011-11-30 Ben Konrath <ben@bagu.org>
1667 Update for java-libglom API change.
1669 The getters and setters on FieldFormatting and NumericFormat were
1670 changed to remove the 'M'.
1672 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1674 2011-11-29 Ben Konrath <ben@bagu.org>
1676 Only allow RelatedListTables in Portals.
1678 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1680 2011-11-29 Ben Konrath <ben@bagu.org>
1682 Only create a contents panel for Portals when title is being set.
1684 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1686 2011-11-29 Ben Konrath <ben@bagu.org>
1688 Set TabLayoutPanel height based on calculated height its widgets.
1690 This is a potential fix for this bug:
1692 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1694 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1696 2011-11-29 Ben Konrath <ben@bagu.org>
1698 Align details field labels and data with the Open buttons.
1700 * src/main/webapp/style.css:
1702 2011-11-29 Ben Konrath <ben@bagu.org>
1704 Remove unnecessary <div> in the Notebook widget.
1706 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1707 method to get container FlowPanel (<div>).
1708 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1709 initWidget() method directly on the TabLayoutPanel widget instead of
1710 Group's container widget.
1712 2011-11-29 Ben Konrath <ben@bagu.org>
1714 Don't add group titles for Portals in Notebooks.
1716 This reverts the previous patch and fixes a bug I introduced with
1717 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1719 * src/main/java/org/glom/web/client/ui/details/Group.java:
1720 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1722 2011-11-28 Ben Konrath <ben@bagu.org>
1724 Remove unused boolean argument in Portal constructor.
1726 Just a code cleanup.
1728 * src/main/java/org/glom/web/client/ui/details/Group.java:
1729 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1731 2011-11-28 Ben Konrath <ben@bagu.org>
1733 Remove hack for glom 1.18 style glom files.
1735 * src/main/java/org/glom/web/client/ui/details/Group.java:
1736 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1737 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1739 2011-11-28 Ben Konrath <ben@bagu.org>
1741 Use Gda Value version of primary key to log result too large error.
1743 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1745 2011-11-28 Ben Konrath <ben@bagu.org>
1747 Don't use TypedDataItem.getText() for Unknown types from the URL.
1749 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1750 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1751 instead of getText().
1752 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1753 String field and getUnknown() method.
1755 2011-11-28 Ben Konrath <ben@bagu.org>
1757 Log an error message when the java-libglom .so is not present.
1759 The error message was being set in the exception but not logged.
1761 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1763 2011-11-28 Ben Konrath <ben@bagu.org>
1765 Ignore LayoutItem_CalendarPortals.
1767 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1768 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1770 2011-11-28 Ben Konrath <ben@bagu.org>
1772 Extract method for creating the LayoutItemPortal DTO.
1774 Just breaking the code up into smaller chunks.
1776 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1778 2011-11-28 Ben Konrath <ben@bagu.org>
1782 This should have been added with the refactor. Oops!
1784 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1786 2011-11-28 Ben Konrath <ben@bagu.org>
1788 Create primary key value from URL string using type from Glom document.
1790 See this bug, comments 19 - 25:
1792 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1794 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1795 create a TypeDataItem for the primary key here when loading from a
1796 URL. Show the same string for the primary key value as was received
1797 from the URL string (when loading from a URL).
1798 * src/main/java/org/glom/web/server/Utils.java: Update method for
1799 creating the Gda Value from the TypeDataItem to properly deal with
1800 creating a Gda Value based on the Glom document type for the primary
1801 key value string when loading from a URL.
1802 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1803 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1804 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1805 Update for changed method name.
1807 2011-11-27 Ben Konrath <ben@bagu.org>
1809 Rename PrimaryKeyItem to TypedDataItem.
1811 The name PrimaryKeyItem suggests what the class should be used for.
1812 TypedDataItem is a neutral name that describes the class better.
1814 This is a rename-only refactor.
1816 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1817 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1818 * src/main/java/org/glom/web/client/Utils.java:
1819 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1820 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1821 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1822 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1823 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1824 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1826 * src/main/java/org/glom/web/server/Utils.java:
1827 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1828 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1829 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1830 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1832 2011-11-25 Ben Konrath <ben@bagu.org>
1834 Improve Gda Value conversion from PrimaryKeyItem.
1836 The value from the PrimaryKeyItem is only used if its type match the
1837 type from the glom document.
1839 * src/main/java/org/glom/web/server/Utils.java:
1841 2011-11-25 Ben Konrath <ben@bagu.org>
1843 Manually check if the java-liblgom .so is visible to the JVM.
1845 It seems that Tomcat has problems when a static initializer throws an
1846 exception. This check is done before the first method call into
1847 java-libglom so that execution doesn't continue if the .so is not
1850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1852 2011-11-25 Ben Konrath <ben@bagu.org>
1854 Improve browser configuration error messages.
1858 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1860 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1861 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1862 getConfigurationErrorMessage() method.
1863 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1864 Get and display a specific configuration error message when no Glom
1865 documents are found.
1866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1867 Implement getConfigurationErrorMessage() method. Surround configuration
1868 code in the init() method with a try/catch block. This allows the
1869 errors to be caught while keeping the servlet available to retrieve the
1870 configuration error message.
1872 2011-11-25 Ben Konrath <ben@bagu.org>
1874 Don't use Strings to hold primary key values.
1876 The primary key values are now held in a new data object
1877 (PrimaryKeyItem) that holds type information and the primary key value
1878 using the correct type.
1880 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1881 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1882 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1883 PrimaryKeyItem instead of String to hold the primary key value.
1884 * src/main/java/org/glom/web/client/Utils.java: Remove
1885 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1886 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1887 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1888 PrimaryKeyItem instead of String to hold the primary key value. Load
1889 document selection page when the documentID has not been set correctly.
1890 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1891 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1893 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1894 Return empty string for URL instead of "null".
1895 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1896 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1897 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1898 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1899 PrimaryKeyItem instead of String to hold primary key values.
1900 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1901 PrimaryKeyValue to a Gda Value.
1902 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1903 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1904 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1905 Replace temporary database access code that uses the PrimaryKeyValue to
1906 Gda Value conversion.
1907 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1908 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1909 PrimaryKeyItem instead of String.
1910 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1911 hold primary key values.
1913 2011-11-24 Ben Konrath <ben@bagu.org>
1915 Use newly added java-libglom API to create queries.
1917 This isn't finished. I still need to stop using Strings for primary key
1918 values in the client code.
1920 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1921 libglom to use fake connections so that retrieving the query string will
1923 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1924 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1925 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1926 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1927 Use the newly added libglom sql methods and classes to create the
1928 query. Add temporary hack to convert primary value strings to Gda
1931 2011-11-23 Ben Konrath <ben@bagu.org>
1933 Don't explicitly set the height of Portals.
1935 See comments 6 - 10 of this bug for details:
1937 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1939 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1941 2011-11-23 Ben Konrath <ben@bagu.org>
1943 Use an HTML table instead of CSS for the FlowTable layout.
1945 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1946 GWT's FlexTable to implement the FlowTable.
1947 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1949 2011-11-18 Ben Konrath <ben@bagu.org>
1951 Add boolean example to HTML table mockup.
1953 * mockups/details-view-html-tables-text-entries.html:
1955 2011-11-17 Ben Konrath <ben@bagu.org>
1957 Ensure the pager buttons are always visible for related lists.
1959 To accomplish this, I've turned off text wrapping in the list view and
1960 related list tables for both the header and data text. The related list
1961 table now has a fixed layout so the it doesn't overflow its container.
1962 This is required to ensure that the cell text is clipped when it
1963 overflows the cell and an ellipsis is added to the right side of the
1964 cell when text is clipped.
1966 A fixed table layout for the related list table in the details view
1967 seems what we want for the details view anyway, so the side-effect is
1970 The ellipsis will only be displayed in Firefox >= 7.
1974 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1976 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1977 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1978 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1980 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1981 Set the 'table-layout: fixed' CSS property to the related list table.
1982 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1983 'white-space: nowrap;' CSS property on both the list view and the
1984 related list tables.
1986 2011-11-16 Ben Konrath <ben@bagu.org>
1988 Rework the fix for empty notebook tab labels.
1990 Setting the empty group titles with its name caused problems for the
1991 details layout. Instead of using libglom's
1992 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1993 to the client when the title is empty. This allows the Notebook to use
1994 the name when the title is empty without affecting anything else.
1996 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1997 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1999 2011-11-16 Ben Konrath <ben@bagu.org>
2001 Set group titles with name when title is empty.
2003 This fixes a problem with an empty notebook tab label in the Lesson
2004 Planner document. The forth tab in the notebook should be "Internet":
2006 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2008 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2009 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2012 2011-11-16 Ben Konrath <ben@bagu.org>
2014 Remove whitespace from the configured username properties.
2016 This assumes that usernames won't have whitespace at the beginning
2017 or end. But I think this is a reasonable assumption.
2019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2020 String.trim() to remove the whitespace from the username properties.
2022 2011-11-15 Ben Konrath <ben@bagu.org>
2024 Add details view mockup with HTML tables and text entries.
2026 This is from the attachment on this bug:
2028 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2030 * mockups/details-view-html-tables-text-entries.html:
2032 2011-11-15 Ben Konrath <ben@bagu.org>
2034 Add space between the columns of the flow table.
2038 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2040 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2041 space between columns in the flow table.
2043 2011-11-15 Ben Konrath <ben@bagu.org>
2045 Add backup files to the .gitignore.
2047 * .gitignore: Ignore files that end with ~.
2049 2011-11-09 Ben Konrath <ben@bagu.org>
2051 Use latest release of gwt-log.
2053 Gwt-log releases are now being submitted to the maven central
2054 repository so manual installation of the jar is no longer required.
2056 * pom.xml: Update version and groupId of gwt-log dependency.
2058 2011-10-31 Ben Konrath <ben@bagu.org>
2060 Don't use GWT numeric formatting to override the glom currency formatting.
2062 Currencies are now displayed like they are in Glom. See this bug:
2064 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2066 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2068 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2069 currency code to constructor and set it when the cell is rendered.
2070 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2071 currency code to the constructor of the NumericCell.
2073 2011-10-27 Ben Konrath <ben@bagu.org>
2075 Require the latest release of java-libglom (1.17.4).
2079 2011-10-26 Ben Konrath <ben@bagu.org>
2081 Add style to Notebook that matches current theme.
2083 It's not the best style in the world but it's better than the default.
2085 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2086 padding at the bottom of the child widgets.
2087 * src/main/webapp/style.css: Add style for the Notebook.
2089 2011-10-26 Ben Konrath <ben@bagu.org>
2091 Move servlet initialization code to overridden init method.
2093 This is half of the solution to getting proper error messages
2094 displayed when configuration errors occur. Here's the relevant bug:
2096 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2098 The rest of the solution involves surrounding the init method with a
2099 try/catch block and setting a global variable with the error /
2100 exception. A new async method should be created to retrieve and display
2101 the error message / exception.
2103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2104 code from constructor to init method adding exceptions as needed.
2106 2011-10-26 Ben Konrath <ben@bagu.org>
2108 Add script to monitor and restart tomcat if required.
2110 * utils/check-and-recover-tomcat.py: New file.
2112 2011-10-26 Ben Konrath <ben@bagu.org>
2114 Display the correct number of data items in the pager.
2118 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2120 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2121 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2122 The implementation is the same for both tables: Keep track of the
2123 number of non-empty rows and fire and RowCountChangeEvent after the data has
2125 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2126 custom Pager class that subclasses SimplePager to handle displaying
2127 the correct number when empty rows have been added.
2129 2011-10-26 Ben Konrath <ben@bagu.org>
2131 Correct error in previous commit.
2133 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2134 eventBus parameter from listView.setCellTable().
2136 2011-10-26 Ben Konrath <ben@bagu.org>
2138 Fix error in TODO comment.
2140 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2142 2011-10-24 Ben Konrath <ben@bagu.org>
2144 Create Notebook widgets to the details view.
2146 This isn't finished just yet - I still need to create a reasonable
2147 style to match the current theme.
2149 * src/main/java/org/glom/web/client/Utils.java: Add method for
2150 calculating the height of a widget. This is used in the Notebook class.
2151 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2152 new constructor method in Group.
2153 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2154 method for creating child widget that can be used by subclasses
2155 like Notebook. New constructor that allows disabling the group
2156 titles - Notebooks don't set a group title for their child groups.
2157 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2158 to make Notebooks using GWT's TabLayoutPanel.
2159 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2160 constructor that allows disabling the group titles.
2161 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2162 LayoutItemNotebook DTO.
2163 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2164 DTO for Notebooks. It's just an empty class for now but we might need
2165 it to transfer some specific information in the future.
2167 2011-10-21 Ben Konrath <ben@bagu.org>
2169 Add navigation buttons to related list tables.
2171 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2172 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2174 method getSuitableRecordToViewDetails() for getting the table name
2175 and primary key value for related list navigation buttons.
2176 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2177 private cell renderer class to get the navigation information for
2178 related list tables from the server. Extract the navigation
2179 processing code from the details cell navigation and use it for the
2180 related list navigation as well.
2181 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2182 cell renderer class for the details open buttons. This was needed
2183 because the related list navigation buttons and the list view
2184 navigation buttons need to react differently when clicked.
2185 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2186 the onEnterKeyDown() method because it's now overriden in the
2187 subclasses that are specific to the related list tables and the list
2189 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2190 the vertical size a little because the buttons add a bit of vertical
2191 space to table. This is not a perfect solution because the vertical
2192 size of with table fewer than 5 rows will be a little smaller.
2193 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2194 changes in how navigation buttons are handled.
2195 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2196 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2197 database access object.
2198 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2199 to find the portal for a given relationship name from
2200 RelatedListDBAccess. Add method to find a primary key field for a
2202 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2203 Move code to find the portal for a given relationship name to
2205 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2206 New file: database access object for getting the related list
2207 navigation information (the table name and the primary key value).
2208 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2209 DTO for transferring a table name to navigate to and a primary key
2211 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2212 boolean and getter/setter to specifies if the related list should add
2215 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2217 Use the master branch of java-libglom
2219 * pom.xml: Depend on java-libglom 1.19 instead.
2221 This is the master branch. See also the libglom-1-18 branch.
2223 2011-10-11 Ben Konrath <ben@bagu.org>
2225 Enable the open navigation button when the data has been set.
2227 This avoids having active buttons that don't do anything when the data
2230 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2232 2011-10-11 Ben Konrath <ben@bagu.org>
2234 Use IsWidget interface for FlowTableItem.
2236 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2237 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2239 2011-10-11 Ben Konrath <ben@bagu.org>
2241 Remove GWT styling from open button in details view.
2243 There are still some issues with how the details cell is arranged but
2244 this should be made to match Glom 1.20. I'm going to leave fixing this
2245 until I have Glom 1.20 up and running.
2247 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2248 style name on open button.
2249 * src/main/webapp/style.css: Move and edit details-navigation class.
2250 Re-arrange some classes to make them appear in the same order as the
2253 2011-10-07 Ben Konrath <ben@bagu.org>
2255 Update to GWT 2.4.0.
2257 * .gitignore: Ignore new cache directory.
2258 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2259 * pom.xml: Change GWT and maven plugin to 2.4.0.
2260 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2262 * src/main/java/org/glom/web/client/ClientFactory.java:
2263 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2264 * src/main/java/org/glom/web/client/OnlineGlom.java:
2265 Update source for API changes.
2266 * utils/build-onlineglom-war.sh: Remove cache directory before the
2269 2011-10-07 Ben Konrath <ben@bagu.org>
2271 Add navigation buttons in the details view.
2273 This isn't finished but I thought I'd commit what I have as it's a
2274 pretty good start. I still need to:
2276 1. Change the style so that it fits better into the current theme
2277 2. Adjust the details cell to expand as much as possible.
2279 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2280 click handlers to navigation buttons in the DetailsCells. Create a
2281 refreshData() method to get just the data from the server without the
2283 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2284 Update the tableSelector and browser title when the table name
2285 changes without using the tableSelector.
2286 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2287 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2288 getDetailsCells() to getCells(). Update variable names.
2289 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2290 method to set click handler on navigation button. Rename a few
2291 variables. Add navigation buttons where needed.
2292 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2293 variables and methods.
2294 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2295 navigation boolean and navigation table as required in the
2296 LayoutItemField DTO.
2297 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2298 variables for navigation along with getter/setter methods.
2300 2011-10-07 Ben Konrath <ben@bagu.org>
2302 Rename Field to DetailsCell.
2304 This is a refactor-only commit. No functionality has been added or
2307 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2308 Update variable and method names.
2309 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2310 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2311 variable and method names.
2312 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2314 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2315 variable and method names.
2317 2011-10-07 Ben Konrath <ben@bagu.org>
2319 Create separate methods for layout and data the details view.
2321 This is a refactor-only commit. No functionality has been added or
2324 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2325 private methods: setData(), createLayout().
2327 2011-10-07 Ben Konrath <ben@bagu.org>
2329 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2331 This is part of a change to get navigation buttons in the details view
2332 but it should have been done this way from the start.
2334 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2335 for method name change in TableSelectionView.
2336 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2337 Create TableChangeEvent and set the browser title using the
2338 TableSelectionView API.
2339 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2340 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2341 Change getSelectedTable() to getSelectedTableName(). Add
2342 getSelectedTableTitle().
2344 2011-10-07 Ben Konrath <ben@bagu.org>
2346 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2348 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2350 2011-10-07 Ben Konrath <ben@bagu.org>
2352 Update TableChangeEvent to use newTableName naming convention.
2354 This makes the class more consistent with GWT naming conventions.
2356 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2357 Update for method name change in TableChangeEvent.
2358 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2359 for method name change in TableChangeEvent.
2360 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2361 newTableName variable and getter method. Make toDebugString()
2364 2011-09-30 Ben Konrath <ben@bagu.org>
2366 Disable the pager in the list tables when the data row count is less than the minimum.
2368 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2369 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2371 2011-09-30 Ben Konrath <ben@bagu.org>
2373 Add empty rows to the end of related list and list view tables.
2375 I also extracted the cell rendering classes from the ListTable because
2376 the code was becoming a little crazy with all the anonymous inner
2377 classes. My plan is to use these cell rendering classes in the details
2378 view as well so this refactor will be needed for that change.
2380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2381 set the row count in related list tables if the data has more rows
2382 than the minimum number of rows visible.
2383 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2384 row count in list view tables if the data has more rows than the
2385 minimum number of rows visible.
2386 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2387 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2389 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2390 for rendering TYPE_NUMERIC cells. The code was extracted from the
2392 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2393 class for rendering cells with buttons in list views. The code was
2394 extracted from the ListTable class.
2395 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2396 for rendering TYPE_TEXT cells. The code was extracted from the
2398 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2399 Add empty rows to the end of the data if required. Implement
2400 ListTable.getMinNumVisibleRows().
2401 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2402 cell renderer code to public classes. Return null in
2403 Column.getValue() for empty rows. Add new abstract method:
2404 getMinNumVisibleRows(). Move code to set the row count of the list view
2405 table to ListViewImpl.
2406 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2407 empty rows to the end of the data if required. Implement
2408 ListTable.getMinNumVisibleRows().
2411 2011-09-27 Ben Konrath <ben@bagu.org>
2413 Use GWT.log for client-side debugging statements.
2415 These are optimized out when deployed so I should have used this method
2416 in the first place. These statements will eventually be replaced with some sort
2417 of notification in the browser.
2419 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2420 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2421 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2422 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2423 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2425 2011-09-27 Ben Konrath <ben@bagu.org>
2427 Put tableselector on the right, back to list link on right.
2429 The idea is that the table selector is acting like a label for the
2430 currently displayed table so it should be placed below the document title. This
2431 puts the table title in a similar position to where it is in Glom.
2433 * mockups/details-contacts.html:
2434 * mockups/details-projects.html:
2435 * mockups/listview-contacts.html:
2436 * mockups/listview-projects.html:
2437 * mockups/style.css:
2438 Update mockups to match how the interfaces currently look.
2439 * src/main/webapp/style.css: Swap positions of backlink with the table
2440 selector. Add some space on the left side of the table selector to
2441 line things up with the document title.
2443 2011-09-27 Ben Konrath <ben@bagu.org>
2445 Add field colouring to details view.
2447 This change re-works how field colouring works. The colour formatting
2448 information is now set to the client with the layout information instead of
2449 with the data. This eliminates the need to send the same colour strings for
2450 data in list view column when colour information is set.
2452 In order to set an alternate colour for negative numeric values, the
2453 number is now sent to client and formatted with the GWT NumberFormat class.
2455 This change also fixes:
2457 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2459 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2460 internationalization framework which is needed for client side numeric
2462 * src/main/java/org/glom/web/client/Utils.java: New file for some
2463 client static utility methods.
2464 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2465 the DataItem object to the Field class. Use a utility method to
2466 create the foreignKeyValue string.
2467 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2468 alignment and text colours in the constructor. Add setData(DataItem)
2469 method. Remove setText(String) method.
2470 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2471 colour information to GlomTextCell. Create and use GlomNumberCell for
2472 rendering numbers. Use utility method to get the string for the
2473 primary key of the key provider. Re-work how the horizontal alignment
2475 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2476 formatting to layout information. Methods for converting the libglom
2477 formatting information were moved from DBAccess.
2478 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2479 numeric formatting (it's now done on the client side). Don't set text
2480 colours in DataItem. Move libglom formatting conversion methods to
2482 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2483 getters/setters for text colour information.
2484 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2485 for transferring the libglom NumericFormat information to the client.
2486 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2487 and getters/setters for: GlomNumericFormat, background colour and
2488 foreground colour strings.
2490 2011-09-26 Ben Konrath <ben@bagu.org>
2492 Simplify code that iterates through the LayoutGroup.
2494 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2496 2011-09-26 Ben Konrath <ben@bagu.org>
2498 Accept Eclipse formatting for OnlineGlomServiceAsync.
2500 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2502 2011-09-26 Ben Konrath <ben@bagu.org>
2504 Don't use the ListDBAccess classes to get the primary key layout information.
2506 This was causing a bug where the wrong index for the hidden primary key
2507 was being sent to the client.
2509 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2510 primary key while creating the LayoutGroup DTO. Create a
2511 LayoutItemField DTO for hidden primary keys. Don't use the
2512 RelatedListDBAccess because it was only used for getting the primary
2514 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2515 access modifier from public to protected for getPrimaryKeyField() and
2516 getPrimaryKeyLayoutItemField().
2517 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2518 abstract method getExpectedResultSize() because RelatedListDBAccess
2519 doesn't have enough info to implement it.
2520 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2521 Remove @Override for getExpectedResultSize().
2522 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2523 Remove method getExpectedResultSize().
2525 2011-09-23 Ben Konrath <ben@bagu.org>
2527 Log which layout (list or details) the ignored item is from.
2529 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2531 2011-09-23 Ben Konrath <ben@bagu.org>
2533 Remove annotations that turn off code formatting in DataItem.
2535 * src/main/java/org/glom/web/shared/DataItem.java:
2537 2011-09-23 Ben Konrath <ben@bagu.org>
2539 Rename GlomField to DataItem and update associated methods.
2541 This is a rename-only refactor. No functionality has been added or
2544 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2545 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2546 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2547 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2548 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2549 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2550 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2551 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2553 * src/main/java/org/glom/web/server/database/DBAccess.java:
2554 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2555 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2556 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2557 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2558 * src/main/java/org/glom/web/shared/DataItem.java:
2559 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2560 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2562 2011-09-23 Ben Konrath <ben@bagu.org>
2564 Rename GlomDocument to DocumentInfo and update associated methods.
2566 This is a rename-only refactor. No functionality has been added or
2569 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2570 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2571 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2572 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2573 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2575 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2577 2011-09-20 Ben Konrath <ben@bagu.org>
2579 Require java-libglom 1.17.3.
2581 This picks up the fix for the seg fault problem with the Scenes table
2582 in the Openismus Film Manager example.
2586 2011-09-20 Ben Konrath <ben@bagu.org>
2588 Change the way sort clause is added for primary key when no sort clause is requested.
2590 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2591 before the sort clause is created. When a sort clause is not requested, the
2592 sort clause is created by finding the primary key in the LayoutFieldVector
2595 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2597 2011-09-20 Ben Konrath <ben@bagu.org>
2599 Log error message if no documents are found in the configured directory.
2601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2602 Extract the glom file extension string to a private static final class
2603 variable (mostly as syntactic sugar). Accept a minor formatting change.
2604 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2605 the example glom.document.directory configuration property to make it
2606 more clear that it can any directory, not just the home directory.
2608 2011-09-18 Ben Konrath <ben@bagu.org>
2610 Add related lists to details view.
2612 The related list table has support for paging and sorting just like the
2613 table in the list view.
2615 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2616 SQL queries for the related list tables.
2617 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2618 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2620 Rename getList methods to getListView and add comments. Remove
2621 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2622 it being unused. Add methods: getDetailsLayoutAndData(),
2623 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2624 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2625 Create the layout and set the data for the fields in one async call
2626 instead of two. Create related lists where appropriate.
2627 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2628 for method name changes in OnlineGlomService.
2629 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2630 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2631 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2633 * src/main/java/org/glom/web/client/ui/ListView.java:
2634 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2635 tableName from setCellTable(). Create a ListViewTable instead of
2637 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2638 represent a data field in the details view.
2639 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2640 from addDetailsCell() to Field class. Keep track of the Fields and
2641 Portals in the details view.
2642 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2643 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2644 and add a method to get it. Add method to set the contents of the
2646 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2647 New class for related list tables. This class has the data provider
2648 for the related list table.
2649 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2650 abstract class which is the base class for the ListViewTable and the
2652 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2653 New class for list view tables. This class has the data provider for
2654 the list view table.
2655 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2656 methods for related list tables. Add more information to the
2657 LayoutItemField and LayoutItemPortal DTOs.
2658 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2659 Remove debugging print statement.
2660 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2661 Remove debugging print statements. Add primary key field to SQL count
2663 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2664 Remove unnecessary LayoutFieldVector parameter from
2665 getResultSizeOfSQLQuery() method.
2666 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2667 New class for related list table database access.
2668 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2669 class that is a wrapper DTO for details view layout and data.
2670 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2671 new 'fromField' string to this DTO.
2672 * src/main/webapp/style.css: Remove bottom margin and override top
2675 2011-09-15 Ben Konrath <ben@bagu.org>
2677 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2679 This sets things up to make it easier to add the data retrieval for
2680 related lists (portals). No user noticeable changes were made with
2683 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2684 class has the code to retrieve the layouts and access the
2685 database using the new database helper classes.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2687 Most of the functionality has been removed from this class. This
2688 class now represents the public interface for the client side
2689 code. It also deals with configuring the servlet and cleaning
2690 things up when the servlet is stopped.
2691 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2692 of static methods into this utility class.
2693 * src/main/java/org/glom/web/server/database/DBAccess.java:
2694 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2695 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2696 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2697 These classes have the database retrieval code. The class hierarchy
2698 has been setup to make it easy to reuse code for similar
2701 2011-09-06 Ben Konrath <ben@bagu.org>
2703 Create separate classes for list table code and the data provider.
2705 As part of this refactor, I also split up the code a bit to make it
2708 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2709 table code to two new classes (below).
2710 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2711 with code from ListViewImpl.
2712 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2713 New file with code from ListViewImpl.
2715 2011-09-06 Ben Konrath <ben@bagu.org>
2717 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2719 This fixes the LayoutItemPortal DTO to match the libglom layout object
2722 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2724 2011-09-01 Ben Konrath <ben@bagu.org>
2726 Set title of Portals in the Details View.
2728 * pom.xml: Bump required version of java-libglom to 1.17.1.
2729 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2730 widget creation to its own class. Add comments to constructor.
2731 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2732 The code is mostly from the Group class with the title now set.
2733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2734 title of Portal. Update some comments. Fix some code formatting.
2736 2011-09-01 Ben Konrath <ben@bagu.org>
2738 Remove TODO comment for the flow table column width.
2740 The flow table column width is working correctly and doesn't need to be
2741 changed. See this mailing list post for more info:
2743 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2745 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2747 2011-08-27 Ben Konrath <ben@bagu.org>
2749 Add document title (database name) to top of the browser page.
2751 I added the document title to the TableSelecitonView but that will
2752 change if / when we add a view that doesn't require table selection.
2754 * mockups/details-contacts.html:
2755 * mockups/details-projects.html:
2756 * mockups/listview-contacts.html:
2757 * mockups/listview-projects.html:
2758 * mockups/style.css: Add document title to mockups to keep things
2760 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2761 sizes to account for the document title.
2762 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2763 Set the document title when it has been retrieved from the server.
2764 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2765 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2766 and implement setDocumentTitle(String) method.
2767 * src/main/webapp/style.css: Add ID for document title style.
2769 2011-08-25 Ben Konrath <ben@bagu.org>
2771 Add NavigationType enum to LayoutItemPortal DTO.
2773 This is the start of adding support for Portals to the Details View.
2775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2776 LayoutItem_Portal.navigation_type enum from libglom to
2777 LayoutItemPortal.NavigationType enum.
2778 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2779 NavigationType enum, field for storing the NavigationType and getter
2782 2011-08-25 Ben Konrath <ben@bagu.org>
2784 Implement the flow table layout in the Details View.
2786 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2787 FlowTable to Group to account for the renamed class.
2788 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2789 File. This is a container widget that implements the Glom details view
2790 flow table behaviour.
2791 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2792 org/glom/web/client/ui/FlowTable.java.
2793 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2794 so that the size of the subgroups are a closer match to the size of
2795 the Glom subgroups. This makes the flowtable layout match the layout
2796 in Glom for the Music Collection example file.
2798 2011-08-16 Ben Konrath <ben@bagu.org>
2800 Create container element for LayoutItemPortal in Details View.
2802 This will help me develop the layout for the FlowTable.
2804 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2805 fieldPanel variable to detailsCell.
2807 2011-08-15 Ben Konrath <ben@bagu.org>
2809 Set the height of the data element in the Details View.
2811 I changed the InlineLabels (text in a span element) to Labels (text in
2812 a div element) so that I could set the height of the details-data
2813 elements instead of the details-cell parent elements. This allows the
2814 the details-data element to display the correct height if style is
2815 applied that shows the height.
2817 This change has the added benefit of allowing the order of the labels
2818 and data elements to be changed for right-to-left languages.
2820 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2821 InlineLabels to Labels.
2822 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2823 InlineLabels to Labels. Set the height of the data element.
2824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2825 multiline text height in the Formatting DTO.
2826 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2827 for multiline height along with getter and setter methods.
2828 * src/main/webapp/style.css: Adjust style to account for the change
2829 from span elements to div elements in the details cell.
2831 2011-08-15 Ben Konrath <ben@bagu.org>
2833 Make the List View appearance match the mockups.
2835 It doesn't match exactly but it's much better than it was.
2837 * mockups/listview-contacts.html: Remove unused css classes.
2838 * mockups/listview-projects.html: Remove unused css classes.
2839 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2840 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2841 for mainPanel instead of VerticalPanel (table). Set style name on
2842 CellTable. Set style name on Details column. Right-align Details
2844 * src/main/webapp/style.css: Adjust properties to match the mockups.
2846 2011-08-12 Ben Konrath <ben@bagu.org>
2848 Add better support for subgroups in the details view.
2850 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2851 changed FlowTable constructor.
2852 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2853 support for subgroups and subgroup-titles.
2854 * src/main/webapp/style.css: Add CSS class for subgroups and
2857 2011-08-12 Ben Konrath <ben@bagu.org>
2859 Return the top level LayoutGroup title.
2861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2863 2011-08-11 Ben Konrath <ben@bagu.org>
2865 Make the TableSelector header match the mockup.
2867 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2868 the layout panel. Properly lineup the table selection header with
2869 the list and details view.
2870 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2871 margin around the details view.
2872 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2873 Rename listBox variable to tableSelector. Set id for the style sheet.
2874 Use a FlowPanel instead of a HorizontalPanel.
2875 * src/main/webapp/style.css: Add properties to make the TableSelector
2876 box match the mockups.
2878 2011-07-13 Ben Konrath <ben@bagu.org>
2880 Update install script for java-libglom version change.
2882 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2885 2011-07-13 Ben Konrath <ben@bagu.org>
2887 Add support sub-group in the details view.
2889 I also removed the code that special-cased the default details view
2892 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2894 I still have to make a proper flowtable.
2896 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2897 Don't special-case default details view layout.
2898 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2899 addLayoutField() as I'm going to use it.
2900 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2901 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2903 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2904 extracted from DetailsViewImpl.GroupPanel. Add support for
2906 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2907 column count when getting the details layout.
2909 2011-07-12 Ben Konrath <ben@bagu.org>
2911 Set browser title with database and table titles.
2913 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2914 Set the browser title when the table changes and when the activity
2916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2917 title when retrieving document info (the GlomDocument object).
2918 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2919 with getter and setter methods. Remove unused convenience constructor.
2920 Use default code formatting.
2922 2011-07-12 Ben Konrath <ben@bagu.org>
2924 Ignore LayoutItemPortals in the details view.
2926 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2929 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2930 LayoutItemPortal layout objects.
2931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2932 LayoutItemPortal objects when retrieving the details layout.
2933 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2934 file. This is an empty class and just used to get type information for
2937 2011-07-12 Ben Konrath <ben@bagu.org>
2939 Use java-libglom 1.17.0.
2943 2011-07-11 Ben Konrath <ben@bagu.org>
2945 Remove "Table:" label from table selector.
2947 This matches a recent change in the Glom UI.
2949 * mockups/details-contacts.html:
2950 * mockups/details-projects.html:
2951 * mockups/listview-contacts.html:
2952 * mockups/listview-projects.html: Remove the "Table:" label from the
2954 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2956 2011-07-11 Ben Konrath <ben@bagu.org>
2958 Add main groups to the details view.
2960 This makes things look a little nicer in the details view. The next step
2961 is to implement the flowtable.
2963 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2964 resources from the standard gwt css theme. Standard.css is now
2965 included in OnlineGlom.html so that the online glom css rules have
2966 precedence over the gwt theme.
2967 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2968 the whole LayoutGroup to the DetailsView instead of just the titles.
2969 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2970 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2971 details layout with a helper class (GroupPanel). I might extract this
2972 class when I make the full flowtable.
2973 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2974 string as default so I don't have to worry about NPEs when processing
2976 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2977 note beside OnlineGlom.gwt.xml above).
2978 * src/main/webapp/style.css: Add default font-size to body to override
2979 the font-size set by the standard theme. Don't use h2 tags for
2980 group-title. Create new details-cell class.
2982 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2984 ConfiguredDocument: Set the port number too.
2986 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2987 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2988 Glom document. Presumably this worked sometimes so far because there is a
2989 default port number.
2991 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2993 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2995 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2996 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2997 correct, though we should throw an exception too.
2999 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3001 Fix a addDocuemnt typo.
3003 * src/main/java/org/glom/web/shared/Documents.java
3004 (Documents.addDocuemnt): Rename to addDocument().
3005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3006 (OnlineGlomServiceImpl.getDocuments): Adapt.
3008 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3010 Slightly improved log output when connection fails.
3012 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3013 (ConfiguredDocument.setUsernameAndPassword):
3014 We don't know for sure if it' the username/password that's wrong, so
3015 rephrase the message.
3016 Also ouput the exception message, though it's generic in this case.
3018 2011-07-08 Ben Konrath <ben@bagu.org>
3022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3023 added braces to a one line if statement because the Eclipse formatter
3024 was getting confused.
3026 2011-07-07 Ben Konrath <ben@bagu.org>
3028 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3030 These should really be two separate tasks but I counldn't get things to
3031 work with GWT 2.2.0 and Eclipse 3.7.
3035 * .settings/org.eclipse.jdt.core.prefs:
3036 * .settings/org.eclipse.jdt.ui.prefs:
3037 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3038 * .settings/org.eclipse.m2e.core.prefs:
3039 Add new config files. Update current files. Remove references to the
3040 webtools plugins as we're not using any of the webtools features.
3041 * .gitignore: Add logs directory which is created when running with
3043 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3044 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3045 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3047 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3049 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3051 onlineglom.properties: Add explanatory comments.
3053 * src/main/resources/onlineglom.properties: Also change the default user
3054 from ben to someuser, to avoid the risk of people thinking we just
3055 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3057 2011-06-28 Ben Konrath <ben@bagu.org>
3059 Use filename in Log for incorrect passwords.
3061 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3062 getFileName(String) method to get the filename from the URI.
3064 2011-06-28 Ben Konrath <ben@bagu.org>
3066 Add the table name to the URL token for the ListPlace.
3068 This makes things consistent between the DetailsPlace and the
3069 ListPlace. It also allows the the ListPlace to be bookmarked.
3071 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3072 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3074 Remove getDefaultListLayout(). The default layout is now returned
3075 by the getListLayout() method when the table name is an empty string.
3076 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3077 Add table name field. Change to a new ListPlace when the table
3078 has been changed. Use getListLayout() for getting the default
3080 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3081 Add table name field. Set the correct table name in the list box
3082 when loading from bookmark. This corrects a problem for the
3084 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3085 Move table name to super-class (HasSelectableTable). Move document
3086 and table URL keys to super-class in HasSelectableTable.
3087 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3088 Add table name field. Add Tokenizer class with URL key common to
3089 the subclasses (DetailsPlace and ListPlace).
3090 * src/main/java/org/glom/web/client/place/ListPlace.java:
3091 Add table name. Add code to parse the URL token.
3092 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3093 Update ListPlace construction with empty table name string.
3094 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3095 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3096 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3097 Update ListPlace construction with table name string.
3098 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3099 Change defaultTableName field to tableName to reflect how it's now
3100 used. Update the getter and setter methods.
3102 2011-06-28 Ben Konrath <ben@bagu.org>
3104 Enable the table selector in the DetailsView.
3106 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3107 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3109 Remove getDefaultDetailsLayout(). The default layout is now returned
3110 by the getDetailsLayout() method when the table name is an empty
3112 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3113 event handler for table change event. Change to using
3114 getDetailsLayout() for the default details layout.
3115 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3117 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3118 when navigating to the details place.
3120 2011-06-27 Ben Konrath <ben@bagu.org>
3122 Use filename based unique document ID in URL and for RPC.
3124 The document ID is the glom document name with spaces (' ') replaced
3125 with pluses ('+') and without the .glom extension.
3127 This change is mostly a string substitution of 'documentTitle' for
3128 'documentID'. The only code change is the addition of a Documents DTO to get the
3129 filename to document title mappings as indicated below.
3131 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3132 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3134 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3135 Use Documents DTO to create the document links in the document
3137 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3139 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3140 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3141 * src/main/java/org/glom/web/client/place/ListPlace.java:
3142 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3143 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3144 * src/main/java/org/glom/web/client/ui/ListView.java:
3145 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3146 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3147 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3148 * src/main/java/org/glom/web/server/Log.java:
3149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3150 getDocumentTitles() to getDocuments() and return the Documents DTO.
3151 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3152 transferring the filename to document title mappings.
3154 2011-06-25 Ben Konrath <ben@bagu.org>
3156 Make the authentication popup work again.
3158 This bug was introduced when I extracted ConfiguredDocument to its own class.
3160 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3161 correct success / fail status in setUsernameAndPassword().
3163 2011-06-25 Ben Konrath <ben@bagu.org>
3165 Use filename as unique key for configuring database usernames and passwords.
3167 This replaces the use of the Glom document title which could change
3168 depending on the locale. Thanks to Murray Cumming for pointing out this
3171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3172 * src/main/resources/onlineglom.properties:
3174 2011-06-24 Ben Konrath <ben@bagu.org>
3176 Pass primary key value to DetailsView.
3178 This enables the DetailsView to load the correct data.
3180 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3181 primary key value field and set in constructor. Pass primary key
3182 value to getDetailsData().
3183 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3184 variables for document title and primary key value.
3185 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3186 key value to the DetailsPlace.
3188 2011-06-24 Ben Konrath <ben@bagu.org>
3190 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3192 This allows the primary key to be retrieved by the Details button. This
3193 functionality has not been implemented yet but it's in the works.
3195 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3196 the LayoutGroup result to ListView.setCellTable instead of all of its
3197 fields individually.
3198 * src/main/java/org/glom/web/client/ui/ListView.java:
3199 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3200 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3201 get the primary key for the table.
3202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3203 index of the primary key in the LayoutGroup accounting for hidden
3204 primary keys. Rename getJavaNumberFormat() to
3205 convertToJavaNumberFormat() for consistency. Cleanup / add some
3207 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3208 field for primary key index and a field to indicate whether the
3209 primary key is hidden or not.
3211 2011-06-23 Ben Konrath <ben@bagu.org>
3213 Rename getTableData methods to getListData.
3215 This is a rename refactor for consistency with other methods.
3217 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3218 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3222 2011-06-23 Ben Konrath <ben@bagu.org>
3224 Extract the ConfiguredDocument innerclass into its own class.
3226 This makes the servlet code more object oriented.
3228 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3229 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3230 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3231 new ConfiguredDocument class.
3233 2011-06-21 Ben Konrath <ben@bagu.org>
3235 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3237 This makes things more inline with how libglom works and reduces code
3238 duplication. This refactor lays the groundwork for adding the primary key to
3239 the LayoutGroup object.
3241 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3242 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3243 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3244 Change method names to getListLayout and getDefaultListLayout for
3245 consistency. Use LayoutGroup as the DTO for the list layout instead of
3246 ColumnInfo and LayoutListTable.
3247 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3248 new method names along with the LayoutGroup object for transferring the