1 2012-04-23 Murray Cumming <murrayc@murrayc.com>
3 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
5 * pom.xml: Depend on jooq.
6 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
7 methods with jOOQ, based on the C++ implementations in libglom,
8 with some changes to the logic required by jooQ.
9 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
11 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
12 * src/main/java/org/glom/web/server/ReportGenerator.java:
13 * src/main/java/org/glom/web/server/SqlUtils.java:
14 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
15 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
16 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
17 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
18 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
19 Adapt. In particular, the SqlUtils methods now need to take a Connection,
20 because jOOQ needs that, though it seems unnecessary.
22 This is not quite finished. Ideally jOOQ would help us to build
23 table_name.field_name names, quoting and escaping them properly.
24 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
26 2012-04-21 Murray Cumming <murrayc@murrayc.com>
28 Move use of Glom.build_sql*() into a new SqlUtils class.
30 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
31 to wrap Glom.build_sql*(). The parameter types are still Glom one,
32 but this will make it easier to start using something other than
33 libglom or SqlBuilder.
35 2012-04-21 Murray Cumming <murrayc@murrayc.com>
37 Update the project URL.
39 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
41 2012-04-21 Murray Cumming <murrayc@murrayc.com>
43 Main layout: Use a FlowTable instead of absolute positioning.
45 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
46 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
47 child panels/widgets must have an absolute position. But that is annoying, so
48 this adds a FlowTable and puts the child panels in there.
50 2012-04-21 Murray Cumming <murrayc@murrayc.com>
52 GwtTestOnlineGlom: Comment out unused code.
54 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
55 Eclipse has started to say that some code is unused.
57 2012-04-21 Murray Cumming <murrayc@murrayc.com>
59 Update to the latest versions of dependencies.
61 * pom.xml: Update version numbers of dependencies to the latest
63 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
64 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
65 * src/main/java/org/glom/web/server/ReportGenerator.java:
66 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
67 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
68 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
70 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
71 Modify the imports where necessary.
73 2012-04-17 Murray Cumming <murrayc@murrayc.com>
75 Style: Remove overflow:hidden from searchbox
77 * src/main/webapp/style.css: Because this pushes the Back To Link
78 label/link on to the next row, which is then hidden due to the
79 hard-coded (in ems) height.
81 2012-04-20 Murray Cumming <murrayc@murrayc.com>
83 Remove some duplicate code.
85 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
86 getDocumentInfo(): This must have been duplicated during the merge from the
91 2012-04-19 Murray Cumming <murrayc@murrayc.com>
93 Reports: Localize the waiting for report message.
95 * src/main/java/org/glom/web/client/activity/ReportActivity.java
96 start(): Get the message from the contants.
97 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
99 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
100 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
101 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
102 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
103 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
104 Update these files with the English text for newer strings for now.
106 2012-04-19 Murray Cumming <murrayc@murrayc.com>
108 Reports: Show a message while waiting for the report.
110 * src/main/java/org/glom/web/client/ui/ReportView.java
111 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
112 Add setWaitingText(), to show a message saying that we are
113 waiting for the report to be ready.
114 * src/main/java/org/glom/web/client/activity/ReportActivity.java
115 start(): Call setWaitingText() before calling the async
118 2012-04-19 Murray Cumming <murrayc@murrayc.com>
120 ReportGenerator: Specify date and time formats.
122 * src/main/java/org/glom/web/server/ReportGenerator.java:
123 createFieldValueElement(): Use the default (and localized)
124 short formats, though we still need a way to show 4-digit
125 years without providing the format for every locale.
126 * src/main/java/org/glom/web/server/database/DBAccess.java:
127 convertResultSetToDTO(): Use the short formats here too.
129 2012-04-18 Murray Cumming <murrayc@murrayc.com>
131 ReportGenerator: Use the correct numeric formatting.
133 * src/main/java/org/glom/web/server/ReportGenerator.java
134 createFieldExpression(), createFieldValueElement(): Take the
135 whole LayoutItem_Field instead of just the field name, so
136 we have access to the formatting.
137 createFieldValueElement(): Use JRTextField.setPattern() to
138 specify the numeric formatting, with the help of a
139 regular DecimalFormat.
141 2012-04-18 Murray Cumming <murrayc@murrayc.com>
143 ReportGenerator: Avoid showing null for group by titles.
145 * src/main/java/org/glom/web/server/ReportGenerator.java
146 generateReport(): Use setBlankWhenNull() on the field title
147 style too, because this is used for values in group by
150 2012-04-18 Murray Cumming <murrayc@murrayc.com>
152 ReportGenerator: Add a colon to titles in vertical groups.
154 * src/main/java/org/glom/web/server/ReportGenerator.java
155 addFieldToDetailBandVertical(): Pass true for the withColon
158 2012-04-18 Murray Cumming <murrayc@murrayc.com>
160 ReportGenerator: Simplify the code by using Position more.
162 2012-04-18 Murray Cumming <murrayc@murrayc.com>
164 Reports: Support vertical groups, roughly.
166 * src/main/java/org/glom/web/server/ReportGenerator.java:
167 addToReport(): Rename to addGroupToReport() and, if necessary,
168 call the new addVerticalGroupToReport() method.
169 createFieldValueElement(): Let the caller specify the Y position
172 2012-04-17 Murray Cumming <murrayc@murrayc.com>
174 Reports: Allow a second report to be shown.
176 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
177 clear(): Do not remove the HTML widget, which broke the whole layout.
179 2012-04-17 Murray Cumming <murrayc@murrayc.com>
181 Locales drop-down: Show that we use English by default.
183 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
184 fillView(): When we use English, just because that is the default, when
185 no locale is specified, show that in the Locales drop-down instead of
186 just showing the first item.
188 2012-04-17 Murray Cumming <murrayc@murrayc.com>
190 Unselect the Report/Locale/Table combo item when appropriate.
192 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
193 setPlace(): clear reportName if this is not a ReportPlace.
194 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
195 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
196 When the provided name is empty, unselect all items, so that none are
197 indicated. This uses a for loop because I cannot find a single method
200 2012-04-17 Murray Cumming <murrayc@murrayc.com>
202 Report: Give the user a way to get back to the list.
204 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
205 start(), setPlace(): Show the Back To List link on reports, and also
206 interpret selecting the empty report item as back to list.
208 2012-04-13 Murray Cumming <murrayc@murrayc.com>
210 Really show the selected Report name.
212 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
213 setPlace(): Store the reportName here, if it is that kind of Place.
214 fillView(): Set the selected Report after filling the list of reports.
215 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
216 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
217 null Strings, though we need some way to unselect all ListBox items
220 2012-04-13 Murray Cumming <murrayc@murrayc.com>
222 ReportGenerator: Try to avoid some problems.
224 * src/main/java/org/glom/web/server/ReportGenerator.java
225 addField(): Try to avoid duplicates, and avoid using a null
228 2012-04-13 Murray Cumming <murrayc@murrayc.com>
230 Reports: Use quickFind.
232 * src/main/java/org/glom/web/client/OnlineGlomService.java;
233 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
235 getReportHTML(): Add a quickFind parameter.
236 * src/main/java/org/glom/web/client/activity/ReportActivity.java
237 start(): Pass the quickFind parameter.
238 * src/main/java/org/glom/web/server/ReportGenerator.java
239 generateReport(): Take a quickFind parameter.
241 2012-04-13 Murray Cumming <murrayc@murrayc.com>
243 ReportPlace: Actually use the report name.
245 * src/main/java/org/glom/web/client/place/ReportPlace.java
246 getPlace(): Do not assign the report name to the quickfind.
248 2012-04-13 Murray Cumming <murrayc@murrayc.com>
250 Show java.library.path when complaining.
252 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
253 init(): When telling us to check java.library.path, show the
256 2012-03-06 Murray Cumming <murrayc@murrayc.com>
258 ReportGenerator: Do not show nulls.
260 2012-03-06 Murray Cumming <murrayc@murrayc.com>
262 ReportGenerator: Make the title font larger.
264 2012-03-06 Murray Cumming <murrayc@murrayc.com>
266 ReportGenerator: Put field titles inside groups, if there are groups.
268 2012-03-06 Murray Cumming <murrayc@murrayc.com>
270 ReportGenerator: Take the Report itself instead of the name and group.
272 * src/main/java/org/glom/web/server/ConfiguredDocument.java
273 Remove getReportLayoutGroup().
274 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
275 getReportHTML(): Pass the report instead
276 of its name and layout group.
277 * src/main/java/org/glom/web/server/ReportGenerator.java
278 generateReport(): Use the report object to use the title
281 2012-03-06 Murray Cumming <murrayc@murrayc.com>
283 ReportGenerator: Remove designBand parameters.
285 * src/main/java/org/glom/web/server/ReportGenerator.java:
286 Make designBand a class member instead of passing it to all
289 2012-03-06 Murray Cumming <murrayc@murrayc.com>
291 ReportGenerator: Add lines, a bit like in the desktop version.
293 * src/main/java/org/glom/web/server/ReportGenerator.java
294 addToReport(): Use JRDesignLine.
296 2012-03-06 Murray Cumming <murrayc@murrayc.com>
298 ReportGenerator: Correct the title positions and use some bold style.
300 * src/main/java/org/glom/web/server/ReportGenerator.java:
301 Break the code up into reusable functions, correct the placement of
302 titles, and use normal/bold styles as in the reports in the desktop
305 2012-03-06 Murray Cumming <murrayc@murrayc.com>
307 ReportGenerator: Add a header band to show the field titles.
309 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
310 getReportHTML(): Pass the localeId to the ReportGenerator
312 * src/main/java/org/glom/web/server/ReportGenerator.java
313 constructor: Take the localeID so we can get translated field
315 generateReport(), addToReport(), addFieldToBand(): Add field
316 titles in a column header band.
318 2012-03-05 Murray Cumming <murrayc@murrayc.com>
320 Reports drop-down list: Some improvement.
322 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
323 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
324 Adedd setSelectedReport(),
325 setReportList(): Add a blank line so that the user can select the
327 * src/main/java/org/glom/web/client/activity/ReportActivity.java
328 start(): Show the current report by calling setSelectedReport().
329 This does not seem to work yet.
331 2012-03-05 Murray Cumming <murrayc@murrayc.com>
333 DetailsActivity, ListActivity: Move some variables into a base class.
335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
336 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
337 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
338 the clientFactory, documentID, tableName and authenticationPopup into
339 a base class, to avoid duplication.
341 2012-03-05 Murray Cumming <murrayc@murrayc.com>
343 Translate the Reports label.
345 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
346 Get the "Reports" label string from the constants.
347 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
348 perties: Add Reports to the constants.
350 2012-03-05 Murray Cumming <murrayc@murrayc.com>
352 Reports: Implement grouping.
354 * src/main/java/org/glom/web/server/ReportGenerator.java:
355 Handle LayoutItem_GroupBy items and try to do the right thing
356 with JRDesignGroup. It seems to work.
358 2012-03-04 Murray Cumming <murrayc@murrayc.com>
360 Actually show some data with JasperReports.
362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
363 getReportHTML(): Move most code into a ReportGenerator class.
364 * src/main/java/org/glom/web/server/ReportGenerator.java:
365 Recurse into sub-groups, adding fields to the JasperDesign's details
366 band. Note that we must set an arbitrary width and height, or it just
367 will not show any data.
369 2012-03-04 Murray Cumming <murrayc@murrayc.com>
371 Reports Chooser: Show the titles, not the names.
373 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
374 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
375 and the names as the values.
376 * src/main/java/org/glom/web/server/ConfiguredDocument.java
377 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
378 group now that we provide the report name, so it should always
381 2012-02-15 Murray Cumming <murrayc@murrayc.com>
383 Depend on jasperreports.
385 * pom.xml: Add the dependency. My plan is to use this on the
388 2012-01-31 Murray Cumming <murrayc@murrayc.com>
390 Implement navigation to report places.
392 * src/main/java/org/glom/web/client/activity/ReportActivity.java
393 start(): Do not bother to handle all events here.
394 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
395 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
396 Added getSelectedReport().
397 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
398 .java: start(): When handling a change to the reports chooser,
399 call getSelectedReport() and goTo() its ReportPlace.
400 * src/main/java/org/glom/web/client/ui/ReportView.java
401 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
402 Added setReportHTML() which puts the html in a gwt HTML widget.
403 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
404 getReportHTML(): Return "TODO" just to show that this works.
406 2012-01-31 Murray Cumming <murrayc@murrayc.com>
408 Make ReportPlace usable.
410 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
412 * src/main/java/org/glom/web/client/place/ReportPlace.java:
413 Correct the @prefix annotation.
415 2012-01-31 Murray Cumming <murrayc@murrayc.com>
417 OnlineGlomService: Return report HTML rather than the LayoutGroup.
419 * src/main/java/org/glom/web/client/OnlineGlomService.java:
420 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
421 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
422 Change getReportLayout() to getReportHMTL() because we will not need to
423 parse or render the report layout on the client side.
424 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
425 getReportLayout(): Return the libglom LayoutGroup type because we will
426 not need to convert to a shared type, because this will not be used on
428 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
431 Note that there is still no implementation for this.
434 2012-01-27 Murray Cumming <murrayc@murrayc.com>
436 Add a (empty) Report Place, View, and Activity.
438 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
440 * src/main/java/org/glom/web/client/place/HasTablePlace.java
441 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
442 this into a superclass:
443 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
444 and also use it as the base of this new ReportPlace:
445 * src/main/java/org/glom/web/client/place/ReportPlace.java
447 * src/main/java/org/glom/web/client/ui/ReportView.java
448 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
449 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
450 Add these, containing mostly boiler-plate for now.
452 * src/main/java/org/glom/web/client/OnlineGlomService.java
453 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
454 * src/main/java/org/glom/web/server/ConfiguredDocument.java
455 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
456 Add API to get the LayoutGroup for the report.
458 2012-01-23 Murray Cumming <murrayc@murrayc.com>
460 Add and fill a Reports drop-down list box.
462 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
464 * src/main/java/org/glom/web/client/OnlineGlomService.java:
465 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
467 Added getReports(document, table, localeID), calling
468 ConfiguredDocument.getReports().
469 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
470 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
471 Added setReportsList() and a list widget.
472 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
473 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
478 2012-04-12 Murray Cumming <murrayc@murrayc.com>
480 Translations: Add Esperanto.
482 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
483 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
484 properties: Add this translation because someone took the time to make it.
486 2012-03-15 Murray Cumming <murrayc@murrayc.com>
488 Adapt to the java-libglom 1.21.7 API.
490 * src/main/java/org/glom/web/server/ReportGenerator.java:
491 addToReport(): get_group_secondary_fields() is now
492 get_secondary_fields().
495 2012-03-15 Murray Cumming <murrayc@murrayc.com>
497 Use the latest java-libglom version.
499 * pom.xml: Use java-libglom 1.21.7.
501 2012-03-03 Ben Konrath <ben@bagu.org>
503 Display date and time in details view.
505 https://bugzilla.gnome.org/show_bug.cgi?id=671257
507 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
509 2012-03-05 Murray Cumming <murrayc@murrayc.com>
511 Require the latest java-libglom.
513 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
515 2012-03-04 Murray Cumming <murrayc@murrayc.com>
517 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
519 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
520 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
521 an empty quickfind string. I also corrected libglom to create only
522 empty where clauses for empty quickfind strings, but this avoids the
525 2012-02-24 Ben Konrath <ben@bagu.org>
527 Improve the tabs in the Notebook widget.
531 2012-01-30 Murray Cumming <murrayc@murrayc.com>
533 Translations: Try to translate the strings.
535 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
536 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
537 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
538 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
539 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
540 Take the Open translation from GTK+'s .po files.
541 Take the Details translation from Glom's po files.
542 I have added the other strings to Glom so we can get translations that way:
543 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
545 2012-01-27 Murray Cumming <murrayc@murrayc.com>
547 TableSelectionViewImpl: Put the search label and entry in a div.
549 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
550 Put the search widgets in a FlowTable so that the CSS can be used to
551 style them while keeping them together.
552 * src/main/webapp/style.css: Mention the new div.
554 2012-01-27 Murray Cumming <murrayc@murrayc.com>
556 Translate more strings in more locales.
558 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
559 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
560 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
561 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
562 Translate the "Details" and "Open" string too.
564 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
565 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
566 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
567 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
568 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
569 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
570 Add these new locales as placeholders though they currently contain English.
572 2012-01-27 Murray Cumming <murrayc@murrayc.com>
574 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
576 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
577 Check the ConfiguredDocument* for null before using it.
579 2012-01-26 Murray Cumming <murrayc@murrayc.com>
581 Tell Eclipse about the generated java files.
583 * .classpath: This lets it find OnlineGlomConstants.java.
584 It would be nice if Eclipse just used the maven build files.
586 2012-01-26 Murray Cumming <murrayc@murrayc.com>
588 Prevent a crash when no locale is specified in the URL.
590 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
591 Avoid returning a null string, obtained from
592 Window.Location.getParameter(). This caused a crash when it was
593 later passed to libglom's API.
594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
595 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
596 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
597 guard against future null strings.
599 2012-01-26 Murray Cumming <murrayc@murrayc.com>
601 Use the ?locale= query param instead of the &lang= token param.
603 * src/main/java/org/glom/web/client/place/ListPlace.java
604 * src/main/java/org/glom/web/client/place/DetailsPlace.java
605 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
606 Remove the lang token key and value.
608 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
609 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
610 When the user selects a different locale from the chooser, use
611 Window.Location.assign() to change the URL, which then causes a reload.
613 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
614 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
615 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
616 * src/main/java/org/glom/web/client/activity/ListActivity.java
617 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
618 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
619 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
620 * src/main/java/org/glom/web/client/ui/ListView.java:
621 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
623 Remove localeID member variables and method/constructor parameters, instead
624 using Utils.getCurrentLocaleID() when we need a localID to pass to
627 2012-01-26 Murray Cumming <murrayc@murrayc.com>
629 Internationalize the UI strings.
631 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
632 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
633 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
634 because it is unused. Messages are apparently strings that can have
635 parameters, but we do not need that yet, so Contants will be enough for now.
636 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
637 to say that we support the en and de locales.
638 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
639 The original English strings.
640 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
641 Some German translations of the English strings.
642 The i18n goal then uses the .properties file to generate an
643 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
644 returns an implementation that returns the translated strings.
645 The documentation suggests putting these in src/java/*/client/, but it seems
646 best to put it in src/resources/*/client/.
647 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
648 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
649 instead of hard-coding them.
650 Note that we cannot import OnlineGlomConstants because it does not exist yet,
651 but that does not seem to stop the build, though it confuses Eclipse.
653 You can see the translated string by adding ?locale=de to the URL, like so:
654 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
656 2012-01-24 Murray Cumming <murrayc@murrayc.com>
658 Improve null/empty String checks.
660 * pom.xml: Add a dependency on commons-lang, to use
661 org.apache.commons.lang.StringUtils.
662 * src/main/java/org/glom/web/server/ConfiguredDocument.java
663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
664 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
665 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
666 Use StringUtils.isEmpty().
668 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
669 StringUtils class with a static isEmpty() function because we
670 cannot use org.apache.commons.lang.StringUtils in client-side
671 GWT code because it (apparently) cannot be compiled to javascript.
672 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
673 * src/main/java/org/glom/web/client/activity/ListActivity.java
674 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
675 * src/main/java/org/glom/web/client/place/DetailsPlace.java
676 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
677 * src/main/java/org/glom/web/client/place/ListPlace.java
678 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
679 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
680 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
681 * src/main/java/org/glom/web/client/ui/details/Group.java
682 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
683 our StringUtils.isEmpty() function.
685 2012-01-24 Murray Cumming <murrayc@murrayc.com>
687 Update to the latest java-libglom API.
689 * pom.xml: Require java-libglom 1.21.4.
690 * src/main/java/org/glom/web/server/ConfiguredDocument.java
691 getDocumentInfo(), getListViewLayoutGroup():
692 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
694 * src/main/java/org/glom/web/server/database/DBAccess.java
695 getFieldsToShowForSQLQueryAddGroup(),
696 getPrimaryKeyLayoutItemField(): Replace get_database_title()
697 with either get_database_title_original() or
698 get_database_title(localeID).
700 2012-01-24 Murray Cumming <murrayc@murrayc.com>
702 ConfiguredDocument: Avoid a null pointer exception.
704 * src/main/java/org/glom/web/server/ConfiguredDocument.java
705 Initialize localeID to "" to avoid returning a null String which
706 causes a crash in java-libglom's swing-generated code.
708 2012-01-23 Murray Cumming <murrayc@murrayc.com>
710 Some simple renaming.
712 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
713 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
714 for localeChooser. This seems more appropriate and is less ambiguous
715 particularly in the .css file.
717 2012-01-23 Murray Cumming <murrayc@murrayc.com>
719 ConfiguredDocument: Rename the localedID private member variable.
721 2012-01-23 Murray Cumming <murrayc@murrayc.com>
723 Adapt to the latest java-libglom API from git master.
725 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
726 libglom now uses only Vector instead of List, which uses add() instead of
729 2012-01-22 Murray Cumming <murrayc@murrayc.com>
731 ConfiguredDocument: Rename the localedID private member variable.
733 2012-01-20 Murray Cumming <murrayc@murrayc.com>
735 Build a source tarball with mvn assembly:single
737 * assembly.xml: Add this file.
738 * pom.xml: Use the maven-assembly-plugin and tell it to use
739 our assembly.xml file.
741 2012-01-19 Murray Cumming <murrayc@murrayc.com>
743 OnlineGlomServiceImpl: Get .glom files recursively.
745 * pom.xml: Depend on commons-io from org.apache.commons.
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
747 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
748 files recursively, and with the easier filter for the extension.
749 Use org.apache.commons.io.FilenameUtils.removeExtension() to
750 simplify that code too.
752 2012-01-19 Murray Cumming <murrayc@murrayc.com>
754 README: Mention that you must install java-libglom packages separately.
756 But then it works, because java-libglom is now in the central maven
759 2012-01-18 Murray Cumming <murrayc@murrayc.com>
761 locales drop-down: Show the correct selected locale when the URL changes.
763 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
764 .java: setPlace(): Move some code into fillView().
766 2012-01-18 Murray Cumming <murrayc@murrayc.com>
768 locales drop-down: Do not lose the primary key.
770 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
771 start(): onLocaleChange(): Pass the current primary key value,
772 instead of an empty value.
774 2012-01-18 Murray Cumming <murrayc@murrayc.com>
776 locales drop-down: Do not lose the drop-down selection.
778 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
779 .java (TableSelectionActivity.fillView): Set the selected locale
780 after changing the drop-down items (though we do not really need
781 to change them just because the locale changes.)
783 2012-01-18 Murray Cumming <murrayc@murrayc.com>
785 locales drop-down: Change the tables list when this changes.
787 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
788 .java: TableSelectionActivity.start(): Move the async table titles
789 retrieval into a private fillView() method and also call this when
790 the chosen locale changes.
791 Note that the document title is not actually translatable yet, but
792 that is a problem that I should fix soon in libglom.
794 2012-01-18 Murray Cumming <murrayc@murrayc.com>
796 Improve the placement of the locales drop-down.
798 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
799 Put the title and locales drop-down in a div (gwt.FlowTable).
800 * src/main/webapp/style.css: Add magic css properties to make this work.
801 Also remove the left margin from the title so that it lines up with the
804 2012-01-18 Murray Cumming <murrayc@murrayc.com>
806 locales selector: Show human-readable locale titles.
808 * src/main/java/org/glom/web/server/ConfiguredDocument.java
809 getDocumentInfo(): Use java.util.Locale to show a real title of
810 each locale, in the locale's own language.
812 2012-01-17 Murray Cumming <murrayc@murrayc.com>
814 Add a language/locale selector drop-down.
816 * src/main/java/org/glom/web/shared/DocumentInfo.java:
817 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
818 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
819 getDocumentInfo(): Store the available Locales in the DocumentInfo.
820 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
821 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
822 Add a ListBox to show the available locales. Add getLocaleSelector(),
823 setLocaleList(), getSelectedLocale(), setSelectedLocale().
824 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
825 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
826 java: Add these classes.
827 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
828 start(): Fill the locales ListBox. Handle its change event, firing a
830 setPlace(): Show the selected locale as specified by the URL token.
831 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
832 * src/main/java/org/glom/web/client/activity/ListActivity.java:
833 Handle LocaleChangeEvent, going to a new *Place with that locale.
835 The placement of the ListBox is not pretty, and it currently uses the ID
836 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
840 2012-01-17 Murray Cumming <murrayc@murrayc.com>
842 Search box: Show the search text from the URL token.
844 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
845 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
846 Add setQuickFindText().
847 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
848 .java: setPlace(): Store the queryText if the place is a ListPlace,
849 and call TableSelectionView.setQuickFindText().
851 2012-01-17 Murray Cumming <murrayc@murrayc.com>
853 Allow use of translations via, for instance, &lang=de in the URL.
855 * pom.xml: Use the unstable java-libglom 1.21 version.
857 * src/main/java/org/glom/web/client/OnlineGlomService.java:
858 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
860 init(): Instead of calling TranslatableItem.set_current_locale()
861 (now removed), call ConfiguredDocument.setDefaultLocaleID().
862 However, this is only for default locales, which are not needed to
863 change the locale in the URL.
864 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
865 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
866 getSortedRelatedListData(): Add a localeID parameter, so we can get the
867 layout for a particular locale.
868 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
869 Add get/setDefaultLocaleID().
870 getDocumentInfo(), getListViewData(), getRelatedListData(),
871 getDetailsLayoutGroup(), getListViewLayoutGroup(),
872 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
873 localeID parameter, so we can get the layout for a particular locale.
875 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
876 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
877 * src/main/java/org/glom/web/client/place/ListPlace.java:
878 Parse and construct a lang parameter too.
880 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
881 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
882 passed to subsequent methods and constructors.
883 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
884 * src/main/java/org/glom/web/client/activity/ListActivity.java:
885 Store the localeID from the *Place and pass it to other constructors
886 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
888 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
889 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
890 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
891 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
892 * src/main/java/org/glom/web/client/ui/ListView.java:
893 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
894 Take localeID parameters and pass them to subsequent constructors and
895 methods, so that the layout is always retrieved for that locale.
897 This is rather repetitive.
899 Note that "" means the original (default) locale of the Glom document,
900 which is usually English.
902 2012-01-17 Murray Cumming <murrayc@murrayc.com>
904 Documents: Remove final keyword to fix startup configuration.
906 * src/main/java/org/glom/web/shared/Documents.java: Remove the
907 final keywords on the private member variables because that breaks
908 the startup, apparently (there are warnings) because it stops them
909 from being serialized. I added these in the previous commit.
911 2012-01-13 Murray Cumming <murrayc@murrayc.com>
913 Documents: Add some final keywords.
915 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
918 2012-01-13 Murray Cumming <murrayc@murrayc.com>
920 OnlineGlomServiceImpl: Add to overview comments.
922 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
923 Note that this is where all the document are loaded. They are not
924 loaded freshly for each page.
926 2012-01-12 Murray Cumming <murrayc@murrayc.com>
930 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
931 Add a TextBox for the text of a quick find.
932 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
934 setBackLink(): Add a String quickFind parameter.
935 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
936 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
937 to the base interface, because that is how TableSelectionViewImpl is used.
938 * src/main/webapp/style.css: Add style for the search box and its label.
940 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
941 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
942 Add these files, based on the existing TableChangeEvent and
943 TableChangeEventHandlers.
944 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
945 start(): Handle QuickFindChangeEvent, passing its quickFind text to
946 a ListPlace() that the user should be taken to.
947 * src/main/java/org/glom/web/client/activity/ListActivity.java
948 start(): Handle it here too and adapt the TableChangeEvent handler to
949 pass the extra "" quickFind parameter to ListPlace.
950 * src/main/java/org/glom/web/client/place/ListPlace.java:
951 Constructor: Take an extra String quickFind parameter and store it,
952 returning it from a new getQuickFind() method.
953 getToken(): Put the quickFind text in the URL token.
954 getPlace(): Parse the quickFind text from the URL token.
955 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
956 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
957 ListPlace constructor.
958 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
959 .java: start(): Add a Change handler for the TableSelectionView's
960 TextBox (via its base HasChangeHandlers interface), firing the new
961 QuickFindChangeEvent.
962 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
963 pass the extra "" quickFind parameter.
965 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
966 setCellTable(): Add a String quickFind parameter and pass it to
967 the ListViewTable() constructor.
968 * src/main/java/org/glom/web/client/ui/ListView.java: Change
969 setCellTable() in the base interface, because that is how ListViewImpl
972 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
973 Add a String quickFind member variable.
974 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
975 Constructor: Add a String quickFind parameter, storing it in the
976 base ListTable's member variable.
977 onRangeChanged(): Pass quickFind to the
978 OnlineGlomServiceAsync.getSortedListViewData() and
979 OnlineGlomServiceAsync.getListViewData() methods.
981 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
982 getListViewData(), getSortedListViewData(): Add a String quickFind
983 parameter, passing it to ConfiguredDocument.getListViewData().
984 * src/main/java/org/glom/web/client/OnlineGlomService.java:
985 Change getListViewData(), getSortedListViewData() in the base interface,
986 because that is how OnlineGlomServiceImpl is used, via this:
987 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
988 Change getListViewData(), getSortedListViewData() here too.
989 This class can apparently be used to asynchronously call methods on
990 OnlineGlomService, and GWT seems to implement that after recognizing
991 just the *Async name convention and the extra AsyncCallback parameters.
993 * src/main/java/org/glom/web/server/ConfiguredDocument.java
994 getListViewData(): Add a String quickFind parameter, and pass it to
995 ListViewDBAccess.getData().
996 * src/main/java/org/glom/web/server/database/ListDBAccess.java
997 getListData(): Add a String quickFind parameter and pass it to
999 getSelectQuery(): Add a String quickFind parameter.
1000 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1001 getSelectQuery(): Add a String quickFind parameter and use it with
1002 Glom.get_find_where_clause_quick() to pass a where_clause to
1003 Glom.build_sql_select_with_where_clause(), to actually filter the
1005 getData(): Add a String quickFind parameter, passing it to getListData().
1006 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1007 va: getData(): Pass an empty string to getListData() for the
1008 quickFind parameter.
1010 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1012 ListTable: Minor change.
1014 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1015 createCellTable(): Make this protected instead of public.
1017 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1019 Many files: Use final for the parameters and use the @override attribute.
1021 2012-01-22 Ben Konrath <ben@bagu.org>
1023 Add anchor links for single line text that starts with http, ftp and www.
1027 2012-01-22 Ben Konrath <ben@bagu.org>
1029 Add ellipsis to single line text in details view.
1033 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1035 Remove all javadoc author tags.
1037 Because they are awkward and meaningless when many people touch
1039 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1041 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1043 Revert the COPYING.LESSER to COPYING rename.
1045 Apparently both should be there if it is LGPL.
1047 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1049 *View: Remove unused imports.
1051 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1052 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1053 * src/main/java/org/glom/web/client/ui/ListView.java:
1054 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1055 Remove unused imports, as suggested by Eclipse.
1057 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1059 Move the *View::Presenter types, and some API into one base View.
1061 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1062 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1063 * src/main/java/org/glom/web/client/ui/ListView.java:
1064 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1065 Presenter, setPresenter() and clear() into a shared base interface,
1066 to avoid the unnecessary duplicate Presenter types and to more clearly
1067 show how the *Views share the same structure, even if they are not
1068 used polymorphically.
1070 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1071 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1074 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1075 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1077 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1080 Feel free to revert this if there is a good reason for the duplicate
1083 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1085 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1087 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1088 a class member instead of a local variable in the method.
1089 This lets us use it to get the view instances, for use in tests.
1090 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1091 beforeOnlineGlom(): Test some more details of the initial view.
1092 Again, this is not very useful.
1094 To really test gwt-glom we will need to start a local postgresql
1095 instance with local data, like the Glom tests in C++.
1097 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1099 pom.xml: Mention the LGPL license.
1101 * pom.xml: Add a licenses section.
1102 * COPYING.LESSER: Move this to COPYING, which
1103 previously contained the GPL. But gwt-glom is all LGPL.
1105 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1107 Add project information to README and pom.xml.
1109 * README: Add a brief description and mention some mvn
1111 * pom.xml: This extra information shows up in mvn site
1114 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1116 Use the latest java-libglom version.
1118 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1120 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1122 GwtTestOnlineGlom: Test a little more.
1124 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1125 protected rather than private, as suggested by the gwt-test-utils
1127 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1128 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1129 Test the initial visibility of the panels.
1131 However, this is not a very useful test.
1132 And I wonder how we should generally test using this idea for an
1133 activity/places app like ours where the real changes happen implicitly
1134 based on the history token/URL.
1136 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1138 Slight modification to *Mapper comments.
1140 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1141 (DataActivityMapper)
1142 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1144 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1146 Remove comments mentioning GIN because they are just copied from
1147 the example code and are apparently not helpful:
1148 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1149 Also change the mention of a class that is only in the example code.
1151 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1153 GwtTestOnlineGlom test: Minor changes.
1155 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1156 Avoid the long qualified class name and modify the comment
1157 because it is now obvious to me that the mocked class is the only
1158 custom one created via GWT.create().
1160 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1162 Tests: Added the beginnings of a test using gwt-test-utils.
1164 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1165 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1166 which tells gwt-test-utils what class will be tested.
1167 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1168 Add a simple (but empty) test case. One class, used by the OnlineGlom
1169 class, is mocked so that it can be created. However, I am not sure
1170 why only this class needs to be mocked.
1172 Note that mockito seems more popular, and clearer, than easymock,
1173 but I have not got that working yet. It might be a matter of the
1176 This test is run during mvn integration-test.
1178 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1180 Tests: Use junit4-style syntax instead of junit3-style.
1182 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1183 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1184 * src/test/java/org/glom/web/shared/DataItemTest.java:
1185 Use the @Test annotation rather than relying on the test*() prefix.
1186 Also no longer implement TestCase, to avoid triggering support for
1187 the junit3-way, which stops the annotations from working.
1188 Change the imports from import junit.framework.* to
1189 import org.junit.*, which is apparently the new way.
1191 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1193 Added a test for ListPlace token parsing and creation.
1195 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1196 This is much the same as DetailsPlaceTest.
1198 I wonder how we could test the other parts of the *Place API.
1200 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1202 DetailsPlace test: Also test getToken() and recreation via getPlace().
1204 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1205 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1206 recreate it, testing the recreated DetailsPlace for the same parameter
1209 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1211 Use the surefire-report plugin.
1213 * pom.xml: This generates a HTML report about the tests in
1214 target/site/surefire-report.html
1215 when you do mvn surefire-report:report. It seems to be popular/normal.
1217 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1219 Added a test for DetailsPlace.
1221 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1222 Test the getPlace() token parsing.
1224 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1226 Added a first unit test.
1228 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1229 * src/test/java/org/glom/web/shared/DataItemTest.java:
1230 This is a silly test but it is just to get things started. Note that
1231 maven/junit finds the test because it looks in src/test by default.
1233 2011-12-22 Ben Konrath <ben@bagu.org>
1235 Change charsetName to "UTF-8" when replacing line breaks.
1237 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1238 that work in Java (such as "UTF8") will not work when compiled to
1241 This fixes a problem with multi-line details view fields that have hard
1242 line breaks. The "License Text" field on this page demonstrates the
1245 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1247 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1249 2011-12-22 Ben Konrath <ben@bagu.org>
1251 Fix another bug with related list navigation.
1253 I've tested all the navigation buttons in all of the related lists
1254 so things should be good now.
1256 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1258 2011-12-22 Ben Konrath <ben@bagu.org>
1260 Fix a crasher when refreshing the list view with the default table.
1262 This crash will also happen when loading the list view with the default
1263 table from a link or bookmark.
1265 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1266 to the main document selection page when the document id hasn't been
1268 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1269 the main document selection page when the document id hasn't been
1271 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1272 values for the details place when the document id hasn't been set.
1273 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1274 values for the list place when the document id hasn't been set.
1276 2011-12-21 Ben Konrath <ben@bagu.org>
1278 Protect against NPE when glom.document.locale is not in config.
1280 This patch protects against an NPE when glom.document.locale is not in
1281 the config file. This NPE will also happen if glom.document.locale is
1284 The patch also updates the error message to display the class name when
1285 the getMessage() returns null. This was happening when the NPE was
1286 thrown and I had "Configuration Error: null". If an NPE is encountered
1287 with this patch, "Configuration Error: NullPointerException " will be
1290 This commit closes this bug:
1292 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1294 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1296 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1298 Rename onlineglom.properties to onlineglom.properties.sample.
1300 * src/main/resources/onlineglom.properties: Rename to:
1301 * src/main/resources/onlineglom.properties.sample:
1302 * src/main/resources/README: And add this file explaining that people
1303 should rename it back when deploying.
1305 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1307 Allow choosing the translation in the .properties file.
1309 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1310 init(): Read a glom.document.locale value from the configuration file
1311 and call Glom's TransatableItem::set_current_locale() method.
1312 * src/main/resources/onlineglom.properties: Add a commented-out
1313 example of this new setting.
1315 It would be better to add &lang=de_DE to the URL, but the current
1316 libglom API does not allow us to do this easily. I am working on that.
1318 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1320 Avoid a crash in parsing of token parameters.
1322 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1323 ava: getTokenParams(): Do not crash if a parameter has a key but no
1324 value, and ignore parameters with neither.
1326 2011-12-17 Murray Cumming <murrayc@murayc.com>
1328 History token building/handling: Improve use of token parameters.
1330 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1331 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1332 and buildParamsToken(HashMap), for use by derived classes.
1333 Make the separator private because it is no longer be needed.
1334 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1335 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1336 instead of manual string concatenation.
1337 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1338 of hardcoded indices and awkward splitting code.
1339 * src/main/java/org/glom/web/client/place/ListPlace.java
1340 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1341 instead of manual string concatenation.
1342 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1343 of hardcoded indices and awkward splitting code.
1344 This should fix bug #666420
1346 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1348 Fix a Navgiation->Navigation typo in the code.
1350 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1351 Rename processNavgiation() to processNavigation().
1353 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1355 Fix a seperator->separator typo in the code.
1357 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1358 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1359 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1362 2011-12-15 Ben Konrath <ben@bagu.org>
1364 Cleanup some comments.
1366 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1368 2011-12-14 Ben Konrath <ben@bagu.org>
1370 Replace \n with <br/> for multiline text in the details view.
1372 Vertical scrollbars are added when needed as well.
1374 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1376 2011-12-14 Ben Konrath <ben@bagu.org>
1378 Specify the font for document selection links.
1380 * src/main/webapp/style.css:
1382 2011-12-14 Ben Konrath <ben@bagu.org>
1384 Fix bouncy CellTable while paging.
1386 This doesn't currently work with related list tables in unselected
1389 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1391 2011-12-14 Ben Konrath <ben@bagu.org>
1393 Revamp the appearance of the document selection page.
1395 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1396 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1397 * src/main/webapp/style.css:
1399 2011-12-13 Ben Konrath <ben@bagu.org>
1401 Set navigation button column to the smallest size possible.
1403 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1405 2011-12-13 Ben Konrath <ben@bagu.org>
1407 Change OpenButton nomenclature to NavigationButton.
1409 Using NavigtionButton makes things more generic. Classes, methods and
1410 variables have been changed.
1412 This is a rename-only refactor.
1414 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1415 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1416 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1417 Renamed from OpenButtonCell.
1418 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1419 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1422 2011-12-12 Ben Konrath <ben@bagu.org>
1424 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1426 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1427 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1428 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1429 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1431 2011-12-12 Ben Konrath <ben@bagu.org>
1433 Update variable names and comments.
1435 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1436 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1438 2011-12-12 Ben Konrath <ben@bagu.org>
1440 Properly initialize numNonEmptyRows variable to zero.
1442 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1443 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1445 2011-12-05 Ben Konrath <ben@bagu.org>
1447 Add latest mockup with HTML tables.
1449 Features of this mockup:
1451 -> HTML table for flowtable
1452 -> HTML table for flowtable column
1453 -> Example of how related lists would look
1454 -> Not using text entries for data items
1456 The current version of Online Glom doesn't use HTML tables for the
1459 This mockup has been sent to the glom-devel mailing list but it's good
1460 to have it here as well.
1462 * mockups/details-view-html-tables.html:
1464 2011-12-05 Ben Konrath <ben@bagu.org>
1466 Remove unnecessary getPrimaryKeyField() method.
1468 getPrimaryKeyFieldForTable(String) has been renamed to
1469 getPrimaryKeyField(String).
1471 * src/main/java/org/glom/web/server/database/DBAccess.java:
1472 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1473 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1475 2011-12-05 Ben Konrath <ben@bagu.org>
1477 Add string representation of TypedDataItem value to conversion error message.
1479 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1480 message was extracted into its own method to avoid duplication.
1482 2011-12-05 Ben Konrath <ben@bagu.org>
1484 Add type checking to navigation primary key value creation.
1486 Create navigation primary key only if the expected type from the Glom
1487 document matches the type returned by the SQL query.
1489 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1491 2011-12-05 Ben Konrath <ben@bagu.org>
1493 Rename a couple of variables in RelatedListNavigation.
1495 This is a rename-only refactor.
1497 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1499 2011-12-05 Ben Konrath <ben@bagu.org>
1501 Move getListLayoutGroup() into getListViewLayoutGroup().
1503 This removes getListLayoutGroup(). It was only being called by
1504 getListViewLayoutGroup().
1506 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1508 2011-12-05 Ben Konrath <ben@bagu.org>
1510 Remove check for LayoutItem_Portal in list table method.
1512 This check is no longer necessary because the method isn't being used
1513 to create the LayoutItemPortal DTO.
1515 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1517 2011-12-05 Ben Konrath <ben@bagu.org>
1519 Properly support related list navigation.
1521 Navigation from the "Repository Analyzer -> Package Scans ->
1522 Dependencies" related table wasn't working because the primary key for
1523 related tables wasn't being set properly. This commit fixes the
1526 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1527 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1528 doesn't set the primary key properly for related list tables.
1529 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1530 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1531 useful for getting the primary key for list view tables and for related
1533 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1534 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1535 Move code to set the primary key for the table from the abstract
1536 ListDBAccess class to ListViewDBAccess as it's only correct for list
1538 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1539 Properly add primary key to related list tables.
1541 2011-12-02 Ben Konrath <ben@bagu.org>
1543 Properly set the horizontal alignment of fields.
1545 This fix is for both the list tables and the details view.
1547 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1548 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1549 to set the horizontal alignment of fields.
1551 2011-12-02 Ben Konrath <ben@bagu.org>
1553 Display currency codes in the details view.
1555 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1557 2011-12-02 Ben Konrath <ben@bagu.org>
1559 Avoid duplicate JNI call.
1561 JNI is not as efficient as pure Java and this is an easy (and small)
1564 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1565 Use previously retrieved value for whereClauseToTableName instead of
1568 2011-12-02 Ben Konrath <ben@bagu.org>
1570 Rename a couple of variables in RelatedListNavigation.
1572 This is a rename-only refactor.
1574 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1576 2011-12-02 Ben Konrath <ben@bagu.org>
1578 Indicate clearly that a mismatched primary key type is a bug.
1580 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1581 warning to error. Add 'This is a bug.' to message.
1583 2011-12-02 Ben Konrath <ben@bagu.org>
1585 Update / fix some comments.
1587 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1589 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1591 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1592 Fix comments. Add some TODOs.
1594 2011-12-02 Ben Konrath <ben@bagu.org>
1596 Enable navigation to details view with string primary key from related list.
1598 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1599 Create a text primary key value when return type of result is
1600 java.sql.Types.VARCHAR.
1602 2011-12-02 Ben Konrath <ben@bagu.org>
1604 Use checkboxes for booleans in the details view.
1606 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1608 2011-12-01 Ben Konrath <ben@bagu.org>
1610 Improve performance of related list height calculation.
1612 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1613 Put code to calculate the expected height in a static initializer so
1614 that that it's only called once.
1616 2011-12-01 Ben Konrath <ben@bagu.org>
1618 Show related list tables in notebooks (again).
1620 Calculate the height of the related list tables so the Notebook can be
1621 set the correct height. The height of the related list table is also needed by
1622 FlowTable to be able decide how to create the layout.
1624 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1625 and set the Portal height based on the height of the related list
1626 table and the Portal container.
1627 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1628 Add method to calculate the height of the related list tables.
1629 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1630 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1631 calculate the height of the Pager widget.
1633 2011-12-01 Ben Konrath <ben@bagu.org>
1635 Use CellTable API for table property instead of setting style on Element.
1637 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1639 2011-12-01 Ben Konrath <ben@bagu.org>
1641 Make ListViewTable and RelatedListTable a consistent height.
1643 The tables are now a consistent height regardless of the contents of
1644 the table. A hidden button is added to empty rows to ensure that the
1645 height of these rows will match the height of rows with data.
1647 A navigation button column is now added to every table. The width of
1648 the navigation column is set to 0px when a RelatedListTable shouldn't
1649 have navigation buttons. This maintains the a consistent row height in
1650 tables that don't show the navigation buttons.
1652 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1653 navigation column when not needed.
1654 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1655 arguments for navigation button to constructor of ListViewTable.
1656 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1657 hidden button for empty data rows.
1658 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1659 arguments for navigation button to constructor.
1660 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1661 create navigation buttons. Add hideNavigationButtons() method.
1662 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1663 arguments for navigation button to constructor.
1665 2011-12-01 Ben Konrath <ben@bagu.org>
1667 Use 'visibility: hidden' in Utils.getWidgetHeight().
1669 This is better choice because hidden elements are invisible, don't
1670 respond to events and are not part of the tab order. They will,
1671 however, take up space which is required to be able to calculate the
1672 height of the widget.
1674 * src/main/java/org/glom/web/client/Utils.java:
1676 2011-12-01 Ben Konrath <ben@bagu.org>
1678 Use Utils.getWidgetHeight() in FlowTable.
1680 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1682 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1684 2011-12-01 Ben Konrath <ben@bagu.org>
1686 Put the details css class name on the correct table column.
1688 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1690 2011-11-30 Ben Konrath <ben@bagu.org>
1692 Update for java-libglom API change.
1694 The getters and setters on FieldFormatting and NumericFormat were
1695 changed to remove the 'M'.
1697 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1699 2011-11-29 Ben Konrath <ben@bagu.org>
1701 Only allow RelatedListTables in Portals.
1703 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1705 2011-11-29 Ben Konrath <ben@bagu.org>
1707 Only create a contents panel for Portals when title is being set.
1709 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1711 2011-11-29 Ben Konrath <ben@bagu.org>
1713 Set TabLayoutPanel height based on calculated height its widgets.
1715 This is a potential fix for this bug:
1717 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1719 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1721 2011-11-29 Ben Konrath <ben@bagu.org>
1723 Align details field labels and data with the Open buttons.
1725 * src/main/webapp/style.css:
1727 2011-11-29 Ben Konrath <ben@bagu.org>
1729 Remove unnecessary <div> in the Notebook widget.
1731 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1732 method to get container FlowPanel (<div>).
1733 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1734 initWidget() method directly on the TabLayoutPanel widget instead of
1735 Group's container widget.
1737 2011-11-29 Ben Konrath <ben@bagu.org>
1739 Don't add group titles for Portals in Notebooks.
1741 This reverts the previous patch and fixes a bug I introduced with
1742 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1744 * src/main/java/org/glom/web/client/ui/details/Group.java:
1745 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1747 2011-11-28 Ben Konrath <ben@bagu.org>
1749 Remove unused boolean argument in Portal constructor.
1751 Just a code cleanup.
1753 * src/main/java/org/glom/web/client/ui/details/Group.java:
1754 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1756 2011-11-28 Ben Konrath <ben@bagu.org>
1758 Remove hack for glom 1.18 style glom files.
1760 * src/main/java/org/glom/web/client/ui/details/Group.java:
1761 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1762 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1764 2011-11-28 Ben Konrath <ben@bagu.org>
1766 Use Gda Value version of primary key to log result too large error.
1768 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1770 2011-11-28 Ben Konrath <ben@bagu.org>
1772 Don't use TypedDataItem.getText() for Unknown types from the URL.
1774 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1775 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1776 instead of getText().
1777 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1778 String field and getUnknown() method.
1780 2011-11-28 Ben Konrath <ben@bagu.org>
1782 Log an error message when the java-libglom .so is not present.
1784 The error message was being set in the exception but not logged.
1786 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1788 2011-11-28 Ben Konrath <ben@bagu.org>
1790 Ignore LayoutItem_CalendarPortals.
1792 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1793 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1795 2011-11-28 Ben Konrath <ben@bagu.org>
1797 Extract method for creating the LayoutItemPortal DTO.
1799 Just breaking the code up into smaller chunks.
1801 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1803 2011-11-28 Ben Konrath <ben@bagu.org>
1807 This should have been added with the refactor. Oops!
1809 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1811 2011-11-28 Ben Konrath <ben@bagu.org>
1813 Create primary key value from URL string using type from Glom document.
1815 See this bug, comments 19 - 25:
1817 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1819 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1820 create a TypeDataItem for the primary key here when loading from a
1821 URL. Show the same string for the primary key value as was received
1822 from the URL string (when loading from a URL).
1823 * src/main/java/org/glom/web/server/Utils.java: Update method for
1824 creating the Gda Value from the TypeDataItem to properly deal with
1825 creating a Gda Value based on the Glom document type for the primary
1826 key value string when loading from a URL.
1827 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1828 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1829 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1830 Update for changed method name.
1832 2011-11-27 Ben Konrath <ben@bagu.org>
1834 Rename PrimaryKeyItem to TypedDataItem.
1836 The name PrimaryKeyItem suggests what the class should be used for.
1837 TypedDataItem is a neutral name that describes the class better.
1839 This is a rename-only refactor.
1841 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1842 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1843 * src/main/java/org/glom/web/client/Utils.java:
1844 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1845 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1846 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1847 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1848 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1849 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1851 * src/main/java/org/glom/web/server/Utils.java:
1852 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1853 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1854 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1855 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1857 2011-11-25 Ben Konrath <ben@bagu.org>
1859 Improve Gda Value conversion from PrimaryKeyItem.
1861 The value from the PrimaryKeyItem is only used if its type match the
1862 type from the glom document.
1864 * src/main/java/org/glom/web/server/Utils.java:
1866 2011-11-25 Ben Konrath <ben@bagu.org>
1868 Manually check if the java-liblgom .so is visible to the JVM.
1870 It seems that Tomcat has problems when a static initializer throws an
1871 exception. This check is done before the first method call into
1872 java-libglom so that execution doesn't continue if the .so is not
1875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1877 2011-11-25 Ben Konrath <ben@bagu.org>
1879 Improve browser configuration error messages.
1883 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1885 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1886 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1887 getConfigurationErrorMessage() method.
1888 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1889 Get and display a specific configuration error message when no Glom
1890 documents are found.
1891 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1892 Implement getConfigurationErrorMessage() method. Surround configuration
1893 code in the init() method with a try/catch block. This allows the
1894 errors to be caught while keeping the servlet available to retrieve the
1895 configuration error message.
1897 2011-11-25 Ben Konrath <ben@bagu.org>
1899 Don't use Strings to hold primary key values.
1901 The primary key values are now held in a new data object
1902 (PrimaryKeyItem) that holds type information and the primary key value
1903 using the correct type.
1905 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1906 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1908 PrimaryKeyItem instead of String to hold the primary key value.
1909 * src/main/java/org/glom/web/client/Utils.java: Remove
1910 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1911 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1913 PrimaryKeyItem instead of String to hold the primary key value. Load
1914 document selection page when the documentID has not been set correctly.
1915 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1916 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1918 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1919 Return empty string for URL instead of "null".
1920 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1921 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1922 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1923 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1924 PrimaryKeyItem instead of String to hold primary key values.
1925 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1926 PrimaryKeyValue to a Gda Value.
1927 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1928 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1929 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1930 Replace temporary database access code that uses the PrimaryKeyValue to
1931 Gda Value conversion.
1932 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1933 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1934 PrimaryKeyItem instead of String.
1935 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1936 hold primary key values.
1938 2011-11-24 Ben Konrath <ben@bagu.org>
1940 Use newly added java-libglom API to create queries.
1942 This isn't finished. I still need to stop using Strings for primary key
1943 values in the client code.
1945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1946 libglom to use fake connections so that retrieving the query string will
1948 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1949 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1950 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1951 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1952 Use the newly added libglom sql methods and classes to create the
1953 query. Add temporary hack to convert primary value strings to Gda
1956 2011-11-23 Ben Konrath <ben@bagu.org>
1958 Don't explicitly set the height of Portals.
1960 See comments 6 - 10 of this bug for details:
1962 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1964 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1966 2011-11-23 Ben Konrath <ben@bagu.org>
1968 Use an HTML table instead of CSS for the FlowTable layout.
1970 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1971 GWT's FlexTable to implement the FlowTable.
1972 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1974 2011-11-18 Ben Konrath <ben@bagu.org>
1976 Add boolean example to HTML table mockup.
1978 * mockups/details-view-html-tables-text-entries.html:
1980 2011-11-17 Ben Konrath <ben@bagu.org>
1982 Ensure the pager buttons are always visible for related lists.
1984 To accomplish this, I've turned off text wrapping in the list view and
1985 related list tables for both the header and data text. The related list
1986 table now has a fixed layout so the it doesn't overflow its container.
1987 This is required to ensure that the cell text is clipped when it
1988 overflows the cell and an ellipsis is added to the right side of the
1989 cell when text is clipped.
1991 A fixed table layout for the related list table in the details view
1992 seems what we want for the details view anyway, so the side-effect is
1995 The ellipsis will only be displayed in Firefox >= 7.
1999 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2001 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2002 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2003 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2005 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2006 Set the 'table-layout: fixed' CSS property to the related list table.
2007 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2008 'white-space: nowrap;' CSS property on both the list view and the
2009 related list tables.
2011 2011-11-16 Ben Konrath <ben@bagu.org>
2013 Rework the fix for empty notebook tab labels.
2015 Setting the empty group titles with its name caused problems for the
2016 details layout. Instead of using libglom's
2017 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2018 to the client when the title is empty. This allows the Notebook to use
2019 the name when the title is empty without affecting anything else.
2021 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2022 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2024 2011-11-16 Ben Konrath <ben@bagu.org>
2026 Set group titles with name when title is empty.
2028 This fixes a problem with an empty notebook tab label in the Lesson
2029 Planner document. The forth tab in the notebook should be "Internet":
2031 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2033 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2034 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2037 2011-11-16 Ben Konrath <ben@bagu.org>
2039 Remove whitespace from the configured username properties.
2041 This assumes that usernames won't have whitespace at the beginning
2042 or end. But I think this is a reasonable assumption.
2044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2045 String.trim() to remove the whitespace from the username properties.
2047 2011-11-15 Ben Konrath <ben@bagu.org>
2049 Add details view mockup with HTML tables and text entries.
2051 This is from the attachment on this bug:
2053 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2055 * mockups/details-view-html-tables-text-entries.html:
2057 2011-11-15 Ben Konrath <ben@bagu.org>
2059 Add space between the columns of the flow table.
2063 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2065 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2066 space between columns in the flow table.
2068 2011-11-15 Ben Konrath <ben@bagu.org>
2070 Add backup files to the .gitignore.
2072 * .gitignore: Ignore files that end with ~.
2074 2011-11-09 Ben Konrath <ben@bagu.org>
2076 Use latest release of gwt-log.
2078 Gwt-log releases are now being submitted to the maven central
2079 repository so manual installation of the jar is no longer required.
2081 * pom.xml: Update version and groupId of gwt-log dependency.
2083 2011-10-31 Ben Konrath <ben@bagu.org>
2085 Don't use GWT numeric formatting to override the glom currency formatting.
2087 Currencies are now displayed like they are in Glom. See this bug:
2089 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2091 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2093 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2094 currency code to constructor and set it when the cell is rendered.
2095 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2096 currency code to the constructor of the NumericCell.
2098 2011-10-27 Ben Konrath <ben@bagu.org>
2100 Require the latest release of java-libglom (1.17.4).
2104 2011-10-26 Ben Konrath <ben@bagu.org>
2106 Add style to Notebook that matches current theme.
2108 It's not the best style in the world but it's better than the default.
2110 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2111 padding at the bottom of the child widgets.
2112 * src/main/webapp/style.css: Add style for the Notebook.
2114 2011-10-26 Ben Konrath <ben@bagu.org>
2116 Move servlet initialization code to overridden init method.
2118 This is half of the solution to getting proper error messages
2119 displayed when configuration errors occur. Here's the relevant bug:
2121 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2123 The rest of the solution involves surrounding the init method with a
2124 try/catch block and setting a global variable with the error /
2125 exception. A new async method should be created to retrieve and display
2126 the error message / exception.
2128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2129 code from constructor to init method adding exceptions as needed.
2131 2011-10-26 Ben Konrath <ben@bagu.org>
2133 Add script to monitor and restart tomcat if required.
2135 * utils/check-and-recover-tomcat.py: New file.
2137 2011-10-26 Ben Konrath <ben@bagu.org>
2139 Display the correct number of data items in the pager.
2143 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2145 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2146 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2147 The implementation is the same for both tables: Keep track of the
2148 number of non-empty rows and fire and RowCountChangeEvent after the data has
2150 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2151 custom Pager class that subclasses SimplePager to handle displaying
2152 the correct number when empty rows have been added.
2154 2011-10-26 Ben Konrath <ben@bagu.org>
2156 Correct error in previous commit.
2158 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2159 eventBus parameter from listView.setCellTable().
2161 2011-10-26 Ben Konrath <ben@bagu.org>
2163 Fix error in TODO comment.
2165 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2167 2011-10-24 Ben Konrath <ben@bagu.org>
2169 Create Notebook widgets to the details view.
2171 This isn't finished just yet - I still need to create a reasonable
2172 style to match the current theme.
2174 * src/main/java/org/glom/web/client/Utils.java: Add method for
2175 calculating the height of a widget. This is used in the Notebook class.
2176 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2177 new constructor method in Group.
2178 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2179 method for creating child widget that can be used by subclasses
2180 like Notebook. New constructor that allows disabling the group
2181 titles - Notebooks don't set a group title for their child groups.
2182 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2183 to make Notebooks using GWT's TabLayoutPanel.
2184 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2185 constructor that allows disabling the group titles.
2186 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2187 LayoutItemNotebook DTO.
2188 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2189 DTO for Notebooks. It's just an empty class for now but we might need
2190 it to transfer some specific information in the future.
2192 2011-10-21 Ben Konrath <ben@bagu.org>
2194 Add navigation buttons to related list tables.
2196 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2197 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2199 method getSuitableRecordToViewDetails() for getting the table name
2200 and primary key value for related list navigation buttons.
2201 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2202 private cell renderer class to get the navigation information for
2203 related list tables from the server. Extract the navigation
2204 processing code from the details cell navigation and use it for the
2205 related list navigation as well.
2206 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2207 cell renderer class for the details open buttons. This was needed
2208 because the related list navigation buttons and the list view
2209 navigation buttons need to react differently when clicked.
2210 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2211 the onEnterKeyDown() method because it's now overriden in the
2212 subclasses that are specific to the related list tables and the list
2214 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2215 the vertical size a little because the buttons add a bit of vertical
2216 space to table. This is not a perfect solution because the vertical
2217 size of with table fewer than 5 rows will be a little smaller.
2218 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2219 changes in how navigation buttons are handled.
2220 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2221 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2222 database access object.
2223 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2224 to find the portal for a given relationship name from
2225 RelatedListDBAccess. Add method to find a primary key field for a
2227 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2228 Move code to find the portal for a given relationship name to
2230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2231 New file: database access object for getting the related list
2232 navigation information (the table name and the primary key value).
2233 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2234 DTO for transferring a table name to navigate to and a primary key
2236 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2237 boolean and getter/setter to specifies if the related list should add
2240 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2242 Use the master branch of java-libglom
2244 * pom.xml: Depend on java-libglom 1.19 instead.
2246 This is the master branch. See also the libglom-1-18 branch.
2248 2011-10-11 Ben Konrath <ben@bagu.org>
2250 Enable the open navigation button when the data has been set.
2252 This avoids having active buttons that don't do anything when the data
2255 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2257 2011-10-11 Ben Konrath <ben@bagu.org>
2259 Use IsWidget interface for FlowTableItem.
2261 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2262 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2264 2011-10-11 Ben Konrath <ben@bagu.org>
2266 Remove GWT styling from open button in details view.
2268 There are still some issues with how the details cell is arranged but
2269 this should be made to match Glom 1.20. I'm going to leave fixing this
2270 until I have Glom 1.20 up and running.
2272 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2273 style name on open button.
2274 * src/main/webapp/style.css: Move and edit details-navigation class.
2275 Re-arrange some classes to make them appear in the same order as the
2278 2011-10-07 Ben Konrath <ben@bagu.org>
2280 Update to GWT 2.4.0.
2282 * .gitignore: Ignore new cache directory.
2283 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2284 * pom.xml: Change GWT and maven plugin to 2.4.0.
2285 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2287 * src/main/java/org/glom/web/client/ClientFactory.java:
2288 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2289 * src/main/java/org/glom/web/client/OnlineGlom.java:
2290 Update source for API changes.
2291 * utils/build-onlineglom-war.sh: Remove cache directory before the
2294 2011-10-07 Ben Konrath <ben@bagu.org>
2296 Add navigation buttons in the details view.
2298 This isn't finished but I thought I'd commit what I have as it's a
2299 pretty good start. I still need to:
2301 1. Change the style so that it fits better into the current theme
2302 2. Adjust the details cell to expand as much as possible.
2304 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2305 click handlers to navigation buttons in the DetailsCells. Create a
2306 refreshData() method to get just the data from the server without the
2308 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2309 Update the tableSelector and browser title when the table name
2310 changes without using the tableSelector.
2311 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2312 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2313 getDetailsCells() to getCells(). Update variable names.
2314 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2315 method to set click handler on navigation button. Rename a few
2316 variables. Add navigation buttons where needed.
2317 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2318 variables and methods.
2319 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2320 navigation boolean and navigation table as required in the
2321 LayoutItemField DTO.
2322 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2323 variables for navigation along with getter/setter methods.
2325 2011-10-07 Ben Konrath <ben@bagu.org>
2327 Rename Field to DetailsCell.
2329 This is a refactor-only commit. No functionality has been added or
2332 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2333 Update variable and method names.
2334 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2335 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2336 variable and method names.
2337 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2339 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2340 variable and method names.
2342 2011-10-07 Ben Konrath <ben@bagu.org>
2344 Create separate methods for layout and data the details view.
2346 This is a refactor-only commit. No functionality has been added or
2349 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2350 private methods: setData(), createLayout().
2352 2011-10-07 Ben Konrath <ben@bagu.org>
2354 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2356 This is part of a change to get navigation buttons in the details view
2357 but it should have been done this way from the start.
2359 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2360 for method name change in TableSelectionView.
2361 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2362 Create TableChangeEvent and set the browser title using the
2363 TableSelectionView API.
2364 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2365 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2366 Change getSelectedTable() to getSelectedTableName(). Add
2367 getSelectedTableTitle().
2369 2011-10-07 Ben Konrath <ben@bagu.org>
2371 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2373 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2375 2011-10-07 Ben Konrath <ben@bagu.org>
2377 Update TableChangeEvent to use newTableName naming convention.
2379 This makes the class more consistent with GWT naming conventions.
2381 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2382 Update for method name change in TableChangeEvent.
2383 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2384 for method name change in TableChangeEvent.
2385 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2386 newTableName variable and getter method. Make toDebugString()
2389 2011-09-30 Ben Konrath <ben@bagu.org>
2391 Disable the pager in the list tables when the data row count is less than the minimum.
2393 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2394 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2396 2011-09-30 Ben Konrath <ben@bagu.org>
2398 Add empty rows to the end of related list and list view tables.
2400 I also extracted the cell rendering classes from the ListTable because
2401 the code was becoming a little crazy with all the anonymous inner
2402 classes. My plan is to use these cell rendering classes in the details
2403 view as well so this refactor will be needed for that change.
2405 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2406 set the row count in related list tables if the data has more rows
2407 than the minimum number of rows visible.
2408 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2409 row count in list view tables if the data has more rows than the
2410 minimum number of rows visible.
2411 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2412 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2414 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2415 for rendering TYPE_NUMERIC cells. The code was extracted from the
2417 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2418 class for rendering cells with buttons in list views. The code was
2419 extracted from the ListTable class.
2420 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2421 for rendering TYPE_TEXT cells. The code was extracted from the
2423 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2424 Add empty rows to the end of the data if required. Implement
2425 ListTable.getMinNumVisibleRows().
2426 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2427 cell renderer code to public classes. Return null in
2428 Column.getValue() for empty rows. Add new abstract method:
2429 getMinNumVisibleRows(). Move code to set the row count of the list view
2430 table to ListViewImpl.
2431 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2432 empty rows to the end of the data if required. Implement
2433 ListTable.getMinNumVisibleRows().
2436 2011-09-27 Ben Konrath <ben@bagu.org>
2438 Use GWT.log for client-side debugging statements.
2440 These are optimized out when deployed so I should have used this method
2441 in the first place. These statements will eventually be replaced with some sort
2442 of notification in the browser.
2444 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2445 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2446 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2447 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2448 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2450 2011-09-27 Ben Konrath <ben@bagu.org>
2452 Put tableselector on the right, back to list link on right.
2454 The idea is that the table selector is acting like a label for the
2455 currently displayed table so it should be placed below the document title. This
2456 puts the table title in a similar position to where it is in Glom.
2458 * mockups/details-contacts.html:
2459 * mockups/details-projects.html:
2460 * mockups/listview-contacts.html:
2461 * mockups/listview-projects.html:
2462 * mockups/style.css:
2463 Update mockups to match how the interfaces currently look.
2464 * src/main/webapp/style.css: Swap positions of backlink with the table
2465 selector. Add some space on the left side of the table selector to
2466 line things up with the document title.
2468 2011-09-27 Ben Konrath <ben@bagu.org>
2470 Add field colouring to details view.
2472 This change re-works how field colouring works. The colour formatting
2473 information is now set to the client with the layout information instead of
2474 with the data. This eliminates the need to send the same colour strings for
2475 data in list view column when colour information is set.
2477 In order to set an alternate colour for negative numeric values, the
2478 number is now sent to client and formatted with the GWT NumberFormat class.
2480 This change also fixes:
2482 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2484 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2485 internationalization framework which is needed for client side numeric
2487 * src/main/java/org/glom/web/client/Utils.java: New file for some
2488 client static utility methods.
2489 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2490 the DataItem object to the Field class. Use a utility method to
2491 create the foreignKeyValue string.
2492 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2493 alignment and text colours in the constructor. Add setData(DataItem)
2494 method. Remove setText(String) method.
2495 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2496 colour information to GlomTextCell. Create and use GlomNumberCell for
2497 rendering numbers. Use utility method to get the string for the
2498 primary key of the key provider. Re-work how the horizontal alignment
2500 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2501 formatting to layout information. Methods for converting the libglom
2502 formatting information were moved from DBAccess.
2503 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2504 numeric formatting (it's now done on the client side). Don't set text
2505 colours in DataItem. Move libglom formatting conversion methods to
2507 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2508 getters/setters for text colour information.
2509 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2510 for transferring the libglom NumericFormat information to the client.
2511 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2512 and getters/setters for: GlomNumericFormat, background colour and
2513 foreground colour strings.
2515 2011-09-26 Ben Konrath <ben@bagu.org>
2517 Simplify code that iterates through the LayoutGroup.
2519 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2521 2011-09-26 Ben Konrath <ben@bagu.org>
2523 Accept Eclipse formatting for OnlineGlomServiceAsync.
2525 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2527 2011-09-26 Ben Konrath <ben@bagu.org>
2529 Don't use the ListDBAccess classes to get the primary key layout information.
2531 This was causing a bug where the wrong index for the hidden primary key
2532 was being sent to the client.
2534 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2535 primary key while creating the LayoutGroup DTO. Create a
2536 LayoutItemField DTO for hidden primary keys. Don't use the
2537 RelatedListDBAccess because it was only used for getting the primary
2539 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2540 access modifier from public to protected for getPrimaryKeyField() and
2541 getPrimaryKeyLayoutItemField().
2542 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2543 abstract method getExpectedResultSize() because RelatedListDBAccess
2544 doesn't have enough info to implement it.
2545 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2546 Remove @Override for getExpectedResultSize().
2547 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2548 Remove method getExpectedResultSize().
2550 2011-09-23 Ben Konrath <ben@bagu.org>
2552 Log which layout (list or details) the ignored item is from.
2554 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2556 2011-09-23 Ben Konrath <ben@bagu.org>
2558 Remove annotations that turn off code formatting in DataItem.
2560 * src/main/java/org/glom/web/shared/DataItem.java:
2562 2011-09-23 Ben Konrath <ben@bagu.org>
2564 Rename GlomField to DataItem and update associated methods.
2566 This is a rename-only refactor. No functionality has been added or
2569 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2570 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2571 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2572 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2573 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2574 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2575 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2576 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2577 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2578 * src/main/java/org/glom/web/server/database/DBAccess.java:
2579 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2580 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2581 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2582 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2583 * src/main/java/org/glom/web/shared/DataItem.java:
2584 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2585 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2587 2011-09-23 Ben Konrath <ben@bagu.org>
2589 Rename GlomDocument to DocumentInfo and update associated methods.
2591 This is a rename-only refactor. No functionality has been added or
2594 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2595 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2596 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2597 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2598 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2600 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2602 2011-09-20 Ben Konrath <ben@bagu.org>
2604 Require java-libglom 1.17.3.
2606 This picks up the fix for the seg fault problem with the Scenes table
2607 in the Openismus Film Manager example.
2611 2011-09-20 Ben Konrath <ben@bagu.org>
2613 Change the way sort clause is added for primary key when no sort clause is requested.
2615 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2616 before the sort clause is created. When a sort clause is not requested, the
2617 sort clause is created by finding the primary key in the LayoutFieldVector
2620 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2622 2011-09-20 Ben Konrath <ben@bagu.org>
2624 Log error message if no documents are found in the configured directory.
2626 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2627 Extract the glom file extension string to a private static final class
2628 variable (mostly as syntactic sugar). Accept a minor formatting change.
2629 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2630 the example glom.document.directory configuration property to make it
2631 more clear that it can any directory, not just the home directory.
2633 2011-09-18 Ben Konrath <ben@bagu.org>
2635 Add related lists to details view.
2637 The related list table has support for paging and sorting just like the
2638 table in the list view.
2640 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2641 SQL queries for the related list tables.
2642 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2645 Rename getList methods to getListView and add comments. Remove
2646 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2647 it being unused. Add methods: getDetailsLayoutAndData(),
2648 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2649 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2650 Create the layout and set the data for the fields in one async call
2651 instead of two. Create related lists where appropriate.
2652 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2653 for method name changes in OnlineGlomService.
2654 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2655 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2656 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2658 * src/main/java/org/glom/web/client/ui/ListView.java:
2659 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2660 tableName from setCellTable(). Create a ListViewTable instead of
2662 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2663 represent a data field in the details view.
2664 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2665 from addDetailsCell() to Field class. Keep track of the Fields and
2666 Portals in the details view.
2667 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2668 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2669 and add a method to get it. Add method to set the contents of the
2671 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2672 New class for related list tables. This class has the data provider
2673 for the related list table.
2674 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2675 abstract class which is the base class for the ListViewTable and the
2677 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2678 New class for list view tables. This class has the data provider for
2679 the list view table.
2680 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2681 methods for related list tables. Add more information to the
2682 LayoutItemField and LayoutItemPortal DTOs.
2683 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2684 Remove debugging print statement.
2685 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2686 Remove debugging print statements. Add primary key field to SQL count
2688 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2689 Remove unnecessary LayoutFieldVector parameter from
2690 getResultSizeOfSQLQuery() method.
2691 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2692 New class for related list table database access.
2693 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2694 class that is a wrapper DTO for details view layout and data.
2695 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2696 new 'fromField' string to this DTO.
2697 * src/main/webapp/style.css: Remove bottom margin and override top
2700 2011-09-15 Ben Konrath <ben@bagu.org>
2702 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2704 This sets things up to make it easier to add the data retrieval for
2705 related lists (portals). No user noticeable changes were made with
2708 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2709 class has the code to retrieve the layouts and access the
2710 database using the new database helper classes.
2711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2712 Most of the functionality has been removed from this class. This
2713 class now represents the public interface for the client side
2714 code. It also deals with configuring the servlet and cleaning
2715 things up when the servlet is stopped.
2716 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2717 of static methods into this utility class.
2718 * src/main/java/org/glom/web/server/database/DBAccess.java:
2719 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2720 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2721 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2722 These classes have the database retrieval code. The class hierarchy
2723 has been setup to make it easy to reuse code for similar
2726 2011-09-06 Ben Konrath <ben@bagu.org>
2728 Create separate classes for list table code and the data provider.
2730 As part of this refactor, I also split up the code a bit to make it
2733 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2734 table code to two new classes (below).
2735 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2736 with code from ListViewImpl.
2737 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2738 New file with code from ListViewImpl.
2740 2011-09-06 Ben Konrath <ben@bagu.org>
2742 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2744 This fixes the LayoutItemPortal DTO to match the libglom layout object
2747 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2749 2011-09-01 Ben Konrath <ben@bagu.org>
2751 Set title of Portals in the Details View.
2753 * pom.xml: Bump required version of java-libglom to 1.17.1.
2754 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2755 widget creation to its own class. Add comments to constructor.
2756 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2757 The code is mostly from the Group class with the title now set.
2758 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2759 title of Portal. Update some comments. Fix some code formatting.
2761 2011-09-01 Ben Konrath <ben@bagu.org>
2763 Remove TODO comment for the flow table column width.
2765 The flow table column width is working correctly and doesn't need to be
2766 changed. See this mailing list post for more info:
2768 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2770 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2772 2011-08-27 Ben Konrath <ben@bagu.org>
2774 Add document title (database name) to top of the browser page.
2776 I added the document title to the TableSelecitonView but that will
2777 change if / when we add a view that doesn't require table selection.
2779 * mockups/details-contacts.html:
2780 * mockups/details-projects.html:
2781 * mockups/listview-contacts.html:
2782 * mockups/listview-projects.html:
2783 * mockups/style.css: Add document title to mockups to keep things
2785 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2786 sizes to account for the document title.
2787 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2788 Set the document title when it has been retrieved from the server.
2789 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2790 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2791 and implement setDocumentTitle(String) method.
2792 * src/main/webapp/style.css: Add ID for document title style.
2794 2011-08-25 Ben Konrath <ben@bagu.org>
2796 Add NavigationType enum to LayoutItemPortal DTO.
2798 This is the start of adding support for Portals to the Details View.
2800 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2801 LayoutItem_Portal.navigation_type enum from libglom to
2802 LayoutItemPortal.NavigationType enum.
2803 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2804 NavigationType enum, field for storing the NavigationType and getter
2807 2011-08-25 Ben Konrath <ben@bagu.org>
2809 Implement the flow table layout in the Details View.
2811 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2812 FlowTable to Group to account for the renamed class.
2813 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2814 File. This is a container widget that implements the Glom details view
2815 flow table behaviour.
2816 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2817 org/glom/web/client/ui/FlowTable.java.
2818 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2819 so that the size of the subgroups are a closer match to the size of
2820 the Glom subgroups. This makes the flowtable layout match the layout
2821 in Glom for the Music Collection example file.
2823 2011-08-16 Ben Konrath <ben@bagu.org>
2825 Create container element for LayoutItemPortal in Details View.
2827 This will help me develop the layout for the FlowTable.
2829 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2830 fieldPanel variable to detailsCell.
2832 2011-08-15 Ben Konrath <ben@bagu.org>
2834 Set the height of the data element in the Details View.
2836 I changed the InlineLabels (text in a span element) to Labels (text in
2837 a div element) so that I could set the height of the details-data
2838 elements instead of the details-cell parent elements. This allows the
2839 the details-data element to display the correct height if style is
2840 applied that shows the height.
2842 This change has the added benefit of allowing the order of the labels
2843 and data elements to be changed for right-to-left languages.
2845 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2846 InlineLabels to Labels.
2847 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2848 InlineLabels to Labels. Set the height of the data element.
2849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2850 multiline text height in the Formatting DTO.
2851 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2852 for multiline height along with getter and setter methods.
2853 * src/main/webapp/style.css: Adjust style to account for the change
2854 from span elements to div elements in the details cell.
2856 2011-08-15 Ben Konrath <ben@bagu.org>
2858 Make the List View appearance match the mockups.
2860 It doesn't match exactly but it's much better than it was.
2862 * mockups/listview-contacts.html: Remove unused css classes.
2863 * mockups/listview-projects.html: Remove unused css classes.
2864 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2865 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2866 for mainPanel instead of VerticalPanel (table). Set style name on
2867 CellTable. Set style name on Details column. Right-align Details
2869 * src/main/webapp/style.css: Adjust properties to match the mockups.
2871 2011-08-12 Ben Konrath <ben@bagu.org>
2873 Add better support for subgroups in the details view.
2875 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2876 changed FlowTable constructor.
2877 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2878 support for subgroups and subgroup-titles.
2879 * src/main/webapp/style.css: Add CSS class for subgroups and
2882 2011-08-12 Ben Konrath <ben@bagu.org>
2884 Return the top level LayoutGroup title.
2886 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2888 2011-08-11 Ben Konrath <ben@bagu.org>
2890 Make the TableSelector header match the mockup.
2892 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2893 the layout panel. Properly lineup the table selection header with
2894 the list and details view.
2895 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2896 margin around the details view.
2897 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2898 Rename listBox variable to tableSelector. Set id for the style sheet.
2899 Use a FlowPanel instead of a HorizontalPanel.
2900 * src/main/webapp/style.css: Add properties to make the TableSelector
2901 box match the mockups.
2903 2011-07-13 Ben Konrath <ben@bagu.org>
2905 Update install script for java-libglom version change.
2907 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2910 2011-07-13 Ben Konrath <ben@bagu.org>
2912 Add support sub-group in the details view.
2914 I also removed the code that special-cased the default details view
2917 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2919 I still have to make a proper flowtable.
2921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2922 Don't special-case default details view layout.
2923 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2924 addLayoutField() as I'm going to use it.
2925 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2926 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2928 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2929 extracted from DetailsViewImpl.GroupPanel. Add support for
2931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2932 column count when getting the details layout.
2934 2011-07-12 Ben Konrath <ben@bagu.org>
2936 Set browser title with database and table titles.
2938 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2939 Set the browser title when the table changes and when the activity
2941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2942 title when retrieving document info (the GlomDocument object).
2943 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2944 with getter and setter methods. Remove unused convenience constructor.
2945 Use default code formatting.
2947 2011-07-12 Ben Konrath <ben@bagu.org>
2949 Ignore LayoutItemPortals in the details view.
2951 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2954 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2955 LayoutItemPortal layout objects.
2956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2957 LayoutItemPortal objects when retrieving the details layout.
2958 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2959 file. This is an empty class and just used to get type information for
2962 2011-07-12 Ben Konrath <ben@bagu.org>
2964 Use java-libglom 1.17.0.
2968 2011-07-11 Ben Konrath <ben@bagu.org>
2970 Remove "Table:" label from table selector.
2972 This matches a recent change in the Glom UI.
2974 * mockups/details-contacts.html:
2975 * mockups/details-projects.html:
2976 * mockups/listview-contacts.html:
2977 * mockups/listview-projects.html: Remove the "Table:" label from the
2979 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2981 2011-07-11 Ben Konrath <ben@bagu.org>
2983 Add main groups to the details view.
2985 This makes things look a little nicer in the details view. The next step
2986 is to implement the flowtable.
2988 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2989 resources from the standard gwt css theme. Standard.css is now
2990 included in OnlineGlom.html so that the online glom css rules have
2991 precedence over the gwt theme.
2992 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2993 the whole LayoutGroup to the DetailsView instead of just the titles.
2994 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2995 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2996 details layout with a helper class (GroupPanel). I might extract this
2997 class when I make the full flowtable.
2998 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2999 string as default so I don't have to worry about NPEs when processing
3001 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3002 note beside OnlineGlom.gwt.xml above).
3003 * src/main/webapp/style.css: Add default font-size to body to override
3004 the font-size set by the standard theme. Don't use h2 tags for
3005 group-title. Create new details-cell class.
3007 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3009 ConfiguredDocument: Set the port number too.
3011 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3012 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3013 Glom document. Presumably this worked sometimes so far because there is a
3014 default port number.
3016 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3018 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3020 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3021 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3022 correct, though we should throw an exception too.
3024 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3026 Fix a addDocuemnt typo.
3028 * src/main/java/org/glom/web/shared/Documents.java
3029 (Documents.addDocuemnt): Rename to addDocument().
3030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3031 (OnlineGlomServiceImpl.getDocuments): Adapt.
3033 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3035 Slightly improved log output when connection fails.
3037 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3038 (ConfiguredDocument.setUsernameAndPassword):
3039 We don't know for sure if it' the username/password that's wrong, so
3040 rephrase the message.
3041 Also ouput the exception message, though it's generic in this case.
3043 2011-07-08 Ben Konrath <ben@bagu.org>
3047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3048 added braces to a one line if statement because the Eclipse formatter
3049 was getting confused.
3051 2011-07-07 Ben Konrath <ben@bagu.org>
3053 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3055 These should really be two separate tasks but I counldn't get things to
3056 work with GWT 2.2.0 and Eclipse 3.7.
3060 * .settings/org.eclipse.jdt.core.prefs:
3061 * .settings/org.eclipse.jdt.ui.prefs:
3062 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3063 * .settings/org.eclipse.m2e.core.prefs:
3064 Add new config files. Update current files. Remove references to the
3065 webtools plugins as we're not using any of the webtools features.
3066 * .gitignore: Add logs directory which is created when running with
3068 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3069 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3070 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3072 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3074 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3076 onlineglom.properties: Add explanatory comments.
3078 * src/main/resources/onlineglom.properties: Also change the default user
3079 from ben to someuser, to avoid the risk of people thinking we just
3080 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3082 2011-06-28 Ben Konrath <ben@bagu.org>
3084 Use filename in Log for incorrect passwords.
3086 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3087 getFileName(String) method to get the filename from the URI.
3089 2011-06-28 Ben Konrath <ben@bagu.org>
3091 Add the table name to the URL token for the ListPlace.
3093 This makes things consistent between the DetailsPlace and the
3094 ListPlace. It also allows the the ListPlace to be bookmarked.
3096 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3097 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3099 Remove getDefaultListLayout(). The default layout is now returned
3100 by the getListLayout() method when the table name is an empty string.
3101 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3102 Add table name field. Change to a new ListPlace when the table
3103 has been changed. Use getListLayout() for getting the default
3105 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3106 Add table name field. Set the correct table name in the list box
3107 when loading from bookmark. This corrects a problem for the
3109 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3110 Move table name to super-class (HasSelectableTable). Move document
3111 and table URL keys to super-class in HasSelectableTable.
3112 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3113 Add table name field. Add Tokenizer class with URL key common to
3114 the subclasses (DetailsPlace and ListPlace).
3115 * src/main/java/org/glom/web/client/place/ListPlace.java:
3116 Add table name. Add code to parse the URL token.
3117 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3118 Update ListPlace construction with empty table name string.
3119 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3120 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3121 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3122 Update ListPlace construction with table name string.
3123 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3124 Change defaultTableName field to tableName to reflect how it's now
3125 used. Update the getter and setter methods.
3127 2011-06-28 Ben Konrath <ben@bagu.org>
3129 Enable the table selector in the DetailsView.
3131 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3132 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3134 Remove getDefaultDetailsLayout(). The default layout is now returned
3135 by the getDetailsLayout() method when the table name is an empty
3137 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3138 event handler for table change event. Change to using
3139 getDetailsLayout() for the default details layout.
3140 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3142 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3143 when navigating to the details place.
3145 2011-06-27 Ben Konrath <ben@bagu.org>
3147 Use filename based unique document ID in URL and for RPC.
3149 The document ID is the glom document name with spaces (' ') replaced
3150 with pluses ('+') and without the .glom extension.
3152 This change is mostly a string substitution of 'documentTitle' for
3153 'documentID'. The only code change is the addition of a Documents DTO to get the
3154 filename to document title mappings as indicated below.
3156 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3157 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3158 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3159 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3160 Use Documents DTO to create the document links in the document
3162 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3163 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3164 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3165 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3166 * src/main/java/org/glom/web/client/place/ListPlace.java:
3167 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3168 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3169 * src/main/java/org/glom/web/client/ui/ListView.java:
3170 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3171 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3172 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3173 * src/main/java/org/glom/web/server/Log.java:
3174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3175 getDocumentTitles() to getDocuments() and return the Documents DTO.
3176 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3177 transferring the filename to document title mappings.
3179 2011-06-25 Ben Konrath <ben@bagu.org>
3181 Make the authentication popup work again.
3183 This bug was introduced when I extracted ConfiguredDocument to its own class.
3185 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3186 correct success / fail status in setUsernameAndPassword().
3188 2011-06-25 Ben Konrath <ben@bagu.org>
3190 Use filename as unique key for configuring database usernames and passwords.
3192 This replaces the use of the Glom document title which could change
3193 depending on the locale. Thanks to Murray Cumming for pointing out this
3196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3197 * src/main/resources/onlineglom.properties:
3199 2011-06-24 Ben Konrath <ben@bagu.org>
3201 Pass primary key value to DetailsView.
3203 This enables the DetailsView to load the correct data.
3205 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3206 primary key value field and set in constructor. Pass primary key
3207 value to getDetailsData().
3208 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3209 variables for document title and primary key value.
3210 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3211 key value to the DetailsPlace.
3213 2011-06-24 Ben Konrath <ben@bagu.org>
3215 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3217 This allows the primary key to be retrieved by the Details button. This
3218 functionality has not been implemented yet but it's in the works.
3220 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3221 the LayoutGroup result to ListView.setCellTable instead of all of its
3222 fields individually.
3223 * src/main/java/org/glom/web/client/ui/ListView.java:
3224 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3225 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3226 get the primary key for the table.
3227 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3228 index of the primary key in the LayoutGroup accounting for hidden
3229 primary keys. Rename getJavaNumberFormat() to
3230 convertToJavaNumberFormat() for consistency. Cleanup / add some
3232 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3233 field for primary key index and a field to indicate whether the
3234 primary key is hidden or not.
3236 2011-06-23 Ben Konrath <ben@bagu.org>
3238 Rename getTableData methods to getListData.
3240 This is a rename refactor for consistency with other methods.
3242 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3243 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3244 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3245 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3247 2011-06-23 Ben Konrath <ben@bagu.org>