1 2012-01-27 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
6 Check the ConfiguredDocument* for null before using it.
8 2012-01-26 Murray Cumming <murrayc@murrayc.com>
10 Tell Eclipse about the generated java files.
12 * .classpath: This lets it find OnlineGlomConstants.java.
13 It would be nice if Eclipse just used the maven build files.
15 2012-01-26 Murray Cumming <murrayc@murrayc.com>
17 Prevent a crash when no locale is specified in the URL.
19 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
20 Avoid returning a null string, obtained from
21 Window.Location.getParameter(). This caused a crash when it was
22 later passed to libglom's API.
23 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
24 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
25 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
26 guard against future null strings.
28 2012-01-26 Murray Cumming <murrayc@murrayc.com>
30 Use the ?locale= query param instead of the &lang= token param.
32 * src/main/java/org/glom/web/client/place/ListPlace.java
33 * src/main/java/org/glom/web/client/place/DetailsPlace.java
34 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
35 Remove the lang token key and value.
37 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
38 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
39 When the user selects a different locale from the chooser, use
40 Window.Location.assign() to change the URL, which then causes a reload.
42 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
43 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
44 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
45 * src/main/java/org/glom/web/client/activity/ListActivity.java
46 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
47 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
48 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
49 * src/main/java/org/glom/web/client/ui/ListView.java:
50 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
52 Remove localeID member variables and method/constructor parameters, instead
53 using Utils.getCurrentLocaleID() when we need a localID to pass to
56 2012-01-26 Murray Cumming <murrayc@murrayc.com>
58 Internationalize the UI strings.
60 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
61 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
62 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
63 because it is unused. Messages are apparently strings that can have
64 parameters, but we do not need that yet, so Contants will be enough for now.
65 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
66 to say that we support the en and de locales.
67 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
68 The original English strings.
69 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
70 Some German translations of the English strings.
71 The i18n goal then uses the .properties file to generate an
72 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
73 returns an implementation that returns the translated strings.
74 The documentation suggests putting these in src/java/*/client/, but it seems
75 best to put it in src/resources/*/client/.
76 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
77 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
78 instead of hard-coding them.
79 Note that we cannot import OnlineGlomConstants because it does not exist yet,
80 but that does not seem to stop the build, though it confuses Eclipse.
82 You can see the translated string by adding ?locale=de to the URL, like so:
83 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
85 2012-01-24 Murray Cumming <murrayc@murrayc.com>
87 Improve null/empty String checks.
89 * pom.xml: Add a dependency on commons-lang, to use
90 org.apache.commons.lang.StringUtils.
91 * src/main/java/org/glom/web/server/ConfiguredDocument.java
92 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
93 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
94 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
95 Use StringUtils.isEmpty().
97 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
98 StringUtils class with a static isEmpty() function because we
99 cannot use org.apache.commons.lang.StringUtils in client-side
100 GWT code because it (apparently) cannot be compiled to javascript.
101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
102 * src/main/java/org/glom/web/client/activity/ListActivity.java
103 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
104 * src/main/java/org/glom/web/client/place/DetailsPlace.java
105 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
106 * src/main/java/org/glom/web/client/place/ListPlace.java
107 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
108 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
109 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
110 * src/main/java/org/glom/web/client/ui/details/Group.java
111 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
112 our StringUtils.isEmpty() function.
114 2012-01-24 Murray Cumming <murrayc@murrayc.com>
116 Update to the latest java-libglom API.
118 * pom.xml: Require java-libglom 1.21.4.
119 * src/main/java/org/glom/web/server/ConfiguredDocument.java
120 getDocumentInfo(), getListViewLayoutGroup():
121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
123 * src/main/java/org/glom/web/server/database/DBAccess.java
124 getFieldsToShowForSQLQueryAddGroup(),
125 getPrimaryKeyLayoutItemField(): Replace get_database_title()
126 with either get_database_title_original() or
127 get_database_title(localeID).
129 2012-01-24 Murray Cumming <murrayc@murrayc.com>
131 ConfiguredDocument: Avoid a null pointer exception.
133 * src/main/java/org/glom/web/server/ConfiguredDocument.java
134 Initialize localeID to "" to avoid returning a null String which
135 causes a crash in java-libglom's swing-generated code.
137 2012-01-23 Murray Cumming <murrayc@murrayc.com>
139 Some simple renaming.
141 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
142 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
143 for localeChooser. This seems more appropriate and is less ambiguous
144 particularly in the .css file.
146 2012-01-23 Murray Cumming <murrayc@murrayc.com>
148 ConfiguredDocument: Rename the localedID private member variable.
150 2012-01-23 Murray Cumming <murrayc@murrayc.com>
152 Adapt to the latest java-libglom API from git master.
154 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
155 libglom now uses only Vector instead of List, which uses add() instead of
158 2012-01-23 Murray Cumming <murrayc@murrayc.com>
160 Add and fill a Reports drop-down list box.
162 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
164 * src/main/java/org/glom/web/client/OnlineGlomService.java:
165 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
167 Added getReports(document, table, localeID), calling
168 ConfiguredDocument.getReports().
169 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
170 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
171 Added setReportsList() and a list widget.
172 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
173 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
175 2012-01-22 Murray Cumming <murrayc@murrayc.com>
177 ConfiguredDocument: Rename the localedID private member variable.
179 2012-01-20 Murray Cumming <murrayc@murrayc.com>
181 Build a source tarball with mvn assembly:single
183 * assembly.xml: Add this file.
184 * pom.xml: Use the maven-assembly-plugin and tell it to use
185 our assembly.xml file.
187 2012-01-19 Murray Cumming <murrayc@murrayc.com>
189 OnlineGlomServiceImpl: Get .glom files recursively.
191 * pom.xml: Depend on commons-io from org.apache.commons.
192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
193 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
194 files recursively, and with the easier filter for the extension.
195 Use org.apache.commons.io.FilenameUtils.removeExtension() to
196 simplify that code too.
198 2012-01-19 Murray Cumming <murrayc@murrayc.com>
200 README: Mention that you must install java-libglom packages separately.
202 But then it works, because java-libglom is now in the central maven
205 2012-01-18 Murray Cumming <murrayc@murrayc.com>
207 locales drop-down: Show the correct selected locale when the URL changes.
209 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
210 .java: setPlace(): Move some code into fillView().
212 2012-01-18 Murray Cumming <murrayc@murrayc.com>
214 locales drop-down: Do not lose the primary key.
216 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
217 start(): onLocaleChange(): Pass the current primary key value,
218 instead of an empty value.
220 2012-01-18 Murray Cumming <murrayc@murrayc.com>
222 locales drop-down: Do not lose the drop-down selection.
224 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
225 .java (TableSelectionActivity.fillView): Set the selected locale
226 after changing the drop-down items (though we do not really need
227 to change them just because the locale changes.)
229 2012-01-18 Murray Cumming <murrayc@murrayc.com>
231 locales drop-down: Change the tables list when this changes.
233 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
234 .java: TableSelectionActivity.start(): Move the async table titles
235 retrieval into a private fillView() method and also call this when
236 the chosen locale changes.
237 Note that the document title is not actually translatable yet, but
238 that is a problem that I should fix soon in libglom.
240 2012-01-18 Murray Cumming <murrayc@murrayc.com>
242 Improve the placement of the locales drop-down.
244 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
245 Put the title and locales drop-down in a div (gwt.FlowTable).
246 * src/main/webapp/style.css: Add magic css properties to make this work.
247 Also remove the left margin from the title so that it lines up with the
250 2012-01-18 Murray Cumming <murrayc@murrayc.com>
252 locales selector: Show human-readable locale titles.
254 * src/main/java/org/glom/web/server/ConfiguredDocument.java
255 getDocumentInfo(): Use java.util.Locale to show a real title of
256 each locale, in the locale's own language.
258 2012-01-17 Murray Cumming <murrayc@murrayc.com>
260 Add a language/locale selector drop-down.
262 * src/main/java/org/glom/web/shared/DocumentInfo.java:
263 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
264 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
265 getDocumentInfo(): Store the available Locales in the DocumentInfo.
266 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
267 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
268 Add a ListBox to show the available locales. Add getLocaleSelector(),
269 setLocaleList(), getSelectedLocale(), setSelectedLocale().
270 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
271 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
272 java: Add these classes.
273 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
274 start(): Fill the locales ListBox. Handle its change event, firing a
276 setPlace(): Show the selected locale as specified by the URL token.
277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
278 * src/main/java/org/glom/web/client/activity/ListActivity.java:
279 Handle LocaleChangeEvent, going to a new *Place with that locale.
281 The placement of the ListBox is not pretty, and it currently uses the ID
282 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
286 2012-01-17 Murray Cumming <murrayc@murrayc.com>
288 Search box: Show the search text from the URL token.
290 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
291 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
292 Add setQuickFindText().
293 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
294 .java: setPlace(): Store the queryText if the place is a ListPlace,
295 and call TableSelectionView.setQuickFindText().
297 2012-01-17 Murray Cumming <murrayc@murrayc.com>
299 Allow use of translations via, for instance, &lang=de in the URL.
301 * pom.xml: Use the unstable java-libglom 1.21 version.
303 * src/main/java/org/glom/web/client/OnlineGlomService.java:
304 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
305 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
306 init(): Instead of calling TranslatableItem.set_current_locale()
307 (now removed), call ConfiguredDocument.setDefaultLocaleID().
308 However, this is only for default locales, which are not needed to
309 change the locale in the URL.
310 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
311 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
312 getSortedRelatedListData(): Add a localeID parameter, so we can get the
313 layout for a particular locale.
314 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
315 Add get/setDefaultLocaleID().
316 getDocumentInfo(), getListViewData(), getRelatedListData(),
317 getDetailsLayoutGroup(), getListViewLayoutGroup(),
318 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
319 localeID parameter, so we can get the layout for a particular locale.
321 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
322 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
323 * src/main/java/org/glom/web/client/place/ListPlace.java:
324 Parse and construct a lang parameter too.
326 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
327 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
328 passed to subsequent methods and constructors.
329 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
330 * src/main/java/org/glom/web/client/activity/ListActivity.java:
331 Store the localeID from the *Place and pass it to other constructors
332 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
334 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
335 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
336 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
337 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
338 * src/main/java/org/glom/web/client/ui/ListView.java:
339 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
340 Take localeID parameters and pass them to subsequent constructors and
341 methods, so that the layout is always retrieved for that locale.
343 This is rather repetitive.
345 Note that "" means the original (default) locale of the Glom document,
346 which is usually English.
348 2012-01-17 Murray Cumming <murrayc@murrayc.com>
350 Documents: Remove final keyword to fix startup configuration.
352 * src/main/java/org/glom/web/shared/Documents.java: Remove the
353 final keywords on the private member variables because that breaks
354 the startup, apparently (there are warnings) because it stops them
355 from being serialized. I added these in the previous commit.
357 2012-01-13 Murray Cumming <murrayc@murrayc.com>
359 Documents: Add some final keywords.
361 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
364 2012-01-13 Murray Cumming <murrayc@murrayc.com>
366 OnlineGlomServiceImpl: Add to overview comments.
368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
369 Note that this is where all the document are loaded. They are not
370 loaded freshly for each page.
372 2012-01-12 Murray Cumming <murrayc@murrayc.com>
376 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
377 Add a TextBox for the text of a quick find.
378 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
380 setBackLink(): Add a String quickFind parameter.
381 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
382 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
383 to the base interface, because that is how TableSelectionViewImpl is used.
384 * src/main/webapp/style.css: Add style for the search box and its label.
386 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
387 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
388 Add these files, based on the existing TableChangeEvent and
389 TableChangeEventHandlers.
390 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
391 start(): Handle QuickFindChangeEvent, passing its quickFind text to
392 a ListPlace() that the user should be taken to.
393 * src/main/java/org/glom/web/client/activity/ListActivity.java
394 start(): Handle it here too and adapt the TableChangeEvent handler to
395 pass the extra "" quickFind parameter to ListPlace.
396 * src/main/java/org/glom/web/client/place/ListPlace.java:
397 Constructor: Take an extra String quickFind parameter and store it,
398 returning it from a new getQuickFind() method.
399 getToken(): Put the quickFind text in the URL token.
400 getPlace(): Parse the quickFind text from the URL token.
401 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
402 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
403 ListPlace constructor.
404 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
405 .java: start(): Add a Change handler for the TableSelectionView's
406 TextBox (via its base HasChangeHandlers interface), firing the new
407 QuickFindChangeEvent.
408 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
409 pass the extra "" quickFind parameter.
411 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
412 setCellTable(): Add a String quickFind parameter and pass it to
413 the ListViewTable() constructor.
414 * src/main/java/org/glom/web/client/ui/ListView.java: Change
415 setCellTable() in the base interface, because that is how ListViewImpl
418 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
419 Add a String quickFind member variable.
420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
421 Constructor: Add a String quickFind parameter, storing it in the
422 base ListTable's member variable.
423 onRangeChanged(): Pass quickFind to the
424 OnlineGlomServiceAsync.getSortedListViewData() and
425 OnlineGlomServiceAsync.getListViewData() methods.
427 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
428 getListViewData(), getSortedListViewData(): Add a String quickFind
429 parameter, passing it to ConfiguredDocument.getListViewData().
430 * src/main/java/org/glom/web/client/OnlineGlomService.java:
431 Change getListViewData(), getSortedListViewData() in the base interface,
432 because that is how OnlineGlomServiceImpl is used, via this:
433 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
434 Change getListViewData(), getSortedListViewData() here too.
435 This class can apparently be used to asynchronously call methods on
436 OnlineGlomService, and GWT seems to implement that after recognizing
437 just the *Async name convention and the extra AsyncCallback parameters.
439 * src/main/java/org/glom/web/server/ConfiguredDocument.java
440 getListViewData(): Add a String quickFind parameter, and pass it to
441 ListViewDBAccess.getData().
442 * src/main/java/org/glom/web/server/database/ListDBAccess.java
443 getListData(): Add a String quickFind parameter and pass it to
445 getSelectQuery(): Add a String quickFind parameter.
446 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
447 getSelectQuery(): Add a String quickFind parameter and use it with
448 Glom.get_find_where_clause_quick() to pass a where_clause to
449 Glom.build_sql_select_with_where_clause(), to actually filter the
451 getData(): Add a String quickFind parameter, passing it to getListData().
452 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
453 va: getData(): Pass an empty string to getListData() for the
456 2012-01-12 Murray Cumming <murrayc@murrayc.com>
458 ListTable: Minor change.
460 * src/main/java/org/glom/web/client/ui/list/ListTable.java
461 createCellTable(): Make this protected instead of public.
463 2012-01-12 Murray Cumming <murrayc@murrayc.com>
465 Many files: Use final for the parameters and use the @override attribute.
467 2012-01-22 Ben Konrath <ben@bagu.org>
469 Add anchor links for single line text that starts with http, ftp and www.
473 2012-01-22 Ben Konrath <ben@bagu.org>
475 Add ellipsis to single line text in details view.
479 2012-01-04 Murray Cumming <murrayc@murrayc.com>
481 Remove all javadoc author tags.
483 Because they are awkward and meaningless when many people touch
485 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
487 2012-01-04 Murray Cumming <murrayc@murrayc.com>
489 Revert the COPYING.LESSER to COPYING rename.
491 Apparently both should be there if it is LGPL.
493 2012-01-03 Murray Cumming <murrayc@murrayc.com>
495 *View: Remove unused imports.
497 * src/main/java/org/glom/web/client/ui/DetailsView.java:
498 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
499 * src/main/java/org/glom/web/client/ui/ListView.java:
500 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
501 Remove unused imports, as suggested by Eclipse.
503 2012-01-02 Murray Cumming <murrayc@murrayc.com>
505 Move the *View::Presenter types, and some API into one base View.
507 * src/main/java/org/glom/web/client/ui/DetailsView.java:
508 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
509 * src/main/java/org/glom/web/client/ui/ListView.java:
510 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
511 Presenter, setPresenter() and clear() into a shared base interface,
512 to avoid the unnecessary duplicate Presenter types and to more clearly
513 show how the *Views share the same structure, even if they are not
514 used polymorphically.
516 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
517 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
519 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
520 * src/main/java/org/glom/web/client/activity/ListActivity.java:
521 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
523 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
526 Feel free to revert this if there is a good reason for the duplicate
529 2012-01-02 Murray Cumming <murrayc@murrayc.com>
531 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
533 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
534 a class member instead of a local variable in the method.
535 This lets us use it to get the view instances, for use in tests.
536 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
537 beforeOnlineGlom(): Test some more details of the initial view.
538 Again, this is not very useful.
540 To really test gwt-glom we will need to start a local postgresql
541 instance with local data, like the Glom tests in C++.
543 2012-01-02 Murray Cumming <murrayc@murrayc.com>
545 pom.xml: Mention the LGPL license.
547 * pom.xml: Add a licenses section.
548 * COPYING.LESSER: Move this to COPYING, which
549 previously contained the GPL. But gwt-glom is all LGPL.
551 2012-01-02 Murray Cumming <murrayc@murrayc.com>
553 Add project information to README and pom.xml.
555 * README: Add a brief description and mention some mvn
557 * pom.xml: This extra information shows up in mvn site
560 2011-01-02 Murray Cumming <murrayc@murrayc.com>
562 Use the latest java-libglom version.
564 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
566 2012-01-01 Murray Cumming <murrayc@murrayc.com>
568 GwtTestOnlineGlom: Test a little more.
570 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
571 protected rather than private, as suggested by the gwt-test-utils
573 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
574 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
575 Test the initial visibility of the panels.
577 However, this is not a very useful test.
578 And I wonder how we should generally test using this idea for an
579 activity/places app like ours where the real changes happen implicitly
580 based on the history token/URL.
582 2012-01-01 Murray Cumming <murrayc@murrayc.com>
584 Slight modification to *Mapper comments.
586 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
588 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
590 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
592 Remove comments mentioning GIN because they are just copied from
593 the example code and are apparently not helpful:
594 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
595 Also change the mention of a class that is only in the example code.
597 2012-01-01 Murray Cumming <murrayc@murrayc.com>
599 GwtTestOnlineGlom test: Minor changes.
601 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
602 Avoid the long qualified class name and modify the comment
603 because it is now obvious to me that the mocked class is the only
604 custom one created via GWT.create().
606 2012-01-01 Murray Cumming <murrayc@murrayc.com>
608 Tests: Added the beginnings of a test using gwt-test-utils.
610 * pom.xml: Add dependencies on gwt-test-utils and easymock.
611 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
612 which tells gwt-test-utils what class will be tested.
613 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
614 Add a simple (but empty) test case. One class, used by the OnlineGlom
615 class, is mocked so that it can be created. However, I am not sure
616 why only this class needs to be mocked.
618 Note that mockito seems more popular, and clearer, than easymock,
619 but I have not got that working yet. It might be a matter of the
622 This test is run during mvn integration-test.
624 2011-12-31 Murray Cumming <murrayc@murrayc.com>
626 Tests: Use junit4-style syntax instead of junit3-style.
628 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
629 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
630 * src/test/java/org/glom/web/shared/DataItemTest.java:
631 Use the @Test annotation rather than relying on the test*() prefix.
632 Also no longer implement TestCase, to avoid triggering support for
633 the junit3-way, which stops the annotations from working.
634 Change the imports from import junit.framework.* to
635 import org.junit.*, which is apparently the new way.
637 2011-12-31 Murray Cumming <murrayc@murrayc.com>
639 Added a test for ListPlace token parsing and creation.
641 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
642 This is much the same as DetailsPlaceTest.
644 I wonder how we could test the other parts of the *Place API.
646 2011-12-30 Murray Cumming <murrayc@murrayc.com>
648 DetailsPlace test: Also test getToken() and recreation via getPlace().
650 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
651 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
652 recreate it, testing the recreated DetailsPlace for the same parameter
655 2011-12-30 Murray Cumming <murrayc@murrayc.com>
657 Use the surefire-report plugin.
659 * pom.xml: This generates a HTML report about the tests in
660 target/site/surefire-report.html
661 when you do mvn surefire-report:report. It seems to be popular/normal.
663 2011-12-30 Murray Cumming <murrayc@murrayc.com>
665 Added a test for DetailsPlace.
667 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
668 Test the getPlace() token parsing.
670 2011-12-30 Murray Cumming <murrayc@murrayc.com>
672 Added a first unit test.
674 * pom.xml: Add a test goal, and a dependency on junit in that scope.
675 * src/test/java/org/glom/web/shared/DataItemTest.java:
676 This is a silly test but it is just to get things started. Note that
677 maven/junit finds the test because it looks in src/test by default.
679 2011-12-22 Ben Konrath <ben@bagu.org>
681 Change charsetName to "UTF-8" when replacing line breaks.
683 JavaScript requires the charsetName to be "UTF-8". CharsetName values
684 that work in Java (such as "UTF8") will not work when compiled to
687 This fixes a problem with multi-line details view fields that have hard
688 line breaks. The "License Text" field on this page demonstrates the
691 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
693 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
695 2011-12-22 Ben Konrath <ben@bagu.org>
697 Fix another bug with related list navigation.
699 I've tested all the navigation buttons in all of the related lists
700 so things should be good now.
702 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
704 2011-12-22 Ben Konrath <ben@bagu.org>
706 Fix a crasher when refreshing the list view with the default table.
708 This crash will also happen when loading the list view with the default
709 table from a link or bookmark.
711 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
712 to the main document selection page when the document id hasn't been
714 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
715 the main document selection page when the document id hasn't been
717 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
718 values for the details place when the document id hasn't been set.
719 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
720 values for the list place when the document id hasn't been set.
722 2011-12-21 Ben Konrath <ben@bagu.org>
724 Protect against NPE when glom.document.locale is not in config.
726 This patch protects against an NPE when glom.document.locale is not in
727 the config file. This NPE will also happen if glom.document.locale is
730 The patch also updates the error message to display the class name when
731 the getMessage() returns null. This was happening when the NPE was
732 thrown and I had "Configuration Error: null". If an NPE is encountered
733 with this patch, "Configuration Error: NullPointerException " will be
736 This commit closes this bug:
738 https://bugzilla.gnome.org/show_bug.cgi?id=666669
740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
742 2011-12-20 Murray Cumming <murrayc@murrayc.com>
744 Rename onlineglom.properties to onlineglom.properties.sample.
746 * src/main/resources/onlineglom.properties: Rename to:
747 * src/main/resources/onlineglom.properties.sample:
748 * src/main/resources/README: And add this file explaining that people
749 should rename it back when deploying.
751 2011-12-20 Murray Cumming <murrayc@murrayc.com>
753 Allow choosing the translation in the .properties file.
755 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
756 init(): Read a glom.document.locale value from the configuration file
757 and call Glom's TransatableItem::set_current_locale() method.
758 * src/main/resources/onlineglom.properties: Add a commented-out
759 example of this new setting.
761 It would be better to add &lang=de_DE to the URL, but the current
762 libglom API does not allow us to do this easily. I am working on that.
764 2011-12-19 Murray Cumming <murrayc@murrayc.com>
766 Avoid a crash in parsing of token parameters.
768 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
769 ava: getTokenParams(): Do not crash if a parameter has a key but no
770 value, and ignore parameters with neither.
772 2011-12-17 Murray Cumming <murrayc@murayc.com>
774 History token building/handling: Improve use of token parameters.
776 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
777 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
778 and buildParamsToken(HashMap), for use by derived classes.
779 Make the separator private because it is no longer be needed.
780 * src/main/java/org/glom/web/client/place/DetailsPlace.java
781 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
782 instead of manual string concatenation.
783 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
784 of hardcoded indices and awkward splitting code.
785 * src/main/java/org/glom/web/client/place/ListPlace.java
786 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
787 instead of manual string concatenation.
788 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
789 of hardcoded indices and awkward splitting code.
790 This should fix bug #666420
792 2011-12-16 Murray Cumming <murrayc@murrayc.com>
794 Fix a Navgiation->Navigation typo in the code.
796 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
797 Rename processNavgiation() to processNavigation().
799 2011-12-16 Murray Cumming <murrayc@murrayc.com>
801 Fix a seperator->separator typo in the code.
803 * src/main/java/org/glom/web/client/place/DetailsPlace.java
804 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
805 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
808 2011-12-15 Ben Konrath <ben@bagu.org>
810 Cleanup some comments.
812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
814 2011-12-14 Ben Konrath <ben@bagu.org>
816 Replace \n with <br/> for multiline text in the details view.
818 Vertical scrollbars are added when needed as well.
820 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
822 2011-12-14 Ben Konrath <ben@bagu.org>
824 Specify the font for document selection links.
826 * src/main/webapp/style.css:
828 2011-12-14 Ben Konrath <ben@bagu.org>
830 Fix bouncy CellTable while paging.
832 This doesn't currently work with related list tables in unselected
835 * src/main/java/org/glom/web/client/ui/list/ListTable.java
837 2011-12-14 Ben Konrath <ben@bagu.org>
839 Revamp the appearance of the document selection page.
841 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
842 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
843 * src/main/webapp/style.css:
845 2011-12-13 Ben Konrath <ben@bagu.org>
847 Set navigation button column to the smallest size possible.
849 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
851 2011-12-13 Ben Konrath <ben@bagu.org>
853 Change OpenButton nomenclature to NavigationButton.
855 Using NavigtionButton makes things more generic. Classes, methods and
856 variables have been changed.
858 This is a rename-only refactor.
860 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
861 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
862 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
863 Renamed from OpenButtonCell.
864 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
865 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
866 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
868 2011-12-12 Ben Konrath <ben@bagu.org>
870 Remove unnecessary String argument in RelatedListTable and ListViewTable.
872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
873 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
874 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
875 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
877 2011-12-12 Ben Konrath <ben@bagu.org>
879 Update variable names and comments.
881 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
882 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
884 2011-12-12 Ben Konrath <ben@bagu.org>
886 Properly initialize numNonEmptyRows variable to zero.
888 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
889 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
891 2011-12-05 Ben Konrath <ben@bagu.org>
893 Add latest mockup with HTML tables.
895 Features of this mockup:
897 -> HTML table for flowtable
898 -> HTML table for flowtable column
899 -> Example of how related lists would look
900 -> Not using text entries for data items
902 The current version of Online Glom doesn't use HTML tables for the
905 This mockup has been sent to the glom-devel mailing list but it's good
906 to have it here as well.
908 * mockups/details-view-html-tables.html:
910 2011-12-05 Ben Konrath <ben@bagu.org>
912 Remove unnecessary getPrimaryKeyField() method.
914 getPrimaryKeyFieldForTable(String) has been renamed to
915 getPrimaryKeyField(String).
917 * src/main/java/org/glom/web/server/database/DBAccess.java:
918 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
919 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
921 2011-12-05 Ben Konrath <ben@bagu.org>
923 Add string representation of TypedDataItem value to conversion error message.
925 * src/main/java/org/glom/web/server/Utils.java: Logging the error
926 message was extracted into its own method to avoid duplication.
928 2011-12-05 Ben Konrath <ben@bagu.org>
930 Add type checking to navigation primary key value creation.
932 Create navigation primary key only if the expected type from the Glom
933 document matches the type returned by the SQL query.
935 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
937 2011-12-05 Ben Konrath <ben@bagu.org>
939 Rename a couple of variables in RelatedListNavigation.
941 This is a rename-only refactor.
943 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
945 2011-12-05 Ben Konrath <ben@bagu.org>
947 Move getListLayoutGroup() into getListViewLayoutGroup().
949 This removes getListLayoutGroup(). It was only being called by
950 getListViewLayoutGroup().
952 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
954 2011-12-05 Ben Konrath <ben@bagu.org>
956 Remove check for LayoutItem_Portal in list table method.
958 This check is no longer necessary because the method isn't being used
959 to create the LayoutItemPortal DTO.
961 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
963 2011-12-05 Ben Konrath <ben@bagu.org>
965 Properly support related list navigation.
967 Navigation from the "Repository Analyzer -> Package Scans ->
968 Dependencies" related table wasn't working because the primary key for
969 related tables wasn't being set properly. This commit fixes the
972 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
973 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
974 doesn't set the primary key properly for related list tables.
975 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
976 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
977 useful for getting the primary key for list view tables and for related
979 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
980 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
981 Move code to set the primary key for the table from the abstract
982 ListDBAccess class to ListViewDBAccess as it's only correct for list
984 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
985 Properly add primary key to related list tables.
987 2011-12-02 Ben Konrath <ben@bagu.org>
989 Properly set the horizontal alignment of fields.
991 This fix is for both the list tables and the details view.
993 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
994 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
995 to set the horizontal alignment of fields.
997 2011-12-02 Ben Konrath <ben@bagu.org>
999 Display currency codes in the details view.
1001 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1003 2011-12-02 Ben Konrath <ben@bagu.org>
1005 Avoid duplicate JNI call.
1007 JNI is not as efficient as pure Java and this is an easy (and small)
1010 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1011 Use previously retrieved value for whereClauseToTableName instead of
1014 2011-12-02 Ben Konrath <ben@bagu.org>
1016 Rename a couple of variables in RelatedListNavigation.
1018 This is a rename-only refactor.
1020 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1022 2011-12-02 Ben Konrath <ben@bagu.org>
1024 Indicate clearly that a mismatched primary key type is a bug.
1026 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1027 warning to error. Add 'This is a bug.' to message.
1029 2011-12-02 Ben Konrath <ben@bagu.org>
1031 Update / fix some comments.
1033 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1035 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1037 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1038 Fix comments. Add some TODOs.
1040 2011-12-02 Ben Konrath <ben@bagu.org>
1042 Enable navigation to details view with string primary key from related list.
1044 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1045 Create a text primary key value when return type of result is
1046 java.sql.Types.VARCHAR.
1048 2011-12-02 Ben Konrath <ben@bagu.org>
1050 Use checkboxes for booleans in the details view.
1052 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1054 2011-12-01 Ben Konrath <ben@bagu.org>
1056 Improve performance of related list height calculation.
1058 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1059 Put code to calculate the expected height in a static initializer so
1060 that that it's only called once.
1062 2011-12-01 Ben Konrath <ben@bagu.org>
1064 Show related list tables in notebooks (again).
1066 Calculate the height of the related list tables so the Notebook can be
1067 set the correct height. The height of the related list table is also needed by
1068 FlowTable to be able decide how to create the layout.
1070 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1071 and set the Portal height based on the height of the related list
1072 table and the Portal container.
1073 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1074 Add method to calculate the height of the related list tables.
1075 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1076 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1077 calculate the height of the Pager widget.
1079 2011-12-01 Ben Konrath <ben@bagu.org>
1081 Use CellTable API for table property instead of setting style on Element.
1083 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1085 2011-12-01 Ben Konrath <ben@bagu.org>
1087 Make ListViewTable and RelatedListTable a consistent height.
1089 The tables are now a consistent height regardless of the contents of
1090 the table. A hidden button is added to empty rows to ensure that the
1091 height of these rows will match the height of rows with data.
1093 A navigation button column is now added to every table. The width of
1094 the navigation column is set to 0px when a RelatedListTable shouldn't
1095 have navigation buttons. This maintains the a consistent row height in
1096 tables that don't show the navigation buttons.
1098 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1099 navigation column when not needed.
1100 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1101 arguments for navigation button to constructor of ListViewTable.
1102 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1103 hidden button for empty data rows.
1104 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1105 arguments for navigation button to constructor.
1106 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1107 create navigation buttons. Add hideNavigationButtons() method.
1108 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1109 arguments for navigation button to constructor.
1111 2011-12-01 Ben Konrath <ben@bagu.org>
1113 Use 'visibility: hidden' in Utils.getWidgetHeight().
1115 This is better choice because hidden elements are invisible, don't
1116 respond to events and are not part of the tab order. They will,
1117 however, take up space which is required to be able to calculate the
1118 height of the widget.
1120 * src/main/java/org/glom/web/client/Utils.java:
1122 2011-12-01 Ben Konrath <ben@bagu.org>
1124 Use Utils.getWidgetHeight() in FlowTable.
1126 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1128 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1130 2011-12-01 Ben Konrath <ben@bagu.org>
1132 Put the details css class name on the correct table column.
1134 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1136 2011-11-30 Ben Konrath <ben@bagu.org>
1138 Update for java-libglom API change.
1140 The getters and setters on FieldFormatting and NumericFormat were
1141 changed to remove the 'M'.
1143 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1145 2011-11-29 Ben Konrath <ben@bagu.org>
1147 Only allow RelatedListTables in Portals.
1149 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1151 2011-11-29 Ben Konrath <ben@bagu.org>
1153 Only create a contents panel for Portals when title is being set.
1155 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1157 2011-11-29 Ben Konrath <ben@bagu.org>
1159 Set TabLayoutPanel height based on calculated height its widgets.
1161 This is a potential fix for this bug:
1163 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1165 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1167 2011-11-29 Ben Konrath <ben@bagu.org>
1169 Align details field labels and data with the Open buttons.
1171 * src/main/webapp/style.css:
1173 2011-11-29 Ben Konrath <ben@bagu.org>
1175 Remove unnecessary <div> in the Notebook widget.
1177 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1178 method to get container FlowPanel (<div>).
1179 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1180 initWidget() method directly on the TabLayoutPanel widget instead of
1181 Group's container widget.
1183 2011-11-29 Ben Konrath <ben@bagu.org>
1185 Don't add group titles for Portals in Notebooks.
1187 This reverts the previous patch and fixes a bug I introduced with
1188 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1190 * src/main/java/org/glom/web/client/ui/details/Group.java:
1191 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1193 2011-11-28 Ben Konrath <ben@bagu.org>
1195 Remove unused boolean argument in Portal constructor.
1197 Just a code cleanup.
1199 * src/main/java/org/glom/web/client/ui/details/Group.java:
1200 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1202 2011-11-28 Ben Konrath <ben@bagu.org>
1204 Remove hack for glom 1.18 style glom files.
1206 * src/main/java/org/glom/web/client/ui/details/Group.java:
1207 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1208 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1210 2011-11-28 Ben Konrath <ben@bagu.org>
1212 Use Gda Value version of primary key to log result too large error.
1214 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1216 2011-11-28 Ben Konrath <ben@bagu.org>
1218 Don't use TypedDataItem.getText() for Unknown types from the URL.
1220 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1221 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1222 instead of getText().
1223 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1224 String field and getUnknown() method.
1226 2011-11-28 Ben Konrath <ben@bagu.org>
1228 Log an error message when the java-libglom .so is not present.
1230 The error message was being set in the exception but not logged.
1232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1234 2011-11-28 Ben Konrath <ben@bagu.org>
1236 Ignore LayoutItem_CalendarPortals.
1238 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1239 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1241 2011-11-28 Ben Konrath <ben@bagu.org>
1243 Extract method for creating the LayoutItemPortal DTO.
1245 Just breaking the code up into smaller chunks.
1247 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1249 2011-11-28 Ben Konrath <ben@bagu.org>
1253 This should have been added with the refactor. Oops!
1255 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1257 2011-11-28 Ben Konrath <ben@bagu.org>
1259 Create primary key value from URL string using type from Glom document.
1261 See this bug, comments 19 - 25:
1263 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1265 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1266 create a TypeDataItem for the primary key here when loading from a
1267 URL. Show the same string for the primary key value as was received
1268 from the URL string (when loading from a URL).
1269 * src/main/java/org/glom/web/server/Utils.java: Update method for
1270 creating the Gda Value from the TypeDataItem to properly deal with
1271 creating a Gda Value based on the Glom document type for the primary
1272 key value string when loading from a URL.
1273 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1274 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1275 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1276 Update for changed method name.
1278 2011-11-27 Ben Konrath <ben@bagu.org>
1280 Rename PrimaryKeyItem to TypedDataItem.
1282 The name PrimaryKeyItem suggests what the class should be used for.
1283 TypedDataItem is a neutral name that describes the class better.
1285 This is a rename-only refactor.
1287 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1288 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1289 * src/main/java/org/glom/web/client/Utils.java:
1290 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1291 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1292 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1293 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1294 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1295 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1297 * src/main/java/org/glom/web/server/Utils.java:
1298 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1299 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1300 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1301 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1303 2011-11-25 Ben Konrath <ben@bagu.org>
1305 Improve Gda Value conversion from PrimaryKeyItem.
1307 The value from the PrimaryKeyItem is only used if its type match the
1308 type from the glom document.
1310 * src/main/java/org/glom/web/server/Utils.java:
1312 2011-11-25 Ben Konrath <ben@bagu.org>
1314 Manually check if the java-liblgom .so is visible to the JVM.
1316 It seems that Tomcat has problems when a static initializer throws an
1317 exception. This check is done before the first method call into
1318 java-libglom so that execution doesn't continue if the .so is not
1321 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1323 2011-11-25 Ben Konrath <ben@bagu.org>
1325 Improve browser configuration error messages.
1329 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1331 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1332 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1333 getConfigurationErrorMessage() method.
1334 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1335 Get and display a specific configuration error message when no Glom
1336 documents are found.
1337 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1338 Implement getConfigurationErrorMessage() method. Surround configuration
1339 code in the init() method with a try/catch block. This allows the
1340 errors to be caught while keeping the servlet available to retrieve the
1341 configuration error message.
1343 2011-11-25 Ben Konrath <ben@bagu.org>
1345 Don't use Strings to hold primary key values.
1347 The primary key values are now held in a new data object
1348 (PrimaryKeyItem) that holds type information and the primary key value
1349 using the correct type.
1351 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1352 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1354 PrimaryKeyItem instead of String to hold the primary key value.
1355 * src/main/java/org/glom/web/client/Utils.java: Remove
1356 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1357 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1358 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1359 PrimaryKeyItem instead of String to hold the primary key value. Load
1360 document selection page when the documentID has not been set correctly.
1361 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1362 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1364 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1365 Return empty string for URL instead of "null".
1366 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1367 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1368 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1369 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1370 PrimaryKeyItem instead of String to hold primary key values.
1371 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1372 PrimaryKeyValue to a Gda Value.
1373 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1374 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1375 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1376 Replace temporary database access code that uses the PrimaryKeyValue to
1377 Gda Value conversion.
1378 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1379 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1380 PrimaryKeyItem instead of String.
1381 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1382 hold primary key values.
1384 2011-11-24 Ben Konrath <ben@bagu.org>
1386 Use newly added java-libglom API to create queries.
1388 This isn't finished. I still need to stop using Strings for primary key
1389 values in the client code.
1391 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1392 libglom to use fake connections so that retrieving the query string will
1394 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1395 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1396 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1397 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1398 Use the newly added libglom sql methods and classes to create the
1399 query. Add temporary hack to convert primary value strings to Gda
1402 2011-11-23 Ben Konrath <ben@bagu.org>
1404 Don't explicitly set the height of Portals.
1406 See comments 6 - 10 of this bug for details:
1408 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1410 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1412 2011-11-23 Ben Konrath <ben@bagu.org>
1414 Use an HTML table instead of CSS for the FlowTable layout.
1416 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1417 GWT's FlexTable to implement the FlowTable.
1418 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1420 2011-11-18 Ben Konrath <ben@bagu.org>
1422 Add boolean example to HTML table mockup.
1424 * mockups/details-view-html-tables-text-entries.html:
1426 2011-11-17 Ben Konrath <ben@bagu.org>
1428 Ensure the pager buttons are always visible for related lists.
1430 To accomplish this, I've turned off text wrapping in the list view and
1431 related list tables for both the header and data text. The related list
1432 table now has a fixed layout so the it doesn't overflow its container.
1433 This is required to ensure that the cell text is clipped when it
1434 overflows the cell and an ellipsis is added to the right side of the
1435 cell when text is clipped.
1437 A fixed table layout for the related list table in the details view
1438 seems what we want for the details view anyway, so the side-effect is
1441 The ellipsis will only be displayed in Firefox >= 7.
1445 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1447 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1448 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1449 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1451 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1452 Set the 'table-layout: fixed' CSS property to the related list table.
1453 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1454 'white-space: nowrap;' CSS property on both the list view and the
1455 related list tables.
1457 2011-11-16 Ben Konrath <ben@bagu.org>
1459 Rework the fix for empty notebook tab labels.
1461 Setting the empty group titles with its name caused problems for the
1462 details layout. Instead of using libglom's
1463 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1464 to the client when the title is empty. This allows the Notebook to use
1465 the name when the title is empty without affecting anything else.
1467 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1468 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1470 2011-11-16 Ben Konrath <ben@bagu.org>
1472 Set group titles with name when title is empty.
1474 This fixes a problem with an empty notebook tab label in the Lesson
1475 Planner document. The forth tab in the notebook should be "Internet":
1477 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1479 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1480 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1483 2011-11-16 Ben Konrath <ben@bagu.org>
1485 Remove whitespace from the configured username properties.
1487 This assumes that usernames won't have whitespace at the beginning
1488 or end. But I think this is a reasonable assumption.
1490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1491 String.trim() to remove the whitespace from the username properties.
1493 2011-11-15 Ben Konrath <ben@bagu.org>
1495 Add details view mockup with HTML tables and text entries.
1497 This is from the attachment on this bug:
1499 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1501 * mockups/details-view-html-tables-text-entries.html:
1503 2011-11-15 Ben Konrath <ben@bagu.org>
1505 Add space between the columns of the flow table.
1509 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1511 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1512 space between columns in the flow table.
1514 2011-11-15 Ben Konrath <ben@bagu.org>
1516 Add backup files to the .gitignore.
1518 * .gitignore: Ignore files that end with ~.
1520 2011-11-09 Ben Konrath <ben@bagu.org>
1522 Use latest release of gwt-log.
1524 Gwt-log releases are now being submitted to the maven central
1525 repository so manual installation of the jar is no longer required.
1527 * pom.xml: Update version and groupId of gwt-log dependency.
1529 2011-10-31 Ben Konrath <ben@bagu.org>
1531 Don't use GWT numeric formatting to override the glom currency formatting.
1533 Currencies are now displayed like they are in Glom. See this bug:
1535 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1537 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1539 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1540 currency code to constructor and set it when the cell is rendered.
1541 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1542 currency code to the constructor of the NumericCell.
1544 2011-10-27 Ben Konrath <ben@bagu.org>
1546 Require the latest release of java-libglom (1.17.4).
1550 2011-10-26 Ben Konrath <ben@bagu.org>
1552 Add style to Notebook that matches current theme.
1554 It's not the best style in the world but it's better than the default.
1556 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1557 padding at the bottom of the child widgets.
1558 * src/main/webapp/style.css: Add style for the Notebook.
1560 2011-10-26 Ben Konrath <ben@bagu.org>
1562 Move servlet initialization code to overridden init method.
1564 This is half of the solution to getting proper error messages
1565 displayed when configuration errors occur. Here's the relevant bug:
1567 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1569 The rest of the solution involves surrounding the init method with a
1570 try/catch block and setting a global variable with the error /
1571 exception. A new async method should be created to retrieve and display
1572 the error message / exception.
1574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1575 code from constructor to init method adding exceptions as needed.
1577 2011-10-26 Ben Konrath <ben@bagu.org>
1579 Add script to monitor and restart tomcat if required.
1581 * utils/check-and-recover-tomcat.py: New file.
1583 2011-10-26 Ben Konrath <ben@bagu.org>
1585 Display the correct number of data items in the pager.
1589 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1591 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1592 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1593 The implementation is the same for both tables: Keep track of the
1594 number of non-empty rows and fire and RowCountChangeEvent after the data has
1596 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1597 custom Pager class that subclasses SimplePager to handle displaying
1598 the correct number when empty rows have been added.
1600 2011-10-26 Ben Konrath <ben@bagu.org>
1602 Correct error in previous commit.
1604 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1605 eventBus parameter from listView.setCellTable().
1607 2011-10-26 Ben Konrath <ben@bagu.org>
1609 Fix error in TODO comment.
1611 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1613 2011-10-24 Ben Konrath <ben@bagu.org>
1615 Create Notebook widgets to the details view.
1617 This isn't finished just yet - I still need to create a reasonable
1618 style to match the current theme.
1620 * src/main/java/org/glom/web/client/Utils.java: Add method for
1621 calculating the height of a widget. This is used in the Notebook class.
1622 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1623 new constructor method in Group.
1624 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1625 method for creating child widget that can be used by subclasses
1626 like Notebook. New constructor that allows disabling the group
1627 titles - Notebooks don't set a group title for their child groups.
1628 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1629 to make Notebooks using GWT's TabLayoutPanel.
1630 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1631 constructor that allows disabling the group titles.
1632 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1633 LayoutItemNotebook DTO.
1634 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1635 DTO for Notebooks. It's just an empty class for now but we might need
1636 it to transfer some specific information in the future.
1638 2011-10-21 Ben Konrath <ben@bagu.org>
1640 Add navigation buttons to related list tables.
1642 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1645 method getSuitableRecordToViewDetails() for getting the table name
1646 and primary key value for related list navigation buttons.
1647 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1648 private cell renderer class to get the navigation information for
1649 related list tables from the server. Extract the navigation
1650 processing code from the details cell navigation and use it for the
1651 related list navigation as well.
1652 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1653 cell renderer class for the details open buttons. This was needed
1654 because the related list navigation buttons and the list view
1655 navigation buttons need to react differently when clicked.
1656 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1657 the onEnterKeyDown() method because it's now overriden in the
1658 subclasses that are specific to the related list tables and the list
1660 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1661 the vertical size a little because the buttons add a bit of vertical
1662 space to table. This is not a perfect solution because the vertical
1663 size of with table fewer than 5 rows will be a little smaller.
1664 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1665 changes in how navigation buttons are handled.
1666 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1667 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1668 database access object.
1669 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1670 to find the portal for a given relationship name from
1671 RelatedListDBAccess. Add method to find a primary key field for a
1673 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1674 Move code to find the portal for a given relationship name to
1676 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1677 New file: database access object for getting the related list
1678 navigation information (the table name and the primary key value).
1679 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1680 DTO for transferring a table name to navigate to and a primary key
1682 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1683 boolean and getter/setter to specifies if the related list should add
1686 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1688 Use the master branch of java-libglom
1690 * pom.xml: Depend on java-libglom 1.19 instead.
1692 This is the master branch. See also the libglom-1-18 branch.
1694 2011-10-11 Ben Konrath <ben@bagu.org>
1696 Enable the open navigation button when the data has been set.
1698 This avoids having active buttons that don't do anything when the data
1701 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1703 2011-10-11 Ben Konrath <ben@bagu.org>
1705 Use IsWidget interface for FlowTableItem.
1707 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1708 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1710 2011-10-11 Ben Konrath <ben@bagu.org>
1712 Remove GWT styling from open button in details view.
1714 There are still some issues with how the details cell is arranged but
1715 this should be made to match Glom 1.20. I'm going to leave fixing this
1716 until I have Glom 1.20 up and running.
1718 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1719 style name on open button.
1720 * src/main/webapp/style.css: Move and edit details-navigation class.
1721 Re-arrange some classes to make them appear in the same order as the
1724 2011-10-07 Ben Konrath <ben@bagu.org>
1726 Update to GWT 2.4.0.
1728 * .gitignore: Ignore new cache directory.
1729 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1730 * pom.xml: Change GWT and maven plugin to 2.4.0.
1731 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1733 * src/main/java/org/glom/web/client/ClientFactory.java:
1734 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1735 * src/main/java/org/glom/web/client/OnlineGlom.java:
1736 Update source for API changes.
1737 * utils/build-onlineglom-war.sh: Remove cache directory before the
1740 2011-10-07 Ben Konrath <ben@bagu.org>
1742 Add navigation buttons in the details view.
1744 This isn't finished but I thought I'd commit what I have as it's a
1745 pretty good start. I still need to:
1747 1. Change the style so that it fits better into the current theme
1748 2. Adjust the details cell to expand as much as possible.
1750 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1751 click handlers to navigation buttons in the DetailsCells. Create a
1752 refreshData() method to get just the data from the server without the
1754 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1755 Update the tableSelector and browser title when the table name
1756 changes without using the tableSelector.
1757 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1758 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1759 getDetailsCells() to getCells(). Update variable names.
1760 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1761 method to set click handler on navigation button. Rename a few
1762 variables. Add navigation buttons where needed.
1763 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1764 variables and methods.
1765 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1766 navigation boolean and navigation table as required in the
1767 LayoutItemField DTO.
1768 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1769 variables for navigation along with getter/setter methods.
1771 2011-10-07 Ben Konrath <ben@bagu.org>
1773 Rename Field to DetailsCell.
1775 This is a refactor-only commit. No functionality has been added or
1778 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1779 Update variable and method names.
1780 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1781 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1782 variable and method names.
1783 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1785 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1786 variable and method names.
1788 2011-10-07 Ben Konrath <ben@bagu.org>
1790 Create separate methods for layout and data the details view.
1792 This is a refactor-only commit. No functionality has been added or
1795 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1796 private methods: setData(), createLayout().
1798 2011-10-07 Ben Konrath <ben@bagu.org>
1800 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1802 This is part of a change to get navigation buttons in the details view
1803 but it should have been done this way from the start.
1805 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1806 for method name change in TableSelectionView.
1807 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1808 Create TableChangeEvent and set the browser title using the
1809 TableSelectionView API.
1810 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1811 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1812 Change getSelectedTable() to getSelectedTableName(). Add
1813 getSelectedTableTitle().
1815 2011-10-07 Ben Konrath <ben@bagu.org>
1817 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1819 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1821 2011-10-07 Ben Konrath <ben@bagu.org>
1823 Update TableChangeEvent to use newTableName naming convention.
1825 This makes the class more consistent with GWT naming conventions.
1827 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1828 Update for method name change in TableChangeEvent.
1829 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1830 for method name change in TableChangeEvent.
1831 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1832 newTableName variable and getter method. Make toDebugString()
1835 2011-09-30 Ben Konrath <ben@bagu.org>
1837 Disable the pager in the list tables when the data row count is less than the minimum.
1839 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1840 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1842 2011-09-30 Ben Konrath <ben@bagu.org>
1844 Add empty rows to the end of related list and list view tables.
1846 I also extracted the cell rendering classes from the ListTable because
1847 the code was becoming a little crazy with all the anonymous inner
1848 classes. My plan is to use these cell rendering classes in the details
1849 view as well so this refactor will be needed for that change.
1851 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1852 set the row count in related list tables if the data has more rows
1853 than the minimum number of rows visible.
1854 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1855 row count in list view tables if the data has more rows than the
1856 minimum number of rows visible.
1857 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1858 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1860 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1861 for rendering TYPE_NUMERIC cells. The code was extracted from the
1863 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1864 class for rendering cells with buttons in list views. The code was
1865 extracted from the ListTable class.
1866 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1867 for rendering TYPE_TEXT cells. The code was extracted from the
1869 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1870 Add empty rows to the end of the data if required. Implement
1871 ListTable.getMinNumVisibleRows().
1872 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1873 cell renderer code to public classes. Return null in
1874 Column.getValue() for empty rows. Add new abstract method:
1875 getMinNumVisibleRows(). Move code to set the row count of the list view
1876 table to ListViewImpl.
1877 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1878 empty rows to the end of the data if required. Implement
1879 ListTable.getMinNumVisibleRows().
1882 2011-09-27 Ben Konrath <ben@bagu.org>
1884 Use GWT.log for client-side debugging statements.
1886 These are optimized out when deployed so I should have used this method
1887 in the first place. These statements will eventually be replaced with some sort
1888 of notification in the browser.
1890 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1891 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1893 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1894 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1896 2011-09-27 Ben Konrath <ben@bagu.org>
1898 Put tableselector on the right, back to list link on right.
1900 The idea is that the table selector is acting like a label for the
1901 currently displayed table so it should be placed below the document title. This
1902 puts the table title in a similar position to where it is in Glom.
1904 * mockups/details-contacts.html:
1905 * mockups/details-projects.html:
1906 * mockups/listview-contacts.html:
1907 * mockups/listview-projects.html:
1908 * mockups/style.css:
1909 Update mockups to match how the interfaces currently look.
1910 * src/main/webapp/style.css: Swap positions of backlink with the table
1911 selector. Add some space on the left side of the table selector to
1912 line things up with the document title.
1914 2011-09-27 Ben Konrath <ben@bagu.org>
1916 Add field colouring to details view.
1918 This change re-works how field colouring works. The colour formatting
1919 information is now set to the client with the layout information instead of
1920 with the data. This eliminates the need to send the same colour strings for
1921 data in list view column when colour information is set.
1923 In order to set an alternate colour for negative numeric values, the
1924 number is now sent to client and formatted with the GWT NumberFormat class.
1926 This change also fixes:
1928 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1930 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1931 internationalization framework which is needed for client side numeric
1933 * src/main/java/org/glom/web/client/Utils.java: New file for some
1934 client static utility methods.
1935 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1936 the DataItem object to the Field class. Use a utility method to
1937 create the foreignKeyValue string.
1938 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1939 alignment and text colours in the constructor. Add setData(DataItem)
1940 method. Remove setText(String) method.
1941 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1942 colour information to GlomTextCell. Create and use GlomNumberCell for
1943 rendering numbers. Use utility method to get the string for the
1944 primary key of the key provider. Re-work how the horizontal alignment
1946 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1947 formatting to layout information. Methods for converting the libglom
1948 formatting information were moved from DBAccess.
1949 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1950 numeric formatting (it's now done on the client side). Don't set text
1951 colours in DataItem. Move libglom formatting conversion methods to
1953 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1954 getters/setters for text colour information.
1955 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1956 for transferring the libglom NumericFormat information to the client.
1957 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1958 and getters/setters for: GlomNumericFormat, background colour and
1959 foreground colour strings.
1961 2011-09-26 Ben Konrath <ben@bagu.org>
1963 Simplify code that iterates through the LayoutGroup.
1965 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1967 2011-09-26 Ben Konrath <ben@bagu.org>
1969 Accept Eclipse formatting for OnlineGlomServiceAsync.
1971 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1973 2011-09-26 Ben Konrath <ben@bagu.org>
1975 Don't use the ListDBAccess classes to get the primary key layout information.
1977 This was causing a bug where the wrong index for the hidden primary key
1978 was being sent to the client.
1980 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1981 primary key while creating the LayoutGroup DTO. Create a
1982 LayoutItemField DTO for hidden primary keys. Don't use the
1983 RelatedListDBAccess because it was only used for getting the primary
1985 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1986 access modifier from public to protected for getPrimaryKeyField() and
1987 getPrimaryKeyLayoutItemField().
1988 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1989 abstract method getExpectedResultSize() because RelatedListDBAccess
1990 doesn't have enough info to implement it.
1991 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1992 Remove @Override for getExpectedResultSize().
1993 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1994 Remove method getExpectedResultSize().
1996 2011-09-23 Ben Konrath <ben@bagu.org>
1998 Log which layout (list or details) the ignored item is from.
2000 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2002 2011-09-23 Ben Konrath <ben@bagu.org>
2004 Remove annotations that turn off code formatting in DataItem.
2006 * src/main/java/org/glom/web/shared/DataItem.java:
2008 2011-09-23 Ben Konrath <ben@bagu.org>
2010 Rename GlomField to DataItem and update associated methods.
2012 This is a rename-only refactor. No functionality has been added or
2015 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2016 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2017 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2018 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2019 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2020 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2021 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2022 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2023 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2024 * src/main/java/org/glom/web/server/database/DBAccess.java:
2025 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2026 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2027 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2028 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2029 * src/main/java/org/glom/web/shared/DataItem.java:
2030 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2031 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2033 2011-09-23 Ben Konrath <ben@bagu.org>
2035 Rename GlomDocument to DocumentInfo and update associated methods.
2037 This is a rename-only refactor. No functionality has been added or
2040 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2041 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2042 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2043 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2044 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2046 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2048 2011-09-20 Ben Konrath <ben@bagu.org>
2050 Require java-libglom 1.17.3.
2052 This picks up the fix for the seg fault problem with the Scenes table
2053 in the Openismus Film Manager example.
2057 2011-09-20 Ben Konrath <ben@bagu.org>
2059 Change the way sort clause is added for primary key when no sort clause is requested.
2061 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2062 before the sort clause is created. When a sort clause is not requested, the
2063 sort clause is created by finding the primary key in the LayoutFieldVector
2066 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2068 2011-09-20 Ben Konrath <ben@bagu.org>
2070 Log error message if no documents are found in the configured directory.
2072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2073 Extract the glom file extension string to a private static final class
2074 variable (mostly as syntactic sugar). Accept a minor formatting change.
2075 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2076 the example glom.document.directory configuration property to make it
2077 more clear that it can any directory, not just the home directory.
2079 2011-09-18 Ben Konrath <ben@bagu.org>
2081 Add related lists to details view.
2083 The related list table has support for paging and sorting just like the
2084 table in the list view.
2086 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2087 SQL queries for the related list tables.
2088 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2089 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2091 Rename getList methods to getListView and add comments. Remove
2092 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2093 it being unused. Add methods: getDetailsLayoutAndData(),
2094 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2095 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2096 Create the layout and set the data for the fields in one async call
2097 instead of two. Create related lists where appropriate.
2098 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2099 for method name changes in OnlineGlomService.
2100 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2101 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2102 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2104 * src/main/java/org/glom/web/client/ui/ListView.java:
2105 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2106 tableName from setCellTable(). Create a ListViewTable instead of
2108 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2109 represent a data field in the details view.
2110 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2111 from addDetailsCell() to Field class. Keep track of the Fields and
2112 Portals in the details view.
2113 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2114 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2115 and add a method to get it. Add method to set the contents of the
2117 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2118 New class for related list tables. This class has the data provider
2119 for the related list table.
2120 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2121 abstract class which is the base class for the ListViewTable and the
2123 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2124 New class for list view tables. This class has the data provider for
2125 the list view table.
2126 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2127 methods for related list tables. Add more information to the
2128 LayoutItemField and LayoutItemPortal DTOs.
2129 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2130 Remove debugging print statement.
2131 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2132 Remove debugging print statements. Add primary key field to SQL count
2134 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2135 Remove unnecessary LayoutFieldVector parameter from
2136 getResultSizeOfSQLQuery() method.
2137 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2138 New class for related list table database access.
2139 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2140 class that is a wrapper DTO for details view layout and data.
2141 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2142 new 'fromField' string to this DTO.
2143 * src/main/webapp/style.css: Remove bottom margin and override top
2146 2011-09-15 Ben Konrath <ben@bagu.org>
2148 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2150 This sets things up to make it easier to add the data retrieval for
2151 related lists (portals). No user noticeable changes were made with
2154 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2155 class has the code to retrieve the layouts and access the
2156 database using the new database helper classes.
2157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2158 Most of the functionality has been removed from this class. This
2159 class now represents the public interface for the client side
2160 code. It also deals with configuring the servlet and cleaning
2161 things up when the servlet is stopped.
2162 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2163 of static methods into this utility class.
2164 * src/main/java/org/glom/web/server/database/DBAccess.java:
2165 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2166 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2167 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2168 These classes have the database retrieval code. The class hierarchy
2169 has been setup to make it easy to reuse code for similar
2172 2011-09-06 Ben Konrath <ben@bagu.org>
2174 Create separate classes for list table code and the data provider.
2176 As part of this refactor, I also split up the code a bit to make it
2179 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2180 table code to two new classes (below).
2181 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2182 with code from ListViewImpl.
2183 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2184 New file with code from ListViewImpl.
2186 2011-09-06 Ben Konrath <ben@bagu.org>
2188 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2190 This fixes the LayoutItemPortal DTO to match the libglom layout object
2193 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2195 2011-09-01 Ben Konrath <ben@bagu.org>
2197 Set title of Portals in the Details View.
2199 * pom.xml: Bump required version of java-libglom to 1.17.1.
2200 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2201 widget creation to its own class. Add comments to constructor.
2202 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2203 The code is mostly from the Group class with the title now set.
2204 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2205 title of Portal. Update some comments. Fix some code formatting.
2207 2011-09-01 Ben Konrath <ben@bagu.org>
2209 Remove TODO comment for the flow table column width.
2211 The flow table column width is working correctly and doesn't need to be
2212 changed. See this mailing list post for more info:
2214 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2216 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2218 2011-08-27 Ben Konrath <ben@bagu.org>
2220 Add document title (database name) to top of the browser page.
2222 I added the document title to the TableSelecitonView but that will
2223 change if / when we add a view that doesn't require table selection.
2225 * mockups/details-contacts.html:
2226 * mockups/details-projects.html:
2227 * mockups/listview-contacts.html:
2228 * mockups/listview-projects.html:
2229 * mockups/style.css: Add document title to mockups to keep things
2231 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2232 sizes to account for the document title.
2233 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2234 Set the document title when it has been retrieved from the server.
2235 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2236 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2237 and implement setDocumentTitle(String) method.
2238 * src/main/webapp/style.css: Add ID for document title style.
2240 2011-08-25 Ben Konrath <ben@bagu.org>
2242 Add NavigationType enum to LayoutItemPortal DTO.
2244 This is the start of adding support for Portals to the Details View.
2246 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2247 LayoutItem_Portal.navigation_type enum from libglom to
2248 LayoutItemPortal.NavigationType enum.
2249 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2250 NavigationType enum, field for storing the NavigationType and getter
2253 2011-08-25 Ben Konrath <ben@bagu.org>
2255 Implement the flow table layout in the Details View.
2257 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2258 FlowTable to Group to account for the renamed class.
2259 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2260 File. This is a container widget that implements the Glom details view
2261 flow table behaviour.
2262 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2263 org/glom/web/client/ui/FlowTable.java.
2264 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2265 so that the size of the subgroups are a closer match to the size of
2266 the Glom subgroups. This makes the flowtable layout match the layout
2267 in Glom for the Music Collection example file.
2269 2011-08-16 Ben Konrath <ben@bagu.org>
2271 Create container element for LayoutItemPortal in Details View.
2273 This will help me develop the layout for the FlowTable.
2275 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2276 fieldPanel variable to detailsCell.
2278 2011-08-15 Ben Konrath <ben@bagu.org>
2280 Set the height of the data element in the Details View.
2282 I changed the InlineLabels (text in a span element) to Labels (text in
2283 a div element) so that I could set the height of the details-data
2284 elements instead of the details-cell parent elements. This allows the
2285 the details-data element to display the correct height if style is
2286 applied that shows the height.
2288 This change has the added benefit of allowing the order of the labels
2289 and data elements to be changed for right-to-left languages.
2291 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2292 InlineLabels to Labels.
2293 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2294 InlineLabels to Labels. Set the height of the data element.
2295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2296 multiline text height in the Formatting DTO.
2297 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2298 for multiline height along with getter and setter methods.
2299 * src/main/webapp/style.css: Adjust style to account for the change
2300 from span elements to div elements in the details cell.
2302 2011-08-15 Ben Konrath <ben@bagu.org>
2304 Make the List View appearance match the mockups.
2306 It doesn't match exactly but it's much better than it was.
2308 * mockups/listview-contacts.html: Remove unused css classes.
2309 * mockups/listview-projects.html: Remove unused css classes.
2310 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2311 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2312 for mainPanel instead of VerticalPanel (table). Set style name on
2313 CellTable. Set style name on Details column. Right-align Details
2315 * src/main/webapp/style.css: Adjust properties to match the mockups.
2317 2011-08-12 Ben Konrath <ben@bagu.org>
2319 Add better support for subgroups in the details view.
2321 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2322 changed FlowTable constructor.
2323 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2324 support for subgroups and subgroup-titles.
2325 * src/main/webapp/style.css: Add CSS class for subgroups and
2328 2011-08-12 Ben Konrath <ben@bagu.org>
2330 Return the top level LayoutGroup title.
2332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2334 2011-08-11 Ben Konrath <ben@bagu.org>
2336 Make the TableSelector header match the mockup.
2338 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2339 the layout panel. Properly lineup the table selection header with
2340 the list and details view.
2341 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2342 margin around the details view.
2343 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2344 Rename listBox variable to tableSelector. Set id for the style sheet.
2345 Use a FlowPanel instead of a HorizontalPanel.
2346 * src/main/webapp/style.css: Add properties to make the TableSelector
2347 box match the mockups.
2349 2011-07-13 Ben Konrath <ben@bagu.org>
2351 Update install script for java-libglom version change.
2353 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2356 2011-07-13 Ben Konrath <ben@bagu.org>
2358 Add support sub-group in the details view.
2360 I also removed the code that special-cased the default details view
2363 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2365 I still have to make a proper flowtable.
2367 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2368 Don't special-case default details view layout.
2369 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2370 addLayoutField() as I'm going to use it.
2371 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2372 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2374 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2375 extracted from DetailsViewImpl.GroupPanel. Add support for
2377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2378 column count when getting the details layout.
2380 2011-07-12 Ben Konrath <ben@bagu.org>
2382 Set browser title with database and table titles.
2384 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2385 Set the browser title when the table changes and when the activity
2387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2388 title when retrieving document info (the GlomDocument object).
2389 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2390 with getter and setter methods. Remove unused convenience constructor.
2391 Use default code formatting.
2393 2011-07-12 Ben Konrath <ben@bagu.org>
2395 Ignore LayoutItemPortals in the details view.
2397 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2400 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2401 LayoutItemPortal layout objects.
2402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2403 LayoutItemPortal objects when retrieving the details layout.
2404 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2405 file. This is an empty class and just used to get type information for
2408 2011-07-12 Ben Konrath <ben@bagu.org>
2410 Use java-libglom 1.17.0.
2414 2011-07-11 Ben Konrath <ben@bagu.org>
2416 Remove "Table:" label from table selector.
2418 This matches a recent change in the Glom UI.
2420 * mockups/details-contacts.html:
2421 * mockups/details-projects.html:
2422 * mockups/listview-contacts.html:
2423 * mockups/listview-projects.html: Remove the "Table:" label from the
2425 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2427 2011-07-11 Ben Konrath <ben@bagu.org>
2429 Add main groups to the details view.
2431 This makes things look a little nicer in the details view. The next step
2432 is to implement the flowtable.
2434 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2435 resources from the standard gwt css theme. Standard.css is now
2436 included in OnlineGlom.html so that the online glom css rules have
2437 precedence over the gwt theme.
2438 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2439 the whole LayoutGroup to the DetailsView instead of just the titles.
2440 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2441 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2442 details layout with a helper class (GroupPanel). I might extract this
2443 class when I make the full flowtable.
2444 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2445 string as default so I don't have to worry about NPEs when processing
2447 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2448 note beside OnlineGlom.gwt.xml above).
2449 * src/main/webapp/style.css: Add default font-size to body to override
2450 the font-size set by the standard theme. Don't use h2 tags for
2451 group-title. Create new details-cell class.
2453 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2455 ConfiguredDocument: Set the port number too.
2457 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2458 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2459 Glom document. Presumably this worked sometimes so far because there is a
2460 default port number.
2462 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2464 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2466 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2467 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2468 correct, though we should throw an exception too.
2470 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2472 Fix a addDocuemnt typo.
2474 * src/main/java/org/glom/web/shared/Documents.java
2475 (Documents.addDocuemnt): Rename to addDocument().
2476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2477 (OnlineGlomServiceImpl.getDocuments): Adapt.
2479 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2481 Slightly improved log output when connection fails.
2483 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2484 (ConfiguredDocument.setUsernameAndPassword):
2485 We don't know for sure if it' the username/password that's wrong, so
2486 rephrase the message.
2487 Also ouput the exception message, though it's generic in this case.
2489 2011-07-08 Ben Konrath <ben@bagu.org>
2493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2494 added braces to a one line if statement because the Eclipse formatter
2495 was getting confused.
2497 2011-07-07 Ben Konrath <ben@bagu.org>
2499 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2501 These should really be two separate tasks but I counldn't get things to
2502 work with GWT 2.2.0 and Eclipse 3.7.
2506 * .settings/org.eclipse.jdt.core.prefs:
2507 * .settings/org.eclipse.jdt.ui.prefs:
2508 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2509 * .settings/org.eclipse.m2e.core.prefs:
2510 Add new config files. Update current files. Remove references to the
2511 webtools plugins as we're not using any of the webtools features.
2512 * .gitignore: Add logs directory which is created when running with
2514 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2515 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2516 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2518 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2520 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2522 onlineglom.properties: Add explanatory comments.
2524 * src/main/resources/onlineglom.properties: Also change the default user
2525 from ben to someuser, to avoid the risk of people thinking we just
2526 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2528 2011-06-28 Ben Konrath <ben@bagu.org>
2530 Use filename in Log for incorrect passwords.
2532 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2533 getFileName(String) method to get the filename from the URI.
2535 2011-06-28 Ben Konrath <ben@bagu.org>
2537 Add the table name to the URL token for the ListPlace.
2539 This makes things consistent between the DetailsPlace and the
2540 ListPlace. It also allows the the ListPlace to be bookmarked.
2542 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2543 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2545 Remove getDefaultListLayout(). The default layout is now returned
2546 by the getListLayout() method when the table name is an empty string.
2547 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2548 Add table name field. Change to a new ListPlace when the table
2549 has been changed. Use getListLayout() for getting the default
2551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2552 Add table name field. Set the correct table name in the list box
2553 when loading from bookmark. This corrects a problem for the
2555 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2556 Move table name to super-class (HasSelectableTable). Move document
2557 and table URL keys to super-class in HasSelectableTable.
2558 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2559 Add table name field. Add Tokenizer class with URL key common to
2560 the subclasses (DetailsPlace and ListPlace).
2561 * src/main/java/org/glom/web/client/place/ListPlace.java:
2562 Add table name. Add code to parse the URL token.
2563 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2564 Update ListPlace construction with empty table name string.
2565 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2566 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2567 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2568 Update ListPlace construction with table name string.
2569 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2570 Change defaultTableName field to tableName to reflect how it's now
2571 used. Update the getter and setter methods.
2573 2011-06-28 Ben Konrath <ben@bagu.org>
2575 Enable the table selector in the DetailsView.
2577 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2578 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2580 Remove getDefaultDetailsLayout(). The default layout is now returned
2581 by the getDetailsLayout() method when the table name is an empty
2583 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2584 event handler for table change event. Change to using
2585 getDetailsLayout() for the default details layout.
2586 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2588 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2589 when navigating to the details place.
2591 2011-06-27 Ben Konrath <ben@bagu.org>
2593 Use filename based unique document ID in URL and for RPC.
2595 The document ID is the glom document name with spaces (' ') replaced
2596 with pluses ('+') and without the .glom extension.
2598 This change is mostly a string substitution of 'documentTitle' for
2599 'documentID'. The only code change is the addition of a Documents DTO to get the
2600 filename to document title mappings as indicated below.
2602 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2603 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2604 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2605 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2606 Use Documents DTO to create the document links in the document
2608 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2609 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2610 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2611 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2612 * src/main/java/org/glom/web/client/place/ListPlace.java:
2613 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2614 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2615 * src/main/java/org/glom/web/client/ui/ListView.java:
2616 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2617 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2618 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2619 * src/main/java/org/glom/web/server/Log.java:
2620 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2621 getDocumentTitles() to getDocuments() and return the Documents DTO.
2622 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2623 transferring the filename to document title mappings.
2625 2011-06-25 Ben Konrath <ben@bagu.org>
2627 Make the authentication popup work again.
2629 This bug was introduced when I extracted ConfiguredDocument to its own class.
2631 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2632 correct success / fail status in setUsernameAndPassword().
2634 2011-06-25 Ben Konrath <ben@bagu.org>
2636 Use filename as unique key for configuring database usernames and passwords.
2638 This replaces the use of the Glom document title which could change
2639 depending on the locale. Thanks to Murray Cumming for pointing out this
2642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2643 * src/main/resources/onlineglom.properties:
2645 2011-06-24 Ben Konrath <ben@bagu.org>
2647 Pass primary key value to DetailsView.
2649 This enables the DetailsView to load the correct data.
2651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2652 primary key value field and set in constructor. Pass primary key
2653 value to getDetailsData().
2654 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2655 variables for document title and primary key value.
2656 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2657 key value to the DetailsPlace.
2659 2011-06-24 Ben Konrath <ben@bagu.org>
2661 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2663 This allows the primary key to be retrieved by the Details button. This
2664 functionality has not been implemented yet but it's in the works.
2666 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2667 the LayoutGroup result to ListView.setCellTable instead of all of its
2668 fields individually.
2669 * src/main/java/org/glom/web/client/ui/ListView.java:
2670 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2671 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2672 get the primary key for the table.
2673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2674 index of the primary key in the LayoutGroup accounting for hidden
2675 primary keys. Rename getJavaNumberFormat() to
2676 convertToJavaNumberFormat() for consistency. Cleanup / add some
2678 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2679 field for primary key index and a field to indicate whether the
2680 primary key is hidden or not.
2682 2011-06-23 Ben Konrath <ben@bagu.org>
2684 Rename getTableData methods to getListData.
2686 This is a rename refactor for consistency with other methods.
2688 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2689 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2690 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2693 2011-06-23 Ben Konrath <ben@bagu.org>
2695 Extract the ConfiguredDocument innerclass into its own class.
2697 This makes the servlet code more object oriented.
2699 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2700 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2701 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2702 new ConfiguredDocument class.
2704 2011-06-21 Ben Konrath <ben@bagu.org>
2706 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2708 This makes things more inline with how libglom works and reduces code
2709 duplication. This refactor lays the groundwork for adding the primary key to
2710 the LayoutGroup object.
2712 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2713 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2715 Change method names to getListLayout and getDefaultListLayout for
2716 consistency. Use LayoutGroup as the DTO for the list layout instead of
2717 ColumnInfo and LayoutListTable.
2718 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2719 new method names along with the LayoutGroup object for transferring the
2721 * src/main/java/org/glom/web/client/ui/ListView.java:
2722 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2723 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2724 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2726 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2727 Replaced with LayoutGroup.
2728 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2729 expectedResultSize and defaultTableName fields which are needed for
2731 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2732 type field which is needed for the list layout but will also be
2733 useful for the details layout as things progress.
2734 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2735 Make class abstract. Remove the unnecessary
2736 getFormattingHorizontalAlignment method. Add setFormatting method.
2738 2011-06-16 Ben Konrath <ben@bagu.org>
2740 Add scripts for building and installing war.
2742 These will help when updating OnlineGlom but they're also good
2743 supplemental documentation of the build and deployment proceeding.
2745 * utils/build-onlineglom-war.sh: New file.
2746 * utils/install-onlineglom-war.sh: New file.
2748 2011-06-16 Ben Konrath <ben@bagu.org>
2750 Create wrapper class to create consistent log messages.
2752 I wrapped methods in the Log class of gwt-log to add the method names
2753 from the servlet and create consistent formatting of the document title
2754 and table names in the log messages.
2756 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2757 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2758 log methods to use methods from wrapped Log class.
2760 2011-06-16 Ben Konrath <ben@bagu.org>
2762 Remove superfluous conditional return.
2764 Thanks to Murray Cumming for pointing this out!
2766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2768 2011-06-15 Ben Konrath <ben@bagu.org>
2770 Return an ArrayList of LayoutGroups for the Details layout.
2772 This corrects a problem with the details layout as it can have more
2773 than one top level LayoutGroup.
2775 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2776 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2777 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2778 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2779 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2780 with ArrayList of LayoutGroups for the details view layout.
2781 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2782 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2783 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2784 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2785 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2786 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2788 2011-06-14 Ben Konrath <ben@bagu.org>
2790 Use cast_dynamic method to determine the libglom LayoutItem type.
2792 This is better than finding the LayoutItem type by using the string
2793 returned from the get_part_type_name() method.
2795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2797 2011-06-14 Ben Konrath <ben@bagu.org>
2799 Add method names to log entries in the servlet.
2801 This helps when tracking down deployment problems.
2803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2805 2011-06-14 Ben Konrath <ben@bagu.org>
2807 Add data to the DetailsView using a hard-coded primary key value.
2809 The layout and functionality of the DetailsView is not complete. This
2810 is just a checkpoint so the patch doesn't get too big.
2812 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2813 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2814 Add getDetailsData() servlet method.
2815 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2816 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2817 LayoutFields are added to the DetailsView.
2818 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2819 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2820 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2821 take the string for the title instead of the object.
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2823 Add implementation getDetailsData() along with some private helper
2825 * src/main/webapp/style.css: Add padding to details-data class. Add a
2826 details-label class with the same padding as the details-data class.
2828 2011-06-03 Ben Konrath <ben@bagu.org>
2830 Use presenter.goTo() to change to the DetailsPlace.
2832 This will make things easier when we need to open the DetailsView with
2833 data specific to the row that was clicked.
2835 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2837 2011-06-02 Ben Konrath <ben@bagu.org>
2839 Add CSS file from mockups.
2841 I'm adding this now because it's going to be useful to have when
2842 developing the DetailsView. The TableSelectionView and ListView aren't
2845 * src/main/webapp/OnlineGlom.html:
2846 * src/main/webapp/style.css:
2848 2011-06-02 Ben Konrath <ben@bagu.org>
2850 Use String.isEmpty() to check for empty string.
2852 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2854 2011-06-02 Ben Konrath <ben@bagu.org>
2856 Display main layout group titles in the DetailsView.
2858 This is the start of the DetailsActivity/DetailsView implementation.
2860 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2861 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2862 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2863 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2864 Get the layout information for the details view from the server and set
2865 the main layout group titles.
2866 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2867 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2868 Add addLayoutGroup() and addLayoutField() methods. This are just
2869 temporary methods for creating the the details view that will change
2871 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2872 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2874 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2875 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2876 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2877 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2878 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2879 Data Transfer Objects that mimic the libglom object structure. These are
2880 used for transferring the details layout but could also be used for
2881 transferring the list layout.
2883 2011-05-27 Ben Konrath <ben@bagu.org>
2885 Reset the AuthenticationPopup when clearing the ListView.
2887 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2889 2011-05-27 Ben Konrath <ben@bagu.org>
2891 Fix problem with onlineglom.properties file loading.
2893 The old way worked in Eclipse but not on the server. Loading the
2894 onlineglom.properties file now works in Eclipse and on the server.
2896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2898 2011-05-24 Ben Konrath <ben@bagu.org>
2900 Update gwt-log from 3.1.0 to 3.1.2.
2902 Gwt-log 3.1.0 has been marked as depreciated.
2906 2011-05-24 Ben Konrath <ben@bagu.org>
2908 Add comment to ListActivity.goTo() method.
2910 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2912 2011-05-24 Ben Konrath <ben@bagu.org>
2914 Remove FIXME in convertGdkColorToHtmlColour()
2916 The Gdk::Color value returned by libglom is 16-bits per channel on both
2917 64 and 32-bit platforms.
2919 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2921 2011-05-19 Ben Konrath <ben@bagu.org>
2923 Improve performance of initial ListView load.
2925 I removed a round trip to the server for getting the default table name
2926 and then requesting information about that table. This also removes a potential
2927 problem with the table change handler not being setup in time to receive the
2928 table change event from the ListActivity.
2930 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2931 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2932 getDefaultLayoutListTable() method. Improve comments.
2933 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2934 getDefaultLayoutListTable() method instead of firing a table change
2935 event to get the table to load.
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2937 implementation of getDefaultLayoutListTable() method.
2938 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2941 2011-05-19 Ben Konrath <ben@bagu.org>
2943 Override toDebugString() in TableChangeEvent.
2945 This is useful to have for debugging.
2947 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2949 2011-05-19 Ben Konrath <ben@bagu.org>
2951 Add a "Back to List" link when at the DetailsPlace.
2953 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2954 Populate the CellTable based on the selected table of the ListBox if
2955 it's set otherwise use the default table. This allows the "Back to
2957 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2958 Remove Place from constructors. Add a setPlace() method. Add
2959 goToPlace() method. Set class as presenter for TableSelectionView.
2960 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2961 Use the same TableSelectionActivity when switching between the List and
2963 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2964 Subclass the new HasSelectableTablePlace. This removes some duplicate
2966 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2967 New class to represent Places that display the TableSelectionView.
2968 * src/main/java/org/glom/web/client/place/ListPlace.java:
2969 Subclass the new HasSelectableTablePlace. This removes some duplicate
2971 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2972 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2973 Add Presenter interface. Add setBackLinkVisible() method. Add
2974 setBackLink() method.
2976 2011-05-18 Ben Konrath <ben@bagu.org>
2978 Enable the "Details" buttons.
2980 Right now only an empty details view is displayed.
2982 * src/main/java/org/glom/web/client/ClientFactory.java:
2983 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2984 Add DetailsView to ClientFactory.
2985 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2986 A basic activity for the details view.
2987 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2988 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2990 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2991 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2993 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2994 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2995 unnecessary super() in constructor.
2996 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2997 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2998 really shouldn't create a new TableSelectionActivity for both the ListPlace
2999 and the DetailsPlace so this should be considered a temporary solution.
3000 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3001 New file. Represents a URL for the details view.
3002 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3003 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3004 A basic details view interface and implementation.
3005 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3006 Enable the "Details" buttons.
3008 2011-05-12 Ben Konrath <ben@bagu.org>
3010 Use a LayoutPanel with multiple display areas for main layout.
3012 This is mostly a refactor in that there are no changes from the user
3013 point of view. These changes are required so that we can swap out the list view
3014 with the details view when the user clicks the "Details" button.
3016 * src/main/java/org/glom/web/client/ClientFactory.java:
3017 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3018 OnlineGlomView. Add TableSelectionView, ListView and
3019 AuthenticationPopup.
3020 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3021 for main layout. Add display regions for main activities. Add
3022 activity manager for for main activities.
3023 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3024 file from parts of the deleted OnlineGlomActivity.
3025 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3026 New file from parts of the deleted OnlineGlomActivity.
3027 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3028 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3029 New files for app wide table change event.
3030 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3031 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3032 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3033 Activity mappers for the main activities replace the deleted app-wide
3035 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3036 Fix a spelling error in he comment.
3037 * src/main/java/org/glom/web/client/ui/ListView.java:
3038 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3039 Renamed from LayoutListView and modified for MVP. This still not a
3040 proper dumb view as prescribed by the MVP pattern but it works for now.
3041 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3042 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3043 New widget stripped out of the deleted OnlineGlomView.
3044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3045 Remove hack that is fixed by this patch.
3047 2011-05-06 Ben Konrath <ben@bagu.org>
3049 Rename OnlineGlomPlace to ListPlace.
3051 The only change besides the rename is that url will now display #list
3052 instead of #Document.
3054 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3055 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3056 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3057 * src/main/java/org/glom/web/client/place/ListPlace.java:
3058 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3060 2011-05-06 Ben Konrath <ben@bagu.org>
3062 Use Presenter for app navigation.
3064 This is the proper way to deal with Place (URL) changes with the MVP
3067 * src/main/java/org/glom/web/client/ClientFactory.java:
3068 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3069 PlaceHistoryMapper and PlaceHistoryHandler.
3070 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3071 PlaceHistoryMapper and PlaceHistoryHandler.
3072 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3073 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3074 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3075 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3076 Add Presenter interface and setPresenter methods. Rename addHyperLink
3077 to addDocumentLink taking only the document title as a parameter.
3079 2011-04-14 Ben Konrath <ben@bagu.org>
3081 Prompt for db username/password if they haven't been set.
3083 This is implemented with a popup widget that is contained within the
3084 OnlineGlomView and managed by the OnlineGlomActivity.
3086 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3087 methods for checking and setting the database username and password.
3088 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3089 new methods for checking and setting the database username and
3091 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3092 Display authentication popup if the JDBC connection to the database
3093 has not been authenticated.
3094 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3096 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3097 for dealing with the authentication popup.
3098 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3099 Implement the methods for dealing with the authentication popup.
3100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3101 try to executed queries if the database connection hasn't been
3102 authenticated. Implement methods for checking and setting the
3103 database username and password.
3105 2011-04-12 Ben Konrath <ben@bagu.org>
3107 Make log messages a little clearer.
3109 Add a dash betweeen the document title and the table name.
3111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3113 2011-04-12 Ben Konrath <ben@bagu.org>
3115 Protect against NPEs when cleaning up database resources.
3117 While this isn't strictly necessary because the exception is caught,
3118 not protecting against the NPEs makes it harder to find the real error
3121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3123 2011-04-12 Ben Konrath <ben@bagu.org>
3125 Move configuration of the servlet to the constructor.
3127 The servlet will be initialized even if the database authentication
3128 information is not set or correct. I still need to add the UI for prompting
3129 the user for the authentication information when it's required.
3131 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3132 javadocs for getDocumentTitles() method.
3133 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3134 Set error message when RPC fails.
3135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3136 glom files directory from the configuration file. Try to set the
3137 database authentication information for the specific document if it's
3138 set and works otherwise try to use the global authentication
3139 information set for the directory.
3140 * src/main/resources/onlineglom.properties: Moved from
3141 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3142 Added detailed comments for the new keys.
3144 2011-04-11 Ben Konrath <ben@bagu.org>
3146 Remove unnecessary @Override in DocumentSelectionViewImpl.
3148 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3150 2011-04-11 Ben Konrath <ben@bagu.org>
3152 Remove center alignment in DocumentSelectionView.
3154 The title element is still centred but the document titles and bottom
3155 sentence are both left-aligned.
3157 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3159 2011-04-11 Ben Konrath <ben@bagu.org>
3161 Change 'Demo' naming convention to 'Document'.
3163 This is just a rename refactor with no functional changes to the code.
3165 * src/main/java/org/glom/web/client/ClientFactory.java:
3166 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3167 * src/main/java/org/glom/web/client/OnlineGlom.java:
3168 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3169 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3170 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3171 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3172 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3173 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3174 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3175 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3176 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3179 2011-04-08 Ben Konrath <ben@bagu.org>
3181 Remove FIXME from safeLongToInt() method.
3183 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3188 2011-04-08 Ben Konrath <ben@bagu.org>
3190 Display an error if no glom documents are found in the specified directory.
3192 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3193 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3194 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3197 2011-04-08 Ben Konrath <ben@bagu.org>
3199 Add copyright header to one more file ... oops.
3201 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3203 2011-04-08 Ben Konrath <ben@bagu.org>
3205 Add copyright header to files without it.
3207 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3208 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3209 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3210 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3211 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3212 * src/main/java/org/glom/web/shared/GlomField.java:
3214 2011-04-08 Ben Konrath <ben@bagu.org>
3216 Add support for accessing multiple glom documents in the servlet.
3218 This completes the demo selection functionality.
3220 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3221 document title to methods.
3222 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3223 document title to methods.
3224 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3225 Set browser window title when the activity starts. Correct name of
3226 document title variable.
3227 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3228 Set browser window title when the activity starts. Set the table
3229 selector change handler after table selector has been set. Clear the
3230 OnlineGlomView when the activity has been stopped.
3231 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the