1 2012-07-22 Murray Cumming <murrayc@murrayc.com>
3 Tests: Make the imports of assert*() consistent.
5 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
6 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
7 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
8 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
9 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
10 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
11 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
12 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
13 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
14 * src/test/java/org/glom/web/shared/DataItemTest.java:
16 import static org.junit.Assert.*;
17 which seems fairly common.
21 2012-07-21 Murray Cumming <murrayc@murrayc.com>
23 tests: Move a test that needs a database connection.
25 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
26 Move testGetListViewLayoutGroup() to
27 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
28 because it needs a database connection.
30 2012-07-21 Murray Cumming <murrayc@murrayc.com>
32 tests: Use @BeforeClass on tearDown().
34 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
35 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
36 This avoids leaking a postgres process in SelfHostExampleTest.
38 2012-07-21 Murray Cumming <murrayc@murrayc.com>
40 tests: Test translations more.
42 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
43 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
44 Test titles in the non-default locale.
46 2012-07-21 Murray Cumming <murrayc@murrayc.com>
48 tests: Add SelfHostConfiguredDocumentTest
50 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
51 username and password, for use by ConfiguredDocument.
52 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
53 This tests some of the ConfiguredDocument API that requires a database connection.
55 2012-07-21 Murray Cumming <murrayc@murrayc.com>
57 Document: Load title translations and test them.
59 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
60 of titles. I am surprised that we do not do this yet.
61 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
62 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
63 Test translations more.
65 2012-07-20 Murray Cumming <murrayc@murrayc.com>
69 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
70 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
71 Set the timeout here too.
73 2012-07-20 Murray Cumming <murrayc@murrayc.com>
75 tests: ConfiguredDocumentTest: Make this pass.
77 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
78 Disable tests that need a database connection.
80 2012-07-20 Murray Cumming <murrayc@murrayc.com>
82 Use Java 1.7 instead of Java 1.6.
84 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
85 to do this twice, at least for Eclipse.
86 This seems OK because it is the current version.
88 2012-07-20 Murray Cumming <murrayc@murrayc.com>
92 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
93 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
94 Avoid using a null Connection.
96 2012-07-20 Murray Cumming <murrayc@murrayc.com>
98 tests: Add a ConfiguredDocument test.
100 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
103 2012-07-20 Murray Cumming <murrayc@murrayc.com>
105 LayoutItemFIeld: getName(): Use the Field if it is set.
107 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
108 getName(): If the full field details have been set, return its name, so that
109 callers do not need to set the name separately.
110 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
111 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
112 so we can count the rows.
114 2012-07-20 Murray Cumming <murrayc@murrayc.com>
116 tests: SelfHoster: Test SqlUtils too.
118 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
119 Retrieve some data and check it too, as in the regular Glom
120 test_selfhosting_new_from_example.cc test.
121 * src/test/java/org/glom/web/server/SelfHoster.java:
122 createConnection(): Make this public.
124 2012-07-20 Murray Cumming <murrayc@murrayc.com>
126 tests: SelfHoster: createConnection(): Do not warn about expected failures.
128 Let the caller say if the connection is expected to fail, to avoid
129 irrelevant error output.
131 2012-07-20 Murray Cumming <murrayc@murrayc.com>
133 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
135 * src/test/java/org/glom/web/server/SelfHoster.java:
136 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
137 due to the inevitable need to retry the connection while the database server
140 2012-07-20 Murray Cumming <murrayc@murray.com>
142 tests: SelfHoster: createConnection(): Set a timeout.
144 * src/test/java/org/glom/web/server/SelfHoster.java:
145 createConnection(): Use setLoginTimeout() because it otherwise seems to take
146 ages to actually return when it fails.
148 2012-07-20 Murray Cumming <murrayc@murrayc.com>
150 tests: SelfHoster: selfHost(): Close the test connection.
152 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
153 When we check that the connection works, close the connection. This seems
154 to not be closed automatically otherwise.
156 2012-07-20 Murray Cumming <murrayc@murrayc.com>
158 Use slf4j-simple to see JDBC errors.
160 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
162 2012-07-19 Murray Cumming <murrayc@murrayc.com>
164 SelfHoster.discoverFirstFreePort(): Close the socket.
166 * src/test/java/org/glom/web/server/SelfHoster.java:
167 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
169 2012-07-19 Murray Cumming <murrayc@murrayc.com>
171 Avoid another code warning in Eclipse Juno.
173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
174 Do instanceof checks on the FileUtils.listFiles() result and its
177 2012-07-13 Murray Cumming <murrayc@murrayc.com>
179 Avoid some code warnings in Eclipse Juno
181 * src/main/java/org/glom/web/server/libglom/Document.java:
182 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
183 * src/test/java/org/glom/web/server/SelfHoster.java
184 createTextFile(): Make sure that the FileOutputStream is closed.
186 2012-06-22 Murray Cumming <murrayc@murrayc.com>
188 Added OnlineGlomPropertiesTest.
190 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
191 Make sure we never return a null string.
192 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
193 Added tests of the OnlineGlomProperties API, using our sample file.
195 2012-06-20 Murray Cumming <murrayc@murrayc.com>
197 Make OnlineGlomProperties be a normal class.
199 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
200 Move OnlineGlomProperties into its own file to be a regular class:
201 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
202 This makes testing simpler.
204 2012-06-15 Murray Cumming <murrayc@murrayc.com>
206 OnlineGlomServiceImpl.init(): Move some code into a new method.
208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
209 Create addDocument().
211 2012-06-15 Murray Cumming <murrayc@murrayc.com>
213 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
216 OnlineGlomProperties.getKey(): Make this more robust by moving the
217 check for *.*.filename to here.
219 2012-06-15 Murray Cumming <murrayc@murrayc.com>
221 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
224 init(): Move knowledge of the config file format into the
225 OnlineGlomProperties inner class.
227 2012-06-15 Murray Cumming <murrayc@murrayc.com>
229 SelfHostExampleTest: Make sure we cleanup on failure.
231 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
232 the use of cleanup() to a tearDown() JUnit method.
236 2012-06-12 Murray Cumming <murrayc@murrayc.com>
238 ConfiguredDocument: Add a primary key to portals at least once.
240 * src/main/java/org/glom/web/server/ConfiguredDocument.java
241 updatePortalsExtras): Fix a typo so that we add the primary key
242 column at least once.
243 This is a fix for the previous commit:
244 ConfiguredDocument: Do not add a primary key to portals each time.
246 2012-06-08 Murray Cumming <murrayc@murrayc.com>
248 SelfHoster: Avoid some compiler warnings.
250 * src/test/java/org/glom/web/server/SelfHoster.java
251 executeCommandLineAndWait():
252 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
253 the now-unused streams for stdout and stderr from the command Processes.
254 These are not used because readln() hangs while waiting for a new line,
255 where there may be no next line. The commented out code is still there
256 to help us figure out how to do this properly.
258 2012-06-08 Murray Cumming <murrayc@murrayc.com>
260 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
262 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
263 Make this actually test the cloning again, though it is not very useful
264 now that we do not use the part that had a problem with cloning before.
266 2012-06-08 Murray Cumming <murrayc@murrayc.com>
268 SelfHoster: Keep trying pg_ctl after starting postgres.
270 * src/test/java/org/glom/web/server/SelfHoster.java
271 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
272 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
273 regular Glom. This seems mad but it seems to work because the first
274 command would fail if pg_ctl would eventually fail.
276 2012-06-08 Murray Cumming <murrayc@murrayc.com>
278 SelfHoster: Wait until the server is really ready.
280 * src/test/java/org/glom/web/server/SelfHoster.java
281 selfHost(): Attempt the connection after starting the server, retrying
282 a few times if necessary, so that the server is really ready already when
283 we return from this method.
284 The regular Glom code does this too because pg_ctl reports success too soon.
286 2012-06-08 Murray Cumming <murrayc@murrayc.com>
288 ConfiguredDocument: Do not add a primary key to portals each time.
290 * src/main/java/org/glom/web/server/ConfiguredDocument.java
291 updatePortalsExtras(): Only add an extra primary key field if there is
292 none, to avoid adding one each time we retrieve the details layout from the
294 This should fix bug #676986 (Ben Konrath)
296 2012-05-25 Murray Cumming <murrayc@murrayc.com>
298 Document.load(): Support version 7 documents.
300 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
301 database_title attribute if the title attribute is not there.
304 2012-05-24 Ben Konrath <ben@bagu.org>
306 Add configuration for auto-generating mvn:i18n from with Eclipse.
308 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
310 2012-05-24 Murray Cumming <murrayc@murrayc.com>
312 Update translations, adding French.
314 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
315 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
316 Add a French translation, using the translation from Glom.
318 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
319 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
320 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
321 Update these based on the translations from Glom.
323 2012-05-24 Murray Cumming <murrayc@murrayc.com>
325 SelfHoster: Add some debug println messages to help when things fail.
327 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
328 System.out.println() lines.
330 2012-05-23 Murray Cumming <murrayc@murrayc.com>
332 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
334 * src/test/java/org/glom/web/server/SelfHoster.java:
335 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
336 instance) instead of just /usr/bin (as on Fedora). Check the result when
339 2012-05-23 Murray Cumming <murrayc@murrayc.com>
341 Remove LayoutItemPortal.get/setNavigationTable().
343 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
344 Remove get/setNavigationTable(), which is only a cache, because it is not
345 used, and does not need to be used, because that decision should be made on
347 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
348 updatePortalsExtras():
349 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
350 getNavigationRecord():
351 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
354 2012-05-21 Murray Cumming <murrayc@murrayc.com>
356 Initial self-hosting for tests.
358 * pom.xml: Change the scope for log4j, to hopefully make it
359 available to the test code which uses it indirectly via jOOQ.
360 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
361 self-hosting, though we only use it for testing.
363 * src/main/java/org/glom/web/server/libglom/Document.java:
364 example rows: Use a map instead of a list for each row of values,
365 so we know what field they are for, instead of relying on the sequence
366 being correct. This is not very efficient, but it does not really need
368 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
369 testReadTableExampleRows(): Adapted.
371 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
372 that returns an Object, for generic use. Note that Object seems to be
373 the implicit base even of double.
374 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
375 for use in CREATE TABLE SQL queries.
376 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
377 to do self-hosting of PostgreSQL databases via its command-line
378 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
379 backends/postgres_self.cc. This is incomplete - it needs more
380 warnings about failures and it needs to clean up properly when things
382 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
383 test of this new class.
385 2012-05-21 Murray Cumming <murrayc@murrayc.com>
387 Document: loading example data: Handle exceptions.
389 * src/main/java/org/glom/web/server/libglom/Document.java:
390 DateFormat.parse() and Double.valueOf() can throw exceptions, though
391 Eclipse did not warn about that.
393 2012-05-20 Murray Cumming <murrayc@murrayc.com>
395 Document: load(), save(): Handle the example rows.
397 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
399 * src/main/java/org/glom/web/server/libglom/Document.java:
400 load(), save(): Load and save the example rows, though the date, time
401 and image types are not handled properly yet.
402 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
403 Add testReadTableExampleRows() just to check that something is read.
405 2012-05-20 Murray Cumming <murrayc@murrayc.com>
407 Document: Add save().
409 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
410 Added getTranslationsMap() for use while saving.
411 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
412 Adedd getUseDefaultFormatting() for use while saving.
413 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
414 and several private methods that it uses.
416 This will be useful while testing via self-hosting.
417 It is not complete, but should be complete enough for testing.
419 2012-05-17 Murray Cumming <murrayc@murrayc.com>
421 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
423 * src/main/java/org/glom/web/client/OnlineGlomService.java
424 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
425 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
426 Remove getSortedListViewData() and getSortedRelatedListData(), adding
427 the sort column index and ascending bool to the regular method.
428 Instead, a sort column index of -1 now means no sort.
429 This is less explicit, but it's fairly simple, reduces the amount of
430 code, and makes the OnlineGlomService API slightly smaller.
431 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
432 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
434 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
435 getListViewData(), getRelatedListData():
436 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
437 getListViewData(), getRelatedListData():
438 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
440 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
442 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
447 2012-05-16 Murray Cumming <murrayc@murrayc.com>
449 Use translations for top-level groups too.
451 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
452 updateTitlesForLocale(): Use the translation for the group
453 as well as for child items.
457 Just recompiled to fix a problem in the released .tar.gz file.
461 2012-05-15 Murray Cumming <murrayc@murrayc.com>
463 Corrections to navigation to related records.
465 * src/main/java/org/glom/web/client/OnlineGlomService.java:
466 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
468 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
469 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
470 relationship name, because the relationship name is not necessarily unique
472 TOOD: This is inefficient, because it passes the whole list of
473 child field items back to the server, but it is more correct, and happens
474 to fix a bug with the primary key being lost after a few navigations.
475 There is probably a chance to make this more efficient anyway in some
478 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
480 * src/main/java/org/glom/web/server/ConfiguredDocument.java
481 * src/main/java/org/glom/web/server/database/DBAccess.java
482 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
483 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
486 2012-05-15 Murray Cumming <murrayc@murrayc.com>
488 Fix the use of translations.
490 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
491 Add updateTitlesForLocale().
492 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
493 Call it to discard unwanted translations and to make getTitle() return
494 the wanted translation wihout the need for the client code to specify a locale.
495 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
496 getTitle(): Fallback to the original title, as libglom does.
498 2012-05-15 Murray Cumming <murrayc@murrayc.com>
500 Document: Correctly report the number of available translation locales.
502 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
503 the available locale IDs list.
504 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
505 testLocales: Test this.
507 2012-05-15 Murray Cumming <murrayc@murrayc.com>
509 SqlUtils: Use camelCase.
511 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
512 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
513 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
514 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
515 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
516 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
518 2012-05-15 Murray Cumming <murrayc@murrayc.com>
520 Use jOOQ's tableByName() and fieldByName.
522 * pom.xml: Use jOOQ 2.3.1 to get the new API.
523 * src/main/java/org/glom/web/server/SqlUtils.java:
524 build_sql_select_step_with_where_clause(), .createField(),
525 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
526 so we can get correct quoting and escaping. Thanks to Lukas Eder for
527 adding this, and other things, to jOOQ.
529 2012-05-15 Murray Cumming <murrayc@murrayc.com>
531 SqlUtils: Remove the Connection parameters.
533 * src/main/java/org/glom/web/server/SqlUtils.java:
534 build_sql_select_with_key(), build_sql_select_with_where_clause(),
535 createSelect(), build_sql_select_step_with_where_clause(),
536 build_sql_count_select_with_where_clause(),
537 build_sql_select_count_rows(): Remove the Connection parameter because
538 jOOQ does not actually need a connectionwhen it is just used to build
540 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
542 * src/main/java/org/glom/web/server/ReportGenerator.java:
544 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
546 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
547 Constructor, getListData(), getResultSizeOfSQLQuery():
548 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
549 getSelectQuery(), getCountQuery():
550 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
551 getSelectQuery(), getCountQuery():
552 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
553 getNavigationRecord(): Adapted.
555 2012-05-14 Murray Cumming <murrayc@murrayc.com>
559 * src/main/java/org/glom/web/server/SqlUtils.java:
560 get_find_where_clause_quick(): Use a comparison of
561 lowercase values, instead of a simple equals. Regular Glom
562 uses the PostgreSQL ILIKE operator but jOOQ does not
563 support that just yet, though it will soon.
565 2012-05-14 Murray Cumming <murrayc@murrayc.com>
567 TableToViewDetails: Use a real serialization ID.
569 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
570 Though this does not fix the serialization problem.
572 2012-05-12 Murray Cumming <murrayc@murrayc.com>
574 Added LayoutItemPortalDeepCloneTest.
576 2012-05-11 Murray Cumming <murrayc@murrayc.com>
578 Make navigation work again.
580 * src/main/java/org/glom/web/server/libglom/Document.java:
581 Add getLayoutItemFieldShouldHaveNavigation().
582 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
583 Replace get/setAddNavigation() with the partly-existing
584 get/setNavigationTableName(), with an empty string being no navigation,
585 because this is simpler. Use the new
586 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
588 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
589 Add updateFieldsExtras() and call setNavigationTableName in it.
590 getDetailsLayoutGroup(),
591 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
592 createLayout(): Adapted.
593 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
594 Constructor: Adapted.
596 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
597 Replace get/setAddNavigation() with get/setNavigation(), returning a
598 TableToViewDetails class with both the table name and UsesRelationship,
599 because both are need. The previous code used java-libglom's output
600 variable (strangely, via sharedptr) to return both, but we cannot really
602 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
603 getNavigationRecord(): Adapt. However, we cannot actually use the cache
604 here because it somehow gets set to null during deepCopy(). I must test this.
605 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
606 testGetSuitableTableToViewDetails(): Adapted.
608 TODO: Find out why deepClone() is not quite working.
610 2012-05-11 Murray Cumming <murrayc@murrayc.com>
612 DBAccess: Simplify the retrievel of full field details.
614 * src/main/java/org/glom/web/server/database/DBAccess.java
615 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
616 because the Document loading should have done this.
618 2012-05-11 Murray Cumming <murrayc@murrayc.com>
620 Document: Correct loading of doubly-related layout fields.
622 * src/main/java/org/glom/web/server/libglom/Document.java:
623 loadUsesRelationship(): Actually set the related relationship, instead
624 of only setting it if it's not found.
626 2012-05-09 Murray Cumming <murrayc@murrayc.com>
628 Replace all appearances of Colour with color.
630 Because US English is dominant.
632 2012-05-09 Murray Cumming <murrayc@murrayc.com>
634 Use colors in HTML format, solving a warning about an unused function.
636 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
637 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
638 Add *asHTMLColor() versions of methods.
639 TODO: However, we should create and cache the results on the server.
640 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
641 * src/main/java/org/glom/web/client/ui/list/ListTable.java
642 * src/main/java/org/glom/web/server/ConfiguredDocument.java
643 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
644 Use the asHTMLcolor() versions.
646 2012-05-09 Murray Cumming <murrayc@murrayc.com>
648 ListViewTable: Constructor: Take the table name as a parameter.
650 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
651 Constructor: Take the tableName, and set the member variable, because
653 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
654 setCellTable(): Pass the table name.
655 This makes navigation to non-default tables work again. I don't know
656 why it worked before in the master branch.
658 2012-05-07 Murray Cumming <murrayc@murrayc.com>
660 ConfiguredDocument: Restore correct addition of hidden primary key items.
662 * src/main/java/org/glom/web/client/ui/list/ListTable.java
663 (ListTable.createCellTable): Uncomment out the check for the hidden
665 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
666 add primary key items for top-level lists and portals, as before,
667 instead of adding them to each group.
668 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
669 Actually implement the extra methods such as setHiddenPrimaryKey() and
670 comment that these are used only for top-level list groups and in portals.
671 This strangeness suggests even more that this should not be squeezed
672 into the LayoutGroup class.
674 2012-05-07 Murray Cumming <murrayc@murrayc.com>
676 Fix Formatting loading.
678 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
679 getFormattingUsed(): Remove the duplicate Formatting member variable
680 in favour of the one from the base class.
681 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
682 Initialize a new Formatting instead of using null by default, so we
683 have some defaults, instead of having to initialize one later just to
684 get the same defaults. This also makes loading of formatting from the
685 document work, because that expected a non-null.
687 2012-05-07 Murray Cumming <murrayc@murrayc.com>
689 RelatedListTable: Make sure that the tableName is set.
691 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
692 Constructor: Take the tableName so it is available later. Otherwise,
693 the server assumes that we mean the default table and cannot find the
695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
696 setData(): Pass the tableName to the RelatedListTable constructor.
698 2012-05-07 Murray Cumming <murrayc@murrayc.com>
702 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
703 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
704 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
706 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
708 * src/main/java/org/glom/web/server/database/DBAccess.java:
709 convertResultSetToDTO(), getPortal():
710 * src/main/java/org/glom/web/server/database/ListDBAccess.java
712 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
713 Add checks for null objects and out of range access, with log messages to
714 give hints so we can fix these properly.
716 2012-05-07 Murray Cumming <murrayc@murrayc.com>
718 Portals: some corrections.
720 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
722 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
723 constructor: Use getRelationshipNameUsed() instead of getName(), because
724 that is what is meant.
725 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
726 getFromField(): Fix a typo, to get the field name, not the table name.
727 * src/main/java/org/glom/web/server/database/DBAccess.java:
728 getPortal(): Fix a typo that stopped this from working.
730 2012-05-07 Murray Cumming <murrayc@murrayc.com>
732 LayoutItemPortal: Also override getTitleOriginal().
734 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
735 This lets the base getTitle() with no parameters work.
736 TODO: Test this properly.
738 2012-05-06 Murray Cumming <murrayc@murrayc.com>
740 LayoutItemPortal: getTitle*(): Use the relationship title.
742 2012-05-06 Murray Cumming <murrayc@murrayc.com>
744 LayoutItemField: Fix loading of custom titles.
746 * src/main/java/org/glom/web/server/libglom/Document.java
747 loadDataLayoutItemField(): The title, if any, instead of the field
748 title, is stored in a title_custom node. Load it from there.
749 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
751 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
752 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
753 getTitle*() overrides.
754 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
757 2012-05-06 Murray Cumming <murrayc@murrayc.com>
759 LayoutItemField: Fall back to field titles, so some are really shown.
761 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
762 Override getTitleOriginal() and getTitle(), as in java-libglom.
763 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
766 2012-05-06 Murray Cumming <murrayc@murrayc.com>
768 Correct use of setExpectedResultSize().
770 * src/main/java/org/glom/web/server/ConfiguredDocument.java
771 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
772 Use setExpectedResultSize only on top-level groups (for instance, the
773 list layout) or on child portals (in details views).
774 Use the correct table name for portals to avoid SQL errors.
775 Update the expected counts when returning cached layouts.
777 2012-05-06 Murray Cumming <murrayc@murrayc.com>
779 Document: Interpret no group column count as 1.
781 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
782 default, though we now check for this in the UI code anyway.
784 2012-05-06 Murray Cumming <murrayc@murrayc.com>
788 2012-05-06 Murray Cumming <murrayc@murrayc.com>
790 Translatable: Use Hashmap instead of Treemap because GWT supports it.
792 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
793 The use of Treemap lead to this error from async methods, with no
795 "The response could not be deserialized"
797 2012-05-06 Murray Cumming <murrayc@murrayc.com>
799 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
801 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
802 when using the Google -> GWT Compile, or
803 g toolbar button -> GWT Compile Project... feature in Eclipse.
805 2012-05-06 Murray Cumming <murrayc@murrayc.com>
807 ListTable.addColumn(): Protect against a null Formatting.
809 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
810 Create a default Formatting if it is null, because that is the simplest
813 2012-05-06 Murray Cumming <murrayc@murrayc.com>
815 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
817 * src/main/java/org/glom/web/server/ConfiguredDocument.java
818 updateLayoutGroup(): Check that the field is not null.
820 2012-05-06 Murray Cumming <murrayc@murrayc.com>
822 ListViewImpl: Protected against a bad cast error.
824 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
825 onEnterKeyDown(): Do not cast without an instanceof check.
827 2012-05-06 Murray Cumming <murrayc@murrayc.com>
829 ListTable: Protect against an out of range error.
831 * src/main/java/org/glom/web/client/ui/list/ListTable.java
832 createCellTable(): This is unlikely, but can happen while debugging.
834 2012-05-06 Murray Cumming <murrayc@murrayc.com>
836 AsyncMessage onFailure() callbacks: Log the exception message.
838 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
839 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
840 * src/main/java/org/glom/web/client/activity/ListActivity.java:
841 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
842 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
843 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
844 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
845 These are useful clues when something is wrong.
847 2012-05-06 Murray Cumming <murrayc@murrayc.com>
849 ConfiguredDocument: Avoid a null dereference.
851 * src/main/java/org/glom/web/server/ConfiguredDocument.java
852 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
853 details maps are created.
855 2012-05-06 Murray Cumming <murrayc@murrayc.com>
857 Document: Correct the port number parsing.
859 * src/main/java/org/glom/web/server/libglom/Document.java:
860 This lets us actually connect to the database and show the document.
862 2012-05-05 Murray Cumming <murrayc@murrayc.com>
866 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
867 user-interaction, asking us to load a temporary URL in a browser.s
868 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
869 which is apparently necessary for testing the service. See the comment.
870 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
871 Show the exception, if any. This is how I saw the 404 in the HTML in
874 2012-05-05 Murray Cumming <murrayc@murrayc.com>
876 DocumentTest: Move the .glom files into the resources directory.
878 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
879 URI via getResource().
881 2012-05-05 Murray Cumming <murrayc@murrayc.com>
883 Document: Remove the FieldIdentifies inner class.
885 * src/main/java/org/glom/web/server/libglom/Document.java: We only
886 use the Relationship (though the same function in libglom is maybe
887 used in other ways) and so this removes a compiler warning.
889 2012-05-05 Murray Cumming <murrayc@murrayc.com>
891 Document.load() Remove the error code parameter.
893 * src/main/java/org/glom/web/server/libglom/Document.java: load():
894 Remove the parameter. We do not set it yet and it could never have
895 worked as an output parameter (though maybe it did in java-libglom).
896 We could use an exception if we really want the failure reason.
897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
899 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
900 setUp(), testGetSuitableTableToViewDetails(): Adapt.
902 2012-05-05 Murray Cumming <murrayc@murrayc.com>
904 Make some inner classes static.
906 * src/main/java/org/glom/web/server/ConfiguredDocument.java
907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
908 * src/main/java/org/glom/web/server/ReportGenerator.java
909 * src/main/java/org/glom/web/server/libglom/Document.java
910 Make all inner classes static that can be static.
912 2012-05-05 Murray Cumming <murrayc@murrayc.com>
914 OnlineGlomServiceImpl: Do not load and check for java-libglom.
916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
917 init(): We do not use java-libglom any more.
919 2012-05-05 Murray Cumming <murrayc@murrayc.com>
921 Remove mentions of java-libglom.
923 * README: Remove mention of java-libglom, because it no longer needed.
924 * utils/build-onlineglom-war.sh:
925 * utils/check-and-recover-tomcat.py:
926 * utils/install-onlineglom-war.sh: Remove these as they are no longer
927 useful. Building is now far easier, with no need for jhbuild.
929 2012-05-05 Murray Cumming <murrayc@murrayc.com>
931 Fix the build (mvn package)
933 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
934 (LayoutGroup): Make the LayoutItemList inner class static and protected.
935 Otherwise the GWT Java->Javascript compilation fails with just this
936 error, during mvn package or when attempting to view in a browser,
937 in the GWT developer mode in Eclipse.
939 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
940 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
941 [INFO] Compiling module org.glom.web.OnlineGlom
942 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
943 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
944 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
945 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
946 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
947 [INFO] [ERROR] Cannot proceed due to previous errors
949 It has taken me 2 days to find out what was causing that. After reducing
950 the code, the compiler eventually showed me the full error message.
952 2012-05-04 Murray Cumming <murrayc@murrayc.com>
954 ConfiguredDocument: Cache the cloned and stripped layouts.
956 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
957 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
958 layout in a map, so we can retrieve it again without rebuilding it.
960 2012-05-04 Murray Cumming <murrayc@murrayc.com>
962 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
964 2012-05-04 Murray Cumming <murrayc@murrayc.com>
966 libglom classes: Implement some auto-generated emthods.
968 2012-05-04 Murray Cumming <murrayc@murrayc.com>
970 Add GwtTestOnlineGlomService.
972 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
973 However, this (and the other GwtTest*) does not seem to run during
976 2012-05-04 Murray Cumming <murrayc@murrayc.com>
978 Remove use of unsupported features from client code.
980 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
981 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
982 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
983 Use our client version of StringUtils instead of the apache commons one.
985 However, the GWT Javascript compliation still fails.
987 2012-04-25 Murray Cumming <murrayc@murrayc.com>
989 Add a Field class and implement some loading of it in Document.
991 2012-04-25 Murray Cumming <murrayc@murrayc.com>
993 Initial Document loading implementation, instead of libglom.
995 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
996 and Translatable classes, and adapt the rest of the code to use them.
997 However, this is still missing Layout and Field classes and loading.
999 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1001 Use of jOOQ: Move Field creation into a utility method.
1003 * src/main/java/org/glom/web/server/SqlUtils.java:
1004 This lets us improve it more easily.
1006 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1008 Use of jOOQ: Improve the code to COUNT a sub-select.
1010 * src/main/java/org/glom/web/server/SqlUtils.java:
1011 Move initial query creation into
1012 build_sql_select_step_with_where_clause().
1013 build_sql_select_count_rows(): Use the jOOQ API instead of
1014 concatentating text, because a jOOQ Select*Step is a TableLike,
1015 which is what from() takes.
1017 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1019 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1021 * pom.xml: Depend on jooq.
1022 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1023 methods with jOOQ, based on the C++ implementations in libglom,
1024 with some changes to the logic required by jooQ.
1025 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1027 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1028 * src/main/java/org/glom/web/server/ReportGenerator.java:
1029 * src/main/java/org/glom/web/server/SqlUtils.java:
1030 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1031 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1032 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1033 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1034 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1035 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1036 because jOOQ needs that, though it seems unnecessary.
1038 This is not quite finished. Ideally jOOQ would help us to build
1039 table_name.field_name names, quoting and escaping them properly.
1040 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1042 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1044 Move use of Glom.build_sql*() into a new SqlUtils class.
1046 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1047 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1048 but this will make it easier to start using something other than
1049 libglom or SqlBuilder.
1051 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1053 Update the project URL.
1055 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1057 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1059 Main layout: Use a FlowTable instead of absolute positioning.
1061 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1062 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1063 child panels/widgets must have an absolute position. But that is annoying, so
1064 this adds a FlowTable and puts the child panels in there.
1066 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1068 GwtTestOnlineGlom: Comment out unused code.
1070 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1071 Eclipse has started to say that some code is unused.
1073 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1075 Update to the latest versions of dependencies.
1077 * pom.xml: Update version numbers of dependencies to the latest
1079 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1080 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1081 * src/main/java/org/glom/web/server/ReportGenerator.java:
1082 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1083 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1084 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1086 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1087 Modify the imports where necessary.
1089 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1091 Style: Remove overflow:hidden from searchbox
1093 * src/main/webapp/style.css: Because this pushes the Back To Link
1094 label/link on to the next row, which is then hidden due to the
1095 hard-coded (in ems) height.
1097 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1099 Remove some duplicate code.
1101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1102 getDocumentInfo(): This must have been duplicated during the merge from the
1107 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1109 Reports: Localize the waiting for report message.
1111 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1112 start(): Get the message from the contants.
1113 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1114 Add the string here.
1115 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1116 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1117 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1118 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1119 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1120 Update these files with the English text for newer strings for now.
1122 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1124 Reports: Show a message while waiting for the report.
1126 * src/main/java/org/glom/web/client/ui/ReportView.java
1127 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1128 Add setWaitingText(), to show a message saying that we are
1129 waiting for the report to be ready.
1130 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1131 start(): Call setWaitingText() before calling the async
1134 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1136 ReportGenerator: Specify date and time formats.
1138 * src/main/java/org/glom/web/server/ReportGenerator.java:
1139 createFieldValueElement(): Use the default (and localized)
1140 short formats, though we still need a way to show 4-digit
1141 years without providing the format for every locale.
1142 * src/main/java/org/glom/web/server/database/DBAccess.java:
1143 convertResultSetToDTO(): Use the short formats here too.
1145 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1147 ReportGenerator: Use the correct numeric formatting.
1149 * src/main/java/org/glom/web/server/ReportGenerator.java
1150 createFieldExpression(), createFieldValueElement(): Take the
1151 whole LayoutItem_Field instead of just the field name, so
1152 we have access to the formatting.
1153 createFieldValueElement(): Use JRTextField.setPattern() to
1154 specify the numeric formatting, with the help of a
1155 regular DecimalFormat.
1157 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1159 ReportGenerator: Avoid showing null for group by titles.
1161 * src/main/java/org/glom/web/server/ReportGenerator.java
1162 generateReport(): Use setBlankWhenNull() on the field title
1163 style too, because this is used for values in group by
1166 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1168 ReportGenerator: Add a colon to titles in vertical groups.
1170 * src/main/java/org/glom/web/server/ReportGenerator.java
1171 addFieldToDetailBandVertical(): Pass true for the withColon
1174 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1176 ReportGenerator: Simplify the code by using Position more.
1178 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1180 Reports: Support vertical groups, roughly.
1182 * src/main/java/org/glom/web/server/ReportGenerator.java:
1183 addToReport(): Rename to addGroupToReport() and, if necessary,
1184 call the new addVerticalGroupToReport() method.
1185 createFieldValueElement(): Let the caller specify the Y position
1188 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1190 Reports: Allow a second report to be shown.
1192 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1193 clear(): Do not remove the HTML widget, which broke the whole layout.
1195 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1197 Locales drop-down: Show that we use English by default.
1199 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1200 fillView(): When we use English, just because that is the default, when
1201 no locale is specified, show that in the Locales drop-down instead of
1202 just showing the first item.
1204 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1206 Unselect the Report/Locale/Table combo item when appropriate.
1208 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1209 setPlace(): clear reportName if this is not a ReportPlace.
1210 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1211 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1212 When the provided name is empty, unselect all items, so that none are
1213 indicated. This uses a for loop because I cannot find a single method
1216 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1218 Report: Give the user a way to get back to the list.
1220 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1221 start(), setPlace(): Show the Back To List link on reports, and also
1222 interpret selecting the empty report item as back to list.
1224 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1226 Really show the selected Report name.
1228 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1229 setPlace(): Store the reportName here, if it is that kind of Place.
1230 fillView(): Set the selected Report after filling the list of reports.
1231 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1232 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1233 null Strings, though we need some way to unselect all ListBox items
1236 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1238 ReportGenerator: Try to avoid some problems.
1240 * src/main/java/org/glom/web/server/ReportGenerator.java
1241 addField(): Try to avoid duplicates, and avoid using a null
1244 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1246 Reports: Use quickFind.
1248 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1249 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1251 getReportHTML(): Add a quickFind parameter.
1252 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1253 start(): Pass the quickFind parameter.
1254 * src/main/java/org/glom/web/server/ReportGenerator.java
1255 generateReport(): Take a quickFind parameter.
1257 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1259 ReportPlace: Actually use the report name.
1261 * src/main/java/org/glom/web/client/place/ReportPlace.java
1262 getPlace(): Do not assign the report name to the quickfind.
1264 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1266 Show java.library.path when complaining.
1268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1269 init(): When telling us to check java.library.path, show the
1272 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1274 ReportGenerator: Do not show nulls.
1276 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1278 ReportGenerator: Make the title font larger.
1280 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1282 ReportGenerator: Put field titles inside groups, if there are groups.
1284 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1286 ReportGenerator: Take the Report itself instead of the name and group.
1288 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1289 Remove getReportLayoutGroup().
1290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1291 getReportHTML(): Pass the report instead
1292 of its name and layout group.
1293 * src/main/java/org/glom/web/server/ReportGenerator.java
1294 generateReport(): Use the report object to use the title
1295 instead of the name.
1297 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1299 ReportGenerator: Remove designBand parameters.
1301 * src/main/java/org/glom/web/server/ReportGenerator.java:
1302 Make designBand a class member instead of passing it to all
1305 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1307 ReportGenerator: Add lines, a bit like in the desktop version.
1309 * src/main/java/org/glom/web/server/ReportGenerator.java
1310 addToReport(): Use JRDesignLine.
1312 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1314 ReportGenerator: Correct the title positions and use some bold style.
1316 * src/main/java/org/glom/web/server/ReportGenerator.java:
1317 Break the code up into reusable functions, correct the placement of
1318 titles, and use normal/bold styles as in the reports in the desktop
1321 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1323 ReportGenerator: Add a header band to show the field titles.
1325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1326 getReportHTML(): Pass the localeId to the ReportGenerator
1328 * src/main/java/org/glom/web/server/ReportGenerator.java
1329 constructor: Take the localeID so we can get translated field
1331 generateReport(), addToReport(), addFieldToBand(): Add field
1332 titles in a column header band.
1334 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1336 Reports drop-down list: Some improvement.
1338 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1339 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1340 Adedd setSelectedReport(),
1341 setReportList(): Add a blank line so that the user can select the
1343 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1344 start(): Show the current report by calling setSelectedReport().
1345 This does not seem to work yet.
1347 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1349 DetailsActivity, ListActivity: Move some variables into a base class.
1351 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1352 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1353 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1354 the clientFactory, documentID, tableName and authenticationPopup into
1355 a base class, to avoid duplication.
1357 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1359 Translate the Reports label.
1361 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1362 Get the "Reports" label string from the constants.
1363 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1364 perties: Add Reports to the constants.
1366 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1368 Reports: Implement grouping.
1370 * src/main/java/org/glom/web/server/ReportGenerator.java:
1371 Handle LayoutItem_GroupBy items and try to do the right thing
1372 with JRDesignGroup. It seems to work.
1374 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1376 Actually show some data with JasperReports.
1378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1379 getReportHTML(): Move most code into a ReportGenerator class.
1380 * src/main/java/org/glom/web/server/ReportGenerator.java:
1381 Recurse into sub-groups, adding fields to the JasperDesign's details
1382 band. Note that we must set an arbitrary width and height, or it just
1383 will not show any data.
1385 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1387 Reports Chooser: Show the titles, not the names.
1389 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1390 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1391 and the names as the values.
1392 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1393 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1394 group now that we provide the report name, so it should always
1397 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1399 Depend on jasperreports.
1401 * pom.xml: Add the dependency. My plan is to use this on the
1404 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1406 Implement navigation to report places.
1408 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1409 start(): Do not bother to handle all events here.
1410 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1411 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1412 Added getSelectedReport().
1413 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1414 .java: start(): When handling a change to the reports chooser,
1415 call getSelectedReport() and goTo() its ReportPlace.
1416 * src/main/java/org/glom/web/client/ui/ReportView.java
1417 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1418 Added setReportHTML() which puts the html in a gwt HTML widget.
1419 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1420 getReportHTML(): Return "TODO" just to show that this works.
1422 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1424 Make ReportPlace usable.
1426 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1427 Mention ReportPlace.
1428 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1429 Correct the @prefix annotation.
1431 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1433 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1435 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1436 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1437 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1438 Change getReportLayout() to getReportHMTL() because we will not need to
1439 parse or render the report layout on the client side.
1440 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1441 getReportLayout(): Return the libglom LayoutGroup type because we will
1442 not need to convert to a shared type, because this will not be used on
1444 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1447 Note that there is still no implementation for this.
1450 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1452 Add a (empty) Report Place, View, and Activity.
1454 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1456 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1457 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1458 this into a superclass:
1459 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1460 and also use it as the base of this new ReportPlace:
1461 * src/main/java/org/glom/web/client/place/ReportPlace.java
1463 * src/main/java/org/glom/web/client/ui/ReportView.java
1464 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1465 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1466 Add these, containing mostly boiler-plate for now.
1468 * src/main/java/org/glom/web/client/OnlineGlomService.java
1469 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1470 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1471 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1472 Add API to get the LayoutGroup for the report.
1474 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1476 Add and fill a Reports drop-down list box.
1478 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1480 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1481 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1482 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1483 Added getReports(document, table, localeID), calling
1484 ConfiguredDocument.getReports().
1485 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1486 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1487 Added setReportsList() and a list widget.
1488 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1489 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1494 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1496 Translations: Add Esperanto.
1498 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1499 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1500 properties: Add this translation because someone took the time to make it.
1502 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1504 Adapt to the java-libglom 1.21.7 API.
1506 * src/main/java/org/glom/web/server/ReportGenerator.java:
1507 addToReport(): get_group_secondary_fields() is now
1508 get_secondary_fields().
1511 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1513 Use the latest java-libglom version.
1515 * pom.xml: Use java-libglom 1.21.7.
1517 2012-03-03 Ben Konrath <ben@bagu.org>
1519 Display date and time in details view.
1521 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1523 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1525 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1527 Require the latest java-libglom.
1529 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1531 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1533 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1535 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1536 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1537 an empty quickfind string. I also corrected libglom to create only
1538 empty where clauses for empty quickfind strings, but this avoids the
1541 2012-02-24 Ben Konrath <ben@bagu.org>
1543 Improve the tabs in the Notebook widget.
1547 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1549 Translations: Try to translate the strings.
1551 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1552 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1553 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1554 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1555 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1556 Take the Open translation from GTK+'s .po files.
1557 Take the Details translation from Glom's po files.
1558 I have added the other strings to Glom so we can get translations that way:
1559 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1561 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1563 TableSelectionViewImpl: Put the search label and entry in a div.
1565 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1566 Put the search widgets in a FlowTable so that the CSS can be used to
1567 style them while keeping them together.
1568 * src/main/webapp/style.css: Mention the new div.
1570 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1572 Translate more strings in more locales.
1574 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1575 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1576 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1577 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1578 Translate the "Details" and "Open" string too.
1580 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1581 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1582 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1583 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1584 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1585 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1586 Add these new locales as placeholders though they currently contain English.
1588 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1590 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1593 Check the ConfiguredDocument* for null before using it.
1595 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1597 Tell Eclipse about the generated java files.
1599 * .classpath: This lets it find OnlineGlomConstants.java.
1600 It would be nice if Eclipse just used the maven build files.
1602 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1604 Prevent a crash when no locale is specified in the URL.
1606 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1607 Avoid returning a null string, obtained from
1608 Window.Location.getParameter(). This caused a crash when it was
1609 later passed to libglom's API.
1610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1611 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1612 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1613 guard against future null strings.
1615 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1617 Use the ?locale= query param instead of the &lang= token param.
1619 * src/main/java/org/glom/web/client/place/ListPlace.java
1620 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1621 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1622 Remove the lang token key and value.
1624 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1625 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1626 When the user selects a different locale from the chooser, use
1627 Window.Location.assign() to change the URL, which then causes a reload.
1629 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1630 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1631 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1632 * src/main/java/org/glom/web/client/activity/ListActivity.java
1633 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1634 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1635 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1636 * src/main/java/org/glom/web/client/ui/ListView.java:
1637 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1639 Remove localeID member variables and method/constructor parameters, instead
1640 using Utils.getCurrentLocaleID() when we need a localID to pass to
1643 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1645 Internationalize the UI strings.
1647 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1648 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1649 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1650 because it is unused. Messages are apparently strings that can have
1651 parameters, but we do not need that yet, so Contants will be enough for now.
1652 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1653 to say that we support the en and de locales.
1654 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1655 The original English strings.
1656 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1657 Some German translations of the English strings.
1658 The i18n goal then uses the .properties file to generate an
1659 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1660 returns an implementation that returns the translated strings.
1661 The documentation suggests putting these in src/java/*/client/, but it seems
1662 best to put it in src/resources/*/client/.
1663 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1664 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1665 instead of hard-coding them.
1666 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1667 but that does not seem to stop the build, though it confuses Eclipse.
1669 You can see the translated string by adding ?locale=de to the URL, like so:
1670 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1672 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1674 Improve null/empty String checks.
1676 * pom.xml: Add a dependency on commons-lang, to use
1677 org.apache.commons.lang.StringUtils.
1678 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1680 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1681 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1682 Use StringUtils.isEmpty().
1684 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1685 StringUtils class with a static isEmpty() function because we
1686 cannot use org.apache.commons.lang.StringUtils in client-side
1687 GWT code because it (apparently) cannot be compiled to javascript.
1688 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1689 * src/main/java/org/glom/web/client/activity/ListActivity.java
1690 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1691 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1692 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1693 * src/main/java/org/glom/web/client/place/ListPlace.java
1694 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1695 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1696 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1697 * src/main/java/org/glom/web/client/ui/details/Group.java
1698 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1699 our StringUtils.isEmpty() function.
1701 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1703 Update to the latest java-libglom API.
1705 * pom.xml: Require java-libglom 1.21.4.
1706 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1707 getDocumentInfo(), getListViewLayoutGroup():
1708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1710 * src/main/java/org/glom/web/server/database/DBAccess.java
1711 getFieldsToShowForSQLQueryAddGroup(),
1712 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1713 with either get_database_title_original() or
1714 get_database_title(localeID).
1716 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1718 ConfiguredDocument: Avoid a null pointer exception.
1720 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1721 Initialize localeID to "" to avoid returning a null String which
1722 causes a crash in java-libglom's swing-generated code.
1724 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1726 Some simple renaming.
1728 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1729 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1730 for localeChooser. This seems more appropriate and is less ambiguous
1731 particularly in the .css file.
1733 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1735 ConfiguredDocument: Rename the localedID private member variable.
1737 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1739 Adapt to the latest java-libglom API from git master.
1741 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1742 libglom now uses only Vector instead of List, which uses add() instead of
1745 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1747 ConfiguredDocument: Rename the localedID private member variable.
1749 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1751 Build a source tarball with mvn assembly:single
1753 * assembly.xml: Add this file.
1754 * pom.xml: Use the maven-assembly-plugin and tell it to use
1755 our assembly.xml file.
1757 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1759 OnlineGlomServiceImpl: Get .glom files recursively.
1761 * pom.xml: Depend on commons-io from org.apache.commons.
1762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1763 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1764 files recursively, and with the easier filter for the extension.
1765 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1766 simplify that code too.
1768 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1770 README: Mention that you must install java-libglom packages separately.
1772 But then it works, because java-libglom is now in the central maven
1775 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1777 locales drop-down: Show the correct selected locale when the URL changes.
1779 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1780 .java: setPlace(): Move some code into fillView().
1782 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1784 locales drop-down: Do not lose the primary key.
1786 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1787 start(): onLocaleChange(): Pass the current primary key value,
1788 instead of an empty value.
1790 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1792 locales drop-down: Do not lose the drop-down selection.
1794 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1795 .java (TableSelectionActivity.fillView): Set the selected locale
1796 after changing the drop-down items (though we do not really need
1797 to change them just because the locale changes.)
1799 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1801 locales drop-down: Change the tables list when this changes.
1803 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1804 .java: TableSelectionActivity.start(): Move the async table titles
1805 retrieval into a private fillView() method and also call this when
1806 the chosen locale changes.
1807 Note that the document title is not actually translatable yet, but
1808 that is a problem that I should fix soon in libglom.
1810 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1812 Improve the placement of the locales drop-down.
1814 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1815 Put the title and locales drop-down in a div (gwt.FlowTable).
1816 * src/main/webapp/style.css: Add magic css properties to make this work.
1817 Also remove the left margin from the title so that it lines up with the
1820 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1822 locales selector: Show human-readable locale titles.
1824 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1825 getDocumentInfo(): Use java.util.Locale to show a real title of
1826 each locale, in the locale's own language.
1828 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1830 Add a language/locale selector drop-down.
1832 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1833 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1834 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1835 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1836 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1837 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1838 Add a ListBox to show the available locales. Add getLocaleSelector(),
1839 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1840 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1841 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1842 java: Add these classes.
1843 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1844 start(): Fill the locales ListBox. Handle its change event, firing a
1846 setPlace(): Show the selected locale as specified by the URL token.
1847 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1848 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1849 Handle LocaleChangeEvent, going to a new *Place with that locale.
1851 The placement of the ListBox is not pretty, and it currently uses the ID
1852 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1856 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1858 Search box: Show the search text from the URL token.
1860 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1861 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1862 Add setQuickFindText().
1863 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1864 .java: setPlace(): Store the queryText if the place is a ListPlace,
1865 and call TableSelectionView.setQuickFindText().
1867 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1869 Allow use of translations via, for instance, &lang=de in the URL.
1871 * pom.xml: Use the unstable java-libglom 1.21 version.
1873 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1874 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1876 init(): Instead of calling TranslatableItem.set_current_locale()
1877 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1878 However, this is only for default locales, which are not needed to
1879 change the locale in the URL.
1880 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1881 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1882 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1883 layout for a particular locale.
1884 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1885 Add get/setDefaultLocaleID().
1886 getDocumentInfo(), getListViewData(), getRelatedListData(),
1887 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1888 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1889 localeID parameter, so we can get the layout for a particular locale.
1891 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1892 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1893 * src/main/java/org/glom/web/client/place/ListPlace.java:
1894 Parse and construct a lang parameter too.
1896 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1897 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1898 passed to subsequent methods and constructors.
1899 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1900 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1901 Store the localeID from the *Place and pass it to other constructors
1902 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1904 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1905 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1906 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1907 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1908 * src/main/java/org/glom/web/client/ui/ListView.java:
1909 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1910 Take localeID parameters and pass them to subsequent constructors and
1911 methods, so that the layout is always retrieved for that locale.
1913 This is rather repetitive.
1915 Note that "" means the original (default) locale of the Glom document,
1916 which is usually English.
1918 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1920 Documents: Remove final keyword to fix startup configuration.
1922 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1923 final keywords on the private member variables because that breaks
1924 the startup, apparently (there are warnings) because it stops them
1925 from being serialized. I added these in the previous commit.
1927 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1929 Documents: Add some final keywords.
1931 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1934 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1936 OnlineGlomServiceImpl: Add to overview comments.
1938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1939 Note that this is where all the document are loaded. They are not
1940 loaded freshly for each page.
1942 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1946 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1947 Add a TextBox for the text of a quick find.
1948 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1950 setBackLink(): Add a String quickFind parameter.
1951 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1952 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1953 to the base interface, because that is how TableSelectionViewImpl is used.
1954 * src/main/webapp/style.css: Add style for the search box and its label.
1956 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1957 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1958 Add these files, based on the existing TableChangeEvent and
1959 TableChangeEventHandlers.
1960 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1961 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1962 a ListPlace() that the user should be taken to.
1963 * src/main/java/org/glom/web/client/activity/ListActivity.java
1964 start(): Handle it here too and adapt the TableChangeEvent handler to
1965 pass the extra "" quickFind parameter to ListPlace.
1966 * src/main/java/org/glom/web/client/place/ListPlace.java:
1967 Constructor: Take an extra String quickFind parameter and store it,
1968 returning it from a new getQuickFind() method.
1969 getToken(): Put the quickFind text in the URL token.
1970 getPlace(): Parse the quickFind text from the URL token.
1971 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1972 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1973 ListPlace constructor.
1974 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1975 .java: start(): Add a Change handler for the TableSelectionView's
1976 TextBox (via its base HasChangeHandlers interface), firing the new
1977 QuickFindChangeEvent.
1978 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1979 pass the extra "" quickFind parameter.
1981 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1982 setCellTable(): Add a String quickFind parameter and pass it to
1983 the ListViewTable() constructor.
1984 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1985 setCellTable() in the base interface, because that is how ListViewImpl
1988 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1989 Add a String quickFind member variable.
1990 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1991 Constructor: Add a String quickFind parameter, storing it in the
1992 base ListTable's member variable.
1993 onRangeChanged(): Pass quickFind to the
1994 OnlineGlomServiceAsync.getSortedListViewData() and
1995 OnlineGlomServiceAsync.getListViewData() methods.
1997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1998 getListViewData(), getSortedListViewData(): Add a String quickFind
1999 parameter, passing it to ConfiguredDocument.getListViewData().
2000 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2001 Change getListViewData(), getSortedListViewData() in the base interface,
2002 because that is how OnlineGlomServiceImpl is used, via this:
2003 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2004 Change getListViewData(), getSortedListViewData() here too.
2005 This class can apparently be used to asynchronously call methods on
2006 OnlineGlomService, and GWT seems to implement that after recognizing
2007 just the *Async name convention and the extra AsyncCallback parameters.
2009 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2010 getListViewData(): Add a String quickFind parameter, and pass it to
2011 ListViewDBAccess.getData().
2012 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2013 getListData(): Add a String quickFind parameter and pass it to
2015 getSelectQuery(): Add a String quickFind parameter.
2016 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2017 getSelectQuery(): Add a String quickFind parameter and use it with
2018 Glom.get_find_where_clause_quick() to pass a where_clause to
2019 Glom.build_sql_select_with_where_clause(), to actually filter the
2021 getData(): Add a String quickFind parameter, passing it to getListData().
2022 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2023 va: getData(): Pass an empty string to getListData() for the
2024 quickFind parameter.
2026 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2028 ListTable: Minor change.
2030 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2031 createCellTable(): Make this protected instead of public.
2033 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2035 Many files: Use final for the parameters and use the @override attribute.
2037 2012-01-22 Ben Konrath <ben@bagu.org>
2039 Add anchor links for single line text that starts with http, ftp and www.
2043 2012-01-22 Ben Konrath <ben@bagu.org>
2045 Add ellipsis to single line text in details view.
2049 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2051 Remove all javadoc author tags.
2053 Because they are awkward and meaningless when many people touch
2055 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2057 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2059 Revert the COPYING.LESSER to COPYING rename.
2061 Apparently both should be there if it is LGPL.
2063 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2065 *View: Remove unused imports.
2067 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2068 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2069 * src/main/java/org/glom/web/client/ui/ListView.java:
2070 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2071 Remove unused imports, as suggested by Eclipse.
2073 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2075 Move the *View::Presenter types, and some API into one base View.
2077 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2078 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2079 * src/main/java/org/glom/web/client/ui/ListView.java:
2080 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2081 Presenter, setPresenter() and clear() into a shared base interface,
2082 to avoid the unnecessary duplicate Presenter types and to more clearly
2083 show how the *Views share the same structure, even if they are not
2084 used polymorphically.
2086 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2087 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2089 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2090 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2091 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2093 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2096 Feel free to revert this if there is a good reason for the duplicate
2099 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2101 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2103 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2104 a class member instead of a local variable in the method.
2105 This lets us use it to get the view instances, for use in tests.
2106 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2107 beforeOnlineGlom(): Test some more details of the initial view.
2108 Again, this is not very useful.
2110 To really test gwt-glom we will need to start a local postgresql
2111 instance with local data, like the Glom tests in C++.
2113 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2115 pom.xml: Mention the LGPL license.
2117 * pom.xml: Add a licenses section.
2118 * COPYING.LESSER: Move this to COPYING, which
2119 previously contained the GPL. But gwt-glom is all LGPL.
2121 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2123 Add project information to README and pom.xml.
2125 * README: Add a brief description and mention some mvn
2127 * pom.xml: This extra information shows up in mvn site
2130 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2132 Use the latest java-libglom version.
2134 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2136 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2138 GwtTestOnlineGlom: Test a little more.
2140 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2141 protected rather than private, as suggested by the gwt-test-utils
2143 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2144 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2145 Test the initial visibility of the panels.
2147 However, this is not a very useful test.
2148 And I wonder how we should generally test using this idea for an
2149 activity/places app like ours where the real changes happen implicitly
2150 based on the history token/URL.
2152 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2154 Slight modification to *Mapper comments.
2156 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2157 (DataActivityMapper)
2158 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2160 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2162 Remove comments mentioning GIN because they are just copied from
2163 the example code and are apparently not helpful:
2164 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2165 Also change the mention of a class that is only in the example code.
2167 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2169 GwtTestOnlineGlom test: Minor changes.
2171 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2172 Avoid the long qualified class name and modify the comment
2173 because it is now obvious to me that the mocked class is the only
2174 custom one created via GWT.create().
2176 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2178 Tests: Added the beginnings of a test using gwt-test-utils.
2180 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2181 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2182 which tells gwt-test-utils what class will be tested.
2183 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2184 Add a simple (but empty) test case. One class, used by the OnlineGlom
2185 class, is mocked so that it can be created. However, I am not sure
2186 why only this class needs to be mocked.
2188 Note that mockito seems more popular, and clearer, than easymock,
2189 but I have not got that working yet. It might be a matter of the
2192 This test is run during mvn integration-test.
2194 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2196 Tests: Use junit4-style syntax instead of junit3-style.
2198 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2199 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2200 * src/test/java/org/glom/web/shared/DataItemTest.java:
2201 Use the @Test annotation rather than relying on the test*() prefix.
2202 Also no longer implement TestCase, to avoid triggering support for
2203 the junit3-way, which stops the annotations from working.
2204 Change the imports from import junit.framework.* to
2205 import org.junit.*, which is apparently the new way.
2207 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2209 Added a test for ListPlace token parsing and creation.
2211 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2212 This is much the same as DetailsPlaceTest.
2214 I wonder how we could test the other parts of the *Place API.
2216 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2218 DetailsPlace test: Also test getToken() and recreation via getPlace().
2220 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2221 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2222 recreate it, testing the recreated DetailsPlace for the same parameter
2225 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2227 Use the surefire-report plugin.
2229 * pom.xml: This generates a HTML report about the tests in
2230 target/site/surefire-report.html
2231 when you do mvn surefire-report:report. It seems to be popular/normal.
2233 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2235 Added a test for DetailsPlace.
2237 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2238 Test the getPlace() token parsing.
2240 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2242 Added a first unit test.
2244 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2245 * src/test/java/org/glom/web/shared/DataItemTest.java:
2246 This is a silly test but it is just to get things started. Note that
2247 maven/junit finds the test because it looks in src/test by default.
2249 2011-12-22 Ben Konrath <ben@bagu.org>
2251 Change charsetName to "UTF-8" when replacing line breaks.
2253 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2254 that work in Java (such as "UTF8") will not work when compiled to
2257 This fixes a problem with multi-line details view fields that have hard
2258 line breaks. The "License Text" field on this page demonstrates the
2261 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2263 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2265 2011-12-22 Ben Konrath <ben@bagu.org>
2267 Fix another bug with related list navigation.
2269 I've tested all the navigation buttons in all of the related lists
2270 so things should be good now.
2272 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2274 2011-12-22 Ben Konrath <ben@bagu.org>
2276 Fix a crasher when refreshing the list view with the default table.
2278 This crash will also happen when loading the list view with the default
2279 table from a link or bookmark.
2281 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2282 to the main document selection page when the document id hasn't been
2284 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2285 the main document selection page when the document id hasn't been
2287 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2288 values for the details place when the document id hasn't been set.
2289 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2290 values for the list place when the document id hasn't been set.
2292 2011-12-21 Ben Konrath <ben@bagu.org>
2294 Protect against NPE when glom.document.locale is not in config.
2296 This patch protects against an NPE when glom.document.locale is not in
2297 the config file. This NPE will also happen if glom.document.locale is
2300 The patch also updates the error message to display the class name when
2301 the getMessage() returns null. This was happening when the NPE was
2302 thrown and I had "Configuration Error: null". If an NPE is encountered
2303 with this patch, "Configuration Error: NullPointerException " will be
2306 This commit closes this bug:
2308 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2312 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2314 Rename onlineglom.properties to onlineglom.properties.sample.
2316 * src/main/resources/onlineglom.properties: Rename to:
2317 * src/main/resources/onlineglom.properties.sample:
2318 * src/main/resources/README: And add this file explaining that people
2319 should rename it back when deploying.
2321 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2323 Allow choosing the translation in the .properties file.
2325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2326 init(): Read a glom.document.locale value from the configuration file
2327 and call Glom's TransatableItem::set_current_locale() method.
2328 * src/main/resources/onlineglom.properties: Add a commented-out
2329 example of this new setting.
2331 It would be better to add &lang=de_DE to the URL, but the current
2332 libglom API does not allow us to do this easily. I am working on that.
2334 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2336 Avoid a crash in parsing of token parameters.
2338 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2339 ava: getTokenParams(): Do not crash if a parameter has a key but no
2340 value, and ignore parameters with neither.
2342 2011-12-17 Murray Cumming <murrayc@murayc.com>
2344 History token building/handling: Improve use of token parameters.
2346 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2347 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2348 and buildParamsToken(HashMap), for use by derived classes.
2349 Make the separator private because it is no longer be needed.
2350 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2351 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2352 instead of manual string concatenation.
2353 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2354 of hardcoded indices and awkward splitting code.
2355 * src/main/java/org/glom/web/client/place/ListPlace.java
2356 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2357 instead of manual string concatenation.
2358 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2359 of hardcoded indices and awkward splitting code.
2360 This should fix bug #666420
2362 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2364 Fix a Navgiation->Navigation typo in the code.
2366 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2367 Rename processNavgiation() to processNavigation().
2369 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2371 Fix a seperator->separator typo in the code.
2373 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2374 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2375 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2378 2011-12-15 Ben Konrath <ben@bagu.org>
2380 Cleanup some comments.
2382 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2384 2011-12-14 Ben Konrath <ben@bagu.org>
2386 Replace \n with <br/> for multiline text in the details view.
2388 Vertical scrollbars are added when needed as well.
2390 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2392 2011-12-14 Ben Konrath <ben@bagu.org>
2394 Specify the font for document selection links.
2396 * src/main/webapp/style.css:
2398 2011-12-14 Ben Konrath <ben@bagu.org>
2400 Fix bouncy CellTable while paging.
2402 This doesn't currently work with related list tables in unselected
2405 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2407 2011-12-14 Ben Konrath <ben@bagu.org>
2409 Revamp the appearance of the document selection page.
2411 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2412 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2413 * src/main/webapp/style.css:
2415 2011-12-13 Ben Konrath <ben@bagu.org>
2417 Set navigation button column to the smallest size possible.
2419 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2421 2011-12-13 Ben Konrath <ben@bagu.org>
2423 Change OpenButton nomenclature to NavigationButton.
2425 Using NavigtionButton makes things more generic. Classes, methods and
2426 variables have been changed.
2428 This is a rename-only refactor.
2430 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2431 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2432 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2433 Renamed from OpenButtonCell.
2434 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2435 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2436 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2438 2011-12-12 Ben Konrath <ben@bagu.org>
2440 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2442 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2443 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2444 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2445 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2447 2011-12-12 Ben Konrath <ben@bagu.org>
2449 Update variable names and comments.
2451 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2452 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2454 2011-12-12 Ben Konrath <ben@bagu.org>
2456 Properly initialize numNonEmptyRows variable to zero.
2458 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2459 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2461 2011-12-05 Ben Konrath <ben@bagu.org>
2463 Add latest mockup with HTML tables.
2465 Features of this mockup:
2467 -> HTML table for flowtable
2468 -> HTML table for flowtable column
2469 -> Example of how related lists would look
2470 -> Not using text entries for data items
2472 The current version of Online Glom doesn't use HTML tables for the
2475 This mockup has been sent to the glom-devel mailing list but it's good
2476 to have it here as well.
2478 * mockups/details-view-html-tables.html:
2480 2011-12-05 Ben Konrath <ben@bagu.org>
2482 Remove unnecessary getPrimaryKeyField() method.
2484 getPrimaryKeyFieldForTable(String) has been renamed to
2485 getPrimaryKeyField(String).
2487 * src/main/java/org/glom/web/server/database/DBAccess.java:
2488 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2489 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2491 2011-12-05 Ben Konrath <ben@bagu.org>
2493 Add string representation of TypedDataItem value to conversion error message.
2495 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2496 message was extracted into its own method to avoid duplication.
2498 2011-12-05 Ben Konrath <ben@bagu.org>
2500 Add type checking to navigation primary key value creation.
2502 Create navigation primary key only if the expected type from the Glom
2503 document matches the type returned by the SQL query.
2505 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2507 2011-12-05 Ben Konrath <ben@bagu.org>
2509 Rename a couple of variables in RelatedListNavigation.
2511 This is a rename-only refactor.
2513 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2515 2011-12-05 Ben Konrath <ben@bagu.org>
2517 Move getListLayoutGroup() into getListViewLayoutGroup().
2519 This removes getListLayoutGroup(). It was only being called by
2520 getListViewLayoutGroup().
2522 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2524 2011-12-05 Ben Konrath <ben@bagu.org>
2526 Remove check for LayoutItem_Portal in list table method.
2528 This check is no longer necessary because the method isn't being used
2529 to create the LayoutItemPortal DTO.
2531 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2533 2011-12-05 Ben Konrath <ben@bagu.org>
2535 Properly support related list navigation.
2537 Navigation from the "Repository Analyzer -> Package Scans ->
2538 Dependencies" related table wasn't working because the primary key for
2539 related tables wasn't being set properly. This commit fixes the
2542 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2543 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2544 doesn't set the primary key properly for related list tables.
2545 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2546 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2547 useful for getting the primary key for list view tables and for related
2549 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2550 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2551 Move code to set the primary key for the table from the abstract
2552 ListDBAccess class to ListViewDBAccess as it's only correct for list
2554 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2555 Properly add primary key to related list tables.
2557 2011-12-02 Ben Konrath <ben@bagu.org>
2559 Properly set the horizontal alignment of fields.
2561 This fix is for both the list tables and the details view.
2563 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2564 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2565 to set the horizontal alignment of fields.
2567 2011-12-02 Ben Konrath <ben@bagu.org>
2569 Display currency codes in the details view.
2571 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2573 2011-12-02 Ben Konrath <ben@bagu.org>
2575 Avoid duplicate JNI call.
2577 JNI is not as efficient as pure Java and this is an easy (and small)
2580 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2581 Use previously retrieved value for whereClauseToTableName instead of
2584 2011-12-02 Ben Konrath <ben@bagu.org>
2586 Rename a couple of variables in RelatedListNavigation.
2588 This is a rename-only refactor.
2590 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2592 2011-12-02 Ben Konrath <ben@bagu.org>
2594 Indicate clearly that a mismatched primary key type is a bug.
2596 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2597 warning to error. Add 'This is a bug.' to message.
2599 2011-12-02 Ben Konrath <ben@bagu.org>
2601 Update / fix some comments.
2603 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2605 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2607 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2608 Fix comments. Add some TODOs.
2610 2011-12-02 Ben Konrath <ben@bagu.org>
2612 Enable navigation to details view with string primary key from related list.
2614 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2615 Create a text primary key value when return type of result is
2616 java.sql.Types.VARCHAR.
2618 2011-12-02 Ben Konrath <ben@bagu.org>
2620 Use checkboxes for booleans in the details view.
2622 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2624 2011-12-01 Ben Konrath <ben@bagu.org>
2626 Improve performance of related list height calculation.
2628 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2629 Put code to calculate the expected height in a static initializer so
2630 that that it's only called once.
2632 2011-12-01 Ben Konrath <ben@bagu.org>
2634 Show related list tables in notebooks (again).
2636 Calculate the height of the related list tables so the Notebook can be
2637 set the correct height. The height of the related list table is also needed by
2638 FlowTable to be able decide how to create the layout.
2640 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2641 and set the Portal height based on the height of the related list
2642 table and the Portal container.
2643 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2644 Add method to calculate the height of the related list tables.
2645 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2646 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2647 calculate the height of the Pager widget.
2649 2011-12-01 Ben Konrath <ben@bagu.org>
2651 Use CellTable API for table property instead of setting style on Element.
2653 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2655 2011-12-01 Ben Konrath <ben@bagu.org>
2657 Make ListViewTable and RelatedListTable a consistent height.
2659 The tables are now a consistent height regardless of the contents of
2660 the table. A hidden button is added to empty rows to ensure that the
2661 height of these rows will match the height of rows with data.
2663 A navigation button column is now added to every table. The width of
2664 the navigation column is set to 0px when a RelatedListTable shouldn't
2665 have navigation buttons. This maintains the a consistent row height in
2666 tables that don't show the navigation buttons.
2668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2669 navigation column when not needed.
2670 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2671 arguments for navigation button to constructor of ListViewTable.
2672 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2673 hidden button for empty data rows.
2674 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2675 arguments for navigation button to constructor.
2676 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2677 create navigation buttons. Add hideNavigationButtons() method.
2678 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2679 arguments for navigation button to constructor.
2681 2011-12-01 Ben Konrath <ben@bagu.org>
2683 Use 'visibility: hidden' in Utils.getWidgetHeight().
2685 This is better choice because hidden elements are invisible, don't
2686 respond to events and are not part of the tab order. They will,