1 2012-07-13 Murray Cumming <murrayc@murrayc.com>
3 Avoid some code warnings in Eclipse Juno
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
7 * src/test/java/org/glom/web/server/SelfHoster.java
8 createTextFile(): Make sure that the FileOutputStream is closed.
10 2012-06-22 Murray Cumming <murrayc@murrayc.com>
12 Added OnlineGlomPropertiesTest.
14 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
15 Make sure we never return a null string.
16 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
17 Added tests of the OnlineGlomProperties API, using our sample file.
19 2012-06-20 Murray Cumming <murrayc@murrayc.com>
21 Make OnlineGlomProperties be a normal class.
23 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
24 Move OnlineGlomProperties into its own file to be a regular class:
25 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
26 This makes testing simpler.
28 2012-06-15 Murray Cumming <murrayc@murrayc.com>
30 OnlineGlomServiceImpl.init(): Move some code into a new method.
32 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
35 2012-06-15 Murray Cumming <murrayc@murrayc.com>
37 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
39 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
40 OnlineGlomProperties.getKey(): Make this more robust by moving the
41 check for *.*.filename to here.
43 2012-06-15 Murray Cumming <murrayc@murrayc.com>
45 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
47 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
48 init(): Move knowledge of the config file format into the
49 OnlineGlomProperties inner class.
51 2012-06-15 Murray Cumming <murrayc@murrayc.com>
53 SelfHostExampleTest: Make sure we cleanup on failure.
55 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
56 the use of cleanup() to a tearDown() JUnit method.
58 2012-06-12 Murray Cumming <murrayc@murrayc.com>
60 ConfiguredDocument: Add a primary key to portals at least once.
62 * src/main/java/org/glom/web/server/ConfiguredDocument.java
63 updatePortalsExtras): Fix a typo so that we add the primary key
65 This is a fix for the previous commit:
66 ConfiguredDocument: Do not add a primary key to portals each time.
68 2012-06-08 Murray Cumming <murrayc@murrayc.com>
70 SelfHoster: Avoid some compiler warnings.
72 * src/test/java/org/glom/web/server/SelfHoster.java
73 executeCommandLineAndWait():
74 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
75 the now-unused streams for stdout and stderr from the command Processes.
76 These are not used because readln() hangs while waiting for a new line,
77 where there may be no next line. The commented out code is still there
78 to help us figure out how to do this properly.
80 2012-06-08 Murray Cumming <murrayc@murrayc.com>
82 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
84 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
85 Make this actually test the cloning again, though it is not very useful
86 now that we do not use the part that had a problem with cloning before.
88 2012-06-08 Murray Cumming <murrayc@murrayc.com>
90 SelfHoster: Keep trying pg_ctl after starting postgres.
92 * src/test/java/org/glom/web/server/SelfHoster.java
93 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
94 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
95 regular Glom. This seems mad but it seems to work because the first
96 command would fail if pg_ctl would eventually fail.
98 2012-06-08 Murray Cumming <murrayc@murrayc.com>
100 SelfHoster: Wait until the server is really ready.
102 * src/test/java/org/glom/web/server/SelfHoster.java
103 selfHost(): Attempt the connection after starting the server, retrying
104 a few times if necessary, so that the server is really ready already when
105 we return from this method.
106 The regular Glom code does this too because pg_ctl reports success too soon.
108 2012-06-08 Murray Cumming <murrayc@murrayc.com>
110 ConfiguredDocument: Do not add a primary key to portals each time.
112 * src/main/java/org/glom/web/server/ConfiguredDocument.java
113 updatePortalsExtras(): Only add an extra primary key field if there is
114 none, to avoid adding one each time we retrieve the details layout from the
116 This should fix bug #676986 (Ben Konrath)
118 2012-05-25 Murray Cumming <murrayc@murrayc.com>
120 Document.load(): Support version 7 documents.
122 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
123 database_title attribute if the title attribute is not there.
126 2012-05-24 Ben Konrath <ben@bagu.org>
128 Add configuration for auto-generating mvn:i18n from with Eclipse.
130 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
132 2012-05-24 Murray Cumming <murrayc@murrayc.com>
134 Update translations, adding French.
136 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
137 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
138 Add a French translation, using the translation from Glom.
140 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
141 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
142 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
143 Update these based on the translations from Glom.
145 2012-05-24 Murray Cumming <murrayc@murrayc.com>
147 SelfHoster: Add some debug println messages to help when things fail.
149 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
150 System.out.println() lines.
152 2012-05-23 Murray Cumming <murrayc@murrayc.com>
154 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
156 * src/test/java/org/glom/web/server/SelfHoster.java:
157 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
158 instance) instead of just /usr/bin (as on Fedora). Check the result when
161 2012-05-23 Murray Cumming <murrayc@murrayc.com>
163 Remove LayoutItemPortal.get/setNavigationTable().
165 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
166 Remove get/setNavigationTable(), which is only a cache, because it is not
167 used, and does not need to be used, because that decision should be made on
169 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
170 updatePortalsExtras():
171 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
172 getNavigationRecord():
173 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
176 2012-05-21 Murray Cumming <murrayc@murrayc.com>
178 Initial self-hosting for tests.
180 * pom.xml: Change the scope for log4j, to hopefully make it
181 available to the test code which uses it indirectly via jOOQ.
182 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
183 self-hosting, though we only use it for testing.
185 * src/main/java/org/glom/web/server/libglom/Document.java:
186 example rows: Use a map instead of a list for each row of values,
187 so we know what field they are for, instead of relying on the sequence
188 being correct. This is not very efficient, but it does not really need
190 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
191 testReadTableExampleRows(): Adapted.
193 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
194 that returns an Object, for generic use. Note that Object seems to be
195 the implicit base even of double.
196 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
197 for use in CREATE TABLE SQL queries.
198 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
199 to do self-hosting of PostgreSQL databases via its command-line
200 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
201 backends/postgres_self.cc. This is incomplete - it needs more
202 warnings about failures and it needs to clean up properly when things
204 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
205 test of this new class.
207 2012-05-21 Murray Cumming <murrayc@murrayc.com>
209 Document: loading example data: Handle exceptions.
211 * src/main/java/org/glom/web/server/libglom/Document.java:
212 DateFormat.parse() and Double.valueOf() can throw exceptions, though
213 Eclipse did not warn about that.
215 2012-05-20 Murray Cumming <murrayc@murrayc.com>
217 Document: load(), save(): Handle the example rows.
219 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
221 * src/main/java/org/glom/web/server/libglom/Document.java:
222 load(), save(): Load and save the example rows, though the date, time
223 and image types are not handled properly yet.
224 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
225 Add testReadTableExampleRows() just to check that something is read.
227 2012-05-20 Murray Cumming <murrayc@murrayc.com>
229 Document: Add save().
231 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
232 Added getTranslationsMap() for use while saving.
233 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
234 Adedd getUseDefaultFormatting() for use while saving.
235 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
236 and several private methods that it uses.
238 This will be useful while testing via self-hosting.
239 It is not complete, but should be complete enough for testing.
241 2012-05-17 Murray Cumming <murrayc@murrayc.com>
243 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
245 * src/main/java/org/glom/web/client/OnlineGlomService.java
246 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
247 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
248 Remove getSortedListViewData() and getSortedRelatedListData(), adding
249 the sort column index and ascending bool to the regular method.
250 Instead, a sort column index of -1 now means no sort.
251 This is less explicit, but it's fairly simple, reduces the amount of
252 code, and makes the OnlineGlomService API slightly smaller.
253 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
254 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
256 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
257 getListViewData(), getRelatedListData():
258 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
259 getListViewData(), getRelatedListData():
260 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
262 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
264 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
269 2012-05-16 Murray Cumming <murrayc@murrayc.com>
271 Use translations for top-level groups too.
273 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
274 updateTitlesForLocale(): Use the translation for the group
275 as well as for child items.
279 Just recompiled to fix a problem in the released .tar.gz file.
283 2012-05-15 Murray Cumming <murrayc@murrayc.com>
285 Corrections to navigation to related records.
287 * src/main/java/org/glom/web/client/OnlineGlomService.java:
288 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
290 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
291 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
292 relationship name, because the relationship name is not necessarily unique
294 TOOD: This is inefficient, because it passes the whole list of
295 child field items back to the server, but it is more correct, and happens
296 to fix a bug with the primary key being lost after a few navigations.
297 There is probably a chance to make this more efficient anyway in some
300 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
301 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
302 * src/main/java/org/glom/web/server/ConfiguredDocument.java
303 * src/main/java/org/glom/web/server/database/DBAccess.java
304 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
305 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
308 2012-05-15 Murray Cumming <murrayc@murrayc.com>
310 Fix the use of translations.
312 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
313 Add updateTitlesForLocale().
314 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
315 Call it to discard unwanted translations and to make getTitle() return
316 the wanted translation wihout the need for the client code to specify a locale.
317 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
318 getTitle(): Fallback to the original title, as libglom does.
320 2012-05-15 Murray Cumming <murrayc@murrayc.com>
322 Document: Correctly report the number of available translation locales.
324 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
325 the available locale IDs list.
326 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
327 testLocales: Test this.
329 2012-05-15 Murray Cumming <murrayc@murrayc.com>
331 SqlUtils: Use camelCase.
333 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
334 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
335 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
336 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
337 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
338 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
340 2012-05-15 Murray Cumming <murrayc@murrayc.com>
342 Use jOOQ's tableByName() and fieldByName.
344 * pom.xml: Use jOOQ 2.3.1 to get the new API.
345 * src/main/java/org/glom/web/server/SqlUtils.java:
346 build_sql_select_step_with_where_clause(), .createField(),
347 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
348 so we can get correct quoting and escaping. Thanks to Lukas Eder for
349 adding this, and other things, to jOOQ.
351 2012-05-15 Murray Cumming <murrayc@murrayc.com>
353 SqlUtils: Remove the Connection parameters.
355 * src/main/java/org/glom/web/server/SqlUtils.java:
356 build_sql_select_with_key(), build_sql_select_with_where_clause(),
357 createSelect(), build_sql_select_step_with_where_clause(),
358 build_sql_count_select_with_where_clause(),
359 build_sql_select_count_rows(): Remove the Connection parameter because
360 jOOQ does not actually need a connectionwhen it is just used to build
362 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
364 * src/main/java/org/glom/web/server/ReportGenerator.java:
366 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
368 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
369 Constructor, getListData(), getResultSizeOfSQLQuery():
370 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
371 getSelectQuery(), getCountQuery():
372 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
373 getSelectQuery(), getCountQuery():
374 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
375 getNavigationRecord(): Adapted.
377 2012-05-14 Murray Cumming <murrayc@murrayc.com>
381 * src/main/java/org/glom/web/server/SqlUtils.java:
382 get_find_where_clause_quick(): Use a comparison of
383 lowercase values, instead of a simple equals. Regular Glom
384 uses the PostgreSQL ILIKE operator but jOOQ does not
385 support that just yet, though it will soon.
387 2012-05-14 Murray Cumming <murrayc@murrayc.com>
389 TableToViewDetails: Use a real serialization ID.
391 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
392 Though this does not fix the serialization problem.
394 2012-05-12 Murray Cumming <murrayc@murrayc.com>
396 Added LayoutItemPortalDeepCloneTest.
398 2012-05-11 Murray Cumming <murrayc@murrayc.com>
400 Make navigation work again.
402 * src/main/java/org/glom/web/server/libglom/Document.java:
403 Add getLayoutItemFieldShouldHaveNavigation().
404 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
405 Replace get/setAddNavigation() with the partly-existing
406 get/setNavigationTableName(), with an empty string being no navigation,
407 because this is simpler. Use the new
408 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
410 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
411 Add updateFieldsExtras() and call setNavigationTableName in it.
412 getDetailsLayoutGroup(),
413 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
414 createLayout(): Adapted.
415 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
416 Constructor: Adapted.
418 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
419 Replace get/setAddNavigation() with get/setNavigation(), returning a
420 TableToViewDetails class with both the table name and UsesRelationship,
421 because both are need. The previous code used java-libglom's output
422 variable (strangely, via sharedptr) to return both, but we cannot really
424 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
425 getNavigationRecord(): Adapt. However, we cannot actually use the cache
426 here because it somehow gets set to null during deepCopy(). I must test this.
427 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
428 testGetSuitableTableToViewDetails(): Adapted.
430 TODO: Find out why deepClone() is not quite working.
432 2012-05-11 Murray Cumming <murrayc@murrayc.com>
434 DBAccess: Simplify the retrievel of full field details.
436 * src/main/java/org/glom/web/server/database/DBAccess.java
437 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
438 because the Document loading should have done this.
440 2012-05-11 Murray Cumming <murrayc@murrayc.com>
442 Document: Correct loading of doubly-related layout fields.
444 * src/main/java/org/glom/web/server/libglom/Document.java:
445 loadUsesRelationship(): Actually set the related relationship, instead
446 of only setting it if it's not found.
448 2012-05-09 Murray Cumming <murrayc@murrayc.com>
450 Replace all appearances of Colour with color.
452 Because US English is dominant.
454 2012-05-09 Murray Cumming <murrayc@murrayc.com>
456 Use colors in HTML format, solving a warning about an unused function.
458 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
459 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
460 Add *asHTMLColor() versions of methods.
461 TODO: However, we should create and cache the results on the server.
462 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
463 * src/main/java/org/glom/web/client/ui/list/ListTable.java
464 * src/main/java/org/glom/web/server/ConfiguredDocument.java
465 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
466 Use the asHTMLcolor() versions.
468 2012-05-09 Murray Cumming <murrayc@murrayc.com>
470 ListViewTable: Constructor: Take the table name as a parameter.
472 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
473 Constructor: Take the tableName, and set the member variable, because
475 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
476 setCellTable(): Pass the table name.
477 This makes navigation to non-default tables work again. I don't know
478 why it worked before in the master branch.
480 2012-05-07 Murray Cumming <murrayc@murrayc.com>
482 ConfiguredDocument: Restore correct addition of hidden primary key items.
484 * src/main/java/org/glom/web/client/ui/list/ListTable.java
485 (ListTable.createCellTable): Uncomment out the check for the hidden
487 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
488 add primary key items for top-level lists and portals, as before,
489 instead of adding them to each group.
490 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
491 Actually implement the extra methods such as setHiddenPrimaryKey() and
492 comment that these are used only for top-level list groups and in portals.
493 This strangeness suggests even more that this should not be squeezed
494 into the LayoutGroup class.
496 2012-05-07 Murray Cumming <murrayc@murrayc.com>
498 Fix Formatting loading.
500 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
501 getFormattingUsed(): Remove the duplicate Formatting member variable
502 in favour of the one from the base class.
503 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
504 Initialize a new Formatting instead of using null by default, so we
505 have some defaults, instead of having to initialize one later just to
506 get the same defaults. This also makes loading of formatting from the
507 document work, because that expected a non-null.
509 2012-05-07 Murray Cumming <murrayc@murrayc.com>
511 RelatedListTable: Make sure that the tableName is set.
513 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
514 Constructor: Take the tableName so it is available later. Otherwise,
515 the server assumes that we mean the default table and cannot find the
517 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
518 setData(): Pass the tableName to the RelatedListTable constructor.
520 2012-05-07 Murray Cumming <murrayc@murrayc.com>
524 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
525 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
526 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
528 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
530 * src/main/java/org/glom/web/server/database/DBAccess.java:
531 convertResultSetToDTO(), getPortal():
532 * src/main/java/org/glom/web/server/database/ListDBAccess.java
534 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
535 Add checks for null objects and out of range access, with log messages to
536 give hints so we can fix these properly.
538 2012-05-07 Murray Cumming <murrayc@murrayc.com>
540 Portals: some corrections.
542 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
544 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
545 constructor: Use getRelationshipNameUsed() instead of getName(), because
546 that is what is meant.
547 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
548 getFromField(): Fix a typo, to get the field name, not the table name.
549 * src/main/java/org/glom/web/server/database/DBAccess.java:
550 getPortal(): Fix a typo that stopped this from working.
552 2012-05-07 Murray Cumming <murrayc@murrayc.com>
554 LayoutItemPortal: Also override getTitleOriginal().
556 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
557 This lets the base getTitle() with no parameters work.
558 TODO: Test this properly.
560 2012-05-06 Murray Cumming <murrayc@murrayc.com>
562 LayoutItemPortal: getTitle*(): Use the relationship title.
564 2012-05-06 Murray Cumming <murrayc@murrayc.com>
566 LayoutItemField: Fix loading of custom titles.
568 * src/main/java/org/glom/web/server/libglom/Document.java
569 loadDataLayoutItemField(): The title, if any, instead of the field
570 title, is stored in a title_custom node. Load it from there.
571 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
573 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
574 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
575 getTitle*() overrides.
576 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
579 2012-05-06 Murray Cumming <murrayc@murrayc.com>
581 LayoutItemField: Fall back to field titles, so some are really shown.
583 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
584 Override getTitleOriginal() and getTitle(), as in java-libglom.
585 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
588 2012-05-06 Murray Cumming <murrayc@murrayc.com>
590 Correct use of setExpectedResultSize().
592 * src/main/java/org/glom/web/server/ConfiguredDocument.java
593 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
594 Use setExpectedResultSize only on top-level groups (for instance, the
595 list layout) or on child portals (in details views).
596 Use the correct table name for portals to avoid SQL errors.
597 Update the expected counts when returning cached layouts.
599 2012-05-06 Murray Cumming <murrayc@murrayc.com>
601 Document: Interpret no group column count as 1.
603 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
604 default, though we now check for this in the UI code anyway.
606 2012-05-06 Murray Cumming <murrayc@murrayc.com>
610 2012-05-06 Murray Cumming <murrayc@murrayc.com>
612 Translatable: Use Hashmap instead of Treemap because GWT supports it.
614 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
615 The use of Treemap lead to this error from async methods, with no
617 "The response could not be deserialized"
619 2012-05-06 Murray Cumming <murrayc@murrayc.com>
621 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
623 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
624 when using the Google -> GWT Compile, or
625 g toolbar button -> GWT Compile Project... feature in Eclipse.
627 2012-05-06 Murray Cumming <murrayc@murrayc.com>
629 ListTable.addColumn(): Protect against a null Formatting.
631 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
632 Create a default Formatting if it is null, because that is the simplest
635 2012-05-06 Murray Cumming <murrayc@murrayc.com>
637 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
639 * src/main/java/org/glom/web/server/ConfiguredDocument.java
640 updateLayoutGroup(): Check that the field is not null.
642 2012-05-06 Murray Cumming <murrayc@murrayc.com>
644 ListViewImpl: Protected against a bad cast error.
646 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
647 onEnterKeyDown(): Do not cast without an instanceof check.
649 2012-05-06 Murray Cumming <murrayc@murrayc.com>
651 ListTable: Protect against an out of range error.
653 * src/main/java/org/glom/web/client/ui/list/ListTable.java
654 createCellTable(): This is unlikely, but can happen while debugging.
656 2012-05-06 Murray Cumming <murrayc@murrayc.com>
658 AsyncMessage onFailure() callbacks: Log the exception message.
660 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
661 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
662 * src/main/java/org/glom/web/client/activity/ListActivity.java:
663 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
664 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
665 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
666 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
667 These are useful clues when something is wrong.
669 2012-05-06 Murray Cumming <murrayc@murrayc.com>
671 ConfiguredDocument: Avoid a null dereference.
673 * src/main/java/org/glom/web/server/ConfiguredDocument.java
674 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
675 details maps are created.
677 2012-05-06 Murray Cumming <murrayc@murrayc.com>
679 Document: Correct the port number parsing.
681 * src/main/java/org/glom/web/server/libglom/Document.java:
682 This lets us actually connect to the database and show the document.
684 2012-05-05 Murray Cumming <murrayc@murrayc.com>
688 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
689 user-interaction, asking us to load a temporary URL in a browser.s
690 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
691 which is apparently necessary for testing the service. See the comment.
692 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
693 Show the exception, if any. This is how I saw the 404 in the HTML in
696 2012-05-05 Murray Cumming <murrayc@murrayc.com>
698 DocumentTest: Move the .glom files into the resources directory.
700 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
701 URI via getResource().
703 2012-05-05 Murray Cumming <murrayc@murrayc.com>
705 Document: Remove the FieldIdentifies inner class.
707 * src/main/java/org/glom/web/server/libglom/Document.java: We only
708 use the Relationship (though the same function in libglom is maybe
709 used in other ways) and so this removes a compiler warning.
711 2012-05-05 Murray Cumming <murrayc@murrayc.com>
713 Document.load() Remove the error code parameter.
715 * src/main/java/org/glom/web/server/libglom/Document.java: load():
716 Remove the parameter. We do not set it yet and it could never have
717 worked as an output parameter (though maybe it did in java-libglom).
718 We could use an exception if we really want the failure reason.
719 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
721 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
722 setUp(), testGetSuitableTableToViewDetails(): Adapt.
724 2012-05-05 Murray Cumming <murrayc@murrayc.com>
726 Make some inner classes static.
728 * src/main/java/org/glom/web/server/ConfiguredDocument.java
729 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
730 * src/main/java/org/glom/web/server/ReportGenerator.java
731 * src/main/java/org/glom/web/server/libglom/Document.java
732 Make all inner classes static that can be static.
734 2012-05-05 Murray Cumming <murrayc@murrayc.com>
736 OnlineGlomServiceImpl: Do not load and check for java-libglom.
738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
739 init(): We do not use java-libglom any more.
741 2012-05-05 Murray Cumming <murrayc@murrayc.com>
743 Remove mentions of java-libglom.
745 * README: Remove mention of java-libglom, because it no longer needed.
746 * utils/build-onlineglom-war.sh:
747 * utils/check-and-recover-tomcat.py:
748 * utils/install-onlineglom-war.sh: Remove these as they are no longer
749 useful. Building is now far easier, with no need for jhbuild.
751 2012-05-05 Murray Cumming <murrayc@murrayc.com>
753 Fix the build (mvn package)
755 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
756 (LayoutGroup): Make the LayoutItemList inner class static and protected.
757 Otherwise the GWT Java->Javascript compilation fails with just this
758 error, during mvn package or when attempting to view in a browser,
759 in the GWT developer mode in Eclipse.
761 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
762 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
763 [INFO] Compiling module org.glom.web.OnlineGlom
764 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
765 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
766 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
767 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
768 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
769 [INFO] [ERROR] Cannot proceed due to previous errors
771 It has taken me 2 days to find out what was causing that. After reducing
772 the code, the compiler eventually showed me the full error message.
774 2012-05-04 Murray Cumming <murrayc@murrayc.com>
776 ConfiguredDocument: Cache the cloned and stripped layouts.
778 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
779 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
780 layout in a map, so we can retrieve it again without rebuilding it.
782 2012-05-04 Murray Cumming <murrayc@murrayc.com>
784 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
786 2012-05-04 Murray Cumming <murrayc@murrayc.com>
788 libglom classes: Implement some auto-generated emthods.
790 2012-05-04 Murray Cumming <murrayc@murrayc.com>
792 Add GwtTestOnlineGlomService.
794 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
795 However, this (and the other GwtTest*) does not seem to run during
798 2012-05-04 Murray Cumming <murrayc@murrayc.com>
800 Remove use of unsupported features from client code.
802 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
803 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
804 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
805 Use our client version of StringUtils instead of the apache commons one.
807 However, the GWT Javascript compliation still fails.
809 2012-04-25 Murray Cumming <murrayc@murrayc.com>
811 Add a Field class and implement some loading of it in Document.
813 2012-04-25 Murray Cumming <murrayc@murrayc.com>
815 Initial Document loading implementation, instead of libglom.
817 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
818 and Translatable classes, and adapt the rest of the code to use them.
819 However, this is still missing Layout and Field classes and loading.
821 2012-04-24 Murray Cumming <murrayc@murrayc.com>
823 Use of jOOQ: Move Field creation into a utility method.
825 * src/main/java/org/glom/web/server/SqlUtils.java:
826 This lets us improve it more easily.
828 2012-04-24 Murray Cumming <murrayc@murrayc.com>
830 Use of jOOQ: Improve the code to COUNT a sub-select.
832 * src/main/java/org/glom/web/server/SqlUtils.java:
833 Move initial query creation into
834 build_sql_select_step_with_where_clause().
835 build_sql_select_count_rows(): Use the jOOQ API instead of
836 concatentating text, because a jOOQ Select*Step is a TableLike,
837 which is what from() takes.
839 2012-04-23 Murray Cumming <murrayc@murrayc.com>
841 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
843 * pom.xml: Depend on jooq.
844 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
845 methods with jOOQ, based on the C++ implementations in libglom,
846 with some changes to the logic required by jooQ.
847 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
849 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
850 * src/main/java/org/glom/web/server/ReportGenerator.java:
851 * src/main/java/org/glom/web/server/SqlUtils.java:
852 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
853 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
854 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
855 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
856 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
857 Adapt. In particular, the SqlUtils methods now need to take a Connection,
858 because jOOQ needs that, though it seems unnecessary.
860 This is not quite finished. Ideally jOOQ would help us to build
861 table_name.field_name names, quoting and escaping them properly.
862 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
864 2012-04-21 Murray Cumming <murrayc@murrayc.com>
866 Move use of Glom.build_sql*() into a new SqlUtils class.
868 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
869 to wrap Glom.build_sql*(). The parameter types are still Glom one,
870 but this will make it easier to start using something other than
871 libglom or SqlBuilder.
873 2012-04-21 Murray Cumming <murrayc@murrayc.com>
875 Update the project URL.
877 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
879 2012-04-21 Murray Cumming <murrayc@murrayc.com>
881 Main layout: Use a FlowTable instead of absolute positioning.
883 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
884 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
885 child panels/widgets must have an absolute position. But that is annoying, so
886 this adds a FlowTable and puts the child panels in there.
888 2012-04-21 Murray Cumming <murrayc@murrayc.com>
890 GwtTestOnlineGlom: Comment out unused code.
892 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
893 Eclipse has started to say that some code is unused.
895 2012-04-21 Murray Cumming <murrayc@murrayc.com>
897 Update to the latest versions of dependencies.
899 * pom.xml: Update version numbers of dependencies to the latest
901 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
902 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
903 * src/main/java/org/glom/web/server/ReportGenerator.java:
904 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
905 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
906 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
908 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
909 Modify the imports where necessary.
911 2012-04-17 Murray Cumming <murrayc@murrayc.com>
913 Style: Remove overflow:hidden from searchbox
915 * src/main/webapp/style.css: Because this pushes the Back To Link
916 label/link on to the next row, which is then hidden due to the
917 hard-coded (in ems) height.
919 2012-04-20 Murray Cumming <murrayc@murrayc.com>
921 Remove some duplicate code.
923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
924 getDocumentInfo(): This must have been duplicated during the merge from the
929 2012-04-19 Murray Cumming <murrayc@murrayc.com>
931 Reports: Localize the waiting for report message.
933 * src/main/java/org/glom/web/client/activity/ReportActivity.java
934 start(): Get the message from the contants.
935 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
937 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
938 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
939 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
940 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
941 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
942 Update these files with the English text for newer strings for now.
944 2012-04-19 Murray Cumming <murrayc@murrayc.com>
946 Reports: Show a message while waiting for the report.
948 * src/main/java/org/glom/web/client/ui/ReportView.java
949 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
950 Add setWaitingText(), to show a message saying that we are
951 waiting for the report to be ready.
952 * src/main/java/org/glom/web/client/activity/ReportActivity.java
953 start(): Call setWaitingText() before calling the async
956 2012-04-19 Murray Cumming <murrayc@murrayc.com>
958 ReportGenerator: Specify date and time formats.
960 * src/main/java/org/glom/web/server/ReportGenerator.java:
961 createFieldValueElement(): Use the default (and localized)
962 short formats, though we still need a way to show 4-digit
963 years without providing the format for every locale.
964 * src/main/java/org/glom/web/server/database/DBAccess.java:
965 convertResultSetToDTO(): Use the short formats here too.
967 2012-04-18 Murray Cumming <murrayc@murrayc.com>
969 ReportGenerator: Use the correct numeric formatting.
971 * src/main/java/org/glom/web/server/ReportGenerator.java
972 createFieldExpression(), createFieldValueElement(): Take the
973 whole LayoutItem_Field instead of just the field name, so
974 we have access to the formatting.
975 createFieldValueElement(): Use JRTextField.setPattern() to
976 specify the numeric formatting, with the help of a
977 regular DecimalFormat.
979 2012-04-18 Murray Cumming <murrayc@murrayc.com>
981 ReportGenerator: Avoid showing null for group by titles.
983 * src/main/java/org/glom/web/server/ReportGenerator.java
984 generateReport(): Use setBlankWhenNull() on the field title
985 style too, because this is used for values in group by
988 2012-04-18 Murray Cumming <murrayc@murrayc.com>
990 ReportGenerator: Add a colon to titles in vertical groups.
992 * src/main/java/org/glom/web/server/ReportGenerator.java
993 addFieldToDetailBandVertical(): Pass true for the withColon
996 2012-04-18 Murray Cumming <murrayc@murrayc.com>
998 ReportGenerator: Simplify the code by using Position more.
1000 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1002 Reports: Support vertical groups, roughly.
1004 * src/main/java/org/glom/web/server/ReportGenerator.java:
1005 addToReport(): Rename to addGroupToReport() and, if necessary,
1006 call the new addVerticalGroupToReport() method.
1007 createFieldValueElement(): Let the caller specify the Y position
1010 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1012 Reports: Allow a second report to be shown.
1014 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1015 clear(): Do not remove the HTML widget, which broke the whole layout.
1017 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1019 Locales drop-down: Show that we use English by default.
1021 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1022 fillView(): When we use English, just because that is the default, when
1023 no locale is specified, show that in the Locales drop-down instead of
1024 just showing the first item.
1026 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1028 Unselect the Report/Locale/Table combo item when appropriate.
1030 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1031 setPlace(): clear reportName if this is not a ReportPlace.
1032 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1033 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1034 When the provided name is empty, unselect all items, so that none are
1035 indicated. This uses a for loop because I cannot find a single method
1038 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1040 Report: Give the user a way to get back to the list.
1042 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1043 start(), setPlace(): Show the Back To List link on reports, and also
1044 interpret selecting the empty report item as back to list.
1046 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1048 Really show the selected Report name.
1050 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1051 setPlace(): Store the reportName here, if it is that kind of Place.
1052 fillView(): Set the selected Report after filling the list of reports.
1053 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1054 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1055 null Strings, though we need some way to unselect all ListBox items
1058 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1060 ReportGenerator: Try to avoid some problems.
1062 * src/main/java/org/glom/web/server/ReportGenerator.java
1063 addField(): Try to avoid duplicates, and avoid using a null
1066 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1068 Reports: Use quickFind.
1070 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1071 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1073 getReportHTML(): Add a quickFind parameter.
1074 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1075 start(): Pass the quickFind parameter.
1076 * src/main/java/org/glom/web/server/ReportGenerator.java
1077 generateReport(): Take a quickFind parameter.
1079 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1081 ReportPlace: Actually use the report name.
1083 * src/main/java/org/glom/web/client/place/ReportPlace.java
1084 getPlace(): Do not assign the report name to the quickfind.
1086 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1088 Show java.library.path when complaining.
1090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1091 init(): When telling us to check java.library.path, show the
1094 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1096 ReportGenerator: Do not show nulls.
1098 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1100 ReportGenerator: Make the title font larger.
1102 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1104 ReportGenerator: Put field titles inside groups, if there are groups.
1106 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1108 ReportGenerator: Take the Report itself instead of the name and group.
1110 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1111 Remove getReportLayoutGroup().
1112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1113 getReportHTML(): Pass the report instead
1114 of its name and layout group.
1115 * src/main/java/org/glom/web/server/ReportGenerator.java
1116 generateReport(): Use the report object to use the title
1117 instead of the name.
1119 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1121 ReportGenerator: Remove designBand parameters.
1123 * src/main/java/org/glom/web/server/ReportGenerator.java:
1124 Make designBand a class member instead of passing it to all
1127 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1129 ReportGenerator: Add lines, a bit like in the desktop version.
1131 * src/main/java/org/glom/web/server/ReportGenerator.java
1132 addToReport(): Use JRDesignLine.
1134 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1136 ReportGenerator: Correct the title positions and use some bold style.
1138 * src/main/java/org/glom/web/server/ReportGenerator.java:
1139 Break the code up into reusable functions, correct the placement of
1140 titles, and use normal/bold styles as in the reports in the desktop
1143 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1145 ReportGenerator: Add a header band to show the field titles.
1147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1148 getReportHTML(): Pass the localeId to the ReportGenerator
1150 * src/main/java/org/glom/web/server/ReportGenerator.java
1151 constructor: Take the localeID so we can get translated field
1153 generateReport(), addToReport(), addFieldToBand(): Add field
1154 titles in a column header band.
1156 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1158 Reports drop-down list: Some improvement.
1160 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1161 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1162 Adedd setSelectedReport(),
1163 setReportList(): Add a blank line so that the user can select the
1165 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1166 start(): Show the current report by calling setSelectedReport().
1167 This does not seem to work yet.
1169 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1171 DetailsActivity, ListActivity: Move some variables into a base class.
1173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1174 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1175 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1176 the clientFactory, documentID, tableName and authenticationPopup into
1177 a base class, to avoid duplication.
1179 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1181 Translate the Reports label.
1183 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1184 Get the "Reports" label string from the constants.
1185 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1186 perties: Add Reports to the constants.
1188 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1190 Reports: Implement grouping.
1192 * src/main/java/org/glom/web/server/ReportGenerator.java:
1193 Handle LayoutItem_GroupBy items and try to do the right thing
1194 with JRDesignGroup. It seems to work.
1196 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1198 Actually show some data with JasperReports.
1200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1201 getReportHTML(): Move most code into a ReportGenerator class.
1202 * src/main/java/org/glom/web/server/ReportGenerator.java:
1203 Recurse into sub-groups, adding fields to the JasperDesign's details
1204 band. Note that we must set an arbitrary width and height, or it just
1205 will not show any data.
1207 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1209 Reports Chooser: Show the titles, not the names.
1211 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1212 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1213 and the names as the values.
1214 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1215 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1216 group now that we provide the report name, so it should always
1219 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1221 Depend on jasperreports.
1223 * pom.xml: Add the dependency. My plan is to use this on the
1226 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1228 Implement navigation to report places.
1230 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1231 start(): Do not bother to handle all events here.
1232 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1233 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1234 Added getSelectedReport().
1235 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1236 .java: start(): When handling a change to the reports chooser,
1237 call getSelectedReport() and goTo() its ReportPlace.
1238 * src/main/java/org/glom/web/client/ui/ReportView.java
1239 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1240 Added setReportHTML() which puts the html in a gwt HTML widget.
1241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1242 getReportHTML(): Return "TODO" just to show that this works.
1244 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1246 Make ReportPlace usable.
1248 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1249 Mention ReportPlace.
1250 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1251 Correct the @prefix annotation.
1253 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1255 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1257 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1258 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1259 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1260 Change getReportLayout() to getReportHMTL() because we will not need to
1261 parse or render the report layout on the client side.
1262 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1263 getReportLayout(): Return the libglom LayoutGroup type because we will
1264 not need to convert to a shared type, because this will not be used on
1266 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1269 Note that there is still no implementation for this.
1272 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1274 Add a (empty) Report Place, View, and Activity.
1276 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1278 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1279 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1280 this into a superclass:
1281 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1282 and also use it as the base of this new ReportPlace:
1283 * src/main/java/org/glom/web/client/place/ReportPlace.java
1285 * src/main/java/org/glom/web/client/ui/ReportView.java
1286 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1287 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1288 Add these, containing mostly boiler-plate for now.
1290 * src/main/java/org/glom/web/client/OnlineGlomService.java
1291 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1292 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1294 Add API to get the LayoutGroup for the report.
1296 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1298 Add and fill a Reports drop-down list box.
1300 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1302 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1303 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1305 Added getReports(document, table, localeID), calling
1306 ConfiguredDocument.getReports().
1307 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1308 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1309 Added setReportsList() and a list widget.
1310 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1311 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1316 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1318 Translations: Add Esperanto.
1320 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1321 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1322 properties: Add this translation because someone took the time to make it.
1324 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1326 Adapt to the java-libglom 1.21.7 API.
1328 * src/main/java/org/glom/web/server/ReportGenerator.java:
1329 addToReport(): get_group_secondary_fields() is now
1330 get_secondary_fields().
1333 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1335 Use the latest java-libglom version.
1337 * pom.xml: Use java-libglom 1.21.7.
1339 2012-03-03 Ben Konrath <ben@bagu.org>
1341 Display date and time in details view.
1343 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1345 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1347 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1349 Require the latest java-libglom.
1351 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1353 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1355 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1357 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1358 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1359 an empty quickfind string. I also corrected libglom to create only
1360 empty where clauses for empty quickfind strings, but this avoids the
1363 2012-02-24 Ben Konrath <ben@bagu.org>
1365 Improve the tabs in the Notebook widget.
1369 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1371 Translations: Try to translate the strings.
1373 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1374 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1375 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1376 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1377 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1378 Take the Open translation from GTK+'s .po files.
1379 Take the Details translation from Glom's po files.
1380 I have added the other strings to Glom so we can get translations that way:
1381 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1383 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1385 TableSelectionViewImpl: Put the search label and entry in a div.
1387 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1388 Put the search widgets in a FlowTable so that the CSS can be used to
1389 style them while keeping them together.
1390 * src/main/webapp/style.css: Mention the new div.
1392 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1394 Translate more strings in more locales.
1396 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1397 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1398 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1399 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1400 Translate the "Details" and "Open" string too.
1402 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1403 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1404 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1405 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1406 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1407 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1408 Add these new locales as placeholders though they currently contain English.
1410 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1412 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1415 Check the ConfiguredDocument* for null before using it.
1417 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1419 Tell Eclipse about the generated java files.
1421 * .classpath: This lets it find OnlineGlomConstants.java.
1422 It would be nice if Eclipse just used the maven build files.
1424 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1426 Prevent a crash when no locale is specified in the URL.
1428 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1429 Avoid returning a null string, obtained from
1430 Window.Location.getParameter(). This caused a crash when it was
1431 later passed to libglom's API.
1432 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1433 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1434 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1435 guard against future null strings.
1437 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1439 Use the ?locale= query param instead of the &lang= token param.
1441 * src/main/java/org/glom/web/client/place/ListPlace.java
1442 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1443 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1444 Remove the lang token key and value.
1446 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1447 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1448 When the user selects a different locale from the chooser, use
1449 Window.Location.assign() to change the URL, which then causes a reload.
1451 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1452 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1453 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1454 * src/main/java/org/glom/web/client/activity/ListActivity.java
1455 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1456 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1457 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1458 * src/main/java/org/glom/web/client/ui/ListView.java:
1459 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1461 Remove localeID member variables and method/constructor parameters, instead
1462 using Utils.getCurrentLocaleID() when we need a localID to pass to
1465 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1467 Internationalize the UI strings.
1469 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1470 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1471 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1472 because it is unused. Messages are apparently strings that can have
1473 parameters, but we do not need that yet, so Contants will be enough for now.
1474 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1475 to say that we support the en and de locales.
1476 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1477 The original English strings.
1478 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1479 Some German translations of the English strings.
1480 The i18n goal then uses the .properties file to generate an
1481 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1482 returns an implementation that returns the translated strings.
1483 The documentation suggests putting these in src/java/*/client/, but it seems
1484 best to put it in src/resources/*/client/.
1485 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1486 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1487 instead of hard-coding them.
1488 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1489 but that does not seem to stop the build, though it confuses Eclipse.
1491 You can see the translated string by adding ?locale=de to the URL, like so:
1492 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1494 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1496 Improve null/empty String checks.
1498 * pom.xml: Add a dependency on commons-lang, to use
1499 org.apache.commons.lang.StringUtils.
1500 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1502 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1503 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1504 Use StringUtils.isEmpty().
1506 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1507 StringUtils class with a static isEmpty() function because we
1508 cannot use org.apache.commons.lang.StringUtils in client-side
1509 GWT code because it (apparently) cannot be compiled to javascript.
1510 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1511 * src/main/java/org/glom/web/client/activity/ListActivity.java
1512 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1513 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1514 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1515 * src/main/java/org/glom/web/client/place/ListPlace.java
1516 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1517 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1518 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1519 * src/main/java/org/glom/web/client/ui/details/Group.java
1520 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1521 our StringUtils.isEmpty() function.
1523 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1525 Update to the latest java-libglom API.
1527 * pom.xml: Require java-libglom 1.21.4.
1528 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1529 getDocumentInfo(), getListViewLayoutGroup():
1530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1532 * src/main/java/org/glom/web/server/database/DBAccess.java
1533 getFieldsToShowForSQLQueryAddGroup(),
1534 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1535 with either get_database_title_original() or
1536 get_database_title(localeID).
1538 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1540 ConfiguredDocument: Avoid a null pointer exception.
1542 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1543 Initialize localeID to "" to avoid returning a null String which
1544 causes a crash in java-libglom's swing-generated code.
1546 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1548 Some simple renaming.
1550 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1551 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1552 for localeChooser. This seems more appropriate and is less ambiguous
1553 particularly in the .css file.
1555 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1557 ConfiguredDocument: Rename the localedID private member variable.
1559 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1561 Adapt to the latest java-libglom API from git master.
1563 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1564 libglom now uses only Vector instead of List, which uses add() instead of
1567 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1569 ConfiguredDocument: Rename the localedID private member variable.
1571 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1573 Build a source tarball with mvn assembly:single
1575 * assembly.xml: Add this file.
1576 * pom.xml: Use the maven-assembly-plugin and tell it to use
1577 our assembly.xml file.
1579 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1581 OnlineGlomServiceImpl: Get .glom files recursively.
1583 * pom.xml: Depend on commons-io from org.apache.commons.
1584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1585 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1586 files recursively, and with the easier filter for the extension.
1587 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1588 simplify that code too.
1590 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1592 README: Mention that you must install java-libglom packages separately.
1594 But then it works, because java-libglom is now in the central maven
1597 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1599 locales drop-down: Show the correct selected locale when the URL changes.
1601 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1602 .java: setPlace(): Move some code into fillView().
1604 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1606 locales drop-down: Do not lose the primary key.
1608 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1609 start(): onLocaleChange(): Pass the current primary key value,
1610 instead of an empty value.
1612 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1614 locales drop-down: Do not lose the drop-down selection.
1616 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1617 .java (TableSelectionActivity.fillView): Set the selected locale
1618 after changing the drop-down items (though we do not really need
1619 to change them just because the locale changes.)
1621 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1623 locales drop-down: Change the tables list when this changes.
1625 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1626 .java: TableSelectionActivity.start(): Move the async table titles
1627 retrieval into a private fillView() method and also call this when
1628 the chosen locale changes.
1629 Note that the document title is not actually translatable yet, but
1630 that is a problem that I should fix soon in libglom.
1632 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1634 Improve the placement of the locales drop-down.
1636 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1637 Put the title and locales drop-down in a div (gwt.FlowTable).
1638 * src/main/webapp/style.css: Add magic css properties to make this work.
1639 Also remove the left margin from the title so that it lines up with the
1642 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1644 locales selector: Show human-readable locale titles.
1646 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1647 getDocumentInfo(): Use java.util.Locale to show a real title of
1648 each locale, in the locale's own language.
1650 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1652 Add a language/locale selector drop-down.
1654 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1655 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1656 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1657 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1658 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1659 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1660 Add a ListBox to show the available locales. Add getLocaleSelector(),
1661 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1662 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1663 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1664 java: Add these classes.
1665 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1666 start(): Fill the locales ListBox. Handle its change event, firing a
1668 setPlace(): Show the selected locale as specified by the URL token.
1669 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1670 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1671 Handle LocaleChangeEvent, going to a new *Place with that locale.
1673 The placement of the ListBox is not pretty, and it currently uses the ID
1674 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1678 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1680 Search box: Show the search text from the URL token.
1682 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1683 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1684 Add setQuickFindText().
1685 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1686 .java: setPlace(): Store the queryText if the place is a ListPlace,
1687 and call TableSelectionView.setQuickFindText().
1689 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1691 Allow use of translations via, for instance, &lang=de in the URL.
1693 * pom.xml: Use the unstable java-libglom 1.21 version.
1695 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1696 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1698 init(): Instead of calling TranslatableItem.set_current_locale()
1699 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1700 However, this is only for default locales, which are not needed to
1701 change the locale in the URL.
1702 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1703 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1704 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1705 layout for a particular locale.
1706 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1707 Add get/setDefaultLocaleID().
1708 getDocumentInfo(), getListViewData(), getRelatedListData(),
1709 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1710 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1711 localeID parameter, so we can get the layout for a particular locale.
1713 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1714 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1715 * src/main/java/org/glom/web/client/place/ListPlace.java:
1716 Parse and construct a lang parameter too.
1718 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1719 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1720 passed to subsequent methods and constructors.
1721 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1722 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1723 Store the localeID from the *Place and pass it to other constructors
1724 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1726 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1727 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1728 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1729 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1730 * src/main/java/org/glom/web/client/ui/ListView.java:
1731 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1732 Take localeID parameters and pass them to subsequent constructors and
1733 methods, so that the layout is always retrieved for that locale.
1735 This is rather repetitive.
1737 Note that "" means the original (default) locale of the Glom document,
1738 which is usually English.
1740 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1742 Documents: Remove final keyword to fix startup configuration.
1744 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1745 final keywords on the private member variables because that breaks
1746 the startup, apparently (there are warnings) because it stops them
1747 from being serialized. I added these in the previous commit.
1749 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1751 Documents: Add some final keywords.
1753 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1756 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1758 OnlineGlomServiceImpl: Add to overview comments.
1760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1761 Note that this is where all the document are loaded. They are not
1762 loaded freshly for each page.
1764 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1768 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1769 Add a TextBox for the text of a quick find.
1770 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1772 setBackLink(): Add a String quickFind parameter.
1773 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1774 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1775 to the base interface, because that is how TableSelectionViewImpl is used.
1776 * src/main/webapp/style.css: Add style for the search box and its label.
1778 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1779 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1780 Add these files, based on the existing TableChangeEvent and
1781 TableChangeEventHandlers.
1782 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1783 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1784 a ListPlace() that the user should be taken to.
1785 * src/main/java/org/glom/web/client/activity/ListActivity.java
1786 start(): Handle it here too and adapt the TableChangeEvent handler to
1787 pass the extra "" quickFind parameter to ListPlace.
1788 * src/main/java/org/glom/web/client/place/ListPlace.java:
1789 Constructor: Take an extra String quickFind parameter and store it,
1790 returning it from a new getQuickFind() method.
1791 getToken(): Put the quickFind text in the URL token.
1792 getPlace(): Parse the quickFind text from the URL token.
1793 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1794 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1795 ListPlace constructor.
1796 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1797 .java: start(): Add a Change handler for the TableSelectionView's
1798 TextBox (via its base HasChangeHandlers interface), firing the new
1799 QuickFindChangeEvent.
1800 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1801 pass the extra "" quickFind parameter.
1803 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1804 setCellTable(): Add a String quickFind parameter and pass it to
1805 the ListViewTable() constructor.
1806 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1807 setCellTable() in the base interface, because that is how ListViewImpl
1810 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1811 Add a String quickFind member variable.
1812 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1813 Constructor: Add a String quickFind parameter, storing it in the
1814 base ListTable's member variable.
1815 onRangeChanged(): Pass quickFind to the
1816 OnlineGlomServiceAsync.getSortedListViewData() and
1817 OnlineGlomServiceAsync.getListViewData() methods.
1819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1820 getListViewData(), getSortedListViewData(): Add a String quickFind
1821 parameter, passing it to ConfiguredDocument.getListViewData().
1822 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1823 Change getListViewData(), getSortedListViewData() in the base interface,
1824 because that is how OnlineGlomServiceImpl is used, via this:
1825 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1826 Change getListViewData(), getSortedListViewData() here too.
1827 This class can apparently be used to asynchronously call methods on
1828 OnlineGlomService, and GWT seems to implement that after recognizing
1829 just the *Async name convention and the extra AsyncCallback parameters.
1831 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1832 getListViewData(): Add a String quickFind parameter, and pass it to
1833 ListViewDBAccess.getData().
1834 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1835 getListData(): Add a String quickFind parameter and pass it to
1837 getSelectQuery(): Add a String quickFind parameter.
1838 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1839 getSelectQuery(): Add a String quickFind parameter and use it with
1840 Glom.get_find_where_clause_quick() to pass a where_clause to
1841 Glom.build_sql_select_with_where_clause(), to actually filter the
1843 getData(): Add a String quickFind parameter, passing it to getListData().
1844 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1845 va: getData(): Pass an empty string to getListData() for the
1846 quickFind parameter.
1848 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1850 ListTable: Minor change.
1852 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1853 createCellTable(): Make this protected instead of public.
1855 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1857 Many files: Use final for the parameters and use the @override attribute.
1859 2012-01-22 Ben Konrath <ben@bagu.org>
1861 Add anchor links for single line text that starts with http, ftp and www.
1865 2012-01-22 Ben Konrath <ben@bagu.org>
1867 Add ellipsis to single line text in details view.
1871 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1873 Remove all javadoc author tags.
1875 Because they are awkward and meaningless when many people touch
1877 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1879 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1881 Revert the COPYING.LESSER to COPYING rename.
1883 Apparently both should be there if it is LGPL.
1885 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1887 *View: Remove unused imports.
1889 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1890 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1891 * src/main/java/org/glom/web/client/ui/ListView.java:
1892 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1893 Remove unused imports, as suggested by Eclipse.
1895 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1897 Move the *View::Presenter types, and some API into one base View.
1899 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1900 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1901 * src/main/java/org/glom/web/client/ui/ListView.java:
1902 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1903 Presenter, setPresenter() and clear() into a shared base interface,
1904 to avoid the unnecessary duplicate Presenter types and to more clearly
1905 show how the *Views share the same structure, even if they are not
1906 used polymorphically.
1908 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1909 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1911 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1912 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1913 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1915 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1918 Feel free to revert this if there is a good reason for the duplicate
1921 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1923 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1925 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1926 a class member instead of a local variable in the method.
1927 This lets us use it to get the view instances, for use in tests.
1928 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1929 beforeOnlineGlom(): Test some more details of the initial view.
1930 Again, this is not very useful.
1932 To really test gwt-glom we will need to start a local postgresql
1933 instance with local data, like the Glom tests in C++.
1935 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1937 pom.xml: Mention the LGPL license.
1939 * pom.xml: Add a licenses section.
1940 * COPYING.LESSER: Move this to COPYING, which
1941 previously contained the GPL. But gwt-glom is all LGPL.
1943 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1945 Add project information to README and pom.xml.
1947 * README: Add a brief description and mention some mvn
1949 * pom.xml: This extra information shows up in mvn site
1952 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1954 Use the latest java-libglom version.
1956 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1958 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1960 GwtTestOnlineGlom: Test a little more.
1962 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1963 protected rather than private, as suggested by the gwt-test-utils
1965 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1966 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1967 Test the initial visibility of the panels.
1969 However, this is not a very useful test.
1970 And I wonder how we should generally test using this idea for an
1971 activity/places app like ours where the real changes happen implicitly
1972 based on the history token/URL.
1974 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1976 Slight modification to *Mapper comments.
1978 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1979 (DataActivityMapper)
1980 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1982 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1984 Remove comments mentioning GIN because they are just copied from
1985 the example code and are apparently not helpful:
1986 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1987 Also change the mention of a class that is only in the example code.
1989 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1991 GwtTestOnlineGlom test: Minor changes.
1993 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1994 Avoid the long qualified class name and modify the comment
1995 because it is now obvious to me that the mocked class is the only
1996 custom one created via GWT.create().
1998 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2000 Tests: Added the beginnings of a test using gwt-test-utils.
2002 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2003 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2004 which tells gwt-test-utils what class will be tested.
2005 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2006 Add a simple (but empty) test case. One class, used by the OnlineGlom
2007 class, is mocked so that it can be created. However, I am not sure
2008 why only this class needs to be mocked.
2010 Note that mockito seems more popular, and clearer, than easymock,
2011 but I have not got that working yet. It might be a matter of the
2014 This test is run during mvn integration-test.
2016 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2018 Tests: Use junit4-style syntax instead of junit3-style.
2020 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2021 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2022 * src/test/java/org/glom/web/shared/DataItemTest.java:
2023 Use the @Test annotation rather than relying on the test*() prefix.
2024 Also no longer implement TestCase, to avoid triggering support for
2025 the junit3-way, which stops the annotations from working.
2026 Change the imports from import junit.framework.* to
2027 import org.junit.*, which is apparently the new way.
2029 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2031 Added a test for ListPlace token parsing and creation.
2033 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2034 This is much the same as DetailsPlaceTest.
2036 I wonder how we could test the other parts of the *Place API.
2038 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2040 DetailsPlace test: Also test getToken() and recreation via getPlace().
2042 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2043 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2044 recreate it, testing the recreated DetailsPlace for the same parameter
2047 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2049 Use the surefire-report plugin.
2051 * pom.xml: This generates a HTML report about the tests in
2052 target/site/surefire-report.html
2053 when you do mvn surefire-report:report. It seems to be popular/normal.
2055 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2057 Added a test for DetailsPlace.
2059 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2060 Test the getPlace() token parsing.
2062 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2064 Added a first unit test.
2066 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2067 * src/test/java/org/glom/web/shared/DataItemTest.java:
2068 This is a silly test but it is just to get things started. Note that
2069 maven/junit finds the test because it looks in src/test by default.
2071 2011-12-22 Ben Konrath <ben@bagu.org>
2073 Change charsetName to "UTF-8" when replacing line breaks.
2075 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2076 that work in Java (such as "UTF8") will not work when compiled to
2079 This fixes a problem with multi-line details view fields that have hard
2080 line breaks. The "License Text" field on this page demonstrates the
2083 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2085 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2087 2011-12-22 Ben Konrath <ben@bagu.org>
2089 Fix another bug with related list navigation.
2091 I've tested all the navigation buttons in all of the related lists
2092 so things should be good now.
2094 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2096 2011-12-22 Ben Konrath <ben@bagu.org>
2098 Fix a crasher when refreshing the list view with the default table.
2100 This crash will also happen when loading the list view with the default
2101 table from a link or bookmark.
2103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2104 to the main document selection page when the document id hasn't been
2106 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2107 the main document selection page when the document id hasn't been
2109 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2110 values for the details place when the document id hasn't been set.
2111 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2112 values for the list place when the document id hasn't been set.
2114 2011-12-21 Ben Konrath <ben@bagu.org>
2116 Protect against NPE when glom.document.locale is not in config.
2118 This patch protects against an NPE when glom.document.locale is not in
2119 the config file. This NPE will also happen if glom.document.locale is
2122 The patch also updates the error message to display the class name when
2123 the getMessage() returns null. This was happening when the NPE was
2124 thrown and I had "Configuration Error: null". If an NPE is encountered
2125 with this patch, "Configuration Error: NullPointerException " will be
2128 This commit closes this bug:
2130 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2134 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2136 Rename onlineglom.properties to onlineglom.properties.sample.
2138 * src/main/resources/onlineglom.properties: Rename to:
2139 * src/main/resources/onlineglom.properties.sample:
2140 * src/main/resources/README: And add this file explaining that people
2141 should rename it back when deploying.
2143 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2145 Allow choosing the translation in the .properties file.
2147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2148 init(): Read a glom.document.locale value from the configuration file
2149 and call Glom's TransatableItem::set_current_locale() method.
2150 * src/main/resources/onlineglom.properties: Add a commented-out
2151 example of this new setting.
2153 It would be better to add &lang=de_DE to the URL, but the current
2154 libglom API does not allow us to do this easily. I am working on that.
2156 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2158 Avoid a crash in parsing of token parameters.
2160 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2161 ava: getTokenParams(): Do not crash if a parameter has a key but no
2162 value, and ignore parameters with neither.
2164 2011-12-17 Murray Cumming <murrayc@murayc.com>
2166 History token building/handling: Improve use of token parameters.
2168 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2169 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2170 and buildParamsToken(HashMap), for use by derived classes.
2171 Make the separator private because it is no longer be needed.
2172 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2173 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2174 instead of manual string concatenation.
2175 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2176 of hardcoded indices and awkward splitting code.
2177 * src/main/java/org/glom/web/client/place/ListPlace.java
2178 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2179 instead of manual string concatenation.
2180 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2181 of hardcoded indices and awkward splitting code.
2182 This should fix bug #666420
2184 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2186 Fix a Navgiation->Navigation typo in the code.
2188 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2189 Rename processNavgiation() to processNavigation().
2191 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2193 Fix a seperator->separator typo in the code.
2195 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2196 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2197 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2200 2011-12-15 Ben Konrath <ben@bagu.org>
2202 Cleanup some comments.
2204 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2206 2011-12-14 Ben Konrath <ben@bagu.org>
2208 Replace \n with <br/> for multiline text in the details view.
2210 Vertical scrollbars are added when needed as well.
2212 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2214 2011-12-14 Ben Konrath <ben@bagu.org>
2216 Specify the font for document selection links.
2218 * src/main/webapp/style.css:
2220 2011-12-14 Ben Konrath <ben@bagu.org>
2222 Fix bouncy CellTable while paging.
2224 This doesn't currently work with related list tables in unselected
2227 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2229 2011-12-14 Ben Konrath <ben@bagu.org>
2231 Revamp the appearance of the document selection page.
2233 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2234 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2235 * src/main/webapp/style.css:
2237 2011-12-13 Ben Konrath <ben@bagu.org>
2239 Set navigation button column to the smallest size possible.
2241 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2243 2011-12-13 Ben Konrath <ben@bagu.org>
2245 Change OpenButton nomenclature to NavigationButton.
2247 Using NavigtionButton makes things more generic. Classes, methods and
2248 variables have been changed.
2250 This is a rename-only refactor.
2252 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2253 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2254 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2255 Renamed from OpenButtonCell.
2256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2257 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2258 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2260 2011-12-12 Ben Konrath <ben@bagu.org>
2262 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2264 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2265 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2266 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2267 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2269 2011-12-12 Ben Konrath <ben@bagu.org>
2271 Update variable names and comments.
2273 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2274 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2276 2011-12-12 Ben Konrath <ben@bagu.org>
2278 Properly initialize numNonEmptyRows variable to zero.
2280 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2281 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2283 2011-12-05 Ben Konrath <ben@bagu.org>
2285 Add latest mockup with HTML tables.
2287 Features of this mockup:
2289 -> HTML table for flowtable
2290 -> HTML table for flowtable column
2291 -> Example of how related lists would look
2292 -> Not using text entries for data items
2294 The current version of Online Glom doesn't use HTML tables for the
2297 This mockup has been sent to the glom-devel mailing list but it's good
2298 to have it here as well.
2300 * mockups/details-view-html-tables.html:
2302 2011-12-05 Ben Konrath <ben@bagu.org>
2304 Remove unnecessary getPrimaryKeyField() method.
2306 getPrimaryKeyFieldForTable(String) has been renamed to
2307 getPrimaryKeyField(String).
2309 * src/main/java/org/glom/web/server/database/DBAccess.java:
2310 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2311 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2313 2011-12-05 Ben Konrath <ben@bagu.org>
2315 Add string representation of TypedDataItem value to conversion error message.
2317 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2318 message was extracted into its own method to avoid duplication.
2320 2011-12-05 Ben Konrath <ben@bagu.org>
2322 Add type checking to navigation primary key value creation.
2324 Create navigation primary key only if the expected type from the Glom
2325 document matches the type returned by the SQL query.
2327 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2329 2011-12-05 Ben Konrath <ben@bagu.org>
2331 Rename a couple of variables in RelatedListNavigation.
2333 This is a rename-only refactor.
2335 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2337 2011-12-05 Ben Konrath <ben@bagu.org>
2339 Move getListLayoutGroup() into getListViewLayoutGroup().
2341 This removes getListLayoutGroup(). It was only being called by
2342 getListViewLayoutGroup().
2344 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2346 2011-12-05 Ben Konrath <ben@bagu.org>
2348 Remove check for LayoutItem_Portal in list table method.
2350 This check is no longer necessary because the method isn't being used
2351 to create the LayoutItemPortal DTO.
2353 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2355 2011-12-05 Ben Konrath <ben@bagu.org>
2357 Properly support related list navigation.
2359 Navigation from the "Repository Analyzer -> Package Scans ->
2360 Dependencies" related table wasn't working because the primary key for
2361 related tables wasn't being set properly. This commit fixes the
2364 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2365 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2366 doesn't set the primary key properly for related list tables.
2367 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2368 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2369 useful for getting the primary key for list view tables and for related
2371 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2372 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2373 Move code to set the primary key for the table from the abstract
2374 ListDBAccess class to ListViewDBAccess as it's only correct for list
2376 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2377 Properly add primary key to related list tables.
2379 2011-12-02 Ben Konrath <ben@bagu.org>
2381 Properly set the horizontal alignment of fields.
2383 This fix is for both the list tables and the details view.
2385 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2386 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2387 to set the horizontal alignment of fields.
2389 2011-12-02 Ben Konrath <ben@bagu.org>
2391 Display currency codes in the details view.
2393 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2395 2011-12-02 Ben Konrath <ben@bagu.org>
2397 Avoid duplicate JNI call.
2399 JNI is not as efficient as pure Java and this is an easy (and small)
2402 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2403 Use previously retrieved value for whereClauseToTableName instead of
2406 2011-12-02 Ben Konrath <ben@bagu.org>
2408 Rename a couple of variables in RelatedListNavigation.
2410 This is a rename-only refactor.
2412 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2414 2011-12-02 Ben Konrath <ben@bagu.org>
2416 Indicate clearly that a mismatched primary key type is a bug.
2418 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2419 warning to error. Add 'This is a bug.' to message.
2421 2011-12-02 Ben Konrath <ben@bagu.org>
2423 Update / fix some comments.
2425 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2427 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2429 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2430 Fix comments. Add some TODOs.
2432 2011-12-02 Ben Konrath <ben@bagu.org>
2434 Enable navigation to details view with string primary key from related list.
2436 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2437 Create a text primary key value when return type of result is
2438 java.sql.Types.VARCHAR.
2440 2011-12-02 Ben Konrath <ben@bagu.org>
2442 Use checkboxes for booleans in the details view.
2444 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2446 2011-12-01 Ben Konrath <ben@bagu.org>
2448 Improve performance of related list height calculation.
2450 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2451 Put code to calculate the expected height in a static initializer so
2452 that that it's only called once.
2454 2011-12-01 Ben Konrath <ben@bagu.org>
2456 Show related list tables in notebooks (again).
2458 Calculate the height of the related list tables so the Notebook can be
2459 set the correct height. The height of the related list table is also needed by
2460 FlowTable to be able decide how to create the layout.
2462 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2463 and set the Portal height based on the height of the related list
2464 table and the Portal container.
2465 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2466 Add method to calculate the height of the related list tables.
2467 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2468 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2469 calculate the height of the Pager widget.
2471 2011-12-01 Ben Konrath <ben@bagu.org>
2473 Use CellTable API for table property instead of setting style on Element.
2475 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2477 2011-12-01 Ben Konrath <ben@bagu.org>
2479 Make ListViewTable and RelatedListTable a consistent height.
2481 The tables are now a consistent height regardless of the contents of
2482 the table. A hidden button is added to empty rows to ensure that the
2483 height of these rows will match the height of rows with data.
2485 A navigation button column is now added to every table. The width of
2486 the navigation column is set to 0px when a RelatedListTable shouldn't
2487 have navigation buttons. This maintains the a consistent row height in
2488 tables that don't show the navigation buttons.
2490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2491 navigation column when not needed.
2492 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2493 arguments for navigation button to constructor of ListViewTable.
2494 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2495 hidden button for empty data rows.
2496 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2497 arguments for navigation button to constructor.
2498 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2499 create navigation buttons. Add hideNavigationButtons() method.
2500 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2501 arguments for navigation button to constructor.
2503 2011-12-01 Ben Konrath <ben@bagu.org>
2505 Use 'visibility: hidden' in Utils.getWidgetHeight().
2507 This is better choice because hidden elements are invisible, don't
2508 respond to events and are not part of the tab order. They will,