1 2012-05-11 Murray Cumming <murrayc@murrayc.com>
3 Document: Correct loading of doubly-related layout fields.
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 loadUsesRelationship(): Actually set the related relationship, instead
7 of only setting it if it's not found.
9 2012-05-07 Murray Cumming <murrayc@murrayc.com>
11 ConfiguredDocument: Restore correct addition of hidden primary key items.
13 * src/main/java/org/glom/web/client/ui/list/ListTable.java
14 (ListTable.createCellTable): Uncomment out the check for the hidden
16 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
17 add primary key items for top-level lists and portals, as before,
18 instead of adding them to each group.
19 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
20 Actually implement the extra methods such as setHiddenPrimaryKey() and
21 comment that these are used only for top-level list groups and in portals.
22 This strangeness suggests even more that this should not be squeezed
23 into the LayoutGroup class.
25 2012-05-07 Murray Cumming <murrayc@murrayc.com>
27 Fix Formatting loading.
29 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
30 getFormattingUsed(): Remove the duplicate Formatting member variable
31 in favour of the one from the base class.
32 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
33 Initialize a new Formatting instead of using null by default, so we
34 have some defaults, instead of having to initialize one later just to
35 get the same defaults. This also makes loading of formatting from the
36 document work, because that expected a non-null.
38 2012-05-07 Murray Cumming <murrayc@murrayc.com>
40 RelatedListTable: Make sure that the tableName is set.
42 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
43 Constructor: Take the tableName so it is available later. Otherwise,
44 the server assumes that we mean the default table and cannot find the
46 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
47 setData(): Pass the tableName to the RelatedListTable constructor.
49 2012-05-07 Murray Cumming <murrayc@murrayc.com>
53 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
54 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
55 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
57 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
59 * src/main/java/org/glom/web/server/database/DBAccess.java:
60 convertResultSetToDTO(), getPortal():
61 * src/main/java/org/glom/web/server/database/ListDBAccess.java
63 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
64 Add checks for null objects and out of range access, with log messages to
65 give hints so we can fix these properly.
67 2012-05-07 Murray Cumming <murrayc@murrayc.com>
69 Portals: some corrections.
71 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
73 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
74 constructor: Use getRelationshipNameUsed() instead of getName(), because
75 that is what is meant.
76 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
77 getFromField(): Fix a typo, to get the field name, not the table name.
78 * src/main/java/org/glom/web/server/database/DBAccess.java:
79 getPortal(): Fix a typo that stopped this from working.
81 2012-05-07 Murray Cumming <murrayc@murrayc.com>
83 LayoutItemPortal: Also override getTitleOriginal().
85 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
86 This lets the base getTitle() with no parameters work.
87 TODO: Test this properly.
89 2012-05-06 Murray Cumming <murrayc@murrayc.com>
91 LayoutItemPortal: getTitle*(): Use the relationship title.
93 2012-05-06 Murray Cumming <murrayc@murrayc.com>
95 LayoutItemField: Fix loading of custom titles.
97 * src/main/java/org/glom/web/server/libglom/Document.java
98 loadDataLayoutItemField(): The title, if any, instead of the field
99 title, is stored in a title_custom node. Load it from there.
100 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
102 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
103 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
104 getTitle*() overrides.
105 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
108 2012-05-06 Murray Cumming <murrayc@murrayc.com>
110 LayoutItemField: Fall back to field titles, so some are really shown.
112 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
113 Override getTitleOriginal() and getTitle(), as in java-libglom.
114 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
117 2012-05-06 Murray Cumming <murrayc@murrayc.com>
119 Correct use of setExpectedResultSize().
121 * src/main/java/org/glom/web/server/ConfiguredDocument.java
122 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
123 Use setExpectedResultSize only on top-level groups (for instance, the
124 list layout) or on child portals (in details views).
125 Use the correct table name for portals to avoid SQL errors.
126 Update the expected counts when returning cached layouts.
128 2012-05-06 Murray Cumming <murrayc@murrayc.com>
130 Document: Interpret no group column count as 1.
132 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
133 default, though we now check for this in the UI code anyway.
135 2012-05-06 Murray Cumming <murrayc@murrayc.com>
139 2012-05-06 Murray Cumming <murrayc@murrayc.com>
141 Translatable: Use Hashmap instead of Treemap because GWT supports it.
143 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
144 The use of Treemap lead to this error from async methods, with no
146 "The response could not be deserialized"
148 2012-05-06 Murray Cumming <murrayc@murrayc.com>
150 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
152 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
153 when using the Google -> GWT Compile, or
154 g toolbar button -> GWT Compile Project... feature in Eclipse.
156 2012-05-06 Murray Cumming <murrayc@murrayc.com>
158 ListTable.addColumn(): Protect against a null Formatting.
160 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
161 Create a default Formatting if it is null, because that is the simplest
164 2012-05-06 Murray Cumming <murrayc@murrayc.com>
166 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
168 * src/main/java/org/glom/web/server/ConfiguredDocument.java
169 updateLayoutGroup(): Check that the field is not null.
171 2012-05-06 Murray Cumming <murrayc@murrayc.com>
173 ListViewImpl: Protected against a bad cast error.
175 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
176 onEnterKeyDown(): Do not cast without an instanceof check.
178 2012-05-06 Murray Cumming <murrayc@murrayc.com>
180 ListTable: Protect against an out of range error.
182 * src/main/java/org/glom/web/client/ui/list/ListTable.java
183 createCellTable(): This is unlikely, but can happen while debugging.
185 2012-05-06 Murray Cumming <murrayc@murrayc.com>
187 AsyncMessage onFailure() callbacks: Log the exception message.
189 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
190 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
191 * src/main/java/org/glom/web/client/activity/ListActivity.java:
192 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
193 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
194 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
195 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
196 These are useful clues when something is wrong.
198 2012-05-06 Murray Cumming <murrayc@murrayc.com>
200 ConfiguredDocument: Avoid a null dereference.
202 * src/main/java/org/glom/web/server/ConfiguredDocument.java
203 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
204 details maps are created.
206 2012-05-06 Murray Cumming <murrayc@murrayc.com>
208 Document: Correct the port number parsing.
210 * src/main/java/org/glom/web/server/libglom/Document.java:
211 This lets us actually connect to the database and show the document.
213 2012-05-05 Murray Cumming <murrayc@murrayc.com>
217 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
218 user-interaction, asking us to load a temporary URL in a browser.s
219 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
220 which is apparently necessary for testing the service. See the comment.
221 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
222 Show the exception, if any. This is how I saw the 404 in the HTML in
225 2012-05-05 Murray Cumming <murrayc@murrayc.com>
227 DocumentTest: Move the .glom files into the resources directory.
229 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
230 URI via getResource().
232 2012-05-05 Murray Cumming <murrayc@murrayc.com>
234 Document: Remove the FieldIdentifies inner class.
236 * src/main/java/org/glom/web/server/libglom/Document.java: We only
237 use the Relationship (though the same function in libglom is maybe
238 used in other ways) and so this removes a compiler warning.
240 2012-05-05 Murray Cumming <murrayc@murrayc.com>
242 Document.load() Remove the error code parameter.
244 * src/main/java/org/glom/web/server/libglom/Document.java: load():
245 Remove the parameter. We do not set it yet and it could never have
246 worked as an output parameter (though maybe it did in java-libglom).
247 We could use an exception if we really want the failure reason.
248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
250 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
251 setUp(), testGetSuitableTableToViewDetails(): Adapt.
253 2012-05-05 Murray Cumming <murrayc@murrayc.com>
255 Make some inner classes static.
257 * src/main/java/org/glom/web/server/ConfiguredDocument.java
258 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
259 * src/main/java/org/glom/web/server/ReportGenerator.java
260 * src/main/java/org/glom/web/server/libglom/Document.java
261 Make all inner classes static that can be static.
263 2012-05-05 Murray Cumming <murrayc@murrayc.com>
265 OnlineGlomServiceImpl: Do not load and check for java-libglom.
267 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
268 init(): We do not use java-libglom any more.
270 2012-05-05 Murray Cumming <murrayc@murrayc.com>
272 Remove mentions of java-libglom.
274 * README: Remove mention of java-libglom, because it no longer needed.
275 * utils/build-onlineglom-war.sh:
276 * utils/check-and-recover-tomcat.py:
277 * utils/install-onlineglom-war.sh: Remove these as they are no longer
278 useful. Building is now far easier, with no need for jhbuild.
280 2012-05-05 Murray Cumming <murrayc@murrayc.com>
282 Fix the build (mvn package)
284 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
285 (LayoutGroup): Make the LayoutItemList inner class static and protected.
286 Otherwise the GWT Java->Javascript compilation fails with just this
287 error, during mvn package or when attempting to view in a browser,
288 in the GWT developer mode in Eclipse.
290 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
291 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
292 [INFO] Compiling module org.glom.web.OnlineGlom
293 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
294 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
295 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
296 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
297 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
298 [INFO] [ERROR] Cannot proceed due to previous errors
300 It has taken me 2 days to find out what was causing that. After reducing
301 the code, the compiler eventually showed me the full error message.
303 2012-05-04 Murray Cumming <murrayc@murrayc.com>
305 ConfiguredDocument: Cache the cloned and stripped layouts.
307 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
308 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
309 layout in a map, so we can retrieve it again without rebuilding it.
311 2012-05-04 Murray Cumming <murrayc@murrayc.com>
313 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
315 2012-05-04 Murray Cumming <murrayc@murrayc.com>
317 libglom classes: Implement some auto-generated emthods.
319 2012-05-04 Murray Cumming <murrayc@murrayc.com>
321 Add GwtTestOnlineGlomService.
323 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
324 However, this (and the other GwtTest*) does not seem to run during
327 2012-05-04 Murray Cumming <murrayc@murrayc.com>
329 Remove use of unsupported features from client code.
331 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
332 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
333 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
334 Use our client version of StringUtils instead of the apache commons one.
336 However, the GWT Javascript compliation still fails.
338 2012-04-25 Murray Cumming <murrayc@murrayc.com>
340 Add a Field class and implement some loading of it in Document.
342 2012-04-25 Murray Cumming <murrayc@murrayc.com>
344 Initial Document loading implementation, instead of libglom.
346 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
347 and Translatable classes, and adapt the rest of the code to use them.
348 However, this is still missing Layout and Field classes and loading.
350 2012-04-24 Murray Cumming <murrayc@murrayc.com>
352 Use of jOOQ: Move Field creation into a utility method.
354 * src/main/java/org/glom/web/server/SqlUtils.java:
355 This lets us improve it more easily.
357 2012-04-24 Murray Cumming <murrayc@murrayc.com>
359 Use of jOOQ: Improve the code to COUNT a sub-select.
361 * src/main/java/org/glom/web/server/SqlUtils.java:
362 Move initial query creation into
363 build_sql_select_step_with_where_clause().
364 build_sql_select_count_rows(): Use the jOOQ API instead of
365 concatentating text, because a jOOQ Select*Step is a TableLike,
366 which is what from() takes.
368 2012-04-23 Murray Cumming <murrayc@murrayc.com>
370 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
372 * pom.xml: Depend on jooq.
373 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
374 methods with jOOQ, based on the C++ implementations in libglom,
375 with some changes to the logic required by jooQ.
376 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
378 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
379 * src/main/java/org/glom/web/server/ReportGenerator.java:
380 * src/main/java/org/glom/web/server/SqlUtils.java:
381 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
382 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
383 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
385 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
386 Adapt. In particular, the SqlUtils methods now need to take a Connection,
387 because jOOQ needs that, though it seems unnecessary.
389 This is not quite finished. Ideally jOOQ would help us to build
390 table_name.field_name names, quoting and escaping them properly.
391 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
393 2012-04-21 Murray Cumming <murrayc@murrayc.com>
395 Move use of Glom.build_sql*() into a new SqlUtils class.
397 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
398 to wrap Glom.build_sql*(). The parameter types are still Glom one,
399 but this will make it easier to start using something other than
400 libglom or SqlBuilder.
402 2012-04-21 Murray Cumming <murrayc@murrayc.com>
404 Update the project URL.
406 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
408 2012-04-21 Murray Cumming <murrayc@murrayc.com>
410 Main layout: Use a FlowTable instead of absolute positioning.
412 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
413 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
414 child panels/widgets must have an absolute position. But that is annoying, so
415 this adds a FlowTable and puts the child panels in there.
417 2012-04-21 Murray Cumming <murrayc@murrayc.com>
419 GwtTestOnlineGlom: Comment out unused code.
421 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
422 Eclipse has started to say that some code is unused.
424 2012-04-21 Murray Cumming <murrayc@murrayc.com>
426 Update to the latest versions of dependencies.
428 * pom.xml: Update version numbers of dependencies to the latest
430 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
432 * src/main/java/org/glom/web/server/ReportGenerator.java:
433 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
434 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
435 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
437 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
438 Modify the imports where necessary.
440 2012-04-17 Murray Cumming <murrayc@murrayc.com>
442 Style: Remove overflow:hidden from searchbox
444 * src/main/webapp/style.css: Because this pushes the Back To Link
445 label/link on to the next row, which is then hidden due to the
446 hard-coded (in ems) height.
448 2012-04-20 Murray Cumming <murrayc@murrayc.com>
450 Remove some duplicate code.
452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
453 getDocumentInfo(): This must have been duplicated during the merge from the
458 2012-04-19 Murray Cumming <murrayc@murrayc.com>
460 Reports: Localize the waiting for report message.
462 * src/main/java/org/glom/web/client/activity/ReportActivity.java
463 start(): Get the message from the contants.
464 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
466 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
467 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
468 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
469 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
470 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
471 Update these files with the English text for newer strings for now.
473 2012-04-19 Murray Cumming <murrayc@murrayc.com>
475 Reports: Show a message while waiting for the report.
477 * src/main/java/org/glom/web/client/ui/ReportView.java
478 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
479 Add setWaitingText(), to show a message saying that we are
480 waiting for the report to be ready.
481 * src/main/java/org/glom/web/client/activity/ReportActivity.java
482 start(): Call setWaitingText() before calling the async
485 2012-04-19 Murray Cumming <murrayc@murrayc.com>
487 ReportGenerator: Specify date and time formats.
489 * src/main/java/org/glom/web/server/ReportGenerator.java:
490 createFieldValueElement(): Use the default (and localized)
491 short formats, though we still need a way to show 4-digit
492 years without providing the format for every locale.
493 * src/main/java/org/glom/web/server/database/DBAccess.java:
494 convertResultSetToDTO(): Use the short formats here too.
496 2012-04-18 Murray Cumming <murrayc@murrayc.com>
498 ReportGenerator: Use the correct numeric formatting.
500 * src/main/java/org/glom/web/server/ReportGenerator.java
501 createFieldExpression(), createFieldValueElement(): Take the
502 whole LayoutItem_Field instead of just the field name, so
503 we have access to the formatting.
504 createFieldValueElement(): Use JRTextField.setPattern() to
505 specify the numeric formatting, with the help of a
506 regular DecimalFormat.
508 2012-04-18 Murray Cumming <murrayc@murrayc.com>
510 ReportGenerator: Avoid showing null for group by titles.
512 * src/main/java/org/glom/web/server/ReportGenerator.java
513 generateReport(): Use setBlankWhenNull() on the field title
514 style too, because this is used for values in group by
517 2012-04-18 Murray Cumming <murrayc@murrayc.com>
519 ReportGenerator: Add a colon to titles in vertical groups.
521 * src/main/java/org/glom/web/server/ReportGenerator.java
522 addFieldToDetailBandVertical(): Pass true for the withColon
525 2012-04-18 Murray Cumming <murrayc@murrayc.com>
527 ReportGenerator: Simplify the code by using Position more.
529 2012-04-18 Murray Cumming <murrayc@murrayc.com>
531 Reports: Support vertical groups, roughly.
533 * src/main/java/org/glom/web/server/ReportGenerator.java:
534 addToReport(): Rename to addGroupToReport() and, if necessary,
535 call the new addVerticalGroupToReport() method.
536 createFieldValueElement(): Let the caller specify the Y position
539 2012-04-17 Murray Cumming <murrayc@murrayc.com>
541 Reports: Allow a second report to be shown.
543 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
544 clear(): Do not remove the HTML widget, which broke the whole layout.
546 2012-04-17 Murray Cumming <murrayc@murrayc.com>
548 Locales drop-down: Show that we use English by default.
550 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
551 fillView(): When we use English, just because that is the default, when
552 no locale is specified, show that in the Locales drop-down instead of
553 just showing the first item.
555 2012-04-17 Murray Cumming <murrayc@murrayc.com>
557 Unselect the Report/Locale/Table combo item when appropriate.
559 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
560 setPlace(): clear reportName if this is not a ReportPlace.
561 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
562 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
563 When the provided name is empty, unselect all items, so that none are
564 indicated. This uses a for loop because I cannot find a single method
567 2012-04-17 Murray Cumming <murrayc@murrayc.com>
569 Report: Give the user a way to get back to the list.
571 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
572 start(), setPlace(): Show the Back To List link on reports, and also
573 interpret selecting the empty report item as back to list.
575 2012-04-13 Murray Cumming <murrayc@murrayc.com>
577 Really show the selected Report name.
579 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
580 setPlace(): Store the reportName here, if it is that kind of Place.
581 fillView(): Set the selected Report after filling the list of reports.
582 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
583 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
584 null Strings, though we need some way to unselect all ListBox items
587 2012-04-13 Murray Cumming <murrayc@murrayc.com>
589 ReportGenerator: Try to avoid some problems.
591 * src/main/java/org/glom/web/server/ReportGenerator.java
592 addField(): Try to avoid duplicates, and avoid using a null
595 2012-04-13 Murray Cumming <murrayc@murrayc.com>
597 Reports: Use quickFind.
599 * src/main/java/org/glom/web/client/OnlineGlomService.java;
600 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
602 getReportHTML(): Add a quickFind parameter.
603 * src/main/java/org/glom/web/client/activity/ReportActivity.java
604 start(): Pass the quickFind parameter.
605 * src/main/java/org/glom/web/server/ReportGenerator.java
606 generateReport(): Take a quickFind parameter.
608 2012-04-13 Murray Cumming <murrayc@murrayc.com>
610 ReportPlace: Actually use the report name.
612 * src/main/java/org/glom/web/client/place/ReportPlace.java
613 getPlace(): Do not assign the report name to the quickfind.
615 2012-04-13 Murray Cumming <murrayc@murrayc.com>
617 Show java.library.path when complaining.
619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
620 init(): When telling us to check java.library.path, show the
623 2012-03-06 Murray Cumming <murrayc@murrayc.com>
625 ReportGenerator: Do not show nulls.
627 2012-03-06 Murray Cumming <murrayc@murrayc.com>
629 ReportGenerator: Make the title font larger.
631 2012-03-06 Murray Cumming <murrayc@murrayc.com>
633 ReportGenerator: Put field titles inside groups, if there are groups.
635 2012-03-06 Murray Cumming <murrayc@murrayc.com>
637 ReportGenerator: Take the Report itself instead of the name and group.
639 * src/main/java/org/glom/web/server/ConfiguredDocument.java
640 Remove getReportLayoutGroup().
641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
642 getReportHTML(): Pass the report instead
643 of its name and layout group.
644 * src/main/java/org/glom/web/server/ReportGenerator.java
645 generateReport(): Use the report object to use the title
648 2012-03-06 Murray Cumming <murrayc@murrayc.com>
650 ReportGenerator: Remove designBand parameters.
652 * src/main/java/org/glom/web/server/ReportGenerator.java:
653 Make designBand a class member instead of passing it to all
656 2012-03-06 Murray Cumming <murrayc@murrayc.com>
658 ReportGenerator: Add lines, a bit like in the desktop version.
660 * src/main/java/org/glom/web/server/ReportGenerator.java
661 addToReport(): Use JRDesignLine.
663 2012-03-06 Murray Cumming <murrayc@murrayc.com>
665 ReportGenerator: Correct the title positions and use some bold style.
667 * src/main/java/org/glom/web/server/ReportGenerator.java:
668 Break the code up into reusable functions, correct the placement of
669 titles, and use normal/bold styles as in the reports in the desktop
672 2012-03-06 Murray Cumming <murrayc@murrayc.com>
674 ReportGenerator: Add a header band to show the field titles.
676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
677 getReportHTML(): Pass the localeId to the ReportGenerator
679 * src/main/java/org/glom/web/server/ReportGenerator.java
680 constructor: Take the localeID so we can get translated field
682 generateReport(), addToReport(), addFieldToBand(): Add field
683 titles in a column header band.
685 2012-03-05 Murray Cumming <murrayc@murrayc.com>
687 Reports drop-down list: Some improvement.
689 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
690 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
691 Adedd setSelectedReport(),
692 setReportList(): Add a blank line so that the user can select the
694 * src/main/java/org/glom/web/client/activity/ReportActivity.java
695 start(): Show the current report by calling setSelectedReport().
696 This does not seem to work yet.
698 2012-03-05 Murray Cumming <murrayc@murrayc.com>
700 DetailsActivity, ListActivity: Move some variables into a base class.
702 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
703 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
704 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
705 the clientFactory, documentID, tableName and authenticationPopup into
706 a base class, to avoid duplication.
708 2012-03-05 Murray Cumming <murrayc@murrayc.com>
710 Translate the Reports label.
712 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
713 Get the "Reports" label string from the constants.
714 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
715 perties: Add Reports to the constants.
717 2012-03-05 Murray Cumming <murrayc@murrayc.com>
719 Reports: Implement grouping.
721 * src/main/java/org/glom/web/server/ReportGenerator.java:
722 Handle LayoutItem_GroupBy items and try to do the right thing
723 with JRDesignGroup. It seems to work.
725 2012-03-04 Murray Cumming <murrayc@murrayc.com>
727 Actually show some data with JasperReports.
729 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
730 getReportHTML(): Move most code into a ReportGenerator class.
731 * src/main/java/org/glom/web/server/ReportGenerator.java:
732 Recurse into sub-groups, adding fields to the JasperDesign's details
733 band. Note that we must set an arbitrary width and height, or it just
734 will not show any data.
736 2012-03-04 Murray Cumming <murrayc@murrayc.com>
738 Reports Chooser: Show the titles, not the names.
740 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
741 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
742 and the names as the values.
743 * src/main/java/org/glom/web/server/ConfiguredDocument.java
744 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
745 group now that we provide the report name, so it should always
748 2012-02-15 Murray Cumming <murrayc@murrayc.com>
750 Depend on jasperreports.
752 * pom.xml: Add the dependency. My plan is to use this on the
755 2012-01-31 Murray Cumming <murrayc@murrayc.com>
757 Implement navigation to report places.
759 * src/main/java/org/glom/web/client/activity/ReportActivity.java
760 start(): Do not bother to handle all events here.
761 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
762 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
763 Added getSelectedReport().
764 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
765 .java: start(): When handling a change to the reports chooser,
766 call getSelectedReport() and goTo() its ReportPlace.
767 * src/main/java/org/glom/web/client/ui/ReportView.java
768 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
769 Added setReportHTML() which puts the html in a gwt HTML widget.
770 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
771 getReportHTML(): Return "TODO" just to show that this works.
773 2012-01-31 Murray Cumming <murrayc@murrayc.com>
775 Make ReportPlace usable.
777 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
779 * src/main/java/org/glom/web/client/place/ReportPlace.java:
780 Correct the @prefix annotation.
782 2012-01-31 Murray Cumming <murrayc@murrayc.com>
784 OnlineGlomService: Return report HTML rather than the LayoutGroup.
786 * src/main/java/org/glom/web/client/OnlineGlomService.java:
787 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
788 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
789 Change getReportLayout() to getReportHMTL() because we will not need to
790 parse or render the report layout on the client side.
791 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
792 getReportLayout(): Return the libglom LayoutGroup type because we will
793 not need to convert to a shared type, because this will not be used on
795 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
798 Note that there is still no implementation for this.
801 2012-01-27 Murray Cumming <murrayc@murrayc.com>
803 Add a (empty) Report Place, View, and Activity.
805 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
807 * src/main/java/org/glom/web/client/place/HasTablePlace.java
808 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
809 this into a superclass:
810 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
811 and also use it as the base of this new ReportPlace:
812 * src/main/java/org/glom/web/client/place/ReportPlace.java
814 * src/main/java/org/glom/web/client/ui/ReportView.java
815 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
816 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
817 Add these, containing mostly boiler-plate for now.
819 * src/main/java/org/glom/web/client/OnlineGlomService.java
820 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
821 * src/main/java/org/glom/web/server/ConfiguredDocument.java
822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
823 Add API to get the LayoutGroup for the report.
825 2012-01-23 Murray Cumming <murrayc@murrayc.com>
827 Add and fill a Reports drop-down list box.
829 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
831 * src/main/java/org/glom/web/client/OnlineGlomService.java:
832 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
834 Added getReports(document, table, localeID), calling
835 ConfiguredDocument.getReports().
836 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
837 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
838 Added setReportsList() and a list widget.
839 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
840 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
845 2012-04-12 Murray Cumming <murrayc@murrayc.com>
847 Translations: Add Esperanto.
849 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
850 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
851 properties: Add this translation because someone took the time to make it.
853 2012-03-15 Murray Cumming <murrayc@murrayc.com>
855 Adapt to the java-libglom 1.21.7 API.
857 * src/main/java/org/glom/web/server/ReportGenerator.java:
858 addToReport(): get_group_secondary_fields() is now
859 get_secondary_fields().
862 2012-03-15 Murray Cumming <murrayc@murrayc.com>
864 Use the latest java-libglom version.
866 * pom.xml: Use java-libglom 1.21.7.
868 2012-03-03 Ben Konrath <ben@bagu.org>
870 Display date and time in details view.
872 https://bugzilla.gnome.org/show_bug.cgi?id=671257
874 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
876 2012-03-05 Murray Cumming <murrayc@murrayc.com>
878 Require the latest java-libglom.
880 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
882 2012-03-04 Murray Cumming <murrayc@murrayc.com>
884 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
886 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
887 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
888 an empty quickfind string. I also corrected libglom to create only
889 empty where clauses for empty quickfind strings, but this avoids the
892 2012-02-24 Ben Konrath <ben@bagu.org>
894 Improve the tabs in the Notebook widget.
898 2012-01-30 Murray Cumming <murrayc@murrayc.com>
900 Translations: Try to translate the strings.
902 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
903 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
904 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
905 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
906 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
907 Take the Open translation from GTK+'s .po files.
908 Take the Details translation from Glom's po files.
909 I have added the other strings to Glom so we can get translations that way:
910 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
912 2012-01-27 Murray Cumming <murrayc@murrayc.com>
914 TableSelectionViewImpl: Put the search label and entry in a div.
916 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
917 Put the search widgets in a FlowTable so that the CSS can be used to
918 style them while keeping them together.
919 * src/main/webapp/style.css: Mention the new div.
921 2012-01-27 Murray Cumming <murrayc@murrayc.com>
923 Translate more strings in more locales.
925 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
926 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
927 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
928 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
929 Translate the "Details" and "Open" string too.
931 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
932 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
933 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
934 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
935 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
936 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
937 Add these new locales as placeholders though they currently contain English.
939 2012-01-27 Murray Cumming <murrayc@murrayc.com>
941 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
944 Check the ConfiguredDocument* for null before using it.
946 2012-01-26 Murray Cumming <murrayc@murrayc.com>
948 Tell Eclipse about the generated java files.
950 * .classpath: This lets it find OnlineGlomConstants.java.
951 It would be nice if Eclipse just used the maven build files.
953 2012-01-26 Murray Cumming <murrayc@murrayc.com>
955 Prevent a crash when no locale is specified in the URL.
957 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
958 Avoid returning a null string, obtained from
959 Window.Location.getParameter(). This caused a crash when it was
960 later passed to libglom's API.
961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
962 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
963 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
964 guard against future null strings.
966 2012-01-26 Murray Cumming <murrayc@murrayc.com>
968 Use the ?locale= query param instead of the &lang= token param.
970 * src/main/java/org/glom/web/client/place/ListPlace.java
971 * src/main/java/org/glom/web/client/place/DetailsPlace.java
972 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
973 Remove the lang token key and value.
975 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
976 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
977 When the user selects a different locale from the chooser, use
978 Window.Location.assign() to change the URL, which then causes a reload.
980 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
981 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
982 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
983 * src/main/java/org/glom/web/client/activity/ListActivity.java
984 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
985 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
986 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
987 * src/main/java/org/glom/web/client/ui/ListView.java:
988 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
990 Remove localeID member variables and method/constructor parameters, instead
991 using Utils.getCurrentLocaleID() when we need a localID to pass to
994 2012-01-26 Murray Cumming <murrayc@murrayc.com>
996 Internationalize the UI strings.
998 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
999 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1000 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1001 because it is unused. Messages are apparently strings that can have
1002 parameters, but we do not need that yet, so Contants will be enough for now.
1003 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1004 to say that we support the en and de locales.
1005 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1006 The original English strings.
1007 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1008 Some German translations of the English strings.
1009 The i18n goal then uses the .properties file to generate an
1010 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1011 returns an implementation that returns the translated strings.
1012 The documentation suggests putting these in src/java/*/client/, but it seems
1013 best to put it in src/resources/*/client/.
1014 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1015 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1016 instead of hard-coding them.
1017 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1018 but that does not seem to stop the build, though it confuses Eclipse.
1020 You can see the translated string by adding ?locale=de to the URL, like so:
1021 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1023 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1025 Improve null/empty String checks.
1027 * pom.xml: Add a dependency on commons-lang, to use
1028 org.apache.commons.lang.StringUtils.
1029 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1031 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1032 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1033 Use StringUtils.isEmpty().
1035 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1036 StringUtils class with a static isEmpty() function because we
1037 cannot use org.apache.commons.lang.StringUtils in client-side
1038 GWT code because it (apparently) cannot be compiled to javascript.
1039 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1040 * src/main/java/org/glom/web/client/activity/ListActivity.java
1041 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1042 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1043 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1044 * src/main/java/org/glom/web/client/place/ListPlace.java
1045 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1046 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1047 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1048 * src/main/java/org/glom/web/client/ui/details/Group.java
1049 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1050 our StringUtils.isEmpty() function.
1052 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1054 Update to the latest java-libglom API.
1056 * pom.xml: Require java-libglom 1.21.4.
1057 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1058 getDocumentInfo(), getListViewLayoutGroup():
1059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1061 * src/main/java/org/glom/web/server/database/DBAccess.java
1062 getFieldsToShowForSQLQueryAddGroup(),
1063 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1064 with either get_database_title_original() or
1065 get_database_title(localeID).
1067 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1069 ConfiguredDocument: Avoid a null pointer exception.
1071 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1072 Initialize localeID to "" to avoid returning a null String which
1073 causes a crash in java-libglom's swing-generated code.
1075 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1077 Some simple renaming.
1079 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1080 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1081 for localeChooser. This seems more appropriate and is less ambiguous
1082 particularly in the .css file.
1084 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1086 ConfiguredDocument: Rename the localedID private member variable.
1088 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1090 Adapt to the latest java-libglom API from git master.
1092 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1093 libglom now uses only Vector instead of List, which uses add() instead of
1096 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1098 ConfiguredDocument: Rename the localedID private member variable.
1100 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1102 Build a source tarball with mvn assembly:single
1104 * assembly.xml: Add this file.
1105 * pom.xml: Use the maven-assembly-plugin and tell it to use
1106 our assembly.xml file.
1108 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1110 OnlineGlomServiceImpl: Get .glom files recursively.
1112 * pom.xml: Depend on commons-io from org.apache.commons.
1113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1114 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1115 files recursively, and with the easier filter for the extension.
1116 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1117 simplify that code too.
1119 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1121 README: Mention that you must install java-libglom packages separately.
1123 But then it works, because java-libglom is now in the central maven
1126 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1128 locales drop-down: Show the correct selected locale when the URL changes.
1130 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1131 .java: setPlace(): Move some code into fillView().
1133 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1135 locales drop-down: Do not lose the primary key.
1137 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1138 start(): onLocaleChange(): Pass the current primary key value,
1139 instead of an empty value.
1141 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1143 locales drop-down: Do not lose the drop-down selection.
1145 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1146 .java (TableSelectionActivity.fillView): Set the selected locale
1147 after changing the drop-down items (though we do not really need
1148 to change them just because the locale changes.)
1150 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1152 locales drop-down: Change the tables list when this changes.
1154 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1155 .java: TableSelectionActivity.start(): Move the async table titles
1156 retrieval into a private fillView() method and also call this when
1157 the chosen locale changes.
1158 Note that the document title is not actually translatable yet, but
1159 that is a problem that I should fix soon in libglom.
1161 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1163 Improve the placement of the locales drop-down.
1165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1166 Put the title and locales drop-down in a div (gwt.FlowTable).
1167 * src/main/webapp/style.css: Add magic css properties to make this work.
1168 Also remove the left margin from the title so that it lines up with the
1171 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1173 locales selector: Show human-readable locale titles.
1175 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1176 getDocumentInfo(): Use java.util.Locale to show a real title of
1177 each locale, in the locale's own language.
1179 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1181 Add a language/locale selector drop-down.
1183 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1184 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1185 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1186 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1187 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1188 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1189 Add a ListBox to show the available locales. Add getLocaleSelector(),
1190 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1191 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1192 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1193 java: Add these classes.
1194 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1195 start(): Fill the locales ListBox. Handle its change event, firing a
1197 setPlace(): Show the selected locale as specified by the URL token.
1198 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1199 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1200 Handle LocaleChangeEvent, going to a new *Place with that locale.
1202 The placement of the ListBox is not pretty, and it currently uses the ID
1203 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1207 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1209 Search box: Show the search text from the URL token.
1211 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1212 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1213 Add setQuickFindText().
1214 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1215 .java: setPlace(): Store the queryText if the place is a ListPlace,
1216 and call TableSelectionView.setQuickFindText().
1218 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1220 Allow use of translations via, for instance, &lang=de in the URL.
1222 * pom.xml: Use the unstable java-libglom 1.21 version.
1224 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1225 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1227 init(): Instead of calling TranslatableItem.set_current_locale()
1228 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1229 However, this is only for default locales, which are not needed to
1230 change the locale in the URL.
1231 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1232 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1233 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1234 layout for a particular locale.
1235 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1236 Add get/setDefaultLocaleID().
1237 getDocumentInfo(), getListViewData(), getRelatedListData(),
1238 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1239 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1240 localeID parameter, so we can get the layout for a particular locale.
1242 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1243 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1244 * src/main/java/org/glom/web/client/place/ListPlace.java:
1245 Parse and construct a lang parameter too.
1247 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1248 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1249 passed to subsequent methods and constructors.
1250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1251 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1252 Store the localeID from the *Place and pass it to other constructors
1253 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1255 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1256 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1257 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1258 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1259 * src/main/java/org/glom/web/client/ui/ListView.java:
1260 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1261 Take localeID parameters and pass them to subsequent constructors and
1262 methods, so that the layout is always retrieved for that locale.
1264 This is rather repetitive.
1266 Note that "" means the original (default) locale of the Glom document,
1267 which is usually English.
1269 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1271 Documents: Remove final keyword to fix startup configuration.
1273 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1274 final keywords on the private member variables because that breaks
1275 the startup, apparently (there are warnings) because it stops them
1276 from being serialized. I added these in the previous commit.
1278 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1280 Documents: Add some final keywords.
1282 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1285 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1287 OnlineGlomServiceImpl: Add to overview comments.
1289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1290 Note that this is where all the document are loaded. They are not
1291 loaded freshly for each page.
1293 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1297 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1298 Add a TextBox for the text of a quick find.
1299 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1301 setBackLink(): Add a String quickFind parameter.
1302 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1303 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1304 to the base interface, because that is how TableSelectionViewImpl is used.
1305 * src/main/webapp/style.css: Add style for the search box and its label.
1307 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1308 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1309 Add these files, based on the existing TableChangeEvent and
1310 TableChangeEventHandlers.
1311 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1312 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1313 a ListPlace() that the user should be taken to.
1314 * src/main/java/org/glom/web/client/activity/ListActivity.java
1315 start(): Handle it here too and adapt the TableChangeEvent handler to
1316 pass the extra "" quickFind parameter to ListPlace.
1317 * src/main/java/org/glom/web/client/place/ListPlace.java:
1318 Constructor: Take an extra String quickFind parameter and store it,
1319 returning it from a new getQuickFind() method.
1320 getToken(): Put the quickFind text in the URL token.
1321 getPlace(): Parse the quickFind text from the URL token.
1322 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1323 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1324 ListPlace constructor.
1325 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1326 .java: start(): Add a Change handler for the TableSelectionView's
1327 TextBox (via its base HasChangeHandlers interface), firing the new
1328 QuickFindChangeEvent.
1329 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1330 pass the extra "" quickFind parameter.
1332 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1333 setCellTable(): Add a String quickFind parameter and pass it to
1334 the ListViewTable() constructor.
1335 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1336 setCellTable() in the base interface, because that is how ListViewImpl
1339 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1340 Add a String quickFind member variable.
1341 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1342 Constructor: Add a String quickFind parameter, storing it in the
1343 base ListTable's member variable.
1344 onRangeChanged(): Pass quickFind to the
1345 OnlineGlomServiceAsync.getSortedListViewData() and
1346 OnlineGlomServiceAsync.getListViewData() methods.
1348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1349 getListViewData(), getSortedListViewData(): Add a String quickFind
1350 parameter, passing it to ConfiguredDocument.getListViewData().
1351 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1352 Change getListViewData(), getSortedListViewData() in the base interface,
1353 because that is how OnlineGlomServiceImpl is used, via this:
1354 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1355 Change getListViewData(), getSortedListViewData() here too.
1356 This class can apparently be used to asynchronously call methods on
1357 OnlineGlomService, and GWT seems to implement that after recognizing
1358 just the *Async name convention and the extra AsyncCallback parameters.
1360 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1361 getListViewData(): Add a String quickFind parameter, and pass it to
1362 ListViewDBAccess.getData().
1363 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1364 getListData(): Add a String quickFind parameter and pass it to
1366 getSelectQuery(): Add a String quickFind parameter.
1367 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1368 getSelectQuery(): Add a String quickFind parameter and use it with
1369 Glom.get_find_where_clause_quick() to pass a where_clause to
1370 Glom.build_sql_select_with_where_clause(), to actually filter the
1372 getData(): Add a String quickFind parameter, passing it to getListData().
1373 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1374 va: getData(): Pass an empty string to getListData() for the
1375 quickFind parameter.
1377 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1379 ListTable: Minor change.
1381 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1382 createCellTable(): Make this protected instead of public.
1384 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1386 Many files: Use final for the parameters and use the @override attribute.
1388 2012-01-22 Ben Konrath <ben@bagu.org>
1390 Add anchor links for single line text that starts with http, ftp and www.
1394 2012-01-22 Ben Konrath <ben@bagu.org>
1396 Add ellipsis to single line text in details view.
1400 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1402 Remove all javadoc author tags.
1404 Because they are awkward and meaningless when many people touch
1406 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1408 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1410 Revert the COPYING.LESSER to COPYING rename.
1412 Apparently both should be there if it is LGPL.
1414 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1416 *View: Remove unused imports.
1418 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1419 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1420 * src/main/java/org/glom/web/client/ui/ListView.java:
1421 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1422 Remove unused imports, as suggested by Eclipse.
1424 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1426 Move the *View::Presenter types, and some API into one base View.
1428 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1429 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1430 * src/main/java/org/glom/web/client/ui/ListView.java:
1431 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1432 Presenter, setPresenter() and clear() into a shared base interface,
1433 to avoid the unnecessary duplicate Presenter types and to more clearly
1434 show how the *Views share the same structure, even if they are not
1435 used polymorphically.
1437 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1438 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1440 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1441 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1442 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1444 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1447 Feel free to revert this if there is a good reason for the duplicate
1450 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1452 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1454 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1455 a class member instead of a local variable in the method.
1456 This lets us use it to get the view instances, for use in tests.
1457 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1458 beforeOnlineGlom(): Test some more details of the initial view.
1459 Again, this is not very useful.
1461 To really test gwt-glom we will need to start a local postgresql
1462 instance with local data, like the Glom tests in C++.
1464 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1466 pom.xml: Mention the LGPL license.
1468 * pom.xml: Add a licenses section.
1469 * COPYING.LESSER: Move this to COPYING, which
1470 previously contained the GPL. But gwt-glom is all LGPL.
1472 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1474 Add project information to README and pom.xml.
1476 * README: Add a brief description and mention some mvn
1478 * pom.xml: This extra information shows up in mvn site
1481 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1483 Use the latest java-libglom version.
1485 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1487 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1489 GwtTestOnlineGlom: Test a little more.
1491 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1492 protected rather than private, as suggested by the gwt-test-utils
1494 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1495 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1496 Test the initial visibility of the panels.
1498 However, this is not a very useful test.
1499 And I wonder how we should generally test using this idea for an
1500 activity/places app like ours where the real changes happen implicitly
1501 based on the history token/URL.
1503 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1505 Slight modification to *Mapper comments.
1507 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1508 (DataActivityMapper)
1509 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1511 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1513 Remove comments mentioning GIN because they are just copied from
1514 the example code and are apparently not helpful:
1515 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1516 Also change the mention of a class that is only in the example code.
1518 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1520 GwtTestOnlineGlom test: Minor changes.
1522 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1523 Avoid the long qualified class name and modify the comment
1524 because it is now obvious to me that the mocked class is the only
1525 custom one created via GWT.create().
1527 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1529 Tests: Added the beginnings of a test using gwt-test-utils.
1531 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1532 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1533 which tells gwt-test-utils what class will be tested.
1534 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1535 Add a simple (but empty) test case. One class, used by the OnlineGlom
1536 class, is mocked so that it can be created. However, I am not sure
1537 why only this class needs to be mocked.
1539 Note that mockito seems more popular, and clearer, than easymock,
1540 but I have not got that working yet. It might be a matter of the
1543 This test is run during mvn integration-test.
1545 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1547 Tests: Use junit4-style syntax instead of junit3-style.
1549 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1550 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1551 * src/test/java/org/glom/web/shared/DataItemTest.java:
1552 Use the @Test annotation rather than relying on the test*() prefix.
1553 Also no longer implement TestCase, to avoid triggering support for
1554 the junit3-way, which stops the annotations from working.
1555 Change the imports from import junit.framework.* to
1556 import org.junit.*, which is apparently the new way.
1558 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1560 Added a test for ListPlace token parsing and creation.
1562 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1563 This is much the same as DetailsPlaceTest.
1565 I wonder how we could test the other parts of the *Place API.
1567 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1569 DetailsPlace test: Also test getToken() and recreation via getPlace().
1571 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1572 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1573 recreate it, testing the recreated DetailsPlace for the same parameter
1576 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1578 Use the surefire-report plugin.
1580 * pom.xml: This generates a HTML report about the tests in
1581 target/site/surefire-report.html
1582 when you do mvn surefire-report:report. It seems to be popular/normal.
1584 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1586 Added a test for DetailsPlace.
1588 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1589 Test the getPlace() token parsing.
1591 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1593 Added a first unit test.
1595 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1596 * src/test/java/org/glom/web/shared/DataItemTest.java:
1597 This is a silly test but it is just to get things started. Note that
1598 maven/junit finds the test because it looks in src/test by default.
1600 2011-12-22 Ben Konrath <ben@bagu.org>
1602 Change charsetName to "UTF-8" when replacing line breaks.
1604 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1605 that work in Java (such as "UTF8") will not work when compiled to
1608 This fixes a problem with multi-line details view fields that have hard
1609 line breaks. The "License Text" field on this page demonstrates the
1612 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1614 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1616 2011-12-22 Ben Konrath <ben@bagu.org>
1618 Fix another bug with related list navigation.
1620 I've tested all the navigation buttons in all of the related lists
1621 so things should be good now.
1623 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1625 2011-12-22 Ben Konrath <ben@bagu.org>
1627 Fix a crasher when refreshing the list view with the default table.
1629 This crash will also happen when loading the list view with the default
1630 table from a link or bookmark.
1632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1633 to the main document selection page when the document id hasn't been
1635 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1636 the main document selection page when the document id hasn't been
1638 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1639 values for the details place when the document id hasn't been set.
1640 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1641 values for the list place when the document id hasn't been set.
1643 2011-12-21 Ben Konrath <ben@bagu.org>
1645 Protect against NPE when glom.document.locale is not in config.
1647 This patch protects against an NPE when glom.document.locale is not in
1648 the config file. This NPE will also happen if glom.document.locale is
1651 The patch also updates the error message to display the class name when
1652 the getMessage() returns null. This was happening when the NPE was
1653 thrown and I had "Configuration Error: null". If an NPE is encountered
1654 with this patch, "Configuration Error: NullPointerException " will be
1657 This commit closes this bug:
1659 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1661 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1663 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1665 Rename onlineglom.properties to onlineglom.properties.sample.
1667 * src/main/resources/onlineglom.properties: Rename to:
1668 * src/main/resources/onlineglom.properties.sample:
1669 * src/main/resources/README: And add this file explaining that people
1670 should rename it back when deploying.
1672 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1674 Allow choosing the translation in the .properties file.
1676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1677 init(): Read a glom.document.locale value from the configuration file
1678 and call Glom's TransatableItem::set_current_locale() method.
1679 * src/main/resources/onlineglom.properties: Add a commented-out
1680 example of this new setting.
1682 It would be better to add &lang=de_DE to the URL, but the current
1683 libglom API does not allow us to do this easily. I am working on that.
1685 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1687 Avoid a crash in parsing of token parameters.
1689 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1690 ava: getTokenParams(): Do not crash if a parameter has a key but no
1691 value, and ignore parameters with neither.
1693 2011-12-17 Murray Cumming <murrayc@murayc.com>
1695 History token building/handling: Improve use of token parameters.
1697 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1698 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1699 and buildParamsToken(HashMap), for use by derived classes.
1700 Make the separator private because it is no longer be needed.
1701 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1702 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1703 instead of manual string concatenation.
1704 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1705 of hardcoded indices and awkward splitting code.
1706 * src/main/java/org/glom/web/client/place/ListPlace.java
1707 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1708 instead of manual string concatenation.
1709 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1710 of hardcoded indices and awkward splitting code.
1711 This should fix bug #666420
1713 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1715 Fix a Navgiation->Navigation typo in the code.
1717 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1718 Rename processNavgiation() to processNavigation().
1720 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1722 Fix a seperator->separator typo in the code.
1724 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1725 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1726 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1729 2011-12-15 Ben Konrath <ben@bagu.org>
1731 Cleanup some comments.
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1735 2011-12-14 Ben Konrath <ben@bagu.org>
1737 Replace \n with <br/> for multiline text in the details view.
1739 Vertical scrollbars are added when needed as well.
1741 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1743 2011-12-14 Ben Konrath <ben@bagu.org>
1745 Specify the font for document selection links.
1747 * src/main/webapp/style.css:
1749 2011-12-14 Ben Konrath <ben@bagu.org>
1751 Fix bouncy CellTable while paging.
1753 This doesn't currently work with related list tables in unselected
1756 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1758 2011-12-14 Ben Konrath <ben@bagu.org>
1760 Revamp the appearance of the document selection page.
1762 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1763 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1764 * src/main/webapp/style.css:
1766 2011-12-13 Ben Konrath <ben@bagu.org>
1768 Set navigation button column to the smallest size possible.
1770 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1772 2011-12-13 Ben Konrath <ben@bagu.org>
1774 Change OpenButton nomenclature to NavigationButton.
1776 Using NavigtionButton makes things more generic. Classes, methods and
1777 variables have been changed.
1779 This is a rename-only refactor.
1781 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1782 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1783 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1784 Renamed from OpenButtonCell.
1785 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1786 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1787 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1789 2011-12-12 Ben Konrath <ben@bagu.org>
1791 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1793 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1794 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1795 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1796 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1798 2011-12-12 Ben Konrath <ben@bagu.org>
1800 Update variable names and comments.
1802 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1803 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1805 2011-12-12 Ben Konrath <ben@bagu.org>
1807 Properly initialize numNonEmptyRows variable to zero.
1809 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1810 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1812 2011-12-05 Ben Konrath <ben@bagu.org>
1814 Add latest mockup with HTML tables.
1816 Features of this mockup:
1818 -> HTML table for flowtable
1819 -> HTML table for flowtable column
1820 -> Example of how related lists would look
1821 -> Not using text entries for data items
1823 The current version of Online Glom doesn't use HTML tables for the
1826 This mockup has been sent to the glom-devel mailing list but it's good
1827 to have it here as well.
1829 * mockups/details-view-html-tables.html:
1831 2011-12-05 Ben Konrath <ben@bagu.org>
1833 Remove unnecessary getPrimaryKeyField() method.
1835 getPrimaryKeyFieldForTable(String) has been renamed to
1836 getPrimaryKeyField(String).
1838 * src/main/java/org/glom/web/server/database/DBAccess.java:
1839 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1840 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1842 2011-12-05 Ben Konrath <ben@bagu.org>
1844 Add string representation of TypedDataItem value to conversion error message.
1846 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1847 message was extracted into its own method to avoid duplication.
1849 2011-12-05 Ben Konrath <ben@bagu.org>
1851 Add type checking to navigation primary key value creation.
1853 Create navigation primary key only if the expected type from the Glom
1854 document matches the type returned by the SQL query.
1856 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1858 2011-12-05 Ben Konrath <ben@bagu.org>
1860 Rename a couple of variables in RelatedListNavigation.
1862 This is a rename-only refactor.
1864 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1866 2011-12-05 Ben Konrath <ben@bagu.org>
1868 Move getListLayoutGroup() into getListViewLayoutGroup().
1870 This removes getListLayoutGroup(). It was only being called by
1871 getListViewLayoutGroup().
1873 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1875 2011-12-05 Ben Konrath <ben@bagu.org>
1877 Remove check for LayoutItem_Portal in list table method.
1879 This check is no longer necessary because the method isn't being used
1880 to create the LayoutItemPortal DTO.
1882 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1884 2011-12-05 Ben Konrath <ben@bagu.org>
1886 Properly support related list navigation.
1888 Navigation from the "Repository Analyzer -> Package Scans ->
1889 Dependencies" related table wasn't working because the primary key for
1890 related tables wasn't being set properly. This commit fixes the
1893 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1894 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1895 doesn't set the primary key properly for related list tables.
1896 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1897 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1898 useful for getting the primary key for list view tables and for related
1900 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1901 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1902 Move code to set the primary key for the table from the abstract
1903 ListDBAccess class to ListViewDBAccess as it's only correct for list
1905 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1906 Properly add primary key to related list tables.
1908 2011-12-02 Ben Konrath <ben@bagu.org>
1910 Properly set the horizontal alignment of fields.
1912 This fix is for both the list tables and the details view.
1914 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1915 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1916 to set the horizontal alignment of fields.
1918 2011-12-02 Ben Konrath <ben@bagu.org>
1920 Display currency codes in the details view.
1922 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1924 2011-12-02 Ben Konrath <ben@bagu.org>
1926 Avoid duplicate JNI call.
1928 JNI is not as efficient as pure Java and this is an easy (and small)
1931 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1932 Use previously retrieved value for whereClauseToTableName instead of
1935 2011-12-02 Ben Konrath <ben@bagu.org>
1937 Rename a couple of variables in RelatedListNavigation.
1939 This is a rename-only refactor.
1941 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1943 2011-12-02 Ben Konrath <ben@bagu.org>
1945 Indicate clearly that a mismatched primary key type is a bug.
1947 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1948 warning to error. Add 'This is a bug.' to message.
1950 2011-12-02 Ben Konrath <ben@bagu.org>
1952 Update / fix some comments.
1954 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1956 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1958 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1959 Fix comments. Add some TODOs.
1961 2011-12-02 Ben Konrath <ben@bagu.org>
1963 Enable navigation to details view with string primary key from related list.
1965 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1966 Create a text primary key value when return type of result is
1967 java.sql.Types.VARCHAR.
1969 2011-12-02 Ben Konrath <ben@bagu.org>
1971 Use checkboxes for booleans in the details view.
1973 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1975 2011-12-01 Ben Konrath <ben@bagu.org>
1977 Improve performance of related list height calculation.
1979 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1980 Put code to calculate the expected height in a static initializer so
1981 that that it's only called once.
1983 2011-12-01 Ben Konrath <ben@bagu.org>
1985 Show related list tables in notebooks (again).
1987 Calculate the height of the related list tables so the Notebook can be
1988 set the correct height. The height of the related list table is also needed by
1989 FlowTable to be able decide how to create the layout.
1991 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1992 and set the Portal height based on the height of the related list
1993 table and the Portal container.
1994 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1995 Add method to calculate the height of the related list tables.
1996 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1997 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1998 calculate the height of the Pager widget.
2000 2011-12-01 Ben Konrath <ben@bagu.org>
2002 Use CellTable API for table property instead of setting style on Element.
2004 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2006 2011-12-01 Ben Konrath <ben@bagu.org>
2008 Make ListViewTable and RelatedListTable a consistent height.
2010 The tables are now a consistent height regardless of the contents of
2011 the table. A hidden button is added to empty rows to ensure that the
2012 height of these rows will match the height of rows with data.
2014 A navigation button column is now added to every table. The width of
2015 the navigation column is set to 0px when a RelatedListTable shouldn't
2016 have navigation buttons. This maintains the a consistent row height in
2017 tables that don't show the navigation buttons.
2019 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2020 navigation column when not needed.
2021 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2022 arguments for navigation button to constructor of ListViewTable.
2023 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2024 hidden button for empty data rows.
2025 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2026 arguments for navigation button to constructor.
2027 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2028 create navigation buttons. Add hideNavigationButtons() method.
2029 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2030 arguments for navigation button to constructor.
2032 2011-12-01 Ben Konrath <ben@bagu.org>
2034 Use 'visibility: hidden' in Utils.getWidgetHeight().
2036 This is better choice because hidden elements are invisible, don't
2037 respond to events and are not part of the tab order. They will,
2038 however, take up space which is required to be able to calculate the
2039 height of the widget.
2041 * src/main/java/org/glom/web/client/Utils.java:
2043 2011-12-01 Ben Konrath <ben@bagu.org>
2045 Use Utils.getWidgetHeight() in FlowTable.
2047 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2049 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2051 2011-12-01 Ben Konrath <ben@bagu.org>
2053 Put the details css class name on the correct table column.
2055 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2057 2011-11-30 Ben Konrath <ben@bagu.org>
2059 Update for java-libglom API change.
2061 The getters and setters on FieldFormatting and NumericFormat were
2062 changed to remove the 'M'.
2064 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2066 2011-11-29 Ben Konrath <ben@bagu.org>
2068 Only allow RelatedListTables in Portals.
2070 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2072 2011-11-29 Ben Konrath <ben@bagu.org>
2074 Only create a contents panel for Portals when title is being set.
2076 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2078 2011-11-29 Ben Konrath <ben@bagu.org>
2080 Set TabLayoutPanel height based on calculated height its widgets.
2082 This is a potential fix for this bug:
2084 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2086 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2088 2011-11-29 Ben Konrath <ben@bagu.org>
2090 Align details field labels and data with the Open buttons.
2092 * src/main/webapp/style.css:
2094 2011-11-29 Ben Konrath <ben@bagu.org>
2096 Remove unnecessary <div> in the Notebook widget.
2098 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2099 method to get container FlowPanel (<div>).
2100 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2101 initWidget() method directly on the TabLayoutPanel widget instead of
2102 Group's container widget.
2104 2011-11-29 Ben Konrath <ben@bagu.org>
2106 Don't add group titles for Portals in Notebooks.
2108 This reverts the previous patch and fixes a bug I introduced with
2109 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2111 * src/main/java/org/glom/web/client/ui/details/Group.java:
2112 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2114 2011-11-28 Ben Konrath <ben@bagu.org>
2116 Remove unused boolean argument in Portal constructor.
2118 Just a code cleanup.
2120 * src/main/java/org/glom/web/client/ui/details/Group.java:
2121 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2123 2011-11-28 Ben Konrath <ben@bagu.org>
2125 Remove hack for glom 1.18 style glom files.
2127 * src/main/java/org/glom/web/client/ui/details/Group.java:
2128 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2129 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2131 2011-11-28 Ben Konrath <ben@bagu.org>
2133 Use Gda Value version of primary key to log result too large error.
2135 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2137 2011-11-28 Ben Konrath <ben@bagu.org>
2139 Don't use TypedDataItem.getText() for Unknown types from the URL.
2141 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2142 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2143 instead of getText().
2144 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2145 String field and getUnknown() method.
2147 2011-11-28 Ben Konrath <ben@bagu.org>
2149 Log an error message when the java-libglom .so is not present.
2151 The error message was being set in the exception but not logged.
2153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2155 2011-11-28 Ben Konrath <ben@bagu.org>
2157 Ignore LayoutItem_CalendarPortals.
2159 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2160 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2162 2011-11-28 Ben Konrath <ben@bagu.org>
2164 Extract method for creating the LayoutItemPortal DTO.
2166 Just breaking the code up into smaller chunks.
2168 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2170 2011-11-28 Ben Konrath <ben@bagu.org>
2174 This should have been added with the refactor. Oops!
2176 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2178 2011-11-28 Ben Konrath <ben@bagu.org>
2180 Create primary key value from URL string using type from Glom document.
2182 See this bug, comments 19 - 25:
2184 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2186 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2187 create a TypeDataItem for the primary key here when loading from a
2188 URL. Show the same string for the primary key value as was received
2189 from the URL string (when loading from a URL).
2190 * src/main/java/org/glom/web/server/Utils.java: Update method for
2191 creating the Gda Value from the TypeDataItem to properly deal with
2192 creating a Gda Value based on the Glom document type for the primary
2193 key value string when loading from a URL.
2194 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2195 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2196 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2197 Update for changed method name.
2199 2011-11-27 Ben Konrath <ben@bagu.org>
2201 Rename PrimaryKeyItem to TypedDataItem.
2203 The name PrimaryKeyItem suggests what the class should be used for.
2204 TypedDataItem is a neutral name that describes the class better.
2206 This is a rename-only refactor.
2208 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2209 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2210 * src/main/java/org/glom/web/client/Utils.java:
2211 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2212 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2213 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2214 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2215 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2216 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2218 * src/main/java/org/glom/web/server/Utils.java:
2219 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2220 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2221 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2222 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2224 2011-11-25 Ben Konrath <ben@bagu.org>
2226 Improve Gda Value conversion from PrimaryKeyItem.
2228 The value from the PrimaryKeyItem is only used if its type match the
2229 type from the glom document.
2231 * src/main/java/org/glom/web/server/Utils.java:
2233 2011-11-25 Ben Konrath <ben@bagu.org>
2235 Manually check if the java-liblgom .so is visible to the JVM.
2237 It seems that Tomcat has problems when a static initializer throws an
2238 exception. This check is done before the first method call into
2239 java-libglom so that execution doesn't continue if the .so is not
2242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2244 2011-11-25 Ben Konrath <ben@bagu.org>
2246 Improve browser configuration error messages.
2250 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2252 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2253 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2254 getConfigurationErrorMessage() method.
2255 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2256 Get and display a specific configuration error message when no Glom
2257 documents are found.
2258 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2259 Implement getConfigurationErrorMessage() method. Surround configuration
2260 code in the init() method with a try/catch block. This allows the
2261 errors to be caught while keeping the servlet available to retrieve the
2262 configuration error message.
2264 2011-11-25 Ben Konrath <ben@bagu.org>
2266 Don't use Strings to hold primary key values.
2268 The primary key values are now held in a new data object
2269 (PrimaryKeyItem) that holds type information and the primary key value
2270 using the correct type.
2272 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2273 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2274 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2275 PrimaryKeyItem instead of String to hold the primary key value.
2276 * src/main/java/org/glom/web/client/Utils.java: Remove
2277 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2278 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2279 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2280 PrimaryKeyItem instead of String to hold the primary key value. Load
2281 document selection page when the documentID has not been set correctly.
2282 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2283 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2285 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2286 Return empty string for URL instead of "null".
2287 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2288 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2289 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2290 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2291 PrimaryKeyItem instead of String to hold primary key values.
2292 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2293 PrimaryKeyValue to a Gda Value.
2294 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2295 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2296 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2297 Replace temporary database access code that uses the PrimaryKeyValue to
2298 Gda Value conversion.
2299 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2300 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2301 PrimaryKeyItem instead of String.
2302 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2303 hold primary key values.
2305 2011-11-24 Ben Konrath <ben@bagu.org>
2307 Use newly added java-libglom API to create queries.
2309 This isn't finished. I still need to stop using Strings for primary key
2310 values in the client code.
2312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2313 libglom to use fake connections so that retrieving the query string will
2315 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2316 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2317 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2318 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2319 Use the newly added libglom sql methods and classes to create the
2320 query. Add temporary hack to convert primary value strings to Gda
2323 2011-11-23 Ben Konrath <ben@bagu.org>
2325 Don't explicitly set the height of Portals.
2327 See comments 6 - 10 of this bug for details:
2329 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2331 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2333 2011-11-23 Ben Konrath <ben@bagu.org>
2335 Use an HTML table instead of CSS for the FlowTable layout.
2337 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2338 GWT's FlexTable to implement the FlowTable.
2339 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2341 2011-11-18 Ben Konrath <ben@bagu.org>
2343 Add boolean example to HTML table mockup.
2345 * mockups/details-view-html-tables-text-entries.html:
2347 2011-11-17 Ben Konrath <ben@bagu.org>
2349 Ensure the pager buttons are always visible for related lists.
2351 To accomplish this, I've turned off text wrapping in the list view and
2352 related list tables for both the header and data text. The related list
2353 table now has a fixed layout so the it doesn't overflow its container.
2354 This is required to ensure that the cell text is clipped when it
2355 overflows the cell and an ellipsis is added to the right side of the
2356 cell when text is clipped.
2358 A fixed table layout for the related list table in the details view
2359 seems what we want for the details view anyway, so the side-effect is
2362 The ellipsis will only be displayed in Firefox >= 7.
2366 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2368 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2369 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2370 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2372 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2373 Set the 'table-layout: fixed' CSS property to the related list table.
2374 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2375 'white-space: nowrap;' CSS property on both the list view and the
2376 related list tables.
2378 2011-11-16 Ben Konrath <ben@bagu.org>
2380 Rework the fix for empty notebook tab labels.
2382 Setting the empty group titles with its name caused problems for the
2383 details layout. Instead of using libglom's
2384 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2385 to the client when the title is empty. This allows the Notebook to use
2386 the name when the title is empty without affecting anything else.
2388 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2389 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2391 2011-11-16 Ben Konrath <ben@bagu.org>
2393 Set group titles with name when title is empty.
2395 This fixes a problem with an empty notebook tab label in the Lesson
2396 Planner document. The forth tab in the notebook should be "Internet":
2398 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2400 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2401 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2404 2011-11-16 Ben Konrath <ben@bagu.org>
2406 Remove whitespace from the configured username properties.
2408 This assumes that usernames won't have whitespace at the beginning
2409 or end. But I think this is a reasonable assumption.
2411 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2412 String.trim() to remove the whitespace from the username properties.
2414 2011-11-15 Ben Konrath <ben@bagu.org>
2416 Add details view mockup with HTML tables and text entries.
2418 This is from the attachment on this bug:
2420 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2422 * mockups/details-view-html-tables-text-entries.html:
2424 2011-11-15 Ben Konrath <ben@bagu.org>
2426 Add space between the columns of the flow table.
2430 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2432 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2433 space between columns in the flow table.
2435 2011-11-15 Ben Konrath <ben@bagu.org>
2437 Add backup files to the .gitignore.
2439 * .gitignore: Ignore files that end with ~.
2441 2011-11-09 Ben Konrath <ben@bagu.org>
2443 Use latest release of gwt-log.
2445 Gwt-log releases are now being submitted to the maven central
2446 repository so manual installation of the jar is no longer required.
2448 * pom.xml: Update version and groupId of gwt-log dependency.
2450 2011-10-31 Ben Konrath <ben@bagu.org>
2452 Don't use GWT numeric formatting to override the glom currency formatting.
2454 Currencies are now displayed like they are in Glom. See this bug:
2456 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2458 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2460 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2461 currency code to constructor and set it when the cell is rendered.
2462 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2463 currency code to the constructor of the NumericCell.
2465 2011-10-27 Ben Konrath <ben@bagu.org>
2467 Require the latest release of java-libglom (1.17.4).
2471 2011-10-26 Ben Konrath <ben@bagu.org>
2473 Add style to Notebook that matches current theme.
2475 It's not the best style in the world but it's better than the default.
2477 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2478 padding at the bottom of the child widgets.
2479 * src/main/webapp/style.css: Add style for the Notebook.
2481 2011-10-26 Ben Konrath <ben@bagu.org>
2483 Move servlet initialization code to overridden init method.
2485 This is half of the solution to getting proper error messages
2486 displayed when configuration errors occur. Here's the relevant bug:
2488 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2490 The rest of the solution involves surrounding the init method with a
2491 try/catch block and setting a global variable with the error /
2492 exception. A new async method should be created to retrieve and display
2493 the error message / exception.
2495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2496 code from constructor to init method adding exceptions as needed.
2498 2011-10-26 Ben Konrath <ben@bagu.org>
2500 Add script to monitor and restart tomcat if required.
2502 * utils/check-and-recover-tomcat.py: New file.
2504 2011-10-26 Ben Konrath <ben@bagu.org>
2506 Display the correct number of data items in the pager.
2510 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2512 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2513 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2514 The implementation is the same for both tables: Keep track of the
2515 number of non-empty rows and fire and RowCountChangeEvent after the data has
2517 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2518 custom Pager class that subclasses SimplePager to handle displaying
2519 the correct number when empty rows have been added.
2521 2011-10-26 Ben Konrath <ben@bagu.org>
2523 Correct error in previous commit.
2525 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2526 eventBus parameter from listView.setCellTable().
2528 2011-10-26 Ben Konrath <ben@bagu.org>
2530 Fix error in TODO comment.
2532 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2534 2011-10-24 Ben Konrath <ben@bagu.org>
2536 Create Notebook widgets to the details view.
2538 This isn't finished just yet - I still need to create a reasonable
2539 style to match the current theme.
2541 * src/main/java/org/glom/web/client/Utils.java: Add method for
2542 calculating the height of a widget. This is used in the Notebook class.
2543 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2544 new constructor method in Group.
2545 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2546 method for creating child widget that can be used by subclasses
2547 like Notebook. New constructor that allows disabling the group
2548 titles - Notebooks don't set a group title for their child groups.
2549 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2550 to make Notebooks using GWT's TabLayoutPanel.
2551 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2552 constructor that allows disabling the group titles.
2553 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2554 LayoutItemNotebook DTO.
2555 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2556 DTO for Notebooks. It's just an empty class for now but we might need
2557 it to transfer some specific information in the future.
2559 2011-10-21 Ben Konrath <ben@bagu.org>
2561 Add navigation buttons to related list tables.
2563 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2564 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2566 method getSuitableRecordToViewDetails() for getting the table name
2567 and primary key value for related list navigation buttons.
2568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2569 private cell renderer class to get the navigation information for
2570 related list tables from the server. Extract the navigation
2571 processing code from the details cell navigation and use it for the
2572 related list navigation as well.
2573 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2574 cell renderer class for the details open buttons. This was needed
2575 because the related list navigation buttons and the list view
2576 navigation buttons need to react differently when clicked.
2577 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2578 the onEnterKeyDown() method because it's now overriden in the
2579 subclasses that are specific to the related list tables and the list
2581 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2582 the vertical size a little because the buttons add a bit of vertical
2583 space to table. This is not a perfect solution because the vertical
2584 size of with table fewer than 5 rows will be a little smaller.
2585 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2586 changes in how navigation buttons are handled.
2587 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2588 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2589 database access object.
2590 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2591 to find the portal for a given relationship name from
2592 RelatedListDBAccess. Add method to find a primary key field for a
2594 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2595 Move code to find the portal for a given relationship name to
2597 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2598 New file: database access object for getting the related list
2599 navigation information (the table name and the primary key value).
2600 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2601 DTO for transferring a table name to navigate to and a primary key
2603 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2604 boolean and getter/setter to specifies if the related list should add
2607 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2609 Use the master branch of java-libglom
2611 * pom.xml: Depend on java-libglom 1.19 instead.
2613 This is the master branch. See also the libglom-1-18 branch.
2615 2011-10-11 Ben Konrath <ben@bagu.org>
2617 Enable the open navigation button when the data has been set.
2619 This avoids having active buttons that don't do anything when the data
2622 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2624 2011-10-11 Ben Konrath <ben@bagu.org>
2626 Use IsWidget interface for FlowTableItem.
2628 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2629 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2631 2011-10-11 Ben Konrath <ben@bagu.org>
2633 Remove GWT styling from open button in details view.
2635 There are still some issues with how the details cell is arranged but
2636 this should be made to match Glom 1.20. I'm going to leave fixing this
2637 until I have Glom 1.20 up and running.
2639 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2640 style name on open button.
2641 * src/main/webapp/style.css: Move and edit details-navigation class.
2642 Re-arrange some classes to make them appear in the same order as the
2645 2011-10-07 Ben Konrath <ben@bagu.org>
2647 Update to GWT 2.4.0.
2649 * .gitignore: Ignore new cache directory.
2650 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2651 * pom.xml: Change GWT and maven plugin to 2.4.0.
2652 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2654 * src/main/java/org/glom/web/client/ClientFactory.java:
2655 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2656 * src/main/java/org/glom/web/client/OnlineGlom.java:
2657 Update source for API changes.
2658 * utils/build-onlineglom-war.sh: Remove cache directory before the
2661 2011-10-07 Ben Konrath <ben@bagu.org>
2663 Add navigation buttons in the details view.
2665 This isn't finished but I thought I'd commit what I have as it's a
2666 pretty good start. I still need to:
2668 1. Change the style so that it fits better into the current theme
2669 2. Adjust the details cell to expand as much as possible.
2671 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2672 click handlers to navigation buttons in the DetailsCells. Create a
2673 refreshData() method to get just the data from the server without the
2675 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2676 Update the tableSelector and browser title when the table name
2677 changes without using the tableSelector.
2678 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2679 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2680 getDetailsCells() to getCells(). Update variable names.
2681 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2682 method to set click handler on navigation button. Rename a few
2683 variables. Add navigation buttons where needed.
2684 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2685 variables and methods.
2686 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2687 navigation boolean and navigation table as required in the
2688 LayoutItemField DTO.
2689 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2690 variables for navigation along with getter/setter methods.
2692 2011-10-07 Ben Konrath <ben@bagu.org>
2694 Rename Field to DetailsCell.
2696 This is a refactor-only commit. No functionality has been added or
2699 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2700 Update variable and method names.
2701 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2702 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2703 variable and method names.
2704 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2706 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2707 variable and method names.
2709 2011-10-07 Ben Konrath <ben@bagu.org>
2711 Create separate methods for layout and data the details view.
2713 This is a refactor-only commit. No functionality has been added or
2716 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2717 private methods: setData(), createLayout().
2719 2011-10-07 Ben Konrath <ben@bagu.org>
2721 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2723 This is part of a change to get navigation buttons in the details view
2724 but it should have been done this way from the start.
2726 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2727 for method name change in TableSelectionView.
2728 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2729 Create TableChangeEvent and set the browser title using the
2730 TableSelectionView API.
2731 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2732 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2733 Change getSelectedTable() to getSelectedTableName(). Add
2734 getSelectedTableTitle().
2736 2011-10-07 Ben Konrath <ben@bagu.org>
2738 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2740 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2742 2011-10-07 Ben Konrath <ben@bagu.org>
2744 Update TableChangeEvent to use newTableName naming convention.
2746 This makes the class more consistent with GWT naming conventions.
2748 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2749 Update for method name change in TableChangeEvent.
2750 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2751 for method name change in TableChangeEvent.
2752 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2753 newTableName variable and getter method. Make toDebugString()
2756 2011-09-30 Ben Konrath <ben@bagu.org>
2758 Disable the pager in the list tables when the data row count is less than the minimum.
2760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2761 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2763 2011-09-30 Ben Konrath <ben@bagu.org>
2765 Add empty rows to the end of related list and list view tables.
2767 I also extracted the cell rendering classes from the ListTable because
2768 the code was becoming a little crazy with all the anonymous inner
2769 classes. My plan is to use these cell rendering classes in the details
2770 view as well so this refactor will be needed for that change.
2772 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2773 set the row count in related list tables if the data has more rows
2774 than the minimum number of rows visible.
2775 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2776 row count in list view tables if the data has more rows than the
2777 minimum number of rows visible.
2778 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2779 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2781 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2782 for rendering TYPE_NUMERIC cells. The code was extracted from the
2784 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2785 class for rendering cells with buttons in list views. The code was
2786 extracted from the ListTable class.
2787 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2788 for rendering TYPE_TEXT cells. The code was extracted from the
2790 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2791 Add empty rows to the end of the data if required. Implement
2792 ListTable.getMinNumVisibleRows().
2793 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2794 cell renderer code to public classes. Return null in
2795 Column.getValue() for empty rows. Add new abstract method:
2796 getMinNumVisibleRows(). Move code to set the row count of the list view
2797 table to ListViewImpl.
2798 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2799 empty rows to the end of the data if required. Implement
2800 ListTable.getMinNumVisibleRows().
2803 2011-09-27 Ben Konrath <ben@bagu.org>
2805 Use GWT.log for client-side debugging statements.
2807 These are optimized out when deployed so I should have used this method
2808 in the first place. These statements will eventually be replaced with some sort
2809 of notification in the browser.
2811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2812 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2813 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2814 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2815 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2817 2011-09-27 Ben Konrath <ben@bagu.org>
2819 Put tableselector on the right, back to list link on right.
2821 The idea is that the table selector is acting like a label for the
2822 currently displayed table so it should be placed below the document title. This
2823 puts the table title in a similar position to where it is in Glom.
2825 * mockups/details-contacts.html:
2826 * mockups/details-projects.html:
2827 * mockups/listview-contacts.html:
2828 * mockups/listview-projects.html:
2829 * mockups/style.css:
2830 Update mockups to match how the interfaces currently look.
2831 * src/main/webapp/style.css: Swap positions of backlink with the table
2832 selector. Add some space on the left side of the table selector to
2833 line things up with the document title.
2835 2011-09-27 Ben Konrath <ben@bagu.org>
2837 Add field colouring to details view.
2839 This change re-works how field colouring works. The colour formatting
2840 information is now set to the client with the layout information instead of
2841 with the data. This eliminates the need to send the same colour strings for
2842 data in list view column when colour information is set.
2844 In order to set an alternate colour for negative numeric values, the
2845 number is now sent to client and formatted with the GWT NumberFormat class.
2847 This change also fixes:
2849 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2851 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2852 internationalization framework which is needed for client side numeric
2854 * src/main/java/org/glom/web/client/Utils.java: New file for some
2855 client static utility methods.
2856 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2857 the DataItem object to the Field class. Use a utility method to
2858 create the foreignKeyValue string.
2859 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2860 alignment and text colours in the constructor. Add setData(DataItem)
2861 method. Remove setText(String) method.
2862 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2863 colour information to GlomTextCell. Create and use GlomNumberCell for
2864 rendering numbers. Use utility method to get the string for the
2865 primary key of the key provider. Re-work how the horizontal alignment
2867 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2868 formatting to layout information. Methods for converting the libglom
2869 formatting information were moved from DBAccess.
2870 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2871 numeric formatting (it's now done on the client side). Don't set text
2872 colours in DataItem. Move libglom formatting conversion methods to
2874 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2875 getters/setters for text colour information.
2876 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2877 for transferring the libglom NumericFormat information to the client.
2878 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2879 and getters/setters for: GlomNumericFormat, background colour and
2880 foreground colour strings.
2882 2011-09-26 Ben Konrath <ben@bagu.org>
2884 Simplify code that iterates through the LayoutGroup.
2886 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2888 2011-09-26 Ben Konrath <ben@bagu.org>
2890 Accept Eclipse formatting for OnlineGlomServiceAsync.
2892 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2894 2011-09-26 Ben Konrath <ben@bagu.org>
2896 Don't use the ListDBAccess classes to get the primary key layout information.
2898 This was causing a bug where the wrong index for the hidden primary key
2899 was being sent to the client.
2901 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2902 primary key while creating the LayoutGroup DTO. Create a
2903 LayoutItemField DTO for hidden primary keys. Don't use the
2904 RelatedListDBAccess because it was only used for getting the primary
2906 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2907 access modifier from public to protected for getPrimaryKeyField() and
2908 getPrimaryKeyLayoutItemField().
2909 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2910 abstract method getExpectedResultSize() because RelatedListDBAccess
2911 doesn't have enough info to implement it.
2912 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2913 Remove @Override for getExpectedResultSize().
2914 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2915 Remove method getExpectedResultSize().
2917 2011-09-23 Ben Konrath <ben@bagu.org>
2919 Log which layout (list or details) the ignored item is from.
2921 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2923 2011-09-23 Ben Konrath <ben@bagu.org>
2925 Remove annotations that turn off code formatting in DataItem.
2927 * src/main/java/org/glom/web/shared/DataItem.java:
2929 2011-09-23 Ben Konrath <ben@bagu.org>
2931 Rename GlomField to DataItem and update associated methods.
2933 This is a rename-only refactor. No functionality has been added or
2936 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2937 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2938 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2939 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2940 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2941 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2942 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2943 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2944 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2945 * src/main/java/org/glom/web/server/database/DBAccess.java:
2946 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2947 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2948 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2949 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2950 * src/main/java/org/glom/web/shared/DataItem.java:
2951 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2952 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2954 2011-09-23 Ben Konrath <ben@bagu.org>
2956 Rename GlomDocument to DocumentInfo and update associated methods.
2958 This is a rename-only refactor. No functionality has been added or
2961 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2962 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2963 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2964 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2965 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2967 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2969 2011-09-20 Ben Konrath <ben@bagu.org>
2971 Require java-libglom 1.17.3.
2973 This picks up the fix for the seg fault problem with the Scenes table
2974 in the Openismus Film Manager example.
2978 2011-09-20 Ben Konrath <ben@bagu.org>
2980 Change the way sort clause is added for primary key when no sort clause is requested.
2982 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2983 before the sort clause is created. When a sort clause is not requested, the
2984 sort clause is created by finding the primary key in the LayoutFieldVector
2987 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2989 2011-09-20 Ben Konrath <ben@bagu.org>
2991 Log error message if no documents are found in the configured directory.
2993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2994 Extract the glom file extension string to a private static final class
2995 variable (mostly as syntactic sugar). Accept a minor formatting change.
2996 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2997 the example glom.document.directory configuration property to make it
2998 more clear that it can any directory, not just the home directory.
3000 2011-09-18 Ben Konrath <ben@bagu.org>
3002 Add related lists to details view.
3004 The related list table has support for paging and sorting just like the
3005 table in the list view.
3007 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3008 SQL queries for the related list tables.
3009 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3010 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3012 Rename getList methods to getListView and add comments. Remove
3013 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3014 it being unused. Add methods: getDetailsLayoutAndData(),
3015 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3016 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3017 Create the layout and set the data for the fields in one async call
3018 instead of two. Create related lists where appropriate.
3019 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3020 for method name changes in OnlineGlomService.
3021 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3022 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3023 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3025 * src/main/java/org/glom/web/client/ui/ListView.java:
3026 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3027 tableName from setCellTable(). Create a ListViewTable instead of
3029 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3030 represent a data field in the details view.
3031 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3032 from addDetailsCell() to Field class. Keep track of the Fields and
3033 Portals in the details view.
3034 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3035 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3036 and add a method to get it. Add method to set the contents of the
3038 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3039 New class for related list tables. This class has the data provider
3040 for the related list table.
3041 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3042 abstract class which is the base class for the ListViewTable and the
3044 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3045 New class for list view tables. This class has the data provider for
3046 the list view table.
3047 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3048 methods for related list tables. Add more information to the
3049 LayoutItemField and LayoutItemPortal DTOs.
3050 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3051 Remove debugging print statement.
3052 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3053 Remove debugging print statements. Add primary key field to SQL count
3055 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3056 Remove unnecessary LayoutFieldVector parameter from
3057 getResultSizeOfSQLQuery() method.
3058 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3059 New class for related list table database access.
3060 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3061 class that is a wrapper DTO for details view layout and data.
3062 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3063 new 'fromField' string to this DTO.
3064 * src/main/webapp/style.css: Remove bottom margin and override top
3067 2011-09-15 Ben Konrath <ben@bagu.org>
3069 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3071 This sets things up to make it easier to add the data retrieval for
3072 related lists (portals). No user noticeable changes were made with
3075 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3076 class has the code to retrieve the layouts and access the
3077 database using the new database helper classes.
3078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3079 Most of the functionality has been removed from this class. This
3080 class now represents the public interface for the client side
3081 code. It also deals with configuring the servlet and cleaning
3082 things up when the servlet is stopped.
3083 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3084 of static methods into this utility class.
3085 * src/main/java/org/glom/web/server/database/DBAccess.java:
3086 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3087 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3088 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3089 These classes have the database retrieval code. The class hierarchy
3090 has been setup to make it easy to reuse code for similar
3093 2011-09-06 Ben Konrath <ben@bagu.org>
3095 Create separate classes for list table code and the data provider.
3097 As part of this refactor, I also split up the code a bit to make it
3100 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3101 table code to two new classes (below).
3102 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3103 with code from ListViewImpl.
3104 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3105 New file with code from ListViewImpl.
3107 2011-09-06 Ben Konrath <ben@bagu.org>
3109 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3111 This fixes the LayoutItemPortal DTO to match the libglom layout object
3114 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3116 2011-09-01 Ben Konrath <ben@bagu.org>
3118 Set title of Portals in the Details View.
3120 * pom.xml: Bump required version of java-libglom to 1.17.1.
3121 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3122 widget creation to its own class. Add comments to constructor.
3123 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3124 The code is mostly from the Group class with the title now set.
3125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3126 title of Portal. Update some comments. Fix some code formatting.
3128 2011-09-01 Ben Konrath <ben@bagu.org>
3130 Remove TODO comment for the flow table column width.
3132 The flow table column width is working correctly and doesn't need to be
3133 changed. See this mailing list post for more info:
3135 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3137 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3139 2011-08-27 Ben Konrath <ben@bagu.org>
3141 Add document title (database name) to top of the browser page.
3143 I added the document title to the TableSelecitonView but that will
3144 change if / when we add a view that doesn't require table selection.
3146 * mockups/details-contacts.html:
3147 * mockups/details-projects.html:
3148 * mockups/listview-contacts.html:
3149 * mockups/listview-projects.html:
3150 * mockups/style.css: Add document title to mockups to keep things
3152 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3153 sizes to account for the document title.
3154 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3155 Set the document title when it has been retrieved from the server.
3156 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3158 and implement setDocumentTitle(String) method.
3159 * src/main/webapp/style.css: Add ID for document title style.
3161 2011-08-25 Ben Konrath <ben@bagu.org>
3163 Add NavigationType enum to LayoutItemPortal DTO.
3165 This is the start of adding support for Portals to the Details View.
3167 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3168 LayoutItem_Portal.navigation_type enum from libglom to
3169 LayoutItemPortal.NavigationType enum.
3170 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3171 NavigationType enum, field for storing the NavigationType and getter
3174 2011-08-25 Ben Konrath <ben@bagu.org>
3176 Implement the flow table layout in the Details View.
3178 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3179 FlowTable to Group to account for the renamed class.
3180 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3181 File. This is a container widget that implements the Glom details view
3182 flow table behaviour.
3183 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3184 org/glom/web/client/ui/FlowTable.java.
3185 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3186 so that the size of the subgroups are a closer match to the size of
3187 the Glom subgroups. This makes the flowtable layout match the layout
3188 in Glom for the Music Collection example file.
3190 2011-08-16 Ben Konrath <ben@bagu.org>
3192 Create container element for LayoutItemPortal in Details View.
3194 This will help me develop the layout for the FlowTable.
3196 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3197 fieldPanel variable to detailsCell.
3199 2011-08-15 Ben Konrath <ben@bagu.org>
3201 Set the height of the data element in the Details View.
3203 I changed the InlineLabels (text in a span element) to Labels (text in
3204 a div element) so that I could set the height of the details-data
3205 elements instead of the details-cell parent elements. This allows the
3206 the details-data element to display the correct height if style is
3207 applied that shows the height.
3209 This change has the added benefit of allowing the order of the labels
3210 and data elements to be changed for right-to-left languages.
3212 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3213 InlineLabels to Labels.
3214 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3215 InlineLabels to Labels. Set the height of the data element.
3216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3217 multiline text height in the Formatting DTO.
3218 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3219 for multiline height along with getter and setter methods.
3220 * src/main/webapp/style.css: Adjust style to account for the change
3221 from span elements to div elements in the details cell.
3223 2011-08-15 Ben Konrath <ben@bagu.org>
3225 Make the List View appearance match the mockups.
3227 It doesn't match exactly but it's much better than it was.
3229 * mockups/listview-contacts.html: Remove unused css classes.
3230 * mockups/listview-projects.html: Remove unused css classes.
3231 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3232 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3233 for mainPanel instead of VerticalPanel (table). Set style name on
3234 CellTable. Set style name on Details column. Right-align Details
3236 * src/main/webapp/style.css: Adjust properties to match the mockups.
3238 2011-08-12 Ben Konrath <ben@bagu.org>
3240 Add better support for subgroups in the details view.
3242 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3243 changed FlowTable constructor.
3244 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3245 support for subgroups and subgroup-titles.
3246 * src/main/webapp/style.css: Add CSS class for subgroups and
3249 2011-08-12 Ben Konrath <ben@bagu.org>
3251 Return the top level LayoutGroup title.
3253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3255 2011-08-11 Ben Konrath <ben@bagu.org>