1 2012-06-08 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Do not add a primary key to portals each time.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java
6 updatePortalsExtras(): Only add an extra primary key field if there is
7 none, to avoid adding one each time we retrieve the details layout from the
9 This should fix bug #676986 (Ben Konrath)
11 2012-05-25 Murray Cumming <murrayc@murrayc.com>
13 Document.load(): Support version 7 documents.
15 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
16 database_title attribute if the title attribute is not there.
19 2012-05-24 Ben Konrath <ben@bagu.org>
21 Add configuration for auto-generating mvn:i18n from with Eclipse.
23 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
25 2012-05-24 Murray Cumming <murrayc@murrayc.com>
27 Update translations, adding French.
29 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
30 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
31 Add a French translation, using the translation from Glom.
33 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
34 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
35 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
36 Update these based on the translations from Glom.
38 2012-05-24 Murray Cumming <murrayc@murrayc.com>
40 SelfHoster: Add some debug println messages to help when things fail.
42 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
43 System.out.println() lines.
45 2012-05-23 Murray Cumming <murrayc@murrayc.com>
47 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
49 * src/test/java/org/glom/web/server/SelfHoster.java:
50 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
51 instance) instead of just /usr/bin (as on Fedora). Check the result when
54 2012-05-23 Murray Cumming <murrayc@murrayc.com>
56 Remove LayoutItemPortal.get/setNavigationTable().
58 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
59 Remove get/setNavigationTable(), which is only a cache, because it is not
60 used, and does not need to be used, because that decision should be made on
62 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
63 updatePortalsExtras():
64 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
65 getNavigationRecord():
66 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
69 2012-05-21 Murray Cumming <murrayc@murrayc.com>
71 Initial self-hosting for tests.
73 * pom.xml: Change the scope for log4j, to hopefully make it
74 available to the test code which uses it indirectly via jOOQ.
75 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
76 self-hosting, though we only use it for testing.
78 * src/main/java/org/glom/web/server/libglom/Document.java:
79 example rows: Use a map instead of a list for each row of values,
80 so we know what field they are for, instead of relying on the sequence
81 being correct. This is not very efficient, but it does not really need
83 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
84 testReadTableExampleRows(): Adapted.
86 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
87 that returns an Object, for generic use. Note that Object seems to be
88 the implicit base even of double.
89 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
90 for use in CREATE TABLE SQL queries.
91 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
92 to do self-hosting of PostgreSQL databases via its command-line
93 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
94 backends/postgres_self.cc. This is incomplete - it needs more
95 warnings about failures and it needs to clean up properly when things
97 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
98 test of this new class.
100 2012-05-21 Murray Cumming <murrayc@murrayc.com>
102 Document: loading example data: Handle exceptions.
104 * src/main/java/org/glom/web/server/libglom/Document.java:
105 DateFormat.parse() and Double.valueOf() can throw exceptions, though
106 Eclipse did not warn about that.
108 2012-05-20 Murray Cumming <murrayc@murrayc.com>
110 Document: load(), save(): Handle the example rows.
112 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
114 * src/main/java/org/glom/web/server/libglom/Document.java:
115 load(), save(): Load and save the example rows, though the date, time
116 and image types are not handled properly yet.
117 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
118 Add testReadTableExampleRows() just to check that something is read.
120 2012-05-20 Murray Cumming <murrayc@murrayc.com>
122 Document: Add save().
124 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
125 Added getTranslationsMap() for use while saving.
126 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
127 Adedd getUseDefaultFormatting() for use while saving.
128 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
129 and several private methods that it uses.
131 This will be useful while testing via self-hosting.
132 It is not complete, but should be complete enough for testing.
134 2012-05-17 Murray Cumming <murrayc@murrayc.com>
136 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
138 * src/main/java/org/glom/web/client/OnlineGlomService.java
139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
141 Remove getSortedListViewData() and getSortedRelatedListData(), adding
142 the sort column index and ascending bool to the regular method.
143 Instead, a sort column index of -1 now means no sort.
144 This is less explicit, but it's fairly simple, reduces the amount of
145 code, and makes the OnlineGlomService API slightly smaller.
146 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
147 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
149 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
150 getListViewData(), getRelatedListData():
151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
152 getListViewData(), getRelatedListData():
153 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
155 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
157 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
162 2012-05-16 Murray Cumming <murrayc@murrayc.com>
164 Use translations for top-level groups too.
166 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
167 updateTitlesForLocale(): Use the translation for the group
168 as well as for child items.
172 Just recompiled to fix a problem in the released .tar.gz file.
176 2012-05-15 Murray Cumming <murrayc@murrayc.com>
178 Corrections to navigation to related records.
180 * src/main/java/org/glom/web/client/OnlineGlomService.java:
181 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
183 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
184 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
185 relationship name, because the relationship name is not necessarily unique
187 TOOD: This is inefficient, because it passes the whole list of
188 child field items back to the server, but it is more correct, and happens
189 to fix a bug with the primary key being lost after a few navigations.
190 There is probably a chance to make this more efficient anyway in some
193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
194 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
195 * src/main/java/org/glom/web/server/ConfiguredDocument.java
196 * src/main/java/org/glom/web/server/database/DBAccess.java
197 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
198 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
201 2012-05-15 Murray Cumming <murrayc@murrayc.com>
203 Fix the use of translations.
205 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
206 Add updateTitlesForLocale().
207 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
208 Call it to discard unwanted translations and to make getTitle() return
209 the wanted translation wihout the need for the client code to specify a locale.
210 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
211 getTitle(): Fallback to the original title, as libglom does.
213 2012-05-15 Murray Cumming <murrayc@murrayc.com>
215 Document: Correctly report the number of available translation locales.
217 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
218 the available locale IDs list.
219 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
220 testLocales: Test this.
222 2012-05-15 Murray Cumming <murrayc@murrayc.com>
224 SqlUtils: Use camelCase.
226 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
227 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
228 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
229 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
231 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
233 2012-05-15 Murray Cumming <murrayc@murrayc.com>
235 Use jOOQ's tableByName() and fieldByName.
237 * pom.xml: Use jOOQ 2.3.1 to get the new API.
238 * src/main/java/org/glom/web/server/SqlUtils.java:
239 build_sql_select_step_with_where_clause(), .createField(),
240 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
241 so we can get correct quoting and escaping. Thanks to Lukas Eder for
242 adding this, and other things, to jOOQ.
244 2012-05-15 Murray Cumming <murrayc@murrayc.com>
246 SqlUtils: Remove the Connection parameters.
248 * src/main/java/org/glom/web/server/SqlUtils.java:
249 build_sql_select_with_key(), build_sql_select_with_where_clause(),
250 createSelect(), build_sql_select_step_with_where_clause(),
251 build_sql_count_select_with_where_clause(),
252 build_sql_select_count_rows(): Remove the Connection parameter because
253 jOOQ does not actually need a connectionwhen it is just used to build
255 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
257 * src/main/java/org/glom/web/server/ReportGenerator.java:
259 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
261 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
262 Constructor, getListData(), getResultSizeOfSQLQuery():
263 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
264 getSelectQuery(), getCountQuery():
265 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
266 getSelectQuery(), getCountQuery():
267 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
268 getNavigationRecord(): Adapted.
270 2012-05-14 Murray Cumming <murrayc@murrayc.com>
274 * src/main/java/org/glom/web/server/SqlUtils.java:
275 get_find_where_clause_quick(): Use a comparison of
276 lowercase values, instead of a simple equals. Regular Glom
277 uses the PostgreSQL ILIKE operator but jOOQ does not
278 support that just yet, though it will soon.
280 2012-05-14 Murray Cumming <murrayc@murrayc.com>
282 TableToViewDetails: Use a real serialization ID.
284 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
285 Though this does not fix the serialization problem.
287 2012-05-12 Murray Cumming <murrayc@murrayc.com>
289 Added LayoutItemPortalDeepCloneTest.
291 2012-05-11 Murray Cumming <murrayc@murrayc.com>
293 Make navigation work again.
295 * src/main/java/org/glom/web/server/libglom/Document.java:
296 Add getLayoutItemFieldShouldHaveNavigation().
297 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
298 Replace get/setAddNavigation() with the partly-existing
299 get/setNavigationTableName(), with an empty string being no navigation,
300 because this is simpler. Use the new
301 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
303 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
304 Add updateFieldsExtras() and call setNavigationTableName in it.
305 getDetailsLayoutGroup(),
306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
307 createLayout(): Adapted.
308 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
309 Constructor: Adapted.
311 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
312 Replace get/setAddNavigation() with get/setNavigation(), returning a
313 TableToViewDetails class with both the table name and UsesRelationship,
314 because both are need. The previous code used java-libglom's output
315 variable (strangely, via sharedptr) to return both, but we cannot really
317 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
318 getNavigationRecord(): Adapt. However, we cannot actually use the cache
319 here because it somehow gets set to null during deepCopy(). I must test this.
320 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
321 testGetSuitableTableToViewDetails(): Adapted.
323 TODO: Find out why deepClone() is not quite working.
325 2012-05-11 Murray Cumming <murrayc@murrayc.com>
327 DBAccess: Simplify the retrievel of full field details.
329 * src/main/java/org/glom/web/server/database/DBAccess.java
330 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
331 because the Document loading should have done this.
333 2012-05-11 Murray Cumming <murrayc@murrayc.com>
335 Document: Correct loading of doubly-related layout fields.
337 * src/main/java/org/glom/web/server/libglom/Document.java:
338 loadUsesRelationship(): Actually set the related relationship, instead
339 of only setting it if it's not found.
341 2012-05-09 Murray Cumming <murrayc@murrayc.com>
343 Replace all appearances of Colour with color.
345 Because US English is dominant.
347 2012-05-09 Murray Cumming <murrayc@murrayc.com>
349 Use colors in HTML format, solving a warning about an unused function.
351 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
352 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
353 Add *asHTMLColor() versions of methods.
354 TODO: However, we should create and cache the results on the server.
355 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
356 * src/main/java/org/glom/web/client/ui/list/ListTable.java
357 * src/main/java/org/glom/web/server/ConfiguredDocument.java
358 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
359 Use the asHTMLcolor() versions.
361 2012-05-09 Murray Cumming <murrayc@murrayc.com>
363 ListViewTable: Constructor: Take the table name as a parameter.
365 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
366 Constructor: Take the tableName, and set the member variable, because
368 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
369 setCellTable(): Pass the table name.
370 This makes navigation to non-default tables work again. I don't know
371 why it worked before in the master branch.
373 2012-05-07 Murray Cumming <murrayc@murrayc.com>
375 ConfiguredDocument: Restore correct addition of hidden primary key items.
377 * src/main/java/org/glom/web/client/ui/list/ListTable.java
378 (ListTable.createCellTable): Uncomment out the check for the hidden
380 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
381 add primary key items for top-level lists and portals, as before,
382 instead of adding them to each group.
383 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
384 Actually implement the extra methods such as setHiddenPrimaryKey() and
385 comment that these are used only for top-level list groups and in portals.
386 This strangeness suggests even more that this should not be squeezed
387 into the LayoutGroup class.
389 2012-05-07 Murray Cumming <murrayc@murrayc.com>
391 Fix Formatting loading.
393 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
394 getFormattingUsed(): Remove the duplicate Formatting member variable
395 in favour of the one from the base class.
396 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
397 Initialize a new Formatting instead of using null by default, so we
398 have some defaults, instead of having to initialize one later just to
399 get the same defaults. This also makes loading of formatting from the
400 document work, because that expected a non-null.
402 2012-05-07 Murray Cumming <murrayc@murrayc.com>
404 RelatedListTable: Make sure that the tableName is set.
406 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
407 Constructor: Take the tableName so it is available later. Otherwise,
408 the server assumes that we mean the default table and cannot find the
410 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
411 setData(): Pass the tableName to the RelatedListTable constructor.
413 2012-05-07 Murray Cumming <murrayc@murrayc.com>
417 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
418 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
419 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
421 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
423 * src/main/java/org/glom/web/server/database/DBAccess.java:
424 convertResultSetToDTO(), getPortal():
425 * src/main/java/org/glom/web/server/database/ListDBAccess.java
427 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
428 Add checks for null objects and out of range access, with log messages to
429 give hints so we can fix these properly.
431 2012-05-07 Murray Cumming <murrayc@murrayc.com>
433 Portals: some corrections.
435 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
437 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
438 constructor: Use getRelationshipNameUsed() instead of getName(), because
439 that is what is meant.
440 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
441 getFromField(): Fix a typo, to get the field name, not the table name.
442 * src/main/java/org/glom/web/server/database/DBAccess.java:
443 getPortal(): Fix a typo that stopped this from working.
445 2012-05-07 Murray Cumming <murrayc@murrayc.com>
447 LayoutItemPortal: Also override getTitleOriginal().
449 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
450 This lets the base getTitle() with no parameters work.
451 TODO: Test this properly.
453 2012-05-06 Murray Cumming <murrayc@murrayc.com>
455 LayoutItemPortal: getTitle*(): Use the relationship title.
457 2012-05-06 Murray Cumming <murrayc@murrayc.com>
459 LayoutItemField: Fix loading of custom titles.
461 * src/main/java/org/glom/web/server/libglom/Document.java
462 loadDataLayoutItemField(): The title, if any, instead of the field
463 title, is stored in a title_custom node. Load it from there.
464 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
466 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
467 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
468 getTitle*() overrides.
469 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
472 2012-05-06 Murray Cumming <murrayc@murrayc.com>
474 LayoutItemField: Fall back to field titles, so some are really shown.
476 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
477 Override getTitleOriginal() and getTitle(), as in java-libglom.
478 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
481 2012-05-06 Murray Cumming <murrayc@murrayc.com>
483 Correct use of setExpectedResultSize().
485 * src/main/java/org/glom/web/server/ConfiguredDocument.java
486 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
487 Use setExpectedResultSize only on top-level groups (for instance, the
488 list layout) or on child portals (in details views).
489 Use the correct table name for portals to avoid SQL errors.
490 Update the expected counts when returning cached layouts.
492 2012-05-06 Murray Cumming <murrayc@murrayc.com>
494 Document: Interpret no group column count as 1.
496 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
497 default, though we now check for this in the UI code anyway.
499 2012-05-06 Murray Cumming <murrayc@murrayc.com>
503 2012-05-06 Murray Cumming <murrayc@murrayc.com>
505 Translatable: Use Hashmap instead of Treemap because GWT supports it.
507 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
508 The use of Treemap lead to this error from async methods, with no
510 "The response could not be deserialized"
512 2012-05-06 Murray Cumming <murrayc@murrayc.com>
514 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
516 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
517 when using the Google -> GWT Compile, or
518 g toolbar button -> GWT Compile Project... feature in Eclipse.
520 2012-05-06 Murray Cumming <murrayc@murrayc.com>
522 ListTable.addColumn(): Protect against a null Formatting.
524 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
525 Create a default Formatting if it is null, because that is the simplest
528 2012-05-06 Murray Cumming <murrayc@murrayc.com>
530 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
532 * src/main/java/org/glom/web/server/ConfiguredDocument.java
533 updateLayoutGroup(): Check that the field is not null.
535 2012-05-06 Murray Cumming <murrayc@murrayc.com>
537 ListViewImpl: Protected against a bad cast error.
539 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
540 onEnterKeyDown(): Do not cast without an instanceof check.
542 2012-05-06 Murray Cumming <murrayc@murrayc.com>
544 ListTable: Protect against an out of range error.
546 * src/main/java/org/glom/web/client/ui/list/ListTable.java
547 createCellTable(): This is unlikely, but can happen while debugging.
549 2012-05-06 Murray Cumming <murrayc@murrayc.com>
551 AsyncMessage onFailure() callbacks: Log the exception message.
553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
554 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
555 * src/main/java/org/glom/web/client/activity/ListActivity.java:
556 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
557 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
558 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
559 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
560 These are useful clues when something is wrong.
562 2012-05-06 Murray Cumming <murrayc@murrayc.com>
564 ConfiguredDocument: Avoid a null dereference.
566 * src/main/java/org/glom/web/server/ConfiguredDocument.java
567 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
568 details maps are created.
570 2012-05-06 Murray Cumming <murrayc@murrayc.com>
572 Document: Correct the port number parsing.
574 * src/main/java/org/glom/web/server/libglom/Document.java:
575 This lets us actually connect to the database and show the document.
577 2012-05-05 Murray Cumming <murrayc@murrayc.com>
581 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
582 user-interaction, asking us to load a temporary URL in a browser.s
583 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
584 which is apparently necessary for testing the service. See the comment.
585 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
586 Show the exception, if any. This is how I saw the 404 in the HTML in
589 2012-05-05 Murray Cumming <murrayc@murrayc.com>
591 DocumentTest: Move the .glom files into the resources directory.
593 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
594 URI via getResource().
596 2012-05-05 Murray Cumming <murrayc@murrayc.com>
598 Document: Remove the FieldIdentifies inner class.
600 * src/main/java/org/glom/web/server/libglom/Document.java: We only
601 use the Relationship (though the same function in libglom is maybe
602 used in other ways) and so this removes a compiler warning.
604 2012-05-05 Murray Cumming <murrayc@murrayc.com>
606 Document.load() Remove the error code parameter.
608 * src/main/java/org/glom/web/server/libglom/Document.java: load():
609 Remove the parameter. We do not set it yet and it could never have
610 worked as an output parameter (though maybe it did in java-libglom).
611 We could use an exception if we really want the failure reason.
612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
614 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
615 setUp(), testGetSuitableTableToViewDetails(): Adapt.
617 2012-05-05 Murray Cumming <murrayc@murrayc.com>
619 Make some inner classes static.
621 * src/main/java/org/glom/web/server/ConfiguredDocument.java
622 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
623 * src/main/java/org/glom/web/server/ReportGenerator.java
624 * src/main/java/org/glom/web/server/libglom/Document.java
625 Make all inner classes static that can be static.
627 2012-05-05 Murray Cumming <murrayc@murrayc.com>
629 OnlineGlomServiceImpl: Do not load and check for java-libglom.
631 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
632 init(): We do not use java-libglom any more.
634 2012-05-05 Murray Cumming <murrayc@murrayc.com>
636 Remove mentions of java-libglom.
638 * README: Remove mention of java-libglom, because it no longer needed.
639 * utils/build-onlineglom-war.sh:
640 * utils/check-and-recover-tomcat.py:
641 * utils/install-onlineglom-war.sh: Remove these as they are no longer
642 useful. Building is now far easier, with no need for jhbuild.
644 2012-05-05 Murray Cumming <murrayc@murrayc.com>
646 Fix the build (mvn package)
648 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
649 (LayoutGroup): Make the LayoutItemList inner class static and protected.
650 Otherwise the GWT Java->Javascript compilation fails with just this
651 error, during mvn package or when attempting to view in a browser,
652 in the GWT developer mode in Eclipse.
654 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
655 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
656 [INFO] Compiling module org.glom.web.OnlineGlom
657 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
658 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
659 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
660 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
661 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
662 [INFO] [ERROR] Cannot proceed due to previous errors
664 It has taken me 2 days to find out what was causing that. After reducing
665 the code, the compiler eventually showed me the full error message.
667 2012-05-04 Murray Cumming <murrayc@murrayc.com>
669 ConfiguredDocument: Cache the cloned and stripped layouts.
671 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
672 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
673 layout in a map, so we can retrieve it again without rebuilding it.
675 2012-05-04 Murray Cumming <murrayc@murrayc.com>
677 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
679 2012-05-04 Murray Cumming <murrayc@murrayc.com>
681 libglom classes: Implement some auto-generated emthods.
683 2012-05-04 Murray Cumming <murrayc@murrayc.com>
685 Add GwtTestOnlineGlomService.
687 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
688 However, this (and the other GwtTest*) does not seem to run during
691 2012-05-04 Murray Cumming <murrayc@murrayc.com>
693 Remove use of unsupported features from client code.
695 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
696 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
697 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
698 Use our client version of StringUtils instead of the apache commons one.
700 However, the GWT Javascript compliation still fails.
702 2012-04-25 Murray Cumming <murrayc@murrayc.com>
704 Add a Field class and implement some loading of it in Document.
706 2012-04-25 Murray Cumming <murrayc@murrayc.com>
708 Initial Document loading implementation, instead of libglom.
710 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
711 and Translatable classes, and adapt the rest of the code to use them.
712 However, this is still missing Layout and Field classes and loading.
714 2012-04-24 Murray Cumming <murrayc@murrayc.com>
716 Use of jOOQ: Move Field creation into a utility method.
718 * src/main/java/org/glom/web/server/SqlUtils.java:
719 This lets us improve it more easily.
721 2012-04-24 Murray Cumming <murrayc@murrayc.com>
723 Use of jOOQ: Improve the code to COUNT a sub-select.
725 * src/main/java/org/glom/web/server/SqlUtils.java:
726 Move initial query creation into
727 build_sql_select_step_with_where_clause().
728 build_sql_select_count_rows(): Use the jOOQ API instead of
729 concatentating text, because a jOOQ Select*Step is a TableLike,
730 which is what from() takes.
732 2012-04-23 Murray Cumming <murrayc@murrayc.com>
734 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
736 * pom.xml: Depend on jooq.
737 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
738 methods with jOOQ, based on the C++ implementations in libglom,
739 with some changes to the logic required by jooQ.
740 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
742 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
743 * src/main/java/org/glom/web/server/ReportGenerator.java:
744 * src/main/java/org/glom/web/server/SqlUtils.java:
745 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
746 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
747 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
748 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
749 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
750 Adapt. In particular, the SqlUtils methods now need to take a Connection,
751 because jOOQ needs that, though it seems unnecessary.
753 This is not quite finished. Ideally jOOQ would help us to build
754 table_name.field_name names, quoting and escaping them properly.
755 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
757 2012-04-21 Murray Cumming <murrayc@murrayc.com>
759 Move use of Glom.build_sql*() into a new SqlUtils class.
761 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
762 to wrap Glom.build_sql*(). The parameter types are still Glom one,
763 but this will make it easier to start using something other than
764 libglom or SqlBuilder.
766 2012-04-21 Murray Cumming <murrayc@murrayc.com>
768 Update the project URL.
770 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
772 2012-04-21 Murray Cumming <murrayc@murrayc.com>
774 Main layout: Use a FlowTable instead of absolute positioning.
776 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
777 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
778 child panels/widgets must have an absolute position. But that is annoying, so
779 this adds a FlowTable and puts the child panels in there.
781 2012-04-21 Murray Cumming <murrayc@murrayc.com>
783 GwtTestOnlineGlom: Comment out unused code.
785 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
786 Eclipse has started to say that some code is unused.
788 2012-04-21 Murray Cumming <murrayc@murrayc.com>
790 Update to the latest versions of dependencies.
792 * pom.xml: Update version numbers of dependencies to the latest
794 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
796 * src/main/java/org/glom/web/server/ReportGenerator.java:
797 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
798 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
799 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
801 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
802 Modify the imports where necessary.
804 2012-04-17 Murray Cumming <murrayc@murrayc.com>
806 Style: Remove overflow:hidden from searchbox
808 * src/main/webapp/style.css: Because this pushes the Back To Link
809 label/link on to the next row, which is then hidden due to the
810 hard-coded (in ems) height.
812 2012-04-20 Murray Cumming <murrayc@murrayc.com>
814 Remove some duplicate code.
816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
817 getDocumentInfo(): This must have been duplicated during the merge from the
822 2012-04-19 Murray Cumming <murrayc@murrayc.com>
824 Reports: Localize the waiting for report message.
826 * src/main/java/org/glom/web/client/activity/ReportActivity.java
827 start(): Get the message from the contants.
828 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
830 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
831 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
832 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
833 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
834 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
835 Update these files with the English text for newer strings for now.
837 2012-04-19 Murray Cumming <murrayc@murrayc.com>
839 Reports: Show a message while waiting for the report.
841 * src/main/java/org/glom/web/client/ui/ReportView.java
842 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
843 Add setWaitingText(), to show a message saying that we are
844 waiting for the report to be ready.
845 * src/main/java/org/glom/web/client/activity/ReportActivity.java
846 start(): Call setWaitingText() before calling the async
849 2012-04-19 Murray Cumming <murrayc@murrayc.com>
851 ReportGenerator: Specify date and time formats.
853 * src/main/java/org/glom/web/server/ReportGenerator.java:
854 createFieldValueElement(): Use the default (and localized)
855 short formats, though we still need a way to show 4-digit
856 years without providing the format for every locale.
857 * src/main/java/org/glom/web/server/database/DBAccess.java:
858 convertResultSetToDTO(): Use the short formats here too.
860 2012-04-18 Murray Cumming <murrayc@murrayc.com>
862 ReportGenerator: Use the correct numeric formatting.
864 * src/main/java/org/glom/web/server/ReportGenerator.java
865 createFieldExpression(), createFieldValueElement(): Take the
866 whole LayoutItem_Field instead of just the field name, so
867 we have access to the formatting.
868 createFieldValueElement(): Use JRTextField.setPattern() to
869 specify the numeric formatting, with the help of a
870 regular DecimalFormat.
872 2012-04-18 Murray Cumming <murrayc@murrayc.com>
874 ReportGenerator: Avoid showing null for group by titles.
876 * src/main/java/org/glom/web/server/ReportGenerator.java
877 generateReport(): Use setBlankWhenNull() on the field title
878 style too, because this is used for values in group by
881 2012-04-18 Murray Cumming <murrayc@murrayc.com>
883 ReportGenerator: Add a colon to titles in vertical groups.
885 * src/main/java/org/glom/web/server/ReportGenerator.java
886 addFieldToDetailBandVertical(): Pass true for the withColon
889 2012-04-18 Murray Cumming <murrayc@murrayc.com>
891 ReportGenerator: Simplify the code by using Position more.
893 2012-04-18 Murray Cumming <murrayc@murrayc.com>
895 Reports: Support vertical groups, roughly.
897 * src/main/java/org/glom/web/server/ReportGenerator.java:
898 addToReport(): Rename to addGroupToReport() and, if necessary,
899 call the new addVerticalGroupToReport() method.
900 createFieldValueElement(): Let the caller specify the Y position
903 2012-04-17 Murray Cumming <murrayc@murrayc.com>
905 Reports: Allow a second report to be shown.
907 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
908 clear(): Do not remove the HTML widget, which broke the whole layout.
910 2012-04-17 Murray Cumming <murrayc@murrayc.com>
912 Locales drop-down: Show that we use English by default.
914 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
915 fillView(): When we use English, just because that is the default, when
916 no locale is specified, show that in the Locales drop-down instead of
917 just showing the first item.
919 2012-04-17 Murray Cumming <murrayc@murrayc.com>
921 Unselect the Report/Locale/Table combo item when appropriate.
923 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
924 setPlace(): clear reportName if this is not a ReportPlace.
925 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
926 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
927 When the provided name is empty, unselect all items, so that none are
928 indicated. This uses a for loop because I cannot find a single method
931 2012-04-17 Murray Cumming <murrayc@murrayc.com>
933 Report: Give the user a way to get back to the list.
935 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
936 start(), setPlace(): Show the Back To List link on reports, and also
937 interpret selecting the empty report item as back to list.
939 2012-04-13 Murray Cumming <murrayc@murrayc.com>
941 Really show the selected Report name.
943 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
944 setPlace(): Store the reportName here, if it is that kind of Place.
945 fillView(): Set the selected Report after filling the list of reports.
946 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
947 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
948 null Strings, though we need some way to unselect all ListBox items
951 2012-04-13 Murray Cumming <murrayc@murrayc.com>
953 ReportGenerator: Try to avoid some problems.
955 * src/main/java/org/glom/web/server/ReportGenerator.java
956 addField(): Try to avoid duplicates, and avoid using a null
959 2012-04-13 Murray Cumming <murrayc@murrayc.com>
961 Reports: Use quickFind.
963 * src/main/java/org/glom/web/client/OnlineGlomService.java;
964 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
966 getReportHTML(): Add a quickFind parameter.
967 * src/main/java/org/glom/web/client/activity/ReportActivity.java
968 start(): Pass the quickFind parameter.
969 * src/main/java/org/glom/web/server/ReportGenerator.java
970 generateReport(): Take a quickFind parameter.
972 2012-04-13 Murray Cumming <murrayc@murrayc.com>
974 ReportPlace: Actually use the report name.
976 * src/main/java/org/glom/web/client/place/ReportPlace.java
977 getPlace(): Do not assign the report name to the quickfind.
979 2012-04-13 Murray Cumming <murrayc@murrayc.com>
981 Show java.library.path when complaining.
983 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
984 init(): When telling us to check java.library.path, show the
987 2012-03-06 Murray Cumming <murrayc@murrayc.com>
989 ReportGenerator: Do not show nulls.
991 2012-03-06 Murray Cumming <murrayc@murrayc.com>
993 ReportGenerator: Make the title font larger.
995 2012-03-06 Murray Cumming <murrayc@murrayc.com>
997 ReportGenerator: Put field titles inside groups, if there are groups.
999 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1001 ReportGenerator: Take the Report itself instead of the name and group.
1003 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1004 Remove getReportLayoutGroup().
1005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1006 getReportHTML(): Pass the report instead
1007 of its name and layout group.
1008 * src/main/java/org/glom/web/server/ReportGenerator.java
1009 generateReport(): Use the report object to use the title
1010 instead of the name.
1012 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1014 ReportGenerator: Remove designBand parameters.
1016 * src/main/java/org/glom/web/server/ReportGenerator.java:
1017 Make designBand a class member instead of passing it to all
1020 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1022 ReportGenerator: Add lines, a bit like in the desktop version.
1024 * src/main/java/org/glom/web/server/ReportGenerator.java
1025 addToReport(): Use JRDesignLine.
1027 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1029 ReportGenerator: Correct the title positions and use some bold style.
1031 * src/main/java/org/glom/web/server/ReportGenerator.java:
1032 Break the code up into reusable functions, correct the placement of
1033 titles, and use normal/bold styles as in the reports in the desktop
1036 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1038 ReportGenerator: Add a header band to show the field titles.
1040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1041 getReportHTML(): Pass the localeId to the ReportGenerator
1043 * src/main/java/org/glom/web/server/ReportGenerator.java
1044 constructor: Take the localeID so we can get translated field
1046 generateReport(), addToReport(), addFieldToBand(): Add field
1047 titles in a column header band.
1049 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1051 Reports drop-down list: Some improvement.
1053 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1054 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1055 Adedd setSelectedReport(),
1056 setReportList(): Add a blank line so that the user can select the
1058 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1059 start(): Show the current report by calling setSelectedReport().
1060 This does not seem to work yet.
1062 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1064 DetailsActivity, ListActivity: Move some variables into a base class.
1066 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1067 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1068 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1069 the clientFactory, documentID, tableName and authenticationPopup into
1070 a base class, to avoid duplication.
1072 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1074 Translate the Reports label.
1076 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1077 Get the "Reports" label string from the constants.
1078 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1079 perties: Add Reports to the constants.
1081 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1083 Reports: Implement grouping.
1085 * src/main/java/org/glom/web/server/ReportGenerator.java:
1086 Handle LayoutItem_GroupBy items and try to do the right thing
1087 with JRDesignGroup. It seems to work.
1089 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1091 Actually show some data with JasperReports.
1093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1094 getReportHTML(): Move most code into a ReportGenerator class.
1095 * src/main/java/org/glom/web/server/ReportGenerator.java:
1096 Recurse into sub-groups, adding fields to the JasperDesign's details
1097 band. Note that we must set an arbitrary width and height, or it just
1098 will not show any data.
1100 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1102 Reports Chooser: Show the titles, not the names.
1104 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1105 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1106 and the names as the values.
1107 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1108 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1109 group now that we provide the report name, so it should always
1112 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1114 Depend on jasperreports.
1116 * pom.xml: Add the dependency. My plan is to use this on the
1119 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1121 Implement navigation to report places.
1123 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1124 start(): Do not bother to handle all events here.
1125 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1126 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1127 Added getSelectedReport().
1128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1129 .java: start(): When handling a change to the reports chooser,
1130 call getSelectedReport() and goTo() its ReportPlace.
1131 * src/main/java/org/glom/web/client/ui/ReportView.java
1132 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1133 Added setReportHTML() which puts the html in a gwt HTML widget.
1134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1135 getReportHTML(): Return "TODO" just to show that this works.
1137 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1139 Make ReportPlace usable.
1141 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1142 Mention ReportPlace.
1143 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1144 Correct the @prefix annotation.
1146 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1148 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1150 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1153 Change getReportLayout() to getReportHMTL() because we will not need to
1154 parse or render the report layout on the client side.
1155 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1156 getReportLayout(): Return the libglom LayoutGroup type because we will
1157 not need to convert to a shared type, because this will not be used on
1159 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1162 Note that there is still no implementation for this.
1165 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1167 Add a (empty) Report Place, View, and Activity.
1169 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1171 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1172 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1173 this into a superclass:
1174 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1175 and also use it as the base of this new ReportPlace:
1176 * src/main/java/org/glom/web/client/place/ReportPlace.java
1178 * src/main/java/org/glom/web/client/ui/ReportView.java
1179 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1180 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1181 Add these, containing mostly boiler-plate for now.
1183 * src/main/java/org/glom/web/client/OnlineGlomService.java
1184 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1185 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1187 Add API to get the LayoutGroup for the report.
1189 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1191 Add and fill a Reports drop-down list box.
1193 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1195 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1196 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1198 Added getReports(document, table, localeID), calling
1199 ConfiguredDocument.getReports().
1200 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1201 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1202 Added setReportsList() and a list widget.
1203 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1204 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1209 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1211 Translations: Add Esperanto.
1213 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1214 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1215 properties: Add this translation because someone took the time to make it.
1217 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1219 Adapt to the java-libglom 1.21.7 API.
1221 * src/main/java/org/glom/web/server/ReportGenerator.java:
1222 addToReport(): get_group_secondary_fields() is now
1223 get_secondary_fields().
1226 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1228 Use the latest java-libglom version.
1230 * pom.xml: Use java-libglom 1.21.7.
1232 2012-03-03 Ben Konrath <ben@bagu.org>
1234 Display date and time in details view.
1236 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1238 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1240 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1242 Require the latest java-libglom.
1244 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1246 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1248 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1250 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1251 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1252 an empty quickfind string. I also corrected libglom to create only
1253 empty where clauses for empty quickfind strings, but this avoids the
1256 2012-02-24 Ben Konrath <ben@bagu.org>
1258 Improve the tabs in the Notebook widget.
1262 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1264 Translations: Try to translate the strings.
1266 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1267 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1268 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1269 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1270 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1271 Take the Open translation from GTK+'s .po files.
1272 Take the Details translation from Glom's po files.
1273 I have added the other strings to Glom so we can get translations that way:
1274 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1276 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1278 TableSelectionViewImpl: Put the search label and entry in a div.
1280 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1281 Put the search widgets in a FlowTable so that the CSS can be used to
1282 style them while keeping them together.
1283 * src/main/webapp/style.css: Mention the new div.
1285 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1287 Translate more strings in more locales.
1289 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1290 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1291 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1292 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1293 Translate the "Details" and "Open" string too.
1295 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1296 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1297 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1298 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1299 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1300 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1301 Add these new locales as placeholders though they currently contain English.
1303 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1305 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1307 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1308 Check the ConfiguredDocument* for null before using it.
1310 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1312 Tell Eclipse about the generated java files.
1314 * .classpath: This lets it find OnlineGlomConstants.java.
1315 It would be nice if Eclipse just used the maven build files.
1317 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1319 Prevent a crash when no locale is specified in the URL.
1321 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1322 Avoid returning a null string, obtained from
1323 Window.Location.getParameter(). This caused a crash when it was
1324 later passed to libglom's API.
1325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1326 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1327 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1328 guard against future null strings.
1330 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1332 Use the ?locale= query param instead of the &lang= token param.
1334 * src/main/java/org/glom/web/client/place/ListPlace.java
1335 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1336 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1337 Remove the lang token key and value.
1339 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1340 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1341 When the user selects a different locale from the chooser, use
1342 Window.Location.assign() to change the URL, which then causes a reload.
1344 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1345 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1346 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1347 * src/main/java/org/glom/web/client/activity/ListActivity.java
1348 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1349 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1350 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1351 * src/main/java/org/glom/web/client/ui/ListView.java:
1352 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1354 Remove localeID member variables and method/constructor parameters, instead
1355 using Utils.getCurrentLocaleID() when we need a localID to pass to
1358 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1360 Internationalize the UI strings.
1362 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1363 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1364 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1365 because it is unused. Messages are apparently strings that can have
1366 parameters, but we do not need that yet, so Contants will be enough for now.
1367 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1368 to say that we support the en and de locales.
1369 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1370 The original English strings.
1371 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1372 Some German translations of the English strings.
1373 The i18n goal then uses the .properties file to generate an
1374 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1375 returns an implementation that returns the translated strings.
1376 The documentation suggests putting these in src/java/*/client/, but it seems
1377 best to put it in src/resources/*/client/.
1378 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1379 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1380 instead of hard-coding them.
1381 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1382 but that does not seem to stop the build, though it confuses Eclipse.
1384 You can see the translated string by adding ?locale=de to the URL, like so:
1385 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1387 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1389 Improve null/empty String checks.
1391 * pom.xml: Add a dependency on commons-lang, to use
1392 org.apache.commons.lang.StringUtils.
1393 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1395 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1396 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1397 Use StringUtils.isEmpty().
1399 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1400 StringUtils class with a static isEmpty() function because we
1401 cannot use org.apache.commons.lang.StringUtils in client-side
1402 GWT code because it (apparently) cannot be compiled to javascript.
1403 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1404 * src/main/java/org/glom/web/client/activity/ListActivity.java
1405 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1406 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1407 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1408 * src/main/java/org/glom/web/client/place/ListPlace.java
1409 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1410 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1411 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1412 * src/main/java/org/glom/web/client/ui/details/Group.java
1413 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1414 our StringUtils.isEmpty() function.
1416 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1418 Update to the latest java-libglom API.
1420 * pom.xml: Require java-libglom 1.21.4.
1421 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1422 getDocumentInfo(), getListViewLayoutGroup():
1423 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1425 * src/main/java/org/glom/web/server/database/DBAccess.java
1426 getFieldsToShowForSQLQueryAddGroup(),
1427 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1428 with either get_database_title_original() or
1429 get_database_title(localeID).
1431 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1433 ConfiguredDocument: Avoid a null pointer exception.
1435 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1436 Initialize localeID to "" to avoid returning a null String which
1437 causes a crash in java-libglom's swing-generated code.
1439 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1441 Some simple renaming.
1443 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1444 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1445 for localeChooser. This seems more appropriate and is less ambiguous
1446 particularly in the .css file.
1448 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1450 ConfiguredDocument: Rename the localedID private member variable.
1452 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1454 Adapt to the latest java-libglom API from git master.
1456 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1457 libglom now uses only Vector instead of List, which uses add() instead of
1460 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1462 ConfiguredDocument: Rename the localedID private member variable.
1464 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1466 Build a source tarball with mvn assembly:single
1468 * assembly.xml: Add this file.
1469 * pom.xml: Use the maven-assembly-plugin and tell it to use
1470 our assembly.xml file.
1472 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1474 OnlineGlomServiceImpl: Get .glom files recursively.
1476 * pom.xml: Depend on commons-io from org.apache.commons.
1477 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1478 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1479 files recursively, and with the easier filter for the extension.
1480 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1481 simplify that code too.
1483 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1485 README: Mention that you must install java-libglom packages separately.
1487 But then it works, because java-libglom is now in the central maven
1490 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1492 locales drop-down: Show the correct selected locale when the URL changes.
1494 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1495 .java: setPlace(): Move some code into fillView().
1497 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1499 locales drop-down: Do not lose the primary key.
1501 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1502 start(): onLocaleChange(): Pass the current primary key value,
1503 instead of an empty value.
1505 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1507 locales drop-down: Do not lose the drop-down selection.
1509 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1510 .java (TableSelectionActivity.fillView): Set the selected locale
1511 after changing the drop-down items (though we do not really need
1512 to change them just because the locale changes.)
1514 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1516 locales drop-down: Change the tables list when this changes.
1518 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1519 .java: TableSelectionActivity.start(): Move the async table titles
1520 retrieval into a private fillView() method and also call this when
1521 the chosen locale changes.
1522 Note that the document title is not actually translatable yet, but
1523 that is a problem that I should fix soon in libglom.
1525 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1527 Improve the placement of the locales drop-down.
1529 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1530 Put the title and locales drop-down in a div (gwt.FlowTable).
1531 * src/main/webapp/style.css: Add magic css properties to make this work.
1532 Also remove the left margin from the title so that it lines up with the
1535 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1537 locales selector: Show human-readable locale titles.
1539 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1540 getDocumentInfo(): Use java.util.Locale to show a real title of
1541 each locale, in the locale's own language.
1543 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1545 Add a language/locale selector drop-down.
1547 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1548 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1549 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1550 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1551 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1552 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1553 Add a ListBox to show the available locales. Add getLocaleSelector(),
1554 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1555 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1556 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1557 java: Add these classes.
1558 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1559 start(): Fill the locales ListBox. Handle its change event, firing a
1561 setPlace(): Show the selected locale as specified by the URL token.
1562 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1563 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1564 Handle LocaleChangeEvent, going to a new *Place with that locale.
1566 The placement of the ListBox is not pretty, and it currently uses the ID
1567 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1571 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1573 Search box: Show the search text from the URL token.
1575 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1576 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1577 Add setQuickFindText().
1578 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1579 .java: setPlace(): Store the queryText if the place is a ListPlace,
1580 and call TableSelectionView.setQuickFindText().
1582 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1584 Allow use of translations via, for instance, &lang=de in the URL.
1586 * pom.xml: Use the unstable java-libglom 1.21 version.
1588 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1589 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1591 init(): Instead of calling TranslatableItem.set_current_locale()
1592 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1593 However, this is only for default locales, which are not needed to
1594 change the locale in the URL.
1595 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1596 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1597 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1598 layout for a particular locale.
1599 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1600 Add get/setDefaultLocaleID().
1601 getDocumentInfo(), getListViewData(), getRelatedListData(),
1602 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1603 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1604 localeID parameter, so we can get the layout for a particular locale.
1606 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1607 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1608 * src/main/java/org/glom/web/client/place/ListPlace.java:
1609 Parse and construct a lang parameter too.
1611 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1612 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1613 passed to subsequent methods and constructors.
1614 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1615 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1616 Store the localeID from the *Place and pass it to other constructors
1617 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1619 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1620 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1621 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1622 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1623 * src/main/java/org/glom/web/client/ui/ListView.java:
1624 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1625 Take localeID parameters and pass them to subsequent constructors and
1626 methods, so that the layout is always retrieved for that locale.
1628 This is rather repetitive.
1630 Note that "" means the original (default) locale of the Glom document,
1631 which is usually English.
1633 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1635 Documents: Remove final keyword to fix startup configuration.
1637 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1638 final keywords on the private member variables because that breaks
1639 the startup, apparently (there are warnings) because it stops them
1640 from being serialized. I added these in the previous commit.
1642 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1644 Documents: Add some final keywords.
1646 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1649 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1651 OnlineGlomServiceImpl: Add to overview comments.
1653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1654 Note that this is where all the document are loaded. They are not
1655 loaded freshly for each page.
1657 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1661 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1662 Add a TextBox for the text of a quick find.
1663 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1665 setBackLink(): Add a String quickFind parameter.
1666 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1667 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1668 to the base interface, because that is how TableSelectionViewImpl is used.
1669 * src/main/webapp/style.css: Add style for the search box and its label.
1671 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1672 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1673 Add these files, based on the existing TableChangeEvent and
1674 TableChangeEventHandlers.
1675 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1676 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1677 a ListPlace() that the user should be taken to.
1678 * src/main/java/org/glom/web/client/activity/ListActivity.java
1679 start(): Handle it here too and adapt the TableChangeEvent handler to
1680 pass the extra "" quickFind parameter to ListPlace.
1681 * src/main/java/org/glom/web/client/place/ListPlace.java:
1682 Constructor: Take an extra String quickFind parameter and store it,
1683 returning it from a new getQuickFind() method.
1684 getToken(): Put the quickFind text in the URL token.
1685 getPlace(): Parse the quickFind text from the URL token.
1686 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1687 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1688 ListPlace constructor.
1689 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1690 .java: start(): Add a Change handler for the TableSelectionView's
1691 TextBox (via its base HasChangeHandlers interface), firing the new
1692 QuickFindChangeEvent.
1693 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1694 pass the extra "" quickFind parameter.
1696 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1697 setCellTable(): Add a String quickFind parameter and pass it to
1698 the ListViewTable() constructor.
1699 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1700 setCellTable() in the base interface, because that is how ListViewImpl
1703 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1704 Add a String quickFind member variable.
1705 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1706 Constructor: Add a String quickFind parameter, storing it in the
1707 base ListTable's member variable.
1708 onRangeChanged(): Pass quickFind to the
1709 OnlineGlomServiceAsync.getSortedListViewData() and
1710 OnlineGlomServiceAsync.getListViewData() methods.
1712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1713 getListViewData(), getSortedListViewData(): Add a String quickFind
1714 parameter, passing it to ConfiguredDocument.getListViewData().
1715 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1716 Change getListViewData(), getSortedListViewData() in the base interface,
1717 because that is how OnlineGlomServiceImpl is used, via this:
1718 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1719 Change getListViewData(), getSortedListViewData() here too.
1720 This class can apparently be used to asynchronously call methods on
1721 OnlineGlomService, and GWT seems to implement that after recognizing
1722 just the *Async name convention and the extra AsyncCallback parameters.
1724 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1725 getListViewData(): Add a String quickFind parameter, and pass it to
1726 ListViewDBAccess.getData().
1727 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1728 getListData(): Add a String quickFind parameter and pass it to
1730 getSelectQuery(): Add a String quickFind parameter.
1731 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1732 getSelectQuery(): Add a String quickFind parameter and use it with
1733 Glom.get_find_where_clause_quick() to pass a where_clause to
1734 Glom.build_sql_select_with_where_clause(), to actually filter the
1736 getData(): Add a String quickFind parameter, passing it to getListData().
1737 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1738 va: getData(): Pass an empty string to getListData() for the
1739 quickFind parameter.
1741 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1743 ListTable: Minor change.
1745 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1746 createCellTable(): Make this protected instead of public.
1748 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1750 Many files: Use final for the parameters and use the @override attribute.
1752 2012-01-22 Ben Konrath <ben@bagu.org>
1754 Add anchor links for single line text that starts with http, ftp and www.
1758 2012-01-22 Ben Konrath <ben@bagu.org>
1760 Add ellipsis to single line text in details view.
1764 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1766 Remove all javadoc author tags.
1768 Because they are awkward and meaningless when many people touch
1770 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1772 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1774 Revert the COPYING.LESSER to COPYING rename.
1776 Apparently both should be there if it is LGPL.
1778 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1780 *View: Remove unused imports.
1782 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1783 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1784 * src/main/java/org/glom/web/client/ui/ListView.java:
1785 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1786 Remove unused imports, as suggested by Eclipse.
1788 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1790 Move the *View::Presenter types, and some API into one base View.
1792 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1793 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1794 * src/main/java/org/glom/web/client/ui/ListView.java:
1795 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1796 Presenter, setPresenter() and clear() into a shared base interface,
1797 to avoid the unnecessary duplicate Presenter types and to more clearly
1798 show how the *Views share the same structure, even if they are not
1799 used polymorphically.
1801 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1802 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1804 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1805 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1806 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1808 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1811 Feel free to revert this if there is a good reason for the duplicate
1814 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1816 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1818 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1819 a class member instead of a local variable in the method.
1820 This lets us use it to get the view instances, for use in tests.
1821 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1822 beforeOnlineGlom(): Test some more details of the initial view.
1823 Again, this is not very useful.
1825 To really test gwt-glom we will need to start a local postgresql
1826 instance with local data, like the Glom tests in C++.
1828 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1830 pom.xml: Mention the LGPL license.
1832 * pom.xml: Add a licenses section.
1833 * COPYING.LESSER: Move this to COPYING, which
1834 previously contained the GPL. But gwt-glom is all LGPL.
1836 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1838 Add project information to README and pom.xml.
1840 * README: Add a brief description and mention some mvn
1842 * pom.xml: This extra information shows up in mvn site
1845 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1847 Use the latest java-libglom version.
1849 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1851 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1853 GwtTestOnlineGlom: Test a little more.
1855 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1856 protected rather than private, as suggested by the gwt-test-utils
1858 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1859 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1860 Test the initial visibility of the panels.
1862 However, this is not a very useful test.
1863 And I wonder how we should generally test using this idea for an
1864 activity/places app like ours where the real changes happen implicitly
1865 based on the history token/URL.
1867 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1869 Slight modification to *Mapper comments.
1871 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1872 (DataActivityMapper)
1873 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1875 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1877 Remove comments mentioning GIN because they are just copied from
1878 the example code and are apparently not helpful:
1879 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1880 Also change the mention of a class that is only in the example code.
1882 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1884 GwtTestOnlineGlom test: Minor changes.
1886 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1887 Avoid the long qualified class name and modify the comment
1888 because it is now obvious to me that the mocked class is the only
1889 custom one created via GWT.create().
1891 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1893 Tests: Added the beginnings of a test using gwt-test-utils.
1895 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1896 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1897 which tells gwt-test-utils what class will be tested.
1898 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1899 Add a simple (but empty) test case. One class, used by the OnlineGlom
1900 class, is mocked so that it can be created. However, I am not sure
1901 why only this class needs to be mocked.
1903 Note that mockito seems more popular, and clearer, than easymock,
1904 but I have not got that working yet. It might be a matter of the
1907 This test is run during mvn integration-test.
1909 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1911 Tests: Use junit4-style syntax instead of junit3-style.
1913 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1914 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1915 * src/test/java/org/glom/web/shared/DataItemTest.java:
1916 Use the @Test annotation rather than relying on the test*() prefix.
1917 Also no longer implement TestCase, to avoid triggering support for
1918 the junit3-way, which stops the annotations from working.
1919 Change the imports from import junit.framework.* to
1920 import org.junit.*, which is apparently the new way.
1922 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1924 Added a test for ListPlace token parsing and creation.
1926 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1927 This is much the same as DetailsPlaceTest.
1929 I wonder how we could test the other parts of the *Place API.
1931 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1933 DetailsPlace test: Also test getToken() and recreation via getPlace().
1935 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1936 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1937 recreate it, testing the recreated DetailsPlace for the same parameter
1940 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1942 Use the surefire-report plugin.
1944 * pom.xml: This generates a HTML report about the tests in
1945 target/site/surefire-report.html
1946 when you do mvn surefire-report:report. It seems to be popular/normal.
1948 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1950 Added a test for DetailsPlace.
1952 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1953 Test the getPlace() token parsing.
1955 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1957 Added a first unit test.
1959 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1960 * src/test/java/org/glom/web/shared/DataItemTest.java:
1961 This is a silly test but it is just to get things started. Note that
1962 maven/junit finds the test because it looks in src/test by default.
1964 2011-12-22 Ben Konrath <ben@bagu.org>
1966 Change charsetName to "UTF-8" when replacing line breaks.
1968 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1969 that work in Java (such as "UTF8") will not work when compiled to
1972 This fixes a problem with multi-line details view fields that have hard
1973 line breaks. The "License Text" field on this page demonstrates the
1976 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1978 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1980 2011-12-22 Ben Konrath <ben@bagu.org>
1982 Fix another bug with related list navigation.
1984 I've tested all the navigation buttons in all of the related lists
1985 so things should be good now.
1987 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1989 2011-12-22 Ben Konrath <ben@bagu.org>
1991 Fix a crasher when refreshing the list view with the default table.
1993 This crash will also happen when loading the list view with the default
1994 table from a link or bookmark.
1996 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1997 to the main document selection page when the document id hasn't been
1999 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2000 the main document selection page when the document id hasn't been
2002 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2003 values for the details place when the document id hasn't been set.
2004 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2005 values for the list place when the document id hasn't been set.
2007 2011-12-21 Ben Konrath <ben@bagu.org>
2009 Protect against NPE when glom.document.locale is not in config.
2011 This patch protects against an NPE when glom.document.locale is not in
2012 the config file. This NPE will also happen if glom.document.locale is
2015 The patch also updates the error message to display the class name when
2016 the getMessage() returns null. This was happening when the NPE was
2017 thrown and I had "Configuration Error: null". If an NPE is encountered
2018 with this patch, "Configuration Error: NullPointerException " will be
2021 This commit closes this bug:
2023 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2025 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2027 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2029 Rename onlineglom.properties to onlineglom.properties.sample.
2031 * src/main/resources/onlineglom.properties: Rename to:
2032 * src/main/resources/onlineglom.properties.sample:
2033 * src/main/resources/README: And add this file explaining that people
2034 should rename it back when deploying.
2036 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2038 Allow choosing the translation in the .properties file.
2040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2041 init(): Read a glom.document.locale value from the configuration file
2042 and call Glom's TransatableItem::set_current_locale() method.
2043 * src/main/resources/onlineglom.properties: Add a commented-out
2044 example of this new setting.
2046 It would be better to add &lang=de_DE to the URL, but the current
2047 libglom API does not allow us to do this easily. I am working on that.
2049 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2051 Avoid a crash in parsing of token parameters.
2053 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2054 ava: getTokenParams(): Do not crash if a parameter has a key but no
2055 value, and ignore parameters with neither.
2057 2011-12-17 Murray Cumming <murrayc@murayc.com>
2059 History token building/handling: Improve use of token parameters.
2061 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2062 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2063 and buildParamsToken(HashMap), for use by derived classes.
2064 Make the separator private because it is no longer be needed.
2065 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2066 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2067 instead of manual string concatenation.
2068 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2069 of hardcoded indices and awkward splitting code.
2070 * src/main/java/org/glom/web/client/place/ListPlace.java
2071 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2072 instead of manual string concatenation.
2073 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2074 of hardcoded indices and awkward splitting code.
2075 This should fix bug #666420
2077 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2079 Fix a Navgiation->Navigation typo in the code.
2081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2082 Rename processNavgiation() to processNavigation().
2084 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2086 Fix a seperator->separator typo in the code.
2088 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2089 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2090 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2093 2011-12-15 Ben Konrath <ben@bagu.org>
2095 Cleanup some comments.
2097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2099 2011-12-14 Ben Konrath <ben@bagu.org>
2101 Replace \n with <br/> for multiline text in the details view.
2103 Vertical scrollbars are added when needed as well.
2105 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2107 2011-12-14 Ben Konrath <ben@bagu.org>
2109 Specify the font for document selection links.
2111 * src/main/webapp/style.css:
2113 2011-12-14 Ben Konrath <ben@bagu.org>
2115 Fix bouncy CellTable while paging.
2117 This doesn't currently work with related list tables in unselected
2120 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2122 2011-12-14 Ben Konrath <ben@bagu.org>
2124 Revamp the appearance of the document selection page.
2126 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2127 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2128 * src/main/webapp/style.css:
2130 2011-12-13 Ben Konrath <ben@bagu.org>
2132 Set navigation button column to the smallest size possible.
2134 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2136 2011-12-13 Ben Konrath <ben@bagu.org>
2138 Change OpenButton nomenclature to NavigationButton.
2140 Using NavigtionButton makes things more generic. Classes, methods and
2141 variables have been changed.
2143 This is a rename-only refactor.
2145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2146 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2147 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2148 Renamed from OpenButtonCell.
2149 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2150 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2151 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2153 2011-12-12 Ben Konrath <ben@bagu.org>
2155 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2157 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2158 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2159 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2160 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2162 2011-12-12 Ben Konrath <ben@bagu.org>
2164 Update variable names and comments.
2166 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2167 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2169 2011-12-12 Ben Konrath <ben@bagu.org>
2171 Properly initialize numNonEmptyRows variable to zero.
2173 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2174 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2176 2011-12-05 Ben Konrath <ben@bagu.org>
2178 Add latest mockup with HTML tables.
2180 Features of this mockup:
2182 -> HTML table for flowtable
2183 -> HTML table for flowtable column
2184 -> Example of how related lists would look
2185 -> Not using text entries for data items
2187 The current version of Online Glom doesn't use HTML tables for the
2190 This mockup has been sent to the glom-devel mailing list but it's good
2191 to have it here as well.
2193 * mockups/details-view-html-tables.html:
2195 2011-12-05 Ben Konrath <ben@bagu.org>
2197 Remove unnecessary getPrimaryKeyField() method.
2199 getPrimaryKeyFieldForTable(String) has been renamed to
2200 getPrimaryKeyField(String).
2202 * src/main/java/org/glom/web/server/database/DBAccess.java:
2203 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2204 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2206 2011-12-05 Ben Konrath <ben@bagu.org>
2208 Add string representation of TypedDataItem value to conversion error message.
2210 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2211 message was extracted into its own method to avoid duplication.
2213 2011-12-05 Ben Konrath <ben@bagu.org>
2215 Add type checking to navigation primary key value creation.
2217 Create navigation primary key only if the expected type from the Glom
2218 document matches the type returned by the SQL query.
2220 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2222 2011-12-05 Ben Konrath <ben@bagu.org>
2224 Rename a couple of variables in RelatedListNavigation.
2226 This is a rename-only refactor.
2228 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2230 2011-12-05 Ben Konrath <ben@bagu.org>
2232 Move getListLayoutGroup() into getListViewLayoutGroup().
2234 This removes getListLayoutGroup(). It was only being called by
2235 getListViewLayoutGroup().
2237 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2239 2011-12-05 Ben Konrath <ben@bagu.org>
2241 Remove check for LayoutItem_Portal in list table method.
2243 This check is no longer necessary because the method isn't being used
2244 to create the LayoutItemPortal DTO.
2246 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2248 2011-12-05 Ben Konrath <ben@bagu.org>
2250 Properly support related list navigation.
2252 Navigation from the "Repository Analyzer -> Package Scans ->
2253 Dependencies" related table wasn't working because the primary key for
2254 related tables wasn't being set properly. This commit fixes the
2257 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2258 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2259 doesn't set the primary key properly for related list tables.
2260 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2261 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2262 useful for getting the primary key for list view tables and for related
2264 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2265 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2266 Move code to set the primary key for the table from the abstract
2267 ListDBAccess class to ListViewDBAccess as it's only correct for list
2269 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2270 Properly add primary key to related list tables.
2272 2011-12-02 Ben Konrath <ben@bagu.org>
2274 Properly set the horizontal alignment of fields.
2276 This fix is for both the list tables and the details view.
2278 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2279 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2280 to set the horizontal alignment of fields.
2282 2011-12-02 Ben Konrath <ben@bagu.org>
2284 Display currency codes in the details view.
2286 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2288 2011-12-02 Ben Konrath <ben@bagu.org>
2290 Avoid duplicate JNI call.
2292 JNI is not as efficient as pure Java and this is an easy (and small)
2295 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2296 Use previously retrieved value for whereClauseToTableName instead of
2299 2011-12-02 Ben Konrath <ben@bagu.org>
2301 Rename a couple of variables in RelatedListNavigation.
2303 This is a rename-only refactor.
2305 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2307 2011-12-02 Ben Konrath <ben@bagu.org>
2309 Indicate clearly that a mismatched primary key type is a bug.
2311 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2312 warning to error. Add 'This is a bug.' to message.
2314 2011-12-02 Ben Konrath <ben@bagu.org>
2316 Update / fix some comments.
2318 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2320 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2322 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2323 Fix comments. Add some TODOs.
2325 2011-12-02 Ben Konrath <ben@bagu.org>
2327 Enable navigation to details view with string primary key from related list.
2329 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2330 Create a text primary key value when return type of result is
2331 java.sql.Types.VARCHAR.
2333 2011-12-02 Ben Konrath <ben@bagu.org>
2335 Use checkboxes for booleans in the details view.
2337 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2339 2011-12-01 Ben Konrath <ben@bagu.org>
2341 Improve performance of related list height calculation.
2343 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2344 Put code to calculate the expected height in a static initializer so
2345 that that it's only called once.
2347 2011-12-01 Ben Konrath <ben@bagu.org>
2349 Show related list tables in notebooks (again).
2351 Calculate the height of the related list tables so the Notebook can be
2352 set the correct height. The height of the related list table is also needed by
2353 FlowTable to be able decide how to create the layout.
2355 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2356 and set the Portal height based on the height of the related list
2357 table and the Portal container.
2358 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2359 Add method to calculate the height of the related list tables.
2360 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2361 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2362 calculate the height of the Pager widget.
2364 2011-12-01 Ben Konrath <ben@bagu.org>
2366 Use CellTable API for table property instead of setting style on Element.
2368 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2370 2011-12-01 Ben Konrath <ben@bagu.org>
2372 Make ListViewTable and RelatedListTable a consistent height.
2374 The tables are now a consistent height regardless of the contents of
2375 the table. A hidden button is added to empty rows to ensure that the
2376 height of these rows will match the height of rows with data.
2378 A navigation button column is now added to every table. The width of
2379 the navigation column is set to 0px when a RelatedListTable shouldn't
2380 have navigation buttons. This maintains the a consistent row height in
2381 tables that don't show the navigation buttons.
2383 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2384 navigation column when not needed.
2385 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2386 arguments for navigation button to constructor of ListViewTable.
2387 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2388 hidden button for empty data rows.
2389 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2390 arguments for navigation button to constructor.
2391 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2392 create navigation buttons. Add hideNavigationButtons() method.
2393 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2394 arguments for navigation button to constructor.
2396 2011-12-01 Ben Konrath <ben@bagu.org>
2398 Use 'visibility: hidden' in Utils.getWidgetHeight().
2400 This is better choice because hidden elements are invisible, don't
2401 respond to events and are not part of the tab order. They will,
2402 however, take up space which is required to be able to calculate the
2403 height of the widget.
2405 * src/main/java/org/glom/web/client/Utils.java:
2407 2011-12-01 Ben Konrath <ben@bagu.org>
2409 Use Utils.getWidgetHeight() in FlowTable.
2411 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2413 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2415 2011-12-01 Ben Konrath <ben@bagu.org>
2417 Put the details css class name on the correct table column.
2419 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2421 2011-11-30 Ben Konrath <ben@bagu.org>
2423 Update for java-libglom API change.
2425 The getters and setters on FieldFormatting and NumericFormat were
2426 changed to remove the 'M'.
2428 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2430 2011-11-29 Ben Konrath <ben@bagu.org>
2432 Only allow RelatedListTables in Portals.
2434 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2436 2011-11-29 Ben Konrath <ben@bagu.org>
2438 Only create a contents panel for Portals when title is being set.
2440 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2442 2011-11-29 Ben Konrath <ben@bagu.org>
2444 Set TabLayoutPanel height based on calculated height its widgets.
2446 This is a potential fix for this bug:
2448 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2450 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2452 2011-11-29 Ben Konrath <ben@bagu.org>
2454 Align details field labels and data with the Open buttons.
2456 * src/main/webapp/style.css:
2458 2011-11-29 Ben Konrath <ben@bagu.org>
2460 Remove unnecessary <div> in the Notebook widget.
2462 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2463 method to get container FlowPanel (<div>).
2464 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2465 initWidget() method directly on the TabLayoutPanel widget instead of
2466 Group's container widget.
2468 2011-11-29 Ben Konrath <ben@bagu.org>
2470 Don't add group titles for Portals in Notebooks.
2472 This reverts the previous patch and fixes a bug I introduced with
2473 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2475 * src/main/java/org/glom/web/client/ui/details/Group.java:
2476 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2478 2011-11-28 Ben Konrath <ben@bagu.org>
2480 Remove unused boolean argument in Portal constructor.
2482 Just a code cleanup.
2484 * src/main/java/org/glom/web/client/ui/details/Group.java:
2485 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2487 2011-11-28 Ben Konrath <ben@bagu.org>
2489 Remove hack for glom 1.18 style glom files.
2491 * src/main/java/org/glom/web/client/ui/details/Group.java:
2492 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2493 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2495 2011-11-28 Ben Konrath <ben@bagu.org>
2497 Use Gda Value version of primary key to log result too large error.
2499 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2501 2011-11-28 Ben Konrath <ben@bagu.org>
2503 Don't use TypedDataItem.getText() for Unknown types from the URL.
2505 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2506 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2507 instead of getText().
2508 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2509 String field and getUnknown() method.
2511 2011-11-28 Ben Konrath <ben@bagu.org>
2513 Log an error message when the java-libglom .so is not present.
2515 The error message was being set in the exception but not logged.
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2519 2011-11-28 Ben Konrath <ben@bagu.org>
2521 Ignore LayoutItem_CalendarPortals.
2523 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2524 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2526 2011-11-28 Ben Konrath <ben@bagu.org>
2528 Extract method for creating the LayoutItemPortal DTO.
2530 Just breaking the code up into smaller chunks.
2532 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2534 2011-11-28 Ben Konrath <ben@bagu.org>
2538 This should have been added with the refactor. Oops!
2540 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2542 2011-11-28 Ben Konrath <ben@bagu.org>
2544 Create primary key value from URL string using type from Glom document.
2546 See this bug, comments 19 - 25:
2548 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2550 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2551 create a TypeDataItem for the primary key here when loading from a
2552 URL. Show the same string for the primary key value as was received
2553 from the URL string (when loading from a URL).
2554 * src/main/java/org/glom/web/server/Utils.java: Update method for
2555 creating the Gda Value from the TypeDataItem to properly deal with
2556 creating a Gda Value based on the Glom document type for the primary
2557 key value string when loading from a URL.
2558 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2559 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2560 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2561 Update for changed method name.
2563 2011-11-27 Ben Konrath <ben@bagu.org>
2565 Rename PrimaryKeyItem to TypedDataItem.
2567 The name PrimaryKeyItem suggests what the class should be used for.
2568 TypedDataItem is a neutral name that describes the class better.
2570 This is a rename-only refactor.
2572 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2573 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2574 * src/main/java/org/glom/web/client/Utils.java:
2575 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2576 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2577 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2579 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2580 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2581 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2582 * src/main/java/org/glom/web/server/Utils.java:
2583 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2584 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2585 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2586 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2588 2011-11-25 Ben Konrath <ben@bagu.org>
2590 Improve Gda Value conversion from PrimaryKeyItem.
2592 The value from the PrimaryKeyItem is only used if its type match the
2593 type from the glom document.
2595 * src/main/java/org/glom/web/server/Utils.java:
2597 2011-11-25 Ben Konrath <ben@bagu.org>
2599 Manually check if the java-liblgom .so is visible to the JVM.
2601 It seems that Tomcat has problems when a static initializer throws an
2602 exception. This check is done before the first method call into
2603 java-libglom so that execution doesn't continue if the .so is not
2606 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2608 2011-11-25 Ben Konrath <ben@bagu.org>
2610 Improve browser configuration error messages.
2614 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2616 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2617 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2618 getConfigurationErrorMessage() method.
2619 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2620 Get and display a specific configuration error message when no Glom
2621 documents are found.
2622 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2623 Implement getConfigurationErrorMessage() method. Surround configuration
2624 code in the init() method with a try/catch block. This allows the
2625 errors to be caught while keeping the servlet available to retrieve the
2626 configuration error message.
2628 2011-11-25 Ben Konrath <ben@bagu.org>
2630 Don't use Strings to hold primary key values.
2632 The primary key values are now held in a new data object
2633 (PrimaryKeyItem) that holds type information and the primary key value
2634 using the correct type.
2636 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2637 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2639 PrimaryKeyItem instead of String to hold the primary key value.
2640 * src/main/java/org/glom/web/client/Utils.java: Remove
2641 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2642 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2643 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2644 PrimaryKeyItem instead of String to hold the primary key value. Load
2645 document selection page when the documentID has not been set correctly.
2646 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2647 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2649 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2650 Return empty string for URL instead of "null".
2651 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2652 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2653 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2654 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2655 PrimaryKeyItem instead of String to hold primary key values.
2656 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2657 PrimaryKeyValue to a Gda Value.
2658 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2659 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2660 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2661 Replace temporary database access code that uses the PrimaryKeyValue to
2662 Gda Value conversion.
2663 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2664 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2665 PrimaryKeyItem instead of String.
2666 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2667 hold primary key values.
2669 2011-11-24 Ben Konrath <ben@bagu.org>
2671 Use newly added java-libglom API to create queries.
2673 This isn't finished. I still need to stop using Strings for primary key
2674 values in the client code.
2676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2677 libglom to use fake connections so that retrieving the query string will
2679 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2680 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2681 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2682 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2683 Use the newly added libglom sql methods and classes to create the
2684 query. Add temporary hack to convert primary value strings to Gda
2687 2011-11-23 Ben Konrath <ben@bagu.org>
2689 Don't explicitly set the height of Portals.
2691 See comments 6 - 10 of this bug for details:
2693 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2695 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2697 2011-11-23 Ben Konrath <ben@bagu.org>
2699 Use an HTML table instead of CSS for the FlowTable layout.
2701 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2702 GWT's FlexTable to implement the FlowTable.
2703 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2705 2011-11-18 Ben Konrath <ben@bagu.org>
2707 Add boolean example to HTML table mockup.
2709 * mockups/details-view-html-tables-text-entries.html:
2711 2011-11-17 Ben Konrath <ben@bagu.org>
2713 Ensure the pager buttons are always visible for related lists.
2715 To accomplish this, I've turned off text wrapping in the list view and
2716 related list tables for both the header and data text. The related list
2717 table now has a fixed layout so the it doesn't overflow its container.
2718 This is required to ensure that the cell text is clipped when it
2719 overflows the cell and an ellipsis is added to the right side of the
2720 cell when text is clipped.
2722 A fixed table layout for the related list table in the details view
2723 seems what we want for the details view anyway, so the side-effect is
2726 The ellipsis will only be displayed in Firefox >= 7.
2730 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2732 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2733 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2734 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2736 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2737 Set the 'table-layout: fixed' CSS property to the related list table.
2738 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2739 'white-space: nowrap;' CSS property on both the list view and the
2740 related list tables.
2742 2011-11-16 Ben Konrath <ben@bagu.org>
2744 Rework the fix for empty notebook tab labels.
2746 Setting the empty group titles with its name caused problems for the
2747 details layout. Instead of using libglom's
2748 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2749 to the client when the title is empty. This allows the Notebook to use
2750 the name when the title is empty without affecting anything else.
2752 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2753 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2755 2011-11-16 Ben Konrath <ben@bagu.org>
2757 Set group titles with name when title is empty.
2759 This fixes a problem with an empty notebook tab label in the Lesson
2760 Planner document. The forth tab in the notebook should be "Internet":
2762 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2764 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2765 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2768 2011-11-16 Ben Konrath <ben@bagu.org>
2770 Remove whitespace from the configured username properties.
2772 This assumes that usernames won't have whitespace at the beginning
2773 or end. But I think this is a reasonable assumption.
2775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2776 String.trim() to remove the whitespace from the username properties.
2778 2011-11-15 Ben Konrath <ben@bagu.org>
2780 Add details view mockup with HTML tables and text entries.
2782 This is from the attachment on this bug:
2784 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2786 * mockups/details-view-html-tables-text-entries.html:
2788 2011-11-15 Ben Konrath <ben@bagu.org>
2790 Add space between the columns of the flow table.
2794 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2796 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2797 space between columns in the flow table.
2799 2011-11-15 Ben Konrath <ben@bagu.org>
2801 Add backup files to the .gitignore.
2803 * .gitignore: Ignore files that end with ~.
2805 2011-11-09 Ben Konrath <ben@bagu.org>
2807 Use latest release of gwt-log.
2809 Gwt-log releases are now being submitted to the maven central
2810 repository so manual installation of the jar is no longer required.
2812 * pom.xml: Update version and groupId of gwt-log dependency.
2814 2011-10-31 Ben Konrath <ben@bagu.org>
2816 Don't use GWT numeric formatting to override the glom currency formatting.
2818 Currencies are now displayed like they are in Glom. See this bug:
2820 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2822 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2824 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2825 currency code to constructor and set it when the cell is rendered.
2826 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2827 currency code to the constructor of the NumericCell.
2829 2011-10-27 Ben Konrath <ben@bagu.org>
2831 Require the latest release of java-libglom (1.17.4).
2835 2011-10-26 Ben Konrath <ben@bagu.org>
2837 Add style to Notebook that matches current theme.
2839 It's not the best style in the world but it's better than the default.
2841 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2842 padding at the bottom of the child widgets.
2843 * src/main/webapp/style.css: Add style for the Notebook.
2845 2011-10-26 Ben Konrath <ben@bagu.org>
2847 Move servlet initialization code to overridden init method.
2849 This is half of the solution to getting proper error messages
2850 displayed when configuration errors occur. Here's the relevant bug:
2852 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2854 The rest of the solution involves surrounding the init method with a
2855 try/catch block and setting a global variable with the error /
2856 exception. A new async method should be created to retrieve and display
2857 the error message / exception.
2859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2860 code from constructor to init method adding exceptions as needed.
2862 2011-10-26 Ben Konrath <ben@bagu.org>
2864 Add script to monitor and restart tomcat if required.
2866 * utils/check-and-recover-tomcat.py: New file.
2868 2011-10-26 Ben Konrath <ben@bagu.org>
2870 Display the correct number of data items in the pager.
2874 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2876 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2877 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2878 The implementation is the same for both tables: Keep track of the
2879 number of non-empty rows and fire and RowCountChangeEvent after the data has
2881 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2882 custom Pager class that subclasses SimplePager to handle displaying
2883 the correct number when empty rows have been added.
2885 2011-10-26 Ben Konrath <ben@bagu.org>
2887 Correct error in previous commit.
2889 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2890 eventBus parameter from listView.setCellTable().
2892 2011-10-26 Ben Konrath <ben@bagu.org>
2894 Fix error in TODO comment.
2896 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2898 2011-10-24 Ben Konrath <ben@bagu.org>
2900 Create Notebook widgets to the details view.
2902 This isn't finished just yet - I still need to create a reasonable
2903 style to match the current theme.
2905 * src/main/java/org/glom/web/client/Utils.java: Add method for
2906 calculating the height of a widget. This is used in the Notebook class.
2907 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2908 new constructor method in Group.
2909 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2910 method for creating child widget that can be used by subclasses
2911 like Notebook. New constructor that allows disabling the group
2912 titles - Notebooks don't set a group title for their child groups.
2913 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2914 to make Notebooks using GWT's TabLayoutPanel.
2915 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2916 constructor that allows disabling the group titles.
2917 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2918 LayoutItemNotebook DTO.
2919 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2920 DTO for Notebooks. It's just an empty class for now but we might need
2921 it to transfer some specific information in the future.
2923 2011-10-21 Ben Konrath <ben@bagu.org>
2925 Add navigation buttons to related list tables.
2927 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2928 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2930 method getSuitableRecordToViewDetails() for getting the table name
2931 and primary key value for related list navigation buttons.
2932 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2933 private cell renderer class to get the navigation information for
2934 related list tables from the server. Extract the navigation
2935 processing code from the details cell navigation and use it for the
2936 related list navigation as well.
2937 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2938 cell renderer class for the details open buttons. This was needed
2939 because the related list navigation buttons and the list view
2940 navigation buttons need to react differently when clicked.
2941 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2942 the onEnterKeyDown() method because it's now overriden in the
2943 subclasses that are specific to the related list tables and the list
2945 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2946 the vertical size a little because the buttons add a bit of vertical
2947 space to table. This is not a perfect solution because the vertical
2948 size of with table fewer than 5 rows will be a little smaller.
2949 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2950 changes in how navigation buttons are handled.
2951 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2952 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2953 database access object.
2954 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2955 to find the portal for a given relationship name from
2956 RelatedListDBAccess. Add method to find a primary key field for a
2958 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2959 Move code to find the portal for a given relationship name to
2961 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2962 New file: database access object for getting the related list
2963 navigation information (the table name and the primary key value).
2964 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2965 DTO for transferring a table name to navigate to and a primary key
2967 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2968 boolean and getter/setter to specifies if the related list should add
2971 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2973 Use the master branch of java-libglom
2975 * pom.xml: Depend on java-libglom 1.19 instead.
2977 This is the master branch. See also the libglom-1-18 branch.
2979 2011-10-11 Ben Konrath <ben@bagu.org>
2981 Enable the open navigation button when the data has been set.
2983 This avoids having active buttons that don't do anything when the data
2986 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2988 2011-10-11 Ben Konrath <ben@bagu.org>
2990 Use IsWidget interface for FlowTableItem.
2992 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2993 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2995 2011-10-11 Ben Konrath <ben@bagu.org>
2997 Remove GWT styling from open button in details view.
2999 There are still some issues with how the details cell is arranged but
3000 this should be made to match Glom 1.20. I'm going to leave fixing this
3001 until I have Glom 1.20 up and running.
3003 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3004 style name on open button.
3005 * src/main/webapp/style.css: Move and edit details-navigation class.
3006 Re-arrange some classes to make them appear in the same order as the
3009 2011-10-07 Ben Konrath <ben@bagu.org>
3011 Update to GWT 2.4.0.
3013 * .gitignore: Ignore new cache directory.
3014 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3015 * pom.xml: Change GWT and maven plugin to 2.4.0.
3016 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3018 * src/main/java/org/glom/web/client/ClientFactory.java:
3019 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3020 * src/main/java/org/glom/web/client/OnlineGlom.java:
3021 Update source for API changes.
3022 * utils/build-onlineglom-war.sh: Remove cache directory before the
3025 2011-10-07 Ben Konrath <ben@bagu.org>
3027 Add navigation buttons in the details view.
3029 This isn't finished but I thought I'd commit what I have as it's a
3030 pretty good start. I still need to:
3032 1. Change the style so that it fits better into the current theme
3033 2. Adjust the details cell to expand as much as possible.
3035 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3036 click handlers to navigation buttons in the DetailsCells. Create a
3037 refreshData() method to get just the data from the server without the
3039 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3040 Update the tableSelector and browser title when the table name
3041 changes without using the tableSelector.
3042 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3043 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3044 getDetailsCells() to getCells(). Update variable names.
3045 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3046 method to set click handler on navigation button. Rename a few
3047 variables. Add navigation buttons where needed.
3048 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3049 variables and methods.
3050 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3051 navigation boolean and navigation table as required in the
3052 LayoutItemField DTO.
3053 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3054 variables for navigation along with getter/setter methods.
3056 2011-10-07 Ben Konrath <ben@bagu.org>
3058 Rename Field to DetailsCell.
3060 This is a refactor-only commit. No functionality has been added or
3063 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3064 Update variable and method names.
3065 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3066 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3067 variable and method names.
3068 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3070 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3071 variable and method names.
3073 2011-10-07 Ben Konrath <ben@bagu.org>
3075 Create separate methods for layout and data the details view.
3077 This is a refactor-only commit. No functionality has been added or
3080 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3081 private methods: setData(), createLayout().
3083 2011-10-07 Ben Konrath <ben@bagu.org>
3085 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3087 This is part of a change to get navigation buttons in the details view
3088 but it should have been done this way from the start.
3090 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3091 for method name change in TableSelectionView.
3092 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3093 Create TableChangeEvent and set the browser title using the
3094 TableSelectionView API.
3095 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3096 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3097 Change getSelectedTable() to getSelectedTableName(). Add
3098 getSelectedTableTitle().
3100 2011-10-07 Ben Konrath <ben@bagu.org>
3102 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3104 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3106 2011-10-07 Ben Konrath <ben@bagu.org>
3108 Update TableChangeEvent to use newTableName naming convention.
3110 This makes the class more consistent with GWT naming conventions.
3112 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3113 Update for method name change in TableChangeEvent.
3114 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3115 for method name change in TableChangeEvent.
3116 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3117 newTableName variable and getter method. Make toDebugString()
3120 2011-09-30 Ben Konrath <ben@bagu.org>
3122 Disable the pager in the list tables when the data row count is less than the minimum.
3124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3125 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3127 2011-09-30 Ben Konrath <ben@bagu.org>
3129 Add empty rows to the end of related list and list view tables.
3131 I also extracted the cell rendering classes from the ListTable because
3132 the code was becoming a little crazy with all the anonymous inner
3133 classes. My plan is to use these cell rendering classes in the details
3134 view as well so this refactor will be needed for that change.
3136 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3137 set the row count in related list tables if the data has more rows
3138 than the minimum number of rows visible.
3139 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3140 row count in list view tables if the data has more rows than the
3141 minimum number of rows visible.
3142 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3143 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3145 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3146 for rendering TYPE_NUMERIC cells. The code was extracted from the
3148 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3149 class for rendering cells with buttons in list views. The code was
3150 extracted from the ListTable class.
3151 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3152 for rendering TYPE_TEXT cells. The code was extracted from the
3154 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3155 Add empty rows to the end of the data if required. Implement
3156 ListTable.getMinNumVisibleRows().
3157 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3158 cell renderer code to public classes. Return null in
3159 Column.getValue() for empty rows. Add new abstract method:
3160 getMinNumVisibleRows(). Move code to set the row count of the list view
3161 table to ListViewImpl.
3162 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3163 empty rows to the end of the data if required. Implement
3164 ListTable.getMinNumVisibleRows().
3167 2011-09-27 Ben Konrath <ben@bagu.org>
3169 Use GWT.log for client-side debugging statements.
3171 These are optimized out when deployed so I should have used this method
3172 in the first place. These statements will eventually be replaced with some sort
3173 of notification in the browser.
3175 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3176 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3177 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3178 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3179 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3181 2011-09-27 Ben Konrath <ben@bagu.org>
3183 Put tableselector on the right, back to list link on right.
3185 The idea is that the table selector is acting like a label for the
3186 currently displayed table so it should be placed below the document title. This
3187 puts the table title in a similar position to where it is in Glom.
3189 * mockups/details-contacts.html:
3190 * mockups/details-projects.html:
3191 * mockups/listview-contacts.html:
3192 * mockups/listview-projects.html:
3193 * mockups/style.css:
3194 Update mockups to match how the interfaces currently look.
3195 * src/main/webapp/style.css: Swap positions of backlink with the table
3196 selector. Add some space on the left side of the table selector to
3197 line things up with the document title.
3199 2011-09-27 Ben Konrath <ben@bagu.org>
3201 Add field colouring to details view.
3203 This change re-works how field colouring works. The colour formatting
3204 information is now set to the client with the layout information instead of
3205 with the data. This eliminates the need to send the same colour strings for
3206 data in list view column when colour information is set.
3208 In order to set an alternate colour for negative numeric values, the
3209 number is now sent to client and formatted with the GWT NumberFormat class.
3211 This change also fixes:
3213 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3215 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3216 internationalization framework which is needed for client side numeric
3218 * src/main/java/org/glom/web/client/Utils.java: New file for some
3219 client static utility methods.
3220 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3221 the DataItem object to the Field class. Use a utility method to
3222 create the foreignKeyValue string.
3223 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3224 alignment and text colours in the constructor. Add setData(DataItem)
3225 method. Remove setText(String) method.
3226 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3227 colour information to GlomTextCell. Create and use GlomNumberCell for
3228 rendering numbers. Use utility method to get the string for the
3229 primary key of the key provider. Re-work how the horizontal alignment
3231 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3232 formatting to layout information. Methods for converting the libglom
3233 formatting information were moved from DBAccess.
3234 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3235 numeric formatting (it's now done on the client side). Don't set text
3236 colours in DataItem. Move libglom formatting conversion methods to
3238 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3239 getters/setters for text colour information.
3240 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3241 for transferring the libglom NumericFormat information to the client.
3242 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3243 and getters/setters for: GlomNumericFormat, background colour and
3244 foreground colour strings.
3246 2011-09-26 Ben Konrath <ben@bagu.org>
3248 Simplify code that iterates through the LayoutGroup.
3250 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3252 2011-09-26 Ben Konrath <ben@bagu.org>
3254 Accept Eclipse formatting for OnlineGlomServiceAsync.
3256 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3258 2011-09-26 Ben Konrath <ben@bagu.org>
3260 Don't use the ListDBAccess classes to get the primary key layout information.
3262 This was causing a bug where the wrong index for the hidden primary key
3263 was being sent to the client.
3265 * src/main/java/org/glom/web/server/Configu