1 2012-03-04 Murray Cumming <murrayc@murrayc.com>
3 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
5 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
6 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
7 an empty quickfind string. I also corrected libglom to create only
8 empty where clauses for empty quickfind strings, but this avoids the
11 2012-02-24 Ben Konrath <ben@bagu.org>
13 Improve the tabs in the Notebook widget.
17 2012-02-15 Murray Cumming <murrayc@murrayc.com>
19 Depend on jasperreports.
21 * pom.xml: Add the dependency. My plan is to use this on the
24 2012-01-31 Murray Cumming <murrayc@murrayc.com>
26 Implement navigation to report places.
28 * src/main/java/org/glom/web/client/activity/ReportActivity.java
29 start(): Do not bother to handle all events here.
30 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
31 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
32 Added getSelectedReport().
33 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
34 .java: start(): When handling a change to the reports chooser,
35 call getSelectedReport() and goTo() its ReportPlace.
36 * src/main/java/org/glom/web/client/ui/ReportView.java
37 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
38 Added setReportHTML() which puts the html in a gwt HTML widget.
39 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
40 getReportHTML(): Return "TODO" just to show that this works.
42 2012-01-31 Murray Cumming <murrayc@murrayc.com>
44 Make ReportPlace usable.
46 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
48 * src/main/java/org/glom/web/client/place/ReportPlace.java:
49 Correct the @prefix annotation.
51 2012-01-31 Murray Cumming <murrayc@murrayc.com>
53 OnlineGlomService: Return report HTML rather than the LayoutGroup.
55 * src/main/java/org/glom/web/client/OnlineGlomService.java:
56 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
57 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
58 Change getReportLayout() to getReportHMTL() because we will not need to
59 parse or render the report layout on the client side.
60 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
61 getReportLayout(): Return the libglom LayoutGroup type because we will
62 not need to convert to a shared type, because this will not be used on
64 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
67 Note that there is still no implementation for this.
69 2012-01-30 Murray Cumming <murrayc@murrayc.com>
71 Translations: Try to translate the strings.
73 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
74 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
75 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
76 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
77 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
78 Take the Open translation from GTK+'s .po files.
79 Take the Details translation from Glom's po files.
80 I have added the other strings to Glom so we can get translations that way:
81 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
83 2012-01-27 Murray Cumming <murrayc@murrayc.com>
85 Add a (empty) Report Place, View, and Activity.
87 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
89 * src/main/java/org/glom/web/client/place/HasTablePlace.java
90 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
91 this into a superclass:
92 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
93 and also use it as the base of this new ReportPlace:
94 * src/main/java/org/glom/web/client/place/ReportPlace.java
96 * src/main/java/org/glom/web/client/ui/ReportView.java
97 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
98 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
99 Add these, containing mostly boiler-plate for now.
101 * src/main/java/org/glom/web/client/OnlineGlomService.java
102 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
103 * src/main/java/org/glom/web/server/ConfiguredDocument.java
104 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
105 Add API to get the LayoutGroup for the report.
107 2012-01-27 Murray Cumming <murrayc@murrayc.com>
109 TableSelectionViewImpl: Put the search label and entry in a div.
111 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
112 Put the search widgets in a FlowTable so that the CSS can be used to
113 style them while keeping them together.
114 * src/main/webapp/style.css: Mention the new div.
116 2012-01-27 Murray Cumming <murrayc@murrayc.com>
118 Translate more strings in more locales.
120 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
121 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
122 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
123 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
124 Translate the "Details" and "Open" string too.
126 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
127 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
128 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
129 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
130 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
131 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
132 Add these new locales as placeholders though they currently contain English.
134 2012-01-27 Murray Cumming <murrayc@murrayc.com>
136 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
139 Check the ConfiguredDocument* for null before using it.
141 2012-01-26 Murray Cumming <murrayc@murrayc.com>
143 Tell Eclipse about the generated java files.
145 * .classpath: This lets it find OnlineGlomConstants.java.
146 It would be nice if Eclipse just used the maven build files.
148 2012-01-26 Murray Cumming <murrayc@murrayc.com>
150 Prevent a crash when no locale is specified in the URL.
152 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
153 Avoid returning a null string, obtained from
154 Window.Location.getParameter(). This caused a crash when it was
155 later passed to libglom's API.
156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
157 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
158 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
159 guard against future null strings.
161 2012-01-26 Murray Cumming <murrayc@murrayc.com>
163 Use the ?locale= query param instead of the &lang= token param.
165 * src/main/java/org/glom/web/client/place/ListPlace.java
166 * src/main/java/org/glom/web/client/place/DetailsPlace.java
167 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
168 Remove the lang token key and value.
170 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
171 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
172 When the user selects a different locale from the chooser, use
173 Window.Location.assign() to change the URL, which then causes a reload.
175 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
176 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
177 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
178 * src/main/java/org/glom/web/client/activity/ListActivity.java
179 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
180 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
181 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
182 * src/main/java/org/glom/web/client/ui/ListView.java:
183 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
185 Remove localeID member variables and method/constructor parameters, instead
186 using Utils.getCurrentLocaleID() when we need a localID to pass to
189 2012-01-26 Murray Cumming <murrayc@murrayc.com>
191 Internationalize the UI strings.
193 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
194 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
195 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
196 because it is unused. Messages are apparently strings that can have
197 parameters, but we do not need that yet, so Contants will be enough for now.
198 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
199 to say that we support the en and de locales.
200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
201 The original English strings.
202 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
203 Some German translations of the English strings.
204 The i18n goal then uses the .properties file to generate an
205 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
206 returns an implementation that returns the translated strings.
207 The documentation suggests putting these in src/java/*/client/, but it seems
208 best to put it in src/resources/*/client/.
209 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
210 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
211 instead of hard-coding them.
212 Note that we cannot import OnlineGlomConstants because it does not exist yet,
213 but that does not seem to stop the build, though it confuses Eclipse.
215 You can see the translated string by adding ?locale=de to the URL, like so:
216 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
218 2012-01-24 Murray Cumming <murrayc@murrayc.com>
220 Improve null/empty String checks.
222 * pom.xml: Add a dependency on commons-lang, to use
223 org.apache.commons.lang.StringUtils.
224 * src/main/java/org/glom/web/server/ConfiguredDocument.java
225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
226 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
227 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
228 Use StringUtils.isEmpty().
230 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
231 StringUtils class with a static isEmpty() function because we
232 cannot use org.apache.commons.lang.StringUtils in client-side
233 GWT code because it (apparently) cannot be compiled to javascript.
234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
235 * src/main/java/org/glom/web/client/activity/ListActivity.java
236 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
237 * src/main/java/org/glom/web/client/place/DetailsPlace.java
238 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
239 * src/main/java/org/glom/web/client/place/ListPlace.java
240 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
241 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
242 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
243 * src/main/java/org/glom/web/client/ui/details/Group.java
244 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
245 our StringUtils.isEmpty() function.
247 2012-01-24 Murray Cumming <murrayc@murrayc.com>
249 Update to the latest java-libglom API.
251 * pom.xml: Require java-libglom 1.21.4.
252 * src/main/java/org/glom/web/server/ConfiguredDocument.java
253 getDocumentInfo(), getListViewLayoutGroup():
254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
256 * src/main/java/org/glom/web/server/database/DBAccess.java
257 getFieldsToShowForSQLQueryAddGroup(),
258 getPrimaryKeyLayoutItemField(): Replace get_database_title()
259 with either get_database_title_original() or
260 get_database_title(localeID).
262 2012-01-24 Murray Cumming <murrayc@murrayc.com>
264 ConfiguredDocument: Avoid a null pointer exception.
266 * src/main/java/org/glom/web/server/ConfiguredDocument.java
267 Initialize localeID to "" to avoid returning a null String which
268 causes a crash in java-libglom's swing-generated code.
270 2012-01-23 Murray Cumming <murrayc@murrayc.com>
272 Some simple renaming.
274 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
275 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
276 for localeChooser. This seems more appropriate and is less ambiguous
277 particularly in the .css file.
279 2012-01-23 Murray Cumming <murrayc@murrayc.com>
281 ConfiguredDocument: Rename the localedID private member variable.
283 2012-01-23 Murray Cumming <murrayc@murrayc.com>
285 Adapt to the latest java-libglom API from git master.
287 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
288 libglom now uses only Vector instead of List, which uses add() instead of
291 2012-01-23 Murray Cumming <murrayc@murrayc.com>
293 Add and fill a Reports drop-down list box.
295 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
297 * src/main/java/org/glom/web/client/OnlineGlomService.java:
298 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
299 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
300 Added getReports(document, table, localeID), calling
301 ConfiguredDocument.getReports().
302 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
303 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
304 Added setReportsList() and a list widget.
305 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
306 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
308 2012-01-22 Murray Cumming <murrayc@murrayc.com>
310 ConfiguredDocument: Rename the localedID private member variable.
312 2012-01-20 Murray Cumming <murrayc@murrayc.com>
314 Build a source tarball with mvn assembly:single
316 * assembly.xml: Add this file.
317 * pom.xml: Use the maven-assembly-plugin and tell it to use
318 our assembly.xml file.
320 2012-01-19 Murray Cumming <murrayc@murrayc.com>
322 OnlineGlomServiceImpl: Get .glom files recursively.
324 * pom.xml: Depend on commons-io from org.apache.commons.
325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
326 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
327 files recursively, and with the easier filter for the extension.
328 Use org.apache.commons.io.FilenameUtils.removeExtension() to
329 simplify that code too.
331 2012-01-19 Murray Cumming <murrayc@murrayc.com>
333 README: Mention that you must install java-libglom packages separately.
335 But then it works, because java-libglom is now in the central maven
338 2012-01-18 Murray Cumming <murrayc@murrayc.com>
340 locales drop-down: Show the correct selected locale when the URL changes.
342 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
343 .java: setPlace(): Move some code into fillView().
345 2012-01-18 Murray Cumming <murrayc@murrayc.com>
347 locales drop-down: Do not lose the primary key.
349 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
350 start(): onLocaleChange(): Pass the current primary key value,
351 instead of an empty value.
353 2012-01-18 Murray Cumming <murrayc@murrayc.com>
355 locales drop-down: Do not lose the drop-down selection.
357 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
358 .java (TableSelectionActivity.fillView): Set the selected locale
359 after changing the drop-down items (though we do not really need
360 to change them just because the locale changes.)
362 2012-01-18 Murray Cumming <murrayc@murrayc.com>
364 locales drop-down: Change the tables list when this changes.
366 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
367 .java: TableSelectionActivity.start(): Move the async table titles
368 retrieval into a private fillView() method and also call this when
369 the chosen locale changes.
370 Note that the document title is not actually translatable yet, but
371 that is a problem that I should fix soon in libglom.
373 2012-01-18 Murray Cumming <murrayc@murrayc.com>
375 Improve the placement of the locales drop-down.
377 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
378 Put the title and locales drop-down in a div (gwt.FlowTable).
379 * src/main/webapp/style.css: Add magic css properties to make this work.
380 Also remove the left margin from the title so that it lines up with the
383 2012-01-18 Murray Cumming <murrayc@murrayc.com>
385 locales selector: Show human-readable locale titles.
387 * src/main/java/org/glom/web/server/ConfiguredDocument.java
388 getDocumentInfo(): Use java.util.Locale to show a real title of
389 each locale, in the locale's own language.
391 2012-01-17 Murray Cumming <murrayc@murrayc.com>
393 Add a language/locale selector drop-down.
395 * src/main/java/org/glom/web/shared/DocumentInfo.java:
396 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
397 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
398 getDocumentInfo(): Store the available Locales in the DocumentInfo.
399 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
400 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
401 Add a ListBox to show the available locales. Add getLocaleSelector(),
402 setLocaleList(), getSelectedLocale(), setSelectedLocale().
403 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
404 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
405 java: Add these classes.
406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
407 start(): Fill the locales ListBox. Handle its change event, firing a
409 setPlace(): Show the selected locale as specified by the URL token.
410 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
411 * src/main/java/org/glom/web/client/activity/ListActivity.java:
412 Handle LocaleChangeEvent, going to a new *Place with that locale.
414 The placement of the ListBox is not pretty, and it currently uses the ID
415 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
419 2012-01-17 Murray Cumming <murrayc@murrayc.com>
421 Search box: Show the search text from the URL token.
423 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
424 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
425 Add setQuickFindText().
426 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
427 .java: setPlace(): Store the queryText if the place is a ListPlace,
428 and call TableSelectionView.setQuickFindText().
430 2012-01-17 Murray Cumming <murrayc@murrayc.com>
432 Allow use of translations via, for instance, &lang=de in the URL.
434 * pom.xml: Use the unstable java-libglom 1.21 version.
436 * src/main/java/org/glom/web/client/OnlineGlomService.java:
437 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
439 init(): Instead of calling TranslatableItem.set_current_locale()
440 (now removed), call ConfiguredDocument.setDefaultLocaleID().
441 However, this is only for default locales, which are not needed to
442 change the locale in the URL.
443 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
444 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
445 getSortedRelatedListData(): Add a localeID parameter, so we can get the
446 layout for a particular locale.
447 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
448 Add get/setDefaultLocaleID().
449 getDocumentInfo(), getListViewData(), getRelatedListData(),
450 getDetailsLayoutGroup(), getListViewLayoutGroup(),
451 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
452 localeID parameter, so we can get the layout for a particular locale.
454 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
455 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
456 * src/main/java/org/glom/web/client/place/ListPlace.java:
457 Parse and construct a lang parameter too.
459 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
460 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
461 passed to subsequent methods and constructors.
462 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
463 * src/main/java/org/glom/web/client/activity/ListActivity.java:
464 Store the localeID from the *Place and pass it to other constructors
465 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
467 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
468 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
469 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
470 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
471 * src/main/java/org/glom/web/client/ui/ListView.java:
472 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
473 Take localeID parameters and pass them to subsequent constructors and
474 methods, so that the layout is always retrieved for that locale.
476 This is rather repetitive.
478 Note that "" means the original (default) locale of the Glom document,
479 which is usually English.
481 2012-01-17 Murray Cumming <murrayc@murrayc.com>
483 Documents: Remove final keyword to fix startup configuration.
485 * src/main/java/org/glom/web/shared/Documents.java: Remove the
486 final keywords on the private member variables because that breaks
487 the startup, apparently (there are warnings) because it stops them
488 from being serialized. I added these in the previous commit.
490 2012-01-13 Murray Cumming <murrayc@murrayc.com>
492 Documents: Add some final keywords.
494 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
497 2012-01-13 Murray Cumming <murrayc@murrayc.com>
499 OnlineGlomServiceImpl: Add to overview comments.
501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
502 Note that this is where all the document are loaded. They are not
503 loaded freshly for each page.
505 2012-01-12 Murray Cumming <murrayc@murrayc.com>
509 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
510 Add a TextBox for the text of a quick find.
511 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
513 setBackLink(): Add a String quickFind parameter.
514 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
515 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
516 to the base interface, because that is how TableSelectionViewImpl is used.
517 * src/main/webapp/style.css: Add style for the search box and its label.
519 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
520 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
521 Add these files, based on the existing TableChangeEvent and
522 TableChangeEventHandlers.
523 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
524 start(): Handle QuickFindChangeEvent, passing its quickFind text to
525 a ListPlace() that the user should be taken to.
526 * src/main/java/org/glom/web/client/activity/ListActivity.java
527 start(): Handle it here too and adapt the TableChangeEvent handler to
528 pass the extra "" quickFind parameter to ListPlace.
529 * src/main/java/org/glom/web/client/place/ListPlace.java:
530 Constructor: Take an extra String quickFind parameter and store it,
531 returning it from a new getQuickFind() method.
532 getToken(): Put the quickFind text in the URL token.
533 getPlace(): Parse the quickFind text from the URL token.
534 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
535 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
536 ListPlace constructor.
537 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
538 .java: start(): Add a Change handler for the TableSelectionView's
539 TextBox (via its base HasChangeHandlers interface), firing the new
540 QuickFindChangeEvent.
541 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
542 pass the extra "" quickFind parameter.
544 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
545 setCellTable(): Add a String quickFind parameter and pass it to
546 the ListViewTable() constructor.
547 * src/main/java/org/glom/web/client/ui/ListView.java: Change
548 setCellTable() in the base interface, because that is how ListViewImpl
551 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
552 Add a String quickFind member variable.
553 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
554 Constructor: Add a String quickFind parameter, storing it in the
555 base ListTable's member variable.
556 onRangeChanged(): Pass quickFind to the
557 OnlineGlomServiceAsync.getSortedListViewData() and
558 OnlineGlomServiceAsync.getListViewData() methods.
560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
561 getListViewData(), getSortedListViewData(): Add a String quickFind
562 parameter, passing it to ConfiguredDocument.getListViewData().
563 * src/main/java/org/glom/web/client/OnlineGlomService.java:
564 Change getListViewData(), getSortedListViewData() in the base interface,
565 because that is how OnlineGlomServiceImpl is used, via this:
566 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
567 Change getListViewData(), getSortedListViewData() here too.
568 This class can apparently be used to asynchronously call methods on
569 OnlineGlomService, and GWT seems to implement that after recognizing
570 just the *Async name convention and the extra AsyncCallback parameters.
572 * src/main/java/org/glom/web/server/ConfiguredDocument.java
573 getListViewData(): Add a String quickFind parameter, and pass it to
574 ListViewDBAccess.getData().
575 * src/main/java/org/glom/web/server/database/ListDBAccess.java
576 getListData(): Add a String quickFind parameter and pass it to
578 getSelectQuery(): Add a String quickFind parameter.
579 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
580 getSelectQuery(): Add a String quickFind parameter and use it with
581 Glom.get_find_where_clause_quick() to pass a where_clause to
582 Glom.build_sql_select_with_where_clause(), to actually filter the
584 getData(): Add a String quickFind parameter, passing it to getListData().
585 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
586 va: getData(): Pass an empty string to getListData() for the
589 2012-01-12 Murray Cumming <murrayc@murrayc.com>
591 ListTable: Minor change.
593 * src/main/java/org/glom/web/client/ui/list/ListTable.java
594 createCellTable(): Make this protected instead of public.
596 2012-01-12 Murray Cumming <murrayc@murrayc.com>
598 Many files: Use final for the parameters and use the @override attribute.
600 2012-01-22 Ben Konrath <ben@bagu.org>
602 Add anchor links for single line text that starts with http, ftp and www.
606 2012-01-22 Ben Konrath <ben@bagu.org>
608 Add ellipsis to single line text in details view.
612 2012-01-04 Murray Cumming <murrayc@murrayc.com>
614 Remove all javadoc author tags.
616 Because they are awkward and meaningless when many people touch
618 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
620 2012-01-04 Murray Cumming <murrayc@murrayc.com>
622 Revert the COPYING.LESSER to COPYING rename.
624 Apparently both should be there if it is LGPL.
626 2012-01-03 Murray Cumming <murrayc@murrayc.com>
628 *View: Remove unused imports.
630 * src/main/java/org/glom/web/client/ui/DetailsView.java:
631 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
632 * src/main/java/org/glom/web/client/ui/ListView.java:
633 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
634 Remove unused imports, as suggested by Eclipse.
636 2012-01-02 Murray Cumming <murrayc@murrayc.com>
638 Move the *View::Presenter types, and some API into one base View.
640 * src/main/java/org/glom/web/client/ui/DetailsView.java:
641 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
642 * src/main/java/org/glom/web/client/ui/ListView.java:
643 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
644 Presenter, setPresenter() and clear() into a shared base interface,
645 to avoid the unnecessary duplicate Presenter types and to more clearly
646 show how the *Views share the same structure, even if they are not
647 used polymorphically.
649 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
650 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
652 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
653 * src/main/java/org/glom/web/client/activity/ListActivity.java:
654 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
656 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
659 Feel free to revert this if there is a good reason for the duplicate
662 2012-01-02 Murray Cumming <murrayc@murrayc.com>
664 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
666 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
667 a class member instead of a local variable in the method.
668 This lets us use it to get the view instances, for use in tests.
669 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
670 beforeOnlineGlom(): Test some more details of the initial view.
671 Again, this is not very useful.
673 To really test gwt-glom we will need to start a local postgresql
674 instance with local data, like the Glom tests in C++.
676 2012-01-02 Murray Cumming <murrayc@murrayc.com>
678 pom.xml: Mention the LGPL license.
680 * pom.xml: Add a licenses section.
681 * COPYING.LESSER: Move this to COPYING, which
682 previously contained the GPL. But gwt-glom is all LGPL.
684 2012-01-02 Murray Cumming <murrayc@murrayc.com>
686 Add project information to README and pom.xml.
688 * README: Add a brief description and mention some mvn
690 * pom.xml: This extra information shows up in mvn site
693 2011-01-02 Murray Cumming <murrayc@murrayc.com>
695 Use the latest java-libglom version.
697 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
699 2012-01-01 Murray Cumming <murrayc@murrayc.com>
701 GwtTestOnlineGlom: Test a little more.
703 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
704 protected rather than private, as suggested by the gwt-test-utils
706 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
707 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
708 Test the initial visibility of the panels.
710 However, this is not a very useful test.
711 And I wonder how we should generally test using this idea for an
712 activity/places app like ours where the real changes happen implicitly
713 based on the history token/URL.
715 2012-01-01 Murray Cumming <murrayc@murrayc.com>
717 Slight modification to *Mapper comments.
719 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
721 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
723 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
725 Remove comments mentioning GIN because they are just copied from
726 the example code and are apparently not helpful:
727 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
728 Also change the mention of a class that is only in the example code.
730 2012-01-01 Murray Cumming <murrayc@murrayc.com>
732 GwtTestOnlineGlom test: Minor changes.
734 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
735 Avoid the long qualified class name and modify the comment
736 because it is now obvious to me that the mocked class is the only
737 custom one created via GWT.create().
739 2012-01-01 Murray Cumming <murrayc@murrayc.com>
741 Tests: Added the beginnings of a test using gwt-test-utils.
743 * pom.xml: Add dependencies on gwt-test-utils and easymock.
744 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
745 which tells gwt-test-utils what class will be tested.
746 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
747 Add a simple (but empty) test case. One class, used by the OnlineGlom
748 class, is mocked so that it can be created. However, I am not sure
749 why only this class needs to be mocked.
751 Note that mockito seems more popular, and clearer, than easymock,
752 but I have not got that working yet. It might be a matter of the
755 This test is run during mvn integration-test.
757 2011-12-31 Murray Cumming <murrayc@murrayc.com>
759 Tests: Use junit4-style syntax instead of junit3-style.
761 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
762 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
763 * src/test/java/org/glom/web/shared/DataItemTest.java:
764 Use the @Test annotation rather than relying on the test*() prefix.
765 Also no longer implement TestCase, to avoid triggering support for
766 the junit3-way, which stops the annotations from working.
767 Change the imports from import junit.framework.* to
768 import org.junit.*, which is apparently the new way.
770 2011-12-31 Murray Cumming <murrayc@murrayc.com>
772 Added a test for ListPlace token parsing and creation.
774 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
775 This is much the same as DetailsPlaceTest.
777 I wonder how we could test the other parts of the *Place API.
779 2011-12-30 Murray Cumming <murrayc@murrayc.com>
781 DetailsPlace test: Also test getToken() and recreation via getPlace().
783 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
784 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
785 recreate it, testing the recreated DetailsPlace for the same parameter
788 2011-12-30 Murray Cumming <murrayc@murrayc.com>
790 Use the surefire-report plugin.
792 * pom.xml: This generates a HTML report about the tests in
793 target/site/surefire-report.html
794 when you do mvn surefire-report:report. It seems to be popular/normal.
796 2011-12-30 Murray Cumming <murrayc@murrayc.com>
798 Added a test for DetailsPlace.
800 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
801 Test the getPlace() token parsing.
803 2011-12-30 Murray Cumming <murrayc@murrayc.com>
805 Added a first unit test.
807 * pom.xml: Add a test goal, and a dependency on junit in that scope.
808 * src/test/java/org/glom/web/shared/DataItemTest.java:
809 This is a silly test but it is just to get things started. Note that
810 maven/junit finds the test because it looks in src/test by default.
812 2011-12-22 Ben Konrath <ben@bagu.org>
814 Change charsetName to "UTF-8" when replacing line breaks.
816 JavaScript requires the charsetName to be "UTF-8". CharsetName values
817 that work in Java (such as "UTF8") will not work when compiled to
820 This fixes a problem with multi-line details view fields that have hard
821 line breaks. The "License Text" field on this page demonstrates the
824 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
826 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
828 2011-12-22 Ben Konrath <ben@bagu.org>
830 Fix another bug with related list navigation.
832 I've tested all the navigation buttons in all of the related lists
833 so things should be good now.
835 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
837 2011-12-22 Ben Konrath <ben@bagu.org>
839 Fix a crasher when refreshing the list view with the default table.
841 This crash will also happen when loading the list view with the default
842 table from a link or bookmark.
844 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
845 to the main document selection page when the document id hasn't been
847 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
848 the main document selection page when the document id hasn't been
850 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
851 values for the details place when the document id hasn't been set.
852 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
853 values for the list place when the document id hasn't been set.
855 2011-12-21 Ben Konrath <ben@bagu.org>
857 Protect against NPE when glom.document.locale is not in config.
859 This patch protects against an NPE when glom.document.locale is not in
860 the config file. This NPE will also happen if glom.document.locale is
863 The patch also updates the error message to display the class name when
864 the getMessage() returns null. This was happening when the NPE was
865 thrown and I had "Configuration Error: null". If an NPE is encountered
866 with this patch, "Configuration Error: NullPointerException " will be
869 This commit closes this bug:
871 https://bugzilla.gnome.org/show_bug.cgi?id=666669
873 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
875 2011-12-20 Murray Cumming <murrayc@murrayc.com>
877 Rename onlineglom.properties to onlineglom.properties.sample.
879 * src/main/resources/onlineglom.properties: Rename to:
880 * src/main/resources/onlineglom.properties.sample:
881 * src/main/resources/README: And add this file explaining that people
882 should rename it back when deploying.
884 2011-12-20 Murray Cumming <murrayc@murrayc.com>
886 Allow choosing the translation in the .properties file.
888 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
889 init(): Read a glom.document.locale value from the configuration file
890 and call Glom's TransatableItem::set_current_locale() method.
891 * src/main/resources/onlineglom.properties: Add a commented-out
892 example of this new setting.
894 It would be better to add &lang=de_DE to the URL, but the current
895 libglom API does not allow us to do this easily. I am working on that.
897 2011-12-19 Murray Cumming <murrayc@murrayc.com>
899 Avoid a crash in parsing of token parameters.
901 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
902 ava: getTokenParams(): Do not crash if a parameter has a key but no
903 value, and ignore parameters with neither.
905 2011-12-17 Murray Cumming <murrayc@murayc.com>
907 History token building/handling: Improve use of token parameters.
909 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
910 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
911 and buildParamsToken(HashMap), for use by derived classes.
912 Make the separator private because it is no longer be needed.
913 * src/main/java/org/glom/web/client/place/DetailsPlace.java
914 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
915 instead of manual string concatenation.
916 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
917 of hardcoded indices and awkward splitting code.
918 * src/main/java/org/glom/web/client/place/ListPlace.java
919 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
920 instead of manual string concatenation.
921 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
922 of hardcoded indices and awkward splitting code.
923 This should fix bug #666420
925 2011-12-16 Murray Cumming <murrayc@murrayc.com>
927 Fix a Navgiation->Navigation typo in the code.
929 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
930 Rename processNavgiation() to processNavigation().
932 2011-12-16 Murray Cumming <murrayc@murrayc.com>
934 Fix a seperator->separator typo in the code.
936 * src/main/java/org/glom/web/client/place/DetailsPlace.java
937 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
938 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
941 2011-12-15 Ben Konrath <ben@bagu.org>
943 Cleanup some comments.
945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
947 2011-12-14 Ben Konrath <ben@bagu.org>
949 Replace \n with <br/> for multiline text in the details view.
951 Vertical scrollbars are added when needed as well.
953 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
955 2011-12-14 Ben Konrath <ben@bagu.org>
957 Specify the font for document selection links.
959 * src/main/webapp/style.css:
961 2011-12-14 Ben Konrath <ben@bagu.org>
963 Fix bouncy CellTable while paging.
965 This doesn't currently work with related list tables in unselected
968 * src/main/java/org/glom/web/client/ui/list/ListTable.java
970 2011-12-14 Ben Konrath <ben@bagu.org>
972 Revamp the appearance of the document selection page.
974 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
975 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
976 * src/main/webapp/style.css:
978 2011-12-13 Ben Konrath <ben@bagu.org>
980 Set navigation button column to the smallest size possible.
982 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
984 2011-12-13 Ben Konrath <ben@bagu.org>
986 Change OpenButton nomenclature to NavigationButton.
988 Using NavigtionButton makes things more generic. Classes, methods and
989 variables have been changed.
991 This is a rename-only refactor.
993 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
994 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
995 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
996 Renamed from OpenButtonCell.
997 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
998 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
999 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1001 2011-12-12 Ben Konrath <ben@bagu.org>
1003 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1005 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1006 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1007 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1008 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1010 2011-12-12 Ben Konrath <ben@bagu.org>
1012 Update variable names and comments.
1014 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1015 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1017 2011-12-12 Ben Konrath <ben@bagu.org>
1019 Properly initialize numNonEmptyRows variable to zero.
1021 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1022 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1024 2011-12-05 Ben Konrath <ben@bagu.org>
1026 Add latest mockup with HTML tables.
1028 Features of this mockup:
1030 -> HTML table for flowtable
1031 -> HTML table for flowtable column
1032 -> Example of how related lists would look
1033 -> Not using text entries for data items
1035 The current version of Online Glom doesn't use HTML tables for the
1038 This mockup has been sent to the glom-devel mailing list but it's good
1039 to have it here as well.
1041 * mockups/details-view-html-tables.html:
1043 2011-12-05 Ben Konrath <ben@bagu.org>
1045 Remove unnecessary getPrimaryKeyField() method.
1047 getPrimaryKeyFieldForTable(String) has been renamed to
1048 getPrimaryKeyField(String).
1050 * src/main/java/org/glom/web/server/database/DBAccess.java:
1051 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1052 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1054 2011-12-05 Ben Konrath <ben@bagu.org>
1056 Add string representation of TypedDataItem value to conversion error message.
1058 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1059 message was extracted into its own method to avoid duplication.
1061 2011-12-05 Ben Konrath <ben@bagu.org>
1063 Add type checking to navigation primary key value creation.
1065 Create navigation primary key only if the expected type from the Glom
1066 document matches the type returned by the SQL query.
1068 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1070 2011-12-05 Ben Konrath <ben@bagu.org>
1072 Rename a couple of variables in RelatedListNavigation.
1074 This is a rename-only refactor.
1076 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1078 2011-12-05 Ben Konrath <ben@bagu.org>
1080 Move getListLayoutGroup() into getListViewLayoutGroup().
1082 This removes getListLayoutGroup(). It was only being called by
1083 getListViewLayoutGroup().
1085 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1087 2011-12-05 Ben Konrath <ben@bagu.org>
1089 Remove check for LayoutItem_Portal in list table method.
1091 This check is no longer necessary because the method isn't being used
1092 to create the LayoutItemPortal DTO.
1094 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1096 2011-12-05 Ben Konrath <ben@bagu.org>
1098 Properly support related list navigation.
1100 Navigation from the "Repository Analyzer -> Package Scans ->
1101 Dependencies" related table wasn't working because the primary key for
1102 related tables wasn't being set properly. This commit fixes the
1105 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1106 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1107 doesn't set the primary key properly for related list tables.
1108 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1109 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1110 useful for getting the primary key for list view tables and for related
1112 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1113 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1114 Move code to set the primary key for the table from the abstract
1115 ListDBAccess class to ListViewDBAccess as it's only correct for list
1117 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1118 Properly add primary key to related list tables.
1120 2011-12-02 Ben Konrath <ben@bagu.org>
1122 Properly set the horizontal alignment of fields.
1124 This fix is for both the list tables and the details view.
1126 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1127 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1128 to set the horizontal alignment of fields.
1130 2011-12-02 Ben Konrath <ben@bagu.org>
1132 Display currency codes in the details view.
1134 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1136 2011-12-02 Ben Konrath <ben@bagu.org>
1138 Avoid duplicate JNI call.
1140 JNI is not as efficient as pure Java and this is an easy (and small)
1143 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1144 Use previously retrieved value for whereClauseToTableName instead of
1147 2011-12-02 Ben Konrath <ben@bagu.org>
1149 Rename a couple of variables in RelatedListNavigation.
1151 This is a rename-only refactor.
1153 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1155 2011-12-02 Ben Konrath <ben@bagu.org>
1157 Indicate clearly that a mismatched primary key type is a bug.
1159 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1160 warning to error. Add 'This is a bug.' to message.
1162 2011-12-02 Ben Konrath <ben@bagu.org>
1164 Update / fix some comments.
1166 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1168 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1170 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1171 Fix comments. Add some TODOs.
1173 2011-12-02 Ben Konrath <ben@bagu.org>
1175 Enable navigation to details view with string primary key from related list.
1177 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1178 Create a text primary key value when return type of result is
1179 java.sql.Types.VARCHAR.
1181 2011-12-02 Ben Konrath <ben@bagu.org>
1183 Use checkboxes for booleans in the details view.
1185 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1187 2011-12-01 Ben Konrath <ben@bagu.org>
1189 Improve performance of related list height calculation.
1191 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1192 Put code to calculate the expected height in a static initializer so
1193 that that it's only called once.
1195 2011-12-01 Ben Konrath <ben@bagu.org>
1197 Show related list tables in notebooks (again).
1199 Calculate the height of the related list tables so the Notebook can be
1200 set the correct height. The height of the related list table is also needed by
1201 FlowTable to be able decide how to create the layout.
1203 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1204 and set the Portal height based on the height of the related list
1205 table and the Portal container.
1206 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1207 Add method to calculate the height of the related list tables.
1208 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1209 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1210 calculate the height of the Pager widget.
1212 2011-12-01 Ben Konrath <ben@bagu.org>
1214 Use CellTable API for table property instead of setting style on Element.
1216 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1218 2011-12-01 Ben Konrath <ben@bagu.org>
1220 Make ListViewTable and RelatedListTable a consistent height.
1222 The tables are now a consistent height regardless of the contents of
1223 the table. A hidden button is added to empty rows to ensure that the
1224 height of these rows will match the height of rows with data.
1226 A navigation button column is now added to every table. The width of
1227 the navigation column is set to 0px when a RelatedListTable shouldn't
1228 have navigation buttons. This maintains the a consistent row height in
1229 tables that don't show the navigation buttons.
1231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1232 navigation column when not needed.
1233 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1234 arguments for navigation button to constructor of ListViewTable.
1235 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1236 hidden button for empty data rows.
1237 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1238 arguments for navigation button to constructor.
1239 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1240 create navigation buttons. Add hideNavigationButtons() method.
1241 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1242 arguments for navigation button to constructor.
1244 2011-12-01 Ben Konrath <ben@bagu.org>
1246 Use 'visibility: hidden' in Utils.getWidgetHeight().
1248 This is better choice because hidden elements are invisible, don't
1249 respond to events and are not part of the tab order. They will,
1250 however, take up space which is required to be able to calculate the
1251 height of the widget.
1253 * src/main/java/org/glom/web/client/Utils.java:
1255 2011-12-01 Ben Konrath <ben@bagu.org>
1257 Use Utils.getWidgetHeight() in FlowTable.
1259 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1261 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1263 2011-12-01 Ben Konrath <ben@bagu.org>
1265 Put the details css class name on the correct table column.
1267 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1269 2011-11-30 Ben Konrath <ben@bagu.org>
1271 Update for java-libglom API change.
1273 The getters and setters on FieldFormatting and NumericFormat were
1274 changed to remove the 'M'.
1276 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1278 2011-11-29 Ben Konrath <ben@bagu.org>
1280 Only allow RelatedListTables in Portals.
1282 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1284 2011-11-29 Ben Konrath <ben@bagu.org>
1286 Only create a contents panel for Portals when title is being set.
1288 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1290 2011-11-29 Ben Konrath <ben@bagu.org>
1292 Set TabLayoutPanel height based on calculated height its widgets.
1294 This is a potential fix for this bug:
1296 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1298 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1300 2011-11-29 Ben Konrath <ben@bagu.org>
1302 Align details field labels and data with the Open buttons.
1304 * src/main/webapp/style.css:
1306 2011-11-29 Ben Konrath <ben@bagu.org>
1308 Remove unnecessary <div> in the Notebook widget.
1310 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1311 method to get container FlowPanel (<div>).
1312 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1313 initWidget() method directly on the TabLayoutPanel widget instead of
1314 Group's container widget.
1316 2011-11-29 Ben Konrath <ben@bagu.org>
1318 Don't add group titles for Portals in Notebooks.
1320 This reverts the previous patch and fixes a bug I introduced with
1321 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1323 * src/main/java/org/glom/web/client/ui/details/Group.java:
1324 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1326 2011-11-28 Ben Konrath <ben@bagu.org>
1328 Remove unused boolean argument in Portal constructor.
1330 Just a code cleanup.
1332 * src/main/java/org/glom/web/client/ui/details/Group.java:
1333 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1335 2011-11-28 Ben Konrath <ben@bagu.org>
1337 Remove hack for glom 1.18 style glom files.
1339 * src/main/java/org/glom/web/client/ui/details/Group.java:
1340 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1341 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1343 2011-11-28 Ben Konrath <ben@bagu.org>
1345 Use Gda Value version of primary key to log result too large error.
1347 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1349 2011-11-28 Ben Konrath <ben@bagu.org>
1351 Don't use TypedDataItem.getText() for Unknown types from the URL.
1353 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1354 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1355 instead of getText().
1356 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1357 String field and getUnknown() method.
1359 2011-11-28 Ben Konrath <ben@bagu.org>
1361 Log an error message when the java-libglom .so is not present.
1363 The error message was being set in the exception but not logged.
1365 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1367 2011-11-28 Ben Konrath <ben@bagu.org>
1369 Ignore LayoutItem_CalendarPortals.
1371 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1372 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1374 2011-11-28 Ben Konrath <ben@bagu.org>
1376 Extract method for creating the LayoutItemPortal DTO.
1378 Just breaking the code up into smaller chunks.
1380 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1382 2011-11-28 Ben Konrath <ben@bagu.org>
1386 This should have been added with the refactor. Oops!
1388 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1390 2011-11-28 Ben Konrath <ben@bagu.org>
1392 Create primary key value from URL string using type from Glom document.
1394 See this bug, comments 19 - 25:
1396 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1398 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1399 create a TypeDataItem for the primary key here when loading from a
1400 URL. Show the same string for the primary key value as was received
1401 from the URL string (when loading from a URL).
1402 * src/main/java/org/glom/web/server/Utils.java: Update method for
1403 creating the Gda Value from the TypeDataItem to properly deal with
1404 creating a Gda Value based on the Glom document type for the primary
1405 key value string when loading from a URL.
1406 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1407 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1408 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1409 Update for changed method name.
1411 2011-11-27 Ben Konrath <ben@bagu.org>
1413 Rename PrimaryKeyItem to TypedDataItem.
1415 The name PrimaryKeyItem suggests what the class should be used for.
1416 TypedDataItem is a neutral name that describes the class better.
1418 This is a rename-only refactor.
1420 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1421 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1422 * src/main/java/org/glom/web/client/Utils.java:
1423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1424 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1425 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1426 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1427 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1428 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1430 * src/main/java/org/glom/web/server/Utils.java:
1431 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1432 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1433 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1434 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1436 2011-11-25 Ben Konrath <ben@bagu.org>
1438 Improve Gda Value conversion from PrimaryKeyItem.
1440 The value from the PrimaryKeyItem is only used if its type match the
1441 type from the glom document.
1443 * src/main/java/org/glom/web/server/Utils.java:
1445 2011-11-25 Ben Konrath <ben@bagu.org>
1447 Manually check if the java-liblgom .so is visible to the JVM.
1449 It seems that Tomcat has problems when a static initializer throws an
1450 exception. This check is done before the first method call into
1451 java-libglom so that execution doesn't continue if the .so is not
1454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1456 2011-11-25 Ben Konrath <ben@bagu.org>
1458 Improve browser configuration error messages.
1462 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1464 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1465 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1466 getConfigurationErrorMessage() method.
1467 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1468 Get and display a specific configuration error message when no Glom
1469 documents are found.
1470 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1471 Implement getConfigurationErrorMessage() method. Surround configuration
1472 code in the init() method with a try/catch block. This allows the
1473 errors to be caught while keeping the servlet available to retrieve the
1474 configuration error message.
1476 2011-11-25 Ben Konrath <ben@bagu.org>
1478 Don't use Strings to hold primary key values.
1480 The primary key values are now held in a new data object
1481 (PrimaryKeyItem) that holds type information and the primary key value
1482 using the correct type.
1484 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1485 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1486 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1487 PrimaryKeyItem instead of String to hold the primary key value.
1488 * src/main/java/org/glom/web/client/Utils.java: Remove
1489 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1490 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1491 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1492 PrimaryKeyItem instead of String to hold the primary key value. Load
1493 document selection page when the documentID has not been set correctly.
1494 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1495 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1497 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1498 Return empty string for URL instead of "null".
1499 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1500 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1501 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1502 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1503 PrimaryKeyItem instead of String to hold primary key values.
1504 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1505 PrimaryKeyValue to a Gda Value.
1506 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1507 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1508 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1509 Replace temporary database access code that uses the PrimaryKeyValue to
1510 Gda Value conversion.
1511 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1512 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1513 PrimaryKeyItem instead of String.
1514 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1515 hold primary key values.
1517 2011-11-24 Ben Konrath <ben@bagu.org>
1519 Use newly added java-libglom API to create queries.
1521 This isn't finished. I still need to stop using Strings for primary key
1522 values in the client code.
1524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1525 libglom to use fake connections so that retrieving the query string will
1527 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1528 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1529 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1530 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1531 Use the newly added libglom sql methods and classes to create the
1532 query. Add temporary hack to convert primary value strings to Gda
1535 2011-11-23 Ben Konrath <ben@bagu.org>
1537 Don't explicitly set the height of Portals.
1539 See comments 6 - 10 of this bug for details:
1541 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1543 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1545 2011-11-23 Ben Konrath <ben@bagu.org>
1547 Use an HTML table instead of CSS for the FlowTable layout.
1549 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1550 GWT's FlexTable to implement the FlowTable.
1551 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1553 2011-11-18 Ben Konrath <ben@bagu.org>
1555 Add boolean example to HTML table mockup.
1557 * mockups/details-view-html-tables-text-entries.html:
1559 2011-11-17 Ben Konrath <ben@bagu.org>
1561 Ensure the pager buttons are always visible for related lists.
1563 To accomplish this, I've turned off text wrapping in the list view and
1564 related list tables for both the header and data text. The related list
1565 table now has a fixed layout so the it doesn't overflow its container.
1566 This is required to ensure that the cell text is clipped when it
1567 overflows the cell and an ellipsis is added to the right side of the
1568 cell when text is clipped.
1570 A fixed table layout for the related list table in the details view
1571 seems what we want for the details view anyway, so the side-effect is
1574 The ellipsis will only be displayed in Firefox >= 7.
1578 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1580 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1581 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1582 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1584 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1585 Set the 'table-layout: fixed' CSS property to the related list table.
1586 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1587 'white-space: nowrap;' CSS property on both the list view and the
1588 related list tables.
1590 2011-11-16 Ben Konrath <ben@bagu.org>
1592 Rework the fix for empty notebook tab labels.
1594 Setting the empty group titles with its name caused problems for the
1595 details layout. Instead of using libglom's
1596 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1597 to the client when the title is empty. This allows the Notebook to use
1598 the name when the title is empty without affecting anything else.
1600 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1601 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1603 2011-11-16 Ben Konrath <ben@bagu.org>
1605 Set group titles with name when title is empty.
1607 This fixes a problem with an empty notebook tab label in the Lesson
1608 Planner document. The forth tab in the notebook should be "Internet":
1610 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1612 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1613 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1616 2011-11-16 Ben Konrath <ben@bagu.org>
1618 Remove whitespace from the configured username properties.
1620 This assumes that usernames won't have whitespace at the beginning
1621 or end. But I think this is a reasonable assumption.
1623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1624 String.trim() to remove the whitespace from the username properties.
1626 2011-11-15 Ben Konrath <ben@bagu.org>
1628 Add details view mockup with HTML tables and text entries.
1630 This is from the attachment on this bug:
1632 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1634 * mockups/details-view-html-tables-text-entries.html:
1636 2011-11-15 Ben Konrath <ben@bagu.org>
1638 Add space between the columns of the flow table.
1642 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1644 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1645 space between columns in the flow table.
1647 2011-11-15 Ben Konrath <ben@bagu.org>
1649 Add backup files to the .gitignore.
1651 * .gitignore: Ignore files that end with ~.
1653 2011-11-09 Ben Konrath <ben@bagu.org>
1655 Use latest release of gwt-log.
1657 Gwt-log releases are now being submitted to the maven central
1658 repository so manual installation of the jar is no longer required.
1660 * pom.xml: Update version and groupId of gwt-log dependency.
1662 2011-10-31 Ben Konrath <ben@bagu.org>
1664 Don't use GWT numeric formatting to override the glom currency formatting.
1666 Currencies are now displayed like they are in Glom. See this bug:
1668 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1670 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1672 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1673 currency code to constructor and set it when the cell is rendered.
1674 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1675 currency code to the constructor of the NumericCell.
1677 2011-10-27 Ben Konrath <ben@bagu.org>
1679 Require the latest release of java-libglom (1.17.4).
1683 2011-10-26 Ben Konrath <ben@bagu.org>
1685 Add style to Notebook that matches current theme.
1687 It's not the best style in the world but it's better than the default.
1689 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1690 padding at the bottom of the child widgets.
1691 * src/main/webapp/style.css: Add style for the Notebook.
1693 2011-10-26 Ben Konrath <ben@bagu.org>
1695 Move servlet initialization code to overridden init method.
1697 This is half of the solution to getting proper error messages
1698 displayed when configuration errors occur. Here's the relevant bug:
1700 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1702 The rest of the solution involves surrounding the init method with a
1703 try/catch block and setting a global variable with the error /
1704 exception. A new async method should be created to retrieve and display
1705 the error message / exception.
1707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1708 code from constructor to init method adding exceptions as needed.
1710 2011-10-26 Ben Konrath <ben@bagu.org>
1712 Add script to monitor and restart tomcat if required.
1714 * utils/check-and-recover-tomcat.py: New file.
1716 2011-10-26 Ben Konrath <ben@bagu.org>
1718 Display the correct number of data items in the pager.
1722 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1724 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1725 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1726 The implementation is the same for both tables: Keep track of the
1727 number of non-empty rows and fire and RowCountChangeEvent after the data has
1729 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1730 custom Pager class that subclasses SimplePager to handle displaying
1731 the correct number when empty rows have been added.
1733 2011-10-26 Ben Konrath <ben@bagu.org>
1735 Correct error in previous commit.
1737 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1738 eventBus parameter from listView.setCellTable().
1740 2011-10-26 Ben Konrath <ben@bagu.org>
1742 Fix error in TODO comment.
1744 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1746 2011-10-24 Ben Konrath <ben@bagu.org>
1748 Create Notebook widgets to the details view.
1750 This isn't finished just yet - I still need to create a reasonable
1751 style to match the current theme.
1753 * src/main/java/org/glom/web/client/Utils.java: Add method for
1754 calculating the height of a widget. This is used in the Notebook class.
1755 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1756 new constructor method in Group.
1757 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1758 method for creating child widget that can be used by subclasses
1759 like Notebook. New constructor that allows disabling the group
1760 titles - Notebooks don't set a group title for their child groups.
1761 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1762 to make Notebooks using GWT's TabLayoutPanel.
1763 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1764 constructor that allows disabling the group titles.
1765 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1766 LayoutItemNotebook DTO.
1767 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1768 DTO for Notebooks. It's just an empty class for now but we might need
1769 it to transfer some specific information in the future.
1771 2011-10-21 Ben Konrath <ben@bagu.org>
1773 Add navigation buttons to related list tables.
1775 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1776 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1778 method getSuitableRecordToViewDetails() for getting the table name
1779 and primary key value for related list navigation buttons.
1780 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1781 private cell renderer class to get the navigation information for
1782 related list tables from the server. Extract the navigation
1783 processing code from the details cell navigation and use it for the
1784 related list navigation as well.
1785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1786 cell renderer class for the details open buttons. This was needed
1787 because the related list navigation buttons and the list view
1788 navigation buttons need to react differently when clicked.
1789 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1790 the onEnterKeyDown() method because it's now overriden in the
1791 subclasses that are specific to the related list tables and the list
1793 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1794 the vertical size a little because the buttons add a bit of vertical
1795 space to table. This is not a perfect solution because the vertical
1796 size of with table fewer than 5 rows will be a little smaller.
1797 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1798 changes in how navigation buttons are handled.
1799 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1800 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1801 database access object.
1802 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1803 to find the portal for a given relationship name from
1804 RelatedListDBAccess. Add method to find a primary key field for a
1806 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1807 Move code to find the portal for a given relationship name to
1809 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1810 New file: database access object for getting the related list
1811 navigation information (the table name and the primary key value).
1812 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1813 DTO for transferring a table name to navigate to and a primary key
1815 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1816 boolean and getter/setter to specifies if the related list should add
1819 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1821 Use the master branch of java-libglom
1823 * pom.xml: Depend on java-libglom 1.19 instead.
1825 This is the master branch. See also the libglom-1-18 branch.
1827 2011-10-11 Ben Konrath <ben@bagu.org>
1829 Enable the open navigation button when the data has been set.
1831 This avoids having active buttons that don't do anything when the data
1834 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1836 2011-10-11 Ben Konrath <ben@bagu.org>
1838 Use IsWidget interface for FlowTableItem.
1840 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1841 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1843 2011-10-11 Ben Konrath <ben@bagu.org>
1845 Remove GWT styling from open button in details view.
1847 There are still some issues with how the details cell is arranged but
1848 this should be made to match Glom 1.20. I'm going to leave fixing this
1849 until I have Glom 1.20 up and running.
1851 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1852 style name on open button.
1853 * src/main/webapp/style.css: Move and edit details-navigation class.
1854 Re-arrange some classes to make them appear in the same order as the
1857 2011-10-07 Ben Konrath <ben@bagu.org>
1859 Update to GWT 2.4.0.
1861 * .gitignore: Ignore new cache directory.
1862 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1863 * pom.xml: Change GWT and maven plugin to 2.4.0.
1864 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1866 * src/main/java/org/glom/web/client/ClientFactory.java:
1867 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1868 * src/main/java/org/glom/web/client/OnlineGlom.java:
1869 Update source for API changes.
1870 * utils/build-onlineglom-war.sh: Remove cache directory before the
1873 2011-10-07 Ben Konrath <ben@bagu.org>
1875 Add navigation buttons in the details view.
1877 This isn't finished but I thought I'd commit what I have as it's a
1878 pretty good start. I still need to:
1880 1. Change the style so that it fits better into the current theme
1881 2. Adjust the details cell to expand as much as possible.
1883 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1884 click handlers to navigation buttons in the DetailsCells. Create a
1885 refreshData() method to get just the data from the server without the
1887 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1888 Update the tableSelector and browser title when the table name
1889 changes without using the tableSelector.
1890 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1891 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1892 getDetailsCells() to getCells(). Update variable names.
1893 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1894 method to set click handler on navigation button. Rename a few
1895 variables. Add navigation buttons where needed.
1896 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1897 variables and methods.
1898 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1899 navigation boolean and navigation table as required in the
1900 LayoutItemField DTO.
1901 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1902 variables for navigation along with getter/setter methods.
1904 2011-10-07 Ben Konrath <ben@bagu.org>
1906 Rename Field to DetailsCell.
1908 This is a refactor-only commit. No functionality has been added or
1911 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1912 Update variable and method names.
1913 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1914 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1915 variable and method names.
1916 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1918 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1919 variable and method names.
1921 2011-10-07 Ben Konrath <ben@bagu.org>
1923 Create separate methods for layout and data the details view.
1925 This is a refactor-only commit. No functionality has been added or
1928 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1929 private methods: setData(), createLayout().
1931 2011-10-07 Ben Konrath <ben@bagu.org>
1933 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1935 This is part of a change to get navigation buttons in the details view
1936 but it should have been done this way from the start.
1938 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1939 for method name change in TableSelectionView.
1940 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1941 Create TableChangeEvent and set the browser title using the
1942 TableSelectionView API.
1943 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1944 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1945 Change getSelectedTable() to getSelectedTableName(). Add
1946 getSelectedTableTitle().
1948 2011-10-07 Ben Konrath <ben@bagu.org>
1950 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1952 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1954 2011-10-07 Ben Konrath <ben@bagu.org>
1956 Update TableChangeEvent to use newTableName naming convention.
1958 This makes the class more consistent with GWT naming conventions.
1960 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1961 Update for method name change in TableChangeEvent.
1962 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1963 for method name change in TableChangeEvent.
1964 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1965 newTableName variable and getter method. Make toDebugString()
1968 2011-09-30 Ben Konrath <ben@bagu.org>
1970 Disable the pager in the list tables when the data row count is less than the minimum.
1972 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1973 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1975 2011-09-30 Ben Konrath <ben@bagu.org>
1977 Add empty rows to the end of related list and list view tables.
1979 I also extracted the cell rendering classes from the ListTable because
1980 the code was becoming a little crazy with all the anonymous inner
1981 classes. My plan is to use these cell rendering classes in the details
1982 view as well so this refactor will be needed for that change.
1984 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1985 set the row count in related list tables if the data has more rows
1986 than the minimum number of rows visible.
1987 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1988 row count in list view tables if the data has more rows than the
1989 minimum number of rows visible.
1990 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1991 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1993 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1994 for rendering TYPE_NUMERIC cells. The code was extracted from the
1996 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1997 class for rendering cells with buttons in list views. The code was
1998 extracted from the ListTable class.
1999 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2000 for rendering TYPE_TEXT cells. The code was extracted from the
2002 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2003 Add empty rows to the end of the data if required. Implement
2004 ListTable.getMinNumVisibleRows().
2005 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2006 cell renderer code to public classes. Return null in
2007 Column.getValue() for empty rows. Add new abstract method:
2008 getMinNumVisibleRows(). Move code to set the row count of the list view
2009 table to ListViewImpl.
2010 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2011 empty rows to the end of the data if required. Implement
2012 ListTable.getMinNumVisibleRows().
2015 2011-09-27 Ben Konrath <ben@bagu.org>
2017 Use GWT.log for client-side debugging statements.
2019 These are optimized out when deployed so I should have used this method
2020 in the first place. These statements will eventually be replaced with some sort
2021 of notification in the browser.
2023 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2024 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2025 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2026 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2027 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2029 2011-09-27 Ben Konrath <ben@bagu.org>
2031 Put tableselector on the right, back to list link on right.
2033 The idea is that the table selector is acting like a label for the
2034 currently displayed table so it should be placed below the document title. This
2035 puts the table title in a similar position to where it is in Glom.
2037 * mockups/details-contacts.html:
2038 * mockups/details-projects.html:
2039 * mockups/listview-contacts.html:
2040 * mockups/listview-projects.html:
2041 * mockups/style.css:
2042 Update mockups to match how the interfaces currently look.
2043 * src/main/webapp/style.css: Swap positions of backlink with the table
2044 selector. Add some space on the left side of the table selector to
2045 line things up with the document title.
2047 2011-09-27 Ben Konrath <ben@bagu.org>
2049 Add field colouring to details view.
2051 This change re-works how field colouring works. The colour formatting
2052 information is now set to the client with the layout information instead of
2053 with the data. This eliminates the need to send the same colour strings for
2054 data in list view column when colour information is set.
2056 In order to set an alternate colour for negative numeric values, the
2057 number is now sent to client and formatted with the GWT NumberFormat class.
2059 This change also fixes:
2061 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2063 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2064 internationalization framework which is needed for client side numeric
2066 * src/main/java/org/glom/web/client/Utils.java: New file for some
2067 client static utility methods.
2068 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2069 the DataItem object to the Field class. Use a utility method to
2070 create the foreignKeyValue string.
2071 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2072 alignment and text colours in the constructor. Add setData(DataItem)
2073 method. Remove setText(String) method.
2074 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2075 colour information to GlomTextCell. Create and use GlomNumberCell for
2076 rendering numbers. Use utility method to get the string for the
2077 primary key of the key provider. Re-work how the horizontal alignment
2079 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2080 formatting to layout information. Methods for converting the libglom
2081 formatting information were moved from DBAccess.
2082 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2083 numeric formatting (it's now done on the client side). Don't set text
2084 colours in DataItem. Move libglom formatting conversion methods to
2086 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2087 getters/setters for text colour information.
2088 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2089 for transferring the libglom NumericFormat information to the client.
2090 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2091 and getters/setters for: GlomNumericFormat, background colour and
2092 foreground colour strings.
2094 2011-09-26 Ben Konrath <ben@bagu.org>
2096 Simplify code that iterates through the LayoutGroup.
2098 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2100 2011-09-26 Ben Konrath <ben@bagu.org>
2102 Accept Eclipse formatting for OnlineGlomServiceAsync.
2104 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2106 2011-09-26 Ben Konrath <ben@bagu.org>
2108 Don't use the ListDBAccess classes to get the primary key layout information.
2110 This was causing a bug where the wrong index for the hidden primary key
2111 was being sent to the client.
2113 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2114 primary key while creating the LayoutGroup DTO. Create a
2115 LayoutItemField DTO for hidden primary keys. Don't use the
2116 RelatedListDBAccess because it was only used for getting the primary
2118 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2119 access modifier from public to protected for getPrimaryKeyField() and
2120 getPrimaryKeyLayoutItemField().
2121 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2122 abstract method getExpectedResultSize() because RelatedListDBAccess
2123 doesn't have enough info to implement it.
2124 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2125 Remove @Override for getExpectedResultSize().
2126 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2127 Remove method getExpectedResultSize().
2129 2011-09-23 Ben Konrath <ben@bagu.org>
2131 Log which layout (list or details) the ignored item is from.
2133 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2135 2011-09-23 Ben Konrath <ben@bagu.org>
2137 Remove annotations that turn off code formatting in DataItem.
2139 * src/main/java/org/glom/web/shared/DataItem.java:
2141 2011-09-23 Ben Konrath <ben@bagu.org>
2143 Rename GlomField to DataItem and update associated methods.
2145 This is a rename-only refactor. No functionality has been added or
2148 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2149 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2150 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2151 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2152 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2153 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2154 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2155 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2157 * src/main/java/org/glom/web/server/database/DBAccess.java:
2158 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2159 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2160 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2161 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2162 * src/main/java/org/glom/web/shared/DataItem.java:
2163 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2164 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2166 2011-09-23 Ben Konrath <ben@bagu.org>
2168 Rename GlomDocument to DocumentInfo and update associated methods.
2170 This is a rename-only refactor. No functionality has been added or
2173 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2174 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2175 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2176 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2177 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2179 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2181 2011-09-20 Ben Konrath <ben@bagu.org>
2183 Require java-libglom 1.17.3.
2185 This picks up the fix for the seg fault problem with the Scenes table
2186 in the Openismus Film Manager example.
2190 2011-09-20 Ben Konrath <ben@bagu.org>
2192 Change the way sort clause is added for primary key when no sort clause is requested.
2194 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2195 before the sort clause is created. When a sort clause is not requested, the
2196 sort clause is created by finding the primary key in the LayoutFieldVector
2199 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2201 2011-09-20 Ben Konrath <ben@bagu.org>
2203 Log error message if no documents are found in the configured directory.
2205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2206 Extract the glom file extension string to a private static final class
2207 variable (mostly as syntactic sugar). Accept a minor formatting change.
2208 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2209 the example glom.document.directory configuration property to make it
2210 more clear that it can any directory, not just the home directory.
2212 2011-09-18 Ben Konrath <ben@bagu.org>
2214 Add related lists to details view.
2216 The related list table has support for paging and sorting just like the
2217 table in the list view.
2219 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2220 SQL queries for the related list tables.
2221 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2222 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2224 Rename getList methods to getListView and add comments. Remove
2225 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2226 it being unused. Add methods: getDetailsLayoutAndData(),
2227 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2228 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2229 Create the layout and set the data for the fields in one async call
2230 instead of two. Create related lists where appropriate.
2231 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2232 for method name changes in OnlineGlomService.
2233 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2234 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2235 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2237 * src/main/java/org/glom/web/client/ui/ListView.java:
2238 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2239 tableName from setCellTable(). Create a ListViewTable instead of
2241 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2242 represent a data field in the details view.
2243 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2244 from addDetailsCell() to Field class. Keep track of the Fields and
2245 Portals in the details view.
2246 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2247 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2248 and add a method to get it. Add method to set the contents of the
2250 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2251 New class for related list tables. This class has the data provider
2252 for the related list table.
2253 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2254 abstract class which is the base class for the ListViewTable and the
2256 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2257 New class for list view tables. This class has the data provider for
2258 the list view table.
2259 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2260 methods for related list tables. Add more information to the
2261 LayoutItemField and LayoutItemPortal DTOs.
2262 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2263 Remove debugging print statement.
2264 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2265 Remove debugging print statements. Add primary key field to SQL count
2267 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2268 Remove unnecessary LayoutFieldVector parameter from
2269 getResultSizeOfSQLQuery() method.
2270 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2271 New class for related list table database access.
2272 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2273 class that is a wrapper DTO for details view layout and data.
2274 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2275 new 'fromField' string to this DTO.
2276 * src/main/webapp/style.css: Remove bottom margin and override top
2279 2011-09-15 Ben Konrath <ben@bagu.org>
2281 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2283 This sets things up to make it easier to add the data retrieval for
2284 related lists (portals). No user noticeable changes were made with
2287 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2288 class has the code to retrieve the layouts and access the
2289 database using the new database helper classes.
2290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2291 Most of the functionality has been removed from this class. This
2292 class now represents the public interface for the client side
2293 code. It also deals with configuring the servlet and cleaning
2294 things up when the servlet is stopped.
2295 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2296 of static methods into this utility class.
2297 * src/main/java/org/glom/web/server/database/DBAccess.java:
2298 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2299 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2300 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2301 These classes have the database retrieval code. The class hierarchy
2302 has been setup to make it easy to reuse code for similar
2305 2011-09-06 Ben Konrath <ben@bagu.org>
2307 Create separate classes for list table code and the data provider.
2309 As part of this refactor, I also split up the code a bit to make it
2312 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2313 table code to two new classes (below).
2314 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2315 with code from ListViewImpl.
2316 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2317 New file with code from ListViewImpl.
2319 2011-09-06 Ben Konrath <ben@bagu.org>
2321 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2323 This fixes the LayoutItemPortal DTO to match the libglom layout object
2326 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2328 2011-09-01 Ben Konrath <ben@bagu.org>
2330 Set title of Portals in the Details View.
2332 * pom.xml: Bump required version of java-libglom to 1.17.1.
2333 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2334 widget creation to its own class. Add comments to constructor.
2335 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2336 The code is mostly from the Group class with the title now set.
2337 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2338 title of Portal. Update some comments. Fix some code formatting.
2340 2011-09-01 Ben Konrath <ben@bagu.org>
2342 Remove TODO comment for the flow table column width.
2344 The flow table column width is working correctly and doesn't need to be
2345 changed. See this mailing list post for more info:
2347 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2349 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2351 2011-08-27 Ben Konrath <ben@bagu.org>
2353 Add document title (database name) to top of the browser page.
2355 I added the document title to the TableSelecitonView but that will
2356 change if / when we add a view that doesn't require table selection.
2358 * mockups/details-contacts.html:
2359 * mockups/details-projects.html:
2360 * mockups/listview-contacts.html:
2361 * mockups/listview-projects.html:
2362 * mockups/style.css: Add document title to mockups to keep things
2364 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2365 sizes to account for the document title.
2366 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2367 Set the document title when it has been retrieved from the server.
2368 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2369 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2370 and implement setDocumentTitle(String) method.
2371 * src/main/webapp/style.css: Add ID for document title style.
2373 2011-08-25 Ben Konrath <ben@bagu.org>
2375 Add NavigationType enum to LayoutItemPortal DTO.
2377 This is the start of adding support for Portals to the Details View.
2379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2380 LayoutItem_Portal.navigation_type enum from libglom to
2381 LayoutItemPortal.NavigationType enum.
2382 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2383 NavigationType enum, field for storing the NavigationType and getter
2386 2011-08-25 Ben Konrath <ben@bagu.org>
2388 Implement the flow table layout in the Details View.
2390 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2391 FlowTable to Group to account for the renamed class.
2392 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2393 File. This is a container widget that implements the Glom details view
2394 flow table behaviour.
2395 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2396 org/glom/web/client/ui/FlowTable.java.
2397 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2398 so that the size of the subgroups are a closer match to the size of
2399 the Glom subgroups. This makes the flowtable layout match the layout
2400 in Glom for the Music Collection example file.
2402 2011-08-16 Ben Konrath <ben@bagu.org>
2404 Create container element for LayoutItemPortal in Details View.
2406 This will help me develop the layout for the FlowTable.
2408 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2409 fieldPanel variable to detailsCell.
2411 2011-08-15 Ben Konrath <ben@bagu.org>
2413 Set the height of the data element in the Details View.
2415 I changed the InlineLabels (text in a span element) to Labels (text in
2416 a div element) so that I could set the height of the details-data
2417 elements instead of the details-cell parent elements. This allows the
2418 the details-data element to display the correct height if style is
2419 applied that shows the height.
2421 This change has the added benefit of allowing the order of the labels
2422 and data elements to be changed for right-to-left languages.
2424 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2425 InlineLabels to Labels.
2426 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2427 InlineLabels to Labels. Set the height of the data element.
2428 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2429 multiline text height in the Formatting DTO.
2430 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2431 for multiline height along with getter and setter methods.
2432 * src/main/webapp/style.css: Adjust style to account for the change
2433 from span elements to div elements in the details cell.
2435 2011-08-15 Ben Konrath <ben@bagu.org>
2437 Make the List View appearance match the mockups.
2439 It doesn't match exactly but it's much better than it was.
2441 * mockups/listview-contacts.html: Remove unused css classes.
2442 * mockups/listview-projects.html: Remove unused css classes.
2443 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2444 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2445 for mainPanel instead of VerticalPanel (table). Set style name on
2446 CellTable. Set style name on Details column. Right-align Details
2448 * src/main/webapp/style.css: Adjust properties to match the mockups.
2450 2011-08-12 Ben Konrath <ben@bagu.org>
2452 Add better support for subgroups in the details view.
2454 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2455 changed FlowTable constructor.
2456 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2457 support for subgroups and subgroup-titles.
2458 * src/main/webapp/style.css: Add CSS class for subgroups and
2461 2011-08-12 Ben Konrath <ben@bagu.org>
2463 Return the top level LayoutGroup title.
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2467 2011-08-11 Ben Konrath <ben@bagu.org>
2469 Make the TableSelector header match the mockup.
2471 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2472 the layout panel. Properly lineup the table selection header with
2473 the list and details view.
2474 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2475 margin around the details view.
2476 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2477 Rename listBox variable to tableSelector. Set id for the style sheet.
2478 Use a FlowPanel instead of a HorizontalPanel.
2479 * src/main/webapp/style.css: Add properties to make the TableSelector
2480 box match the mockups.
2482 2011-07-13 Ben Konrath <ben@bagu.org>
2484 Update install script for java-libglom version change.
2486 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2489 2011-07-13 Ben Konrath <ben@bagu.org>
2491 Add support sub-group in the details view.
2493 I also removed the code that special-cased the default details view
2496 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2498 I still have to make a proper flowtable.
2500 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2501 Don't special-case default details view layout.
2502 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2503 addLayoutField() as I'm going to use it.
2504 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2505 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2507 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2508 extracted from DetailsViewImpl.GroupPanel. Add support for
2510 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2511 column count when getting the details layout.
2513 2011-07-12 Ben Konrath <ben@bagu.org>
2515 Set browser title with database and table titles.
2517 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2518 Set the browser title when the table changes and when the activity
2520 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2521 title when retrieving document info (the GlomDocument object).
2522 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2523 with getter and setter methods. Remove unused convenience constructor.
2524 Use default code formatting.
2526 2011-07-12 Ben Konrath <ben@bagu.org>
2528 Ignore LayoutItemPortals in the details view.
2530 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2533 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2534 LayoutItemPortal layout objects.
2535 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2536 LayoutItemPortal objects when retrieving the details layout.
2537 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2538 file. This is an empty class and just used to get type information for
2541 2011-07-12 Ben Konrath <ben@bagu.org>
2543 Use java-libglom 1.17.0.
2547 2011-07-11 Ben Konrath <ben@bagu.org>
2549 Remove "Table:" label from table selector.
2551 This matches a recent change in the Glom UI.
2553 * mockups/details-contacts.html:
2554 * mockups/details-projects.html:
2555 * mockups/listview-contacts.html:
2556 * mockups/listview-projects.html: Remove the "Table:" label from the
2558 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2560 2011-07-11 Ben Konrath <ben@bagu.org>
2562 Add main groups to the details view.
2564 This makes things look a little nicer in the details view. The next step
2565 is to implement the flowtable.
2567 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2568 resources from the standard gwt css theme. Standard.css is now
2569 included in OnlineGlom.html so that the online glom css rules have
2570 precedence over the gwt theme.
2571 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2572 the whole LayoutGroup to the DetailsView instead of just the titles.
2573 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2574 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2575 details layout with a helper class (GroupPanel). I might extract this
2576 class when I make the full flowtable.
2577 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2578 string as default so I don't have to worry about NPEs when processing
2580 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2581 note beside OnlineGlom.gwt.xml above).
2582 * src/main/webapp/style.css: Add default font-size to body to override
2583 the font-size set by the standard theme. Don't use h2 tags for
2584 group-title. Create new details-cell class.
2586 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2588 ConfiguredDocument: Set the port number too.
2590 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2591 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2592 Glom document. Presumably this worked sometimes so far because there is a
2593 default port number.
2595 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2597 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2599 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2600 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2601 correct, though we should throw an exception too.
2603 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2605 Fix a addDocuemnt typo.
2607 * src/main/java/org/glom/web/shared/Documents.java
2608 (Documents.addDocuemnt): Rename to addDocument().
2609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2610 (OnlineGlomServiceImpl.getDocuments): Adapt.
2612 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2614 Slightly improved log output when connection fails.
2616 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2617 (ConfiguredDocument.setUsernameAndPassword):
2618 We don't know for sure if it' the username/password that's wrong, so
2619 rephrase the message.
2620 Also ouput the exception message, though it's generic in this case.
2622 2011-07-08 Ben Konrath <ben@bagu.org>
2626 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2627 added braces to a one line if statement because the Eclipse formatter
2628 was getting confused.
2630 2011-07-07 Ben Konrath <ben@bagu.org>
2632 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2634 These should really be two separate tasks but I counldn't get things to
2635 work with GWT 2.2.0 and Eclipse 3.7.
2639 * .settings/org.eclipse.jdt.core.prefs:
2640 * .settings/org.eclipse.jdt.ui.prefs:
2641 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2642 * .settings/org.eclipse.m2e.core.prefs:
2643 Add new config files. Update current files. Remove references to the
2644 webtools plugins as we're not using any of the webtools features.
2645 * .gitignore: Add logs directory which is created when running with
2647 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2648 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2649 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2651 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2653 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2655 onlineglom.properties: Add explanatory comments.
2657 * src/main/resources/onlineglom.properties: Also change the default user
2658 from ben to someuser, to avoid the risk of people thinking we just
2659 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2661 2011-06-28 Ben Konrath <ben@bagu.org>
2663 Use filename in Log for incorrect passwords.
2665 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2666 getFileName(String) method to get the filename from the URI.
2668 2011-06-28 Ben Konrath <ben@bagu.org>
2670 Add the table name to the URL token for the ListPlace.
2672 This makes things consistent between the DetailsPlace and the
2673 ListPlace. It also allows the the ListPlace to be bookmarked.
2675 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2676 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2677 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2678 Remove getDefaultListLayout(). The default layout is now returned
2679 by the getListLayout() method when the table name is an empty string.
2680 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2681 Add table name field. Change to a new ListPlace when the table
2682 has been changed. Use getListLayout() for getting the default
2684 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2685 Add table name field. Set the correct table name in the list box
2686 when loading from bookmark. This corrects a problem for the
2688 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2689 Move table name to super-class (HasSelectableTable). Move document
2690 and table URL keys to super-class in HasSelectableTable.
2691 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2692 Add table name field. Add Tokenizer class with URL key common to
2693 the subclasses (DetailsPlace and ListPlace).
2694 * src/main/java/org/glom/web/client/place/ListPlace.java:
2695 Add table name. Add code to parse the URL token.
2696 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2697 Update ListPlace construction with empty table name string.
2698 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2699 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2700 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2701 Update ListPlace construction with table name string.
2702 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2703 Change defaultTableName field to tableName to reflect how it's now
2704 used. Update the getter and setter methods.
2706 2011-06-28 Ben Konrath <ben@bagu.org>
2708 Enable the table selector in the DetailsView.
2710 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2711 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2713 Remove getDefaultDetailsLayout(). The default layout is now returned
2714 by the getDetailsLayout() method when the table name is an empty
2716 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2717 event handler for table change event. Change to using
2718 getDetailsLayout() for the default details layout.
2719 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2721 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2722 when navigating to the details place.
2724 2011-06-27 Ben Konrath <ben@bagu.org>
2726 Use filename based unique document ID in URL and for RPC.
2728 The document ID is the glom document name with spaces (' ') replaced
2729 with pluses ('+') and without the .glom extension.
2731 This change is mostly a string substitution of 'documentTitle' for
2732 'documentID'. The only code change is the addition of a Documents DTO to get the
2733 filename to document title mappings as indicated below.
2735 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2736 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2737 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2738 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2739 Use Documents DTO to create the document links in the document
2741 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2742 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2743 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2744 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2745 * src/main/java/org/glom/web/client/place/ListPlace.java:
2746 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2747 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2748 * src/main/java/org/glom/web/client/ui/ListView.java:
2749 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2750 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2751 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2752 * src/main/java/org/glom/web/server/Log.java:
2753 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2754 getDocumentTitles() to getDocuments() and return the Documents DTO.
2755 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2756 transferring the filename to document title mappings.
2758 2011-06-25 Ben Konrath <ben@bagu.org>
2760 Make the authentication popup work again.
2762 This bug was introduced when I extracted ConfiguredDocument to its own class.
2764 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2765 correct success / fail status in setUsernameAndPassword().
2767 2011-06-25 Ben Konrath <ben@bagu.org>
2769 Use filename as unique key for configuring database usernames and passwords.
2771 This replaces the use of the Glom document title which could change
2772 depending on the locale. Thanks to Murray Cumming for pointing out this
2775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2776 * src/main/resources/onlineglom.properties:
2778 2011-06-24 Ben Konrath <ben@bagu.org>
2780 Pass primary key value to DetailsView.
2782 This enables the DetailsView to load the correct data.
2784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2785 primary key value field and set in constructor. Pass primary key
2786 value to getDetailsData().
2787 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2788 variables for document title and primary key value.
2789 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2790 key value to the DetailsPlace.
2792 2011-06-24 Ben Konrath <ben@bagu.org>
2794 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2796 This allows the primary key to be retrieved by the Details button. This
2797 functionality has not been implemented yet but it's in the works.
2799 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2800 the LayoutGroup result to ListView.setCellTable instead of all of its
2801 fields individually.
2802 * src/main/java/org/glom/web/client/ui/ListView.java:
2803 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2804 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2805 get the primary key for the table.
2806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2807 index of the primary key in the LayoutGroup accounting for hidden
2808 primary keys. Rename getJavaNumberFormat() to
2809 convertToJavaNumberFormat() for consistency. Cleanup / add some
2811 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2812 field for primary key index and a field to indicate whether the
2813 primary key is hidden or not.
2815 2011-06-23 Ben Konrath <ben@bagu.org>
2817 Rename getTableData methods to getListData.
2819 This is a rename refactor for consistency with other methods.
2821 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2822 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2823 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2826 2011-06-23 Ben Konrath <ben@bagu.org>
2828 Extract the ConfiguredDocument innerclass into its own class.
2830 This makes the servlet code more object oriented.
2832 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2833 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2835 new ConfiguredDocument class.
2837 2011-06-21 Ben Konrath <ben@bagu.org>
2839 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2841 This makes things more inline with how libglom works and reduces code
2842 duplication. This refactor lays the groundwork for adding the primary key to
2843 the LayoutGroup object.
2845 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2846 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2847 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2848 Change method names to getListLayout and getDefaultListLayout for
2849 consistency. Use LayoutGroup as the DTO for the list layout instead of
2850 ColumnInfo and LayoutListTable.
2851 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2852 new method names along with the LayoutGroup object for transferring the
2854 * src/main/java/org/glom/web/client/ui/ListView.java:
2855 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2856 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2857 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2859 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2860 Replaced with LayoutGroup.
2861 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2862 expectedResultSize and defaultTableName fields which are needed for
2864 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2865 type field which is needed for the list layout but will also be
2866 useful for the details layout as things progress.
2867 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2868 Make class abstract. Remove the unnecessary
2869 getFormattingHorizontalAlignment method. Add setFormatting method.
2871 2011-06-16 Ben Konrath <ben@bagu.org>
2873 Add scripts for building and installing war.
2875 These will help when updating OnlineGlom but they're also good
2876 supplemental documentation of the build and deployment proceeding.
2878 * utils/build-onlineglom-war.sh: New file.
2879 * utils/install-onlineglom-war.sh: New file.
2881 2011-06-16 Ben Konrath <ben@bagu.org>
2883 Create wrapper class to create consistent log messages.
2885 I wrapped methods in the Log class of gwt-log to add the method names
2886 from the servlet and create consistent formatting of the document title
2887 and table names in the log messages.
2889 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2891 log methods to use methods from wrapped Log class.
2893 2011-06-16 Ben Konrath <ben@bagu.org>
2895 Remove superfluous conditional return.
2897 Thanks to Murray Cumming for pointing this out!
2899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2901 2011-06-15 Ben Konrath <ben@bagu.org>
2903 Return an ArrayList of LayoutGroups for the Details layout.
2905 This corrects a problem with the details layout as it can have more
2906 than one top level LayoutGroup.
2908 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2909 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2910 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2911 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2913 with ArrayList of LayoutGroups for the details view layout.
2914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2915 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2916 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2917 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2918 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2919 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2921 2011-06-14 Ben Konrath <ben@bagu.org>
2923 Use cast_dynamic method to determine the libglom LayoutItem type.
2925 This is better than finding the LayoutItem type by using the string
2926 returned from the get_part_type_name() method.
2928 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2930 2011-06-14 Ben Konrath <ben@bagu.org>
2932 Add method names to log entries in the servlet.
2934 This helps when tracking down deployment problems.
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2938 2011-06-14 Ben Konrath <ben@bagu.org>
2940 Add data to the DetailsView using a hard-coded primary key value.
2942 The layout and functionality of the DetailsView is not complete. This
2943 is just a checkpoint so the patch doesn't get too big.
2945 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2946 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2947 Add getDetailsData() servlet method.
2948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2949 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2950 LayoutFields are added to the DetailsView.
2951 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2952 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2953 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2954 take the string for the title instead of the object.
2955 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2956 Add implementation getDetailsData() along with some private helper
2958 * src/main/webapp/style.css: Add padding to details-data class. Add a
2959 details-label class with the same padding as the details-data class.
2961 2011-06-03 Ben Konrath <ben@bagu.org>
2963 Use presenter.goTo() to change to the DetailsPlace.
2965 This will make things easier when we need to open the DetailsView with
2966 data specific to the row that was clicked.
2968 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2970 2011-06-02 Ben Konrath <ben@bagu.org>
2972 Add CSS file from mockups.
2974 I'm adding this now because it's going to be useful to have when
2975 developing the DetailsView. The TableSelectionView and ListView aren't
2978 * src/main/webapp/OnlineGlom.html:
2979 * src/main/webapp/style.css:
2981 2011-06-02 Ben Konrath <ben@bagu.org>
2983 Use String.isEmpty() to check for empty string.
2985 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2987 2011-06-02 Ben Konrath <ben@bagu.org>
2989 Display main layout group titles in the DetailsView.
2991 This is the start of the DetailsActivity/DetailsView implementation.
2993 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2994 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2995 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2996 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2997 Get the layout information for the details view from the server and set
2998 the main layout group titles.
2999 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3000 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3001 Add addLayoutGroup() and addLayoutField() methods. This are just
3002 temporary methods for creating the the details view that will change
3004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3005 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3007 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3008 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3009 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3010 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3011 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3012 Data Transfer Objects that mimic the libglom object structure. These are
3013 used for transferring the details layout but could also be used for
3014 transferring the list layout.
3016 2011-05-27 Ben Konrath <ben@bagu.org>
3018 Reset the AuthenticationPopup when clearing the ListView.
3020 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3022 2011-05-27 Ben Konrath <ben@bagu.org>
3024 Fix problem with onlineglom.properties file loading.
3026 The old way worked in Eclipse but not on the server. Loading the
3027 onlineglom.properties file now works in Eclipse and on the server.
3029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3031 2011-05-24 Ben Konrath <ben@bagu.org>
3033 Update gwt-log from 3.1.0 to 3.1.2.
3035 Gwt-log 3.1.0 has been marked as depreciated.
3039 2011-05-24 Ben Konrath <ben@bagu.org>
3041 Add comment to ListActivity.goTo() method.
3043 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3045 2011-05-24 Ben Konrath <ben@bagu.org>
3047 Remove FIXME in convertGdkColorToHtmlColour()
3049 The Gdk::Color value returned by libglom is 16-bits per channel on both
3050 64 and 32-bit platforms.
3052 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3054 2011-05-19 Ben Konrath <ben@bagu.org>
3056 Improve performance of initial ListView load.
3058 I removed a round trip to the server for getting the default table name
3059 and then requesting information about that table. This also removes a potential
3060 problem with the table change handler not being setup in time to receive the
3061 table change event from the ListActivity.
3063 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3064 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3065 getDefaultLayoutListTable() method. Improve comments.
3066 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3067 getDefaultLayoutListTable() method instead of firing a table change
3068 event to get the table to load.
3069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3070 implementation of getDefaultLayoutListTable() method.
3071 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3074 2011-05-19 Ben Konrath <ben@bagu.org>
3076 Override toDebugString() in TableChangeEvent.
3078 This is useful to have for debugging.
3080 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3082 2011-05-19 Ben Konrath <ben@bagu.org>
3084 Add a "Back to List" link when at the DetailsPlace.
3086 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3087 Populate the CellTable based on the selected table of the ListBox if
3088 it's set otherwise use the default table. This allows the "Back to
3090 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3091 Remove Place from constructors. Add a setPlace() method. Add
3092 goToPlace() method. Set class as presenter for TableSelectionView.
3093 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3094 Use the same TableSelectionActivity when switching between the List and
3096 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3097 Subclass the new HasSelectableTablePlace. This removes some duplicate
3099 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3100 New class to represent Places that display the TableSelectionView.
3101 * src/main/java/org/glom/web/client/place/ListPlace.java:
3102 Subclass the new HasSelectableTablePlace. This removes some duplicate
3104 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3105 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3106 Add Presenter interface. Add setBackLinkVisible() method. Add
3107 setBackLink() method.
3109 2011-05-18 Ben Konrath <ben@bagu.org>
3111 Enable the "Details" buttons.
3113 Right now only an empty details view is displayed.
3115 * src/main/java/org/glom/web/client/ClientFactory.java:
3116 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3117 Add DetailsView to ClientFactory.
3118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3119 A basic activity for the details view.
3120 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3121 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3123 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3124 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3126 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3127 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3128 unnecessary super() in constructor.
3129 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3130 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3131 really shouldn't create a new TableSelectionActivity for both the ListPlace
3132 and the DetailsPlace so this should be considered a temporary solution.
3133 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3134 New file. Represents a URL for the details view.
3135 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3136 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3137 A basic details view interface and implementation.
3138 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3139 Enable the "Details" buttons.
3141 2011-05-12 Ben Konrath <ben@bagu.org>
3143 Use a LayoutPanel with multiple display areas for main layout.
3145 This is mostly a refactor in that there are no changes from the user
3146 point of view. These changes are required so that we can swap out the list view
3147 with the details view when the user clicks the "Details" button.
3149 * src/main/java/org/glom/web/client/ClientFactory.java:
3150 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3151 OnlineGlomView. Add TableSelectionView, ListView and
3152 AuthenticationPopup.
3153 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3154 for main layout. Add display regions for main activities. Add
3155 activity manager for for main activities.
3156 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3157 file from parts of the deleted OnlineGlomActivity.
3158 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3159 New file from parts of the deleted OnlineGlomActivity.
3160 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3161 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3162 New files for app wide table change event.
3163 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3164 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3165 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3166 Activity mappers for the main activities replace the deleted app-wide
3168 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3169 Fix a spelling error in he comment.
3170 * src/main/java/org/glom/web/client/ui/ListView.java:
3171 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3172 Renamed from LayoutListView and modified for MVP. This still not a
3173 proper dumb view as prescribed by the MVP pattern but it works for now.
3174 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3175 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3176 New widget stripped out of the deleted OnlineGlomView.
3177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3178 Remove hack that is fixed by this patch.
3180 2011-05-06 Ben Konrath <ben@bagu.org>
3182 Rename OnlineGlomPlace to ListPlace.
3184 The only change besides the rename is that url will now display #list
3185 instead of #Document.
3187 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3188 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3189 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3190 * src/main/java/org/glom/web/client/place/ListPlace.java:
3191 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3193 2011-05-06 Ben Konrath <ben@bagu.org>
3195 Use Presenter for app navigation.
3197 This is the proper way to deal with Place (URL) changes with the MVP
3200 * src/main/java/org/glom/web/client/ClientFactory.java:
3201 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3202 PlaceHistoryMapper and PlaceHistoryHandler.
3203 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3204 PlaceHistoryMapper and PlaceHistoryHandler.
3205 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3206 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3207 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3208 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3209 Add Presenter interface and setPresenter methods. Rename addHyperLink
3210 to addDocumentLink taking only the document title as a parameter.
3212 2011-04-14 Ben Konrath <ben@bagu.org>
3214 Prompt for db username/password if they haven't been set.
3216 This is implemented with a popup widget that is contained within the
3217 OnlineGlomView and managed by the OnlineGlomActivity.
3219 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3220 methods for checking and setting the database username and password.
3221 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3222 new methods for checking and setting the database username and
3224 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3225 Display authentication popup if the JDBC connection to the database
3226 has not been authenticated.
3227 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3229 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods