1 2012-07-19 Murray Cumming <murrayc@murrayc.com>
3 SelfHoster.discoverFirstFreePort(): Close the socket.
5 * src/test/java/org/glom/web/server/SelfHoster.java:
6 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
8 2012-07-19 Murray Cumming <murrayc@murrayc.com>
10 Avoid another code warning in Eclipse Juno.
12 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
13 Do instanceof checks on the FileUtils.listFiles() result and its
16 2012-07-13 Murray Cumming <murrayc@murrayc.com>
18 Avoid some code warnings in Eclipse Juno
20 * src/main/java/org/glom/web/server/libglom/Document.java:
21 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
22 * src/test/java/org/glom/web/server/SelfHoster.java
23 createTextFile(): Make sure that the FileOutputStream is closed.
25 2012-06-22 Murray Cumming <murrayc@murrayc.com>
27 Added OnlineGlomPropertiesTest.
29 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
30 Make sure we never return a null string.
31 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
32 Added tests of the OnlineGlomProperties API, using our sample file.
34 2012-06-20 Murray Cumming <murrayc@murrayc.com>
36 Make OnlineGlomProperties be a normal class.
38 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
39 Move OnlineGlomProperties into its own file to be a regular class:
40 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
41 This makes testing simpler.
43 2012-06-15 Murray Cumming <murrayc@murrayc.com>
45 OnlineGlomServiceImpl.init(): Move some code into a new method.
47 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
50 2012-06-15 Murray Cumming <murrayc@murrayc.com>
52 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
54 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
55 OnlineGlomProperties.getKey(): Make this more robust by moving the
56 check for *.*.filename to here.
58 2012-06-15 Murray Cumming <murrayc@murrayc.com>
60 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
62 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
63 init(): Move knowledge of the config file format into the
64 OnlineGlomProperties inner class.
66 2012-06-15 Murray Cumming <murrayc@murrayc.com>
68 SelfHostExampleTest: Make sure we cleanup on failure.
70 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
71 the use of cleanup() to a tearDown() JUnit method.
73 2012-06-12 Murray Cumming <murrayc@murrayc.com>
75 ConfiguredDocument: Add a primary key to portals at least once.
77 * src/main/java/org/glom/web/server/ConfiguredDocument.java
78 updatePortalsExtras): Fix a typo so that we add the primary key
80 This is a fix for the previous commit:
81 ConfiguredDocument: Do not add a primary key to portals each time.
83 2012-06-08 Murray Cumming <murrayc@murrayc.com>
85 SelfHoster: Avoid some compiler warnings.
87 * src/test/java/org/glom/web/server/SelfHoster.java
88 executeCommandLineAndWait():
89 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
90 the now-unused streams for stdout and stderr from the command Processes.
91 These are not used because readln() hangs while waiting for a new line,
92 where there may be no next line. The commented out code is still there
93 to help us figure out how to do this properly.
95 2012-06-08 Murray Cumming <murrayc@murrayc.com>
97 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
99 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
100 Make this actually test the cloning again, though it is not very useful
101 now that we do not use the part that had a problem with cloning before.
103 2012-06-08 Murray Cumming <murrayc@murrayc.com>
105 SelfHoster: Keep trying pg_ctl after starting postgres.
107 * src/test/java/org/glom/web/server/SelfHoster.java
108 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
109 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
110 regular Glom. This seems mad but it seems to work because the first
111 command would fail if pg_ctl would eventually fail.
113 2012-06-08 Murray Cumming <murrayc@murrayc.com>
115 SelfHoster: Wait until the server is really ready.
117 * src/test/java/org/glom/web/server/SelfHoster.java
118 selfHost(): Attempt the connection after starting the server, retrying
119 a few times if necessary, so that the server is really ready already when
120 we return from this method.
121 The regular Glom code does this too because pg_ctl reports success too soon.
123 2012-06-08 Murray Cumming <murrayc@murrayc.com>
125 ConfiguredDocument: Do not add a primary key to portals each time.
127 * src/main/java/org/glom/web/server/ConfiguredDocument.java
128 updatePortalsExtras(): Only add an extra primary key field if there is
129 none, to avoid adding one each time we retrieve the details layout from the
131 This should fix bug #676986 (Ben Konrath)
133 2012-05-25 Murray Cumming <murrayc@murrayc.com>
135 Document.load(): Support version 7 documents.
137 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
138 database_title attribute if the title attribute is not there.
141 2012-05-24 Ben Konrath <ben@bagu.org>
143 Add configuration for auto-generating mvn:i18n from with Eclipse.
145 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
147 2012-05-24 Murray Cumming <murrayc@murrayc.com>
149 Update translations, adding French.
151 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
152 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
153 Add a French translation, using the translation from Glom.
155 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
156 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
157 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
158 Update these based on the translations from Glom.
160 2012-05-24 Murray Cumming <murrayc@murrayc.com>
162 SelfHoster: Add some debug println messages to help when things fail.
164 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
165 System.out.println() lines.
167 2012-05-23 Murray Cumming <murrayc@murrayc.com>
169 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
171 * src/test/java/org/glom/web/server/SelfHoster.java:
172 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
173 instance) instead of just /usr/bin (as on Fedora). Check the result when
176 2012-05-23 Murray Cumming <murrayc@murrayc.com>
178 Remove LayoutItemPortal.get/setNavigationTable().
180 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
181 Remove get/setNavigationTable(), which is only a cache, because it is not
182 used, and does not need to be used, because that decision should be made on
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
185 updatePortalsExtras():
186 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
187 getNavigationRecord():
188 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
191 2012-05-21 Murray Cumming <murrayc@murrayc.com>
193 Initial self-hosting for tests.
195 * pom.xml: Change the scope for log4j, to hopefully make it
196 available to the test code which uses it indirectly via jOOQ.
197 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
198 self-hosting, though we only use it for testing.
200 * src/main/java/org/glom/web/server/libglom/Document.java:
201 example rows: Use a map instead of a list for each row of values,
202 so we know what field they are for, instead of relying on the sequence
203 being correct. This is not very efficient, but it does not really need
205 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
206 testReadTableExampleRows(): Adapted.
208 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
209 that returns an Object, for generic use. Note that Object seems to be
210 the implicit base even of double.
211 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
212 for use in CREATE TABLE SQL queries.
213 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
214 to do self-hosting of PostgreSQL databases via its command-line
215 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
216 backends/postgres_self.cc. This is incomplete - it needs more
217 warnings about failures and it needs to clean up properly when things
219 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
220 test of this new class.
222 2012-05-21 Murray Cumming <murrayc@murrayc.com>
224 Document: loading example data: Handle exceptions.
226 * src/main/java/org/glom/web/server/libglom/Document.java:
227 DateFormat.parse() and Double.valueOf() can throw exceptions, though
228 Eclipse did not warn about that.
230 2012-05-20 Murray Cumming <murrayc@murrayc.com>
232 Document: load(), save(): Handle the example rows.
234 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
236 * src/main/java/org/glom/web/server/libglom/Document.java:
237 load(), save(): Load and save the example rows, though the date, time
238 and image types are not handled properly yet.
239 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
240 Add testReadTableExampleRows() just to check that something is read.
242 2012-05-20 Murray Cumming <murrayc@murrayc.com>
244 Document: Add save().
246 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
247 Added getTranslationsMap() for use while saving.
248 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
249 Adedd getUseDefaultFormatting() for use while saving.
250 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
251 and several private methods that it uses.
253 This will be useful while testing via self-hosting.
254 It is not complete, but should be complete enough for testing.
256 2012-05-17 Murray Cumming <murrayc@murrayc.com>
258 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
260 * src/main/java/org/glom/web/client/OnlineGlomService.java
261 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
263 Remove getSortedListViewData() and getSortedRelatedListData(), adding
264 the sort column index and ascending bool to the regular method.
265 Instead, a sort column index of -1 now means no sort.
266 This is less explicit, but it's fairly simple, reduces the amount of
267 code, and makes the OnlineGlomService API slightly smaller.
268 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
269 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
271 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
272 getListViewData(), getRelatedListData():
273 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
274 getListViewData(), getRelatedListData():
275 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
277 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
279 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
284 2012-05-16 Murray Cumming <murrayc@murrayc.com>
286 Use translations for top-level groups too.
288 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
289 updateTitlesForLocale(): Use the translation for the group
290 as well as for child items.
294 Just recompiled to fix a problem in the released .tar.gz file.
298 2012-05-15 Murray Cumming <murrayc@murrayc.com>
300 Corrections to navigation to related records.
302 * src/main/java/org/glom/web/client/OnlineGlomService.java:
303 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
305 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
306 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
307 relationship name, because the relationship name is not necessarily unique
309 TOOD: This is inefficient, because it passes the whole list of
310 child field items back to the server, but it is more correct, and happens
311 to fix a bug with the primary key being lost after a few navigations.
312 There is probably a chance to make this more efficient anyway in some
315 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
316 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
317 * src/main/java/org/glom/web/server/ConfiguredDocument.java
318 * src/main/java/org/glom/web/server/database/DBAccess.java
319 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
320 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
323 2012-05-15 Murray Cumming <murrayc@murrayc.com>
325 Fix the use of translations.
327 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
328 Add updateTitlesForLocale().
329 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
330 Call it to discard unwanted translations and to make getTitle() return
331 the wanted translation wihout the need for the client code to specify a locale.
332 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
333 getTitle(): Fallback to the original title, as libglom does.
335 2012-05-15 Murray Cumming <murrayc@murrayc.com>
337 Document: Correctly report the number of available translation locales.
339 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
340 the available locale IDs list.
341 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
342 testLocales: Test this.
344 2012-05-15 Murray Cumming <murrayc@murrayc.com>
346 SqlUtils: Use camelCase.
348 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
349 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
350 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
351 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
352 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
353 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
355 2012-05-15 Murray Cumming <murrayc@murrayc.com>
357 Use jOOQ's tableByName() and fieldByName.
359 * pom.xml: Use jOOQ 2.3.1 to get the new API.
360 * src/main/java/org/glom/web/server/SqlUtils.java:
361 build_sql_select_step_with_where_clause(), .createField(),
362 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
363 so we can get correct quoting and escaping. Thanks to Lukas Eder for
364 adding this, and other things, to jOOQ.
366 2012-05-15 Murray Cumming <murrayc@murrayc.com>
368 SqlUtils: Remove the Connection parameters.
370 * src/main/java/org/glom/web/server/SqlUtils.java:
371 build_sql_select_with_key(), build_sql_select_with_where_clause(),
372 createSelect(), build_sql_select_step_with_where_clause(),
373 build_sql_count_select_with_where_clause(),
374 build_sql_select_count_rows(): Remove the Connection parameter because
375 jOOQ does not actually need a connectionwhen it is just used to build
377 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
379 * src/main/java/org/glom/web/server/ReportGenerator.java:
381 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
383 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
384 Constructor, getListData(), getResultSizeOfSQLQuery():
385 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
386 getSelectQuery(), getCountQuery():
387 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
388 getSelectQuery(), getCountQuery():
389 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
390 getNavigationRecord(): Adapted.
392 2012-05-14 Murray Cumming <murrayc@murrayc.com>
396 * src/main/java/org/glom/web/server/SqlUtils.java:
397 get_find_where_clause_quick(): Use a comparison of
398 lowercase values, instead of a simple equals. Regular Glom
399 uses the PostgreSQL ILIKE operator but jOOQ does not
400 support that just yet, though it will soon.
402 2012-05-14 Murray Cumming <murrayc@murrayc.com>
404 TableToViewDetails: Use a real serialization ID.
406 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
407 Though this does not fix the serialization problem.
409 2012-05-12 Murray Cumming <murrayc@murrayc.com>
411 Added LayoutItemPortalDeepCloneTest.
413 2012-05-11 Murray Cumming <murrayc@murrayc.com>
415 Make navigation work again.
417 * src/main/java/org/glom/web/server/libglom/Document.java:
418 Add getLayoutItemFieldShouldHaveNavigation().
419 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
420 Replace get/setAddNavigation() with the partly-existing
421 get/setNavigationTableName(), with an empty string being no navigation,
422 because this is simpler. Use the new
423 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
425 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
426 Add updateFieldsExtras() and call setNavigationTableName in it.
427 getDetailsLayoutGroup(),
428 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
429 createLayout(): Adapted.
430 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
431 Constructor: Adapted.
433 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
434 Replace get/setAddNavigation() with get/setNavigation(), returning a
435 TableToViewDetails class with both the table name and UsesRelationship,
436 because both are need. The previous code used java-libglom's output
437 variable (strangely, via sharedptr) to return both, but we cannot really
439 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
440 getNavigationRecord(): Adapt. However, we cannot actually use the cache
441 here because it somehow gets set to null during deepCopy(). I must test this.
442 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
443 testGetSuitableTableToViewDetails(): Adapted.
445 TODO: Find out why deepClone() is not quite working.
447 2012-05-11 Murray Cumming <murrayc@murrayc.com>
449 DBAccess: Simplify the retrievel of full field details.
451 * src/main/java/org/glom/web/server/database/DBAccess.java
452 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
453 because the Document loading should have done this.
455 2012-05-11 Murray Cumming <murrayc@murrayc.com>
457 Document: Correct loading of doubly-related layout fields.
459 * src/main/java/org/glom/web/server/libglom/Document.java:
460 loadUsesRelationship(): Actually set the related relationship, instead
461 of only setting it if it's not found.
463 2012-05-09 Murray Cumming <murrayc@murrayc.com>
465 Replace all appearances of Colour with color.
467 Because US English is dominant.
469 2012-05-09 Murray Cumming <murrayc@murrayc.com>
471 Use colors in HTML format, solving a warning about an unused function.
473 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
474 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
475 Add *asHTMLColor() versions of methods.
476 TODO: However, we should create and cache the results on the server.
477 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
478 * src/main/java/org/glom/web/client/ui/list/ListTable.java
479 * src/main/java/org/glom/web/server/ConfiguredDocument.java
480 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
481 Use the asHTMLcolor() versions.
483 2012-05-09 Murray Cumming <murrayc@murrayc.com>
485 ListViewTable: Constructor: Take the table name as a parameter.
487 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
488 Constructor: Take the tableName, and set the member variable, because
490 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
491 setCellTable(): Pass the table name.
492 This makes navigation to non-default tables work again. I don't know
493 why it worked before in the master branch.
495 2012-05-07 Murray Cumming <murrayc@murrayc.com>
497 ConfiguredDocument: Restore correct addition of hidden primary key items.
499 * src/main/java/org/glom/web/client/ui/list/ListTable.java
500 (ListTable.createCellTable): Uncomment out the check for the hidden
502 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
503 add primary key items for top-level lists and portals, as before,
504 instead of adding them to each group.
505 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
506 Actually implement the extra methods such as setHiddenPrimaryKey() and
507 comment that these are used only for top-level list groups and in portals.
508 This strangeness suggests even more that this should not be squeezed
509 into the LayoutGroup class.
511 2012-05-07 Murray Cumming <murrayc@murrayc.com>
513 Fix Formatting loading.
515 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
516 getFormattingUsed(): Remove the duplicate Formatting member variable
517 in favour of the one from the base class.
518 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
519 Initialize a new Formatting instead of using null by default, so we
520 have some defaults, instead of having to initialize one later just to
521 get the same defaults. This also makes loading of formatting from the
522 document work, because that expected a non-null.
524 2012-05-07 Murray Cumming <murrayc@murrayc.com>
526 RelatedListTable: Make sure that the tableName is set.
528 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
529 Constructor: Take the tableName so it is available later. Otherwise,
530 the server assumes that we mean the default table and cannot find the
532 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
533 setData(): Pass the tableName to the RelatedListTable constructor.
535 2012-05-07 Murray Cumming <murrayc@murrayc.com>
539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
540 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
541 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
543 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
545 * src/main/java/org/glom/web/server/database/DBAccess.java:
546 convertResultSetToDTO(), getPortal():
547 * src/main/java/org/glom/web/server/database/ListDBAccess.java
549 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
550 Add checks for null objects and out of range access, with log messages to
551 give hints so we can fix these properly.
553 2012-05-07 Murray Cumming <murrayc@murrayc.com>
555 Portals: some corrections.
557 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
559 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
560 constructor: Use getRelationshipNameUsed() instead of getName(), because
561 that is what is meant.
562 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
563 getFromField(): Fix a typo, to get the field name, not the table name.
564 * src/main/java/org/glom/web/server/database/DBAccess.java:
565 getPortal(): Fix a typo that stopped this from working.
567 2012-05-07 Murray Cumming <murrayc@murrayc.com>
569 LayoutItemPortal: Also override getTitleOriginal().
571 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
572 This lets the base getTitle() with no parameters work.
573 TODO: Test this properly.
575 2012-05-06 Murray Cumming <murrayc@murrayc.com>
577 LayoutItemPortal: getTitle*(): Use the relationship title.
579 2012-05-06 Murray Cumming <murrayc@murrayc.com>
581 LayoutItemField: Fix loading of custom titles.
583 * src/main/java/org/glom/web/server/libglom/Document.java
584 loadDataLayoutItemField(): The title, if any, instead of the field
585 title, is stored in a title_custom node. Load it from there.
586 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
588 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
589 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
590 getTitle*() overrides.
591 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
594 2012-05-06 Murray Cumming <murrayc@murrayc.com>
596 LayoutItemField: Fall back to field titles, so some are really shown.
598 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
599 Override getTitleOriginal() and getTitle(), as in java-libglom.
600 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
603 2012-05-06 Murray Cumming <murrayc@murrayc.com>
605 Correct use of setExpectedResultSize().
607 * src/main/java/org/glom/web/server/ConfiguredDocument.java
608 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
609 Use setExpectedResultSize only on top-level groups (for instance, the
610 list layout) or on child portals (in details views).
611 Use the correct table name for portals to avoid SQL errors.
612 Update the expected counts when returning cached layouts.
614 2012-05-06 Murray Cumming <murrayc@murrayc.com>
616 Document: Interpret no group column count as 1.
618 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
619 default, though we now check for this in the UI code anyway.
621 2012-05-06 Murray Cumming <murrayc@murrayc.com>
625 2012-05-06 Murray Cumming <murrayc@murrayc.com>
627 Translatable: Use Hashmap instead of Treemap because GWT supports it.
629 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
630 The use of Treemap lead to this error from async methods, with no
632 "The response could not be deserialized"
634 2012-05-06 Murray Cumming <murrayc@murrayc.com>
636 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
638 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
639 when using the Google -> GWT Compile, or
640 g toolbar button -> GWT Compile Project... feature in Eclipse.
642 2012-05-06 Murray Cumming <murrayc@murrayc.com>
644 ListTable.addColumn(): Protect against a null Formatting.
646 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
647 Create a default Formatting if it is null, because that is the simplest
650 2012-05-06 Murray Cumming <murrayc@murrayc.com>
652 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
654 * src/main/java/org/glom/web/server/ConfiguredDocument.java
655 updateLayoutGroup(): Check that the field is not null.
657 2012-05-06 Murray Cumming <murrayc@murrayc.com>
659 ListViewImpl: Protected against a bad cast error.
661 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
662 onEnterKeyDown(): Do not cast without an instanceof check.
664 2012-05-06 Murray Cumming <murrayc@murrayc.com>
666 ListTable: Protect against an out of range error.
668 * src/main/java/org/glom/web/client/ui/list/ListTable.java
669 createCellTable(): This is unlikely, but can happen while debugging.
671 2012-05-06 Murray Cumming <murrayc@murrayc.com>
673 AsyncMessage onFailure() callbacks: Log the exception message.
675 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
676 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
677 * src/main/java/org/glom/web/client/activity/ListActivity.java:
678 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
679 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
680 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
681 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
682 These are useful clues when something is wrong.
684 2012-05-06 Murray Cumming <murrayc@murrayc.com>
686 ConfiguredDocument: Avoid a null dereference.
688 * src/main/java/org/glom/web/server/ConfiguredDocument.java
689 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
690 details maps are created.
692 2012-05-06 Murray Cumming <murrayc@murrayc.com>
694 Document: Correct the port number parsing.
696 * src/main/java/org/glom/web/server/libglom/Document.java:
697 This lets us actually connect to the database and show the document.
699 2012-05-05 Murray Cumming <murrayc@murrayc.com>
703 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
704 user-interaction, asking us to load a temporary URL in a browser.s
705 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
706 which is apparently necessary for testing the service. See the comment.
707 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
708 Show the exception, if any. This is how I saw the 404 in the HTML in
711 2012-05-05 Murray Cumming <murrayc@murrayc.com>
713 DocumentTest: Move the .glom files into the resources directory.
715 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
716 URI via getResource().
718 2012-05-05 Murray Cumming <murrayc@murrayc.com>
720 Document: Remove the FieldIdentifies inner class.
722 * src/main/java/org/glom/web/server/libglom/Document.java: We only
723 use the Relationship (though the same function in libglom is maybe
724 used in other ways) and so this removes a compiler warning.
726 2012-05-05 Murray Cumming <murrayc@murrayc.com>
728 Document.load() Remove the error code parameter.
730 * src/main/java/org/glom/web/server/libglom/Document.java: load():
731 Remove the parameter. We do not set it yet and it could never have
732 worked as an output parameter (though maybe it did in java-libglom).
733 We could use an exception if we really want the failure reason.
734 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
736 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
737 setUp(), testGetSuitableTableToViewDetails(): Adapt.
739 2012-05-05 Murray Cumming <murrayc@murrayc.com>
741 Make some inner classes static.
743 * src/main/java/org/glom/web/server/ConfiguredDocument.java
744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
745 * src/main/java/org/glom/web/server/ReportGenerator.java
746 * src/main/java/org/glom/web/server/libglom/Document.java
747 Make all inner classes static that can be static.
749 2012-05-05 Murray Cumming <murrayc@murrayc.com>
751 OnlineGlomServiceImpl: Do not load and check for java-libglom.
753 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
754 init(): We do not use java-libglom any more.
756 2012-05-05 Murray Cumming <murrayc@murrayc.com>
758 Remove mentions of java-libglom.
760 * README: Remove mention of java-libglom, because it no longer needed.
761 * utils/build-onlineglom-war.sh:
762 * utils/check-and-recover-tomcat.py:
763 * utils/install-onlineglom-war.sh: Remove these as they are no longer
764 useful. Building is now far easier, with no need for jhbuild.
766 2012-05-05 Murray Cumming <murrayc@murrayc.com>
768 Fix the build (mvn package)
770 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
771 (LayoutGroup): Make the LayoutItemList inner class static and protected.
772 Otherwise the GWT Java->Javascript compilation fails with just this
773 error, during mvn package or when attempting to view in a browser,
774 in the GWT developer mode in Eclipse.
776 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
777 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
778 [INFO] Compiling module org.glom.web.OnlineGlom
779 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
780 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
781 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
782 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
783 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
784 [INFO] [ERROR] Cannot proceed due to previous errors
786 It has taken me 2 days to find out what was causing that. After reducing
787 the code, the compiler eventually showed me the full error message.
789 2012-05-04 Murray Cumming <murrayc@murrayc.com>
791 ConfiguredDocument: Cache the cloned and stripped layouts.
793 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
794 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
795 layout in a map, so we can retrieve it again without rebuilding it.
797 2012-05-04 Murray Cumming <murrayc@murrayc.com>
799 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
801 2012-05-04 Murray Cumming <murrayc@murrayc.com>
803 libglom classes: Implement some auto-generated emthods.
805 2012-05-04 Murray Cumming <murrayc@murrayc.com>
807 Add GwtTestOnlineGlomService.
809 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
810 However, this (and the other GwtTest*) does not seem to run during
813 2012-05-04 Murray Cumming <murrayc@murrayc.com>
815 Remove use of unsupported features from client code.
817 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
818 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
819 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
820 Use our client version of StringUtils instead of the apache commons one.
822 However, the GWT Javascript compliation still fails.
824 2012-04-25 Murray Cumming <murrayc@murrayc.com>
826 Add a Field class and implement some loading of it in Document.
828 2012-04-25 Murray Cumming <murrayc@murrayc.com>
830 Initial Document loading implementation, instead of libglom.
832 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
833 and Translatable classes, and adapt the rest of the code to use them.
834 However, this is still missing Layout and Field classes and loading.
836 2012-04-24 Murray Cumming <murrayc@murrayc.com>
838 Use of jOOQ: Move Field creation into a utility method.
840 * src/main/java/org/glom/web/server/SqlUtils.java:
841 This lets us improve it more easily.
843 2012-04-24 Murray Cumming <murrayc@murrayc.com>
845 Use of jOOQ: Improve the code to COUNT a sub-select.
847 * src/main/java/org/glom/web/server/SqlUtils.java:
848 Move initial query creation into
849 build_sql_select_step_with_where_clause().
850 build_sql_select_count_rows(): Use the jOOQ API instead of
851 concatentating text, because a jOOQ Select*Step is a TableLike,
852 which is what from() takes.
854 2012-04-23 Murray Cumming <murrayc@murrayc.com>
856 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
858 * pom.xml: Depend on jooq.
859 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
860 methods with jOOQ, based on the C++ implementations in libglom,
861 with some changes to the logic required by jooQ.
862 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
864 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
865 * src/main/java/org/glom/web/server/ReportGenerator.java:
866 * src/main/java/org/glom/web/server/SqlUtils.java:
867 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
868 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
869 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
870 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
871 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
872 Adapt. In particular, the SqlUtils methods now need to take a Connection,
873 because jOOQ needs that, though it seems unnecessary.
875 This is not quite finished. Ideally jOOQ would help us to build
876 table_name.field_name names, quoting and escaping them properly.
877 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
879 2012-04-21 Murray Cumming <murrayc@murrayc.com>
881 Move use of Glom.build_sql*() into a new SqlUtils class.
883 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
884 to wrap Glom.build_sql*(). The parameter types are still Glom one,
885 but this will make it easier to start using something other than
886 libglom or SqlBuilder.
888 2012-04-21 Murray Cumming <murrayc@murrayc.com>
890 Update the project URL.
892 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
894 2012-04-21 Murray Cumming <murrayc@murrayc.com>
896 Main layout: Use a FlowTable instead of absolute positioning.
898 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
899 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
900 child panels/widgets must have an absolute position. But that is annoying, so
901 this adds a FlowTable and puts the child panels in there.
903 2012-04-21 Murray Cumming <murrayc@murrayc.com>
905 GwtTestOnlineGlom: Comment out unused code.
907 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
908 Eclipse has started to say that some code is unused.
910 2012-04-21 Murray Cumming <murrayc@murrayc.com>
912 Update to the latest versions of dependencies.
914 * pom.xml: Update version numbers of dependencies to the latest
916 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
917 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
918 * src/main/java/org/glom/web/server/ReportGenerator.java:
919 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
920 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
921 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
923 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
924 Modify the imports where necessary.
926 2012-04-17 Murray Cumming <murrayc@murrayc.com>
928 Style: Remove overflow:hidden from searchbox
930 * src/main/webapp/style.css: Because this pushes the Back To Link
931 label/link on to the next row, which is then hidden due to the
932 hard-coded (in ems) height.
934 2012-04-20 Murray Cumming <murrayc@murrayc.com>
936 Remove some duplicate code.
938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
939 getDocumentInfo(): This must have been duplicated during the merge from the
944 2012-04-19 Murray Cumming <murrayc@murrayc.com>
946 Reports: Localize the waiting for report message.
948 * src/main/java/org/glom/web/client/activity/ReportActivity.java
949 start(): Get the message from the contants.
950 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
952 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
953 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
954 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
955 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
956 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
957 Update these files with the English text for newer strings for now.
959 2012-04-19 Murray Cumming <murrayc@murrayc.com>
961 Reports: Show a message while waiting for the report.
963 * src/main/java/org/glom/web/client/ui/ReportView.java
964 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
965 Add setWaitingText(), to show a message saying that we are
966 waiting for the report to be ready.
967 * src/main/java/org/glom/web/client/activity/ReportActivity.java
968 start(): Call setWaitingText() before calling the async
971 2012-04-19 Murray Cumming <murrayc@murrayc.com>
973 ReportGenerator: Specify date and time formats.
975 * src/main/java/org/glom/web/server/ReportGenerator.java:
976 createFieldValueElement(): Use the default (and localized)
977 short formats, though we still need a way to show 4-digit
978 years without providing the format for every locale.
979 * src/main/java/org/glom/web/server/database/DBAccess.java:
980 convertResultSetToDTO(): Use the short formats here too.
982 2012-04-18 Murray Cumming <murrayc@murrayc.com>
984 ReportGenerator: Use the correct numeric formatting.
986 * src/main/java/org/glom/web/server/ReportGenerator.java
987 createFieldExpression(), createFieldValueElement(): Take the
988 whole LayoutItem_Field instead of just the field name, so
989 we have access to the formatting.
990 createFieldValueElement(): Use JRTextField.setPattern() to
991 specify the numeric formatting, with the help of a
992 regular DecimalFormat.
994 2012-04-18 Murray Cumming <murrayc@murrayc.com>
996 ReportGenerator: Avoid showing null for group by titles.
998 * src/main/java/org/glom/web/server/ReportGenerator.java
999 generateReport(): Use setBlankWhenNull() on the field title
1000 style too, because this is used for values in group by
1003 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1005 ReportGenerator: Add a colon to titles in vertical groups.
1007 * src/main/java/org/glom/web/server/ReportGenerator.java
1008 addFieldToDetailBandVertical(): Pass true for the withColon
1011 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1013 ReportGenerator: Simplify the code by using Position more.
1015 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1017 Reports: Support vertical groups, roughly.
1019 * src/main/java/org/glom/web/server/ReportGenerator.java:
1020 addToReport(): Rename to addGroupToReport() and, if necessary,
1021 call the new addVerticalGroupToReport() method.
1022 createFieldValueElement(): Let the caller specify the Y position
1025 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1027 Reports: Allow a second report to be shown.
1029 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1030 clear(): Do not remove the HTML widget, which broke the whole layout.
1032 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1034 Locales drop-down: Show that we use English by default.
1036 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1037 fillView(): When we use English, just because that is the default, when
1038 no locale is specified, show that in the Locales drop-down instead of
1039 just showing the first item.
1041 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1043 Unselect the Report/Locale/Table combo item when appropriate.
1045 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1046 setPlace(): clear reportName if this is not a ReportPlace.
1047 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1048 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1049 When the provided name is empty, unselect all items, so that none are
1050 indicated. This uses a for loop because I cannot find a single method
1053 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1055 Report: Give the user a way to get back to the list.
1057 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1058 start(), setPlace(): Show the Back To List link on reports, and also
1059 interpret selecting the empty report item as back to list.
1061 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1063 Really show the selected Report name.
1065 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1066 setPlace(): Store the reportName here, if it is that kind of Place.
1067 fillView(): Set the selected Report after filling the list of reports.
1068 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1069 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1070 null Strings, though we need some way to unselect all ListBox items
1073 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1075 ReportGenerator: Try to avoid some problems.
1077 * src/main/java/org/glom/web/server/ReportGenerator.java
1078 addField(): Try to avoid duplicates, and avoid using a null
1081 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1083 Reports: Use quickFind.
1085 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1086 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1088 getReportHTML(): Add a quickFind parameter.
1089 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1090 start(): Pass the quickFind parameter.
1091 * src/main/java/org/glom/web/server/ReportGenerator.java
1092 generateReport(): Take a quickFind parameter.
1094 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1096 ReportPlace: Actually use the report name.
1098 * src/main/java/org/glom/web/client/place/ReportPlace.java
1099 getPlace(): Do not assign the report name to the quickfind.
1101 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1103 Show java.library.path when complaining.
1105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1106 init(): When telling us to check java.library.path, show the
1109 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1111 ReportGenerator: Do not show nulls.
1113 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1115 ReportGenerator: Make the title font larger.
1117 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1119 ReportGenerator: Put field titles inside groups, if there are groups.
1121 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1123 ReportGenerator: Take the Report itself instead of the name and group.
1125 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1126 Remove getReportLayoutGroup().
1127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1128 getReportHTML(): Pass the report instead
1129 of its name and layout group.
1130 * src/main/java/org/glom/web/server/ReportGenerator.java
1131 generateReport(): Use the report object to use the title
1132 instead of the name.
1134 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1136 ReportGenerator: Remove designBand parameters.
1138 * src/main/java/org/glom/web/server/ReportGenerator.java:
1139 Make designBand a class member instead of passing it to all
1142 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1144 ReportGenerator: Add lines, a bit like in the desktop version.
1146 * src/main/java/org/glom/web/server/ReportGenerator.java
1147 addToReport(): Use JRDesignLine.
1149 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1151 ReportGenerator: Correct the title positions and use some bold style.
1153 * src/main/java/org/glom/web/server/ReportGenerator.java:
1154 Break the code up into reusable functions, correct the placement of
1155 titles, and use normal/bold styles as in the reports in the desktop
1158 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1160 ReportGenerator: Add a header band to show the field titles.
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1163 getReportHTML(): Pass the localeId to the ReportGenerator
1165 * src/main/java/org/glom/web/server/ReportGenerator.java
1166 constructor: Take the localeID so we can get translated field
1168 generateReport(), addToReport(), addFieldToBand(): Add field
1169 titles in a column header band.
1171 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1173 Reports drop-down list: Some improvement.
1175 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1176 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1177 Adedd setSelectedReport(),
1178 setReportList(): Add a blank line so that the user can select the
1180 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1181 start(): Show the current report by calling setSelectedReport().
1182 This does not seem to work yet.
1184 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1186 DetailsActivity, ListActivity: Move some variables into a base class.
1188 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1189 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1190 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1191 the clientFactory, documentID, tableName and authenticationPopup into
1192 a base class, to avoid duplication.
1194 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1196 Translate the Reports label.
1198 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1199 Get the "Reports" label string from the constants.
1200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1201 perties: Add Reports to the constants.
1203 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1205 Reports: Implement grouping.
1207 * src/main/java/org/glom/web/server/ReportGenerator.java:
1208 Handle LayoutItem_GroupBy items and try to do the right thing
1209 with JRDesignGroup. It seems to work.
1211 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1213 Actually show some data with JasperReports.
1215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1216 getReportHTML(): Move most code into a ReportGenerator class.
1217 * src/main/java/org/glom/web/server/ReportGenerator.java:
1218 Recurse into sub-groups, adding fields to the JasperDesign's details
1219 band. Note that we must set an arbitrary width and height, or it just
1220 will not show any data.
1222 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1224 Reports Chooser: Show the titles, not the names.
1226 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1227 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1228 and the names as the values.
1229 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1230 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1231 group now that we provide the report name, so it should always
1234 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1236 Depend on jasperreports.
1238 * pom.xml: Add the dependency. My plan is to use this on the
1241 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1243 Implement navigation to report places.
1245 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1246 start(): Do not bother to handle all events here.
1247 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1248 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1249 Added getSelectedReport().
1250 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1251 .java: start(): When handling a change to the reports chooser,
1252 call getSelectedReport() and goTo() its ReportPlace.
1253 * src/main/java/org/glom/web/client/ui/ReportView.java
1254 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1255 Added setReportHTML() which puts the html in a gwt HTML widget.
1256 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1257 getReportHTML(): Return "TODO" just to show that this works.
1259 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1261 Make ReportPlace usable.
1263 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1264 Mention ReportPlace.
1265 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1266 Correct the @prefix annotation.
1268 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1270 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1272 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1273 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1274 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1275 Change getReportLayout() to getReportHMTL() because we will not need to
1276 parse or render the report layout on the client side.
1277 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1278 getReportLayout(): Return the libglom LayoutGroup type because we will
1279 not need to convert to a shared type, because this will not be used on
1281 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1284 Note that there is still no implementation for this.
1287 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1289 Add a (empty) Report Place, View, and Activity.
1291 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1293 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1294 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1295 this into a superclass:
1296 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1297 and also use it as the base of this new ReportPlace:
1298 * src/main/java/org/glom/web/client/place/ReportPlace.java
1300 * src/main/java/org/glom/web/client/ui/ReportView.java
1301 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1302 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1303 Add these, containing mostly boiler-plate for now.
1305 * src/main/java/org/glom/web/client/OnlineGlomService.java
1306 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1307 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1308 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1309 Add API to get the LayoutGroup for the report.
1311 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1313 Add and fill a Reports drop-down list box.
1315 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1317 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1318 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1319 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1320 Added getReports(document, table, localeID), calling
1321 ConfiguredDocument.getReports().
1322 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1323 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1324 Added setReportsList() and a list widget.
1325 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1326 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1331 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1333 Translations: Add Esperanto.
1335 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1336 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1337 properties: Add this translation because someone took the time to make it.
1339 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1341 Adapt to the java-libglom 1.21.7 API.
1343 * src/main/java/org/glom/web/server/ReportGenerator.java:
1344 addToReport(): get_group_secondary_fields() is now
1345 get_secondary_fields().
1348 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1350 Use the latest java-libglom version.
1352 * pom.xml: Use java-libglom 1.21.7.
1354 2012-03-03 Ben Konrath <ben@bagu.org>
1356 Display date and time in details view.
1358 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1360 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1362 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1364 Require the latest java-libglom.
1366 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1368 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1370 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1372 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1373 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1374 an empty quickfind string. I also corrected libglom to create only
1375 empty where clauses for empty quickfind strings, but this avoids the
1378 2012-02-24 Ben Konrath <ben@bagu.org>
1380 Improve the tabs in the Notebook widget.
1384 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1386 Translations: Try to translate the strings.
1388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1390 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1391 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1392 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1393 Take the Open translation from GTK+'s .po files.
1394 Take the Details translation from Glom's po files.
1395 I have added the other strings to Glom so we can get translations that way:
1396 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1398 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1400 TableSelectionViewImpl: Put the search label and entry in a div.
1402 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1403 Put the search widgets in a FlowTable so that the CSS can be used to
1404 style them while keeping them together.
1405 * src/main/webapp/style.css: Mention the new div.
1407 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1409 Translate more strings in more locales.
1411 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1412 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1413 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1414 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1415 Translate the "Details" and "Open" string too.
1417 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1418 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1419 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1420 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1421 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1422 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1423 Add these new locales as placeholders though they currently contain English.
1425 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1427 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1430 Check the ConfiguredDocument* for null before using it.
1432 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1434 Tell Eclipse about the generated java files.
1436 * .classpath: This lets it find OnlineGlomConstants.java.
1437 It would be nice if Eclipse just used the maven build files.
1439 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1441 Prevent a crash when no locale is specified in the URL.
1443 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1444 Avoid returning a null string, obtained from
1445 Window.Location.getParameter(). This caused a crash when it was
1446 later passed to libglom's API.
1447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1448 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1449 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1450 guard against future null strings.
1452 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1454 Use the ?locale= query param instead of the &lang= token param.
1456 * src/main/java/org/glom/web/client/place/ListPlace.java
1457 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1458 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1459 Remove the lang token key and value.
1461 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1462 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1463 When the user selects a different locale from the chooser, use
1464 Window.Location.assign() to change the URL, which then causes a reload.
1466 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1467 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1468 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1469 * src/main/java/org/glom/web/client/activity/ListActivity.java
1470 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1471 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1472 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1473 * src/main/java/org/glom/web/client/ui/ListView.java:
1474 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1476 Remove localeID member variables and method/constructor parameters, instead
1477 using Utils.getCurrentLocaleID() when we need a localID to pass to
1480 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1482 Internationalize the UI strings.
1484 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1485 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1486 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1487 because it is unused. Messages are apparently strings that can have
1488 parameters, but we do not need that yet, so Contants will be enough for now.
1489 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1490 to say that we support the en and de locales.
1491 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1492 The original English strings.
1493 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1494 Some German translations of the English strings.
1495 The i18n goal then uses the .properties file to generate an
1496 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1497 returns an implementation that returns the translated strings.
1498 The documentation suggests putting these in src/java/*/client/, but it seems
1499 best to put it in src/resources/*/client/.
1500 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1501 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1502 instead of hard-coding them.
1503 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1504 but that does not seem to stop the build, though it confuses Eclipse.
1506 You can see the translated string by adding ?locale=de to the URL, like so:
1507 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1509 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1511 Improve null/empty String checks.
1513 * pom.xml: Add a dependency on commons-lang, to use
1514 org.apache.commons.lang.StringUtils.
1515 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1517 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1518 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1519 Use StringUtils.isEmpty().
1521 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1522 StringUtils class with a static isEmpty() function because we
1523 cannot use org.apache.commons.lang.StringUtils in client-side
1524 GWT code because it (apparently) cannot be compiled to javascript.
1525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1526 * src/main/java/org/glom/web/client/activity/ListActivity.java
1527 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1528 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1529 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1530 * src/main/java/org/glom/web/client/place/ListPlace.java
1531 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1532 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1533 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1534 * src/main/java/org/glom/web/client/ui/details/Group.java
1535 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1536 our StringUtils.isEmpty() function.
1538 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1540 Update to the latest java-libglom API.
1542 * pom.xml: Require java-libglom 1.21.4.
1543 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1544 getDocumentInfo(), getListViewLayoutGroup():
1545 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1547 * src/main/java/org/glom/web/server/database/DBAccess.java
1548 getFieldsToShowForSQLQueryAddGroup(),
1549 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1550 with either get_database_title_original() or
1551 get_database_title(localeID).
1553 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1555 ConfiguredDocument: Avoid a null pointer exception.
1557 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1558 Initialize localeID to "" to avoid returning a null String which
1559 causes a crash in java-libglom's swing-generated code.
1561 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1563 Some simple renaming.
1565 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1566 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1567 for localeChooser. This seems more appropriate and is less ambiguous
1568 particularly in the .css file.
1570 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1572 ConfiguredDocument: Rename the localedID private member variable.
1574 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1576 Adapt to the latest java-libglom API from git master.
1578 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1579 libglom now uses only Vector instead of List, which uses add() instead of
1582 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1584 ConfiguredDocument: Rename the localedID private member variable.
1586 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1588 Build a source tarball with mvn assembly:single
1590 * assembly.xml: Add this file.
1591 * pom.xml: Use the maven-assembly-plugin and tell it to use
1592 our assembly.xml file.
1594 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1596 OnlineGlomServiceImpl: Get .glom files recursively.
1598 * pom.xml: Depend on commons-io from org.apache.commons.
1599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1600 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1601 files recursively, and with the easier filter for the extension.
1602 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1603 simplify that code too.
1605 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1607 README: Mention that you must install java-libglom packages separately.
1609 But then it works, because java-libglom is now in the central maven
1612 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1614 locales drop-down: Show the correct selected locale when the URL changes.
1616 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1617 .java: setPlace(): Move some code into fillView().
1619 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1621 locales drop-down: Do not lose the primary key.
1623 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1624 start(): onLocaleChange(): Pass the current primary key value,
1625 instead of an empty value.
1627 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1629 locales drop-down: Do not lose the drop-down selection.
1631 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1632 .java (TableSelectionActivity.fillView): Set the selected locale
1633 after changing the drop-down items (though we do not really need
1634 to change them just because the locale changes.)
1636 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1638 locales drop-down: Change the tables list when this changes.
1640 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1641 .java: TableSelectionActivity.start(): Move the async table titles
1642 retrieval into a private fillView() method and also call this when
1643 the chosen locale changes.
1644 Note that the document title is not actually translatable yet, but
1645 that is a problem that I should fix soon in libglom.
1647 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1649 Improve the placement of the locales drop-down.
1651 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1652 Put the title and locales drop-down in a div (gwt.FlowTable).
1653 * src/main/webapp/style.css: Add magic css properties to make this work.
1654 Also remove the left margin from the title so that it lines up with the
1657 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1659 locales selector: Show human-readable locale titles.
1661 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1662 getDocumentInfo(): Use java.util.Locale to show a real title of
1663 each locale, in the locale's own language.
1665 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1667 Add a language/locale selector drop-down.
1669 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1670 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1671 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1672 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1673 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1675 Add a ListBox to show the available locales. Add getLocaleSelector(),
1676 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1677 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1678 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1679 java: Add these classes.
1680 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1681 start(): Fill the locales ListBox. Handle its change event, firing a
1683 setPlace(): Show the selected locale as specified by the URL token.
1684 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1685 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1686 Handle LocaleChangeEvent, going to a new *Place with that locale.
1688 The placement of the ListBox is not pretty, and it currently uses the ID
1689 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1693 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1695 Search box: Show the search text from the URL token.
1697 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1698 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1699 Add setQuickFindText().
1700 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1701 .java: setPlace(): Store the queryText if the place is a ListPlace,
1702 and call TableSelectionView.setQuickFindText().
1704 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1706 Allow use of translations via, for instance, &lang=de in the URL.
1708 * pom.xml: Use the unstable java-libglom 1.21 version.
1710 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1711 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1713 init(): Instead of calling TranslatableItem.set_current_locale()
1714 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1715 However, this is only for default locales, which are not needed to
1716 change the locale in the URL.
1717 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1718 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1719 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1720 layout for a particular locale.
1721 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1722 Add get/setDefaultLocaleID().
1723 getDocumentInfo(), getListViewData(), getRelatedListData(),
1724 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1725 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1726 localeID parameter, so we can get the layout for a particular locale.
1728 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1729 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1730 * src/main/java/org/glom/web/client/place/ListPlace.java:
1731 Parse and construct a lang parameter too.
1733 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1734 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1735 passed to subsequent methods and constructors.
1736 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1737 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1738 Store the localeID from the *Place and pass it to other constructors
1739 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1741 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1742 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1743 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1744 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1745 * src/main/java/org/glom/web/client/ui/ListView.java:
1746 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1747 Take localeID parameters and pass them to subsequent constructors and
1748 methods, so that the layout is always retrieved for that locale.
1750 This is rather repetitive.
1752 Note that "" means the original (default) locale of the Glom document,
1753 which is usually English.
1755 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1757 Documents: Remove final keyword to fix startup configuration.
1759 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1760 final keywords on the private member variables because that breaks
1761 the startup, apparently (there are warnings) because it stops them
1762 from being serialized. I added these in the previous commit.
1764 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1766 Documents: Add some final keywords.
1768 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1771 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1773 OnlineGlomServiceImpl: Add to overview comments.
1775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1776 Note that this is where all the document are loaded. They are not
1777 loaded freshly for each page.
1779 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1783 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1784 Add a TextBox for the text of a quick find.
1785 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1787 setBackLink(): Add a String quickFind parameter.
1788 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1789 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1790 to the base interface, because that is how TableSelectionViewImpl is used.
1791 * src/main/webapp/style.css: Add style for the search box and its label.
1793 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1794 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1795 Add these files, based on the existing TableChangeEvent and
1796 TableChangeEventHandlers.
1797 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1798 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1799 a ListPlace() that the user should be taken to.
1800 * src/main/java/org/glom/web/client/activity/ListActivity.java
1801 start(): Handle it here too and adapt the TableChangeEvent handler to
1802 pass the extra "" quickFind parameter to ListPlace.
1803 * src/main/java/org/glom/web/client/place/ListPlace.java:
1804 Constructor: Take an extra String quickFind parameter and store it,
1805 returning it from a new getQuickFind() method.
1806 getToken(): Put the quickFind text in the URL token.
1807 getPlace(): Parse the quickFind text from the URL token.
1808 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1809 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1810 ListPlace constructor.
1811 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1812 .java: start(): Add a Change handler for the TableSelectionView's
1813 TextBox (via its base HasChangeHandlers interface), firing the new
1814 QuickFindChangeEvent.
1815 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1816 pass the extra "" quickFind parameter.
1818 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1819 setCellTable(): Add a String quickFind parameter and pass it to
1820 the ListViewTable() constructor.
1821 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1822 setCellTable() in the base interface, because that is how ListViewImpl
1825 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1826 Add a String quickFind member variable.
1827 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1828 Constructor: Add a String quickFind parameter, storing it in the
1829 base ListTable's member variable.
1830 onRangeChanged(): Pass quickFind to the
1831 OnlineGlomServiceAsync.getSortedListViewData() and
1832 OnlineGlomServiceAsync.getListViewData() methods.
1834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1835 getListViewData(), getSortedListViewData(): Add a String quickFind
1836 parameter, passing it to ConfiguredDocument.getListViewData().
1837 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1838 Change getListViewData(), getSortedListViewData() in the base interface,
1839 because that is how OnlineGlomServiceImpl is used, via this:
1840 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1841 Change getListViewData(), getSortedListViewData() here too.
1842 This class can apparently be used to asynchronously call methods on
1843 OnlineGlomService, and GWT seems to implement that after recognizing
1844 just the *Async name convention and the extra AsyncCallback parameters.
1846 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1847 getListViewData(): Add a String quickFind parameter, and pass it to
1848 ListViewDBAccess.getData().
1849 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1850 getListData(): Add a String quickFind parameter and pass it to
1852 getSelectQuery(): Add a String quickFind parameter.
1853 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1854 getSelectQuery(): Add a String quickFind parameter and use it with
1855 Glom.get_find_where_clause_quick() to pass a where_clause to
1856 Glom.build_sql_select_with_where_clause(), to actually filter the
1858 getData(): Add a String quickFind parameter, passing it to getListData().
1859 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1860 va: getData(): Pass an empty string to getListData() for the
1861 quickFind parameter.
1863 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1865 ListTable: Minor change.
1867 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1868 createCellTable(): Make this protected instead of public.
1870 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1872 Many files: Use final for the parameters and use the @override attribute.
1874 2012-01-22 Ben Konrath <ben@bagu.org>
1876 Add anchor links for single line text that starts with http, ftp and www.
1880 2012-01-22 Ben Konrath <ben@bagu.org>
1882 Add ellipsis to single line text in details view.
1886 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1888 Remove all javadoc author tags.
1890 Because they are awkward and meaningless when many people touch
1892 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1894 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1896 Revert the COPYING.LESSER to COPYING rename.
1898 Apparently both should be there if it is LGPL.
1900 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1902 *View: Remove unused imports.
1904 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1905 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1906 * src/main/java/org/glom/web/client/ui/ListView.java:
1907 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1908 Remove unused imports, as suggested by Eclipse.
1910 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1912 Move the *View::Presenter types, and some API into one base View.
1914 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1915 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1916 * src/main/java/org/glom/web/client/ui/ListView.java:
1917 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1918 Presenter, setPresenter() and clear() into a shared base interface,
1919 to avoid the unnecessary duplicate Presenter types and to more clearly
1920 show how the *Views share the same structure, even if they are not
1921 used polymorphically.
1923 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1924 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1926 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1927 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1928 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1930 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1933 Feel free to revert this if there is a good reason for the duplicate
1936 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1938 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1940 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1941 a class member instead of a local variable in the method.
1942 This lets us use it to get the view instances, for use in tests.
1943 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1944 beforeOnlineGlom(): Test some more details of the initial view.
1945 Again, this is not very useful.
1947 To really test gwt-glom we will need to start a local postgresql
1948 instance with local data, like the Glom tests in C++.
1950 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1952 pom.xml: Mention the LGPL license.
1954 * pom.xml: Add a licenses section.
1955 * COPYING.LESSER: Move this to COPYING, which
1956 previously contained the GPL. But gwt-glom is all LGPL.
1958 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1960 Add project information to README and pom.xml.
1962 * README: Add a brief description and mention some mvn
1964 * pom.xml: This extra information shows up in mvn site
1967 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1969 Use the latest java-libglom version.
1971 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1973 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1975 GwtTestOnlineGlom: Test a little more.
1977 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1978 protected rather than private, as suggested by the gwt-test-utils
1980 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1981 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1982 Test the initial visibility of the panels.
1984 However, this is not a very useful test.
1985 And I wonder how we should generally test using this idea for an
1986 activity/places app like ours where the real changes happen implicitly
1987 based on the history token/URL.
1989 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1991 Slight modification to *Mapper comments.
1993 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1994 (DataActivityMapper)
1995 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1997 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1999 Remove comments mentioning GIN because they are just copied from
2000 the example code and are apparently not helpful:
2001 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2002 Also change the mention of a class that is only in the example code.
2004 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2006 GwtTestOnlineGlom test: Minor changes.
2008 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2009 Avoid the long qualified class name and modify the comment
2010 because it is now obvious to me that the mocked class is the only
2011 custom one created via GWT.create().
2013 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2015 Tests: Added the beginnings of a test using gwt-test-utils.
2017 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2018 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2019 which tells gwt-test-utils what class will be tested.
2020 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2021 Add a simple (but empty) test case. One class, used by the OnlineGlom
2022 class, is mocked so that it can be created. However, I am not sure
2023 why only this class needs to be mocked.
2025 Note that mockito seems more popular, and clearer, than easymock,
2026 but I have not got that working yet. It might be a matter of the
2029 This test is run during mvn integration-test.
2031 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2033 Tests: Use junit4-style syntax instead of junit3-style.
2035 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2036 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2037 * src/test/java/org/glom/web/shared/DataItemTest.java:
2038 Use the @Test annotation rather than relying on the test*() prefix.
2039 Also no longer implement TestCase, to avoid triggering support for
2040 the junit3-way, which stops the annotations from working.
2041 Change the imports from import junit.framework.* to
2042 import org.junit.*, which is apparently the new way.
2044 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2046 Added a test for ListPlace token parsing and creation.
2048 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2049 This is much the same as DetailsPlaceTest.
2051 I wonder how we could test the other parts of the *Place API.
2053 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2055 DetailsPlace test: Also test getToken() and recreation via getPlace().
2057 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2058 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2059 recreate it, testing the recreated DetailsPlace for the same parameter
2062 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2064 Use the surefire-report plugin.
2066 * pom.xml: This generates a HTML report about the tests in
2067 target/site/surefire-report.html
2068 when you do mvn surefire-report:report. It seems to be popular/normal.
2070 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2072 Added a test for DetailsPlace.
2074 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2075 Test the getPlace() token parsing.
2077 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2079 Added a first unit test.
2081 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2082 * src/test/java/org/glom/web/shared/DataItemTest.java:
2083 This is a silly test but it is just to get things started. Note that
2084 maven/junit finds the test because it looks in src/test by default.
2086 2011-12-22 Ben Konrath <ben@bagu.org>
2088 Change charsetName to "UTF-8" when replacing line breaks.
2090 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2091 that work in Java (such as "UTF8") will not work when compiled to
2094 This fixes a problem with multi-line details view fields that have hard
2095 line breaks. The "License Text" field on this page demonstrates the
2098 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2100 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2102 2011-12-22 Ben Konrath <ben@bagu.org>
2104 Fix another bug with related list navigation.
2106 I've tested all the navigation buttons in all of the related lists
2107 so things should be good now.
2109 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2111 2011-12-22 Ben Konrath <ben@bagu.org>
2113 Fix a crasher when refreshing the list view with the default table.
2115 This crash will also happen when loading the list view with the default
2116 table from a link or bookmark.
2118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2119 to the main document selection page when the document id hasn't been
2121 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2122 the main document selection page when the document id hasn't been
2124 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2125 values for the details place when the document id hasn't been set.
2126 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2127 values for the list place when the document id hasn't been set.
2129 2011-12-21 Ben Konrath <ben@bagu.org>
2131 Protect against NPE when glom.document.locale is not in config.
2133 This patch protects against an NPE when glom.document.locale is not in
2134 the config file. This NPE will also happen if glom.document.locale is
2137 The patch also updates the error message to display the class name when
2138 the getMessage() returns null. This was happening when the NPE was
2139 thrown and I had "Configuration Error: null". If an NPE is encountered
2140 with this patch, "Configuration Error: NullPointerException " will be
2143 This commit closes this bug:
2145 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2149 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2151 Rename onlineglom.properties to onlineglom.properties.sample.
2153 * src/main/resources/onlineglom.properties: Rename to:
2154 * src/main/resources/onlineglom.properties.sample:
2155 * src/main/resources/README: And add this file explaining that people
2156 should rename it back when deploying.
2158 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2160 Allow choosing the translation in the .properties file.
2162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2163 init(): Read a glom.document.locale value from the configuration file
2164 and call Glom's TransatableItem::set_current_locale() method.
2165 * src/main/resources/onlineglom.properties: Add a commented-out
2166 example of this new setting.
2168 It would be better to add &lang=de_DE to the URL, but the current
2169 libglom API does not allow us to do this easily. I am working on that.
2171 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2173 Avoid a crash in parsing of token parameters.
2175 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2176 ava: getTokenParams(): Do not crash if a parameter has a key but no
2177 value, and ignore parameters with neither.
2179 2011-12-17 Murray Cumming <murrayc@murayc.com>
2181 History token building/handling: Improve use of token parameters.
2183 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2184 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2185 and buildParamsToken(HashMap), for use by derived classes.
2186 Make the separator private because it is no longer be needed.
2187 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2188 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2189 instead of manual string concatenation.
2190 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2191 of hardcoded indices and awkward splitting code.
2192 * src/main/java/org/glom/web/client/place/ListPlace.java
2193 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2194 instead of manual string concatenation.
2195 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2196 of hardcoded indices and awkward splitting code.
2197 This should fix bug #666420
2199 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2201 Fix a Navgiation->Navigation typo in the code.
2203 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2204 Rename processNavgiation() to processNavigation().
2206 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2208 Fix a seperator->separator typo in the code.
2210 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2211 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2212 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2215 2011-12-15 Ben Konrath <ben@bagu.org>
2217 Cleanup some comments.
2219 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2221 2011-12-14 Ben Konrath <ben@bagu.org>
2223 Replace \n with <br/> for multiline text in the details view.
2225 Vertical scrollbars are added when needed as well.
2227 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2229 2011-12-14 Ben Konrath <ben@bagu.org>
2231 Specify the font for document selection links.
2233 * src/main/webapp/style.css:
2235 2011-12-14 Ben Konrath <ben@bagu.org>
2237 Fix bouncy CellTable while paging.
2239 This doesn't currently work with related list tables in unselected
2242 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2244 2011-12-14 Ben Konrath <ben@bagu.org>
2246 Revamp the appearance of the document selection page.
2248 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2249 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2250 * src/main/webapp/style.css:
2252 2011-12-13 Ben Konrath <ben@bagu.org>
2254 Set navigation button column to the smallest size possible.
2256 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2258 2011-12-13 Ben Konrath <ben@bagu.org>
2260 Change OpenButton nomenclature to NavigationButton.
2262 Using NavigtionButton makes things more generic. Classes, methods and
2263 variables have been changed.
2265 This is a rename-only refactor.
2267 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2268 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2269 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2270 Renamed from OpenButtonCell.
2271 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2272 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2273 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2275 2011-12-12 Ben Konrath <ben@bagu.org>
2277 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2279 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2280 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2281 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2282 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2284 2011-12-12 Ben Konrath <ben@bagu.org>
2286 Update variable names and comments.
2288 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2289 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2291 2011-12-12 Ben Konrath <ben@bagu.org>
2293 Properly initialize numNonEmptyRows variable to zero.
2295 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2296 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2298 2011-12-05 Ben Konrath <ben@bagu.org>
2300 Add latest mockup with HTML tables.
2302 Features of this mockup:
2304 -> HTML table for flowtable
2305 -> HTML table for flowtable column
2306 -> Example of how related lists would look
2307 -> Not using text entries for data items
2309 The current version of Online Glom doesn't use HTML tables for the
2312 This mockup has been sent to the glom-devel mailing list but it's good
2313 to have it here as well.
2315 * mockups/details-view-html-tables.html:
2317 2011-12-05 Ben Konrath <ben@bagu.org>
2319 Remove unnecessary getPrimaryKeyField() method.
2321 getPrimaryKeyFieldForTable(String) has been renamed to
2322 getPrimaryKeyField(String).
2324 * src/main/java/org/glom/web/server/database/DBAccess.java:
2325 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2326 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2328 2011-12-05 Ben Konrath <ben@bagu.org>
2330 Add string representation of TypedDataItem value to conversion error message.
2332 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2333 message was extracted into its own method to avoid duplication.
2335 2011-12-05 Ben Konrath <ben@bagu.org>
2337 Add type checking to navigation primary key value creation.
2339 Create navigation primary key only if the expected type from the Glom
2340 document matches the type returned by the SQL query.
2342 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2344 2011-12-05 Ben Konrath <ben@bagu.org>
2346 Rename a couple of variables in RelatedListNavigation.
2348 This is a rename-only refactor.
2350 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2352 2011-12-05 Ben Konrath <ben@bagu.org>
2354 Move getListLayoutGroup() into getListViewLayoutGroup().
2356 This removes getListLayoutGroup(). It was only being called by
2357 getListViewLayoutGroup().
2359 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2361 2011-12-05 Ben Konrath <ben@bagu.org>
2363 Remove check for LayoutItem_Portal in list table method.
2365 This check is no longer necessary because the method isn't being used
2366 to create the LayoutItemPortal DTO.
2368 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2370 2011-12-05 Ben Konrath <ben@bagu.org>
2372 Properly support related list navigation.
2374 Navigation from the "Repository Analyzer -> Package Scans ->
2375 Dependencies" related table wasn't working because the primary key for
2376 related tables wasn't being set properly. This commit fixes the
2379 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2380 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2381 doesn't set the primary key properly for related list tables.
2382 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2383 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2384 useful for getting the primary key for list view tables and for related
2386 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2387 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2388 Move code to set the primary key for the table from the abstract
2389 ListDBAccess class to ListViewDBAccess as it's only correct for list
2391 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2392 Properly add primary key to related list tables.
2394 2011-12-02 Ben Konrath <ben@bagu.org>
2396 Properly set the horizontal alignment of fields.
2398 This fix is for both the list tables and the details view.
2400 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2401 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2402 to set the horizontal alignment of fields.
2404 2011-12-02 Ben Konrath <ben@bagu.org>
2406 Display currency codes in the details view.
2408 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2410 2011-12-02 Ben Konrath <ben@bagu.org>
2412 Avoid duplicate JNI call.
2414 JNI is not as efficient as pure Java and this is an easy (and small)
2417 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2418 Use previously retrieved value for whereClauseToTableName instead of
2421 2011-12-02 Ben Konrath <ben@bagu.org>
2423 Rename a couple of variables in RelatedListNavigation.
2425 This is a rename-only refactor.
2427 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2429 2011-12-02 Ben Konrath <ben@bagu.org>
2431 Indicate clearly that a mismatched primary key type is a bug.
2433 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2434 warning to error. Add 'This is a bug.' to message.
2436 2011-12-02 Ben Konrath <ben@bagu.org>
2438 Update / fix some comments.
2440 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2442 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2444 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2445 Fix comments. Add some TODOs.
2447 2011-12-02 Ben Konrath <ben@bagu.org>
2449 Enable navigation to details view with string primary key from related list.
2451 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2452 Create a text primary key value when return type of result is
2453 java.sql.Types.VARCHAR.
2455 2011-12-02 Ben Konrath <ben@bagu.org>
2457 Use checkboxes for booleans in the details view.
2459 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2461 2011-12-01 Ben Konrath <ben@bagu.org>
2463 Improve performance of related list height calculation.
2465 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2466 Put code to calculate the expected height in a static initializer so
2467 that that it's only called once.
2469 2011-12-01 Ben Konrath <ben@bagu.org>
2471 Show related list tables in notebooks (again).
2473 Calculate the height of the related list tables so the Notebook can be
2474 set the correct height. The height of the related list table is also needed by
2475 FlowTable to be able decide how to create the layout.
2477 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2478 and set the Portal height based on the height of the related list
2479 table and the Portal container.
2480 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2481 Add method to calculate the height of the related list tables.
2482 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2483 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2484 calculate the height of the Pager widget.
2486 2011-12-01 Ben Konrath <ben@bagu.org>
2488 Use CellTable API for table property instead of setting style on Element.
2490 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2492 2011-12-01 Ben Konrath <ben@bagu.org>
2494 Make ListViewTable and RelatedListTable a consistent height.
2496 The tables are now a consistent height regardless of the contents of
2497 the table. A hidden button is added to empty rows to ensure that the
2498 height of these rows will match the height of rows with data.
2500 A navigation button column is now added to every table. The width of
2501 the navigation column is set to 0px when a RelatedListTable shouldn't
2502 have navigation buttons. This maintains the a consistent row height in
2503 tables that don't show the navigation buttons.
2505 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2506 navigation column when not needed.
2507 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2508 arguments for navigation button to constructor of ListViewTable.
2509 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2510 hidden button for empty data rows.
2511 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2512 arguments for navigation button to constructor.
2513 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2514 create navigation buttons. Add hideNavigationButtons() method.
2515 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2516 arguments for navigation button to constructor.
2518 2011-12-01 Ben Konrath <ben@bagu.org>
2520 Use 'visibility: hidden' in Utils.getWidgetHeight().
2522 This is better choice because hidden elements are invisible, don't
2523 respond to events and are not part of the tab order. They will,