1 2012-01-23 Murray Cumming <murrayc@murrayc.com>
3 Add and fill a Reports drop-down list box.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
7 * src/main/java/org/glom/web/client/OnlineGlomService.java:
8 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
9 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
10 Added getReports(document, table, localeID), calling
11 ConfiguredDocument.getReports().
12 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
13 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
14 Added setReportsList() and a list widget.
15 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
16 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
18 2012-01-22 Murray Cumming <murrayc@murrayc.com>
20 ConfiguredDocument: Rename the localedID private member variable.
22 2012-01-20 Murray Cumming <murrayc@murrayc.com>
24 Build a source tarball with mvn assembly:single
26 * assembly.xml: Add this file.
27 * pom.xml: Use the maven-assembly-plugin and tell it to use
28 our assembly.xml file.
30 2012-01-19 Murray Cumming <murrayc@murrayc.com>
32 OnlineGlomServiceImpl: Get .glom files recursively.
34 * pom.xml: Depend on commons-io from org.apache.commons.
35 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
36 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
37 files recursively, and with the easier filter for the extension.
38 Use org.apache.commons.io.FilenameUtils.removeExtension() to
39 simplify that code too.
41 2012-01-19 Murray Cumming <murrayc@murrayc.com>
43 README: Mention that you must install java-libglom packages separately.
45 But then it works, because java-libglom is now in the central maven
48 2012-01-18 Murray Cumming <murrayc@murrayc.com>
50 locales drop-down: Show the correct selected locale when the URL changes.
52 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
53 .java: setPlace(): Move some code into fillView().
55 2012-01-18 Murray Cumming <murrayc@murrayc.com>
57 locales drop-down: Do not lose the primary key.
59 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
60 start(): onLocaleChange(): Pass the current primary key value,
61 instead of an empty value.
63 2012-01-18 Murray Cumming <murrayc@murrayc.com>
65 locales drop-down: Do not lose the drop-down selection.
67 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
68 .java (TableSelectionActivity.fillView): Set the selected locale
69 after changing the drop-down items (though we do not really need
70 to change them just because the locale changes.)
72 2012-01-18 Murray Cumming <murrayc@murrayc.com>
74 locales drop-down: Change the tables list when this changes.
76 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
77 .java: TableSelectionActivity.start(): Move the async table titles
78 retrieval into a private fillView() method and also call this when
79 the chosen locale changes.
80 Note that the document title is not actually translatable yet, but
81 that is a problem that I should fix soon in libglom.
83 2012-01-18 Murray Cumming <murrayc@murrayc.com>
85 Improve the placement of the locales drop-down.
87 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
88 Put the title and locales drop-down in a div (gwt.FlowTable).
89 * src/main/webapp/style.css: Add magic css properties to make this work.
90 Also remove the left margin from the title so that it lines up with the
93 2012-01-18 Murray Cumming <murrayc@murrayc.com>
95 locales selector: Show human-readable locale titles.
97 * src/main/java/org/glom/web/server/ConfiguredDocument.java
98 getDocumentInfo(): Use java.util.Locale to show a real title of
99 each locale, in the locale's own language.
101 2012-01-17 Murray Cumming <murrayc@murrayc.com>
103 Add a language/locale selector drop-down.
105 * src/main/java/org/glom/web/shared/DocumentInfo.java:
106 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
107 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
108 getDocumentInfo(): Store the available Locales in the DocumentInfo.
109 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
110 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
111 Add a ListBox to show the available locales. Add getLocaleSelector(),
112 setLocaleList(), getSelectedLocale(), setSelectedLocale().
113 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
114 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
115 java: Add these classes.
116 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
117 start(): Fill the locales ListBox. Handle its change event, firing a
119 setPlace(): Show the selected locale as specified by the URL token.
120 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
121 * src/main/java/org/glom/web/client/activity/ListActivity.java:
122 Handle LocaleChangeEvent, going to a new *Place with that locale.
124 The placement of the ListBox is not pretty, and it currently uses the ID
125 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
129 2012-01-17 Murray Cumming <murrayc@murrayc.com>
131 Search box: Show the search text from the URL token.
133 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
134 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
135 Add setQuickFindText().
136 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
137 .java: setPlace(): Store the queryText if the place is a ListPlace,
138 and call TableSelectionView.setQuickFindText().
140 2012-01-17 Murray Cumming <murrayc@murrayc.com>
142 Allow use of translations via, for instance, &lang=de in the URL.
144 * pom.xml: Use the unstable java-libglom 1.21 version.
146 * src/main/java/org/glom/web/client/OnlineGlomService.java:
147 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
149 init(): Instead of calling TranslatableItem.set_current_locale()
150 (now removed), call ConfiguredDocument.setDefaultLocaleID().
151 However, this is only for default locales, which are not needed to
152 change the locale in the URL.
153 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
154 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
155 getSortedRelatedListData(): Add a localeID parameter, so we can get the
156 layout for a particular locale.
157 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
158 Add get/setDefaultLocaleID().
159 getDocumentInfo(), getListViewData(), getRelatedListData(),
160 getDetailsLayoutGroup(), getListViewLayoutGroup(),
161 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
162 localeID parameter, so we can get the layout for a particular locale.
164 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
165 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
166 * src/main/java/org/glom/web/client/place/ListPlace.java:
167 Parse and construct a lang parameter too.
169 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
170 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
171 passed to subsequent methods and constructors.
172 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
173 * src/main/java/org/glom/web/client/activity/ListActivity.java:
174 Store the localeID from the *Place and pass it to other constructors
175 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
177 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
178 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
179 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
180 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
181 * src/main/java/org/glom/web/client/ui/ListView.java:
182 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
183 Take localeID parameters and pass them to subsequent constructors and
184 methods, so that the layout is always retrieved for that locale.
186 This is rather repetitive.
188 Note that "" means the original (default) locale of the Glom document,
189 which is usually English.
191 2012-01-17 Murray Cumming <murrayc@murrayc.com>
193 Documents: Remove final keyword to fix startup configuration.
195 * src/main/java/org/glom/web/shared/Documents.java: Remove the
196 final keywords on the private member variables because that breaks
197 the startup, apparently (there are warnings) because it stops them
198 from being serialized. I added these in the previous commit.
200 2012-01-13 Murray Cumming <murrayc@murrayc.com>
202 Documents: Add some final keywords.
204 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
207 2012-01-13 Murray Cumming <murrayc@murrayc.com>
209 OnlineGlomServiceImpl: Add to overview comments.
211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
212 Note that this is where all the document are loaded. They are not
213 loaded freshly for each page.
215 2012-01-12 Murray Cumming <murrayc@murrayc.com>
219 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
220 Add a TextBox for the text of a quick find.
221 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
223 setBackLink(): Add a String quickFind parameter.
224 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
225 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
226 to the base interface, because that is how TableSelectionViewImpl is used.
227 * src/main/webapp/style.css: Add style for the search box and its label.
229 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
230 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
231 Add these files, based on the existing TableChangeEvent and
232 TableChangeEventHandlers.
233 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
234 start(): Handle QuickFindChangeEvent, passing its quickFind text to
235 a ListPlace() that the user should be taken to.
236 * src/main/java/org/glom/web/client/activity/ListActivity.java
237 start(): Handle it here too and adapt the TableChangeEvent handler to
238 pass the extra "" quickFind parameter to ListPlace.
239 * src/main/java/org/glom/web/client/place/ListPlace.java:
240 Constructor: Take an extra String quickFind parameter and store it,
241 returning it from a new getQuickFind() method.
242 getToken(): Put the quickFind text in the URL token.
243 getPlace(): Parse the quickFind text from the URL token.
244 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
245 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
246 ListPlace constructor.
247 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
248 .java: start(): Add a Change handler for the TableSelectionView's
249 TextBox (via its base HasChangeHandlers interface), firing the new
250 QuickFindChangeEvent.
251 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
252 pass the extra "" quickFind parameter.
254 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
255 setCellTable(): Add a String quickFind parameter and pass it to
256 the ListViewTable() constructor.
257 * src/main/java/org/glom/web/client/ui/ListView.java: Change
258 setCellTable() in the base interface, because that is how ListViewImpl
261 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
262 Add a String quickFind member variable.
263 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
264 Constructor: Add a String quickFind parameter, storing it in the
265 base ListTable's member variable.
266 onRangeChanged(): Pass quickFind to the
267 OnlineGlomServiceAsync.getSortedListViewData() and
268 OnlineGlomServiceAsync.getListViewData() methods.
270 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
271 getListViewData(), getSortedListViewData(): Add a String quickFind
272 parameter, passing it to ConfiguredDocument.getListViewData().
273 * src/main/java/org/glom/web/client/OnlineGlomService.java:
274 Change getListViewData(), getSortedListViewData() in the base interface,
275 because that is how OnlineGlomServiceImpl is used, via this:
276 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
277 Change getListViewData(), getSortedListViewData() here too.
278 This class can apparently be used to asynchronously call methods on
279 OnlineGlomService, and GWT seems to implement that after recognizing
280 just the *Async name convention and the extra AsyncCallback parameters.
282 * src/main/java/org/glom/web/server/ConfiguredDocument.java
283 getListViewData(): Add a String quickFind parameter, and pass it to
284 ListViewDBAccess.getData().
285 * src/main/java/org/glom/web/server/database/ListDBAccess.java
286 getListData(): Add a String quickFind parameter and pass it to
288 getSelectQuery(): Add a String quickFind parameter.
289 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
290 getSelectQuery(): Add a String quickFind parameter and use it with
291 Glom.get_find_where_clause_quick() to pass a where_clause to
292 Glom.build_sql_select_with_where_clause(), to actually filter the
294 getData(): Add a String quickFind parameter, passing it to getListData().
295 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
296 va: getData(): Pass an empty string to getListData() for the
299 2012-01-12 Murray Cumming <murrayc@murrayc.com>
301 ListTable: Minor change.
303 * src/main/java/org/glom/web/client/ui/list/ListTable.java
304 createCellTable(): Make this protected instead of public.
306 2012-01-12 Murray Cumming <murrayc@murrayc.com>
308 Many files: Use final for the parameters and use the @override attribute.
310 2012-01-22 Ben Konrath <ben@bagu.org>
312 Add anchor links for single line text that starts with http, ftp and www.
316 2012-01-22 Ben Konrath <ben@bagu.org>
318 Add ellipsis to single line text in details view.
322 2012-01-04 Murray Cumming <murrayc@murrayc.com>
324 Remove all javadoc author tags.
326 Because they are awkward and meaningless when many people touch
328 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
330 2012-01-04 Murray Cumming <murrayc@murrayc.com>
332 Revert the COPYING.LESSER to COPYING rename.
334 Apparently both should be there if it is LGPL.
336 2012-01-03 Murray Cumming <murrayc@murrayc.com>
338 *View: Remove unused imports.
340 * src/main/java/org/glom/web/client/ui/DetailsView.java:
341 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
342 * src/main/java/org/glom/web/client/ui/ListView.java:
343 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
344 Remove unused imports, as suggested by Eclipse.
346 2012-01-02 Murray Cumming <murrayc@murrayc.com>
348 Move the *View::Presenter types, and some API into one base View.
350 * src/main/java/org/glom/web/client/ui/DetailsView.java:
351 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
352 * src/main/java/org/glom/web/client/ui/ListView.java:
353 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
354 Presenter, setPresenter() and clear() into a shared base interface,
355 to avoid the unnecessary duplicate Presenter types and to more clearly
356 show how the *Views share the same structure, even if they are not
357 used polymorphically.
359 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
360 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
362 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
363 * src/main/java/org/glom/web/client/activity/ListActivity.java:
364 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
366 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
369 Feel free to revert this if there is a good reason for the duplicate
372 2012-01-02 Murray Cumming <murrayc@murrayc.com>
374 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
376 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
377 a class member instead of a local variable in the method.
378 This lets us use it to get the view instances, for use in tests.
379 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
380 beforeOnlineGlom(): Test some more details of the initial view.
381 Again, this is not very useful.
383 To really test gwt-glom we will need to start a local postgresql
384 instance with local data, like the Glom tests in C++.
386 2012-01-02 Murray Cumming <murrayc@murrayc.com>
388 pom.xml: Mention the LGPL license.
390 * pom.xml: Add a licenses section.
391 * COPYING.LESSER: Move this to COPYING, which
392 previously contained the GPL. But gwt-glom is all LGPL.
394 2012-01-02 Murray Cumming <murrayc@murrayc.com>
396 Add project information to README and pom.xml.
398 * README: Add a brief description and mention some mvn
400 * pom.xml: This extra information shows up in mvn site
403 2011-01-02 Murray Cumming <murrayc@murrayc.com>
405 Use the latest java-libglom version.
407 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
409 2012-01-01 Murray Cumming <murrayc@murrayc.com>
411 GwtTestOnlineGlom: Test a little more.
413 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
414 protected rather than private, as suggested by the gwt-test-utils
416 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
417 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
418 Test the initial visibility of the panels.
420 However, this is not a very useful test.
421 And I wonder how we should generally test using this idea for an
422 activity/places app like ours where the real changes happen implicitly
423 based on the history token/URL.
425 2012-01-01 Murray Cumming <murrayc@murrayc.com>
427 Slight modification to *Mapper comments.
429 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
431 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
433 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
435 Remove comments mentioning GIN because they are just copied from
436 the example code and are apparently not helpful:
437 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
438 Also change the mention of a class that is only in the example code.
440 2012-01-01 Murray Cumming <murrayc@murrayc.com>
442 GwtTestOnlineGlom test: Minor changes.
444 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
445 Avoid the long qualified class name and modify the comment
446 because it is now obvious to me that the mocked class is the only
447 custom one created via GWT.create().
449 2012-01-01 Murray Cumming <murrayc@murrayc.com>
451 Tests: Added the beginnings of a test using gwt-test-utils.
453 * pom.xml: Add dependencies on gwt-test-utils and easymock.
454 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
455 which tells gwt-test-utils what class will be tested.
456 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
457 Add a simple (but empty) test case. One class, used by the OnlineGlom
458 class, is mocked so that it can be created. However, I am not sure
459 why only this class needs to be mocked.
461 Note that mockito seems more popular, and clearer, than easymock,
462 but I have not got that working yet. It might be a matter of the
465 This test is run during mvn integration-test.
467 2011-12-31 Murray Cumming <murrayc@murrayc.com>
469 Tests: Use junit4-style syntax instead of junit3-style.
471 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
472 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
473 * src/test/java/org/glom/web/shared/DataItemTest.java:
474 Use the @Test annotation rather than relying on the test*() prefix.
475 Also no longer implement TestCase, to avoid triggering support for
476 the junit3-way, which stops the annotations from working.
477 Change the imports from import junit.framework.* to
478 import org.junit.*, which is apparently the new way.
480 2011-12-31 Murray Cumming <murrayc@murrayc.com>
482 Added a test for ListPlace token parsing and creation.
484 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
485 This is much the same as DetailsPlaceTest.
487 I wonder how we could test the other parts of the *Place API.
489 2011-12-30 Murray Cumming <murrayc@murrayc.com>
491 DetailsPlace test: Also test getToken() and recreation via getPlace().
493 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
494 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
495 recreate it, testing the recreated DetailsPlace for the same parameter
498 2011-12-30 Murray Cumming <murrayc@murrayc.com>
500 Use the surefire-report plugin.
502 * pom.xml: This generates a HTML report about the tests in
503 target/site/surefire-report.html
504 when you do mvn surefire-report:report. It seems to be popular/normal.
506 2011-12-30 Murray Cumming <murrayc@murrayc.com>
508 Added a test for DetailsPlace.
510 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
511 Test the getPlace() token parsing.
513 2011-12-30 Murray Cumming <murrayc@murrayc.com>
515 Added a first unit test.
517 * pom.xml: Add a test goal, and a dependency on junit in that scope.
518 * src/test/java/org/glom/web/shared/DataItemTest.java:
519 This is a silly test but it is just to get things started. Note that
520 maven/junit finds the test because it looks in src/test by default.
522 2011-12-22 Ben Konrath <ben@bagu.org>
524 Change charsetName to "UTF-8" when replacing line breaks.
526 JavaScript requires the charsetName to be "UTF-8". CharsetName values
527 that work in Java (such as "UTF8") will not work when compiled to
530 This fixes a problem with multi-line details view fields that have hard
531 line breaks. The "License Text" field on this page demonstrates the
534 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
536 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
538 2011-12-22 Ben Konrath <ben@bagu.org>
540 Fix another bug with related list navigation.
542 I've tested all the navigation buttons in all of the related lists
543 so things should be good now.
545 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
547 2011-12-22 Ben Konrath <ben@bagu.org>
549 Fix a crasher when refreshing the list view with the default table.
551 This crash will also happen when loading the list view with the default
552 table from a link or bookmark.
554 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
555 to the main document selection page when the document id hasn't been
557 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
558 the main document selection page when the document id hasn't been
560 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
561 values for the details place when the document id hasn't been set.
562 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
563 values for the list place when the document id hasn't been set.
565 2011-12-21 Ben Konrath <ben@bagu.org>
567 Protect against NPE when glom.document.locale is not in config.
569 This patch protects against an NPE when glom.document.locale is not in
570 the config file. This NPE will also happen if glom.document.locale is
573 The patch also updates the error message to display the class name when
574 the getMessage() returns null. This was happening when the NPE was
575 thrown and I had "Configuration Error: null". If an NPE is encountered
576 with this patch, "Configuration Error: NullPointerException " will be
579 This commit closes this bug:
581 https://bugzilla.gnome.org/show_bug.cgi?id=666669
583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
585 2011-12-20 Murray Cumming <murrayc@murrayc.com>
587 Rename onlineglom.properties to onlineglom.properties.sample.
589 * src/main/resources/onlineglom.properties: Rename to:
590 * src/main/resources/onlineglom.properties.sample:
591 * src/main/resources/README: And add this file explaining that people
592 should rename it back when deploying.
594 2011-12-20 Murray Cumming <murrayc@murrayc.com>
596 Allow choosing the translation in the .properties file.
598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
599 init(): Read a glom.document.locale value from the configuration file
600 and call Glom's TransatableItem::set_current_locale() method.
601 * src/main/resources/onlineglom.properties: Add a commented-out
602 example of this new setting.
604 It would be better to add &lang=de_DE to the URL, but the current
605 libglom API does not allow us to do this easily. I am working on that.
607 2011-12-19 Murray Cumming <murrayc@murrayc.com>
609 Avoid a crash in parsing of token parameters.
611 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
612 ava: getTokenParams(): Do not crash if a parameter has a key but no
613 value, and ignore parameters with neither.
615 2011-12-17 Murray Cumming <murrayc@murayc.com>
617 History token building/handling: Improve use of token parameters.
619 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
620 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
621 and buildParamsToken(HashMap), for use by derived classes.
622 Make the separator private because it is no longer be needed.
623 * src/main/java/org/glom/web/client/place/DetailsPlace.java
624 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
625 instead of manual string concatenation.
626 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
627 of hardcoded indices and awkward splitting code.
628 * src/main/java/org/glom/web/client/place/ListPlace.java
629 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
630 instead of manual string concatenation.
631 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
632 of hardcoded indices and awkward splitting code.
633 This should fix bug #666420
635 2011-12-16 Murray Cumming <murrayc@murrayc.com>
637 Fix a Navgiation->Navigation typo in the code.
639 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
640 Rename processNavgiation() to processNavigation().
642 2011-12-16 Murray Cumming <murrayc@murrayc.com>
644 Fix a seperator->separator typo in the code.
646 * src/main/java/org/glom/web/client/place/DetailsPlace.java
647 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
648 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
651 2011-12-15 Ben Konrath <ben@bagu.org>
653 Cleanup some comments.
655 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
657 2011-12-14 Ben Konrath <ben@bagu.org>
659 Replace \n with <br/> for multiline text in the details view.
661 Vertical scrollbars are added when needed as well.
663 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
665 2011-12-14 Ben Konrath <ben@bagu.org>
667 Specify the font for document selection links.
669 * src/main/webapp/style.css:
671 2011-12-14 Ben Konrath <ben@bagu.org>
673 Fix bouncy CellTable while paging.
675 This doesn't currently work with related list tables in unselected
678 * src/main/java/org/glom/web/client/ui/list/ListTable.java
680 2011-12-14 Ben Konrath <ben@bagu.org>
682 Revamp the appearance of the document selection page.
684 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
685 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
686 * src/main/webapp/style.css:
688 2011-12-13 Ben Konrath <ben@bagu.org>
690 Set navigation button column to the smallest size possible.
692 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
694 2011-12-13 Ben Konrath <ben@bagu.org>
696 Change OpenButton nomenclature to NavigationButton.
698 Using NavigtionButton makes things more generic. Classes, methods and
699 variables have been changed.
701 This is a rename-only refactor.
703 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
704 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
705 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
706 Renamed from OpenButtonCell.
707 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
708 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
709 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
711 2011-12-12 Ben Konrath <ben@bagu.org>
713 Remove unnecessary String argument in RelatedListTable and ListViewTable.
715 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
716 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
717 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
718 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
720 2011-12-12 Ben Konrath <ben@bagu.org>
722 Update variable names and comments.
724 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
725 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
727 2011-12-12 Ben Konrath <ben@bagu.org>
729 Properly initialize numNonEmptyRows variable to zero.
731 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
732 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
734 2011-12-05 Ben Konrath <ben@bagu.org>
736 Add latest mockup with HTML tables.
738 Features of this mockup:
740 -> HTML table for flowtable
741 -> HTML table for flowtable column
742 -> Example of how related lists would look
743 -> Not using text entries for data items
745 The current version of Online Glom doesn't use HTML tables for the
748 This mockup has been sent to the glom-devel mailing list but it's good
749 to have it here as well.
751 * mockups/details-view-html-tables.html:
753 2011-12-05 Ben Konrath <ben@bagu.org>
755 Remove unnecessary getPrimaryKeyField() method.
757 getPrimaryKeyFieldForTable(String) has been renamed to
758 getPrimaryKeyField(String).
760 * src/main/java/org/glom/web/server/database/DBAccess.java:
761 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
762 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
764 2011-12-05 Ben Konrath <ben@bagu.org>
766 Add string representation of TypedDataItem value to conversion error message.
768 * src/main/java/org/glom/web/server/Utils.java: Logging the error
769 message was extracted into its own method to avoid duplication.
771 2011-12-05 Ben Konrath <ben@bagu.org>
773 Add type checking to navigation primary key value creation.
775 Create navigation primary key only if the expected type from the Glom
776 document matches the type returned by the SQL query.
778 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
780 2011-12-05 Ben Konrath <ben@bagu.org>
782 Rename a couple of variables in RelatedListNavigation.
784 This is a rename-only refactor.
786 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
788 2011-12-05 Ben Konrath <ben@bagu.org>
790 Move getListLayoutGroup() into getListViewLayoutGroup().
792 This removes getListLayoutGroup(). It was only being called by
793 getListViewLayoutGroup().
795 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
797 2011-12-05 Ben Konrath <ben@bagu.org>
799 Remove check for LayoutItem_Portal in list table method.
801 This check is no longer necessary because the method isn't being used
802 to create the LayoutItemPortal DTO.
804 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
806 2011-12-05 Ben Konrath <ben@bagu.org>
808 Properly support related list navigation.
810 Navigation from the "Repository Analyzer -> Package Scans ->
811 Dependencies" related table wasn't working because the primary key for
812 related tables wasn't being set properly. This commit fixes the
815 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
816 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
817 doesn't set the primary key properly for related list tables.
818 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
819 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
820 useful for getting the primary key for list view tables and for related
822 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
823 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
824 Move code to set the primary key for the table from the abstract
825 ListDBAccess class to ListViewDBAccess as it's only correct for list
827 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
828 Properly add primary key to related list tables.
830 2011-12-02 Ben Konrath <ben@bagu.org>
832 Properly set the horizontal alignment of fields.
834 This fix is for both the list tables and the details view.
836 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
837 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
838 to set the horizontal alignment of fields.
840 2011-12-02 Ben Konrath <ben@bagu.org>
842 Display currency codes in the details view.
844 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
846 2011-12-02 Ben Konrath <ben@bagu.org>
848 Avoid duplicate JNI call.
850 JNI is not as efficient as pure Java and this is an easy (and small)
853 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
854 Use previously retrieved value for whereClauseToTableName instead of
857 2011-12-02 Ben Konrath <ben@bagu.org>
859 Rename a couple of variables in RelatedListNavigation.
861 This is a rename-only refactor.
863 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
865 2011-12-02 Ben Konrath <ben@bagu.org>
867 Indicate clearly that a mismatched primary key type is a bug.
869 * src/main/java/org/glom/web/server/Utils.java: Change log level from
870 warning to error. Add 'This is a bug.' to message.
872 2011-12-02 Ben Konrath <ben@bagu.org>
874 Update / fix some comments.
876 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
878 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
880 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
881 Fix comments. Add some TODOs.
883 2011-12-02 Ben Konrath <ben@bagu.org>
885 Enable navigation to details view with string primary key from related list.
887 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
888 Create a text primary key value when return type of result is
889 java.sql.Types.VARCHAR.
891 2011-12-02 Ben Konrath <ben@bagu.org>
893 Use checkboxes for booleans in the details view.
895 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
897 2011-12-01 Ben Konrath <ben@bagu.org>
899 Improve performance of related list height calculation.
901 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
902 Put code to calculate the expected height in a static initializer so
903 that that it's only called once.
905 2011-12-01 Ben Konrath <ben@bagu.org>
907 Show related list tables in notebooks (again).
909 Calculate the height of the related list tables so the Notebook can be
910 set the correct height. The height of the related list table is also needed by
911 FlowTable to be able decide how to create the layout.
913 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
914 and set the Portal height based on the height of the related list
915 table and the Portal container.
916 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
917 Add method to calculate the height of the related list tables.
918 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
919 * src/main/webapp/style.css: Add css class for Pager. This is needed to
920 calculate the height of the Pager widget.
922 2011-12-01 Ben Konrath <ben@bagu.org>
924 Use CellTable API for table property instead of setting style on Element.
926 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
928 2011-12-01 Ben Konrath <ben@bagu.org>
930 Make ListViewTable and RelatedListTable a consistent height.
932 The tables are now a consistent height regardless of the contents of
933 the table. A hidden button is added to empty rows to ensure that the
934 height of these rows will match the height of rows with data.
936 A navigation button column is now added to every table. The width of
937 the navigation column is set to 0px when a RelatedListTable shouldn't
938 have navigation buttons. This maintains the a consistent row height in
939 tables that don't show the navigation buttons.
941 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
942 navigation column when not needed.
943 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
944 arguments for navigation button to constructor of ListViewTable.
945 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
946 hidden button for empty data rows.
947 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
948 arguments for navigation button to constructor.
949 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
950 create navigation buttons. Add hideNavigationButtons() method.
951 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
952 arguments for navigation button to constructor.
954 2011-12-01 Ben Konrath <ben@bagu.org>
956 Use 'visibility: hidden' in Utils.getWidgetHeight().
958 This is better choice because hidden elements are invisible, don't
959 respond to events and are not part of the tab order. They will,
960 however, take up space which is required to be able to calculate the
961 height of the widget.
963 * src/main/java/org/glom/web/client/Utils.java:
965 2011-12-01 Ben Konrath <ben@bagu.org>
967 Use Utils.getWidgetHeight() in FlowTable.
969 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
971 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
973 2011-12-01 Ben Konrath <ben@bagu.org>
975 Put the details css class name on the correct table column.
977 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
979 2011-11-30 Ben Konrath <ben@bagu.org>
981 Update for java-libglom API change.
983 The getters and setters on FieldFormatting and NumericFormat were
984 changed to remove the 'M'.
986 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
988 2011-11-29 Ben Konrath <ben@bagu.org>
990 Only allow RelatedListTables in Portals.
992 * src/main/java/org/glom/web/client/ui/details/Portal.java:
994 2011-11-29 Ben Konrath <ben@bagu.org>
996 Only create a contents panel for Portals when title is being set.
998 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1000 2011-11-29 Ben Konrath <ben@bagu.org>
1002 Set TabLayoutPanel height based on calculated height its widgets.
1004 This is a potential fix for this bug:
1006 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1008 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1010 2011-11-29 Ben Konrath <ben@bagu.org>
1012 Align details field labels and data with the Open buttons.
1014 * src/main/webapp/style.css:
1016 2011-11-29 Ben Konrath <ben@bagu.org>
1018 Remove unnecessary <div> in the Notebook widget.
1020 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1021 method to get container FlowPanel (<div>).
1022 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1023 initWidget() method directly on the TabLayoutPanel widget instead of
1024 Group's container widget.
1026 2011-11-29 Ben Konrath <ben@bagu.org>
1028 Don't add group titles for Portals in Notebooks.
1030 This reverts the previous patch and fixes a bug I introduced with
1031 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1033 * src/main/java/org/glom/web/client/ui/details/Group.java:
1034 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1036 2011-11-28 Ben Konrath <ben@bagu.org>
1038 Remove unused boolean argument in Portal constructor.
1040 Just a code cleanup.
1042 * src/main/java/org/glom/web/client/ui/details/Group.java:
1043 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1045 2011-11-28 Ben Konrath <ben@bagu.org>
1047 Remove hack for glom 1.18 style glom files.
1049 * src/main/java/org/glom/web/client/ui/details/Group.java:
1050 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1051 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1053 2011-11-28 Ben Konrath <ben@bagu.org>
1055 Use Gda Value version of primary key to log result too large error.
1057 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1059 2011-11-28 Ben Konrath <ben@bagu.org>
1061 Don't use TypedDataItem.getText() for Unknown types from the URL.
1063 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1064 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1065 instead of getText().
1066 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1067 String field and getUnknown() method.
1069 2011-11-28 Ben Konrath <ben@bagu.org>
1071 Log an error message when the java-libglom .so is not present.
1073 The error message was being set in the exception but not logged.
1075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1077 2011-11-28 Ben Konrath <ben@bagu.org>
1079 Ignore LayoutItem_CalendarPortals.
1081 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1082 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1084 2011-11-28 Ben Konrath <ben@bagu.org>
1086 Extract method for creating the LayoutItemPortal DTO.
1088 Just breaking the code up into smaller chunks.
1090 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1092 2011-11-28 Ben Konrath <ben@bagu.org>
1096 This should have been added with the refactor. Oops!
1098 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1100 2011-11-28 Ben Konrath <ben@bagu.org>
1102 Create primary key value from URL string using type from Glom document.
1104 See this bug, comments 19 - 25:
1106 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1108 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1109 create a TypeDataItem for the primary key here when loading from a
1110 URL. Show the same string for the primary key value as was received
1111 from the URL string (when loading from a URL).
1112 * src/main/java/org/glom/web/server/Utils.java: Update method for
1113 creating the Gda Value from the TypeDataItem to properly deal with
1114 creating a Gda Value based on the Glom document type for the primary
1115 key value string when loading from a URL.
1116 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1117 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1118 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1119 Update for changed method name.
1121 2011-11-27 Ben Konrath <ben@bagu.org>
1123 Rename PrimaryKeyItem to TypedDataItem.
1125 The name PrimaryKeyItem suggests what the class should be used for.
1126 TypedDataItem is a neutral name that describes the class better.
1128 This is a rename-only refactor.
1130 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1131 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1132 * src/main/java/org/glom/web/client/Utils.java:
1133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1134 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1135 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1136 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1137 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1138 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1139 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1140 * src/main/java/org/glom/web/server/Utils.java:
1141 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1142 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1143 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1144 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1146 2011-11-25 Ben Konrath <ben@bagu.org>
1148 Improve Gda Value conversion from PrimaryKeyItem.
1150 The value from the PrimaryKeyItem is only used if its type match the
1151 type from the glom document.
1153 * src/main/java/org/glom/web/server/Utils.java:
1155 2011-11-25 Ben Konrath <ben@bagu.org>
1157 Manually check if the java-liblgom .so is visible to the JVM.
1159 It seems that Tomcat has problems when a static initializer throws an
1160 exception. This check is done before the first method call into
1161 java-libglom so that execution doesn't continue if the .so is not
1164 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1166 2011-11-25 Ben Konrath <ben@bagu.org>
1168 Improve browser configuration error messages.
1172 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1174 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1175 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1176 getConfigurationErrorMessage() method.
1177 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1178 Get and display a specific configuration error message when no Glom
1179 documents are found.
1180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1181 Implement getConfigurationErrorMessage() method. Surround configuration
1182 code in the init() method with a try/catch block. This allows the
1183 errors to be caught while keeping the servlet available to retrieve the
1184 configuration error message.
1186 2011-11-25 Ben Konrath <ben@bagu.org>
1188 Don't use Strings to hold primary key values.
1190 The primary key values are now held in a new data object
1191 (PrimaryKeyItem) that holds type information and the primary key value
1192 using the correct type.
1194 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1195 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1197 PrimaryKeyItem instead of String to hold the primary key value.
1198 * src/main/java/org/glom/web/client/Utils.java: Remove
1199 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1200 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1201 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1202 PrimaryKeyItem instead of String to hold the primary key value. Load
1203 document selection page when the documentID has not been set correctly.
1204 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1205 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1207 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1208 Return empty string for URL instead of "null".
1209 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1210 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1211 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1212 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1213 PrimaryKeyItem instead of String to hold primary key values.
1214 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1215 PrimaryKeyValue to a Gda Value.
1216 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1217 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1218 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1219 Replace temporary database access code that uses the PrimaryKeyValue to
1220 Gda Value conversion.
1221 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1222 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1223 PrimaryKeyItem instead of String.
1224 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1225 hold primary key values.
1227 2011-11-24 Ben Konrath <ben@bagu.org>
1229 Use newly added java-libglom API to create queries.
1231 This isn't finished. I still need to stop using Strings for primary key
1232 values in the client code.
1234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1235 libglom to use fake connections so that retrieving the query string will
1237 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1238 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1239 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1240 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1241 Use the newly added libglom sql methods and classes to create the
1242 query. Add temporary hack to convert primary value strings to Gda
1245 2011-11-23 Ben Konrath <ben@bagu.org>
1247 Don't explicitly set the height of Portals.
1249 See comments 6 - 10 of this bug for details:
1251 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1253 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1255 2011-11-23 Ben Konrath <ben@bagu.org>
1257 Use an HTML table instead of CSS for the FlowTable layout.
1259 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1260 GWT's FlexTable to implement the FlowTable.
1261 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1263 2011-11-18 Ben Konrath <ben@bagu.org>
1265 Add boolean example to HTML table mockup.
1267 * mockups/details-view-html-tables-text-entries.html:
1269 2011-11-17 Ben Konrath <ben@bagu.org>
1271 Ensure the pager buttons are always visible for related lists.
1273 To accomplish this, I've turned off text wrapping in the list view and
1274 related list tables for both the header and data text. The related list
1275 table now has a fixed layout so the it doesn't overflow its container.
1276 This is required to ensure that the cell text is clipped when it
1277 overflows the cell and an ellipsis is added to the right side of the
1278 cell when text is clipped.
1280 A fixed table layout for the related list table in the details view
1281 seems what we want for the details view anyway, so the side-effect is
1284 The ellipsis will only be displayed in Firefox >= 7.
1288 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1290 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1291 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1292 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1294 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1295 Set the 'table-layout: fixed' CSS property to the related list table.
1296 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1297 'white-space: nowrap;' CSS property on both the list view and the
1298 related list tables.
1300 2011-11-16 Ben Konrath <ben@bagu.org>
1302 Rework the fix for empty notebook tab labels.
1304 Setting the empty group titles with its name caused problems for the
1305 details layout. Instead of using libglom's
1306 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1307 to the client when the title is empty. This allows the Notebook to use
1308 the name when the title is empty without affecting anything else.
1310 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1311 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1313 2011-11-16 Ben Konrath <ben@bagu.org>
1315 Set group titles with name when title is empty.
1317 This fixes a problem with an empty notebook tab label in the Lesson
1318 Planner document. The forth tab in the notebook should be "Internet":
1320 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1322 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1323 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1326 2011-11-16 Ben Konrath <ben@bagu.org>
1328 Remove whitespace from the configured username properties.
1330 This assumes that usernames won't have whitespace at the beginning
1331 or end. But I think this is a reasonable assumption.
1333 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1334 String.trim() to remove the whitespace from the username properties.
1336 2011-11-15 Ben Konrath <ben@bagu.org>
1338 Add details view mockup with HTML tables and text entries.
1340 This is from the attachment on this bug:
1342 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1344 * mockups/details-view-html-tables-text-entries.html:
1346 2011-11-15 Ben Konrath <ben@bagu.org>
1348 Add space between the columns of the flow table.
1352 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1354 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1355 space between columns in the flow table.
1357 2011-11-15 Ben Konrath <ben@bagu.org>
1359 Add backup files to the .gitignore.
1361 * .gitignore: Ignore files that end with ~.
1363 2011-11-09 Ben Konrath <ben@bagu.org>
1365 Use latest release of gwt-log.
1367 Gwt-log releases are now being submitted to the maven central
1368 repository so manual installation of the jar is no longer required.
1370 * pom.xml: Update version and groupId of gwt-log dependency.
1372 2011-10-31 Ben Konrath <ben@bagu.org>
1374 Don't use GWT numeric formatting to override the glom currency formatting.
1376 Currencies are now displayed like they are in Glom. See this bug:
1378 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1380 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1382 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1383 currency code to constructor and set it when the cell is rendered.
1384 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1385 currency code to the constructor of the NumericCell.
1387 2011-10-27 Ben Konrath <ben@bagu.org>
1389 Require the latest release of java-libglom (1.17.4).
1393 2011-10-26 Ben Konrath <ben@bagu.org>
1395 Add style to Notebook that matches current theme.
1397 It's not the best style in the world but it's better than the default.
1399 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1400 padding at the bottom of the child widgets.
1401 * src/main/webapp/style.css: Add style for the Notebook.
1403 2011-10-26 Ben Konrath <ben@bagu.org>
1405 Move servlet initialization code to overridden init method.
1407 This is half of the solution to getting proper error messages
1408 displayed when configuration errors occur. Here's the relevant bug:
1410 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1412 The rest of the solution involves surrounding the init method with a
1413 try/catch block and setting a global variable with the error /
1414 exception. A new async method should be created to retrieve and display
1415 the error message / exception.
1417 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1418 code from constructor to init method adding exceptions as needed.
1420 2011-10-26 Ben Konrath <ben@bagu.org>
1422 Add script to monitor and restart tomcat if required.
1424 * utils/check-and-recover-tomcat.py: New file.
1426 2011-10-26 Ben Konrath <ben@bagu.org>
1428 Display the correct number of data items in the pager.
1432 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1434 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1435 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1436 The implementation is the same for both tables: Keep track of the
1437 number of non-empty rows and fire and RowCountChangeEvent after the data has
1439 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1440 custom Pager class that subclasses SimplePager to handle displaying
1441 the correct number when empty rows have been added.
1443 2011-10-26 Ben Konrath <ben@bagu.org>
1445 Correct error in previous commit.
1447 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1448 eventBus parameter from listView.setCellTable().
1450 2011-10-26 Ben Konrath <ben@bagu.org>
1452 Fix error in TODO comment.
1454 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1456 2011-10-24 Ben Konrath <ben@bagu.org>
1458 Create Notebook widgets to the details view.
1460 This isn't finished just yet - I still need to create a reasonable
1461 style to match the current theme.
1463 * src/main/java/org/glom/web/client/Utils.java: Add method for
1464 calculating the height of a widget. This is used in the Notebook class.
1465 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1466 new constructor method in Group.
1467 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1468 method for creating child widget that can be used by subclasses
1469 like Notebook. New constructor that allows disabling the group
1470 titles - Notebooks don't set a group title for their child groups.
1471 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1472 to make Notebooks using GWT's TabLayoutPanel.
1473 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1474 constructor that allows disabling the group titles.
1475 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1476 LayoutItemNotebook DTO.
1477 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1478 DTO for Notebooks. It's just an empty class for now but we might need
1479 it to transfer some specific information in the future.
1481 2011-10-21 Ben Konrath <ben@bagu.org>
1483 Add navigation buttons to related list tables.
1485 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1486 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1487 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1488 method getSuitableRecordToViewDetails() for getting the table name
1489 and primary key value for related list navigation buttons.
1490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1491 private cell renderer class to get the navigation information for
1492 related list tables from the server. Extract the navigation
1493 processing code from the details cell navigation and use it for the
1494 related list navigation as well.
1495 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1496 cell renderer class for the details open buttons. This was needed
1497 because the related list navigation buttons and the list view
1498 navigation buttons need to react differently when clicked.
1499 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1500 the onEnterKeyDown() method because it's now overriden in the
1501 subclasses that are specific to the related list tables and the list
1503 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1504 the vertical size a little because the buttons add a bit of vertical
1505 space to table. This is not a perfect solution because the vertical
1506 size of with table fewer than 5 rows will be a little smaller.
1507 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1508 changes in how navigation buttons are handled.
1509 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1510 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1511 database access object.
1512 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1513 to find the portal for a given relationship name from
1514 RelatedListDBAccess. Add method to find a primary key field for a
1516 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1517 Move code to find the portal for a given relationship name to
1519 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1520 New file: database access object for getting the related list
1521 navigation information (the table name and the primary key value).
1522 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1523 DTO for transferring a table name to navigate to and a primary key
1525 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1526 boolean and getter/setter to specifies if the related list should add
1529 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1531 Use the master branch of java-libglom
1533 * pom.xml: Depend on java-libglom 1.19 instead.
1535 This is the master branch. See also the libglom-1-18 branch.
1537 2011-10-11 Ben Konrath <ben@bagu.org>
1539 Enable the open navigation button when the data has been set.
1541 This avoids having active buttons that don't do anything when the data
1544 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1546 2011-10-11 Ben Konrath <ben@bagu.org>
1548 Use IsWidget interface for FlowTableItem.
1550 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1551 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1553 2011-10-11 Ben Konrath <ben@bagu.org>
1555 Remove GWT styling from open button in details view.
1557 There are still some issues with how the details cell is arranged but
1558 this should be made to match Glom 1.20. I'm going to leave fixing this
1559 until I have Glom 1.20 up and running.
1561 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1562 style name on open button.
1563 * src/main/webapp/style.css: Move and edit details-navigation class.
1564 Re-arrange some classes to make them appear in the same order as the
1567 2011-10-07 Ben Konrath <ben@bagu.org>
1569 Update to GWT 2.4.0.
1571 * .gitignore: Ignore new cache directory.
1572 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1573 * pom.xml: Change GWT and maven plugin to 2.4.0.
1574 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1576 * src/main/java/org/glom/web/client/ClientFactory.java:
1577 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1578 * src/main/java/org/glom/web/client/OnlineGlom.java:
1579 Update source for API changes.
1580 * utils/build-onlineglom-war.sh: Remove cache directory before the
1583 2011-10-07 Ben Konrath <ben@bagu.org>
1585 Add navigation buttons in the details view.
1587 This isn't finished but I thought I'd commit what I have as it's a
1588 pretty good start. I still need to:
1590 1. Change the style so that it fits better into the current theme
1591 2. Adjust the details cell to expand as much as possible.
1593 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1594 click handlers to navigation buttons in the DetailsCells. Create a
1595 refreshData() method to get just the data from the server without the
1597 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1598 Update the tableSelector and browser title when the table name
1599 changes without using the tableSelector.
1600 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1601 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1602 getDetailsCells() to getCells(). Update variable names.
1603 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1604 method to set click handler on navigation button. Rename a few
1605 variables. Add navigation buttons where needed.
1606 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1607 variables and methods.
1608 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1609 navigation boolean and navigation table as required in the
1610 LayoutItemField DTO.
1611 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1612 variables for navigation along with getter/setter methods.
1614 2011-10-07 Ben Konrath <ben@bagu.org>
1616 Rename Field to DetailsCell.
1618 This is a refactor-only commit. No functionality has been added or
1621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1622 Update variable and method names.
1623 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1624 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1625 variable and method names.
1626 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1628 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1629 variable and method names.
1631 2011-10-07 Ben Konrath <ben@bagu.org>
1633 Create separate methods for layout and data the details view.
1635 This is a refactor-only commit. No functionality has been added or
1638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1639 private methods: setData(), createLayout().
1641 2011-10-07 Ben Konrath <ben@bagu.org>
1643 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1645 This is part of a change to get navigation buttons in the details view
1646 but it should have been done this way from the start.
1648 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1649 for method name change in TableSelectionView.
1650 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1651 Create TableChangeEvent and set the browser title using the
1652 TableSelectionView API.
1653 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1654 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1655 Change getSelectedTable() to getSelectedTableName(). Add
1656 getSelectedTableTitle().
1658 2011-10-07 Ben Konrath <ben@bagu.org>
1660 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1662 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1664 2011-10-07 Ben Konrath <ben@bagu.org>
1666 Update TableChangeEvent to use newTableName naming convention.
1668 This makes the class more consistent with GWT naming conventions.
1670 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1671 Update for method name change in TableChangeEvent.
1672 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1673 for method name change in TableChangeEvent.
1674 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1675 newTableName variable and getter method. Make toDebugString()
1678 2011-09-30 Ben Konrath <ben@bagu.org>
1680 Disable the pager in the list tables when the data row count is less than the minimum.
1682 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1683 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1685 2011-09-30 Ben Konrath <ben@bagu.org>
1687 Add empty rows to the end of related list and list view tables.
1689 I also extracted the cell rendering classes from the ListTable because
1690 the code was becoming a little crazy with all the anonymous inner
1691 classes. My plan is to use these cell rendering classes in the details
1692 view as well so this refactor will be needed for that change.
1694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1695 set the row count in related list tables if the data has more rows
1696 than the minimum number of rows visible.
1697 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1698 row count in list view tables if the data has more rows than the
1699 minimum number of rows visible.
1700 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1701 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1703 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1704 for rendering TYPE_NUMERIC cells. The code was extracted from the
1706 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1707 class for rendering cells with buttons in list views. The code was
1708 extracted from the ListTable class.
1709 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1710 for rendering TYPE_TEXT cells. The code was extracted from the
1712 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1713 Add empty rows to the end of the data if required. Implement
1714 ListTable.getMinNumVisibleRows().
1715 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1716 cell renderer code to public classes. Return null in
1717 Column.getValue() for empty rows. Add new abstract method:
1718 getMinNumVisibleRows(). Move code to set the row count of the list view
1719 table to ListViewImpl.
1720 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1721 empty rows to the end of the data if required. Implement
1722 ListTable.getMinNumVisibleRows().
1725 2011-09-27 Ben Konrath <ben@bagu.org>
1727 Use GWT.log for client-side debugging statements.
1729 These are optimized out when deployed so I should have used this method
1730 in the first place. These statements will eventually be replaced with some sort
1731 of notification in the browser.
1733 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1734 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1735 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1736 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1737 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1739 2011-09-27 Ben Konrath <ben@bagu.org>
1741 Put tableselector on the right, back to list link on right.
1743 The idea is that the table selector is acting like a label for the
1744 currently displayed table so it should be placed below the document title. This
1745 puts the table title in a similar position to where it is in Glom.
1747 * mockups/details-contacts.html:
1748 * mockups/details-projects.html:
1749 * mockups/listview-contacts.html:
1750 * mockups/listview-projects.html:
1751 * mockups/style.css:
1752 Update mockups to match how the interfaces currently look.
1753 * src/main/webapp/style.css: Swap positions of backlink with the table
1754 selector. Add some space on the left side of the table selector to
1755 line things up with the document title.
1757 2011-09-27 Ben Konrath <ben@bagu.org>
1759 Add field colouring to details view.
1761 This change re-works how field colouring works. The colour formatting
1762 information is now set to the client with the layout information instead of
1763 with the data. This eliminates the need to send the same colour strings for
1764 data in list view column when colour information is set.
1766 In order to set an alternate colour for negative numeric values, the
1767 number is now sent to client and formatted with the GWT NumberFormat class.
1769 This change also fixes:
1771 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1773 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1774 internationalization framework which is needed for client side numeric
1776 * src/main/java/org/glom/web/client/Utils.java: New file for some
1777 client static utility methods.
1778 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1779 the DataItem object to the Field class. Use a utility method to
1780 create the foreignKeyValue string.
1781 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1782 alignment and text colours in the constructor. Add setData(DataItem)
1783 method. Remove setText(String) method.
1784 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1785 colour information to GlomTextCell. Create and use GlomNumberCell for
1786 rendering numbers. Use utility method to get the string for the
1787 primary key of the key provider. Re-work how the horizontal alignment
1789 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1790 formatting to layout information. Methods for converting the libglom
1791 formatting information were moved from DBAccess.
1792 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1793 numeric formatting (it's now done on the client side). Don't set text
1794 colours in DataItem. Move libglom formatting conversion methods to
1796 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1797 getters/setters for text colour information.
1798 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1799 for transferring the libglom NumericFormat information to the client.
1800 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1801 and getters/setters for: GlomNumericFormat, background colour and
1802 foreground colour strings.
1804 2011-09-26 Ben Konrath <ben@bagu.org>
1806 Simplify code that iterates through the LayoutGroup.
1808 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1810 2011-09-26 Ben Konrath <ben@bagu.org>
1812 Accept Eclipse formatting for OnlineGlomServiceAsync.
1814 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1816 2011-09-26 Ben Konrath <ben@bagu.org>
1818 Don't use the ListDBAccess classes to get the primary key layout information.
1820 This was causing a bug where the wrong index for the hidden primary key
1821 was being sent to the client.
1823 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1824 primary key while creating the LayoutGroup DTO. Create a
1825 LayoutItemField DTO for hidden primary keys. Don't use the
1826 RelatedListDBAccess because it was only used for getting the primary
1828 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1829 access modifier from public to protected for getPrimaryKeyField() and
1830 getPrimaryKeyLayoutItemField().
1831 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1832 abstract method getExpectedResultSize() because RelatedListDBAccess
1833 doesn't have enough info to implement it.
1834 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1835 Remove @Override for getExpectedResultSize().
1836 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1837 Remove method getExpectedResultSize().
1839 2011-09-23 Ben Konrath <ben@bagu.org>
1841 Log which layout (list or details) the ignored item is from.
1843 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1845 2011-09-23 Ben Konrath <ben@bagu.org>
1847 Remove annotations that turn off code formatting in DataItem.
1849 * src/main/java/org/glom/web/shared/DataItem.java:
1851 2011-09-23 Ben Konrath <ben@bagu.org>
1853 Rename GlomField to DataItem and update associated methods.
1855 This is a rename-only refactor. No functionality has been added or
1858 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1859 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1860 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1861 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1862 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1863 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1864 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1865 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1867 * src/main/java/org/glom/web/server/database/DBAccess.java:
1868 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1869 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1870 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1871 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1872 * src/main/java/org/glom/web/shared/DataItem.java:
1873 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1874 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1876 2011-09-23 Ben Konrath <ben@bagu.org>
1878 Rename GlomDocument to DocumentInfo and update associated methods.
1880 This is a rename-only refactor. No functionality has been added or
1883 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1884 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1885 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1886 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1887 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1888 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1889 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1891 2011-09-20 Ben Konrath <ben@bagu.org>
1893 Require java-libglom 1.17.3.
1895 This picks up the fix for the seg fault problem with the Scenes table
1896 in the Openismus Film Manager example.
1900 2011-09-20 Ben Konrath <ben@bagu.org>
1902 Change the way sort clause is added for primary key when no sort clause is requested.
1904 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1905 before the sort clause is created. When a sort clause is not requested, the
1906 sort clause is created by finding the primary key in the LayoutFieldVector
1909 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1911 2011-09-20 Ben Konrath <ben@bagu.org>
1913 Log error message if no documents are found in the configured directory.
1915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1916 Extract the glom file extension string to a private static final class
1917 variable (mostly as syntactic sugar). Accept a minor formatting change.
1918 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1919 the example glom.document.directory configuration property to make it
1920 more clear that it can any directory, not just the home directory.
1922 2011-09-18 Ben Konrath <ben@bagu.org>
1924 Add related lists to details view.
1926 The related list table has support for paging and sorting just like the
1927 table in the list view.
1929 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1930 SQL queries for the related list tables.
1931 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1932 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1933 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1934 Rename getList methods to getListView and add comments. Remove
1935 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1936 it being unused. Add methods: getDetailsLayoutAndData(),
1937 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1938 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1939 Create the layout and set the data for the fields in one async call
1940 instead of two. Create related lists where appropriate.
1941 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1942 for method name changes in OnlineGlomService.
1943 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1944 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1945 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1947 * src/main/java/org/glom/web/client/ui/ListView.java:
1948 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1949 tableName from setCellTable(). Create a ListViewTable instead of
1951 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1952 represent a data field in the details view.
1953 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1954 from addDetailsCell() to Field class. Keep track of the Fields and
1955 Portals in the details view.
1956 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1957 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1958 and add a method to get it. Add method to set the contents of the
1960 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1961 New class for related list tables. This class has the data provider
1962 for the related list table.
1963 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1964 abstract class which is the base class for the ListViewTable and the
1966 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1967 New class for list view tables. This class has the data provider for
1968 the list view table.
1969 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1970 methods for related list tables. Add more information to the
1971 LayoutItemField and LayoutItemPortal DTOs.
1972 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1973 Remove debugging print statement.
1974 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1975 Remove debugging print statements. Add primary key field to SQL count
1977 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1978 Remove unnecessary LayoutFieldVector parameter from
1979 getResultSizeOfSQLQuery() method.
1980 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1981 New class for related list table database access.
1982 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1983 class that is a wrapper DTO for details view layout and data.
1984 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1985 new 'fromField' string to this DTO.
1986 * src/main/webapp/style.css: Remove bottom margin and override top
1989 2011-09-15 Ben Konrath <ben@bagu.org>
1991 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1993 This sets things up to make it easier to add the data retrieval for
1994 related lists (portals). No user noticeable changes were made with
1997 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1998 class has the code to retrieve the layouts and access the
1999 database using the new database helper classes.
2000 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2001 Most of the functionality has been removed from this class. This
2002 class now represents the public interface for the client side
2003 code. It also deals with configuring the servlet and cleaning
2004 things up when the servlet is stopped.
2005 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2006 of static methods into this utility class.
2007 * src/main/java/org/glom/web/server/database/DBAccess.java:
2008 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2009 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2010 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2011 These classes have the database retrieval code. The class hierarchy
2012 has been setup to make it easy to reuse code for similar
2015 2011-09-06 Ben Konrath <ben@bagu.org>
2017 Create separate classes for list table code and the data provider.
2019 As part of this refactor, I also split up the code a bit to make it
2022 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2023 table code to two new classes (below).
2024 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2025 with code from ListViewImpl.
2026 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2027 New file with code from ListViewImpl.
2029 2011-09-06 Ben Konrath <ben@bagu.org>
2031 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2033 This fixes the LayoutItemPortal DTO to match the libglom layout object
2036 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2038 2011-09-01 Ben Konrath <ben@bagu.org>
2040 Set title of Portals in the Details View.
2042 * pom.xml: Bump required version of java-libglom to 1.17.1.
2043 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2044 widget creation to its own class. Add comments to constructor.
2045 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2046 The code is mostly from the Group class with the title now set.
2047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2048 title of Portal. Update some comments. Fix some code formatting.
2050 2011-09-01 Ben Konrath <ben@bagu.org>
2052 Remove TODO comment for the flow table column width.
2054 The flow table column width is working correctly and doesn't need to be
2055 changed. See this mailing list post for more info:
2057 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2059 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2061 2011-08-27 Ben Konrath <ben@bagu.org>
2063 Add document title (database name) to top of the browser page.
2065 I added the document title to the TableSelecitonView but that will
2066 change if / when we add a view that doesn't require table selection.
2068 * mockups/details-contacts.html:
2069 * mockups/details-projects.html:
2070 * mockups/listview-contacts.html:
2071 * mockups/listview-projects.html:
2072 * mockups/style.css: Add document title to mockups to keep things
2074 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2075 sizes to account for the document title.
2076 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2077 Set the document title when it has been retrieved from the server.
2078 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2079 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2080 and implement setDocumentTitle(String) method.
2081 * src/main/webapp/style.css: Add ID for document title style.
2083 2011-08-25 Ben Konrath <ben@bagu.org>
2085 Add NavigationType enum to LayoutItemPortal DTO.
2087 This is the start of adding support for Portals to the Details View.
2089 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2090 LayoutItem_Portal.navigation_type enum from libglom to
2091 LayoutItemPortal.NavigationType enum.
2092 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2093 NavigationType enum, field for storing the NavigationType and getter
2096 2011-08-25 Ben Konrath <ben@bagu.org>
2098 Implement the flow table layout in the Details View.
2100 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2101 FlowTable to Group to account for the renamed class.
2102 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2103 File. This is a container widget that implements the Glom details view
2104 flow table behaviour.
2105 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2106 org/glom/web/client/ui/FlowTable.java.
2107 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2108 so that the size of the subgroups are a closer match to the size of
2109 the Glom subgroups. This makes the flowtable layout match the layout
2110 in Glom for the Music Collection example file.
2112 2011-08-16 Ben Konrath <ben@bagu.org>
2114 Create container element for LayoutItemPortal in Details View.
2116 This will help me develop the layout for the FlowTable.
2118 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2119 fieldPanel variable to detailsCell.
2121 2011-08-15 Ben Konrath <ben@bagu.org>
2123 Set the height of the data element in the Details View.
2125 I changed the InlineLabels (text in a span element) to Labels (text in
2126 a div element) so that I could set the height of the details-data
2127 elements instead of the details-cell parent elements. This allows the
2128 the details-data element to display the correct height if style is
2129 applied that shows the height.
2131 This change has the added benefit of allowing the order of the labels
2132 and data elements to be changed for right-to-left languages.
2134 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2135 InlineLabels to Labels.
2136 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2137 InlineLabels to Labels. Set the height of the data element.
2138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2139 multiline text height in the Formatting DTO.
2140 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2141 for multiline height along with getter and setter methods.
2142 * src/main/webapp/style.css: Adjust style to account for the change
2143 from span elements to div elements in the details cell.
2145 2011-08-15 Ben Konrath <ben@bagu.org>
2147 Make the List View appearance match the mockups.
2149 It doesn't match exactly but it's much better than it was.
2151 * mockups/listview-contacts.html: Remove unused css classes.
2152 * mockups/listview-projects.html: Remove unused css classes.
2153 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2154 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2155 for mainPanel instead of VerticalPanel (table). Set style name on
2156 CellTable. Set style name on Details column. Right-align Details
2158 * src/main/webapp/style.css: Adjust properties to match the mockups.
2160 2011-08-12 Ben Konrath <ben@bagu.org>
2162 Add better support for subgroups in the details view.
2164 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2165 changed FlowTable constructor.
2166 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2167 support for subgroups and subgroup-titles.
2168 * src/main/webapp/style.css: Add CSS class for subgroups and
2171 2011-08-12 Ben Konrath <ben@bagu.org>
2173 Return the top level LayoutGroup title.
2175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2177 2011-08-11 Ben Konrath <ben@bagu.org>
2179 Make the TableSelector header match the mockup.
2181 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2182 the layout panel. Properly lineup the table selection header with
2183 the list and details view.
2184 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2185 margin around the details view.
2186 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2187 Rename listBox variable to tableSelector. Set id for the style sheet.
2188 Use a FlowPanel instead of a HorizontalPanel.
2189 * src/main/webapp/style.css: Add properties to make the TableSelector
2190 box match the mockups.
2192 2011-07-13 Ben Konrath <ben@bagu.org>
2194 Update install script for java-libglom version change.
2196 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2199 2011-07-13 Ben Konrath <ben@bagu.org>
2201 Add support sub-group in the details view.
2203 I also removed the code that special-cased the default details view
2206 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2208 I still have to make a proper flowtable.
2210 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2211 Don't special-case default details view layout.
2212 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2213 addLayoutField() as I'm going to use it.
2214 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2215 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2217 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2218 extracted from DetailsViewImpl.GroupPanel. Add support for
2220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2221 column count when getting the details layout.
2223 2011-07-12 Ben Konrath <ben@bagu.org>
2225 Set browser title with database and table titles.
2227 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2228 Set the browser title when the table changes and when the activity
2230 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2231 title when retrieving document info (the GlomDocument object).
2232 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2233 with getter and setter methods. Remove unused convenience constructor.
2234 Use default code formatting.
2236 2011-07-12 Ben Konrath <ben@bagu.org>
2238 Ignore LayoutItemPortals in the details view.
2240 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2243 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2244 LayoutItemPortal layout objects.
2245 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2246 LayoutItemPortal objects when retrieving the details layout.
2247 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2248 file. This is an empty class and just used to get type information for
2251 2011-07-12 Ben Konrath <ben@bagu.org>
2253 Use java-libglom 1.17.0.
2257 2011-07-11 Ben Konrath <ben@bagu.org>
2259 Remove "Table:" label from table selector.
2261 This matches a recent change in the Glom UI.
2263 * mockups/details-contacts.html:
2264 * mockups/details-projects.html:
2265 * mockups/listview-contacts.html:
2266 * mockups/listview-projects.html: Remove the "Table:" label from the
2268 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2270 2011-07-11 Ben Konrath <ben@bagu.org>
2272 Add main groups to the details view.
2274 This makes things look a little nicer in the details view. The next step
2275 is to implement the flowtable.
2277 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2278 resources from the standard gwt css theme. Standard.css is now
2279 included in OnlineGlom.html so that the online glom css rules have
2280 precedence over the gwt theme.
2281 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2282 the whole LayoutGroup to the DetailsView instead of just the titles.
2283 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2284 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2285 details layout with a helper class (GroupPanel). I might extract this
2286 class when I make the full flowtable.
2287 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2288 string as default so I don't have to worry about NPEs when processing
2290 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2291 note beside OnlineGlom.gwt.xml above).
2292 * src/main/webapp/style.css: Add default font-size to body to override
2293 the font-size set by the standard theme. Don't use h2 tags for
2294 group-title. Create new details-cell class.
2296 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2298 ConfiguredDocument: Set the port number too.
2300 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2301 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2302 Glom document. Presumably this worked sometimes so far because there is a
2303 default port number.
2305 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2307 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2309 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2310 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2311 correct, though we should throw an exception too.
2313 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2315 Fix a addDocuemnt typo.
2317 * src/main/java/org/glom/web/shared/Documents.java
2318 (Documents.addDocuemnt): Rename to addDocument().
2319 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2320 (OnlineGlomServiceImpl.getDocuments): Adapt.
2322 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2324 Slightly improved log output when connection fails.
2326 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2327 (ConfiguredDocument.setUsernameAndPassword):
2328 We don't know for sure if it' the username/password that's wrong, so
2329 rephrase the message.
2330 Also ouput the exception message, though it's generic in this case.
2332 2011-07-08 Ben Konrath <ben@bagu.org>
2336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2337 added braces to a one line if statement because the Eclipse formatter
2338 was getting confused.
2340 2011-07-07 Ben Konrath <ben@bagu.org>
2342 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2344 These should really be two separate tasks but I counldn't get things to
2345 work with GWT 2.2.0 and Eclipse 3.7.
2349 * .settings/org.eclipse.jdt.core.prefs:
2350 * .settings/org.eclipse.jdt.ui.prefs:
2351 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2352 * .settings/org.eclipse.m2e.core.prefs:
2353 Add new config files. Update current files. Remove references to the
2354 webtools plugins as we're not using any of the webtools features.
2355 * .gitignore: Add logs directory which is created when running with
2357 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2358 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2359 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2361 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2363 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2365 onlineglom.properties: Add explanatory comments.
2367 * src/main/resources/onlineglom.properties: Also change the default user
2368 from ben to someuser, to avoid the risk of people thinking we just
2369 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2371 2011-06-28 Ben Konrath <ben@bagu.org>
2373 Use filename in Log for incorrect passwords.
2375 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2376 getFileName(String) method to get the filename from the URI.
2378 2011-06-28 Ben Konrath <ben@bagu.org>
2380 Add the table name to the URL token for the ListPlace.
2382 This makes things consistent between the DetailsPlace and the
2383 ListPlace. It also allows the the ListPlace to be bookmarked.
2385 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2386 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2388 Remove getDefaultListLayout(). The default layout is now returned
2389 by the getListLayout() method when the table name is an empty string.
2390 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2391 Add table name field. Change to a new ListPlace when the table
2392 has been changed. Use getListLayout() for getting the default
2394 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2395 Add table name field. Set the correct table name in the list box
2396 when loading from bookmark. This corrects a problem for the
2398 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2399 Move table name to super-class (HasSelectableTable). Move document
2400 and table URL keys to super-class in HasSelectableTable.
2401 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2402 Add table name field. Add Tokenizer class with URL key common to
2403 the subclasses (DetailsPlace and ListPlace).
2404 * src/main/java/org/glom/web/client/place/ListPlace.java:
2405 Add table name. Add code to parse the URL token.
2406 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2407 Update ListPlace construction with empty table name string.
2408 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2409 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2410 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2411 Update ListPlace construction with table name string.
2412 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2413 Change defaultTableName field to tableName to reflect how it's now
2414 used. Update the getter and setter methods.
2416 2011-06-28 Ben Konrath <ben@bagu.org>
2418 Enable the table selector in the DetailsView.
2420 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2421 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2423 Remove getDefaultDetailsLayout(). The default layout is now returned
2424 by the getDetailsLayout() method when the table name is an empty
2426 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2427 event handler for table change event. Change to using
2428 getDetailsLayout() for the default details layout.
2429 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2431 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2432 when navigating to the details place.
2434 2011-06-27 Ben Konrath <ben@bagu.org>
2436 Use filename based unique document ID in URL and for RPC.
2438 The document ID is the glom document name with spaces (' ') replaced
2439 with pluses ('+') and without the .glom extension.
2441 This change is mostly a string substitution of 'documentTitle' for
2442 'documentID'. The only code change is the addition of a Documents DTO to get the
2443 filename to document title mappings as indicated below.
2445 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2446 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2447 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2448 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2449 Use Documents DTO to create the document links in the document
2451 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2452 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2453 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2454 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2455 * src/main/java/org/glom/web/client/place/ListPlace.java:
2456 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2457 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2458 * src/main/java/org/glom/web/client/ui/ListView.java:
2459 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2460 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2462 * src/main/java/org/glom/web/server/Log.java:
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2464 getDocumentTitles() to getDocuments() and return the Documents DTO.
2465 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2466 transferring the filename to document title mappings.
2468 2011-06-25 Ben Konrath <ben@bagu.org>
2470 Make the authentication popup work again.
2472 This bug was introduced when I extracted ConfiguredDocument to its own class.
2474 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2475 correct success / fail status in setUsernameAndPassword().
2477 2011-06-25 Ben Konrath <ben@bagu.org>
2479 Use filename as unique key for configuring database usernames and passwords.
2481 This replaces the use of the Glom document title which could change
2482 depending on the locale. Thanks to Murray Cumming for pointing out this
2485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2486 * src/main/resources/onlineglom.properties:
2488 2011-06-24 Ben Konrath <ben@bagu.org>
2490 Pass primary key value to DetailsView.
2492 This enables the DetailsView to load the correct data.
2494 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2495 primary key value field and set in constructor. Pass primary key
2496 value to getDetailsData().
2497 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2498 variables for document title and primary key value.
2499 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2500 key value to the DetailsPlace.
2502 2011-06-24 Ben Konrath <ben@bagu.org>
2504 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2506 This allows the primary key to be retrieved by the Details button. This
2507 functionality has not been implemented yet but it's in the works.
2509 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2510 the LayoutGroup result to ListView.setCellTable instead of all of its
2511 fields individually.
2512 * src/main/java/org/glom/web/client/ui/ListView.java:
2513 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2514 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2515 get the primary key for the table.
2516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2517 index of the primary key in the LayoutGroup accounting for hidden
2518 primary keys. Rename getJavaNumberFormat() to
2519 convertToJavaNumberFormat() for consistency. Cleanup / add some
2521 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2522 field for primary key index and a field to indicate whether the
2523 primary key is hidden or not.
2525 2011-06-23 Ben Konrath <ben@bagu.org>
2527 Rename getTableData methods to getListData.
2529 This is a rename refactor for consistency with other methods.
2531 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2532 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2533 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2534 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2536 2011-06-23 Ben Konrath <ben@bagu.org>
2538 Extract the ConfiguredDocument innerclass into its own class.
2540 This makes the servlet code more object oriented.
2542 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2543 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2545 new ConfiguredDocument class.
2547 2011-06-21 Ben Konrath <ben@bagu.org>
2549 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2551 This makes things more inline with how libglom works and reduces code
2552 duplication. This refactor lays the groundwork for adding the primary key to
2553 the LayoutGroup object.
2555 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2556 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2558 Change method names to getListLayout and getDefaultListLayout for
2559 consistency. Use LayoutGroup as the DTO for the list layout instead of
2560 ColumnInfo and LayoutListTable.
2561 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2562 new method names along with the LayoutGroup object for transferring the
2564 * src/main/java/org/glom/web/client/ui/ListView.java:
2565 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2566 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2567 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2569 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2570 Replaced with LayoutGroup.
2571 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2572 expectedResultSize and defaultTableName fields which are needed for
2574 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2575 type field which is needed for the list layout but will also be
2576 useful for the details layout as things progress.
2577 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2578 Make class abstract. Remove the unnecessary
2579 getFormattingHorizontalAlignment method. Add setFormatting method.
2581 2011-06-16 Ben Konrath <ben@bagu.org>
2583 Add scripts for building and installing war.
2585 These will help when updating OnlineGlom but they're also good
2586 supplemental documentation of the build and deployment proceeding.
2588 * utils/build-onlineglom-war.sh: New file.
2589 * utils/install-onlineglom-war.sh: New file.
2591 2011-06-16 Ben Konrath <ben@bagu.org>
2593 Create wrapper class to create consistent log messages.
2595 I wrapped methods in the Log class of gwt-log to add the method names
2596 from the servlet and create consistent formatting of the document title
2597 and table names in the log messages.
2599 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2601 log methods to use methods from wrapped Log class.
2603 2011-06-16 Ben Konrath <ben@bagu.org>
2605 Remove superfluous conditional return.
2607 Thanks to Murray Cumming for pointing this out!
2609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2611 2011-06-15 Ben Konrath <ben@bagu.org>
2613 Return an ArrayList of LayoutGroups for the Details layout.
2615 This corrects a problem with the details layout as it can have more
2616 than one top level LayoutGroup.
2618 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2619 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2620 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2621 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2623 with ArrayList of LayoutGroups for the details view layout.
2624 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2625 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2626 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2627 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2628 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2629 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2631 2011-06-14 Ben Konrath <ben@bagu.org>
2633 Use cast_dynamic method to determine the libglom LayoutItem type.
2635 This is better than finding the LayoutItem type by using the string
2636 returned from the get_part_type_name() method.
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2640 2011-06-14 Ben Konrath <ben@bagu.org>
2642 Add method names to log entries in the servlet.
2644 This helps when tracking down deployment problems.
2646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2648 2011-06-14 Ben Konrath <ben@bagu.org>
2650 Add data to the DetailsView using a hard-coded primary key value.
2652 The layout and functionality of the DetailsView is not complete. This
2653 is just a checkpoint so the patch doesn't get too big.
2655 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2656 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2657 Add getDetailsData() servlet method.
2658 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2659 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2660 LayoutFields are added to the DetailsView.
2661 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2662 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2663 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2664 take the string for the title instead of the object.
2665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2666 Add implementation getDetailsData() along with some private helper
2668 * src/main/webapp/style.css: Add padding to details-data class. Add a
2669 details-label class with the same padding as the details-data class.
2671 2011-06-03 Ben Konrath <ben@bagu.org>
2673 Use presenter.goTo() to change to the DetailsPlace.
2675 This will make things easier when we need to open the DetailsView with
2676 data specific to the row that was clicked.
2678 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2680 2011-06-02 Ben Konrath <ben@bagu.org>
2682 Add CSS file from mockups.
2684 I'm adding this now because it's going to be useful to have when
2685 developing the DetailsView. The TableSelectionView and ListView aren't
2688 * src/main/webapp/OnlineGlom.html:
2689 * src/main/webapp/style.css:
2691 2011-06-02 Ben Konrath <ben@bagu.org>
2693 Use String.isEmpty() to check for empty string.
2695 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2697 2011-06-02 Ben Konrath <ben@bagu.org>
2699 Display main layout group titles in the DetailsView.
2701 This is the start of the DetailsActivity/DetailsView implementation.
2703 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2704 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2705 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2707 Get the layout information for the details view from the server and set
2708 the main layout group titles.
2709 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2710 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2711 Add addLayoutGroup() and addLayoutField() methods. This are just
2712 temporary methods for creating the the details view that will change
2714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2715 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2717 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2718 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2719 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2720 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2721 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2722 Data Transfer Objects that mimic the libglom object structure. These are
2723 used for transferring the details layout but could also be used for
2724 transferring the list layout.
2726 2011-05-27 Ben Konrath <ben@bagu.org>
2728 Reset the AuthenticationPopup when clearing the ListView.
2730 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2732 2011-05-27 Ben Konrath <ben@bagu.org>
2734 Fix problem with onlineglom.properties file loading.
2736 The old way worked in Eclipse but not on the server. Loading the
2737 onlineglom.properties file now works in Eclipse and on the server.
2739 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2741 2011-05-24 Ben Konrath <ben@bagu.org>
2743 Update gwt-log from 3.1.0 to 3.1.2.
2745 Gwt-log 3.1.0 has been marked as depreciated.
2749 2011-05-24 Ben Konrath <ben@bagu.org>
2751 Add comment to ListActivity.goTo() method.
2753 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2755 2011-05-24 Ben Konrath <ben@bagu.org>
2757 Remove FIXME in convertGdkColorToHtmlColour()
2759 The Gdk::Color value returned by libglom is 16-bits per channel on both
2760 64 and 32-bit platforms.
2762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2764 2011-05-19 Ben Konrath <ben@bagu.org>
2766 Improve performance of initial ListView load.
2768 I removed a round trip to the server for getting the default table name
2769 and then requesting information about that table. This also removes a potential
2770 problem with the table change handler not being setup in time to receive the
2771 table change event from the ListActivity.
2773 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2774 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2775 getDefaultLayoutListTable() method. Improve comments.
2776 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2777 getDefaultLayoutListTable() method instead of firing a table change
2778 event to get the table to load.
2779 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2780 implementation of getDefaultLayoutListTable() method.
2781 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2784 2011-05-19 Ben Konrath <ben@bagu.org>
2786 Override toDebugString() in TableChangeEvent.
2788 This is useful to have for debugging.
2790 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2792 2011-05-19 Ben Konrath <ben@bagu.org>
2794 Add a "Back to List" link when at the DetailsPlace.
2796 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2797 Populate the CellTable based on the selected table of the ListBox if
2798 it's set otherwise use the default table. This allows the "Back to
2800 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2801 Remove Place from constructors. Add a setPlace() method. Add
2802 goToPlace() method. Set class as presenter for TableSelectionView.
2803 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2804 Use the same TableSelectionActivity when switching between the List and
2806 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2807 Subclass the new HasSelectableTablePlace. This removes some duplicate
2809 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2810 New class to represent Places that display the TableSelectionView.
2811 * src/main/java/org/glom/web/client/place/ListPlace.java:
2812 Subclass the new HasSelectableTablePlace. This removes some duplicate
2814 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2815 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2816 Add Presenter interface. Add setBackLinkVisible() method. Add
2817 setBackLink() method.
2819 2011-05-18 Ben Konrath <ben@bagu.org>
2821 Enable the "Details" buttons.
2823 Right now only an empty details view is displayed.
2825 * src/main/java/org/glom/web/client/ClientFactory.java:
2826 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2827 Add DetailsView to ClientFactory.
2828 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2829 A basic activity for the details view.
2830 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2831 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2833 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2834 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2836 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2837 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2838 unnecessary super() in constructor.
2839 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2840 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2841 really shouldn't create a new TableSelectionActivity for both the ListPlace
2842 and the DetailsPlace so this should be considered a temporary solution.
2843 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2844 New file. Represents a URL for the details view.
2845 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2846 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2847 A basic details view interface and implementation.
2848 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2849 Enable the "Details" buttons.
2851 2011-05-12 Ben Konrath <ben@bagu.org>
2853 Use a LayoutPanel with multiple display areas for main layout.
2855 This is mostly a refactor in that there are no changes from the user
2856 point of view. These changes are required so that we can swap out the list view
2857 with the details view when the user clicks the "Details" button.
2859 * src/main/java/org/glom/web/client/ClientFactory.java:
2860 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2861 OnlineGlomView. Add TableSelectionView, ListView and
2862 AuthenticationPopup.
2863 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2864 for main layout. Add display regions for main activities. Add
2865 activity manager for for main activities.
2866 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2867 file from parts of the deleted OnlineGlomActivity.
2868 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2869 New file from parts of the deleted OnlineGlomActivity.
2870 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2871 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2872 New files for app wide table change event.
2873 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2874 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2875 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2876 Activity mappers for the main activities replace the deleted app-wide
2878 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2879 Fix a spelling error in he comment.
2880 * src/main/java/org/glom/web/client/ui/ListView.java:
2881 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2882 Renamed from LayoutListView and modified for MVP. This still not a
2883 proper dumb view as prescribed by the MVP pattern but it works for now.
2884 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2885 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2886 New widget stripped out of the deleted OnlineGlomView.
2887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2888 Remove hack that is fixed by this patch.
2890 2011-05-06 Ben Konrath <ben@bagu.org>
2892 Rename OnlineGlomPlace to ListPlace.
2894 The only change besides the rename is that url will now display #list
2895 instead of #Document.
2897 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2898 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2899 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2900 * src/main/java/org/glom/web/client/place/ListPlace.java:
2901 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2903 2011-05-06 Ben Konrath <ben@bagu.org>
2905 Use Presenter for app navigation.
2907 This is the proper way to deal with Place (URL) changes with the MVP
2910 * src/main/java/org/glom/web/client/ClientFactory.java:
2911 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2912 PlaceHistoryMapper and PlaceHistoryHandler.
2913 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2914 PlaceHistoryMapper and PlaceHistoryHandler.
2915 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2916 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2917 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2918 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2919 Add Presenter interface and setPresenter methods. Rename addHyperLink
2920 to addDocumentLink taking only the document title as a parameter.
2922 2011-04-14 Ben Konrath <ben@bagu.org>
2924 Prompt for db username/password if they haven't been set.
2926 This is implemented with a popup widget that is contained within the
2927 OnlineGlomView and managed by the OnlineGlomActivity.
2929 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2930 methods for checking and setting the database username and password.
2931 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2932 new methods for checking and setting the database username and
2934 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2935 Display authentication popup if the JDBC connection to the database
2936 has not been authenticated.
2937 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2939 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2940 for dealing with the authentication popup.
2941 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2942 Implement the methods for dealing with the authentication popup.
2943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2944 try to executed queries if the database connection hasn't been
2945 authenticated. Implement methods for checking and setting the
2946 database username and password.
2948 2011-04-12 Ben Konrath <ben@bagu.org>
2950 Make log messages a little clearer.
2952 Add a dash betweeen the document title and the table name.
2954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2956 2011-04-12 Ben Konrath <ben@bagu.org>
2958 Protect against NPEs when cleaning up database resources.
2960 While this isn't strictly necessary because the exception is caught,
2961 not protecting against the NPEs makes it harder to find the real error
2964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2966 2011-04-12 Ben Konrath <ben@bagu.org>
2968 Move configuration of the servlet to the constructor.
2970 The servlet will be initialized even if the database authentication
2971 information is not set or correct. I still need to add the UI for prompting
2972 the user for the authentication information when it's required.
2974 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2975 javadocs for getDocumentTitles() method.
2976 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2977 Set error message when RPC fails.
2978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2979 glom files directory from the configuration file. Try to set the
2980 database authentication information for the specific document if it's
2981 set and works otherwise try to use the global authentication
2982 information set for the directory.
2983 * src/main/resources/onlineglom.properties: Moved from
2984 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2985 Added detailed comments for the new keys.
2987 2011-04-11 Ben Konrath <ben@bagu.org>
2989 Remove unnecessary @Override in DocumentSelectionViewImpl.
2991 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2993 2011-04-11 Ben Konrath <ben@bagu.org>
2995 Remove center alignment in DocumentSelectionView.
2997 The title element is still centred but the document titles and bottom
2998 sentence are both left-aligned.
3000 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3002 2011-04-11 Ben Konrath <ben@bagu.org>
3004 Change 'Demo' naming convention to 'Document'.
3006 This is just a rename refactor with no functional changes to the code.
3008 * src/main/java/org/glom/web/client/ClientFactory.java:
3009 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3010 * src/main/java/org/glom/web/client/OnlineGlom.java:
3011 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3012 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3013 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3014 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3015 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3016 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3017 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3018 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3019 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3022 2011-04-08 Ben Konrath <ben@bagu.org>
3024 Remove FIXME from safeLongToInt() method.
3026 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3031 2011-04-08 Ben Konrath <ben@bagu.org>
3033 Display an error if no glom documents are found in the specified directory.
3035 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3036 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3037 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3038 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3040 2011-04-08 Ben Konrath <ben@bagu.org>
3042 Add copyright header to one more file ... oops.
3044 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3046 2011-04-08 Ben Konrath <ben@bagu.org>
3048 Add copyright header to files without it.
3050 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3051 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3052 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3053 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3054 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3055 * src/main/java/org/glom/web/shared/GlomField.java:
3057 2011-04-08 Ben Konrath <ben@bagu.org>
3059 Add support for accessing multiple glom documents in the servlet.
3061 This completes the demo selection functionality.
3063 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3064 document title to methods.
3065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3066 document title to methods.
3067 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3068 Set browser window title when the activity starts. Correct name of
3069 document title variable.
3070 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3071 Set browser window title when the activity starts. Set the table
3072 selector change handler after table selector has been set. Clear the
3073 OnlineGlomView when the activity has been stopped.
3074 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3075 document title as the place token. Use "#Document:" instead of
3076 "#OnlineGlomPlace:" in the URL.
3077 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3078 Change heading to "Online Glom"
3079 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3080 document title in RPC methods.
3081 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3082 setDocumentTitle() method. Add clear() method.
3083 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3084 setDocumentTitle() method. Implement clear() method which removes the
3085 change handler on the ListBox, clears the ListBox and clears the
3087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3088 Implement methods with document title. Keep track for the configured
3089 glom documents and their corresponding JDBC configurations in a hash
3090 table. This information is retrieved using the document title as the
3091 key in the hash table.
3092 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3093 document title field as it's no longer needed.
3095 2011-04-08 Ben Konrath <ben@bagu.org>
3097 Update the Eclipse JDT configuration.
3099 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3100 methods. Automatically add the copyright header to new files.
3102 2011-04-05 Ben Konrath <ben@bagu.org>
3104 Add new page for demo selection.
3106 This patch adds all the components required to view and start an
3107 OnlineGlom demo by clicking on the desired hyperlink. The user is
3108 able to return to the demo selection page with the browser's back
3109 button. I still need to modify the servlet to work with multiple
3110 documents so all demo links will load the file defined in the
3111 OnlineGlom.properties.
3113 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3114 This is only useful during development so we don't need to save it.
3115 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3116 get a reference to the DemoSelectionView.
3117 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3118 method to get a reference to the DemoSelectionView.
3119 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3120 default view to DemoSelectionView.
3121 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3122 to get glom document titles for glom files in a hard-coded directory.
3123 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3124 method to get glom document titles for glom files in a hard-coded
3126 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3127 Presenter for DemoSelectionView.
3128 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3129 for DemoSelectionView.
3130 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3131 Update for DemoSelectionView.
3132 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3133 Basic 'Place' implementation for the DemoSelectionView.
3134 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3135 The interface for the DemoSelectionView.
3136 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3137 The implementation of the DemoSelectionView.
3138 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3139 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3141 implementation of method to get glom document titles for glom files
3142 in a hard-coded directory.
3143 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3144 on longer being used.
3145 * src/main/webapp/glom.png: Glom logo.
3147 2011-04-05 Ben Konrath <ben@bagu.org>
3149 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3151 This is the forth and final commit of a refactor that will allow
3152 OnlineGlom to be used with multiple documents.
3154 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3155 Move RPC code from OnlineGlomViewImpl to this class.
3156 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3158 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3159 RPC code to the presenter class (the P in MVP).
3161 2011-04-04 Ben Konrath <ben@bagu.org>
3163 Start moving the existing OnlineGlom code to MVP.
3165 This work is based on the GWT MVP framework that is documented here:
3167 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3169 This is the third commit of a refactor that will allow OnlineGlom to
3170 be used with multiple documents.
3172 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3173 Interface for client factory which is used to get instances of various
3174 classes throughout the app.
3175 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3176 Implementation of client factory.
3177 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3178 initialize the MVP framework.
3179 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3180 New file. Activity manager for the main container widget. This is the
3182 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3183 Maps place (URL) to its corresponding activity.
3184 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3185 New file. This is just a place holder for a generated file.
3186 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3187 New file. Represents the URL for the main Online Glom app.
3188 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3189 for changes in LayoutListViewImpl.
3190 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3191 interface for View. Move code to OnlineGlomViewImpl class.
3192 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3193 file. Implementation of OnlineGlomView.
3194 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3195 Place resources. Use ClientFactoryImpl by default.
3197 2011-04-04 Ben Konrath <ben@bagu.org>
3199 Move View classes to their own package.
3201 This is the second commit of a refactor that will allow OnlineGlom to
3202 be used with multiple documents.
3204 * src/main/java/org/glom/web/client/OnlineGlom.java:
3205 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3206 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3208 2011-04-02 Ben Konrath <ben@bagu.org>
3210 Move UI code from the main module to its own class.
3212 This is the first commit of a refactor that will allow OnlineGlom to be
3213 used with multiple documents.
3215 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3216 references to OnlineGlom to OnlineGlomView.
3217 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3218 OnlineGlomView and instantiate it here.
3219 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3220 represents the main OnlineGlomView with one document.
3222 2011-04-01 Ben Konrath <ben@bagu.org>
3224 Fix formatting of gwt.xml and add DTD.
3226 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3228 2011-03-30 Ben Konrath <ben@bagu.org>