1 2012-03-15 Murray Cumming <murrayc@murrayc.com>
3 Use the latest java-libglom version.
5 * pom.xml: Use java-libglom 1.21.7.
7 2012-03-03 Ben Konrath <ben@bagu.org>
9 Display date and time in details view.
11 https://bugzilla.gnome.org/show_bug.cgi?id=671257
13 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
15 2012-02-24 Ben Konrath <ben@bagu.org>
17 Improve the tabs in the Notebook widget.
21 2012-01-30 Murray Cumming <murrayc@murrayc.com>
23 Translations: Try to translate the strings.
25 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
26 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
27 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
28 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
29 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
30 Take the Open translation from GTK+'s .po files.
31 Take the Details translation from Glom's po files.
32 I have added the other strings to Glom so we can get translations that way:
33 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
35 2012-01-27 Murray Cumming <murrayc@murrayc.com>
37 TableSelectionViewImpl: Put the search label and entry in a div.
39 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
40 Put the search widgets in a FlowTable so that the CSS can be used to
41 style them while keeping them together.
42 * src/main/webapp/style.css: Mention the new div.
44 2012-01-27 Murray Cumming <murrayc@murrayc.com>
46 Translate more strings in more locales.
48 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
49 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
50 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
51 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
52 Translate the "Details" and "Open" string too.
54 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
55 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
56 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
57 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
58 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
59 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
60 Add these new locales as placeholders though they currently contain English.
62 2012-01-27 Murray Cumming <murrayc@murrayc.com>
64 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
66 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
67 Check the ConfiguredDocument* for null before using it.
69 2012-01-26 Murray Cumming <murrayc@murrayc.com>
71 Tell Eclipse about the generated java files.
73 * .classpath: This lets it find OnlineGlomConstants.java.
74 It would be nice if Eclipse just used the maven build files.
76 2012-01-26 Murray Cumming <murrayc@murrayc.com>
78 Prevent a crash when no locale is specified in the URL.
80 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
81 Avoid returning a null string, obtained from
82 Window.Location.getParameter(). This caused a crash when it was
83 later passed to libglom's API.
84 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
85 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
86 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
87 guard against future null strings.
89 2012-01-26 Murray Cumming <murrayc@murrayc.com>
91 Use the ?locale= query param instead of the &lang= token param.
93 * src/main/java/org/glom/web/client/place/ListPlace.java
94 * src/main/java/org/glom/web/client/place/DetailsPlace.java
95 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
96 Remove the lang token key and value.
98 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
99 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
100 When the user selects a different locale from the chooser, use
101 Window.Location.assign() to change the URL, which then causes a reload.
103 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
104 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
105 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
106 * src/main/java/org/glom/web/client/activity/ListActivity.java
107 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
108 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
109 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
110 * src/main/java/org/glom/web/client/ui/ListView.java:
111 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
113 Remove localeID member variables and method/constructor parameters, instead
114 using Utils.getCurrentLocaleID() when we need a localID to pass to
117 2012-01-26 Murray Cumming <murrayc@murrayc.com>
119 Internationalize the UI strings.
121 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
122 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
123 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
124 because it is unused. Messages are apparently strings that can have
125 parameters, but we do not need that yet, so Contants will be enough for now.
126 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
127 to say that we support the en and de locales.
128 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
129 The original English strings.
130 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
131 Some German translations of the English strings.
132 The i18n goal then uses the .properties file to generate an
133 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
134 returns an implementation that returns the translated strings.
135 The documentation suggests putting these in src/java/*/client/, but it seems
136 best to put it in src/resources/*/client/.
137 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
138 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
139 instead of hard-coding them.
140 Note that we cannot import OnlineGlomConstants because it does not exist yet,
141 but that does not seem to stop the build, though it confuses Eclipse.
143 You can see the translated string by adding ?locale=de to the URL, like so:
144 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
146 2012-01-24 Murray Cumming <murrayc@murrayc.com>
148 Improve null/empty String checks.
150 * pom.xml: Add a dependency on commons-lang, to use
151 org.apache.commons.lang.StringUtils.
152 * src/main/java/org/glom/web/server/ConfiguredDocument.java
153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
154 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
155 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
156 Use StringUtils.isEmpty().
158 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
159 StringUtils class with a static isEmpty() function because we
160 cannot use org.apache.commons.lang.StringUtils in client-side
161 GWT code because it (apparently) cannot be compiled to javascript.
162 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
163 * src/main/java/org/glom/web/client/activity/ListActivity.java
164 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
165 * src/main/java/org/glom/web/client/place/DetailsPlace.java
166 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
167 * src/main/java/org/glom/web/client/place/ListPlace.java
168 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
169 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
170 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
171 * src/main/java/org/glom/web/client/ui/details/Group.java
172 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
173 our StringUtils.isEmpty() function.
175 2012-01-24 Murray Cumming <murrayc@murrayc.com>
177 Update to the latest java-libglom API.
179 * pom.xml: Require java-libglom 1.21.4.
180 * src/main/java/org/glom/web/server/ConfiguredDocument.java
181 getDocumentInfo(), getListViewLayoutGroup():
182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
184 * src/main/java/org/glom/web/server/database/DBAccess.java
185 getFieldsToShowForSQLQueryAddGroup(),
186 getPrimaryKeyLayoutItemField(): Replace get_database_title()
187 with either get_database_title_original() or
188 get_database_title(localeID).
190 2012-01-24 Murray Cumming <murrayc@murrayc.com>
192 ConfiguredDocument: Avoid a null pointer exception.
194 * src/main/java/org/glom/web/server/ConfiguredDocument.java
195 Initialize localeID to "" to avoid returning a null String which
196 causes a crash in java-libglom's swing-generated code.
198 2012-01-23 Murray Cumming <murrayc@murrayc.com>
200 Some simple renaming.
202 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
203 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
204 for localeChooser. This seems more appropriate and is less ambiguous
205 particularly in the .css file.
207 2012-01-23 Murray Cumming <murrayc@murrayc.com>
209 ConfiguredDocument: Rename the localedID private member variable.
211 2012-01-23 Murray Cumming <murrayc@murrayc.com>
213 Adapt to the latest java-libglom API from git master.
215 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
216 libglom now uses only Vector instead of List, which uses add() instead of
219 2012-01-20 Murray Cumming <murrayc@murrayc.com>
221 Build a source tarball with mvn assembly:single
223 * assembly.xml: Add this file.
224 * pom.xml: Use the maven-assembly-plugin and tell it to use
225 our assembly.xml file.
227 2012-01-19 Murray Cumming <murrayc@murrayc.com>
229 OnlineGlomServiceImpl: Get .glom files recursively.
231 * pom.xml: Depend on commons-io from org.apache.commons.
232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
233 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
234 files recursively, and with the easier filter for the extension.
235 Use org.apache.commons.io.FilenameUtils.removeExtension() to
236 simplify that code too.
238 2012-01-19 Murray Cumming <murrayc@murrayc.com>
240 README: Mention that you must install java-libglom packages separately.
242 But then it works, because java-libglom is now in the central maven
245 2012-01-18 Murray Cumming <murrayc@murrayc.com>
247 locales drop-down: Show the correct selected locale when the URL changes.
249 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
250 .java: setPlace(): Move some code into fillView().
252 2012-01-18 Murray Cumming <murrayc@murrayc.com>
254 locales drop-down: Do not lose the primary key.
256 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
257 start(): onLocaleChange(): Pass the current primary key value,
258 instead of an empty value.
260 2012-01-18 Murray Cumming <murrayc@murrayc.com>
262 locales drop-down: Do not lose the drop-down selection.
264 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
265 .java (TableSelectionActivity.fillView): Set the selected locale
266 after changing the drop-down items (though we do not really need
267 to change them just because the locale changes.)
269 2012-01-18 Murray Cumming <murrayc@murrayc.com>
271 locales drop-down: Change the tables list when this changes.
273 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
274 .java: TableSelectionActivity.start(): Move the async table titles
275 retrieval into a private fillView() method and also call this when
276 the chosen locale changes.
277 Note that the document title is not actually translatable yet, but
278 that is a problem that I should fix soon in libglom.
280 2012-01-18 Murray Cumming <murrayc@murrayc.com>
282 Improve the placement of the locales drop-down.
284 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
285 Put the title and locales drop-down in a div (gwt.FlowTable).
286 * src/main/webapp/style.css: Add magic css properties to make this work.
287 Also remove the left margin from the title so that it lines up with the
290 2012-01-18 Murray Cumming <murrayc@murrayc.com>
292 locales selector: Show human-readable locale titles.
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java
295 getDocumentInfo(): Use java.util.Locale to show a real title of
296 each locale, in the locale's own language.
298 2012-01-17 Murray Cumming <murrayc@murrayc.com>
300 Add a language/locale selector drop-down.
302 * src/main/java/org/glom/web/shared/DocumentInfo.java:
303 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
304 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
305 getDocumentInfo(): Store the available Locales in the DocumentInfo.
306 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
307 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
308 Add a ListBox to show the available locales. Add getLocaleSelector(),
309 setLocaleList(), getSelectedLocale(), setSelectedLocale().
310 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
311 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
312 java: Add these classes.
313 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
314 start(): Fill the locales ListBox. Handle its change event, firing a
316 setPlace(): Show the selected locale as specified by the URL token.
317 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
318 * src/main/java/org/glom/web/client/activity/ListActivity.java:
319 Handle LocaleChangeEvent, going to a new *Place with that locale.
321 The placement of the ListBox is not pretty, and it currently uses the ID
322 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
326 2012-01-17 Murray Cumming <murrayc@murrayc.com>
328 Search box: Show the search text from the URL token.
330 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
331 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
332 Add setQuickFindText().
333 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
334 .java: setPlace(): Store the queryText if the place is a ListPlace,
335 and call TableSelectionView.setQuickFindText().
337 2012-01-17 Murray Cumming <murrayc@murrayc.com>
339 Allow use of translations via, for instance, &lang=de in the URL.
341 * pom.xml: Use the unstable java-libglom 1.21 version.
343 * src/main/java/org/glom/web/client/OnlineGlomService.java:
344 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
346 init(): Instead of calling TranslatableItem.set_current_locale()
347 (now removed), call ConfiguredDocument.setDefaultLocaleID().
348 However, this is only for default locales, which are not needed to
349 change the locale in the URL.
350 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
351 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
352 getSortedRelatedListData(): Add a localeID parameter, so we can get the
353 layout for a particular locale.
354 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
355 Add get/setDefaultLocaleID().
356 getDocumentInfo(), getListViewData(), getRelatedListData(),
357 getDetailsLayoutGroup(), getListViewLayoutGroup(),
358 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
359 localeID parameter, so we can get the layout for a particular locale.
361 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
362 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
363 * src/main/java/org/glom/web/client/place/ListPlace.java:
364 Parse and construct a lang parameter too.
366 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
367 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
368 passed to subsequent methods and constructors.
369 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
370 * src/main/java/org/glom/web/client/activity/ListActivity.java:
371 Store the localeID from the *Place and pass it to other constructors
372 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
374 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
375 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
376 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
377 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
378 * src/main/java/org/glom/web/client/ui/ListView.java:
379 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
380 Take localeID parameters and pass them to subsequent constructors and
381 methods, so that the layout is always retrieved for that locale.
383 This is rather repetitive.
385 Note that "" means the original (default) locale of the Glom document,
386 which is usually English.
388 2012-01-17 Murray Cumming <murrayc@murrayc.com>
390 Documents: Remove final keyword to fix startup configuration.
392 * src/main/java/org/glom/web/shared/Documents.java: Remove the
393 final keywords on the private member variables because that breaks
394 the startup, apparently (there are warnings) because it stops them
395 from being serialized. I added these in the previous commit.
397 2012-01-13 Murray Cumming <murrayc@murrayc.com>
399 Documents: Add some final keywords.
401 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
404 2012-01-13 Murray Cumming <murrayc@murrayc.com>
406 OnlineGlomServiceImpl: Add to overview comments.
408 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
409 Note that this is where all the document are loaded. They are not
410 loaded freshly for each page.
412 2012-01-12 Murray Cumming <murrayc@murrayc.com>
416 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
417 Add a TextBox for the text of a quick find.
418 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
420 setBackLink(): Add a String quickFind parameter.
421 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
422 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
423 to the base interface, because that is how TableSelectionViewImpl is used.
424 * src/main/webapp/style.css: Add style for the search box and its label.
426 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
427 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
428 Add these files, based on the existing TableChangeEvent and
429 TableChangeEventHandlers.
430 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
431 start(): Handle QuickFindChangeEvent, passing its quickFind text to
432 a ListPlace() that the user should be taken to.
433 * src/main/java/org/glom/web/client/activity/ListActivity.java
434 start(): Handle it here too and adapt the TableChangeEvent handler to
435 pass the extra "" quickFind parameter to ListPlace.
436 * src/main/java/org/glom/web/client/place/ListPlace.java:
437 Constructor: Take an extra String quickFind parameter and store it,
438 returning it from a new getQuickFind() method.
439 getToken(): Put the quickFind text in the URL token.
440 getPlace(): Parse the quickFind text from the URL token.
441 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
442 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
443 ListPlace constructor.
444 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
445 .java: start(): Add a Change handler for the TableSelectionView's
446 TextBox (via its base HasChangeHandlers interface), firing the new
447 QuickFindChangeEvent.
448 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
449 pass the extra "" quickFind parameter.
451 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
452 setCellTable(): Add a String quickFind parameter and pass it to
453 the ListViewTable() constructor.
454 * src/main/java/org/glom/web/client/ui/ListView.java: Change
455 setCellTable() in the base interface, because that is how ListViewImpl
458 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
459 Add a String quickFind member variable.
460 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
461 Constructor: Add a String quickFind parameter, storing it in the
462 base ListTable's member variable.
463 onRangeChanged(): Pass quickFind to the
464 OnlineGlomServiceAsync.getSortedListViewData() and
465 OnlineGlomServiceAsync.getListViewData() methods.
467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
468 getListViewData(), getSortedListViewData(): Add a String quickFind
469 parameter, passing it to ConfiguredDocument.getListViewData().
470 * src/main/java/org/glom/web/client/OnlineGlomService.java:
471 Change getListViewData(), getSortedListViewData() in the base interface,
472 because that is how OnlineGlomServiceImpl is used, via this:
473 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
474 Change getListViewData(), getSortedListViewData() here too.
475 This class can apparently be used to asynchronously call methods on
476 OnlineGlomService, and GWT seems to implement that after recognizing
477 just the *Async name convention and the extra AsyncCallback parameters.
479 * src/main/java/org/glom/web/server/ConfiguredDocument.java
480 getListViewData(): Add a String quickFind parameter, and pass it to
481 ListViewDBAccess.getData().
482 * src/main/java/org/glom/web/server/database/ListDBAccess.java
483 getListData(): Add a String quickFind parameter and pass it to
485 getSelectQuery(): Add a String quickFind parameter.
486 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
487 getSelectQuery(): Add a String quickFind parameter and use it with
488 Glom.get_find_where_clause_quick() to pass a where_clause to
489 Glom.build_sql_select_with_where_clause(), to actually filter the
491 getData(): Add a String quickFind parameter, passing it to getListData().
492 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
493 va: getData(): Pass an empty string to getListData() for the
496 2012-01-12 Murray Cumming <murrayc@murrayc.com>
498 ListTable: Minor change.
500 * src/main/java/org/glom/web/client/ui/list/ListTable.java
501 createCellTable(): Make this protected instead of public.
503 2012-01-12 Murray Cumming <murrayc@murrayc.com>
505 Many files: Use final for the parameters and use the @override attribute.
507 2012-01-22 Ben Konrath <ben@bagu.org>
509 Add anchor links for single line text that starts with http, ftp and www.
513 2012-01-22 Ben Konrath <ben@bagu.org>
515 Add ellipsis to single line text in details view.
519 2012-01-04 Murray Cumming <murrayc@murrayc.com>
521 Remove all javadoc author tags.
523 Because they are awkward and meaningless when many people touch
525 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
527 2012-01-04 Murray Cumming <murrayc@murrayc.com>
529 Revert the COPYING.LESSER to COPYING rename.
531 Apparently both should be there if it is LGPL.
533 2012-01-03 Murray Cumming <murrayc@murrayc.com>
535 *View: Remove unused imports.
537 * src/main/java/org/glom/web/client/ui/DetailsView.java:
538 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
539 * src/main/java/org/glom/web/client/ui/ListView.java:
540 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
541 Remove unused imports, as suggested by Eclipse.
543 2012-01-02 Murray Cumming <murrayc@murrayc.com>
545 Move the *View::Presenter types, and some API into one base View.
547 * src/main/java/org/glom/web/client/ui/DetailsView.java:
548 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
549 * src/main/java/org/glom/web/client/ui/ListView.java:
550 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
551 Presenter, setPresenter() and clear() into a shared base interface,
552 to avoid the unnecessary duplicate Presenter types and to more clearly
553 show how the *Views share the same structure, even if they are not
554 used polymorphically.
556 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
557 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
559 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
560 * src/main/java/org/glom/web/client/activity/ListActivity.java:
561 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
563 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
566 Feel free to revert this if there is a good reason for the duplicate
569 2012-01-02 Murray Cumming <murrayc@murrayc.com>
571 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
573 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
574 a class member instead of a local variable in the method.
575 This lets us use it to get the view instances, for use in tests.
576 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
577 beforeOnlineGlom(): Test some more details of the initial view.
578 Again, this is not very useful.
580 To really test gwt-glom we will need to start a local postgresql
581 instance with local data, like the Glom tests in C++.
583 2012-01-02 Murray Cumming <murrayc@murrayc.com>
585 pom.xml: Mention the LGPL license.
587 * pom.xml: Add a licenses section.
588 * COPYING.LESSER: Move this to COPYING, which
589 previously contained the GPL. But gwt-glom is all LGPL.
591 2012-01-02 Murray Cumming <murrayc@murrayc.com>
593 Add project information to README and pom.xml.
595 * README: Add a brief description and mention some mvn
597 * pom.xml: This extra information shows up in mvn site
600 2011-01-02 Murray Cumming <murrayc@murrayc.com>
602 Use the latest java-libglom version.
604 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
606 2012-01-01 Murray Cumming <murrayc@murrayc.com>
608 GwtTestOnlineGlom: Test a little more.
610 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
611 protected rather than private, as suggested by the gwt-test-utils
613 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
614 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
615 Test the initial visibility of the panels.
617 However, this is not a very useful test.
618 And I wonder how we should generally test using this idea for an
619 activity/places app like ours where the real changes happen implicitly
620 based on the history token/URL.
622 2012-01-01 Murray Cumming <murrayc@murrayc.com>
624 Slight modification to *Mapper comments.
626 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
628 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
630 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
632 Remove comments mentioning GIN because they are just copied from
633 the example code and are apparently not helpful:
634 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
635 Also change the mention of a class that is only in the example code.
637 2012-01-01 Murray Cumming <murrayc@murrayc.com>
639 GwtTestOnlineGlom test: Minor changes.
641 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
642 Avoid the long qualified class name and modify the comment
643 because it is now obvious to me that the mocked class is the only
644 custom one created via GWT.create().
646 2012-01-01 Murray Cumming <murrayc@murrayc.com>
648 Tests: Added the beginnings of a test using gwt-test-utils.
650 * pom.xml: Add dependencies on gwt-test-utils and easymock.
651 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
652 which tells gwt-test-utils what class will be tested.
653 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
654 Add a simple (but empty) test case. One class, used by the OnlineGlom
655 class, is mocked so that it can be created. However, I am not sure
656 why only this class needs to be mocked.
658 Note that mockito seems more popular, and clearer, than easymock,
659 but I have not got that working yet. It might be a matter of the
662 This test is run during mvn integration-test.
664 2011-12-31 Murray Cumming <murrayc@murrayc.com>
666 Tests: Use junit4-style syntax instead of junit3-style.
668 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
669 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
670 * src/test/java/org/glom/web/shared/DataItemTest.java:
671 Use the @Test annotation rather than relying on the test*() prefix.
672 Also no longer implement TestCase, to avoid triggering support for
673 the junit3-way, which stops the annotations from working.
674 Change the imports from import junit.framework.* to
675 import org.junit.*, which is apparently the new way.
677 2011-12-31 Murray Cumming <murrayc@murrayc.com>
679 Added a test for ListPlace token parsing and creation.
681 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
682 This is much the same as DetailsPlaceTest.
684 I wonder how we could test the other parts of the *Place API.
686 2011-12-30 Murray Cumming <murrayc@murrayc.com>
688 DetailsPlace test: Also test getToken() and recreation via getPlace().
690 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
691 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
692 recreate it, testing the recreated DetailsPlace for the same parameter
695 2011-12-30 Murray Cumming <murrayc@murrayc.com>
697 Use the surefire-report plugin.
699 * pom.xml: This generates a HTML report about the tests in
700 target/site/surefire-report.html
701 when you do mvn surefire-report:report. It seems to be popular/normal.
703 2011-12-30 Murray Cumming <murrayc@murrayc.com>
705 Added a test for DetailsPlace.
707 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
708 Test the getPlace() token parsing.
710 2011-12-30 Murray Cumming <murrayc@murrayc.com>
712 Added a first unit test.
714 * pom.xml: Add a test goal, and a dependency on junit in that scope.
715 * src/test/java/org/glom/web/shared/DataItemTest.java:
716 This is a silly test but it is just to get things started. Note that
717 maven/junit finds the test because it looks in src/test by default.
719 2011-12-22 Ben Konrath <ben@bagu.org>
721 Change charsetName to "UTF-8" when replacing line breaks.
723 JavaScript requires the charsetName to be "UTF-8". CharsetName values
724 that work in Java (such as "UTF8") will not work when compiled to
727 This fixes a problem with multi-line details view fields that have hard
728 line breaks. The "License Text" field on this page demonstrates the
731 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
733 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
735 2011-12-22 Ben Konrath <ben@bagu.org>
737 Fix another bug with related list navigation.
739 I've tested all the navigation buttons in all of the related lists
740 so things should be good now.
742 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
744 2011-12-22 Ben Konrath <ben@bagu.org>
746 Fix a crasher when refreshing the list view with the default table.
748 This crash will also happen when loading the list view with the default
749 table from a link or bookmark.
751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
752 to the main document selection page when the document id hasn't been
754 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
755 the main document selection page when the document id hasn't been
757 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
758 values for the details place when the document id hasn't been set.
759 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
760 values for the list place when the document id hasn't been set.
762 2011-12-21 Ben Konrath <ben@bagu.org>
764 Protect against NPE when glom.document.locale is not in config.
766 This patch protects against an NPE when glom.document.locale is not in
767 the config file. This NPE will also happen if glom.document.locale is
770 The patch also updates the error message to display the class name when
771 the getMessage() returns null. This was happening when the NPE was
772 thrown and I had "Configuration Error: null". If an NPE is encountered
773 with this patch, "Configuration Error: NullPointerException " will be
776 This commit closes this bug:
778 https://bugzilla.gnome.org/show_bug.cgi?id=666669
780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
782 2011-12-20 Murray Cumming <murrayc@murrayc.com>
784 Rename onlineglom.properties to onlineglom.properties.sample.
786 * src/main/resources/onlineglom.properties: Rename to:
787 * src/main/resources/onlineglom.properties.sample:
788 * src/main/resources/README: And add this file explaining that people
789 should rename it back when deploying.
791 2011-12-20 Murray Cumming <murrayc@murrayc.com>
793 Allow choosing the translation in the .properties file.
795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
796 init(): Read a glom.document.locale value from the configuration file
797 and call Glom's TransatableItem::set_current_locale() method.
798 * src/main/resources/onlineglom.properties: Add a commented-out
799 example of this new setting.
801 It would be better to add &lang=de_DE to the URL, but the current
802 libglom API does not allow us to do this easily. I am working on that.
804 2011-12-19 Murray Cumming <murrayc@murrayc.com>
806 Avoid a crash in parsing of token parameters.
808 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
809 ava: getTokenParams(): Do not crash if a parameter has a key but no
810 value, and ignore parameters with neither.
812 2011-12-17 Murray Cumming <murrayc@murayc.com>
814 History token building/handling: Improve use of token parameters.
816 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
817 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
818 and buildParamsToken(HashMap), for use by derived classes.
819 Make the separator private because it is no longer be needed.
820 * src/main/java/org/glom/web/client/place/DetailsPlace.java
821 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
822 instead of manual string concatenation.
823 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
824 of hardcoded indices and awkward splitting code.
825 * src/main/java/org/glom/web/client/place/ListPlace.java
826 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
827 instead of manual string concatenation.
828 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
829 of hardcoded indices and awkward splitting code.
830 This should fix bug #666420
832 2011-12-16 Murray Cumming <murrayc@murrayc.com>
834 Fix a Navgiation->Navigation typo in the code.
836 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
837 Rename processNavgiation() to processNavigation().
839 2011-12-16 Murray Cumming <murrayc@murrayc.com>
841 Fix a seperator->separator typo in the code.
843 * src/main/java/org/glom/web/client/place/DetailsPlace.java
844 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
845 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
848 2011-12-15 Ben Konrath <ben@bagu.org>
850 Cleanup some comments.
852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
854 2011-12-14 Ben Konrath <ben@bagu.org>
856 Replace \n with <br/> for multiline text in the details view.
858 Vertical scrollbars are added when needed as well.
860 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
862 2011-12-14 Ben Konrath <ben@bagu.org>
864 Specify the font for document selection links.
866 * src/main/webapp/style.css:
868 2011-12-14 Ben Konrath <ben@bagu.org>
870 Fix bouncy CellTable while paging.
872 This doesn't currently work with related list tables in unselected
875 * src/main/java/org/glom/web/client/ui/list/ListTable.java
877 2011-12-14 Ben Konrath <ben@bagu.org>
879 Revamp the appearance of the document selection page.
881 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
882 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
883 * src/main/webapp/style.css:
885 2011-12-13 Ben Konrath <ben@bagu.org>
887 Set navigation button column to the smallest size possible.
889 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
891 2011-12-13 Ben Konrath <ben@bagu.org>
893 Change OpenButton nomenclature to NavigationButton.
895 Using NavigtionButton makes things more generic. Classes, methods and
896 variables have been changed.
898 This is a rename-only refactor.
900 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
901 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
902 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
903 Renamed from OpenButtonCell.
904 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
905 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
906 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
908 2011-12-12 Ben Konrath <ben@bagu.org>
910 Remove unnecessary String argument in RelatedListTable and ListViewTable.
912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
913 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
914 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
915 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
917 2011-12-12 Ben Konrath <ben@bagu.org>
919 Update variable names and comments.
921 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
922 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
924 2011-12-12 Ben Konrath <ben@bagu.org>
926 Properly initialize numNonEmptyRows variable to zero.
928 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
929 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
931 2011-12-05 Ben Konrath <ben@bagu.org>
933 Add latest mockup with HTML tables.
935 Features of this mockup:
937 -> HTML table for flowtable
938 -> HTML table for flowtable column
939 -> Example of how related lists would look
940 -> Not using text entries for data items
942 The current version of Online Glom doesn't use HTML tables for the
945 This mockup has been sent to the glom-devel mailing list but it's good
946 to have it here as well.
948 * mockups/details-view-html-tables.html:
950 2011-12-05 Ben Konrath <ben@bagu.org>
952 Remove unnecessary getPrimaryKeyField() method.
954 getPrimaryKeyFieldForTable(String) has been renamed to
955 getPrimaryKeyField(String).
957 * src/main/java/org/glom/web/server/database/DBAccess.java:
958 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
959 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
961 2011-12-05 Ben Konrath <ben@bagu.org>
963 Add string representation of TypedDataItem value to conversion error message.
965 * src/main/java/org/glom/web/server/Utils.java: Logging the error
966 message was extracted into its own method to avoid duplication.
968 2011-12-05 Ben Konrath <ben@bagu.org>
970 Add type checking to navigation primary key value creation.
972 Create navigation primary key only if the expected type from the Glom
973 document matches the type returned by the SQL query.
975 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
977 2011-12-05 Ben Konrath <ben@bagu.org>
979 Rename a couple of variables in RelatedListNavigation.
981 This is a rename-only refactor.
983 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
985 2011-12-05 Ben Konrath <ben@bagu.org>
987 Move getListLayoutGroup() into getListViewLayoutGroup().
989 This removes getListLayoutGroup(). It was only being called by
990 getListViewLayoutGroup().
992 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
994 2011-12-05 Ben Konrath <ben@bagu.org>
996 Remove check for LayoutItem_Portal in list table method.
998 This check is no longer necessary because the method isn't being used
999 to create the LayoutItemPortal DTO.
1001 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1003 2011-12-05 Ben Konrath <ben@bagu.org>
1005 Properly support related list navigation.
1007 Navigation from the "Repository Analyzer -> Package Scans ->
1008 Dependencies" related table wasn't working because the primary key for
1009 related tables wasn't being set properly. This commit fixes the
1012 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1013 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1014 doesn't set the primary key properly for related list tables.
1015 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1016 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1017 useful for getting the primary key for list view tables and for related
1019 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1020 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1021 Move code to set the primary key for the table from the abstract
1022 ListDBAccess class to ListViewDBAccess as it's only correct for list
1024 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1025 Properly add primary key to related list tables.
1027 2011-12-02 Ben Konrath <ben@bagu.org>
1029 Properly set the horizontal alignment of fields.
1031 This fix is for both the list tables and the details view.
1033 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1034 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1035 to set the horizontal alignment of fields.
1037 2011-12-02 Ben Konrath <ben@bagu.org>
1039 Display currency codes in the details view.
1041 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1043 2011-12-02 Ben Konrath <ben@bagu.org>
1045 Avoid duplicate JNI call.
1047 JNI is not as efficient as pure Java and this is an easy (and small)
1050 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1051 Use previously retrieved value for whereClauseToTableName instead of
1054 2011-12-02 Ben Konrath <ben@bagu.org>
1056 Rename a couple of variables in RelatedListNavigation.
1058 This is a rename-only refactor.
1060 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1062 2011-12-02 Ben Konrath <ben@bagu.org>
1064 Indicate clearly that a mismatched primary key type is a bug.
1066 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1067 warning to error. Add 'This is a bug.' to message.
1069 2011-12-02 Ben Konrath <ben@bagu.org>
1071 Update / fix some comments.
1073 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1075 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1077 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1078 Fix comments. Add some TODOs.
1080 2011-12-02 Ben Konrath <ben@bagu.org>
1082 Enable navigation to details view with string primary key from related list.
1084 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1085 Create a text primary key value when return type of result is
1086 java.sql.Types.VARCHAR.
1088 2011-12-02 Ben Konrath <ben@bagu.org>
1090 Use checkboxes for booleans in the details view.
1092 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1094 2011-12-01 Ben Konrath <ben@bagu.org>
1096 Improve performance of related list height calculation.
1098 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1099 Put code to calculate the expected height in a static initializer so
1100 that that it's only called once.
1102 2011-12-01 Ben Konrath <ben@bagu.org>
1104 Show related list tables in notebooks (again).
1106 Calculate the height of the related list tables so the Notebook can be
1107 set the correct height. The height of the related list table is also needed by
1108 FlowTable to be able decide how to create the layout.
1110 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1111 and set the Portal height based on the height of the related list
1112 table and the Portal container.
1113 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1114 Add method to calculate the height of the related list tables.
1115 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1116 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1117 calculate the height of the Pager widget.
1119 2011-12-01 Ben Konrath <ben@bagu.org>
1121 Use CellTable API for table property instead of setting style on Element.
1123 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1125 2011-12-01 Ben Konrath <ben@bagu.org>
1127 Make ListViewTable and RelatedListTable a consistent height.
1129 The tables are now a consistent height regardless of the contents of
1130 the table. A hidden button is added to empty rows to ensure that the
1131 height of these rows will match the height of rows with data.
1133 A navigation button column is now added to every table. The width of
1134 the navigation column is set to 0px when a RelatedListTable shouldn't
1135 have navigation buttons. This maintains the a consistent row height in
1136 tables that don't show the navigation buttons.
1138 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1139 navigation column when not needed.
1140 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1141 arguments for navigation button to constructor of ListViewTable.
1142 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1143 hidden button for empty data rows.
1144 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1145 arguments for navigation button to constructor.
1146 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1147 create navigation buttons. Add hideNavigationButtons() method.
1148 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1149 arguments for navigation button to constructor.
1151 2011-12-01 Ben Konrath <ben@bagu.org>
1153 Use 'visibility: hidden' in Utils.getWidgetHeight().
1155 This is better choice because hidden elements are invisible, don't
1156 respond to events and are not part of the tab order. They will,
1157 however, take up space which is required to be able to calculate the
1158 height of the widget.
1160 * src/main/java/org/glom/web/client/Utils.java:
1162 2011-12-01 Ben Konrath <ben@bagu.org>
1164 Use Utils.getWidgetHeight() in FlowTable.
1166 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1168 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1170 2011-12-01 Ben Konrath <ben@bagu.org>
1172 Put the details css class name on the correct table column.
1174 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1176 2011-11-30 Ben Konrath <ben@bagu.org>
1178 Update for java-libglom API change.
1180 The getters and setters on FieldFormatting and NumericFormat were
1181 changed to remove the 'M'.
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1185 2011-11-29 Ben Konrath <ben@bagu.org>
1187 Only allow RelatedListTables in Portals.
1189 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1191 2011-11-29 Ben Konrath <ben@bagu.org>
1193 Only create a contents panel for Portals when title is being set.
1195 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1197 2011-11-29 Ben Konrath <ben@bagu.org>
1199 Set TabLayoutPanel height based on calculated height its widgets.
1201 This is a potential fix for this bug:
1203 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1205 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1207 2011-11-29 Ben Konrath <ben@bagu.org>
1209 Align details field labels and data with the Open buttons.
1211 * src/main/webapp/style.css:
1213 2011-11-29 Ben Konrath <ben@bagu.org>
1215 Remove unnecessary <div> in the Notebook widget.
1217 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1218 method to get container FlowPanel (<div>).
1219 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1220 initWidget() method directly on the TabLayoutPanel widget instead of
1221 Group's container widget.
1223 2011-11-29 Ben Konrath <ben@bagu.org>
1225 Don't add group titles for Portals in Notebooks.
1227 This reverts the previous patch and fixes a bug I introduced with
1228 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1230 * src/main/java/org/glom/web/client/ui/details/Group.java:
1231 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1233 2011-11-28 Ben Konrath <ben@bagu.org>
1235 Remove unused boolean argument in Portal constructor.
1237 Just a code cleanup.
1239 * src/main/java/org/glom/web/client/ui/details/Group.java:
1240 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1242 2011-11-28 Ben Konrath <ben@bagu.org>
1244 Remove hack for glom 1.18 style glom files.
1246 * src/main/java/org/glom/web/client/ui/details/Group.java:
1247 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1248 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1250 2011-11-28 Ben Konrath <ben@bagu.org>
1252 Use Gda Value version of primary key to log result too large error.
1254 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1256 2011-11-28 Ben Konrath <ben@bagu.org>
1258 Don't use TypedDataItem.getText() for Unknown types from the URL.
1260 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1261 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1262 instead of getText().
1263 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1264 String field and getUnknown() method.
1266 2011-11-28 Ben Konrath <ben@bagu.org>
1268 Log an error message when the java-libglom .so is not present.
1270 The error message was being set in the exception but not logged.
1272 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1274 2011-11-28 Ben Konrath <ben@bagu.org>
1276 Ignore LayoutItem_CalendarPortals.
1278 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1279 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1281 2011-11-28 Ben Konrath <ben@bagu.org>
1283 Extract method for creating the LayoutItemPortal DTO.
1285 Just breaking the code up into smaller chunks.
1287 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1289 2011-11-28 Ben Konrath <ben@bagu.org>
1293 This should have been added with the refactor. Oops!
1295 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1297 2011-11-28 Ben Konrath <ben@bagu.org>
1299 Create primary key value from URL string using type from Glom document.
1301 See this bug, comments 19 - 25:
1303 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1305 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1306 create a TypeDataItem for the primary key here when loading from a
1307 URL. Show the same string for the primary key value as was received
1308 from the URL string (when loading from a URL).
1309 * src/main/java/org/glom/web/server/Utils.java: Update method for
1310 creating the Gda Value from the TypeDataItem to properly deal with
1311 creating a Gda Value based on the Glom document type for the primary
1312 key value string when loading from a URL.
1313 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1314 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1315 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1316 Update for changed method name.
1318 2011-11-27 Ben Konrath <ben@bagu.org>
1320 Rename PrimaryKeyItem to TypedDataItem.
1322 The name PrimaryKeyItem suggests what the class should be used for.
1323 TypedDataItem is a neutral name that describes the class better.
1325 This is a rename-only refactor.
1327 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1328 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1329 * src/main/java/org/glom/web/client/Utils.java:
1330 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1331 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1332 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1333 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1334 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1335 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1337 * src/main/java/org/glom/web/server/Utils.java:
1338 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1339 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1340 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1341 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1343 2011-11-25 Ben Konrath <ben@bagu.org>
1345 Improve Gda Value conversion from PrimaryKeyItem.
1347 The value from the PrimaryKeyItem is only used if its type match the
1348 type from the glom document.
1350 * src/main/java/org/glom/web/server/Utils.java:
1352 2011-11-25 Ben Konrath <ben@bagu.org>
1354 Manually check if the java-liblgom .so is visible to the JVM.
1356 It seems that Tomcat has problems when a static initializer throws an
1357 exception. This check is done before the first method call into
1358 java-libglom so that execution doesn't continue if the .so is not
1361 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1363 2011-11-25 Ben Konrath <ben@bagu.org>
1365 Improve browser configuration error messages.
1369 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1371 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1372 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1373 getConfigurationErrorMessage() method.
1374 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1375 Get and display a specific configuration error message when no Glom
1376 documents are found.
1377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1378 Implement getConfigurationErrorMessage() method. Surround configuration
1379 code in the init() method with a try/catch block. This allows the
1380 errors to be caught while keeping the servlet available to retrieve the
1381 configuration error message.
1383 2011-11-25 Ben Konrath <ben@bagu.org>
1385 Don't use Strings to hold primary key values.
1387 The primary key values are now held in a new data object
1388 (PrimaryKeyItem) that holds type information and the primary key value
1389 using the correct type.
1391 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1392 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1394 PrimaryKeyItem instead of String to hold the primary key value.
1395 * src/main/java/org/glom/web/client/Utils.java: Remove
1396 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1397 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1398 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1399 PrimaryKeyItem instead of String to hold the primary key value. Load
1400 document selection page when the documentID has not been set correctly.
1401 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1402 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1404 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1405 Return empty string for URL instead of "null".
1406 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1407 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1408 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1409 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1410 PrimaryKeyItem instead of String to hold primary key values.
1411 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1412 PrimaryKeyValue to a Gda Value.
1413 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1414 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1415 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1416 Replace temporary database access code that uses the PrimaryKeyValue to
1417 Gda Value conversion.
1418 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1419 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1420 PrimaryKeyItem instead of String.
1421 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1422 hold primary key values.
1424 2011-11-24 Ben Konrath <ben@bagu.org>
1426 Use newly added java-libglom API to create queries.
1428 This isn't finished. I still need to stop using Strings for primary key
1429 values in the client code.
1431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1432 libglom to use fake connections so that retrieving the query string will
1434 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1435 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1436 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1437 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1438 Use the newly added libglom sql methods and classes to create the
1439 query. Add temporary hack to convert primary value strings to Gda
1442 2011-11-23 Ben Konrath <ben@bagu.org>
1444 Don't explicitly set the height of Portals.
1446 See comments 6 - 10 of this bug for details:
1448 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1450 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1452 2011-11-23 Ben Konrath <ben@bagu.org>
1454 Use an HTML table instead of CSS for the FlowTable layout.
1456 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1457 GWT's FlexTable to implement the FlowTable.
1458 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1460 2011-11-18 Ben Konrath <ben@bagu.org>
1462 Add boolean example to HTML table mockup.
1464 * mockups/details-view-html-tables-text-entries.html:
1466 2011-11-17 Ben Konrath <ben@bagu.org>
1468 Ensure the pager buttons are always visible for related lists.
1470 To accomplish this, I've turned off text wrapping in the list view and
1471 related list tables for both the header and data text. The related list
1472 table now has a fixed layout so the it doesn't overflow its container.
1473 This is required to ensure that the cell text is clipped when it
1474 overflows the cell and an ellipsis is added to the right side of the
1475 cell when text is clipped.
1477 A fixed table layout for the related list table in the details view
1478 seems what we want for the details view anyway, so the side-effect is
1481 The ellipsis will only be displayed in Firefox >= 7.
1485 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1487 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1488 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1489 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1491 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1492 Set the 'table-layout: fixed' CSS property to the related list table.
1493 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1494 'white-space: nowrap;' CSS property on both the list view and the
1495 related list tables.
1497 2011-11-16 Ben Konrath <ben@bagu.org>
1499 Rework the fix for empty notebook tab labels.
1501 Setting the empty group titles with its name caused problems for the
1502 details layout. Instead of using libglom's
1503 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1504 to the client when the title is empty. This allows the Notebook to use
1505 the name when the title is empty without affecting anything else.
1507 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1508 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1510 2011-11-16 Ben Konrath <ben@bagu.org>
1512 Set group titles with name when title is empty.
1514 This fixes a problem with an empty notebook tab label in the Lesson
1515 Planner document. The forth tab in the notebook should be "Internet":
1517 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1519 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1520 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1523 2011-11-16 Ben Konrath <ben@bagu.org>
1525 Remove whitespace from the configured username properties.
1527 This assumes that usernames won't have whitespace at the beginning
1528 or end. But I think this is a reasonable assumption.
1530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1531 String.trim() to remove the whitespace from the username properties.
1533 2011-11-15 Ben Konrath <ben@bagu.org>
1535 Add details view mockup with HTML tables and text entries.
1537 This is from the attachment on this bug:
1539 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1541 * mockups/details-view-html-tables-text-entries.html:
1543 2011-11-15 Ben Konrath <ben@bagu.org>
1545 Add space between the columns of the flow table.
1549 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1551 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1552 space between columns in the flow table.
1554 2011-11-15 Ben Konrath <ben@bagu.org>
1556 Add backup files to the .gitignore.
1558 * .gitignore: Ignore files that end with ~.
1560 2011-11-09 Ben Konrath <ben@bagu.org>
1562 Use latest release of gwt-log.
1564 Gwt-log releases are now being submitted to the maven central
1565 repository so manual installation of the jar is no longer required.
1567 * pom.xml: Update version and groupId of gwt-log dependency.
1569 2011-10-31 Ben Konrath <ben@bagu.org>
1571 Don't use GWT numeric formatting to override the glom currency formatting.
1573 Currencies are now displayed like they are in Glom. See this bug:
1575 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1577 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1579 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1580 currency code to constructor and set it when the cell is rendered.
1581 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1582 currency code to the constructor of the NumericCell.
1584 2011-10-27 Ben Konrath <ben@bagu.org>
1586 Require the latest release of java-libglom (1.17.4).
1590 2011-10-26 Ben Konrath <ben@bagu.org>
1592 Add style to Notebook that matches current theme.
1594 It's not the best style in the world but it's better than the default.
1596 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1597 padding at the bottom of the child widgets.
1598 * src/main/webapp/style.css: Add style for the Notebook.
1600 2011-10-26 Ben Konrath <ben@bagu.org>
1602 Move servlet initialization code to overridden init method.
1604 This is half of the solution to getting proper error messages
1605 displayed when configuration errors occur. Here's the relevant bug:
1607 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1609 The rest of the solution involves surrounding the init method with a
1610 try/catch block and setting a global variable with the error /
1611 exception. A new async method should be created to retrieve and display
1612 the error message / exception.
1614 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1615 code from constructor to init method adding exceptions as needed.
1617 2011-10-26 Ben Konrath <ben@bagu.org>
1619 Add script to monitor and restart tomcat if required.
1621 * utils/check-and-recover-tomcat.py: New file.
1623 2011-10-26 Ben Konrath <ben@bagu.org>
1625 Display the correct number of data items in the pager.
1629 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1631 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1632 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1633 The implementation is the same for both tables: Keep track of the
1634 number of non-empty rows and fire and RowCountChangeEvent after the data has
1636 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1637 custom Pager class that subclasses SimplePager to handle displaying
1638 the correct number when empty rows have been added.
1640 2011-10-26 Ben Konrath <ben@bagu.org>
1642 Correct error in previous commit.
1644 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1645 eventBus parameter from listView.setCellTable().
1647 2011-10-26 Ben Konrath <ben@bagu.org>
1649 Fix error in TODO comment.
1651 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1653 2011-10-24 Ben Konrath <ben@bagu.org>
1655 Create Notebook widgets to the details view.
1657 This isn't finished just yet - I still need to create a reasonable
1658 style to match the current theme.
1660 * src/main/java/org/glom/web/client/Utils.java: Add method for
1661 calculating the height of a widget. This is used in the Notebook class.
1662 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1663 new constructor method in Group.
1664 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1665 method for creating child widget that can be used by subclasses
1666 like Notebook. New constructor that allows disabling the group
1667 titles - Notebooks don't set a group title for their child groups.
1668 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1669 to make Notebooks using GWT's TabLayoutPanel.
1670 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1671 constructor that allows disabling the group titles.
1672 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1673 LayoutItemNotebook DTO.
1674 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1675 DTO for Notebooks. It's just an empty class for now but we might need
1676 it to transfer some specific information in the future.
1678 2011-10-21 Ben Konrath <ben@bagu.org>
1680 Add navigation buttons to related list tables.
1682 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1683 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1685 method getSuitableRecordToViewDetails() for getting the table name
1686 and primary key value for related list navigation buttons.
1687 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1688 private cell renderer class to get the navigation information for
1689 related list tables from the server. Extract the navigation
1690 processing code from the details cell navigation and use it for the
1691 related list navigation as well.
1692 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1693 cell renderer class for the details open buttons. This was needed
1694 because the related list navigation buttons and the list view
1695 navigation buttons need to react differently when clicked.
1696 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1697 the onEnterKeyDown() method because it's now overriden in the
1698 subclasses that are specific to the related list tables and the list
1700 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1701 the vertical size a little because the buttons add a bit of vertical
1702 space to table. This is not a perfect solution because the vertical
1703 size of with table fewer than 5 rows will be a little smaller.
1704 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1705 changes in how navigation buttons are handled.
1706 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1707 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1708 database access object.
1709 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1710 to find the portal for a given relationship name from
1711 RelatedListDBAccess. Add method to find a primary key field for a
1713 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1714 Move code to find the portal for a given relationship name to
1716 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1717 New file: database access object for getting the related list
1718 navigation information (the table name and the primary key value).
1719 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1720 DTO for transferring a table name to navigate to and a primary key
1722 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1723 boolean and getter/setter to specifies if the related list should add
1726 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1728 Use the master branch of java-libglom
1730 * pom.xml: Depend on java-libglom 1.19 instead.
1732 This is the master branch. See also the libglom-1-18 branch.
1734 2011-10-11 Ben Konrath <ben@bagu.org>
1736 Enable the open navigation button when the data has been set.
1738 This avoids having active buttons that don't do anything when the data
1741 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1743 2011-10-11 Ben Konrath <ben@bagu.org>
1745 Use IsWidget interface for FlowTableItem.
1747 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1748 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1750 2011-10-11 Ben Konrath <ben@bagu.org>
1752 Remove GWT styling from open button in details view.
1754 There are still some issues with how the details cell is arranged but
1755 this should be made to match Glom 1.20. I'm going to leave fixing this
1756 until I have Glom 1.20 up and running.
1758 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1759 style name on open button.
1760 * src/main/webapp/style.css: Move and edit details-navigation class.
1761 Re-arrange some classes to make them appear in the same order as the
1764 2011-10-07 Ben Konrath <ben@bagu.org>
1766 Update to GWT 2.4.0.
1768 * .gitignore: Ignore new cache directory.
1769 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1770 * pom.xml: Change GWT and maven plugin to 2.4.0.
1771 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1773 * src/main/java/org/glom/web/client/ClientFactory.java:
1774 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1775 * src/main/java/org/glom/web/client/OnlineGlom.java:
1776 Update source for API changes.
1777 * utils/build-onlineglom-war.sh: Remove cache directory before the
1780 2011-10-07 Ben Konrath <ben@bagu.org>
1782 Add navigation buttons in the details view.
1784 This isn't finished but I thought I'd commit what I have as it's a
1785 pretty good start. I still need to:
1787 1. Change the style so that it fits better into the current theme
1788 2. Adjust the details cell to expand as much as possible.
1790 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1791 click handlers to navigation buttons in the DetailsCells. Create a
1792 refreshData() method to get just the data from the server without the
1794 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1795 Update the tableSelector and browser title when the table name
1796 changes without using the tableSelector.
1797 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1798 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1799 getDetailsCells() to getCells(). Update variable names.
1800 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1801 method to set click handler on navigation button. Rename a few
1802 variables. Add navigation buttons where needed.
1803 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1804 variables and methods.
1805 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1806 navigation boolean and navigation table as required in the
1807 LayoutItemField DTO.
1808 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1809 variables for navigation along with getter/setter methods.
1811 2011-10-07 Ben Konrath <ben@bagu.org>
1813 Rename Field to DetailsCell.
1815 This is a refactor-only commit. No functionality has been added or
1818 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1819 Update variable and method names.
1820 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1821 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1822 variable and method names.
1823 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1825 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1826 variable and method names.
1828 2011-10-07 Ben Konrath <ben@bagu.org>
1830 Create separate methods for layout and data the details view.
1832 This is a refactor-only commit. No functionality has been added or
1835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1836 private methods: setData(), createLayout().
1838 2011-10-07 Ben Konrath <ben@bagu.org>
1840 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1842 This is part of a change to get navigation buttons in the details view
1843 but it should have been done this way from the start.
1845 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1846 for method name change in TableSelectionView.
1847 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1848 Create TableChangeEvent and set the browser title using the
1849 TableSelectionView API.
1850 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1851 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1852 Change getSelectedTable() to getSelectedTableName(). Add
1853 getSelectedTableTitle().
1855 2011-10-07 Ben Konrath <ben@bagu.org>
1857 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1859 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1861 2011-10-07 Ben Konrath <ben@bagu.org>
1863 Update TableChangeEvent to use newTableName naming convention.
1865 This makes the class more consistent with GWT naming conventions.
1867 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1868 Update for method name change in TableChangeEvent.
1869 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1870 for method name change in TableChangeEvent.
1871 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1872 newTableName variable and getter method. Make toDebugString()
1875 2011-09-30 Ben Konrath <ben@bagu.org>
1877 Disable the pager in the list tables when the data row count is less than the minimum.
1879 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1880 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1882 2011-09-30 Ben Konrath <ben@bagu.org>
1884 Add empty rows to the end of related list and list view tables.
1886 I also extracted the cell rendering classes from the ListTable because
1887 the code was becoming a little crazy with all the anonymous inner
1888 classes. My plan is to use these cell rendering classes in the details
1889 view as well so this refactor will be needed for that change.
1891 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1892 set the row count in related list tables if the data has more rows
1893 than the minimum number of rows visible.
1894 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1895 row count in list view tables if the data has more rows than the
1896 minimum number of rows visible.
1897 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1898 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1900 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1901 for rendering TYPE_NUMERIC cells. The code was extracted from the
1903 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1904 class for rendering cells with buttons in list views. The code was
1905 extracted from the ListTable class.
1906 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1907 for rendering TYPE_TEXT cells. The code was extracted from the
1909 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1910 Add empty rows to the end of the data if required. Implement
1911 ListTable.getMinNumVisibleRows().
1912 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1913 cell renderer code to public classes. Return null in
1914 Column.getValue() for empty rows. Add new abstract method:
1915 getMinNumVisibleRows(). Move code to set the row count of the list view
1916 table to ListViewImpl.
1917 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1918 empty rows to the end of the data if required. Implement
1919 ListTable.getMinNumVisibleRows().
1922 2011-09-27 Ben Konrath <ben@bagu.org>
1924 Use GWT.log for client-side debugging statements.
1926 These are optimized out when deployed so I should have used this method
1927 in the first place. These statements will eventually be replaced with some sort
1928 of notification in the browser.
1930 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1931 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1932 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1933 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1934 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1936 2011-09-27 Ben Konrath <ben@bagu.org>
1938 Put tableselector on the right, back to list link on right.
1940 The idea is that the table selector is acting like a label for the
1941 currently displayed table so it should be placed below the document title. This
1942 puts the table title in a similar position to where it is in Glom.
1944 * mockups/details-contacts.html:
1945 * mockups/details-projects.html:
1946 * mockups/listview-contacts.html:
1947 * mockups/listview-projects.html:
1948 * mockups/style.css:
1949 Update mockups to match how the interfaces currently look.
1950 * src/main/webapp/style.css: Swap positions of backlink with the table
1951 selector. Add some space on the left side of the table selector to
1952 line things up with the document title.
1954 2011-09-27 Ben Konrath <ben@bagu.org>
1956 Add field colouring to details view.
1958 This change re-works how field colouring works. The colour formatting
1959 information is now set to the client with the layout information instead of
1960 with the data. This eliminates the need to send the same colour strings for
1961 data in list view column when colour information is set.
1963 In order to set an alternate colour for negative numeric values, the
1964 number is now sent to client and formatted with the GWT NumberFormat class.
1966 This change also fixes:
1968 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1970 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1971 internationalization framework which is needed for client side numeric
1973 * src/main/java/org/glom/web/client/Utils.java: New file for some
1974 client static utility methods.
1975 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1976 the DataItem object to the Field class. Use a utility method to
1977 create the foreignKeyValue string.
1978 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1979 alignment and text colours in the constructor. Add setData(DataItem)
1980 method. Remove setText(String) method.
1981 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1982 colour information to GlomTextCell. Create and use GlomNumberCell for
1983 rendering numbers. Use utility method to get the string for the
1984 primary key of the key provider. Re-work how the horizontal alignment
1986 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1987 formatting to layout information. Methods for converting the libglom
1988 formatting information were moved from DBAccess.
1989 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1990 numeric formatting (it's now done on the client side). Don't set text
1991 colours in DataItem. Move libglom formatting conversion methods to
1993 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1994 getters/setters for text colour information.
1995 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1996 for transferring the libglom NumericFormat information to the client.
1997 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1998 and getters/setters for: GlomNumericFormat, background colour and
1999 foreground colour strings.
2001 2011-09-26 Ben Konrath <ben@bagu.org>
2003 Simplify code that iterates through the LayoutGroup.
2005 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2007 2011-09-26 Ben Konrath <ben@bagu.org>
2009 Accept Eclipse formatting for OnlineGlomServiceAsync.
2011 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2013 2011-09-26 Ben Konrath <ben@bagu.org>
2015 Don't use the ListDBAccess classes to get the primary key layout information.
2017 This was causing a bug where the wrong index for the hidden primary key
2018 was being sent to the client.
2020 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2021 primary key while creating the LayoutGroup DTO. Create a
2022 LayoutItemField DTO for hidden primary keys. Don't use the
2023 RelatedListDBAccess because it was only used for getting the primary
2025 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2026 access modifier from public to protected for getPrimaryKeyField() and
2027 getPrimaryKeyLayoutItemField().
2028 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2029 abstract method getExpectedResultSize() because RelatedListDBAccess
2030 doesn't have enough info to implement it.
2031 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2032 Remove @Override for getExpectedResultSize().
2033 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2034 Remove method getExpectedResultSize().
2036 2011-09-23 Ben Konrath <ben@bagu.org>
2038 Log which layout (list or details) the ignored item is from.
2040 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2042 2011-09-23 Ben Konrath <ben@bagu.org>
2044 Remove annotations that turn off code formatting in DataItem.
2046 * src/main/java/org/glom/web/shared/DataItem.java:
2048 2011-09-23 Ben Konrath <ben@bagu.org>
2050 Rename GlomField to DataItem and update associated methods.
2052 This is a rename-only refactor. No functionality has been added or
2055 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2058 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2059 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2060 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2061 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2062 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2064 * src/main/java/org/glom/web/server/database/DBAccess.java:
2065 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2066 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2067 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2068 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2069 * src/main/java/org/glom/web/shared/DataItem.java:
2070 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2071 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2073 2011-09-23 Ben Konrath <ben@bagu.org>
2075 Rename GlomDocument to DocumentInfo and update associated methods.
2077 This is a rename-only refactor. No functionality has been added or
2080 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2081 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2082 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2083 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2084 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2085 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2086 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2088 2011-09-20 Ben Konrath <ben@bagu.org>
2090 Require java-libglom 1.17.3.
2092 This picks up the fix for the seg fault problem with the Scenes table
2093 in the Openismus Film Manager example.
2097 2011-09-20 Ben Konrath <ben@bagu.org>
2099 Change the way sort clause is added for primary key when no sort clause is requested.
2101 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2102 before the sort clause is created. When a sort clause is not requested, the
2103 sort clause is created by finding the primary key in the LayoutFieldVector
2106 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2108 2011-09-20 Ben Konrath <ben@bagu.org>
2110 Log error message if no documents are found in the configured directory.
2112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2113 Extract the glom file extension string to a private static final class
2114 variable (mostly as syntactic sugar). Accept a minor formatting change.
2115 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2116 the example glom.document.directory configuration property to make it
2117 more clear that it can any directory, not just the home directory.
2119 2011-09-18 Ben Konrath <ben@bagu.org>
2121 Add related lists to details view.
2123 The related list table has support for paging and sorting just like the
2124 table in the list view.
2126 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2127 SQL queries for the related list tables.
2128 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2129 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2130 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2131 Rename getList methods to getListView and add comments. Remove
2132 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2133 it being unused. Add methods: getDetailsLayoutAndData(),
2134 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2135 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2136 Create the layout and set the data for the fields in one async call
2137 instead of two. Create related lists where appropriate.
2138 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2139 for method name changes in OnlineGlomService.
2140 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2141 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2142 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2144 * src/main/java/org/glom/web/client/ui/ListView.java:
2145 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2146 tableName from setCellTable(). Create a ListViewTable instead of
2148 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2149 represent a data field in the details view.
2150 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2151 from addDetailsCell() to Field class. Keep track of the Fields and
2152 Portals in the details view.
2153 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2154 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2155 and add a method to get it. Add method to set the contents of the
2157 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2158 New class for related list tables. This class has the data provider
2159 for the related list table.
2160 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2161 abstract class which is the base class for the ListViewTable and the
2163 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2164 New class for list view tables. This class has the data provider for
2165 the list view table.
2166 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2167 methods for related list tables. Add more information to the
2168 LayoutItemField and LayoutItemPortal DTOs.
2169 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2170 Remove debugging print statement.
2171 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2172 Remove debugging print statements. Add primary key field to SQL count
2174 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2175 Remove unnecessary LayoutFieldVector parameter from
2176 getResultSizeOfSQLQuery() method.
2177 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2178 New class for related list table database access.
2179 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2180 class that is a wrapper DTO for details view layout and data.
2181 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2182 new 'fromField' string to this DTO.
2183 * src/main/webapp/style.css: Remove bottom margin and override top
2186 2011-09-15 Ben Konrath <ben@bagu.org>
2188 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2190 This sets things up to make it easier to add the data retrieval for
2191 related lists (portals). No user noticeable changes were made with
2194 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2195 class has the code to retrieve the layouts and access the
2196 database using the new database helper classes.
2197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2198 Most of the functionality has been removed from this class. This
2199 class now represents the public interface for the client side
2200 code. It also deals with configuring the servlet and cleaning
2201 things up when the servlet is stopped.
2202 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2203 of static methods into this utility class.
2204 * src/main/java/org/glom/web/server/database/DBAccess.java:
2205 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2206 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2207 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2208 These classes have the database retrieval code. The class hierarchy
2209 has been setup to make it easy to reuse code for similar
2212 2011-09-06 Ben Konrath <ben@bagu.org>
2214 Create separate classes for list table code and the data provider.
2216 As part of this refactor, I also split up the code a bit to make it
2219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2220 table code to two new classes (below).
2221 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2222 with code from ListViewImpl.
2223 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2224 New file with code from ListViewImpl.
2226 2011-09-06 Ben Konrath <ben@bagu.org>
2228 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2230 This fixes the LayoutItemPortal DTO to match the libglom layout object
2233 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2235 2011-09-01 Ben Konrath <ben@bagu.org>
2237 Set title of Portals in the Details View.
2239 * pom.xml: Bump required version of java-libglom to 1.17.1.
2240 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2241 widget creation to its own class. Add comments to constructor.
2242 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2243 The code is mostly from the Group class with the title now set.
2244 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2245 title of Portal. Update some comments. Fix some code formatting.
2247 2011-09-01 Ben Konrath <ben@bagu.org>
2249 Remove TODO comment for the flow table column width.
2251 The flow table column width is working correctly and doesn't need to be
2252 changed. See this mailing list post for more info:
2254 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2256 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2258 2011-08-27 Ben Konrath <ben@bagu.org>
2260 Add document title (database name) to top of the browser page.
2262 I added the document title to the TableSelecitonView but that will
2263 change if / when we add a view that doesn't require table selection.
2265 * mockups/details-contacts.html:
2266 * mockups/details-projects.html:
2267 * mockups/listview-contacts.html:
2268 * mockups/listview-projects.html:
2269 * mockups/style.css: Add document title to mockups to keep things
2271 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2272 sizes to account for the document title.
2273 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2274 Set the document title when it has been retrieved from the server.
2275 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2276 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2277 and implement setDocumentTitle(String) method.
2278 * src/main/webapp/style.css: Add ID for document title style.
2280 2011-08-25 Ben Konrath <ben@bagu.org>
2282 Add NavigationType enum to LayoutItemPortal DTO.
2284 This is the start of adding support for Portals to the Details View.
2286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2287 LayoutItem_Portal.navigation_type enum from libglom to
2288 LayoutItemPortal.NavigationType enum.
2289 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2290 NavigationType enum, field for storing the NavigationType and getter
2293 2011-08-25 Ben Konrath <ben@bagu.org>
2295 Implement the flow table layout in the Details View.
2297 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2298 FlowTable to Group to account for the renamed class.
2299 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2300 File. This is a container widget that implements the Glom details view
2301 flow table behaviour.
2302 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2303 org/glom/web/client/ui/FlowTable.java.
2304 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2305 so that the size of the subgroups are a closer match to the size of
2306 the Glom subgroups. This makes the flowtable layout match the layout
2307 in Glom for the Music Collection example file.
2309 2011-08-16 Ben Konrath <ben@bagu.org>
2311 Create container element for LayoutItemPortal in Details View.
2313 This will help me develop the layout for the FlowTable.
2315 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2316 fieldPanel variable to detailsCell.
2318 2011-08-15 Ben Konrath <ben@bagu.org>
2320 Set the height of the data element in the Details View.
2322 I changed the InlineLabels (text in a span element) to Labels (text in
2323 a div element) so that I could set the height of the details-data
2324 elements instead of the details-cell parent elements. This allows the
2325 the details-data element to display the correct height if style is
2326 applied that shows the height.
2328 This change has the added benefit of allowing the order of the labels
2329 and data elements to be changed for right-to-left languages.
2331 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2332 InlineLabels to Labels.
2333 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2334 InlineLabels to Labels. Set the height of the data element.
2335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2336 multiline text height in the Formatting DTO.
2337 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2338 for multiline height along with getter and setter methods.
2339 * src/main/webapp/style.css: Adjust style to account for the change
2340 from span elements to div elements in the details cell.
2342 2011-08-15 Ben Konrath <ben@bagu.org>
2344 Make the List View appearance match the mockups.
2346 It doesn't match exactly but it's much better than it was.
2348 * mockups/listview-contacts.html: Remove unused css classes.
2349 * mockups/listview-projects.html: Remove unused css classes.
2350 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2351 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2352 for mainPanel instead of VerticalPanel (table). Set style name on
2353 CellTable. Set style name on Details column. Right-align Details
2355 * src/main/webapp/style.css: Adjust properties to match the mockups.
2357 2011-08-12 Ben Konrath <ben@bagu.org>
2359 Add better support for subgroups in the details view.
2361 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2362 changed FlowTable constructor.
2363 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2364 support for subgroups and subgroup-titles.
2365 * src/main/webapp/style.css: Add CSS class for subgroups and
2368 2011-08-12 Ben Konrath <ben@bagu.org>
2370 Return the top level LayoutGroup title.
2372 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2374 2011-08-11 Ben Konrath <ben@bagu.org>
2376 Make the TableSelector header match the mockup.
2378 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2379 the layout panel. Properly lineup the table selection header with
2380 the list and details view.
2381 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2382 margin around the details view.
2383 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2384 Rename listBox variable to tableSelector. Set id for the style sheet.
2385 Use a FlowPanel instead of a HorizontalPanel.
2386 * src/main/webapp/style.css: Add properties to make the TableSelector
2387 box match the mockups.
2389 2011-07-13 Ben Konrath <ben@bagu.org>
2391 Update install script for java-libglom version change.
2393 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2396 2011-07-13 Ben Konrath <ben@bagu.org>
2398 Add support sub-group in the details view.
2400 I also removed the code that special-cased the default details view
2403 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2405 I still have to make a proper flowtable.
2407 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2408 Don't special-case default details view layout.
2409 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2410 addLayoutField() as I'm going to use it.
2411 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2412 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2414 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2415 extracted from DetailsViewImpl.GroupPanel. Add support for
2417 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2418 column count when getting the details layout.
2420 2011-07-12 Ben Konrath <ben@bagu.org>
2422 Set browser title with database and table titles.
2424 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2425 Set the browser title when the table changes and when the activity
2427 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2428 title when retrieving document info (the GlomDocument object).
2429 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2430 with getter and setter methods. Remove unused convenience constructor.
2431 Use default code formatting.
2433 2011-07-12 Ben Konrath <ben@bagu.org>
2435 Ignore LayoutItemPortals in the details view.
2437 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2440 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2441 LayoutItemPortal layout objects.
2442 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2443 LayoutItemPortal objects when retrieving the details layout.
2444 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2445 file. This is an empty class and just used to get type information for
2448 2011-07-12 Ben Konrath <ben@bagu.org>
2450 Use java-libglom 1.17.0.
2454 2011-07-11 Ben Konrath <ben@bagu.org>
2456 Remove "Table:" label from table selector.
2458 This matches a recent change in the Glom UI.
2460 * mockups/details-contacts.html:
2461 * mockups/details-projects.html:
2462 * mockups/listview-contacts.html:
2463 * mockups/listview-projects.html: Remove the "Table:" label from the
2465 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2467 2011-07-11 Ben Konrath <ben@bagu.org>
2469 Add main groups to the details view.
2471 This makes things look a little nicer in the details view. The next step
2472 is to implement the flowtable.
2474 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2475 resources from the standard gwt css theme. Standard.css is now
2476 included in OnlineGlom.html so that the online glom css rules have
2477 precedence over the gwt theme.
2478 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2479 the whole LayoutGroup to the DetailsView instead of just the titles.
2480 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2481 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2482 details layout with a helper class (GroupPanel). I might extract this
2483 class when I make the full flowtable.
2484 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2485 string as default so I don't have to worry about NPEs when processing
2487 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2488 note beside OnlineGlom.gwt.xml above).
2489 * src/main/webapp/style.css: Add default font-size to body to override
2490 the font-size set by the standard theme. Don't use h2 tags for
2491 group-title. Create new details-cell class.
2493 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2495 ConfiguredDocument: Set the port number too.
2497 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2498 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2499 Glom document. Presumably this worked sometimes so far because there is a
2500 default port number.
2502 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2504 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2506 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2507 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2508 correct, though we should throw an exception too.
2510 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2512 Fix a addDocuemnt typo.
2514 * src/main/java/org/glom/web/shared/Documents.java
2515 (Documents.addDocuemnt): Rename to addDocument().
2516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2517 (OnlineGlomServiceImpl.getDocuments): Adapt.
2519 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2521 Slightly improved log output when connection fails.
2523 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2524 (ConfiguredDocument.setUsernameAndPassword):
2525 We don't know for sure if it' the username/password that's wrong, so
2526 rephrase the message.
2527 Also ouput the exception message, though it's generic in this case.
2529 2011-07-08 Ben Konrath <ben@bagu.org>
2533 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2534 added braces to a one line if statement because the Eclipse formatter
2535 was getting confused.
2537 2011-07-07 Ben Konrath <ben@bagu.org>
2539 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2541 These should really be two separate tasks but I counldn't get things to
2542 work with GWT 2.2.0 and Eclipse 3.7.
2546 * .settings/org.eclipse.jdt.core.prefs:
2547 * .settings/org.eclipse.jdt.ui.prefs:
2548 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2549 * .settings/org.eclipse.m2e.core.prefs:
2550 Add new config files. Update current files. Remove references to the
2551 webtools plugins as we're not using any of the webtools features.
2552 * .gitignore: Add logs directory which is created when running with
2554 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2555 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2556 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2558 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2560 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2562 onlineglom.properties: Add explanatory comments.
2564 * src/main/resources/onlineglom.properties: Also change the default user
2565 from ben to someuser, to avoid the risk of people thinking we just
2566 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2568 2011-06-28 Ben Konrath <ben@bagu.org>
2570 Use filename in Log for incorrect passwords.
2572 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2573 getFileName(String) method to get the filename from the URI.
2575 2011-06-28 Ben Konrath <ben@bagu.org>
2577 Add the table name to the URL token for the ListPlace.
2579 This makes things consistent between the DetailsPlace and the
2580 ListPlace. It also allows the the ListPlace to be bookmarked.
2582 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2583 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2585 Remove getDefaultListLayout(). The default layout is now returned
2586 by the getListLayout() method when the table name is an empty string.
2587 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2588 Add table name field. Change to a new ListPlace when the table
2589 has been changed. Use getListLayout() for getting the default
2591 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2592 Add table name field. Set the correct table name in the list box
2593 when loading from bookmark. This corrects a problem for the
2595 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2596 Move table name to super-class (HasSelectableTable). Move document
2597 and table URL keys to super-class in HasSelectableTable.
2598 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2599 Add table name field. Add Tokenizer class with URL key common to
2600 the subclasses (DetailsPlace and ListPlace).
2601 * src/main/java/org/glom/web/client/place/ListPlace.java:
2602 Add table name. Add code to parse the URL token.
2603 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2604 Update ListPlace construction with empty table name string.
2605 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2606 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2607 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2608 Update ListPlace construction with table name string.
2609 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2610 Change defaultTableName field to tableName to reflect how it's now
2611 used. Update the getter and setter methods.
2613 2011-06-28 Ben Konrath <ben@bagu.org>
2615 Enable the table selector in the DetailsView.
2617 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2618 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2620 Remove getDefaultDetailsLayout(). The default layout is now returned
2621 by the getDetailsLayout() method when the table name is an empty
2623 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2624 event handler for table change event. Change to using
2625 getDetailsLayout() for the default details layout.
2626 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2628 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2629 when navigating to the details place.
2631 2011-06-27 Ben Konrath <ben@bagu.org>
2633 Use filename based unique document ID in URL and for RPC.
2635 The document ID is the glom document name with spaces (' ') replaced
2636 with pluses ('+') and without the .glom extension.
2638 This change is mostly a string substitution of 'documentTitle' for
2639 'documentID'. The only code change is the addition of a Documents DTO to get the
2640 filename to document title mappings as indicated below.
2642 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2644 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2645 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2646 Use Documents DTO to create the document links in the document
2648 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2649 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2650 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2651 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2652 * src/main/java/org/glom/web/client/place/ListPlace.java:
2653 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2654 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2655 * src/main/java/org/glom/web/client/ui/ListView.java:
2656 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2657 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2658 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2659 * src/main/java/org/glom/web/server/Log.java:
2660 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2661 getDocumentTitles() to getDocuments() and return the Documents DTO.
2662 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2663 transferring the filename to document title mappings.
2665 2011-06-25 Ben Konrath <ben@bagu.org>
2667 Make the authentication popup work again.
2669 This bug was introduced when I extracted ConfiguredDocument to its own class.
2671 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2672 correct success / fail status in setUsernameAndPassword().
2674 2011-06-25 Ben Konrath <ben@bagu.org>
2676 Use filename as unique key for configuring database usernames and passwords.
2678 This replaces the use of the Glom document title which could change
2679 depending on the locale. Thanks to Murray Cumming for pointing out this
2682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2683 * src/main/resources/onlineglom.properties:
2685 2011-06-24 Ben Konrath <ben@bagu.org>
2687 Pass primary key value to DetailsView.
2689 This enables the DetailsView to load the correct data.
2691 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2692 primary key value field and set in constructor. Pass primary key
2693 value to getDetailsData().
2694 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2695 variables for document title and primary key value.
2696 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2697 key value to the DetailsPlace.
2699 2011-06-24 Ben Konrath <ben@bagu.org>
2701 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2703 This allows the primary key to be retrieved by the Details button. This
2704 functionality has not been implemented yet but it's in the works.
2706 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2707 the LayoutGroup result to ListView.setCellTable instead of all of its
2708 fields individually.
2709 * src/main/java/org/glom/web/client/ui/ListView.java:
2710 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2711 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2712 get the primary key for the table.
2713 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2714 index of the primary key in the LayoutGroup accounting for hidden
2715 primary keys. Rename getJavaNumberFormat() to
2716 convertToJavaNumberFormat() for consistency. Cleanup / add some
2718 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2719 field for primary key index and a field to indicate whether the
2720 primary key is hidden or not.
2722 2011-06-23 Ben Konrath <ben@bagu.org>
2724 Rename getTableData methods to getListData.
2726 This is a rename refactor for consistency with other methods.
2728 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2729 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2730 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2731 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2733 2011-06-23 Ben Konrath <ben@bagu.org>
2735 Extract the ConfiguredDocument innerclass into its own class.
2737 This makes the servlet code more object oriented.
2739 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2740 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2742 new ConfiguredDocument class.
2744 2011-06-21 Ben Konrath <ben@bagu.org>
2746 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2748 This makes things more inline with how libglom works and reduces code
2749 duplication. This refactor lays the groundwork for adding the primary key to
2750 the LayoutGroup object.
2752 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2753 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2755 Change method names to getListLayout and getDefaultListLayout for
2756 consistency. Use LayoutGroup as the DTO for the list layout instead of
2757 ColumnInfo and LayoutListTable.
2758 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2759 new method names along with the LayoutGroup object for transferring the
2761 * src/main/java/org/glom/web/client/ui/ListView.java:
2762 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2763 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2764 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2766 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2767 Replaced with LayoutGroup.
2768 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2769 expectedResultSize and defaultTableName fields which are needed for
2771 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2772 type field which is needed for the list layout but will also be
2773 useful for the details layout as things progress.
2774 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2775 Make class abstract. Remove the unnecessary
2776 getFormattingHorizontalAlignment method. Add setFormatting method.
2778 2011-06-16 Ben Konrath <ben@bagu.org>
2780 Add scripts for building and installing war.
2782 These will help when updating OnlineGlom but they're also good
2783 supplemental documentation of the build and deployment proceeding.
2785 * utils/build-onlineglom-war.sh: New file.
2786 * utils/install-onlineglom-war.sh: New file.
2788 2011-06-16 Ben Konrath <ben@bagu.org>
2790 Create wrapper class to create consistent log messages.
2792 I wrapped methods in the Log class of gwt-log to add the method names
2793 from the servlet and create consistent formatting of the document title
2794 and table names in the log messages.
2796 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2797 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2798 log methods to use methods from wrapped Log class.
2800 2011-06-16 Ben Konrath <ben@bagu.org>
2802 Remove superfluous conditional return.
2804 Thanks to Murray Cumming for pointing this out!
2806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2808 2011-06-15 Ben Konrath <ben@bagu.org>
2810 Return an ArrayList of LayoutGroups for the Details layout.
2812 This corrects a problem with the details layout as it can have more
2813 than one top level LayoutGroup.
2815 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2816 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2817 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2818 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2819 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2820 with ArrayList of LayoutGroups for the details view layout.
2821 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2822 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2823 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2824 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2825 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2826 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2828 2011-06-14 Ben Konrath <ben@bagu.org>
2830 Use cast_dynamic method to determine the libglom LayoutItem type.
2832 This is better than finding the LayoutItem type by using the string
2833 returned from the get_part_type_name() method.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2837 2011-06-14 Ben Konrath <ben@bagu.org>
2839 Add method names to log entries in the servlet.
2841 This helps when tracking down deployment problems.
2843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2845 2011-06-14 Ben Konrath <ben@bagu.org>
2847 Add data to the DetailsView using a hard-coded primary key value.
2849 The layout and functionality of the DetailsView is not complete. This
2850 is just a checkpoint so the patch doesn't get too big.
2852 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2853 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2854 Add getDetailsData() servlet method.
2855 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2856 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2857 LayoutFields are added to the DetailsView.
2858 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2859 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2860 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2861 take the string for the title instead of the object.
2862 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2863 Add implementation getDetailsData() along with some private helper
2865 * src/main/webapp/style.css: Add padding to details-data class. Add a
2866 details-label class with the same padding as the details-data class.
2868 2011-06-03 Ben Konrath <ben@bagu.org>
2870 Use presenter.goTo() to change to the DetailsPlace.
2872 This will make things easier when we need to open the DetailsView with
2873 data specific to the row that was clicked.
2875 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2877 2011-06-02 Ben Konrath <ben@bagu.org>
2879 Add CSS file from mockups.
2881 I'm adding this now because it's going to be useful to have when
2882 developing the DetailsView. The TableSelectionView and ListView aren't
2885 * src/main/webapp/OnlineGlom.html:
2886 * src/main/webapp/style.css:
2888 2011-06-02 Ben Konrath <ben@bagu.org>
2890 Use String.isEmpty() to check for empty string.
2892 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2894 2011-06-02 Ben Konrath <ben@bagu.org>
2896 Display main layout group titles in the DetailsView.
2898 This is the start of the DetailsActivity/DetailsView implementation.
2900 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2901 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2902 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2903 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2904 Get the layout information for the details view from the server and set
2905 the main layout group titles.
2906 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2907 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2908 Add addLayoutGroup() and addLayoutField() methods. This are just
2909 temporary methods for creating the the details view that will change
2911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2912 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2914 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2915 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2916 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2917 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2918 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2919 Data Transfer Objects that mimic the libglom object structure. These are
2920 used for transferring the details layout but could also be used for
2921 transferring the list layout.
2923 2011-05-27 Ben Konrath <ben@bagu.org>
2925 Reset the AuthenticationPopup when clearing the ListView.
2927 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2929 2011-05-27 Ben Konrath <ben@bagu.org>
2931 Fix problem with onlineglom.properties file loading.
2933 The old way worked in Eclipse but not on the server. Loading the
2934 onlineglom.properties file now works in Eclipse and on the server.
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2938 2011-05-24 Ben Konrath <ben@bagu.org>
2940 Update gwt-log from 3.1.0 to 3.1.2.
2942 Gwt-log 3.1.0 has been marked as depreciated.
2946 2011-05-24 Ben Konrath <ben@bagu.org>
2948 Add comment to ListActivity.goTo() method.
2950 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2952 2011-05-24 Ben Konrath <ben@bagu.org>
2954 Remove FIXME in convertGdkColorToHtmlColour()
2956 The Gdk::Color value returned by libglom is 16-bits per channel on both
2957 64 and 32-bit platforms.
2959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2961 2011-05-19 Ben Konrath <ben@bagu.org>
2963 Improve performance of initial ListView load.
2965 I removed a round trip to the server for getting the default table name
2966 and then requesting information about that table. This also removes a potential
2967 problem with the table change handler not being setup in time to receive the
2968 table change event from the ListActivity.
2970 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2971 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2972 getDefaultLayoutListTable() method. Improve comments.
2973 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2974 getDefaultLayoutListTable() method instead of firing a table change
2975 event to get the table to load.
2976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2977 implementation of getDefaultLayoutListTable() method.
2978 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2981 2011-05-19 Ben Konrath <ben@bagu.org>
2983 Override toDebugString() in TableChangeEvent.
2985 This is useful to have for debugging.
2987 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2989 2011-05-19 Ben Konrath <ben@bagu.org>
2991 Add a "Back to List" link when at the DetailsPlace.
2993 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2994 Populate the CellTable based on the selected table of the ListBox if
2995 it's set otherwise use the default table. This allows the "Back to
2997 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2998 Remove Place from constructors. Add a setPlace() method. Add
2999 goToPlace() method. Set class as presenter for TableSelectionView.
3000 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3001 Use the same TableSelectionActivity when switching between the List and
3003 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3004 Subclass the new HasSelectableTablePlace. This removes some duplicate
3006 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3007 New class to represent Places that display the TableSelectionView.
3008 * src/main/java/org/glom/web/client/place/ListPlace.java:
3009 Subclass the new HasSelectableTablePlace. This removes some duplicate
3011 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3012 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3013 Add Presenter interface. Add setBackLinkVisible() method. Add
3014 setBackLink() method.
3016 2011-05-18 Ben Konrath <ben@bagu.org>
3018 Enable the "Details" buttons.
3020 Right now only an empty details view is displayed.
3022 * src/main/java/org/glom/web/client/ClientFactory.java:
3023 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3024 Add DetailsView to ClientFactory.
3025 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3026 A basic activity for the details view.
3027 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3028 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3030 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3031 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3033 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3034 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3035 unnecessary super() in constructor.
3036 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3037 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3038 really shouldn't create a new TableSelectionActivity for both the ListPlace
3039 and the DetailsPlace so this should be considered a temporary solution.
3040 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3041 New file. Represents a URL for the details view.
3042 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3043 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3044 A basic details view interface and implementation.
3045 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3046 Enable the "Details" buttons.
3048 2011-05-12 Ben Konrath <ben@bagu.org>
3050 Use a LayoutPanel with multiple display areas for main layout.
3052 This is mostly a refactor in that there are no changes from the user
3053 point of view. These changes are required so that we can swap out the list view
3054 with the details view when the user clicks the "Details" button.
3056 * src/main/java/org/glom/web/client/ClientFactory.java:
3057 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3058 OnlineGlomView. Add TableSelectionView, ListView and
3059 AuthenticationPopup.
3060 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3061 for main layout. Add display regions for main activities. Add
3062 activity manager for for main activities.
3063 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3064 file from parts of the deleted OnlineGlomActivity.
3065 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3066 New file from parts of the deleted OnlineGlomActivity.
3067 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3068 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3069 New files for app wide table change event.
3070 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3071 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3072 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3073 Activity mappers for the main activities replace the deleted app-wide
3075 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3076 Fix a spelling error in he comment.
3077 * src/main/java/org/glom/web/client/ui/ListView.java:
3078 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3079 Renamed from LayoutListView and modified for MVP. This still not a
3080 proper dumb view as prescribed by the MVP pattern but it works for now.
3081 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3082 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3083 New widget stripped out of the deleted OnlineGlomView.
3084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3085 Remove hack that is fixed by this patch.
3087 2011-05-06 Ben Konrath <ben@bagu.org>
3089 Rename OnlineGlomPlace to ListPlace.
3091 The only change besides the rename is that url will now display #list
3092 instead of #Document.
3094 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3095 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3096 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3097 * src/main/java/org/glom/web/client/place/ListPlace.java:
3098 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3100 2011-05-06 Ben Konrath <ben@bagu.org>
3102 Use Presenter for app navigation.
3104 This is the proper way to deal with Place (URL) changes with the MVP
3107 * src/main/java/org/glom/web/client/ClientFactory.java:
3108 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3109 PlaceHistoryMapper and PlaceHistoryHandler.
3110 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3111 PlaceHistoryMapper and PlaceHistoryHandler.
3112 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3113 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3114 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3115 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3116 Add Presenter interface and setPresenter methods. Rename addHyperLink
3117 to addDocumentLink taking only the document title as a parameter.
3119 2011-04-14 Ben Konrath <ben@bagu.org>
3121 Prompt for db username/password if they haven't been set.
3123 This is implemented with a popup widget that is contained within the
3124 OnlineGlomView and managed by the OnlineGlomActivity.
3126 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3127 methods for checking and setting the database username and password.
3128 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3129 new methods for checking and setting the database username and
3131 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3132 Display authentication popup if the JDBC connection to the database
3133 has not been authenticated.
3134 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3136 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3137 for dealing with the authentication popup.
3138 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3139 Implement the methods for dealing with the authentication popup.
3140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3141 try to executed queries if the database connection hasn't been
3142 authenticated. Implement methods for checking and setting the
3143 database username and password.
3145 2011-04-12 Ben Konrath <ben@bagu.org>
3147 Make log messages a little clearer.
3149 Add a dash betweeen the document title and the table name.
3151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3153 2011-04-12 Ben Konrath <ben@bagu.org>
3155 Protect against NPEs when cleaning up database resources.
3157 While this isn't strictly necessary because the exception is caught,
3158 not protecting against the NPEs makes it harder to find the real error
3161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3163 2011-04-12 Ben Konrath <ben@bagu.org>
3165 Move configuration of the servlet to the constructor.
3167 The servlet will be initialized even if the database authentication
3168 information is not set or correct. I still need to add the UI for prompting
3169 the user for the authentication information when it's required.
3171 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3172 javadocs for getDocumentTitles() method.
3173 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3174 Set error message when RPC fails.
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3176 glom files directory from the configuration file. Try to set the
3177 database authentication information for the specific document if it's
3178 set and works otherwise try to use the global authentication
3179 information set for the directory.
3180 * src/main/resources/onlineglom.properties: Moved from
3181 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3182 Added detailed comments for the new keys.
3184 2011-04-11 Ben Konrath <ben@bagu.org>
3186 Remove unnecessary @Override in DocumentSelectionViewImpl.
3188 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3190 2011-04-11 Ben Konrath <ben@bagu.org>
3192 Remove center alignment in DocumentSelectionView.
3194 The title element is still centred but the document titles and bottom
3195 sentence are both left-aligned.
3197 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3199 2011-04-11 Ben Konrath <ben@bagu.org>
3201 Change 'Demo' naming convention to 'Document'.
3203 This is just a rename refactor with no functional changes to the code.
3205 * src/main/java/org/glom/web/client/ClientFactory.java:
3206 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3207 * src/main/java/org/glom/web/client/OnlineGlom.java:
3208 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3209 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3210 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3211 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3212 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3213 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3214 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3215 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3216 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3219 2011-04-08 Ben Konrath <ben@bagu.org>
3221 Remove FIXME from safeLongToInt() method.
3223 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3228 2011-04-08 Ben Konrath <ben@bagu.org>
3230 Display an error if no glom documents are found in the specified directory.
3232 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
projects / online-glom:gwt-glom.git / blob