1 2012-11-28 Murray Cumming <murrayc@murrayc.com>
3 SelfHostExampleTest: Move some checks into a utility function.
5 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
6 Move the data checks into a new file:
7 * src/test/java/org/glom/web/server/SelfHostTestUtils.java:
8 SelfHostTestUtils.java: so we can use it in some other
9 tests, with different documents.
11 2012-11-28 Murray Cumming <murrayc@murrayc.com>
13 SelfHosting test: Also try using a relationship.
15 * src/main/java/org/glom/web/server/database/DBAccess.java:
16 convertResultSetToDTO(): Move some code into a public
18 * src/main/java/org/glom/web/server/SqlUtils.java:
19 fillDataItemFromResultSet(): This takes a DataItem and
20 sets it from a value from a datbase recordset.
21 * src/main/java/org/glom/web/server/libglom/Document.java:
22 Make getDocument() public, so we can use it in a test.
23 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
24 Add testExampleMusiccollectionDataRelated() and call it from
25 testExampleMusiccollectionData(), to do a basic test of using
28 2012-11-22 Murray Cumming <murrayc@murrayc.com>
30 Build: Specify the source encoding.
32 * pom.xml: Set project.build.sourceEncoding
33 This should fix this build problem on some systems:
34 [ERROR] /var/lib/jenkins/workspace/OnlineGlom/src/test/java/org/glom/web/server/libglom/DocumentTest.java:[139,72] error: unmappable character for encoding ASCII
38 2012-11-20 Murray Cumming <murrayc@murrayc.com>
40 Update the jasperreports version.
42 * pom.xml: This was shown by
43 mvn versions:display-dependency-updates
45 2012-11-20 Murray Cumming <murrayc@murrayc.com>
47 Eclipse: Reorder the Java Build Path to fix the build in Eclipse.
49 * .classpath: This prevents an error saying that getTextContent()
51 See http://mergetag.com/the-method-gettextcontent-is-undefined-for-the-type-node/
53 2012-11-20 Murray Cumming <murrayc@murrayc.com>
55 Explicitly declare some dependencies (and scopes) that we use.
57 * pom.xml: The dependency report showed what we use.
59 2012-11-20 Murray Cumming <murrayc@murrayc.com>
61 Update the gwt-test-utils version.
63 * pom.xml: gwt-test-utils 0.43 uses GWT 2.5.0, not GWT 2.4.0.
64 Using both in the same project was causing gwt-log to fail in GWTBrige,
66 testOutOfBounds(org.glom.web.server.libglom.DocumentLayoutPathTest):
67 (class: com/google/gwt/core/client/GWT, method: setBridge signature: (Lcom/google/gwt/core/client/GWTBridge;)V) Incompatible argument to function
69 2012-11-19 Murray Cumming <murrayc@murrayc.com>
71 DocumentTest: testLocales(): Update for the latest example version.
73 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
74 The .glom file, updated in the previous commit, now has more translations.
76 2012-11-19 Murray Cumming <murrayc@murrayc.com>
78 Update the .glom files used for tests.
80 * src/test/resources/org/glom/web/server/example_film_manager.glom:
81 * src/test/resources/org/glom/web/server/example_music_collection.glom:
82 * src/test/resources/org/glom/web/server/libglom/example_film_manager.glom:
83 * src/test/resources/org/glom/web/server/libglom/example_music_collection.glom:
84 Copy them from git master of Glom.
86 2012-11-18 Murray Cumming <murrayc@murrayc.com>
88 Update versions of dependencies.
90 * pom.xml: Increase some version numbers based on the output of
91 , using mvn versions:display-dependency-updates.
92 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
93 Use the annotation instead of getModuleName().
94 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
95 Do not use deprecated assert() classes/methods.
97 2012-11-18 Murray Cumming <murrayc@murrayc.com>
99 Document: Correct an import to use the correct Log API.
101 * src/main/java/org/glom/web/server/libglom/Document.java:
102 Use our Utils.Log API rather than the jfree one that Eclipse
103 must have suggested at some time.
105 2012-11-15 Murray Cumming <murrayc@murrayc.com>
107 Details: Get static image data from our images services.
109 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
110 Add constructors for LayoutItemText and LayoutItemImage and
111 deal with their common type instead of just LayoutItemField.
113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
115 * src/main/java/org/glom/web/client/ui/details/Group.java:
116 createChildWidget(): Use the other DetailsCell constructors for
117 these layout items, and do not add them to the list of
118 cells with data from the database.
119 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
120 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
121 Remove the image data when cloning the layout and storing it in the
122 cache. Clients will instead get it via the URL, from
124 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
125 doGet(): Depending on the URI parameters, optionally get
126 image data from a layout_item_image in the document,
128 * src/main/java/org/glom/web/server/database/DBAccess.java:
129 convertResultSetToDTO(): Move some URIBuilder code to:
130 * src/main/java/org/glom/web/server/Utils.java:
131 Add buildImageDataUrl() taking the primary key, etc, to
132 get data from the database.
134 2012-11-15 Murray Cumming <murrayc@murrayc.com>
136 Document: Static image items: Store an image URL, using the layout path.
138 * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
139 * src/main/java/org/glom/web/server/libglom/Document.java:
140 Add a constructor that takes the documentID, for use in the
142 loadLayoutNode(): Pass a Path object to the helper methods, so we
143 can use it to create a URL for LayoutItemImage items.
144 This seems as good a way as any to specify a layout item in the document.
145 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
146 Pass the documentID to the constructor, for use in the LayoutItemImage
149 2012-11-15 Murray Cumming <murrayc@murrayc.com>
151 Document: Add getLayoutItemByPath().
153 * src/main/java/org/glom/web/server/Utils.java:
154 Add buildLayoutPath() and parseLayoutPath().
155 * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these
156 utility methods work.
157 * src/main/java/org/glom/web/server/libglom/Document.java:
158 Add Add getLayoutItemByPath().
159 * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test
162 This will be useful in subsequent commits.
164 2012-11-15 Murray Cumming <murrayc@murrayc.com>
166 Document: Use a better base64 decoder to read static image data.
168 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
169 getNodeTextChildAsValue(): Use the apache commons base64 decoder
170 instead of the gwt one, because it correctly decodes the strings
171 from g_base64_encode(). It is probably more correct.
172 The newlines might be confusing the gwt decoder.
174 2012-11-14 Murray Cumming <murrayc@murrayc.com>
176 Document: Do not use == to compare strings. Use equals().
178 * src/main/java/org/glom/web/server/libglom/Document.java:
179 == only checks that they are the same object, so it can
182 2012-11-14 Murray Cumming <murrayc@murrayc.com>
184 Document: Add and use public constants for layout names.
186 * src/main/java/org/glom/web/server/libglom/Document.java:
187 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
188 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
189 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
190 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
191 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
192 them here instead of hard-coded the strings repeatedly.
194 2012-11-13 Murray Cumming <murrayc@murrayc.com>
196 Document: Load static text and image items too.
198 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
199 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
200 New LayoutItem classes to represent these layout items.
201 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
202 main text of a LayoutItemText.
203 * src/main/java/org/glom/web/server/libglom/Document.java:
204 load_after_layout_group(): Handle the node types and instantiate the
206 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
207 Add testLayoutItemText() to check that the text is loaded properly.
209 2012-11-13 Murray Cumming <murrayc@murrayc.com>
211 Do not use client.GWT for shared code.
213 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
214 Import shared.GWT instead of client.GWT, which seems to be appropriate.
216 2012-11-12 Murray Cumming <murrayc@murrayc.com>
218 Use image data when recreating databases for testing.
220 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
221 for use locally (not acrosss the network) when recreating databases
223 getValue(): Use it here instead of getImageDataUrl(), noting that
224 this method is only for use when recreating databases.
225 * src/main/java/org/glom/web/server/libglom/Document.java:
226 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
228 2012-11-09 Murray Cumming <murrayc@murrayc.com>
230 OnlineGlomImages: Detect the mime-type (content type).
232 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
233 doGet(): Instead of hard-coding image/png.
235 2012-11-09 Murray Cumming <murrayc@murrayc.com>
237 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
240 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
241 Java Compiler and Java Build path settings in the UI.
243 2012-11-09 Murray Cumming <murrayc@murrayc.com>
245 Use the latest (now stable) version of GWT.
247 * pom.xml: And the latest version of the gwt-maven-plugin.
249 2012-11-08 Murray Cumming <murrayc@murrayc.com>
251 Added an Indonesian translation.
253 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
254 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
255 This is from the new translation in Glom.
257 2012-07-23 Murray Cumming <murrayc@murrayc.com>
259 Details: Show images.
261 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
263 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
264 so it can be used in:
265 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
266 for serving image data.
267 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
269 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
270 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
271 setData(): For image field types, add a GWT Image widget,
272 with the URL that was set in the DataItem.
274 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
275 * src/main/java/org/glom/web/server/database/DBAccess.java:
276 convertResultSetToDTO(): Set the URL for image data, so the client browser
277 can retrieve the image from our new servlet. This uses UriBuilder.
278 Move getPrimaryKeyField to:
279 * src/main/java/org/glom/web/server/libglom/Document.java:
280 Added getTablePrimaryKeyField().
282 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
283 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
284 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
287 2012-07-22 Murray Cumming <murrayc@murrayc.com>
291 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
292 * src/main/java/org/glom/web/client/OnlineGlomService.java:
293 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
294 to gwtGlom, which is more appropriate.
295 This servlet name does not seem to be visible to the client side anyway.
297 2012-07-22 Murray Cumming <murrayc@murrayc.com>
299 Tests: Make the imports of assert*() consistent.
301 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
302 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
303 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
304 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
305 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
306 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
307 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
308 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
309 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
310 * src/test/java/org/glom/web/shared/DataItemTest.java:
312 import static org.junit.Assert.*;
313 which seems fairly common.
317 2012-07-21 Murray Cumming <murrayc@murrayc.com>
319 tests: Move a test that needs a database connection.
321 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
322 Move testGetListViewLayoutGroup() to
323 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
324 because it needs a database connection.
326 2012-07-21 Murray Cumming <murrayc@murrayc.com>
328 tests: Use @BeforeClass on tearDown().
330 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
331 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
332 This avoids leaking a postgres process in SelfHostExampleTest.
334 2012-07-21 Murray Cumming <murrayc@murrayc.com>
336 tests: Test translations more.
338 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
339 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
340 Test titles in the non-default locale.
342 2012-07-21 Murray Cumming <murrayc@murrayc.com>
344 tests: Add SelfHostConfiguredDocumentTest
346 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
347 username and password, for use by ConfiguredDocument.
348 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
349 This tests some of the ConfiguredDocument API that requires a database connection.
351 2012-07-21 Murray Cumming <murrayc@murrayc.com>
353 Document: Load title translations and test them.
355 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
356 of titles. I am surprised that we do not do this yet.
357 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
358 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
359 Test translations more.
361 2012-07-20 Murray Cumming <murrayc@murrayc.com>
365 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
366 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
367 Set the timeout here too.
369 2012-07-20 Murray Cumming <murrayc@murrayc.com>
371 tests: ConfiguredDocumentTest: Make this pass.
373 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
374 Disable tests that need a database connection.
376 2012-07-20 Murray Cumming <murrayc@murrayc.com>
378 Use Java 1.7 instead of Java 1.6.
380 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
381 to do this twice, at least for Eclipse.
382 This seems OK because it is the current version.
384 2012-07-20 Murray Cumming <murrayc@murrayc.com>
388 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
389 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
390 Avoid using a null Connection.
392 2012-07-20 Murray Cumming <murrayc@murrayc.com>
394 tests: Add a ConfiguredDocument test.
396 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
399 2012-07-20 Murray Cumming <murrayc@murrayc.com>
401 LayoutItemFIeld: getName(): Use the Field if it is set.
403 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
404 getName(): If the full field details have been set, return its name, so that
405 callers do not need to set the name separately.
406 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
407 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
408 so we can count the rows.
410 2012-07-20 Murray Cumming <murrayc@murrayc.com>
412 tests: SelfHoster: Test SqlUtils too.
414 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
415 Retrieve some data and check it too, as in the regular Glom
416 test_selfhosting_new_from_example.cc test.
417 * src/test/java/org/glom/web/server/SelfHoster.java:
418 createConnection(): Make this public.
420 2012-07-20 Murray Cumming <murrayc@murrayc.com>
422 tests: SelfHoster: createConnection(): Do not warn about expected failures.
424 Let the caller say if the connection is expected to fail, to avoid
425 irrelevant error output.
427 2012-07-20 Murray Cumming <murrayc@murrayc.com>
429 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
431 * src/test/java/org/glom/web/server/SelfHoster.java:
432 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
433 due to the inevitable need to retry the connection while the database server
436 2012-07-20 Murray Cumming <murrayc@murray.com>
438 tests: SelfHoster: createConnection(): Set a timeout.
440 * src/test/java/org/glom/web/server/SelfHoster.java:
441 createConnection(): Use setLoginTimeout() because it otherwise seems to take
442 ages to actually return when it fails.
444 2012-07-20 Murray Cumming <murrayc@murrayc.com>
446 tests: SelfHoster: selfHost(): Close the test connection.
448 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
449 When we check that the connection works, close the connection. This seems
450 to not be closed automatically otherwise.
452 2012-07-20 Murray Cumming <murrayc@murrayc.com>
454 Use slf4j-simple to see JDBC errors.
456 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
458 2012-07-19 Murray Cumming <murrayc@murrayc.com>
460 SelfHoster.discoverFirstFreePort(): Close the socket.
462 * src/test/java/org/glom/web/server/SelfHoster.java:
463 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
465 2012-07-19 Murray Cumming <murrayc@murrayc.com>
467 Avoid another code warning in Eclipse Juno.
469 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
470 Do instanceof checks on the FileUtils.listFiles() result and its
473 2012-07-13 Murray Cumming <murrayc@murrayc.com>
475 Avoid some code warnings in Eclipse Juno
477 * src/main/java/org/glom/web/server/libglom/Document.java:
478 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
479 * src/test/java/org/glom/web/server/SelfHoster.java
480 createTextFile(): Make sure that the FileOutputStream is closed.
482 2012-06-22 Murray Cumming <murrayc@murrayc.com>
484 Added OnlineGlomPropertiesTest.
486 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
487 Make sure we never return a null string.
488 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
489 Added tests of the OnlineGlomProperties API, using our sample file.
491 2012-06-20 Murray Cumming <murrayc@murrayc.com>
493 Make OnlineGlomProperties be a normal class.
495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
496 Move OnlineGlomProperties into its own file to be a regular class:
497 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
498 This makes testing simpler.
500 2012-06-15 Murray Cumming <murrayc@murrayc.com>
502 OnlineGlomServiceImpl.init(): Move some code into a new method.
504 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
505 Create addDocument().
507 2012-06-15 Murray Cumming <murrayc@murrayc.com>
509 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
511 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
512 OnlineGlomProperties.getKey(): Make this more robust by moving the
513 check for *.*.filename to here.
515 2012-06-15 Murray Cumming <murrayc@murrayc.com>
517 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
519 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
520 init(): Move knowledge of the config file format into the
521 OnlineGlomProperties inner class.
523 2012-06-15 Murray Cumming <murrayc@murrayc.com>
525 SelfHostExampleTest: Make sure we cleanup on failure.
527 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
528 the use of cleanup() to a tearDown() JUnit method.
532 2012-06-12 Murray Cumming <murrayc@murrayc.com>
534 ConfiguredDocument: Add a primary key to portals at least once.
536 * src/main/java/org/glom/web/server/ConfiguredDocument.java
537 updatePortalsExtras): Fix a typo so that we add the primary key
538 column at least once.
539 This is a fix for the previous commit:
540 ConfiguredDocument: Do not add a primary key to portals each time.
542 2012-06-08 Murray Cumming <murrayc@murrayc.com>
544 SelfHoster: Avoid some compiler warnings.
546 * src/test/java/org/glom/web/server/SelfHoster.java
547 executeCommandLineAndWait():
548 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
549 the now-unused streams for stdout and stderr from the command Processes.
550 These are not used because readln() hangs while waiting for a new line,
551 where there may be no next line. The commented out code is still there
552 to help us figure out how to do this properly.
554 2012-06-08 Murray Cumming <murrayc@murrayc.com>
556 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
558 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
559 Make this actually test the cloning again, though it is not very useful
560 now that we do not use the part that had a problem with cloning before.
562 2012-06-08 Murray Cumming <murrayc@murrayc.com>
564 SelfHoster: Keep trying pg_ctl after starting postgres.
566 * src/test/java/org/glom/web/server/SelfHoster.java
567 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
568 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
569 regular Glom. This seems mad but it seems to work because the first
570 command would fail if pg_ctl would eventually fail.
572 2012-06-08 Murray Cumming <murrayc@murrayc.com>
574 SelfHoster: Wait until the server is really ready.
576 * src/test/java/org/glom/web/server/SelfHoster.java
577 selfHost(): Attempt the connection after starting the server, retrying
578 a few times if necessary, so that the server is really ready already when
579 we return from this method.
580 The regular Glom code does this too because pg_ctl reports success too soon.
582 2012-06-08 Murray Cumming <murrayc@murrayc.com>
584 ConfiguredDocument: Do not add a primary key to portals each time.
586 * src/main/java/org/glom/web/server/ConfiguredDocument.java
587 updatePortalsExtras(): Only add an extra primary key field if there is
588 none, to avoid adding one each time we retrieve the details layout from the
590 This should fix bug #676986 (Ben Konrath)
592 2012-05-25 Murray Cumming <murrayc@murrayc.com>
594 Document.load(): Support version 7 documents.
596 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
597 database_title attribute if the title attribute is not there.
600 2012-05-24 Ben Konrath <ben@bagu.org>
602 Add configuration for auto-generating mvn:i18n from with Eclipse.
604 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
606 2012-05-24 Murray Cumming <murrayc@murrayc.com>
608 Update translations, adding French.
610 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
611 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
612 Add a French translation, using the translation from Glom.
614 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
615 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
616 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
617 Update these based on the translations from Glom.
619 2012-05-24 Murray Cumming <murrayc@murrayc.com>
621 SelfHoster: Add some debug println messages to help when things fail.
623 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
624 System.out.println() lines.
626 2012-05-23 Murray Cumming <murrayc@murrayc.com>
628 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
630 * src/test/java/org/glom/web/server/SelfHoster.java:
631 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
632 instance) instead of just /usr/bin (as on Fedora). Check the result when
635 2012-05-23 Murray Cumming <murrayc@murrayc.com>
637 Remove LayoutItemPortal.get/setNavigationTable().
639 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
640 Remove get/setNavigationTable(), which is only a cache, because it is not
641 used, and does not need to be used, because that decision should be made on
643 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
644 updatePortalsExtras():
645 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
646 getNavigationRecord():
647 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
650 2012-05-21 Murray Cumming <murrayc@murrayc.com>
652 Initial self-hosting for tests.
654 * pom.xml: Change the scope for log4j, to hopefully make it
655 available to the test code which uses it indirectly via jOOQ.
656 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
657 self-hosting, though we only use it for testing.
659 * src/main/java/org/glom/web/server/libglom/Document.java:
660 example rows: Use a map instead of a list for each row of values,
661 so we know what field they are for, instead of relying on the sequence
662 being correct. This is not very efficient, but it does not really need
664 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
665 testReadTableExampleRows(): Adapted.
667 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
668 that returns an Object, for generic use. Note that Object seems to be
669 the implicit base even of double.
670 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
671 for use in CREATE TABLE SQL queries.
672 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
673 to do self-hosting of PostgreSQL databases via its command-line
674 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
675 backends/postgres_self.cc. This is incomplete - it needs more
676 warnings about failures and it needs to clean up properly when things
678 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
679 test of this new class.
681 2012-05-21 Murray Cumming <murrayc@murrayc.com>
683 Document: loading example data: Handle exceptions.
685 * src/main/java/org/glom/web/server/libglom/Document.java:
686 DateFormat.parse() and Double.valueOf() can throw exceptions, though
687 Eclipse did not warn about that.
689 2012-05-20 Murray Cumming <murrayc@murrayc.com>
691 Document: load(), save(): Handle the example rows.
693 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
695 * src/main/java/org/glom/web/server/libglom/Document.java:
696 load(), save(): Load and save the example rows, though the date, time
697 and image types are not handled properly yet.
698 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
699 Add testReadTableExampleRows() just to check that something is read.
701 2012-05-20 Murray Cumming <murrayc@murrayc.com>
703 Document: Add save().
705 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
706 Added getTranslationsMap() for use while saving.
707 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
708 Adedd getUseDefaultFormatting() for use while saving.
709 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
710 and several private methods that it uses.
712 This will be useful while testing via self-hosting.
713 It is not complete, but should be complete enough for testing.
715 2012-05-17 Murray Cumming <murrayc@murrayc.com>
717 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
719 * src/main/java/org/glom/web/client/OnlineGlomService.java
720 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
721 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
722 Remove getSortedListViewData() and getSortedRelatedListData(), adding
723 the sort column index and ascending bool to the regular method.
724 Instead, a sort column index of -1 now means no sort.
725 This is less explicit, but it's fairly simple, reduces the amount of
726 code, and makes the OnlineGlomService API slightly smaller.
727 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
728 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
730 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
731 getListViewData(), getRelatedListData():
732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
733 getListViewData(), getRelatedListData():
734 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
736 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
738 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
743 2012-05-16 Murray Cumming <murrayc@murrayc.com>
745 Use translations for top-level groups too.
747 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
748 updateTitlesForLocale(): Use the translation for the group
749 as well as for child items.
753 Just recompiled to fix a problem in the released .tar.gz file.
757 2012-05-15 Murray Cumming <murrayc@murrayc.com>
759 Corrections to navigation to related records.
761 * src/main/java/org/glom/web/client/OnlineGlomService.java:
762 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
763 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
764 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
765 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
766 relationship name, because the relationship name is not necessarily unique
768 TOOD: This is inefficient, because it passes the whole list of
769 child field items back to the server, but it is more correct, and happens
770 to fix a bug with the primary key being lost after a few navigations.
771 There is probably a chance to make this more efficient anyway in some
774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
775 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
776 * src/main/java/org/glom/web/server/ConfiguredDocument.java
777 * src/main/java/org/glom/web/server/database/DBAccess.java
778 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
779 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
782 2012-05-15 Murray Cumming <murrayc@murrayc.com>
784 Fix the use of translations.
786 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
787 Add updateTitlesForLocale().
788 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
789 Call it to discard unwanted translations and to make getTitle() return
790 the wanted translation wihout the need for the client code to specify a locale.
791 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
792 getTitle(): Fallback to the original title, as libglom does.
794 2012-05-15 Murray Cumming <murrayc@murrayc.com>
796 Document: Correctly report the number of available translation locales.
798 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
799 the available locale IDs list.
800 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
801 testLocales: Test this.
803 2012-05-15 Murray Cumming <murrayc@murrayc.com>
805 SqlUtils: Use camelCase.
807 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
808 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
809 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
810 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
811 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
812 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
814 2012-05-15 Murray Cumming <murrayc@murrayc.com>
816 Use jOOQ's tableByName() and fieldByName.
818 * pom.xml: Use jOOQ 2.3.1 to get the new API.
819 * src/main/java/org/glom/web/server/SqlUtils.java:
820 build_sql_select_step_with_where_clause(), .createField(),
821 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
822 so we can get correct quoting and escaping. Thanks to Lukas Eder for
823 adding this, and other things, to jOOQ.
825 2012-05-15 Murray Cumming <murrayc@murrayc.com>
827 SqlUtils: Remove the Connection parameters.
829 * src/main/java/org/glom/web/server/SqlUtils.java:
830 build_sql_select_with_key(), build_sql_select_with_where_clause(),
831 createSelect(), build_sql_select_step_with_where_clause(),
832 build_sql_count_select_with_where_clause(),
833 build_sql_select_count_rows(): Remove the Connection parameter because
834 jOOQ does not actually need a connectionwhen it is just used to build
836 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
838 * src/main/java/org/glom/web/server/ReportGenerator.java:
840 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
842 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
843 Constructor, getListData(), getResultSizeOfSQLQuery():
844 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
845 getSelectQuery(), getCountQuery():
846 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
847 getSelectQuery(), getCountQuery():
848 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
849 getNavigationRecord(): Adapted.
851 2012-05-14 Murray Cumming <murrayc@murrayc.com>
855 * src/main/java/org/glom/web/server/SqlUtils.java:
856 get_find_where_clause_quick(): Use a comparison of
857 lowercase values, instead of a simple equals. Regular Glom
858 uses the PostgreSQL ILIKE operator but jOOQ does not
859 support that just yet, though it will soon.
861 2012-05-14 Murray Cumming <murrayc@murrayc.com>
863 TableToViewDetails: Use a real serialization ID.
865 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
866 Though this does not fix the serialization problem.
868 2012-05-12 Murray Cumming <murrayc@murrayc.com>
870 Added LayoutItemPortalDeepCloneTest.
872 2012-05-11 Murray Cumming <murrayc@murrayc.com>
874 Make navigation work again.
876 * src/main/java/org/glom/web/server/libglom/Document.java:
877 Add getLayoutItemFieldShouldHaveNavigation().
878 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
879 Replace get/setAddNavigation() with the partly-existing
880 get/setNavigationTableName(), with an empty string being no navigation,
881 because this is simpler. Use the new
882 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
884 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
885 Add updateFieldsExtras() and call setNavigationTableName in it.
886 getDetailsLayoutGroup(),
887 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
888 createLayout(): Adapted.
889 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
890 Constructor: Adapted.
892 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
893 Replace get/setAddNavigation() with get/setNavigation(), returning a
894 TableToViewDetails class with both the table name and UsesRelationship,
895 because both are need. The previous code used java-libglom's output
896 variable (strangely, via sharedptr) to return both, but we cannot really
898 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
899 getNavigationRecord(): Adapt. However, we cannot actually use the cache
900 here because it somehow gets set to null during deepCopy(). I must test this.
901 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
902 testGetSuitableTableToViewDetails(): Adapted.
904 TODO: Find out why deepClone() is not quite working.
906 2012-05-11 Murray Cumming <murrayc@murrayc.com>
908 DBAccess: Simplify the retrievel of full field details.
910 * src/main/java/org/glom/web/server/database/DBAccess.java
911 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
912 because the Document loading should have done this.
914 2012-05-11 Murray Cumming <murrayc@murrayc.com>
916 Document: Correct loading of doubly-related layout fields.
918 * src/main/java/org/glom/web/server/libglom/Document.java:
919 loadUsesRelationship(): Actually set the related relationship, instead
920 of only setting it if it's not found.
922 2012-05-09 Murray Cumming <murrayc@murrayc.com>
924 Replace all appearances of Colour with color.
926 Because US English is dominant.
928 2012-05-09 Murray Cumming <murrayc@murrayc.com>
930 Use colors in HTML format, solving a warning about an unused function.
932 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
933 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
934 Add *asHTMLColor() versions of methods.
935 TODO: However, we should create and cache the results on the server.
936 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
937 * src/main/java/org/glom/web/client/ui/list/ListTable.java
938 * src/main/java/org/glom/web/server/ConfiguredDocument.java
939 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
940 Use the asHTMLcolor() versions.
942 2012-05-09 Murray Cumming <murrayc@murrayc.com>
944 ListViewTable: Constructor: Take the table name as a parameter.
946 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
947 Constructor: Take the tableName, and set the member variable, because
949 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
950 setCellTable(): Pass the table name.
951 This makes navigation to non-default tables work again. I don't know
952 why it worked before in the master branch.
954 2012-05-07 Murray Cumming <murrayc@murrayc.com>
956 ConfiguredDocument: Restore correct addition of hidden primary key items.
958 * src/main/java/org/glom/web/client/ui/list/ListTable.java
959 (ListTable.createCellTable): Uncomment out the check for the hidden
961 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
962 add primary key items for top-level lists and portals, as before,
963 instead of adding them to each group.
964 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
965 Actually implement the extra methods such as setHiddenPrimaryKey() and
966 comment that these are used only for top-level list groups and in portals.
967 This strangeness suggests even more that this should not be squeezed
968 into the LayoutGroup class.
970 2012-05-07 Murray Cumming <murrayc@murrayc.com>
972 Fix Formatting loading.
974 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
975 getFormattingUsed(): Remove the duplicate Formatting member variable
976 in favour of the one from the base class.
977 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
978 Initialize a new Formatting instead of using null by default, so we
979 have some defaults, instead of having to initialize one later just to
980 get the same defaults. This also makes loading of formatting from the
981 document work, because that expected a non-null.
983 2012-05-07 Murray Cumming <murrayc@murrayc.com>
985 RelatedListTable: Make sure that the tableName is set.
987 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
988 Constructor: Take the tableName so it is available later. Otherwise,
989 the server assumes that we mean the default table and cannot find the
991 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
992 setData(): Pass the tableName to the RelatedListTable constructor.
994 2012-05-07 Murray Cumming <murrayc@murrayc.com>
998 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
999 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
1000 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1002 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1004 * src/main/java/org/glom/web/server/database/DBAccess.java:
1005 convertResultSetToDTO(), getPortal():
1006 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1008 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1009 Add checks for null objects and out of range access, with log messages to
1010 give hints so we can fix these properly.
1012 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1014 Portals: some corrections.
1016 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1018 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1019 constructor: Use getRelationshipNameUsed() instead of getName(), because
1020 that is what is meant.
1021 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1022 getFromField(): Fix a typo, to get the field name, not the table name.
1023 * src/main/java/org/glom/web/server/database/DBAccess.java:
1024 getPortal(): Fix a typo that stopped this from working.
1026 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1028 LayoutItemPortal: Also override getTitleOriginal().
1030 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1031 This lets the base getTitle() with no parameters work.
1032 TODO: Test this properly.
1034 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1036 LayoutItemPortal: getTitle*(): Use the relationship title.
1038 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1040 LayoutItemField: Fix loading of custom titles.
1042 * src/main/java/org/glom/web/server/libglom/Document.java
1043 loadDataLayoutItemField(): The title, if any, instead of the field
1044 title, is stored in a title_custom node. Load it from there.
1045 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
1047 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
1048 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
1049 getTitle*() overrides.
1050 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1053 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1055 LayoutItemField: Fall back to field titles, so some are really shown.
1057 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1058 Override getTitleOriginal() and getTitle(), as in java-libglom.
1059 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1060 Test this behaviour.
1062 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1064 Correct use of setExpectedResultSize().
1066 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1067 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1068 Use setExpectedResultSize only on top-level groups (for instance, the
1069 list layout) or on child portals (in details views).
1070 Use the correct table name for portals to avoid SQL errors.
1071 Update the expected counts when returning cached layouts.
1073 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1075 Document: Interpret no group column count as 1.
1077 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1078 default, though we now check for this in the UI code anyway.
1080 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1084 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1086 Translatable: Use Hashmap instead of Treemap because GWT supports it.
1088 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1089 The use of Treemap lead to this error from async methods, with no
1091 "The response could not be deserialized"
1093 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1095 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1097 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
1098 when using the Google -> GWT Compile, or
1099 g toolbar button -> GWT Compile Project... feature in Eclipse.
1101 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1103 ListTable.addColumn(): Protect against a null Formatting.
1105 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1106 Create a default Formatting if it is null, because that is the simplest
1109 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1111 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1113 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1114 updateLayoutGroup(): Check that the field is not null.
1116 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1118 ListViewImpl: Protected against a bad cast error.
1120 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1121 onEnterKeyDown(): Do not cast without an instanceof check.
1123 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1125 ListTable: Protect against an out of range error.
1127 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1128 createCellTable(): This is unlikely, but can happen while debugging.
1130 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1132 AsyncMessage onFailure() callbacks: Log the exception message.
1134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1135 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1136 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1137 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1139 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1140 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1141 These are useful clues when something is wrong.
1143 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1145 ConfiguredDocument: Avoid a null dereference.
1147 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1148 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
1149 details maps are created.
1151 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1153 Document: Correct the port number parsing.
1155 * src/main/java/org/glom/web/server/libglom/Document.java:
1156 This lets us actually connect to the database and show the document.
1158 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1162 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1163 user-interaction, asking us to load a temporary URL in a browser.s
1164 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1165 which is apparently necessary for testing the service. See the comment.
1166 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1167 Show the exception, if any. This is how I saw the 404 in the HTML in
1170 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1172 DocumentTest: Move the .glom files into the resources directory.
1174 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1175 URI via getResource().
1177 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1179 Document: Remove the FieldIdentifies inner class.
1181 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1182 use the Relationship (though the same function in libglom is maybe
1183 used in other ways) and so this removes a compiler warning.
1185 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1187 Document.load() Remove the error code parameter.
1189 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1190 Remove the parameter. We do not set it yet and it could never have
1191 worked as an output parameter (though maybe it did in java-libglom).
1192 We could use an exception if we really want the failure reason.
1193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1195 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1196 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1198 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1200 Make some inner classes static.
1202 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1204 * src/main/java/org/glom/web/server/ReportGenerator.java
1205 * src/main/java/org/glom/web/server/libglom/Document.java
1206 Make all inner classes static that can be static.
1208 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1210 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1213 init(): We do not use java-libglom any more.
1215 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1217 Remove mentions of java-libglom.
1219 * README: Remove mention of java-libglom, because it no longer needed.
1220 * utils/build-onlineglom-war.sh:
1221 * utils/check-and-recover-tomcat.py:
1222 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1223 useful. Building is now far easier, with no need for jhbuild.
1225 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1227 Fix the build (mvn package)
1229 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1230 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1231 Otherwise the GWT Java->Javascript compilation fails with just this
1232 error, during mvn package or when attempting to view in a browser,
1233 in the GWT developer mode in Eclipse.
1235 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1236 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1237 [INFO] Compiling module org.glom.web.OnlineGlom
1238 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1239 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1240 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1241 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1242 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1243 [INFO] [ERROR] Cannot proceed due to previous errors
1245 It has taken me 2 days to find out what was causing that. After reducing
1246 the code, the compiler eventually showed me the full error message.
1248 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1250 ConfiguredDocument: Cache the cloned and stripped layouts.
1252 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1253 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1254 layout in a map, so we can retrieve it again without rebuilding it.
1256 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1258 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1260 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1262 libglom classes: Implement some auto-generated emthods.
1264 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1266 Add GwtTestOnlineGlomService.
1268 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1269 However, this (and the other GwtTest*) does not seem to run during
1272 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1274 Remove use of unsupported features from client code.
1276 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1277 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1278 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1279 Use our client version of StringUtils instead of the apache commons one.
1281 However, the GWT Javascript compliation still fails.
1283 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1285 Add a Field class and implement some loading of it in Document.
1287 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1289 Initial Document loading implementation, instead of libglom.
1291 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1292 and Translatable classes, and adapt the rest of the code to use them.
1293 However, this is still missing Layout and Field classes and loading.
1295 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1297 Use of jOOQ: Move Field creation into a utility method.
1299 * src/main/java/org/glom/web/server/SqlUtils.java:
1300 This lets us improve it more easily.
1302 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1304 Use of jOOQ: Improve the code to COUNT a sub-select.
1306 * src/main/java/org/glom/web/server/SqlUtils.java:
1307 Move initial query creation into
1308 build_sql_select_step_with_where_clause().
1309 build_sql_select_count_rows(): Use the jOOQ API instead of
1310 concatentating text, because a jOOQ Select*Step is a TableLike,
1311 which is what from() takes.
1313 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1315 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1317 * pom.xml: Depend on jooq.
1318 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1319 methods with jOOQ, based on the C++ implementations in libglom,
1320 with some changes to the logic required by jooQ.
1321 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1323 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1324 * src/main/java/org/glom/web/server/ReportGenerator.java:
1325 * src/main/java/org/glom/web/server/SqlUtils.java:
1326 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1327 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1328 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1329 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1330 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1331 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1332 because jOOQ needs that, though it seems unnecessary.
1334 This is not quite finished. Ideally jOOQ would help us to build
1335 table_name.field_name names, quoting and escaping them properly.
1336 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1338 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1340 Move use of Glom.build_sql*() into a new SqlUtils class.
1342 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1343 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1344 but this will make it easier to start using something other than
1345 libglom or SqlBuilder.
1347 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1349 Update the project URL.
1351 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1353 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1355 Main layout: Use a FlowTable instead of absolute positioning.
1357 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1358 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1359 child panels/widgets must have an absolute position. But that is annoying, so
1360 this adds a FlowTable and puts the child panels in there.
1362 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1364 GwtTestOnlineGlom: Comment out unused code.
1366 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1367 Eclipse has started to say that some code is unused.
1369 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1371 Update to the latest versions of dependencies.
1373 * pom.xml: Update version numbers of dependencies to the latest
1375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1376 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1377 * src/main/java/org/glom/web/server/ReportGenerator.java:
1378 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1379 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1380 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1382 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1383 Modify the imports where necessary.
1385 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1387 Style: Remove overflow:hidden from searchbox
1389 * src/main/webapp/style.css: Because this pushes the Back To Link
1390 label/link on to the next row, which is then hidden due to the
1391 hard-coded (in ems) height.
1393 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1395 Remove some duplicate code.
1397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1398 getDocumentInfo(): This must have been duplicated during the merge from the
1403 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1405 Reports: Localize the waiting for report message.
1407 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1408 start(): Get the message from the contants.
1409 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1410 Add the string here.
1411 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1412 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1413 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1414 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1415 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1416 Update these files with the English text for newer strings for now.
1418 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1420 Reports: Show a message while waiting for the report.
1422 * src/main/java/org/glom/web/client/ui/ReportView.java
1423 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1424 Add setWaitingText(), to show a message saying that we are
1425 waiting for the report to be ready.
1426 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1427 start(): Call setWaitingText() before calling the async
1430 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1432 ReportGenerator: Specify date and time formats.
1434 * src/main/java/org/glom/web/server/ReportGenerator.java:
1435 createFieldValueElement(): Use the default (and localized)
1436 short formats, though we still need a way to show 4-digit
1437 years without providing the format for every locale.
1438 * src/main/java/org/glom/web/server/database/DBAccess.java:
1439 convertResultSetToDTO(): Use the short formats here too.
1441 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1443 ReportGenerator: Use the correct numeric formatting.
1445 * src/main/java/org/glom/web/server/ReportGenerator.java
1446 createFieldExpression(), createFieldValueElement(): Take the
1447 whole LayoutItem_Field instead of just the field name, so
1448 we have access to the formatting.
1449 createFieldValueElement(): Use JRTextField.setPattern() to
1450 specify the numeric formatting, with the help of a
1451 regular DecimalFormat.
1453 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1455 ReportGenerator: Avoid showing null for group by titles.
1457 * src/main/java/org/glom/web/server/ReportGenerator.java
1458 generateReport(): Use setBlankWhenNull() on the field title
1459 style too, because this is used for values in group by
1462 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1464 ReportGenerator: Add a colon to titles in vertical groups.
1466 * src/main/java/org/glom/web/server/ReportGenerator.java
1467 addFieldToDetailBandVertical(): Pass true for the withColon
1470 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1472 ReportGenerator: Simplify the code by using Position more.
1474 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1476 Reports: Support vertical groups, roughly.
1478 * src/main/java/org/glom/web/server/ReportGenerator.java:
1479 addToReport(): Rename to addGroupToReport() and, if necessary,
1480 call the new addVerticalGroupToReport() method.
1481 createFieldValueElement(): Let the caller specify the Y position
1484 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1486 Reports: Allow a second report to be shown.
1488 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1489 clear(): Do not remove the HTML widget, which broke the whole layout.
1491 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1493 Locales drop-down: Show that we use English by default.
1495 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1496 fillView(): When we use English, just because that is the default, when
1497 no locale is specified, show that in the Locales drop-down instead of
1498 just showing the first item.
1500 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1502 Unselect the Report/Locale/Table combo item when appropriate.
1504 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1505 setPlace(): clear reportName if this is not a ReportPlace.
1506 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1507 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1508 When the provided name is empty, unselect all items, so that none are
1509 indicated. This uses a for loop because I cannot find a single method
1512 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1514 Report: Give the user a way to get back to the list.
1516 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1517 start(), setPlace(): Show the Back To List link on reports, and also
1518 interpret selecting the empty report item as back to list.
1520 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1522 Really show the selected Report name.
1524 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1525 setPlace(): Store the reportName here, if it is that kind of Place.
1526 fillView(): Set the selected Report after filling the list of reports.
1527 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1528 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1529 null Strings, though we need some way to unselect all ListBox items
1532 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1534 ReportGenerator: Try to avoid some problems.
1536 * src/main/java/org/glom/web/server/ReportGenerator.java
1537 addField(): Try to avoid duplicates, and avoid using a null
1540 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1542 Reports: Use quickFind.
1544 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1545 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1547 getReportHTML(): Add a quickFind parameter.
1548 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1549 start(): Pass the quickFind parameter.
1550 * src/main/java/org/glom/web/server/ReportGenerator.java
1551 generateReport(): Take a quickFind parameter.
1553 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1555 ReportPlace: Actually use the report name.
1557 * src/main/java/org/glom/web/client/place/ReportPlace.java
1558 getPlace(): Do not assign the report name to the quickfind.
1560 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1562 Show java.library.path when complaining.
1564 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1565 init(): When telling us to check java.library.path, show the
1568 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1570 ReportGenerator: Do not show nulls.
1572 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1574 ReportGenerator: Make the title font larger.
1576 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1578 ReportGenerator: Put field titles inside groups, if there are groups.
1580 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1582 ReportGenerator: Take the Report itself instead of the name and group.
1584 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1585 Remove getReportLayoutGroup().
1586 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1587 getReportHTML(): Pass the report instead
1588 of its name and layout group.
1589 * src/main/java/org/glom/web/server/ReportGenerator.java
1590 generateReport(): Use the report object to use the title
1591 instead of the name.
1593 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1595 ReportGenerator: Remove designBand parameters.
1597 * src/main/java/org/glom/web/server/ReportGenerator.java:
1598 Make designBand a class member instead of passing it to all
1601 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1603 ReportGenerator: Add lines, a bit like in the desktop version.
1605 * src/main/java/org/glom/web/server/ReportGenerator.java
1606 addToReport(): Use JRDesignLine.
1608 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1610 ReportGenerator: Correct the title positions and use some bold style.
1612 * src/main/java/org/glom/web/server/ReportGenerator.java:
1613 Break the code up into reusable functions, correct the placement of
1614 titles, and use normal/bold styles as in the reports in the desktop
1617 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1619 ReportGenerator: Add a header band to show the field titles.
1621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1622 getReportHTML(): Pass the localeId to the ReportGenerator
1624 * src/main/java/org/glom/web/server/ReportGenerator.java
1625 constructor: Take the localeID so we can get translated field
1627 generateReport(), addToReport(), addFieldToBand(): Add field
1628 titles in a column header band.
1630 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1632 Reports drop-down list: Some improvement.
1634 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1636 Adedd setSelectedReport(),
1637 setReportList(): Add a blank line so that the user can select the
1639 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1640 start(): Show the current report by calling setSelectedReport().
1641 This does not seem to work yet.
1643 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1645 DetailsActivity, ListActivity: Move some variables into a base class.
1647 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1648 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1649 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1650 the clientFactory, documentID, tableName and authenticationPopup into
1651 a base class, to avoid duplication.
1653 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1655 Translate the Reports label.
1657 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1658 Get the "Reports" label string from the constants.
1659 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1660 perties: Add Reports to the constants.
1662 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1664 Reports: Implement grouping.
1666 * src/main/java/org/glom/web/server/ReportGenerator.java:
1667 Handle LayoutItem_GroupBy items and try to do the right thing
1668 with JRDesignGroup. It seems to work.
1670 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1672 Actually show some data with JasperReports.
1674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1675 getReportHTML(): Move most code into a ReportGenerator class.
1676 * src/main/java/org/glom/web/server/ReportGenerator.java:
1677 Recurse into sub-groups, adding fields to the JasperDesign's details
1678 band. Note that we must set an arbitrary width and height, or it just
1679 will not show any data.
1681 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1683 Reports Chooser: Show the titles, not the names.
1685 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1686 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1687 and the names as the values.
1688 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1689 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1690 group now that we provide the report name, so it should always
1693 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1695 Depend on jasperreports.
1697 * pom.xml: Add the dependency. My plan is to use this on the
1700 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1702 Implement navigation to report places.
1704 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1705 start(): Do not bother to handle all events here.
1706 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1707 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1708 Added getSelectedReport().
1709 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1710 .java: start(): When handling a change to the reports chooser,
1711 call getSelectedReport() and goTo() its ReportPlace.
1712 * src/main/java/org/glom/web/client/ui/ReportView.java
1713 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1714 Added setReportHTML() which puts the html in a gwt HTML widget.
1715 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1716 getReportHTML(): Return "TODO" just to show that this works.
1718 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1720 Make ReportPlace usable.
1722 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1723 Mention ReportPlace.
1724 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1725 Correct the @prefix annotation.
1727 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1729 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1731 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1732 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1734 Change getReportLayout() to getReportHMTL() because we will not need to
1735 parse or render the report layout on the client side.
1736 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1737 getReportLayout(): Return the libglom LayoutGroup type because we will
1738 not need to convert to a shared type, because this will not be used on
1740 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1743 Note that there is still no implementation for this.
1746 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1748 Add a (empty) Report Place, View, and Activity.
1750 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1752 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1753 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1754 this into a superclass:
1755 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1756 and also use it as the base of this new ReportPlace:
1757 * src/main/java/org/glom/web/client/place/ReportPlace.java
1759 * src/main/java/org/glom/web/client/ui/ReportView.java
1760 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1761 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1762 Add these, containing mostly boiler-plate for now.
1764 * src/main/java/org/glom/web/client/OnlineGlomService.java
1765 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1766 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1768 Add API to get the LayoutGroup for the report.
1770 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1772 Add and fill a Reports drop-down list box.
1774 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1776 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1777 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1778 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1779 Added getReports(document, table, localeID), calling
1780 ConfiguredDocument.getReports().
1781 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1782 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1783 Added setReportsList() and a list widget.
1784 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1785 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1790 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1792 Translations: Add Esperanto.
1794 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1795 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1796 properties: Add this translation because someone took the time to make it.
1798 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1800 Adapt to the java-libglom 1.21.7 API.
1802 * src/main/java/org/glom/web/server/ReportGenerator.java:
1803 addToReport(): get_group_secondary_fields() is now
1804 get_secondary_fields().
1807 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1809 Use the latest java-libglom version.
1811 * pom.xml: Use java-libglom 1.21.7.
1813 2012-03-03 Ben Konrath <ben@bagu.org>
1815 Display date and time in details view.
1817 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1819 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1821 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1823 Require the latest java-libglom.
1825 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1827 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1829 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1831 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1832 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1833 an empty quickfind string. I also corrected libglom to create only
1834 empty where clauses for empty quickfind strings, but this avoids the
1837 2012-02-24 Ben Konrath <ben@bagu.org>
1839 Improve the tabs in the Notebook widget.
1843 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1845 Translations: Try to translate the strings.
1847 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1848 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1849 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1850 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1851 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1852 Take the Open translation from GTK+'s .po files.
1853 Take the Details translation from Glom's po files.
1854 I have added the other strings to Glom so we can get translations that way:
1855 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1857 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1859 TableSelectionViewImpl: Put the search label and entry in a div.
1861 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1862 Put the search widgets in a FlowTable so that the CSS can be used to
1863 style them while keeping them together.
1864 * src/main/webapp/style.css: Mention the new div.
1866 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1868 Translate more strings in more locales.
1870 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1871 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1872 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1873 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1874 Translate the "Details" and "Open" string too.
1876 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1877 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1878 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1879 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1880 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1881 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1882 Add these new locales as placeholders though they currently contain English.
1884 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1886 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1888 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1889 Check the ConfiguredDocument* for null before using it.
1891 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1893 Tell Eclipse about the generated java files.
1895 * .classpath: This lets it find OnlineGlomConstants.java.
1896 It would be nice if Eclipse just used the maven build files.
1898 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1900 Prevent a crash when no locale is specified in the URL.
1902 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1903 Avoid returning a null string, obtained from
1904 Window.Location.getParameter(). This caused a crash when it was
1905 later passed to libglom's API.
1906 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1907 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1908 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1909 guard against future null strings.
1911 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1913 Use the ?locale= query param instead of the &lang= token param.
1915 * src/main/java/org/glom/web/client/place/ListPlace.java
1916 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1917 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1918 Remove the lang token key and value.
1920 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1921 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1922 When the user selects a different locale from the chooser, use
1923 Window.Location.assign() to change the URL, which then causes a reload.
1925 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1926 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1927 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1928 * src/main/java/org/glom/web/client/activity/ListActivity.java
1929 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1930 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1931 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1932 * src/main/java/org/glom/web/client/ui/ListView.java:
1933 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1935 Remove localeID member variables and method/constructor parameters, instead
1936 using Utils.getCurrentLocaleID() when we need a localID to pass to
1939 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1941 Internationalize the UI strings.
1943 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1944 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1945 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1946 because it is unused. Messages are apparently strings that can have
1947 parameters, but we do not need that yet, so Contants will be enough for now.
1948 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1949 to say that we support the en and de locales.
1950 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1951 The original English strings.
1952 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1953 Some German translations of the English strings.
1954 The i18n goal then uses the .properties file to generate an
1955 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1956 returns an implementation that returns the translated strings.
1957 The documentation suggests putting these in src/java/*/client/, but it seems
1958 best to put it in src/resources/*/client/.
1959 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1960 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1961 instead of hard-coding them.
1962 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1963 but that does not seem to stop the build, though it confuses Eclipse.
1965 You can see the translated string by adding ?locale=de to the URL, like so:
1966 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1968 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1970 Improve null/empty String checks.
1972 * pom.xml: Add a dependency on commons-lang, to use
1973 org.apache.commons.lang.StringUtils.
1974 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1976 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1977 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1978 Use StringUtils.isEmpty().
1980 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1981 StringUtils class with a static isEmpty() function because we
1982 cannot use org.apache.commons.lang.StringUtils in client-side
1983 GWT code because it (apparently) cannot be compiled to javascript.
1984 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1985 * src/main/java/org/glom/web/client/activity/ListActivity.java
1986 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1987 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1988 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1989 * src/main/java/org/glom/web/client/place/ListPlace.java
1990 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1991 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1992 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1993 * src/main/java/org/glom/web/client/ui/details/Group.java
1994 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1995 our StringUtils.isEmpty() function.
1997 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1999 Update to the latest java-libglom API.
2001 * pom.xml: Require java-libglom 1.21.4.
2002 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2003 getDocumentInfo(), getListViewLayoutGroup():
2004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2006 * src/main/java/org/glom/web/server/database/DBAccess.java
2007 getFieldsToShowForSQLQueryAddGroup(),
2008 getPrimaryKeyLayoutItemField(): Replace get_database_title()
2009 with either get_database_title_original() or
2010 get_database_title(localeID).
2012 2012-01-24 Murray Cumming <murrayc@murrayc.com>
2014 ConfiguredDocument: Avoid a null pointer exception.
2016 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2017 Initialize localeID to "" to avoid returning a null String which
2018 causes a crash in java-libglom's swing-generated code.
2020 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2022 Some simple renaming.
2024 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2025 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
2026 for localeChooser. This seems more appropriate and is less ambiguous
2027 particularly in the .css file.
2029 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2031 ConfiguredDocument: Rename the localedID private member variable.
2033 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2035 Adapt to the latest java-libglom API from git master.
2037 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2038 libglom now uses only Vector instead of List, which uses add() instead of
2041 2012-01-22 Murray Cumming <murrayc@murrayc.com>
2043 ConfiguredDocument: Rename the localedID private member variable.
2045 2012-01-20 Murray Cumming <murrayc@murrayc.com>
2047 Build a source tarball with mvn assembly:single
2049 * assembly.xml: Add this file.
2050 * pom.xml: Use the maven-assembly-plugin and tell it to use
2051 our assembly.xml file.
2053 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2055 OnlineGlomServiceImpl: Get .glom files recursively.
2057 * pom.xml: Depend on commons-io from org.apache.commons.
2058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2059 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
2060 files recursively, and with the easier filter for the extension.
2061 Use org.apache.commons.io.FilenameUtils.removeExtension() to
2062 simplify that code too.
2064 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2066 README: Mention that you must install java-libglom packages separately.
2068 But then it works, because java-libglom is now in the central maven
2071 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2073 locales drop-down: Show the correct selected locale when the URL changes.
2075 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2076 .java: setPlace(): Move some code into fillView().
2078 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2080 locales drop-down: Do not lose the primary key.
2082 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2083 start(): onLocaleChange(): Pass the current primary key value,
2084 instead of an empty value.
2086 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2088 locales drop-down: Do not lose the drop-down selection.
2090 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2091 .java (TableSelectionActivity.fillView): Set the selected locale
2092 after changing the drop-down items (though we do not really need
2093 to change them just because the locale changes.)
2095 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2097 locales drop-down: Change the tables list when this changes.
2099 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2100 .java: TableSelectionActivity.start(): Move the async table titles
2101 retrieval into a private fillView() method and also call this when
2102 the chosen locale changes.
2103 Note that the document title is not actually translatable yet, but
2104 that is a problem that I should fix soon in libglom.
2106 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2108 Improve the placement of the locales drop-down.
2110 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2111 Put the title and locales drop-down in a div (gwt.FlowTable).
2112 * src/main/webapp/style.css: Add magic css properties to make this work.
2113 Also remove the left margin from the title so that it lines up with the
2116 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2118 locales selector: Show human-readable locale titles.
2120 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2121 getDocumentInfo(): Use java.util.Locale to show a real title of
2122 each locale, in the locale's own language.
2124 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2126 Add a language/locale selector drop-down.
2128 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2129 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2130 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2131 getDocumentInfo(): Store the available Locales in the DocumentInfo.
2132 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2133 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2134 Add a ListBox to show the available locales. Add getLocaleSelector(),
2135 setLocaleList(), getSelectedLocale(), setSelectedLocale().
2136 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2137 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2138 java: Add these classes.
2139 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2140 start(): Fill the locales ListBox. Handle its change event, firing a
2142 setPlace(): Show the selected locale as specified by the URL token.
2143 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2144 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2145 Handle LocaleChangeEvent, going to a new *Place with that locale.
2147 The placement of the ListBox is not pretty, and it currently uses the ID
2148 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
2152 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2154 Search box: Show the search text from the URL token.
2156 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2158 Add setQuickFindText().
2159 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2160 .java: setPlace(): Store the queryText if the place is a ListPlace,
2161 and call TableSelectionView.setQuickFindText().
2163 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2165 Allow use of translations via, for instance, &lang=de in the URL.
2167 * pom.xml: Use the unstable java-libglom 1.21 version.
2169 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2170 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2172 init(): Instead of calling TranslatableItem.set_current_locale()
2173 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2174 However, this is only for default locales, which are not needed to
2175 change the locale in the URL.
2176 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2177 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2178 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2179 layout for a particular locale.
2180 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2181 Add get/setDefaultLocaleID().
2182 getDocumentInfo(), getListViewData(), getRelatedListData(),
2183 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2184 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2185 localeID parameter, so we can get the layout for a particular locale.
2187 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2188 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2189 * src/main/java/org/glom/web/client/place/ListPlace.java:
2190 Parse and construct a lang parameter too.
2192 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2193 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2194 passed to subsequent methods and constructors.
2195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2196 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2197 Store the localeID from the *Place and pass it to other constructors
2198 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2200 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2201 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2202 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2203 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2204 * src/main/java/org/glom/web/client/ui/ListView.java:
2205 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2206 Take localeID parameters and pass them to subsequent constructors and
2207 methods, so that the layout is always retrieved for that locale.
2209 This is rather repetitive.
2211 Note that "" means the original (default) locale of the Glom document,
2212 which is usually English.
2214 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2216 Documents: Remove final keyword to fix startup configuration.
2218 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2219 final keywords on the private member variables because that breaks
2220 the startup, apparently (there are warnings) because it stops them
2221 from being serialized. I added these in the previous commit.
2223 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2225 Documents: Add some final keywords.
2227 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2230 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2232 OnlineGlomServiceImpl: Add to overview comments.
2234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2235 Note that this is where all the document are loaded. They are not
2236 loaded freshly for each page.
2238 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2242 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2243 Add a TextBox for the text of a quick find.
2244 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2246 setBackLink(): Add a String quickFind parameter.
2247 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2248 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2249 to the base interface, because that is how TableSelectionViewImpl is used.
2250 * src/main/webapp/style.css: Add style for the search box and its label.
2252 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2253 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2254 Add these files, based on the existing TableChangeEvent and
2255 TableChangeEventHandlers.
2256 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2257 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2258 a ListPlace() that the user should be taken to.
2259 * src/main/java/org/glom/web/client/activity/ListActivity.java
2260 start(): Handle it here too and adapt the TableChangeEvent handler to
2261 pass the extra "" quickFind parameter to ListPlace.
2262 * src/main/java/org/glom/web/client/place/ListPlace.java:
2263 Constructor: Take an extra String quickFind parameter and store it,
2264 returning it from a new getQuickFind() method.
2265 getToken(): Put the quickFind text in the URL token.
2266 getPlace(): Parse the quickFind text from the URL token.
2267 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2268 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2269 ListPlace constructor.
2270 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2271 .java: start(): Add a Change handler for the TableSelectionView's
2272 TextBox (via its base HasChangeHandlers interface), firing the new
2273 QuickFindChangeEvent.
2274 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2275 pass the extra "" quickFind parameter.
2277 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2278 setCellTable(): Add a String quickFind parameter and pass it to
2279 the ListViewTable() constructor.
2280 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2281 setCellTable() in the base interface, because that is how ListViewImpl
2284 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2285 Add a String quickFind member variable.
2286 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2287 Constructor: Add a String quickFind parameter, storing it in the
2288 base ListTable's member variable.
2289 onRangeChanged(): Pass quickFind to the
2290 OnlineGlomServiceAsync.getSortedListViewData() and
2291 OnlineGlomServiceAsync.getListViewData() methods.
2293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2294 getListViewData(), getSortedListViewData(): Add a String quickFind
2295 parameter, passing it to ConfiguredDocument.getListViewData().
2296 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2297 Change getListViewData(), getSortedListViewData() in the base interface,
2298 because that is how OnlineGlomServiceImpl is used, via this:
2299 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2300 Change getListViewData(), getSortedListViewData() here too.
2301 This class can apparently be used to asynchronously call methods on
2302 OnlineGlomService, and GWT seems to implement that after recognizing
2303 just the *Async name convention and the extra AsyncCallback parameters.
2305 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2306 getListViewData(): Add a String quickFind parameter, and pass it to
2307 ListViewDBAccess.getData().
2308 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2309 getListData(): Add a String quickFind parameter and pass it to
2311 getSelectQuery(): Add a String quickFind parameter.
2312 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2313 getSelectQuery(): Add a String quickFind parameter and use it with
2314 Glom.get_find_where_clause_quick() to pass a where_clause to
2315 Glom.build_sql_select_with_where_clause(), to actually filter the
2317 getData(): Add a String quickFind parameter, passing it to getListData().
2318 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2319 va: getData(): Pass an empty string to getListData() for the
2320 quickFind parameter.
2322 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2324 ListTable: Minor change.
2326 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2327 createCellTable(): Make this protected instead of public.
2329 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2331 Many files: Use final for the parameters and use the @override attribute.
2333 2012-01-22 Ben Konrath <ben@bagu.org>
2335 Add anchor links for single line text that starts with http, ftp and www.
2339 2012-01-22 Ben Konrath <ben@bagu.org>
2341 Add ellipsis to single line text in details view.
2345 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2347 Remove all javadoc author tags.
2349 Because they are awkward and meaningless when many people touch
2351 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2353 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2355 Revert the COPYING.LESSER to COPYING rename.
2357 Apparently both should be there if it is LGPL.
2359 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2361 *View: Remove unused imports.
2363 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2364 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2365 * src/main/java/org/glom/web/client/ui/ListView.java:
2366 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2367 Remove unused imports, as suggested by Eclipse.
2369 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2371 Move the *View::Presenter types, and some API into one base View.
2373 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2374 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2375 * src/main/java/org/glom/web/client/ui/ListView.java:
2376 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2377 Presenter, setPresenter() and clear() into a shared base interface,
2378 to avoid the unnecessary duplicate Presenter types and to more clearly
2379 show how the *Views share the same structure, even if they are not
2380 used polymorphically.
2382 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2383 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2385 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2386 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2387 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2389 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2392 Feel free to revert this if there is a good reason for the duplicate
2395 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2397 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2399 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2400 a class member instead of a local variable in the method.
2401 This lets us use it to get the view instances, for use in tests.
2402 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2403 beforeOnlineGlom(): Test some more details of the initial view.
2404 Again, this is not very useful.
2406 To really test gwt-glom we will need to start a local postgresql
2407 instance with local data, like the Glom tests in C++.
2409 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2411 pom.xml: Mention the LGPL license.
2413 * pom.xml: Add a licenses section.
2414 * COPYING.LESSER: Move this to COPYING, which
2415 previously contained the GPL. But gwt-glom is all LGPL.
2417 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2419 Add project information to README and pom.xml.
2421 * README: Add a brief description and mention some mvn
2423 * pom.xml: This extra information shows up in mvn site
2426 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2428 Use the latest java-libglom version.
2430 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2432 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2434 GwtTestOnlineGlom: Test a little more.
2436 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2437 protected rather than private, as suggested by the gwt-test-utils
2439 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2440 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2441 Test the initial visibility of the panels.
2443 However, this is not a very useful test.
2444 And I wonder how we should generally test using this idea for an
2445 activity/places app like ours where the real changes happen implicitly
2446 based on the history token/URL.
2448 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2450 Slight modification to *Mapper comments.
2452 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2453 (DataActivityMapper)
2454 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2456 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2458 Remove comments mentioning GIN because they are just copied from
2459 the example code and are apparently not helpful:
2460 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2461 Also change the mention of a class that is only in the example code.
2463 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2465 GwtTestOnlineGlom test: Minor changes.
2467 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2468 Avoid the long qualified class name and modify the comment
2469 because it is now obvious to me that the mocked class is the only
2470 custom one created via GWT.create().
2472 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2474 Tests: Added the beginnings of a test using gwt-test-utils.
2476 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2477 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2478 which tells gwt-test-utils what class will be tested.
2479 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2480 Add a simple (but empty) test case. One class, used by the OnlineGlom
2481 class, is mocked so that it can be created. However, I am not sure
2482 why only this class needs to be mocked.
2484 Note that mockito seems more popular, and clearer, than easymock,
2485 but I have not got that working yet. It might be a matter of the
2488 This test is run during mvn integration-test.
2490 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2492 Tests: Use junit4-style syntax instead of junit3-style.
2494 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2495 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2496 * src/test/java/org/glom/web/shared/DataItemTest.java:
2497 Use the @Test annotation rather than relying on the test*() prefix.
2498 Also no longer implement TestCase, to avoid triggering support for
2499 the junit3-way, which stops the annotations from working.
2500 Change the imports from import junit.framework.* to
2501 import org.junit.*, which is apparently the new way.
2503 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2505 Added a test for ListPlace token parsing and creation.
2507 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2508 This is much the same as DetailsPlaceTest.
2510 I wonder how we could test the other parts of the *Place API.
2512 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2514 DetailsPlace test: Also test getToken() and recreation via getPlace().
2516 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2517 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2518 recreate it, testing the recreated DetailsPlace for the same parameter
2521 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2523 Use the surefire-report plugin.
2525 * pom.xml: This generates a HTML report about the tests in
2526 target/site/surefire-report.html
2527 when you do mvn surefire-report:report. It seems to be popular/normal.
2529 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2531 Added a test for DetailsPlace.
2533 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2534 Test the getPlace() token parsing.
2536 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2538 Added a first unit test.
2540 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2541 * src/test/java/org/glom/web/shared/DataItemTest.java:
2542 This is a silly test but it is just to get things started. Note that
2543 maven/junit finds the test because it looks in src/test by default.
2545 2011-12-22 Ben Konrath <ben@bagu.org>
2547 Change charsetName to "UTF-8" when replacing line breaks.
2549 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2550 that work in Java (such as "UTF8") will not work when compiled to
2553 This fixes a problem with multi-line details view fields that have hard
2554 line breaks. The "License Text" field on this page demonstrates the
2557 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2559 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2561 2011-12-22 Ben Konrath <ben@bagu.org>
2563 Fix another bug with related list navigation.
2565 I've tested all the navigation buttons in all of the related lists
2566 so things should be good now.
2568 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2570 2011-12-22 Ben Konrath <ben@bagu.org>
2572 Fix a crasher when refreshing the list view with the default table.
2574 This crash will also happen when loading the list view with the default
2575 table from a link or bookmark.
2577 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2578 to the main document selection page when the document id hasn't been
2580 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2581 the main document selection page when the document id hasn't been
2583 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2584 values for the details place when the document id hasn't been set.
2585 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2586 values for the list place when the document id hasn't been set.
2588 2011-12-21 Ben Konrath <ben@bagu.org>
2590 Protect against NPE when glom.document.locale is not in config.
2592 This patch protects against an NPE when glom.document.locale is not in
2593 the config file. This NPE will also happen if glom.document.locale is
2596 The patch also updates the error message to display the class name when
2597 the getMessage() returns null. This was happening when the NPE was
2598 thrown and I had "Configuration Error: null". If an NPE is encountered
2599 with this patch, "Configuration Error: NullPointerException " will be
2602 This commit closes this bug:
2604 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2606 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2608 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2610 Rename onlineglom.properties to onlineglom.properties.sample.
2612 * src/main/resources/onlineglom.properties: Rename to:
2613 * src/main/resources/onlineglom.properties.sample:
2614 * src/main/resources/README: And add this file explaining that people
2615 should rename it back when deploying.
2617 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2619 Allow choosing the translation in the .properties file.
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2622 init(): Read a glom.document.locale value from the configuration file
2623 and call Glom's TransatableItem::set_current_locale() method.
2624 * src/main/resources/onlineglom.properties: Add a commented-out
2625 example of this new setting.
2627 It would be better to add &lang=de_DE to the URL, but the current
2628 libglom API does not allow us to do this easily. I am working on that.
2630 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2632 Avoid a crash in parsing of token parameters.
2634 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2635 ava: getTokenParams(): Do not crash if a parameter has a key but no
2636 value, and ignore parameters with neither.
2638 2011-12-17 Murray Cumming <murrayc@murayc.com>
2640 History token building/handling: Improve use of token parameters.
2642 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2643 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2644 and buildParamsToken(HashMap), for use by derived classes.
2645 Make the separator private because it is no longer be needed.
2646 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2647 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2648 instead of manual string concatenation.
2649 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2650 of hardcoded indices and awkward splitting code.
2651 * src/main/java/org/glom/web/client/place/ListPlace.java
2652 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2653 instead of manual string concatenation.
2654 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2655 of hardcoded indices and awkward splitting code.
2656 This should fix bug #666420
2658 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2660 Fix a Navgiation->Navigation typo in the code.
2662 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2663 Rename processNavgiation() to processNavigation().
2665 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2667 Fix a seperator->separator typo in the code.
2669 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2670 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2671 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2674 2011-12-15 Ben Konrath <ben@bagu.org>
2676 Cleanup some comments.
2678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2680 2011-12-14 Ben Konrath <ben@bagu.org>
2682 Replace \n with <br/> for multiline text in the details view.
2684 Vertical scrollbars are added when needed as well.
2686 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2688 2011-12-14 Ben Konrath <ben@bagu.org>
2690 Specify the font for document selection links.
2692 * src/main/webapp/style.css:
2694 2011-12-14 Ben Konrath <ben@bagu.org>
2696 Fix bouncy CellTable while paging.
2698 This doesn't currently work with related list tables in unselected
2701 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2703 2011-12-14 Ben Konrath <ben@bagu.org>
2705 Revamp the appearance of the document selection page.
2707 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2708 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2709 * src/main/webapp/style.css:
2711 2011-12-13 Ben Konrath <ben@bagu.org>
2713 Set navigation button column to the smallest size possible.
2715 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2717 2011-12-13 Ben Konrath <ben@bagu.org>
2719 Change OpenButton nomenclature to NavigationButton.
2721 Using NavigtionButton makes things more generic. Classes, methods and
2722 variables have been changed.
2724 This is a rename-only refactor.
2726 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2727 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2728 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2729 Renamed from OpenButtonCell.
2730 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2731 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2732 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2734 2011-12-12 Ben Konrath <ben@bagu.org>
2736 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2738 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2739 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2740 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2741 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2743 2011-12-12 Ben Konrath <ben@bagu.org>
2745 Update variable names and comments.
2747 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2748 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2750 2011-12-12 Ben Konrath <ben@bagu.org>
2752 Properly initialize numNonEmptyRows variable to zero.
2754 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2755 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2757 2011-12-05 Ben Konrath <ben@bagu.org>
2759 Add latest mockup with HTML tables.
2761 Features of this mockup:
2763 -> HTML table for flowtable
2764 -> HTML table for flowtable column
2765 -> Example of how related lists would look
2766 -> Not using text entries for data items
2768 The current version of Online Glom doesn't use HTML tables for the
2771 This mockup has been sent to the glom-devel mailing list but it's good
2772 to have it here as well.
2774 * mockups/details-view-html-tables.html:
2776 2011-12-05 Ben Konrath <ben@bagu.org>
2778 Remove unnecessary getPrimaryKeyField() method.
2780 getPrimaryKeyFieldForTable(String) has been renamed to
2781 getPrimaryKeyField(String).
2783 * src/main/java/org/glom/web/server/database/DBAccess.java:
2784 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2785 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2787 2011-12-05 Ben Konrath <ben@bagu.org>
2789 Add string representation of TypedDataItem value to conversion error message.
2791 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2792 message was extracted into its own method to avoid duplication.
2794 2011-12-05 Ben Konrath <ben@bagu.org>
2796 Add type checking to navigation primary key value creation.
2798 Create navigation primary key only if the expected type from the Glom
2799 document matches the type returned by the SQL query.
2801 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2803 2011-12-05 Ben Konrath <ben@bagu.org>
2805 Rename a couple of variables in RelatedListNavigation.
2807 This is a rename-only refactor.
2809 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2811 2011-12-05 Ben Konrath <ben@bagu.org>
2813 Move getListLayoutGroup() into getListViewLayoutGroup().
2815 This removes getListLayoutGroup(). It was only being called by
2816 getListViewLayoutGroup().
2818 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2820 2011-12-05 Ben Konrath <ben@bagu.org>
2822 Remove check for LayoutItem_Portal in list table method.
2824 This check is no longer necessary because the method isn't being used
2825 to create the LayoutItemPortal DTO.
2827 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2829 2011-12-05 Ben Konrath <ben@bagu.org>
2831 Properly support related list navigation.
2833 Navigation from the "Repository Analyzer -> Package Scans ->
2834 Dependencies" related table wasn't working because the primary key for
2835 related tables wasn't being set properly. This commit fixes the
2838 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2839 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2840 doesn't set the primary key properly for related list tables.
2841 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2842 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2843 useful for getting the primary key for list view tables and for related
2845 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2846 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2847 Move code to set the primary key for the table from the abstract
2848 ListDBAccess class to ListViewDBAccess as it's only correct for list
2850 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2851 Properly add primary key to related list tables.
2853 2011-12-02 Ben Konrath <ben@bagu.org>
2855 Properly set the horizontal alignment of fields.
2857 This fix is for both the list tables and the details view.
2859 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2860 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2861 to set the horizontal alignment of fields.
2863 2011-12-02 Ben Konrath <ben@bagu.org>
2865 Display currency codes in the details view.
2867 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2869 2011-12-02 Ben Konrath <ben@bagu.org>
2871 Avoid duplicate JNI call.
2873 JNI is not as efficient as pure Java and this is an easy (and small)
2876 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2877 Use previously retrieved value for whereClauseToTableName instead of
2880 2011-12-02 Ben Konrath <ben@bagu.org>
2882 Rename a couple of variables in RelatedListNavigation.
2884 This is a rename-only refactor.
2886 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2888 2011-12-02 Ben Konrath <ben@bagu.org>
2890 Indicate clearly that a mismatched primary key type is a bug.
2892 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2893 warning to error. Add 'This is a bug.' to message.
2895 2011-12-02 Ben Konrath <ben@bagu.org>
2897 Update / fix some comments.
2899 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2901 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2903 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2904 Fix comments. Add some TODOs.
2906 2011-12-02 Ben Konrath <ben@bagu.org>
2908 Enable navigation to details view with string primary key from related list.
2910 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2911 Create a text primary key value when return type of result is
2912 java.sql.Types.VARCHAR.
2914 2011-12-02 Ben Konrath <ben@bagu.org>
2916 Use checkboxes for booleans in the details view.
2918 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2920 2011-12-01 Ben Konrath <ben@bagu.org>
2922 Improve performance of related list height calculation.
2924 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2925 Put code to calculate the expected height in a static initializer so
2926 that that it's only called once.
2928 2011-12-01 Ben Konrath <ben@bagu.org>
2930 Show related list tables in notebooks (again).
2932 Calculate the height of the related list tables so the Notebook can be
2933 set the correct height. The height of the related list table is also needed by
2934 FlowTable to be able decide how to create the layout.
2936 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2937 and set the Portal height based on the height of the related list
2938 table and the Portal container.
2939 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2940 Add method to calculate the height of the related list tables.
2941 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2942 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2943 calculate the height of the Pager widget.
2945 2011-12-01 Ben Konrath <ben@bagu.org>
2947 Use CellTable API for table property instead of setting style on Element.
2949 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2951 2011-12-01 Ben Konrath <ben@bagu.org>
2953 Make ListViewTable and RelatedListTable a consistent height.
2955 The tables are now a consistent height regardless of the contents of
2956 the table. A hidden button is added to empty rows to ensure that the
2957 height of these rows will match the height of rows with data.
2959 A navigation button column is now added to every table. The width of
2960 the navigation column is set to 0px when a RelatedListTable shouldn't
2961 have navigation buttons. This maintains the a consistent row height in
2962 tables that don't show the navigation buttons.
2964 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2965 navigation column when not needed.
2966 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2967 arguments for navigation button to constructor of ListViewTable.
2968 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2969 hidden button for empty data rows.
2970 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2971 arguments for navigation button to constructor.
2972 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2973 create navigation buttons. Add hideNavigationButtons() method.
2974 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2975 arguments for navigation button to constructor.
2977 2011-12-01 Ben Konrath <ben@bagu.org>
2979 Use 'visibility: hidden' in Utils.getWidgetHeight().
2981 This is better choice because hidden elements are invisible, don't
2982 respond to events and are not part of the tab order. They will,