1 2012-05-05 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlomServiceImpl: Do not load and check for java-libglom.
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
6 init(): We do not use java-libglom any more.
8 2012-05-05 Murray Cumming <murrayc@murrayc.com>
10 Remove mentions of java-libglom.
12 * README: Remove mention of java-libglom, because it no longer needed.
13 * utils/build-onlineglom-war.sh:
14 * utils/check-and-recover-tomcat.py:
15 * utils/install-onlineglom-war.sh: Remove these as they are no longer
16 useful. Building is now far easier, with no need for jhbuild.
18 2012-05-05 Murray Cumming <murrayc@murrayc.com>
20 Fix the build (mvn package)
22 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
23 (LayoutGroup): Make the LayoutItemList inner class static and protected.
24 Otherwise the GWT Java->Javascript compilation fails with just this
25 error, during mvn package or when attempting to view in a browser,
26 in the GWT developer mode in Eclipse.
28 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
29 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
30 [INFO] Compiling module org.glom.web.OnlineGlom
31 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
32 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
33 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
34 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
35 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
36 [INFO] [ERROR] Cannot proceed due to previous errors
38 It has taken me 2 days to find out what was causing that. After reducing
39 the code, the compiler eventually showed me the full error message.
41 2012-05-04 Murray Cumming <murrayc@murrayc.com>
43 ConfiguredDocument: Cache the cloned and stripped layouts.
45 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
46 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
47 layout in a map, so we can retrieve it again without rebuilding it.
49 2012-05-04 Murray Cumming <murrayc@murrayc.com>
51 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
53 2012-05-04 Murray Cumming <murrayc@murrayc.com>
55 libglom classes: Implement some auto-generated emthods.
57 2012-05-04 Murray Cumming <murrayc@murrayc.com>
59 Add GwtTestOnlineGlomService.
61 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
62 However, this (and the other GwtTest*) does not seem to run during
65 2012-05-04 Murray Cumming <murrayc@murrayc.com>
67 Remove use of unsupported features from client code.
69 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
70 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
71 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
72 Use our client version of StringUtils instead of the apache commons one.
74 However, the GWT Javascript compliation still fails.
76 2012-04-25 Murray Cumming <murrayc@murrayc.com>
78 Add a Field class and implement some loading of it in Document.
80 2012-04-25 Murray Cumming <murrayc@murrayc.com>
82 Initial Document loading implementation, instead of libglom.
84 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
85 and Translatable classes, and adapt the rest of the code to use them.
86 However, this is still missing Layout and Field classes and loading.
88 2012-04-24 Murray Cumming <murrayc@murrayc.com>
90 Use of jOOQ: Move Field creation into a utility method.
92 * src/main/java/org/glom/web/server/SqlUtils.java:
93 This lets us improve it more easily.
95 2012-04-24 Murray Cumming <murrayc@murrayc.com>
97 Use of jOOQ: Improve the code to COUNT a sub-select.
99 * src/main/java/org/glom/web/server/SqlUtils.java:
100 Move initial query creation into
101 build_sql_select_step_with_where_clause().
102 build_sql_select_count_rows(): Use the jOOQ API instead of
103 concatentating text, because a jOOQ Select*Step is a TableLike,
104 which is what from() takes.
106 2012-04-23 Murray Cumming <murrayc@murrayc.com>
108 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
110 * pom.xml: Depend on jooq.
111 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
112 methods with jOOQ, based on the C++ implementations in libglom,
113 with some changes to the logic required by jooQ.
114 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
116 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
117 * src/main/java/org/glom/web/server/ReportGenerator.java:
118 * src/main/java/org/glom/web/server/SqlUtils.java:
119 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
120 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
121 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
122 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
123 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
124 Adapt. In particular, the SqlUtils methods now need to take a Connection,
125 because jOOQ needs that, though it seems unnecessary.
127 This is not quite finished. Ideally jOOQ would help us to build
128 table_name.field_name names, quoting and escaping them properly.
129 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
131 2012-04-21 Murray Cumming <murrayc@murrayc.com>
133 Move use of Glom.build_sql*() into a new SqlUtils class.
135 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
136 to wrap Glom.build_sql*(). The parameter types are still Glom one,
137 but this will make it easier to start using something other than
138 libglom or SqlBuilder.
140 2012-04-21 Murray Cumming <murrayc@murrayc.com>
142 Update the project URL.
144 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
146 2012-04-21 Murray Cumming <murrayc@murrayc.com>
148 Main layout: Use a FlowTable instead of absolute positioning.
150 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
151 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
152 child panels/widgets must have an absolute position. But that is annoying, so
153 this adds a FlowTable and puts the child panels in there.
155 2012-04-21 Murray Cumming <murrayc@murrayc.com>
157 GwtTestOnlineGlom: Comment out unused code.
159 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
160 Eclipse has started to say that some code is unused.
162 2012-04-21 Murray Cumming <murrayc@murrayc.com>
164 Update to the latest versions of dependencies.
166 * pom.xml: Update version numbers of dependencies to the latest
168 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
170 * src/main/java/org/glom/web/server/ReportGenerator.java:
171 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
172 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
173 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
175 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
176 Modify the imports where necessary.
178 2012-04-17 Murray Cumming <murrayc@murrayc.com>
180 Style: Remove overflow:hidden from searchbox
182 * src/main/webapp/style.css: Because this pushes the Back To Link
183 label/link on to the next row, which is then hidden due to the
184 hard-coded (in ems) height.
186 2012-04-20 Murray Cumming <murrayc@murrayc.com>
188 Remove some duplicate code.
190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
191 getDocumentInfo(): This must have been duplicated during the merge from the
196 2012-04-19 Murray Cumming <murrayc@murrayc.com>
198 Reports: Localize the waiting for report message.
200 * src/main/java/org/glom/web/client/activity/ReportActivity.java
201 start(): Get the message from the contants.
202 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
204 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
205 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
206 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
207 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
208 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
209 Update these files with the English text for newer strings for now.
211 2012-04-19 Murray Cumming <murrayc@murrayc.com>
213 Reports: Show a message while waiting for the report.
215 * src/main/java/org/glom/web/client/ui/ReportView.java
216 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
217 Add setWaitingText(), to show a message saying that we are
218 waiting for the report to be ready.
219 * src/main/java/org/glom/web/client/activity/ReportActivity.java
220 start(): Call setWaitingText() before calling the async
223 2012-04-19 Murray Cumming <murrayc@murrayc.com>
225 ReportGenerator: Specify date and time formats.
227 * src/main/java/org/glom/web/server/ReportGenerator.java:
228 createFieldValueElement(): Use the default (and localized)
229 short formats, though we still need a way to show 4-digit
230 years without providing the format for every locale.
231 * src/main/java/org/glom/web/server/database/DBAccess.java:
232 convertResultSetToDTO(): Use the short formats here too.
234 2012-04-18 Murray Cumming <murrayc@murrayc.com>
236 ReportGenerator: Use the correct numeric formatting.
238 * src/main/java/org/glom/web/server/ReportGenerator.java
239 createFieldExpression(), createFieldValueElement(): Take the
240 whole LayoutItem_Field instead of just the field name, so
241 we have access to the formatting.
242 createFieldValueElement(): Use JRTextField.setPattern() to
243 specify the numeric formatting, with the help of a
244 regular DecimalFormat.
246 2012-04-18 Murray Cumming <murrayc@murrayc.com>
248 ReportGenerator: Avoid showing null for group by titles.
250 * src/main/java/org/glom/web/server/ReportGenerator.java
251 generateReport(): Use setBlankWhenNull() on the field title
252 style too, because this is used for values in group by
255 2012-04-18 Murray Cumming <murrayc@murrayc.com>
257 ReportGenerator: Add a colon to titles in vertical groups.
259 * src/main/java/org/glom/web/server/ReportGenerator.java
260 addFieldToDetailBandVertical(): Pass true for the withColon
263 2012-04-18 Murray Cumming <murrayc@murrayc.com>
265 ReportGenerator: Simplify the code by using Position more.
267 2012-04-18 Murray Cumming <murrayc@murrayc.com>
269 Reports: Support vertical groups, roughly.
271 * src/main/java/org/glom/web/server/ReportGenerator.java:
272 addToReport(): Rename to addGroupToReport() and, if necessary,
273 call the new addVerticalGroupToReport() method.
274 createFieldValueElement(): Let the caller specify the Y position
277 2012-04-17 Murray Cumming <murrayc@murrayc.com>
279 Reports: Allow a second report to be shown.
281 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
282 clear(): Do not remove the HTML widget, which broke the whole layout.
284 2012-04-17 Murray Cumming <murrayc@murrayc.com>
286 Locales drop-down: Show that we use English by default.
288 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
289 fillView(): When we use English, just because that is the default, when
290 no locale is specified, show that in the Locales drop-down instead of
291 just showing the first item.
293 2012-04-17 Murray Cumming <murrayc@murrayc.com>
295 Unselect the Report/Locale/Table combo item when appropriate.
297 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
298 setPlace(): clear reportName if this is not a ReportPlace.
299 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
300 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
301 When the provided name is empty, unselect all items, so that none are
302 indicated. This uses a for loop because I cannot find a single method
305 2012-04-17 Murray Cumming <murrayc@murrayc.com>
307 Report: Give the user a way to get back to the list.
309 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
310 start(), setPlace(): Show the Back To List link on reports, and also
311 interpret selecting the empty report item as back to list.
313 2012-04-13 Murray Cumming <murrayc@murrayc.com>
315 Really show the selected Report name.
317 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
318 setPlace(): Store the reportName here, if it is that kind of Place.
319 fillView(): Set the selected Report after filling the list of reports.
320 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
321 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
322 null Strings, though we need some way to unselect all ListBox items
325 2012-04-13 Murray Cumming <murrayc@murrayc.com>
327 ReportGenerator: Try to avoid some problems.
329 * src/main/java/org/glom/web/server/ReportGenerator.java
330 addField(): Try to avoid duplicates, and avoid using a null
333 2012-04-13 Murray Cumming <murrayc@murrayc.com>
335 Reports: Use quickFind.
337 * src/main/java/org/glom/web/client/OnlineGlomService.java;
338 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
340 getReportHTML(): Add a quickFind parameter.
341 * src/main/java/org/glom/web/client/activity/ReportActivity.java
342 start(): Pass the quickFind parameter.
343 * src/main/java/org/glom/web/server/ReportGenerator.java
344 generateReport(): Take a quickFind parameter.
346 2012-04-13 Murray Cumming <murrayc@murrayc.com>
348 ReportPlace: Actually use the report name.
350 * src/main/java/org/glom/web/client/place/ReportPlace.java
351 getPlace(): Do not assign the report name to the quickfind.
353 2012-04-13 Murray Cumming <murrayc@murrayc.com>
355 Show java.library.path when complaining.
357 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
358 init(): When telling us to check java.library.path, show the
361 2012-03-06 Murray Cumming <murrayc@murrayc.com>
363 ReportGenerator: Do not show nulls.
365 2012-03-06 Murray Cumming <murrayc@murrayc.com>
367 ReportGenerator: Make the title font larger.
369 2012-03-06 Murray Cumming <murrayc@murrayc.com>
371 ReportGenerator: Put field titles inside groups, if there are groups.
373 2012-03-06 Murray Cumming <murrayc@murrayc.com>
375 ReportGenerator: Take the Report itself instead of the name and group.
377 * src/main/java/org/glom/web/server/ConfiguredDocument.java
378 Remove getReportLayoutGroup().
379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
380 getReportHTML(): Pass the report instead
381 of its name and layout group.
382 * src/main/java/org/glom/web/server/ReportGenerator.java
383 generateReport(): Use the report object to use the title
386 2012-03-06 Murray Cumming <murrayc@murrayc.com>
388 ReportGenerator: Remove designBand parameters.
390 * src/main/java/org/glom/web/server/ReportGenerator.java:
391 Make designBand a class member instead of passing it to all
394 2012-03-06 Murray Cumming <murrayc@murrayc.com>
396 ReportGenerator: Add lines, a bit like in the desktop version.
398 * src/main/java/org/glom/web/server/ReportGenerator.java
399 addToReport(): Use JRDesignLine.
401 2012-03-06 Murray Cumming <murrayc@murrayc.com>
403 ReportGenerator: Correct the title positions and use some bold style.
405 * src/main/java/org/glom/web/server/ReportGenerator.java:
406 Break the code up into reusable functions, correct the placement of
407 titles, and use normal/bold styles as in the reports in the desktop
410 2012-03-06 Murray Cumming <murrayc@murrayc.com>
412 ReportGenerator: Add a header band to show the field titles.
414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
415 getReportHTML(): Pass the localeId to the ReportGenerator
417 * src/main/java/org/glom/web/server/ReportGenerator.java
418 constructor: Take the localeID so we can get translated field
420 generateReport(), addToReport(), addFieldToBand(): Add field
421 titles in a column header band.
423 2012-03-05 Murray Cumming <murrayc@murrayc.com>
425 Reports drop-down list: Some improvement.
427 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
428 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
429 Adedd setSelectedReport(),
430 setReportList(): Add a blank line so that the user can select the
432 * src/main/java/org/glom/web/client/activity/ReportActivity.java
433 start(): Show the current report by calling setSelectedReport().
434 This does not seem to work yet.
436 2012-03-05 Murray Cumming <murrayc@murrayc.com>
438 DetailsActivity, ListActivity: Move some variables into a base class.
440 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
441 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
442 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
443 the clientFactory, documentID, tableName and authenticationPopup into
444 a base class, to avoid duplication.
446 2012-03-05 Murray Cumming <murrayc@murrayc.com>
448 Translate the Reports label.
450 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
451 Get the "Reports" label string from the constants.
452 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
453 perties: Add Reports to the constants.
455 2012-03-05 Murray Cumming <murrayc@murrayc.com>
457 Reports: Implement grouping.
459 * src/main/java/org/glom/web/server/ReportGenerator.java:
460 Handle LayoutItem_GroupBy items and try to do the right thing
461 with JRDesignGroup. It seems to work.
463 2012-03-04 Murray Cumming <murrayc@murrayc.com>
465 Actually show some data with JasperReports.
467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
468 getReportHTML(): Move most code into a ReportGenerator class.
469 * src/main/java/org/glom/web/server/ReportGenerator.java:
470 Recurse into sub-groups, adding fields to the JasperDesign's details
471 band. Note that we must set an arbitrary width and height, or it just
472 will not show any data.
474 2012-03-04 Murray Cumming <murrayc@murrayc.com>
476 Reports Chooser: Show the titles, not the names.
478 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
479 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
480 and the names as the values.
481 * src/main/java/org/glom/web/server/ConfiguredDocument.java
482 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
483 group now that we provide the report name, so it should always
486 2012-02-15 Murray Cumming <murrayc@murrayc.com>
488 Depend on jasperreports.
490 * pom.xml: Add the dependency. My plan is to use this on the
493 2012-01-31 Murray Cumming <murrayc@murrayc.com>
495 Implement navigation to report places.
497 * src/main/java/org/glom/web/client/activity/ReportActivity.java
498 start(): Do not bother to handle all events here.
499 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
500 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
501 Added getSelectedReport().
502 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
503 .java: start(): When handling a change to the reports chooser,
504 call getSelectedReport() and goTo() its ReportPlace.
505 * src/main/java/org/glom/web/client/ui/ReportView.java
506 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
507 Added setReportHTML() which puts the html in a gwt HTML widget.
508 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
509 getReportHTML(): Return "TODO" just to show that this works.
511 2012-01-31 Murray Cumming <murrayc@murrayc.com>
513 Make ReportPlace usable.
515 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
517 * src/main/java/org/glom/web/client/place/ReportPlace.java:
518 Correct the @prefix annotation.
520 2012-01-31 Murray Cumming <murrayc@murrayc.com>
522 OnlineGlomService: Return report HTML rather than the LayoutGroup.
524 * src/main/java/org/glom/web/client/OnlineGlomService.java:
525 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
527 Change getReportLayout() to getReportHMTL() because we will not need to
528 parse or render the report layout on the client side.
529 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
530 getReportLayout(): Return the libglom LayoutGroup type because we will
531 not need to convert to a shared type, because this will not be used on
533 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
536 Note that there is still no implementation for this.
539 2012-01-27 Murray Cumming <murrayc@murrayc.com>
541 Add a (empty) Report Place, View, and Activity.
543 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
545 * src/main/java/org/glom/web/client/place/HasTablePlace.java
546 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
547 this into a superclass:
548 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
549 and also use it as the base of this new ReportPlace:
550 * src/main/java/org/glom/web/client/place/ReportPlace.java
552 * src/main/java/org/glom/web/client/ui/ReportView.java
553 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
554 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
555 Add these, containing mostly boiler-plate for now.
557 * src/main/java/org/glom/web/client/OnlineGlomService.java
558 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
559 * src/main/java/org/glom/web/server/ConfiguredDocument.java
560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
561 Add API to get the LayoutGroup for the report.
563 2012-01-23 Murray Cumming <murrayc@murrayc.com>
565 Add and fill a Reports drop-down list box.
567 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
569 * src/main/java/org/glom/web/client/OnlineGlomService.java:
570 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
571 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
572 Added getReports(document, table, localeID), calling
573 ConfiguredDocument.getReports().
574 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
575 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
576 Added setReportsList() and a list widget.
577 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
578 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
583 2012-04-12 Murray Cumming <murrayc@murrayc.com>
585 Translations: Add Esperanto.
587 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
588 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
589 properties: Add this translation because someone took the time to make it.
591 2012-03-15 Murray Cumming <murrayc@murrayc.com>
593 Adapt to the java-libglom 1.21.7 API.
595 * src/main/java/org/glom/web/server/ReportGenerator.java:
596 addToReport(): get_group_secondary_fields() is now
597 get_secondary_fields().
600 2012-03-15 Murray Cumming <murrayc@murrayc.com>
602 Use the latest java-libglom version.
604 * pom.xml: Use java-libglom 1.21.7.
606 2012-03-03 Ben Konrath <ben@bagu.org>
608 Display date and time in details view.
610 https://bugzilla.gnome.org/show_bug.cgi?id=671257
612 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
614 2012-03-05 Murray Cumming <murrayc@murrayc.com>
616 Require the latest java-libglom.
618 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
620 2012-03-04 Murray Cumming <murrayc@murrayc.com>
622 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
624 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
625 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
626 an empty quickfind string. I also corrected libglom to create only
627 empty where clauses for empty quickfind strings, but this avoids the
630 2012-02-24 Ben Konrath <ben@bagu.org>
632 Improve the tabs in the Notebook widget.
636 2012-01-30 Murray Cumming <murrayc@murrayc.com>
638 Translations: Try to translate the strings.
640 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
641 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
642 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
643 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
644 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
645 Take the Open translation from GTK+'s .po files.
646 Take the Details translation from Glom's po files.
647 I have added the other strings to Glom so we can get translations that way:
648 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
650 2012-01-27 Murray Cumming <murrayc@murrayc.com>
652 TableSelectionViewImpl: Put the search label and entry in a div.
654 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
655 Put the search widgets in a FlowTable so that the CSS can be used to
656 style them while keeping them together.
657 * src/main/webapp/style.css: Mention the new div.
659 2012-01-27 Murray Cumming <murrayc@murrayc.com>
661 Translate more strings in more locales.
663 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
664 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
665 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
666 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
667 Translate the "Details" and "Open" string too.
669 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
670 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
671 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
672 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
673 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
674 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
675 Add these new locales as placeholders though they currently contain English.
677 2012-01-27 Murray Cumming <murrayc@murrayc.com>
679 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
682 Check the ConfiguredDocument* for null before using it.
684 2012-01-26 Murray Cumming <murrayc@murrayc.com>
686 Tell Eclipse about the generated java files.
688 * .classpath: This lets it find OnlineGlomConstants.java.
689 It would be nice if Eclipse just used the maven build files.
691 2012-01-26 Murray Cumming <murrayc@murrayc.com>
693 Prevent a crash when no locale is specified in the URL.
695 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
696 Avoid returning a null string, obtained from
697 Window.Location.getParameter(). This caused a crash when it was
698 later passed to libglom's API.
699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
700 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
701 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
702 guard against future null strings.
704 2012-01-26 Murray Cumming <murrayc@murrayc.com>
706 Use the ?locale= query param instead of the &lang= token param.
708 * src/main/java/org/glom/web/client/place/ListPlace.java
709 * src/main/java/org/glom/web/client/place/DetailsPlace.java
710 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
711 Remove the lang token key and value.
713 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
714 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
715 When the user selects a different locale from the chooser, use
716 Window.Location.assign() to change the URL, which then causes a reload.
718 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
719 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
720 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
721 * src/main/java/org/glom/web/client/activity/ListActivity.java
722 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
723 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
724 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
725 * src/main/java/org/glom/web/client/ui/ListView.java:
726 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
728 Remove localeID member variables and method/constructor parameters, instead
729 using Utils.getCurrentLocaleID() when we need a localID to pass to
732 2012-01-26 Murray Cumming <murrayc@murrayc.com>
734 Internationalize the UI strings.
736 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
737 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
738 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
739 because it is unused. Messages are apparently strings that can have
740 parameters, but we do not need that yet, so Contants will be enough for now.
741 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
742 to say that we support the en and de locales.
743 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
744 The original English strings.
745 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
746 Some German translations of the English strings.
747 The i18n goal then uses the .properties file to generate an
748 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
749 returns an implementation that returns the translated strings.
750 The documentation suggests putting these in src/java/*/client/, but it seems
751 best to put it in src/resources/*/client/.
752 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
753 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
754 instead of hard-coding them.
755 Note that we cannot import OnlineGlomConstants because it does not exist yet,
756 but that does not seem to stop the build, though it confuses Eclipse.
758 You can see the translated string by adding ?locale=de to the URL, like so:
759 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
761 2012-01-24 Murray Cumming <murrayc@murrayc.com>
763 Improve null/empty String checks.
765 * pom.xml: Add a dependency on commons-lang, to use
766 org.apache.commons.lang.StringUtils.
767 * src/main/java/org/glom/web/server/ConfiguredDocument.java
768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
769 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
770 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
771 Use StringUtils.isEmpty().
773 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
774 StringUtils class with a static isEmpty() function because we
775 cannot use org.apache.commons.lang.StringUtils in client-side
776 GWT code because it (apparently) cannot be compiled to javascript.
777 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
778 * src/main/java/org/glom/web/client/activity/ListActivity.java
779 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
780 * src/main/java/org/glom/web/client/place/DetailsPlace.java
781 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
782 * src/main/java/org/glom/web/client/place/ListPlace.java
783 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
784 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
785 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
786 * src/main/java/org/glom/web/client/ui/details/Group.java
787 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
788 our StringUtils.isEmpty() function.
790 2012-01-24 Murray Cumming <murrayc@murrayc.com>
792 Update to the latest java-libglom API.
794 * pom.xml: Require java-libglom 1.21.4.
795 * src/main/java/org/glom/web/server/ConfiguredDocument.java
796 getDocumentInfo(), getListViewLayoutGroup():
797 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
799 * src/main/java/org/glom/web/server/database/DBAccess.java
800 getFieldsToShowForSQLQueryAddGroup(),
801 getPrimaryKeyLayoutItemField(): Replace get_database_title()
802 with either get_database_title_original() or
803 get_database_title(localeID).
805 2012-01-24 Murray Cumming <murrayc@murrayc.com>
807 ConfiguredDocument: Avoid a null pointer exception.
809 * src/main/java/org/glom/web/server/ConfiguredDocument.java
810 Initialize localeID to "" to avoid returning a null String which
811 causes a crash in java-libglom's swing-generated code.
813 2012-01-23 Murray Cumming <murrayc@murrayc.com>
815 Some simple renaming.
817 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
818 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
819 for localeChooser. This seems more appropriate and is less ambiguous
820 particularly in the .css file.
822 2012-01-23 Murray Cumming <murrayc@murrayc.com>
824 ConfiguredDocument: Rename the localedID private member variable.
826 2012-01-23 Murray Cumming <murrayc@murrayc.com>
828 Adapt to the latest java-libglom API from git master.
830 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
831 libglom now uses only Vector instead of List, which uses add() instead of
834 2012-01-22 Murray Cumming <murrayc@murrayc.com>
836 ConfiguredDocument: Rename the localedID private member variable.
838 2012-01-20 Murray Cumming <murrayc@murrayc.com>
840 Build a source tarball with mvn assembly:single
842 * assembly.xml: Add this file.
843 * pom.xml: Use the maven-assembly-plugin and tell it to use
844 our assembly.xml file.
846 2012-01-19 Murray Cumming <murrayc@murrayc.com>
848 OnlineGlomServiceImpl: Get .glom files recursively.
850 * pom.xml: Depend on commons-io from org.apache.commons.
851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
852 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
853 files recursively, and with the easier filter for the extension.
854 Use org.apache.commons.io.FilenameUtils.removeExtension() to
855 simplify that code too.
857 2012-01-19 Murray Cumming <murrayc@murrayc.com>
859 README: Mention that you must install java-libglom packages separately.
861 But then it works, because java-libglom is now in the central maven
864 2012-01-18 Murray Cumming <murrayc@murrayc.com>
866 locales drop-down: Show the correct selected locale when the URL changes.
868 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
869 .java: setPlace(): Move some code into fillView().
871 2012-01-18 Murray Cumming <murrayc@murrayc.com>
873 locales drop-down: Do not lose the primary key.
875 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
876 start(): onLocaleChange(): Pass the current primary key value,
877 instead of an empty value.
879 2012-01-18 Murray Cumming <murrayc@murrayc.com>
881 locales drop-down: Do not lose the drop-down selection.
883 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
884 .java (TableSelectionActivity.fillView): Set the selected locale
885 after changing the drop-down items (though we do not really need
886 to change them just because the locale changes.)
888 2012-01-18 Murray Cumming <murrayc@murrayc.com>
890 locales drop-down: Change the tables list when this changes.
892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
893 .java: TableSelectionActivity.start(): Move the async table titles
894 retrieval into a private fillView() method and also call this when
895 the chosen locale changes.
896 Note that the document title is not actually translatable yet, but
897 that is a problem that I should fix soon in libglom.
899 2012-01-18 Murray Cumming <murrayc@murrayc.com>
901 Improve the placement of the locales drop-down.
903 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
904 Put the title and locales drop-down in a div (gwt.FlowTable).
905 * src/main/webapp/style.css: Add magic css properties to make this work.
906 Also remove the left margin from the title so that it lines up with the
909 2012-01-18 Murray Cumming <murrayc@murrayc.com>
911 locales selector: Show human-readable locale titles.
913 * src/main/java/org/glom/web/server/ConfiguredDocument.java
914 getDocumentInfo(): Use java.util.Locale to show a real title of
915 each locale, in the locale's own language.
917 2012-01-17 Murray Cumming <murrayc@murrayc.com>
919 Add a language/locale selector drop-down.
921 * src/main/java/org/glom/web/shared/DocumentInfo.java:
922 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
923 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
924 getDocumentInfo(): Store the available Locales in the DocumentInfo.
925 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
926 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
927 Add a ListBox to show the available locales. Add getLocaleSelector(),
928 setLocaleList(), getSelectedLocale(), setSelectedLocale().
929 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
930 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
931 java: Add these classes.
932 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
933 start(): Fill the locales ListBox. Handle its change event, firing a
935 setPlace(): Show the selected locale as specified by the URL token.
936 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
937 * src/main/java/org/glom/web/client/activity/ListActivity.java:
938 Handle LocaleChangeEvent, going to a new *Place with that locale.
940 The placement of the ListBox is not pretty, and it currently uses the ID
941 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
945 2012-01-17 Murray Cumming <murrayc@murrayc.com>
947 Search box: Show the search text from the URL token.
949 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
950 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
951 Add setQuickFindText().
952 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
953 .java: setPlace(): Store the queryText if the place is a ListPlace,
954 and call TableSelectionView.setQuickFindText().
956 2012-01-17 Murray Cumming <murrayc@murrayc.com>
958 Allow use of translations via, for instance, &lang=de in the URL.
960 * pom.xml: Use the unstable java-libglom 1.21 version.
962 * src/main/java/org/glom/web/client/OnlineGlomService.java:
963 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
965 init(): Instead of calling TranslatableItem.set_current_locale()
966 (now removed), call ConfiguredDocument.setDefaultLocaleID().
967 However, this is only for default locales, which are not needed to
968 change the locale in the URL.
969 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
970 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
971 getSortedRelatedListData(): Add a localeID parameter, so we can get the
972 layout for a particular locale.
973 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
974 Add get/setDefaultLocaleID().
975 getDocumentInfo(), getListViewData(), getRelatedListData(),
976 getDetailsLayoutGroup(), getListViewLayoutGroup(),
977 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
978 localeID parameter, so we can get the layout for a particular locale.
980 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
981 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
982 * src/main/java/org/glom/web/client/place/ListPlace.java:
983 Parse and construct a lang parameter too.
985 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
986 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
987 passed to subsequent methods and constructors.
988 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
989 * src/main/java/org/glom/web/client/activity/ListActivity.java:
990 Store the localeID from the *Place and pass it to other constructors
991 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
993 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
994 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
995 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
996 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
997 * src/main/java/org/glom/web/client/ui/ListView.java:
998 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
999 Take localeID parameters and pass them to subsequent constructors and
1000 methods, so that the layout is always retrieved for that locale.
1002 This is rather repetitive.
1004 Note that "" means the original (default) locale of the Glom document,
1005 which is usually English.
1007 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1009 Documents: Remove final keyword to fix startup configuration.
1011 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1012 final keywords on the private member variables because that breaks
1013 the startup, apparently (there are warnings) because it stops them
1014 from being serialized. I added these in the previous commit.
1016 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1018 Documents: Add some final keywords.
1020 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1023 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1025 OnlineGlomServiceImpl: Add to overview comments.
1027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1028 Note that this is where all the document are loaded. They are not
1029 loaded freshly for each page.
1031 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1035 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1036 Add a TextBox for the text of a quick find.
1037 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1039 setBackLink(): Add a String quickFind parameter.
1040 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1041 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1042 to the base interface, because that is how TableSelectionViewImpl is used.
1043 * src/main/webapp/style.css: Add style for the search box and its label.
1045 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1046 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1047 Add these files, based on the existing TableChangeEvent and
1048 TableChangeEventHandlers.
1049 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1050 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1051 a ListPlace() that the user should be taken to.
1052 * src/main/java/org/glom/web/client/activity/ListActivity.java
1053 start(): Handle it here too and adapt the TableChangeEvent handler to
1054 pass the extra "" quickFind parameter to ListPlace.
1055 * src/main/java/org/glom/web/client/place/ListPlace.java:
1056 Constructor: Take an extra String quickFind parameter and store it,
1057 returning it from a new getQuickFind() method.
1058 getToken(): Put the quickFind text in the URL token.
1059 getPlace(): Parse the quickFind text from the URL token.
1060 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1061 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1062 ListPlace constructor.
1063 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1064 .java: start(): Add a Change handler for the TableSelectionView's
1065 TextBox (via its base HasChangeHandlers interface), firing the new
1066 QuickFindChangeEvent.
1067 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1068 pass the extra "" quickFind parameter.
1070 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1071 setCellTable(): Add a String quickFind parameter and pass it to
1072 the ListViewTable() constructor.
1073 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1074 setCellTable() in the base interface, because that is how ListViewImpl
1077 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1078 Add a String quickFind member variable.
1079 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1080 Constructor: Add a String quickFind parameter, storing it in the
1081 base ListTable's member variable.
1082 onRangeChanged(): Pass quickFind to the
1083 OnlineGlomServiceAsync.getSortedListViewData() and
1084 OnlineGlomServiceAsync.getListViewData() methods.
1086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1087 getListViewData(), getSortedListViewData(): Add a String quickFind
1088 parameter, passing it to ConfiguredDocument.getListViewData().
1089 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1090 Change getListViewData(), getSortedListViewData() in the base interface,
1091 because that is how OnlineGlomServiceImpl is used, via this:
1092 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1093 Change getListViewData(), getSortedListViewData() here too.
1094 This class can apparently be used to asynchronously call methods on
1095 OnlineGlomService, and GWT seems to implement that after recognizing
1096 just the *Async name convention and the extra AsyncCallback parameters.
1098 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1099 getListViewData(): Add a String quickFind parameter, and pass it to
1100 ListViewDBAccess.getData().
1101 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1102 getListData(): Add a String quickFind parameter and pass it to
1104 getSelectQuery(): Add a String quickFind parameter.
1105 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1106 getSelectQuery(): Add a String quickFind parameter and use it with
1107 Glom.get_find_where_clause_quick() to pass a where_clause to
1108 Glom.build_sql_select_with_where_clause(), to actually filter the
1110 getData(): Add a String quickFind parameter, passing it to getListData().
1111 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1112 va: getData(): Pass an empty string to getListData() for the
1113 quickFind parameter.
1115 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1117 ListTable: Minor change.
1119 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1120 createCellTable(): Make this protected instead of public.
1122 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1124 Many files: Use final for the parameters and use the @override attribute.
1126 2012-01-22 Ben Konrath <ben@bagu.org>
1128 Add anchor links for single line text that starts with http, ftp and www.
1132 2012-01-22 Ben Konrath <ben@bagu.org>
1134 Add ellipsis to single line text in details view.
1138 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1140 Remove all javadoc author tags.
1142 Because they are awkward and meaningless when many people touch
1144 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1146 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1148 Revert the COPYING.LESSER to COPYING rename.
1150 Apparently both should be there if it is LGPL.
1152 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1154 *View: Remove unused imports.
1156 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1157 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1158 * src/main/java/org/glom/web/client/ui/ListView.java:
1159 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1160 Remove unused imports, as suggested by Eclipse.
1162 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1164 Move the *View::Presenter types, and some API into one base View.
1166 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1167 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1168 * src/main/java/org/glom/web/client/ui/ListView.java:
1169 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1170 Presenter, setPresenter() and clear() into a shared base interface,
1171 to avoid the unnecessary duplicate Presenter types and to more clearly
1172 show how the *Views share the same structure, even if they are not
1173 used polymorphically.
1175 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1176 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1178 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1179 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1180 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1182 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1185 Feel free to revert this if there is a good reason for the duplicate
1188 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1190 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1192 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1193 a class member instead of a local variable in the method.
1194 This lets us use it to get the view instances, for use in tests.
1195 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1196 beforeOnlineGlom(): Test some more details of the initial view.
1197 Again, this is not very useful.
1199 To really test gwt-glom we will need to start a local postgresql
1200 instance with local data, like the Glom tests in C++.
1202 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1204 pom.xml: Mention the LGPL license.
1206 * pom.xml: Add a licenses section.
1207 * COPYING.LESSER: Move this to COPYING, which
1208 previously contained the GPL. But gwt-glom is all LGPL.
1210 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1212 Add project information to README and pom.xml.
1214 * README: Add a brief description and mention some mvn
1216 * pom.xml: This extra information shows up in mvn site
1219 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1221 Use the latest java-libglom version.
1223 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1225 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1227 GwtTestOnlineGlom: Test a little more.
1229 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1230 protected rather than private, as suggested by the gwt-test-utils
1232 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1233 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1234 Test the initial visibility of the panels.
1236 However, this is not a very useful test.
1237 And I wonder how we should generally test using this idea for an
1238 activity/places app like ours where the real changes happen implicitly
1239 based on the history token/URL.
1241 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1243 Slight modification to *Mapper comments.
1245 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1246 (DataActivityMapper)
1247 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1249 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1251 Remove comments mentioning GIN because they are just copied from
1252 the example code and are apparently not helpful:
1253 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1254 Also change the mention of a class that is only in the example code.
1256 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1258 GwtTestOnlineGlom test: Minor changes.
1260 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1261 Avoid the long qualified class name and modify the comment
1262 because it is now obvious to me that the mocked class is the only
1263 custom one created via GWT.create().
1265 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1267 Tests: Added the beginnings of a test using gwt-test-utils.
1269 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1270 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1271 which tells gwt-test-utils what class will be tested.
1272 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1273 Add a simple (but empty) test case. One class, used by the OnlineGlom
1274 class, is mocked so that it can be created. However, I am not sure
1275 why only this class needs to be mocked.
1277 Note that mockito seems more popular, and clearer, than easymock,
1278 but I have not got that working yet. It might be a matter of the
1281 This test is run during mvn integration-test.
1283 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1285 Tests: Use junit4-style syntax instead of junit3-style.
1287 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1288 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1289 * src/test/java/org/glom/web/shared/DataItemTest.java:
1290 Use the @Test annotation rather than relying on the test*() prefix.
1291 Also no longer implement TestCase, to avoid triggering support for
1292 the junit3-way, which stops the annotations from working.
1293 Change the imports from import junit.framework.* to
1294 import org.junit.*, which is apparently the new way.
1296 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1298 Added a test for ListPlace token parsing and creation.
1300 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1301 This is much the same as DetailsPlaceTest.
1303 I wonder how we could test the other parts of the *Place API.
1305 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1307 DetailsPlace test: Also test getToken() and recreation via getPlace().
1309 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1310 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1311 recreate it, testing the recreated DetailsPlace for the same parameter
1314 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1316 Use the surefire-report plugin.
1318 * pom.xml: This generates a HTML report about the tests in
1319 target/site/surefire-report.html
1320 when you do mvn surefire-report:report. It seems to be popular/normal.
1322 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1324 Added a test for DetailsPlace.
1326 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1327 Test the getPlace() token parsing.
1329 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1331 Added a first unit test.
1333 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1334 * src/test/java/org/glom/web/shared/DataItemTest.java:
1335 This is a silly test but it is just to get things started. Note that
1336 maven/junit finds the test because it looks in src/test by default.
1338 2011-12-22 Ben Konrath <ben@bagu.org>
1340 Change charsetName to "UTF-8" when replacing line breaks.
1342 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1343 that work in Java (such as "UTF8") will not work when compiled to
1346 This fixes a problem with multi-line details view fields that have hard
1347 line breaks. The "License Text" field on this page demonstrates the
1350 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1352 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1354 2011-12-22 Ben Konrath <ben@bagu.org>
1356 Fix another bug with related list navigation.
1358 I've tested all the navigation buttons in all of the related lists
1359 so things should be good now.
1361 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1363 2011-12-22 Ben Konrath <ben@bagu.org>
1365 Fix a crasher when refreshing the list view with the default table.
1367 This crash will also happen when loading the list view with the default
1368 table from a link or bookmark.
1370 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1371 to the main document selection page when the document id hasn't been
1373 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1374 the main document selection page when the document id hasn't been
1376 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1377 values for the details place when the document id hasn't been set.
1378 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1379 values for the list place when the document id hasn't been set.
1381 2011-12-21 Ben Konrath <ben@bagu.org>
1383 Protect against NPE when glom.document.locale is not in config.
1385 This patch protects against an NPE when glom.document.locale is not in
1386 the config file. This NPE will also happen if glom.document.locale is
1389 The patch also updates the error message to display the class name when
1390 the getMessage() returns null. This was happening when the NPE was
1391 thrown and I had "Configuration Error: null". If an NPE is encountered
1392 with this patch, "Configuration Error: NullPointerException " will be
1395 This commit closes this bug:
1397 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1399 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1401 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1403 Rename onlineglom.properties to onlineglom.properties.sample.
1405 * src/main/resources/onlineglom.properties: Rename to:
1406 * src/main/resources/onlineglom.properties.sample:
1407 * src/main/resources/README: And add this file explaining that people
1408 should rename it back when deploying.
1410 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1412 Allow choosing the translation in the .properties file.
1414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1415 init(): Read a glom.document.locale value from the configuration file
1416 and call Glom's TransatableItem::set_current_locale() method.
1417 * src/main/resources/onlineglom.properties: Add a commented-out
1418 example of this new setting.
1420 It would be better to add &lang=de_DE to the URL, but the current
1421 libglom API does not allow us to do this easily. I am working on that.
1423 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1425 Avoid a crash in parsing of token parameters.
1427 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1428 ava: getTokenParams(): Do not crash if a parameter has a key but no
1429 value, and ignore parameters with neither.
1431 2011-12-17 Murray Cumming <murrayc@murayc.com>
1433 History token building/handling: Improve use of token parameters.
1435 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1436 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1437 and buildParamsToken(HashMap), for use by derived classes.
1438 Make the separator private because it is no longer be needed.
1439 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1440 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1441 instead of manual string concatenation.
1442 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1443 of hardcoded indices and awkward splitting code.
1444 * src/main/java/org/glom/web/client/place/ListPlace.java
1445 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1446 instead of manual string concatenation.
1447 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1448 of hardcoded indices and awkward splitting code.
1449 This should fix bug #666420
1451 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1453 Fix a Navgiation->Navigation typo in the code.
1455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1456 Rename processNavgiation() to processNavigation().
1458 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1460 Fix a seperator->separator typo in the code.
1462 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1463 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1464 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1467 2011-12-15 Ben Konrath <ben@bagu.org>
1469 Cleanup some comments.
1471 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1473 2011-12-14 Ben Konrath <ben@bagu.org>
1475 Replace \n with <br/> for multiline text in the details view.
1477 Vertical scrollbars are added when needed as well.
1479 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1481 2011-12-14 Ben Konrath <ben@bagu.org>
1483 Specify the font for document selection links.
1485 * src/main/webapp/style.css:
1487 2011-12-14 Ben Konrath <ben@bagu.org>
1489 Fix bouncy CellTable while paging.
1491 This doesn't currently work with related list tables in unselected
1494 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1496 2011-12-14 Ben Konrath <ben@bagu.org>
1498 Revamp the appearance of the document selection page.
1500 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1501 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1502 * src/main/webapp/style.css:
1504 2011-12-13 Ben Konrath <ben@bagu.org>
1506 Set navigation button column to the smallest size possible.
1508 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1510 2011-12-13 Ben Konrath <ben@bagu.org>
1512 Change OpenButton nomenclature to NavigationButton.
1514 Using NavigtionButton makes things more generic. Classes, methods and
1515 variables have been changed.
1517 This is a rename-only refactor.
1519 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1520 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1521 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1522 Renamed from OpenButtonCell.
1523 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1524 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1525 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1527 2011-12-12 Ben Konrath <ben@bagu.org>
1529 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1531 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1532 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1534 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1536 2011-12-12 Ben Konrath <ben@bagu.org>
1538 Update variable names and comments.
1540 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1541 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1543 2011-12-12 Ben Konrath <ben@bagu.org>
1545 Properly initialize numNonEmptyRows variable to zero.
1547 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1548 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1550 2011-12-05 Ben Konrath <ben@bagu.org>
1552 Add latest mockup with HTML tables.
1554 Features of this mockup:
1556 -> HTML table for flowtable
1557 -> HTML table for flowtable column
1558 -> Example of how related lists would look
1559 -> Not using text entries for data items
1561 The current version of Online Glom doesn't use HTML tables for the
1564 This mockup has been sent to the glom-devel mailing list but it's good
1565 to have it here as well.
1567 * mockups/details-view-html-tables.html:
1569 2011-12-05 Ben Konrath <ben@bagu.org>
1571 Remove unnecessary getPrimaryKeyField() method.
1573 getPrimaryKeyFieldForTable(String) has been renamed to
1574 getPrimaryKeyField(String).
1576 * src/main/java/org/glom/web/server/database/DBAccess.java:
1577 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1578 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1580 2011-12-05 Ben Konrath <ben@bagu.org>
1582 Add string representation of TypedDataItem value to conversion error message.
1584 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1585 message was extracted into its own method to avoid duplication.
1587 2011-12-05 Ben Konrath <ben@bagu.org>
1589 Add type checking to navigation primary key value creation.
1591 Create navigation primary key only if the expected type from the Glom
1592 document matches the type returned by the SQL query.
1594 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1596 2011-12-05 Ben Konrath <ben@bagu.org>
1598 Rename a couple of variables in RelatedListNavigation.
1600 This is a rename-only refactor.
1602 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1604 2011-12-05 Ben Konrath <ben@bagu.org>
1606 Move getListLayoutGroup() into getListViewLayoutGroup().
1608 This removes getListLayoutGroup(). It was only being called by
1609 getListViewLayoutGroup().
1611 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1613 2011-12-05 Ben Konrath <ben@bagu.org>
1615 Remove check for LayoutItem_Portal in list table method.
1617 This check is no longer necessary because the method isn't being used
1618 to create the LayoutItemPortal DTO.
1620 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1622 2011-12-05 Ben Konrath <ben@bagu.org>
1624 Properly support related list navigation.
1626 Navigation from the "Repository Analyzer -> Package Scans ->
1627 Dependencies" related table wasn't working because the primary key for
1628 related tables wasn't being set properly. This commit fixes the
1631 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1632 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1633 doesn't set the primary key properly for related list tables.
1634 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1635 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1636 useful for getting the primary key for list view tables and for related
1638 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1639 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1640 Move code to set the primary key for the table from the abstract
1641 ListDBAccess class to ListViewDBAccess as it's only correct for list
1643 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1644 Properly add primary key to related list tables.
1646 2011-12-02 Ben Konrath <ben@bagu.org>
1648 Properly set the horizontal alignment of fields.
1650 This fix is for both the list tables and the details view.
1652 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1653 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1654 to set the horizontal alignment of fields.
1656 2011-12-02 Ben Konrath <ben@bagu.org>
1658 Display currency codes in the details view.
1660 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1662 2011-12-02 Ben Konrath <ben@bagu.org>
1664 Avoid duplicate JNI call.
1666 JNI is not as efficient as pure Java and this is an easy (and small)
1669 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1670 Use previously retrieved value for whereClauseToTableName instead of
1673 2011-12-02 Ben Konrath <ben@bagu.org>
1675 Rename a couple of variables in RelatedListNavigation.
1677 This is a rename-only refactor.
1679 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1681 2011-12-02 Ben Konrath <ben@bagu.org>
1683 Indicate clearly that a mismatched primary key type is a bug.
1685 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1686 warning to error. Add 'This is a bug.' to message.
1688 2011-12-02 Ben Konrath <ben@bagu.org>
1690 Update / fix some comments.
1692 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1694 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1696 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1697 Fix comments. Add some TODOs.
1699 2011-12-02 Ben Konrath <ben@bagu.org>
1701 Enable navigation to details view with string primary key from related list.
1703 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1704 Create a text primary key value when return type of result is
1705 java.sql.Types.VARCHAR.
1707 2011-12-02 Ben Konrath <ben@bagu.org>
1709 Use checkboxes for booleans in the details view.
1711 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1713 2011-12-01 Ben Konrath <ben@bagu.org>
1715 Improve performance of related list height calculation.
1717 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1718 Put code to calculate the expected height in a static initializer so
1719 that that it's only called once.
1721 2011-12-01 Ben Konrath <ben@bagu.org>
1723 Show related list tables in notebooks (again).
1725 Calculate the height of the related list tables so the Notebook can be
1726 set the correct height. The height of the related list table is also needed by
1727 FlowTable to be able decide how to create the layout.
1729 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1730 and set the Portal height based on the height of the related list
1731 table and the Portal container.
1732 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1733 Add method to calculate the height of the related list tables.
1734 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1735 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1736 calculate the height of the Pager widget.
1738 2011-12-01 Ben Konrath <ben@bagu.org>
1740 Use CellTable API for table property instead of setting style on Element.
1742 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1744 2011-12-01 Ben Konrath <ben@bagu.org>
1746 Make ListViewTable and RelatedListTable a consistent height.
1748 The tables are now a consistent height regardless of the contents of
1749 the table. A hidden button is added to empty rows to ensure that the
1750 height of these rows will match the height of rows with data.
1752 A navigation button column is now added to every table. The width of
1753 the navigation column is set to 0px when a RelatedListTable shouldn't
1754 have navigation buttons. This maintains the a consistent row height in
1755 tables that don't show the navigation buttons.
1757 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1758 navigation column when not needed.
1759 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1760 arguments for navigation button to constructor of ListViewTable.
1761 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1762 hidden button for empty data rows.
1763 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1764 arguments for navigation button to constructor.
1765 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1766 create navigation buttons. Add hideNavigationButtons() method.
1767 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1768 arguments for navigation button to constructor.
1770 2011-12-01 Ben Konrath <ben@bagu.org>
1772 Use 'visibility: hidden' in Utils.getWidgetHeight().
1774 This is better choice because hidden elements are invisible, don't
1775 respond to events and are not part of the tab order. They will,
1776 however, take up space which is required to be able to calculate the
1777 height of the widget.
1779 * src/main/java/org/glom/web/client/Utils.java:
1781 2011-12-01 Ben Konrath <ben@bagu.org>
1783 Use Utils.getWidgetHeight() in FlowTable.
1785 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1787 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1789 2011-12-01 Ben Konrath <ben@bagu.org>
1791 Put the details css class name on the correct table column.
1793 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1795 2011-11-30 Ben Konrath <ben@bagu.org>
1797 Update for java-libglom API change.
1799 The getters and setters on FieldFormatting and NumericFormat were
1800 changed to remove the 'M'.
1802 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1804 2011-11-29 Ben Konrath <ben@bagu.org>
1806 Only allow RelatedListTables in Portals.
1808 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1810 2011-11-29 Ben Konrath <ben@bagu.org>
1812 Only create a contents panel for Portals when title is being set.
1814 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1816 2011-11-29 Ben Konrath <ben@bagu.org>
1818 Set TabLayoutPanel height based on calculated height its widgets.
1820 This is a potential fix for this bug:
1822 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1824 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1826 2011-11-29 Ben Konrath <ben@bagu.org>
1828 Align details field labels and data with the Open buttons.
1830 * src/main/webapp/style.css:
1832 2011-11-29 Ben Konrath <ben@bagu.org>
1834 Remove unnecessary <div> in the Notebook widget.
1836 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1837 method to get container FlowPanel (<div>).
1838 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1839 initWidget() method directly on the TabLayoutPanel widget instead of
1840 Group's container widget.
1842 2011-11-29 Ben Konrath <ben@bagu.org>
1844 Don't add group titles for Portals in Notebooks.
1846 This reverts the previous patch and fixes a bug I introduced with
1847 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1849 * src/main/java/org/glom/web/client/ui/details/Group.java:
1850 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1852 2011-11-28 Ben Konrath <ben@bagu.org>
1854 Remove unused boolean argument in Portal constructor.
1856 Just a code cleanup.
1858 * src/main/java/org/glom/web/client/ui/details/Group.java:
1859 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1861 2011-11-28 Ben Konrath <ben@bagu.org>
1863 Remove hack for glom 1.18 style glom files.
1865 * src/main/java/org/glom/web/client/ui/details/Group.java:
1866 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1867 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1869 2011-11-28 Ben Konrath <ben@bagu.org>
1871 Use Gda Value version of primary key to log result too large error.
1873 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1875 2011-11-28 Ben Konrath <ben@bagu.org>
1877 Don't use TypedDataItem.getText() for Unknown types from the URL.
1879 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1880 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1881 instead of getText().
1882 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1883 String field and getUnknown() method.
1885 2011-11-28 Ben Konrath <ben@bagu.org>
1887 Log an error message when the java-libglom .so is not present.
1889 The error message was being set in the exception but not logged.
1891 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1893 2011-11-28 Ben Konrath <ben@bagu.org>
1895 Ignore LayoutItem_CalendarPortals.
1897 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1898 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1900 2011-11-28 Ben Konrath <ben@bagu.org>
1902 Extract method for creating the LayoutItemPortal DTO.
1904 Just breaking the code up into smaller chunks.
1906 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1908 2011-11-28 Ben Konrath <ben@bagu.org>
1912 This should have been added with the refactor. Oops!
1914 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1916 2011-11-28 Ben Konrath <ben@bagu.org>
1918 Create primary key value from URL string using type from Glom document.
1920 See this bug, comments 19 - 25:
1922 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1924 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1925 create a TypeDataItem for the primary key here when loading from a
1926 URL. Show the same string for the primary key value as was received
1927 from the URL string (when loading from a URL).
1928 * src/main/java/org/glom/web/server/Utils.java: Update method for
1929 creating the Gda Value from the TypeDataItem to properly deal with
1930 creating a Gda Value based on the Glom document type for the primary
1931 key value string when loading from a URL.
1932 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1933 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1934 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1935 Update for changed method name.
1937 2011-11-27 Ben Konrath <ben@bagu.org>
1939 Rename PrimaryKeyItem to TypedDataItem.
1941 The name PrimaryKeyItem suggests what the class should be used for.
1942 TypedDataItem is a neutral name that describes the class better.
1944 This is a rename-only refactor.
1946 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1947 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1948 * src/main/java/org/glom/web/client/Utils.java:
1949 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1950 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1951 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1952 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1953 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1954 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1955 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1956 * src/main/java/org/glom/web/server/Utils.java:
1957 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1958 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1959 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1960 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1962 2011-11-25 Ben Konrath <ben@bagu.org>
1964 Improve Gda Value conversion from PrimaryKeyItem.
1966 The value from the PrimaryKeyItem is only used if its type match the
1967 type from the glom document.
1969 * src/main/java/org/glom/web/server/Utils.java:
1971 2011-11-25 Ben Konrath <ben@bagu.org>
1973 Manually check if the java-liblgom .so is visible to the JVM.
1975 It seems that Tomcat has problems when a static initializer throws an
1976 exception. This check is done before the first method call into
1977 java-libglom so that execution doesn't continue if the .so is not
1980 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1982 2011-11-25 Ben Konrath <ben@bagu.org>
1984 Improve browser configuration error messages.
1988 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1990 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1991 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1992 getConfigurationErrorMessage() method.
1993 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1994 Get and display a specific configuration error message when no Glom
1995 documents are found.
1996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1997 Implement getConfigurationErrorMessage() method. Surround configuration
1998 code in the init() method with a try/catch block. This allows the
1999 errors to be caught while keeping the servlet available to retrieve the
2000 configuration error message.
2002 2011-11-25 Ben Konrath <ben@bagu.org>
2004 Don't use Strings to hold primary key values.
2006 The primary key values are now held in a new data object
2007 (PrimaryKeyItem) that holds type information and the primary key value
2008 using the correct type.
2010 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2011 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2013 PrimaryKeyItem instead of String to hold the primary key value.
2014 * src/main/java/org/glom/web/client/Utils.java: Remove
2015 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2016 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2017 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2018 PrimaryKeyItem instead of String to hold the primary key value. Load
2019 document selection page when the documentID has not been set correctly.
2020 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2021 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2023 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2024 Return empty string for URL instead of "null".
2025 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2026 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2027 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2028 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2029 PrimaryKeyItem instead of String to hold primary key values.
2030 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2031 PrimaryKeyValue to a Gda Value.
2032 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2033 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2034 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2035 Replace temporary database access code that uses the PrimaryKeyValue to
2036 Gda Value conversion.
2037 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2038 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2039 PrimaryKeyItem instead of String.
2040 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2041 hold primary key values.
2043 2011-11-24 Ben Konrath <ben@bagu.org>
2045 Use newly added java-libglom API to create queries.
2047 This isn't finished. I still need to stop using Strings for primary key
2048 values in the client code.
2050 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2051 libglom to use fake connections so that retrieving the query string will
2053 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2054 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2055 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2056 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2057 Use the newly added libglom sql methods and classes to create the
2058 query. Add temporary hack to convert primary value strings to Gda
2061 2011-11-23 Ben Konrath <ben@bagu.org>
2063 Don't explicitly set the height of Portals.
2065 See comments 6 - 10 of this bug for details:
2067 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2069 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2071 2011-11-23 Ben Konrath <ben@bagu.org>
2073 Use an HTML table instead of CSS for the FlowTable layout.
2075 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2076 GWT's FlexTable to implement the FlowTable.
2077 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2079 2011-11-18 Ben Konrath <ben@bagu.org>
2081 Add boolean example to HTML table mockup.
2083 * mockups/details-view-html-tables-text-entries.html:
2085 2011-11-17 Ben Konrath <ben@bagu.org>
2087 Ensure the pager buttons are always visible for related lists.
2089 To accomplish this, I've turned off text wrapping in the list view and
2090 related list tables for both the header and data text. The related list
2091 table now has a fixed layout so the it doesn't overflow its container.
2092 This is required to ensure that the cell text is clipped when it
2093 overflows the cell and an ellipsis is added to the right side of the
2094 cell when text is clipped.
2096 A fixed table layout for the related list table in the details view
2097 seems what we want for the details view anyway, so the side-effect is
2100 The ellipsis will only be displayed in Firefox >= 7.
2104 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2106 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2107 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2108 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2110 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2111 Set the 'table-layout: fixed' CSS property to the related list table.
2112 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2113 'white-space: nowrap;' CSS property on both the list view and the
2114 related list tables.
2116 2011-11-16 Ben Konrath <ben@bagu.org>
2118 Rework the fix for empty notebook tab labels.
2120 Setting the empty group titles with its name caused problems for the
2121 details layout. Instead of using libglom's
2122 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2123 to the client when the title is empty. This allows the Notebook to use
2124 the name when the title is empty without affecting anything else.
2126 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2127 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2129 2011-11-16 Ben Konrath <ben@bagu.org>
2131 Set group titles with name when title is empty.
2133 This fixes a problem with an empty notebook tab label in the Lesson
2134 Planner document. The forth tab in the notebook should be "Internet":
2136 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2138 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2139 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2142 2011-11-16 Ben Konrath <ben@bagu.org>
2144 Remove whitespace from the configured username properties.
2146 This assumes that usernames won't have whitespace at the beginning
2147 or end. But I think this is a reasonable assumption.
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2150 String.trim() to remove the whitespace from the username properties.
2152 2011-11-15 Ben Konrath <ben@bagu.org>
2154 Add details view mockup with HTML tables and text entries.
2156 This is from the attachment on this bug:
2158 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2160 * mockups/details-view-html-tables-text-entries.html:
2162 2011-11-15 Ben Konrath <ben@bagu.org>
2164 Add space between the columns of the flow table.
2168 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2170 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2171 space between columns in the flow table.
2173 2011-11-15 Ben Konrath <ben@bagu.org>
2175 Add backup files to the .gitignore.
2177 * .gitignore: Ignore files that end with ~.
2179 2011-11-09 Ben Konrath <ben@bagu.org>
2181 Use latest release of gwt-log.
2183 Gwt-log releases are now being submitted to the maven central
2184 repository so manual installation of the jar is no longer required.
2186 * pom.xml: Update version and groupId of gwt-log dependency.
2188 2011-10-31 Ben Konrath <ben@bagu.org>
2190 Don't use GWT numeric formatting to override the glom currency formatting.
2192 Currencies are now displayed like they are in Glom. See this bug:
2194 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2196 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2198 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2199 currency code to constructor and set it when the cell is rendered.
2200 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2201 currency code to the constructor of the NumericCell.
2203 2011-10-27 Ben Konrath <ben@bagu.org>
2205 Require the latest release of java-libglom (1.17.4).
2209 2011-10-26 Ben Konrath <ben@bagu.org>
2211 Add style to Notebook that matches current theme.
2213 It's not the best style in the world but it's better than the default.
2215 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2216 padding at the bottom of the child widgets.
2217 * src/main/webapp/style.css: Add style for the Notebook.
2219 2011-10-26 Ben Konrath <ben@bagu.org>
2221 Move servlet initialization code to overridden init method.
2223 This is half of the solution to getting proper error messages
2224 displayed when configuration errors occur. Here's the relevant bug:
2226 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2228 The rest of the solution involves surrounding the init method with a
2229 try/catch block and setting a global variable with the error /
2230 exception. A new async method should be created to retrieve and display
2231 the error message / exception.
2233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2234 code from constructor to init method adding exceptions as needed.
2236 2011-10-26 Ben Konrath <ben@bagu.org>
2238 Add script to monitor and restart tomcat if required.
2240 * utils/check-and-recover-tomcat.py: New file.
2242 2011-10-26 Ben Konrath <ben@bagu.org>
2244 Display the correct number of data items in the pager.
2248 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2250 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2251 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2252 The implementation is the same for both tables: Keep track of the
2253 number of non-empty rows and fire and RowCountChangeEvent after the data has
2255 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2256 custom Pager class that subclasses SimplePager to handle displaying
2257 the correct number when empty rows have been added.
2259 2011-10-26 Ben Konrath <ben@bagu.org>
2261 Correct error in previous commit.
2263 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2264 eventBus parameter from listView.setCellTable().
2266 2011-10-26 Ben Konrath <ben@bagu.org>
2268 Fix error in TODO comment.
2270 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2272 2011-10-24 Ben Konrath <ben@bagu.org>
2274 Create Notebook widgets to the details view.
2276 This isn't finished just yet - I still need to create a reasonable
2277 style to match the current theme.
2279 * src/main/java/org/glom/web/client/Utils.java: Add method for
2280 calculating the height of a widget. This is used in the Notebook class.
2281 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2282 new constructor method in Group.
2283 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2284 method for creating child widget that can be used by subclasses
2285 like Notebook. New constructor that allows disabling the group
2286 titles - Notebooks don't set a group title for their child groups.
2287 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2288 to make Notebooks using GWT's TabLayoutPanel.
2289 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2290 constructor that allows disabling the group titles.
2291 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2292 LayoutItemNotebook DTO.
2293 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2294 DTO for Notebooks. It's just an empty class for now but we might need
2295 it to transfer some specific information in the future.
2297 2011-10-21 Ben Konrath <ben@bagu.org>
2299 Add navigation buttons to related list tables.
2301 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2302 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2303 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2304 method getSuitableRecordToViewDetails() for getting the table name
2305 and primary key value for related list navigation buttons.
2306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2307 private cell renderer class to get the navigation information for
2308 related list tables from the server. Extract the navigation
2309 processing code from the details cell navigation and use it for the
2310 related list navigation as well.
2311 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2312 cell renderer class for the details open buttons. This was needed
2313 because the related list navigation buttons and the list view
2314 navigation buttons need to react differently when clicked.
2315 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2316 the onEnterKeyDown() method because it's now overriden in the
2317 subclasses that are specific to the related list tables and the list
2319 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2320 the vertical size a little because the buttons add a bit of vertical
2321 space to table. This is not a perfect solution because the vertical
2322 size of with table fewer than 5 rows will be a little smaller.
2323 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2324 changes in how navigation buttons are handled.
2325 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2326 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2327 database access object.
2328 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2329 to find the portal for a given relationship name from
2330 RelatedListDBAccess. Add method to find a primary key field for a
2332 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2333 Move code to find the portal for a given relationship name to
2335 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2336 New file: database access object for getting the related list
2337 navigation information (the table name and the primary key value).
2338 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2339 DTO for transferring a table name to navigate to and a primary key
2341 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2342 boolean and getter/setter to specifies if the related list should add
2345 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2347 Use the master branch of java-libglom
2349 * pom.xml: Depend on java-libglom 1.19 instead.
2351 This is the master branch. See also the libglom-1-18 branch.
2353 2011-10-11 Ben Konrath <ben@bagu.org>
2355 Enable the open navigation button when the data has been set.
2357 This avoids having active buttons that don't do anything when the data
2360 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2362 2011-10-11 Ben Konrath <ben@bagu.org>
2364 Use IsWidget interface for FlowTableItem.
2366 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2367 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2369 2011-10-11 Ben Konrath <ben@bagu.org>
2371 Remove GWT styling from open button in details view.
2373 There are still some issues with how the details cell is arranged but
2374 this should be made to match Glom 1.20. I'm going to leave fixing this
2375 until I have Glom 1.20 up and running.
2377 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2378 style name on open button.
2379 * src/main/webapp/style.css: Move and edit details-navigation class.
2380 Re-arrange some classes to make them appear in the same order as the
2383 2011-10-07 Ben Konrath <ben@bagu.org>
2385 Update to GWT 2.4.0.
2387 * .gitignore: Ignore new cache directory.
2388 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2389 * pom.xml: Change GWT and maven plugin to 2.4.0.
2390 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2392 * src/main/java/org/glom/web/client/ClientFactory.java:
2393 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2394 * src/main/java/org/glom/web/client/OnlineGlom.java:
2395 Update source for API changes.
2396 * utils/build-onlineglom-war.sh: Remove cache directory before the
2399 2011-10-07 Ben Konrath <ben@bagu.org>
2401 Add navigation buttons in the details view.
2403 This isn't finished but I thought I'd commit what I have as it's a
2404 pretty good start. I still need to:
2406 1. Change the style so that it fits better into the current theme
2407 2. Adjust the details cell to expand as much as possible.
2409 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2410 click handlers to navigation buttons in the DetailsCells. Create a
2411 refreshData() method to get just the data from the server without the
2413 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2414 Update the tableSelector and browser title when the table name
2415 changes without using the tableSelector.
2416 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2417 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2418 getDetailsCells() to getCells(). Update variable names.
2419 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2420 method to set click handler on navigation button. Rename a few
2421 variables. Add navigation buttons where needed.
2422 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2423 variables and methods.
2424 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2425 navigation boolean and navigation table as required in the
2426 LayoutItemField DTO.
2427 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2428 variables for navigation along with getter/setter methods.
2430 2011-10-07 Ben Konrath <ben@bagu.org>
2432 Rename Field to DetailsCell.
2434 This is a refactor-only commit. No functionality has been added or
2437 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2438 Update variable and method names.
2439 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2440 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2441 variable and method names.
2442 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2444 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2445 variable and method names.
2447 2011-10-07 Ben Konrath <ben@bagu.org>
2449 Create separate methods for layout and data the details view.
2451 This is a refactor-only commit. No functionality has been added or
2454 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2455 private methods: setData(), createLayout().
2457 2011-10-07 Ben Konrath <ben@bagu.org>
2459 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2461 This is part of a change to get navigation buttons in the details view
2462 but it should have been done this way from the start.
2464 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2465 for method name change in TableSelectionView.
2466 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2467 Create TableChangeEvent and set the browser title using the
2468 TableSelectionView API.
2469 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2470 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2471 Change getSelectedTable() to getSelectedTableName(). Add
2472 getSelectedTableTitle().
2474 2011-10-07 Ben Konrath <ben@bagu.org>
2476 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2478 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2480 2011-10-07 Ben Konrath <ben@bagu.org>
2482 Update TableChangeEvent to use newTableName naming convention.
2484 This makes the class more consistent with GWT naming conventions.
2486 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2487 Update for method name change in TableChangeEvent.
2488 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2489 for method name change in TableChangeEvent.
2490 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2491 newTableName variable and getter method. Make toDebugString()
2494 2011-09-30 Ben Konrath <ben@bagu.org>
2496 Disable the pager in the list tables when the data row count is less than the minimum.
2498 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2499 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2501 2011-09-30 Ben Konrath <ben@bagu.org>
2503 Add empty rows to the end of related list and list view tables.
2505 I also extracted the cell rendering classes from the ListTable because
2506 the code was becoming a little crazy with all the anonymous inner
2507 classes. My plan is to use these cell rendering classes in the details
2508 view as well so this refactor will be needed for that change.
2510 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2511 set the row count in related list tables if the data has more rows
2512 than the minimum number of rows visible.
2513 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2514 row count in list view tables if the data has more rows than the
2515 minimum number of rows visible.
2516 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2517 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2519 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2520 for rendering TYPE_NUMERIC cells. The code was extracted from the
2522 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2523 class for rendering cells with buttons in list views. The code was
2524 extracted from the ListTable class.
2525 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2526 for rendering TYPE_TEXT cells. The code was extracted from the
2528 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2529 Add empty rows to the end of the data if required. Implement
2530 ListTable.getMinNumVisibleRows().
2531 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2532 cell renderer code to public classes. Return null in
2533 Column.getValue() for empty rows. Add new abstract method:
2534 getMinNumVisibleRows(). Move code to set the row count of the list view
2535 table to ListViewImpl.
2536 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2537 empty rows to the end of the data if required. Implement
2538 ListTable.getMinNumVisibleRows().
2541 2011-09-27 Ben Konrath <ben@bagu.org>
2543 Use GWT.log for client-side debugging statements.
2545 These are optimized out when deployed so I should have used this method
2546 in the first place. These statements will eventually be replaced with some sort
2547 of notification in the browser.
2549 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2550 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2552 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2553 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2555 2011-09-27 Ben Konrath <ben@bagu.org>
2557 Put tableselector on the right, back to list link on right.
2559 The idea is that the table selector is acting like a label for the
2560 currently displayed table so it should be placed below the document title. This
2561 puts the table title in a similar position to where it is in Glom.
2563 * mockups/details-contacts.html:
2564 * mockups/details-projects.html:
2565 * mockups/listview-contacts.html:
2566 * mockups/listview-projects.html:
2567 * mockups/style.css:
2568 Update mockups to match how the interfaces currently look.
2569 * src/main/webapp/style.css: Swap positions of backlink with the table
2570 selector. Add some space on the left side of the table selector to
2571 line things up with the document title.
2573 2011-09-27 Ben Konrath <ben@bagu.org>
2575 Add field colouring to details view.
2577 This change re-works how field colouring works. The colour formatting
2578 information is now set to the client with the layout information instead of
2579 with the data. This eliminates the need to send the same colour strings for
2580 data in list view column when colour information is set.
2582 In order to set an alternate colour for negative numeric values, the
2583 number is now sent to client and formatted with the GWT NumberFormat class.
2585 This change also fixes:
2587 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2589 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2590 internationalization framework which is needed for client side numeric
2592 * src/main/java/org/glom/web/client/Utils.java: New file for some
2593 client static utility methods.
2594 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2595 the DataItem object to the Field class. Use a utility method to
2596 create the foreignKeyValue string.
2597 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2598 alignment and text colours in the constructor. Add setData(DataItem)
2599 method. Remove setText(String) method.
2600 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2601 colour information to GlomTextCell. Create and use GlomNumberCell for
2602 rendering numbers. Use utility method to get the string for the
2603 primary key of the key provider. Re-work how the horizontal alignment
2605 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2606 formatting to layout information. Methods for converting the libglom
2607 formatting information were moved from DBAccess.
2608 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2609 numeric formatting (it's now done on the client side). Don't set text
2610 colours in DataItem. Move libglom formatting conversion methods to
2612 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2613 getters/setters for text colour information.
2614 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2615 for transferring the libglom NumericFormat information to the client.
2616 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2617 and getters/setters for: GlomNumericFormat, background colour and
2618 foreground colour strings.
2620 2011-09-26 Ben Konrath <ben@bagu.org>
2622 Simplify code that iterates through the LayoutGroup.
2624 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2626 2011-09-26 Ben Konrath <ben@bagu.org>
2628 Accept Eclipse formatting for OnlineGlomServiceAsync.
2630 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2632 2011-09-26 Ben Konrath <ben@bagu.org>
2634 Don't use the ListDBAccess classes to get the primary key layout information.
2636 This was causing a bug where the wrong index for the hidden primary key
2637 was being sent to the client.
2639 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2640 primary key while creating the LayoutGroup DTO. Create a
2641 LayoutItemField DTO for hidden primary keys. Don't use the
2642 RelatedListDBAccess because it was only used for getting the primary
2644 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2645 access modifier from public to protected for getPrimaryKeyField() and
2646 getPrimaryKeyLayoutItemField().
2647 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2648 abstract method getExpectedResultSize() because RelatedListDBAccess
2649 doesn't have enough info to implement it.
2650 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2651 Remove @Override for getExpectedResultSize().
2652 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2653 Remove method getExpectedResultSize().
2655 2011-09-23 Ben Konrath <ben@bagu.org>
2657 Log which layout (list or details) the ignored item is from.
2659 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2661 2011-09-23 Ben Konrath <ben@bagu.org>
2663 Remove annotations that turn off code formatting in DataItem.
2665 * src/main/java/org/glom/web/shared/DataItem.java:
2667 2011-09-23 Ben Konrath <ben@bagu.org>
2669 Rename GlomField to DataItem and update associated methods.
2671 This is a rename-only refactor. No functionality has been added or
2674 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2675 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2676 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2677 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2678 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2679 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2680 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2681 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2683 * src/main/java/org/glom/web/server/database/DBAccess.java:
2684 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2685 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2686 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2687 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2688 * src/main/java/org/glom/web/shared/DataItem.java:
2689 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2690 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2692 2011-09-23 Ben Konrath <ben@bagu.org>
2694 Rename GlomDocument to DocumentInfo and update associated methods.
2696 This is a rename-only refactor. No functionality has been added or
2699 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2700 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2701 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2702 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2703 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2705 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2707 2011-09-20 Ben Konrath <ben@bagu.org>
2709 Require java-libglom 1.17.3.
2711 This picks up the fix for the seg fault problem with the Scenes table
2712 in the Openismus Film Manager example.
2716 2011-09-20 Ben Konrath <ben@bagu.org>
2718 Change the way sort clause is added for primary key when no sort clause is requested.
2720 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2721 before the sort clause is created. When a sort clause is not requested, the
2722 sort clause is created by finding the primary key in the LayoutFieldVector
2725 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2727 2011-09-20 Ben Konrath <ben@bagu.org>
2729 Log error message if no documents are found in the configured directory.
2731 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2732 Extract the glom file extension string to a private static final class
2733 variable (mostly as syntactic sugar). Accept a minor formatting change.
2734 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2735 the example glom.document.directory configuration property to make it
2736 more clear that it can any directory, not just the home directory.
2738 2011-09-18 Ben Konrath <ben@bagu.org>
2740 Add related lists to details view.
2742 The related list table has support for paging and sorting just like the
2743 table in the list view.
2745 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2746 SQL queries for the related list tables.
2747 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2748 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2749 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2750 Rename getList methods to getListView and add comments. Remove
2751 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2752 it being unused. Add methods: getDetailsLayoutAndData(),
2753 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2754 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2755 Create the layout and set the data for the fields in one async call
2756 instead of two. Create related lists where appropriate.
2757 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2758 for method name changes in OnlineGlomService.
2759 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2760 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2761 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2763 * src/main/java/org/glom/web/client/ui/ListView.java:
2764 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2765 tableName from setCellTable(). Create a ListViewTable instead of
2767 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2768 represent a data field in the details view.
2769 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2770 from addDetailsCell() to Field class. Keep track of the Fields and
2771 Portals in the details view.
2772 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2773 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2774 and add a method to get it. Add method to set the contents of the
2776 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2777 New class for related list tables. This class has the data provider
2778 for the related list table.
2779 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2780 abstract class which is the base class for the ListViewTable and the
2782 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2783 New class for list view tables. This class has the data provider for
2784 the list view table.
2785 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2786 methods for related list tables. Add more information to the
2787 LayoutItemField and LayoutItemPortal DTOs.
2788 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2789 Remove debugging print statement.
2790 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2791 Remove debugging print statements. Add primary key field to SQL count
2793 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2794 Remove unnecessary LayoutFieldVector parameter from
2795 getResultSizeOfSQLQuery() method.
2796 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2797 New class for related list table database access.
2798 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2799 class that is a wrapper DTO for details view layout and data.
2800 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2801 new 'fromField' string to this DTO.
2802 * src/main/webapp/style.css: Remove bottom margin and override top
2805 2011-09-15 Ben Konrath <ben@bagu.org>
2807 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2809 This sets things up to make it easier to add the data retrieval for
2810 related lists (portals). No user noticeable changes were made with
2813 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2814 class has the code to retrieve the layouts and access the
2815 database using the new database helper classes.
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2817 Most of the functionality has been removed from this class. This
2818 class now represents the public interface for the client side
2819 code. It also deals with configuring the servlet and cleaning
2820 things up when the servlet is stopped.
2821 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2822 of static methods into this utility class.
2823 * src/main/java/org/glom/web/server/database/DBAccess.java:
2824 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2825 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2826 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2827 These classes have the database retrieval code. The class hierarchy
2828 has been setup to make it easy to reuse code for similar
2831 2011-09-06 Ben Konrath <ben@bagu.org>
2833 Create separate classes for list table code and the data provider.
2835 As part of this refactor, I also split up the code a bit to make it
2838 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2839 table code to two new classes (below).
2840 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2841 with code from ListViewImpl.
2842 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2843 New file with code from ListViewImpl.
2845 2011-09-06 Ben Konrath <ben@bagu.org>
2847 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2849 This fixes the LayoutItemPortal DTO to match the libglom layout object
2852 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2854 2011-09-01 Ben Konrath <ben@bagu.org>
2856 Set title of Portals in the Details View.
2858 * pom.xml: Bump required version of java-libglom to 1.17.1.
2859 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2860 widget creation to its own class. Add comments to constructor.
2861 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2862 The code is mostly from the Group class with the title now set.
2863 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2864 title of Portal. Update some comments. Fix some code formatting.
2866 2011-09-01 Ben Konrath <ben@bagu.org>
2868 Remove TODO comment for the flow table column width.
2870 The flow table column width is working correctly and doesn't need to be
2871 changed. See this mailing list post for more info:
2873 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2875 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2877 2011-08-27 Ben Konrath <ben@bagu.org>
2879 Add document title (database name) to top of the browser page.
2881 I added the document title to the TableSelecitonView but that will
2882 change if / when we add a view that doesn't require table selection.
2884 * mockups/details-contacts.html:
2885 * mockups/details-projects.html:
2886 * mockups/listview-contacts.html:
2887 * mockups/listview-projects.html:
2888 * mockups/style.css: Add document title to mockups to keep things
2890 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2891 sizes to account for the document title.
2892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2893 Set the document title when it has been retrieved from the server.
2894 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2895 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2896 and implement setDocumentTitle(String) method.
2897 * src/main/webapp/style.css: Add ID for document title style.
2899 2011-08-25 Ben Konrath <ben@bagu.org>
2901 Add NavigationType enum to LayoutItemPortal DTO.
2903 This is the start of adding support for Portals to the Details View.
2905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2906 LayoutItem_Portal.navigation_type enum from libglom to
2907 LayoutItemPortal.NavigationType enum.
2908 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2909 NavigationType enum, field for storing the NavigationType and getter
2912 2011-08-25 Ben Konrath <ben@bagu.org>
2914 Implement the flow table layout in the Details View.
2916 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2917 FlowTable to Group to account for the renamed class.
2918 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2919 File. This is a container widget that implements the Glom details view
2920 flow table behaviour.
2921 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2922 org/glom/web/client/ui/FlowTable.java.
2923 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2924 so that the size of the subgroups are a closer match to the size of
2925 the Glom subgroups. This makes the flowtable layout match the layout
2926 in Glom for the Music Collection example file.
2928 2011-08-16 Ben Konrath <ben@bagu.org>
2930 Create container element for LayoutItemPortal in Details View.
2932 This will help me develop the layout for the FlowTable.
2934 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2935 fieldPanel variable to detailsCell.
2937 2011-08-15 Ben Konrath <ben@bagu.org>
2939 Set the height of the data element in the Details View.
2941 I changed the InlineLabels (text in a span element) to Labels (text in
2942 a div element) so that I could set the height of the details-data
2943 elements instead of the details-cell parent elements. This allows the
2944 the details-data element to display the correct height if style is
2945 applied that shows the height.
2947 This change has the added benefit of allowing the order of the labels
2948 and data elements to be changed for right-to-left languages.
2950 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2951 InlineLabels to Labels.
2952 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2953 InlineLabels to Labels. Set the height of the data element.
2954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2955 multiline text height in the Formatting DTO.
2956 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2957 for multiline height along with getter and setter methods.
2958 * src/main/webapp/style.css: Adjust style to account for the change
2959 from span elements to div elements in the details cell.
2961 2011-08-15 Ben Konrath <ben@bagu.org>
2963 Make the List View appearance match the mockups.
2965 It doesn't match exactly but it's much better than it was.
2967 * mockups/listview-contacts.html: Remove unused css classes.
2968 * mockups/listview-projects.html: Remove unused css classes.
2969 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2970 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2971 for mainPanel instead of VerticalPanel (table). Set style name on
2972 CellTable. Set style name on Details column. Right-align Details
2974 * src/main/webapp/style.css: Adjust properties to match the mockups.
2976 2011-08-12 Ben Konrath <ben@bagu.org>
2978 Add better support for subgroups in the details view.
2980 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2981 changed FlowTable constructor.
2982 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2983 support for subgroups and subgroup-titles.
2984 * src/main/webapp/style.css: Add CSS class for subgroups and
2987 2011-08-12 Ben Konrath <ben@bagu.org>
2989 Return the top level LayoutGroup title.
2991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2993 2011-08-11 Ben Konrath <ben@bagu.org>
2995 Make the TableSelector header match the mockup.
2997 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2998 the layout panel. Properly lineup the table selection header with
2999 the list and details view.
3000 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3001 margin around the details view.
3002 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3003 Rename listBox variable to tableSelector. Set id for the style sheet.
3004 Use a FlowPanel instead of a HorizontalPanel.
3005 * src/main/webapp/style.css: Add properties to make the TableSelector
3006 box match the mockups.
3008 2011-07-13 Ben Konrath <ben@bagu.org>
3010 Update install script for java-libglom version change.
3012 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3015 2011-07-13 Ben Konrath <ben@bagu.org>
3017 Add support sub-group in the details view.
3019 I also removed the code that special-cased the default details view
3022 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3024 I still have to make a proper flowtable.
3026 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3027 Don't special-case default details view layout.
3028 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3029 addLayoutField() as I'm going to use it.
3030 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3031 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3033 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3034 extracted from DetailsViewImpl.GroupPanel. Add support for
3036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3037 column count when getting the details layout.
3039 2011-07-12 Ben Konrath <ben@bagu.org>
3041 Set browser title with database and table titles.
3043 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3044 Set the browser title when the table changes and when the activity
3046 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3047 title when retrieving document info (the GlomDocument object).
3048 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3049 with getter and setter methods. Remove unused convenience constructor.
3050 Use default code formatting.
3052 2011-07-12 Ben Konrath <ben@bagu.org>
3054 Ignore LayoutItemPortals in the details view.
3056 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3059 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3060 LayoutItemPortal layout objects.
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3062 LayoutItemPortal objects when retrieving the details layout.
3063 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3064 file. This is an empty class and just used to get type information for
3067 2011-07-12 Ben Konrath <ben@bagu.org>
3069 Use java-libglom 1.17.0.
3073 2011-07-11 Ben Konrath <ben@bagu.org>
3075 Remove "Table:" label from table selector.
3077 This matches a recent change in the Glom UI.
3079 * mockups/details-contacts.html:
3080 * mockups/details-projects.html:
3081 * mockups/listview-contacts.html:
3082 * mockups/listview-projects.html: Remove the "Table:" label from the
3084 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3086 2011-07-11 Ben Konrath <ben@bagu.org>
3088 Add main groups to the details view.
3090 This makes things look a little nicer in the details view. The next step
3091 is to implement the flowtable.
3093 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3094 resources from the standard gwt css theme. Standard.css is now
3095 included in OnlineGlom.html so that the online glom css rules have
3096 precedence over the gwt theme.
3097 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3098 the whole LayoutGroup to the DetailsView instead of just the titles.
3099 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3100 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3101 details layout with a helper class (GroupPanel). I might extract this
3102 class when I make the full flowtable.
3103 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3104 string as default so I don't have to worry about NPEs when processing
3106 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3107 note beside OnlineGlom.gwt.xml above).
3108 * src/main/webapp/style.css: Add default font-size to body to override
3109 the font-size set by the standard theme. Don't use h2 tags for
3110 group-title. Create new details-cell class.
3112 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3114 ConfiguredDocument: Set the port number too.
3116 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3117 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3118 Glom document. Presumably this worked sometimes so far because there is a
3119 default port number.
3121 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3123 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3125 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3126 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3127 correct, though we should throw an exception too.
3129 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3131 Fix a addDocuemnt typo.
3133 * src/main/java/org/glom/web/shared/Documents.java
3134 (Documents.addDocuemnt): Rename to addDocument().
3135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3136 (OnlineGlomServiceImpl.getDocuments): Adapt.
3138 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3140 Slightly improved log output when connection fails.
3142 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3143 (ConfiguredDocument.setUsernameAndPassword):
3144 We don't know for sure if it' the username/password that's wrong, so
3145 rephrase the message.
3146 Also ouput the exception message, though it's generic in this case.
3148 2011-07-08 Ben Konrath <ben@bagu.org>
3152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3153 added braces to a one line if statement because the Eclipse formatter
3154 was getting confused.
3156 2011-07-07 Ben Konrath <ben@bagu.org>
3158 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3160 These should really be two separate tasks but I counldn't get things to
3161 work with GWT 2.2.0 and Eclipse 3.7.
3165 * .settings/org.eclipse.jdt.core.prefs:
3166 * .settings/org.eclipse.jdt.ui.prefs:
3167 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3168 * .settings/org.eclipse.m2e.core.prefs:
3169 Add new config files. Update current files. Remove references to the
3170 webtools plugins as we're not using any of the webtools features.
3171 * .gitignore: Add logs directory which is created when running with
3173 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3174 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3175 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3177 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3179 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3181 onlineglom.properties: Add explanatory comments.
3183 * src/main/resources/onlineglom.properties: Also change the default user
3184 from ben to someuser, to avoid the risk of people thinking we just
3185 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3187 2011-06-28 Ben Konrath <ben@bagu.org>
3189 Use filename in Log for incorrect passwords.
3191 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3192 getFileName(String) method to get the filename from the URI.
3194 2011-06-28 Ben Konrath <ben@bagu.org>
3196 Add the table name to the URL token for the ListPlace.
3198 This makes things consistent between the DetailsPlace and the
3199 ListPlace. It also allows the the ListPlace to be bookmarked.
3201 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3202 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3204 Remove getDefaultListLayout(). The default layout is now returned
3205 by the getListLayout() method when the table name is an empty string.
3206 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3207 Add table name field. Change to a new ListPlace when the table
3208 has been changed. Use getListLayout() for getting the default
3210 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3211 Add table name field. Set the correct table name in the list box
3212 when loading from bookmark. This corrects a problem for the
3214 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3215 Move table name to super-class (HasSelectableTable). Move document
3216 and table URL keys to super-class in HasSelectableTable.
3217 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3218 Add table name field. Add Tokenizer class with URL key common to
3219 the subclasses (DetailsPlace and ListPlace).
3220 * src/main/java/org/glom/web/client/place/ListPlace.java:
3221 Add table name. Add code to parse the URL token.
3222 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3223 Update ListPlace construction with empty table name string.
3224 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3225 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3226 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3227 Update ListPlace construction with table name string.
3228 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3229 Change defaultTableName field to tableName to reflect how it's now
3230 used. Update the getter and setter methods.
3232 2011-06-28 Ben Konrath <ben@bagu.org>
3234 Enable the table selector in the DetailsView.
3236 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3237 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3239 Remove getDefaultDetailsLayout(). The default layout is now returned
3240 by the getDetailsLayout() method when the table name is an empty
3242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3243 event handler for table change event. Change to using
3244 getDetailsLayout() for the default details layout.
3245 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3247 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3248 when navigating to the details place.
3250 2011-06-27 Ben Konrath <b