1 2012-01-30 Murray Cumming <murrayc@murrayc.com>
3 Translations: Try to translate the strings.
5 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
6 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
7 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
8 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
9 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
10 Take the Open translation from GTK+'s .po files.
11 Take the Details translation from Glom's po files.
12 I have added the other strings to Glom so we can get translations that way:
13 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
15 2012-01-27 Murray Cumming <murrayc@murrayc.com>
17 Add a (empty) Report Place, View, and Activity.
19 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
21 * src/main/java/org/glom/web/client/place/HasTablePlace.java
22 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
23 this into a superclass:
24 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
25 and also use it as the base of this new ReportPlace:
26 * src/main/java/org/glom/web/client/place/ReportPlace.java
28 * src/main/java/org/glom/web/client/ui/ReportView.java
29 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
30 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
31 Add these, containing mostly boiler-plate for now.
33 * src/main/java/org/glom/web/client/OnlineGlomService.java
34 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
35 * src/main/java/org/glom/web/server/ConfiguredDocument.java
36 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
37 Add API to get the LayoutGroup for the report.
39 2012-01-27 Murray Cumming <murrayc@murrayc.com>
41 TableSelectionViewImpl: Put the search label and entry in a div.
43 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
44 Put the search widgets in a FlowTable so that the CSS can be used to
45 style them while keeping them together.
46 * src/main/webapp/style.css: Mention the new div.
48 2012-01-27 Murray Cumming <murrayc@murrayc.com>
50 Translate more strings in more locales.
52 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
53 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
54 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
55 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
56 Translate the "Details" and "Open" string too.
58 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
59 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
60 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
61 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
62 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
63 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
64 Add these new locales as placeholders though they currently contain English.
66 2012-01-27 Murray Cumming <murrayc@murrayc.com>
68 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
70 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
71 Check the ConfiguredDocument* for null before using it.
73 2012-01-26 Murray Cumming <murrayc@murrayc.com>
75 Tell Eclipse about the generated java files.
77 * .classpath: This lets it find OnlineGlomConstants.java.
78 It would be nice if Eclipse just used the maven build files.
80 2012-01-26 Murray Cumming <murrayc@murrayc.com>
82 Prevent a crash when no locale is specified in the URL.
84 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
85 Avoid returning a null string, obtained from
86 Window.Location.getParameter(). This caused a crash when it was
87 later passed to libglom's API.
88 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
89 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
90 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
91 guard against future null strings.
93 2012-01-26 Murray Cumming <murrayc@murrayc.com>
95 Use the ?locale= query param instead of the &lang= token param.
97 * src/main/java/org/glom/web/client/place/ListPlace.java
98 * src/main/java/org/glom/web/client/place/DetailsPlace.java
99 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
100 Remove the lang token key and value.
102 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
103 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
104 When the user selects a different locale from the chooser, use
105 Window.Location.assign() to change the URL, which then causes a reload.
107 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
108 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
109 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
110 * src/main/java/org/glom/web/client/activity/ListActivity.java
111 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
112 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
113 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
114 * src/main/java/org/glom/web/client/ui/ListView.java:
115 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
117 Remove localeID member variables and method/constructor parameters, instead
118 using Utils.getCurrentLocaleID() when we need a localID to pass to
121 2012-01-26 Murray Cumming <murrayc@murrayc.com>
123 Internationalize the UI strings.
125 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
126 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
127 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
128 because it is unused. Messages are apparently strings that can have
129 parameters, but we do not need that yet, so Contants will be enough for now.
130 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
131 to say that we support the en and de locales.
132 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
133 The original English strings.
134 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
135 Some German translations of the English strings.
136 The i18n goal then uses the .properties file to generate an
137 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
138 returns an implementation that returns the translated strings.
139 The documentation suggests putting these in src/java/*/client/, but it seems
140 best to put it in src/resources/*/client/.
141 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
142 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
143 instead of hard-coding them.
144 Note that we cannot import OnlineGlomConstants because it does not exist yet,
145 but that does not seem to stop the build, though it confuses Eclipse.
147 You can see the translated string by adding ?locale=de to the URL, like so:
148 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
150 2012-01-24 Murray Cumming <murrayc@murrayc.com>
152 Improve null/empty String checks.
154 * pom.xml: Add a dependency on commons-lang, to use
155 org.apache.commons.lang.StringUtils.
156 * src/main/java/org/glom/web/server/ConfiguredDocument.java
157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
158 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
159 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
160 Use StringUtils.isEmpty().
162 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
163 StringUtils class with a static isEmpty() function because we
164 cannot use org.apache.commons.lang.StringUtils in client-side
165 GWT code because it (apparently) cannot be compiled to javascript.
166 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
167 * src/main/java/org/glom/web/client/activity/ListActivity.java
168 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
169 * src/main/java/org/glom/web/client/place/DetailsPlace.java
170 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
171 * src/main/java/org/glom/web/client/place/ListPlace.java
172 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
173 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
174 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
175 * src/main/java/org/glom/web/client/ui/details/Group.java
176 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
177 our StringUtils.isEmpty() function.
179 2012-01-24 Murray Cumming <murrayc@murrayc.com>
181 Update to the latest java-libglom API.
183 * pom.xml: Require java-libglom 1.21.4.
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java
185 getDocumentInfo(), getListViewLayoutGroup():
186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
188 * src/main/java/org/glom/web/server/database/DBAccess.java
189 getFieldsToShowForSQLQueryAddGroup(),
190 getPrimaryKeyLayoutItemField(): Replace get_database_title()
191 with either get_database_title_original() or
192 get_database_title(localeID).
194 2012-01-24 Murray Cumming <murrayc@murrayc.com>
196 ConfiguredDocument: Avoid a null pointer exception.
198 * src/main/java/org/glom/web/server/ConfiguredDocument.java
199 Initialize localeID to "" to avoid returning a null String which
200 causes a crash in java-libglom's swing-generated code.
202 2012-01-23 Murray Cumming <murrayc@murrayc.com>
204 Some simple renaming.
206 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
207 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
208 for localeChooser. This seems more appropriate and is less ambiguous
209 particularly in the .css file.
211 2012-01-23 Murray Cumming <murrayc@murrayc.com>
213 ConfiguredDocument: Rename the localedID private member variable.
215 2012-01-23 Murray Cumming <murrayc@murrayc.com>
217 Adapt to the latest java-libglom API from git master.
219 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
220 libglom now uses only Vector instead of List, which uses add() instead of
223 2012-01-23 Murray Cumming <murrayc@murrayc.com>
225 Add and fill a Reports drop-down list box.
227 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
229 * src/main/java/org/glom/web/client/OnlineGlomService.java:
230 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
232 Added getReports(document, table, localeID), calling
233 ConfiguredDocument.getReports().
234 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
235 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
236 Added setReportsList() and a list widget.
237 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
238 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
240 2012-01-22 Murray Cumming <murrayc@murrayc.com>
242 ConfiguredDocument: Rename the localedID private member variable.
244 2012-01-20 Murray Cumming <murrayc@murrayc.com>
246 Build a source tarball with mvn assembly:single
248 * assembly.xml: Add this file.
249 * pom.xml: Use the maven-assembly-plugin and tell it to use
250 our assembly.xml file.
252 2012-01-19 Murray Cumming <murrayc@murrayc.com>
254 OnlineGlomServiceImpl: Get .glom files recursively.
256 * pom.xml: Depend on commons-io from org.apache.commons.
257 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
258 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
259 files recursively, and with the easier filter for the extension.
260 Use org.apache.commons.io.FilenameUtils.removeExtension() to
261 simplify that code too.
263 2012-01-19 Murray Cumming <murrayc@murrayc.com>
265 README: Mention that you must install java-libglom packages separately.
267 But then it works, because java-libglom is now in the central maven
270 2012-01-18 Murray Cumming <murrayc@murrayc.com>
272 locales drop-down: Show the correct selected locale when the URL changes.
274 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
275 .java: setPlace(): Move some code into fillView().
277 2012-01-18 Murray Cumming <murrayc@murrayc.com>
279 locales drop-down: Do not lose the primary key.
281 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
282 start(): onLocaleChange(): Pass the current primary key value,
283 instead of an empty value.
285 2012-01-18 Murray Cumming <murrayc@murrayc.com>
287 locales drop-down: Do not lose the drop-down selection.
289 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
290 .java (TableSelectionActivity.fillView): Set the selected locale
291 after changing the drop-down items (though we do not really need
292 to change them just because the locale changes.)
294 2012-01-18 Murray Cumming <murrayc@murrayc.com>
296 locales drop-down: Change the tables list when this changes.
298 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
299 .java: TableSelectionActivity.start(): Move the async table titles
300 retrieval into a private fillView() method and also call this when
301 the chosen locale changes.
302 Note that the document title is not actually translatable yet, but
303 that is a problem that I should fix soon in libglom.
305 2012-01-18 Murray Cumming <murrayc@murrayc.com>
307 Improve the placement of the locales drop-down.
309 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
310 Put the title and locales drop-down in a div (gwt.FlowTable).
311 * src/main/webapp/style.css: Add magic css properties to make this work.
312 Also remove the left margin from the title so that it lines up with the
315 2012-01-18 Murray Cumming <murrayc@murrayc.com>
317 locales selector: Show human-readable locale titles.
319 * src/main/java/org/glom/web/server/ConfiguredDocument.java
320 getDocumentInfo(): Use java.util.Locale to show a real title of
321 each locale, in the locale's own language.
323 2012-01-17 Murray Cumming <murrayc@murrayc.com>
325 Add a language/locale selector drop-down.
327 * src/main/java/org/glom/web/shared/DocumentInfo.java:
328 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
329 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
330 getDocumentInfo(): Store the available Locales in the DocumentInfo.
331 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
332 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
333 Add a ListBox to show the available locales. Add getLocaleSelector(),
334 setLocaleList(), getSelectedLocale(), setSelectedLocale().
335 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
336 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
337 java: Add these classes.
338 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
339 start(): Fill the locales ListBox. Handle its change event, firing a
341 setPlace(): Show the selected locale as specified by the URL token.
342 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
343 * src/main/java/org/glom/web/client/activity/ListActivity.java:
344 Handle LocaleChangeEvent, going to a new *Place with that locale.
346 The placement of the ListBox is not pretty, and it currently uses the ID
347 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
351 2012-01-17 Murray Cumming <murrayc@murrayc.com>
353 Search box: Show the search text from the URL token.
355 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
356 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
357 Add setQuickFindText().
358 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
359 .java: setPlace(): Store the queryText if the place is a ListPlace,
360 and call TableSelectionView.setQuickFindText().
362 2012-01-17 Murray Cumming <murrayc@murrayc.com>
364 Allow use of translations via, for instance, &lang=de in the URL.
366 * pom.xml: Use the unstable java-libglom 1.21 version.
368 * src/main/java/org/glom/web/client/OnlineGlomService.java:
369 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
371 init(): Instead of calling TranslatableItem.set_current_locale()
372 (now removed), call ConfiguredDocument.setDefaultLocaleID().
373 However, this is only for default locales, which are not needed to
374 change the locale in the URL.
375 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
376 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
377 getSortedRelatedListData(): Add a localeID parameter, so we can get the
378 layout for a particular locale.
379 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
380 Add get/setDefaultLocaleID().
381 getDocumentInfo(), getListViewData(), getRelatedListData(),
382 getDetailsLayoutGroup(), getListViewLayoutGroup(),
383 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
384 localeID parameter, so we can get the layout for a particular locale.
386 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
387 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
388 * src/main/java/org/glom/web/client/place/ListPlace.java:
389 Parse and construct a lang parameter too.
391 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
392 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
393 passed to subsequent methods and constructors.
394 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
395 * src/main/java/org/glom/web/client/activity/ListActivity.java:
396 Store the localeID from the *Place and pass it to other constructors
397 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
399 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
400 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
401 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
402 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
403 * src/main/java/org/glom/web/client/ui/ListView.java:
404 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
405 Take localeID parameters and pass them to subsequent constructors and
406 methods, so that the layout is always retrieved for that locale.
408 This is rather repetitive.
410 Note that "" means the original (default) locale of the Glom document,
411 which is usually English.
413 2012-01-17 Murray Cumming <murrayc@murrayc.com>
415 Documents: Remove final keyword to fix startup configuration.
417 * src/main/java/org/glom/web/shared/Documents.java: Remove the
418 final keywords on the private member variables because that breaks
419 the startup, apparently (there are warnings) because it stops them
420 from being serialized. I added these in the previous commit.
422 2012-01-13 Murray Cumming <murrayc@murrayc.com>
424 Documents: Add some final keywords.
426 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
429 2012-01-13 Murray Cumming <murrayc@murrayc.com>
431 OnlineGlomServiceImpl: Add to overview comments.
433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
434 Note that this is where all the document are loaded. They are not
435 loaded freshly for each page.
437 2012-01-12 Murray Cumming <murrayc@murrayc.com>
441 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
442 Add a TextBox for the text of a quick find.
443 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
445 setBackLink(): Add a String quickFind parameter.
446 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
447 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
448 to the base interface, because that is how TableSelectionViewImpl is used.
449 * src/main/webapp/style.css: Add style for the search box and its label.
451 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
452 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
453 Add these files, based on the existing TableChangeEvent and
454 TableChangeEventHandlers.
455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
456 start(): Handle QuickFindChangeEvent, passing its quickFind text to
457 a ListPlace() that the user should be taken to.
458 * src/main/java/org/glom/web/client/activity/ListActivity.java
459 start(): Handle it here too and adapt the TableChangeEvent handler to
460 pass the extra "" quickFind parameter to ListPlace.
461 * src/main/java/org/glom/web/client/place/ListPlace.java:
462 Constructor: Take an extra String quickFind parameter and store it,
463 returning it from a new getQuickFind() method.
464 getToken(): Put the quickFind text in the URL token.
465 getPlace(): Parse the quickFind text from the URL token.
466 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
467 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
468 ListPlace constructor.
469 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
470 .java: start(): Add a Change handler for the TableSelectionView's
471 TextBox (via its base HasChangeHandlers interface), firing the new
472 QuickFindChangeEvent.
473 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
474 pass the extra "" quickFind parameter.
476 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
477 setCellTable(): Add a String quickFind parameter and pass it to
478 the ListViewTable() constructor.
479 * src/main/java/org/glom/web/client/ui/ListView.java: Change
480 setCellTable() in the base interface, because that is how ListViewImpl
483 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
484 Add a String quickFind member variable.
485 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
486 Constructor: Add a String quickFind parameter, storing it in the
487 base ListTable's member variable.
488 onRangeChanged(): Pass quickFind to the
489 OnlineGlomServiceAsync.getSortedListViewData() and
490 OnlineGlomServiceAsync.getListViewData() methods.
492 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
493 getListViewData(), getSortedListViewData(): Add a String quickFind
494 parameter, passing it to ConfiguredDocument.getListViewData().
495 * src/main/java/org/glom/web/client/OnlineGlomService.java:
496 Change getListViewData(), getSortedListViewData() in the base interface,
497 because that is how OnlineGlomServiceImpl is used, via this:
498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
499 Change getListViewData(), getSortedListViewData() here too.
500 This class can apparently be used to asynchronously call methods on
501 OnlineGlomService, and GWT seems to implement that after recognizing
502 just the *Async name convention and the extra AsyncCallback parameters.
504 * src/main/java/org/glom/web/server/ConfiguredDocument.java
505 getListViewData(): Add a String quickFind parameter, and pass it to
506 ListViewDBAccess.getData().
507 * src/main/java/org/glom/web/server/database/ListDBAccess.java
508 getListData(): Add a String quickFind parameter and pass it to
510 getSelectQuery(): Add a String quickFind parameter.
511 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
512 getSelectQuery(): Add a String quickFind parameter and use it with
513 Glom.get_find_where_clause_quick() to pass a where_clause to
514 Glom.build_sql_select_with_where_clause(), to actually filter the
516 getData(): Add a String quickFind parameter, passing it to getListData().
517 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
518 va: getData(): Pass an empty string to getListData() for the
521 2012-01-12 Murray Cumming <murrayc@murrayc.com>
523 ListTable: Minor change.
525 * src/main/java/org/glom/web/client/ui/list/ListTable.java
526 createCellTable(): Make this protected instead of public.
528 2012-01-12 Murray Cumming <murrayc@murrayc.com>
530 Many files: Use final for the parameters and use the @override attribute.
532 2012-01-22 Ben Konrath <ben@bagu.org>
534 Add anchor links for single line text that starts with http, ftp and www.
538 2012-01-22 Ben Konrath <ben@bagu.org>
540 Add ellipsis to single line text in details view.
544 2012-01-04 Murray Cumming <murrayc@murrayc.com>
546 Remove all javadoc author tags.
548 Because they are awkward and meaningless when many people touch
550 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
552 2012-01-04 Murray Cumming <murrayc@murrayc.com>
554 Revert the COPYING.LESSER to COPYING rename.
556 Apparently both should be there if it is LGPL.
558 2012-01-03 Murray Cumming <murrayc@murrayc.com>
560 *View: Remove unused imports.
562 * src/main/java/org/glom/web/client/ui/DetailsView.java:
563 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
564 * src/main/java/org/glom/web/client/ui/ListView.java:
565 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
566 Remove unused imports, as suggested by Eclipse.
568 2012-01-02 Murray Cumming <murrayc@murrayc.com>
570 Move the *View::Presenter types, and some API into one base View.
572 * src/main/java/org/glom/web/client/ui/DetailsView.java:
573 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
574 * src/main/java/org/glom/web/client/ui/ListView.java:
575 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
576 Presenter, setPresenter() and clear() into a shared base interface,
577 to avoid the unnecessary duplicate Presenter types and to more clearly
578 show how the *Views share the same structure, even if they are not
579 used polymorphically.
581 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
582 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
584 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
585 * src/main/java/org/glom/web/client/activity/ListActivity.java:
586 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
588 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
591 Feel free to revert this if there is a good reason for the duplicate
594 2012-01-02 Murray Cumming <murrayc@murrayc.com>
596 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
598 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
599 a class member instead of a local variable in the method.
600 This lets us use it to get the view instances, for use in tests.
601 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
602 beforeOnlineGlom(): Test some more details of the initial view.
603 Again, this is not very useful.
605 To really test gwt-glom we will need to start a local postgresql
606 instance with local data, like the Glom tests in C++.
608 2012-01-02 Murray Cumming <murrayc@murrayc.com>
610 pom.xml: Mention the LGPL license.
612 * pom.xml: Add a licenses section.
613 * COPYING.LESSER: Move this to COPYING, which
614 previously contained the GPL. But gwt-glom is all LGPL.
616 2012-01-02 Murray Cumming <murrayc@murrayc.com>
618 Add project information to README and pom.xml.
620 * README: Add a brief description and mention some mvn
622 * pom.xml: This extra information shows up in mvn site
625 2011-01-02 Murray Cumming <murrayc@murrayc.com>
627 Use the latest java-libglom version.
629 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
631 2012-01-01 Murray Cumming <murrayc@murrayc.com>
633 GwtTestOnlineGlom: Test a little more.
635 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
636 protected rather than private, as suggested by the gwt-test-utils
638 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
639 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
640 Test the initial visibility of the panels.
642 However, this is not a very useful test.
643 And I wonder how we should generally test using this idea for an
644 activity/places app like ours where the real changes happen implicitly
645 based on the history token/URL.
647 2012-01-01 Murray Cumming <murrayc@murrayc.com>
649 Slight modification to *Mapper comments.
651 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
653 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
655 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
657 Remove comments mentioning GIN because they are just copied from
658 the example code and are apparently not helpful:
659 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
660 Also change the mention of a class that is only in the example code.
662 2012-01-01 Murray Cumming <murrayc@murrayc.com>
664 GwtTestOnlineGlom test: Minor changes.
666 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
667 Avoid the long qualified class name and modify the comment
668 because it is now obvious to me that the mocked class is the only
669 custom one created via GWT.create().
671 2012-01-01 Murray Cumming <murrayc@murrayc.com>
673 Tests: Added the beginnings of a test using gwt-test-utils.
675 * pom.xml: Add dependencies on gwt-test-utils and easymock.
676 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
677 which tells gwt-test-utils what class will be tested.
678 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
679 Add a simple (but empty) test case. One class, used by the OnlineGlom
680 class, is mocked so that it can be created. However, I am not sure
681 why only this class needs to be mocked.
683 Note that mockito seems more popular, and clearer, than easymock,
684 but I have not got that working yet. It might be a matter of the
687 This test is run during mvn integration-test.
689 2011-12-31 Murray Cumming <murrayc@murrayc.com>
691 Tests: Use junit4-style syntax instead of junit3-style.
693 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
694 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
695 * src/test/java/org/glom/web/shared/DataItemTest.java:
696 Use the @Test annotation rather than relying on the test*() prefix.
697 Also no longer implement TestCase, to avoid triggering support for
698 the junit3-way, which stops the annotations from working.
699 Change the imports from import junit.framework.* to
700 import org.junit.*, which is apparently the new way.
702 2011-12-31 Murray Cumming <murrayc@murrayc.com>
704 Added a test for ListPlace token parsing and creation.
706 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
707 This is much the same as DetailsPlaceTest.
709 I wonder how we could test the other parts of the *Place API.
711 2011-12-30 Murray Cumming <murrayc@murrayc.com>
713 DetailsPlace test: Also test getToken() and recreation via getPlace().
715 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
716 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
717 recreate it, testing the recreated DetailsPlace for the same parameter
720 2011-12-30 Murray Cumming <murrayc@murrayc.com>
722 Use the surefire-report plugin.
724 * pom.xml: This generates a HTML report about the tests in
725 target/site/surefire-report.html
726 when you do mvn surefire-report:report. It seems to be popular/normal.
728 2011-12-30 Murray Cumming <murrayc@murrayc.com>
730 Added a test for DetailsPlace.
732 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
733 Test the getPlace() token parsing.
735 2011-12-30 Murray Cumming <murrayc@murrayc.com>
737 Added a first unit test.
739 * pom.xml: Add a test goal, and a dependency on junit in that scope.
740 * src/test/java/org/glom/web/shared/DataItemTest.java:
741 This is a silly test but it is just to get things started. Note that
742 maven/junit finds the test because it looks in src/test by default.
744 2011-12-22 Ben Konrath <ben@bagu.org>
746 Change charsetName to "UTF-8" when replacing line breaks.
748 JavaScript requires the charsetName to be "UTF-8". CharsetName values
749 that work in Java (such as "UTF8") will not work when compiled to
752 This fixes a problem with multi-line details view fields that have hard
753 line breaks. The "License Text" field on this page demonstrates the
756 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
758 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
760 2011-12-22 Ben Konrath <ben@bagu.org>
762 Fix another bug with related list navigation.
764 I've tested all the navigation buttons in all of the related lists
765 so things should be good now.
767 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
769 2011-12-22 Ben Konrath <ben@bagu.org>
771 Fix a crasher when refreshing the list view with the default table.
773 This crash will also happen when loading the list view with the default
774 table from a link or bookmark.
776 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
777 to the main document selection page when the document id hasn't been
779 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
780 the main document selection page when the document id hasn't been
782 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
783 values for the details place when the document id hasn't been set.
784 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
785 values for the list place when the document id hasn't been set.
787 2011-12-21 Ben Konrath <ben@bagu.org>
789 Protect against NPE when glom.document.locale is not in config.
791 This patch protects against an NPE when glom.document.locale is not in
792 the config file. This NPE will also happen if glom.document.locale is
795 The patch also updates the error message to display the class name when
796 the getMessage() returns null. This was happening when the NPE was
797 thrown and I had "Configuration Error: null". If an NPE is encountered
798 with this patch, "Configuration Error: NullPointerException " will be
801 This commit closes this bug:
803 https://bugzilla.gnome.org/show_bug.cgi?id=666669
805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
807 2011-12-20 Murray Cumming <murrayc@murrayc.com>
809 Rename onlineglom.properties to onlineglom.properties.sample.
811 * src/main/resources/onlineglom.properties: Rename to:
812 * src/main/resources/onlineglom.properties.sample:
813 * src/main/resources/README: And add this file explaining that people
814 should rename it back when deploying.
816 2011-12-20 Murray Cumming <murrayc@murrayc.com>
818 Allow choosing the translation in the .properties file.
820 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
821 init(): Read a glom.document.locale value from the configuration file
822 and call Glom's TransatableItem::set_current_locale() method.
823 * src/main/resources/onlineglom.properties: Add a commented-out
824 example of this new setting.
826 It would be better to add &lang=de_DE to the URL, but the current
827 libglom API does not allow us to do this easily. I am working on that.
829 2011-12-19 Murray Cumming <murrayc@murrayc.com>
831 Avoid a crash in parsing of token parameters.
833 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
834 ava: getTokenParams(): Do not crash if a parameter has a key but no
835 value, and ignore parameters with neither.
837 2011-12-17 Murray Cumming <murrayc@murayc.com>
839 History token building/handling: Improve use of token parameters.
841 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
842 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
843 and buildParamsToken(HashMap), for use by derived classes.
844 Make the separator private because it is no longer be needed.
845 * src/main/java/org/glom/web/client/place/DetailsPlace.java
846 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
847 instead of manual string concatenation.
848 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
849 of hardcoded indices and awkward splitting code.
850 * src/main/java/org/glom/web/client/place/ListPlace.java
851 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
852 instead of manual string concatenation.
853 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
854 of hardcoded indices and awkward splitting code.
855 This should fix bug #666420
857 2011-12-16 Murray Cumming <murrayc@murrayc.com>
859 Fix a Navgiation->Navigation typo in the code.
861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
862 Rename processNavgiation() to processNavigation().
864 2011-12-16 Murray Cumming <murrayc@murrayc.com>
866 Fix a seperator->separator typo in the code.
868 * src/main/java/org/glom/web/client/place/DetailsPlace.java
869 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
870 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
873 2011-12-15 Ben Konrath <ben@bagu.org>
875 Cleanup some comments.
877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
879 2011-12-14 Ben Konrath <ben@bagu.org>
881 Replace \n with <br/> for multiline text in the details view.
883 Vertical scrollbars are added when needed as well.
885 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
887 2011-12-14 Ben Konrath <ben@bagu.org>
889 Specify the font for document selection links.
891 * src/main/webapp/style.css:
893 2011-12-14 Ben Konrath <ben@bagu.org>
895 Fix bouncy CellTable while paging.
897 This doesn't currently work with related list tables in unselected
900 * src/main/java/org/glom/web/client/ui/list/ListTable.java
902 2011-12-14 Ben Konrath <ben@bagu.org>
904 Revamp the appearance of the document selection page.
906 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
907 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
908 * src/main/webapp/style.css:
910 2011-12-13 Ben Konrath <ben@bagu.org>
912 Set navigation button column to the smallest size possible.
914 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
916 2011-12-13 Ben Konrath <ben@bagu.org>
918 Change OpenButton nomenclature to NavigationButton.
920 Using NavigtionButton makes things more generic. Classes, methods and
921 variables have been changed.
923 This is a rename-only refactor.
925 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
926 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
927 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
928 Renamed from OpenButtonCell.
929 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
930 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
931 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
933 2011-12-12 Ben Konrath <ben@bagu.org>
935 Remove unnecessary String argument in RelatedListTable and ListViewTable.
937 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
938 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
939 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
940 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
942 2011-12-12 Ben Konrath <ben@bagu.org>
944 Update variable names and comments.
946 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
947 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
949 2011-12-12 Ben Konrath <ben@bagu.org>
951 Properly initialize numNonEmptyRows variable to zero.
953 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
954 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
956 2011-12-05 Ben Konrath <ben@bagu.org>
958 Add latest mockup with HTML tables.
960 Features of this mockup:
962 -> HTML table for flowtable
963 -> HTML table for flowtable column
964 -> Example of how related lists would look
965 -> Not using text entries for data items
967 The current version of Online Glom doesn't use HTML tables for the
970 This mockup has been sent to the glom-devel mailing list but it's good
971 to have it here as well.
973 * mockups/details-view-html-tables.html:
975 2011-12-05 Ben Konrath <ben@bagu.org>
977 Remove unnecessary getPrimaryKeyField() method.
979 getPrimaryKeyFieldForTable(String) has been renamed to
980 getPrimaryKeyField(String).
982 * src/main/java/org/glom/web/server/database/DBAccess.java:
983 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
984 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
986 2011-12-05 Ben Konrath <ben@bagu.org>
988 Add string representation of TypedDataItem value to conversion error message.
990 * src/main/java/org/glom/web/server/Utils.java: Logging the error
991 message was extracted into its own method to avoid duplication.
993 2011-12-05 Ben Konrath <ben@bagu.org>
995 Add type checking to navigation primary key value creation.
997 Create navigation primary key only if the expected type from the Glom
998 document matches the type returned by the SQL query.
1000 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1002 2011-12-05 Ben Konrath <ben@bagu.org>
1004 Rename a couple of variables in RelatedListNavigation.
1006 This is a rename-only refactor.
1008 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1010 2011-12-05 Ben Konrath <ben@bagu.org>
1012 Move getListLayoutGroup() into getListViewLayoutGroup().
1014 This removes getListLayoutGroup(). It was only being called by
1015 getListViewLayoutGroup().
1017 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1019 2011-12-05 Ben Konrath <ben@bagu.org>
1021 Remove check for LayoutItem_Portal in list table method.
1023 This check is no longer necessary because the method isn't being used
1024 to create the LayoutItemPortal DTO.
1026 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1028 2011-12-05 Ben Konrath <ben@bagu.org>
1030 Properly support related list navigation.
1032 Navigation from the "Repository Analyzer -> Package Scans ->
1033 Dependencies" related table wasn't working because the primary key for
1034 related tables wasn't being set properly. This commit fixes the
1037 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1038 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1039 doesn't set the primary key properly for related list tables.
1040 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1041 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1042 useful for getting the primary key for list view tables and for related
1044 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1045 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1046 Move code to set the primary key for the table from the abstract
1047 ListDBAccess class to ListViewDBAccess as it's only correct for list
1049 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1050 Properly add primary key to related list tables.
1052 2011-12-02 Ben Konrath <ben@bagu.org>
1054 Properly set the horizontal alignment of fields.
1056 This fix is for both the list tables and the details view.
1058 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1059 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1060 to set the horizontal alignment of fields.
1062 2011-12-02 Ben Konrath <ben@bagu.org>
1064 Display currency codes in the details view.
1066 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1068 2011-12-02 Ben Konrath <ben@bagu.org>
1070 Avoid duplicate JNI call.
1072 JNI is not as efficient as pure Java and this is an easy (and small)
1075 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1076 Use previously retrieved value for whereClauseToTableName instead of
1079 2011-12-02 Ben Konrath <ben@bagu.org>
1081 Rename a couple of variables in RelatedListNavigation.
1083 This is a rename-only refactor.
1085 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1087 2011-12-02 Ben Konrath <ben@bagu.org>
1089 Indicate clearly that a mismatched primary key type is a bug.
1091 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1092 warning to error. Add 'This is a bug.' to message.
1094 2011-12-02 Ben Konrath <ben@bagu.org>
1096 Update / fix some comments.
1098 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1100 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1102 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1103 Fix comments. Add some TODOs.
1105 2011-12-02 Ben Konrath <ben@bagu.org>
1107 Enable navigation to details view with string primary key from related list.
1109 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1110 Create a text primary key value when return type of result is
1111 java.sql.Types.VARCHAR.
1113 2011-12-02 Ben Konrath <ben@bagu.org>
1115 Use checkboxes for booleans in the details view.
1117 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1119 2011-12-01 Ben Konrath <ben@bagu.org>
1121 Improve performance of related list height calculation.
1123 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1124 Put code to calculate the expected height in a static initializer so
1125 that that it's only called once.
1127 2011-12-01 Ben Konrath <ben@bagu.org>
1129 Show related list tables in notebooks (again).
1131 Calculate the height of the related list tables so the Notebook can be
1132 set the correct height. The height of the related list table is also needed by
1133 FlowTable to be able decide how to create the layout.
1135 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1136 and set the Portal height based on the height of the related list
1137 table and the Portal container.
1138 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1139 Add method to calculate the height of the related list tables.
1140 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1141 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1142 calculate the height of the Pager widget.
1144 2011-12-01 Ben Konrath <ben@bagu.org>
1146 Use CellTable API for table property instead of setting style on Element.
1148 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1150 2011-12-01 Ben Konrath <ben@bagu.org>
1152 Make ListViewTable and RelatedListTable a consistent height.
1154 The tables are now a consistent height regardless of the contents of
1155 the table. A hidden button is added to empty rows to ensure that the
1156 height of these rows will match the height of rows with data.
1158 A navigation button column is now added to every table. The width of
1159 the navigation column is set to 0px when a RelatedListTable shouldn't
1160 have navigation buttons. This maintains the a consistent row height in
1161 tables that don't show the navigation buttons.
1163 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1164 navigation column when not needed.
1165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1166 arguments for navigation button to constructor of ListViewTable.
1167 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1168 hidden button for empty data rows.
1169 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1170 arguments for navigation button to constructor.
1171 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1172 create navigation buttons. Add hideNavigationButtons() method.
1173 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1174 arguments for navigation button to constructor.
1176 2011-12-01 Ben Konrath <ben@bagu.org>
1178 Use 'visibility: hidden' in Utils.getWidgetHeight().
1180 This is better choice because hidden elements are invisible, don't
1181 respond to events and are not part of the tab order. They will,
1182 however, take up space which is required to be able to calculate the
1183 height of the widget.
1185 * src/main/java/org/glom/web/client/Utils.java:
1187 2011-12-01 Ben Konrath <ben@bagu.org>
1189 Use Utils.getWidgetHeight() in FlowTable.
1191 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1193 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1195 2011-12-01 Ben Konrath <ben@bagu.org>
1197 Put the details css class name on the correct table column.
1199 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1201 2011-11-30 Ben Konrath <ben@bagu.org>
1203 Update for java-libglom API change.
1205 The getters and setters on FieldFormatting and NumericFormat were
1206 changed to remove the 'M'.
1208 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1210 2011-11-29 Ben Konrath <ben@bagu.org>
1212 Only allow RelatedListTables in Portals.
1214 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1216 2011-11-29 Ben Konrath <ben@bagu.org>
1218 Only create a contents panel for Portals when title is being set.
1220 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1222 2011-11-29 Ben Konrath <ben@bagu.org>
1224 Set TabLayoutPanel height based on calculated height its widgets.
1226 This is a potential fix for this bug:
1228 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1230 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1232 2011-11-29 Ben Konrath <ben@bagu.org>
1234 Align details field labels and data with the Open buttons.
1236 * src/main/webapp/style.css:
1238 2011-11-29 Ben Konrath <ben@bagu.org>
1240 Remove unnecessary <div> in the Notebook widget.
1242 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1243 method to get container FlowPanel (<div>).
1244 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1245 initWidget() method directly on the TabLayoutPanel widget instead of
1246 Group's container widget.
1248 2011-11-29 Ben Konrath <ben@bagu.org>
1250 Don't add group titles for Portals in Notebooks.
1252 This reverts the previous patch and fixes a bug I introduced with
1253 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1255 * src/main/java/org/glom/web/client/ui/details/Group.java:
1256 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1258 2011-11-28 Ben Konrath <ben@bagu.org>
1260 Remove unused boolean argument in Portal constructor.
1262 Just a code cleanup.
1264 * src/main/java/org/glom/web/client/ui/details/Group.java:
1265 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1267 2011-11-28 Ben Konrath <ben@bagu.org>
1269 Remove hack for glom 1.18 style glom files.
1271 * src/main/java/org/glom/web/client/ui/details/Group.java:
1272 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1273 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1275 2011-11-28 Ben Konrath <ben@bagu.org>
1277 Use Gda Value version of primary key to log result too large error.
1279 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1281 2011-11-28 Ben Konrath <ben@bagu.org>
1283 Don't use TypedDataItem.getText() for Unknown types from the URL.
1285 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1286 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1287 instead of getText().
1288 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1289 String field and getUnknown() method.
1291 2011-11-28 Ben Konrath <ben@bagu.org>
1293 Log an error message when the java-libglom .so is not present.
1295 The error message was being set in the exception but not logged.
1297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1299 2011-11-28 Ben Konrath <ben@bagu.org>
1301 Ignore LayoutItem_CalendarPortals.
1303 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1304 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1306 2011-11-28 Ben Konrath <ben@bagu.org>
1308 Extract method for creating the LayoutItemPortal DTO.
1310 Just breaking the code up into smaller chunks.
1312 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1314 2011-11-28 Ben Konrath <ben@bagu.org>
1318 This should have been added with the refactor. Oops!
1320 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1322 2011-11-28 Ben Konrath <ben@bagu.org>
1324 Create primary key value from URL string using type from Glom document.
1326 See this bug, comments 19 - 25:
1328 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1330 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1331 create a TypeDataItem for the primary key here when loading from a
1332 URL. Show the same string for the primary key value as was received
1333 from the URL string (when loading from a URL).
1334 * src/main/java/org/glom/web/server/Utils.java: Update method for
1335 creating the Gda Value from the TypeDataItem to properly deal with
1336 creating a Gda Value based on the Glom document type for the primary
1337 key value string when loading from a URL.
1338 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1339 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1340 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1341 Update for changed method name.
1343 2011-11-27 Ben Konrath <ben@bagu.org>
1345 Rename PrimaryKeyItem to TypedDataItem.
1347 The name PrimaryKeyItem suggests what the class should be used for.
1348 TypedDataItem is a neutral name that describes the class better.
1350 This is a rename-only refactor.
1352 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1353 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1354 * src/main/java/org/glom/web/client/Utils.java:
1355 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1356 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1357 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1358 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1359 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1360 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1361 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1362 * src/main/java/org/glom/web/server/Utils.java:
1363 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1364 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1365 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1366 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1368 2011-11-25 Ben Konrath <ben@bagu.org>
1370 Improve Gda Value conversion from PrimaryKeyItem.
1372 The value from the PrimaryKeyItem is only used if its type match the
1373 type from the glom document.
1375 * src/main/java/org/glom/web/server/Utils.java:
1377 2011-11-25 Ben Konrath <ben@bagu.org>
1379 Manually check if the java-liblgom .so is visible to the JVM.
1381 It seems that Tomcat has problems when a static initializer throws an
1382 exception. This check is done before the first method call into
1383 java-libglom so that execution doesn't continue if the .so is not
1386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1388 2011-11-25 Ben Konrath <ben@bagu.org>
1390 Improve browser configuration error messages.
1394 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1396 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1397 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1398 getConfigurationErrorMessage() method.
1399 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1400 Get and display a specific configuration error message when no Glom
1401 documents are found.
1402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1403 Implement getConfigurationErrorMessage() method. Surround configuration
1404 code in the init() method with a try/catch block. This allows the
1405 errors to be caught while keeping the servlet available to retrieve the
1406 configuration error message.
1408 2011-11-25 Ben Konrath <ben@bagu.org>
1410 Don't use Strings to hold primary key values.
1412 The primary key values are now held in a new data object
1413 (PrimaryKeyItem) that holds type information and the primary key value
1414 using the correct type.
1416 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1417 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1419 PrimaryKeyItem instead of String to hold the primary key value.
1420 * src/main/java/org/glom/web/client/Utils.java: Remove
1421 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1422 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1424 PrimaryKeyItem instead of String to hold the primary key value. Load
1425 document selection page when the documentID has not been set correctly.
1426 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1427 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1429 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1430 Return empty string for URL instead of "null".
1431 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1432 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1433 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1434 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1435 PrimaryKeyItem instead of String to hold primary key values.
1436 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1437 PrimaryKeyValue to a Gda Value.
1438 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1439 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1440 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1441 Replace temporary database access code that uses the PrimaryKeyValue to
1442 Gda Value conversion.
1443 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1444 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1445 PrimaryKeyItem instead of String.
1446 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1447 hold primary key values.
1449 2011-11-24 Ben Konrath <ben@bagu.org>
1451 Use newly added java-libglom API to create queries.
1453 This isn't finished. I still need to stop using Strings for primary key
1454 values in the client code.
1456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1457 libglom to use fake connections so that retrieving the query string will
1459 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1460 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1461 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1462 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1463 Use the newly added libglom sql methods and classes to create the
1464 query. Add temporary hack to convert primary value strings to Gda
1467 2011-11-23 Ben Konrath <ben@bagu.org>
1469 Don't explicitly set the height of Portals.
1471 See comments 6 - 10 of this bug for details:
1473 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1475 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1477 2011-11-23 Ben Konrath <ben@bagu.org>
1479 Use an HTML table instead of CSS for the FlowTable layout.
1481 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1482 GWT's FlexTable to implement the FlowTable.
1483 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1485 2011-11-18 Ben Konrath <ben@bagu.org>
1487 Add boolean example to HTML table mockup.
1489 * mockups/details-view-html-tables-text-entries.html:
1491 2011-11-17 Ben Konrath <ben@bagu.org>
1493 Ensure the pager buttons are always visible for related lists.
1495 To accomplish this, I've turned off text wrapping in the list view and
1496 related list tables for both the header and data text. The related list
1497 table now has a fixed layout so the it doesn't overflow its container.
1498 This is required to ensure that the cell text is clipped when it
1499 overflows the cell and an ellipsis is added to the right side of the
1500 cell when text is clipped.
1502 A fixed table layout for the related list table in the details view
1503 seems what we want for the details view anyway, so the side-effect is
1506 The ellipsis will only be displayed in Firefox >= 7.
1510 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1512 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1513 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1514 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1516 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1517 Set the 'table-layout: fixed' CSS property to the related list table.
1518 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1519 'white-space: nowrap;' CSS property on both the list view and the
1520 related list tables.
1522 2011-11-16 Ben Konrath <ben@bagu.org>
1524 Rework the fix for empty notebook tab labels.
1526 Setting the empty group titles with its name caused problems for the
1527 details layout. Instead of using libglom's
1528 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1529 to the client when the title is empty. This allows the Notebook to use
1530 the name when the title is empty without affecting anything else.
1532 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1533 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1535 2011-11-16 Ben Konrath <ben@bagu.org>
1537 Set group titles with name when title is empty.
1539 This fixes a problem with an empty notebook tab label in the Lesson
1540 Planner document. The forth tab in the notebook should be "Internet":
1542 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1544 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1545 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1548 2011-11-16 Ben Konrath <ben@bagu.org>
1550 Remove whitespace from the configured username properties.
1552 This assumes that usernames won't have whitespace at the beginning
1553 or end. But I think this is a reasonable assumption.
1555 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1556 String.trim() to remove the whitespace from the username properties.
1558 2011-11-15 Ben Konrath <ben@bagu.org>
1560 Add details view mockup with HTML tables and text entries.
1562 This is from the attachment on this bug:
1564 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1566 * mockups/details-view-html-tables-text-entries.html:
1568 2011-11-15 Ben Konrath <ben@bagu.org>
1570 Add space between the columns of the flow table.
1574 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1576 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1577 space between columns in the flow table.
1579 2011-11-15 Ben Konrath <ben@bagu.org>
1581 Add backup files to the .gitignore.
1583 * .gitignore: Ignore files that end with ~.
1585 2011-11-09 Ben Konrath <ben@bagu.org>
1587 Use latest release of gwt-log.
1589 Gwt-log releases are now being submitted to the maven central
1590 repository so manual installation of the jar is no longer required.
1592 * pom.xml: Update version and groupId of gwt-log dependency.
1594 2011-10-31 Ben Konrath <ben@bagu.org>
1596 Don't use GWT numeric formatting to override the glom currency formatting.
1598 Currencies are now displayed like they are in Glom. See this bug:
1600 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1602 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1604 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1605 currency code to constructor and set it when the cell is rendered.
1606 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1607 currency code to the constructor of the NumericCell.
1609 2011-10-27 Ben Konrath <ben@bagu.org>
1611 Require the latest release of java-libglom (1.17.4).
1615 2011-10-26 Ben Konrath <ben@bagu.org>
1617 Add style to Notebook that matches current theme.
1619 It's not the best style in the world but it's better than the default.
1621 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1622 padding at the bottom of the child widgets.
1623 * src/main/webapp/style.css: Add style for the Notebook.
1625 2011-10-26 Ben Konrath <ben@bagu.org>
1627 Move servlet initialization code to overridden init method.
1629 This is half of the solution to getting proper error messages
1630 displayed when configuration errors occur. Here's the relevant bug:
1632 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1634 The rest of the solution involves surrounding the init method with a
1635 try/catch block and setting a global variable with the error /
1636 exception. A new async method should be created to retrieve and display
1637 the error message / exception.
1639 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1640 code from constructor to init method adding exceptions as needed.
1642 2011-10-26 Ben Konrath <ben@bagu.org>
1644 Add script to monitor and restart tomcat if required.
1646 * utils/check-and-recover-tomcat.py: New file.
1648 2011-10-26 Ben Konrath <ben@bagu.org>
1650 Display the correct number of data items in the pager.
1654 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1656 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1657 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1658 The implementation is the same for both tables: Keep track of the
1659 number of non-empty rows and fire and RowCountChangeEvent after the data has
1661 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1662 custom Pager class that subclasses SimplePager to handle displaying
1663 the correct number when empty rows have been added.
1665 2011-10-26 Ben Konrath <ben@bagu.org>
1667 Correct error in previous commit.
1669 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1670 eventBus parameter from listView.setCellTable().
1672 2011-10-26 Ben Konrath <ben@bagu.org>
1674 Fix error in TODO comment.
1676 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1678 2011-10-24 Ben Konrath <ben@bagu.org>
1680 Create Notebook widgets to the details view.
1682 This isn't finished just yet - I still need to create a reasonable
1683 style to match the current theme.
1685 * src/main/java/org/glom/web/client/Utils.java: Add method for
1686 calculating the height of a widget. This is used in the Notebook class.
1687 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1688 new constructor method in Group.
1689 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1690 method for creating child widget that can be used by subclasses
1691 like Notebook. New constructor that allows disabling the group
1692 titles - Notebooks don't set a group title for their child groups.
1693 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1694 to make Notebooks using GWT's TabLayoutPanel.
1695 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1696 constructor that allows disabling the group titles.
1697 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1698 LayoutItemNotebook DTO.
1699 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1700 DTO for Notebooks. It's just an empty class for now but we might need
1701 it to transfer some specific information in the future.
1703 2011-10-21 Ben Konrath <ben@bagu.org>
1705 Add navigation buttons to related list tables.
1707 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1708 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1710 method getSuitableRecordToViewDetails() for getting the table name
1711 and primary key value for related list navigation buttons.
1712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1713 private cell renderer class to get the navigation information for
1714 related list tables from the server. Extract the navigation
1715 processing code from the details cell navigation and use it for the
1716 related list navigation as well.
1717 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1718 cell renderer class for the details open buttons. This was needed
1719 because the related list navigation buttons and the list view
1720 navigation buttons need to react differently when clicked.
1721 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1722 the onEnterKeyDown() method because it's now overriden in the
1723 subclasses that are specific to the related list tables and the list
1725 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1726 the vertical size a little because the buttons add a bit of vertical
1727 space to table. This is not a perfect solution because the vertical
1728 size of with table fewer than 5 rows will be a little smaller.
1729 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1730 changes in how navigation buttons are handled.
1731 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1732 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1733 database access object.
1734 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1735 to find the portal for a given relationship name from
1736 RelatedListDBAccess. Add method to find a primary key field for a
1738 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1739 Move code to find the portal for a given relationship name to
1741 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1742 New file: database access object for getting the related list
1743 navigation information (the table name and the primary key value).
1744 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1745 DTO for transferring a table name to navigate to and a primary key
1747 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1748 boolean and getter/setter to specifies if the related list should add
1751 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1753 Use the master branch of java-libglom
1755 * pom.xml: Depend on java-libglom 1.19 instead.
1757 This is the master branch. See also the libglom-1-18 branch.
1759 2011-10-11 Ben Konrath <ben@bagu.org>
1761 Enable the open navigation button when the data has been set.
1763 This avoids having active buttons that don't do anything when the data
1766 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1768 2011-10-11 Ben Konrath <ben@bagu.org>
1770 Use IsWidget interface for FlowTableItem.
1772 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1773 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1775 2011-10-11 Ben Konrath <ben@bagu.org>
1777 Remove GWT styling from open button in details view.
1779 There are still some issues with how the details cell is arranged but
1780 this should be made to match Glom 1.20. I'm going to leave fixing this
1781 until I have Glom 1.20 up and running.
1783 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1784 style name on open button.
1785 * src/main/webapp/style.css: Move and edit details-navigation class.
1786 Re-arrange some classes to make them appear in the same order as the
1789 2011-10-07 Ben Konrath <ben@bagu.org>
1791 Update to GWT 2.4.0.
1793 * .gitignore: Ignore new cache directory.
1794 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1795 * pom.xml: Change GWT and maven plugin to 2.4.0.
1796 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1798 * src/main/java/org/glom/web/client/ClientFactory.java:
1799 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1800 * src/main/java/org/glom/web/client/OnlineGlom.java:
1801 Update source for API changes.
1802 * utils/build-onlineglom-war.sh: Remove cache directory before the
1805 2011-10-07 Ben Konrath <ben@bagu.org>
1807 Add navigation buttons in the details view.
1809 This isn't finished but I thought I'd commit what I have as it's a
1810 pretty good start. I still need to:
1812 1. Change the style so that it fits better into the current theme
1813 2. Adjust the details cell to expand as much as possible.
1815 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1816 click handlers to navigation buttons in the DetailsCells. Create a
1817 refreshData() method to get just the data from the server without the
1819 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1820 Update the tableSelector and browser title when the table name
1821 changes without using the tableSelector.
1822 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1823 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1824 getDetailsCells() to getCells(). Update variable names.
1825 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1826 method to set click handler on navigation button. Rename a few
1827 variables. Add navigation buttons where needed.
1828 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1829 variables and methods.
1830 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1831 navigation boolean and navigation table as required in the
1832 LayoutItemField DTO.
1833 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1834 variables for navigation along with getter/setter methods.
1836 2011-10-07 Ben Konrath <ben@bagu.org>
1838 Rename Field to DetailsCell.
1840 This is a refactor-only commit. No functionality has been added or
1843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1844 Update variable and method names.
1845 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1846 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1847 variable and method names.
1848 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1850 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1851 variable and method names.
1853 2011-10-07 Ben Konrath <ben@bagu.org>
1855 Create separate methods for layout and data the details view.
1857 This is a refactor-only commit. No functionality has been added or
1860 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1861 private methods: setData(), createLayout().
1863 2011-10-07 Ben Konrath <ben@bagu.org>
1865 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1867 This is part of a change to get navigation buttons in the details view
1868 but it should have been done this way from the start.
1870 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1871 for method name change in TableSelectionView.
1872 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1873 Create TableChangeEvent and set the browser title using the
1874 TableSelectionView API.
1875 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1876 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1877 Change getSelectedTable() to getSelectedTableName(). Add
1878 getSelectedTableTitle().
1880 2011-10-07 Ben Konrath <ben@bagu.org>
1882 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1884 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1886 2011-10-07 Ben Konrath <ben@bagu.org>
1888 Update TableChangeEvent to use newTableName naming convention.
1890 This makes the class more consistent with GWT naming conventions.
1892 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1893 Update for method name change in TableChangeEvent.
1894 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1895 for method name change in TableChangeEvent.
1896 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1897 newTableName variable and getter method. Make toDebugString()
1900 2011-09-30 Ben Konrath <ben@bagu.org>
1902 Disable the pager in the list tables when the data row count is less than the minimum.
1904 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1905 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1907 2011-09-30 Ben Konrath <ben@bagu.org>
1909 Add empty rows to the end of related list and list view tables.
1911 I also extracted the cell rendering classes from the ListTable because
1912 the code was becoming a little crazy with all the anonymous inner
1913 classes. My plan is to use these cell rendering classes in the details
1914 view as well so this refactor will be needed for that change.
1916 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1917 set the row count in related list tables if the data has more rows
1918 than the minimum number of rows visible.
1919 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1920 row count in list view tables if the data has more rows than the
1921 minimum number of rows visible.
1922 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1923 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1925 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1926 for rendering TYPE_NUMERIC cells. The code was extracted from the
1928 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1929 class for rendering cells with buttons in list views. The code was
1930 extracted from the ListTable class.
1931 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1932 for rendering TYPE_TEXT cells. The code was extracted from the
1934 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1935 Add empty rows to the end of the data if required. Implement
1936 ListTable.getMinNumVisibleRows().
1937 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1938 cell renderer code to public classes. Return null in
1939 Column.getValue() for empty rows. Add new abstract method:
1940 getMinNumVisibleRows(). Move code to set the row count of the list view
1941 table to ListViewImpl.
1942 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1943 empty rows to the end of the data if required. Implement
1944 ListTable.getMinNumVisibleRows().
1947 2011-09-27 Ben Konrath <ben@bagu.org>
1949 Use GWT.log for client-side debugging statements.
1951 These are optimized out when deployed so I should have used this method
1952 in the first place. These statements will eventually be replaced with some sort
1953 of notification in the browser.
1955 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1956 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1957 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1958 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1959 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1961 2011-09-27 Ben Konrath <ben@bagu.org>
1963 Put tableselector on the right, back to list link on right.
1965 The idea is that the table selector is acting like a label for the
1966 currently displayed table so it should be placed below the document title. This
1967 puts the table title in a similar position to where it is in Glom.
1969 * mockups/details-contacts.html:
1970 * mockups/details-projects.html:
1971 * mockups/listview-contacts.html:
1972 * mockups/listview-projects.html:
1973 * mockups/style.css:
1974 Update mockups to match how the interfaces currently look.
1975 * src/main/webapp/style.css: Swap positions of backlink with the table
1976 selector. Add some space on the left side of the table selector to
1977 line things up with the document title.
1979 2011-09-27 Ben Konrath <ben@bagu.org>
1981 Add field colouring to details view.
1983 This change re-works how field colouring works. The colour formatting
1984 information is now set to the client with the layout information instead of
1985 with the data. This eliminates the need to send the same colour strings for
1986 data in list view column when colour information is set.
1988 In order to set an alternate colour for negative numeric values, the
1989 number is now sent to client and formatted with the GWT NumberFormat class.
1991 This change also fixes:
1993 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1995 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1996 internationalization framework which is needed for client side numeric
1998 * src/main/java/org/glom/web/client/Utils.java: New file for some
1999 client static utility methods.
2000 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2001 the DataItem object to the Field class. Use a utility method to
2002 create the foreignKeyValue string.
2003 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2004 alignment and text colours in the constructor. Add setData(DataItem)
2005 method. Remove setText(String) method.
2006 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2007 colour information to GlomTextCell. Create and use GlomNumberCell for
2008 rendering numbers. Use utility method to get the string for the
2009 primary key of the key provider. Re-work how the horizontal alignment
2011 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2012 formatting to layout information. Methods for converting the libglom
2013 formatting information were moved from DBAccess.
2014 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2015 numeric formatting (it's now done on the client side). Don't set text
2016 colours in DataItem. Move libglom formatting conversion methods to
2018 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2019 getters/setters for text colour information.
2020 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2021 for transferring the libglom NumericFormat information to the client.
2022 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2023 and getters/setters for: GlomNumericFormat, background colour and
2024 foreground colour strings.
2026 2011-09-26 Ben Konrath <ben@bagu.org>
2028 Simplify code that iterates through the LayoutGroup.
2030 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2032 2011-09-26 Ben Konrath <ben@bagu.org>
2034 Accept Eclipse formatting for OnlineGlomServiceAsync.
2036 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2038 2011-09-26 Ben Konrath <ben@bagu.org>
2040 Don't use the ListDBAccess classes to get the primary key layout information.
2042 This was causing a bug where the wrong index for the hidden primary key
2043 was being sent to the client.
2045 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2046 primary key while creating the LayoutGroup DTO. Create a
2047 LayoutItemField DTO for hidden primary keys. Don't use the
2048 RelatedListDBAccess because it was only used for getting the primary
2050 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2051 access modifier from public to protected for getPrimaryKeyField() and
2052 getPrimaryKeyLayoutItemField().
2053 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2054 abstract method getExpectedResultSize() because RelatedListDBAccess
2055 doesn't have enough info to implement it.
2056 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2057 Remove @Override for getExpectedResultSize().
2058 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2059 Remove method getExpectedResultSize().
2061 2011-09-23 Ben Konrath <ben@bagu.org>
2063 Log which layout (list or details) the ignored item is from.
2065 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2067 2011-09-23 Ben Konrath <ben@bagu.org>
2069 Remove annotations that turn off code formatting in DataItem.
2071 * src/main/java/org/glom/web/shared/DataItem.java:
2073 2011-09-23 Ben Konrath <ben@bagu.org>
2075 Rename GlomField to DataItem and update associated methods.
2077 This is a rename-only refactor. No functionality has been added or
2080 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2081 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2082 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2083 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2084 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2085 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2086 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2087 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2088 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2089 * src/main/java/org/glom/web/server/database/DBAccess.java:
2090 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2091 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2092 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2093 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2094 * src/main/java/org/glom/web/shared/DataItem.java:
2095 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2096 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2098 2011-09-23 Ben Konrath <ben@bagu.org>
2100 Rename GlomDocument to DocumentInfo and update associated methods.
2102 This is a rename-only refactor. No functionality has been added or
2105 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2106 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2107 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2108 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2109 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2111 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2113 2011-09-20 Ben Konrath <ben@bagu.org>
2115 Require java-libglom 1.17.3.
2117 This picks up the fix for the seg fault problem with the Scenes table
2118 in the Openismus Film Manager example.
2122 2011-09-20 Ben Konrath <ben@bagu.org>
2124 Change the way sort clause is added for primary key when no sort clause is requested.
2126 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2127 before the sort clause is created. When a sort clause is not requested, the
2128 sort clause is created by finding the primary key in the LayoutFieldVector
2131 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2133 2011-09-20 Ben Konrath <ben@bagu.org>
2135 Log error message if no documents are found in the configured directory.
2137 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2138 Extract the glom file extension string to a private static final class
2139 variable (mostly as syntactic sugar). Accept a minor formatting change.
2140 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2141 the example glom.document.directory configuration property to make it
2142 more clear that it can any directory, not just the home directory.
2144 2011-09-18 Ben Konrath <ben@bagu.org>
2146 Add related lists to details view.
2148 The related list table has support for paging and sorting just like the
2149 table in the list view.
2151 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2152 SQL queries for the related list tables.
2153 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2154 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2156 Rename getList methods to getListView and add comments. Remove
2157 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2158 it being unused. Add methods: getDetailsLayoutAndData(),
2159 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2160 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2161 Create the layout and set the data for the fields in one async call
2162 instead of two. Create related lists where appropriate.
2163 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2164 for method name changes in OnlineGlomService.
2165 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2166 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2167 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2169 * src/main/java/org/glom/web/client/ui/ListView.java:
2170 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2171 tableName from setCellTable(). Create a ListViewTable instead of
2173 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2174 represent a data field in the details view.
2175 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2176 from addDetailsCell() to Field class. Keep track of the Fields and
2177 Portals in the details view.
2178 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2179 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2180 and add a method to get it. Add method to set the contents of the
2182 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2183 New class for related list tables. This class has the data provider
2184 for the related list table.
2185 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2186 abstract class which is the base class for the ListViewTable and the
2188 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2189 New class for list view tables. This class has the data provider for
2190 the list view table.
2191 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2192 methods for related list tables. Add more information to the
2193 LayoutItemField and LayoutItemPortal DTOs.
2194 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2195 Remove debugging print statement.
2196 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2197 Remove debugging print statements. Add primary key field to SQL count
2199 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2200 Remove unnecessary LayoutFieldVector parameter from
2201 getResultSizeOfSQLQuery() method.
2202 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2203 New class for related list table database access.
2204 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2205 class that is a wrapper DTO for details view layout and data.
2206 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2207 new 'fromField' string to this DTO.
2208 * src/main/webapp/style.css: Remove bottom margin and override top
2211 2011-09-15 Ben Konrath <ben@bagu.org>
2213 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2215 This sets things up to make it easier to add the data retrieval for
2216 related lists (portals). No user noticeable changes were made with
2219 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2220 class has the code to retrieve the layouts and access the
2221 database using the new database helper classes.
2222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2223 Most of the functionality has been removed from this class. This
2224 class now represents the public interface for the client side
2225 code. It also deals with configuring the servlet and cleaning
2226 things up when the servlet is stopped.
2227 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2228 of static methods into this utility class.
2229 * src/main/java/org/glom/web/server/database/DBAccess.java:
2230 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2231 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2232 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2233 These classes have the database retrieval code. The class hierarchy
2234 has been setup to make it easy to reuse code for similar
2237 2011-09-06 Ben Konrath <ben@bagu.org>
2239 Create separate classes for list table code and the data provider.
2241 As part of this refactor, I also split up the code a bit to make it
2244 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2245 table code to two new classes (below).
2246 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2247 with code from ListViewImpl.
2248 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2249 New file with code from ListViewImpl.
2251 2011-09-06 Ben Konrath <ben@bagu.org>
2253 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2255 This fixes the LayoutItemPortal DTO to match the libglom layout object
2258 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2260 2011-09-01 Ben Konrath <ben@bagu.org>
2262 Set title of Portals in the Details View.
2264 * pom.xml: Bump required version of java-libglom to 1.17.1.
2265 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2266 widget creation to its own class. Add comments to constructor.
2267 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2268 The code is mostly from the Group class with the title now set.
2269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2270 title of Portal. Update some comments. Fix some code formatting.
2272 2011-09-01 Ben Konrath <ben@bagu.org>
2274 Remove TODO comment for the flow table column width.
2276 The flow table column width is working correctly and doesn't need to be
2277 changed. See this mailing list post for more info:
2279 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2281 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2283 2011-08-27 Ben Konrath <ben@bagu.org>
2285 Add document title (database name) to top of the browser page.
2287 I added the document title to the TableSelecitonView but that will
2288 change if / when we add a view that doesn't require table selection.
2290 * mockups/details-contacts.html:
2291 * mockups/details-projects.html:
2292 * mockups/listview-contacts.html:
2293 * mockups/listview-projects.html:
2294 * mockups/style.css: Add document title to mockups to keep things
2296 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2297 sizes to account for the document title.
2298 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2299 Set the document title when it has been retrieved from the server.
2300 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2301 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2302 and implement setDocumentTitle(String) method.
2303 * src/main/webapp/style.css: Add ID for document title style.
2305 2011-08-25 Ben Konrath <ben@bagu.org>
2307 Add NavigationType enum to LayoutItemPortal DTO.
2309 This is the start of adding support for Portals to the Details View.
2311 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2312 LayoutItem_Portal.navigation_type enum from libglom to
2313 LayoutItemPortal.NavigationType enum.
2314 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2315 NavigationType enum, field for storing the NavigationType and getter
2318 2011-08-25 Ben Konrath <ben@bagu.org>
2320 Implement the flow table layout in the Details View.
2322 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2323 FlowTable to Group to account for the renamed class.
2324 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2325 File. This is a container widget that implements the Glom details view
2326 flow table behaviour.
2327 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2328 org/glom/web/client/ui/FlowTable.java.
2329 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2330 so that the size of the subgroups are a closer match to the size of
2331 the Glom subgroups. This makes the flowtable layout match the layout
2332 in Glom for the Music Collection example file.
2334 2011-08-16 Ben Konrath <ben@bagu.org>
2336 Create container element for LayoutItemPortal in Details View.
2338 This will help me develop the layout for the FlowTable.
2340 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2341 fieldPanel variable to detailsCell.
2343 2011-08-15 Ben Konrath <ben@bagu.org>
2345 Set the height of the data element in the Details View.
2347 I changed the InlineLabels (text in a span element) to Labels (text in
2348 a div element) so that I could set the height of the details-data
2349 elements instead of the details-cell parent elements. This allows the
2350 the details-data element to display the correct height if style is
2351 applied that shows the height.
2353 This change has the added benefit of allowing the order of the labels
2354 and data elements to be changed for right-to-left languages.
2356 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2357 InlineLabels to Labels.
2358 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2359 InlineLabels to Labels. Set the height of the data element.
2360 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2361 multiline text height in the Formatting DTO.
2362 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2363 for multiline height along with getter and setter methods.
2364 * src/main/webapp/style.css: Adjust style to account for the change
2365 from span elements to div elements in the details cell.
2367 2011-08-15 Ben Konrath <ben@bagu.org>
2369 Make the List View appearance match the mockups.
2371 It doesn't match exactly but it's much better than it was.
2373 * mockups/listview-contacts.html: Remove unused css classes.
2374 * mockups/listview-projects.html: Remove unused css classes.
2375 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2376 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2377 for mainPanel instead of VerticalPanel (table). Set style name on
2378 CellTable. Set style name on Details column. Right-align Details
2380 * src/main/webapp/style.css: Adjust properties to match the mockups.
2382 2011-08-12 Ben Konrath <ben@bagu.org>
2384 Add better support for subgroups in the details view.
2386 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2387 changed FlowTable constructor.
2388 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2389 support for subgroups and subgroup-titles.
2390 * src/main/webapp/style.css: Add CSS class for subgroups and
2393 2011-08-12 Ben Konrath <ben@bagu.org>
2395 Return the top level LayoutGroup title.
2397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2399 2011-08-11 Ben Konrath <ben@bagu.org>
2401 Make the TableSelector header match the mockup.
2403 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2404 the layout panel. Properly lineup the table selection header with
2405 the list and details view.
2406 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2407 margin around the details view.
2408 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2409 Rename listBox variable to tableSelector. Set id for the style sheet.
2410 Use a FlowPanel instead of a HorizontalPanel.
2411 * src/main/webapp/style.css: Add properties to make the TableSelector
2412 box match the mockups.
2414 2011-07-13 Ben Konrath <ben@bagu.org>
2416 Update install script for java-libglom version change.
2418 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2421 2011-07-13 Ben Konrath <ben@bagu.org>
2423 Add support sub-group in the details view.
2425 I also removed the code that special-cased the default details view
2428 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2430 I still have to make a proper flowtable.
2432 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2433 Don't special-case default details view layout.
2434 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2435 addLayoutField() as I'm going to use it.
2436 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2437 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2439 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2440 extracted from DetailsViewImpl.GroupPanel. Add support for
2442 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2443 column count when getting the details layout.
2445 2011-07-12 Ben Konrath <ben@bagu.org>
2447 Set browser title with database and table titles.
2449 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2450 Set the browser title when the table changes and when the activity
2452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2453 title when retrieving document info (the GlomDocument object).
2454 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2455 with getter and setter methods. Remove unused convenience constructor.
2456 Use default code formatting.
2458 2011-07-12 Ben Konrath <ben@bagu.org>
2460 Ignore LayoutItemPortals in the details view.
2462 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2465 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2466 LayoutItemPortal layout objects.
2467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2468 LayoutItemPortal objects when retrieving the details layout.
2469 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2470 file. This is an empty class and just used to get type information for
2473 2011-07-12 Ben Konrath <ben@bagu.org>
2475 Use java-libglom 1.17.0.
2479 2011-07-11 Ben Konrath <ben@bagu.org>
2481 Remove "Table:" label from table selector.
2483 This matches a recent change in the Glom UI.
2485 * mockups/details-contacts.html:
2486 * mockups/details-projects.html:
2487 * mockups/listview-contacts.html:
2488 * mockups/listview-projects.html: Remove the "Table:" label from the
2490 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2492 2011-07-11 Ben Konrath <ben@bagu.org>
2494 Add main groups to the details view.
2496 This makes things look a little nicer in the details view. The next step
2497 is to implement the flowtable.
2499 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2500 resources from the standard gwt css theme. Standard.css is now
2501 included in OnlineGlom.html so that the online glom css rules have
2502 precedence over the gwt theme.
2503 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2504 the whole LayoutGroup to the DetailsView instead of just the titles.
2505 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2506 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2507 details layout with a helper class (GroupPanel). I might extract this
2508 class when I make the full flowtable.
2509 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2510 string as default so I don't have to worry about NPEs when processing
2512 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2513 note beside OnlineGlom.gwt.xml above).
2514 * src/main/webapp/style.css: Add default font-size to body to override
2515 the font-size set by the standard theme. Don't use h2 tags for
2516 group-title. Create new details-cell class.
2518 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2520 ConfiguredDocument: Set the port number too.
2522 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2523 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2524 Glom document. Presumably this worked sometimes so far because there is a
2525 default port number.
2527 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2529 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2531 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2532 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2533 correct, though we should throw an exception too.
2535 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2537 Fix a addDocuemnt typo.
2539 * src/main/java/org/glom/web/shared/Documents.java
2540 (Documents.addDocuemnt): Rename to addDocument().
2541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2542 (OnlineGlomServiceImpl.getDocuments): Adapt.
2544 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2546 Slightly improved log output when connection fails.
2548 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2549 (ConfiguredDocument.setUsernameAndPassword):
2550 We don't know for sure if it' the username/password that's wrong, so
2551 rephrase the message.
2552 Also ouput the exception message, though it's generic in this case.
2554 2011-07-08 Ben Konrath <ben@bagu.org>
2558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2559 added braces to a one line if statement because the Eclipse formatter
2560 was getting confused.
2562 2011-07-07 Ben Konrath <ben@bagu.org>
2564 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2566 These should really be two separate tasks but I counldn't get things to
2567 work with GWT 2.2.0 and Eclipse 3.7.
2571 * .settings/org.eclipse.jdt.core.prefs:
2572 * .settings/org.eclipse.jdt.ui.prefs:
2573 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2574 * .settings/org.eclipse.m2e.core.prefs:
2575 Add new config files. Update current files. Remove references to the
2576 webtools plugins as we're not using any of the webtools features.
2577 * .gitignore: Add logs directory which is created when running with
2579 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2580 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2581 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2583 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2585 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2587 onlineglom.properties: Add explanatory comments.
2589 * src/main/resources/onlineglom.properties: Also change the default user
2590 from ben to someuser, to avoid the risk of people thinking we just
2591 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2593 2011-06-28 Ben Konrath <ben@bagu.org>
2595 Use filename in Log for incorrect passwords.
2597 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2598 getFileName(String) method to get the filename from the URI.
2600 2011-06-28 Ben Konrath <ben@bagu.org>
2602 Add the table name to the URL token for the ListPlace.
2604 This makes things consistent between the DetailsPlace and the
2605 ListPlace. It also allows the the ListPlace to be bookmarked.
2607 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2608 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2610 Remove getDefaultListLayout(). The default layout is now returned
2611 by the getListLayout() method when the table name is an empty string.
2612 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2613 Add table name field. Change to a new ListPlace when the table
2614 has been changed. Use getListLayout() for getting the default
2616 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2617 Add table name field. Set the correct table name in the list box
2618 when loading from bookmark. This corrects a problem for the
2620 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2621 Move table name to super-class (HasSelectableTable). Move document
2622 and table URL keys to super-class in HasSelectableTable.
2623 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2624 Add table name field. Add Tokenizer class with URL key common to
2625 the subclasses (DetailsPlace and ListPlace).
2626 * src/main/java/org/glom/web/client/place/ListPlace.java:
2627 Add table name. Add code to parse the URL token.
2628 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2629 Update ListPlace construction with empty table name string.
2630 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2631 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2632 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2633 Update ListPlace construction with table name string.
2634 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2635 Change defaultTableName field to tableName to reflect how it's now
2636 used. Update the getter and setter methods.
2638 2011-06-28 Ben Konrath <ben@bagu.org>
2640 Enable the table selector in the DetailsView.
2642 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2645 Remove getDefaultDetailsLayout(). The default layout is now returned
2646 by the getDetailsLayout() method when the table name is an empty
2648 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2649 event handler for table change event. Change to using
2650 getDetailsLayout() for the default details layout.
2651 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2653 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2654 when navigating to the details place.
2656 2011-06-27 Ben Konrath <ben@bagu.org>
2658 Use filename based unique document ID in URL and for RPC.
2660 The document ID is the glom document name with spaces (' ') replaced
2661 with pluses ('+') and without the .glom extension.
2663 This change is mostly a string substitution of 'documentTitle' for
2664 'documentID'. The only code change is the addition of a Documents DTO to get the
2665 filename to document title mappings as indicated below.
2667 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2668 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2669 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2670 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2671 Use Documents DTO to create the document links in the document
2673 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2674 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2675 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2676 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2677 * src/main/java/org/glom/web/client/place/ListPlace.java:
2678 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2679 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2680 * src/main/java/org/glom/web/client/ui/ListView.java:
2681 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2682 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2683 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2684 * src/main/java/org/glom/web/server/Log.java:
2685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2686 getDocumentTitles() to getDocuments() and return the Documents DTO.
2687 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2688 transferring the filename to document title mappings.
2690 2011-06-25 Ben Konrath <ben@bagu.org>
2692 Make the authentication popup work again.
2694 This bug was introduced when I extracted ConfiguredDocument to its own class.
2696 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2697 correct success / fail status in setUsernameAndPassword().
2699 2011-06-25 Ben Konrath <ben@bagu.org>
2701 Use filename as unique key for configuring database usernames and passwords.
2703 This replaces the use of the Glom document title which could change
2704 depending on the locale. Thanks to Murray Cumming for pointing out this
2707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2708 * src/main/resources/onlineglom.properties:
2710 2011-06-24 Ben Konrath <ben@bagu.org>
2712 Pass primary key value to DetailsView.
2714 This enables the DetailsView to load the correct data.
2716 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2717 primary key value field and set in constructor. Pass primary key
2718 value to getDetailsData().
2719 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2720 variables for document title and primary key value.
2721 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2722 key value to the DetailsPlace.
2724 2011-06-24 Ben Konrath <ben@bagu.org>
2726 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2728 This allows the primary key to be retrieved by the Details button. This
2729 functionality has not been implemented yet but it's in the works.
2731 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2732 the LayoutGroup result to ListView.setCellTable instead of all of its
2733 fields individually.
2734 * src/main/java/org/glom/web/client/ui/ListView.java:
2735 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2736 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2737 get the primary key for the table.
2738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2739 index of the primary key in the LayoutGroup accounting for hidden
2740 primary keys. Rename getJavaNumberFormat() to
2741 convertToJavaNumberFormat() for consistency. Cleanup / add some
2743 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2744 field for primary key index and a field to indicate whether the
2745 primary key is hidden or not.
2747 2011-06-23 Ben Konrath <ben@bagu.org>
2749 Rename getTableData methods to getListData.
2751 This is a rename refactor for consistency with other methods.
2753 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2754 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2755 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2758 2011-06-23 Ben Konrath <ben@bagu.org>
2760 Extract the ConfiguredDocument innerclass into its own class.
2762 This makes the servlet code more object oriented.
2764 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2765 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2767 new ConfiguredDocument class.
2769 2011-06-21 Ben Konrath <ben@bagu.org>
2771 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2773 This makes things more inline with how libglom works and reduces code
2774 duplication. This refactor lays the groundwork for adding the primary key to
2775 the LayoutGroup object.
2777 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2778 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2779 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2780 Change method names to getListLayout and getDefaultListLayout for
2781 consistency. Use LayoutGroup as the DTO for the list layout instead of
2782 ColumnInfo and LayoutListTable.
2783 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2784 new method names along with the LayoutGroup object for transferring the
2786 * src/main/java/org/glom/web/client/ui/ListView.java:
2787 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2788 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2789 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2791 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2792 Replaced with LayoutGroup.
2793 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2794 expectedResultSize and defaultTableName fields which are needed for
2796 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2797 type field which is needed for the list layout but will also be
2798 useful for the details layout as things progress.
2799 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2800 Make class abstract. Remove the unnecessary
2801 getFormattingHorizontalAlignment method. Add setFormatting method.
2803 2011-06-16 Ben Konrath <ben@bagu.org>
2805 Add scripts for building and installing war.
2807 These will help when updating OnlineGlom but they're also good
2808 supplemental documentation of the build and deployment proceeding.
2810 * utils/build-onlineglom-war.sh: New file.
2811 * utils/install-onlineglom-war.sh: New file.
2813 2011-06-16 Ben Konrath <ben@bagu.org>
2815 Create wrapper class to create consistent log messages.
2817 I wrapped methods in the Log class of gwt-log to add the method names
2818 from the servlet and create consistent formatting of the document title
2819 and table names in the log messages.
2821 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2823 log methods to use methods from wrapped Log class.
2825 2011-06-16 Ben Konrath <ben@bagu.org>
2827 Remove superfluous conditional return.
2829 Thanks to Murray Cumming for pointing this out!
2831 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2833 2011-06-15 Ben Konrath <ben@bagu.org>
2835 Return an ArrayList of LayoutGroups for the Details layout.
2837 This corrects a problem with the details layout as it can have more
2838 than one top level LayoutGroup.
2840 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2841 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2842 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2843 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2844 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2845 with ArrayList of LayoutGroups for the details view layout.
2846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2847 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2848 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2849 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2850 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2851 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2853 2011-06-14 Ben Konrath <ben@bagu.org>
2855 Use cast_dynamic method to determine the libglom LayoutItem type.
2857 This is better than finding the LayoutItem type by using the string
2858 returned from the get_part_type_name() method.
2860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2862 2011-06-14 Ben Konrath <ben@bagu.org>
2864 Add method names to log entries in the servlet.
2866 This helps when tracking down deployment problems.
2868 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2870 2011-06-14 Ben Konrath <ben@bagu.org>
2872 Add data to the DetailsView using a hard-coded primary key value.
2874 The layout and functionality of the DetailsView is not complete. This
2875 is just a checkpoint so the patch doesn't get too big.
2877 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2878 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2879 Add getDetailsData() servlet method.
2880 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2881 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2882 LayoutFields are added to the DetailsView.
2883 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2884 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2885 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2886 take the string for the title instead of the object.
2887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2888 Add implementation getDetailsData() along with some private helper
2890 * src/main/webapp/style.css: Add padding to details-data class. Add a
2891 details-label class with the same padding as the details-data class.
2893 2011-06-03 Ben Konrath <ben@bagu.org>
2895 Use presenter.goTo() to change to the DetailsPlace.
2897 This will make things easier when we need to open the DetailsView with
2898 data specific to the row that was clicked.
2900 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2902 2011-06-02 Ben Konrath <ben@bagu.org>
2904 Add CSS file from mockups.
2906 I'm adding this now because it's going to be useful to have when
2907 developing the DetailsView. The TableSelectionView and ListView aren't
2910 * src/main/webapp/OnlineGlom.html:
2911 * src/main/webapp/style.css:
2913 2011-06-02 Ben Konrath <ben@bagu.org>
2915 Use String.isEmpty() to check for empty string.
2917 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2919 2011-06-02 Ben Konrath <ben@bagu.org>
2921 Display main layout group titles in the DetailsView.
2923 This is the start of the DetailsActivity/DetailsView implementation.
2925 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2926 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2927 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2928 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2929 Get the layout information for the details view from the server and set
2930 the main layout group titles.
2931 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2932 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2933 Add addLayoutGroup() and addLayoutField() methods. This are just
2934 temporary methods for creating the the details view that will change
2936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2937 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2939 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2940 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2941 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2942 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2943 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2944 Data Transfer Objects that mimic the libglom object structure. These are
2945 used for transferring the details layout but could also be used for
2946 transferring the list layout.
2948 2011-05-27 Ben Konrath <ben@bagu.org>
2950 Reset the AuthenticationPopup when clearing the ListView.
2952 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2954 2011-05-27 Ben Konrath <ben@bagu.org>
2956 Fix problem with onlineglom.properties file loading.
2958 The old way worked in Eclipse but not on the server. Loading the
2959 onlineglom.properties file now works in Eclipse and on the server.
2961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2963 2011-05-24 Ben Konrath <ben@bagu.org>
2965 Update gwt-log from 3.1.0 to 3.1.2.
2967 Gwt-log 3.1.0 has been marked as depreciated.
2971 2011-05-24 Ben Konrath <ben@bagu.org>
2973 Add comment to ListActivity.goTo() method.
2975 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2977 2011-05-24 Ben Konrath <ben@bagu.org>
2979 Remove FIXME in convertGdkColorToHtmlColour()
2981 The Gdk::Color value returned by libglom is 16-bits per channel on both
2982 64 and 32-bit platforms.
2984 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2986 2011-05-19 Ben Konrath <ben@bagu.org>
2988 Improve performance of initial ListView load.
2990 I removed a round trip to the server for getting the default table name
2991 and then requesting information about that table. This also removes a potential
2992 problem with the table change handler not being setup in time to receive the
2993 table change event from the ListActivity.
2995 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2996 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2997 getDefaultLayoutListTable() method. Improve comments.
2998 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2999 getDefaultLayoutListTable() method instead of firing a table change
3000 event to get the table to load.
3001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3002 implementation of getDefaultLayoutListTable() method.
3003 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3006 2011-05-19 Ben Konrath <ben@bagu.org>
3008 Override toDebugString() in TableChangeEvent.
3010 This is useful to have for debugging.
3012 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3014 2011-05-19 Ben Konrath <ben@bagu.org>
3016 Add a "Back to List" link when at the DetailsPlace.
3018 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3019 Populate the CellTable based on the selected table of the ListBox if
3020 it's set otherwise use the default table. This allows the "Back to
3022 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3023 Remove Place from constructors. Add a setPlace() method. Add
3024 goToPlace() method. Set class as presenter for TableSelectionView.
3025 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3026 Use the same TableSelectionActivity when switching between the List and
3028 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3029 Subclass the new HasSelectableTablePlace. This removes some duplicate
3031 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3032 New class to represent Places that display the TableSelectionView.
3033 * src/main/java/org/glom/web/client/place/ListPlace.java:
3034 Subclass the new HasSelectableTablePlace. This removes some duplicate
3036 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3037 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3038 Add Presenter interface. Add setBackLinkVisible() method. Add
3039 setBackLink() method.
3041 2011-05-18 Ben Konrath <ben@bagu.org>
3043 Enable the "Details" buttons.
3045 Right now only an empty details view is displayed.
3047 * src/main/java/org/glom/web/client/ClientFactory.java:
3048 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3049 Add DetailsView to ClientFactory.
3050 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3051 A basic activity for the details view.
3052 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3053 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3055 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3056 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3058 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3059 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3060 unnecessary super() in constructor.
3061 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3062 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3063 really shouldn't create a new TableSelectionActivity for both the ListPlace
3064 and the DetailsPlace so this should be considered a temporary solution.
3065 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3066 New file. Represents a URL for the details view.
3067 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3068 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3069 A basic details view interface and implementation.
3070 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3071 Enable the "Details" buttons.
3073 2011-05-12 Ben Konrath <ben@bagu.org>
3075 Use a LayoutPanel with multiple display areas for main layout.
3077 This is mostly a refactor in that there are no changes from the user
3078 point of view. These changes are required so that we can swap out the list view
3079 with the details view when the user clicks the "Details" button.
3081 * src/main/java/org/glom/web/client/ClientFactory.java:
3082 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3083 OnlineGlomView. Add TableSelectionView, ListView and
3084 AuthenticationPopup.
3085 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3086 for main layout. Add display regions for main activities. Add
3087 activity manager for for main activities.
3088 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3089 file from parts of the deleted OnlineGlomActivity.
3090 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3091 New file from parts of the deleted OnlineGlomActivity.
3092 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3093 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3094 New files for app wide table change event.
3095 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3096 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3097 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3098 Activity mappers for the main activities replace the deleted app-wide
3100 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3101 Fix a spelling error in he comment.
3102 * src/main/java/org/glom/web/client/ui/ListView.java:
3103 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3104 Renamed from LayoutListView and modified for MVP. This still not a
3105 proper dumb view as prescribed by the MVP pattern but it works for now.
3106 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3107 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3108 New widget stripped out of the deleted OnlineGlomView.
3109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3110 Remove hack that is fixed by this patch.
3112 2011-05-06 Ben Konrath <ben@bagu.org>
3114 Rename OnlineGlomPlace to ListPlace.
3116 The only change besides the rename is that url will now display #list
3117 instead of #Document.
3119 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3120 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3121 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3122 * src/main/java/org/glom/web/client/place/ListPlace.java:
3123 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3125 2011-05-06 Ben Konrath <ben@bagu.org>
3127 Use Presenter for app navigation.
3129 This is the proper way to deal with Place (URL) changes with the MVP
3132 * src/main/java/org/glom/web/client/ClientFactory.java:
3133 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3134 PlaceHistoryMapper and PlaceHistoryHandler.
3135 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3136 PlaceHistoryMapper and PlaceHistoryHandler.
3137 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3138 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3139 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3140 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3141 Add Presenter interface and setPresenter methods. Rename addHyperLink
3142 to addDocumentLink taking only the document title as a parameter.
3144 2011-04-14 Ben Konrath <ben@bagu.org>
3146 Prompt for db username/password if they haven't been set.
3148 This is implemented with a popup widget that is contained within the
3149 OnlineGlomView and managed by the OnlineGlomActivity.
3151 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3152 methods for checking and setting the database username and password.
3153 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3154 new methods for checking and setting the database username and
3156 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3157 Display authentication popup if the JDBC connection to the database
3158 has not been authenticated.
3159 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3161 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3162 for dealing with the authentication popup.
3163 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3164 Implement the methods for dealing with the authentication popup.
3165 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3166 try to executed queries if the database connection hasn't been
3167 authenticated. Implement methods for checking and setting the
3168 database username and password.
3170 2011-04-12 Ben Konrath <ben@bagu.org>
3172 Make log messages a little clearer.
3174 Add a dash betweeen the document title and the table name.
3176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3178 2011-04-12 Ben Konrath <ben@bagu.org>
3180 Protect against NPEs when cleaning up database resources.
3182 While this isn't strictly necessary because the exception is caught,
3183 not protecting against the NPEs makes it harder to find the real error
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3188 2011-04-12 Ben Konrath <ben@bagu.org>
3190 Move configuration of the servlet to the constructor.
3192 The servlet will be initialized even if the database authentication
3193 information is not set or correct. I still need to add the UI for prompting
3194 the user for the authentication information when it's required.
3196 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3197 javadocs for getDocumentTitles() method.
3198 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3199 Set error message when RPC fails.
3200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3201 glom files directory from the configuration file. Try to set the
3202 database authentication information for the specific document if it's
3203 set and works otherwise try to use the global authentication
3204 information set for the directory.
3205 * src/main/resources/onlineglom.properties: Moved from
3206 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3207 Added detailed comments for the new keys.
3209 2011-04-11 Ben Konrath <ben@bagu.org>
3211 Remove unnecessary @Override in DocumentSelectionViewImpl.
3213 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3215 2011-04-11 Ben Konrath <ben@bagu.org>
3217 Remove center alignment in DocumentSelectionView.
3219 The title element is still centred but the document titles and bottom
3220 sentence are both left-aligned.
3222 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3224 2011-04-11 Ben Konrath <ben@bagu.org>
3226 Change 'Demo' naming convention to 'Document'.
3228 This is just a rename refactor with no functional changes to the code.