1 2012-05-15 Murray Cumming <murrayc@murrayc.com>
3 Fix the use of translations.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
6 Add updateTitlesForLocale().
7 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
8 Call it to discard unwanted translations and to make getTitle() return
9 the wanted translation wihout the need for the client code to specify a locale.
10 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
11 getTitle(): Fallback to the original title, as libglom does.
13 2012-05-15 Murray Cumming <murrayc@murrayc.com>
15 Document: Correctly report the number of available translation locales.
17 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
18 the available locale IDs list.
19 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
20 testLocales: Test this.
22 2012-05-15 Murray Cumming <murrayc@murrayc.com>
24 SqlUtils: Use camelCase.
26 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
27 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
28 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
29 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
30 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
31 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
33 2012-05-15 Murray Cumming <murrayc@murrayc.com>
35 Use jOOQ's tableByName() and fieldByName.
37 * pom.xml: Use jOOQ 2.3.1 to get the new API.
38 * src/main/java/org/glom/web/server/SqlUtils.java:
39 build_sql_select_step_with_where_clause(), .createField(),
40 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
41 so we can get correct quoting and escaping. Thanks to Lukas Eder for
42 adding this, and other things, to jOOQ.
44 2012-05-15 Murray Cumming <murrayc@murrayc.com>
46 SqlUtils: Remove the Connection parameters.
48 * src/main/java/org/glom/web/server/SqlUtils.java:
49 build_sql_select_with_key(), build_sql_select_with_where_clause(),
50 createSelect(), build_sql_select_step_with_where_clause(),
51 build_sql_count_select_with_where_clause(),
52 build_sql_select_count_rows(): Remove the Connection parameter because
53 jOOQ does not actually need a connectionwhen it is just used to build
55 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
57 * src/main/java/org/glom/web/server/ReportGenerator.java:
59 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
61 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
62 Constructor, getListData(), getResultSizeOfSQLQuery():
63 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
64 getSelectQuery(), getCountQuery():
65 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
66 getSelectQuery(), getCountQuery():
67 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
68 getNavigationRecord(): Adapted.
70 2012-05-14 Murray Cumming <murrayc@murrayc.com>
74 * src/main/java/org/glom/web/server/SqlUtils.java:
75 get_find_where_clause_quick(): Use a comparison of
76 lowercase values, instead of a simple equals. Regular Glom
77 uses the PostgreSQL ILIKE operator but jOOQ does not
78 support that just yet, though it will soon.
80 2012-05-14 Murray Cumming <murrayc@murrayc.com>
82 TableToViewDetails: Use a real serialization ID.
84 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
85 Though this does not fix the serialization problem.
87 2012-05-12 Murray Cumming <murrayc@murrayc.com>
89 Added LayoutItemPortalDeepCloneTest.
91 2012-05-11 Murray Cumming <murrayc@murrayc.com>
93 Make navigation work again.
95 * src/main/java/org/glom/web/server/libglom/Document.java:
96 Add getLayoutItemFieldShouldHaveNavigation().
97 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
98 Replace get/setAddNavigation() with the partly-existing
99 get/setNavigationTableName(), with an empty string being no navigation,
100 because this is simpler. Use the new
101 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
103 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
104 Add updateFieldsExtras() and call setNavigationTableName in it.
105 getDetailsLayoutGroup(),
106 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
107 createLayout(): Adapted.
108 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
109 Constructor: Adapted.
111 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
112 Replace get/setAddNavigation() with get/setNavigation(), returning a
113 TableToViewDetails class with both the table name and UsesRelationship,
114 because both are need. The previous code used java-libglom's output
115 variable (strangely, via sharedptr) to return both, but we cannot really
117 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
118 getNavigationRecord(): Adapt. However, we cannot actually use the cache
119 here because it somehow gets set to null during deepCopy(). I must test this.
120 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
121 testGetSuitableTableToViewDetails(): Adapted.
123 TODO: Find out why deepClone() is not quite working.
125 2012-05-11 Murray Cumming <murrayc@murrayc.com>
127 DBAccess: Simplify the retrievel of full field details.
129 * src/main/java/org/glom/web/server/database/DBAccess.java
130 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
131 because the Document loading should have done this.
133 2012-05-11 Murray Cumming <murrayc@murrayc.com>
135 Document: Correct loading of doubly-related layout fields.
137 * src/main/java/org/glom/web/server/libglom/Document.java:
138 loadUsesRelationship(): Actually set the related relationship, instead
139 of only setting it if it's not found.
141 2012-05-09 Murray Cumming <murrayc@murrayc.com>
143 Replace all appearances of Colour with color.
145 Because US English is dominant.
147 2012-05-09 Murray Cumming <murrayc@murrayc.com>
149 Use colors in HTML format, solving a warning about an unused function.
151 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
152 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
153 Add *asHTMLColor() versions of methods.
154 TODO: However, we should create and cache the results on the server.
155 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
156 * src/main/java/org/glom/web/client/ui/list/ListTable.java
157 * src/main/java/org/glom/web/server/ConfiguredDocument.java
158 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
159 Use the asHTMLcolor() versions.
161 2012-05-09 Murray Cumming <murrayc@murrayc.com>
163 ListViewTable: Constructor: Take the table name as a parameter.
165 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
166 Constructor: Take the tableName, and set the member variable, because
168 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
169 setCellTable(): Pass the table name.
170 This makes navigation to non-default tables work again. I don't know
171 why it worked before in the master branch.
173 2012-05-07 Murray Cumming <murrayc@murrayc.com>
175 ConfiguredDocument: Restore correct addition of hidden primary key items.
177 * src/main/java/org/glom/web/client/ui/list/ListTable.java
178 (ListTable.createCellTable): Uncomment out the check for the hidden
180 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
181 add primary key items for top-level lists and portals, as before,
182 instead of adding them to each group.
183 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
184 Actually implement the extra methods such as setHiddenPrimaryKey() and
185 comment that these are used only for top-level list groups and in portals.
186 This strangeness suggests even more that this should not be squeezed
187 into the LayoutGroup class.
189 2012-05-07 Murray Cumming <murrayc@murrayc.com>
191 Fix Formatting loading.
193 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
194 getFormattingUsed(): Remove the duplicate Formatting member variable
195 in favour of the one from the base class.
196 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
197 Initialize a new Formatting instead of using null by default, so we
198 have some defaults, instead of having to initialize one later just to
199 get the same defaults. This also makes loading of formatting from the
200 document work, because that expected a non-null.
202 2012-05-07 Murray Cumming <murrayc@murrayc.com>
204 RelatedListTable: Make sure that the tableName is set.
206 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
207 Constructor: Take the tableName so it is available later. Otherwise,
208 the server assumes that we mean the default table and cannot find the
210 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
211 setData(): Pass the tableName to the RelatedListTable constructor.
213 2012-05-07 Murray Cumming <murrayc@murrayc.com>
217 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
218 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
219 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
221 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
223 * src/main/java/org/glom/web/server/database/DBAccess.java:
224 convertResultSetToDTO(), getPortal():
225 * src/main/java/org/glom/web/server/database/ListDBAccess.java
227 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
228 Add checks for null objects and out of range access, with log messages to
229 give hints so we can fix these properly.
231 2012-05-07 Murray Cumming <murrayc@murrayc.com>
233 Portals: some corrections.
235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
237 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
238 constructor: Use getRelationshipNameUsed() instead of getName(), because
239 that is what is meant.
240 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
241 getFromField(): Fix a typo, to get the field name, not the table name.
242 * src/main/java/org/glom/web/server/database/DBAccess.java:
243 getPortal(): Fix a typo that stopped this from working.
245 2012-05-07 Murray Cumming <murrayc@murrayc.com>
247 LayoutItemPortal: Also override getTitleOriginal().
249 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
250 This lets the base getTitle() with no parameters work.
251 TODO: Test this properly.
253 2012-05-06 Murray Cumming <murrayc@murrayc.com>
255 LayoutItemPortal: getTitle*(): Use the relationship title.
257 2012-05-06 Murray Cumming <murrayc@murrayc.com>
259 LayoutItemField: Fix loading of custom titles.
261 * src/main/java/org/glom/web/server/libglom/Document.java
262 loadDataLayoutItemField(): The title, if any, instead of the field
263 title, is stored in a title_custom node. Load it from there.
264 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
266 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
267 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
268 getTitle*() overrides.
269 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
272 2012-05-06 Murray Cumming <murrayc@murrayc.com>
274 LayoutItemField: Fall back to field titles, so some are really shown.
276 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
277 Override getTitleOriginal() and getTitle(), as in java-libglom.
278 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
281 2012-05-06 Murray Cumming <murrayc@murrayc.com>
283 Correct use of setExpectedResultSize().
285 * src/main/java/org/glom/web/server/ConfiguredDocument.java
286 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
287 Use setExpectedResultSize only on top-level groups (for instance, the
288 list layout) or on child portals (in details views).
289 Use the correct table name for portals to avoid SQL errors.
290 Update the expected counts when returning cached layouts.
292 2012-05-06 Murray Cumming <murrayc@murrayc.com>
294 Document: Interpret no group column count as 1.
296 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
297 default, though we now check for this in the UI code anyway.
299 2012-05-06 Murray Cumming <murrayc@murrayc.com>
303 2012-05-06 Murray Cumming <murrayc@murrayc.com>
305 Translatable: Use Hashmap instead of Treemap because GWT supports it.
307 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
308 The use of Treemap lead to this error from async methods, with no
310 "The response could not be deserialized"
312 2012-05-06 Murray Cumming <murrayc@murrayc.com>
314 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
316 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
317 when using the Google -> GWT Compile, or
318 g toolbar button -> GWT Compile Project... feature in Eclipse.
320 2012-05-06 Murray Cumming <murrayc@murrayc.com>
322 ListTable.addColumn(): Protect against a null Formatting.
324 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
325 Create a default Formatting if it is null, because that is the simplest
328 2012-05-06 Murray Cumming <murrayc@murrayc.com>
330 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
332 * src/main/java/org/glom/web/server/ConfiguredDocument.java
333 updateLayoutGroup(): Check that the field is not null.
335 2012-05-06 Murray Cumming <murrayc@murrayc.com>
337 ListViewImpl: Protected against a bad cast error.
339 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
340 onEnterKeyDown(): Do not cast without an instanceof check.
342 2012-05-06 Murray Cumming <murrayc@murrayc.com>
344 ListTable: Protect against an out of range error.
346 * src/main/java/org/glom/web/client/ui/list/ListTable.java
347 createCellTable(): This is unlikely, but can happen while debugging.
349 2012-05-06 Murray Cumming <murrayc@murrayc.com>
351 AsyncMessage onFailure() callbacks: Log the exception message.
353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
354 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
355 * src/main/java/org/glom/web/client/activity/ListActivity.java:
356 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
357 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
358 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
359 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
360 These are useful clues when something is wrong.
362 2012-05-06 Murray Cumming <murrayc@murrayc.com>
364 ConfiguredDocument: Avoid a null dereference.
366 * src/main/java/org/glom/web/server/ConfiguredDocument.java
367 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
368 details maps are created.
370 2012-05-06 Murray Cumming <murrayc@murrayc.com>
372 Document: Correct the port number parsing.
374 * src/main/java/org/glom/web/server/libglom/Document.java:
375 This lets us actually connect to the database and show the document.
377 2012-05-05 Murray Cumming <murrayc@murrayc.com>
381 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
382 user-interaction, asking us to load a temporary URL in a browser.s
383 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
384 which is apparently necessary for testing the service. See the comment.
385 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
386 Show the exception, if any. This is how I saw the 404 in the HTML in
389 2012-05-05 Murray Cumming <murrayc@murrayc.com>
391 DocumentTest: Move the .glom files into the resources directory.
393 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
394 URI via getResource().
396 2012-05-05 Murray Cumming <murrayc@murrayc.com>
398 Document: Remove the FieldIdentifies inner class.
400 * src/main/java/org/glom/web/server/libglom/Document.java: We only
401 use the Relationship (though the same function in libglom is maybe
402 used in other ways) and so this removes a compiler warning.
404 2012-05-05 Murray Cumming <murrayc@murrayc.com>
406 Document.load() Remove the error code parameter.
408 * src/main/java/org/glom/web/server/libglom/Document.java: load():
409 Remove the parameter. We do not set it yet and it could never have
410 worked as an output parameter (though maybe it did in java-libglom).
411 We could use an exception if we really want the failure reason.
412 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
414 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
415 setUp(), testGetSuitableTableToViewDetails(): Adapt.
417 2012-05-05 Murray Cumming <murrayc@murrayc.com>
419 Make some inner classes static.
421 * src/main/java/org/glom/web/server/ConfiguredDocument.java
422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
423 * src/main/java/org/glom/web/server/ReportGenerator.java
424 * src/main/java/org/glom/web/server/libglom/Document.java
425 Make all inner classes static that can be static.
427 2012-05-05 Murray Cumming <murrayc@murrayc.com>
429 OnlineGlomServiceImpl: Do not load and check for java-libglom.
431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
432 init(): We do not use java-libglom any more.
434 2012-05-05 Murray Cumming <murrayc@murrayc.com>
436 Remove mentions of java-libglom.
438 * README: Remove mention of java-libglom, because it no longer needed.
439 * utils/build-onlineglom-war.sh:
440 * utils/check-and-recover-tomcat.py:
441 * utils/install-onlineglom-war.sh: Remove these as they are no longer
442 useful. Building is now far easier, with no need for jhbuild.
444 2012-05-05 Murray Cumming <murrayc@murrayc.com>
446 Fix the build (mvn package)
448 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
449 (LayoutGroup): Make the LayoutItemList inner class static and protected.
450 Otherwise the GWT Java->Javascript compilation fails with just this
451 error, during mvn package or when attempting to view in a browser,
452 in the GWT developer mode in Eclipse.
454 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
455 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
456 [INFO] Compiling module org.glom.web.OnlineGlom
457 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
458 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
459 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
460 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
461 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
462 [INFO] [ERROR] Cannot proceed due to previous errors
464 It has taken me 2 days to find out what was causing that. After reducing
465 the code, the compiler eventually showed me the full error message.
467 2012-05-04 Murray Cumming <murrayc@murrayc.com>
469 ConfiguredDocument: Cache the cloned and stripped layouts.
471 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
472 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
473 layout in a map, so we can retrieve it again without rebuilding it.
475 2012-05-04 Murray Cumming <murrayc@murrayc.com>
477 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
479 2012-05-04 Murray Cumming <murrayc@murrayc.com>
481 libglom classes: Implement some auto-generated emthods.
483 2012-05-04 Murray Cumming <murrayc@murrayc.com>
485 Add GwtTestOnlineGlomService.
487 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
488 However, this (and the other GwtTest*) does not seem to run during
491 2012-05-04 Murray Cumming <murrayc@murrayc.com>
493 Remove use of unsupported features from client code.
495 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
496 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
497 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
498 Use our client version of StringUtils instead of the apache commons one.
500 However, the GWT Javascript compliation still fails.
502 2012-04-25 Murray Cumming <murrayc@murrayc.com>
504 Add a Field class and implement some loading of it in Document.
506 2012-04-25 Murray Cumming <murrayc@murrayc.com>
508 Initial Document loading implementation, instead of libglom.
510 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
511 and Translatable classes, and adapt the rest of the code to use them.
512 However, this is still missing Layout and Field classes and loading.
514 2012-04-24 Murray Cumming <murrayc@murrayc.com>
516 Use of jOOQ: Move Field creation into a utility method.
518 * src/main/java/org/glom/web/server/SqlUtils.java:
519 This lets us improve it more easily.
521 2012-04-24 Murray Cumming <murrayc@murrayc.com>
523 Use of jOOQ: Improve the code to COUNT a sub-select.
525 * src/main/java/org/glom/web/server/SqlUtils.java:
526 Move initial query creation into
527 build_sql_select_step_with_where_clause().
528 build_sql_select_count_rows(): Use the jOOQ API instead of
529 concatentating text, because a jOOQ Select*Step is a TableLike,
530 which is what from() takes.
532 2012-04-23 Murray Cumming <murrayc@murrayc.com>
534 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
536 * pom.xml: Depend on jooq.
537 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
538 methods with jOOQ, based on the C++ implementations in libglom,
539 with some changes to the logic required by jooQ.
540 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
542 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
543 * src/main/java/org/glom/web/server/ReportGenerator.java:
544 * src/main/java/org/glom/web/server/SqlUtils.java:
545 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
546 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
547 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
548 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
549 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
550 Adapt. In particular, the SqlUtils methods now need to take a Connection,
551 because jOOQ needs that, though it seems unnecessary.
553 This is not quite finished. Ideally jOOQ would help us to build
554 table_name.field_name names, quoting and escaping them properly.
555 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
557 2012-04-21 Murray Cumming <murrayc@murrayc.com>
559 Move use of Glom.build_sql*() into a new SqlUtils class.
561 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
562 to wrap Glom.build_sql*(). The parameter types are still Glom one,
563 but this will make it easier to start using something other than
564 libglom or SqlBuilder.
566 2012-04-21 Murray Cumming <murrayc@murrayc.com>
568 Update the project URL.
570 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
572 2012-04-21 Murray Cumming <murrayc@murrayc.com>
574 Main layout: Use a FlowTable instead of absolute positioning.
576 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
577 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
578 child panels/widgets must have an absolute position. But that is annoying, so
579 this adds a FlowTable and puts the child panels in there.
581 2012-04-21 Murray Cumming <murrayc@murrayc.com>
583 GwtTestOnlineGlom: Comment out unused code.
585 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
586 Eclipse has started to say that some code is unused.
588 2012-04-21 Murray Cumming <murrayc@murrayc.com>
590 Update to the latest versions of dependencies.
592 * pom.xml: Update version numbers of dependencies to the latest
594 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
596 * src/main/java/org/glom/web/server/ReportGenerator.java:
597 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
598 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
599 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
601 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
602 Modify the imports where necessary.
604 2012-04-17 Murray Cumming <murrayc@murrayc.com>
606 Style: Remove overflow:hidden from searchbox
608 * src/main/webapp/style.css: Because this pushes the Back To Link
609 label/link on to the next row, which is then hidden due to the
610 hard-coded (in ems) height.
612 2012-04-20 Murray Cumming <murrayc@murrayc.com>
614 Remove some duplicate code.
616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
617 getDocumentInfo(): This must have been duplicated during the merge from the
622 2012-04-19 Murray Cumming <murrayc@murrayc.com>
624 Reports: Localize the waiting for report message.
626 * src/main/java/org/glom/web/client/activity/ReportActivity.java
627 start(): Get the message from the contants.
628 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
630 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
631 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
632 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
633 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
634 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
635 Update these files with the English text for newer strings for now.
637 2012-04-19 Murray Cumming <murrayc@murrayc.com>
639 Reports: Show a message while waiting for the report.
641 * src/main/java/org/glom/web/client/ui/ReportView.java
642 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
643 Add setWaitingText(), to show a message saying that we are
644 waiting for the report to be ready.
645 * src/main/java/org/glom/web/client/activity/ReportActivity.java
646 start(): Call setWaitingText() before calling the async
649 2012-04-19 Murray Cumming <murrayc@murrayc.com>
651 ReportGenerator: Specify date and time formats.
653 * src/main/java/org/glom/web/server/ReportGenerator.java:
654 createFieldValueElement(): Use the default (and localized)
655 short formats, though we still need a way to show 4-digit
656 years without providing the format for every locale.
657 * src/main/java/org/glom/web/server/database/DBAccess.java:
658 convertResultSetToDTO(): Use the short formats here too.
660 2012-04-18 Murray Cumming <murrayc@murrayc.com>
662 ReportGenerator: Use the correct numeric formatting.
664 * src/main/java/org/glom/web/server/ReportGenerator.java
665 createFieldExpression(), createFieldValueElement(): Take the
666 whole LayoutItem_Field instead of just the field name, so
667 we have access to the formatting.
668 createFieldValueElement(): Use JRTextField.setPattern() to
669 specify the numeric formatting, with the help of a
670 regular DecimalFormat.
672 2012-04-18 Murray Cumming <murrayc@murrayc.com>
674 ReportGenerator: Avoid showing null for group by titles.
676 * src/main/java/org/glom/web/server/ReportGenerator.java
677 generateReport(): Use setBlankWhenNull() on the field title
678 style too, because this is used for values in group by
681 2012-04-18 Murray Cumming <murrayc@murrayc.com>
683 ReportGenerator: Add a colon to titles in vertical groups.
685 * src/main/java/org/glom/web/server/ReportGenerator.java
686 addFieldToDetailBandVertical(): Pass true for the withColon
689 2012-04-18 Murray Cumming <murrayc@murrayc.com>
691 ReportGenerator: Simplify the code by using Position more.
693 2012-04-18 Murray Cumming <murrayc@murrayc.com>
695 Reports: Support vertical groups, roughly.
697 * src/main/java/org/glom/web/server/ReportGenerator.java:
698 addToReport(): Rename to addGroupToReport() and, if necessary,
699 call the new addVerticalGroupToReport() method.
700 createFieldValueElement(): Let the caller specify the Y position
703 2012-04-17 Murray Cumming <murrayc@murrayc.com>
705 Reports: Allow a second report to be shown.
707 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
708 clear(): Do not remove the HTML widget, which broke the whole layout.
710 2012-04-17 Murray Cumming <murrayc@murrayc.com>
712 Locales drop-down: Show that we use English by default.
714 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
715 fillView(): When we use English, just because that is the default, when
716 no locale is specified, show that in the Locales drop-down instead of
717 just showing the first item.
719 2012-04-17 Murray Cumming <murrayc@murrayc.com>
721 Unselect the Report/Locale/Table combo item when appropriate.
723 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
724 setPlace(): clear reportName if this is not a ReportPlace.
725 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
726 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
727 When the provided name is empty, unselect all items, so that none are
728 indicated. This uses a for loop because I cannot find a single method
731 2012-04-17 Murray Cumming <murrayc@murrayc.com>
733 Report: Give the user a way to get back to the list.
735 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
736 start(), setPlace(): Show the Back To List link on reports, and also
737 interpret selecting the empty report item as back to list.
739 2012-04-13 Murray Cumming <murrayc@murrayc.com>
741 Really show the selected Report name.
743 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
744 setPlace(): Store the reportName here, if it is that kind of Place.
745 fillView(): Set the selected Report after filling the list of reports.
746 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
747 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
748 null Strings, though we need some way to unselect all ListBox items
751 2012-04-13 Murray Cumming <murrayc@murrayc.com>
753 ReportGenerator: Try to avoid some problems.
755 * src/main/java/org/glom/web/server/ReportGenerator.java
756 addField(): Try to avoid duplicates, and avoid using a null
759 2012-04-13 Murray Cumming <murrayc@murrayc.com>
761 Reports: Use quickFind.
763 * src/main/java/org/glom/web/client/OnlineGlomService.java;
764 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
765 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
766 getReportHTML(): Add a quickFind parameter.
767 * src/main/java/org/glom/web/client/activity/ReportActivity.java
768 start(): Pass the quickFind parameter.
769 * src/main/java/org/glom/web/server/ReportGenerator.java
770 generateReport(): Take a quickFind parameter.
772 2012-04-13 Murray Cumming <murrayc@murrayc.com>
774 ReportPlace: Actually use the report name.
776 * src/main/java/org/glom/web/client/place/ReportPlace.java
777 getPlace(): Do not assign the report name to the quickfind.
779 2012-04-13 Murray Cumming <murrayc@murrayc.com>
781 Show java.library.path when complaining.
783 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
784 init(): When telling us to check java.library.path, show the
787 2012-03-06 Murray Cumming <murrayc@murrayc.com>
789 ReportGenerator: Do not show nulls.
791 2012-03-06 Murray Cumming <murrayc@murrayc.com>
793 ReportGenerator: Make the title font larger.
795 2012-03-06 Murray Cumming <murrayc@murrayc.com>
797 ReportGenerator: Put field titles inside groups, if there are groups.
799 2012-03-06 Murray Cumming <murrayc@murrayc.com>
801 ReportGenerator: Take the Report itself instead of the name and group.
803 * src/main/java/org/glom/web/server/ConfiguredDocument.java
804 Remove getReportLayoutGroup().
805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
806 getReportHTML(): Pass the report instead
807 of its name and layout group.
808 * src/main/java/org/glom/web/server/ReportGenerator.java
809 generateReport(): Use the report object to use the title
812 2012-03-06 Murray Cumming <murrayc@murrayc.com>
814 ReportGenerator: Remove designBand parameters.
816 * src/main/java/org/glom/web/server/ReportGenerator.java:
817 Make designBand a class member instead of passing it to all
820 2012-03-06 Murray Cumming <murrayc@murrayc.com>
822 ReportGenerator: Add lines, a bit like in the desktop version.
824 * src/main/java/org/glom/web/server/ReportGenerator.java
825 addToReport(): Use JRDesignLine.
827 2012-03-06 Murray Cumming <murrayc@murrayc.com>
829 ReportGenerator: Correct the title positions and use some bold style.
831 * src/main/java/org/glom/web/server/ReportGenerator.java:
832 Break the code up into reusable functions, correct the placement of
833 titles, and use normal/bold styles as in the reports in the desktop
836 2012-03-06 Murray Cumming <murrayc@murrayc.com>
838 ReportGenerator: Add a header band to show the field titles.
840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
841 getReportHTML(): Pass the localeId to the ReportGenerator
843 * src/main/java/org/glom/web/server/ReportGenerator.java
844 constructor: Take the localeID so we can get translated field
846 generateReport(), addToReport(), addFieldToBand(): Add field
847 titles in a column header band.
849 2012-03-05 Murray Cumming <murrayc@murrayc.com>
851 Reports drop-down list: Some improvement.
853 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
854 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
855 Adedd setSelectedReport(),
856 setReportList(): Add a blank line so that the user can select the
858 * src/main/java/org/glom/web/client/activity/ReportActivity.java
859 start(): Show the current report by calling setSelectedReport().
860 This does not seem to work yet.
862 2012-03-05 Murray Cumming <murrayc@murrayc.com>
864 DetailsActivity, ListActivity: Move some variables into a base class.
866 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
867 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
868 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
869 the clientFactory, documentID, tableName and authenticationPopup into
870 a base class, to avoid duplication.
872 2012-03-05 Murray Cumming <murrayc@murrayc.com>
874 Translate the Reports label.
876 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
877 Get the "Reports" label string from the constants.
878 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
879 perties: Add Reports to the constants.
881 2012-03-05 Murray Cumming <murrayc@murrayc.com>
883 Reports: Implement grouping.
885 * src/main/java/org/glom/web/server/ReportGenerator.java:
886 Handle LayoutItem_GroupBy items and try to do the right thing
887 with JRDesignGroup. It seems to work.
889 2012-03-04 Murray Cumming <murrayc@murrayc.com>
891 Actually show some data with JasperReports.
893 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
894 getReportHTML(): Move most code into a ReportGenerator class.
895 * src/main/java/org/glom/web/server/ReportGenerator.java:
896 Recurse into sub-groups, adding fields to the JasperDesign's details
897 band. Note that we must set an arbitrary width and height, or it just
898 will not show any data.
900 2012-03-04 Murray Cumming <murrayc@murrayc.com>
902 Reports Chooser: Show the titles, not the names.
904 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
905 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
906 and the names as the values.
907 * src/main/java/org/glom/web/server/ConfiguredDocument.java
908 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
909 group now that we provide the report name, so it should always
912 2012-02-15 Murray Cumming <murrayc@murrayc.com>
914 Depend on jasperreports.
916 * pom.xml: Add the dependency. My plan is to use this on the
919 2012-01-31 Murray Cumming <murrayc@murrayc.com>
921 Implement navigation to report places.
923 * src/main/java/org/glom/web/client/activity/ReportActivity.java
924 start(): Do not bother to handle all events here.
925 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
926 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
927 Added getSelectedReport().
928 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
929 .java: start(): When handling a change to the reports chooser,
930 call getSelectedReport() and goTo() its ReportPlace.
931 * src/main/java/org/glom/web/client/ui/ReportView.java
932 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
933 Added setReportHTML() which puts the html in a gwt HTML widget.
934 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
935 getReportHTML(): Return "TODO" just to show that this works.
937 2012-01-31 Murray Cumming <murrayc@murrayc.com>
939 Make ReportPlace usable.
941 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
943 * src/main/java/org/glom/web/client/place/ReportPlace.java:
944 Correct the @prefix annotation.
946 2012-01-31 Murray Cumming <murrayc@murrayc.com>
948 OnlineGlomService: Return report HTML rather than the LayoutGroup.
950 * src/main/java/org/glom/web/client/OnlineGlomService.java:
951 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
952 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
953 Change getReportLayout() to getReportHMTL() because we will not need to
954 parse or render the report layout on the client side.
955 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
956 getReportLayout(): Return the libglom LayoutGroup type because we will
957 not need to convert to a shared type, because this will not be used on
959 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
962 Note that there is still no implementation for this.
965 2012-01-27 Murray Cumming <murrayc@murrayc.com>
967 Add a (empty) Report Place, View, and Activity.
969 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
971 * src/main/java/org/glom/web/client/place/HasTablePlace.java
972 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
973 this into a superclass:
974 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
975 and also use it as the base of this new ReportPlace:
976 * src/main/java/org/glom/web/client/place/ReportPlace.java
978 * src/main/java/org/glom/web/client/ui/ReportView.java
979 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
980 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
981 Add these, containing mostly boiler-plate for now.
983 * src/main/java/org/glom/web/client/OnlineGlomService.java
984 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
985 * src/main/java/org/glom/web/server/ConfiguredDocument.java
986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
987 Add API to get the LayoutGroup for the report.
989 2012-01-23 Murray Cumming <murrayc@murrayc.com>
991 Add and fill a Reports drop-down list box.
993 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
995 * src/main/java/org/glom/web/client/OnlineGlomService.java:
996 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
998 Added getReports(document, table, localeID), calling
999 ConfiguredDocument.getReports().
1000 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1001 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1002 Added setReportsList() and a list widget.
1003 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1004 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1009 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1011 Translations: Add Esperanto.
1013 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1014 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1015 properties: Add this translation because someone took the time to make it.
1017 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1019 Adapt to the java-libglom 1.21.7 API.
1021 * src/main/java/org/glom/web/server/ReportGenerator.java:
1022 addToReport(): get_group_secondary_fields() is now
1023 get_secondary_fields().
1026 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1028 Use the latest java-libglom version.
1030 * pom.xml: Use java-libglom 1.21.7.
1032 2012-03-03 Ben Konrath <ben@bagu.org>
1034 Display date and time in details view.
1036 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1038 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1040 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1042 Require the latest java-libglom.
1044 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1046 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1048 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1050 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1051 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1052 an empty quickfind string. I also corrected libglom to create only
1053 empty where clauses for empty quickfind strings, but this avoids the
1056 2012-02-24 Ben Konrath <ben@bagu.org>
1058 Improve the tabs in the Notebook widget.
1062 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1064 Translations: Try to translate the strings.
1066 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1067 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1068 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1069 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1070 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1071 Take the Open translation from GTK+'s .po files.
1072 Take the Details translation from Glom's po files.
1073 I have added the other strings to Glom so we can get translations that way:
1074 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1076 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1078 TableSelectionViewImpl: Put the search label and entry in a div.
1080 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1081 Put the search widgets in a FlowTable so that the CSS can be used to
1082 style them while keeping them together.
1083 * src/main/webapp/style.css: Mention the new div.
1085 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1087 Translate more strings in more locales.
1089 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1090 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1091 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1092 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1093 Translate the "Details" and "Open" string too.
1095 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1096 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1097 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1098 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1099 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1100 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1101 Add these new locales as placeholders though they currently contain English.
1103 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1105 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1108 Check the ConfiguredDocument* for null before using it.
1110 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1112 Tell Eclipse about the generated java files.
1114 * .classpath: This lets it find OnlineGlomConstants.java.
1115 It would be nice if Eclipse just used the maven build files.
1117 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1119 Prevent a crash when no locale is specified in the URL.
1121 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1122 Avoid returning a null string, obtained from
1123 Window.Location.getParameter(). This caused a crash when it was
1124 later passed to libglom's API.
1125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1126 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1127 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1128 guard against future null strings.
1130 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1132 Use the ?locale= query param instead of the &lang= token param.
1134 * src/main/java/org/glom/web/client/place/ListPlace.java
1135 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1136 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1137 Remove the lang token key and value.
1139 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1140 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1141 When the user selects a different locale from the chooser, use
1142 Window.Location.assign() to change the URL, which then causes a reload.
1144 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1146 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1147 * src/main/java/org/glom/web/client/activity/ListActivity.java
1148 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1149 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1150 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1151 * src/main/java/org/glom/web/client/ui/ListView.java:
1152 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1154 Remove localeID member variables and method/constructor parameters, instead
1155 using Utils.getCurrentLocaleID() when we need a localID to pass to
1158 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1160 Internationalize the UI strings.
1162 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1163 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1164 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1165 because it is unused. Messages are apparently strings that can have
1166 parameters, but we do not need that yet, so Contants will be enough for now.
1167 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1168 to say that we support the en and de locales.
1169 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1170 The original English strings.
1171 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1172 Some German translations of the English strings.
1173 The i18n goal then uses the .properties file to generate an
1174 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1175 returns an implementation that returns the translated strings.
1176 The documentation suggests putting these in src/java/*/client/, but it seems
1177 best to put it in src/resources/*/client/.
1178 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1179 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1180 instead of hard-coding them.
1181 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1182 but that does not seem to stop the build, though it confuses Eclipse.
1184 You can see the translated string by adding ?locale=de to the URL, like so:
1185 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1187 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1189 Improve null/empty String checks.
1191 * pom.xml: Add a dependency on commons-lang, to use
1192 org.apache.commons.lang.StringUtils.
1193 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1195 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1196 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1197 Use StringUtils.isEmpty().
1199 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1200 StringUtils class with a static isEmpty() function because we
1201 cannot use org.apache.commons.lang.StringUtils in client-side
1202 GWT code because it (apparently) cannot be compiled to javascript.
1203 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1204 * src/main/java/org/glom/web/client/activity/ListActivity.java
1205 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1206 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1207 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1208 * src/main/java/org/glom/web/client/place/ListPlace.java
1209 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1210 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1211 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1212 * src/main/java/org/glom/web/client/ui/details/Group.java
1213 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1214 our StringUtils.isEmpty() function.
1216 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1218 Update to the latest java-libglom API.
1220 * pom.xml: Require java-libglom 1.21.4.
1221 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1222 getDocumentInfo(), getListViewLayoutGroup():
1223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1225 * src/main/java/org/glom/web/server/database/DBAccess.java
1226 getFieldsToShowForSQLQueryAddGroup(),
1227 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1228 with either get_database_title_original() or
1229 get_database_title(localeID).
1231 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1233 ConfiguredDocument: Avoid a null pointer exception.
1235 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1236 Initialize localeID to "" to avoid returning a null String which
1237 causes a crash in java-libglom's swing-generated code.
1239 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1241 Some simple renaming.
1243 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1244 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1245 for localeChooser. This seems more appropriate and is less ambiguous
1246 particularly in the .css file.
1248 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1250 ConfiguredDocument: Rename the localedID private member variable.
1252 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1254 Adapt to the latest java-libglom API from git master.
1256 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1257 libglom now uses only Vector instead of List, which uses add() instead of
1260 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1262 ConfiguredDocument: Rename the localedID private member variable.
1264 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1266 Build a source tarball with mvn assembly:single
1268 * assembly.xml: Add this file.
1269 * pom.xml: Use the maven-assembly-plugin and tell it to use
1270 our assembly.xml file.
1272 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1274 OnlineGlomServiceImpl: Get .glom files recursively.
1276 * pom.xml: Depend on commons-io from org.apache.commons.
1277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1278 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1279 files recursively, and with the easier filter for the extension.
1280 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1281 simplify that code too.
1283 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1285 README: Mention that you must install java-libglom packages separately.
1287 But then it works, because java-libglom is now in the central maven
1290 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1292 locales drop-down: Show the correct selected locale when the URL changes.
1294 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1295 .java: setPlace(): Move some code into fillView().
1297 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1299 locales drop-down: Do not lose the primary key.
1301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1302 start(): onLocaleChange(): Pass the current primary key value,
1303 instead of an empty value.
1305 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1307 locales drop-down: Do not lose the drop-down selection.
1309 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1310 .java (TableSelectionActivity.fillView): Set the selected locale
1311 after changing the drop-down items (though we do not really need
1312 to change them just because the locale changes.)
1314 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1316 locales drop-down: Change the tables list when this changes.
1318 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1319 .java: TableSelectionActivity.start(): Move the async table titles
1320 retrieval into a private fillView() method and also call this when
1321 the chosen locale changes.
1322 Note that the document title is not actually translatable yet, but
1323 that is a problem that I should fix soon in libglom.
1325 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1327 Improve the placement of the locales drop-down.
1329 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1330 Put the title and locales drop-down in a div (gwt.FlowTable).
1331 * src/main/webapp/style.css: Add magic css properties to make this work.
1332 Also remove the left margin from the title so that it lines up with the
1335 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1337 locales selector: Show human-readable locale titles.
1339 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1340 getDocumentInfo(): Use java.util.Locale to show a real title of
1341 each locale, in the locale's own language.
1343 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1345 Add a language/locale selector drop-down.
1347 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1348 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1349 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1350 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1351 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1352 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1353 Add a ListBox to show the available locales. Add getLocaleSelector(),
1354 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1355 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1356 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1357 java: Add these classes.
1358 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1359 start(): Fill the locales ListBox. Handle its change event, firing a
1361 setPlace(): Show the selected locale as specified by the URL token.
1362 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1363 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1364 Handle LocaleChangeEvent, going to a new *Place with that locale.
1366 The placement of the ListBox is not pretty, and it currently uses the ID
1367 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1371 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1373 Search box: Show the search text from the URL token.
1375 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1376 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1377 Add setQuickFindText().
1378 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1379 .java: setPlace(): Store the queryText if the place is a ListPlace,
1380 and call TableSelectionView.setQuickFindText().
1382 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1384 Allow use of translations via, for instance, &lang=de in the URL.
1386 * pom.xml: Use the unstable java-libglom 1.21 version.
1388 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1389 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1391 init(): Instead of calling TranslatableItem.set_current_locale()
1392 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1393 However, this is only for default locales, which are not needed to
1394 change the locale in the URL.
1395 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1396 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1397 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1398 layout for a particular locale.
1399 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1400 Add get/setDefaultLocaleID().
1401 getDocumentInfo(), getListViewData(), getRelatedListData(),
1402 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1403 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1404 localeID parameter, so we can get the layout for a particular locale.
1406 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1407 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1408 * src/main/java/org/glom/web/client/place/ListPlace.java:
1409 Parse and construct a lang parameter too.
1411 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1412 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1413 passed to subsequent methods and constructors.
1414 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1415 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1416 Store the localeID from the *Place and pass it to other constructors
1417 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1419 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1420 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1421 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1422 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1423 * src/main/java/org/glom/web/client/ui/ListView.java:
1424 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1425 Take localeID parameters and pass them to subsequent constructors and
1426 methods, so that the layout is always retrieved for that locale.
1428 This is rather repetitive.
1430 Note that "" means the original (default) locale of the Glom document,
1431 which is usually English.
1433 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1435 Documents: Remove final keyword to fix startup configuration.
1437 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1438 final keywords on the private member variables because that breaks
1439 the startup, apparently (there are warnings) because it stops them
1440 from being serialized. I added these in the previous commit.
1442 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1444 Documents: Add some final keywords.
1446 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1449 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1451 OnlineGlomServiceImpl: Add to overview comments.
1453 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1454 Note that this is where all the document are loaded. They are not
1455 loaded freshly for each page.
1457 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1462 Add a TextBox for the text of a quick find.
1463 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1465 setBackLink(): Add a String quickFind parameter.
1466 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1467 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1468 to the base interface, because that is how TableSelectionViewImpl is used.
1469 * src/main/webapp/style.css: Add style for the search box and its label.
1471 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1472 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1473 Add these files, based on the existing TableChangeEvent and
1474 TableChangeEventHandlers.
1475 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1476 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1477 a ListPlace() that the user should be taken to.
1478 * src/main/java/org/glom/web/client/activity/ListActivity.java
1479 start(): Handle it here too and adapt the TableChangeEvent handler to
1480 pass the extra "" quickFind parameter to ListPlace.
1481 * src/main/java/org/glom/web/client/place/ListPlace.java:
1482 Constructor: Take an extra String quickFind parameter and store it,
1483 returning it from a new getQuickFind() method.
1484 getToken(): Put the quickFind text in the URL token.
1485 getPlace(): Parse the quickFind text from the URL token.
1486 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1487 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1488 ListPlace constructor.
1489 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1490 .java: start(): Add a Change handler for the TableSelectionView's
1491 TextBox (via its base HasChangeHandlers interface), firing the new
1492 QuickFindChangeEvent.
1493 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1494 pass the extra "" quickFind parameter.
1496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1497 setCellTable(): Add a String quickFind parameter and pass it to
1498 the ListViewTable() constructor.
1499 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1500 setCellTable() in the base interface, because that is how ListViewImpl
1503 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1504 Add a String quickFind member variable.
1505 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1506 Constructor: Add a String quickFind parameter, storing it in the
1507 base ListTable's member variable.
1508 onRangeChanged(): Pass quickFind to the
1509 OnlineGlomServiceAsync.getSortedListViewData() and
1510 OnlineGlomServiceAsync.getListViewData() methods.
1512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1513 getListViewData(), getSortedListViewData(): Add a String quickFind
1514 parameter, passing it to ConfiguredDocument.getListViewData().
1515 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1516 Change getListViewData(), getSortedListViewData() in the base interface,
1517 because that is how OnlineGlomServiceImpl is used, via this:
1518 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1519 Change getListViewData(), getSortedListViewData() here too.
1520 This class can apparently be used to asynchronously call methods on
1521 OnlineGlomService, and GWT seems to implement that after recognizing
1522 just the *Async name convention and the extra AsyncCallback parameters.
1524 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1525 getListViewData(): Add a String quickFind parameter, and pass it to
1526 ListViewDBAccess.getData().
1527 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1528 getListData(): Add a String quickFind parameter and pass it to
1530 getSelectQuery(): Add a String quickFind parameter.
1531 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1532 getSelectQuery(): Add a String quickFind parameter and use it with
1533 Glom.get_find_where_clause_quick() to pass a where_clause to
1534 Glom.build_sql_select_with_where_clause(), to actually filter the
1536 getData(): Add a String quickFind parameter, passing it to getListData().
1537 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1538 va: getData(): Pass an empty string to getListData() for the
1539 quickFind parameter.
1541 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1543 ListTable: Minor change.
1545 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1546 createCellTable(): Make this protected instead of public.
1548 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1550 Many files: Use final for the parameters and use the @override attribute.
1552 2012-01-22 Ben Konrath <ben@bagu.org>
1554 Add anchor links for single line text that starts with http, ftp and www.
1558 2012-01-22 Ben Konrath <ben@bagu.org>
1560 Add ellipsis to single line text in details view.
1564 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1566 Remove all javadoc author tags.
1568 Because they are awkward and meaningless when many people touch
1570 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1572 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1574 Revert the COPYING.LESSER to COPYING rename.
1576 Apparently both should be there if it is LGPL.
1578 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1580 *View: Remove unused imports.
1582 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1583 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1584 * src/main/java/org/glom/web/client/ui/ListView.java:
1585 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1586 Remove unused imports, as suggested by Eclipse.
1588 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1590 Move the *View::Presenter types, and some API into one base View.
1592 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1593 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1594 * src/main/java/org/glom/web/client/ui/ListView.java:
1595 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1596 Presenter, setPresenter() and clear() into a shared base interface,
1597 to avoid the unnecessary duplicate Presenter types and to more clearly
1598 show how the *Views share the same structure, even if they are not
1599 used polymorphically.
1601 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1602 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1604 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1605 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1606 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1608 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1611 Feel free to revert this if there is a good reason for the duplicate
1614 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1616 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1618 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1619 a class member instead of a local variable in the method.
1620 This lets us use it to get the view instances, for use in tests.
1621 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1622 beforeOnlineGlom(): Test some more details of the initial view.
1623 Again, this is not very useful.
1625 To really test gwt-glom we will need to start a local postgresql
1626 instance with local data, like the Glom tests in C++.
1628 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1630 pom.xml: Mention the LGPL license.
1632 * pom.xml: Add a licenses section.
1633 * COPYING.LESSER: Move this to COPYING, which
1634 previously contained the GPL. But gwt-glom is all LGPL.
1636 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1638 Add project information to README and pom.xml.
1640 * README: Add a brief description and mention some mvn
1642 * pom.xml: This extra information shows up in mvn site
1645 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1647 Use the latest java-libglom version.
1649 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1651 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1653 GwtTestOnlineGlom: Test a little more.
1655 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1656 protected rather than private, as suggested by the gwt-test-utils
1658 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1659 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1660 Test the initial visibility of the panels.
1662 However, this is not a very useful test.
1663 And I wonder how we should generally test using this idea for an
1664 activity/places app like ours where the real changes happen implicitly
1665 based on the history token/URL.
1667 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1669 Slight modification to *Mapper comments.
1671 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1672 (DataActivityMapper)
1673 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1675 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1677 Remove comments mentioning GIN because they are just copied from
1678 the example code and are apparently not helpful:
1679 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1680 Also change the mention of a class that is only in the example code.
1682 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1684 GwtTestOnlineGlom test: Minor changes.
1686 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1687 Avoid the long qualified class name and modify the comment
1688 because it is now obvious to me that the mocked class is the only
1689 custom one created via GWT.create().
1691 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1693 Tests: Added the beginnings of a test using gwt-test-utils.
1695 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1696 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1697 which tells gwt-test-utils what class will be tested.
1698 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1699 Add a simple (but empty) test case. One class, used by the OnlineGlom
1700 class, is mocked so that it can be created. However, I am not sure
1701 why only this class needs to be mocked.
1703 Note that mockito seems more popular, and clearer, than easymock,
1704 but I have not got that working yet. It might be a matter of the
1707 This test is run during mvn integration-test.
1709 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1711 Tests: Use junit4-style syntax instead of junit3-style.
1713 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1714 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1715 * src/test/java/org/glom/web/shared/DataItemTest.java:
1716 Use the @Test annotation rather than relying on the test*() prefix.
1717 Also no longer implement TestCase, to avoid triggering support for
1718 the junit3-way, which stops the annotations from working.
1719 Change the imports from import junit.framework.* to
1720 import org.junit.*, which is apparently the new way.
1722 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1724 Added a test for ListPlace token parsing and creation.
1726 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1727 This is much the same as DetailsPlaceTest.
1729 I wonder how we could test the other parts of the *Place API.
1731 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1733 DetailsPlace test: Also test getToken() and recreation via getPlace().
1735 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1736 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1737 recreate it, testing the recreated DetailsPlace for the same parameter
1740 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1742 Use the surefire-report plugin.
1744 * pom.xml: This generates a HTML report about the tests in
1745 target/site/surefire-report.html
1746 when you do mvn surefire-report:report. It seems to be popular/normal.
1748 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1750 Added a test for DetailsPlace.
1752 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1753 Test the getPlace() token parsing.
1755 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1757 Added a first unit test.
1759 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1760 * src/test/java/org/glom/web/shared/DataItemTest.java:
1761 This is a silly test but it is just to get things started. Note that
1762 maven/junit finds the test because it looks in src/test by default.
1764 2011-12-22 Ben Konrath <ben@bagu.org>
1766 Change charsetName to "UTF-8" when replacing line breaks.
1768 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1769 that work in Java (such as "UTF8") will not work when compiled to
1772 This fixes a problem with multi-line details view fields that have hard
1773 line breaks. The "License Text" field on this page demonstrates the
1776 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1778 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1780 2011-12-22 Ben Konrath <ben@bagu.org>
1782 Fix another bug with related list navigation.
1784 I've tested all the navigation buttons in all of the related lists
1785 so things should be good now.
1787 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1789 2011-12-22 Ben Konrath <ben@bagu.org>
1791 Fix a crasher when refreshing the list view with the default table.
1793 This crash will also happen when loading the list view with the default
1794 table from a link or bookmark.
1796 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1797 to the main document selection page when the document id hasn't been
1799 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1800 the main document selection page when the document id hasn't been
1802 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1803 values for the details place when the document id hasn't been set.
1804 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1805 values for the list place when the document id hasn't been set.
1807 2011-12-21 Ben Konrath <ben@bagu.org>
1809 Protect against NPE when glom.document.locale is not in config.
1811 This patch protects against an NPE when glom.document.locale is not in
1812 the config file. This NPE will also happen if glom.document.locale is
1815 The patch also updates the error message to display the class name when
1816 the getMessage() returns null. This was happening when the NPE was
1817 thrown and I had "Configuration Error: null". If an NPE is encountered
1818 with this patch, "Configuration Error: NullPointerException " will be
1821 This commit closes this bug:
1823 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1827 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1829 Rename onlineglom.properties to onlineglom.properties.sample.
1831 * src/main/resources/onlineglom.properties: Rename to:
1832 * src/main/resources/onlineglom.properties.sample:
1833 * src/main/resources/README: And add this file explaining that people
1834 should rename it back when deploying.
1836 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1838 Allow choosing the translation in the .properties file.
1840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1841 init(): Read a glom.document.locale value from the configuration file
1842 and call Glom's TransatableItem::set_current_locale() method.
1843 * src/main/resources/onlineglom.properties: Add a commented-out
1844 example of this new setting.
1846 It would be better to add &lang=de_DE to the URL, but the current
1847 libglom API does not allow us to do this easily. I am working on that.
1849 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1851 Avoid a crash in parsing of token parameters.
1853 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1854 ava: getTokenParams(): Do not crash if a parameter has a key but no
1855 value, and ignore parameters with neither.
1857 2011-12-17 Murray Cumming <murrayc@murayc.com>
1859 History token building/handling: Improve use of token parameters.
1861 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1862 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1863 and buildParamsToken(HashMap), for use by derived classes.
1864 Make the separator private because it is no longer be needed.
1865 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1866 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1867 instead of manual string concatenation.
1868 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1869 of hardcoded indices and awkward splitting code.
1870 * src/main/java/org/glom/web/client/place/ListPlace.java
1871 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1872 instead of manual string concatenation.
1873 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1874 of hardcoded indices and awkward splitting code.
1875 This should fix bug #666420
1877 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1879 Fix a Navgiation->Navigation typo in the code.
1881 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1882 Rename processNavgiation() to processNavigation().
1884 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1886 Fix a seperator->separator typo in the code.
1888 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1889 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1890 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1893 2011-12-15 Ben Konrath <ben@bagu.org>
1895 Cleanup some comments.
1897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1899 2011-12-14 Ben Konrath <ben@bagu.org>
1901 Replace \n with <br/> for multiline text in the details view.
1903 Vertical scrollbars are added when needed as well.
1905 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1907 2011-12-14 Ben Konrath <ben@bagu.org>
1909 Specify the font for document selection links.
1911 * src/main/webapp/style.css:
1913 2011-12-14 Ben Konrath <ben@bagu.org>
1915 Fix bouncy CellTable while paging.
1917 This doesn't currently work with related list tables in unselected
1920 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1922 2011-12-14 Ben Konrath <ben@bagu.org>
1924 Revamp the appearance of the document selection page.
1926 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1927 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1928 * src/main/webapp/style.css:
1930 2011-12-13 Ben Konrath <ben@bagu.org>
1932 Set navigation button column to the smallest size possible.
1934 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1936 2011-12-13 Ben Konrath <ben@bagu.org>
1938 Change OpenButton nomenclature to NavigationButton.
1940 Using NavigtionButton makes things more generic. Classes, methods and
1941 variables have been changed.
1943 This is a rename-only refactor.
1945 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1946 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1947 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1948 Renamed from OpenButtonCell.
1949 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1950 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1951 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1953 2011-12-12 Ben Konrath <ben@bagu.org>
1955 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1957 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1958 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1959 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1960 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1962 2011-12-12 Ben Konrath <ben@bagu.org>
1964 Update variable names and comments.
1966 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1967 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1969 2011-12-12 Ben Konrath <ben@bagu.org>
1971 Properly initialize numNonEmptyRows variable to zero.
1973 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1974 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1976 2011-12-05 Ben Konrath <ben@bagu.org>
1978 Add latest mockup with HTML tables.
1980 Features of this mockup:
1982 -> HTML table for flowtable
1983 -> HTML table for flowtable column
1984 -> Example of how related lists would look
1985 -> Not using text entries for data items
1987 The current version of Online Glom doesn't use HTML tables for the
1990 This mockup has been sent to the glom-devel mailing list but it's good
1991 to have it here as well.
1993 * mockups/details-view-html-tables.html:
1995 2011-12-05 Ben Konrath <ben@bagu.org>
1997 Remove unnecessary getPrimaryKeyField() method.
1999 getPrimaryKeyFieldForTable(String) has been renamed to
2000 getPrimaryKeyField(String).
2002 * src/main/java/org/glom/web/server/database/DBAccess.java:
2003 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2004 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2006 2011-12-05 Ben Konrath <ben@bagu.org>
2008 Add string representation of TypedDataItem value to conversion error message.
2010 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2011 message was extracted into its own method to avoid duplication.
2013 2011-12-05 Ben Konrath <ben@bagu.org>
2015 Add type checking to navigation primary key value creation.
2017 Create navigation primary key only if the expected type from the Glom
2018 document matches the type returned by the SQL query.
2020 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2022 2011-12-05 Ben Konrath <ben@bagu.org>
2024 Rename a couple of variables in RelatedListNavigation.
2026 This is a rename-only refactor.
2028 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2030 2011-12-05 Ben Konrath <ben@bagu.org>
2032 Move getListLayoutGroup() into getListViewLayoutGroup().
2034 This removes getListLayoutGroup(). It was only being called by
2035 getListViewLayoutGroup().
2037 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2039 2011-12-05 Ben Konrath <ben@bagu.org>
2041 Remove check for LayoutItem_Portal in list table method.
2043 This check is no longer necessary because the method isn't being used
2044 to create the LayoutItemPortal DTO.
2046 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2048 2011-12-05 Ben Konrath <ben@bagu.org>
2050 Properly support related list navigation.
2052 Navigation from the "Repository Analyzer -> Package Scans ->
2053 Dependencies" related table wasn't working because the primary key for
2054 related tables wasn't being set properly. This commit fixes the
2057 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2058 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2059 doesn't set the primary key properly for related list tables.
2060 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2061 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2062 useful for getting the primary key for list view tables and for related
2064 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2065 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2066 Move code to set the primary key for the table from the abstract
2067 ListDBAccess class to ListViewDBAccess as it's only correct for list
2069 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2070 Properly add primary key to related list tables.
2072 2011-12-02 Ben Konrath <ben@bagu.org>
2074 Properly set the horizontal alignment of fields.
2076 This fix is for both the list tables and the details view.
2078 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2079 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2080 to set the horizontal alignment of fields.
2082 2011-12-02 Ben Konrath <ben@bagu.org>
2084 Display currency codes in the details view.
2086 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2088 2011-12-02 Ben Konrath <ben@bagu.org>
2090 Avoid duplicate JNI call.
2092 JNI is not as efficient as pure Java and this is an easy (and small)
2095 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2096 Use previously retrieved value for whereClauseToTableName instead of
2099 2011-12-02 Ben Konrath <ben@bagu.org>
2101 Rename a couple of variables in RelatedListNavigation.
2103 This is a rename-only refactor.
2105 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2107 2011-12-02 Ben Konrath <ben@bagu.org>
2109 Indicate clearly that a mismatched primary key type is a bug.
2111 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2112 warning to error. Add 'This is a bug.' to message.
2114 2011-12-02 Ben Konrath <ben@bagu.org>
2116 Update / fix some comments.
2118 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2120 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2122 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2123 Fix comments. Add some TODOs.
2125 2011-12-02 Ben Konrath <ben@bagu.org>
2127 Enable navigation to details view with string primary key from related list.
2129 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2130 Create a text primary key value when return type of result is
2131 java.sql.Types.VARCHAR.
2133 2011-12-02 Ben Konrath <ben@bagu.org>
2135 Use checkboxes for booleans in the details view.
2137 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2139 2011-12-01 Ben Konrath <ben@bagu.org>
2141 Improve performance of related list height calculation.
2143 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2144 Put code to calculate the expected height in a static initializer so
2145 that that it's only called once.
2147 2011-12-01 Ben Konrath <ben@bagu.org>
2149 Show related list tables in notebooks (again).
2151 Calculate the height of the related list tables so the Notebook can be
2152 set the correct height. The height of the related list table is also needed by
2153 FlowTable to be able decide how to create the layout.
2155 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2156 and set the Portal height based on the height of the related list
2157 table and the Portal container.
2158 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2159 Add method to calculate the height of the related list tables.
2160 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2161 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2162 calculate the height of the Pager widget.
2164 2011-12-01 Ben Konrath <ben@bagu.org>
2166 Use CellTable API for table property instead of setting style on Element.
2168 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2170 2011-12-01 Ben Konrath <ben@bagu.org>
2172 Make ListViewTable and RelatedListTable a consistent height.
2174 The tables are now a consistent height regardless of the contents of
2175 the table. A hidden button is added to empty rows to ensure that the
2176 height of these rows will match the height of rows with data.
2178 A navigation button column is now added to every table. The width of
2179 the navigation column is set to 0px when a RelatedListTable shouldn't
2180 have navigation buttons. This maintains the a consistent row height in
2181 tables that don't show the navigation buttons.
2183 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2184 navigation column when not needed.
2185 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2186 arguments for navigation button to constructor of ListViewTable.
2187 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2188 hidden button for empty data rows.
2189 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2190 arguments for navigation button to constructor.
2191 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2192 create navigation buttons. Add hideNavigationButtons() method.
2193 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2194 arguments for navigation button to constructor.
2196 2011-12-01 Ben Konrath <ben@bagu.org>
2198 Use 'visibility: hidden' in Utils.getWidgetHeight().
2200 This is better choice because hidden elements are invisible, don't
2201 respond to events and are not part of the tab order. They will,
2202 however, take up space which is required to be able to calculate the
2203 height of the widget.
2205 * src/main/java/org/glom/web/client/Utils.java:
2207 2011-12-01 Ben Konrath <ben@bagu.org>
2209 Use Utils.getWidgetHeight() in FlowTable.
2211 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2213 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2215 2011-12-01 Ben Konrath <ben@bagu.org>
2217 Put the details css class name on the correct table column.
2219 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2221 2011-11-30 Ben Konrath <ben@bagu.org>
2223 Update for java-libglom API change.
2225 The getters and setters on FieldFormatting and NumericFormat were
2226 changed to remove the 'M'.
2228 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2230 2011-11-29 Ben Konrath <ben@bagu.org>
2232 Only allow RelatedListTables in Portals.
2234 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2236 2011-11-29 Ben Konrath <ben@bagu.org>
2238 Only create a contents panel for Portals when title is being set.
2240 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2242 2011-11-29 Ben Konrath <ben@bagu.org>
2244 Set TabLayoutPanel height based on calculated height its widgets.
2246 This is a potential fix for this bug:
2248 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2250 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2252 2011-11-29 Ben Konrath <ben@bagu.org>
2254 Align details field labels and data with the Open buttons.
2256 * src/main/webapp/style.css:
2258 2011-11-29 Ben Konrath <ben@bagu.org>
2260 Remove unnecessary <div> in the Notebook widget.
2262 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2263 method to get container FlowPanel (<div>).
2264 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2265 initWidget() method directly on the TabLayoutPanel widget instead of
2266 Group's container widget.
2268 2011-11-29 Ben Konrath <ben@bagu.org>
2270 Don't add group titles for Portals in Notebooks.
2272 This reverts the previous patch and fixes a bug I introduced with
2273 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2275 * src/main/java/org/glom/web/client/ui/details/Group.java:
2276 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2278 2011-11-28 Ben Konrath <ben@bagu.org>
2280 Remove unused boolean argument in Portal constructor.
2282 Just a code cleanup.
2284 * src/main/java/org/glom/web/client/ui/details/Group.java:
2285 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2287 2011-11-28 Ben Konrath <ben@bagu.org>
2289 Remove hack for glom 1.18 style glom files.
2291 * src/main/java/org/glom/web/client/ui/details/Group.java:
2292 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2293 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2295 2011-11-28 Ben Konrath <ben@bagu.org>
2297 Use Gda Value version of primary key to log result too large error.
2299 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2301 2011-11-28 Ben Konrath <ben@bagu.org>
2303 Don't use TypedDataItem.getText() for Unknown types from the URL.
2305 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2306 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2307 instead of getText().
2308 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2309 String field and getUnknown() method.
2311 2011-11-28 Ben Konrath <ben@bagu.org>
2313 Log an error message when the java-libglom .so is not present.
2315 The error message was being set in the exception but not logged.
2317 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2319 2011-11-28 Ben Konrath <ben@bagu.org>
2321 Ignore LayoutItem_CalendarPortals.
2323 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2324 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2326 2011-11-28 Ben Konrath <ben@bagu.org>
2328 Extract method for creating the LayoutItemPortal DTO.
2330 Just breaking the code up into smaller chunks.
2332 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2334 2011-11-28 Ben Konrath <ben@bagu.org>
2338 This should have been added with the refactor. Oops!
2340 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2342 2011-11-28 Ben Konrath <ben@bagu.org>
2344 Create primary key value from URL string using type from Glom document.
2346 See this bug, comments 19 - 25:
2348 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2350 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2351 create a TypeDataItem for the primary key here when loading from a
2352 URL. Show the same string for the primary key value as was received
2353 from the URL string (when loading from a URL).
2354 * src/main/java/org/glom/web/server/Utils.java: Update method for
2355 creating the Gda Value from the TypeDataItem to properly deal with
2356 creating a Gda Value based on the Glom document type for the primary
2357 key value string when loading from a URL.
2358 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2359 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2360 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2361 Update for changed method name.
2363 2011-11-27 Ben Konrath <ben@bagu.org>
2365 Rename PrimaryKeyItem to TypedDataItem.
2367 The name PrimaryKeyItem suggests what the class should be used for.
2368 TypedDataItem is a neutral name that describes the class better.
2370 This is a rename-only refactor.
2372 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2373 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2374 * src/main/java/org/glom/web/client/Utils.java:
2375 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2376 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2377 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2379 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2380 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2381 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2382 * src/main/java/org/glom/web/server/Utils.java:
2383 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2385 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2386 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2388 2011-11-25 Ben Konrath <ben@bagu.org>
2390 Improve Gda Value conversion from PrimaryKeyItem.
2392 The value from the PrimaryKeyItem is only used if its type match the
2393 type from the glom document.
2395 * src/main/java/org/glom/web/server/Utils.java:
2397 2011-11-25 Ben Konrath <ben@bagu.org>
2399 Manually check if the java-liblgom .so is visible to the JVM.
2401 It seems that Tomcat has problems when a static initializer throws an
2402 exception. This check is done before the first method call into
2403 java-libglom so that execution doesn't continue if the .so is not
2406 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2408 2011-11-25 Ben Konrath <ben@bagu.org>
2410 Improve browser configuration error messages.
2414 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2416 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2417 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2418 getConfigurationErrorMessage() method.
2419 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2420 Get and display a specific configuration error message when no Glom
2421 documents are found.
2422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2423 Implement getConfigurationErrorMessage() method. Surround configuration
2424 code in the init() method with a try/catch block. This allows the
2425 errors to be caught while keeping the servlet available to retrieve the
2426 configuration error message.
2428 2011-11-25 Ben Konrath <ben@bagu.org>
2430 Don't use Strings to hold primary key values.
2432 The primary key values are now held in a new data object
2433 (PrimaryKeyItem) that holds type information and the primary key value
2434 using the correct type.
2436 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2437 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2439 PrimaryKeyItem instead of String to hold the primary key value.
2440 * src/main/java/org/glom/web/client/Utils.java: Remove
2441 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2442 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2443 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2444 PrimaryKeyItem instead of String to hold the primary key value. Load
2445 document selection page when the documentID has not been set correctly.
2446 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2447 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2449 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2450 Return empty string for URL instead of "null".
2451 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2452 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2453 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2454 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2455 PrimaryKeyItem instead of String to hold primary key values.
2456 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2457 PrimaryKeyValue to a Gda Value.
2458 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2459 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2460 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2461 Replace temporary database access code that uses the PrimaryKeyValue to
2462 Gda Value conversion.
2463 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2464 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2465 PrimaryKeyItem instead of String.
2466 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2467 hold primary key values.
2469 2011-11-24 Ben Konrath <ben@bagu.org>
2471 Use newly added java-libglom API to create queries.
2473 This isn't finished. I still need to stop using Strings for primary key
2474 values in the client code.
2476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2477 libglom to use fake connections so that retrieving the query string will
2479 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2480 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2481 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2482 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2483 Use the newly added libglom sql methods and classes to create the
2484 query. Add temporary hack to convert primary value strings to Gda
2487 2011-11-23 Ben Konrath <ben@bagu.org>
2489 Don't explicitly set the height of Portals.
2491 See comments 6 - 10 of this bug for details:
2493 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2495 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2497 2011-11-23 Ben Konrath <ben@bagu.org>
2499 Use an HTML table instead of CSS for the FlowTable layout.
2501 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2502 GWT's FlexTable to implement the FlowTable.
2503 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2505 2011-11-18 Ben Konrath <ben@bagu.org>
2507 Add boolean example to HTML table mockup.
2509 * mockups/details-view-html-tables-text-entries.html:
2511 2011-11-17 Ben Konrath <ben@bagu.org>
2513 Ensure the pager buttons are always visible for related lists.
2515 To accomplish this, I've turned off text wrapping in the list view and
2516 related list tables for both the header and data text. The related list
2517 table now has a fixed layout so the it doesn't overflow its container.
2518 This is required to ensure that the cell text is clipped when it
2519 overflows the cell and an ellipsis is added to the right side of the
2520 cell when text is clipped.
2522 A fixed table layout for the related list table in the details view
2523 seems what we want for the details view anyway, so the side-effect is
2526 The ellipsis will only be displayed in Firefox >= 7.
2530 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2532 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2533 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2534 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2536 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2537 Set the 'table-layout: fixed' CSS property to the related list table.
2538 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2539 'white-space: nowrap;' CSS property on both the list view and the
2540 related list tables.
2542 2011-11-16 Ben Konrath <ben@bagu.org>
2544 Rework the fix for empty notebook tab labels.
2546 Setting the empty group titles with its name caused problems for the
2547 details layout. Instead of using libglom's
2548 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2549 to the client when the title is empty. This allows the Notebook to use
2550 the name when the title is empty without affecting anything else.
2552 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2553 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2555 2011-11-16 Ben Konrath <ben@bagu.org>
2557 Set group titles with name when title is empty.
2559 This fixes a problem with an empty notebook tab label in the Lesson
2560 Planner document. The forth tab in the notebook should be "Internet":
2562 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2564 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2565 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2568 2011-11-16 Ben Konrath <ben@bagu.org>
2570 Remove whitespace from the configured username properties.
2572 This assumes that usernames won't have whitespace at the beginning
2573 or end. But I think this is a reasonable assumption.
2575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2576 String.trim() to remove the whitespace from the username properties.
2578 2011-11-15 Ben Konrath <ben@bagu.org>
2580 Add details view mockup with HTML tables and text entries.
2582 This is from the attachment on this bug:
2584 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2586 * mockups/details-view-html-tables-text-entries.html:
2588 2011-11-15 Ben Konrath <ben@bagu.org>
2590 Add space between the columns of the flow table.
2594 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2596 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2597 space between columns in the flow table.
2599 2011-11-15 Ben Konrath <ben@bagu.org>
2601 Add backup files to the .gitignore.
2603 * .gitignore: Ignore files that end with ~.
2605 2011-11-09 Ben Konrath <ben@bagu.org>
2607 Use latest release of gwt-log.
2609 Gwt-log releases are now being submitted to the maven central
2610 repository so manual installation of the jar is no longer required.
2612 * pom.xml: Update version and groupId of gwt-log dependency.
2614 2011-10-31 Ben Konrath <ben@bagu.org>
2616 Don't use GWT numeric formatting to override the glom currency formatting.
2618 Currencies are now displayed like they are in Glom. See this bug:
2620 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2622 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2624 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2625 currency code to constructor and set it when the cell is rendered.
2626 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2627 currency code to the constructor of the NumericCell.
2629 2011-10-27 Ben Konrath <ben@bagu.org>
2631 Require the latest release of java-libglom (1.17.4).
2635 2011-10-26 Ben Konrath <ben@bagu.org>
2637 Add style to Notebook that matches current theme.
2639 It's not the best style in the world but it's better than the default.
2641 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2642 padding at the bottom of the child widgets.
2643 * src/main/webapp/style.css: Add style for the Notebook.
2645 2011-10-26 Ben Konrath <ben@bagu.org>
2647 Move servlet initialization code to overridden init method.
2649 This is half of the solution to getting proper error messages
2650 displayed when configuration errors occur. Here's the relevant bug:
2652 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2654 The rest of the solution involves surrounding the init method with a
2655 try/catch block and setting a global variable with the error /
2656 exception. A new async method should be created to retrieve and display
2657 the error message / exception.
2659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2660 code from constructor to init method adding exceptions as needed.
2662 2011-10-26 Ben Konrath <ben@bagu.org>
2664 Add script to monitor and restart tomcat if required.
2666 * utils/check-and-recover-tomcat.py: New file.
2668 2011-10-26 Ben Konrath <ben@bagu.org>
2670 Display the correct number of data items in the pager.
2674 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2676 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2677 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2678 The implementation is the same for both tables: Keep track of the
2679 number of non-empty rows and fire and RowCountChangeEvent after the data has
2681 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2682 custom Pager class that subclasses SimplePager to handle displaying
2683 the correct number when empty rows have been added.
2685 2011-10-26 Ben Konrath <ben@bagu.org>
2687 Correct error in previous commit.
2689 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2690 eventBus parameter from listView.setCellTable().
2692 2011-10-26 Ben Konrath <ben@bagu.org>
2694 Fix error in TODO comment.
2696 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2698 2011-10-24 Ben Konrath <ben@bagu.org>
2700 Create Notebook widgets to the details view.
2702 This isn't finished just yet - I still need to create a reasonable
2703 style to match the current theme.
2705 * src/main/java/org/glom/web/client/Utils.java: Add method for
2706 calculating the height of a widget. This is used in the Notebook class.
2707 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2708 new constructor method in Group.
2709 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2710 method for creating child widget that can be used by subclasses
2711 like Notebook. New constructor that allows disabling the group
2712 titles - Notebooks don't set a group title for their child groups.
2713 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2714 to make Notebooks using GWT's TabLayoutPanel.
2715 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2716 constructor that allows disabling the group titles.
2717 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2718 LayoutItemNotebook DTO.
2719 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2720 DTO for Notebooks. It's just an empty class for now but we might need
2721 it to transfer some specific information in the future.
2723 2011-10-21 Ben Konrath <ben@bagu.org>
2725 Add navigation buttons to related list tables.
2727 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2728 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2729 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2730 method getSuitableRecordToViewDetails() for getting the table name
2731 and primary key value for related list navigation buttons.
2732 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2733 private cell renderer class to get the navigation information for
2734 related list tables from the server. Extract the navigation
2735 processing code from the details cell navigation and use it for the
2736 related list navigation as well.
2737 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2738 cell renderer class for the details open buttons. This was needed
2739 because the related list navigation buttons and the list view
2740 navigation buttons need to react differently when clicked.
2741 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2742 the onEnterKeyDown() method because it's now overriden in the
2743 subclasses that are specific to the related list tables and the list
2745 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2746 the vertical size a little because the buttons add a bit of vertical
2747 space to table. This is not a perfect solution because the vertical
2748 size of with table fewer than 5 rows will be a little smaller.
2749 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2750 changes in how navigation buttons are handled.
2751 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2752 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2753 database access object.
2754 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2755 to find the portal for a given relationship name from
2756 RelatedListDBAccess. Add method to find a primary key field for a
2758 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2759 Move code to find the portal for a given relationship name to
2761 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2762 New file: database access object for getting the related list
2763 navigation information (the table name and the primary key value).
2764 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2765 DTO for transferring a table name to navigate to and a primary key
2767 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2768 boolean and getter/setter to specifies if the related list should add
2771 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2773 Use the master branch of java-libglom
2775 * pom.xml: Depend on java-libglom 1.19 instead.
2777 This is the master branch. See also the libglom-1-18 branch.
2779 2011-10-11 Ben Konrath <ben@bagu.org>
2781 Enable the open navigation button when the data has been set.
2783 This avoids having active buttons that don't do anything when the data
2786 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2788 2011-10-11 Ben Konrath <ben@bagu.org>
2790 Use IsWidget interface for FlowTableItem.
2792 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2793 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2795 2011-10-11 Ben Konrath <ben@bagu.org>
2797 Remove GWT styling from open button in details view.
2799 There are still some issues with how the details cell is arranged but
2800 this should be made to match Glom 1.20. I'm going to leave fixing this
2801 until I have Glom 1.20 up and running.
2803 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2804 style name on open button.
2805 * src/main/webapp/style.css: Move and edit details-navigation class.
2806 Re-arrange some classes to make them appear in the same order as the
2809 2011-10-07 Ben Konrath <ben@bagu.org>
2811 Update to GWT 2.4.0.
2813 * .gitignore: Ignore new cache directory.
2814 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2815 * pom.xml: Change GWT and maven plugin to 2.4.0.
2816 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2818 * src/main/java/org/glom/web/client/ClientFactory.java:
2819 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2820 * src/main/java/org/glom/web/client/OnlineGlom.java:
2821 Update source for API changes.
2822 * utils/build-onlineglom-war.sh: Remove cache directory before the
2825 2011-10-07 Ben Konrath <ben@bagu.org>
2827 Add navigation buttons in the details view.
2829 This isn't finished but I thought I'd commit what I have as it's a
2830 pretty good start. I still need to:
2832 1. Change the style so that it fits better into the current theme
2833 2. Adjust the details cell to expand as much as possible.
2835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2836 click handlers to navigation buttons in the DetailsCells. Create a
2837 refreshData() method to get just the data from the server without the
2839 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2840 Update the tableSelector and browser title when the table name
2841 changes without using the tableSelector.
2842 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2843 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2844 getDetailsCells() to getCells(). Update variable names.
2845 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2846 method to set click handler on navigation button. Rename a few
2847 variables. Add navigation buttons where needed.
2848 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2849 variables and methods.
2850 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2851 navigation boolean and navigation table as required in the
2852 LayoutItemField DTO.
2853 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2854 variables for navigation along with getter/setter methods.
2856 2011-10-07 Ben Konrath <ben@bagu.org>
2858 Rename Field to DetailsCell.
2860 This is a refactor-only commit. No functionality has been added or
2863 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2864 Update variable and method names.
2865 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2866 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2867 variable and method names.
2868 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2870 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2871 variable and method names.
2873 2011-10-07 Ben Konrath <ben@bagu.org>
2875 Create separate methods for layout and data the details view.
2877 This is a refactor-only commit. No functionality has been added or
2880 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2881 private methods: setData(), createLayout().
2883 2011-10-07 Ben Konrath <ben@bagu.org>
2885 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2887 This is part of a change to get navigation buttons in the details view
2888 but it should have been done this way from the start.
2890 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2891 for method name change in TableSelectionView.
2892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2893 Create TableChangeEvent and set the browser title using the
2894 TableSelectionView API.
2895 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2896 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2897 Change getSelectedTable() to getSelectedTableName(). Add
2898 getSelectedTableTitle().
2900 2011-10-07 Ben Konrath <ben@bagu.org>
2902 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2904 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2906 2011-10-07 Ben Konrath <ben@bagu.org>
2908 Update TableChangeEvent to use newTableName naming convention.
2910 This makes the class more consistent with GWT naming conventions.
2912 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2913 Update for method name change in TableChangeEvent.
2914 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2915 for method name change in TableChangeEvent.
2916 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2917 newTableName variable and getter method. Make toDebugString()
2920 2011-09-30 Ben Konrath <ben@bagu.org>
2922 Disable the pager in the list tables when the data row count is less than the minimum.
2924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2925 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2927 2011-09-30 Ben Konrath <ben@bagu.org>
2929 Add empty rows to the end of related list and list view tables.
2931 I also extracted the cell rendering classes from the ListTable because
2932 the code was becoming a little crazy with all the anonymous inner
2933 classes. My plan is to use these cell rendering classes in the details
2934 view as well so this refactor will be needed for that change.
2936 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2937 set the row count in related list tables if the data has more rows
2938 than the minimum number of rows visible.
2939 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2940 row count in list view tables if the data has more rows than the
2941 minimum number of rows visible.
2942 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2943 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2945 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2946 for rendering TYPE_NUMERIC cells. The code was extracted from the
2948 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2949 class for rendering cells with buttons in list views. The code was
2950 extracted from the ListTable class.
2951 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2952 for rendering TYPE_TEXT cells. The code was extracted from the
2954 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2955 Add empty rows to the end of the data if required. Implement
2956 ListTable.getMinNumVisibleRows().
2957 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2958 cell renderer code to public classes. Return null in
2959 Column.getValue() for empty rows. Add new abstract method:
2960 getMinNumVisibleRows(). Move code to set the row count of the list view
2961 table to ListViewImpl.
2962 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2963 empty rows to the end of the data if required. Implement
2964 ListTable.getMinNumVisibleRows().
2967 2011-09-27 Ben Konrath <ben@bagu.org>
2969 Use GWT.log for client-side debugging statements.
2971 These are optimized out when deployed so I should have used this method
2972 in the first place. These statements will eventually be replaced with some sort
2973 of notification in the browser.
2975 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2976 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2977 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2978 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2979 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2981 2011-09-27 Ben Konrath <ben@bagu.org>
2983 Put tableselector on the right, back to list link on right.
2985 The idea is that the table selector is acting like a label for the
2986 currently displayed table so it should be placed below the document title. This
2987 puts the table title in a similar position to where it is in Glom.
2989 * mockups/details-contacts.html:
2990 * mockups/details-projects.html:
2991 * mockups/listview-contacts.html:
2992 * mockups/listview-projects.html:
2993 * mockups/style.css:
2994 Update mockups to match how the interfaces currently look.
2995 * src/main/webapp/style.css: Swap positions of backlink with the table
2996 selector. Add some space on the left side of the table selector to
2997 line things up with the document title.
2999 2011-09-27 Ben Konrath <ben@bagu.org>
3001 Add field colouring to details view.
3003 This change re-works how field colouring works. The colour formatting
3004 information is now set to the client with the layout information instead of
3005 with the data. This eliminates the need to send the same colour strings for
3006 data in list view column when colour information is set.
3008 In order to set an alternate colour for negative numeric values, the
3009 number is now sent to client and formatted with the GWT NumberFormat class.
3011 This change also fixes:
3013 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3015 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3016 internationalization framework which is needed for client side numeric
3018 * src/main/java/org/glom/web/client/Utils.java: New file for some
3019 client static utility methods.
3020 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3021 the DataItem object to the Field class. Use a utility method to
3022 create the foreignKeyValue string.
3023 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3024 alignment and text colours in the constructor. Add setData(DataItem)
3025 method. Remove setText(String) method.
3026 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3027 colour information to GlomTextCell. Create and use GlomNumberCell for
3028 rendering numbers. Use utility method to get the string for the
3029 primary key of the key provider. Re-work how the horizontal alignment
3031 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3032 formatting to layout information. Methods for converting the libglom
3033 formatting information were moved from DBAccess.
3034 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3035 numeric formatting (it's now done on the client side). Don't set text
3036 colours in DataItem. Move libglom formatting conversion methods to
3038 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3039 getters/setters for text colour information.
3040 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3041 for transferring the libglom NumericFormat information to the client.
3042 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3043 and getters/setters for: GlomNumericFormat, background colour and
3044 foreground colour strings.
3046 2011-09-26 Ben Konrath <ben@bagu.org>
3048 Simplify code that iterates through the LayoutGroup.
3050 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3052 2011-09-26 Ben Konrath <ben@bagu.org>
3054 Accept Eclipse formatting for OnlineGlomServiceAsync.
3056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3058 2011-09-26 Ben Konrath <ben@bagu.org>
3060 Don't use the ListDBAccess classes to get the primary key layout information.
3062 This was causing a bug where the wrong index for the hidden primary key
3063 was being sent to the client.
3065 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3066 primary key while creating the LayoutGroup DTO. Create a
3067 LayoutItemField DTO for hidden primary keys. Don't use the
3068 RelatedListDBAccess because it was only used for getting the primary
3070 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3071 access modifier from public to protected for getPrimaryKeyField() and
3072 getPrimaryKeyLayoutItemField().
3073 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3074 abstract method getExpectedResultSize() because RelatedListDBAccess
3075 doesn't have enough info to implement it.
3076 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3077 Remove @Override for getExpectedResultSize().
3078 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3079 Remove method getExpectedResultSize().
3081 2011-09-23 Ben Konrath <ben@bagu.org>
3083 Log which layout (list or details) the ignored item is from.
3085 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3087 2011-09-23 Ben Konrath <ben@bagu.org>
3089 Remove annotations that turn off code formatting in DataItem.
3091 * src/main/java/org/glom/web/shared/DataItem.java:
3093 2011-09-23 Ben Konrath <ben@bagu.org>
3095 Rename GlomField to DataItem and update associated methods.
3097 This is a rename-only refactor. No functionality has been added or
3100 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3101 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3102 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3103 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3104 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3105 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3106 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3107 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3109 * src/main/java/org/glom/web/server/database/DBAccess.java:
3110 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3111 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3112 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3113 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3114 * src/main/java/org/glom/web/shared/DataItem.java:
3115 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3116 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3118 2011-09-23 Ben Konrath <ben@bagu.org>
3120 Rename GlomDocument to DocumentInfo and update associated methods.
3122 This is a rename-only refactor. No functionality has been added or
3125 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3126 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3127 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3129 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3130 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3131 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3133 2011-09-20 Ben Konrath <ben@bagu.org>
3135 Require java-libglom 1.17.3.
3137 This picks up the fix for the seg fault problem with the Scenes table
3138 in the Openismus Film Manager example.
3142 2011-09-20 Ben Konrath <ben@bagu.org>
3144 Change the way sort clause is added for primary key when no sort clause is requested.
3146 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3147 before the sort clause is created. When a sort clause is not requested, the
3148 sort clause is created by finding the primary key in the LayoutFieldVector
3151 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3153 2011-09-20 Ben Konrath <ben@bagu.org>
3155 Log error message if no documents are found in the configured directory.
3157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3158 Extract the glom file extension string to a private static final class
3159 variable (mostly as syntactic sugar). Accept a minor formatting change.
3160 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3161 the example glom.document.directory configuration property to make it
3162 more clear that it can any directory, not just the home directory.
3164 2011-09-18 Ben Konrath <ben@bagu.org>
3166 Add related lists to details view.
3168 The related list table has support for paging and sorting just like the
3169 table in the list view.
3171 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3172 SQL queries for the related list tables.
3173 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3174 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3176 Rename getList methods to getListView and add comments. Remove
3177 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3178 it being unused. Add methods: getDetailsLayoutAndData(),
3179 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3180 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3181 Create the layout and set the data for the fields in one async call
3182 instead of two. Create related lists where appropriate.
3183 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3184 for method name changes in OnlineGlomService.
3185 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3186 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3187 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3189 * src/main/java/org/glom/web/client/ui/ListView.java:
3190 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3191 tableName from setCellTable(). Create a ListViewTable instead of
3193 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3194 represent a data field in the details view.
3195 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3196 from addDetailsCell() to Field class. Keep track of the Fields and
3197 Portals in the details view.
3198 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3199 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3200 and add a method to get it. Add method to set the contents of the
3202 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3203 New class for related list tables. This class has the data provider
3204 for the related list table.
3205 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3206 abstract class which is the base class for the ListViewTable and the
3208 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3209 New class for list view tables. This class has the data provider for
3210 the list view table.
3211 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3212 methods for related list tables. Add more information to the
3213 LayoutItemField and LayoutItemPortal DTOs.
3214 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3215 Remove debugging print statement.
3216 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3217 Remove debugging print statements. Add primary key field to SQL count
3219 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3220 Remove unnecessary LayoutFieldVector parameter from
3221 getResultSizeOfSQLQuery() method.
3222 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3223 New class for related list table database access.
3224 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3225 class that is a wrapper DTO for details view layout and data.
3226 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3227 new 'fromField' string to this DTO.
3228 * src/main/webapp/style.css: Remove bottom margin and override top
3231 2011-09-15 Ben Konrath <ben@bagu.org>
3233 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3235 This sets things up to make it easier to add the data retrieval for
3236 related lists (portals). No user noticeable changes were made with
3239 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3240 class has the code to retrieve the layouts and access the
3241 database using the new database helper classes.
3242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3243 Most of the functionality has been removed from this class. This
3244 class now represents the public interface for the client side
3245 code. It also deals with configuring the servlet and cleaning
3246 things up when the servlet is stopped.
3247 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3248 of static methods into this utility class.
3249 * src/main/java/org/glom/web/server/database/DBAccess.java:
3250 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3251 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3252 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3253 These classes have the database retrieval code. The class hierarchy
3254 has been setup to make it easy to reuse code for similar
3257 2011-09-06 Ben Konrath <ben@bagu.org>