1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 ListTable: Protect against an out of range error.
5 * src/main/java/org/glom/web/client/ui/list/ListTable.java
6 createCellTable(): This is unlikely, but can happen while debugging.
8 2012-05-06 Murray Cumming <murrayc@murrayc.com>
10 AsyncMessage onFailure() callbacks: Log the exception message.
12 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
13 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
14 * src/main/java/org/glom/web/client/activity/ListActivity.java:
15 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
16 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
17 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
18 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
19 These are useful clues when something is wrong.
21 2012-05-06 Murray Cumming <murrayc@murrayc.com>
23 ConfiguredDocument: Avoid a null dereference.
25 * src/main/java/org/glom/web/server/ConfiguredDocument.java
26 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
27 details maps are created.
29 2012-05-06 Murray Cumming <murrayc@murrayc.com>
31 Document: Correct the port number parsing.
33 * src/main/java/org/glom/web/server/libglom/Document.java:
34 This lets us actually connect to the database and show the document.
36 2012-05-05 Murray Cumming <murrayc@murrayc.com>
40 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
41 user-interaction, asking us to load a temporary URL in a browser.s
42 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
43 which is apparently necessary for testing the service. See the comment.
44 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
45 Show the exception, if any. This is how I saw the 404 in the HTML in
48 2012-05-05 Murray Cumming <murrayc@murrayc.com>
50 DocumentTest: Move the .glom files into the resources directory.
52 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
53 URI via getResource().
55 2012-05-05 Murray Cumming <murrayc@murrayc.com>
57 Document: Remove the FieldIdentifies inner class.
59 * src/main/java/org/glom/web/server/libglom/Document.java: We only
60 use the Relationship (though the same function in libglom is maybe
61 used in other ways) and so this removes a compiler warning.
63 2012-05-05 Murray Cumming <murrayc@murrayc.com>
65 Document.load() Remove the error code parameter.
67 * src/main/java/org/glom/web/server/libglom/Document.java: load():
68 Remove the parameter. We do not set it yet and it could never have
69 worked as an output parameter (though maybe it did in java-libglom).
70 We could use an exception if we really want the failure reason.
71 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
73 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
74 setUp(), testGetSuitableTableToViewDetails(): Adapt.
76 2012-05-05 Murray Cumming <murrayc@murrayc.com>
78 Make some inner classes static.
80 * src/main/java/org/glom/web/server/ConfiguredDocument.java
81 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
82 * src/main/java/org/glom/web/server/ReportGenerator.java
83 * src/main/java/org/glom/web/server/libglom/Document.java
84 Make all inner classes static that can be static.
86 2012-05-05 Murray Cumming <murrayc@murrayc.com>
88 OnlineGlomServiceImpl: Do not load and check for java-libglom.
90 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
91 init(): We do not use java-libglom any more.
93 2012-05-05 Murray Cumming <murrayc@murrayc.com>
95 Remove mentions of java-libglom.
97 * README: Remove mention of java-libglom, because it no longer needed.
98 * utils/build-onlineglom-war.sh:
99 * utils/check-and-recover-tomcat.py:
100 * utils/install-onlineglom-war.sh: Remove these as they are no longer
101 useful. Building is now far easier, with no need for jhbuild.
103 2012-05-05 Murray Cumming <murrayc@murrayc.com>
105 Fix the build (mvn package)
107 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
108 (LayoutGroup): Make the LayoutItemList inner class static and protected.
109 Otherwise the GWT Java->Javascript compilation fails with just this
110 error, during mvn package or when attempting to view in a browser,
111 in the GWT developer mode in Eclipse.
113 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
114 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
115 [INFO] Compiling module org.glom.web.OnlineGlom
116 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
117 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
118 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
119 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
120 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
121 [INFO] [ERROR] Cannot proceed due to previous errors
123 It has taken me 2 days to find out what was causing that. After reducing
124 the code, the compiler eventually showed me the full error message.
126 2012-05-04 Murray Cumming <murrayc@murrayc.com>
128 ConfiguredDocument: Cache the cloned and stripped layouts.
130 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
131 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
132 layout in a map, so we can retrieve it again without rebuilding it.
134 2012-05-04 Murray Cumming <murrayc@murrayc.com>
136 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
138 2012-05-04 Murray Cumming <murrayc@murrayc.com>
140 libglom classes: Implement some auto-generated emthods.
142 2012-05-04 Murray Cumming <murrayc@murrayc.com>
144 Add GwtTestOnlineGlomService.
146 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
147 However, this (and the other GwtTest*) does not seem to run during
150 2012-05-04 Murray Cumming <murrayc@murrayc.com>
152 Remove use of unsupported features from client code.
154 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
155 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
156 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
157 Use our client version of StringUtils instead of the apache commons one.
159 However, the GWT Javascript compliation still fails.
161 2012-04-25 Murray Cumming <murrayc@murrayc.com>
163 Add a Field class and implement some loading of it in Document.
165 2012-04-25 Murray Cumming <murrayc@murrayc.com>
167 Initial Document loading implementation, instead of libglom.
169 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
170 and Translatable classes, and adapt the rest of the code to use them.
171 However, this is still missing Layout and Field classes and loading.
173 2012-04-24 Murray Cumming <murrayc@murrayc.com>
175 Use of jOOQ: Move Field creation into a utility method.
177 * src/main/java/org/glom/web/server/SqlUtils.java:
178 This lets us improve it more easily.
180 2012-04-24 Murray Cumming <murrayc@murrayc.com>
182 Use of jOOQ: Improve the code to COUNT a sub-select.
184 * src/main/java/org/glom/web/server/SqlUtils.java:
185 Move initial query creation into
186 build_sql_select_step_with_where_clause().
187 build_sql_select_count_rows(): Use the jOOQ API instead of
188 concatentating text, because a jOOQ Select*Step is a TableLike,
189 which is what from() takes.
191 2012-04-23 Murray Cumming <murrayc@murrayc.com>
193 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
195 * pom.xml: Depend on jooq.
196 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
197 methods with jOOQ, based on the C++ implementations in libglom,
198 with some changes to the logic required by jooQ.
199 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
201 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
202 * src/main/java/org/glom/web/server/ReportGenerator.java:
203 * src/main/java/org/glom/web/server/SqlUtils.java:
204 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
205 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
206 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
207 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
208 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
209 Adapt. In particular, the SqlUtils methods now need to take a Connection,
210 because jOOQ needs that, though it seems unnecessary.
212 This is not quite finished. Ideally jOOQ would help us to build
213 table_name.field_name names, quoting and escaping them properly.
214 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
216 2012-04-21 Murray Cumming <murrayc@murrayc.com>
218 Move use of Glom.build_sql*() into a new SqlUtils class.
220 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
221 to wrap Glom.build_sql*(). The parameter types are still Glom one,
222 but this will make it easier to start using something other than
223 libglom or SqlBuilder.
225 2012-04-21 Murray Cumming <murrayc@murrayc.com>
227 Update the project URL.
229 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
231 2012-04-21 Murray Cumming <murrayc@murrayc.com>
233 Main layout: Use a FlowTable instead of absolute positioning.
235 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
236 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
237 child panels/widgets must have an absolute position. But that is annoying, so
238 this adds a FlowTable and puts the child panels in there.
240 2012-04-21 Murray Cumming <murrayc@murrayc.com>
242 GwtTestOnlineGlom: Comment out unused code.
244 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
245 Eclipse has started to say that some code is unused.
247 2012-04-21 Murray Cumming <murrayc@murrayc.com>
249 Update to the latest versions of dependencies.
251 * pom.xml: Update version numbers of dependencies to the latest
253 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
255 * src/main/java/org/glom/web/server/ReportGenerator.java:
256 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
257 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
258 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
260 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
261 Modify the imports where necessary.
263 2012-04-17 Murray Cumming <murrayc@murrayc.com>
265 Style: Remove overflow:hidden from searchbox
267 * src/main/webapp/style.css: Because this pushes the Back To Link
268 label/link on to the next row, which is then hidden due to the
269 hard-coded (in ems) height.
271 2012-04-20 Murray Cumming <murrayc@murrayc.com>
273 Remove some duplicate code.
275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
276 getDocumentInfo(): This must have been duplicated during the merge from the
281 2012-04-19 Murray Cumming <murrayc@murrayc.com>
283 Reports: Localize the waiting for report message.
285 * src/main/java/org/glom/web/client/activity/ReportActivity.java
286 start(): Get the message from the contants.
287 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
289 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
290 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
291 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
292 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
293 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
294 Update these files with the English text for newer strings for now.
296 2012-04-19 Murray Cumming <murrayc@murrayc.com>
298 Reports: Show a message while waiting for the report.
300 * src/main/java/org/glom/web/client/ui/ReportView.java
301 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
302 Add setWaitingText(), to show a message saying that we are
303 waiting for the report to be ready.
304 * src/main/java/org/glom/web/client/activity/ReportActivity.java
305 start(): Call setWaitingText() before calling the async
308 2012-04-19 Murray Cumming <murrayc@murrayc.com>
310 ReportGenerator: Specify date and time formats.
312 * src/main/java/org/glom/web/server/ReportGenerator.java:
313 createFieldValueElement(): Use the default (and localized)
314 short formats, though we still need a way to show 4-digit
315 years without providing the format for every locale.
316 * src/main/java/org/glom/web/server/database/DBAccess.java:
317 convertResultSetToDTO(): Use the short formats here too.
319 2012-04-18 Murray Cumming <murrayc@murrayc.com>
321 ReportGenerator: Use the correct numeric formatting.
323 * src/main/java/org/glom/web/server/ReportGenerator.java
324 createFieldExpression(), createFieldValueElement(): Take the
325 whole LayoutItem_Field instead of just the field name, so
326 we have access to the formatting.
327 createFieldValueElement(): Use JRTextField.setPattern() to
328 specify the numeric formatting, with the help of a
329 regular DecimalFormat.
331 2012-04-18 Murray Cumming <murrayc@murrayc.com>
333 ReportGenerator: Avoid showing null for group by titles.
335 * src/main/java/org/glom/web/server/ReportGenerator.java
336 generateReport(): Use setBlankWhenNull() on the field title
337 style too, because this is used for values in group by
340 2012-04-18 Murray Cumming <murrayc@murrayc.com>
342 ReportGenerator: Add a colon to titles in vertical groups.
344 * src/main/java/org/glom/web/server/ReportGenerator.java
345 addFieldToDetailBandVertical(): Pass true for the withColon
348 2012-04-18 Murray Cumming <murrayc@murrayc.com>
350 ReportGenerator: Simplify the code by using Position more.
352 2012-04-18 Murray Cumming <murrayc@murrayc.com>
354 Reports: Support vertical groups, roughly.
356 * src/main/java/org/glom/web/server/ReportGenerator.java:
357 addToReport(): Rename to addGroupToReport() and, if necessary,
358 call the new addVerticalGroupToReport() method.
359 createFieldValueElement(): Let the caller specify the Y position
362 2012-04-17 Murray Cumming <murrayc@murrayc.com>
364 Reports: Allow a second report to be shown.
366 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
367 clear(): Do not remove the HTML widget, which broke the whole layout.
369 2012-04-17 Murray Cumming <murrayc@murrayc.com>
371 Locales drop-down: Show that we use English by default.
373 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
374 fillView(): When we use English, just because that is the default, when
375 no locale is specified, show that in the Locales drop-down instead of
376 just showing the first item.
378 2012-04-17 Murray Cumming <murrayc@murrayc.com>
380 Unselect the Report/Locale/Table combo item when appropriate.
382 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
383 setPlace(): clear reportName if this is not a ReportPlace.
384 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
385 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
386 When the provided name is empty, unselect all items, so that none are
387 indicated. This uses a for loop because I cannot find a single method
390 2012-04-17 Murray Cumming <murrayc@murrayc.com>
392 Report: Give the user a way to get back to the list.
394 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
395 start(), setPlace(): Show the Back To List link on reports, and also
396 interpret selecting the empty report item as back to list.
398 2012-04-13 Murray Cumming <murrayc@murrayc.com>
400 Really show the selected Report name.
402 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
403 setPlace(): Store the reportName here, if it is that kind of Place.
404 fillView(): Set the selected Report after filling the list of reports.
405 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
406 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
407 null Strings, though we need some way to unselect all ListBox items
410 2012-04-13 Murray Cumming <murrayc@murrayc.com>
412 ReportGenerator: Try to avoid some problems.
414 * src/main/java/org/glom/web/server/ReportGenerator.java
415 addField(): Try to avoid duplicates, and avoid using a null
418 2012-04-13 Murray Cumming <murrayc@murrayc.com>
420 Reports: Use quickFind.
422 * src/main/java/org/glom/web/client/OnlineGlomService.java;
423 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
424 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
425 getReportHTML(): Add a quickFind parameter.
426 * src/main/java/org/glom/web/client/activity/ReportActivity.java
427 start(): Pass the quickFind parameter.
428 * src/main/java/org/glom/web/server/ReportGenerator.java
429 generateReport(): Take a quickFind parameter.
431 2012-04-13 Murray Cumming <murrayc@murrayc.com>
433 ReportPlace: Actually use the report name.
435 * src/main/java/org/glom/web/client/place/ReportPlace.java
436 getPlace(): Do not assign the report name to the quickfind.
438 2012-04-13 Murray Cumming <murrayc@murrayc.com>
440 Show java.library.path when complaining.
442 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
443 init(): When telling us to check java.library.path, show the
446 2012-03-06 Murray Cumming <murrayc@murrayc.com>
448 ReportGenerator: Do not show nulls.
450 2012-03-06 Murray Cumming <murrayc@murrayc.com>
452 ReportGenerator: Make the title font larger.
454 2012-03-06 Murray Cumming <murrayc@murrayc.com>
456 ReportGenerator: Put field titles inside groups, if there are groups.
458 2012-03-06 Murray Cumming <murrayc@murrayc.com>
460 ReportGenerator: Take the Report itself instead of the name and group.
462 * src/main/java/org/glom/web/server/ConfiguredDocument.java
463 Remove getReportLayoutGroup().
464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
465 getReportHTML(): Pass the report instead
466 of its name and layout group.
467 * src/main/java/org/glom/web/server/ReportGenerator.java
468 generateReport(): Use the report object to use the title
471 2012-03-06 Murray Cumming <murrayc@murrayc.com>
473 ReportGenerator: Remove designBand parameters.
475 * src/main/java/org/glom/web/server/ReportGenerator.java:
476 Make designBand a class member instead of passing it to all
479 2012-03-06 Murray Cumming <murrayc@murrayc.com>
481 ReportGenerator: Add lines, a bit like in the desktop version.
483 * src/main/java/org/glom/web/server/ReportGenerator.java
484 addToReport(): Use JRDesignLine.
486 2012-03-06 Murray Cumming <murrayc@murrayc.com>
488 ReportGenerator: Correct the title positions and use some bold style.
490 * src/main/java/org/glom/web/server/ReportGenerator.java:
491 Break the code up into reusable functions, correct the placement of
492 titles, and use normal/bold styles as in the reports in the desktop
495 2012-03-06 Murray Cumming <murrayc@murrayc.com>
497 ReportGenerator: Add a header band to show the field titles.
499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
500 getReportHTML(): Pass the localeId to the ReportGenerator
502 * src/main/java/org/glom/web/server/ReportGenerator.java
503 constructor: Take the localeID so we can get translated field
505 generateReport(), addToReport(), addFieldToBand(): Add field
506 titles in a column header band.
508 2012-03-05 Murray Cumming <murrayc@murrayc.com>
510 Reports drop-down list: Some improvement.
512 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
513 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
514 Adedd setSelectedReport(),
515 setReportList(): Add a blank line so that the user can select the
517 * src/main/java/org/glom/web/client/activity/ReportActivity.java
518 start(): Show the current report by calling setSelectedReport().
519 This does not seem to work yet.
521 2012-03-05 Murray Cumming <murrayc@murrayc.com>
523 DetailsActivity, ListActivity: Move some variables into a base class.
525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
526 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
527 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
528 the clientFactory, documentID, tableName and authenticationPopup into
529 a base class, to avoid duplication.
531 2012-03-05 Murray Cumming <murrayc@murrayc.com>
533 Translate the Reports label.
535 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
536 Get the "Reports" label string from the constants.
537 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
538 perties: Add Reports to the constants.
540 2012-03-05 Murray Cumming <murrayc@murrayc.com>
542 Reports: Implement grouping.
544 * src/main/java/org/glom/web/server/ReportGenerator.java:
545 Handle LayoutItem_GroupBy items and try to do the right thing
546 with JRDesignGroup. It seems to work.
548 2012-03-04 Murray Cumming <murrayc@murrayc.com>
550 Actually show some data with JasperReports.
552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
553 getReportHTML(): Move most code into a ReportGenerator class.
554 * src/main/java/org/glom/web/server/ReportGenerator.java:
555 Recurse into sub-groups, adding fields to the JasperDesign's details
556 band. Note that we must set an arbitrary width and height, or it just
557 will not show any data.
559 2012-03-04 Murray Cumming <murrayc@murrayc.com>
561 Reports Chooser: Show the titles, not the names.
563 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
564 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
565 and the names as the values.
566 * src/main/java/org/glom/web/server/ConfiguredDocument.java
567 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
568 group now that we provide the report name, so it should always
571 2012-02-15 Murray Cumming <murrayc@murrayc.com>
573 Depend on jasperreports.
575 * pom.xml: Add the dependency. My plan is to use this on the
578 2012-01-31 Murray Cumming <murrayc@murrayc.com>
580 Implement navigation to report places.
582 * src/main/java/org/glom/web/client/activity/ReportActivity.java
583 start(): Do not bother to handle all events here.
584 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
585 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
586 Added getSelectedReport().
587 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
588 .java: start(): When handling a change to the reports chooser,
589 call getSelectedReport() and goTo() its ReportPlace.
590 * src/main/java/org/glom/web/client/ui/ReportView.java
591 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
592 Added setReportHTML() which puts the html in a gwt HTML widget.
593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
594 getReportHTML(): Return "TODO" just to show that this works.
596 2012-01-31 Murray Cumming <murrayc@murrayc.com>
598 Make ReportPlace usable.
600 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
602 * src/main/java/org/glom/web/client/place/ReportPlace.java:
603 Correct the @prefix annotation.
605 2012-01-31 Murray Cumming <murrayc@murrayc.com>
607 OnlineGlomService: Return report HTML rather than the LayoutGroup.
609 * src/main/java/org/glom/web/client/OnlineGlomService.java:
610 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
612 Change getReportLayout() to getReportHMTL() because we will not need to
613 parse or render the report layout on the client side.
614 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
615 getReportLayout(): Return the libglom LayoutGroup type because we will
616 not need to convert to a shared type, because this will not be used on
618 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
621 Note that there is still no implementation for this.
624 2012-01-27 Murray Cumming <murrayc@murrayc.com>
626 Add a (empty) Report Place, View, and Activity.
628 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
630 * src/main/java/org/glom/web/client/place/HasTablePlace.java
631 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
632 this into a superclass:
633 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
634 and also use it as the base of this new ReportPlace:
635 * src/main/java/org/glom/web/client/place/ReportPlace.java
637 * src/main/java/org/glom/web/client/ui/ReportView.java
638 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
639 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
640 Add these, containing mostly boiler-plate for now.
642 * src/main/java/org/glom/web/client/OnlineGlomService.java
643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
644 * src/main/java/org/glom/web/server/ConfiguredDocument.java
645 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
646 Add API to get the LayoutGroup for the report.
648 2012-01-23 Murray Cumming <murrayc@murrayc.com>
650 Add and fill a Reports drop-down list box.
652 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
654 * src/main/java/org/glom/web/client/OnlineGlomService.java:
655 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
656 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
657 Added getReports(document, table, localeID), calling
658 ConfiguredDocument.getReports().
659 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
660 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
661 Added setReportsList() and a list widget.
662 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
663 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
668 2012-04-12 Murray Cumming <murrayc@murrayc.com>
670 Translations: Add Esperanto.
672 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
673 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
674 properties: Add this translation because someone took the time to make it.
676 2012-03-15 Murray Cumming <murrayc@murrayc.com>
678 Adapt to the java-libglom 1.21.7 API.
680 * src/main/java/org/glom/web/server/ReportGenerator.java:
681 addToReport(): get_group_secondary_fields() is now
682 get_secondary_fields().
685 2012-03-15 Murray Cumming <murrayc@murrayc.com>
687 Use the latest java-libglom version.
689 * pom.xml: Use java-libglom 1.21.7.
691 2012-03-03 Ben Konrath <ben@bagu.org>
693 Display date and time in details view.
695 https://bugzilla.gnome.org/show_bug.cgi?id=671257
697 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
699 2012-03-05 Murray Cumming <murrayc@murrayc.com>
701 Require the latest java-libglom.
703 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
705 2012-03-04 Murray Cumming <murrayc@murrayc.com>
707 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
709 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
710 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
711 an empty quickfind string. I also corrected libglom to create only
712 empty where clauses for empty quickfind strings, but this avoids the
715 2012-02-24 Ben Konrath <ben@bagu.org>
717 Improve the tabs in the Notebook widget.
721 2012-01-30 Murray Cumming <murrayc@murrayc.com>
723 Translations: Try to translate the strings.
725 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
726 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
727 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
728 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
729 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
730 Take the Open translation from GTK+'s .po files.
731 Take the Details translation from Glom's po files.
732 I have added the other strings to Glom so we can get translations that way:
733 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
735 2012-01-27 Murray Cumming <murrayc@murrayc.com>
737 TableSelectionViewImpl: Put the search label and entry in a div.
739 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
740 Put the search widgets in a FlowTable so that the CSS can be used to
741 style them while keeping them together.
742 * src/main/webapp/style.css: Mention the new div.
744 2012-01-27 Murray Cumming <murrayc@murrayc.com>
746 Translate more strings in more locales.
748 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
749 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
750 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
751 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
752 Translate the "Details" and "Open" string too.
754 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
755 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
756 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
757 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
758 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
759 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
760 Add these new locales as placeholders though they currently contain English.
762 2012-01-27 Murray Cumming <murrayc@murrayc.com>
764 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
767 Check the ConfiguredDocument* for null before using it.
769 2012-01-26 Murray Cumming <murrayc@murrayc.com>
771 Tell Eclipse about the generated java files.
773 * .classpath: This lets it find OnlineGlomConstants.java.
774 It would be nice if Eclipse just used the maven build files.
776 2012-01-26 Murray Cumming <murrayc@murrayc.com>
778 Prevent a crash when no locale is specified in the URL.
780 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
781 Avoid returning a null string, obtained from
782 Window.Location.getParameter(). This caused a crash when it was
783 later passed to libglom's API.
784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
785 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
786 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
787 guard against future null strings.
789 2012-01-26 Murray Cumming <murrayc@murrayc.com>
791 Use the ?locale= query param instead of the &lang= token param.
793 * src/main/java/org/glom/web/client/place/ListPlace.java
794 * src/main/java/org/glom/web/client/place/DetailsPlace.java
795 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
796 Remove the lang token key and value.
798 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
799 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
800 When the user selects a different locale from the chooser, use
801 Window.Location.assign() to change the URL, which then causes a reload.
803 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
804 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
805 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
806 * src/main/java/org/glom/web/client/activity/ListActivity.java
807 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
808 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
809 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
810 * src/main/java/org/glom/web/client/ui/ListView.java:
811 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
813 Remove localeID member variables and method/constructor parameters, instead
814 using Utils.getCurrentLocaleID() when we need a localID to pass to
817 2012-01-26 Murray Cumming <murrayc@murrayc.com>
819 Internationalize the UI strings.
821 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
822 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
823 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
824 because it is unused. Messages are apparently strings that can have
825 parameters, but we do not need that yet, so Contants will be enough for now.
826 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
827 to say that we support the en and de locales.
828 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
829 The original English strings.
830 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
831 Some German translations of the English strings.
832 The i18n goal then uses the .properties file to generate an
833 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
834 returns an implementation that returns the translated strings.
835 The documentation suggests putting these in src/java/*/client/, but it seems
836 best to put it in src/resources/*/client/.
837 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
838 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
839 instead of hard-coding them.
840 Note that we cannot import OnlineGlomConstants because it does not exist yet,
841 but that does not seem to stop the build, though it confuses Eclipse.
843 You can see the translated string by adding ?locale=de to the URL, like so:
844 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
846 2012-01-24 Murray Cumming <murrayc@murrayc.com>
848 Improve null/empty String checks.
850 * pom.xml: Add a dependency on commons-lang, to use
851 org.apache.commons.lang.StringUtils.
852 * src/main/java/org/glom/web/server/ConfiguredDocument.java
853 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
854 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
855 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
856 Use StringUtils.isEmpty().
858 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
859 StringUtils class with a static isEmpty() function because we
860 cannot use org.apache.commons.lang.StringUtils in client-side
861 GWT code because it (apparently) cannot be compiled to javascript.
862 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
863 * src/main/java/org/glom/web/client/activity/ListActivity.java
864 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
865 * src/main/java/org/glom/web/client/place/DetailsPlace.java
866 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
867 * src/main/java/org/glom/web/client/place/ListPlace.java
868 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
869 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
870 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
871 * src/main/java/org/glom/web/client/ui/details/Group.java
872 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
873 our StringUtils.isEmpty() function.
875 2012-01-24 Murray Cumming <murrayc@murrayc.com>
877 Update to the latest java-libglom API.
879 * pom.xml: Require java-libglom 1.21.4.
880 * src/main/java/org/glom/web/server/ConfiguredDocument.java
881 getDocumentInfo(), getListViewLayoutGroup():
882 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
884 * src/main/java/org/glom/web/server/database/DBAccess.java
885 getFieldsToShowForSQLQueryAddGroup(),
886 getPrimaryKeyLayoutItemField(): Replace get_database_title()
887 with either get_database_title_original() or
888 get_database_title(localeID).
890 2012-01-24 Murray Cumming <murrayc@murrayc.com>
892 ConfiguredDocument: Avoid a null pointer exception.
894 * src/main/java/org/glom/web/server/ConfiguredDocument.java
895 Initialize localeID to "" to avoid returning a null String which
896 causes a crash in java-libglom's swing-generated code.
898 2012-01-23 Murray Cumming <murrayc@murrayc.com>
900 Some simple renaming.
902 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
903 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
904 for localeChooser. This seems more appropriate and is less ambiguous
905 particularly in the .css file.
907 2012-01-23 Murray Cumming <murrayc@murrayc.com>
909 ConfiguredDocument: Rename the localedID private member variable.
911 2012-01-23 Murray Cumming <murrayc@murrayc.com>
913 Adapt to the latest java-libglom API from git master.
915 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
916 libglom now uses only Vector instead of List, which uses add() instead of
919 2012-01-22 Murray Cumming <murrayc@murrayc.com>
921 ConfiguredDocument: Rename the localedID private member variable.
923 2012-01-20 Murray Cumming <murrayc@murrayc.com>
925 Build a source tarball with mvn assembly:single
927 * assembly.xml: Add this file.
928 * pom.xml: Use the maven-assembly-plugin and tell it to use
929 our assembly.xml file.
931 2012-01-19 Murray Cumming <murrayc@murrayc.com>
933 OnlineGlomServiceImpl: Get .glom files recursively.
935 * pom.xml: Depend on commons-io from org.apache.commons.
936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
937 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
938 files recursively, and with the easier filter for the extension.
939 Use org.apache.commons.io.FilenameUtils.removeExtension() to
940 simplify that code too.
942 2012-01-19 Murray Cumming <murrayc@murrayc.com>
944 README: Mention that you must install java-libglom packages separately.
946 But then it works, because java-libglom is now in the central maven
949 2012-01-18 Murray Cumming <murrayc@murrayc.com>
951 locales drop-down: Show the correct selected locale when the URL changes.
953 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
954 .java: setPlace(): Move some code into fillView().
956 2012-01-18 Murray Cumming <murrayc@murrayc.com>
958 locales drop-down: Do not lose the primary key.
960 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
961 start(): onLocaleChange(): Pass the current primary key value,
962 instead of an empty value.
964 2012-01-18 Murray Cumming <murrayc@murrayc.com>
966 locales drop-down: Do not lose the drop-down selection.
968 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
969 .java (TableSelectionActivity.fillView): Set the selected locale
970 after changing the drop-down items (though we do not really need
971 to change them just because the locale changes.)
973 2012-01-18 Murray Cumming <murrayc@murrayc.com>
975 locales drop-down: Change the tables list when this changes.
977 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
978 .java: TableSelectionActivity.start(): Move the async table titles
979 retrieval into a private fillView() method and also call this when
980 the chosen locale changes.
981 Note that the document title is not actually translatable yet, but
982 that is a problem that I should fix soon in libglom.
984 2012-01-18 Murray Cumming <murrayc@murrayc.com>
986 Improve the placement of the locales drop-down.
988 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
989 Put the title and locales drop-down in a div (gwt.FlowTable).
990 * src/main/webapp/style.css: Add magic css properties to make this work.
991 Also remove the left margin from the title so that it lines up with the
994 2012-01-18 Murray Cumming <murrayc@murrayc.com>
996 locales selector: Show human-readable locale titles.
998 * src/main/java/org/glom/web/server/ConfiguredDocument.java
999 getDocumentInfo(): Use java.util.Locale to show a real title of
1000 each locale, in the locale's own language.
1002 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1004 Add a language/locale selector drop-down.
1006 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1007 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1008 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1009 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1010 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1011 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1012 Add a ListBox to show the available locales. Add getLocaleSelector(),
1013 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1014 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1015 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1016 java: Add these classes.
1017 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1018 start(): Fill the locales ListBox. Handle its change event, firing a
1020 setPlace(): Show the selected locale as specified by the URL token.
1021 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1022 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1023 Handle LocaleChangeEvent, going to a new *Place with that locale.
1025 The placement of the ListBox is not pretty, and it currently uses the ID
1026 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1030 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1032 Search box: Show the search text from the URL token.
1034 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1035 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1036 Add setQuickFindText().
1037 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1038 .java: setPlace(): Store the queryText if the place is a ListPlace,
1039 and call TableSelectionView.setQuickFindText().
1041 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1043 Allow use of translations via, for instance, &lang=de in the URL.
1045 * pom.xml: Use the unstable java-libglom 1.21 version.
1047 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1048 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1049 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1050 init(): Instead of calling TranslatableItem.set_current_locale()
1051 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1052 However, this is only for default locales, which are not needed to
1053 change the locale in the URL.
1054 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1055 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1056 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1057 layout for a particular locale.
1058 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1059 Add get/setDefaultLocaleID().
1060 getDocumentInfo(), getListViewData(), getRelatedListData(),
1061 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1062 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1063 localeID parameter, so we can get the layout for a particular locale.
1065 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1066 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1067 * src/main/java/org/glom/web/client/place/ListPlace.java:
1068 Parse and construct a lang parameter too.
1070 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1071 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1072 passed to subsequent methods and constructors.
1073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1074 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1075 Store the localeID from the *Place and pass it to other constructors
1076 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1078 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1079 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1080 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1081 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1082 * src/main/java/org/glom/web/client/ui/ListView.java:
1083 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1084 Take localeID parameters and pass them to subsequent constructors and
1085 methods, so that the layout is always retrieved for that locale.
1087 This is rather repetitive.
1089 Note that "" means the original (default) locale of the Glom document,
1090 which is usually English.
1092 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1094 Documents: Remove final keyword to fix startup configuration.
1096 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1097 final keywords on the private member variables because that breaks
1098 the startup, apparently (there are warnings) because it stops them
1099 from being serialized. I added these in the previous commit.
1101 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1103 Documents: Add some final keywords.
1105 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1108 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1110 OnlineGlomServiceImpl: Add to overview comments.
1112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1113 Note that this is where all the document are loaded. They are not
1114 loaded freshly for each page.
1116 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1120 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1121 Add a TextBox for the text of a quick find.
1122 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1124 setBackLink(): Add a String quickFind parameter.
1125 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1126 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1127 to the base interface, because that is how TableSelectionViewImpl is used.
1128 * src/main/webapp/style.css: Add style for the search box and its label.
1130 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1131 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1132 Add these files, based on the existing TableChangeEvent and
1133 TableChangeEventHandlers.
1134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1135 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1136 a ListPlace() that the user should be taken to.
1137 * src/main/java/org/glom/web/client/activity/ListActivity.java
1138 start(): Handle it here too and adapt the TableChangeEvent handler to
1139 pass the extra "" quickFind parameter to ListPlace.
1140 * src/main/java/org/glom/web/client/place/ListPlace.java:
1141 Constructor: Take an extra String quickFind parameter and store it,
1142 returning it from a new getQuickFind() method.
1143 getToken(): Put the quickFind text in the URL token.
1144 getPlace(): Parse the quickFind text from the URL token.
1145 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1146 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1147 ListPlace constructor.
1148 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1149 .java: start(): Add a Change handler for the TableSelectionView's
1150 TextBox (via its base HasChangeHandlers interface), firing the new
1151 QuickFindChangeEvent.
1152 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1153 pass the extra "" quickFind parameter.
1155 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1156 setCellTable(): Add a String quickFind parameter and pass it to
1157 the ListViewTable() constructor.
1158 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1159 setCellTable() in the base interface, because that is how ListViewImpl
1162 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1163 Add a String quickFind member variable.
1164 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1165 Constructor: Add a String quickFind parameter, storing it in the
1166 base ListTable's member variable.
1167 onRangeChanged(): Pass quickFind to the
1168 OnlineGlomServiceAsync.getSortedListViewData() and
1169 OnlineGlomServiceAsync.getListViewData() methods.
1171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1172 getListViewData(), getSortedListViewData(): Add a String quickFind
1173 parameter, passing it to ConfiguredDocument.getListViewData().
1174 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1175 Change getListViewData(), getSortedListViewData() in the base interface,
1176 because that is how OnlineGlomServiceImpl is used, via this:
1177 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1178 Change getListViewData(), getSortedListViewData() here too.
1179 This class can apparently be used to asynchronously call methods on
1180 OnlineGlomService, and GWT seems to implement that after recognizing
1181 just the *Async name convention and the extra AsyncCallback parameters.
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1184 getListViewData(): Add a String quickFind parameter, and pass it to
1185 ListViewDBAccess.getData().
1186 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1187 getListData(): Add a String quickFind parameter and pass it to
1189 getSelectQuery(): Add a String quickFind parameter.
1190 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1191 getSelectQuery(): Add a String quickFind parameter and use it with
1192 Glom.get_find_where_clause_quick() to pass a where_clause to
1193 Glom.build_sql_select_with_where_clause(), to actually filter the
1195 getData(): Add a String quickFind parameter, passing it to getListData().
1196 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1197 va: getData(): Pass an empty string to getListData() for the
1198 quickFind parameter.
1200 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1202 ListTable: Minor change.
1204 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1205 createCellTable(): Make this protected instead of public.
1207 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1209 Many files: Use final for the parameters and use the @override attribute.
1211 2012-01-22 Ben Konrath <ben@bagu.org>
1213 Add anchor links for single line text that starts with http, ftp and www.
1217 2012-01-22 Ben Konrath <ben@bagu.org>
1219 Add ellipsis to single line text in details view.
1223 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1225 Remove all javadoc author tags.
1227 Because they are awkward and meaningless when many people touch
1229 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1231 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1233 Revert the COPYING.LESSER to COPYING rename.
1235 Apparently both should be there if it is LGPL.
1237 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1239 *View: Remove unused imports.
1241 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1242 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1243 * src/main/java/org/glom/web/client/ui/ListView.java:
1244 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1245 Remove unused imports, as suggested by Eclipse.
1247 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1249 Move the *View::Presenter types, and some API into one base View.
1251 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1252 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1253 * src/main/java/org/glom/web/client/ui/ListView.java:
1254 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1255 Presenter, setPresenter() and clear() into a shared base interface,
1256 to avoid the unnecessary duplicate Presenter types and to more clearly
1257 show how the *Views share the same structure, even if they are not
1258 used polymorphically.
1260 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1261 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1263 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1264 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1265 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1267 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1270 Feel free to revert this if there is a good reason for the duplicate
1273 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1275 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1277 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1278 a class member instead of a local variable in the method.
1279 This lets us use it to get the view instances, for use in tests.
1280 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1281 beforeOnlineGlom(): Test some more details of the initial view.
1282 Again, this is not very useful.
1284 To really test gwt-glom we will need to start a local postgresql
1285 instance with local data, like the Glom tests in C++.
1287 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1289 pom.xml: Mention the LGPL license.
1291 * pom.xml: Add a licenses section.
1292 * COPYING.LESSER: Move this to COPYING, which
1293 previously contained the GPL. But gwt-glom is all LGPL.
1295 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1297 Add project information to README and pom.xml.
1299 * README: Add a brief description and mention some mvn
1301 * pom.xml: This extra information shows up in mvn site
1304 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1306 Use the latest java-libglom version.
1308 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1310 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1312 GwtTestOnlineGlom: Test a little more.
1314 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1315 protected rather than private, as suggested by the gwt-test-utils
1317 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1318 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1319 Test the initial visibility of the panels.
1321 However, this is not a very useful test.
1322 And I wonder how we should generally test using this idea for an
1323 activity/places app like ours where the real changes happen implicitly
1324 based on the history token/URL.
1326 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1328 Slight modification to *Mapper comments.
1330 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1331 (DataActivityMapper)
1332 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1334 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1336 Remove comments mentioning GIN because they are just copied from
1337 the example code and are apparently not helpful:
1338 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1339 Also change the mention of a class that is only in the example code.
1341 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1343 GwtTestOnlineGlom test: Minor changes.
1345 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1346 Avoid the long qualified class name and modify the comment
1347 because it is now obvious to me that the mocked class is the only
1348 custom one created via GWT.create().
1350 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1352 Tests: Added the beginnings of a test using gwt-test-utils.
1354 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1355 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1356 which tells gwt-test-utils what class will be tested.
1357 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1358 Add a simple (but empty) test case. One class, used by the OnlineGlom
1359 class, is mocked so that it can be created. However, I am not sure
1360 why only this class needs to be mocked.
1362 Note that mockito seems more popular, and clearer, than easymock,
1363 but I have not got that working yet. It might be a matter of the
1366 This test is run during mvn integration-test.
1368 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1370 Tests: Use junit4-style syntax instead of junit3-style.
1372 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1373 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1374 * src/test/java/org/glom/web/shared/DataItemTest.java:
1375 Use the @Test annotation rather than relying on the test*() prefix.
1376 Also no longer implement TestCase, to avoid triggering support for
1377 the junit3-way, which stops the annotations from working.
1378 Change the imports from import junit.framework.* to
1379 import org.junit.*, which is apparently the new way.
1381 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1383 Added a test for ListPlace token parsing and creation.
1385 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1386 This is much the same as DetailsPlaceTest.
1388 I wonder how we could test the other parts of the *Place API.
1390 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1392 DetailsPlace test: Also test getToken() and recreation via getPlace().
1394 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1395 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1396 recreate it, testing the recreated DetailsPlace for the same parameter
1399 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1401 Use the surefire-report plugin.
1403 * pom.xml: This generates a HTML report about the tests in
1404 target/site/surefire-report.html
1405 when you do mvn surefire-report:report. It seems to be popular/normal.
1407 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1409 Added a test for DetailsPlace.
1411 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1412 Test the getPlace() token parsing.
1414 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1416 Added a first unit test.
1418 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1419 * src/test/java/org/glom/web/shared/DataItemTest.java:
1420 This is a silly test but it is just to get things started. Note that
1421 maven/junit finds the test because it looks in src/test by default.
1423 2011-12-22 Ben Konrath <ben@bagu.org>
1425 Change charsetName to "UTF-8" when replacing line breaks.
1427 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1428 that work in Java (such as "UTF8") will not work when compiled to
1431 This fixes a problem with multi-line details view fields that have hard
1432 line breaks. The "License Text" field on this page demonstrates the
1435 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1437 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1439 2011-12-22 Ben Konrath <ben@bagu.org>
1441 Fix another bug with related list navigation.
1443 I've tested all the navigation buttons in all of the related lists
1444 so things should be good now.
1446 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1448 2011-12-22 Ben Konrath <ben@bagu.org>
1450 Fix a crasher when refreshing the list view with the default table.
1452 This crash will also happen when loading the list view with the default
1453 table from a link or bookmark.
1455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1456 to the main document selection page when the document id hasn't been
1458 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1459 the main document selection page when the document id hasn't been
1461 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1462 values for the details place when the document id hasn't been set.
1463 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1464 values for the list place when the document id hasn't been set.
1466 2011-12-21 Ben Konrath <ben@bagu.org>
1468 Protect against NPE when glom.document.locale is not in config.
1470 This patch protects against an NPE when glom.document.locale is not in
1471 the config file. This NPE will also happen if glom.document.locale is
1474 The patch also updates the error message to display the class name when
1475 the getMessage() returns null. This was happening when the NPE was
1476 thrown and I had "Configuration Error: null". If an NPE is encountered
1477 with this patch, "Configuration Error: NullPointerException " will be
1480 This commit closes this bug:
1482 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1484 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1486 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1488 Rename onlineglom.properties to onlineglom.properties.sample.
1490 * src/main/resources/onlineglom.properties: Rename to:
1491 * src/main/resources/onlineglom.properties.sample:
1492 * src/main/resources/README: And add this file explaining that people
1493 should rename it back when deploying.
1495 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1497 Allow choosing the translation in the .properties file.
1499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1500 init(): Read a glom.document.locale value from the configuration file
1501 and call Glom's TransatableItem::set_current_locale() method.
1502 * src/main/resources/onlineglom.properties: Add a commented-out
1503 example of this new setting.
1505 It would be better to add &lang=de_DE to the URL, but the current
1506 libglom API does not allow us to do this easily. I am working on that.
1508 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1510 Avoid a crash in parsing of token parameters.
1512 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1513 ava: getTokenParams(): Do not crash if a parameter has a key but no
1514 value, and ignore parameters with neither.
1516 2011-12-17 Murray Cumming <murrayc@murayc.com>
1518 History token building/handling: Improve use of token parameters.
1520 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1521 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1522 and buildParamsToken(HashMap), for use by derived classes.
1523 Make the separator private because it is no longer be needed.
1524 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1525 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1526 instead of manual string concatenation.
1527 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1528 of hardcoded indices and awkward splitting code.
1529 * src/main/java/org/glom/web/client/place/ListPlace.java
1530 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1531 instead of manual string concatenation.
1532 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1533 of hardcoded indices and awkward splitting code.
1534 This should fix bug #666420
1536 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1538 Fix a Navgiation->Navigation typo in the code.
1540 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1541 Rename processNavgiation() to processNavigation().
1543 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1545 Fix a seperator->separator typo in the code.
1547 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1548 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1549 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1552 2011-12-15 Ben Konrath <ben@bagu.org>
1554 Cleanup some comments.
1556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1558 2011-12-14 Ben Konrath <ben@bagu.org>
1560 Replace \n with <br/> for multiline text in the details view.
1562 Vertical scrollbars are added when needed as well.
1564 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1566 2011-12-14 Ben Konrath <ben@bagu.org>
1568 Specify the font for document selection links.
1570 * src/main/webapp/style.css:
1572 2011-12-14 Ben Konrath <ben@bagu.org>
1574 Fix bouncy CellTable while paging.
1576 This doesn't currently work with related list tables in unselected
1579 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1581 2011-12-14 Ben Konrath <ben@bagu.org>
1583 Revamp the appearance of the document selection page.
1585 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1586 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1587 * src/main/webapp/style.css:
1589 2011-12-13 Ben Konrath <ben@bagu.org>
1591 Set navigation button column to the smallest size possible.
1593 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1595 2011-12-13 Ben Konrath <ben@bagu.org>
1597 Change OpenButton nomenclature to NavigationButton.
1599 Using NavigtionButton makes things more generic. Classes, methods and
1600 variables have been changed.
1602 This is a rename-only refactor.
1604 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1605 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1606 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1607 Renamed from OpenButtonCell.
1608 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1609 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1610 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1612 2011-12-12 Ben Konrath <ben@bagu.org>
1614 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1616 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1617 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1618 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1619 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1621 2011-12-12 Ben Konrath <ben@bagu.org>
1623 Update variable names and comments.
1625 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1626 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1628 2011-12-12 Ben Konrath <ben@bagu.org>
1630 Properly initialize numNonEmptyRows variable to zero.
1632 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1633 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1635 2011-12-05 Ben Konrath <ben@bagu.org>
1637 Add latest mockup with HTML tables.
1639 Features of this mockup:
1641 -> HTML table for flowtable
1642 -> HTML table for flowtable column
1643 -> Example of how related lists would look
1644 -> Not using text entries for data items
1646 The current version of Online Glom doesn't use HTML tables for the
1649 This mockup has been sent to the glom-devel mailing list but it's good
1650 to have it here as well.
1652 * mockups/details-view-html-tables.html:
1654 2011-12-05 Ben Konrath <ben@bagu.org>
1656 Remove unnecessary getPrimaryKeyField() method.
1658 getPrimaryKeyFieldForTable(String) has been renamed to
1659 getPrimaryKeyField(String).
1661 * src/main/java/org/glom/web/server/database/DBAccess.java:
1662 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1663 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1665 2011-12-05 Ben Konrath <ben@bagu.org>
1667 Add string representation of TypedDataItem value to conversion error message.
1669 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1670 message was extracted into its own method to avoid duplication.
1672 2011-12-05 Ben Konrath <ben@bagu.org>
1674 Add type checking to navigation primary key value creation.
1676 Create navigation primary key only if the expected type from the Glom
1677 document matches the type returned by the SQL query.
1679 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1681 2011-12-05 Ben Konrath <ben@bagu.org>
1683 Rename a couple of variables in RelatedListNavigation.
1685 This is a rename-only refactor.
1687 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1689 2011-12-05 Ben Konrath <ben@bagu.org>
1691 Move getListLayoutGroup() into getListViewLayoutGroup().
1693 This removes getListLayoutGroup(). It was only being called by
1694 getListViewLayoutGroup().
1696 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1698 2011-12-05 Ben Konrath <ben@bagu.org>
1700 Remove check for LayoutItem_Portal in list table method.
1702 This check is no longer necessary because the method isn't being used
1703 to create the LayoutItemPortal DTO.
1705 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1707 2011-12-05 Ben Konrath <ben@bagu.org>
1709 Properly support related list navigation.
1711 Navigation from the "Repository Analyzer -> Package Scans ->
1712 Dependencies" related table wasn't working because the primary key for
1713 related tables wasn't being set properly. This commit fixes the
1716 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1717 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1718 doesn't set the primary key properly for related list tables.
1719 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1720 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1721 useful for getting the primary key for list view tables and for related
1723 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1724 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1725 Move code to set the primary key for the table from the abstract
1726 ListDBAccess class to ListViewDBAccess as it's only correct for list
1728 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1729 Properly add primary key to related list tables.
1731 2011-12-02 Ben Konrath <ben@bagu.org>
1733 Properly set the horizontal alignment of fields.
1735 This fix is for both the list tables and the details view.
1737 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1738 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1739 to set the horizontal alignment of fields.
1741 2011-12-02 Ben Konrath <ben@bagu.org>
1743 Display currency codes in the details view.
1745 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1747 2011-12-02 Ben Konrath <ben@bagu.org>
1749 Avoid duplicate JNI call.
1751 JNI is not as efficient as pure Java and this is an easy (and small)
1754 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1755 Use previously retrieved value for whereClauseToTableName instead of
1758 2011-12-02 Ben Konrath <ben@bagu.org>
1760 Rename a couple of variables in RelatedListNavigation.
1762 This is a rename-only refactor.
1764 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1766 2011-12-02 Ben Konrath <ben@bagu.org>
1768 Indicate clearly that a mismatched primary key type is a bug.
1770 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1771 warning to error. Add 'This is a bug.' to message.
1773 2011-12-02 Ben Konrath <ben@bagu.org>
1775 Update / fix some comments.
1777 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1779 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1781 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1782 Fix comments. Add some TODOs.
1784 2011-12-02 Ben Konrath <ben@bagu.org>
1786 Enable navigation to details view with string primary key from related list.
1788 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1789 Create a text primary key value when return type of result is
1790 java.sql.Types.VARCHAR.
1792 2011-12-02 Ben Konrath <ben@bagu.org>
1794 Use checkboxes for booleans in the details view.
1796 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1798 2011-12-01 Ben Konrath <ben@bagu.org>
1800 Improve performance of related list height calculation.
1802 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1803 Put code to calculate the expected height in a static initializer so
1804 that that it's only called once.
1806 2011-12-01 Ben Konrath <ben@bagu.org>
1808 Show related list tables in notebooks (again).
1810 Calculate the height of the related list tables so the Notebook can be
1811 set the correct height. The height of the related list table is also needed by
1812 FlowTable to be able decide how to create the layout.
1814 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1815 and set the Portal height based on the height of the related list
1816 table and the Portal container.
1817 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1818 Add method to calculate the height of the related list tables.
1819 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1820 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1821 calculate the height of the Pager widget.
1823 2011-12-01 Ben Konrath <ben@bagu.org>
1825 Use CellTable API for table property instead of setting style on Element.
1827 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1829 2011-12-01 Ben Konrath <ben@bagu.org>
1831 Make ListViewTable and RelatedListTable a consistent height.
1833 The tables are now a consistent height regardless of the contents of
1834 the table. A hidden button is added to empty rows to ensure that the
1835 height of these rows will match the height of rows with data.
1837 A navigation button column is now added to every table. The width of
1838 the navigation column is set to 0px when a RelatedListTable shouldn't
1839 have navigation buttons. This maintains the a consistent row height in
1840 tables that don't show the navigation buttons.
1842 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1843 navigation column when not needed.
1844 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1845 arguments for navigation button to constructor of ListViewTable.
1846 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1847 hidden button for empty data rows.
1848 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1849 arguments for navigation button to constructor.
1850 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1851 create navigation buttons. Add hideNavigationButtons() method.
1852 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1853 arguments for navigation button to constructor.
1855 2011-12-01 Ben Konrath <ben@bagu.org>
1857 Use 'visibility: hidden' in Utils.getWidgetHeight().
1859 This is better choice because hidden elements are invisible, don't
1860 respond to events and are not part of the tab order. They will,
1861 however, take up space which is required to be able to calculate the
1862 height of the widget.
1864 * src/main/java/org/glom/web/client/Utils.java:
1866 2011-12-01 Ben Konrath <ben@bagu.org>
1868 Use Utils.getWidgetHeight() in FlowTable.
1870 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1872 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1874 2011-12-01 Ben Konrath <ben@bagu.org>
1876 Put the details css class name on the correct table column.
1878 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1880 2011-11-30 Ben Konrath <ben@bagu.org>
1882 Update for java-libglom API change.
1884 The getters and setters on FieldFormatting and NumericFormat were
1885 changed to remove the 'M'.
1887 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1889 2011-11-29 Ben Konrath <ben@bagu.org>
1891 Only allow RelatedListTables in Portals.
1893 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1895 2011-11-29 Ben Konrath <ben@bagu.org>
1897 Only create a contents panel for Portals when title is being set.
1899 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1901 2011-11-29 Ben Konrath <ben@bagu.org>
1903 Set TabLayoutPanel height based on calculated height its widgets.
1905 This is a potential fix for this bug:
1907 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1909 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1911 2011-11-29 Ben Konrath <ben@bagu.org>
1913 Align details field labels and data with the Open buttons.
1915 * src/main/webapp/style.css:
1917 2011-11-29 Ben Konrath <ben@bagu.org>
1919 Remove unnecessary <div> in the Notebook widget.
1921 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1922 method to get container FlowPanel (<div>).
1923 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1924 initWidget() method directly on the TabLayoutPanel widget instead of
1925 Group's container widget.
1927 2011-11-29 Ben Konrath <ben@bagu.org>
1929 Don't add group titles for Portals in Notebooks.
1931 This reverts the previous patch and fixes a bug I introduced with
1932 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1934 * src/main/java/org/glom/web/client/ui/details/Group.java:
1935 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1937 2011-11-28 Ben Konrath <ben@bagu.org>
1939 Remove unused boolean argument in Portal constructor.
1941 Just a code cleanup.
1943 * src/main/java/org/glom/web/client/ui/details/Group.java:
1944 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1946 2011-11-28 Ben Konrath <ben@bagu.org>
1948 Remove hack for glom 1.18 style glom files.
1950 * src/main/java/org/glom/web/client/ui/details/Group.java:
1951 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1952 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1954 2011-11-28 Ben Konrath <ben@bagu.org>
1956 Use Gda Value version of primary key to log result too large error.
1958 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1960 2011-11-28 Ben Konrath <ben@bagu.org>
1962 Don't use TypedDataItem.getText() for Unknown types from the URL.
1964 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1965 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1966 instead of getText().
1967 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1968 String field and getUnknown() method.
1970 2011-11-28 Ben Konrath <ben@bagu.org>
1972 Log an error message when the java-libglom .so is not present.
1974 The error message was being set in the exception but not logged.
1976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1978 2011-11-28 Ben Konrath <ben@bagu.org>
1980 Ignore LayoutItem_CalendarPortals.
1982 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1983 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1985 2011-11-28 Ben Konrath <ben@bagu.org>
1987 Extract method for creating the LayoutItemPortal DTO.
1989 Just breaking the code up into smaller chunks.
1991 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1993 2011-11-28 Ben Konrath <ben@bagu.org>
1997 This should have been added with the refactor. Oops!
1999 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2001 2011-11-28 Ben Konrath <ben@bagu.org>
2003 Create primary key value from URL string using type from Glom document.
2005 See this bug, comments 19 - 25:
2007 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2009 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2010 create a TypeDataItem for the primary key here when loading from a
2011 URL. Show the same string for the primary key value as was received
2012 from the URL string (when loading from a URL).
2013 * src/main/java/org/glom/web/server/Utils.java: Update method for
2014 creating the Gda Value from the TypeDataItem to properly deal with
2015 creating a Gda Value based on the Glom document type for the primary
2016 key value string when loading from a URL.
2017 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2018 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2019 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2020 Update for changed method name.
2022 2011-11-27 Ben Konrath <ben@bagu.org>
2024 Rename PrimaryKeyItem to TypedDataItem.
2026 The name PrimaryKeyItem suggests what the class should be used for.
2027 TypedDataItem is a neutral name that describes the class better.
2029 This is a rename-only refactor.
2031 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2032 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2033 * src/main/java/org/glom/web/client/Utils.java:
2034 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2035 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2036 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2037 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2038 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2039 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2041 * src/main/java/org/glom/web/server/Utils.java:
2042 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2043 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2044 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2045 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2047 2011-11-25 Ben Konrath <ben@bagu.org>
2049 Improve Gda Value conversion from PrimaryKeyItem.
2051 The value from the PrimaryKeyItem is only used if its type match the
2052 type from the glom document.
2054 * src/main/java/org/glom/web/server/Utils.java:
2056 2011-11-25 Ben Konrath <ben@bagu.org>
2058 Manually check if the java-liblgom .so is visible to the JVM.
2060 It seems that Tomcat has problems when a static initializer throws an
2061 exception. This check is done before the first method call into
2062 java-libglom so that execution doesn't continue if the .so is not
2065 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2067 2011-11-25 Ben Konrath <ben@bagu.org>
2069 Improve browser configuration error messages.
2073 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2075 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2076 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2077 getConfigurationErrorMessage() method.
2078 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2079 Get and display a specific configuration error message when no Glom
2080 documents are found.
2081 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2082 Implement getConfigurationErrorMessage() method. Surround configuration
2083 code in the init() method with a try/catch block. This allows the
2084 errors to be caught while keeping the servlet available to retrieve the
2085 configuration error message.
2087 2011-11-25 Ben Konrath <ben@bagu.org>
2089 Don't use Strings to hold primary key values.
2091 The primary key values are now held in a new data object
2092 (PrimaryKeyItem) that holds type information and the primary key value
2093 using the correct type.
2095 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2096 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2098 PrimaryKeyItem instead of String to hold the primary key value.
2099 * src/main/java/org/glom/web/client/Utils.java: Remove
2100 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2101 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2102 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2103 PrimaryKeyItem instead of String to hold the primary key value. Load
2104 document selection page when the documentID has not been set correctly.
2105 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2106 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2108 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2109 Return empty string for URL instead of "null".
2110 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2111 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2112 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2113 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2114 PrimaryKeyItem instead of String to hold primary key values.
2115 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2116 PrimaryKeyValue to a Gda Value.
2117 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2118 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2119 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2120 Replace temporary database access code that uses the PrimaryKeyValue to
2121 Gda Value conversion.
2122 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2123 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2124 PrimaryKeyItem instead of String.
2125 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2126 hold primary key values.
2128 2011-11-24 Ben Konrath <ben@bagu.org>
2130 Use newly added java-libglom API to create queries.
2132 This isn't finished. I still need to stop using Strings for primary key
2133 values in the client code.
2135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2136 libglom to use fake connections so that retrieving the query string will
2138 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2139 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2140 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2141 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2142 Use the newly added libglom sql methods and classes to create the
2143 query. Add temporary hack to convert primary value strings to Gda
2146 2011-11-23 Ben Konrath <ben@bagu.org>
2148 Don't explicitly set the height of Portals.
2150 See comments 6 - 10 of this bug for details:
2152 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2154 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2156 2011-11-23 Ben Konrath <ben@bagu.org>
2158 Use an HTML table instead of CSS for the FlowTable layout.
2160 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2161 GWT's FlexTable to implement the FlowTable.
2162 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2164 2011-11-18 Ben Konrath <ben@bagu.org>
2166 Add boolean example to HTML table mockup.
2168 * mockups/details-view-html-tables-text-entries.html:
2170 2011-11-17 Ben Konrath <ben@bagu.org>
2172 Ensure the pager buttons are always visible for related lists.
2174 To accomplish this, I've turned off text wrapping in the list view and
2175 related list tables for both the header and data text. The related list
2176 table now has a fixed layout so the it doesn't overflow its container.
2177 This is required to ensure that the cell text is clipped when it
2178 overflows the cell and an ellipsis is added to the right side of the
2179 cell when text is clipped.
2181 A fixed table layout for the related list table in the details view
2182 seems what we want for the details view anyway, so the side-effect is
2185 The ellipsis will only be displayed in Firefox >= 7.
2189 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2191 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2192 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2193 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2195 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2196 Set the 'table-layout: fixed' CSS property to the related list table.
2197 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2198 'white-space: nowrap;' CSS property on both the list view and the
2199 related list tables.
2201 2011-11-16 Ben Konrath <ben@bagu.org>
2203 Rework the fix for empty notebook tab labels.
2205 Setting the empty group titles with its name caused problems for the
2206 details layout. Instead of using libglom's
2207 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2208 to the client when the title is empty. This allows the Notebook to use
2209 the name when the title is empty without affecting anything else.
2211 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2212 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2214 2011-11-16 Ben Konrath <ben@bagu.org>
2216 Set group titles with name when title is empty.
2218 This fixes a problem with an empty notebook tab label in the Lesson
2219 Planner document. The forth tab in the notebook should be "Internet":
2221 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2223 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2224 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2227 2011-11-16 Ben Konrath <ben@bagu.org>
2229 Remove whitespace from the configured username properties.
2231 This assumes that usernames won't have whitespace at the beginning
2232 or end. But I think this is a reasonable assumption.
2234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2235 String.trim() to remove the whitespace from the username properties.
2237 2011-11-15 Ben Konrath <ben@bagu.org>
2239 Add details view mockup with HTML tables and text entries.
2241 This is from the attachment on this bug:
2243 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2245 * mockups/details-view-html-tables-text-entries.html:
2247 2011-11-15 Ben Konrath <ben@bagu.org>
2249 Add space between the columns of the flow table.
2253 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2255 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2256 space between columns in the flow table.
2258 2011-11-15 Ben Konrath <ben@bagu.org>
2260 Add backup files to the .gitignore.
2262 * .gitignore: Ignore files that end with ~.
2264 2011-11-09 Ben Konrath <ben@bagu.org>
2266 Use latest release of gwt-log.
2268 Gwt-log releases are now being submitted to the maven central
2269 repository so manual installation of the jar is no longer required.
2271 * pom.xml: Update version and groupId of gwt-log dependency.
2273 2011-10-31 Ben Konrath <ben@bagu.org>
2275 Don't use GWT numeric formatting to override the glom currency formatting.
2277 Currencies are now displayed like they are in Glom. See this bug:
2279 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2281 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2283 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2284 currency code to constructor and set it when the cell is rendered.
2285 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2286 currency code to the constructor of the NumericCell.
2288 2011-10-27 Ben Konrath <ben@bagu.org>
2290 Require the latest release of java-libglom (1.17.4).
2294 2011-10-26 Ben Konrath <ben@bagu.org>
2296 Add style to Notebook that matches current theme.
2298 It's not the best style in the world but it's better than the default.
2300 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2301 padding at the bottom of the child widgets.
2302 * src/main/webapp/style.css: Add style for the Notebook.
2304 2011-10-26 Ben Konrath <ben@bagu.org>
2306 Move servlet initialization code to overridden init method.
2308 This is half of the solution to getting proper error messages
2309 displayed when configuration errors occur. Here's the relevant bug:
2311 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2313 The rest of the solution involves surrounding the init method with a
2314 try/catch block and setting a global variable with the error /
2315 exception. A new async method should be created to retrieve and display
2316 the error message / exception.
2318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2319 code from constructor to init method adding exceptions as needed.
2321 2011-10-26 Ben Konrath <ben@bagu.org>
2323 Add script to monitor and restart tomcat if required.
2325 * utils/check-and-recover-tomcat.py: New file.
2327 2011-10-26 Ben Konrath <ben@bagu.org>
2329 Display the correct number of data items in the pager.
2333 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2335 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2336 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2337 The implementation is the same for both tables: Keep track of the
2338 number of non-empty rows and fire and RowCountChangeEvent after the data has
2340 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2341 custom Pager class that subclasses SimplePager to handle displaying
2342 the correct number when empty rows have been added.
2344 2011-10-26 Ben Konrath <ben@bagu.org>
2346 Correct error in previous commit.
2348 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2349 eventBus parameter from listView.setCellTable().
2351 2011-10-26 Ben Konrath <ben@bagu.org>
2353 Fix error in TODO comment.
2355 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2357 2011-10-24 Ben Konrath <ben@bagu.org>
2359 Create Notebook widgets to the details view.
2361 This isn't finished just yet - I still need to create a reasonable
2362 style to match the current theme.
2364 * src/main/java/org/glom/web/client/Utils.java: Add method for
2365 calculating the height of a widget. This is used in the Notebook class.
2366 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2367 new constructor method in Group.
2368 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2369 method for creating child widget that can be used by subclasses
2370 like Notebook. New constructor that allows disabling the group
2371 titles - Notebooks don't set a group title for their child groups.
2372 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2373 to make Notebooks using GWT's TabLayoutPanel.
2374 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2375 constructor that allows disabling the group titles.
2376 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2377 LayoutItemNotebook DTO.
2378 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2379 DTO for Notebooks. It's just an empty class for now but we might need
2380 it to transfer some specific information in the future.
2382 2011-10-21 Ben Konrath <ben@bagu.org>
2384 Add navigation buttons to related list tables.
2386 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2387 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2388 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2389 method getSuitableRecordToViewDetails() for getting the table name
2390 and primary key value for related list navigation buttons.
2391 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2392 private cell renderer class to get the navigation information for
2393 related list tables from the server. Extract the navigation
2394 processing code from the details cell navigation and use it for the
2395 related list navigation as well.
2396 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2397 cell renderer class for the details open buttons. This was needed
2398 because the related list navigation buttons and the list view
2399 navigation buttons need to react differently when clicked.
2400 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2401 the onEnterKeyDown() method because it's now overriden in the
2402 subclasses that are specific to the related list tables and the list
2404 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2405 the vertical size a little because the buttons add a bit of vertical
2406 space to table. This is not a perfect solution because the vertical
2407 size of with table fewer than 5 rows will be a little smaller.
2408 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2409 changes in how navigation buttons are handled.
2410 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2411 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2412 database access object.
2413 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2414 to find the portal for a given relationship name from
2415 RelatedListDBAccess. Add method to find a primary key field for a
2417 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2418 Move code to find the portal for a given relationship name to
2420 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2421 New file: database access object for getting the related list
2422 navigation information (the table name and the primary key value).
2423 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2424 DTO for transferring a table name to navigate to and a primary key
2426 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2427 boolean and getter/setter to specifies if the related list should add
2430 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2432 Use the master branch of java-libglom
2434 * pom.xml: Depend on java-libglom 1.19 instead.
2436 This is the master branch. See also the libglom-1-18 branch.
2438 2011-10-11 Ben Konrath <ben@bagu.org>
2440 Enable the open navigation button when the data has been set.
2442 This avoids having active buttons that don't do anything when the data
2445 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2447 2011-10-11 Ben Konrath <ben@bagu.org>
2449 Use IsWidget interface for FlowTableItem.
2451 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2452 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2454 2011-10-11 Ben Konrath <ben@bagu.org>
2456 Remove GWT styling from open button in details view.
2458 There are still some issues with how the details cell is arranged but
2459 this should be made to match Glom 1.20. I'm going to leave fixing this
2460 until I have Glom 1.20 up and running.
2462 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2463 style name on open button.
2464 * src/main/webapp/style.css: Move and edit details-navigation class.
2465 Re-arrange some classes to make them appear in the same order as the
2468 2011-10-07 Ben Konrath <ben@bagu.org>
2470 Update to GWT 2.4.0.
2472 * .gitignore: Ignore new cache directory.
2473 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2474 * pom.xml: Change GWT and maven plugin to 2.4.0.
2475 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2477 * src/main/java/org/glom/web/client/ClientFactory.java:
2478 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2479 * src/main/java/org/glom/web/client/OnlineGlom.java:
2480 Update source for API changes.
2481 * utils/build-onlineglom-war.sh: Remove cache directory before the
2484 2011-10-07 Ben Konrath <ben@bagu.org>
2486 Add navigation buttons in the details view.
2488 This isn't finished but I thought I'd commit what I have as it's a
2489 pretty good start. I still need to:
2491 1. Change the style so that it fits better into the current theme
2492 2. Adjust the details cell to expand as much as possible.
2494 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2495 click handlers to navigation buttons in the DetailsCells. Create a
2496 refreshData() method to get just the data from the server without the
2498 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2499 Update the tableSelector and browser title when the table name
2500 changes without using the tableSelector.
2501 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2502 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2503 getDetailsCells() to getCells(). Update variable names.
2504 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2505 method to set click handler on navigation button. Rename a few
2506 variables. Add navigation buttons where needed.
2507 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2508 variables and methods.
2509 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2510 navigation boolean and navigation table as required in the
2511 LayoutItemField DTO.
2512 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2513 variables for navigation along with getter/setter methods.
2515 2011-10-07 Ben Konrath <ben@bagu.org>
2517 Rename Field to DetailsCell.
2519 This is a refactor-only commit. No functionality has been added or
2522 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2523 Update variable and method names.
2524 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2525 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2526 variable and method names.
2527 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2529 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2530 variable and method names.
2532 2011-10-07 Ben Konrath <ben@bagu.org>
2534 Create separate methods for layout and data the details view.
2536 This is a refactor-only commit. No functionality has been added or
2539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2540 private methods: setData(), createLayout().
2542 2011-10-07 Ben Konrath <ben@bagu.org>
2544 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2546 This is part of a change to get navigation buttons in the details view
2547 but it should have been done this way from the start.
2549 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2550 for method name change in TableSelectionView.
2551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2552 Create TableChangeEvent and set the browser title using the
2553 TableSelectionView API.
2554 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2555 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2556 Change getSelectedTable() to getSelectedTableName(). Add
2557 getSelectedTableTitle().
2559 2011-10-07 Ben Konrath <ben@bagu.org>
2561 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2563 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2565 2011-10-07 Ben Konrath <ben@bagu.org>
2567 Update TableChangeEvent to use newTableName naming convention.
2569 This makes the class more consistent with GWT naming conventions.
2571 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2572 Update for method name change in TableChangeEvent.
2573 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2574 for method name change in TableChangeEvent.
2575 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2576 newTableName variable and getter method. Make toDebugString()
2579 2011-09-30 Ben Konrath <ben@bagu.org>
2581 Disable the pager in the list tables when the data row count is less than the minimum.
2583 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2584 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2586 2011-09-30 Ben Konrath <ben@bagu.org>
2588 Add empty rows to the end of related list and list view tables.
2590 I also extracted the cell rendering classes from the ListTable because
2591 the code was becoming a little crazy with all the anonymous inner
2592 classes. My plan is to use these cell rendering classes in the details
2593 view as well so this refactor will be needed for that change.
2595 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2596 set the row count in related list tables if the data has more rows
2597 than the minimum number of rows visible.
2598 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2599 row count in list view tables if the data has more rows than the
2600 minimum number of rows visible.
2601 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2602 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2604 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2605 for rendering TYPE_NUMERIC cells. The code was extracted from the
2607 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2608 class for rendering cells with buttons in list views. The code was
2609 extracted from the ListTable class.
2610 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2611 for rendering TYPE_TEXT cells. The code was extracted from the
2613 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2614 Add empty rows to the end of the data if required. Implement
2615 ListTable.getMinNumVisibleRows().
2616 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2617 cell renderer code to public classes. Return null in
2618 Column.getValue() for empty rows. Add new abstract method:
2619 getMinNumVisibleRows(). Move code to set the row count of the list view
2620 table to ListViewImpl.
2621 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2622 empty rows to the end of the data if required. Implement
2623 ListTable.getMinNumVisibleRows().
2626 2011-09-27 Ben Konrath <ben@bagu.org>
2628 Use GWT.log for client-side debugging statements.
2630 These are optimized out when deployed so I should have used this method
2631 in the first place. These statements will eventually be replaced with some sort
2632 of notification in the browser.
2634 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2635 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2636 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2637 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2638 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2640 2011-09-27 Ben Konrath <ben@bagu.org>
2642 Put tableselector on the right, back to list link on right.
2644 The idea is that the table selector is acting like a label for the
2645 currently displayed table so it should be placed below the document title. This
2646 puts the table title in a similar position to where it is in Glom.
2648 * mockups/details-contacts.html:
2649 * mockups/details-projects.html:
2650 * mockups/listview-contacts.html:
2651 * mockups/listview-projects.html:
2652 * mockups/style.css:
2653 Update mockups to match how the interfaces currently look.
2654 * src/main/webapp/style.css: Swap positions of backlink with the table
2655 selector. Add some space on the left side of the table selector to
2656 line things up with the document title.
2658 2011-09-27 Ben Konrath <ben@bagu.org>
2660 Add field colouring to details view.
2662 This change re-works how field colouring works. The colour formatting
2663 information is now set to the client with the layout information instead of
2664 with the data. This eliminates the need to send the same colour strings for
2665 data in list view column when colour information is set.
2667 In order to set an alternate colour for negative numeric values, the
2668 number is now sent to client and formatted with the GWT NumberFormat class.
2670 This change also fixes:
2672 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2674 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2675 internationalization framework which is needed for client side numeric
2677 * src/main/java/org/glom/web/client/Utils.java: New file for some
2678 client static utility methods.
2679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2680 the DataItem object to the Field class. Use a utility method to
2681 create the foreignKeyValue string.
2682 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2683 alignment and text colours in the constructor. Add setData(DataItem)
2684 method. Remove setText(String) method.
2685 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2686 colour information to GlomTextCell. Create and use GlomNumberCell for
2687 rendering numbers. Use utility method to get the string for the
2688 primary key of the key provider. Re-work how the horizontal alignment
2690 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2691 formatting to layout information. Methods for converting the libglom
2692 formatting information were moved from DBAccess.
2693 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2694 numeric formatting (it's now done on the client side). Don't set text
2695 colours in DataItem. Move libglom formatting conversion methods to
2697 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2698 getters/setters for text colour information.
2699 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2700 for transferring the libglom NumericFormat information to the client.
2701 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2702 and getters/setters for: GlomNumericFormat, background colour and
2703 foreground colour strings.
2705 2011-09-26 Ben Konrath <ben@bagu.org>
2707 Simplify code that iterates through the LayoutGroup.
2709 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2711 2011-09-26 Ben Konrath <ben@bagu.org>
2713 Accept Eclipse formatting for OnlineGlomServiceAsync.
2715 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2717 2011-09-26 Ben Konrath <ben@bagu.org>
2719 Don't use the ListDBAccess classes to get the primary key layout information.
2721 This was causing a bug where the wrong index for the hidden primary key
2722 was being sent to the client.
2724 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2725 primary key while creating the LayoutGroup DTO. Create a
2726 LayoutItemField DTO for hidden primary keys. Don't use the
2727 RelatedListDBAccess because it was only used for getting the primary
2729 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2730 access modifier from public to protected for getPrimaryKeyField() and
2731 getPrimaryKeyLayoutItemField().
2732 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2733 abstract method getExpectedResultSize() because RelatedListDBAccess
2734 doesn't have enough info to implement it.
2735 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2736 Remove @Override for getExpectedResultSize().
2737 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2738 Remove method getExpectedResultSize().
2740 2011-09-23 Ben Konrath <ben@bagu.org>
2742 Log which layout (list or details) the ignored item is from.
2744 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2746 2011-09-23 Ben Konrath <ben@bagu.org>
2748 Remove annotations that turn off code formatting in DataItem.
2750 * src/main/java/org/glom/web/shared/DataItem.java:
2752 2011-09-23 Ben Konrath <ben@bagu.org>
2754 Rename GlomField to DataItem and update associated methods.
2756 This is a rename-only refactor. No functionality has been added or
2759 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2760 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2761 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2762 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2763 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2764 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2765 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2766 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2768 * src/main/java/org/glom/web/server/database/DBAccess.java:
2769 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2770 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2771 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2772 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2773 * src/main/java/org/glom/web/shared/DataItem.java:
2774 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2775 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2777 2011-09-23 Ben Konrath <ben@bagu.org>
2779 Rename GlomDocument to DocumentInfo and update associated methods.
2781 This is a rename-only refactor. No functionality has been added or
2784 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2785 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2786 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2787 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2788 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2789 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2790 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2792 2011-09-20 Ben Konrath <ben@bagu.org>
2794 Require java-libglom 1.17.3.
2796 This picks up the fix for the seg fault problem with the Scenes table
2797 in the Openismus Film Manager example.
2801 2011-09-20 Ben Konrath <ben@bagu.org>
2803 Change the way sort clause is added for primary key when no sort clause is requested.
2805 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2806 before the sort clause is created. When a sort clause is not requested, the
2807 sort clause is created by finding the primary key in the LayoutFieldVector
2810 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2812 2011-09-20 Ben Konrath <ben@bagu.org>
2814 Log error message if no documents are found in the configured directory.
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2817 Extract the glom file extension string to a private static final class
2818 variable (mostly as syntactic sugar). Accept a minor formatting change.
2819 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2820 the example glom.document.directory configuration property to make it
2821 more clear that it can any directory, not just the home directory.
2823 2011-09-18 Ben Konrath <ben@bagu.org>
2825 Add related lists to details view.
2827 The related list table has support for paging and sorting just like the
2828 table in the list view.
2830 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2831 SQL queries for the related list tables.
2832 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2833 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2835 Rename getList methods to getListView and add comments. Remove
2836 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2837 it being unused. Add methods: getDetailsLayoutAndData(),
2838 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2839 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2840 Create the layout and set the data for the fields in one async call
2841 instead of two. Create related lists where appropriate.
2842 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2843 for method name changes in OnlineGlomService.
2844 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2845 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2846 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2848 * src/main/java/org/glom/web/client/ui/ListView.java:
2849 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2850 tableName from setCellTable(). Create a ListViewTable instead of
2852 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2853 represent a data field in the details view.
2854 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2855 from addDetailsCell() to Field class. Keep track of the Fields and
2856 Portals in the details view.
2857 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2858 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2859 and add a method to get it. Add method to set the contents of the
2861 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2862 New class for related list tables. This class has the data provider
2863 for the related list table.
2864 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2865 abstract class which is the base class for the ListViewTable and the
2867 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2868 New class for list view tables. This class has the data provider for
2869 the list view table.
2870 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2871 methods for related list tables. Add more information to the
2872 LayoutItemField and LayoutItemPortal DTOs.
2873 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2874 Remove debugging print statement.
2875 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2876 Remove debugging print statements. Add primary key field to SQL count
2878 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2879 Remove unnecessary LayoutFieldVector parameter from
2880 getResultSizeOfSQLQuery() method.
2881 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2882 New class for related list table database access.
2883 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2884 class that is a wrapper DTO for details view layout and data.
2885 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2886 new 'fromField' string to this DTO.
2887 * src/main/webapp/style.css: Remove bottom margin and override top
2890 2011-09-15 Ben Konrath <ben@bagu.org>
2892 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2894 This sets things up to make it easier to add the data retrieval for
2895 related lists (portals). No user noticeable changes were made with
2898 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2899 class has the code to retrieve the layouts and access the
2900 database using the new database helper classes.
2901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2902 Most of the functionality has been removed from this class. This
2903 class now represents the public interface for the client side
2904 code. It also deals with configuring the servlet and cleaning
2905 things up when the servlet is stopped.
2906 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2907 of static methods into this utility class.
2908 * src/main/java/org/glom/web/server/database/DBAccess.java:
2909 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2910 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2911 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2912 These classes have the database retrieval code. The class hierarchy
2913 has been setup to make it easy to reuse code for similar
2916 2011-09-06 Ben Konrath <ben@bagu.org>
2918 Create separate classes for list table code and the data provider.
2920 As part of this refactor, I also split up the code a bit to make it
2923 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2924 table code to two new classes (below).
2925 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2926 with code from ListViewImpl.
2927 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2928 New file with code from ListViewImpl.
2930 2011-09-06 Ben Konrath <ben@bagu.org>
2932 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2934 This fixes the LayoutItemPortal DTO to match the libglom layout object
2937 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2939 2011-09-01 Ben Konrath <ben@bagu.org>
2941 Set title of Portals in the Details View.
2943 * pom.xml: Bump required version of java-libglom to 1.17.1.
2944 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2945 widget creation to its own class. Add comments to constructor.
2946 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2947 The code is mostly from the Group class with the title now set.
2948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2949 title of Portal. Update some comments. Fix some code formatting.
2951 2011-09-01 Ben Konrath <ben@bagu.org>
2953 Remove TODO comment for the flow table column width.
2955 The flow table column width is working correctly and doesn't need to be
2956 changed. See this mailing list post for more info:
2958 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2960 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2962 2011-08-27 Ben Konrath <ben@bagu.org>
2964 Add document title (database name) to top of the browser page.
2966 I added the document title to the TableSelecitonView but that will
2967 change if / when we add a view that doesn't require table selection.
2969 * mockups/details-contacts.html:
2970 * mockups/details-projects.html:
2971 * mockups/listview-contacts.html:
2972 * mockups/listview-projects.html:
2973 * mockups/style.css: Add document title to mockups to keep things
2975 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2976 sizes to account for the document title.
2977 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2978 Set the document title when it has been retrieved from the server.
2979 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2980 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2981 and implement setDocumentTitle(String) method.
2982 * src/main/webapp/style.css: Add ID for document title style.
2984 2011-08-25 Ben Konrath <ben@bagu.org>
2986 Add NavigationType enum to LayoutItemPortal DTO.
2988 This is the start of adding support for Portals to the Details View.
2990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2991 LayoutItem_Portal.navigation_type enum from libglom to
2992 LayoutItemPortal.NavigationType enum.
2993 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2994 NavigationType enum, field for storing the NavigationType and getter
2997 2011-08-25 Ben Konrath <ben@bagu.org>
2999 Implement the flow table layout in the Details View.
3001 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3002 FlowTable to Group to account for the renamed class.
3003 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3004 File. This is a container widget that implements the Glom details view
3005 flow table behaviour.
3006 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3007 org/glom/web/client/ui/FlowTable.java.
3008 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3009 so that the size of the subgroups are a closer match to the size of
3010 the Glom subgroups. This makes the flowtable layout match the layout
3011 in Glom for the Music Collection example file.
3013 2011-08-16 Ben Konrath <ben@bagu.org>
3015 Create container element for LayoutItemPortal in Details View.
3017 This will help me develop the layout for the FlowTable.
3019 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3020 fieldPanel variable to detailsCell.
3022 2011-08-15 Ben Konrath <ben@bagu.org>
3024 Set the height of the data element in the Details View.
3026 I changed the InlineLabels (text in a span element) to Labels (text in
3027 a div element) so that I could set the height of the details-data
3028 elements instead of the details-cell parent elements. This allows the
3029 the details-data element to display the correct height if style is
3030 applied that shows the height.
3032 This change has the added benefit of allowing the order of the labels
3033 and data elements to be changed for right-to-left languages.
3035 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3036 InlineLabels to Labels.
3037 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3038 InlineLabels to Labels. Set the height of the data element.
3039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3040 multiline text height in the Formatting DTO.
3041 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3042 for multiline height along with getter and setter methods.
3043 * src/main/webapp/style.css: Adjust style to account for the change
3044 from span elements to div elements in the details cell.
3046 2011-08-15 Ben Konrath <ben@bagu.org>
3048 Make the List View appearance match the mockups.
3050 It doesn't match exactly but it's much better than it was.
3052 * mockups/listview-contacts.html: Remove unused css classes.
3053 * mockups/listview-projects.html: Remove unused css classes.
3054 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3055 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3056 for mainPanel instead of VerticalPanel (table). Set style name on
3057 CellTable. Set style name on Details column. Right-align Details
3059 * src/main/webapp/style.css: Adjust properties to match the mockups.
3061 2011-08-12 Ben Konrath <ben@bagu.org>
3063 Add better support for subgroups in the details view.
3065 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3066 changed FlowTable constructor.
3067 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3068 support for subgroups and subgroup-titles.
3069 * src/main/webapp/style.css: Add CSS class for subgroups and
3072 2011-08-12 Ben Konrath <ben@bagu.org>
3074 Return the top level LayoutGroup title.
3076 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3078 2011-08-11 Ben Konrath <ben@bagu.org>
3080 Make the TableSelector header match the mockup.
3082 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3083 the layout panel. Properly lineup the table selection header with
3084 the list and details view.
3085 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3086 margin around the details view.
3087 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3088 Rename listBox variable to tableSelector. Set id for the style sheet.
3089 Use a FlowPanel instead of a HorizontalPanel.
3090 * src/main/webapp/style.css: Add properties to make the TableSelector
3091 box match the mockups.
3093 2011-07-13 Ben Konrath <ben@bagu.org>
3095 Update install script for java-libglom version change.
3097 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3100 2011-07-13 Ben Konrath <ben@bagu.org>
3102 Add support sub-group in the details view.
3104 I also removed the code that special-cased the default details view
3107 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3109 I still have to make a proper flowtable.
3111 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3112 Don't special-case default details view layout.
3113 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3114 addLayoutField() as I'm going to use it.
3115 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3116 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3118 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3119 extracted from DetailsViewImpl.GroupPanel. Add support for
3121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3122 column count when getting the details layout.
3124 2011-07-12 Ben Konrath <ben@bagu.org>
3126 Set browser title with database and table titles.
3128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3129 Set the browser title when the table changes and when the activity
3131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3132 title when retrieving document info (the GlomDocument object).
3133 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3134 with getter and setter methods. Remove unused convenience constructor.
3135 Use default code formatting.
3137 2011-07-12 Ben Konrath <ben@bagu.org>
3139 Ignore LayoutItemPortals in the details view.
3141 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3144 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3145 LayoutItemPortal layout objects.
3146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3147 LayoutItemPortal objects when retrieving the details layout.
3148 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3149 file. This is an empty class and just used to get type information for
3152 2011-07-12 Ben Konrath <ben@bagu.org>
3154 Use java-libglom 1.17.0.
3158 2011-07-11 Ben Konrath <ben@bagu.org>
3160 Remove "Table:" label from table selector.
3162 This matches a recent change in the Glom UI.
3164 * mockups/details-contacts.html:
3165 * mockups/details-projects.html:
3166 * mockups/listview-contacts.html:
3167 * mockups/listview-projects.html: Remove the "Table:" label from the
3169 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3171 2011-07-11 Ben Konrath <ben@bagu.org>
3173 Add main groups to the details view.
3175 This makes things look a little nicer in the details view. The next step
3176 is to implement the flowtable.
3178 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3179 resources from the standard gwt css theme. Standard.css is now
3180 included in OnlineGlom.html so that the online glom css rules have
3181 precedence over the gwt theme.
3182 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3183 the whole LayoutGroup to the DetailsView instead of just the titles.
3184 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3185 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3186 details layout with a helper class (GroupPanel). I might extract this
3187 class when I make the full flowtable.
3188 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3189 string as default so I don't have to worry about NPEs when processing
3191 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3192 note beside OnlineGlom.gwt.xml above).
3193 * src/main/webapp/style.css: Add default font-size to body to override
3194 the font-size set by the standard theme. Don't use h2 tags for
3195 group-title. Create new details-cell class.
3197 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3199 ConfiguredDocument: Set the port number too.
3201 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3202 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3203 Glom document. Presumably this worked sometimes so far because there is a
3204 default port number.
3206 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3208 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3210 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3211 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3212 correct, though we should throw an exception too.
3214 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3216 Fix a addDocuemnt typo.
3218 * src/main/java/org/glom/web/shared/Documents.java
3219 (Documents.addDocuemnt): Rename to addDocument().
3220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3221 (OnlineGlomServiceImpl.getDocuments): Adapt.
3223 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3225 Slightly improved log output when connection fails.
3227 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3228 (ConfiguredDocument.setUsernameAndPassword):
3229 We don't know for sure if it' the username/password that's wrong, so
3230 rephrase the message.
3231 Also ouput the exception message, though it's generic in this case.
3233 2011-07-08 Ben Konrath <ben@bagu.org>
3237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3238 added braces to a one line if statement because the Eclipse formatter
3239 was getting confused.
3241 2011-07-07 Ben Konrath <ben@bagu.org>
3243 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3245 These should really be two separate tasks but I counldn't get things to
3246 work with GWT 2.2.0 and Eclipse 3.7.
3250 * .settings/org.eclipse.jdt.core.prefs:
3251 * .settings/org.eclipse.jdt.ui.prefs:
3252 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3253 * .settings/org.eclipse.m2e.core.prefs:
3254 Add new config files. Update current files. Remove references to the
3255 webtools plugins as we're not using any of the webtools features.