3 2012-04-12 Murray Cumming <murrayc@murrayc.com>
5 Adapt to the java-libglom 1.21.8 API.
7 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
8 java-libglom's FieldFormatting is now Formatting.
10 2012-04-12 Murray Cumming <murrayc@murrayc.com>
12 Use the latest java-libglom version.
14 * pom.xml: Use java-libglom 1.21.8.
16 2012-04-12 Murray Cumming <murrayc@murrayc.com>
18 Translations: Add Esperanto.
20 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
21 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
22 properties: Add this translation because someone took the time to make it.
24 2012-03-15 Murray Cumming <murrayc@murrayc.com>
26 Use the latest java-libglom version.
28 * pom.xml: Use java-libglom 1.21.7.
30 2012-03-03 Ben Konrath <ben@bagu.org>
32 Display date and time in details view.
34 https://bugzilla.gnome.org/show_bug.cgi?id=671257
36 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
38 2012-02-24 Ben Konrath <ben@bagu.org>
40 Improve the tabs in the Notebook widget.
44 2012-01-30 Murray Cumming <murrayc@murrayc.com>
46 Translations: Try to translate the strings.
48 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
49 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
50 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
51 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
52 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
53 Take the Open translation from GTK+'s .po files.
54 Take the Details translation from Glom's po files.
55 I have added the other strings to Glom so we can get translations that way:
56 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
58 2012-01-27 Murray Cumming <murrayc@murrayc.com>
60 TableSelectionViewImpl: Put the search label and entry in a div.
62 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
63 Put the search widgets in a FlowTable so that the CSS can be used to
64 style them while keeping them together.
65 * src/main/webapp/style.css: Mention the new div.
67 2012-01-27 Murray Cumming <murrayc@murrayc.com>
69 Translate more strings in more locales.
71 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
72 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
73 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
74 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
75 Translate the "Details" and "Open" string too.
77 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
78 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
79 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
80 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
81 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
82 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
83 Add these new locales as placeholders though they currently contain English.
85 2012-01-27 Murray Cumming <murrayc@murrayc.com>
87 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
89 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
90 Check the ConfiguredDocument* for null before using it.
92 2012-01-26 Murray Cumming <murrayc@murrayc.com>
94 Tell Eclipse about the generated java files.
96 * .classpath: This lets it find OnlineGlomConstants.java.
97 It would be nice if Eclipse just used the maven build files.
99 2012-01-26 Murray Cumming <murrayc@murrayc.com>
101 Prevent a crash when no locale is specified in the URL.
103 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
104 Avoid returning a null string, obtained from
105 Window.Location.getParameter(). This caused a crash when it was
106 later passed to libglom's API.
107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
108 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
109 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
110 guard against future null strings.
112 2012-01-26 Murray Cumming <murrayc@murrayc.com>
114 Use the ?locale= query param instead of the &lang= token param.
116 * src/main/java/org/glom/web/client/place/ListPlace.java
117 * src/main/java/org/glom/web/client/place/DetailsPlace.java
118 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
119 Remove the lang token key and value.
121 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
122 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
123 When the user selects a different locale from the chooser, use
124 Window.Location.assign() to change the URL, which then causes a reload.
126 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
127 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
128 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
129 * src/main/java/org/glom/web/client/activity/ListActivity.java
130 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
131 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
132 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
133 * src/main/java/org/glom/web/client/ui/ListView.java:
134 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
136 Remove localeID member variables and method/constructor parameters, instead
137 using Utils.getCurrentLocaleID() when we need a localID to pass to
140 2012-01-26 Murray Cumming <murrayc@murrayc.com>
142 Internationalize the UI strings.
144 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
145 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
146 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
147 because it is unused. Messages are apparently strings that can have
148 parameters, but we do not need that yet, so Contants will be enough for now.
149 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
150 to say that we support the en and de locales.
151 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
152 The original English strings.
153 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
154 Some German translations of the English strings.
155 The i18n goal then uses the .properties file to generate an
156 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
157 returns an implementation that returns the translated strings.
158 The documentation suggests putting these in src/java/*/client/, but it seems
159 best to put it in src/resources/*/client/.
160 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
161 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
162 instead of hard-coding them.
163 Note that we cannot import OnlineGlomConstants because it does not exist yet,
164 but that does not seem to stop the build, though it confuses Eclipse.
166 You can see the translated string by adding ?locale=de to the URL, like so:
167 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
169 2012-01-24 Murray Cumming <murrayc@murrayc.com>
171 Improve null/empty String checks.
173 * pom.xml: Add a dependency on commons-lang, to use
174 org.apache.commons.lang.StringUtils.
175 * src/main/java/org/glom/web/server/ConfiguredDocument.java
176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
177 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
178 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
179 Use StringUtils.isEmpty().
181 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
182 StringUtils class with a static isEmpty() function because we
183 cannot use org.apache.commons.lang.StringUtils in client-side
184 GWT code because it (apparently) cannot be compiled to javascript.
185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
186 * src/main/java/org/glom/web/client/activity/ListActivity.java
187 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
188 * src/main/java/org/glom/web/client/place/DetailsPlace.java
189 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
190 * src/main/java/org/glom/web/client/place/ListPlace.java
191 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
192 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
193 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
194 * src/main/java/org/glom/web/client/ui/details/Group.java
195 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
196 our StringUtils.isEmpty() function.
198 2012-01-24 Murray Cumming <murrayc@murrayc.com>
200 Update to the latest java-libglom API.
202 * pom.xml: Require java-libglom 1.21.4.
203 * src/main/java/org/glom/web/server/ConfiguredDocument.java
204 getDocumentInfo(), getListViewLayoutGroup():
205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
207 * src/main/java/org/glom/web/server/database/DBAccess.java
208 getFieldsToShowForSQLQueryAddGroup(),
209 getPrimaryKeyLayoutItemField(): Replace get_database_title()
210 with either get_database_title_original() or
211 get_database_title(localeID).
213 2012-01-24 Murray Cumming <murrayc@murrayc.com>
215 ConfiguredDocument: Avoid a null pointer exception.
217 * src/main/java/org/glom/web/server/ConfiguredDocument.java
218 Initialize localeID to "" to avoid returning a null String which
219 causes a crash in java-libglom's swing-generated code.
221 2012-01-23 Murray Cumming <murrayc@murrayc.com>
223 Some simple renaming.
225 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
226 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
227 for localeChooser. This seems more appropriate and is less ambiguous
228 particularly in the .css file.
230 2012-01-23 Murray Cumming <murrayc@murrayc.com>
232 ConfiguredDocument: Rename the localedID private member variable.
234 2012-01-23 Murray Cumming <murrayc@murrayc.com>
236 Adapt to the latest java-libglom API from git master.
238 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
239 libglom now uses only Vector instead of List, which uses add() instead of
242 2012-01-20 Murray Cumming <murrayc@murrayc.com>
244 Build a source tarball with mvn assembly:single
246 * assembly.xml: Add this file.
247 * pom.xml: Use the maven-assembly-plugin and tell it to use
248 our assembly.xml file.
250 2012-01-19 Murray Cumming <murrayc@murrayc.com>
252 OnlineGlomServiceImpl: Get .glom files recursively.
254 * pom.xml: Depend on commons-io from org.apache.commons.
255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
256 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
257 files recursively, and with the easier filter for the extension.
258 Use org.apache.commons.io.FilenameUtils.removeExtension() to
259 simplify that code too.
261 2012-01-19 Murray Cumming <murrayc@murrayc.com>
263 README: Mention that you must install java-libglom packages separately.
265 But then it works, because java-libglom is now in the central maven
268 2012-01-18 Murray Cumming <murrayc@murrayc.com>
270 locales drop-down: Show the correct selected locale when the URL changes.
272 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
273 .java: setPlace(): Move some code into fillView().
275 2012-01-18 Murray Cumming <murrayc@murrayc.com>
277 locales drop-down: Do not lose the primary key.
279 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
280 start(): onLocaleChange(): Pass the current primary key value,
281 instead of an empty value.
283 2012-01-18 Murray Cumming <murrayc@murrayc.com>
285 locales drop-down: Do not lose the drop-down selection.
287 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
288 .java (TableSelectionActivity.fillView): Set the selected locale
289 after changing the drop-down items (though we do not really need
290 to change them just because the locale changes.)
292 2012-01-18 Murray Cumming <murrayc@murrayc.com>
294 locales drop-down: Change the tables list when this changes.
296 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
297 .java: TableSelectionActivity.start(): Move the async table titles
298 retrieval into a private fillView() method and also call this when
299 the chosen locale changes.
300 Note that the document title is not actually translatable yet, but
301 that is a problem that I should fix soon in libglom.
303 2012-01-18 Murray Cumming <murrayc@murrayc.com>
305 Improve the placement of the locales drop-down.
307 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
308 Put the title and locales drop-down in a div (gwt.FlowTable).
309 * src/main/webapp/style.css: Add magic css properties to make this work.
310 Also remove the left margin from the title so that it lines up with the
313 2012-01-18 Murray Cumming <murrayc@murrayc.com>
315 locales selector: Show human-readable locale titles.
317 * src/main/java/org/glom/web/server/ConfiguredDocument.java
318 getDocumentInfo(): Use java.util.Locale to show a real title of
319 each locale, in the locale's own language.
321 2012-01-17 Murray Cumming <murrayc@murrayc.com>
323 Add a language/locale selector drop-down.
325 * src/main/java/org/glom/web/shared/DocumentInfo.java:
326 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
327 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
328 getDocumentInfo(): Store the available Locales in the DocumentInfo.
329 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
330 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
331 Add a ListBox to show the available locales. Add getLocaleSelector(),
332 setLocaleList(), getSelectedLocale(), setSelectedLocale().
333 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
334 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
335 java: Add these classes.
336 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
337 start(): Fill the locales ListBox. Handle its change event, firing a
339 setPlace(): Show the selected locale as specified by the URL token.
340 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
341 * src/main/java/org/glom/web/client/activity/ListActivity.java:
342 Handle LocaleChangeEvent, going to a new *Place with that locale.
344 The placement of the ListBox is not pretty, and it currently uses the ID
345 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
349 2012-01-17 Murray Cumming <murrayc@murrayc.com>
351 Search box: Show the search text from the URL token.
353 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
354 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
355 Add setQuickFindText().
356 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
357 .java: setPlace(): Store the queryText if the place is a ListPlace,
358 and call TableSelectionView.setQuickFindText().
360 2012-01-17 Murray Cumming <murrayc@murrayc.com>
362 Allow use of translations via, for instance, &lang=de in the URL.
364 * pom.xml: Use the unstable java-libglom 1.21 version.
366 * src/main/java/org/glom/web/client/OnlineGlomService.java:
367 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
369 init(): Instead of calling TranslatableItem.set_current_locale()
370 (now removed), call ConfiguredDocument.setDefaultLocaleID().
371 However, this is only for default locales, which are not needed to
372 change the locale in the URL.
373 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
374 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
375 getSortedRelatedListData(): Add a localeID parameter, so we can get the
376 layout for a particular locale.
377 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
378 Add get/setDefaultLocaleID().
379 getDocumentInfo(), getListViewData(), getRelatedListData(),
380 getDetailsLayoutGroup(), getListViewLayoutGroup(),
381 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
382 localeID parameter, so we can get the layout for a particular locale.
384 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
385 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
386 * src/main/java/org/glom/web/client/place/ListPlace.java:
387 Parse and construct a lang parameter too.
389 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
390 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
391 passed to subsequent methods and constructors.
392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
393 * src/main/java/org/glom/web/client/activity/ListActivity.java:
394 Store the localeID from the *Place and pass it to other constructors
395 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
397 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
398 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
399 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
400 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
401 * src/main/java/org/glom/web/client/ui/ListView.java:
402 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
403 Take localeID parameters and pass them to subsequent constructors and
404 methods, so that the layout is always retrieved for that locale.
406 This is rather repetitive.
408 Note that "" means the original (default) locale of the Glom document,
409 which is usually English.
411 2012-01-17 Murray Cumming <murrayc@murrayc.com>
413 Documents: Remove final keyword to fix startup configuration.
415 * src/main/java/org/glom/web/shared/Documents.java: Remove the
416 final keywords on the private member variables because that breaks
417 the startup, apparently (there are warnings) because it stops them
418 from being serialized. I added these in the previous commit.
420 2012-01-13 Murray Cumming <murrayc@murrayc.com>
422 Documents: Add some final keywords.
424 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
427 2012-01-13 Murray Cumming <murrayc@murrayc.com>
429 OnlineGlomServiceImpl: Add to overview comments.
431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
432 Note that this is where all the document are loaded. They are not
433 loaded freshly for each page.
435 2012-01-12 Murray Cumming <murrayc@murrayc.com>
439 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
440 Add a TextBox for the text of a quick find.
441 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
443 setBackLink(): Add a String quickFind parameter.
444 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
445 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
446 to the base interface, because that is how TableSelectionViewImpl is used.
447 * src/main/webapp/style.css: Add style for the search box and its label.
449 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
450 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
451 Add these files, based on the existing TableChangeEvent and
452 TableChangeEventHandlers.
453 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
454 start(): Handle QuickFindChangeEvent, passing its quickFind text to
455 a ListPlace() that the user should be taken to.
456 * src/main/java/org/glom/web/client/activity/ListActivity.java
457 start(): Handle it here too and adapt the TableChangeEvent handler to
458 pass the extra "" quickFind parameter to ListPlace.
459 * src/main/java/org/glom/web/client/place/ListPlace.java:
460 Constructor: Take an extra String quickFind parameter and store it,
461 returning it from a new getQuickFind() method.
462 getToken(): Put the quickFind text in the URL token.
463 getPlace(): Parse the quickFind text from the URL token.
464 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
465 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
466 ListPlace constructor.
467 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
468 .java: start(): Add a Change handler for the TableSelectionView's
469 TextBox (via its base HasChangeHandlers interface), firing the new
470 QuickFindChangeEvent.
471 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
472 pass the extra "" quickFind parameter.
474 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
475 setCellTable(): Add a String quickFind parameter and pass it to
476 the ListViewTable() constructor.
477 * src/main/java/org/glom/web/client/ui/ListView.java: Change
478 setCellTable() in the base interface, because that is how ListViewImpl
481 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
482 Add a String quickFind member variable.
483 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
484 Constructor: Add a String quickFind parameter, storing it in the
485 base ListTable's member variable.
486 onRangeChanged(): Pass quickFind to the
487 OnlineGlomServiceAsync.getSortedListViewData() and
488 OnlineGlomServiceAsync.getListViewData() methods.
490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
491 getListViewData(), getSortedListViewData(): Add a String quickFind
492 parameter, passing it to ConfiguredDocument.getListViewData().
493 * src/main/java/org/glom/web/client/OnlineGlomService.java:
494 Change getListViewData(), getSortedListViewData() in the base interface,
495 because that is how OnlineGlomServiceImpl is used, via this:
496 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
497 Change getListViewData(), getSortedListViewData() here too.
498 This class can apparently be used to asynchronously call methods on
499 OnlineGlomService, and GWT seems to implement that after recognizing
500 just the *Async name convention and the extra AsyncCallback parameters.
502 * src/main/java/org/glom/web/server/ConfiguredDocument.java
503 getListViewData(): Add a String quickFind parameter, and pass it to
504 ListViewDBAccess.getData().
505 * src/main/java/org/glom/web/server/database/ListDBAccess.java
506 getListData(): Add a String quickFind parameter and pass it to
508 getSelectQuery(): Add a String quickFind parameter.
509 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
510 getSelectQuery(): Add a String quickFind parameter and use it with
511 Glom.get_find_where_clause_quick() to pass a where_clause to
512 Glom.build_sql_select_with_where_clause(), to actually filter the
514 getData(): Add a String quickFind parameter, passing it to getListData().
515 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
516 va: getData(): Pass an empty string to getListData() for the
519 2012-01-12 Murray Cumming <murrayc@murrayc.com>
521 ListTable: Minor change.
523 * src/main/java/org/glom/web/client/ui/list/ListTable.java
524 createCellTable(): Make this protected instead of public.
526 2012-01-12 Murray Cumming <murrayc@murrayc.com>
528 Many files: Use final for the parameters and use the @override attribute.
530 2012-01-22 Ben Konrath <ben@bagu.org>
532 Add anchor links for single line text that starts with http, ftp and www.
536 2012-01-22 Ben Konrath <ben@bagu.org>
538 Add ellipsis to single line text in details view.
542 2012-01-04 Murray Cumming <murrayc@murrayc.com>
544 Remove all javadoc author tags.
546 Because they are awkward and meaningless when many people touch
548 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
550 2012-01-04 Murray Cumming <murrayc@murrayc.com>
552 Revert the COPYING.LESSER to COPYING rename.
554 Apparently both should be there if it is LGPL.
556 2012-01-03 Murray Cumming <murrayc@murrayc.com>
558 *View: Remove unused imports.
560 * src/main/java/org/glom/web/client/ui/DetailsView.java:
561 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
562 * src/main/java/org/glom/web/client/ui/ListView.java:
563 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
564 Remove unused imports, as suggested by Eclipse.
566 2012-01-02 Murray Cumming <murrayc@murrayc.com>
568 Move the *View::Presenter types, and some API into one base View.
570 * src/main/java/org/glom/web/client/ui/DetailsView.java:
571 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
572 * src/main/java/org/glom/web/client/ui/ListView.java:
573 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
574 Presenter, setPresenter() and clear() into a shared base interface,
575 to avoid the unnecessary duplicate Presenter types and to more clearly
576 show how the *Views share the same structure, even if they are not
577 used polymorphically.
579 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
580 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
582 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
583 * src/main/java/org/glom/web/client/activity/ListActivity.java:
584 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
586 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
589 Feel free to revert this if there is a good reason for the duplicate
592 2012-01-02 Murray Cumming <murrayc@murrayc.com>
594 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
596 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
597 a class member instead of a local variable in the method.
598 This lets us use it to get the view instances, for use in tests.
599 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
600 beforeOnlineGlom(): Test some more details of the initial view.
601 Again, this is not very useful.
603 To really test gwt-glom we will need to start a local postgresql
604 instance with local data, like the Glom tests in C++.
606 2012-01-02 Murray Cumming <murrayc@murrayc.com>
608 pom.xml: Mention the LGPL license.
610 * pom.xml: Add a licenses section.
611 * COPYING.LESSER: Move this to COPYING, which
612 previously contained the GPL. But gwt-glom is all LGPL.
614 2012-01-02 Murray Cumming <murrayc@murrayc.com>
616 Add project information to README and pom.xml.
618 * README: Add a brief description and mention some mvn
620 * pom.xml: This extra information shows up in mvn site
623 2011-01-02 Murray Cumming <murrayc@murrayc.com>
625 Use the latest java-libglom version.
627 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
629 2012-01-01 Murray Cumming <murrayc@murrayc.com>
631 GwtTestOnlineGlom: Test a little more.
633 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
634 protected rather than private, as suggested by the gwt-test-utils
636 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
637 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
638 Test the initial visibility of the panels.
640 However, this is not a very useful test.
641 And I wonder how we should generally test using this idea for an
642 activity/places app like ours where the real changes happen implicitly
643 based on the history token/URL.
645 2012-01-01 Murray Cumming <murrayc@murrayc.com>
647 Slight modification to *Mapper comments.
649 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
651 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
653 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
655 Remove comments mentioning GIN because they are just copied from
656 the example code and are apparently not helpful:
657 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
658 Also change the mention of a class that is only in the example code.
660 2012-01-01 Murray Cumming <murrayc@murrayc.com>
662 GwtTestOnlineGlom test: Minor changes.
664 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
665 Avoid the long qualified class name and modify the comment
666 because it is now obvious to me that the mocked class is the only
667 custom one created via GWT.create().
669 2012-01-01 Murray Cumming <murrayc@murrayc.com>
671 Tests: Added the beginnings of a test using gwt-test-utils.
673 * pom.xml: Add dependencies on gwt-test-utils and easymock.
674 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
675 which tells gwt-test-utils what class will be tested.
676 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
677 Add a simple (but empty) test case. One class, used by the OnlineGlom
678 class, is mocked so that it can be created. However, I am not sure
679 why only this class needs to be mocked.
681 Note that mockito seems more popular, and clearer, than easymock,
682 but I have not got that working yet. It might be a matter of the
685 This test is run during mvn integration-test.
687 2011-12-31 Murray Cumming <murrayc@murrayc.com>
689 Tests: Use junit4-style syntax instead of junit3-style.
691 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
692 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
693 * src/test/java/org/glom/web/shared/DataItemTest.java:
694 Use the @Test annotation rather than relying on the test*() prefix.
695 Also no longer implement TestCase, to avoid triggering support for
696 the junit3-way, which stops the annotations from working.
697 Change the imports from import junit.framework.* to
698 import org.junit.*, which is apparently the new way.
700 2011-12-31 Murray Cumming <murrayc@murrayc.com>
702 Added a test for ListPlace token parsing and creation.
704 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
705 This is much the same as DetailsPlaceTest.
707 I wonder how we could test the other parts of the *Place API.
709 2011-12-30 Murray Cumming <murrayc@murrayc.com>
711 DetailsPlace test: Also test getToken() and recreation via getPlace().
713 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
714 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
715 recreate it, testing the recreated DetailsPlace for the same parameter
718 2011-12-30 Murray Cumming <murrayc@murrayc.com>
720 Use the surefire-report plugin.
722 * pom.xml: This generates a HTML report about the tests in
723 target/site/surefire-report.html
724 when you do mvn surefire-report:report. It seems to be popular/normal.
726 2011-12-30 Murray Cumming <murrayc@murrayc.com>
728 Added a test for DetailsPlace.
730 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
731 Test the getPlace() token parsing.
733 2011-12-30 Murray Cumming <murrayc@murrayc.com>
735 Added a first unit test.
737 * pom.xml: Add a test goal, and a dependency on junit in that scope.
738 * src/test/java/org/glom/web/shared/DataItemTest.java:
739 This is a silly test but it is just to get things started. Note that
740 maven/junit finds the test because it looks in src/test by default.
742 2011-12-22 Ben Konrath <ben@bagu.org>
744 Change charsetName to "UTF-8" when replacing line breaks.
746 JavaScript requires the charsetName to be "UTF-8". CharsetName values
747 that work in Java (such as "UTF8") will not work when compiled to
750 This fixes a problem with multi-line details view fields that have hard
751 line breaks. The "License Text" field on this page demonstrates the
754 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
756 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
758 2011-12-22 Ben Konrath <ben@bagu.org>
760 Fix another bug with related list navigation.
762 I've tested all the navigation buttons in all of the related lists
763 so things should be good now.
765 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
767 2011-12-22 Ben Konrath <ben@bagu.org>
769 Fix a crasher when refreshing the list view with the default table.
771 This crash will also happen when loading the list view with the default
772 table from a link or bookmark.
774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
775 to the main document selection page when the document id hasn't been
777 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
778 the main document selection page when the document id hasn't been
780 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
781 values for the details place when the document id hasn't been set.
782 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
783 values for the list place when the document id hasn't been set.
785 2011-12-21 Ben Konrath <ben@bagu.org>
787 Protect against NPE when glom.document.locale is not in config.
789 This patch protects against an NPE when glom.document.locale is not in
790 the config file. This NPE will also happen if glom.document.locale is
793 The patch also updates the error message to display the class name when
794 the getMessage() returns null. This was happening when the NPE was
795 thrown and I had "Configuration Error: null". If an NPE is encountered
796 with this patch, "Configuration Error: NullPointerException " will be
799 This commit closes this bug:
801 https://bugzilla.gnome.org/show_bug.cgi?id=666669
803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
805 2011-12-20 Murray Cumming <murrayc@murrayc.com>
807 Rename onlineglom.properties to onlineglom.properties.sample.
809 * src/main/resources/onlineglom.properties: Rename to:
810 * src/main/resources/onlineglom.properties.sample:
811 * src/main/resources/README: And add this file explaining that people
812 should rename it back when deploying.
814 2011-12-20 Murray Cumming <murrayc@murrayc.com>
816 Allow choosing the translation in the .properties file.
818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
819 init(): Read a glom.document.locale value from the configuration file
820 and call Glom's TransatableItem::set_current_locale() method.
821 * src/main/resources/onlineglom.properties: Add a commented-out
822 example of this new setting.
824 It would be better to add &lang=de_DE to the URL, but the current
825 libglom API does not allow us to do this easily. I am working on that.
827 2011-12-19 Murray Cumming <murrayc@murrayc.com>
829 Avoid a crash in parsing of token parameters.
831 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
832 ava: getTokenParams(): Do not crash if a parameter has a key but no
833 value, and ignore parameters with neither.
835 2011-12-17 Murray Cumming <murrayc@murayc.com>
837 History token building/handling: Improve use of token parameters.
839 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
840 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
841 and buildParamsToken(HashMap), for use by derived classes.
842 Make the separator private because it is no longer be needed.
843 * src/main/java/org/glom/web/client/place/DetailsPlace.java
844 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
845 instead of manual string concatenation.
846 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
847 of hardcoded indices and awkward splitting code.
848 * src/main/java/org/glom/web/client/place/ListPlace.java
849 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
850 instead of manual string concatenation.
851 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
852 of hardcoded indices and awkward splitting code.
853 This should fix bug #666420
855 2011-12-16 Murray Cumming <murrayc@murrayc.com>
857 Fix a Navgiation->Navigation typo in the code.
859 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
860 Rename processNavgiation() to processNavigation().
862 2011-12-16 Murray Cumming <murrayc@murrayc.com>
864 Fix a seperator->separator typo in the code.
866 * src/main/java/org/glom/web/client/place/DetailsPlace.java
867 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
868 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
871 2011-12-15 Ben Konrath <ben@bagu.org>
873 Cleanup some comments.
875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
877 2011-12-14 Ben Konrath <ben@bagu.org>
879 Replace \n with <br/> for multiline text in the details view.
881 Vertical scrollbars are added when needed as well.
883 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
885 2011-12-14 Ben Konrath <ben@bagu.org>
887 Specify the font for document selection links.
889 * src/main/webapp/style.css:
891 2011-12-14 Ben Konrath <ben@bagu.org>
893 Fix bouncy CellTable while paging.
895 This doesn't currently work with related list tables in unselected
898 * src/main/java/org/glom/web/client/ui/list/ListTable.java
900 2011-12-14 Ben Konrath <ben@bagu.org>
902 Revamp the appearance of the document selection page.
904 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
905 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
906 * src/main/webapp/style.css:
908 2011-12-13 Ben Konrath <ben@bagu.org>
910 Set navigation button column to the smallest size possible.
912 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
914 2011-12-13 Ben Konrath <ben@bagu.org>
916 Change OpenButton nomenclature to NavigationButton.
918 Using NavigtionButton makes things more generic. Classes, methods and
919 variables have been changed.
921 This is a rename-only refactor.
923 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
924 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
925 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
926 Renamed from OpenButtonCell.
927 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
928 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
929 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
931 2011-12-12 Ben Konrath <ben@bagu.org>
933 Remove unnecessary String argument in RelatedListTable and ListViewTable.
935 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
936 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
937 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
938 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
940 2011-12-12 Ben Konrath <ben@bagu.org>
942 Update variable names and comments.
944 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
945 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
947 2011-12-12 Ben Konrath <ben@bagu.org>
949 Properly initialize numNonEmptyRows variable to zero.
951 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
952 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
954 2011-12-05 Ben Konrath <ben@bagu.org>
956 Add latest mockup with HTML tables.
958 Features of this mockup:
960 -> HTML table for flowtable
961 -> HTML table for flowtable column
962 -> Example of how related lists would look
963 -> Not using text entries for data items
965 The current version of Online Glom doesn't use HTML tables for the
968 This mockup has been sent to the glom-devel mailing list but it's good
969 to have it here as well.
971 * mockups/details-view-html-tables.html:
973 2011-12-05 Ben Konrath <ben@bagu.org>
975 Remove unnecessary getPrimaryKeyField() method.
977 getPrimaryKeyFieldForTable(String) has been renamed to
978 getPrimaryKeyField(String).
980 * src/main/java/org/glom/web/server/database/DBAccess.java:
981 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
982 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
984 2011-12-05 Ben Konrath <ben@bagu.org>
986 Add string representation of TypedDataItem value to conversion error message.
988 * src/main/java/org/glom/web/server/Utils.java: Logging the error
989 message was extracted into its own method to avoid duplication.
991 2011-12-05 Ben Konrath <ben@bagu.org>
993 Add type checking to navigation primary key value creation.
995 Create navigation primary key only if the expected type from the Glom
996 document matches the type returned by the SQL query.
998 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1000 2011-12-05 Ben Konrath <ben@bagu.org>
1002 Rename a couple of variables in RelatedListNavigation.
1004 This is a rename-only refactor.
1006 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1008 2011-12-05 Ben Konrath <ben@bagu.org>
1010 Move getListLayoutGroup() into getListViewLayoutGroup().
1012 This removes getListLayoutGroup(). It was only being called by
1013 getListViewLayoutGroup().
1015 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1017 2011-12-05 Ben Konrath <ben@bagu.org>
1019 Remove check for LayoutItem_Portal in list table method.
1021 This check is no longer necessary because the method isn't being used
1022 to create the LayoutItemPortal DTO.
1024 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1026 2011-12-05 Ben Konrath <ben@bagu.org>
1028 Properly support related list navigation.
1030 Navigation from the "Repository Analyzer -> Package Scans ->
1031 Dependencies" related table wasn't working because the primary key for
1032 related tables wasn't being set properly. This commit fixes the
1035 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1036 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1037 doesn't set the primary key properly for related list tables.
1038 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1039 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1040 useful for getting the primary key for list view tables and for related
1042 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1043 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1044 Move code to set the primary key for the table from the abstract
1045 ListDBAccess class to ListViewDBAccess as it's only correct for list
1047 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1048 Properly add primary key to related list tables.
1050 2011-12-02 Ben Konrath <ben@bagu.org>
1052 Properly set the horizontal alignment of fields.
1054 This fix is for both the list tables and the details view.
1056 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1057 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1058 to set the horizontal alignment of fields.
1060 2011-12-02 Ben Konrath <ben@bagu.org>
1062 Display currency codes in the details view.
1064 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1066 2011-12-02 Ben Konrath <ben@bagu.org>
1068 Avoid duplicate JNI call.
1070 JNI is not as efficient as pure Java and this is an easy (and small)
1073 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1074 Use previously retrieved value for whereClauseToTableName instead of
1077 2011-12-02 Ben Konrath <ben@bagu.org>
1079 Rename a couple of variables in RelatedListNavigation.
1081 This is a rename-only refactor.
1083 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1085 2011-12-02 Ben Konrath <ben@bagu.org>
1087 Indicate clearly that a mismatched primary key type is a bug.
1089 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1090 warning to error. Add 'This is a bug.' to message.
1092 2011-12-02 Ben Konrath <ben@bagu.org>
1094 Update / fix some comments.
1096 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1098 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1100 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1101 Fix comments. Add some TODOs.
1103 2011-12-02 Ben Konrath <ben@bagu.org>
1105 Enable navigation to details view with string primary key from related list.
1107 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1108 Create a text primary key value when return type of result is
1109 java.sql.Types.VARCHAR.
1111 2011-12-02 Ben Konrath <ben@bagu.org>
1113 Use checkboxes for booleans in the details view.
1115 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1117 2011-12-01 Ben Konrath <ben@bagu.org>
1119 Improve performance of related list height calculation.
1121 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1122 Put code to calculate the expected height in a static initializer so
1123 that that it's only called once.
1125 2011-12-01 Ben Konrath <ben@bagu.org>
1127 Show related list tables in notebooks (again).
1129 Calculate the height of the related list tables so the Notebook can be
1130 set the correct height. The height of the related list table is also needed by
1131 FlowTable to be able decide how to create the layout.
1133 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1134 and set the Portal height based on the height of the related list
1135 table and the Portal container.
1136 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1137 Add method to calculate the height of the related list tables.
1138 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1139 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1140 calculate the height of the Pager widget.
1142 2011-12-01 Ben Konrath <ben@bagu.org>
1144 Use CellTable API for table property instead of setting style on Element.
1146 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1148 2011-12-01 Ben Konrath <ben@bagu.org>
1150 Make ListViewTable and RelatedListTable a consistent height.
1152 The tables are now a consistent height regardless of the contents of
1153 the table. A hidden button is added to empty rows to ensure that the
1154 height of these rows will match the height of rows with data.
1156 A navigation button column is now added to every table. The width of
1157 the navigation column is set to 0px when a RelatedListTable shouldn't
1158 have navigation buttons. This maintains the a consistent row height in
1159 tables that don't show the navigation buttons.
1161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1162 navigation column when not needed.
1163 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1164 arguments for navigation button to constructor of ListViewTable.
1165 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1166 hidden button for empty data rows.
1167 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1168 arguments for navigation button to constructor.
1169 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1170 create navigation buttons. Add hideNavigationButtons() method.
1171 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1172 arguments for navigation button to constructor.
1174 2011-12-01 Ben Konrath <ben@bagu.org>
1176 Use 'visibility: hidden' in Utils.getWidgetHeight().
1178 This is better choice because hidden elements are invisible, don't
1179 respond to events and are not part of the tab order. They will,
1180 however, take up space which is required to be able to calculate the
1181 height of the widget.
1183 * src/main/java/org/glom/web/client/Utils.java:
1185 2011-12-01 Ben Konrath <ben@bagu.org>
1187 Use Utils.getWidgetHeight() in FlowTable.
1189 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1191 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1193 2011-12-01 Ben Konrath <ben@bagu.org>
1195 Put the details css class name on the correct table column.
1197 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1199 2011-11-30 Ben Konrath <ben@bagu.org>
1201 Update for java-libglom API change.
1203 The getters and setters on FieldFormatting and NumericFormat were
1204 changed to remove the 'M'.
1206 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1208 2011-11-29 Ben Konrath <ben@bagu.org>
1210 Only allow RelatedListTables in Portals.
1212 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1214 2011-11-29 Ben Konrath <ben@bagu.org>
1216 Only create a contents panel for Portals when title is being set.
1218 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1220 2011-11-29 Ben Konrath <ben@bagu.org>
1222 Set TabLayoutPanel height based on calculated height its widgets.
1224 This is a potential fix for this bug:
1226 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1228 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1230 2011-11-29 Ben Konrath <ben@bagu.org>
1232 Align details field labels and data with the Open buttons.
1234 * src/main/webapp/style.css:
1236 2011-11-29 Ben Konrath <ben@bagu.org>
1238 Remove unnecessary <div> in the Notebook widget.
1240 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1241 method to get container FlowPanel (<div>).
1242 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1243 initWidget() method directly on the TabLayoutPanel widget instead of
1244 Group's container widget.
1246 2011-11-29 Ben Konrath <ben@bagu.org>
1248 Don't add group titles for Portals in Notebooks.
1250 This reverts the previous patch and fixes a bug I introduced with
1251 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1253 * src/main/java/org/glom/web/client/ui/details/Group.java:
1254 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1256 2011-11-28 Ben Konrath <ben@bagu.org>
1258 Remove unused boolean argument in Portal constructor.
1260 Just a code cleanup.
1262 * src/main/java/org/glom/web/client/ui/details/Group.java:
1263 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1265 2011-11-28 Ben Konrath <ben@bagu.org>
1267 Remove hack for glom 1.18 style glom files.
1269 * src/main/java/org/glom/web/client/ui/details/Group.java:
1270 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1271 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1273 2011-11-28 Ben Konrath <ben@bagu.org>
1275 Use Gda Value version of primary key to log result too large error.
1277 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1279 2011-11-28 Ben Konrath <ben@bagu.org>
1281 Don't use TypedDataItem.getText() for Unknown types from the URL.
1283 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1284 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1285 instead of getText().
1286 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1287 String field and getUnknown() method.
1289 2011-11-28 Ben Konrath <ben@bagu.org>
1291 Log an error message when the java-libglom .so is not present.
1293 The error message was being set in the exception but not logged.
1295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1297 2011-11-28 Ben Konrath <ben@bagu.org>
1299 Ignore LayoutItem_CalendarPortals.
1301 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1302 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1304 2011-11-28 Ben Konrath <ben@bagu.org>
1306 Extract method for creating the LayoutItemPortal DTO.
1308 Just breaking the code up into smaller chunks.
1310 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1312 2011-11-28 Ben Konrath <ben@bagu.org>
1316 This should have been added with the refactor. Oops!
1318 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1320 2011-11-28 Ben Konrath <ben@bagu.org>
1322 Create primary key value from URL string using type from Glom document.
1324 See this bug, comments 19 - 25:
1326 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1328 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1329 create a TypeDataItem for the primary key here when loading from a
1330 URL. Show the same string for the primary key value as was received
1331 from the URL string (when loading from a URL).
1332 * src/main/java/org/glom/web/server/Utils.java: Update method for
1333 creating the Gda Value from the TypeDataItem to properly deal with
1334 creating a Gda Value based on the Glom document type for the primary
1335 key value string when loading from a URL.
1336 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1337 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1338 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1339 Update for changed method name.
1341 2011-11-27 Ben Konrath <ben@bagu.org>
1343 Rename PrimaryKeyItem to TypedDataItem.
1345 The name PrimaryKeyItem suggests what the class should be used for.
1346 TypedDataItem is a neutral name that describes the class better.
1348 This is a rename-only refactor.
1350 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1351 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1352 * src/main/java/org/glom/web/client/Utils.java:
1353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1354 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1355 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1356 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1357 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1358 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1359 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1360 * src/main/java/org/glom/web/server/Utils.java:
1361 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1362 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1363 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1364 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1366 2011-11-25 Ben Konrath <ben@bagu.org>
1368 Improve Gda Value conversion from PrimaryKeyItem.
1370 The value from the PrimaryKeyItem is only used if its type match the
1371 type from the glom document.
1373 * src/main/java/org/glom/web/server/Utils.java:
1375 2011-11-25 Ben Konrath <ben@bagu.org>
1377 Manually check if the java-liblgom .so is visible to the JVM.
1379 It seems that Tomcat has problems when a static initializer throws an
1380 exception. This check is done before the first method call into
1381 java-libglom so that execution doesn't continue if the .so is not
1384 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1386 2011-11-25 Ben Konrath <ben@bagu.org>
1388 Improve browser configuration error messages.
1392 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1394 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1395 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1396 getConfigurationErrorMessage() method.
1397 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1398 Get and display a specific configuration error message when no Glom
1399 documents are found.
1400 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1401 Implement getConfigurationErrorMessage() method. Surround configuration
1402 code in the init() method with a try/catch block. This allows the
1403 errors to be caught while keeping the servlet available to retrieve the
1404 configuration error message.
1406 2011-11-25 Ben Konrath <ben@bagu.org>
1408 Don't use Strings to hold primary key values.
1410 The primary key values are now held in a new data object
1411 (PrimaryKeyItem) that holds type information and the primary key value
1412 using the correct type.
1414 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1415 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1417 PrimaryKeyItem instead of String to hold the primary key value.
1418 * src/main/java/org/glom/web/client/Utils.java: Remove
1419 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1420 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1421 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1422 PrimaryKeyItem instead of String to hold the primary key value. Load
1423 document selection page when the documentID has not been set correctly.
1424 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1425 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1427 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1428 Return empty string for URL instead of "null".
1429 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1430 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1431 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1432 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1433 PrimaryKeyItem instead of String to hold primary key values.
1434 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1435 PrimaryKeyValue to a Gda Value.
1436 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1437 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1438 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1439 Replace temporary database access code that uses the PrimaryKeyValue to
1440 Gda Value conversion.
1441 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1442 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1443 PrimaryKeyItem instead of String.
1444 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1445 hold primary key values.
1447 2011-11-24 Ben Konrath <ben@bagu.org>
1449 Use newly added java-libglom API to create queries.
1451 This isn't finished. I still need to stop using Strings for primary key
1452 values in the client code.
1454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1455 libglom to use fake connections so that retrieving the query string will
1457 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1458 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1459 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1460 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1461 Use the newly added libglom sql methods and classes to create the
1462 query. Add temporary hack to convert primary value strings to Gda
1465 2011-11-23 Ben Konrath <ben@bagu.org>
1467 Don't explicitly set the height of Portals.
1469 See comments 6 - 10 of this bug for details:
1471 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1473 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1475 2011-11-23 Ben Konrath <ben@bagu.org>
1477 Use an HTML table instead of CSS for the FlowTable layout.
1479 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1480 GWT's FlexTable to implement the FlowTable.
1481 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1483 2011-11-18 Ben Konrath <ben@bagu.org>
1485 Add boolean example to HTML table mockup.
1487 * mockups/details-view-html-tables-text-entries.html:
1489 2011-11-17 Ben Konrath <ben@bagu.org>
1491 Ensure the pager buttons are always visible for related lists.
1493 To accomplish this, I've turned off text wrapping in the list view and
1494 related list tables for both the header and data text. The related list
1495 table now has a fixed layout so the it doesn't overflow its container.
1496 This is required to ensure that the cell text is clipped when it
1497 overflows the cell and an ellipsis is added to the right side of the
1498 cell when text is clipped.
1500 A fixed table layout for the related list table in the details view
1501 seems what we want for the details view anyway, so the side-effect is
1504 The ellipsis will only be displayed in Firefox >= 7.
1508 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1510 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1511 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1512 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1514 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1515 Set the 'table-layout: fixed' CSS property to the related list table.
1516 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1517 'white-space: nowrap;' CSS property on both the list view and the
1518 related list tables.
1520 2011-11-16 Ben Konrath <ben@bagu.org>
1522 Rework the fix for empty notebook tab labels.
1524 Setting the empty group titles with its name caused problems for the
1525 details layout. Instead of using libglom's
1526 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1527 to the client when the title is empty. This allows the Notebook to use
1528 the name when the title is empty without affecting anything else.
1530 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1531 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1533 2011-11-16 Ben Konrath <ben@bagu.org>
1535 Set group titles with name when title is empty.
1537 This fixes a problem with an empty notebook tab label in the Lesson
1538 Planner document. The forth tab in the notebook should be "Internet":
1540 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1542 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1543 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1546 2011-11-16 Ben Konrath <ben@bagu.org>
1548 Remove whitespace from the configured username properties.
1550 This assumes that usernames won't have whitespace at the beginning
1551 or end. But I think this is a reasonable assumption.
1553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1554 String.trim() to remove the whitespace from the username properties.
1556 2011-11-15 Ben Konrath <ben@bagu.org>
1558 Add details view mockup with HTML tables and text entries.
1560 This is from the attachment on this bug:
1562 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1564 * mockups/details-view-html-tables-text-entries.html:
1566 2011-11-15 Ben Konrath <ben@bagu.org>
1568 Add space between the columns of the flow table.
1572 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1574 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1575 space between columns in the flow table.
1577 2011-11-15 Ben Konrath <ben@bagu.org>
1579 Add backup files to the .gitignore.
1581 * .gitignore: Ignore files that end with ~.
1583 2011-11-09 Ben Konrath <ben@bagu.org>
1585 Use latest release of gwt-log.
1587 Gwt-log releases are now being submitted to the maven central
1588 repository so manual installation of the jar is no longer required.
1590 * pom.xml: Update version and groupId of gwt-log dependency.
1592 2011-10-31 Ben Konrath <ben@bagu.org>
1594 Don't use GWT numeric formatting to override the glom currency formatting.
1596 Currencies are now displayed like they are in Glom. See this bug:
1598 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1600 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1602 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1603 currency code to constructor and set it when the cell is rendered.
1604 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1605 currency code to the constructor of the NumericCell.
1607 2011-10-27 Ben Konrath <ben@bagu.org>
1609 Require the latest release of java-libglom (1.17.4).
1613 2011-10-26 Ben Konrath <ben@bagu.org>
1615 Add style to Notebook that matches current theme.
1617 It's not the best style in the world but it's better than the default.
1619 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1620 padding at the bottom of the child widgets.
1621 * src/main/webapp/style.css: Add style for the Notebook.
1623 2011-10-26 Ben Konrath <ben@bagu.org>
1625 Move servlet initialization code to overridden init method.
1627 This is half of the solution to getting proper error messages
1628 displayed when configuration errors occur. Here's the relevant bug:
1630 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1632 The rest of the solution involves surrounding the init method with a
1633 try/catch block and setting a global variable with the error /
1634 exception. A new async method should be created to retrieve and display
1635 the error message / exception.
1637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1638 code from constructor to init method adding exceptions as needed.
1640 2011-10-26 Ben Konrath <ben@bagu.org>
1642 Add script to monitor and restart tomcat if required.
1644 * utils/check-and-recover-tomcat.py: New file.
1646 2011-10-26 Ben Konrath <ben@bagu.org>
1648 Display the correct number of data items in the pager.
1652 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1654 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1655 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1656 The implementation is the same for both tables: Keep track of the
1657 number of non-empty rows and fire and RowCountChangeEvent after the data has
1659 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1660 custom Pager class that subclasses SimplePager to handle displaying
1661 the correct number when empty rows have been added.
1663 2011-10-26 Ben Konrath <ben@bagu.org>
1665 Correct error in previous commit.
1667 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1668 eventBus parameter from listView.setCellTable().
1670 2011-10-26 Ben Konrath <ben@bagu.org>
1672 Fix error in TODO comment.
1674 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1676 2011-10-24 Ben Konrath <ben@bagu.org>
1678 Create Notebook widgets to the details view.
1680 This isn't finished just yet - I still need to create a reasonable
1681 style to match the current theme.
1683 * src/main/java/org/glom/web/client/Utils.java: Add method for
1684 calculating the height of a widget. This is used in the Notebook class.
1685 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1686 new constructor method in Group.
1687 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1688 method for creating child widget that can be used by subclasses
1689 like Notebook. New constructor that allows disabling the group
1690 titles - Notebooks don't set a group title for their child groups.
1691 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1692 to make Notebooks using GWT's TabLayoutPanel.
1693 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1694 constructor that allows disabling the group titles.
1695 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1696 LayoutItemNotebook DTO.
1697 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1698 DTO for Notebooks. It's just an empty class for now but we might need
1699 it to transfer some specific information in the future.
1701 2011-10-21 Ben Konrath <ben@bagu.org>
1703 Add navigation buttons to related list tables.
1705 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1706 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1708 method getSuitableRecordToViewDetails() for getting the table name
1709 and primary key value for related list navigation buttons.
1710 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1711 private cell renderer class to get the navigation information for
1712 related list tables from the server. Extract the navigation
1713 processing code from the details cell navigation and use it for the
1714 related list navigation as well.
1715 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1716 cell renderer class for the details open buttons. This was needed
1717 because the related list navigation buttons and the list view
1718 navigation buttons need to react differently when clicked.
1719 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1720 the onEnterKeyDown() method because it's now overriden in the
1721 subclasses that are specific to the related list tables and the list
1723 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1724 the vertical size a little because the buttons add a bit of vertical
1725 space to table. This is not a perfect solution because the vertical
1726 size of with table fewer than 5 rows will be a little smaller.
1727 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1728 changes in how navigation buttons are handled.
1729 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1730 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1731 database access object.
1732 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1733 to find the portal for a given relationship name from
1734 RelatedListDBAccess. Add method to find a primary key field for a
1736 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1737 Move code to find the portal for a given relationship name to
1739 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1740 New file: database access object for getting the related list
1741 navigation information (the table name and the primary key value).
1742 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1743 DTO for transferring a table name to navigate to and a primary key
1745 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1746 boolean and getter/setter to specifies if the related list should add
1749 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1751 Use the master branch of java-libglom
1753 * pom.xml: Depend on java-libglom 1.19 instead.
1755 This is the master branch. See also the libglom-1-18 branch.
1757 2011-10-11 Ben Konrath <ben@bagu.org>
1759 Enable the open navigation button when the data has been set.
1761 This avoids having active buttons that don't do anything when the data
1764 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1766 2011-10-11 Ben Konrath <ben@bagu.org>
1768 Use IsWidget interface for FlowTableItem.
1770 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1771 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1773 2011-10-11 Ben Konrath <ben@bagu.org>
1775 Remove GWT styling from open button in details view.
1777 There are still some issues with how the details cell is arranged but
1778 this should be made to match Glom 1.20. I'm going to leave fixing this
1779 until I have Glom 1.20 up and running.
1781 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1782 style name on open button.
1783 * src/main/webapp/style.css: Move and edit details-navigation class.
1784 Re-arrange some classes to make them appear in the same order as the
1787 2011-10-07 Ben Konrath <ben@bagu.org>
1789 Update to GWT 2.4.0.
1791 * .gitignore: Ignore new cache directory.
1792 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1793 * pom.xml: Change GWT and maven plugin to 2.4.0.
1794 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1796 * src/main/java/org/glom/web/client/ClientFactory.java:
1797 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1798 * src/main/java/org/glom/web/client/OnlineGlom.java:
1799 Update source for API changes.
1800 * utils/build-onlineglom-war.sh: Remove cache directory before the
1803 2011-10-07 Ben Konrath <ben@bagu.org>
1805 Add navigation buttons in the details view.
1807 This isn't finished but I thought I'd commit what I have as it's a
1808 pretty good start. I still need to:
1810 1. Change the style so that it fits better into the current theme
1811 2. Adjust the details cell to expand as much as possible.
1813 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1814 click handlers to navigation buttons in the DetailsCells. Create a
1815 refreshData() method to get just the data from the server without the
1817 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1818 Update the tableSelector and browser title when the table name
1819 changes without using the tableSelector.
1820 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1821 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1822 getDetailsCells() to getCells(). Update variable names.
1823 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1824 method to set click handler on navigation button. Rename a few
1825 variables. Add navigation buttons where needed.
1826 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1827 variables and methods.
1828 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1829 navigation boolean and navigation table as required in the
1830 LayoutItemField DTO.
1831 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1832 variables for navigation along with getter/setter methods.
1834 2011-10-07 Ben Konrath <ben@bagu.org>
1836 Rename Field to DetailsCell.
1838 This is a refactor-only commit. No functionality has been added or
1841 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1842 Update variable and method names.
1843 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1844 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1845 variable and method names.
1846 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1848 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1849 variable and method names.
1851 2011-10-07 Ben Konrath <ben@bagu.org>
1853 Create separate methods for layout and data the details view.
1855 This is a refactor-only commit. No functionality has been added or
1858 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1859 private methods: setData(), createLayout().
1861 2011-10-07 Ben Konrath <ben@bagu.org>
1863 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1865 This is part of a change to get navigation buttons in the details view
1866 but it should have been done this way from the start.
1868 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1869 for method name change in TableSelectionView.
1870 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1871 Create TableChangeEvent and set the browser title using the
1872 TableSelectionView API.
1873 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1874 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1875 Change getSelectedTable() to getSelectedTableName(). Add
1876 getSelectedTableTitle().
1878 2011-10-07 Ben Konrath <ben@bagu.org>
1880 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1882 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1884 2011-10-07 Ben Konrath <ben@bagu.org>
1886 Update TableChangeEvent to use newTableName naming convention.
1888 This makes the class more consistent with GWT naming conventions.
1890 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1891 Update for method name change in TableChangeEvent.
1892 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1893 for method name change in TableChangeEvent.
1894 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1895 newTableName variable and getter method. Make toDebugString()
1898 2011-09-30 Ben Konrath <ben@bagu.org>
1900 Disable the pager in the list tables when the data row count is less than the minimum.
1902 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1903 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1905 2011-09-30 Ben Konrath <ben@bagu.org>
1907 Add empty rows to the end of related list and list view tables.
1909 I also extracted the cell rendering classes from the ListTable because
1910 the code was becoming a little crazy with all the anonymous inner
1911 classes. My plan is to use these cell rendering classes in the details
1912 view as well so this refactor will be needed for that change.
1914 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1915 set the row count in related list tables if the data has more rows
1916 than the minimum number of rows visible.
1917 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1918 row count in list view tables if the data has more rows than the
1919 minimum number of rows visible.
1920 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1921 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1923 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1924 for rendering TYPE_NUMERIC cells. The code was extracted from the
1926 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1927 class for rendering cells with buttons in list views. The code was
1928 extracted from the ListTable class.
1929 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1930 for rendering TYPE_TEXT cells. The code was extracted from the
1932 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1933 Add empty rows to the end of the data if required. Implement
1934 ListTable.getMinNumVisibleRows().
1935 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1936 cell renderer code to public classes. Return null in
1937 Column.getValue() for empty rows. Add new abstract method:
1938 getMinNumVisibleRows(). Move code to set the row count of the list view
1939 table to ListViewImpl.
1940 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1941 empty rows to the end of the data if required. Implement
1942 ListTable.getMinNumVisibleRows().
1945 2011-09-27 Ben Konrath <ben@bagu.org>
1947 Use GWT.log for client-side debugging statements.
1949 These are optimized out when deployed so I should have used this method
1950 in the first place. These statements will eventually be replaced with some sort
1951 of notification in the browser.
1953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1954 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1955 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1956 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1957 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1959 2011-09-27 Ben Konrath <ben@bagu.org>
1961 Put tableselector on the right, back to list link on right.
1963 The idea is that the table selector is acting like a label for the
1964 currently displayed table so it should be placed below the document title. This
1965 puts the table title in a similar position to where it is in Glom.
1967 * mockups/details-contacts.html:
1968 * mockups/details-projects.html:
1969 * mockups/listview-contacts.html:
1970 * mockups/listview-projects.html:
1971 * mockups/style.css:
1972 Update mockups to match how the interfaces currently look.
1973 * src/main/webapp/style.css: Swap positions of backlink with the table
1974 selector. Add some space on the left side of the table selector to
1975 line things up with the document title.
1977 2011-09-27 Ben Konrath <ben@bagu.org>
1979 Add field colouring to details view.
1981 This change re-works how field colouring works. The colour formatting
1982 information is now set to the client with the layout information instead of
1983 with the data. This eliminates the need to send the same colour strings for
1984 data in list view column when colour information is set.
1986 In order to set an alternate colour for negative numeric values, the
1987 number is now sent to client and formatted with the GWT NumberFormat class.
1989 This change also fixes:
1991 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1993 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1994 internationalization framework which is needed for client side numeric
1996 * src/main/java/org/glom/web/client/Utils.java: New file for some
1997 client static utility methods.
1998 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1999 the DataItem object to the Field class. Use a utility method to
2000 create the foreignKeyValue string.
2001 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2002 alignment and text colours in the constructor. Add setData(DataItem)
2003 method. Remove setText(String) method.
2004 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2005 colour information to GlomTextCell. Create and use GlomNumberCell for
2006 rendering numbers. Use utility method to get the string for the
2007 primary key of the key provider. Re-work how the horizontal alignment
2009 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2010 formatting to layout information. Methods for converting the libglom
2011 formatting information were moved from DBAccess.
2012 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2013 numeric formatting (it's now done on the client side). Don't set text
2014 colours in DataItem. Move libglom formatting conversion methods to
2016 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2017 getters/setters for text colour information.
2018 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2019 for transferring the libglom NumericFormat information to the client.
2020 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2021 and getters/setters for: GlomNumericFormat, background colour and
2022 foreground colour strings.
2024 2011-09-26 Ben Konrath <ben@bagu.org>
2026 Simplify code that iterates through the LayoutGroup.
2028 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2030 2011-09-26 Ben Konrath <ben@bagu.org>
2032 Accept Eclipse formatting for OnlineGlomServiceAsync.
2034 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2036 2011-09-26 Ben Konrath <ben@bagu.org>
2038 Don't use the ListDBAccess classes to get the primary key layout information.
2040 This was causing a bug where the wrong index for the hidden primary key
2041 was being sent to the client.
2043 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2044 primary key while creating the LayoutGroup DTO. Create a
2045 LayoutItemField DTO for hidden primary keys. Don't use the
2046 RelatedListDBAccess because it was only used for getting the primary
2048 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2049 access modifier from public to protected for getPrimaryKeyField() and
2050 getPrimaryKeyLayoutItemField().
2051 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2052 abstract method getExpectedResultSize() because RelatedListDBAccess
2053 doesn't have enough info to implement it.
2054 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2055 Remove @Override for getExpectedResultSize().
2056 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2057 Remove method getExpectedResultSize().
2059 2011-09-23 Ben Konrath <ben@bagu.org>
2061 Log which layout (list or details) the ignored item is from.
2063 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2065 2011-09-23 Ben Konrath <ben@bagu.org>
2067 Remove annotations that turn off code formatting in DataItem.
2069 * src/main/java/org/glom/web/shared/DataItem.java:
2071 2011-09-23 Ben Konrath <ben@bagu.org>
2073 Rename GlomField to DataItem and update associated methods.
2075 This is a rename-only refactor. No functionality has been added or
2078 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2079 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2080 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2081 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2082 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2083 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2084 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2085 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2087 * src/main/java/org/glom/web/server/database/DBAccess.java:
2088 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2089 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2090 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2091 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2092 * src/main/java/org/glom/web/shared/DataItem.java:
2093 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2094 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2096 2011-09-23 Ben Konrath <ben@bagu.org>
2098 Rename GlomDocument to DocumentInfo and update associated methods.
2100 This is a rename-only refactor. No functionality has been added or
2103 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2104 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2105 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2106 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2107 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2109 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2111 2011-09-20 Ben Konrath <ben@bagu.org>
2113 Require java-libglom 1.17.3.
2115 This picks up the fix for the seg fault problem with the Scenes table
2116 in the Openismus Film Manager example.
2120 2011-09-20 Ben Konrath <ben@bagu.org>
2122 Change the way sort clause is added for primary key when no sort clause is requested.
2124 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2125 before the sort clause is created. When a sort clause is not requested, the
2126 sort clause is created by finding the primary key in the LayoutFieldVector
2129 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2131 2011-09-20 Ben Konrath <ben@bagu.org>
2133 Log error message if no documents are found in the configured directory.
2135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2136 Extract the glom file extension string to a private static final class
2137 variable (mostly as syntactic sugar). Accept a minor formatting change.
2138 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2139 the example glom.document.directory configuration property to make it
2140 more clear that it can any directory, not just the home directory.
2142 2011-09-18 Ben Konrath <ben@bagu.org>
2144 Add related lists to details view.
2146 The related list table has support for paging and sorting just like the
2147 table in the list view.
2149 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2150 SQL queries for the related list tables.
2151 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2152 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2154 Rename getList methods to getListView and add comments. Remove
2155 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2156 it being unused. Add methods: getDetailsLayoutAndData(),
2157 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2158 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2159 Create the layout and set the data for the fields in one async call
2160 instead of two. Create related lists where appropriate.
2161 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2162 for method name changes in OnlineGlomService.
2163 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2164 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2165 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2167 * src/main/java/org/glom/web/client/ui/ListView.java:
2168 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2169 tableName from setCellTable(). Create a ListViewTable instead of
2171 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2172 represent a data field in the details view.
2173 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2174 from addDetailsCell() to Field class. Keep track of the Fields and
2175 Portals in the details view.
2176 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2177 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2178 and add a method to get it. Add method to set the contents of the
2180 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2181 New class for related list tables. This class has the data provider
2182 for the related list table.
2183 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2184 abstract class which is the base class for the ListViewTable and the
2186 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2187 New class for list view tables. This class has the data provider for
2188 the list view table.
2189 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2190 methods for related list tables. Add more information to the
2191 LayoutItemField and LayoutItemPortal DTOs.
2192 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2193 Remove debugging print statement.
2194 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2195 Remove debugging print statements. Add primary key field to SQL count
2197 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2198 Remove unnecessary LayoutFieldVector parameter from
2199 getResultSizeOfSQLQuery() method.
2200 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2201 New class for related list table database access.
2202 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2203 class that is a wrapper DTO for details view layout and data.
2204 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2205 new 'fromField' string to this DTO.
2206 * src/main/webapp/style.css: Remove bottom margin and override top
2209 2011-09-15 Ben Konrath <ben@bagu.org>
2211 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2213 This sets things up to make it easier to add the data retrieval for
2214 related lists (portals). No user noticeable changes were made with
2217 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2218 class has the code to retrieve the layouts and access the
2219 database using the new database helper classes.
2220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2221 Most of the functionality has been removed from this class. This
2222 class now represents the public interface for the client side
2223 code. It also deals with configuring the servlet and cleaning
2224 things up when the servlet is stopped.
2225 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2226 of static methods into this utility class.
2227 * src/main/java/org/glom/web/server/database/DBAccess.java:
2228 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2229 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2230 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2231 These classes have the database retrieval code. The class hierarchy
2232 has been setup to make it easy to reuse code for similar
2235 2011-09-06 Ben Konrath <ben@bagu.org>
2237 Create separate classes for list table code and the data provider.
2239 As part of this refactor, I also split up the code a bit to make it
2242 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2243 table code to two new classes (below).
2244 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2245 with code from ListViewImpl.
2246 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2247 New file with code from ListViewImpl.
2249 2011-09-06 Ben Konrath <ben@bagu.org>
2251 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2253 This fixes the LayoutItemPortal DTO to match the libglom layout object
2256 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2258 2011-09-01 Ben Konrath <ben@bagu.org>
2260 Set title of Portals in the Details View.
2262 * pom.xml: Bump required version of java-libglom to 1.17.1.
2263 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2264 widget creation to its own class. Add comments to constructor.
2265 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2266 The code is mostly from the Group class with the title now set.
2267 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2268 title of Portal. Update some comments. Fix some code formatting.
2270 2011-09-01 Ben Konrath <ben@bagu.org>
2272 Remove TODO comment for the flow table column width.
2274 The flow table column width is working correctly and doesn't need to be
2275 changed. See this mailing list post for more info:
2277 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2279 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2281 2011-08-27 Ben Konrath <ben@bagu.org>
2283 Add document title (database name) to top of the browser page.
2285 I added the document title to the TableSelecitonView but that will
2286 change if / when we add a view that doesn't require table selection.
2288 * mockups/details-contacts.html:
2289 * mockups/details-projects.html:
2290 * mockups/listview-contacts.html:
2291 * mockups/listview-projects.html:
2292 * mockups/style.css: Add document title to mockups to keep things
2294 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2295 sizes to account for the document title.
2296 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2297 Set the document title when it has been retrieved from the server.
2298 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2299 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2300 and implement setDocumentTitle(String) method.
2301 * src/main/webapp/style.css: Add ID for document title style.
2303 2011-08-25 Ben Konrath <ben@bagu.org>
2305 Add NavigationType enum to LayoutItemPortal DTO.
2307 This is the start of adding support for Portals to the Details View.
2309 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2310 LayoutItem_Portal.navigation_type enum from libglom to
2311 LayoutItemPortal.NavigationType enum.
2312 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2313 NavigationType enum, field for storing the NavigationType and getter
2316 2011-08-25 Ben Konrath <ben@bagu.org>
2318 Implement the flow table layout in the Details View.
2320 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2321 FlowTable to Group to account for the renamed class.
2322 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2323 File. This is a container widget that implements the Glom details view
2324 flow table behaviour.
2325 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2326 org/glom/web/client/ui/FlowTable.java.
2327 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2328 so that the size of the subgroups are a closer match to the size of
2329 the Glom subgroups. This makes the flowtable layout match the layout
2330 in Glom for the Music Collection example file.
2332 2011-08-16 Ben Konrath <ben@bagu.org>
2334 Create container element for LayoutItemPortal in Details View.
2336 This will help me develop the layout for the FlowTable.
2338 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2339 fieldPanel variable to detailsCell.
2341 2011-08-15 Ben Konrath <ben@bagu.org>
2343 Set the height of the data element in the Details View.
2345 I changed the InlineLabels (text in a span element) to Labels (text in
2346 a div element) so that I could set the height of the details-data
2347 elements instead of the details-cell parent elements. This allows the
2348 the details-data element to display the correct height if style is
2349 applied that shows the height.
2351 This change has the added benefit of allowing the order of the labels
2352 and data elements to be changed for right-to-left languages.
2354 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2355 InlineLabels to Labels.
2356 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2357 InlineLabels to Labels. Set the height of the data element.
2358 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2359 multiline text height in the Formatting DTO.
2360 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2361 for multiline height along with getter and setter methods.
2362 * src/main/webapp/style.css: Adjust style to account for the change
2363 from span elements to div elements in the details cell.
2365 2011-08-15 Ben Konrath <ben@bagu.org>
2367 Make the List View appearance match the mockups.
2369 It doesn't match exactly but it's much better than it was.
2371 * mockups/listview-contacts.html: Remove unused css classes.
2372 * mockups/listview-projects.html: Remove unused css classes.
2373 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2374 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2375 for mainPanel instead of VerticalPanel (table). Set style name on
2376 CellTable. Set style name on Details column. Right-align Details
2378 * src/main/webapp/style.css: Adjust properties to match the mockups.
2380 2011-08-12 Ben Konrath <ben@bagu.org>
2382 Add better support for subgroups in the details view.
2384 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2385 changed FlowTable constructor.
2386 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2387 support for subgroups and subgroup-titles.
2388 * src/main/webapp/style.css: Add CSS class for subgroups and
2391 2011-08-12 Ben Konrath <ben@bagu.org>
2393 Return the top level LayoutGroup title.
2395 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2397 2011-08-11 Ben Konrath <ben@bagu.org>
2399 Make the TableSelector header match the mockup.
2401 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2402 the layout panel. Properly lineup the table selection header with
2403 the list and details view.
2404 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2405 margin around the details view.
2406 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2407 Rename listBox variable to tableSelector. Set id for the style sheet.
2408 Use a FlowPanel instead of a HorizontalPanel.
2409 * src/main/webapp/style.css: Add properties to make the TableSelector
2410 box match the mockups.
2412 2011-07-13 Ben Konrath <ben@bagu.org>
2414 Update install script for java-libglom version change.
2416 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2419 2011-07-13 Ben Konrath <ben@bagu.org>
2421 Add support sub-group in the details view.
2423 I also removed the code that special-cased the default details view
2426 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2428 I still have to make a proper flowtable.
2430 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2431 Don't special-case default details view layout.
2432 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2433 addLayoutField() as I'm going to use it.
2434 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2435 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2437 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2438 extracted from DetailsViewImpl.GroupPanel. Add support for
2440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2441 column count when getting the details layout.
2443 2011-07-12 Ben Konrath <ben@bagu.org>
2445 Set browser title with database and table titles.
2447 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2448 Set the browser title when the table changes and when the activity
2450 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2451 title when retrieving document info (the GlomDocument object).
2452 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2453 with getter and setter methods. Remove unused convenience constructor.
2454 Use default code formatting.
2456 2011-07-12 Ben Konrath <ben@bagu.org>
2458 Ignore LayoutItemPortals in the details view.
2460 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2463 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2464 LayoutItemPortal layout objects.
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2466 LayoutItemPortal objects when retrieving the details layout.
2467 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2468 file. This is an empty class and just used to get type information for
2471 2011-07-12 Ben Konrath <ben@bagu.org>
2473 Use java-libglom 1.17.0.
2477 2011-07-11 Ben Konrath <ben@bagu.org>
2479 Remove "Table:" label from table selector.
2481 This matches a recent change in the Glom UI.
2483 * mockups/details-contacts.html:
2484 * mockups/details-projects.html:
2485 * mockups/listview-contacts.html:
2486 * mockups/listview-projects.html: Remove the "Table:" label from the
2488 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2490 2011-07-11 Ben Konrath <ben@bagu.org>
2492 Add main groups to the details view.
2494 This makes things look a little nicer in the details view. The next step
2495 is to implement the flowtable.
2497 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2498 resources from the standard gwt css theme. Standard.css is now
2499 included in OnlineGlom.html so that the online glom css rules have
2500 precedence over the gwt theme.
2501 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2502 the whole LayoutGroup to the DetailsView instead of just the titles.
2503 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2504 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2505 details layout with a helper class (GroupPanel). I might extract this
2506 class when I make the full flowtable.
2507 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2508 string as default so I don't have to worry about NPEs when processing
2510 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2511 note beside OnlineGlom.gwt.xml above).
2512 * src/main/webapp/style.css: Add default font-size to body to override
2513 the font-size set by the standard theme. Don't use h2 tags for
2514 group-title. Create new details-cell class.
2516 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2518 ConfiguredDocument: Set the port number too.
2520 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2521 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2522 Glom document. Presumably this worked sometimes so far because there is a
2523 default port number.
2525 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2527 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2529 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2530 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2531 correct, though we should throw an exception too.
2533 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2535 Fix a addDocuemnt typo.
2537 * src/main/java/org/glom/web/shared/Documents.java
2538 (Documents.addDocuemnt): Rename to addDocument().
2539 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2540 (OnlineGlomServiceImpl.getDocuments): Adapt.
2542 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2544 Slightly improved log output when connection fails.
2546 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2547 (ConfiguredDocument.setUsernameAndPassword):
2548 We don't know for sure if it' the username/password that's wrong, so
2549 rephrase the message.
2550 Also ouput the exception message, though it's generic in this case.
2552 2011-07-08 Ben Konrath <ben@bagu.org>
2556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2557 added braces to a one line if statement because the Eclipse formatter
2558 was getting confused.
2560 2011-07-07 Ben Konrath <ben@bagu.org>
2562 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2564 These should really be two separate tasks but I counldn't get things to
2565 work with GWT 2.2.0 and Eclipse 3.7.
2569 * .settings/org.eclipse.jdt.core.prefs:
2570 * .settings/org.eclipse.jdt.ui.prefs:
2571 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2572 * .settings/org.eclipse.m2e.core.prefs:
2573 Add new config files. Update current files. Remove references to the
2574 webtools plugins as we're not using any of the webtools features.
2575 * .gitignore: Add logs directory which is created when running with
2577 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2578 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2579 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2581 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2583 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2585 onlineglom.properties: Add explanatory comments.
2587 * src/main/resources/onlineglom.properties: Also change the default user
2588 from ben to someuser, to avoid the risk of people thinking we just
2589 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2591 2011-06-28 Ben Konrath <ben@bagu.org>
2593 Use filename in Log for incorrect passwords.
2595 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2596 getFileName(String) method to get the filename from the URI.
2598 2011-06-28 Ben Konrath <ben@bagu.org>
2600 Add the table name to the URL token for the ListPlace.
2602 This makes things consistent between the DetailsPlace and the
2603 ListPlace. It also allows the the ListPlace to be bookmarked.
2605 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2606 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2608 Remove getDefaultListLayout(). The default layout is now returned
2609 by the getListLayout() method when the table name is an empty string.
2610 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2611 Add table name field. Change to a new ListPlace when the table
2612 has been changed. Use getListLayout() for getting the default
2614 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2615 Add table name field. Set the correct table name in the list box
2616 when loading from bookmark. This corrects a problem for the
2618 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2619 Move table name to super-class (HasSelectableTable). Move document
2620 and table URL keys to super-class in HasSelectableTable.
2621 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2622 Add table name field. Add Tokenizer class with URL key common to
2623 the subclasses (DetailsPlace and ListPlace).
2624 * src/main/java/org/glom/web/client/place/ListPlace.java:
2625 Add table name. Add code to parse the URL token.
2626 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2627 Update ListPlace construction with empty table name string.
2628 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2629 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2630 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2631 Update ListPlace construction with table name string.
2632 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2633 Change defaultTableName field to tableName to reflect how it's now
2634 used. Update the getter and setter methods.
2636 2011-06-28 Ben Konrath <ben@bagu.org>
2638 Enable the table selector in the DetailsView.
2640 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2641 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2643 Remove getDefaultDetailsLayout(). The default layout is now returned
2644 by the getDetailsLayout() method when the table name is an empty
2646 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2647 event handler for table change event. Change to using
2648 getDetailsLayout() for the default details layout.
2649 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2651 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2652 when navigating to the details place.
2654 2011-06-27 Ben Konrath <ben@bagu.org>
2656 Use filename based unique document ID in URL and for RPC.
2658 The document ID is the glom document name with spaces (' ') replaced
2659 with pluses ('+') and without the .glom extension.
2661 This change is mostly a string substitution of 'documentTitle' for
2662 'documentID'. The only code change is the addition of a Documents DTO to get the
2663 filename to document title mappings as indicated below.
2665 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2666 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2667 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2668 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2669 Use Documents DTO to create the document links in the document
2671 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2672 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2673 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2674 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2675 * src/main/java/org/glom/web/client/place/ListPlace.java:
2676 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2677 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2678 * src/main/java/org/glom/web/client/ui/ListView.java:
2679 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2680 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2681 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2682 * src/main/java/org/glom/web/server/Log.java:
2683 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2684 getDocumentTitles() to getDocuments() and return the Documents DTO.
2685 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2686 transferring the filename to document title mappings.
2688 2011-06-25 Ben Konrath <ben@bagu.org>
2690 Make the authentication popup work again.
2692 This bug was introduced when I extracted ConfiguredDocument to its own class.
2694 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2695 correct success / fail status in setUsernameAndPassword().
2697 2011-06-25 Ben Konrath <ben@bagu.org>
2699 Use filename as unique key for configuring database usernames and passwords.
2701 This replaces the use of the Glom document title which could change
2702 depending on the locale. Thanks to Murray Cumming for pointing out this
2705 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2706 * src/main/resources/onlineglom.properties:
2708 2011-06-24 Ben Konrath <ben@bagu.org>
2710 Pass primary key value to DetailsView.
2712 This enables the DetailsView to load the correct data.
2714 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2715 primary key value field and set in constructor. Pass primary key
2716 value to getDetailsData().
2717 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2718 variables for document title and primary key value.
2719 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2720 key value to the DetailsPlace.
2722 2011-06-24 Ben Konrath <ben@bagu.org>
2724 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2726 This allows the primary key to be retrieved by the Details button. This
2727 functionality has not been implemented yet but it's in the works.
2729 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2730 the LayoutGroup result to ListView.setCellTable instead of all of its
2731 fields individually.
2732 * src/main/java/org/glom/web/client/ui/ListView.java:
2733 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2734 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2735 get the primary key for the table.
2736 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2737 index of the primary key in the LayoutGroup accounting for hidden
2738 primary keys. Rename getJavaNumberFormat() to
2739 convertToJavaNumberFormat() for consistency. Cleanup / add some
2741 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2742 field for primary key index and a field to indicate whether the
2743 primary key is hidden or not.
2745 2011-06-23 Ben Konrath <ben@bagu.org>
2747 Rename getTableData methods to getListData.
2749 This is a rename refactor for consistency with other methods.
2751 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2752 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2753 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2756 2011-06-23 Ben Konrath <ben@bagu.org>
2758 Extract the ConfiguredDocument innerclass into its own class.
2760 This makes the servlet code more object oriented.
2762 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2763 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2764 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2765 new ConfiguredDocument class.
2767 2011-06-21 Ben Konrath <ben@bagu.org>
2769 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2771 This makes things more inline with how libglom works and reduces code
2772 duplication. This refactor lays the groundwork for adding the primary key to
2773 the LayoutGroup object.
2775 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2776 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2778 Change method names to getListLayout and getDefaultListLayout for
2779 consistency. Use LayoutGroup as the DTO for the list layout instead of
2780 ColumnInfo and LayoutListTable.
2781 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2782 new method names along with the LayoutGroup object for transferring the
2784 * src/main/java/org/glom/web/client/ui/ListView.java:
2785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2786 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2787 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2789 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2790 Replaced with LayoutGroup.
2791 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2792 expectedResultSize and defaultTableName fields which are needed for
2794 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2795 type field which is needed for the list layout but will also be
2796 useful for the details layout as things progress.
2797 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2798 Make class abstract. Remove the unnecessary
2799 getFormattingHorizontalAlignment method. Add setFormatting method.
2801 2011-06-16 Ben Konrath <ben@bagu.org>
2803 Add scripts for building and installing war.
2805 These will help when updating OnlineGlom but they're also good
2806 supplemental documentation of the build and deployment proceeding.
2808 * utils/build-onlineglom-war.sh: New file.
2809 * utils/install-onlineglom-war.sh: New file.
2811 2011-06-16 Ben Konrath <ben@bagu.org>
2813 Create wrapper class to create consistent log messages.
2815 I wrapped methods in the Log class of gwt-log to add the method names
2816 from the servlet and create consistent formatting of the document title
2817 and table names in the log messages.
2819 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2820 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2821 log methods to use methods from wrapped Log class.
2823 2011-06-16 Ben Konrath <ben@bagu.org>
2825 Remove superfluous conditional return.
2827 Thanks to Murray Cumming for pointing this out!
2829 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2831 2011-06-15 Ben Konrath <ben@bagu.org>
2833 Return an ArrayList of LayoutGroups for the Details layout.
2835 This corrects a problem with the details layout as it can have more
2836 than one top level LayoutGroup.
2838 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2839 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2840 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2841 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2842 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2843 with ArrayList of LayoutGroups for the details view layout.
2844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2845 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2846 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2847 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2848 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2849 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2851 2011-06-14 Ben Konrath <ben@bagu.org>
2853 Use cast_dynamic method to determine the libglom LayoutItem type.
2855 This is better than finding the LayoutItem type by using the string
2856 returned from the get_part_type_name() method.
2858 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2860 2011-06-14 Ben Konrath <ben@bagu.org>
2862 Add method names to log entries in the servlet.
2864 This helps when tracking down deployment problems.
2866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2868 2011-06-14 Ben Konrath <ben@bagu.org>
2870 Add data to the DetailsView using a hard-coded primary key value.
2872 The layout and functionality of the DetailsView is not complete. This
2873 is just a checkpoint so the patch doesn't get too big.
2875 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2876 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2877 Add getDetailsData() servlet method.
2878 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2879 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2880 LayoutFields are added to the DetailsView.
2881 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2882 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2883 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2884 take the string for the title instead of the object.
2885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2886 Add implementation getDetailsData() along with some private helper
2888 * src/main/webapp/style.css: Add padding to details-data class. Add a
2889 details-label class with the same padding as the details-data class.
2891 2011-06-03 Ben Konrath <ben@bagu.org>
2893 Use presenter.goTo() to change to the DetailsPlace.
2895 This will make things easier when we need to open the DetailsView with
2896 data specific to the row that was clicked.
2898 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2900 2011-06-02 Ben Konrath <ben@bagu.org>
2902 Add CSS file from mockups.
2904 I'm adding this now because it's going to be useful to have when
2905 developing the DetailsView. The TableSelectionView and ListView aren't
2908 * src/main/webapp/OnlineGlom.html:
2909 * src/main/webapp/style.css:
2911 2011-06-02 Ben Konrath <ben@bagu.org>
2913 Use String.isEmpty() to check for empty string.
2915 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2917 2011-06-02 Ben Konrath <ben@bagu.org>
2919 Display main layout group titles in the DetailsView.
2921 This is the start of the DetailsActivity/DetailsView implementation.
2923 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2924 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2925 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2926 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2927 Get the layout information for the details view from the server and set
2928 the main layout group titles.
2929 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2930 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2931 Add addLayoutGroup() and addLayoutField() methods. This are just
2932 temporary methods for creating the the details view that will change
2934 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2935 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2937 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2938 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2939 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2940 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2941 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2942 Data Transfer Objects that mimic the libglom object structure. These are
2943 used for transferring the details layout but could also be used for
2944 transferring the list layout.
2946 2011-05-27 Ben Konrath <ben@bagu.org>
2948 Reset the AuthenticationPopup when clearing the ListView.
2950 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2952 2011-05-27 Ben Konrath <ben@bagu.org>
2954 Fix problem with onlineglom.properties file loading.
2956 The old way worked in Eclipse but not on the server. Loading the
2957 onlineglom.properties file now works in Eclipse and on the server.
2959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2961 2011-05-24 Ben Konrath <ben@bagu.org>
2963 Update gwt-log from 3.1.0 to 3.1.2.
2965 Gwt-log 3.1.0 has been marked as depreciated.
2969 2011-05-24 Ben Konrath <ben@bagu.org>
2971 Add comment to ListActivity.goTo() method.
2973 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2975 2011-05-24 Ben Konrath <ben@bagu.org>
2977 Remove FIXME in convertGdkColorToHtmlColour()
2979 The Gdk::Color value returned by libglom is 16-bits per channel on both
2980 64 and 32-bit platforms.
2982 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2984 2011-05-19 Ben Konrath <ben@bagu.org>
2986 Improve performance of initial ListView load.
2988 I removed a round trip to the server for getting the default table name
2989 and then requesting information about that table. This also removes a potential
2990 problem with the table change handler not being setup in time to receive the
2991 table change event from the ListActivity.
2993 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2994 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2995 getDefaultLayoutListTable() method. Improve comments.
2996 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2997 getDefaultLayoutListTable() method instead of firing a table change
2998 event to get the table to load.
2999 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3000 implementation of getDefaultLayoutListTable() method.
3001 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3004 2011-05-19 Ben Konrath <ben@bagu.org>
3006 Override toDebugString() in TableChangeEvent.
3008 This is useful to have for debugging.
3010 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3012 2011-05-19 Ben Konrath <ben@bagu.org>
3014 Add a "Back to List" link when at the DetailsPlace.
3016 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3017 Populate the CellTable based on the selected table of the ListBox if
3018 it's set otherwise use the default table. This allows the "Back to
3020 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3021 Remove Place from constructors. Add a setPlace() method. Add
3022 goToPlace() method. Set class as presenter for TableSelectionView.
3023 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3024 Use the same TableSelectionActivity when switching between the List and
3026 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3027 Subclass the new HasSelectableTablePlace. This removes some duplicate
3029 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3030 New class to represent Places that display the TableSelectionView.
3031 * src/main/java/org/glom/web/client/place/ListPlace.java:
3032 Subclass the new HasSelectableTablePlace. This removes some duplicate
3034 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3035 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3036 Add Presenter interface. Add setBackLinkVisible() method. Add
3037 setBackLink() method.
3039 2011-05-18 Ben Konrath <ben@bagu.org>
3041 Enable the "Details" buttons.
3043 Right now only an empty details view is displayed.
3045 * src/main/java/org/glom/web/client/ClientFactory.java:
3046 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3047 Add DetailsView to ClientFactory.
3048 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3049 A basic activity for the details view.
3050 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3051 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3053 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3054 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3056 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3057 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3058 unnecessary super() in constructor.
3059 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3060 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3061 really shouldn't create a new TableSelectionActivity for both the ListPlace
3062 and the DetailsPlace so this should be considered a temporary solution.
3063 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3064 New file. Represents a URL for the details view.
3065 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3066 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3067 A basic details view interface and implementation.
3068 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3069 Enable the "Details" buttons.
3071 2011-05-12 Ben Konrath <ben@bagu.org>
3073 Use a LayoutPanel with multiple display areas for main layout.
3075 This is mostly a refactor in that there are no changes from the user
3076 point of view. These changes are required so that we can swap out the list view
3077 with the details view when the user clicks the "Details" button.
3079 * src/main/java/org/glom/web/client/ClientFactory.java:
3080 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3081 OnlineGlomView. Add TableSelectionView, ListView and
3082 AuthenticationPopup.
3083 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3084 for main layout. Add display regions for main activities. Add
3085 activity manager for for main activities.
3086 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3087 file from parts of the deleted OnlineGlomActivity.
3088 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3089 New file from parts of the deleted OnlineGlomActivity.
3090 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3091 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3092 New files for app wide table change event.
3093 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3094 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3095 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3096 Activity mappers for the main activities replace the deleted app-wide
3098 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3099 Fix a spelling error in he comment.
3100 * src/main/java/org/glom/web/client/ui/ListView.java:
3101 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3102 Renamed from LayoutListView and modified for MVP. This still not a
3103 proper dumb view as prescribed by the MVP pattern but it works for now.
3104 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3105 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3106 New widget stripped out of the deleted OnlineGlomView.
3107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3108 Remove hack that is fixed by this patch.
3110 2011-05-06 Ben Konrath <ben@bagu.org>
3112 Rename OnlineGlomPlace to ListPlace.
3114 The only change besides the rename is that url will now display #list
3115 instead of #Document.
3117 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3118 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3119 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3120 * src/main/java/org/glom/web/client/place/ListPlace.java:
3121 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3123 2011-05-06 Ben Konrath <ben@bagu.org>
3125 Use Presenter for app navigation.
3127 This is the proper way to deal with Place (URL) changes with the MVP
3130 * src/main/java/org/glom/web/client/ClientFactory.java:
3131 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3132 PlaceHistoryMapper and PlaceHistoryHandler.
3133 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3134 PlaceHistoryMapper and PlaceHistoryHandler.
3135 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3136 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3137 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3138 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3139 Add Presenter interface and setPresenter methods. Rename addHyperLink
3140 to addDocumentLink taking only the document title as a parameter.
3142 2011-04-14 Ben Konrath <ben@bagu.org>
3144 Prompt for db username/password if they haven't been set.
3146 This is implemented with a popup widget that is contained within the
3147 OnlineGlomView and managed by the OnlineGlomActivity.
3149 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3150 methods for checking and setting the database username and password.
3151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3152 new methods for checking and setting the database username and
3154 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3155 Display authentication popup if the JDBC connection to the database
3156 has not been authenticated.
3157 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3159 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3160 for dealing with the authentication popup.
3161 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3162 Implement the methods for dealing with the authentication popup.
3163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3164 try to executed queries if the database connection hasn't been
3165 authenticated. Implement methods for checking and setting the
3166 database username and password.
3168 2011-04-12 Ben Konrath <ben@bagu.org>
3170 Make log messages a little clearer.
3172 Add a dash betweeen the document title and the table name.
3174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3176 2011-04-12 Ben Konrath <ben@bagu.org>
3178 Protect against NPEs when cleaning up database resources.
3180 While this isn't strictly necessary because the exception is caught,
3181 not protecting against the NPEs makes it harder to find the real error
3184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3186 2011-04-12 Ben Konrath <ben@bagu.org>
3188 Move configuration of the servlet to the constructor.
3190 The servlet will be initialized even if the database authentication
3191 information is not set or correct. I still need to add the UI for prompting
3192 the user for the authentication information when it's required.
3194 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3195 javadocs for getDocumentTitles() method.
3196 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3197 Set error message when RPC fails.
3198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3199 glom files directory from the configuration file. Try to set the
3200 database authentication information for the specific document if it's
3201 set and works otherwise try to use the global authentication
3202 information set for the directory.
3203 * src/main/resources/onlineglom.properties: Moved from
3204 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3205 Added detailed comments for the new keys.
3207 2011-04-11 Ben Konrath <ben@bagu.org>
3209 Remove unnecessary @Override in DocumentSelectionViewImpl.
3211 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3213 2011-04-11 Ben Konrath <ben@bagu.org>
3215 Remove center alignment in DocumentSelectionView.
3217 The title element is still centred but the document titles and bottom
3218 sentence are both left-aligned.
3220 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3222 2011-04-11 Ben Konrath <ben@bagu.org>
3224 Change 'Demo' naming convention to 'Document'.
3226 This is just a rename refactor with no functional changes to the code.
3228 * src/main/java/org/glom/web/client/ClientFactory.java:
3229 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3230 * src/main/java/org/glom/web/client/OnlineGlom.java:
3231 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3232 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3233 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3234 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: