1 2012-11-15 Murray Cumming <murrayc@murrayc.com>
3 Details: Get static image data from our images services.
5 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
6 Add constructors for LayoutItemText and LayoutItemImage and
7 deal with their common type instead of just LayoutItemField.
9 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
11 * src/main/java/org/glom/web/client/ui/details/Group.java:
12 createChildWidget(): Use the other DetailsCell constructors for
13 these layout items, and do not add them to the list of
14 cells with data from the database.
15 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
16 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
17 Remove the image data when cloning the layout and storing it in the
18 cache. Clients will instead get it via the URL, from
20 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
21 doGet(): Depending on the URI parameters, optionally get
22 image data from a layout_item_image in the document,
24 * src/main/java/org/glom/web/server/database/DBAccess.java:
25 convertResultSetToDTO(): Move some URIBuilder code to:
26 * src/main/java/org/glom/web/server/Utils.java:
27 Add buildImageDataUrl() taking the primary key, etc, to
28 get data from the database.
30 2012-11-15 Murray Cumming <murrayc@murrayc.com>
32 Document: Static image items: Store an image URL, using the layout path.
34 * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
35 * src/main/java/org/glom/web/server/libglom/Document.java:
36 Add a constructor that takes the documentID, for use in the
38 loadLayoutNode(): Pass a Path object to the helper methods, so we
39 can use it to create a URL for LayoutItemImage items.
40 This seems as good a way as any to specify a layout item in the document.
41 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
42 Pass the documentID to the constructor, for use in the LayoutItemImage
45 2012-11-15 Murray Cumming <murrayc@murrayc.com>
47 Document: Add getLayoutItemByPath().
49 * src/main/java/org/glom/web/server/Utils.java:
50 Add buildLayoutPath() and parseLayoutPath().
51 * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these
53 * src/main/java/org/glom/web/server/libglom/Document.java:
54 Add Add getLayoutItemByPath().
55 * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test
58 This will be useful in subsequent commits.
60 2012-11-15 Murray Cumming <murrayc@murrayc.com>
62 Need a short description (OOPS!).
63 Need the bug URL (OOPS!).
65 Reviewed by NOBODY (OOPS!).
67 Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
70 * .settings/com.google.gdt.eclipse.core.prefs:
71 * .settings/com.google.gwt.eclipse.core.prefs:
72 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
73 (DetailsActivity.createLayout):
74 (DetailsActivity.setData):
75 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
77 (DetailsCell.DetailsCell):
78 (DetailsCell.setupWidgets):
79 (DetailsCell.setData):
80 (DetailsCell.getLayoutItem):
81 * src/main/java/org/glom/web/client/ui/details/Group.java:
82 (Group.createChildWidget):
83 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
84 (ConfiguredDocument.getValidListViewLayoutGroup):
85 (ConfiguredDocument.getDetailsLayoutGroup):
87 (ConfiguredDocument.updateLayoutItemImages):
88 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
89 (ConfiguredDocumentSet.getDocumentIdForFilename):
90 (ConfiguredDocumentSet):
91 (ConfiguredDocumentSet.addDocument):
92 (ConfiguredDocumentSet.readConfiguration):
93 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
94 (OnlineGlomImages.OnlineGlomImages):
95 (OnlineGlomImages.doGet):
97 (OnlineGlomImages.getImageFromDocument):
98 (OnlineGlomImages.getImageFromDatabase):
99 * src/main/java/org/glom/web/server/Utils.java:
101 (Utils.buildImageDataUrl):
102 (Utils.buildImageDataUrlStart):
103 (Utils.buildLayoutPath):
104 (Utils.parseLayoutPath):
105 * src/main/java/org/glom/web/server/database/DBAccess.java:
106 (DBAccess.convertResultSetToDTO):
107 * src/main/java/org/glom/web/server/libglom/Document.java:
111 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
112 (DocumentTest.TestThread.run):
114 2012-11-15 Murray Cumming <murrayc@murrayc.com>
116 Document: Use a better base64 decoder to read static image data.
118 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
119 getNodeTextChildAsValue(): Use the apache commons base64 decoder
120 instead of the gwt one, because it correctly decodes the strings
121 from g_base64_encode(). It is probably more correct.
122 The newlines might be confusing the gwt decoder.
124 2012-11-14 Murray Cumming <murrayc@murrayc.com>
126 Document: Do not use == to compare strings. Use equals().
128 * src/main/java/org/glom/web/server/libglom/Document.java:
129 == only checks that they are the same object, so it can
132 2012-11-14 Murray Cumming <murrayc@murrayc.com>
134 Document: Add and use public constants for layout names.
136 * src/main/java/org/glom/web/server/libglom/Document.java:
137 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
138 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
139 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
140 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
141 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
142 them here instead of hard-coded the strings repeatedly.
144 2012-11-13 Murray Cumming <murrayc@murrayc.com>
146 Document: Load static text and image items too.
148 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
149 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
150 New LayoutItem classes to represent these layout items.
151 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
152 main text of a LayoutItemText.
153 * src/main/java/org/glom/web/server/libglom/Document.java:
154 load_after_layout_group(): Handle the node types and instantiate the
156 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
157 Add testLayoutItemText() to check that the text is loaded properly.
159 2012-11-13 Murray Cumming <murrayc@murrayc.com>
161 Do not use client.GWT for shared code.
163 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
164 Import shared.GWT instead of client.GWT, which seems to be appropriate.
166 2012-11-12 Murray Cumming <murrayc@murrayc.com>
168 Use image data when recreating databases for testing.
170 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
171 for use locally (not acrosss the network) when recreating databases
173 getValue(): Use it here instead of getImageDataUrl(), noting that
174 this method is only for use when recreating databases.
175 * src/main/java/org/glom/web/server/libglom/Document.java:
176 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
178 2012-11-09 Murray Cumming <murrayc@murrayc.com>
180 OnlineGlomImages: Detect the mime-type (content type).
182 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
183 doGet(): Instead of hard-coding image/png.
185 2012-11-09 Murray Cumming <murrayc@murrayc.com>
187 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
190 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
191 Java Compiler and Java Build path settings in the UI.
193 2012-11-09 Murray Cumming <murrayc@murrayc.com>
195 Use the latest (now stable) version of GWT.
197 * pom.xml: And the latest version of the gwt-maven-plugin.
199 2012-11-08 Murray Cumming <murrayc@murrayc.com>
201 Added an Indonesian translation.
203 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
204 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
205 This is from the new translation in Glom.
207 2012-07-23 Murray Cumming <murrayc@murrayc.com>
209 Details: Show images.
211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
213 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
214 so it can be used in:
215 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
216 for serving image data.
217 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
219 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
220 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
221 setData(): For image field types, add a GWT Image widget,
222 with the URL that was set in the DataItem.
224 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
225 * src/main/java/org/glom/web/server/database/DBAccess.java:
226 convertResultSetToDTO(): Set the URL for image data, so the client browser
227 can retrieve the image from our new servlet. This uses UriBuilder.
228 Move getPrimaryKeyField to:
229 * src/main/java/org/glom/web/server/libglom/Document.java:
230 Added getTablePrimaryKeyField().
232 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
233 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
234 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
237 2012-07-22 Murray Cumming <murrayc@murrayc.com>
241 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
242 * src/main/java/org/glom/web/client/OnlineGlomService.java:
243 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
244 to gwtGlom, which is more appropriate.
245 This servlet name does not seem to be visible to the client side anyway.
247 2012-07-22 Murray Cumming <murrayc@murrayc.com>
249 Tests: Make the imports of assert*() consistent.
251 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
252 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
253 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
254 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
255 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
256 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
257 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
258 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
259 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
260 * src/test/java/org/glom/web/shared/DataItemTest.java:
262 import static org.junit.Assert.*;
263 which seems fairly common.
267 2012-07-21 Murray Cumming <murrayc@murrayc.com>
269 tests: Move a test that needs a database connection.
271 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
272 Move testGetListViewLayoutGroup() to
273 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
274 because it needs a database connection.
276 2012-07-21 Murray Cumming <murrayc@murrayc.com>
278 tests: Use @BeforeClass on tearDown().
280 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
281 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
282 This avoids leaking a postgres process in SelfHostExampleTest.
284 2012-07-21 Murray Cumming <murrayc@murrayc.com>
286 tests: Test translations more.
288 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
289 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
290 Test titles in the non-default locale.
292 2012-07-21 Murray Cumming <murrayc@murrayc.com>
294 tests: Add SelfHostConfiguredDocumentTest
296 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
297 username and password, for use by ConfiguredDocument.
298 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
299 This tests some of the ConfiguredDocument API that requires a database connection.
301 2012-07-21 Murray Cumming <murrayc@murrayc.com>
303 Document: Load title translations and test them.
305 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
306 of titles. I am surprised that we do not do this yet.
307 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
308 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
309 Test translations more.
311 2012-07-20 Murray Cumming <murrayc@murrayc.com>
315 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
316 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
317 Set the timeout here too.
319 2012-07-20 Murray Cumming <murrayc@murrayc.com>
321 tests: ConfiguredDocumentTest: Make this pass.
323 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
324 Disable tests that need a database connection.
326 2012-07-20 Murray Cumming <murrayc@murrayc.com>
328 Use Java 1.7 instead of Java 1.6.
330 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
331 to do this twice, at least for Eclipse.
332 This seems OK because it is the current version.
334 2012-07-20 Murray Cumming <murrayc@murrayc.com>
338 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
339 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
340 Avoid using a null Connection.
342 2012-07-20 Murray Cumming <murrayc@murrayc.com>
344 tests: Add a ConfiguredDocument test.
346 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
349 2012-07-20 Murray Cumming <murrayc@murrayc.com>
351 LayoutItemFIeld: getName(): Use the Field if it is set.
353 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
354 getName(): If the full field details have been set, return its name, so that
355 callers do not need to set the name separately.
356 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
357 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
358 so we can count the rows.
360 2012-07-20 Murray Cumming <murrayc@murrayc.com>
362 tests: SelfHoster: Test SqlUtils too.
364 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
365 Retrieve some data and check it too, as in the regular Glom
366 test_selfhosting_new_from_example.cc test.
367 * src/test/java/org/glom/web/server/SelfHoster.java:
368 createConnection(): Make this public.
370 2012-07-20 Murray Cumming <murrayc@murrayc.com>
372 tests: SelfHoster: createConnection(): Do not warn about expected failures.
374 Let the caller say if the connection is expected to fail, to avoid
375 irrelevant error output.
377 2012-07-20 Murray Cumming <murrayc@murrayc.com>
379 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
381 * src/test/java/org/glom/web/server/SelfHoster.java:
382 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
383 due to the inevitable need to retry the connection while the database server
386 2012-07-20 Murray Cumming <murrayc@murray.com>
388 tests: SelfHoster: createConnection(): Set a timeout.
390 * src/test/java/org/glom/web/server/SelfHoster.java:
391 createConnection(): Use setLoginTimeout() because it otherwise seems to take
392 ages to actually return when it fails.
394 2012-07-20 Murray Cumming <murrayc@murrayc.com>
396 tests: SelfHoster: selfHost(): Close the test connection.
398 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
399 When we check that the connection works, close the connection. This seems
400 to not be closed automatically otherwise.
402 2012-07-20 Murray Cumming <murrayc@murrayc.com>
404 Use slf4j-simple to see JDBC errors.
406 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
408 2012-07-19 Murray Cumming <murrayc@murrayc.com>
410 SelfHoster.discoverFirstFreePort(): Close the socket.
412 * src/test/java/org/glom/web/server/SelfHoster.java:
413 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
415 2012-07-19 Murray Cumming <murrayc@murrayc.com>
417 Avoid another code warning in Eclipse Juno.
419 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
420 Do instanceof checks on the FileUtils.listFiles() result and its
423 2012-07-13 Murray Cumming <murrayc@murrayc.com>
425 Avoid some code warnings in Eclipse Juno
427 * src/main/java/org/glom/web/server/libglom/Document.java:
428 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
429 * src/test/java/org/glom/web/server/SelfHoster.java
430 createTextFile(): Make sure that the FileOutputStream is closed.
432 2012-06-22 Murray Cumming <murrayc@murrayc.com>
434 Added OnlineGlomPropertiesTest.
436 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
437 Make sure we never return a null string.
438 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
439 Added tests of the OnlineGlomProperties API, using our sample file.
441 2012-06-20 Murray Cumming <murrayc@murrayc.com>
443 Make OnlineGlomProperties be a normal class.
445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
446 Move OnlineGlomProperties into its own file to be a regular class:
447 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
448 This makes testing simpler.
450 2012-06-15 Murray Cumming <murrayc@murrayc.com>
452 OnlineGlomServiceImpl.init(): Move some code into a new method.
454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
455 Create addDocument().
457 2012-06-15 Murray Cumming <murrayc@murrayc.com>
459 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
462 OnlineGlomProperties.getKey(): Make this more robust by moving the
463 check for *.*.filename to here.
465 2012-06-15 Murray Cumming <murrayc@murrayc.com>
467 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
469 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
470 init(): Move knowledge of the config file format into the
471 OnlineGlomProperties inner class.
473 2012-06-15 Murray Cumming <murrayc@murrayc.com>
475 SelfHostExampleTest: Make sure we cleanup on failure.
477 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
478 the use of cleanup() to a tearDown() JUnit method.
482 2012-06-12 Murray Cumming <murrayc@murrayc.com>
484 ConfiguredDocument: Add a primary key to portals at least once.
486 * src/main/java/org/glom/web/server/ConfiguredDocument.java
487 updatePortalsExtras): Fix a typo so that we add the primary key
488 column at least once.
489 This is a fix for the previous commit:
490 ConfiguredDocument: Do not add a primary key to portals each time.
492 2012-06-08 Murray Cumming <murrayc@murrayc.com>
494 SelfHoster: Avoid some compiler warnings.
496 * src/test/java/org/glom/web/server/SelfHoster.java
497 executeCommandLineAndWait():
498 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
499 the now-unused streams for stdout and stderr from the command Processes.
500 These are not used because readln() hangs while waiting for a new line,
501 where there may be no next line. The commented out code is still there
502 to help us figure out how to do this properly.
504 2012-06-08 Murray Cumming <murrayc@murrayc.com>
506 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
508 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
509 Make this actually test the cloning again, though it is not very useful
510 now that we do not use the part that had a problem with cloning before.
512 2012-06-08 Murray Cumming <murrayc@murrayc.com>
514 SelfHoster: Keep trying pg_ctl after starting postgres.
516 * src/test/java/org/glom/web/server/SelfHoster.java
517 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
518 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
519 regular Glom. This seems mad but it seems to work because the first
520 command would fail if pg_ctl would eventually fail.
522 2012-06-08 Murray Cumming <murrayc@murrayc.com>
524 SelfHoster: Wait until the server is really ready.
526 * src/test/java/org/glom/web/server/SelfHoster.java
527 selfHost(): Attempt the connection after starting the server, retrying
528 a few times if necessary, so that the server is really ready already when
529 we return from this method.
530 The regular Glom code does this too because pg_ctl reports success too soon.
532 2012-06-08 Murray Cumming <murrayc@murrayc.com>
534 ConfiguredDocument: Do not add a primary key to portals each time.
536 * src/main/java/org/glom/web/server/ConfiguredDocument.java
537 updatePortalsExtras(): Only add an extra primary key field if there is
538 none, to avoid adding one each time we retrieve the details layout from the
540 This should fix bug #676986 (Ben Konrath)
542 2012-05-25 Murray Cumming <murrayc@murrayc.com>
544 Document.load(): Support version 7 documents.
546 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
547 database_title attribute if the title attribute is not there.
550 2012-05-24 Ben Konrath <ben@bagu.org>
552 Add configuration for auto-generating mvn:i18n from with Eclipse.
554 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
556 2012-05-24 Murray Cumming <murrayc@murrayc.com>
558 Update translations, adding French.
560 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
561 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
562 Add a French translation, using the translation from Glom.
564 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
565 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
566 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
567 Update these based on the translations from Glom.
569 2012-05-24 Murray Cumming <murrayc@murrayc.com>
571 SelfHoster: Add some debug println messages to help when things fail.
573 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
574 System.out.println() lines.
576 2012-05-23 Murray Cumming <murrayc@murrayc.com>
578 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
580 * src/test/java/org/glom/web/server/SelfHoster.java:
581 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
582 instance) instead of just /usr/bin (as on Fedora). Check the result when
585 2012-05-23 Murray Cumming <murrayc@murrayc.com>
587 Remove LayoutItemPortal.get/setNavigationTable().
589 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
590 Remove get/setNavigationTable(), which is only a cache, because it is not
591 used, and does not need to be used, because that decision should be made on
593 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
594 updatePortalsExtras():
595 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
596 getNavigationRecord():
597 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
600 2012-05-21 Murray Cumming <murrayc@murrayc.com>
602 Initial self-hosting for tests.
604 * pom.xml: Change the scope for log4j, to hopefully make it
605 available to the test code which uses it indirectly via jOOQ.
606 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
607 self-hosting, though we only use it for testing.
609 * src/main/java/org/glom/web/server/libglom/Document.java:
610 example rows: Use a map instead of a list for each row of values,
611 so we know what field they are for, instead of relying on the sequence
612 being correct. This is not very efficient, but it does not really need
614 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
615 testReadTableExampleRows(): Adapted.
617 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
618 that returns an Object, for generic use. Note that Object seems to be
619 the implicit base even of double.
620 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
621 for use in CREATE TABLE SQL queries.
622 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
623 to do self-hosting of PostgreSQL databases via its command-line
624 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
625 backends/postgres_self.cc. This is incomplete - it needs more
626 warnings about failures and it needs to clean up properly when things
628 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
629 test of this new class.
631 2012-05-21 Murray Cumming <murrayc@murrayc.com>
633 Document: loading example data: Handle exceptions.
635 * src/main/java/org/glom/web/server/libglom/Document.java:
636 DateFormat.parse() and Double.valueOf() can throw exceptions, though
637 Eclipse did not warn about that.
639 2012-05-20 Murray Cumming <murrayc@murrayc.com>
641 Document: load(), save(): Handle the example rows.
643 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
645 * src/main/java/org/glom/web/server/libglom/Document.java:
646 load(), save(): Load and save the example rows, though the date, time
647 and image types are not handled properly yet.
648 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
649 Add testReadTableExampleRows() just to check that something is read.
651 2012-05-20 Murray Cumming <murrayc@murrayc.com>
653 Document: Add save().
655 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
656 Added getTranslationsMap() for use while saving.
657 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
658 Adedd getUseDefaultFormatting() for use while saving.
659 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
660 and several private methods that it uses.
662 This will be useful while testing via self-hosting.
663 It is not complete, but should be complete enough for testing.
665 2012-05-17 Murray Cumming <murrayc@murrayc.com>
667 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
669 * src/main/java/org/glom/web/client/OnlineGlomService.java
670 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
671 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
672 Remove getSortedListViewData() and getSortedRelatedListData(), adding
673 the sort column index and ascending bool to the regular method.
674 Instead, a sort column index of -1 now means no sort.
675 This is less explicit, but it's fairly simple, reduces the amount of
676 code, and makes the OnlineGlomService API slightly smaller.
677 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
678 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
680 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
681 getListViewData(), getRelatedListData():
682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
683 getListViewData(), getRelatedListData():
684 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
686 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
688 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
693 2012-05-16 Murray Cumming <murrayc@murrayc.com>
695 Use translations for top-level groups too.
697 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
698 updateTitlesForLocale(): Use the translation for the group
699 as well as for child items.
703 Just recompiled to fix a problem in the released .tar.gz file.
707 2012-05-15 Murray Cumming <murrayc@murrayc.com>
709 Corrections to navigation to related records.
711 * src/main/java/org/glom/web/client/OnlineGlomService.java:
712 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
713 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
714 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
715 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
716 relationship name, because the relationship name is not necessarily unique
718 TOOD: This is inefficient, because it passes the whole list of
719 child field items back to the server, but it is more correct, and happens
720 to fix a bug with the primary key being lost after a few navigations.
721 There is probably a chance to make this more efficient anyway in some
724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
725 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
726 * src/main/java/org/glom/web/server/ConfiguredDocument.java
727 * src/main/java/org/glom/web/server/database/DBAccess.java
728 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
729 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
732 2012-05-15 Murray Cumming <murrayc@murrayc.com>
734 Fix the use of translations.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
737 Add updateTitlesForLocale().
738 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
739 Call it to discard unwanted translations and to make getTitle() return
740 the wanted translation wihout the need for the client code to specify a locale.
741 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
742 getTitle(): Fallback to the original title, as libglom does.
744 2012-05-15 Murray Cumming <murrayc@murrayc.com>
746 Document: Correctly report the number of available translation locales.
748 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
749 the available locale IDs list.
750 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
751 testLocales: Test this.
753 2012-05-15 Murray Cumming <murrayc@murrayc.com>
755 SqlUtils: Use camelCase.
757 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
758 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
759 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
760 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
761 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
762 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
764 2012-05-15 Murray Cumming <murrayc@murrayc.com>
766 Use jOOQ's tableByName() and fieldByName.
768 * pom.xml: Use jOOQ 2.3.1 to get the new API.
769 * src/main/java/org/glom/web/server/SqlUtils.java:
770 build_sql_select_step_with_where_clause(), .createField(),
771 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
772 so we can get correct quoting and escaping. Thanks to Lukas Eder for
773 adding this, and other things, to jOOQ.
775 2012-05-15 Murray Cumming <murrayc@murrayc.com>
777 SqlUtils: Remove the Connection parameters.
779 * src/main/java/org/glom/web/server/SqlUtils.java:
780 build_sql_select_with_key(), build_sql_select_with_where_clause(),
781 createSelect(), build_sql_select_step_with_where_clause(),
782 build_sql_count_select_with_where_clause(),
783 build_sql_select_count_rows(): Remove the Connection parameter because
784 jOOQ does not actually need a connectionwhen it is just used to build
786 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
788 * src/main/java/org/glom/web/server/ReportGenerator.java:
790 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
792 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
793 Constructor, getListData(), getResultSizeOfSQLQuery():
794 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
795 getSelectQuery(), getCountQuery():
796 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
797 getSelectQuery(), getCountQuery():
798 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
799 getNavigationRecord(): Adapted.
801 2012-05-14 Murray Cumming <murrayc@murrayc.com>
805 * src/main/java/org/glom/web/server/SqlUtils.java:
806 get_find_where_clause_quick(): Use a comparison of
807 lowercase values, instead of a simple equals. Regular Glom
808 uses the PostgreSQL ILIKE operator but jOOQ does not
809 support that just yet, though it will soon.
811 2012-05-14 Murray Cumming <murrayc@murrayc.com>
813 TableToViewDetails: Use a real serialization ID.
815 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
816 Though this does not fix the serialization problem.
818 2012-05-12 Murray Cumming <murrayc@murrayc.com>
820 Added LayoutItemPortalDeepCloneTest.
822 2012-05-11 Murray Cumming <murrayc@murrayc.com>
824 Make navigation work again.
826 * src/main/java/org/glom/web/server/libglom/Document.java:
827 Add getLayoutItemFieldShouldHaveNavigation().
828 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
829 Replace get/setAddNavigation() with the partly-existing
830 get/setNavigationTableName(), with an empty string being no navigation,
831 because this is simpler. Use the new
832 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
834 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
835 Add updateFieldsExtras() and call setNavigationTableName in it.
836 getDetailsLayoutGroup(),
837 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
838 createLayout(): Adapted.
839 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
840 Constructor: Adapted.
842 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
843 Replace get/setAddNavigation() with get/setNavigation(), returning a
844 TableToViewDetails class with both the table name and UsesRelationship,
845 because both are need. The previous code used java-libglom's output
846 variable (strangely, via sharedptr) to return both, but we cannot really
848 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
849 getNavigationRecord(): Adapt. However, we cannot actually use the cache
850 here because it somehow gets set to null during deepCopy(). I must test this.
851 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
852 testGetSuitableTableToViewDetails(): Adapted.
854 TODO: Find out why deepClone() is not quite working.
856 2012-05-11 Murray Cumming <murrayc@murrayc.com>
858 DBAccess: Simplify the retrievel of full field details.
860 * src/main/java/org/glom/web/server/database/DBAccess.java
861 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
862 because the Document loading should have done this.
864 2012-05-11 Murray Cumming <murrayc@murrayc.com>
866 Document: Correct loading of doubly-related layout fields.
868 * src/main/java/org/glom/web/server/libglom/Document.java:
869 loadUsesRelationship(): Actually set the related relationship, instead
870 of only setting it if it's not found.
872 2012-05-09 Murray Cumming <murrayc@murrayc.com>
874 Replace all appearances of Colour with color.
876 Because US English is dominant.
878 2012-05-09 Murray Cumming <murrayc@murrayc.com>
880 Use colors in HTML format, solving a warning about an unused function.
882 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
883 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
884 Add *asHTMLColor() versions of methods.
885 TODO: However, we should create and cache the results on the server.
886 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
887 * src/main/java/org/glom/web/client/ui/list/ListTable.java
888 * src/main/java/org/glom/web/server/ConfiguredDocument.java
889 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
890 Use the asHTMLcolor() versions.
892 2012-05-09 Murray Cumming <murrayc@murrayc.com>
894 ListViewTable: Constructor: Take the table name as a parameter.
896 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
897 Constructor: Take the tableName, and set the member variable, because
899 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
900 setCellTable(): Pass the table name.
901 This makes navigation to non-default tables work again. I don't know
902 why it worked before in the master branch.
904 2012-05-07 Murray Cumming <murrayc@murrayc.com>
906 ConfiguredDocument: Restore correct addition of hidden primary key items.
908 * src/main/java/org/glom/web/client/ui/list/ListTable.java
909 (ListTable.createCellTable): Uncomment out the check for the hidden
911 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
912 add primary key items for top-level lists and portals, as before,
913 instead of adding them to each group.
914 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
915 Actually implement the extra methods such as setHiddenPrimaryKey() and
916 comment that these are used only for top-level list groups and in portals.
917 This strangeness suggests even more that this should not be squeezed
918 into the LayoutGroup class.
920 2012-05-07 Murray Cumming <murrayc@murrayc.com>
922 Fix Formatting loading.
924 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
925 getFormattingUsed(): Remove the duplicate Formatting member variable
926 in favour of the one from the base class.
927 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
928 Initialize a new Formatting instead of using null by default, so we
929 have some defaults, instead of having to initialize one later just to
930 get the same defaults. This also makes loading of formatting from the
931 document work, because that expected a non-null.
933 2012-05-07 Murray Cumming <murrayc@murrayc.com>
935 RelatedListTable: Make sure that the tableName is set.
937 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
938 Constructor: Take the tableName so it is available later. Otherwise,
939 the server assumes that we mean the default table and cannot find the
941 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
942 setData(): Pass the tableName to the RelatedListTable constructor.
944 2012-05-07 Murray Cumming <murrayc@murrayc.com>
948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
949 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
950 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
952 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
954 * src/main/java/org/glom/web/server/database/DBAccess.java:
955 convertResultSetToDTO(), getPortal():
956 * src/main/java/org/glom/web/server/database/ListDBAccess.java
958 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
959 Add checks for null objects and out of range access, with log messages to
960 give hints so we can fix these properly.
962 2012-05-07 Murray Cumming <murrayc@murrayc.com>
964 Portals: some corrections.
966 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
968 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
969 constructor: Use getRelationshipNameUsed() instead of getName(), because
970 that is what is meant.
971 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
972 getFromField(): Fix a typo, to get the field name, not the table name.
973 * src/main/java/org/glom/web/server/database/DBAccess.java:
974 getPortal(): Fix a typo that stopped this from working.
976 2012-05-07 Murray Cumming <murrayc@murrayc.com>
978 LayoutItemPortal: Also override getTitleOriginal().
980 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
981 This lets the base getTitle() with no parameters work.
982 TODO: Test this properly.
984 2012-05-06 Murray Cumming <murrayc@murrayc.com>
986 LayoutItemPortal: getTitle*(): Use the relationship title.
988 2012-05-06 Murray Cumming <murrayc@murrayc.com>
990 LayoutItemField: Fix loading of custom titles.
992 * src/main/java/org/glom/web/server/libglom/Document.java
993 loadDataLayoutItemField(): The title, if any, instead of the field
994 title, is stored in a title_custom node. Load it from there.
995 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
997 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
998 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
999 getTitle*() overrides.
1000 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1003 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1005 LayoutItemField: Fall back to field titles, so some are really shown.
1007 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1008 Override getTitleOriginal() and getTitle(), as in java-libglom.
1009 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1010 Test this behaviour.
1012 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1014 Correct use of setExpectedResultSize().
1016 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1017 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1018 Use setExpectedResultSize only on top-level groups (for instance, the
1019 list layout) or on child portals (in details views).
1020 Use the correct table name for portals to avoid SQL errors.
1021 Update the expected counts when returning cached layouts.
1023 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1025 Document: Interpret no group column count as 1.
1027 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1028 default, though we now check for this in the UI code anyway.
1030 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1034 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1036 Translatable: Use Hashmap instead of Treemap because GWT supports it.
1038 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1039 The use of Treemap lead to this error from async methods, with no
1041 "The response could not be deserialized"
1043 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1045 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1047 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
1048 when using the Google -> GWT Compile, or
1049 g toolbar button -> GWT Compile Project... feature in Eclipse.
1051 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1053 ListTable.addColumn(): Protect against a null Formatting.
1055 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1056 Create a default Formatting if it is null, because that is the simplest
1059 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1061 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1063 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1064 updateLayoutGroup(): Check that the field is not null.
1066 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1068 ListViewImpl: Protected against a bad cast error.
1070 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1071 onEnterKeyDown(): Do not cast without an instanceof check.
1073 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1075 ListTable: Protect against an out of range error.
1077 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1078 createCellTable(): This is unlikely, but can happen while debugging.
1080 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1082 AsyncMessage onFailure() callbacks: Log the exception message.
1084 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1085 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1086 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1087 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1088 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1089 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1090 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1091 These are useful clues when something is wrong.
1093 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1095 ConfiguredDocument: Avoid a null dereference.
1097 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1098 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
1099 details maps are created.
1101 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1103 Document: Correct the port number parsing.
1105 * src/main/java/org/glom/web/server/libglom/Document.java:
1106 This lets us actually connect to the database and show the document.
1108 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1112 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1113 user-interaction, asking us to load a temporary URL in a browser.s
1114 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1115 which is apparently necessary for testing the service. See the comment.
1116 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1117 Show the exception, if any. This is how I saw the 404 in the HTML in
1120 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1122 DocumentTest: Move the .glom files into the resources directory.
1124 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1125 URI via getResource().
1127 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1129 Document: Remove the FieldIdentifies inner class.
1131 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1132 use the Relationship (though the same function in libglom is maybe
1133 used in other ways) and so this removes a compiler warning.
1135 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1137 Document.load() Remove the error code parameter.
1139 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1140 Remove the parameter. We do not set it yet and it could never have
1141 worked as an output parameter (though maybe it did in java-libglom).
1142 We could use an exception if we really want the failure reason.
1143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1145 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1146 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1148 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1150 Make some inner classes static.
1152 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1154 * src/main/java/org/glom/web/server/ReportGenerator.java
1155 * src/main/java/org/glom/web/server/libglom/Document.java
1156 Make all inner classes static that can be static.
1158 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1160 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1163 init(): We do not use java-libglom any more.
1165 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1167 Remove mentions of java-libglom.
1169 * README: Remove mention of java-libglom, because it no longer needed.
1170 * utils/build-onlineglom-war.sh:
1171 * utils/check-and-recover-tomcat.py:
1172 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1173 useful. Building is now far easier, with no need for jhbuild.
1175 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1177 Fix the build (mvn package)
1179 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1180 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1181 Otherwise the GWT Java->Javascript compilation fails with just this
1182 error, during mvn package or when attempting to view in a browser,
1183 in the GWT developer mode in Eclipse.
1185 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1186 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1187 [INFO] Compiling module org.glom.web.OnlineGlom
1188 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1189 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1190 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1191 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1192 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1193 [INFO] [ERROR] Cannot proceed due to previous errors
1195 It has taken me 2 days to find out what was causing that. After reducing
1196 the code, the compiler eventually showed me the full error message.
1198 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1200 ConfiguredDocument: Cache the cloned and stripped layouts.
1202 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1203 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1204 layout in a map, so we can retrieve it again without rebuilding it.
1206 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1208 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1210 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1212 libglom classes: Implement some auto-generated emthods.
1214 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1216 Add GwtTestOnlineGlomService.
1218 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1219 However, this (and the other GwtTest*) does not seem to run during
1222 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1224 Remove use of unsupported features from client code.
1226 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1227 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1228 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1229 Use our client version of StringUtils instead of the apache commons one.
1231 However, the GWT Javascript compliation still fails.
1233 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1235 Add a Field class and implement some loading of it in Document.
1237 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1239 Initial Document loading implementation, instead of libglom.
1241 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1242 and Translatable classes, and adapt the rest of the code to use them.
1243 However, this is still missing Layout and Field classes and loading.
1245 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1247 Use of jOOQ: Move Field creation into a utility method.
1249 * src/main/java/org/glom/web/server/SqlUtils.java:
1250 This lets us improve it more easily.
1252 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1254 Use of jOOQ: Improve the code to COUNT a sub-select.
1256 * src/main/java/org/glom/web/server/SqlUtils.java:
1257 Move initial query creation into
1258 build_sql_select_step_with_where_clause().
1259 build_sql_select_count_rows(): Use the jOOQ API instead of
1260 concatentating text, because a jOOQ Select*Step is a TableLike,
1261 which is what from() takes.
1263 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1265 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1267 * pom.xml: Depend on jooq.
1268 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1269 methods with jOOQ, based on the C++ implementations in libglom,
1270 with some changes to the logic required by jooQ.
1271 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1273 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1274 * src/main/java/org/glom/web/server/ReportGenerator.java:
1275 * src/main/java/org/glom/web/server/SqlUtils.java:
1276 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1277 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1278 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1279 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1280 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1281 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1282 because jOOQ needs that, though it seems unnecessary.
1284 This is not quite finished. Ideally jOOQ would help us to build
1285 table_name.field_name names, quoting and escaping them properly.
1286 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1288 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1290 Move use of Glom.build_sql*() into a new SqlUtils class.
1292 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1293 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1294 but this will make it easier to start using something other than
1295 libglom or SqlBuilder.
1297 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1299 Update the project URL.
1301 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1303 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1305 Main layout: Use a FlowTable instead of absolute positioning.
1307 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1308 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1309 child panels/widgets must have an absolute position. But that is annoying, so
1310 this adds a FlowTable and puts the child panels in there.
1312 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1314 GwtTestOnlineGlom: Comment out unused code.
1316 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1317 Eclipse has started to say that some code is unused.
1319 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1321 Update to the latest versions of dependencies.
1323 * pom.xml: Update version numbers of dependencies to the latest
1325 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1327 * src/main/java/org/glom/web/server/ReportGenerator.java:
1328 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1329 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1330 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1332 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1333 Modify the imports where necessary.
1335 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1337 Style: Remove overflow:hidden from searchbox
1339 * src/main/webapp/style.css: Because this pushes the Back To Link
1340 label/link on to the next row, which is then hidden due to the
1341 hard-coded (in ems) height.
1343 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1345 Remove some duplicate code.
1347 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1348 getDocumentInfo(): This must have been duplicated during the merge from the
1353 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1355 Reports: Localize the waiting for report message.
1357 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1358 start(): Get the message from the contants.
1359 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1360 Add the string here.
1361 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1362 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1363 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1364 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1365 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1366 Update these files with the English text for newer strings for now.
1368 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1370 Reports: Show a message while waiting for the report.
1372 * src/main/java/org/glom/web/client/ui/ReportView.java
1373 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1374 Add setWaitingText(), to show a message saying that we are
1375 waiting for the report to be ready.
1376 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1377 start(): Call setWaitingText() before calling the async
1380 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1382 ReportGenerator: Specify date and time formats.
1384 * src/main/java/org/glom/web/server/ReportGenerator.java:
1385 createFieldValueElement(): Use the default (and localized)
1386 short formats, though we still need a way to show 4-digit
1387 years without providing the format for every locale.
1388 * src/main/java/org/glom/web/server/database/DBAccess.java:
1389 convertResultSetToDTO(): Use the short formats here too.
1391 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1393 ReportGenerator: Use the correct numeric formatting.
1395 * src/main/java/org/glom/web/server/ReportGenerator.java
1396 createFieldExpression(), createFieldValueElement(): Take the
1397 whole LayoutItem_Field instead of just the field name, so
1398 we have access to the formatting.
1399 createFieldValueElement(): Use JRTextField.setPattern() to
1400 specify the numeric formatting, with the help of a
1401 regular DecimalFormat.
1403 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1405 ReportGenerator: Avoid showing null for group by titles.
1407 * src/main/java/org/glom/web/server/ReportGenerator.java
1408 generateReport(): Use setBlankWhenNull() on the field title
1409 style too, because this is used for values in group by
1412 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1414 ReportGenerator: Add a colon to titles in vertical groups.
1416 * src/main/java/org/glom/web/server/ReportGenerator.java
1417 addFieldToDetailBandVertical(): Pass true for the withColon
1420 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1422 ReportGenerator: Simplify the code by using Position more.
1424 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1426 Reports: Support vertical groups, roughly.
1428 * src/main/java/org/glom/web/server/ReportGenerator.java:
1429 addToReport(): Rename to addGroupToReport() and, if necessary,
1430 call the new addVerticalGroupToReport() method.
1431 createFieldValueElement(): Let the caller specify the Y position
1434 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1436 Reports: Allow a second report to be shown.
1438 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1439 clear(): Do not remove the HTML widget, which broke the whole layout.
1441 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1443 Locales drop-down: Show that we use English by default.
1445 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1446 fillView(): When we use English, just because that is the default, when
1447 no locale is specified, show that in the Locales drop-down instead of
1448 just showing the first item.
1450 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1452 Unselect the Report/Locale/Table combo item when appropriate.
1454 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1455 setPlace(): clear reportName if this is not a ReportPlace.
1456 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1457 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1458 When the provided name is empty, unselect all items, so that none are
1459 indicated. This uses a for loop because I cannot find a single method
1462 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1464 Report: Give the user a way to get back to the list.
1466 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1467 start(), setPlace(): Show the Back To List link on reports, and also
1468 interpret selecting the empty report item as back to list.
1470 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1472 Really show the selected Report name.
1474 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1475 setPlace(): Store the reportName here, if it is that kind of Place.
1476 fillView(): Set the selected Report after filling the list of reports.
1477 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1478 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1479 null Strings, though we need some way to unselect all ListBox items
1482 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1484 ReportGenerator: Try to avoid some problems.
1486 * src/main/java/org/glom/web/server/ReportGenerator.java
1487 addField(): Try to avoid duplicates, and avoid using a null
1490 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1492 Reports: Use quickFind.
1494 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1495 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1497 getReportHTML(): Add a quickFind parameter.
1498 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1499 start(): Pass the quickFind parameter.
1500 * src/main/java/org/glom/web/server/ReportGenerator.java
1501 generateReport(): Take a quickFind parameter.
1503 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1505 ReportPlace: Actually use the report name.
1507 * src/main/java/org/glom/web/client/place/ReportPlace.java
1508 getPlace(): Do not assign the report name to the quickfind.
1510 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1512 Show java.library.path when complaining.
1514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1515 init(): When telling us to check java.library.path, show the
1518 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1520 ReportGenerator: Do not show nulls.
1522 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1524 ReportGenerator: Make the title font larger.
1526 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1528 ReportGenerator: Put field titles inside groups, if there are groups.
1530 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1532 ReportGenerator: Take the Report itself instead of the name and group.
1534 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1535 Remove getReportLayoutGroup().
1536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1537 getReportHTML(): Pass the report instead
1538 of its name and layout group.
1539 * src/main/java/org/glom/web/server/ReportGenerator.java
1540 generateReport(): Use the report object to use the title
1541 instead of the name.
1543 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1545 ReportGenerator: Remove designBand parameters.
1547 * src/main/java/org/glom/web/server/ReportGenerator.java:
1548 Make designBand a class member instead of passing it to all
1551 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1553 ReportGenerator: Add lines, a bit like in the desktop version.
1555 * src/main/java/org/glom/web/server/ReportGenerator.java
1556 addToReport(): Use JRDesignLine.
1558 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1560 ReportGenerator: Correct the title positions and use some bold style.
1562 * src/main/java/org/glom/web/server/ReportGenerator.java:
1563 Break the code up into reusable functions, correct the placement of
1564 titles, and use normal/bold styles as in the reports in the desktop
1567 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1569 ReportGenerator: Add a header band to show the field titles.
1571 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1572 getReportHTML(): Pass the localeId to the ReportGenerator
1574 * src/main/java/org/glom/web/server/ReportGenerator.java
1575 constructor: Take the localeID so we can get translated field
1577 generateReport(), addToReport(), addFieldToBand(): Add field
1578 titles in a column header band.
1580 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1582 Reports drop-down list: Some improvement.
1584 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1585 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1586 Adedd setSelectedReport(),
1587 setReportList(): Add a blank line so that the user can select the
1589 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1590 start(): Show the current report by calling setSelectedReport().
1591 This does not seem to work yet.
1593 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1595 DetailsActivity, ListActivity: Move some variables into a base class.
1597 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1598 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1599 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1600 the clientFactory, documentID, tableName and authenticationPopup into
1601 a base class, to avoid duplication.
1603 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1605 Translate the Reports label.
1607 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1608 Get the "Reports" label string from the constants.
1609 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1610 perties: Add Reports to the constants.
1612 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1614 Reports: Implement grouping.
1616 * src/main/java/org/glom/web/server/ReportGenerator.java:
1617 Handle LayoutItem_GroupBy items and try to do the right thing
1618 with JRDesignGroup. It seems to work.
1620 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1622 Actually show some data with JasperReports.
1624 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1625 getReportHTML(): Move most code into a ReportGenerator class.
1626 * src/main/java/org/glom/web/server/ReportGenerator.java:
1627 Recurse into sub-groups, adding fields to the JasperDesign's details
1628 band. Note that we must set an arbitrary width and height, or it just
1629 will not show any data.
1631 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1633 Reports Chooser: Show the titles, not the names.
1635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1636 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1637 and the names as the values.
1638 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1639 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1640 group now that we provide the report name, so it should always
1643 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1645 Depend on jasperreports.
1647 * pom.xml: Add the dependency. My plan is to use this on the
1650 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1652 Implement navigation to report places.
1654 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1655 start(): Do not bother to handle all events here.
1656 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1657 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1658 Added getSelectedReport().
1659 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1660 .java: start(): When handling a change to the reports chooser,
1661 call getSelectedReport() and goTo() its ReportPlace.
1662 * src/main/java/org/glom/web/client/ui/ReportView.java
1663 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1664 Added setReportHTML() which puts the html in a gwt HTML widget.
1665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1666 getReportHTML(): Return "TODO" just to show that this works.
1668 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1670 Make ReportPlace usable.
1672 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1673 Mention ReportPlace.
1674 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1675 Correct the @prefix annotation.
1677 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1679 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1681 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1682 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1683 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1684 Change getReportLayout() to getReportHMTL() because we will not need to
1685 parse or render the report layout on the client side.
1686 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1687 getReportLayout(): Return the libglom LayoutGroup type because we will
1688 not need to convert to a shared type, because this will not be used on
1690 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1693 Note that there is still no implementation for this.
1696 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1698 Add a (empty) Report Place, View, and Activity.
1700 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1702 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1703 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1704 this into a superclass:
1705 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1706 and also use it as the base of this new ReportPlace:
1707 * src/main/java/org/glom/web/client/place/ReportPlace.java
1709 * src/main/java/org/glom/web/client/ui/ReportView.java
1710 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1711 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1712 Add these, containing mostly boiler-plate for now.
1714 * src/main/java/org/glom/web/client/OnlineGlomService.java
1715 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1716 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1717 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1718 Add API to get the LayoutGroup for the report.
1720 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1722 Add and fill a Reports drop-down list box.
1724 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1726 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1727 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1729 Added getReports(document, table, localeID), calling
1730 ConfiguredDocument.getReports().
1731 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1732 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1733 Added setReportsList() and a list widget.
1734 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1735 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1740 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1742 Translations: Add Esperanto.
1744 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1745 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1746 properties: Add this translation because someone took the time to make it.
1748 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1750 Adapt to the java-libglom 1.21.7 API.
1752 * src/main/java/org/glom/web/server/ReportGenerator.java:
1753 addToReport(): get_group_secondary_fields() is now
1754 get_secondary_fields().
1757 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1759 Use the latest java-libglom version.
1761 * pom.xml: Use java-libglom 1.21.7.
1763 2012-03-03 Ben Konrath <ben@bagu.org>
1765 Display date and time in details view.
1767 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1769 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1771 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1773 Require the latest java-libglom.
1775 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1777 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1779 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1781 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1782 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1783 an empty quickfind string. I also corrected libglom to create only
1784 empty where clauses for empty quickfind strings, but this avoids the
1787 2012-02-24 Ben Konrath <ben@bagu.org>
1789 Improve the tabs in the Notebook widget.
1793 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1795 Translations: Try to translate the strings.
1797 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1798 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1799 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1800 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1801 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1802 Take the Open translation from GTK+'s .po files.
1803 Take the Details translation from Glom's po files.
1804 I have added the other strings to Glom so we can get translations that way:
1805 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1807 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1809 TableSelectionViewImpl: Put the search label and entry in a div.
1811 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1812 Put the search widgets in a FlowTable so that the CSS can be used to
1813 style them while keeping them together.
1814 * src/main/webapp/style.css: Mention the new div.
1816 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1818 Translate more strings in more locales.
1820 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1821 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1822 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1823 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1824 Translate the "Details" and "Open" string too.
1826 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1827 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1828 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1829 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1830 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1831 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1832 Add these new locales as placeholders though they currently contain English.
1834 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1836 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1838 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1839 Check the ConfiguredDocument* for null before using it.
1841 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1843 Tell Eclipse about the generated java files.
1845 * .classpath: This lets it find OnlineGlomConstants.java.
1846 It would be nice if Eclipse just used the maven build files.
1848 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1850 Prevent a crash when no locale is specified in the URL.
1852 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1853 Avoid returning a null string, obtained from
1854 Window.Location.getParameter(). This caused a crash when it was
1855 later passed to libglom's API.
1856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1857 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1858 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1859 guard against future null strings.
1861 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1863 Use the ?locale= query param instead of the &lang= token param.
1865 * src/main/java/org/glom/web/client/place/ListPlace.java
1866 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1867 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1868 Remove the lang token key and value.
1870 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1871 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1872 When the user selects a different locale from the chooser, use
1873 Window.Location.assign() to change the URL, which then causes a reload.
1875 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1877 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1878 * src/main/java/org/glom/web/client/activity/ListActivity.java
1879 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1880 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1881 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1882 * src/main/java/org/glom/web/client/ui/ListView.java:
1883 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1885 Remove localeID member variables and method/constructor parameters, instead
1886 using Utils.getCurrentLocaleID() when we need a localID to pass to
1889 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1891 Internationalize the UI strings.
1893 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1894 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1895 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1896 because it is unused. Messages are apparently strings that can have
1897 parameters, but we do not need that yet, so Contants will be enough for now.
1898 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1899 to say that we support the en and de locales.
1900 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1901 The original English strings.
1902 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1903 Some German translations of the English strings.
1904 The i18n goal then uses the .properties file to generate an
1905 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1906 returns an implementation that returns the translated strings.
1907 The documentation suggests putting these in src/java/*/client/, but it seems
1908 best to put it in src/resources/*/client/.
1909 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1910 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1911 instead of hard-coding them.
1912 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1913 but that does not seem to stop the build, though it confuses Eclipse.
1915 You can see the translated string by adding ?locale=de to the URL, like so:
1916 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1918 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1920 Improve null/empty String checks.
1922 * pom.xml: Add a dependency on commons-lang, to use
1923 org.apache.commons.lang.StringUtils.
1924 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1926 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1927 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1928 Use StringUtils.isEmpty().
1930 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1931 StringUtils class with a static isEmpty() function because we
1932 cannot use org.apache.commons.lang.StringUtils in client-side
1933 GWT code because it (apparently) cannot be compiled to javascript.
1934 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1935 * src/main/java/org/glom/web/client/activity/ListActivity.java
1936 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1937 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1938 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1939 * src/main/java/org/glom/web/client/place/ListPlace.java
1940 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1941 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1942 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1943 * src/main/java/org/glom/web/client/ui/details/Group.java
1944 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1945 our StringUtils.isEmpty() function.
1947 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1949 Update to the latest java-libglom API.
1951 * pom.xml: Require java-libglom 1.21.4.
1952 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1953 getDocumentInfo(), getListViewLayoutGroup():
1954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1956 * src/main/java/org/glom/web/server/database/DBAccess.java
1957 getFieldsToShowForSQLQueryAddGroup(),
1958 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1959 with either get_database_title_original() or
1960 get_database_title(localeID).
1962 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1964 ConfiguredDocument: Avoid a null pointer exception.
1966 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1967 Initialize localeID to "" to avoid returning a null String which
1968 causes a crash in java-libglom's swing-generated code.
1970 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1972 Some simple renaming.
1974 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1975 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1976 for localeChooser. This seems more appropriate and is less ambiguous
1977 particularly in the .css file.
1979 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1981 ConfiguredDocument: Rename the localedID private member variable.
1983 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1985 Adapt to the latest java-libglom API from git master.
1987 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1988 libglom now uses only Vector instead of List, which uses add() instead of
1991 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1993 ConfiguredDocument: Rename the localedID private member variable.
1995 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1997 Build a source tarball with mvn assembly:single
1999 * assembly.xml: Add this file.
2000 * pom.xml: Use the maven-assembly-plugin and tell it to use
2001 our assembly.xml file.
2003 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2005 OnlineGlomServiceImpl: Get .glom files recursively.
2007 * pom.xml: Depend on commons-io from org.apache.commons.
2008 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2009 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
2010 files recursively, and with the easier filter for the extension.
2011 Use org.apache.commons.io.FilenameUtils.removeExtension() to
2012 simplify that code too.
2014 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2016 README: Mention that you must install java-libglom packages separately.
2018 But then it works, because java-libglom is now in the central maven
2021 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2023 locales drop-down: Show the correct selected locale when the URL changes.
2025 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2026 .java: setPlace(): Move some code into fillView().
2028 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2030 locales drop-down: Do not lose the primary key.
2032 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2033 start(): onLocaleChange(): Pass the current primary key value,
2034 instead of an empty value.
2036 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2038 locales drop-down: Do not lose the drop-down selection.
2040 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2041 .java (TableSelectionActivity.fillView): Set the selected locale
2042 after changing the drop-down items (though we do not really need
2043 to change them just because the locale changes.)
2045 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2047 locales drop-down: Change the tables list when this changes.
2049 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2050 .java: TableSelectionActivity.start(): Move the async table titles
2051 retrieval into a private fillView() method and also call this when
2052 the chosen locale changes.
2053 Note that the document title is not actually translatable yet, but
2054 that is a problem that I should fix soon in libglom.
2056 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2058 Improve the placement of the locales drop-down.
2060 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2061 Put the title and locales drop-down in a div (gwt.FlowTable).
2062 * src/main/webapp/style.css: Add magic css properties to make this work.
2063 Also remove the left margin from the title so that it lines up with the
2066 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2068 locales selector: Show human-readable locale titles.
2070 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2071 getDocumentInfo(): Use java.util.Locale to show a real title of
2072 each locale, in the locale's own language.
2074 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2076 Add a language/locale selector drop-down.
2078 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2079 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2080 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2081 getDocumentInfo(): Store the available Locales in the DocumentInfo.
2082 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2083 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2084 Add a ListBox to show the available locales. Add getLocaleSelector(),
2085 setLocaleList(), getSelectedLocale(), setSelectedLocale().
2086 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2087 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2088 java: Add these classes.
2089 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2090 start(): Fill the locales ListBox. Handle its change event, firing a
2092 setPlace(): Show the selected locale as specified by the URL token.
2093 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2094 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2095 Handle LocaleChangeEvent, going to a new *Place with that locale.
2097 The placement of the ListBox is not pretty, and it currently uses the ID
2098 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
2102 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2104 Search box: Show the search text from the URL token.
2106 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2107 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2108 Add setQuickFindText().
2109 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2110 .java: setPlace(): Store the queryText if the place is a ListPlace,
2111 and call TableSelectionView.setQuickFindText().
2113 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2115 Allow use of translations via, for instance, &lang=de in the URL.
2117 * pom.xml: Use the unstable java-libglom 1.21 version.
2119 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2120 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2122 init(): Instead of calling TranslatableItem.set_current_locale()
2123 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2124 However, this is only for default locales, which are not needed to
2125 change the locale in the URL.
2126 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2127 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2128 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2129 layout for a particular locale.
2130 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2131 Add get/setDefaultLocaleID().
2132 getDocumentInfo(), getListViewData(), getRelatedListData(),
2133 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2134 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2135 localeID parameter, so we can get the layout for a particular locale.
2137 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2138 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2139 * src/main/java/org/glom/web/client/place/ListPlace.java:
2140 Parse and construct a lang parameter too.
2142 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2143 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2144 passed to subsequent methods and constructors.
2145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2146 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2147 Store the localeID from the *Place and pass it to other constructors
2148 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2150 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2151 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2152 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2153 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2154 * src/main/java/org/glom/web/client/ui/ListView.java:
2155 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2156 Take localeID parameters and pass them to subsequent constructors and
2157 methods, so that the layout is always retrieved for that locale.
2159 This is rather repetitive.
2161 Note that "" means the original (default) locale of the Glom document,
2162 which is usually English.
2164 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2166 Documents: Remove final keyword to fix startup configuration.
2168 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2169 final keywords on the private member variables because that breaks
2170 the startup, apparently (there are warnings) because it stops them
2171 from being serialized. I added these in the previous commit.
2173 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2175 Documents: Add some final keywords.
2177 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2180 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2182 OnlineGlomServiceImpl: Add to overview comments.
2184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2185 Note that this is where all the document are loaded. They are not
2186 loaded freshly for each page.
2188 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2192 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2193 Add a TextBox for the text of a quick find.
2194 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2196 setBackLink(): Add a String quickFind parameter.
2197 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2198 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2199 to the base interface, because that is how TableSelectionViewImpl is used.
2200 * src/main/webapp/style.css: Add style for the search box and its label.
2202 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2203 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2204 Add these files, based on the existing TableChangeEvent and
2205 TableChangeEventHandlers.
2206 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2207 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2208 a ListPlace() that the user should be taken to.
2209 * src/main/java/org/glom/web/client/activity/ListActivity.java
2210 start(): Handle it here too and adapt the TableChangeEvent handler to
2211 pass the extra "" quickFind parameter to ListPlace.
2212 * src/main/java/org/glom/web/client/place/ListPlace.java:
2213 Constructor: Take an extra String quickFind parameter and store it,
2214 returning it from a new getQuickFind() method.
2215 getToken(): Put the quickFind text in the URL token.
2216 getPlace(): Parse the quickFind text from the URL token.
2217 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2218 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2219 ListPlace constructor.
2220 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2221 .java: start(): Add a Change handler for the TableSelectionView's
2222 TextBox (via its base HasChangeHandlers interface), firing the new
2223 QuickFindChangeEvent.
2224 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2225 pass the extra "" quickFind parameter.
2227 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2228 setCellTable(): Add a String quickFind parameter and pass it to
2229 the ListViewTable() constructor.
2230 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2231 setCellTable() in the base interface, because that is how ListViewImpl
2234 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2235 Add a String quickFind member variable.
2236 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2237 Constructor: Add a String quickFind parameter, storing it in the
2238 base ListTable's member variable.
2239 onRangeChanged(): Pass quickFind to the
2240 OnlineGlomServiceAsync.getSortedListViewData() and
2241 OnlineGlomServiceAsync.getListViewData() methods.
2243 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2244 getListViewData(), getSortedListViewData(): Add a String quickFind
2245 parameter, passing it to ConfiguredDocument.getListViewData().
2246 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2247 Change getListViewData(), getSortedListViewData() in the base interface,
2248 because that is how OnlineGlomServiceImpl is used, via this:
2249 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2250 Change getListViewData(), getSortedListViewData() here too.
2251 This class can apparently be used to asynchronously call methods on
2252 OnlineGlomService, and GWT seems to implement that after recognizing
2253 just the *Async name convention and the extra AsyncCallback parameters.
2255 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2256 getListViewData(): Add a String quickFind parameter, and pass it to
2257 ListViewDBAccess.getData().
2258 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2259 getListData(): Add a String quickFind parameter and pass it to
2261 getSelectQuery(): Add a String quickFind parameter.
2262 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2263 getSelectQuery(): Add a String quickFind parameter and use it with
2264 Glom.get_find_where_clause_quick() to pass a where_clause to
2265 Glom.build_sql_select_with_where_clause(), to actually filter the
2267 getData(): Add a String quickFind parameter, passing it to getListData().
2268 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2269 va: getData(): Pass an empty string to getListData() for the
2270 quickFind parameter.
2272 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2274 ListTable: Minor change.
2276 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2277 createCellTable(): Make this protected instead of public.
2279 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2281 Many files: Use final for the parameters and use the @override attribute.
2283 2012-01-22 Ben Konrath <ben@bagu.org>
2285 Add anchor links for single line text that starts with http, ftp and www.
2289 2012-01-22 Ben Konrath <ben@bagu.org>
2291 Add ellipsis to single line text in details view.
2295 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2297 Remove all javadoc author tags.
2299 Because they are awkward and meaningless when many people touch
2301 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2303 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2305 Revert the COPYING.LESSER to COPYING rename.
2307 Apparently both should be there if it is LGPL.
2309 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2311 *View: Remove unused imports.
2313 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2314 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2315 * src/main/java/org/glom/web/client/ui/ListView.java:
2316 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2317 Remove unused imports, as suggested by Eclipse.
2319 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2321 Move the *View::Presenter types, and some API into one base View.
2323 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2324 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2325 * src/main/java/org/glom/web/client/ui/ListView.java:
2326 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2327 Presenter, setPresenter() and clear() into a shared base interface,
2328 to avoid the unnecessary duplicate Presenter types and to more clearly
2329 show how the *Views share the same structure, even if they are not
2330 used polymorphically.
2332 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2333 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2336 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2337 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2339 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2342 Feel free to revert this if there is a good reason for the duplicate
2345 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2347 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2349 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2350 a class member instead of a local variable in the method.
2351 This lets us use it to get the view instances, for use in tests.
2352 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2353 beforeOnlineGlom(): Test some more details of the initial view.
2354 Again, this is not very useful.
2356 To really test gwt-glom we will need to start a local postgresql
2357 instance with local data, like the Glom tests in C++.
2359 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2361 pom.xml: Mention the LGPL license.
2363 * pom.xml: Add a licenses section.
2364 * COPYING.LESSER: Move this to COPYING, which
2365 previously contained the GPL. But gwt-glom is all LGPL.
2367 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2369 Add project information to README and pom.xml.
2371 * README: Add a brief description and mention some mvn
2373 * pom.xml: This extra information shows up in mvn site
2376 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2378 Use the latest java-libglom version.
2380 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2382 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2384 GwtTestOnlineGlom: Test a little more.
2386 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2387 protected rather than private, as suggested by the gwt-test-utils
2389 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2390 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2391 Test the initial visibility of the panels.
2393 However, this is not a very useful test.
2394 And I wonder how we should generally test using this idea for an
2395 activity/places app like ours where the real changes happen implicitly
2396 based on the history token/URL.
2398 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2400 Slight modification to *Mapper comments.
2402 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2403 (DataActivityMapper)
2404 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2406 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2408 Remove comments mentioning GIN because they are just copied from
2409 the example code and are apparently not helpful:
2410 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2411 Also change the mention of a class that is only in the example code.
2413 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2415 GwtTestOnlineGlom test: Minor changes.
2417 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2418 Avoid the long qualified class name and modify the comment
2419 because it is now obvious to me that the mocked class is the only
2420 custom one created via GWT.create().
2422 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2424 Tests: Added the beginnings of a test using gwt-test-utils.
2426 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2427 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2428 which tells gwt-test-utils what class will be tested.
2429 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2430 Add a simple (but empty) test case. One class, used by the OnlineGlom
2431 class, is mocked so that it can be created. However, I am not sure
2432 why only this class needs to be mocked.
2434 Note that mockito seems more popular, and clearer, than easymock,
2435 but I have not got that working yet. It might be a matter of the
2438 This test is run during mvn integration-test.
2440 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2442 Tests: Use junit4-style syntax instead of junit3-style.
2444 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2445 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2446 * src/test/java/org/glom/web/shared/DataItemTest.java:
2447 Use the @Test annotation rather than relying on the test*() prefix.
2448 Also no longer implement TestCase, to avoid triggering support for
2449 the junit3-way, which stops the annotations from working.
2450 Change the imports from import junit.framework.* to
2451 import org.junit.*, which is apparently the new way.
2453 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2455 Added a test for ListPlace token parsing and creation.
2457 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2458 This is much the same as DetailsPlaceTest.
2460 I wonder how we could test the other parts of the *Place API.
2462 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2464 DetailsPlace test: Also test getToken() and recreation via getPlace().
2466 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2467 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2468 recreate it, testing the recreated DetailsPlace for the same parameter
2471 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2473 Use the surefire-report plugin.
2475 * pom.xml: This generates a HTML report about the tests in
2476 target/site/surefire-report.html
2477 when you do mvn surefire-report:report. It seems to be popular/normal.
2479 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2481 Added a test for DetailsPlace.
2483 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2484 Test the getPlace() token parsing.
2486 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2488 Added a first unit test.
2490 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2491 * src/test/java/org/glom/web/shared/DataItemTest.java:
2492 This is a silly test but it is just to get things started. Note that
2493 maven/junit finds the test because it looks in src/test by default.
2495 2011-12-22 Ben Konrath <ben@bagu.org>
2497 Change charsetName to "UTF-8" when replacing line breaks.
2499 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2500 that work in Java (such as "UTF8") will not work when compiled to
2503 This fixes a problem with multi-line details view fields that have hard
2504 line breaks. The "License Text" field on this page demonstrates the
2507 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2509 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2511 2011-12-22 Ben Konrath <ben@bagu.org>
2513 Fix another bug with related list navigation.
2515 I've tested all the navigation buttons in all of the related lists
2516 so things should be good now.
2518 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2520 2011-12-22 Ben Konrath <ben@bagu.org>
2522 Fix a crasher when refreshing the list view with the default table.
2524 This crash will also happen when loading the list view with the default
2525 table from a link or bookmark.
2527 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2528 to the main document selection page when the document id hasn't been
2530 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2531 the main document selection page when the document id hasn't been
2533 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2534 values for the details place when the document id hasn't been set.
2535 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2536 values for the list place when the document id hasn't been set.
2538 2011-12-21 Ben Konrath <ben@bagu.org>
2540 Protect against NPE when glom.document.locale is not in config.
2542 This patch protects against an NPE when glom.document.locale is not in
2543 the config file. This NPE will also happen if glom.document.locale is
2546 The patch also updates the error message to display the class name when
2547 the getMessage() returns null. This was happening when the NPE was
2548 thrown and I had "Configuration Error: null". If an NPE is encountered
2549 with this patch, "Configuration Error: NullPointerException " will be
2552 This commit closes this bug:
2554 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2558 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2560 Rename onlineglom.properties to onlineglom.properties.sample.
2562 * src/main/resources/onlineglom.properties: Rename to:
2563 * src/main/resources/onlineglom.properties.sample:
2564 * src/main/resources/README: And add this file explaining that people
2565 should rename it back when deploying.
2567 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2569 Allow choosing the translation in the .properties file.
2571 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2572 init(): Read a glom.document.locale value from the configuration file
2573 and call Glom's TransatableItem::set_current_locale() method.
2574 * src/main/resources/onlineglom.properties: Add a commented-out
2575 example of this new setting.
2577 It would be better to add &lang=de_DE to the URL, but the current
2578 libglom API does not allow us to do this easily. I am working on that.
2580 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2582 Avoid a crash in parsing of token parameters.
2584 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2585 ava: getTokenParams(): Do not crash if a parameter has a key but no
2586 value, and ignore parameters with neither.
2588 2011-12-17 Murray Cumming <murrayc@murayc.com>
2590 History token building/handling: Improve use of token parameters.
2592 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2593 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2594 and buildParamsToken(HashMap), for use by derived classes.
2595 Make the separator private because it is no longer be needed.
2596 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2597 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2598 instead of manual string concatenation.
2599 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2600 of hardcoded indices and awkward splitting code.
2601 * src/main/java/org/glom/web/client/place/ListPlace.java
2602 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2603 instead of manual string concatenation.
2604 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2605 of hardcoded indices and awkward splitting code.
2606 This should fix bug #666420
2608 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2610 Fix a Navgiation->Navigation typo in the code.
2612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2613 Rename processNavgiation() to processNavigation().
2615 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2617 Fix a seperator->separator typo in the code.
2619 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2620 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2621 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2624 2011-12-15 Ben Konrath <ben@bagu.org>
2626 Cleanup some comments.
2628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2630 2011-12-14 Ben Konrath <ben@bagu.org>
2632 Replace \n with <br/> for multiline text in the details view.
2634 Vertical scrollbars are added when needed as well.
2636 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2638 2011-12-14 Ben Konrath <ben@bagu.org>
2640 Specify the font for document selection links.
2642 * src/main/webapp/style.css:
2644 2011-12-14 Ben Konrath <ben@bagu.org>
2646 Fix bouncy CellTable while paging.
2648 This doesn't currently work with related list tables in unselected
2651 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2653 2011-12-14 Ben Konrath <ben@bagu.org>
2655 Revamp the appearance of the document selection page.
2657 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2658 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2659 * src/main/webapp/style.css:
2661 2011-12-13 Ben Konrath <ben@bagu.org>
2663 Set navigation button column to the smallest size possible.
2665 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2667 2011-12-13 Ben Konrath <ben@bagu.org>
2669 Change OpenButton nomenclature to NavigationButton.
2671 Using NavigtionButton makes things more generic. Classes, methods and
2672 variables have been changed.
2674 This is a rename-only refactor.
2676 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2677 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2678 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2679 Renamed from OpenButtonCell.
2680 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2681 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2682 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2684 2011-12-12 Ben Konrath <ben@bagu.org>
2686 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2688 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2689 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2690 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2691 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2693 2011-12-12 Ben Konrath <ben@bagu.org>
2695 Update variable names and comments.
2697 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2698 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2700 2011-12-12 Ben Konrath <ben@bagu.org>
2702 Properly initialize numNonEmptyRows variable to zero.
2704 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2705 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2707 2011-12-05 Ben Konrath <ben@bagu.org>
2709 Add latest mockup with HTML tables.
2711 Features of this mockup:
2713 -> HTML table for flowtable
2714 -> HTML table for flowtable column
2715 -> Example of how related lists would look
2716 -> Not using text entries for data items
2718 The current version of Online Glom doesn't use HTML tables for the
2721 This mockup has been sent to the glom-devel mailing list but it's good
2722 to have it here as well.
2724 * mockups/details-view-html-tables.html:
2726 2011-12-05 Ben Konrath <ben@bagu.org>
2728 Remove unnecessary getPrimaryKeyField() method.
2730 getPrimaryKeyFieldForTable(String) has been renamed to
2731 getPrimaryKeyField(String).
2733 * src/main/java/org/glom/web/server/database/DBAccess.java:
2734 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2735 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2737 2011-12-05 Ben Konrath <ben@bagu.org>
2739 Add string representation of TypedDataItem value to conversion error message.
2741 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2742 message was extracted into its own method to avoid duplication.
2744 2011-12-05 Ben Konrath <ben@bagu.org>
2746 Add type checking to navigation primary key value creation.
2748 Create navigation primary key only if the expected type from the Glom
2749 document matches the type returned by the SQL query.
2751 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2753 2011-12-05 Ben Konrath <ben@bagu.org>
2755 Rename a couple of variables in RelatedListNavigation.
2757 This is a rename-only refactor.
2759 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2761 2011-12-05 Ben Konrath <ben@bagu.org>
2763 Move getListLayoutGroup() into getListViewLayoutGroup().
2765 This removes getListLayoutGroup(). It was only being called by
2766 getListViewLayoutGroup().
2768 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2770 2011-12-05 Ben Konrath <ben@bagu.org>
2772 Remove check for LayoutItem_Portal in list table method.
2774 This check is no longer necessary because the method isn't being used
2775 to create the LayoutItemPortal DTO.
2777 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2779 2011-12-05 Ben Konrath <ben@bagu.org>
2781 Properly support related list navigation.
2783 Navigation from the "Repository Analyzer -> Package Scans ->
2784 Dependencies" related table wasn't working because the primary key for
2785 related tables wasn't being set properly. This commit fixes the
2788 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2789 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2790 doesn't set the primary key properly for related list tables.
2791 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2792 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2793 useful for getting the primary key for list view tables and for related
2795 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2796 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2797 Move code to set the primary key for the table from the abstract
2798 ListDBAccess class to ListViewDBAccess as it's only correct for list
2800 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2801 Properly add primary key to related list tables.
2803 2011-12-02 Ben Konrath <ben@bagu.org>
2805 Properly set the horizontal alignment of fields.
2807 This fix is for both the list tables and the details view.
2809 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2810 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2811 to set the horizontal alignment of fields.
2813 2011-12-02 Ben Konrath <ben@bagu.org>
2815 Display currency codes in the details view.
2817 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2819 2011-12-02 Ben Konrath <ben@bagu.org>
2821 Avoid duplicate JNI call.
2823 JNI is not as efficient as pure Java and this is an easy (and small)
2826 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2827 Use previously retrieved value for whereClauseToTableName instead of
2830 2011-12-02 Ben Konrath <ben@bagu.org>
2832 Rename a couple of variables in RelatedListNavigation.
2834 This is a rename-only refactor.
2836 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2838 2011-12-02 Ben Konrath <ben@bagu.org>
2840 Indicate clearly that a mismatched primary key type is a bug.
2842 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2843 warning to error. Add 'This is a bug.' to message.
2845 2011-12-02 Ben Konrath <ben@bagu.org>
2847 Update / fix some comments.
2849 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2851 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2853 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2854 Fix comments. Add some TODOs.
2856 2011-12-02 Ben Konrath <ben@bagu.org>
2858 Enable navigation to details view with string primary key from related list.
2860 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2861 Create a text primary key value when return type of result is
2862 java.sql.Types.VARCHAR.
2864 2011-12-02 Ben Konrath <ben@bagu.org>
2866 Use checkboxes for booleans in the details view.
2868 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2870 2011-12-01 Ben Konrath <ben@bagu.org>
2872 Improve performance of related list height calculation.
2874 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2875 Put code to calculate the expected height in a static initializer so
2876 that that it's only called once.
2878 2011-12-01 Ben Konrath <ben@bagu.org>
2880 Show related list tables in notebooks (again).
2882 Calculate the height of the related list tables so the Notebook can be
2883 set the correct height. The height of the related list table is also needed by
2884 FlowTable to be able decide how to create the layout.
2886 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2887 and set the Portal height based on the height of the related list
2888 table and the Portal container.
2889 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2890 Add method to calculate the height of the related list tables.
2891 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2892 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2893 calculate the height of the Pager widget.
2895 2011-12-01 Ben Konrath <ben@bagu.org>
2897 Use CellTable API for table property instead of setting style on Element.
2899 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2901 2011-12-01 Ben Konrath <ben@bagu.org>
2903 Make ListViewTable and RelatedListTable a consistent height.
2905 The tables are now a consistent height regardless of the contents of
2906 the table. A hidden button is added to empty rows to ensure that the
2907 height of these rows will match the height of rows with data.
2909 A navigation button column is now added to every table. The width of
2910 the navigation column is set to 0px when a RelatedListTable shouldn't
2911 have navigation buttons. This maintains the a consistent row height in
2912 tables that don't show the navigation buttons.
2914 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2915 navigation column when not needed.
2916 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2917 arguments for navigation button to constructor of ListViewTable.
2918 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2919 hidden button for empty data rows.
2920 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2921 arguments for navigation button to constructor.
2922 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2923 create navigation buttons. Add hideNavigationButtons() method.
2924 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2925 arguments for navigation button to constructor.
2927 2011-12-01 Ben Konrath <ben@bagu.org>
2929 Use 'visibility: hidden' in Utils.getWidgetHeight().
2931 This is better choice because hidden elements are invisible, don't
2932 respond to events and are not part of the tab order. They will,