1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java
6 updateLayoutGroup(): Check that the field is not null.
8 2012-05-06 Murray Cumming <murrayc@murrayc.com>
10 ListViewImpl: Protected against a bad cast error.
12 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
13 onEnterKeyDown(): Do not cast without an instanceof check.
15 2012-05-06 Murray Cumming <murrayc@murrayc.com>
17 ListTable: Protect against an out of range error.
19 * src/main/java/org/glom/web/client/ui/list/ListTable.java
20 createCellTable(): This is unlikely, but can happen while debugging.
22 2012-05-06 Murray Cumming <murrayc@murrayc.com>
24 AsyncMessage onFailure() callbacks: Log the exception message.
26 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
27 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
28 * src/main/java/org/glom/web/client/activity/ListActivity.java:
29 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
30 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
31 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
32 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
33 These are useful clues when something is wrong.
35 2012-05-06 Murray Cumming <murrayc@murrayc.com>
37 ConfiguredDocument: Avoid a null dereference.
39 * src/main/java/org/glom/web/server/ConfiguredDocument.java
40 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
41 details maps are created.
43 2012-05-06 Murray Cumming <murrayc@murrayc.com>
45 Document: Correct the port number parsing.
47 * src/main/java/org/glom/web/server/libglom/Document.java:
48 This lets us actually connect to the database and show the document.
50 2012-05-05 Murray Cumming <murrayc@murrayc.com>
54 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
55 user-interaction, asking us to load a temporary URL in a browser.s
56 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
57 which is apparently necessary for testing the service. See the comment.
58 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
59 Show the exception, if any. This is how I saw the 404 in the HTML in
62 2012-05-05 Murray Cumming <murrayc@murrayc.com>
64 DocumentTest: Move the .glom files into the resources directory.
66 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
67 URI via getResource().
69 2012-05-05 Murray Cumming <murrayc@murrayc.com>
71 Document: Remove the FieldIdentifies inner class.
73 * src/main/java/org/glom/web/server/libglom/Document.java: We only
74 use the Relationship (though the same function in libglom is maybe
75 used in other ways) and so this removes a compiler warning.
77 2012-05-05 Murray Cumming <murrayc@murrayc.com>
79 Document.load() Remove the error code parameter.
81 * src/main/java/org/glom/web/server/libglom/Document.java: load():
82 Remove the parameter. We do not set it yet and it could never have
83 worked as an output parameter (though maybe it did in java-libglom).
84 We could use an exception if we really want the failure reason.
85 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
87 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
88 setUp(), testGetSuitableTableToViewDetails(): Adapt.
90 2012-05-05 Murray Cumming <murrayc@murrayc.com>
92 Make some inner classes static.
94 * src/main/java/org/glom/web/server/ConfiguredDocument.java
95 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
96 * src/main/java/org/glom/web/server/ReportGenerator.java
97 * src/main/java/org/glom/web/server/libglom/Document.java
98 Make all inner classes static that can be static.
100 2012-05-05 Murray Cumming <murrayc@murrayc.com>
102 OnlineGlomServiceImpl: Do not load and check for java-libglom.
104 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
105 init(): We do not use java-libglom any more.
107 2012-05-05 Murray Cumming <murrayc@murrayc.com>
109 Remove mentions of java-libglom.
111 * README: Remove mention of java-libglom, because it no longer needed.
112 * utils/build-onlineglom-war.sh:
113 * utils/check-and-recover-tomcat.py:
114 * utils/install-onlineglom-war.sh: Remove these as they are no longer
115 useful. Building is now far easier, with no need for jhbuild.
117 2012-05-05 Murray Cumming <murrayc@murrayc.com>
119 Fix the build (mvn package)
121 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
122 (LayoutGroup): Make the LayoutItemList inner class static and protected.
123 Otherwise the GWT Java->Javascript compilation fails with just this
124 error, during mvn package or when attempting to view in a browser,
125 in the GWT developer mode in Eclipse.
127 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
128 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
129 [INFO] Compiling module org.glom.web.OnlineGlom
130 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
131 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
132 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
133 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
134 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
135 [INFO] [ERROR] Cannot proceed due to previous errors
137 It has taken me 2 days to find out what was causing that. After reducing
138 the code, the compiler eventually showed me the full error message.
140 2012-05-04 Murray Cumming <murrayc@murrayc.com>
142 ConfiguredDocument: Cache the cloned and stripped layouts.
144 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
145 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
146 layout in a map, so we can retrieve it again without rebuilding it.
148 2012-05-04 Murray Cumming <murrayc@murrayc.com>
150 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
152 2012-05-04 Murray Cumming <murrayc@murrayc.com>
154 libglom classes: Implement some auto-generated emthods.
156 2012-05-04 Murray Cumming <murrayc@murrayc.com>
158 Add GwtTestOnlineGlomService.
160 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
161 However, this (and the other GwtTest*) does not seem to run during
164 2012-05-04 Murray Cumming <murrayc@murrayc.com>
166 Remove use of unsupported features from client code.
168 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
169 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
170 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
171 Use our client version of StringUtils instead of the apache commons one.
173 However, the GWT Javascript compliation still fails.
175 2012-04-25 Murray Cumming <murrayc@murrayc.com>
177 Add a Field class and implement some loading of it in Document.
179 2012-04-25 Murray Cumming <murrayc@murrayc.com>
181 Initial Document loading implementation, instead of libglom.
183 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
184 and Translatable classes, and adapt the rest of the code to use them.
185 However, this is still missing Layout and Field classes and loading.
187 2012-04-24 Murray Cumming <murrayc@murrayc.com>
189 Use of jOOQ: Move Field creation into a utility method.
191 * src/main/java/org/glom/web/server/SqlUtils.java:
192 This lets us improve it more easily.
194 2012-04-24 Murray Cumming <murrayc@murrayc.com>
196 Use of jOOQ: Improve the code to COUNT a sub-select.
198 * src/main/java/org/glom/web/server/SqlUtils.java:
199 Move initial query creation into
200 build_sql_select_step_with_where_clause().
201 build_sql_select_count_rows(): Use the jOOQ API instead of
202 concatentating text, because a jOOQ Select*Step is a TableLike,
203 which is what from() takes.
205 2012-04-23 Murray Cumming <murrayc@murrayc.com>
207 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
209 * pom.xml: Depend on jooq.
210 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
211 methods with jOOQ, based on the C++ implementations in libglom,
212 with some changes to the logic required by jooQ.
213 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
215 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
216 * src/main/java/org/glom/web/server/ReportGenerator.java:
217 * src/main/java/org/glom/web/server/SqlUtils.java:
218 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
219 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
220 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
221 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
222 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
223 Adapt. In particular, the SqlUtils methods now need to take a Connection,
224 because jOOQ needs that, though it seems unnecessary.
226 This is not quite finished. Ideally jOOQ would help us to build
227 table_name.field_name names, quoting and escaping them properly.
228 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
230 2012-04-21 Murray Cumming <murrayc@murrayc.com>
232 Move use of Glom.build_sql*() into a new SqlUtils class.
234 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
235 to wrap Glom.build_sql*(). The parameter types are still Glom one,
236 but this will make it easier to start using something other than
237 libglom or SqlBuilder.
239 2012-04-21 Murray Cumming <murrayc@murrayc.com>
241 Update the project URL.
243 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
245 2012-04-21 Murray Cumming <murrayc@murrayc.com>
247 Main layout: Use a FlowTable instead of absolute positioning.
249 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
250 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
251 child panels/widgets must have an absolute position. But that is annoying, so
252 this adds a FlowTable and puts the child panels in there.
254 2012-04-21 Murray Cumming <murrayc@murrayc.com>
256 GwtTestOnlineGlom: Comment out unused code.
258 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
259 Eclipse has started to say that some code is unused.
261 2012-04-21 Murray Cumming <murrayc@murrayc.com>
263 Update to the latest versions of dependencies.
265 * pom.xml: Update version numbers of dependencies to the latest
267 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
269 * src/main/java/org/glom/web/server/ReportGenerator.java:
270 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
271 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
272 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
274 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
275 Modify the imports where necessary.
277 2012-04-17 Murray Cumming <murrayc@murrayc.com>
279 Style: Remove overflow:hidden from searchbox
281 * src/main/webapp/style.css: Because this pushes the Back To Link
282 label/link on to the next row, which is then hidden due to the
283 hard-coded (in ems) height.
285 2012-04-20 Murray Cumming <murrayc@murrayc.com>
287 Remove some duplicate code.
289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
290 getDocumentInfo(): This must have been duplicated during the merge from the
295 2012-04-19 Murray Cumming <murrayc@murrayc.com>
297 Reports: Localize the waiting for report message.
299 * src/main/java/org/glom/web/client/activity/ReportActivity.java
300 start(): Get the message from the contants.
301 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
303 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
304 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
305 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
306 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
307 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
308 Update these files with the English text for newer strings for now.
310 2012-04-19 Murray Cumming <murrayc@murrayc.com>
312 Reports: Show a message while waiting for the report.
314 * src/main/java/org/glom/web/client/ui/ReportView.java
315 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
316 Add setWaitingText(), to show a message saying that we are
317 waiting for the report to be ready.
318 * src/main/java/org/glom/web/client/activity/ReportActivity.java
319 start(): Call setWaitingText() before calling the async
322 2012-04-19 Murray Cumming <murrayc@murrayc.com>
324 ReportGenerator: Specify date and time formats.
326 * src/main/java/org/glom/web/server/ReportGenerator.java:
327 createFieldValueElement(): Use the default (and localized)
328 short formats, though we still need a way to show 4-digit
329 years without providing the format for every locale.
330 * src/main/java/org/glom/web/server/database/DBAccess.java:
331 convertResultSetToDTO(): Use the short formats here too.
333 2012-04-18 Murray Cumming <murrayc@murrayc.com>
335 ReportGenerator: Use the correct numeric formatting.
337 * src/main/java/org/glom/web/server/ReportGenerator.java
338 createFieldExpression(), createFieldValueElement(): Take the
339 whole LayoutItem_Field instead of just the field name, so
340 we have access to the formatting.
341 createFieldValueElement(): Use JRTextField.setPattern() to
342 specify the numeric formatting, with the help of a
343 regular DecimalFormat.
345 2012-04-18 Murray Cumming <murrayc@murrayc.com>
347 ReportGenerator: Avoid showing null for group by titles.
349 * src/main/java/org/glom/web/server/ReportGenerator.java
350 generateReport(): Use setBlankWhenNull() on the field title
351 style too, because this is used for values in group by
354 2012-04-18 Murray Cumming <murrayc@murrayc.com>
356 ReportGenerator: Add a colon to titles in vertical groups.
358 * src/main/java/org/glom/web/server/ReportGenerator.java
359 addFieldToDetailBandVertical(): Pass true for the withColon
362 2012-04-18 Murray Cumming <murrayc@murrayc.com>
364 ReportGenerator: Simplify the code by using Position more.
366 2012-04-18 Murray Cumming <murrayc@murrayc.com>
368 Reports: Support vertical groups, roughly.
370 * src/main/java/org/glom/web/server/ReportGenerator.java:
371 addToReport(): Rename to addGroupToReport() and, if necessary,
372 call the new addVerticalGroupToReport() method.
373 createFieldValueElement(): Let the caller specify the Y position
376 2012-04-17 Murray Cumming <murrayc@murrayc.com>
378 Reports: Allow a second report to be shown.
380 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
381 clear(): Do not remove the HTML widget, which broke the whole layout.
383 2012-04-17 Murray Cumming <murrayc@murrayc.com>
385 Locales drop-down: Show that we use English by default.
387 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
388 fillView(): When we use English, just because that is the default, when
389 no locale is specified, show that in the Locales drop-down instead of
390 just showing the first item.
392 2012-04-17 Murray Cumming <murrayc@murrayc.com>
394 Unselect the Report/Locale/Table combo item when appropriate.
396 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
397 setPlace(): clear reportName if this is not a ReportPlace.
398 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
399 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
400 When the provided name is empty, unselect all items, so that none are
401 indicated. This uses a for loop because I cannot find a single method
404 2012-04-17 Murray Cumming <murrayc@murrayc.com>
406 Report: Give the user a way to get back to the list.
408 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
409 start(), setPlace(): Show the Back To List link on reports, and also
410 interpret selecting the empty report item as back to list.
412 2012-04-13 Murray Cumming <murrayc@murrayc.com>
414 Really show the selected Report name.
416 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
417 setPlace(): Store the reportName here, if it is that kind of Place.
418 fillView(): Set the selected Report after filling the list of reports.
419 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
420 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
421 null Strings, though we need some way to unselect all ListBox items
424 2012-04-13 Murray Cumming <murrayc@murrayc.com>
426 ReportGenerator: Try to avoid some problems.
428 * src/main/java/org/glom/web/server/ReportGenerator.java
429 addField(): Try to avoid duplicates, and avoid using a null
432 2012-04-13 Murray Cumming <murrayc@murrayc.com>
434 Reports: Use quickFind.
436 * src/main/java/org/glom/web/client/OnlineGlomService.java;
437 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
439 getReportHTML(): Add a quickFind parameter.
440 * src/main/java/org/glom/web/client/activity/ReportActivity.java
441 start(): Pass the quickFind parameter.
442 * src/main/java/org/glom/web/server/ReportGenerator.java
443 generateReport(): Take a quickFind parameter.
445 2012-04-13 Murray Cumming <murrayc@murrayc.com>
447 ReportPlace: Actually use the report name.
449 * src/main/java/org/glom/web/client/place/ReportPlace.java
450 getPlace(): Do not assign the report name to the quickfind.
452 2012-04-13 Murray Cumming <murrayc@murrayc.com>
454 Show java.library.path when complaining.
456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
457 init(): When telling us to check java.library.path, show the
460 2012-03-06 Murray Cumming <murrayc@murrayc.com>
462 ReportGenerator: Do not show nulls.
464 2012-03-06 Murray Cumming <murrayc@murrayc.com>
466 ReportGenerator: Make the title font larger.
468 2012-03-06 Murray Cumming <murrayc@murrayc.com>
470 ReportGenerator: Put field titles inside groups, if there are groups.
472 2012-03-06 Murray Cumming <murrayc@murrayc.com>
474 ReportGenerator: Take the Report itself instead of the name and group.
476 * src/main/java/org/glom/web/server/ConfiguredDocument.java
477 Remove getReportLayoutGroup().
478 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
479 getReportHTML(): Pass the report instead
480 of its name and layout group.
481 * src/main/java/org/glom/web/server/ReportGenerator.java
482 generateReport(): Use the report object to use the title
485 2012-03-06 Murray Cumming <murrayc@murrayc.com>
487 ReportGenerator: Remove designBand parameters.
489 * src/main/java/org/glom/web/server/ReportGenerator.java:
490 Make designBand a class member instead of passing it to all
493 2012-03-06 Murray Cumming <murrayc@murrayc.com>
495 ReportGenerator: Add lines, a bit like in the desktop version.
497 * src/main/java/org/glom/web/server/ReportGenerator.java
498 addToReport(): Use JRDesignLine.
500 2012-03-06 Murray Cumming <murrayc@murrayc.com>
502 ReportGenerator: Correct the title positions and use some bold style.
504 * src/main/java/org/glom/web/server/ReportGenerator.java:
505 Break the code up into reusable functions, correct the placement of
506 titles, and use normal/bold styles as in the reports in the desktop
509 2012-03-06 Murray Cumming <murrayc@murrayc.com>
511 ReportGenerator: Add a header band to show the field titles.
513 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
514 getReportHTML(): Pass the localeId to the ReportGenerator
516 * src/main/java/org/glom/web/server/ReportGenerator.java
517 constructor: Take the localeID so we can get translated field
519 generateReport(), addToReport(), addFieldToBand(): Add field
520 titles in a column header band.
522 2012-03-05 Murray Cumming <murrayc@murrayc.com>
524 Reports drop-down list: Some improvement.
526 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
527 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
528 Adedd setSelectedReport(),
529 setReportList(): Add a blank line so that the user can select the
531 * src/main/java/org/glom/web/client/activity/ReportActivity.java
532 start(): Show the current report by calling setSelectedReport().
533 This does not seem to work yet.
535 2012-03-05 Murray Cumming <murrayc@murrayc.com>
537 DetailsActivity, ListActivity: Move some variables into a base class.
539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
540 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
541 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
542 the clientFactory, documentID, tableName and authenticationPopup into
543 a base class, to avoid duplication.
545 2012-03-05 Murray Cumming <murrayc@murrayc.com>
547 Translate the Reports label.
549 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
550 Get the "Reports" label string from the constants.
551 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
552 perties: Add Reports to the constants.
554 2012-03-05 Murray Cumming <murrayc@murrayc.com>
556 Reports: Implement grouping.
558 * src/main/java/org/glom/web/server/ReportGenerator.java:
559 Handle LayoutItem_GroupBy items and try to do the right thing
560 with JRDesignGroup. It seems to work.
562 2012-03-04 Murray Cumming <murrayc@murrayc.com>
564 Actually show some data with JasperReports.
566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
567 getReportHTML(): Move most code into a ReportGenerator class.
568 * src/main/java/org/glom/web/server/ReportGenerator.java:
569 Recurse into sub-groups, adding fields to the JasperDesign's details
570 band. Note that we must set an arbitrary width and height, or it just
571 will not show any data.
573 2012-03-04 Murray Cumming <murrayc@murrayc.com>
575 Reports Chooser: Show the titles, not the names.
577 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
578 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
579 and the names as the values.
580 * src/main/java/org/glom/web/server/ConfiguredDocument.java
581 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
582 group now that we provide the report name, so it should always
585 2012-02-15 Murray Cumming <murrayc@murrayc.com>
587 Depend on jasperreports.
589 * pom.xml: Add the dependency. My plan is to use this on the
592 2012-01-31 Murray Cumming <murrayc@murrayc.com>
594 Implement navigation to report places.
596 * src/main/java/org/glom/web/client/activity/ReportActivity.java
597 start(): Do not bother to handle all events here.
598 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
599 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
600 Added getSelectedReport().
601 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
602 .java: start(): When handling a change to the reports chooser,
603 call getSelectedReport() and goTo() its ReportPlace.
604 * src/main/java/org/glom/web/client/ui/ReportView.java
605 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
606 Added setReportHTML() which puts the html in a gwt HTML widget.
607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
608 getReportHTML(): Return "TODO" just to show that this works.
610 2012-01-31 Murray Cumming <murrayc@murrayc.com>
612 Make ReportPlace usable.
614 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
616 * src/main/java/org/glom/web/client/place/ReportPlace.java:
617 Correct the @prefix annotation.
619 2012-01-31 Murray Cumming <murrayc@murrayc.com>
621 OnlineGlomService: Return report HTML rather than the LayoutGroup.
623 * src/main/java/org/glom/web/client/OnlineGlomService.java:
624 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
625 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
626 Change getReportLayout() to getReportHMTL() because we will not need to
627 parse or render the report layout on the client side.
628 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
629 getReportLayout(): Return the libglom LayoutGroup type because we will
630 not need to convert to a shared type, because this will not be used on
632 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
635 Note that there is still no implementation for this.
638 2012-01-27 Murray Cumming <murrayc@murrayc.com>
640 Add a (empty) Report Place, View, and Activity.
642 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
644 * src/main/java/org/glom/web/client/place/HasTablePlace.java
645 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
646 this into a superclass:
647 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
648 and also use it as the base of this new ReportPlace:
649 * src/main/java/org/glom/web/client/place/ReportPlace.java
651 * src/main/java/org/glom/web/client/ui/ReportView.java
652 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
653 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
654 Add these, containing mostly boiler-plate for now.
656 * src/main/java/org/glom/web/client/OnlineGlomService.java
657 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
658 * src/main/java/org/glom/web/server/ConfiguredDocument.java
659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
660 Add API to get the LayoutGroup for the report.
662 2012-01-23 Murray Cumming <murrayc@murrayc.com>
664 Add and fill a Reports drop-down list box.
666 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
668 * src/main/java/org/glom/web/client/OnlineGlomService.java:
669 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
670 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
671 Added getReports(document, table, localeID), calling
672 ConfiguredDocument.getReports().
673 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
675 Added setReportsList() and a list widget.
676 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
677 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
682 2012-04-12 Murray Cumming <murrayc@murrayc.com>
684 Translations: Add Esperanto.
686 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
687 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
688 properties: Add this translation because someone took the time to make it.
690 2012-03-15 Murray Cumming <murrayc@murrayc.com>
692 Adapt to the java-libglom 1.21.7 API.
694 * src/main/java/org/glom/web/server/ReportGenerator.java:
695 addToReport(): get_group_secondary_fields() is now
696 get_secondary_fields().
699 2012-03-15 Murray Cumming <murrayc@murrayc.com>
701 Use the latest java-libglom version.
703 * pom.xml: Use java-libglom 1.21.7.
705 2012-03-03 Ben Konrath <ben@bagu.org>
707 Display date and time in details view.
709 https://bugzilla.gnome.org/show_bug.cgi?id=671257
711 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
713 2012-03-05 Murray Cumming <murrayc@murrayc.com>
715 Require the latest java-libglom.
717 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
719 2012-03-04 Murray Cumming <murrayc@murrayc.com>
721 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
723 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
724 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
725 an empty quickfind string. I also corrected libglom to create only
726 empty where clauses for empty quickfind strings, but this avoids the
729 2012-02-24 Ben Konrath <ben@bagu.org>
731 Improve the tabs in the Notebook widget.
735 2012-01-30 Murray Cumming <murrayc@murrayc.com>
737 Translations: Try to translate the strings.
739 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
740 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
741 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
742 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
743 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
744 Take the Open translation from GTK+'s .po files.
745 Take the Details translation from Glom's po files.
746 I have added the other strings to Glom so we can get translations that way:
747 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
749 2012-01-27 Murray Cumming <murrayc@murrayc.com>
751 TableSelectionViewImpl: Put the search label and entry in a div.
753 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
754 Put the search widgets in a FlowTable so that the CSS can be used to
755 style them while keeping them together.
756 * src/main/webapp/style.css: Mention the new div.
758 2012-01-27 Murray Cumming <murrayc@murrayc.com>
760 Translate more strings in more locales.
762 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
763 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
764 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
765 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
766 Translate the "Details" and "Open" string too.
768 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
769 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
770 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
771 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
772 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
773 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
774 Add these new locales as placeholders though they currently contain English.
776 2012-01-27 Murray Cumming <murrayc@murrayc.com>
778 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
781 Check the ConfiguredDocument* for null before using it.
783 2012-01-26 Murray Cumming <murrayc@murrayc.com>
785 Tell Eclipse about the generated java files.
787 * .classpath: This lets it find OnlineGlomConstants.java.
788 It would be nice if Eclipse just used the maven build files.
790 2012-01-26 Murray Cumming <murrayc@murrayc.com>
792 Prevent a crash when no locale is specified in the URL.
794 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
795 Avoid returning a null string, obtained from
796 Window.Location.getParameter(). This caused a crash when it was
797 later passed to libglom's API.
798 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
799 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
800 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
801 guard against future null strings.
803 2012-01-26 Murray Cumming <murrayc@murrayc.com>
805 Use the ?locale= query param instead of the &lang= token param.
807 * src/main/java/org/glom/web/client/place/ListPlace.java
808 * src/main/java/org/glom/web/client/place/DetailsPlace.java
809 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
810 Remove the lang token key and value.
812 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
813 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
814 When the user selects a different locale from the chooser, use
815 Window.Location.assign() to change the URL, which then causes a reload.
817 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
818 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
819 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
820 * src/main/java/org/glom/web/client/activity/ListActivity.java
821 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
822 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
823 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
824 * src/main/java/org/glom/web/client/ui/ListView.java:
825 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
827 Remove localeID member variables and method/constructor parameters, instead
828 using Utils.getCurrentLocaleID() when we need a localID to pass to
831 2012-01-26 Murray Cumming <murrayc@murrayc.com>
833 Internationalize the UI strings.
835 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
836 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
837 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
838 because it is unused. Messages are apparently strings that can have
839 parameters, but we do not need that yet, so Contants will be enough for now.
840 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
841 to say that we support the en and de locales.
842 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
843 The original English strings.
844 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
845 Some German translations of the English strings.
846 The i18n goal then uses the .properties file to generate an
847 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
848 returns an implementation that returns the translated strings.
849 The documentation suggests putting these in src/java/*/client/, but it seems
850 best to put it in src/resources/*/client/.
851 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
852 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
853 instead of hard-coding them.
854 Note that we cannot import OnlineGlomConstants because it does not exist yet,
855 but that does not seem to stop the build, though it confuses Eclipse.
857 You can see the translated string by adding ?locale=de to the URL, like so:
858 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
860 2012-01-24 Murray Cumming <murrayc@murrayc.com>
862 Improve null/empty String checks.
864 * pom.xml: Add a dependency on commons-lang, to use
865 org.apache.commons.lang.StringUtils.
866 * src/main/java/org/glom/web/server/ConfiguredDocument.java
867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
868 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
869 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
870 Use StringUtils.isEmpty().
872 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
873 StringUtils class with a static isEmpty() function because we
874 cannot use org.apache.commons.lang.StringUtils in client-side
875 GWT code because it (apparently) cannot be compiled to javascript.
876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
877 * src/main/java/org/glom/web/client/activity/ListActivity.java
878 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
879 * src/main/java/org/glom/web/client/place/DetailsPlace.java
880 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
881 * src/main/java/org/glom/web/client/place/ListPlace.java
882 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
883 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
884 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
885 * src/main/java/org/glom/web/client/ui/details/Group.java
886 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
887 our StringUtils.isEmpty() function.
889 2012-01-24 Murray Cumming <murrayc@murrayc.com>
891 Update to the latest java-libglom API.
893 * pom.xml: Require java-libglom 1.21.4.
894 * src/main/java/org/glom/web/server/ConfiguredDocument.java
895 getDocumentInfo(), getListViewLayoutGroup():
896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
898 * src/main/java/org/glom/web/server/database/DBAccess.java
899 getFieldsToShowForSQLQueryAddGroup(),
900 getPrimaryKeyLayoutItemField(): Replace get_database_title()
901 with either get_database_title_original() or
902 get_database_title(localeID).
904 2012-01-24 Murray Cumming <murrayc@murrayc.com>
906 ConfiguredDocument: Avoid a null pointer exception.
908 * src/main/java/org/glom/web/server/ConfiguredDocument.java
909 Initialize localeID to "" to avoid returning a null String which
910 causes a crash in java-libglom's swing-generated code.
912 2012-01-23 Murray Cumming <murrayc@murrayc.com>
914 Some simple renaming.
916 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
917 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
918 for localeChooser. This seems more appropriate and is less ambiguous
919 particularly in the .css file.
921 2012-01-23 Murray Cumming <murrayc@murrayc.com>
923 ConfiguredDocument: Rename the localedID private member variable.
925 2012-01-23 Murray Cumming <murrayc@murrayc.com>
927 Adapt to the latest java-libglom API from git master.
929 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
930 libglom now uses only Vector instead of List, which uses add() instead of
933 2012-01-22 Murray Cumming <murrayc@murrayc.com>
935 ConfiguredDocument: Rename the localedID private member variable.
937 2012-01-20 Murray Cumming <murrayc@murrayc.com>
939 Build a source tarball with mvn assembly:single
941 * assembly.xml: Add this file.
942 * pom.xml: Use the maven-assembly-plugin and tell it to use
943 our assembly.xml file.
945 2012-01-19 Murray Cumming <murrayc@murrayc.com>
947 OnlineGlomServiceImpl: Get .glom files recursively.
949 * pom.xml: Depend on commons-io from org.apache.commons.
950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
951 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
952 files recursively, and with the easier filter for the extension.
953 Use org.apache.commons.io.FilenameUtils.removeExtension() to
954 simplify that code too.
956 2012-01-19 Murray Cumming <murrayc@murrayc.com>
958 README: Mention that you must install java-libglom packages separately.
960 But then it works, because java-libglom is now in the central maven
963 2012-01-18 Murray Cumming <murrayc@murrayc.com>
965 locales drop-down: Show the correct selected locale when the URL changes.
967 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
968 .java: setPlace(): Move some code into fillView().
970 2012-01-18 Murray Cumming <murrayc@murrayc.com>
972 locales drop-down: Do not lose the primary key.
974 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
975 start(): onLocaleChange(): Pass the current primary key value,
976 instead of an empty value.
978 2012-01-18 Murray Cumming <murrayc@murrayc.com>
980 locales drop-down: Do not lose the drop-down selection.
982 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
983 .java (TableSelectionActivity.fillView): Set the selected locale
984 after changing the drop-down items (though we do not really need
985 to change them just because the locale changes.)
987 2012-01-18 Murray Cumming <murrayc@murrayc.com>
989 locales drop-down: Change the tables list when this changes.
991 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
992 .java: TableSelectionActivity.start(): Move the async table titles
993 retrieval into a private fillView() method and also call this when
994 the chosen locale changes.
995 Note that the document title is not actually translatable yet, but
996 that is a problem that I should fix soon in libglom.
998 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1000 Improve the placement of the locales drop-down.
1002 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1003 Put the title and locales drop-down in a div (gwt.FlowTable).
1004 * src/main/webapp/style.css: Add magic css properties to make this work.
1005 Also remove the left margin from the title so that it lines up with the
1008 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1010 locales selector: Show human-readable locale titles.
1012 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1013 getDocumentInfo(): Use java.util.Locale to show a real title of
1014 each locale, in the locale's own language.
1016 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1018 Add a language/locale selector drop-down.
1020 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1021 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1022 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1023 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1024 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1025 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1026 Add a ListBox to show the available locales. Add getLocaleSelector(),
1027 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1028 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1029 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1030 java: Add these classes.
1031 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1032 start(): Fill the locales ListBox. Handle its change event, firing a
1034 setPlace(): Show the selected locale as specified by the URL token.
1035 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1036 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1037 Handle LocaleChangeEvent, going to a new *Place with that locale.
1039 The placement of the ListBox is not pretty, and it currently uses the ID
1040 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1044 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1046 Search box: Show the search text from the URL token.
1048 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1049 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1050 Add setQuickFindText().
1051 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1052 .java: setPlace(): Store the queryText if the place is a ListPlace,
1053 and call TableSelectionView.setQuickFindText().
1055 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1057 Allow use of translations via, for instance, &lang=de in the URL.
1059 * pom.xml: Use the unstable java-libglom 1.21 version.
1061 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1062 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1064 init(): Instead of calling TranslatableItem.set_current_locale()
1065 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1066 However, this is only for default locales, which are not needed to
1067 change the locale in the URL.
1068 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1069 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1070 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1071 layout for a particular locale.
1072 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1073 Add get/setDefaultLocaleID().
1074 getDocumentInfo(), getListViewData(), getRelatedListData(),
1075 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1076 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1077 localeID parameter, so we can get the layout for a particular locale.
1079 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1080 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1081 * src/main/java/org/glom/web/client/place/ListPlace.java:
1082 Parse and construct a lang parameter too.
1084 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1085 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1086 passed to subsequent methods and constructors.
1087 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1088 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1089 Store the localeID from the *Place and pass it to other constructors
1090 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1092 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1093 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1094 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1095 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1096 * src/main/java/org/glom/web/client/ui/ListView.java:
1097 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1098 Take localeID parameters and pass them to subsequent constructors and
1099 methods, so that the layout is always retrieved for that locale.
1101 This is rather repetitive.
1103 Note that "" means the original (default) locale of the Glom document,
1104 which is usually English.
1106 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1108 Documents: Remove final keyword to fix startup configuration.
1110 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1111 final keywords on the private member variables because that breaks
1112 the startup, apparently (there are warnings) because it stops them
1113 from being serialized. I added these in the previous commit.
1115 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1117 Documents: Add some final keywords.
1119 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1122 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1124 OnlineGlomServiceImpl: Add to overview comments.
1126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1127 Note that this is where all the document are loaded. They are not
1128 loaded freshly for each page.
1130 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1134 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1135 Add a TextBox for the text of a quick find.
1136 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1138 setBackLink(): Add a String quickFind parameter.
1139 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1140 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1141 to the base interface, because that is how TableSelectionViewImpl is used.
1142 * src/main/webapp/style.css: Add style for the search box and its label.
1144 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1145 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1146 Add these files, based on the existing TableChangeEvent and
1147 TableChangeEventHandlers.
1148 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1149 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1150 a ListPlace() that the user should be taken to.
1151 * src/main/java/org/glom/web/client/activity/ListActivity.java
1152 start(): Handle it here too and adapt the TableChangeEvent handler to
1153 pass the extra "" quickFind parameter to ListPlace.
1154 * src/main/java/org/glom/web/client/place/ListPlace.java:
1155 Constructor: Take an extra String quickFind parameter and store it,
1156 returning it from a new getQuickFind() method.
1157 getToken(): Put the quickFind text in the URL token.
1158 getPlace(): Parse the quickFind text from the URL token.
1159 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1160 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1161 ListPlace constructor.
1162 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1163 .java: start(): Add a Change handler for the TableSelectionView's
1164 TextBox (via its base HasChangeHandlers interface), firing the new
1165 QuickFindChangeEvent.
1166 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1167 pass the extra "" quickFind parameter.
1169 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1170 setCellTable(): Add a String quickFind parameter and pass it to
1171 the ListViewTable() constructor.
1172 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1173 setCellTable() in the base interface, because that is how ListViewImpl
1176 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1177 Add a String quickFind member variable.
1178 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1179 Constructor: Add a String quickFind parameter, storing it in the
1180 base ListTable's member variable.
1181 onRangeChanged(): Pass quickFind to the
1182 OnlineGlomServiceAsync.getSortedListViewData() and
1183 OnlineGlomServiceAsync.getListViewData() methods.
1185 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1186 getListViewData(), getSortedListViewData(): Add a String quickFind
1187 parameter, passing it to ConfiguredDocument.getListViewData().
1188 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1189 Change getListViewData(), getSortedListViewData() in the base interface,
1190 because that is how OnlineGlomServiceImpl is used, via this:
1191 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1192 Change getListViewData(), getSortedListViewData() here too.
1193 This class can apparently be used to asynchronously call methods on
1194 OnlineGlomService, and GWT seems to implement that after recognizing
1195 just the *Async name convention and the extra AsyncCallback parameters.
1197 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1198 getListViewData(): Add a String quickFind parameter, and pass it to
1199 ListViewDBAccess.getData().
1200 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1201 getListData(): Add a String quickFind parameter and pass it to
1203 getSelectQuery(): Add a String quickFind parameter.
1204 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1205 getSelectQuery(): Add a String quickFind parameter and use it with
1206 Glom.get_find_where_clause_quick() to pass a where_clause to
1207 Glom.build_sql_select_with_where_clause(), to actually filter the
1209 getData(): Add a String quickFind parameter, passing it to getListData().
1210 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1211 va: getData(): Pass an empty string to getListData() for the
1212 quickFind parameter.
1214 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1216 ListTable: Minor change.
1218 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1219 createCellTable(): Make this protected instead of public.
1221 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1223 Many files: Use final for the parameters and use the @override attribute.
1225 2012-01-22 Ben Konrath <ben@bagu.org>
1227 Add anchor links for single line text that starts with http, ftp and www.
1231 2012-01-22 Ben Konrath <ben@bagu.org>
1233 Add ellipsis to single line text in details view.
1237 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1239 Remove all javadoc author tags.
1241 Because they are awkward and meaningless when many people touch
1243 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1245 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1247 Revert the COPYING.LESSER to COPYING rename.
1249 Apparently both should be there if it is LGPL.
1251 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1253 *View: Remove unused imports.
1255 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1256 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1257 * src/main/java/org/glom/web/client/ui/ListView.java:
1258 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1259 Remove unused imports, as suggested by Eclipse.
1261 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1263 Move the *View::Presenter types, and some API into one base View.
1265 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1266 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1267 * src/main/java/org/glom/web/client/ui/ListView.java:
1268 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1269 Presenter, setPresenter() and clear() into a shared base interface,
1270 to avoid the unnecessary duplicate Presenter types and to more clearly
1271 show how the *Views share the same structure, even if they are not
1272 used polymorphically.
1274 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1275 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1278 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1279 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1281 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1284 Feel free to revert this if there is a good reason for the duplicate
1287 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1289 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1291 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1292 a class member instead of a local variable in the method.
1293 This lets us use it to get the view instances, for use in tests.
1294 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1295 beforeOnlineGlom(): Test some more details of the initial view.
1296 Again, this is not very useful.
1298 To really test gwt-glom we will need to start a local postgresql
1299 instance with local data, like the Glom tests in C++.
1301 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1303 pom.xml: Mention the LGPL license.
1305 * pom.xml: Add a licenses section.
1306 * COPYING.LESSER: Move this to COPYING, which
1307 previously contained the GPL. But gwt-glom is all LGPL.
1309 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1311 Add project information to README and pom.xml.
1313 * README: Add a brief description and mention some mvn
1315 * pom.xml: This extra information shows up in mvn site
1318 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1320 Use the latest java-libglom version.
1322 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1324 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1326 GwtTestOnlineGlom: Test a little more.
1328 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1329 protected rather than private, as suggested by the gwt-test-utils
1331 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1332 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1333 Test the initial visibility of the panels.
1335 However, this is not a very useful test.
1336 And I wonder how we should generally test using this idea for an
1337 activity/places app like ours where the real changes happen implicitly
1338 based on the history token/URL.
1340 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1342 Slight modification to *Mapper comments.
1344 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1345 (DataActivityMapper)
1346 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1348 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1350 Remove comments mentioning GIN because they are just copied from
1351 the example code and are apparently not helpful:
1352 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1353 Also change the mention of a class that is only in the example code.
1355 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1357 GwtTestOnlineGlom test: Minor changes.
1359 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1360 Avoid the long qualified class name and modify the comment
1361 because it is now obvious to me that the mocked class is the only
1362 custom one created via GWT.create().
1364 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1366 Tests: Added the beginnings of a test using gwt-test-utils.
1368 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1369 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1370 which tells gwt-test-utils what class will be tested.
1371 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1372 Add a simple (but empty) test case. One class, used by the OnlineGlom
1373 class, is mocked so that it can be created. However, I am not sure
1374 why only this class needs to be mocked.
1376 Note that mockito seems more popular, and clearer, than easymock,
1377 but I have not got that working yet. It might be a matter of the
1380 This test is run during mvn integration-test.
1382 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1384 Tests: Use junit4-style syntax instead of junit3-style.
1386 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1387 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1388 * src/test/java/org/glom/web/shared/DataItemTest.java:
1389 Use the @Test annotation rather than relying on the test*() prefix.
1390 Also no longer implement TestCase, to avoid triggering support for
1391 the junit3-way, which stops the annotations from working.
1392 Change the imports from import junit.framework.* to
1393 import org.junit.*, which is apparently the new way.
1395 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1397 Added a test for ListPlace token parsing and creation.
1399 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1400 This is much the same as DetailsPlaceTest.
1402 I wonder how we could test the other parts of the *Place API.
1404 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1406 DetailsPlace test: Also test getToken() and recreation via getPlace().
1408 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1409 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1410 recreate it, testing the recreated DetailsPlace for the same parameter
1413 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1415 Use the surefire-report plugin.
1417 * pom.xml: This generates a HTML report about the tests in
1418 target/site/surefire-report.html
1419 when you do mvn surefire-report:report. It seems to be popular/normal.
1421 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1423 Added a test for DetailsPlace.
1425 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1426 Test the getPlace() token parsing.
1428 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1430 Added a first unit test.
1432 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1433 * src/test/java/org/glom/web/shared/DataItemTest.java:
1434 This is a silly test but it is just to get things started. Note that
1435 maven/junit finds the test because it looks in src/test by default.
1437 2011-12-22 Ben Konrath <ben@bagu.org>
1439 Change charsetName to "UTF-8" when replacing line breaks.
1441 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1442 that work in Java (such as "UTF8") will not work when compiled to
1445 This fixes a problem with multi-line details view fields that have hard
1446 line breaks. The "License Text" field on this page demonstrates the
1449 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1451 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1453 2011-12-22 Ben Konrath <ben@bagu.org>
1455 Fix another bug with related list navigation.
1457 I've tested all the navigation buttons in all of the related lists
1458 so things should be good now.
1460 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1462 2011-12-22 Ben Konrath <ben@bagu.org>
1464 Fix a crasher when refreshing the list view with the default table.
1466 This crash will also happen when loading the list view with the default
1467 table from a link or bookmark.
1469 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1470 to the main document selection page when the document id hasn't been
1472 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1473 the main document selection page when the document id hasn't been
1475 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1476 values for the details place when the document id hasn't been set.
1477 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1478 values for the list place when the document id hasn't been set.
1480 2011-12-21 Ben Konrath <ben@bagu.org>
1482 Protect against NPE when glom.document.locale is not in config.
1484 This patch protects against an NPE when glom.document.locale is not in
1485 the config file. This NPE will also happen if glom.document.locale is
1488 The patch also updates the error message to display the class name when
1489 the getMessage() returns null. This was happening when the NPE was
1490 thrown and I had "Configuration Error: null". If an NPE is encountered
1491 with this patch, "Configuration Error: NullPointerException " will be
1494 This commit closes this bug:
1496 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1498 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1500 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1502 Rename onlineglom.properties to onlineglom.properties.sample.
1504 * src/main/resources/onlineglom.properties: Rename to:
1505 * src/main/resources/onlineglom.properties.sample:
1506 * src/main/resources/README: And add this file explaining that people
1507 should rename it back when deploying.
1509 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1511 Allow choosing the translation in the .properties file.
1513 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1514 init(): Read a glom.document.locale value from the configuration file
1515 and call Glom's TransatableItem::set_current_locale() method.
1516 * src/main/resources/onlineglom.properties: Add a commented-out
1517 example of this new setting.
1519 It would be better to add &lang=de_DE to the URL, but the current
1520 libglom API does not allow us to do this easily. I am working on that.
1522 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1524 Avoid a crash in parsing of token parameters.
1526 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1527 ava: getTokenParams(): Do not crash if a parameter has a key but no
1528 value, and ignore parameters with neither.
1530 2011-12-17 Murray Cumming <murrayc@murayc.com>
1532 History token building/handling: Improve use of token parameters.
1534 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1535 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1536 and buildParamsToken(HashMap), for use by derived classes.
1537 Make the separator private because it is no longer be needed.
1538 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1539 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1540 instead of manual string concatenation.
1541 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1542 of hardcoded indices and awkward splitting code.
1543 * src/main/java/org/glom/web/client/place/ListPlace.java
1544 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1545 instead of manual string concatenation.
1546 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1547 of hardcoded indices and awkward splitting code.
1548 This should fix bug #666420
1550 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1552 Fix a Navgiation->Navigation typo in the code.
1554 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1555 Rename processNavgiation() to processNavigation().
1557 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1559 Fix a seperator->separator typo in the code.
1561 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1562 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1563 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1566 2011-12-15 Ben Konrath <ben@bagu.org>
1568 Cleanup some comments.
1570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1572 2011-12-14 Ben Konrath <ben@bagu.org>
1574 Replace \n with <br/> for multiline text in the details view.
1576 Vertical scrollbars are added when needed as well.
1578 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1580 2011-12-14 Ben Konrath <ben@bagu.org>
1582 Specify the font for document selection links.
1584 * src/main/webapp/style.css:
1586 2011-12-14 Ben Konrath <ben@bagu.org>
1588 Fix bouncy CellTable while paging.
1590 This doesn't currently work with related list tables in unselected
1593 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1595 2011-12-14 Ben Konrath <ben@bagu.org>
1597 Revamp the appearance of the document selection page.
1599 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1600 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1601 * src/main/webapp/style.css:
1603 2011-12-13 Ben Konrath <ben@bagu.org>
1605 Set navigation button column to the smallest size possible.
1607 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1609 2011-12-13 Ben Konrath <ben@bagu.org>
1611 Change OpenButton nomenclature to NavigationButton.
1613 Using NavigtionButton makes things more generic. Classes, methods and
1614 variables have been changed.
1616 This is a rename-only refactor.
1618 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1619 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1620 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1621 Renamed from OpenButtonCell.
1622 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1623 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1624 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1626 2011-12-12 Ben Konrath <ben@bagu.org>
1628 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1630 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1631 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1632 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1633 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1635 2011-12-12 Ben Konrath <ben@bagu.org>
1637 Update variable names and comments.
1639 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1640 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1642 2011-12-12 Ben Konrath <ben@bagu.org>
1644 Properly initialize numNonEmptyRows variable to zero.
1646 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1647 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1649 2011-12-05 Ben Konrath <ben@bagu.org>
1651 Add latest mockup with HTML tables.
1653 Features of this mockup:
1655 -> HTML table for flowtable
1656 -> HTML table for flowtable column
1657 -> Example of how related lists would look
1658 -> Not using text entries for data items
1660 The current version of Online Glom doesn't use HTML tables for the
1663 This mockup has been sent to the glom-devel mailing list but it's good
1664 to have it here as well.
1666 * mockups/details-view-html-tables.html:
1668 2011-12-05 Ben Konrath <ben@bagu.org>
1670 Remove unnecessary getPrimaryKeyField() method.
1672 getPrimaryKeyFieldForTable(String) has been renamed to
1673 getPrimaryKeyField(String).
1675 * src/main/java/org/glom/web/server/database/DBAccess.java:
1676 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1677 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1679 2011-12-05 Ben Konrath <ben@bagu.org>
1681 Add string representation of TypedDataItem value to conversion error message.
1683 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1684 message was extracted into its own method to avoid duplication.
1686 2011-12-05 Ben Konrath <ben@bagu.org>
1688 Add type checking to navigation primary key value creation.
1690 Create navigation primary key only if the expected type from the Glom
1691 document matches the type returned by the SQL query.
1693 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1695 2011-12-05 Ben Konrath <ben@bagu.org>
1697 Rename a couple of variables in RelatedListNavigation.
1699 This is a rename-only refactor.
1701 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1703 2011-12-05 Ben Konrath <ben@bagu.org>
1705 Move getListLayoutGroup() into getListViewLayoutGroup().
1707 This removes getListLayoutGroup(). It was only being called by
1708 getListViewLayoutGroup().
1710 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1712 2011-12-05 Ben Konrath <ben@bagu.org>
1714 Remove check for LayoutItem_Portal in list table method.
1716 This check is no longer necessary because the method isn't being used
1717 to create the LayoutItemPortal DTO.
1719 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1721 2011-12-05 Ben Konrath <ben@bagu.org>
1723 Properly support related list navigation.
1725 Navigation from the "Repository Analyzer -> Package Scans ->
1726 Dependencies" related table wasn't working because the primary key for
1727 related tables wasn't being set properly. This commit fixes the
1730 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1731 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1732 doesn't set the primary key properly for related list tables.
1733 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1734 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1735 useful for getting the primary key for list view tables and for related
1737 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1738 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1739 Move code to set the primary key for the table from the abstract
1740 ListDBAccess class to ListViewDBAccess as it's only correct for list
1742 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1743 Properly add primary key to related list tables.
1745 2011-12-02 Ben Konrath <ben@bagu.org>
1747 Properly set the horizontal alignment of fields.
1749 This fix is for both the list tables and the details view.
1751 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1752 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1753 to set the horizontal alignment of fields.
1755 2011-12-02 Ben Konrath <ben@bagu.org>
1757 Display currency codes in the details view.
1759 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1761 2011-12-02 Ben Konrath <ben@bagu.org>
1763 Avoid duplicate JNI call.
1765 JNI is not as efficient as pure Java and this is an easy (and small)
1768 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1769 Use previously retrieved value for whereClauseToTableName instead of
1772 2011-12-02 Ben Konrath <ben@bagu.org>
1774 Rename a couple of variables in RelatedListNavigation.
1776 This is a rename-only refactor.
1778 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1780 2011-12-02 Ben Konrath <ben@bagu.org>
1782 Indicate clearly that a mismatched primary key type is a bug.
1784 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1785 warning to error. Add 'This is a bug.' to message.
1787 2011-12-02 Ben Konrath <ben@bagu.org>
1789 Update / fix some comments.
1791 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1793 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1795 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1796 Fix comments. Add some TODOs.
1798 2011-12-02 Ben Konrath <ben@bagu.org>
1800 Enable navigation to details view with string primary key from related list.
1802 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1803 Create a text primary key value when return type of result is
1804 java.sql.Types.VARCHAR.
1806 2011-12-02 Ben Konrath <ben@bagu.org>
1808 Use checkboxes for booleans in the details view.
1810 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1812 2011-12-01 Ben Konrath <ben@bagu.org>
1814 Improve performance of related list height calculation.
1816 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1817 Put code to calculate the expected height in a static initializer so
1818 that that it's only called once.
1820 2011-12-01 Ben Konrath <ben@bagu.org>
1822 Show related list tables in notebooks (again).
1824 Calculate the height of the related list tables so the Notebook can be
1825 set the correct height. The height of the related list table is also needed by
1826 FlowTable to be able decide how to create the layout.
1828 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1829 and set the Portal height based on the height of the related list
1830 table and the Portal container.
1831 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1832 Add method to calculate the height of the related list tables.
1833 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1834 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1835 calculate the height of the Pager widget.
1837 2011-12-01 Ben Konrath <ben@bagu.org>
1839 Use CellTable API for table property instead of setting style on Element.
1841 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1843 2011-12-01 Ben Konrath <ben@bagu.org>
1845 Make ListViewTable and RelatedListTable a consistent height.
1847 The tables are now a consistent height regardless of the contents of
1848 the table. A hidden button is added to empty rows to ensure that the
1849 height of these rows will match the height of rows with data.
1851 A navigation button column is now added to every table. The width of
1852 the navigation column is set to 0px when a RelatedListTable shouldn't
1853 have navigation buttons. This maintains the a consistent row height in
1854 tables that don't show the navigation buttons.
1856 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1857 navigation column when not needed.
1858 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1859 arguments for navigation button to constructor of ListViewTable.
1860 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1861 hidden button for empty data rows.
1862 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1863 arguments for navigation button to constructor.
1864 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1865 create navigation buttons. Add hideNavigationButtons() method.
1866 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1867 arguments for navigation button to constructor.
1869 2011-12-01 Ben Konrath <ben@bagu.org>
1871 Use 'visibility: hidden' in Utils.getWidgetHeight().
1873 This is better choice because hidden elements are invisible, don't
1874 respond to events and are not part of the tab order. They will,
1875 however, take up space which is required to be able to calculate the
1876 height of the widget.
1878 * src/main/java/org/glom/web/client/Utils.java:
1880 2011-12-01 Ben Konrath <ben@bagu.org>
1882 Use Utils.getWidgetHeight() in FlowTable.
1884 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1886 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1888 2011-12-01 Ben Konrath <ben@bagu.org>
1890 Put the details css class name on the correct table column.
1892 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1894 2011-11-30 Ben Konrath <ben@bagu.org>
1896 Update for java-libglom API change.
1898 The getters and setters on FieldFormatting and NumericFormat were
1899 changed to remove the 'M'.
1901 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1903 2011-11-29 Ben Konrath <ben@bagu.org>
1905 Only allow RelatedListTables in Portals.
1907 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1909 2011-11-29 Ben Konrath <ben@bagu.org>
1911 Only create a contents panel for Portals when title is being set.
1913 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1915 2011-11-29 Ben Konrath <ben@bagu.org>
1917 Set TabLayoutPanel height based on calculated height its widgets.
1919 This is a potential fix for this bug:
1921 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1923 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1925 2011-11-29 Ben Konrath <ben@bagu.org>
1927 Align details field labels and data with the Open buttons.
1929 * src/main/webapp/style.css:
1931 2011-11-29 Ben Konrath <ben@bagu.org>
1933 Remove unnecessary <div> in the Notebook widget.
1935 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1936 method to get container FlowPanel (<div>).
1937 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1938 initWidget() method directly on the TabLayoutPanel widget instead of
1939 Group's container widget.
1941 2011-11-29 Ben Konrath <ben@bagu.org>
1943 Don't add group titles for Portals in Notebooks.
1945 This reverts the previous patch and fixes a bug I introduced with
1946 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1948 * src/main/java/org/glom/web/client/ui/details/Group.java:
1949 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1951 2011-11-28 Ben Konrath <ben@bagu.org>
1953 Remove unused boolean argument in Portal constructor.
1955 Just a code cleanup.
1957 * src/main/java/org/glom/web/client/ui/details/Group.java:
1958 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1960 2011-11-28 Ben Konrath <ben@bagu.org>
1962 Remove hack for glom 1.18 style glom files.
1964 * src/main/java/org/glom/web/client/ui/details/Group.java:
1965 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1966 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1968 2011-11-28 Ben Konrath <ben@bagu.org>
1970 Use Gda Value version of primary key to log result too large error.
1972 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1974 2011-11-28 Ben Konrath <ben@bagu.org>
1976 Don't use TypedDataItem.getText() for Unknown types from the URL.
1978 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1979 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1980 instead of getText().
1981 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1982 String field and getUnknown() method.
1984 2011-11-28 Ben Konrath <ben@bagu.org>
1986 Log an error message when the java-libglom .so is not present.
1988 The error message was being set in the exception but not logged.
1990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1992 2011-11-28 Ben Konrath <ben@bagu.org>
1994 Ignore LayoutItem_CalendarPortals.
1996 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1997 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1999 2011-11-28 Ben Konrath <ben@bagu.org>
2001 Extract method for creating the LayoutItemPortal DTO.
2003 Just breaking the code up into smaller chunks.
2005 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2007 2011-11-28 Ben Konrath <ben@bagu.org>
2011 This should have been added with the refactor. Oops!
2013 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2015 2011-11-28 Ben Konrath <ben@bagu.org>
2017 Create primary key value from URL string using type from Glom document.
2019 See this bug, comments 19 - 25:
2021 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2023 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2024 create a TypeDataItem for the primary key here when loading from a
2025 URL. Show the same string for the primary key value as was received
2026 from the URL string (when loading from a URL).
2027 * src/main/java/org/glom/web/server/Utils.java: Update method for
2028 creating the Gda Value from the TypeDataItem to properly deal with
2029 creating a Gda Value based on the Glom document type for the primary
2030 key value string when loading from a URL.
2031 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2032 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2033 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2034 Update for changed method name.
2036 2011-11-27 Ben Konrath <ben@bagu.org>
2038 Rename PrimaryKeyItem to TypedDataItem.
2040 The name PrimaryKeyItem suggests what the class should be used for.
2041 TypedDataItem is a neutral name that describes the class better.
2043 This is a rename-only refactor.
2045 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2046 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2047 * src/main/java/org/glom/web/client/Utils.java:
2048 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2049 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2050 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2051 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2052 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2053 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2055 * src/main/java/org/glom/web/server/Utils.java:
2056 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2057 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2058 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2059 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2061 2011-11-25 Ben Konrath <ben@bagu.org>
2063 Improve Gda Value conversion from PrimaryKeyItem.
2065 The value from the PrimaryKeyItem is only used if its type match the
2066 type from the glom document.
2068 * src/main/java/org/glom/web/server/Utils.java:
2070 2011-11-25 Ben Konrath <ben@bagu.org>
2072 Manually check if the java-liblgom .so is visible to the JVM.
2074 It seems that Tomcat has problems when a static initializer throws an
2075 exception. This check is done before the first method call into
2076 java-libglom so that execution doesn't continue if the .so is not
2079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2081 2011-11-25 Ben Konrath <ben@bagu.org>
2083 Improve browser configuration error messages.
2087 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2089 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2090 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2091 getConfigurationErrorMessage() method.
2092 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2093 Get and display a specific configuration error message when no Glom
2094 documents are found.
2095 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2096 Implement getConfigurationErrorMessage() method. Surround configuration
2097 code in the init() method with a try/catch block. This allows the
2098 errors to be caught while keeping the servlet available to retrieve the
2099 configuration error message.
2101 2011-11-25 Ben Konrath <ben@bagu.org>
2103 Don't use Strings to hold primary key values.
2105 The primary key values are now held in a new data object
2106 (PrimaryKeyItem) that holds type information and the primary key value
2107 using the correct type.
2109 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2110 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2112 PrimaryKeyItem instead of String to hold the primary key value.
2113 * src/main/java/org/glom/web/client/Utils.java: Remove
2114 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2115 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2116 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2117 PrimaryKeyItem instead of String to hold the primary key value. Load
2118 document selection page when the documentID has not been set correctly.
2119 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2120 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2122 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2123 Return empty string for URL instead of "null".
2124 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2125 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2126 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2127 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2128 PrimaryKeyItem instead of String to hold primary key values.
2129 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2130 PrimaryKeyValue to a Gda Value.
2131 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2132 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2133 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2134 Replace temporary database access code that uses the PrimaryKeyValue to
2135 Gda Value conversion.
2136 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2137 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2138 PrimaryKeyItem instead of String.
2139 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2140 hold primary key values.
2142 2011-11-24 Ben Konrath <ben@bagu.org>
2144 Use newly added java-libglom API to create queries.
2146 This isn't finished. I still need to stop using Strings for primary key
2147 values in the client code.
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2150 libglom to use fake connections so that retrieving the query string will
2152 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2153 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2154 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2155 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2156 Use the newly added libglom sql methods and classes to create the
2157 query. Add temporary hack to convert primary value strings to Gda
2160 2011-11-23 Ben Konrath <ben@bagu.org>
2162 Don't explicitly set the height of Portals.
2164 See comments 6 - 10 of this bug for details:
2166 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2168 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2170 2011-11-23 Ben Konrath <ben@bagu.org>
2172 Use an HTML table instead of CSS for the FlowTable layout.
2174 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2175 GWT's FlexTable to implement the FlowTable.
2176 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2178 2011-11-18 Ben Konrath <ben@bagu.org>
2180 Add boolean example to HTML table mockup.
2182 * mockups/details-view-html-tables-text-entries.html:
2184 2011-11-17 Ben Konrath <ben@bagu.org>
2186 Ensure the pager buttons are always visible for related lists.
2188 To accomplish this, I've turned off text wrapping in the list view and
2189 related list tables for both the header and data text. The related list
2190 table now has a fixed layout so the it doesn't overflow its container.
2191 This is required to ensure that the cell text is clipped when it
2192 overflows the cell and an ellipsis is added to the right side of the
2193 cell when text is clipped.
2195 A fixed table layout for the related list table in the details view
2196 seems what we want for the details view anyway, so the side-effect is
2199 The ellipsis will only be displayed in Firefox >= 7.
2203 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2205 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2206 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2207 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2209 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2210 Set the 'table-layout: fixed' CSS property to the related list table.
2211 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2212 'white-space: nowrap;' CSS property on both the list view and the
2213 related list tables.
2215 2011-11-16 Ben Konrath <ben@bagu.org>
2217 Rework the fix for empty notebook tab labels.
2219 Setting the empty group titles with its name caused problems for the
2220 details layout. Instead of using libglom's
2221 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2222 to the client when the title is empty. This allows the Notebook to use
2223 the name when the title is empty without affecting anything else.
2225 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2226 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2228 2011-11-16 Ben Konrath <ben@bagu.org>
2230 Set group titles with name when title is empty.
2232 This fixes a problem with an empty notebook tab label in the Lesson
2233 Planner document. The forth tab in the notebook should be "Internet":
2235 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2237 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2238 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2241 2011-11-16 Ben Konrath <ben@bagu.org>
2243 Remove whitespace from the configured username properties.
2245 This assumes that usernames won't have whitespace at the beginning
2246 or end. But I think this is a reasonable assumption.
2248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2249 String.trim() to remove the whitespace from the username properties.
2251 2011-11-15 Ben Konrath <ben@bagu.org>
2253 Add details view mockup with HTML tables and text entries.
2255 This is from the attachment on this bug:
2257 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2259 * mockups/details-view-html-tables-text-entries.html:
2261 2011-11-15 Ben Konrath <ben@bagu.org>
2263 Add space between the columns of the flow table.
2267 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2269 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2270 space between columns in the flow table.
2272 2011-11-15 Ben Konrath <ben@bagu.org>
2274 Add backup files to the .gitignore.
2276 * .gitignore: Ignore files that end with ~.
2278 2011-11-09 Ben Konrath <ben@bagu.org>
2280 Use latest release of gwt-log.
2282 Gwt-log releases are now being submitted to the maven central
2283 repository so manual installation of the jar is no longer required.
2285 * pom.xml: Update version and groupId of gwt-log dependency.
2287 2011-10-31 Ben Konrath <ben@bagu.org>
2289 Don't use GWT numeric formatting to override the glom currency formatting.
2291 Currencies are now displayed like they are in Glom. See this bug:
2293 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2295 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2297 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2298 currency code to constructor and set it when the cell is rendered.
2299 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2300 currency code to the constructor of the NumericCell.
2302 2011-10-27 Ben Konrath <ben@bagu.org>
2304 Require the latest release of java-libglom (1.17.4).
2308 2011-10-26 Ben Konrath <ben@bagu.org>
2310 Add style to Notebook that matches current theme.
2312 It's not the best style in the world but it's better than the default.
2314 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2315 padding at the bottom of the child widgets.
2316 * src/main/webapp/style.css: Add style for the Notebook.
2318 2011-10-26 Ben Konrath <ben@bagu.org>
2320 Move servlet initialization code to overridden init method.
2322 This is half of the solution to getting proper error messages
2323 displayed when configuration errors occur. Here's the relevant bug:
2325 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2327 The rest of the solution involves surrounding the init method with a
2328 try/catch block and setting a global variable with the error /
2329 exception. A new async method should be created to retrieve and display
2330 the error message / exception.
2332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2333 code from constructor to init method adding exceptions as needed.
2335 2011-10-26 Ben Konrath <ben@bagu.org>
2337 Add script to monitor and restart tomcat if required.
2339 * utils/check-and-recover-tomcat.py: New file.
2341 2011-10-26 Ben Konrath <ben@bagu.org>
2343 Display the correct number of data items in the pager.
2347 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2349 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2350 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2351 The implementation is the same for both tables: Keep track of the
2352 number of non-empty rows and fire and RowCountChangeEvent after the data has
2354 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2355 custom Pager class that subclasses SimplePager to handle displaying
2356 the correct number when empty rows have been added.
2358 2011-10-26 Ben Konrath <ben@bagu.org>
2360 Correct error in previous commit.
2362 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2363 eventBus parameter from listView.setCellTable().
2365 2011-10-26 Ben Konrath <ben@bagu.org>
2367 Fix error in TODO comment.
2369 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2371 2011-10-24 Ben Konrath <ben@bagu.org>
2373 Create Notebook widgets to the details view.
2375 This isn't finished just yet - I still need to create a reasonable
2376 style to match the current theme.
2378 * src/main/java/org/glom/web/client/Utils.java: Add method for
2379 calculating the height of a widget. This is used in the Notebook class.
2380 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2381 new constructor method in Group.
2382 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2383 method for creating child widget that can be used by subclasses
2384 like Notebook. New constructor that allows disabling the group
2385 titles - Notebooks don't set a group title for their child groups.
2386 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2387 to make Notebooks using GWT's TabLayoutPanel.
2388 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2389 constructor that allows disabling the group titles.
2390 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2391 LayoutItemNotebook DTO.
2392 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2393 DTO for Notebooks. It's just an empty class for now but we might need
2394 it to transfer some specific information in the future.
2396 2011-10-21 Ben Konrath <ben@bagu.org>
2398 Add navigation buttons to related list tables.
2400 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2401 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2403 method getSuitableRecordToViewDetails() for getting the table name
2404 and primary key value for related list navigation buttons.
2405 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2406 private cell renderer class to get the navigation information for
2407 related list tables from the server. Extract the navigation
2408 processing code from the details cell navigation and use it for the
2409 related list navigation as well.
2410 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2411 cell renderer class for the details open buttons. This was needed
2412 because the related list navigation buttons and the list view
2413 navigation buttons need to react differently when clicked.
2414 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2415 the onEnterKeyDown() method because it's now overriden in the
2416 subclasses that are specific to the related list tables and the list
2418 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2419 the vertical size a little because the buttons add a bit of vertical
2420 space to table. This is not a perfect solution because the vertical
2421 size of with table fewer than 5 rows will be a little smaller.
2422 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2423 changes in how navigation buttons are handled.
2424 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2425 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2426 database access object.
2427 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2428 to find the portal for a given relationship name from
2429 RelatedListDBAccess. Add method to find a primary key field for a
2431 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2432 Move code to find the portal for a given relationship name to
2434 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2435 New file: database access object for getting the related list
2436 navigation information (the table name and the primary key value).
2437 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2438 DTO for transferring a table name to navigate to and a primary key
2440 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2441 boolean and getter/setter to specifies if the related list should add
2444 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2446 Use the master branch of java-libglom
2448 * pom.xml: Depend on java-libglom 1.19 instead.
2450 This is the master branch. See also the libglom-1-18 branch.
2452 2011-10-11 Ben Konrath <ben@bagu.org>
2454 Enable the open navigation button when the data has been set.
2456 This avoids having active buttons that don't do anything when the data
2459 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2461 2011-10-11 Ben Konrath <ben@bagu.org>
2463 Use IsWidget interface for FlowTableItem.
2465 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2466 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2468 2011-10-11 Ben Konrath <ben@bagu.org>
2470 Remove GWT styling from open button in details view.
2472 There are still some issues with how the details cell is arranged but
2473 this should be made to match Glom 1.20. I'm going to leave fixing this
2474 until I have Glom 1.20 up and running.
2476 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2477 style name on open button.
2478 * src/main/webapp/style.css: Move and edit details-navigation class.
2479 Re-arrange some classes to make them appear in the same order as the
2482 2011-10-07 Ben Konrath <ben@bagu.org>
2484 Update to GWT 2.4.0.
2486 * .gitignore: Ignore new cache directory.
2487 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2488 * pom.xml: Change GWT and maven plugin to 2.4.0.
2489 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2491 * src/main/java/org/glom/web/client/ClientFactory.java:
2492 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2493 * src/main/java/org/glom/web/client/OnlineGlom.java:
2494 Update source for API changes.
2495 * utils/build-onlineglom-war.sh: Remove cache directory before the
2498 2011-10-07 Ben Konrath <ben@bagu.org>
2500 Add navigation buttons in the details view.
2502 This isn't finished but I thought I'd commit what I have as it's a
2503 pretty good start. I still need to:
2505 1. Change the style so that it fits better into the current theme
2506 2. Adjust the details cell to expand as much as possible.
2508 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2509 click handlers to navigation buttons in the DetailsCells. Create a
2510 refreshData() method to get just the data from the server without the
2512 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2513 Update the tableSelector and browser title when the table name
2514 changes without using the tableSelector.
2515 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2516 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2517 getDetailsCells() to getCells(). Update variable names.
2518 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2519 method to set click handler on navigation button. Rename a few
2520 variables. Add navigation buttons where needed.
2521 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2522 variables and methods.
2523 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2524 navigation boolean and navigation table as required in the
2525 LayoutItemField DTO.
2526 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2527 variables for navigation along with getter/setter methods.
2529 2011-10-07 Ben Konrath <ben@bagu.org>
2531 Rename Field to DetailsCell.
2533 This is a refactor-only commit. No functionality has been added or
2536 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2537 Update variable and method names.
2538 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2539 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2540 variable and method names.
2541 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2543 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2544 variable and method names.
2546 2011-10-07 Ben Konrath <ben@bagu.org>
2548 Create separate methods for layout and data the details view.
2550 This is a refactor-only commit. No functionality has been added or
2553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2554 private methods: setData(), createLayout().
2556 2011-10-07 Ben Konrath <ben@bagu.org>
2558 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2560 This is part of a change to get navigation buttons in the details view
2561 but it should have been done this way from the start.
2563 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2564 for method name change in TableSelectionView.
2565 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2566 Create TableChangeEvent and set the browser title using the
2567 TableSelectionView API.
2568 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2570 Change getSelectedTable() to getSelectedTableName(). Add
2571 getSelectedTableTitle().
2573 2011-10-07 Ben Konrath <ben@bagu.org>
2575 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2577 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2579 2011-10-07 Ben Konrath <ben@bagu.org>
2581 Update TableChangeEvent to use newTableName naming convention.
2583 This makes the class more consistent with GWT naming conventions.
2585 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2586 Update for method name change in TableChangeEvent.
2587 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2588 for method name change in TableChangeEvent.
2589 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2590 newTableName variable and getter method. Make toDebugString()
2593 2011-09-30 Ben Konrath <ben@bagu.org>
2595 Disable the pager in the list tables when the data row count is less than the minimum.
2597 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2598 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2600 2011-09-30 Ben Konrath <ben@bagu.org>
2602 Add empty rows to the end of related list and list view tables.
2604 I also extracted the cell rendering classes from the ListTable because
2605 the code was becoming a little crazy with all the anonymous inner
2606 classes. My plan is to use these cell rendering classes in the details
2607 view as well so this refactor will be needed for that change.
2609 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2610 set the row count in related list tables if the data has more rows
2611 than the minimum number of rows visible.
2612 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2613 row count in list view tables if the data has more rows than the
2614 minimum number of rows visible.
2615 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2616 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2618 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2619 for rendering TYPE_NUMERIC cells. The code was extracted from the
2621 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2622 class for rendering cells with buttons in list views. The code was
2623 extracted from the ListTable class.
2624 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2625 for rendering TYPE_TEXT cells. The code was extracted from the
2627 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2628 Add empty rows to the end of the data if required. Implement
2629 ListTable.getMinNumVisibleRows().
2630 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2631 cell renderer code to public classes. Return null in
2632 Column.getValue() for empty rows. Add new abstract method:
2633 getMinNumVisibleRows(). Move code to set the row count of the list view
2634 table to ListViewImpl.
2635 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2636 empty rows to the end of the data if required. Implement
2637 ListTable.getMinNumVisibleRows().
2640 2011-09-27 Ben Konrath <ben@bagu.org>
2642 Use GWT.log for client-side debugging statements.
2644 These are optimized out when deployed so I should have used this method
2645 in the first place. These statements will eventually be replaced with some sort
2646 of notification in the browser.
2648 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2649 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2650 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2651 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2652 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2654 2011-09-27 Ben Konrath <ben@bagu.org>
2656 Put tableselector on the right, back to list link on right.
2658 The idea is that the table selector is acting like a label for the
2659 currently displayed table so it should be placed below the document title. This
2660 puts the table title in a similar position to where it is in Glom.
2662 * mockups/details-contacts.html:
2663 * mockups/details-projects.html:
2664 * mockups/listview-contacts.html:
2665 * mockups/listview-projects.html:
2666 * mockups/style.css:
2667 Update mockups to match how the interfaces currently look.
2668 * src/main/webapp/style.css: Swap positions of backlink with the table
2669 selector. Add some space on the left side of the table selector to
2670 line things up with the document title.
2672 2011-09-27 Ben Konrath <ben@bagu.org>
2674 Add field colouring to details view.
2676 This change re-works how field colouring works. The colour formatting
2677 information is now set to the client with the layout information instead of
2678 with the data. This eliminates the need to send the same colour strings for
2679 data in list view column when colour information is set.
2681 In order to set an alternate colour for negative numeric values, the
2682 number is now sent to client and formatted with the GWT NumberFormat class.
2684 This change also fixes:
2686 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2688 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2689 internationalization framework which is needed for client side numeric
2691 * src/main/java/org/glom/web/client/Utils.java: New file for some
2692 client static utility methods.
2693 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2694 the DataItem object to the Field class. Use a utility method to
2695 create the foreignKeyValue string.
2696 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2697 alignment and text colours in the constructor. Add setData(DataItem)
2698 method. Remove setText(String) method.
2699 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2700 colour information to GlomTextCell. Create and use GlomNumberCell for
2701 rendering numbers. Use utility method to get the string for the
2702 primary key of the key provider. Re-work how the horizontal alignment
2704 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2705 formatting to layout information. Methods for converting the libglom
2706 formatting information were moved from DBAccess.
2707 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2708 numeric formatting (it's now done on the client side). Don't set text
2709 colours in DataItem. Move libglom formatting conversion methods to
2711 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2712 getters/setters for text colour information.
2713 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2714 for transferring the libglom NumericFormat information to the client.
2715 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2716 and getters/setters for: GlomNumericFormat, background colour and
2717 foreground colour strings.
2719 2011-09-26 Ben Konrath <ben@bagu.org>
2721 Simplify code that iterates through the LayoutGroup.
2723 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2725 2011-09-26 Ben Konrath <ben@bagu.org>
2727 Accept Eclipse formatting for OnlineGlomServiceAsync.
2729 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2731 2011-09-26 Ben Konrath <ben@bagu.org>
2733 Don't use the ListDBAccess classes to get the primary key layout information.
2735 This was causing a bug where the wrong index for the hidden primary key
2736 was being sent to the client.
2738 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2739 primary key while creating the LayoutGroup DTO. Create a
2740 LayoutItemField DTO for hidden primary keys. Don't use the
2741 RelatedListDBAccess because it was only used for getting the primary
2743 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2744 access modifier from public to protected for getPrimaryKeyField() and
2745 getPrimaryKeyLayoutItemField().
2746 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2747 abstract method getExpectedResultSize() because RelatedListDBAccess
2748 doesn't have enough info to implement it.
2749 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2750 Remove @Override for getExpectedResultSize().
2751 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2752 Remove method getExpectedResultSize().
2754 2011-09-23 Ben Konrath <ben@bagu.org>
2756 Log which layout (list or details) the ignored item is from.
2758 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2760 2011-09-23 Ben Konrath <ben@bagu.org>
2762 Remove annotations that turn off code formatting in DataItem.
2764 * src/main/java/org/glom/web/shared/DataItem.java:
2766 2011-09-23 Ben Konrath <ben@bagu.org>
2768 Rename GlomField to DataItem and update associated methods.
2770 This is a rename-only refactor. No functionality has been added or
2773 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2774 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2775 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2776 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2777 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2778 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2779 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2780 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2781 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2782 * src/main/java/org/glom/web/server/database/DBAccess.java:
2783 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2784 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2785 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2786 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2787 * src/main/java/org/glom/web/shared/DataItem.java:
2788 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2789 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2791 2011-09-23 Ben Konrath <ben@bagu.org>
2793 Rename GlomDocument to DocumentInfo and update associated methods.
2795 This is a rename-only refactor. No functionality has been added or
2798 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2799 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2800 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2801 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2802 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2804 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2806 2011-09-20 Ben Konrath <ben@bagu.org>
2808 Require java-libglom 1.17.3.
2810 This picks up the fix for the seg fault problem with the Scenes table
2811 in the Openismus Film Manager example.
2815 2011-09-20 Ben Konrath <ben@bagu.org>
2817 Change the way sort clause is added for primary key when no sort clause is requested.
2819 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2820 before the sort clause is created. When a sort clause is not requested, the
2821 sort clause is created by finding the primary key in the LayoutFieldVector
2824 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2826 2011-09-20 Ben Konrath <ben@bagu.org>
2828 Log error message if no documents are found in the configured directory.
2830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2831 Extract the glom file extension string to a private static final class
2832 variable (mostly as syntactic sugar). Accept a minor formatting change.
2833 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2834 the example glom.document.directory configuration property to make it
2835 more clear that it can any directory, not just the home directory.
2837 2011-09-18 Ben Konrath <ben@bagu.org>
2839 Add related lists to details view.
2841 The related list table has support for paging and sorting just like the
2842 table in the list view.
2844 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2845 SQL queries for the related list tables.
2846 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2847 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2849 Rename getList methods to getListView and add comments. Remove
2850 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2851 it being unused. Add methods: getDetailsLayoutAndData(),
2852 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2853 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2854 Create the layout and set the data for the fields in one async call
2855 instead of two. Create related lists where appropriate.
2856 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2857 for method name changes in OnlineGlomService.
2858 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2859 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2860 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2862 * src/main/java/org/glom/web/client/ui/ListView.java:
2863 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2864 tableName from setCellTable(). Create a ListViewTable instead of
2866 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2867 represent a data field in the details view.
2868 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2869 from addDetailsCell() to Field class. Keep track of the Fields and
2870 Portals in the details view.
2871 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2872 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2873 and add a method to get it. Add method to set the contents of the
2875 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2876 New class for related list tables. This class has the data provider
2877 for the related list table.
2878 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2879 abstract class which is the base class for the ListViewTable and the
2881 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2882 New class for list view tables. This class has the data provider for
2883 the list view table.
2884 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2885 methods for related list tables. Add more information to the
2886 LayoutItemField and LayoutItemPortal DTOs.
2887 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2888 Remove debugging print statement.
2889 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2890 Remove debugging print statements. Add primary key field to SQL count
2892 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2893 Remove unnecessary LayoutFieldVector parameter from
2894 getResultSizeOfSQLQuery() method.
2895 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2896 New class for related list table database access.
2897 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2898 class that is a wrapper DTO for details view layout and data.
2899 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2900 new 'fromField' string to this DTO.
2901 * src/main/webapp/style.css: Remove bottom margin and override top
2904 2011-09-15 Ben Konrath <ben@bagu.org>
2906 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2908 This sets things up to make it easier to add the data retrieval for
2909 related lists (portals). No user noticeable changes were made with
2912 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2913 class has the code to retrieve the layouts and access the
2914 database using the new database helper classes.
2915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2916 Most of the functionality has been removed from this class. This
2917 class now represents the public interface for the client side
2918 code. It also deals with configuring the servlet and cleaning
2919 things up when the servlet is stopped.
2920 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2921 of static methods into this utility class.
2922 * src/main/java/org/glom/web/server/database/DBAccess.java:
2923 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2924 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2925 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2926 These classes have the database retrieval code. The class hierarchy
2927 has been setup to make it easy to reuse code for similar
2930 2011-09-06 Ben Konrath <ben@bagu.org>
2932 Create separate classes for list table code and the data provider.
2934 As part of this refactor, I also split up the code a bit to make it
2937 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2938 table code to two new classes (below).
2939 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2940 with code from ListViewImpl.
2941 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2942 New file with code from ListViewImpl.
2944 2011-09-06 Ben Konrath <ben@bagu.org>
2946 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2948 This fixes the LayoutItemPortal DTO to match the libglom layout object
2951 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2953 2011-09-01 Ben Konrath <ben@bagu.org>
2955 Set title of Portals in the Details View.
2957 * pom.xml: Bump required version of java-libglom to 1.17.1.
2958 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2959 widget creation to its own class. Add comments to constructor.
2960 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2961 The code is mostly from the Group class with the title now set.
2962 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2963 title of Portal. Update some comments. Fix some code formatting.
2965 2011-09-01 Ben Konrath <ben@bagu.org>
2967 Remove TODO comment for the flow table column width.
2969 The flow table column width is working correctly and doesn't need to be
2970 changed. See this mailing list post for more info:
2972 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2974 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2976 2011-08-27 Ben Konrath <ben@bagu.org>
2978 Add document title (database name) to top of the browser page.
2980 I added the document title to the TableSelecitonView but that will
2981 change if / when we add a view that doesn't require table selection.
2983 * mockups/details-contacts.html:
2984 * mockups/details-projects.html:
2985 * mockups/listview-contacts.html:
2986 * mockups/listview-projects.html:
2987 * mockups/style.css: Add document title to mockups to keep things
2989 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2990 sizes to account for the document title.
2991 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2992 Set the document title when it has been retrieved from the server.
2993 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2994 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2995 and implement setDocumentTitle(String) method.
2996 * src/main/webapp/style.css: Add ID for document title style.
2998 2011-08-25 Ben Konrath <ben@bagu.org>
3000 Add NavigationType enum to LayoutItemPortal DTO.
3002 This is the start of adding support for Portals to the Details View.
3004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3005 LayoutItem_Portal.navigation_type enum from libglom to
3006 LayoutItemPortal.NavigationType enum.
3007 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3008 NavigationType enum, field for storing the NavigationType and getter
3011 2011-08-25 Ben Konrath <ben@bagu.org>
3013 Implement the flow table layout in the Details View.
3015 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3016 FlowTable to Group to account for the renamed class.
3017 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3018 File. This is a container widget that implements the Glom details view
3019 flow table behaviour.
3020 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3021 org/glom/web/client/ui/FlowTable.java.
3022 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3023 so that the size of the subgroups are a closer match to the size of
3024 the Glom subgroups. This makes the flowtable layout match the layout
3025 in Glom for the Music Collection example file.
3027 2011-08-16 Ben Konrath <ben@bagu.org>
3029 Create container element for LayoutItemPortal in Details View.
3031 This will help me develop the layout for the FlowTable.
3033 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3034 fieldPanel variable to detailsCell.
3036 2011-08-15 Ben Konrath <ben@bagu.org>
3038 Set the height of the data element in the Details View.
3040 I changed the InlineLabels (text in a span element) to Labels (text in
3041 a div element) so that I could set the height of the details-data
3042 elements instead of the details-cell parent elements. This allows the
3043 the details-data element to display the correct height if style is
3044 applied that shows the height.
3046 This change has the added benefit of allowing the order of the labels
3047 and data elements to be changed for right-to-left languages.
3049 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3050 InlineLabels to Labels.
3051 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3052 InlineLabels to Labels. Set the height of the data element.
3053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3054 multiline text height in the Formatting DTO.
3055 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3056 for multiline height along with getter and setter methods.
3057 * src/main/webapp/style.css: Adjust style to account for the change
3058 from span elements to div elements in the details cell.
3060 2011-08-15 Ben Konrath <ben@bagu.org>
3062 Make the List View appearance match the mockups.
3064 It doesn't match exactly but it's much better than it was.
3066 * mockups/listview-contacts.html: Remove unused css classes.
3067 * mockups/listview-projects.html: Remove unused css classes.
3068 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3069 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3070 for mainPanel instead of VerticalPanel (table). Set style name on
3071 CellTable. Set style name on Details column. Right-align Details
3073 * src/main/webapp/style.css: Adjust properties to match the mockups.
3075 2011-08-12 Ben Konrath <ben@bagu.org>
3077 Add better support for subgroups in the details view.
3079 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3080 changed FlowTable constructor.
3081 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3082 support for subgroups and subgroup-titles.
3083 * src/main/webapp/style.css: Add CSS class for subgroups and
3086 2011-08-12 Ben Konrath <ben@bagu.org>
3088 Return the top level LayoutGroup title.
3090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3092 2011-08-11 Ben Konrath <ben@bagu.org>
3094 Make the TableSelector header match the mockup.
3096 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3097 the layout panel. Properly lineup the table selection header with
3098 the list and details view.
3099 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3100 margin around the details view.
3101 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3102 Rename listBox variable to tableSelector. Set id for the style sheet.
3103 Use a FlowPanel instead of a HorizontalPanel.
3104 * src/main/webapp/style.css: Add properties to make the TableSelector
3105 box match the mockups.
3107 2011-07-13 Ben Konrath <ben@bagu.org>
3109 Update install script for java-libglom version change.
3111 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3114 2011-07-13 Ben Konrath <ben@bagu.org>
3116 Add support sub-group in the details view.
3118 I also removed the code that special-cased the default details view
3121 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3123 I still have to make a proper flowtable.
3125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3126 Don't special-case default details view layout.
3127 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3128 addLayoutField() as I'm going to use it.
3129 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3130 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3132 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3133 extracted from DetailsViewImpl.GroupPanel. Add support for
3135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3136 column count when getting the details layout.
3138 2011-07-12 Ben Konrath <ben@bagu.org>
3140 Set browser title with database and table titles.
3142 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3143 Set the browser title when the table changes and when the activity
3145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3146 title when retrieving document info (the GlomDocument object).
3147 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3148 with getter and setter methods. Remove unused convenience constructor.
3149 Use default code formatting.
3151 2011-07-12 Ben Konrath <ben@bagu.org>
3153 Ignore LayoutItemPortals in the details view.
3155 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3158 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3159 LayoutItemPortal layout objects.
3160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3161 LayoutItemPortal objects when retrieving the details layout.
3162 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3163 file. This is an empty class and just used to get type information for
3166 2011-07-12 Ben Konrath <ben@bagu.org>
3168 Use java-libglom 1.17.0.
3172 2011-07-11 Ben Konrath <ben@bagu.org>
3174 Remove "Table:" label from table selector.
3176 This matches a recent change in the Glom UI.
3178 * mockups/details-contacts.html:
3179 * mockups/details-projects.html:
3180 * mockups/listview-contacts.html:
3181 * mockups/listview-projects.html: Remove the "Table:" label from the
3183 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3185 2011-07-11 Ben Konrath <ben@bagu.org>
3187 Add main groups to the details view.
3189 This makes things look a little nicer in the details view. The next step
3190 is to implement the flowtable.
3192 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3193 resources from the standard gwt css theme. Standard.css is now
3194 included in OnlineGlom.html so that the online glom css rules have
3195 precedence over the gwt theme.
3196 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3197 the whole LayoutGroup to the DetailsView instead of just the titles.
3198 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3199 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3200 details layout with a helper class (GroupPanel). I might extract this
3201 class when I make the full flowtable.
3202 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3203 string as default so I don't have to worry about NPEs when processing
3205 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3206 note beside OnlineGlom.gwt.xml above).
3207 * src/main/webapp/style.css: Add default font-size to body to override
3208 the font-size set by the standard theme. Don't use h2 tags for
3209 group-title. Create new details-cell class.
3211 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3213 ConfiguredDocument: Set the port number too.
3215 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3216 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3217 Glom document. Presumably this worked sometimes so far because there is a
3218 default port number.
3220 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3222 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3224 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3225 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3226 correct, though we should throw an exception too.
3228 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3230 Fix a addDocuemnt typo.
3232 * src/main/java/org/glom/web/shared/Documents.java
3233 (Documents.addDocuemnt): Rename to addDocument().
3234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3235 (OnlineGlomServiceImpl.getDocuments): Adapt.
3237 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3239 Slightly improved log output when connection fails.
3241 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3242 (ConfiguredDocument.setUsernameAndPassword):
3243 We don't know for sure if it' the username/password that's wrong, so
3244 rephrase the message.
3245 Also ouput the exception message, though it's generic in this case.
3247 2011-07-08 Ben Konrath <ben@bagu.org>
3251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3252 added braces to a one line if statement because the Eclipse formatter
3253 was getting confused.
3255 2011-07-07 Ben Konrath <ben@bagu.org>