1 2012-07-20 Murray Cumming <murrayc@murrayc.com>
3 tests: Add a ConfiguredDocument test.
5 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
8 2012-07-20 Murray Cumming <murrayc@murrayc.com>
10 LayoutItemFIeld: getName(): Use the Field if it is set.
12 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
13 getName(): If the full field details have been set, return its name, so that
14 callers do not need to set the name separately.
15 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
16 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
17 so we can count the rows.
19 2012-07-20 Murray Cumming <murrayc@murrayc.com>
21 tests: SelfHoster: Test SqlUtils too.
23 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
24 Retrieve some data and check it too, as in the regular Glom
25 test_selfhosting_new_from_example.cc test.
26 * src/test/java/org/glom/web/server/SelfHoster.java:
27 createConnection(): Make this public.
29 2012-07-20 Murray Cumming <murrayc@murrayc.com>
31 tests: SelfHoster: createConnection(): Do not warn about expected failures.
33 Let the caller say if the connection is expected to fail, to avoid
34 irrelevant error output.
36 2012-07-20 Murray Cumming <murrayc@murrayc.com>
38 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
40 * src/test/java/org/glom/web/server/SelfHoster.java:
41 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
42 due to the inevitable need to retry the connection while the database server
45 2012-07-20 Murray Cumming <murrayc@murray.com>
47 tests: SelfHoster: createConnection(): Set a timeout.
49 * src/test/java/org/glom/web/server/SelfHoster.java:
50 createConnection(): Use setLoginTimeout() because it otherwise seems to take
51 ages to actually return when it fails.
53 2012-07-20 Murray Cumming <murrayc@murrayc.com>
55 tests: SelfHoster: selfHost(): Close the test connection.
57 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
58 When we check that the connection works, close the connection. This seems
59 to not be closed automatically otherwise.
61 2012-07-20 Murray Cumming <murrayc@murrayc.com>
63 Use slf4j-simple to see JDBC errors.
65 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
67 2012-07-19 Murray Cumming <murrayc@murrayc.com>
69 SelfHoster.discoverFirstFreePort(): Close the socket.
71 * src/test/java/org/glom/web/server/SelfHoster.java:
72 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
74 2012-07-19 Murray Cumming <murrayc@murrayc.com>
76 Avoid another code warning in Eclipse Juno.
78 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
79 Do instanceof checks on the FileUtils.listFiles() result and its
82 2012-07-13 Murray Cumming <murrayc@murrayc.com>
84 Avoid some code warnings in Eclipse Juno
86 * src/main/java/org/glom/web/server/libglom/Document.java:
87 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
88 * src/test/java/org/glom/web/server/SelfHoster.java
89 createTextFile(): Make sure that the FileOutputStream is closed.
91 2012-06-22 Murray Cumming <murrayc@murrayc.com>
93 Added OnlineGlomPropertiesTest.
95 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
96 Make sure we never return a null string.
97 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
98 Added tests of the OnlineGlomProperties API, using our sample file.
100 2012-06-20 Murray Cumming <murrayc@murrayc.com>
102 Make OnlineGlomProperties be a normal class.
104 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
105 Move OnlineGlomProperties into its own file to be a regular class:
106 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
107 This makes testing simpler.
109 2012-06-15 Murray Cumming <murrayc@murrayc.com>
111 OnlineGlomServiceImpl.init(): Move some code into a new method.
113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
114 Create addDocument().
116 2012-06-15 Murray Cumming <murrayc@murrayc.com>
118 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
121 OnlineGlomProperties.getKey(): Make this more robust by moving the
122 check for *.*.filename to here.
124 2012-06-15 Murray Cumming <murrayc@murrayc.com>
126 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
129 init(): Move knowledge of the config file format into the
130 OnlineGlomProperties inner class.
132 2012-06-15 Murray Cumming <murrayc@murrayc.com>
134 SelfHostExampleTest: Make sure we cleanup on failure.
136 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
137 the use of cleanup() to a tearDown() JUnit method.
139 2012-06-12 Murray Cumming <murrayc@murrayc.com>
141 ConfiguredDocument: Add a primary key to portals at least once.
143 * src/main/java/org/glom/web/server/ConfiguredDocument.java
144 updatePortalsExtras): Fix a typo so that we add the primary key
145 column at least once.
146 This is a fix for the previous commit:
147 ConfiguredDocument: Do not add a primary key to portals each time.
149 2012-06-08 Murray Cumming <murrayc@murrayc.com>
151 SelfHoster: Avoid some compiler warnings.
153 * src/test/java/org/glom/web/server/SelfHoster.java
154 executeCommandLineAndWait():
155 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
156 the now-unused streams for stdout and stderr from the command Processes.
157 These are not used because readln() hangs while waiting for a new line,
158 where there may be no next line. The commented out code is still there
159 to help us figure out how to do this properly.
161 2012-06-08 Murray Cumming <murrayc@murrayc.com>
163 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
165 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
166 Make this actually test the cloning again, though it is not very useful
167 now that we do not use the part that had a problem with cloning before.
169 2012-06-08 Murray Cumming <murrayc@murrayc.com>
171 SelfHoster: Keep trying pg_ctl after starting postgres.
173 * src/test/java/org/glom/web/server/SelfHoster.java
174 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
175 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
176 regular Glom. This seems mad but it seems to work because the first
177 command would fail if pg_ctl would eventually fail.
179 2012-06-08 Murray Cumming <murrayc@murrayc.com>
181 SelfHoster: Wait until the server is really ready.
183 * src/test/java/org/glom/web/server/SelfHoster.java
184 selfHost(): Attempt the connection after starting the server, retrying
185 a few times if necessary, so that the server is really ready already when
186 we return from this method.
187 The regular Glom code does this too because pg_ctl reports success too soon.
189 2012-06-08 Murray Cumming <murrayc@murrayc.com>
191 ConfiguredDocument: Do not add a primary key to portals each time.
193 * src/main/java/org/glom/web/server/ConfiguredDocument.java
194 updatePortalsExtras(): Only add an extra primary key field if there is
195 none, to avoid adding one each time we retrieve the details layout from the
197 This should fix bug #676986 (Ben Konrath)
199 2012-05-25 Murray Cumming <murrayc@murrayc.com>
201 Document.load(): Support version 7 documents.
203 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
204 database_title attribute if the title attribute is not there.
207 2012-05-24 Ben Konrath <ben@bagu.org>
209 Add configuration for auto-generating mvn:i18n from with Eclipse.
211 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
213 2012-05-24 Murray Cumming <murrayc@murrayc.com>
215 Update translations, adding French.
217 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
218 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
219 Add a French translation, using the translation from Glom.
221 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
222 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
223 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
224 Update these based on the translations from Glom.
226 2012-05-24 Murray Cumming <murrayc@murrayc.com>
228 SelfHoster: Add some debug println messages to help when things fail.
230 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
231 System.out.println() lines.
233 2012-05-23 Murray Cumming <murrayc@murrayc.com>
235 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
237 * src/test/java/org/glom/web/server/SelfHoster.java:
238 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
239 instance) instead of just /usr/bin (as on Fedora). Check the result when
242 2012-05-23 Murray Cumming <murrayc@murrayc.com>
244 Remove LayoutItemPortal.get/setNavigationTable().
246 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
247 Remove get/setNavigationTable(), which is only a cache, because it is not
248 used, and does not need to be used, because that decision should be made on
250 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
251 updatePortalsExtras():
252 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
253 getNavigationRecord():
254 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
257 2012-05-21 Murray Cumming <murrayc@murrayc.com>
259 Initial self-hosting for tests.
261 * pom.xml: Change the scope for log4j, to hopefully make it
262 available to the test code which uses it indirectly via jOOQ.
263 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
264 self-hosting, though we only use it for testing.
266 * src/main/java/org/glom/web/server/libglom/Document.java:
267 example rows: Use a map instead of a list for each row of values,
268 so we know what field they are for, instead of relying on the sequence
269 being correct. This is not very efficient, but it does not really need
271 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
272 testReadTableExampleRows(): Adapted.
274 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
275 that returns an Object, for generic use. Note that Object seems to be
276 the implicit base even of double.
277 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
278 for use in CREATE TABLE SQL queries.
279 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
280 to do self-hosting of PostgreSQL databases via its command-line
281 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
282 backends/postgres_self.cc. This is incomplete - it needs more
283 warnings about failures and it needs to clean up properly when things
285 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
286 test of this new class.
288 2012-05-21 Murray Cumming <murrayc@murrayc.com>
290 Document: loading example data: Handle exceptions.
292 * src/main/java/org/glom/web/server/libglom/Document.java:
293 DateFormat.parse() and Double.valueOf() can throw exceptions, though
294 Eclipse did not warn about that.
296 2012-05-20 Murray Cumming <murrayc@murrayc.com>
298 Document: load(), save(): Handle the example rows.
300 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
302 * src/main/java/org/glom/web/server/libglom/Document.java:
303 load(), save(): Load and save the example rows, though the date, time
304 and image types are not handled properly yet.
305 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
306 Add testReadTableExampleRows() just to check that something is read.
308 2012-05-20 Murray Cumming <murrayc@murrayc.com>
310 Document: Add save().
312 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
313 Added getTranslationsMap() for use while saving.
314 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
315 Adedd getUseDefaultFormatting() for use while saving.
316 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
317 and several private methods that it uses.
319 This will be useful while testing via self-hosting.
320 It is not complete, but should be complete enough for testing.
322 2012-05-17 Murray Cumming <murrayc@murrayc.com>
324 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
326 * src/main/java/org/glom/web/client/OnlineGlomService.java
327 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
328 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
329 Remove getSortedListViewData() and getSortedRelatedListData(), adding
330 the sort column index and ascending bool to the regular method.
331 Instead, a sort column index of -1 now means no sort.
332 This is less explicit, but it's fairly simple, reduces the amount of
333 code, and makes the OnlineGlomService API slightly smaller.
334 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
335 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
337 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
338 getListViewData(), getRelatedListData():
339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
340 getListViewData(), getRelatedListData():
341 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
343 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
345 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
350 2012-05-16 Murray Cumming <murrayc@murrayc.com>
352 Use translations for top-level groups too.
354 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
355 updateTitlesForLocale(): Use the translation for the group
356 as well as for child items.
360 Just recompiled to fix a problem in the released .tar.gz file.
364 2012-05-15 Murray Cumming <murrayc@murrayc.com>
366 Corrections to navigation to related records.
368 * src/main/java/org/glom/web/client/OnlineGlomService.java:
369 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
371 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
372 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
373 relationship name, because the relationship name is not necessarily unique
375 TOOD: This is inefficient, because it passes the whole list of
376 child field items back to the server, but it is more correct, and happens
377 to fix a bug with the primary key being lost after a few navigations.
378 There is probably a chance to make this more efficient anyway in some
381 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
382 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
383 * src/main/java/org/glom/web/server/ConfiguredDocument.java
384 * src/main/java/org/glom/web/server/database/DBAccess.java
385 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
386 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
389 2012-05-15 Murray Cumming <murrayc@murrayc.com>
391 Fix the use of translations.
393 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
394 Add updateTitlesForLocale().
395 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
396 Call it to discard unwanted translations and to make getTitle() return
397 the wanted translation wihout the need for the client code to specify a locale.
398 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
399 getTitle(): Fallback to the original title, as libglom does.
401 2012-05-15 Murray Cumming <murrayc@murrayc.com>
403 Document: Correctly report the number of available translation locales.
405 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
406 the available locale IDs list.
407 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
408 testLocales: Test this.
410 2012-05-15 Murray Cumming <murrayc@murrayc.com>
412 SqlUtils: Use camelCase.
414 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
415 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
416 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
417 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
418 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
419 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
421 2012-05-15 Murray Cumming <murrayc@murrayc.com>
423 Use jOOQ's tableByName() and fieldByName.
425 * pom.xml: Use jOOQ 2.3.1 to get the new API.
426 * src/main/java/org/glom/web/server/SqlUtils.java:
427 build_sql_select_step_with_where_clause(), .createField(),
428 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
429 so we can get correct quoting and escaping. Thanks to Lukas Eder for
430 adding this, and other things, to jOOQ.
432 2012-05-15 Murray Cumming <murrayc@murrayc.com>
434 SqlUtils: Remove the Connection parameters.
436 * src/main/java/org/glom/web/server/SqlUtils.java:
437 build_sql_select_with_key(), build_sql_select_with_where_clause(),
438 createSelect(), build_sql_select_step_with_where_clause(),
439 build_sql_count_select_with_where_clause(),
440 build_sql_select_count_rows(): Remove the Connection parameter because
441 jOOQ does not actually need a connectionwhen it is just used to build
443 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
445 * src/main/java/org/glom/web/server/ReportGenerator.java:
447 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
449 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
450 Constructor, getListData(), getResultSizeOfSQLQuery():
451 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
452 getSelectQuery(), getCountQuery():
453 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
454 getSelectQuery(), getCountQuery():
455 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
456 getNavigationRecord(): Adapted.
458 2012-05-14 Murray Cumming <murrayc@murrayc.com>
462 * src/main/java/org/glom/web/server/SqlUtils.java:
463 get_find_where_clause_quick(): Use a comparison of
464 lowercase values, instead of a simple equals. Regular Glom
465 uses the PostgreSQL ILIKE operator but jOOQ does not
466 support that just yet, though it will soon.
468 2012-05-14 Murray Cumming <murrayc@murrayc.com>
470 TableToViewDetails: Use a real serialization ID.
472 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
473 Though this does not fix the serialization problem.
475 2012-05-12 Murray Cumming <murrayc@murrayc.com>
477 Added LayoutItemPortalDeepCloneTest.
479 2012-05-11 Murray Cumming <murrayc@murrayc.com>
481 Make navigation work again.
483 * src/main/java/org/glom/web/server/libglom/Document.java:
484 Add getLayoutItemFieldShouldHaveNavigation().
485 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
486 Replace get/setAddNavigation() with the partly-existing
487 get/setNavigationTableName(), with an empty string being no navigation,
488 because this is simpler. Use the new
489 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
491 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
492 Add updateFieldsExtras() and call setNavigationTableName in it.
493 getDetailsLayoutGroup(),
494 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
495 createLayout(): Adapted.
496 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
497 Constructor: Adapted.
499 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
500 Replace get/setAddNavigation() with get/setNavigation(), returning a
501 TableToViewDetails class with both the table name and UsesRelationship,
502 because both are need. The previous code used java-libglom's output
503 variable (strangely, via sharedptr) to return both, but we cannot really
505 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
506 getNavigationRecord(): Adapt. However, we cannot actually use the cache
507 here because it somehow gets set to null during deepCopy(). I must test this.
508 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
509 testGetSuitableTableToViewDetails(): Adapted.
511 TODO: Find out why deepClone() is not quite working.
513 2012-05-11 Murray Cumming <murrayc@murrayc.com>
515 DBAccess: Simplify the retrievel of full field details.
517 * src/main/java/org/glom/web/server/database/DBAccess.java
518 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
519 because the Document loading should have done this.
521 2012-05-11 Murray Cumming <murrayc@murrayc.com>
523 Document: Correct loading of doubly-related layout fields.
525 * src/main/java/org/glom/web/server/libglom/Document.java:
526 loadUsesRelationship(): Actually set the related relationship, instead
527 of only setting it if it's not found.
529 2012-05-09 Murray Cumming <murrayc@murrayc.com>
531 Replace all appearances of Colour with color.
533 Because US English is dominant.
535 2012-05-09 Murray Cumming <murrayc@murrayc.com>
537 Use colors in HTML format, solving a warning about an unused function.
539 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
540 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
541 Add *asHTMLColor() versions of methods.
542 TODO: However, we should create and cache the results on the server.
543 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
544 * src/main/java/org/glom/web/client/ui/list/ListTable.java
545 * src/main/java/org/glom/web/server/ConfiguredDocument.java
546 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
547 Use the asHTMLcolor() versions.
549 2012-05-09 Murray Cumming <murrayc@murrayc.com>
551 ListViewTable: Constructor: Take the table name as a parameter.
553 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
554 Constructor: Take the tableName, and set the member variable, because
556 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
557 setCellTable(): Pass the table name.
558 This makes navigation to non-default tables work again. I don't know
559 why it worked before in the master branch.
561 2012-05-07 Murray Cumming <murrayc@murrayc.com>
563 ConfiguredDocument: Restore correct addition of hidden primary key items.
565 * src/main/java/org/glom/web/client/ui/list/ListTable.java
566 (ListTable.createCellTable): Uncomment out the check for the hidden
568 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
569 add primary key items for top-level lists and portals, as before,
570 instead of adding them to each group.
571 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
572 Actually implement the extra methods such as setHiddenPrimaryKey() and
573 comment that these are used only for top-level list groups and in portals.
574 This strangeness suggests even more that this should not be squeezed
575 into the LayoutGroup class.
577 2012-05-07 Murray Cumming <murrayc@murrayc.com>
579 Fix Formatting loading.
581 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
582 getFormattingUsed(): Remove the duplicate Formatting member variable
583 in favour of the one from the base class.
584 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
585 Initialize a new Formatting instead of using null by default, so we
586 have some defaults, instead of having to initialize one later just to
587 get the same defaults. This also makes loading of formatting from the
588 document work, because that expected a non-null.
590 2012-05-07 Murray Cumming <murrayc@murrayc.com>
592 RelatedListTable: Make sure that the tableName is set.
594 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
595 Constructor: Take the tableName so it is available later. Otherwise,
596 the server assumes that we mean the default table and cannot find the
598 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
599 setData(): Pass the tableName to the RelatedListTable constructor.
601 2012-05-07 Murray Cumming <murrayc@murrayc.com>
605 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
606 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
607 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
609 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
611 * src/main/java/org/glom/web/server/database/DBAccess.java:
612 convertResultSetToDTO(), getPortal():
613 * src/main/java/org/glom/web/server/database/ListDBAccess.java
615 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
616 Add checks for null objects and out of range access, with log messages to
617 give hints so we can fix these properly.
619 2012-05-07 Murray Cumming <murrayc@murrayc.com>
621 Portals: some corrections.
623 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
625 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
626 constructor: Use getRelationshipNameUsed() instead of getName(), because
627 that is what is meant.
628 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
629 getFromField(): Fix a typo, to get the field name, not the table name.
630 * src/main/java/org/glom/web/server/database/DBAccess.java:
631 getPortal(): Fix a typo that stopped this from working.
633 2012-05-07 Murray Cumming <murrayc@murrayc.com>
635 LayoutItemPortal: Also override getTitleOriginal().
637 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
638 This lets the base getTitle() with no parameters work.
639 TODO: Test this properly.
641 2012-05-06 Murray Cumming <murrayc@murrayc.com>
643 LayoutItemPortal: getTitle*(): Use the relationship title.
645 2012-05-06 Murray Cumming <murrayc@murrayc.com>
647 LayoutItemField: Fix loading of custom titles.
649 * src/main/java/org/glom/web/server/libglom/Document.java
650 loadDataLayoutItemField(): The title, if any, instead of the field
651 title, is stored in a title_custom node. Load it from there.
652 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
654 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
655 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
656 getTitle*() overrides.
657 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
660 2012-05-06 Murray Cumming <murrayc@murrayc.com>
662 LayoutItemField: Fall back to field titles, so some are really shown.
664 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
665 Override getTitleOriginal() and getTitle(), as in java-libglom.
666 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
669 2012-05-06 Murray Cumming <murrayc@murrayc.com>
671 Correct use of setExpectedResultSize().
673 * src/main/java/org/glom/web/server/ConfiguredDocument.java
674 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
675 Use setExpectedResultSize only on top-level groups (for instance, the
676 list layout) or on child portals (in details views).
677 Use the correct table name for portals to avoid SQL errors.
678 Update the expected counts when returning cached layouts.
680 2012-05-06 Murray Cumming <murrayc@murrayc.com>
682 Document: Interpret no group column count as 1.
684 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
685 default, though we now check for this in the UI code anyway.
687 2012-05-06 Murray Cumming <murrayc@murrayc.com>
691 2012-05-06 Murray Cumming <murrayc@murrayc.com>
693 Translatable: Use Hashmap instead of Treemap because GWT supports it.
695 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
696 The use of Treemap lead to this error from async methods, with no
698 "The response could not be deserialized"
700 2012-05-06 Murray Cumming <murrayc@murrayc.com>
702 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
704 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
705 when using the Google -> GWT Compile, or
706 g toolbar button -> GWT Compile Project... feature in Eclipse.
708 2012-05-06 Murray Cumming <murrayc@murrayc.com>
710 ListTable.addColumn(): Protect against a null Formatting.
712 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
713 Create a default Formatting if it is null, because that is the simplest
716 2012-05-06 Murray Cumming <murrayc@murrayc.com>
718 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
720 * src/main/java/org/glom/web/server/ConfiguredDocument.java
721 updateLayoutGroup(): Check that the field is not null.
723 2012-05-06 Murray Cumming <murrayc@murrayc.com>
725 ListViewImpl: Protected against a bad cast error.
727 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
728 onEnterKeyDown(): Do not cast without an instanceof check.
730 2012-05-06 Murray Cumming <murrayc@murrayc.com>
732 ListTable: Protect against an out of range error.
734 * src/main/java/org/glom/web/client/ui/list/ListTable.java
735 createCellTable(): This is unlikely, but can happen while debugging.
737 2012-05-06 Murray Cumming <murrayc@murrayc.com>
739 AsyncMessage onFailure() callbacks: Log the exception message.
741 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
742 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
743 * src/main/java/org/glom/web/client/activity/ListActivity.java:
744 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
745 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
746 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
747 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
748 These are useful clues when something is wrong.
750 2012-05-06 Murray Cumming <murrayc@murrayc.com>
752 ConfiguredDocument: Avoid a null dereference.
754 * src/main/java/org/glom/web/server/ConfiguredDocument.java
755 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
756 details maps are created.
758 2012-05-06 Murray Cumming <murrayc@murrayc.com>
760 Document: Correct the port number parsing.
762 * src/main/java/org/glom/web/server/libglom/Document.java:
763 This lets us actually connect to the database and show the document.
765 2012-05-05 Murray Cumming <murrayc@murrayc.com>
769 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
770 user-interaction, asking us to load a temporary URL in a browser.s
771 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
772 which is apparently necessary for testing the service. See the comment.
773 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
774 Show the exception, if any. This is how I saw the 404 in the HTML in
777 2012-05-05 Murray Cumming <murrayc@murrayc.com>
779 DocumentTest: Move the .glom files into the resources directory.
781 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
782 URI via getResource().
784 2012-05-05 Murray Cumming <murrayc@murrayc.com>
786 Document: Remove the FieldIdentifies inner class.
788 * src/main/java/org/glom/web/server/libglom/Document.java: We only
789 use the Relationship (though the same function in libglom is maybe
790 used in other ways) and so this removes a compiler warning.
792 2012-05-05 Murray Cumming <murrayc@murrayc.com>
794 Document.load() Remove the error code parameter.
796 * src/main/java/org/glom/web/server/libglom/Document.java: load():
797 Remove the parameter. We do not set it yet and it could never have
798 worked as an output parameter (though maybe it did in java-libglom).
799 We could use an exception if we really want the failure reason.
800 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
802 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
803 setUp(), testGetSuitableTableToViewDetails(): Adapt.
805 2012-05-05 Murray Cumming <murrayc@murrayc.com>
807 Make some inner classes static.
809 * src/main/java/org/glom/web/server/ConfiguredDocument.java
810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
811 * src/main/java/org/glom/web/server/ReportGenerator.java
812 * src/main/java/org/glom/web/server/libglom/Document.java
813 Make all inner classes static that can be static.
815 2012-05-05 Murray Cumming <murrayc@murrayc.com>
817 OnlineGlomServiceImpl: Do not load and check for java-libglom.
819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
820 init(): We do not use java-libglom any more.
822 2012-05-05 Murray Cumming <murrayc@murrayc.com>
824 Remove mentions of java-libglom.
826 * README: Remove mention of java-libglom, because it no longer needed.
827 * utils/build-onlineglom-war.sh:
828 * utils/check-and-recover-tomcat.py:
829 * utils/install-onlineglom-war.sh: Remove these as they are no longer
830 useful. Building is now far easier, with no need for jhbuild.
832 2012-05-05 Murray Cumming <murrayc@murrayc.com>
834 Fix the build (mvn package)
836 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
837 (LayoutGroup): Make the LayoutItemList inner class static and protected.
838 Otherwise the GWT Java->Javascript compilation fails with just this
839 error, during mvn package or when attempting to view in a browser,
840 in the GWT developer mode in Eclipse.
842 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
843 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
844 [INFO] Compiling module org.glom.web.OnlineGlom
845 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
846 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
847 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
848 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
849 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
850 [INFO] [ERROR] Cannot proceed due to previous errors
852 It has taken me 2 days to find out what was causing that. After reducing
853 the code, the compiler eventually showed me the full error message.
855 2012-05-04 Murray Cumming <murrayc@murrayc.com>
857 ConfiguredDocument: Cache the cloned and stripped layouts.
859 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
860 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
861 layout in a map, so we can retrieve it again without rebuilding it.
863 2012-05-04 Murray Cumming <murrayc@murrayc.com>
865 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
867 2012-05-04 Murray Cumming <murrayc@murrayc.com>
869 libglom classes: Implement some auto-generated emthods.
871 2012-05-04 Murray Cumming <murrayc@murrayc.com>
873 Add GwtTestOnlineGlomService.
875 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
876 However, this (and the other GwtTest*) does not seem to run during
879 2012-05-04 Murray Cumming <murrayc@murrayc.com>
881 Remove use of unsupported features from client code.
883 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
884 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
885 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
886 Use our client version of StringUtils instead of the apache commons one.
888 However, the GWT Javascript compliation still fails.
890 2012-04-25 Murray Cumming <murrayc@murrayc.com>
892 Add a Field class and implement some loading of it in Document.
894 2012-04-25 Murray Cumming <murrayc@murrayc.com>
896 Initial Document loading implementation, instead of libglom.
898 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
899 and Translatable classes, and adapt the rest of the code to use them.
900 However, this is still missing Layout and Field classes and loading.
902 2012-04-24 Murray Cumming <murrayc@murrayc.com>
904 Use of jOOQ: Move Field creation into a utility method.
906 * src/main/java/org/glom/web/server/SqlUtils.java:
907 This lets us improve it more easily.
909 2012-04-24 Murray Cumming <murrayc@murrayc.com>
911 Use of jOOQ: Improve the code to COUNT a sub-select.
913 * src/main/java/org/glom/web/server/SqlUtils.java:
914 Move initial query creation into
915 build_sql_select_step_with_where_clause().
916 build_sql_select_count_rows(): Use the jOOQ API instead of
917 concatentating text, because a jOOQ Select*Step is a TableLike,
918 which is what from() takes.
920 2012-04-23 Murray Cumming <murrayc@murrayc.com>
922 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
924 * pom.xml: Depend on jooq.
925 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
926 methods with jOOQ, based on the C++ implementations in libglom,
927 with some changes to the logic required by jooQ.
928 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
930 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
931 * src/main/java/org/glom/web/server/ReportGenerator.java:
932 * src/main/java/org/glom/web/server/SqlUtils.java:
933 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
934 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
935 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
936 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
937 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
938 Adapt. In particular, the SqlUtils methods now need to take a Connection,
939 because jOOQ needs that, though it seems unnecessary.
941 This is not quite finished. Ideally jOOQ would help us to build
942 table_name.field_name names, quoting and escaping them properly.
943 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
945 2012-04-21 Murray Cumming <murrayc@murrayc.com>
947 Move use of Glom.build_sql*() into a new SqlUtils class.
949 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
950 to wrap Glom.build_sql*(). The parameter types are still Glom one,
951 but this will make it easier to start using something other than
952 libglom or SqlBuilder.
954 2012-04-21 Murray Cumming <murrayc@murrayc.com>
956 Update the project URL.
958 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
960 2012-04-21 Murray Cumming <murrayc@murrayc.com>
962 Main layout: Use a FlowTable instead of absolute positioning.
964 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
965 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
966 child panels/widgets must have an absolute position. But that is annoying, so
967 this adds a FlowTable and puts the child panels in there.
969 2012-04-21 Murray Cumming <murrayc@murrayc.com>
971 GwtTestOnlineGlom: Comment out unused code.
973 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
974 Eclipse has started to say that some code is unused.
976 2012-04-21 Murray Cumming <murrayc@murrayc.com>
978 Update to the latest versions of dependencies.
980 * pom.xml: Update version numbers of dependencies to the latest
982 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
983 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
984 * src/main/java/org/glom/web/server/ReportGenerator.java:
985 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
986 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
987 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
989 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
990 Modify the imports where necessary.
992 2012-04-17 Murray Cumming <murrayc@murrayc.com>
994 Style: Remove overflow:hidden from searchbox
996 * src/main/webapp/style.css: Because this pushes the Back To Link
997 label/link on to the next row, which is then hidden due to the
998 hard-coded (in ems) height.
1000 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1002 Remove some duplicate code.
1004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1005 getDocumentInfo(): This must have been duplicated during the merge from the
1010 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1012 Reports: Localize the waiting for report message.
1014 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1015 start(): Get the message from the contants.
1016 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1017 Add the string here.
1018 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1019 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1020 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1021 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1022 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1023 Update these files with the English text for newer strings for now.
1025 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1027 Reports: Show a message while waiting for the report.
1029 * src/main/java/org/glom/web/client/ui/ReportView.java
1030 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1031 Add setWaitingText(), to show a message saying that we are
1032 waiting for the report to be ready.
1033 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1034 start(): Call setWaitingText() before calling the async
1037 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1039 ReportGenerator: Specify date and time formats.
1041 * src/main/java/org/glom/web/server/ReportGenerator.java:
1042 createFieldValueElement(): Use the default (and localized)
1043 short formats, though we still need a way to show 4-digit
1044 years without providing the format for every locale.
1045 * src/main/java/org/glom/web/server/database/DBAccess.java:
1046 convertResultSetToDTO(): Use the short formats here too.
1048 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1050 ReportGenerator: Use the correct numeric formatting.
1052 * src/main/java/org/glom/web/server/ReportGenerator.java
1053 createFieldExpression(), createFieldValueElement(): Take the
1054 whole LayoutItem_Field instead of just the field name, so
1055 we have access to the formatting.
1056 createFieldValueElement(): Use JRTextField.setPattern() to
1057 specify the numeric formatting, with the help of a
1058 regular DecimalFormat.
1060 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1062 ReportGenerator: Avoid showing null for group by titles.
1064 * src/main/java/org/glom/web/server/ReportGenerator.java
1065 generateReport(): Use setBlankWhenNull() on the field title
1066 style too, because this is used for values in group by
1069 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1071 ReportGenerator: Add a colon to titles in vertical groups.
1073 * src/main/java/org/glom/web/server/ReportGenerator.java
1074 addFieldToDetailBandVertical(): Pass true for the withColon
1077 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1079 ReportGenerator: Simplify the code by using Position more.
1081 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1083 Reports: Support vertical groups, roughly.
1085 * src/main/java/org/glom/web/server/ReportGenerator.java:
1086 addToReport(): Rename to addGroupToReport() and, if necessary,
1087 call the new addVerticalGroupToReport() method.
1088 createFieldValueElement(): Let the caller specify the Y position
1091 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1093 Reports: Allow a second report to be shown.
1095 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1096 clear(): Do not remove the HTML widget, which broke the whole layout.
1098 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1100 Locales drop-down: Show that we use English by default.
1102 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1103 fillView(): When we use English, just because that is the default, when
1104 no locale is specified, show that in the Locales drop-down instead of
1105 just showing the first item.
1107 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1109 Unselect the Report/Locale/Table combo item when appropriate.
1111 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1112 setPlace(): clear reportName if this is not a ReportPlace.
1113 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1114 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1115 When the provided name is empty, unselect all items, so that none are
1116 indicated. This uses a for loop because I cannot find a single method
1119 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1121 Report: Give the user a way to get back to the list.
1123 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1124 start(), setPlace(): Show the Back To List link on reports, and also
1125 interpret selecting the empty report item as back to list.
1127 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1129 Really show the selected Report name.
1131 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1132 setPlace(): Store the reportName here, if it is that kind of Place.
1133 fillView(): Set the selected Report after filling the list of reports.
1134 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1135 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1136 null Strings, though we need some way to unselect all ListBox items
1139 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1141 ReportGenerator: Try to avoid some problems.
1143 * src/main/java/org/glom/web/server/ReportGenerator.java
1144 addField(): Try to avoid duplicates, and avoid using a null
1147 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1149 Reports: Use quickFind.
1151 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1152 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1154 getReportHTML(): Add a quickFind parameter.
1155 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1156 start(): Pass the quickFind parameter.
1157 * src/main/java/org/glom/web/server/ReportGenerator.java
1158 generateReport(): Take a quickFind parameter.
1160 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1162 ReportPlace: Actually use the report name.
1164 * src/main/java/org/glom/web/client/place/ReportPlace.java
1165 getPlace(): Do not assign the report name to the quickfind.
1167 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1169 Show java.library.path when complaining.
1171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1172 init(): When telling us to check java.library.path, show the
1175 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1177 ReportGenerator: Do not show nulls.
1179 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1181 ReportGenerator: Make the title font larger.
1183 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1185 ReportGenerator: Put field titles inside groups, if there are groups.
1187 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1189 ReportGenerator: Take the Report itself instead of the name and group.
1191 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1192 Remove getReportLayoutGroup().
1193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1194 getReportHTML(): Pass the report instead
1195 of its name and layout group.
1196 * src/main/java/org/glom/web/server/ReportGenerator.java
1197 generateReport(): Use the report object to use the title
1198 instead of the name.
1200 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1202 ReportGenerator: Remove designBand parameters.
1204 * src/main/java/org/glom/web/server/ReportGenerator.java:
1205 Make designBand a class member instead of passing it to all
1208 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1210 ReportGenerator: Add lines, a bit like in the desktop version.
1212 * src/main/java/org/glom/web/server/ReportGenerator.java
1213 addToReport(): Use JRDesignLine.
1215 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1217 ReportGenerator: Correct the title positions and use some bold style.
1219 * src/main/java/org/glom/web/server/ReportGenerator.java:
1220 Break the code up into reusable functions, correct the placement of
1221 titles, and use normal/bold styles as in the reports in the desktop
1224 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1226 ReportGenerator: Add a header band to show the field titles.
1228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1229 getReportHTML(): Pass the localeId to the ReportGenerator
1231 * src/main/java/org/glom/web/server/ReportGenerator.java
1232 constructor: Take the localeID so we can get translated field
1234 generateReport(), addToReport(), addFieldToBand(): Add field
1235 titles in a column header band.
1237 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1239 Reports drop-down list: Some improvement.
1241 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1242 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1243 Adedd setSelectedReport(),
1244 setReportList(): Add a blank line so that the user can select the
1246 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1247 start(): Show the current report by calling setSelectedReport().
1248 This does not seem to work yet.
1250 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1252 DetailsActivity, ListActivity: Move some variables into a base class.
1254 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1255 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1256 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1257 the clientFactory, documentID, tableName and authenticationPopup into
1258 a base class, to avoid duplication.
1260 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1262 Translate the Reports label.
1264 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1265 Get the "Reports" label string from the constants.
1266 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1267 perties: Add Reports to the constants.
1269 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1271 Reports: Implement grouping.
1273 * src/main/java/org/glom/web/server/ReportGenerator.java:
1274 Handle LayoutItem_GroupBy items and try to do the right thing
1275 with JRDesignGroup. It seems to work.
1277 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1279 Actually show some data with JasperReports.
1281 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1282 getReportHTML(): Move most code into a ReportGenerator class.
1283 * src/main/java/org/glom/web/server/ReportGenerator.java:
1284 Recurse into sub-groups, adding fields to the JasperDesign's details
1285 band. Note that we must set an arbitrary width and height, or it just
1286 will not show any data.
1288 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1290 Reports Chooser: Show the titles, not the names.
1292 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1293 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1294 and the names as the values.
1295 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1296 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1297 group now that we provide the report name, so it should always
1300 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1302 Depend on jasperreports.
1304 * pom.xml: Add the dependency. My plan is to use this on the
1307 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1309 Implement navigation to report places.
1311 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1312 start(): Do not bother to handle all events here.
1313 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1314 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1315 Added getSelectedReport().
1316 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1317 .java: start(): When handling a change to the reports chooser,
1318 call getSelectedReport() and goTo() its ReportPlace.
1319 * src/main/java/org/glom/web/client/ui/ReportView.java
1320 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1321 Added setReportHTML() which puts the html in a gwt HTML widget.
1322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1323 getReportHTML(): Return "TODO" just to show that this works.
1325 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1327 Make ReportPlace usable.
1329 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1330 Mention ReportPlace.
1331 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1332 Correct the @prefix annotation.
1334 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1336 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1338 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1339 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1341 Change getReportLayout() to getReportHMTL() because we will not need to
1342 parse or render the report layout on the client side.
1343 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1344 getReportLayout(): Return the libglom LayoutGroup type because we will
1345 not need to convert to a shared type, because this will not be used on
1347 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1350 Note that there is still no implementation for this.
1353 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1355 Add a (empty) Report Place, View, and Activity.
1357 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1359 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1360 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1361 this into a superclass:
1362 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1363 and also use it as the base of this new ReportPlace:
1364 * src/main/java/org/glom/web/client/place/ReportPlace.java
1366 * src/main/java/org/glom/web/client/ui/ReportView.java
1367 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1368 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1369 Add these, containing mostly boiler-plate for now.
1371 * src/main/java/org/glom/web/client/OnlineGlomService.java
1372 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1373 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1374 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1375 Add API to get the LayoutGroup for the report.
1377 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1379 Add and fill a Reports drop-down list box.
1381 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1383 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1384 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1385 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1386 Added getReports(document, table, localeID), calling
1387 ConfiguredDocument.getReports().
1388 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1389 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1390 Added setReportsList() and a list widget.
1391 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1392 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1397 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1399 Translations: Add Esperanto.
1401 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1402 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1403 properties: Add this translation because someone took the time to make it.
1405 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1407 Adapt to the java-libglom 1.21.7 API.
1409 * src/main/java/org/glom/web/server/ReportGenerator.java:
1410 addToReport(): get_group_secondary_fields() is now
1411 get_secondary_fields().
1414 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1416 Use the latest java-libglom version.
1418 * pom.xml: Use java-libglom 1.21.7.
1420 2012-03-03 Ben Konrath <ben@bagu.org>
1422 Display date and time in details view.
1424 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1426 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1428 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1430 Require the latest java-libglom.
1432 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1434 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1436 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1438 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1439 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1440 an empty quickfind string. I also corrected libglom to create only
1441 empty where clauses for empty quickfind strings, but this avoids the
1444 2012-02-24 Ben Konrath <ben@bagu.org>
1446 Improve the tabs in the Notebook widget.
1450 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1452 Translations: Try to translate the strings.
1454 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1455 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1456 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1457 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1458 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1459 Take the Open translation from GTK+'s .po files.
1460 Take the Details translation from Glom's po files.
1461 I have added the other strings to Glom so we can get translations that way:
1462 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1464 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1466 TableSelectionViewImpl: Put the search label and entry in a div.
1468 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1469 Put the search widgets in a FlowTable so that the CSS can be used to
1470 style them while keeping them together.
1471 * src/main/webapp/style.css: Mention the new div.
1473 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1475 Translate more strings in more locales.
1477 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1478 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1480 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1481 Translate the "Details" and "Open" string too.
1483 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1484 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1485 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1486 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1487 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1488 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1489 Add these new locales as placeholders though they currently contain English.
1491 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1493 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1496 Check the ConfiguredDocument* for null before using it.
1498 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1500 Tell Eclipse about the generated java files.
1502 * .classpath: This lets it find OnlineGlomConstants.java.
1503 It would be nice if Eclipse just used the maven build files.
1505 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1507 Prevent a crash when no locale is specified in the URL.
1509 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1510 Avoid returning a null string, obtained from
1511 Window.Location.getParameter(). This caused a crash when it was
1512 later passed to libglom's API.
1513 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1514 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1515 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1516 guard against future null strings.
1518 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1520 Use the ?locale= query param instead of the &lang= token param.
1522 * src/main/java/org/glom/web/client/place/ListPlace.java
1523 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1524 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1525 Remove the lang token key and value.
1527 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1528 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1529 When the user selects a different locale from the chooser, use
1530 Window.Location.assign() to change the URL, which then causes a reload.
1532 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1533 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1534 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1535 * src/main/java/org/glom/web/client/activity/ListActivity.java
1536 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1537 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1538 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1539 * src/main/java/org/glom/web/client/ui/ListView.java:
1540 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1542 Remove localeID member variables and method/constructor parameters, instead
1543 using Utils.getCurrentLocaleID() when we need a localID to pass to
1546 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1548 Internationalize the UI strings.
1550 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1551 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1552 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1553 because it is unused. Messages are apparently strings that can have
1554 parameters, but we do not need that yet, so Contants will be enough for now.
1555 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1556 to say that we support the en and de locales.
1557 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1558 The original English strings.
1559 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1560 Some German translations of the English strings.
1561 The i18n goal then uses the .properties file to generate an
1562 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1563 returns an implementation that returns the translated strings.
1564 The documentation suggests putting these in src/java/*/client/, but it seems
1565 best to put it in src/resources/*/client/.
1566 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1567 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1568 instead of hard-coding them.
1569 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1570 but that does not seem to stop the build, though it confuses Eclipse.
1572 You can see the translated string by adding ?locale=de to the URL, like so:
1573 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1575 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1577 Improve null/empty String checks.
1579 * pom.xml: Add a dependency on commons-lang, to use
1580 org.apache.commons.lang.StringUtils.
1581 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1582 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1583 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1584 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1585 Use StringUtils.isEmpty().
1587 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1588 StringUtils class with a static isEmpty() function because we
1589 cannot use org.apache.commons.lang.StringUtils in client-side
1590 GWT code because it (apparently) cannot be compiled to javascript.
1591 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1592 * src/main/java/org/glom/web/client/activity/ListActivity.java
1593 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1594 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1595 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1596 * src/main/java/org/glom/web/client/place/ListPlace.java
1597 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1598 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1599 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1600 * src/main/java/org/glom/web/client/ui/details/Group.java
1601 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1602 our StringUtils.isEmpty() function.
1604 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1606 Update to the latest java-libglom API.
1608 * pom.xml: Require java-libglom 1.21.4.
1609 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1610 getDocumentInfo(), getListViewLayoutGroup():
1611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1613 * src/main/java/org/glom/web/server/database/DBAccess.java
1614 getFieldsToShowForSQLQueryAddGroup(),
1615 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1616 with either get_database_title_original() or
1617 get_database_title(localeID).
1619 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1621 ConfiguredDocument: Avoid a null pointer exception.
1623 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1624 Initialize localeID to "" to avoid returning a null String which
1625 causes a crash in java-libglom's swing-generated code.
1627 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1629 Some simple renaming.
1631 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1632 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1633 for localeChooser. This seems more appropriate and is less ambiguous
1634 particularly in the .css file.
1636 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1638 ConfiguredDocument: Rename the localedID private member variable.
1640 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1642 Adapt to the latest java-libglom API from git master.
1644 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1645 libglom now uses only Vector instead of List, which uses add() instead of
1648 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1650 ConfiguredDocument: Rename the localedID private member variable.
1652 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1654 Build a source tarball with mvn assembly:single
1656 * assembly.xml: Add this file.
1657 * pom.xml: Use the maven-assembly-plugin and tell it to use
1658 our assembly.xml file.
1660 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1662 OnlineGlomServiceImpl: Get .glom files recursively.
1664 * pom.xml: Depend on commons-io from org.apache.commons.
1665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1666 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1667 files recursively, and with the easier filter for the extension.
1668 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1669 simplify that code too.
1671 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1673 README: Mention that you must install java-libglom packages separately.
1675 But then it works, because java-libglom is now in the central maven
1678 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1680 locales drop-down: Show the correct selected locale when the URL changes.
1682 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1683 .java: setPlace(): Move some code into fillView().
1685 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1687 locales drop-down: Do not lose the primary key.
1689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1690 start(): onLocaleChange(): Pass the current primary key value,
1691 instead of an empty value.
1693 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1695 locales drop-down: Do not lose the drop-down selection.
1697 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1698 .java (TableSelectionActivity.fillView): Set the selected locale
1699 after changing the drop-down items (though we do not really need
1700 to change them just because the locale changes.)
1702 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1704 locales drop-down: Change the tables list when this changes.
1706 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1707 .java: TableSelectionActivity.start(): Move the async table titles
1708 retrieval into a private fillView() method and also call this when
1709 the chosen locale changes.
1710 Note that the document title is not actually translatable yet, but
1711 that is a problem that I should fix soon in libglom.
1713 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1715 Improve the placement of the locales drop-down.
1717 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1718 Put the title and locales drop-down in a div (gwt.FlowTable).
1719 * src/main/webapp/style.css: Add magic css properties to make this work.
1720 Also remove the left margin from the title so that it lines up with the
1723 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1725 locales selector: Show human-readable locale titles.
1727 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1728 getDocumentInfo(): Use java.util.Locale to show a real title of
1729 each locale, in the locale's own language.
1731 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1733 Add a language/locale selector drop-down.
1735 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1736 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1737 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1738 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1739 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1740 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1741 Add a ListBox to show the available locales. Add getLocaleSelector(),
1742 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1743 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1744 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1745 java: Add these classes.
1746 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1747 start(): Fill the locales ListBox. Handle its change event, firing a
1749 setPlace(): Show the selected locale as specified by the URL token.
1750 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1751 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1752 Handle LocaleChangeEvent, going to a new *Place with that locale.
1754 The placement of the ListBox is not pretty, and it currently uses the ID
1755 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1759 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1761 Search box: Show the search text from the URL token.
1763 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1764 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1765 Add setQuickFindText().
1766 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1767 .java: setPlace(): Store the queryText if the place is a ListPlace,
1768 and call TableSelectionView.setQuickFindText().
1770 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1772 Allow use of translations via, for instance, &lang=de in the URL.
1774 * pom.xml: Use the unstable java-libglom 1.21 version.
1776 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1777 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1778 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1779 init(): Instead of calling TranslatableItem.set_current_locale()
1780 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1781 However, this is only for default locales, which are not needed to
1782 change the locale in the URL.
1783 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1784 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1785 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1786 layout for a particular locale.
1787 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1788 Add get/setDefaultLocaleID().
1789 getDocumentInfo(), getListViewData(), getRelatedListData(),
1790 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1791 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1792 localeID parameter, so we can get the layout for a particular locale.
1794 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1795 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1796 * src/main/java/org/glom/web/client/place/ListPlace.java:
1797 Parse and construct a lang parameter too.
1799 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1800 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1801 passed to subsequent methods and constructors.
1802 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1803 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1804 Store the localeID from the *Place and pass it to other constructors
1805 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1807 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1808 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1809 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1810 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1811 * src/main/java/org/glom/web/client/ui/ListView.java:
1812 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1813 Take localeID parameters and pass them to subsequent constructors and
1814 methods, so that the layout is always retrieved for that locale.
1816 This is rather repetitive.
1818 Note that "" means the original (default) locale of the Glom document,
1819 which is usually English.
1821 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1823 Documents: Remove final keyword to fix startup configuration.
1825 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1826 final keywords on the private member variables because that breaks
1827 the startup, apparently (there are warnings) because it stops them
1828 from being serialized. I added these in the previous commit.
1830 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1832 Documents: Add some final keywords.
1834 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1837 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1839 OnlineGlomServiceImpl: Add to overview comments.
1841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1842 Note that this is where all the document are loaded. They are not
1843 loaded freshly for each page.
1845 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1849 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1850 Add a TextBox for the text of a quick find.
1851 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1853 setBackLink(): Add a String quickFind parameter.
1854 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1855 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1856 to the base interface, because that is how TableSelectionViewImpl is used.
1857 * src/main/webapp/style.css: Add style for the search box and its label.
1859 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1860 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1861 Add these files, based on the existing TableChangeEvent and
1862 TableChangeEventHandlers.
1863 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1864 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1865 a ListPlace() that the user should be taken to.
1866 * src/main/java/org/glom/web/client/activity/ListActivity.java
1867 start(): Handle it here too and adapt the TableChangeEvent handler to
1868 pass the extra "" quickFind parameter to ListPlace.
1869 * src/main/java/org/glom/web/client/place/ListPlace.java:
1870 Constructor: Take an extra String quickFind parameter and store it,
1871 returning it from a new getQuickFind() method.
1872 getToken(): Put the quickFind text in the URL token.
1873 getPlace(): Parse the quickFind text from the URL token.
1874 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1875 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1876 ListPlace constructor.
1877 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1878 .java: start(): Add a Change handler for the TableSelectionView's
1879 TextBox (via its base HasChangeHandlers interface), firing the new
1880 QuickFindChangeEvent.
1881 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1882 pass the extra "" quickFind parameter.
1884 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1885 setCellTable(): Add a String quickFind parameter and pass it to
1886 the ListViewTable() constructor.
1887 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1888 setCellTable() in the base interface, because that is how ListViewImpl
1891 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1892 Add a String quickFind member variable.
1893 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1894 Constructor: Add a String quickFind parameter, storing it in the
1895 base ListTable's member variable.
1896 onRangeChanged(): Pass quickFind to the
1897 OnlineGlomServiceAsync.getSortedListViewData() and
1898 OnlineGlomServiceAsync.getListViewData() methods.
1900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1901 getListViewData(), getSortedListViewData(): Add a String quickFind
1902 parameter, passing it to ConfiguredDocument.getListViewData().
1903 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1904 Change getListViewData(), getSortedListViewData() in the base interface,
1905 because that is how OnlineGlomServiceImpl is used, via this:
1906 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1907 Change getListViewData(), getSortedListViewData() here too.
1908 This class can apparently be used to asynchronously call methods on
1909 OnlineGlomService, and GWT seems to implement that after recognizing
1910 just the *Async name convention and the extra AsyncCallback parameters.
1912 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1913 getListViewData(): Add a String quickFind parameter, and pass it to
1914 ListViewDBAccess.getData().
1915 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1916 getListData(): Add a String quickFind parameter and pass it to
1918 getSelectQuery(): Add a String quickFind parameter.
1919 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1920 getSelectQuery(): Add a String quickFind parameter and use it with
1921 Glom.get_find_where_clause_quick() to pass a where_clause to
1922 Glom.build_sql_select_with_where_clause(), to actually filter the
1924 getData(): Add a String quickFind parameter, passing it to getListData().
1925 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1926 va: getData(): Pass an empty string to getListData() for the
1927 quickFind parameter.
1929 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1931 ListTable: Minor change.
1933 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1934 createCellTable(): Make this protected instead of public.
1936 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1938 Many files: Use final for the parameters and use the @override attribute.
1940 2012-01-22 Ben Konrath <ben@bagu.org>
1942 Add anchor links for single line text that starts with http, ftp and www.
1946 2012-01-22 Ben Konrath <ben@bagu.org>
1948 Add ellipsis to single line text in details view.
1952 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1954 Remove all javadoc author tags.
1956 Because they are awkward and meaningless when many people touch
1958 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1960 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1962 Revert the COPYING.LESSER to COPYING rename.
1964 Apparently both should be there if it is LGPL.
1966 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1968 *View: Remove unused imports.
1970 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1971 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1972 * src/main/java/org/glom/web/client/ui/ListView.java:
1973 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1974 Remove unused imports, as suggested by Eclipse.
1976 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1978 Move the *View::Presenter types, and some API into one base View.
1980 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1981 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1982 * src/main/java/org/glom/web/client/ui/ListView.java:
1983 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1984 Presenter, setPresenter() and clear() into a shared base interface,
1985 to avoid the unnecessary duplicate Presenter types and to more clearly
1986 show how the *Views share the same structure, even if they are not
1987 used polymorphically.
1989 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1990 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1992 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1993 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1994 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1996 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1999 Feel free to revert this if there is a good reason for the duplicate
2002 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2004 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2006 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2007 a class member instead of a local variable in the method.
2008 This lets us use it to get the view instances, for use in tests.
2009 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2010 beforeOnlineGlom(): Test some more details of the initial view.
2011 Again, this is not very useful.
2013 To really test gwt-glom we will need to start a local postgresql
2014 instance with local data, like the Glom tests in C++.
2016 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2018 pom.xml: Mention the LGPL license.
2020 * pom.xml: Add a licenses section.
2021 * COPYING.LESSER: Move this to COPYING, which
2022 previously contained the GPL. But gwt-glom is all LGPL.
2024 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2026 Add project information to README and pom.xml.
2028 * README: Add a brief description and mention some mvn
2030 * pom.xml: This extra information shows up in mvn site
2033 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2035 Use the latest java-libglom version.
2037 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2039 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2041 GwtTestOnlineGlom: Test a little more.
2043 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2044 protected rather than private, as suggested by the gwt-test-utils
2046 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2047 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2048 Test the initial visibility of the panels.
2050 However, this is not a very useful test.
2051 And I wonder how we should generally test using this idea for an
2052 activity/places app like ours where the real changes happen implicitly
2053 based on the history token/URL.
2055 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2057 Slight modification to *Mapper comments.
2059 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2060 (DataActivityMapper)
2061 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2063 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2065 Remove comments mentioning GIN because they are just copied from
2066 the example code and are apparently not helpful:
2067 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2068 Also change the mention of a class that is only in the example code.
2070 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2072 GwtTestOnlineGlom test: Minor changes.
2074 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2075 Avoid the long qualified class name and modify the comment
2076 because it is now obvious to me that the mocked class is the only
2077 custom one created via GWT.create().
2079 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2081 Tests: Added the beginnings of a test using gwt-test-utils.
2083 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2084 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2085 which tells gwt-test-utils what class will be tested.
2086 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2087 Add a simple (but empty) test case. One class, used by the OnlineGlom
2088 class, is mocked so that it can be created. However, I am not sure
2089 why only this class needs to be mocked.
2091 Note that mockito seems more popular, and clearer, than easymock,
2092 but I have not got that working yet. It might be a matter of the
2095 This test is run during mvn integration-test.
2097 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2099 Tests: Use junit4-style syntax instead of junit3-style.
2101 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2102 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2103 * src/test/java/org/glom/web/shared/DataItemTest.java:
2104 Use the @Test annotation rather than relying on the test*() prefix.
2105 Also no longer implement TestCase, to avoid triggering support for
2106 the junit3-way, which stops the annotations from working.
2107 Change the imports from import junit.framework.* to
2108 import org.junit.*, which is apparently the new way.
2110 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2112 Added a test for ListPlace token parsing and creation.
2114 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2115 This is much the same as DetailsPlaceTest.
2117 I wonder how we could test the other parts of the *Place API.
2119 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2121 DetailsPlace test: Also test getToken() and recreation via getPlace().
2123 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2124 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2125 recreate it, testing the recreated DetailsPlace for the same parameter
2128 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2130 Use the surefire-report plugin.
2132 * pom.xml: This generates a HTML report about the tests in
2133 target/site/surefire-report.html
2134 when you do mvn surefire-report:report. It seems to be popular/normal.
2136 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2138 Added a test for DetailsPlace.
2140 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2141 Test the getPlace() token parsing.
2143 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2145 Added a first unit test.
2147 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2148 * src/test/java/org/glom/web/shared/DataItemTest.java:
2149 This is a silly test but it is just to get things started. Note that
2150 maven/junit finds the test because it looks in src/test by default.
2152 2011-12-22 Ben Konrath <ben@bagu.org>
2154 Change charsetName to "UTF-8" when replacing line breaks.
2156 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2157 that work in Java (such as "UTF8") will not work when compiled to
2160 This fixes a problem with multi-line details view fields that have hard
2161 line breaks. The "License Text" field on this page demonstrates the
2164 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2166 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2168 2011-12-22 Ben Konrath <ben@bagu.org>
2170 Fix another bug with related list navigation.
2172 I've tested all the navigation buttons in all of the related lists
2173 so things should be good now.
2175 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2177 2011-12-22 Ben Konrath <ben@bagu.org>
2179 Fix a crasher when refreshing the list view with the default table.
2181 This crash will also happen when loading the list view with the default
2182 table from a link or bookmark.
2184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2185 to the main document selection page when the document id hasn't been
2187 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2188 the main document selection page when the document id hasn't been
2190 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2191 values for the details place when the document id hasn't been set.
2192 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2193 values for the list place when the document id hasn't been set.
2195 2011-12-21 Ben Konrath <ben@bagu.org>
2197 Protect against NPE when glom.document.locale is not in config.
2199 This patch protects against an NPE when glom.document.locale is not in
2200 the config file. This NPE will also happen if glom.document.locale is
2203 The patch also updates the error message to display the class name when
2204 the getMessage() returns null. This was happening when the NPE was
2205 thrown and I had "Configuration Error: null". If an NPE is encountered
2206 with this patch, "Configuration Error: NullPointerException " will be
2209 This commit closes this bug:
2211 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2215 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2217 Rename onlineglom.properties to onlineglom.properties.sample.
2219 * src/main/resources/onlineglom.properties: Rename to:
2220 * src/main/resources/onlineglom.properties.sample:
2221 * src/main/resources/README: And add this file explaining that people
2222 should rename it back when deploying.
2224 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2226 Allow choosing the translation in the .properties file.
2228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2229 init(): Read a glom.document.locale value from the configuration file
2230 and call Glom's TransatableItem::set_current_locale() method.
2231 * src/main/resources/onlineglom.properties: Add a commented-out
2232 example of this new setting.
2234 It would be better to add &lang=de_DE to the URL, but the current
2235 libglom API does not allow us to do this easily. I am working on that.
2237 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2239 Avoid a crash in parsing of token parameters.
2241 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2242 ava: getTokenParams(): Do not crash if a parameter has a key but no
2243 value, and ignore parameters with neither.
2245 2011-12-17 Murray Cumming <murrayc@murayc.com>
2247 History token building/handling: Improve use of token parameters.
2249 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2250 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2251 and buildParamsToken(HashMap), for use by derived classes.
2252 Make the separator private because it is no longer be needed.
2253 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2254 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2255 instead of manual string concatenation.
2256 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2257 of hardcoded indices and awkward splitting code.
2258 * src/main/java/org/glom/web/client/place/ListPlace.java
2259 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2260 instead of manual string concatenation.
2261 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2262 of hardcoded indices and awkward splitting code.
2263 This should fix bug #666420
2265 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2267 Fix a Navgiation->Navigation typo in the code.
2269 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2270 Rename processNavgiation() to processNavigation().
2272 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2274 Fix a seperator->separator typo in the code.
2276 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2277 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2278 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2281 2011-12-15 Ben Konrath <ben@bagu.org>
2283 Cleanup some comments.
2285 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2287 2011-12-14 Ben Konrath <ben@bagu.org>
2289 Replace \n with <br/> for multiline text in the details view.
2291 Vertical scrollbars are added when needed as well.
2293 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2295 2011-12-14 Ben Konrath <ben@bagu.org>
2297 Specify the font for document selection links.
2299 * src/main/webapp/style.css:
2301 2011-12-14 Ben Konrath <ben@bagu.org>
2303 Fix bouncy CellTable while paging.
2305 This doesn't currently work with related list tables in unselected
2308 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2310 2011-12-14 Ben Konrath <ben@bagu.org>
2312 Revamp the appearance of the document selection page.
2314 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2315 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2316 * src/main/webapp/style.css:
2318 2011-12-13 Ben Konrath <ben@bagu.org>
2320 Set navigation button column to the smallest size possible.
2322 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2324 2011-12-13 Ben Konrath <ben@bagu.org>
2326 Change OpenButton nomenclature to NavigationButton.
2328 Using NavigtionButton makes things more generic. Classes, methods and
2329 variables have been changed.
2331 This is a rename-only refactor.
2333 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2334 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2335 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2336 Renamed from OpenButtonCell.
2337 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2338 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2339 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2341 2011-12-12 Ben Konrath <ben@bagu.org>
2343 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2345 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2346 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2347 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2348 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2350 2011-12-12 Ben Konrath <ben@bagu.org>
2352 Update variable names and comments.
2354 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2355 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2357 2011-12-12 Ben Konrath <ben@bagu.org>
2359 Properly initialize numNonEmptyRows variable to zero.
2361 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2362 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2364 2011-12-05 Ben Konrath <ben@bagu.org>
2366 Add latest mockup with HTML tables.
2368 Features of this mockup:
2370 -> HTML table for flowtable
2371 -> HTML table for flowtable column
2372 -> Example of how related lists would look
2373 -> Not using text entries for data items
2375 The current version of Online Glom doesn't use HTML tables for the
2378 This mockup has been sent to the glom-devel mailing list but it's good
2379 to have it here as well.
2381 * mockups/details-view-html-tables.html:
2383 2011-12-05 Ben Konrath <ben@bagu.org>
2385 Remove unnecessary getPrimaryKeyField() method.
2387 getPrimaryKeyFieldForTable(String) has been renamed to
2388 getPrimaryKeyField(String).
2390 * src/main/java/org/glom/web/server/database/DBAccess.java:
2391 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2392 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2394 2011-12-05 Ben Konrath <ben@bagu.org>
2396 Add string representation of TypedDataItem value to conversion error message.
2398 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2399 message was extracted into its own method to avoid duplication.
2401 2011-12-05 Ben Konrath <ben@bagu.org>
2403 Add type checking to navigation primary key value creation.
2405 Create navigation primary key only if the expected type from the Glom
2406 document matches the type returned by the SQL query.
2408 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2410 2011-12-05 Ben Konrath <ben@bagu.org>
2412 Rename a couple of variables in RelatedListNavigation.
2414 This is a rename-only refactor.
2416 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2418 2011-12-05 Ben Konrath <ben@bagu.org>
2420 Move getListLayoutGroup() into getListViewLayoutGroup().
2422 This removes getListLayoutGroup(). It was only being called by
2423 getListViewLayoutGroup().
2425 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2427 2011-12-05 Ben Konrath <ben@bagu.org>
2429 Remove check for LayoutItem_Portal in list table method.
2431 This check is no longer necessary because the method isn't being used
2432 to create the LayoutItemPortal DTO.
2434 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2436 2011-12-05 Ben Konrath <ben@bagu.org>
2438 Properly support related list navigation.
2440 Navigation from the "Repository Analyzer -> Package Scans ->
2441 Dependencies" related table wasn't working because the primary key for
2442 related tables wasn't being set properly. This commit fixes the
2445 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2446 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2447 doesn't set the primary key properly for related list tables.
2448 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2449 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2450 useful for getting the primary key for list view tables and for related
2452 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2453 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2454 Move code to set the primary key for the table from the abstract
2455 ListDBAccess class to ListViewDBAccess as it's only correct for list
2457 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2458 Properly add primary key to related list tables.
2460 2011-12-02 Ben Konrath <ben@bagu.org>
2462 Properly set the horizontal alignment of fields.
2464 This fix is for both the list tables and the details view.
2466 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2467 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2468 to set the horizontal alignment of fields.
2470 2011-12-02 Ben Konrath <ben@bagu.org>
2472 Display currency codes in the details view.
2474 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2476 2011-12-02 Ben Konrath <ben@bagu.org>
2478 Avoid duplicate JNI call.
2480 JNI is not as efficient as pure Java and this is an easy (and small)
2483 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2484 Use previously retrieved value for whereClauseToTableName instead of
2487 2011-12-02 Ben Konrath <ben@bagu.org>
2489 Rename a couple of variables in RelatedListNavigation.
2491 This is a rename-only refactor.
2493 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2495 2011-12-02 Ben Konrath <ben@bagu.org>
2497 Indicate clearly that a mismatched primary key type is a bug.
2499 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2500 warning to error. Add 'This is a bug.' to message.
2502 2011-12-02 Ben Konrath <ben@bagu.org>
2504 Update / fix some comments.
2506 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2508 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2510 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2511 Fix comments. Add some TODOs.
2513 2011-12-02 Ben Konrath <ben@bagu.org>
2515 Enable navigation to details view with string primary key from related list.
2517 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2518 Create a text primary key value when return type of result is
2519 java.sql.Types.VARCHAR.
2521 2011-12-02 Ben Konrath <ben@bagu.org>
2523 Use checkboxes for booleans in the details view.
2525 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2527 2011-12-01 Ben Konrath <ben@bagu.org>
2529 Improve performance of related list height calculation.
2531 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2532 Put code to calculate the expected height in a static initializer so
2533 that that it's only called once.
2535 2011-12-01 Ben Konrath <ben@bagu.org>
2537 Show related list tables in notebooks (again).
2539 Calculate the height of the related list tables so the Notebook can be
2540 set the correct height. The height of the related list table is also needed by
2541 FlowTable to be able decide how to create the layout.
2543 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2544 and set the Portal height based on the height of the related list
2545 table and the Portal container.
2546 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2547 Add method to calculate the height of the related list tables.
2548 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2549 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2550 calculate the height of the Pager widget.
2552 2011-12-01 Ben Konrath <ben@bagu.org>
2554 Use CellTable API for table property instead of setting style on Element.
2556 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2558 2011-12-01 Ben Konrath <ben@bagu.org>
2560 Make ListViewTable and RelatedListTable a consistent height.
2562 The tables are now a consistent height regardless of the contents of
2563 the table. A hidden button is added to empty rows to ensure that the
2564 height of these rows will match the height of rows with data.
2566 A navigation button column is now added to every table. The width of
2567 the navigation column is set to 0px when a RelatedListTable shouldn't
2568 have navigation buttons. This maintains the a consistent row height in
2569 tables that don't show the navigation buttons.
2571 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2572 navigation column when not needed.
2573 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2574 arguments for navigation button to constructor of ListViewTable.
2575 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2576 hidden button for empty data rows.
2577 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2578 arguments for navigation button to constructor.
2579 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2580 create navigation buttons. Add hideNavigationButtons() method.
2581 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2582 arguments for navigation button to constructor.
2584 2011-12-01 Ben Konrath <ben@bagu.org>
2586 Use 'visibility: hidden' in Utils.getWidgetHeight().
2588 This is better choice because hidden elements are invisible, don't
2589 respond to events and are not part of the tab order. They will,