1 2012-06-15 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
6 OnlineGlomProperties.getKey(): Make this more robust by moving the
7 check for *.*.filename to here.
9 2012-06-15 Murray Cumming <murrayc@murrayc.com>
11 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
13 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
14 init(): Move knowledge of the config file format into the
15 OnlineGlomProperties inner class.
17 2012-06-15 Murray Cumming <murrayc@murrayc.com>
19 SelfHostExampleTest: Make sure we cleanup on failure.
21 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
22 the use of cleanup() to a tearDown() JUnit method.
24 2012-06-12 Murray Cumming <murrayc@murrayc.com>
26 ConfiguredDocument: Add a primary key to portals at least once.
28 * src/main/java/org/glom/web/server/ConfiguredDocument.java
29 updatePortalsExtras): Fix a typo so that we add the primary key
31 This is a fix for the previous commit:
32 ConfiguredDocument: Do not add a primary key to portals each time.
34 2012-06-08 Murray Cumming <murrayc@murrayc.com>
36 SelfHoster: Avoid some compiler warnings.
38 * src/test/java/org/glom/web/server/SelfHoster.java
39 executeCommandLineAndWait():
40 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
41 the now-unused streams for stdout and stderr from the command Processes.
42 These are not used because readln() hangs while waiting for a new line,
43 where there may be no next line. The commented out code is still there
44 to help us figure out how to do this properly.
46 2012-06-08 Murray Cumming <murrayc@murrayc.com>
48 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
50 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
51 Make this actually test the cloning again, though it is not very useful
52 now that we do not use the part that had a problem with cloning before.
54 2012-06-08 Murray Cumming <murrayc@murrayc.com>
56 SelfHoster: Keep trying pg_ctl after starting postgres.
58 * src/test/java/org/glom/web/server/SelfHoster.java
59 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
60 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
61 regular Glom. This seems mad but it seems to work because the first
62 command would fail if pg_ctl would eventually fail.
64 2012-06-08 Murray Cumming <murrayc@murrayc.com>
66 SelfHoster: Wait until the server is really ready.
68 * src/test/java/org/glom/web/server/SelfHoster.java
69 selfHost(): Attempt the connection after starting the server, retrying
70 a few times if necessary, so that the server is really ready already when
71 we return from this method.
72 The regular Glom code does this too because pg_ctl reports success too soon.
74 2012-06-08 Murray Cumming <murrayc@murrayc.com>
76 ConfiguredDocument: Do not add a primary key to portals each time.
78 * src/main/java/org/glom/web/server/ConfiguredDocument.java
79 updatePortalsExtras(): Only add an extra primary key field if there is
80 none, to avoid adding one each time we retrieve the details layout from the
82 This should fix bug #676986 (Ben Konrath)
84 2012-05-25 Murray Cumming <murrayc@murrayc.com>
86 Document.load(): Support version 7 documents.
88 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
89 database_title attribute if the title attribute is not there.
92 2012-05-24 Ben Konrath <ben@bagu.org>
94 Add configuration for auto-generating mvn:i18n from with Eclipse.
96 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
98 2012-05-24 Murray Cumming <murrayc@murrayc.com>
100 Update translations, adding French.
102 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
103 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
104 Add a French translation, using the translation from Glom.
106 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
107 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
108 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
109 Update these based on the translations from Glom.
111 2012-05-24 Murray Cumming <murrayc@murrayc.com>
113 SelfHoster: Add some debug println messages to help when things fail.
115 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
116 System.out.println() lines.
118 2012-05-23 Murray Cumming <murrayc@murrayc.com>
120 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
122 * src/test/java/org/glom/web/server/SelfHoster.java:
123 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
124 instance) instead of just /usr/bin (as on Fedora). Check the result when
127 2012-05-23 Murray Cumming <murrayc@murrayc.com>
129 Remove LayoutItemPortal.get/setNavigationTable().
131 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
132 Remove get/setNavigationTable(), which is only a cache, because it is not
133 used, and does not need to be used, because that decision should be made on
135 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
136 updatePortalsExtras():
137 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
138 getNavigationRecord():
139 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
142 2012-05-21 Murray Cumming <murrayc@murrayc.com>
144 Initial self-hosting for tests.
146 * pom.xml: Change the scope for log4j, to hopefully make it
147 available to the test code which uses it indirectly via jOOQ.
148 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
149 self-hosting, though we only use it for testing.
151 * src/main/java/org/glom/web/server/libglom/Document.java:
152 example rows: Use a map instead of a list for each row of values,
153 so we know what field they are for, instead of relying on the sequence
154 being correct. This is not very efficient, but it does not really need
156 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
157 testReadTableExampleRows(): Adapted.
159 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
160 that returns an Object, for generic use. Note that Object seems to be
161 the implicit base even of double.
162 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
163 for use in CREATE TABLE SQL queries.
164 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
165 to do self-hosting of PostgreSQL databases via its command-line
166 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
167 backends/postgres_self.cc. This is incomplete - it needs more
168 warnings about failures and it needs to clean up properly when things
170 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
171 test of this new class.
173 2012-05-21 Murray Cumming <murrayc@murrayc.com>
175 Document: loading example data: Handle exceptions.
177 * src/main/java/org/glom/web/server/libglom/Document.java:
178 DateFormat.parse() and Double.valueOf() can throw exceptions, though
179 Eclipse did not warn about that.
181 2012-05-20 Murray Cumming <murrayc@murrayc.com>
183 Document: load(), save(): Handle the example rows.
185 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
187 * src/main/java/org/glom/web/server/libglom/Document.java:
188 load(), save(): Load and save the example rows, though the date, time
189 and image types are not handled properly yet.
190 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
191 Add testReadTableExampleRows() just to check that something is read.
193 2012-05-20 Murray Cumming <murrayc@murrayc.com>
195 Document: Add save().
197 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
198 Added getTranslationsMap() for use while saving.
199 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
200 Adedd getUseDefaultFormatting() for use while saving.
201 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
202 and several private methods that it uses.
204 This will be useful while testing via self-hosting.
205 It is not complete, but should be complete enough for testing.
207 2012-05-17 Murray Cumming <murrayc@murrayc.com>
209 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
211 * src/main/java/org/glom/web/client/OnlineGlomService.java
212 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
214 Remove getSortedListViewData() and getSortedRelatedListData(), adding
215 the sort column index and ascending bool to the regular method.
216 Instead, a sort column index of -1 now means no sort.
217 This is less explicit, but it's fairly simple, reduces the amount of
218 code, and makes the OnlineGlomService API slightly smaller.
219 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
220 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
222 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
223 getListViewData(), getRelatedListData():
224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
225 getListViewData(), getRelatedListData():
226 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
228 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
230 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
235 2012-05-16 Murray Cumming <murrayc@murrayc.com>
237 Use translations for top-level groups too.
239 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
240 updateTitlesForLocale(): Use the translation for the group
241 as well as for child items.
245 Just recompiled to fix a problem in the released .tar.gz file.
249 2012-05-15 Murray Cumming <murrayc@murrayc.com>
251 Corrections to navigation to related records.
253 * src/main/java/org/glom/web/client/OnlineGlomService.java:
254 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
256 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
257 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
258 relationship name, because the relationship name is not necessarily unique
260 TOOD: This is inefficient, because it passes the whole list of
261 child field items back to the server, but it is more correct, and happens
262 to fix a bug with the primary key being lost after a few navigations.
263 There is probably a chance to make this more efficient anyway in some
266 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
267 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
268 * src/main/java/org/glom/web/server/ConfiguredDocument.java
269 * src/main/java/org/glom/web/server/database/DBAccess.java
270 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
271 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
274 2012-05-15 Murray Cumming <murrayc@murrayc.com>
276 Fix the use of translations.
278 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
279 Add updateTitlesForLocale().
280 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
281 Call it to discard unwanted translations and to make getTitle() return
282 the wanted translation wihout the need for the client code to specify a locale.
283 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
284 getTitle(): Fallback to the original title, as libglom does.
286 2012-05-15 Murray Cumming <murrayc@murrayc.com>
288 Document: Correctly report the number of available translation locales.
290 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
291 the available locale IDs list.
292 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
293 testLocales: Test this.
295 2012-05-15 Murray Cumming <murrayc@murrayc.com>
297 SqlUtils: Use camelCase.
299 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
300 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
301 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
302 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
303 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
304 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
306 2012-05-15 Murray Cumming <murrayc@murrayc.com>
308 Use jOOQ's tableByName() and fieldByName.
310 * pom.xml: Use jOOQ 2.3.1 to get the new API.
311 * src/main/java/org/glom/web/server/SqlUtils.java:
312 build_sql_select_step_with_where_clause(), .createField(),
313 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
314 so we can get correct quoting and escaping. Thanks to Lukas Eder for
315 adding this, and other things, to jOOQ.
317 2012-05-15 Murray Cumming <murrayc@murrayc.com>
319 SqlUtils: Remove the Connection parameters.
321 * src/main/java/org/glom/web/server/SqlUtils.java:
322 build_sql_select_with_key(), build_sql_select_with_where_clause(),
323 createSelect(), build_sql_select_step_with_where_clause(),
324 build_sql_count_select_with_where_clause(),
325 build_sql_select_count_rows(): Remove the Connection parameter because
326 jOOQ does not actually need a connectionwhen it is just used to build
328 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
330 * src/main/java/org/glom/web/server/ReportGenerator.java:
332 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
334 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
335 Constructor, getListData(), getResultSizeOfSQLQuery():
336 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
337 getSelectQuery(), getCountQuery():
338 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
339 getSelectQuery(), getCountQuery():
340 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
341 getNavigationRecord(): Adapted.
343 2012-05-14 Murray Cumming <murrayc@murrayc.com>
347 * src/main/java/org/glom/web/server/SqlUtils.java:
348 get_find_where_clause_quick(): Use a comparison of
349 lowercase values, instead of a simple equals. Regular Glom
350 uses the PostgreSQL ILIKE operator but jOOQ does not
351 support that just yet, though it will soon.
353 2012-05-14 Murray Cumming <murrayc@murrayc.com>
355 TableToViewDetails: Use a real serialization ID.
357 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
358 Though this does not fix the serialization problem.
360 2012-05-12 Murray Cumming <murrayc@murrayc.com>
362 Added LayoutItemPortalDeepCloneTest.
364 2012-05-11 Murray Cumming <murrayc@murrayc.com>
366 Make navigation work again.
368 * src/main/java/org/glom/web/server/libglom/Document.java:
369 Add getLayoutItemFieldShouldHaveNavigation().
370 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
371 Replace get/setAddNavigation() with the partly-existing
372 get/setNavigationTableName(), with an empty string being no navigation,
373 because this is simpler. Use the new
374 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
376 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
377 Add updateFieldsExtras() and call setNavigationTableName in it.
378 getDetailsLayoutGroup(),
379 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
380 createLayout(): Adapted.
381 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
382 Constructor: Adapted.
384 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
385 Replace get/setAddNavigation() with get/setNavigation(), returning a
386 TableToViewDetails class with both the table name and UsesRelationship,
387 because both are need. The previous code used java-libglom's output
388 variable (strangely, via sharedptr) to return both, but we cannot really
390 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
391 getNavigationRecord(): Adapt. However, we cannot actually use the cache
392 here because it somehow gets set to null during deepCopy(). I must test this.
393 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
394 testGetSuitableTableToViewDetails(): Adapted.
396 TODO: Find out why deepClone() is not quite working.
398 2012-05-11 Murray Cumming <murrayc@murrayc.com>
400 DBAccess: Simplify the retrievel of full field details.
402 * src/main/java/org/glom/web/server/database/DBAccess.java
403 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
404 because the Document loading should have done this.
406 2012-05-11 Murray Cumming <murrayc@murrayc.com>
408 Document: Correct loading of doubly-related layout fields.
410 * src/main/java/org/glom/web/server/libglom/Document.java:
411 loadUsesRelationship(): Actually set the related relationship, instead
412 of only setting it if it's not found.
414 2012-05-09 Murray Cumming <murrayc@murrayc.com>
416 Replace all appearances of Colour with color.
418 Because US English is dominant.
420 2012-05-09 Murray Cumming <murrayc@murrayc.com>
422 Use colors in HTML format, solving a warning about an unused function.
424 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
425 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
426 Add *asHTMLColor() versions of methods.
427 TODO: However, we should create and cache the results on the server.
428 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
429 * src/main/java/org/glom/web/client/ui/list/ListTable.java
430 * src/main/java/org/glom/web/server/ConfiguredDocument.java
431 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
432 Use the asHTMLcolor() versions.
434 2012-05-09 Murray Cumming <murrayc@murrayc.com>
436 ListViewTable: Constructor: Take the table name as a parameter.
438 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
439 Constructor: Take the tableName, and set the member variable, because
441 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
442 setCellTable(): Pass the table name.
443 This makes navigation to non-default tables work again. I don't know
444 why it worked before in the master branch.
446 2012-05-07 Murray Cumming <murrayc@murrayc.com>
448 ConfiguredDocument: Restore correct addition of hidden primary key items.
450 * src/main/java/org/glom/web/client/ui/list/ListTable.java
451 (ListTable.createCellTable): Uncomment out the check for the hidden
453 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
454 add primary key items for top-level lists and portals, as before,
455 instead of adding them to each group.
456 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
457 Actually implement the extra methods such as setHiddenPrimaryKey() and
458 comment that these are used only for top-level list groups and in portals.
459 This strangeness suggests even more that this should not be squeezed
460 into the LayoutGroup class.
462 2012-05-07 Murray Cumming <murrayc@murrayc.com>
464 Fix Formatting loading.
466 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
467 getFormattingUsed(): Remove the duplicate Formatting member variable
468 in favour of the one from the base class.
469 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
470 Initialize a new Formatting instead of using null by default, so we
471 have some defaults, instead of having to initialize one later just to
472 get the same defaults. This also makes loading of formatting from the
473 document work, because that expected a non-null.
475 2012-05-07 Murray Cumming <murrayc@murrayc.com>
477 RelatedListTable: Make sure that the tableName is set.
479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
480 Constructor: Take the tableName so it is available later. Otherwise,
481 the server assumes that we mean the default table and cannot find the
483 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
484 setData(): Pass the tableName to the RelatedListTable constructor.
486 2012-05-07 Murray Cumming <murrayc@murrayc.com>
490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
491 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
492 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
494 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
496 * src/main/java/org/glom/web/server/database/DBAccess.java:
497 convertResultSetToDTO(), getPortal():
498 * src/main/java/org/glom/web/server/database/ListDBAccess.java
500 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
501 Add checks for null objects and out of range access, with log messages to
502 give hints so we can fix these properly.
504 2012-05-07 Murray Cumming <murrayc@murrayc.com>
506 Portals: some corrections.
508 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
510 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
511 constructor: Use getRelationshipNameUsed() instead of getName(), because
512 that is what is meant.
513 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
514 getFromField(): Fix a typo, to get the field name, not the table name.
515 * src/main/java/org/glom/web/server/database/DBAccess.java:
516 getPortal(): Fix a typo that stopped this from working.
518 2012-05-07 Murray Cumming <murrayc@murrayc.com>
520 LayoutItemPortal: Also override getTitleOriginal().
522 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
523 This lets the base getTitle() with no parameters work.
524 TODO: Test this properly.
526 2012-05-06 Murray Cumming <murrayc@murrayc.com>
528 LayoutItemPortal: getTitle*(): Use the relationship title.
530 2012-05-06 Murray Cumming <murrayc@murrayc.com>
532 LayoutItemField: Fix loading of custom titles.
534 * src/main/java/org/glom/web/server/libglom/Document.java
535 loadDataLayoutItemField(): The title, if any, instead of the field
536 title, is stored in a title_custom node. Load it from there.
537 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
539 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
540 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
541 getTitle*() overrides.
542 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
545 2012-05-06 Murray Cumming <murrayc@murrayc.com>
547 LayoutItemField: Fall back to field titles, so some are really shown.
549 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
550 Override getTitleOriginal() and getTitle(), as in java-libglom.
551 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
554 2012-05-06 Murray Cumming <murrayc@murrayc.com>
556 Correct use of setExpectedResultSize().
558 * src/main/java/org/glom/web/server/ConfiguredDocument.java
559 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
560 Use setExpectedResultSize only on top-level groups (for instance, the
561 list layout) or on child portals (in details views).
562 Use the correct table name for portals to avoid SQL errors.
563 Update the expected counts when returning cached layouts.
565 2012-05-06 Murray Cumming <murrayc@murrayc.com>
567 Document: Interpret no group column count as 1.
569 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
570 default, though we now check for this in the UI code anyway.
572 2012-05-06 Murray Cumming <murrayc@murrayc.com>
576 2012-05-06 Murray Cumming <murrayc@murrayc.com>
578 Translatable: Use Hashmap instead of Treemap because GWT supports it.
580 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
581 The use of Treemap lead to this error from async methods, with no
583 "The response could not be deserialized"
585 2012-05-06 Murray Cumming <murrayc@murrayc.com>
587 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
589 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
590 when using the Google -> GWT Compile, or
591 g toolbar button -> GWT Compile Project... feature in Eclipse.
593 2012-05-06 Murray Cumming <murrayc@murrayc.com>
595 ListTable.addColumn(): Protect against a null Formatting.
597 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
598 Create a default Formatting if it is null, because that is the simplest
601 2012-05-06 Murray Cumming <murrayc@murrayc.com>
603 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
605 * src/main/java/org/glom/web/server/ConfiguredDocument.java
606 updateLayoutGroup(): Check that the field is not null.
608 2012-05-06 Murray Cumming <murrayc@murrayc.com>
610 ListViewImpl: Protected against a bad cast error.
612 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
613 onEnterKeyDown(): Do not cast without an instanceof check.
615 2012-05-06 Murray Cumming <murrayc@murrayc.com>
617 ListTable: Protect against an out of range error.
619 * src/main/java/org/glom/web/client/ui/list/ListTable.java
620 createCellTable(): This is unlikely, but can happen while debugging.
622 2012-05-06 Murray Cumming <murrayc@murrayc.com>
624 AsyncMessage onFailure() callbacks: Log the exception message.
626 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
627 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
628 * src/main/java/org/glom/web/client/activity/ListActivity.java:
629 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
630 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
631 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
632 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
633 These are useful clues when something is wrong.
635 2012-05-06 Murray Cumming <murrayc@murrayc.com>
637 ConfiguredDocument: Avoid a null dereference.
639 * src/main/java/org/glom/web/server/ConfiguredDocument.java
640 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
641 details maps are created.
643 2012-05-06 Murray Cumming <murrayc@murrayc.com>
645 Document: Correct the port number parsing.
647 * src/main/java/org/glom/web/server/libglom/Document.java:
648 This lets us actually connect to the database and show the document.
650 2012-05-05 Murray Cumming <murrayc@murrayc.com>
654 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
655 user-interaction, asking us to load a temporary URL in a browser.s
656 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
657 which is apparently necessary for testing the service. See the comment.
658 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
659 Show the exception, if any. This is how I saw the 404 in the HTML in
662 2012-05-05 Murray Cumming <murrayc@murrayc.com>
664 DocumentTest: Move the .glom files into the resources directory.
666 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
667 URI via getResource().
669 2012-05-05 Murray Cumming <murrayc@murrayc.com>
671 Document: Remove the FieldIdentifies inner class.
673 * src/main/java/org/glom/web/server/libglom/Document.java: We only
674 use the Relationship (though the same function in libglom is maybe
675 used in other ways) and so this removes a compiler warning.
677 2012-05-05 Murray Cumming <murrayc@murrayc.com>
679 Document.load() Remove the error code parameter.
681 * src/main/java/org/glom/web/server/libglom/Document.java: load():
682 Remove the parameter. We do not set it yet and it could never have
683 worked as an output parameter (though maybe it did in java-libglom).
684 We could use an exception if we really want the failure reason.
685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
687 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
688 setUp(), testGetSuitableTableToViewDetails(): Adapt.
690 2012-05-05 Murray Cumming <murrayc@murrayc.com>
692 Make some inner classes static.
694 * src/main/java/org/glom/web/server/ConfiguredDocument.java
695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
696 * src/main/java/org/glom/web/server/ReportGenerator.java
697 * src/main/java/org/glom/web/server/libglom/Document.java
698 Make all inner classes static that can be static.
700 2012-05-05 Murray Cumming <murrayc@murrayc.com>
702 OnlineGlomServiceImpl: Do not load and check for java-libglom.
704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
705 init(): We do not use java-libglom any more.
707 2012-05-05 Murray Cumming <murrayc@murrayc.com>
709 Remove mentions of java-libglom.
711 * README: Remove mention of java-libglom, because it no longer needed.
712 * utils/build-onlineglom-war.sh:
713 * utils/check-and-recover-tomcat.py:
714 * utils/install-onlineglom-war.sh: Remove these as they are no longer
715 useful. Building is now far easier, with no need for jhbuild.
717 2012-05-05 Murray Cumming <murrayc@murrayc.com>
719 Fix the build (mvn package)
721 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
722 (LayoutGroup): Make the LayoutItemList inner class static and protected.
723 Otherwise the GWT Java->Javascript compilation fails with just this
724 error, during mvn package or when attempting to view in a browser,
725 in the GWT developer mode in Eclipse.
727 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
728 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
729 [INFO] Compiling module org.glom.web.OnlineGlom
730 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
731 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
732 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
733 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
734 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
735 [INFO] [ERROR] Cannot proceed due to previous errors
737 It has taken me 2 days to find out what was causing that. After reducing
738 the code, the compiler eventually showed me the full error message.
740 2012-05-04 Murray Cumming <murrayc@murrayc.com>
742 ConfiguredDocument: Cache the cloned and stripped layouts.
744 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
745 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
746 layout in a map, so we can retrieve it again without rebuilding it.
748 2012-05-04 Murray Cumming <murrayc@murrayc.com>
750 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
752 2012-05-04 Murray Cumming <murrayc@murrayc.com>
754 libglom classes: Implement some auto-generated emthods.
756 2012-05-04 Murray Cumming <murrayc@murrayc.com>
758 Add GwtTestOnlineGlomService.
760 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
761 However, this (and the other GwtTest*) does not seem to run during
764 2012-05-04 Murray Cumming <murrayc@murrayc.com>
766 Remove use of unsupported features from client code.
768 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
769 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
770 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
771 Use our client version of StringUtils instead of the apache commons one.
773 However, the GWT Javascript compliation still fails.
775 2012-04-25 Murray Cumming <murrayc@murrayc.com>
777 Add a Field class and implement some loading of it in Document.
779 2012-04-25 Murray Cumming <murrayc@murrayc.com>
781 Initial Document loading implementation, instead of libglom.
783 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
784 and Translatable classes, and adapt the rest of the code to use them.
785 However, this is still missing Layout and Field classes and loading.
787 2012-04-24 Murray Cumming <murrayc@murrayc.com>
789 Use of jOOQ: Move Field creation into a utility method.
791 * src/main/java/org/glom/web/server/SqlUtils.java:
792 This lets us improve it more easily.
794 2012-04-24 Murray Cumming <murrayc@murrayc.com>
796 Use of jOOQ: Improve the code to COUNT a sub-select.
798 * src/main/java/org/glom/web/server/SqlUtils.java:
799 Move initial query creation into
800 build_sql_select_step_with_where_clause().
801 build_sql_select_count_rows(): Use the jOOQ API instead of
802 concatentating text, because a jOOQ Select*Step is a TableLike,
803 which is what from() takes.
805 2012-04-23 Murray Cumming <murrayc@murrayc.com>
807 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
809 * pom.xml: Depend on jooq.
810 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
811 methods with jOOQ, based on the C++ implementations in libglom,
812 with some changes to the logic required by jooQ.
813 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
815 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
816 * src/main/java/org/glom/web/server/ReportGenerator.java:
817 * src/main/java/org/glom/web/server/SqlUtils.java:
818 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
819 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
820 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
821 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
822 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
823 Adapt. In particular, the SqlUtils methods now need to take a Connection,
824 because jOOQ needs that, though it seems unnecessary.
826 This is not quite finished. Ideally jOOQ would help us to build
827 table_name.field_name names, quoting and escaping them properly.
828 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
830 2012-04-21 Murray Cumming <murrayc@murrayc.com>
832 Move use of Glom.build_sql*() into a new SqlUtils class.
834 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
835 to wrap Glom.build_sql*(). The parameter types are still Glom one,
836 but this will make it easier to start using something other than
837 libglom or SqlBuilder.
839 2012-04-21 Murray Cumming <murrayc@murrayc.com>
841 Update the project URL.
843 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
845 2012-04-21 Murray Cumming <murrayc@murrayc.com>
847 Main layout: Use a FlowTable instead of absolute positioning.
849 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
850 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
851 child panels/widgets must have an absolute position. But that is annoying, so
852 this adds a FlowTable and puts the child panels in there.
854 2012-04-21 Murray Cumming <murrayc@murrayc.com>
856 GwtTestOnlineGlom: Comment out unused code.
858 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
859 Eclipse has started to say that some code is unused.
861 2012-04-21 Murray Cumming <murrayc@murrayc.com>
863 Update to the latest versions of dependencies.
865 * pom.xml: Update version numbers of dependencies to the latest
867 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
868 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
869 * src/main/java/org/glom/web/server/ReportGenerator.java:
870 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
871 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
872 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
874 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
875 Modify the imports where necessary.
877 2012-04-17 Murray Cumming <murrayc@murrayc.com>
879 Style: Remove overflow:hidden from searchbox
881 * src/main/webapp/style.css: Because this pushes the Back To Link
882 label/link on to the next row, which is then hidden due to the
883 hard-coded (in ems) height.
885 2012-04-20 Murray Cumming <murrayc@murrayc.com>
887 Remove some duplicate code.
889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
890 getDocumentInfo(): This must have been duplicated during the merge from the
895 2012-04-19 Murray Cumming <murrayc@murrayc.com>
897 Reports: Localize the waiting for report message.
899 * src/main/java/org/glom/web/client/activity/ReportActivity.java
900 start(): Get the message from the contants.
901 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
903 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
904 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
905 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
906 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
907 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
908 Update these files with the English text for newer strings for now.
910 2012-04-19 Murray Cumming <murrayc@murrayc.com>
912 Reports: Show a message while waiting for the report.
914 * src/main/java/org/glom/web/client/ui/ReportView.java
915 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
916 Add setWaitingText(), to show a message saying that we are
917 waiting for the report to be ready.
918 * src/main/java/org/glom/web/client/activity/ReportActivity.java
919 start(): Call setWaitingText() before calling the async
922 2012-04-19 Murray Cumming <murrayc@murrayc.com>
924 ReportGenerator: Specify date and time formats.
926 * src/main/java/org/glom/web/server/ReportGenerator.java:
927 createFieldValueElement(): Use the default (and localized)
928 short formats, though we still need a way to show 4-digit
929 years without providing the format for every locale.
930 * src/main/java/org/glom/web/server/database/DBAccess.java:
931 convertResultSetToDTO(): Use the short formats here too.
933 2012-04-18 Murray Cumming <murrayc@murrayc.com>
935 ReportGenerator: Use the correct numeric formatting.
937 * src/main/java/org/glom/web/server/ReportGenerator.java
938 createFieldExpression(), createFieldValueElement(): Take the
939 whole LayoutItem_Field instead of just the field name, so
940 we have access to the formatting.
941 createFieldValueElement(): Use JRTextField.setPattern() to
942 specify the numeric formatting, with the help of a
943 regular DecimalFormat.
945 2012-04-18 Murray Cumming <murrayc@murrayc.com>
947 ReportGenerator: Avoid showing null for group by titles.
949 * src/main/java/org/glom/web/server/ReportGenerator.java
950 generateReport(): Use setBlankWhenNull() on the field title
951 style too, because this is used for values in group by
954 2012-04-18 Murray Cumming <murrayc@murrayc.com>
956 ReportGenerator: Add a colon to titles in vertical groups.
958 * src/main/java/org/glom/web/server/ReportGenerator.java
959 addFieldToDetailBandVertical(): Pass true for the withColon
962 2012-04-18 Murray Cumming <murrayc@murrayc.com>
964 ReportGenerator: Simplify the code by using Position more.
966 2012-04-18 Murray Cumming <murrayc@murrayc.com>
968 Reports: Support vertical groups, roughly.
970 * src/main/java/org/glom/web/server/ReportGenerator.java:
971 addToReport(): Rename to addGroupToReport() and, if necessary,
972 call the new addVerticalGroupToReport() method.
973 createFieldValueElement(): Let the caller specify the Y position
976 2012-04-17 Murray Cumming <murrayc@murrayc.com>
978 Reports: Allow a second report to be shown.
980 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
981 clear(): Do not remove the HTML widget, which broke the whole layout.
983 2012-04-17 Murray Cumming <murrayc@murrayc.com>
985 Locales drop-down: Show that we use English by default.
987 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
988 fillView(): When we use English, just because that is the default, when
989 no locale is specified, show that in the Locales drop-down instead of
990 just showing the first item.
992 2012-04-17 Murray Cumming <murrayc@murrayc.com>
994 Unselect the Report/Locale/Table combo item when appropriate.
996 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
997 setPlace(): clear reportName if this is not a ReportPlace.
998 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
999 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1000 When the provided name is empty, unselect all items, so that none are
1001 indicated. This uses a for loop because I cannot find a single method
1004 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1006 Report: Give the user a way to get back to the list.
1008 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1009 start(), setPlace(): Show the Back To List link on reports, and also
1010 interpret selecting the empty report item as back to list.
1012 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1014 Really show the selected Report name.
1016 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1017 setPlace(): Store the reportName here, if it is that kind of Place.
1018 fillView(): Set the selected Report after filling the list of reports.
1019 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1020 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1021 null Strings, though we need some way to unselect all ListBox items
1024 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1026 ReportGenerator: Try to avoid some problems.
1028 * src/main/java/org/glom/web/server/ReportGenerator.java
1029 addField(): Try to avoid duplicates, and avoid using a null
1032 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1034 Reports: Use quickFind.
1036 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1037 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1038 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1039 getReportHTML(): Add a quickFind parameter.
1040 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1041 start(): Pass the quickFind parameter.
1042 * src/main/java/org/glom/web/server/ReportGenerator.java
1043 generateReport(): Take a quickFind parameter.
1045 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1047 ReportPlace: Actually use the report name.
1049 * src/main/java/org/glom/web/client/place/ReportPlace.java
1050 getPlace(): Do not assign the report name to the quickfind.
1052 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1054 Show java.library.path when complaining.
1056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1057 init(): When telling us to check java.library.path, show the
1060 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1062 ReportGenerator: Do not show nulls.
1064 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1066 ReportGenerator: Make the title font larger.
1068 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1070 ReportGenerator: Put field titles inside groups, if there are groups.
1072 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1074 ReportGenerator: Take the Report itself instead of the name and group.
1076 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1077 Remove getReportLayoutGroup().
1078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1079 getReportHTML(): Pass the report instead
1080 of its name and layout group.
1081 * src/main/java/org/glom/web/server/ReportGenerator.java
1082 generateReport(): Use the report object to use the title
1083 instead of the name.
1085 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1087 ReportGenerator: Remove designBand parameters.
1089 * src/main/java/org/glom/web/server/ReportGenerator.java:
1090 Make designBand a class member instead of passing it to all
1093 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1095 ReportGenerator: Add lines, a bit like in the desktop version.
1097 * src/main/java/org/glom/web/server/ReportGenerator.java
1098 addToReport(): Use JRDesignLine.
1100 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1102 ReportGenerator: Correct the title positions and use some bold style.
1104 * src/main/java/org/glom/web/server/ReportGenerator.java:
1105 Break the code up into reusable functions, correct the placement of
1106 titles, and use normal/bold styles as in the reports in the desktop
1109 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1111 ReportGenerator: Add a header band to show the field titles.
1113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1114 getReportHTML(): Pass the localeId to the ReportGenerator
1116 * src/main/java/org/glom/web/server/ReportGenerator.java
1117 constructor: Take the localeID so we can get translated field
1119 generateReport(), addToReport(), addFieldToBand(): Add field
1120 titles in a column header band.
1122 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1124 Reports drop-down list: Some improvement.
1126 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1127 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1128 Adedd setSelectedReport(),
1129 setReportList(): Add a blank line so that the user can select the
1131 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1132 start(): Show the current report by calling setSelectedReport().
1133 This does not seem to work yet.
1135 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1137 DetailsActivity, ListActivity: Move some variables into a base class.
1139 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1140 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1141 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1142 the clientFactory, documentID, tableName and authenticationPopup into
1143 a base class, to avoid duplication.
1145 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1147 Translate the Reports label.
1149 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1150 Get the "Reports" label string from the constants.
1151 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1152 perties: Add Reports to the constants.
1154 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1156 Reports: Implement grouping.
1158 * src/main/java/org/glom/web/server/ReportGenerator.java:
1159 Handle LayoutItem_GroupBy items and try to do the right thing
1160 with JRDesignGroup. It seems to work.
1162 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1164 Actually show some data with JasperReports.
1166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1167 getReportHTML(): Move most code into a ReportGenerator class.
1168 * src/main/java/org/glom/web/server/ReportGenerator.java:
1169 Recurse into sub-groups, adding fields to the JasperDesign's details
1170 band. Note that we must set an arbitrary width and height, or it just
1171 will not show any data.
1173 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1175 Reports Chooser: Show the titles, not the names.
1177 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1178 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1179 and the names as the values.
1180 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1181 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1182 group now that we provide the report name, so it should always
1185 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1187 Depend on jasperreports.
1189 * pom.xml: Add the dependency. My plan is to use this on the
1192 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1194 Implement navigation to report places.
1196 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1197 start(): Do not bother to handle all events here.
1198 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1199 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1200 Added getSelectedReport().
1201 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1202 .java: start(): When handling a change to the reports chooser,
1203 call getSelectedReport() and goTo() its ReportPlace.
1204 * src/main/java/org/glom/web/client/ui/ReportView.java
1205 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1206 Added setReportHTML() which puts the html in a gwt HTML widget.
1207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1208 getReportHTML(): Return "TODO" just to show that this works.
1210 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1212 Make ReportPlace usable.
1214 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1215 Mention ReportPlace.
1216 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1217 Correct the @prefix annotation.
1219 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1221 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1223 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1224 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1226 Change getReportLayout() to getReportHMTL() because we will not need to
1227 parse or render the report layout on the client side.
1228 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1229 getReportLayout(): Return the libglom LayoutGroup type because we will
1230 not need to convert to a shared type, because this will not be used on
1232 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1235 Note that there is still no implementation for this.
1238 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1240 Add a (empty) Report Place, View, and Activity.
1242 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1244 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1245 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1246 this into a superclass:
1247 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1248 and also use it as the base of this new ReportPlace:
1249 * src/main/java/org/glom/web/client/place/ReportPlace.java
1251 * src/main/java/org/glom/web/client/ui/ReportView.java
1252 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1253 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1254 Add these, containing mostly boiler-plate for now.
1256 * src/main/java/org/glom/web/client/OnlineGlomService.java
1257 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1258 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1259 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1260 Add API to get the LayoutGroup for the report.
1262 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1264 Add and fill a Reports drop-down list box.
1266 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1268 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1269 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1270 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1271 Added getReports(document, table, localeID), calling
1272 ConfiguredDocument.getReports().
1273 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1274 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1275 Added setReportsList() and a list widget.
1276 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1277 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1282 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1284 Translations: Add Esperanto.
1286 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1287 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1288 properties: Add this translation because someone took the time to make it.
1290 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1292 Adapt to the java-libglom 1.21.7 API.
1294 * src/main/java/org/glom/web/server/ReportGenerator.java:
1295 addToReport(): get_group_secondary_fields() is now
1296 get_secondary_fields().
1299 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1301 Use the latest java-libglom version.
1303 * pom.xml: Use java-libglom 1.21.7.
1305 2012-03-03 Ben Konrath <ben@bagu.org>
1307 Display date and time in details view.
1309 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1311 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1313 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1315 Require the latest java-libglom.
1317 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1319 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1321 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1323 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1324 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1325 an empty quickfind string. I also corrected libglom to create only
1326 empty where clauses for empty quickfind strings, but this avoids the
1329 2012-02-24 Ben Konrath <ben@bagu.org>
1331 Improve the tabs in the Notebook widget.
1335 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1337 Translations: Try to translate the strings.
1339 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1340 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1341 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1342 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1343 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1344 Take the Open translation from GTK+'s .po files.
1345 Take the Details translation from Glom's po files.
1346 I have added the other strings to Glom so we can get translations that way:
1347 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1349 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1351 TableSelectionViewImpl: Put the search label and entry in a div.
1353 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1354 Put the search widgets in a FlowTable so that the CSS can be used to
1355 style them while keeping them together.
1356 * src/main/webapp/style.css: Mention the new div.
1358 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1360 Translate more strings in more locales.
1362 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1363 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1364 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1365 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1366 Translate the "Details" and "Open" string too.
1368 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1369 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1370 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1371 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1372 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1373 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1374 Add these new locales as placeholders though they currently contain English.
1376 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1378 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1381 Check the ConfiguredDocument* for null before using it.
1383 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1385 Tell Eclipse about the generated java files.
1387 * .classpath: This lets it find OnlineGlomConstants.java.
1388 It would be nice if Eclipse just used the maven build files.
1390 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1392 Prevent a crash when no locale is specified in the URL.
1394 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1395 Avoid returning a null string, obtained from
1396 Window.Location.getParameter(). This caused a crash when it was
1397 later passed to libglom's API.
1398 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1399 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1400 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1401 guard against future null strings.
1403 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1405 Use the ?locale= query param instead of the &lang= token param.
1407 * src/main/java/org/glom/web/client/place/ListPlace.java
1408 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1409 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1410 Remove the lang token key and value.
1412 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1413 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1414 When the user selects a different locale from the chooser, use
1415 Window.Location.assign() to change the URL, which then causes a reload.
1417 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1418 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1419 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1420 * src/main/java/org/glom/web/client/activity/ListActivity.java
1421 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1422 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1423 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1424 * src/main/java/org/glom/web/client/ui/ListView.java:
1425 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1427 Remove localeID member variables and method/constructor parameters, instead
1428 using Utils.getCurrentLocaleID() when we need a localID to pass to
1431 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1433 Internationalize the UI strings.
1435 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1436 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1437 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1438 because it is unused. Messages are apparently strings that can have
1439 parameters, but we do not need that yet, so Contants will be enough for now.
1440 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1441 to say that we support the en and de locales.
1442 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1443 The original English strings.
1444 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1445 Some German translations of the English strings.
1446 The i18n goal then uses the .properties file to generate an
1447 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1448 returns an implementation that returns the translated strings.
1449 The documentation suggests putting these in src/java/*/client/, but it seems
1450 best to put it in src/resources/*/client/.
1451 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1452 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1453 instead of hard-coding them.
1454 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1455 but that does not seem to stop the build, though it confuses Eclipse.
1457 You can see the translated string by adding ?locale=de to the URL, like so:
1458 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1460 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1462 Improve null/empty String checks.
1464 * pom.xml: Add a dependency on commons-lang, to use
1465 org.apache.commons.lang.StringUtils.
1466 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1468 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1469 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1470 Use StringUtils.isEmpty().
1472 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1473 StringUtils class with a static isEmpty() function because we
1474 cannot use org.apache.commons.lang.StringUtils in client-side
1475 GWT code because it (apparently) cannot be compiled to javascript.
1476 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1477 * src/main/java/org/glom/web/client/activity/ListActivity.java
1478 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1479 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1480 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1481 * src/main/java/org/glom/web/client/place/ListPlace.java
1482 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1483 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1484 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1485 * src/main/java/org/glom/web/client/ui/details/Group.java
1486 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1487 our StringUtils.isEmpty() function.
1489 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1491 Update to the latest java-libglom API.
1493 * pom.xml: Require java-libglom 1.21.4.
1494 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1495 getDocumentInfo(), getListViewLayoutGroup():
1496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1498 * src/main/java/org/glom/web/server/database/DBAccess.java
1499 getFieldsToShowForSQLQueryAddGroup(),
1500 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1501 with either get_database_title_original() or
1502 get_database_title(localeID).
1504 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1506 ConfiguredDocument: Avoid a null pointer exception.
1508 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1509 Initialize localeID to "" to avoid returning a null String which
1510 causes a crash in java-libglom's swing-generated code.
1512 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1514 Some simple renaming.
1516 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1517 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1518 for localeChooser. This seems more appropriate and is less ambiguous
1519 particularly in the .css file.
1521 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1523 ConfiguredDocument: Rename the localedID private member variable.
1525 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1527 Adapt to the latest java-libglom API from git master.
1529 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1530 libglom now uses only Vector instead of List, which uses add() instead of
1533 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1535 ConfiguredDocument: Rename the localedID private member variable.
1537 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1539 Build a source tarball with mvn assembly:single
1541 * assembly.xml: Add this file.
1542 * pom.xml: Use the maven-assembly-plugin and tell it to use
1543 our assembly.xml file.
1545 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1547 OnlineGlomServiceImpl: Get .glom files recursively.
1549 * pom.xml: Depend on commons-io from org.apache.commons.
1550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1551 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1552 files recursively, and with the easier filter for the extension.
1553 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1554 simplify that code too.
1556 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1558 README: Mention that you must install java-libglom packages separately.
1560 But then it works, because java-libglom is now in the central maven
1563 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1565 locales drop-down: Show the correct selected locale when the URL changes.
1567 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1568 .java: setPlace(): Move some code into fillView().
1570 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1572 locales drop-down: Do not lose the primary key.
1574 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1575 start(): onLocaleChange(): Pass the current primary key value,
1576 instead of an empty value.
1578 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1580 locales drop-down: Do not lose the drop-down selection.
1582 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1583 .java (TableSelectionActivity.fillView): Set the selected locale
1584 after changing the drop-down items (though we do not really need
1585 to change them just because the locale changes.)
1587 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1589 locales drop-down: Change the tables list when this changes.
1591 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1592 .java: TableSelectionActivity.start(): Move the async table titles
1593 retrieval into a private fillView() method and also call this when
1594 the chosen locale changes.
1595 Note that the document title is not actually translatable yet, but
1596 that is a problem that I should fix soon in libglom.
1598 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1600 Improve the placement of the locales drop-down.
1602 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1603 Put the title and locales drop-down in a div (gwt.FlowTable).
1604 * src/main/webapp/style.css: Add magic css properties to make this work.
1605 Also remove the left margin from the title so that it lines up with the
1608 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1610 locales selector: Show human-readable locale titles.
1612 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1613 getDocumentInfo(): Use java.util.Locale to show a real title of
1614 each locale, in the locale's own language.
1616 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1618 Add a language/locale selector drop-down.
1620 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1621 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1622 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1623 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1624 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1625 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1626 Add a ListBox to show the available locales. Add getLocaleSelector(),
1627 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1628 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1629 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1630 java: Add these classes.
1631 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1632 start(): Fill the locales ListBox. Handle its change event, firing a
1634 setPlace(): Show the selected locale as specified by the URL token.
1635 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1636 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1637 Handle LocaleChangeEvent, going to a new *Place with that locale.
1639 The placement of the ListBox is not pretty, and it currently uses the ID
1640 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1644 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1646 Search box: Show the search text from the URL token.
1648 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1649 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1650 Add setQuickFindText().
1651 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1652 .java: setPlace(): Store the queryText if the place is a ListPlace,
1653 and call TableSelectionView.setQuickFindText().
1655 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1657 Allow use of translations via, for instance, &lang=de in the URL.
1659 * pom.xml: Use the unstable java-libglom 1.21 version.
1661 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1662 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1664 init(): Instead of calling TranslatableItem.set_current_locale()
1665 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1666 However, this is only for default locales, which are not needed to
1667 change the locale in the URL.
1668 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1669 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1670 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1671 layout for a particular locale.
1672 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1673 Add get/setDefaultLocaleID().
1674 getDocumentInfo(), getListViewData(), getRelatedListData(),
1675 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1676 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1677 localeID parameter, so we can get the layout for a particular locale.
1679 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1680 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1681 * src/main/java/org/glom/web/client/place/ListPlace.java:
1682 Parse and construct a lang parameter too.
1684 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1685 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1686 passed to subsequent methods and constructors.
1687 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1688 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1689 Store the localeID from the *Place and pass it to other constructors
1690 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1692 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1693 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1694 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1695 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1696 * src/main/java/org/glom/web/client/ui/ListView.java:
1697 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1698 Take localeID parameters and pass them to subsequent constructors and
1699 methods, so that the layout is always retrieved for that locale.
1701 This is rather repetitive.
1703 Note that "" means the original (default) locale of the Glom document,
1704 which is usually English.
1706 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1708 Documents: Remove final keyword to fix startup configuration.
1710 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1711 final keywords on the private member variables because that breaks
1712 the startup, apparently (there are warnings) because it stops them
1713 from being serialized. I added these in the previous commit.
1715 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1717 Documents: Add some final keywords.
1719 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1722 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1724 OnlineGlomServiceImpl: Add to overview comments.
1726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1727 Note that this is where all the document are loaded. They are not
1728 loaded freshly for each page.
1730 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1734 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1735 Add a TextBox for the text of a quick find.
1736 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1738 setBackLink(): Add a String quickFind parameter.
1739 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1740 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1741 to the base interface, because that is how TableSelectionViewImpl is used.
1742 * src/main/webapp/style.css: Add style for the search box and its label.
1744 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1745 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1746 Add these files, based on the existing TableChangeEvent and
1747 TableChangeEventHandlers.
1748 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1749 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1750 a ListPlace() that the user should be taken to.
1751 * src/main/java/org/glom/web/client/activity/ListActivity.java
1752 start(): Handle it here too and adapt the TableChangeEvent handler to
1753 pass the extra "" quickFind parameter to ListPlace.
1754 * src/main/java/org/glom/web/client/place/ListPlace.java:
1755 Constructor: Take an extra String quickFind parameter and store it,
1756 returning it from a new getQuickFind() method.
1757 getToken(): Put the quickFind text in the URL token.
1758 getPlace(): Parse the quickFind text from the URL token.
1759 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1760 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1761 ListPlace constructor.
1762 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1763 .java: start(): Add a Change handler for the TableSelectionView's
1764 TextBox (via its base HasChangeHandlers interface), firing the new
1765 QuickFindChangeEvent.
1766 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1767 pass the extra "" quickFind parameter.
1769 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1770 setCellTable(): Add a String quickFind parameter and pass it to
1771 the ListViewTable() constructor.
1772 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1773 setCellTable() in the base interface, because that is how ListViewImpl
1776 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1777 Add a String quickFind member variable.
1778 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1779 Constructor: Add a String quickFind parameter, storing it in the
1780 base ListTable's member variable.
1781 onRangeChanged(): Pass quickFind to the
1782 OnlineGlomServiceAsync.getSortedListViewData() and
1783 OnlineGlomServiceAsync.getListViewData() methods.
1785 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1786 getListViewData(), getSortedListViewData(): Add a String quickFind
1787 parameter, passing it to ConfiguredDocument.getListViewData().
1788 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1789 Change getListViewData(), getSortedListViewData() in the base interface,
1790 because that is how OnlineGlomServiceImpl is used, via this:
1791 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1792 Change getListViewData(), getSortedListViewData() here too.
1793 This class can apparently be used to asynchronously call methods on
1794 OnlineGlomService, and GWT seems to implement that after recognizing
1795 just the *Async name convention and the extra AsyncCallback parameters.
1797 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1798 getListViewData(): Add a String quickFind parameter, and pass it to
1799 ListViewDBAccess.getData().
1800 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1801 getListData(): Add a String quickFind parameter and pass it to
1803 getSelectQuery(): Add a String quickFind parameter.
1804 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1805 getSelectQuery(): Add a String quickFind parameter and use it with
1806 Glom.get_find_where_clause_quick() to pass a where_clause to
1807 Glom.build_sql_select_with_where_clause(), to actually filter the
1809 getData(): Add a String quickFind parameter, passing it to getListData().
1810 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1811 va: getData(): Pass an empty string to getListData() for the
1812 quickFind parameter.
1814 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1816 ListTable: Minor change.
1818 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1819 createCellTable(): Make this protected instead of public.
1821 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1823 Many files: Use final for the parameters and use the @override attribute.
1825 2012-01-22 Ben Konrath <ben@bagu.org>
1827 Add anchor links for single line text that starts with http, ftp and www.
1831 2012-01-22 Ben Konrath <ben@bagu.org>
1833 Add ellipsis to single line text in details view.
1837 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1839 Remove all javadoc author tags.
1841 Because they are awkward and meaningless when many people touch
1843 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1845 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1847 Revert the COPYING.LESSER to COPYING rename.
1849 Apparently both should be there if it is LGPL.
1851 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1853 *View: Remove unused imports.
1855 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1856 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1857 * src/main/java/org/glom/web/client/ui/ListView.java:
1858 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1859 Remove unused imports, as suggested by Eclipse.
1861 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1863 Move the *View::Presenter types, and some API into one base View.
1865 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1866 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1867 * src/main/java/org/glom/web/client/ui/ListView.java:
1868 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1869 Presenter, setPresenter() and clear() into a shared base interface,
1870 to avoid the unnecessary duplicate Presenter types and to more clearly
1871 show how the *Views share the same structure, even if they are not
1872 used polymorphically.
1874 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1875 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1877 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1878 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1879 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1881 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1884 Feel free to revert this if there is a good reason for the duplicate
1887 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1889 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1891 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1892 a class member instead of a local variable in the method.
1893 This lets us use it to get the view instances, for use in tests.
1894 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1895 beforeOnlineGlom(): Test some more details of the initial view.
1896 Again, this is not very useful.
1898 To really test gwt-glom we will need to start a local postgresql
1899 instance with local data, like the Glom tests in C++.
1901 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1903 pom.xml: Mention the LGPL license.
1905 * pom.xml: Add a licenses section.
1906 * COPYING.LESSER: Move this to COPYING, which
1907 previously contained the GPL. But gwt-glom is all LGPL.
1909 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1911 Add project information to README and pom.xml.
1913 * README: Add a brief description and mention some mvn
1915 * pom.xml: This extra information shows up in mvn site
1918 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1920 Use the latest java-libglom version.
1922 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1924 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1926 GwtTestOnlineGlom: Test a little more.
1928 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1929 protected rather than private, as suggested by the gwt-test-utils
1931 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1932 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1933 Test the initial visibility of the panels.
1935 However, this is not a very useful test.
1936 And I wonder how we should generally test using this idea for an
1937 activity/places app like ours where the real changes happen implicitly
1938 based on the history token/URL.
1940 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1942 Slight modification to *Mapper comments.
1944 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1945 (DataActivityMapper)
1946 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1948 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1950 Remove comments mentioning GIN because they are just copied from
1951 the example code and are apparently not helpful:
1952 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1953 Also change the mention of a class that is only in the example code.
1955 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1957 GwtTestOnlineGlom test: Minor changes.
1959 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1960 Avoid the long qualified class name and modify the comment
1961 because it is now obvious to me that the mocked class is the only
1962 custom one created via GWT.create().
1964 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1966 Tests: Added the beginnings of a test using gwt-test-utils.
1968 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1969 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1970 which tells gwt-test-utils what class will be tested.
1971 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1972 Add a simple (but empty) test case. One class, used by the OnlineGlom
1973 class, is mocked so that it can be created. However, I am not sure
1974 why only this class needs to be mocked.
1976 Note that mockito seems more popular, and clearer, than easymock,
1977 but I have not got that working yet. It might be a matter of the
1980 This test is run during mvn integration-test.
1982 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1984 Tests: Use junit4-style syntax instead of junit3-style.
1986 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1987 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1988 * src/test/java/org/glom/web/shared/DataItemTest.java:
1989 Use the @Test annotation rather than relying on the test*() prefix.
1990 Also no longer implement TestCase, to avoid triggering support for
1991 the junit3-way, which stops the annotations from working.
1992 Change the imports from import junit.framework.* to
1993 import org.junit.*, which is apparently the new way.
1995 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1997 Added a test for ListPlace token parsing and creation.
1999 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2000 This is much the same as DetailsPlaceTest.
2002 I wonder how we could test the other parts of the *Place API.
2004 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2006 DetailsPlace test: Also test getToken() and recreation via getPlace().
2008 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2009 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2010 recreate it, testing the recreated DetailsPlace for the same parameter
2013 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2015 Use the surefire-report plugin.
2017 * pom.xml: This generates a HTML report about the tests in
2018 target/site/surefire-report.html
2019 when you do mvn surefire-report:report. It seems to be popular/normal.
2021 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2023 Added a test for DetailsPlace.
2025 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2026 Test the getPlace() token parsing.
2028 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2030 Added a first unit test.
2032 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2033 * src/test/java/org/glom/web/shared/DataItemTest.java:
2034 This is a silly test but it is just to get things started. Note that
2035 maven/junit finds the test because it looks in src/test by default.
2037 2011-12-22 Ben Konrath <ben@bagu.org>
2039 Change charsetName to "UTF-8" when replacing line breaks.
2041 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2042 that work in Java (such as "UTF8") will not work when compiled to
2045 This fixes a problem with multi-line details view fields that have hard
2046 line breaks. The "License Text" field on this page demonstrates the
2049 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2051 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2053 2011-12-22 Ben Konrath <ben@bagu.org>
2055 Fix another bug with related list navigation.
2057 I've tested all the navigation buttons in all of the related lists
2058 so things should be good now.
2060 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2062 2011-12-22 Ben Konrath <ben@bagu.org>
2064 Fix a crasher when refreshing the list view with the default table.
2066 This crash will also happen when loading the list view with the default
2067 table from a link or bookmark.
2069 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2070 to the main document selection page when the document id hasn't been
2072 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2073 the main document selection page when the document id hasn't been
2075 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2076 values for the details place when the document id hasn't been set.
2077 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2078 values for the list place when the document id hasn't been set.
2080 2011-12-21 Ben Konrath <ben@bagu.org>
2082 Protect against NPE when glom.document.locale is not in config.
2084 This patch protects against an NPE when glom.document.locale is not in
2085 the config file. This NPE will also happen if glom.document.locale is
2088 The patch also updates the error message to display the class name when
2089 the getMessage() returns null. This was happening when the NPE was
2090 thrown and I had "Configuration Error: null". If an NPE is encountered
2091 with this patch, "Configuration Error: NullPointerException " will be
2094 This commit closes this bug:
2096 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2100 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2102 Rename onlineglom.properties to onlineglom.properties.sample.
2104 * src/main/resources/onlineglom.properties: Rename to:
2105 * src/main/resources/onlineglom.properties.sample:
2106 * src/main/resources/README: And add this file explaining that people
2107 should rename it back when deploying.
2109 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2111 Allow choosing the translation in the .properties file.
2113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2114 init(): Read a glom.document.locale value from the configuration file
2115 and call Glom's TransatableItem::set_current_locale() method.
2116 * src/main/resources/onlineglom.properties: Add a commented-out
2117 example of this new setting.
2119 It would be better to add &lang=de_DE to the URL, but the current
2120 libglom API does not allow us to do this easily. I am working on that.
2122 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2124 Avoid a crash in parsing of token parameters.
2126 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2127 ava: getTokenParams(): Do not crash if a parameter has a key but no
2128 value, and ignore parameters with neither.
2130 2011-12-17 Murray Cumming <murrayc@murayc.com>
2132 History token building/handling: Improve use of token parameters.
2134 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2135 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2136 and buildParamsToken(HashMap), for use by derived classes.
2137 Make the separator private because it is no longer be needed.
2138 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2139 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2140 instead of manual string concatenation.
2141 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2142 of hardcoded indices and awkward splitting code.
2143 * src/main/java/org/glom/web/client/place/ListPlace.java
2144 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2145 instead of manual string concatenation.
2146 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2147 of hardcoded indices and awkward splitting code.
2148 This should fix bug #666420
2150 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2152 Fix a Navgiation->Navigation typo in the code.
2154 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2155 Rename processNavgiation() to processNavigation().
2157 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2159 Fix a seperator->separator typo in the code.
2161 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2162 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2163 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2166 2011-12-15 Ben Konrath <ben@bagu.org>
2168 Cleanup some comments.
2170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2172 2011-12-14 Ben Konrath <ben@bagu.org>
2174 Replace \n with <br/> for multiline text in the details view.
2176 Vertical scrollbars are added when needed as well.
2178 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2180 2011-12-14 Ben Konrath <ben@bagu.org>
2182 Specify the font for document selection links.
2184 * src/main/webapp/style.css:
2186 2011-12-14 Ben Konrath <ben@bagu.org>
2188 Fix bouncy CellTable while paging.
2190 This doesn't currently work with related list tables in unselected
2193 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2195 2011-12-14 Ben Konrath <ben@bagu.org>
2197 Revamp the appearance of the document selection page.
2199 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2200 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2201 * src/main/webapp/style.css:
2203 2011-12-13 Ben Konrath <ben@bagu.org>
2205 Set navigation button column to the smallest size possible.
2207 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2209 2011-12-13 Ben Konrath <ben@bagu.org>
2211 Change OpenButton nomenclature to NavigationButton.
2213 Using NavigtionButton makes things more generic. Classes, methods and
2214 variables have been changed.
2216 This is a rename-only refactor.
2218 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2220 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2221 Renamed from OpenButtonCell.
2222 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2223 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2224 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2226 2011-12-12 Ben Konrath <ben@bagu.org>
2228 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2231 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2232 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2233 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2235 2011-12-12 Ben Konrath <ben@bagu.org>
2237 Update variable names and comments.
2239 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2240 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2242 2011-12-12 Ben Konrath <ben@bagu.org>
2244 Properly initialize numNonEmptyRows variable to zero.
2246 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2247 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2249 2011-12-05 Ben Konrath <ben@bagu.org>
2251 Add latest mockup with HTML tables.
2253 Features of this mockup:
2255 -> HTML table for flowtable
2256 -> HTML table for flowtable column
2257 -> Example of how related lists would look
2258 -> Not using text entries for data items
2260 The current version of Online Glom doesn't use HTML tables for the
2263 This mockup has been sent to the glom-devel mailing list but it's good
2264 to have it here as well.
2266 * mockups/details-view-html-tables.html:
2268 2011-12-05 Ben Konrath <ben@bagu.org>
2270 Remove unnecessary getPrimaryKeyField() method.
2272 getPrimaryKeyFieldForTable(String) has been renamed to
2273 getPrimaryKeyField(String).
2275 * src/main/java/org/glom/web/server/database/DBAccess.java:
2276 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2277 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2279 2011-12-05 Ben Konrath <ben@bagu.org>
2281 Add string representation of TypedDataItem value to conversion error message.
2283 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2284 message was extracted into its own method to avoid duplication.
2286 2011-12-05 Ben Konrath <ben@bagu.org>
2288 Add type checking to navigation primary key value creation.
2290 Create navigation primary key only if the expected type from the Glom
2291 document matches the type returned by the SQL query.
2293 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2295 2011-12-05 Ben Konrath <ben@bagu.org>
2297 Rename a couple of variables in RelatedListNavigation.
2299 This is a rename-only refactor.
2301 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2303 2011-12-05 Ben Konrath <ben@bagu.org>
2305 Move getListLayoutGroup() into getListViewLayoutGroup().
2307 This removes getListLayoutGroup(). It was only being called by
2308 getListViewLayoutGroup().
2310 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2312 2011-12-05 Ben Konrath <ben@bagu.org>
2314 Remove check for LayoutItem_Portal in list table method.
2316 This check is no longer necessary because the method isn't being used
2317 to create the LayoutItemPortal DTO.
2319 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2321 2011-12-05 Ben Konrath <ben@bagu.org>
2323 Properly support related list navigation.
2325 Navigation from the "Repository Analyzer -> Package Scans ->
2326 Dependencies" related table wasn't working because the primary key for
2327 related tables wasn't being set properly. This commit fixes the
2330 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2331 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2332 doesn't set the primary key properly for related list tables.
2333 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2334 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2335 useful for getting the primary key for list view tables and for related
2337 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2338 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2339 Move code to set the primary key for the table from the abstract
2340 ListDBAccess class to ListViewDBAccess as it's only correct for list
2342 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2343 Properly add primary key to related list tables.
2345 2011-12-02 Ben Konrath <ben@bagu.org>
2347 Properly set the horizontal alignment of fields.
2349 This fix is for both the list tables and the details view.
2351 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2352 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2353 to set the horizontal alignment of fields.
2355 2011-12-02 Ben Konrath <ben@bagu.org>
2357 Display currency codes in the details view.
2359 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2361 2011-12-02 Ben Konrath <ben@bagu.org>
2363 Avoid duplicate JNI call.
2365 JNI is not as efficient as pure Java and this is an easy (and small)
2368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2369 Use previously retrieved value for whereClauseToTableName instead of
2372 2011-12-02 Ben Konrath <ben@bagu.org>
2374 Rename a couple of variables in RelatedListNavigation.
2376 This is a rename-only refactor.
2378 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2380 2011-12-02 Ben Konrath <ben@bagu.org>
2382 Indicate clearly that a mismatched primary key type is a bug.
2384 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2385 warning to error. Add 'This is a bug.' to message.
2387 2011-12-02 Ben Konrath <ben@bagu.org>
2389 Update / fix some comments.
2391 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2393 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2395 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2396 Fix comments. Add some TODOs.
2398 2011-12-02 Ben Konrath <ben@bagu.org>
2400 Enable navigation to details view with string primary key from related list.
2402 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2403 Create a text primary key value when return type of result is
2404 java.sql.Types.VARCHAR.
2406 2011-12-02 Ben Konrath <ben@bagu.org>
2408 Use checkboxes for booleans in the details view.
2410 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2412 2011-12-01 Ben Konrath <ben@bagu.org>
2414 Improve performance of related list height calculation.
2416 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2417 Put code to calculate the expected height in a static initializer so
2418 that that it's only called once.
2420 2011-12-01 Ben Konrath <ben@bagu.org>
2422 Show related list tables in notebooks (again).
2424 Calculate the height of the related list tables so the Notebook can be
2425 set the correct height. The height of the related list table is also needed by
2426 FlowTable to be able decide how to create the layout.
2428 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2429 and set the Portal height based on the height of the related list
2430 table and the Portal container.
2431 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2432 Add method to calculate the height of the related list tables.
2433 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2434 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2435 calculate the height of the Pager widget.
2437 2011-12-01 Ben Konrath <ben@bagu.org>
2439 Use CellTable API for table property instead of setting style on Element.
2441 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2443 2011-12-01 Ben Konrath <ben@bagu.org>
2445 Make ListViewTable and RelatedListTable a consistent height.
2447 The tables are now a consistent height regardless of the contents of
2448 the table. A hidden button is added to empty rows to ensure that the
2449 height of these rows will match the height of rows with data.
2451 A navigation button column is now added to every table. The width of
2452 the navigation column is set to 0px when a RelatedListTable shouldn't
2453 have navigation buttons. This maintains the a consistent row height in
2454 tables that don't show the navigation buttons.
2456 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2457 navigation column when not needed.
2458 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2459 arguments for navigation button to constructor of ListViewTable.
2460 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2461 hidden button for empty data rows.
2462 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2463 arguments for navigation button to constructor.
2464 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2465 create navigation buttons. Add hideNavigationButtons() method.
2466 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2467 arguments for navigation button to constructor.
2469 2011-12-01 Ben Konrath <ben@bagu.org>
2471 Use 'visibility: hidden' in Utils.getWidgetHeight().
2473 This is better choice because hidden elements are invisible, don't
2474 respond to events and are not part of the tab order. They will,
2475 however, take up space which is required to be able to calculate the
2476 height of the widget.
2478 * src/main/java/org/glom/web/client/Utils.java:
2480 2011-12-01 Ben Konrath <ben@bagu.org>
2482 Use Utils.getWidgetHeight() in FlowTable.
2484 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2486 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2488 2011-12-01 Ben Konrath <ben@bagu.org>
2490 Put the details css class name on the correct table column.
2492 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2494 2011-11-30 Ben Konrath <ben@bagu.org>
2496 Update for java-libglom API change.
2498 The getters and setters on FieldFormatting and NumericFormat were
2499 changed to remove the 'M'.
2501 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2503 2011-11-29 Ben Konrath <ben@bagu.org>
2505 Only allow RelatedListTables in Portals.
2507 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2509 2011-11-29 Ben Konrath <ben@bagu.org>
2511 Only create a contents panel for Portals when title is being set.
2513 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2515 2011-11-29 Ben Konrath <ben@bagu.org>
2517 Set TabLayoutPanel height based on calculated height its widgets.
2519 This is a potential fix for this bug:
2521 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2523 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2525 2011-11-29 Ben Konrath <ben@bagu.org>
2527 Align details field labels and data with the Open buttons.
2529 * src/main/webapp/style.css:
2531 2011-11-29 Ben Konrath <ben@bagu.org>
2533 Remove unnecessary <div> in the Notebook widget.
2535 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2536 method to get container FlowPanel (<div>).
2537 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2538 initWidget() method directly on the TabLayoutPanel widget instead of
2539 Group's container widget.
2541 2011-11-29 Ben Konrath <ben@bagu.org>
2543 Don't add group titles for Portals in Notebooks.
2545 This reverts the previous patch and fixes a bug I introduced with
2546 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2548 * src/main/java/org/glom/web/client/ui/details/Group.java:
2549 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2551 2011-11-28 Ben Konrath <ben@bagu.org>
2553 Remove unused boolean argument in Portal constructor.
2555 Just a code cleanup.
2557 * src/main/java/org/glom/web/client/ui/details/Group.java:
2558 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2560 2011-11-28 Ben Konrath <ben@bagu.org>
2562 Remove hack for glom 1.18 style glom files.
2564 * src/main/java/org/glom/web/client/ui/details/Group.java:
2565 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2566 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2568 2011-11-28 Ben Konrath <ben@bagu.org>
2570 Use Gda Value version of primary key to log result too large error.
2572 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2574 2011-11-28 Ben Konrath <ben@bagu.org>
2576 Don't use TypedDataItem.getText() for Unknown types from the URL.
2578 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2579 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2580 instead of getText().
2581 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2582 String field and getUnknown() method.
2584 2011-11-28 Ben Konrath <ben@bagu.org>
2586 Log an error message when the java-libglom .so is not present.
2588 The error message was being set in the exception but not logged.
2590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2592 2011-11-28 Ben Konrath <ben@bagu.org>
2594 Ignore LayoutItem_CalendarPortals.
2596 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2597 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2599 2011-11-28 Ben Konrath <ben@bagu.org>
2601 Extract method for creating the LayoutItemPortal DTO.
2603 Just breaking the code up into smaller chunks.
2605 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2607 2011-11-28 Ben Konrath <ben@bagu.org>
2611 This should have been added with the refactor. Oops!
2613 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2615 2011-11-28 Ben Konrath <ben@bagu.org>
2617 Create primary key value from URL string using type from Glom document.
2619 See this bug, comments 19 - 25:
2621 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2623 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2624 create a TypeDataItem for the primary key here when loading from a
2625 URL. Show the same string for the primary key value as was received
2626 from the URL string (when loading from a URL).
2627 * src/main/java/org/glom/web/server/Utils.java: Update method for
2628 creating the Gda Value from the TypeDataItem to properly deal with
2629 creating a Gda Value based on the Glom document type for the primary
2630 key value string when loading from a URL.
2631 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2632 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2633 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2634 Update for changed method name.
2636 2011-11-27 Ben Konrath <ben@bagu.org>
2638 Rename PrimaryKeyItem to TypedDataItem.
2640 The name PrimaryKeyItem suggests what the class should be used for.
2641 TypedDataItem is a neutral name that describes the class better.
2643 This is a rename-only refactor.
2645 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2646 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2647 * src/main/java/org/glom/web/client/Utils.java:
2648 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2649 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2650 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2651 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2652 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2653 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2655 * src/main/java/org/glom/web/server/Utils.java:
2656 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2657 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2658 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2659 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2661 2011-11-25 Ben Konrath <ben@bagu.org>
2663 Improve Gda Value conversion from PrimaryKeyItem.
2665 The value from the PrimaryKeyItem is only used if its type match the
2666 type from the glom document.
2668 * src/main/java/org/glom/web/server/Utils.java:
2670 2011-11-25 Ben Konrath <ben@bagu.org>
2672 Manually check if the java-liblgom .so is visible to the JVM.
2674 It seems that Tomcat has problems when a static initializer throws an
2675 exception. This check is done before the first method call into
2676 java-libglom so that execution doesn't continue if the .so is not
2679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2681 2011-11-25 Ben Konrath <ben@bagu.org>
2683 Improve browser configuration error messages.
2687 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2689 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2690 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2691 getConfigurationErrorMessage() method.
2692 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2693 Get and display a specific configuration error message when no Glom
2694 documents are found.
2695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2696 Implement getConfigurationErrorMessage() method. Surround configuration
2697 code in the init() method with a try/catch block. This allows the
2698 errors to be caught while keeping the servlet available to retrieve the
2699 configuration error message.
2701 2011-11-25 Ben Konrath <ben@bagu.org>
2703 Don't use Strings to hold primary key values.
2705 The primary key values are now held in a new data object
2706 (PrimaryKeyItem) that holds type information and the primary key value
2707 using the correct type.
2709 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2710 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2712 PrimaryKeyItem instead of String to hold the primary key value.
2713 * src/main/java/org/glom/web/client/Utils.java: Remove
2714 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2715 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2716 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2717 PrimaryKeyItem instead of String to hold the primary key value. Load
2718 document selection page when the documentID has not been set correctly.
2719 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2720 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2722 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2723 Return empty string for URL instead of "null".
2724 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2725 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2726 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2727 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2728 PrimaryKeyItem instead of String to hold primary key values.
2729 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2730 PrimaryKeyValue to a Gda Value.
2731 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2732 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2733 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2734 Replace temporary database access code that uses the PrimaryKeyValue to
2735 Gda Value conversion.
2736 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2737 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2738 PrimaryKeyItem instead of String.
2739 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2740 hold primary key values.
2742 2011-11-24 Ben Konrath <ben@bagu.org>
2744 Use newly added java-libglom API to create queries.
2746 This isn't finished. I still need to stop using Strings for primary key
2747 values in the client code.
2749 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2750 libglom to use fake connections so that retrieving the query string will
2752 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2753 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2754 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2755 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2756 Use the newly added libglom sql methods and classes to create the
2757 query. Add temporary hack to convert primary value strings to Gda
2760 2011-11-23 Ben Konrath <ben@bagu.org>
2762 Don't explicitly set the height of Portals.
2764 See comments 6 - 10 of this bug for details:
2766 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2768 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2770 2011-11-23 Ben Konrath <ben@bagu.org>
2772 Use an HTML table instead of CSS for the FlowTable layout.
2774 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2775 GWT's FlexTable to implement the FlowTable.
2776 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2778 2011-11-18 Ben Konrath <ben@bagu.org>
2780 Add boolean example to HTML table mockup.
2782 * mockups/details-view-html-tables-text-entries.html:
2784 2011-11-17 Ben Konrath <ben@bagu.org>
2786 Ensure the pager buttons are always visible for related lists.
2788 To accomplish this, I've turned off text wrapping in the list view and
2789 related list tables for both the header and data text. The related list
2790 table now has a fixed layout so the it doesn't overflow its container.
2791 This is required to ensure that the cell text is clipped when it
2792 overflows the cell and an ellipsis is added to the right side of the
2793 cell when text is clipped.
2795 A fixed table layout for the related list table in the details view
2796 seems what we want for the details view anyway, so the side-effect is
2799 The ellipsis will only be displayed in Firefox >= 7.
2803 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2805 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2806 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2807 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2809 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2810 Set the 'table-layout: fixed' CSS property to the related list table.
2811 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2812 'white-space: nowrap;' CSS property on both the list view and the
2813 related list tables.
2815 2011-11-16 Ben Konrath <ben@bagu.org>
2817 Rework the fix for empty notebook tab labels.
2819 Setting the empty group titles with its name caused problems for the
2820 details layout. Instead of using libglom's
2821 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2822 to the client when the title is empty. This allows the Notebook to use
2823 the name when the title is empty without affecting anything else.
2825 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2826 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2828 2011-11-16 Ben Konrath <ben@bagu.org>
2830 Set group titles with name when title is empty.
2832 This fixes a problem with an empty notebook tab label in the Lesson
2833 Planner document. The forth tab in the notebook should be "Internet":
2835 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2837 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2838 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2841 2011-11-16 Ben Konrath <ben@bagu.org>
2843 Remove whitespace from the configured username properties.
2845 This assumes that usernames won't have whitespace at the beginning
2846 or end. But I think this is a reasonable assumption.
2848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2849 String.trim() to remove the whitespace from the username properties.
2851 2011-11-15 Ben Konrath <ben@bagu.org>
2853 Add details view mockup with HTML tables and text entries.
2855 This is from the attachment on this bug:
2857 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2859 * mockups/details-view-html-tables-text-entries.html:
2861 2011-11-15 Ben Konrath <ben@bagu.org>
2863 Add space between the columns of the flow table.
2867 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2869 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2870 space between columns in the flow table.
2872 2011-11-15 Ben Konrath <ben@bagu.org>
2874 Add backup files to the .gitignore.
2876 * .gitignore: Ignore files that end with ~.
2878 2011-11-09 Ben Konrath <ben@bagu.org>
2880 Use latest release of gwt-log.
2882 Gwt-log releases are now being submitted to the maven central
2883 repository so manual installation of the jar is no longer required.
2885 * pom.xml: Update version and groupId of gwt-log dependency.
2887 2011-10-31 Ben Konrath <ben@bagu.org>
2889 Don't use GWT numeric formatting to override the glom currency formatting.
2891 Currencies are now displayed like they are in Glom. See this bug:
2893 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2895 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2897 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2898 currency code to constructor and set it when the cell is rendered.
2899 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2900 currency code to the constructor of the NumericCell.
2902 2011-10-27 Ben Konrath <ben@bagu.org>
2904 Require the latest release of java-libglom (1.17.4).
2908 2011-10-26 Ben Konrath <ben@bagu.org>
2910 Add style to Notebook that matches current theme.
2912 It's not the best style in the world but it's better than the default.
2914 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2915 padding at the bottom of the child widgets.
2916 * src/main/webapp/style.css: Add style for the Notebook.
2918 2011-10-26 Ben Konrath <ben@bagu.org>
2920 Move servlet initialization code to overridden init method.
2922 This is half of the solution to getting proper error messages
2923 displayed when configuration errors occur. Here's the relevant bug:
2925 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2927 The rest of the solution involves surrounding the init method with a
2928 try/catch block and setting a global variable with the error /
2929 exception. A new async method should be created to retrieve and display
2930 the error message / exception.
2932 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2933 code from constructor to init method adding exceptions as needed.
2935 2011-10-26 Ben Konrath <ben@bagu.org>
2937 Add script to monitor and restart tomcat if required.
2939 * utils/check-and-recover-tomcat.py: New file.
2941 2011-10-26 Ben Konrath <ben@bagu.org>
2943 Display the correct number of data items in the pager.
2947 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2949 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2950 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2951 The implementation is the same for both tables: Keep track of the
2952 number of non-empty rows and fire and RowCountChangeEvent after the data has
2954 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2955 custom Pager class that subclasses SimplePager to handle displaying
2956 the correct number when empty rows have been added.
2958 2011-10-26 Ben Konrath <ben@bagu.org>
2960 Correct error in previous commit.
2962 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2963 eventBus parameter from listView.setCellTable().
2965 2011-10-26 Ben Konrath <ben@bagu.org>
2967 Fix error in TODO comment.
2969 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2971 2011-10-24 Ben Konrath <ben@bagu.org>
2973 Create Notebook widgets to the details view.
2975 This isn't finished just yet - I still need to create a reasonable
2976 style to match the current theme.
2978 * src/main/java/org/glom/web/client/Utils.java: Add method for
2979 calculating the height of a widget. This is used in the Notebook class.
2980 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2981 new constructor method in Group.
2982 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2983 method for creating child widget that can be used by subclasses
2984 like Notebook. New constructor that allows disabling the group
2985 titles - Notebooks don't set a group title for their child groups.
2986 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2987 to make Notebooks using GWT's TabLayoutPanel.
2988 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2989 constructor that allows disabling the group titles.
2990 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2991 LayoutItemNotebook DTO.
2992 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2993 DTO for Notebooks. It's just an empty class for now but we might need
2994 it to transfer some specific information in the future.
2996 2011-10-21 Ben Konrath <ben@bagu.org>
2998 Add navigation buttons to related list tables.
3000 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3001 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3002 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
3003 method getSuitableRecordToViewDetails() for getting the table name
3004 and primary key value for related list navigation buttons.
3005 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3006 private cell renderer class to get the navigation information for
3007 related list tables from the server. Extract the navigation
3008 processing code from the details cell navigation and use it for the
3009 related list navigation as well.
3010 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
3011 cell renderer class for the details open buttons. This was needed
3012 because the related list navigation buttons and the list view
3013 navigation buttons need to react differently when clicked.
3014 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
3015 the onEnterKeyDown() method because it's now overriden in the
3016 subclasses that are specific to the related list tables and the list
3018 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
3019 the vertical size a little because the buttons add a bit of vertical
3020 space to table. This is not a perfect solution because the vertical
3021 size of with table fewer than 5 rows will be a little smaller.
3022 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
3023 changes in how navigation buttons are handled.
3024 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
3025 getSuitableRecordToViewDetails() using the new RelatedListNavigation
3026 database access object.
3027 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
3028 to find the portal for a given relationship name from
3029 RelatedListDBAccess. Add method to find a primary key field for a
3031 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3032 Move code to find the portal for a given relationship name to
3034 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3035 New file: database access object for getting the related list
3036 navigation information (the table name and the primary key value).
3037 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
3038 DTO for transferring a table name to navigate to and a primary key
3040 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3041 boolean and getter/setter to specifies if the related list should add
3044 2011-10-24 Murray Cumming <murrayc@murrayc.com>
3046 Use the master branch of java-libglom
3048 * pom.xml: Depend on java-libglom 1.19 instead.
3050 This is the master branch. See also the libglom-1-18 branch.
3052 2011-10-11 Ben Konrath <ben@bagu.org>
3054 Enable the open navigation button when the data has been set.
3056 This avoids having active buttons that don't do anything when the data
3059 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3061 2011-10-11 Ben Konrath <ben@bagu.org>
3063 Use IsWidget interface for FlowTableItem.
3065 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3066 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3068 2011-10-11 Ben Konrath <ben@bagu.org>
3070 Remove GWT styling from open button in details view.
3072 There are still some issues with how the details cell is arranged but
3073 this should be made to match Glom 1.20. I'm going to leave fixing this
3074 until I have Glom 1.20 up and running.
3076 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3077 style name on open button.
3078 * src/main/webapp/style.css: Move and edit details-navigation class.
3079 Re-arrange some classes to make them appear in the same order as the
3082 2011-10-07 Ben Konrath <ben@bagu.org>
3084 Update to GWT 2.4.0.
3086 * .gitignore: Ignore new cache directory.
3087 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3088 * pom.xml: Change GWT and maven plugin to 2.4.0.
3089 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3091 * src/main/java/org/glom/web/client/ClientFactory.java:
3092 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3093 * src/main/java/org/glom/web/client/OnlineGlom.java:
3094 Update source for API changes.
3095 * utils/build-onlineglom-war.sh: Remove cache directory before the
3098 2011-10-07 Ben Konrath <ben@bagu.org>
3100 Add navigation buttons in the details view.
3102 This isn't finished but I thought I'd commit what I have as it's a
3103 pretty good start. I still need to:
3105 1. Change the style so that it fits better into the current theme
3106 2. Adjust the details cell to expand as much as possible.
3108 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3109 click handlers to navigation buttons in the DetailsCells. Create a
3110 refreshData() method to get just the data from the server without the
3112 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3113 Update the tableSelector and browser title when the table name
3114 changes without using the tableSelector.
3115 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3116 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3117 getDetailsCells() to getCells(). Update variable names.
3118 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3119 method to set click handler on navigation button. Rename a few
3120 variables. Add navigation buttons where needed.
3121 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3122 variables and methods.
3123 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3124 navigation boolean and navigation table as required in the
3125 LayoutItemField DTO.
3126 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3127 variables for navigation along with getter/setter methods.
3129 2011-10-07 Ben Konrath <ben@bagu.org>
3131 Rename Field to DetailsCell.
3133 This is a refactor-only commit. No functionality has been added or
3136 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3137 Update variable and method names.
3138 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3139 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3140 variable and method names.
3141 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3143 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3144 variable and method names.
3146 2011-10-07 Ben Konrath <ben@bagu.org>
3148 Create separate methods for layout and data the details view.
3150 This is a refactor-only commit. No functionality has been added or
3153 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3154 private methods: setData(), createLayout().
3156 2011-10-07 Ben Konrath <ben@bagu.org>
3158 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3160 This is part of a change to get navigation buttons in the details view
3161 but it should have been done this way from the start.
3163 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3164 for method name change in TableSelectionView.
3165 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3166 Create TableChangeEvent and set the browser title using the
3167 TableSelectionView API.
3168 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3169 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3170 Change getSelectedTable() to getSelectedTableName(). Add
3171 getSelectedTableTitle().
3173 2011-10-07 Ben Konrath <ben@bagu.org>
3175 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3177 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3179 2011-10-07 Ben Konrath <ben@bagu.org>
3181 Update TableChangeEvent to use newTableName naming convention.
3183 This makes the class more consistent with GWT naming conventions.
3185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3186 Update for method name change in TableChangeEvent.
3187 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3188 for method name change in TableChangeEvent.
3189 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3190 newTableName variable and getter method. Make toDebugString()
3193 2011-09-30 Ben Konrath <ben@bagu.org>
3195 Disable the pager in the list tables when the data row count is less than the minimum.
3197 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3198 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3200 2011-09-30 Ben Konrath <ben@bagu.org>
3202 Add empty rows to the end of related list and list view tables.
3204 I also extracted the cell rendering classes from the ListTable because
3205 the code was becoming a little crazy with all the anonymous inner
3206 classes. My plan is to use these cell rendering classes in the details
3207 view as well so this refactor will be needed for that change.
3209 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3210 set the row count in related list tables if the data has more rows
3211 than the minimum number of rows visible.
3212 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3213 row count in list view tables if the data has more rows than the
3214 minimum number of rows visible.
3215 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3216 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3218 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3219 for rendering TYPE_NUMERIC cells. The code was extracted from the
3221 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3222 class for rendering cells with buttons in list views. The code was
3223 extracted from the ListTable class.
3224 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3225 for rendering TYPE_TEXT cells. The code was extracted from the
3227 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3228 Add empty rows to the end of the data if required. Implement
3229 ListTable.getMinNumVisibleRows().
3230 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3231 cell renderer code to public classes. Return null in
3232 Column.getValue() for empty rows. Add new abstract method:
3233 getMinNumVisibleRows(). Move code to set the row count of the list view
3234 table to ListViewImpl.
3235 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3236 empty rows to the end of the data if required. Implement
3237 ListTable.getMinNumVisibleRows().
3240 2011-09-27 Ben Konrath <ben@bagu.org>
3242 Use GWT.log for client-side debugging statements.
3244 These are optimized out when deployed so I should have used this method
3245 in the first place. These statements will eventually be replaced with some sort
3246 of notification in the browser.
3248 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3249 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3250 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3251 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3252 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3254 2011-09-27 Ben Konrath <ben@bagu.org>
3256 Put tableselector on the right, back to list link on right.
3258 The idea is that the table selector is acting like a label for the
3259 currently displayed table so it should be placed below the document title. This
3260 puts the table title in a similar position to where it is in Glom.
3262 * mockups/details-contacts.html:
3263 * mockups/details-projects.html:
3264 * mockups/listview-contacts.html:
3265 * mockups/listview-projects.html:
3266 * mockups/style.css:
3267 Update mockups to match how the interfaces currently look.