1 2012-01-02 Murray Cumming <murrayc@murrayc.com>
3 Move the *View::Presenter types, and some API into one base View.
5 * src/main/java/org/glom/web/client/ui/DetailsView.java:
6 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
7 * src/main/java/org/glom/web/client/ui/ListView.java:
8 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
9 Presenter, setPresenter() and clear() into a shared base interface,
10 to avoid the unnecessary duplicate Presenter types and to more clearly
11 show how the *Views share the same structure, even if they are not
14 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
15 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
17 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
18 * src/main/java/org/glom/web/client/activity/ListActivity.java:
19 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
21 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
24 Feel free to revert this if there is a good reason for the duplicate
27 2012-01-02 Murray Cumming <murrayc@murrayc.com>
29 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
31 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
32 a class member instead of a local variable in the method.
33 This lets us use it to get the view instances, for use in tests.
34 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
35 beforeOnlineGlom(): Test some more details of the initial view.
36 Again, this is not very useful.
38 To really test gwt-glom we will need to start a local postgresql
39 instance with local data, like the Glom tests in C++.
41 2012-01-02 Murray Cumming <murrayc@murrayc.com>
43 pom.xml: Mention the LGPL license.
45 * pom.xml: Add a licenses section.
46 * COPYING.LESSER: Move this to COPYING, which
47 previously contained the GPL. But gwt-glom is all LGPL.
49 2012-01-02 Murray Cumming <murrayc@murrayc.com>
51 Add project information to README and pom.xml.
53 * README: Add a brief description and mention some mvn
55 * pom.xml: This extra information shows up in mvn site
58 2011-01-02 Murray Cumming <murrayc@murrayc.com>
60 Use the latest java-libglom version.
62 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
64 2012-01-01 Murray Cumming <murrayc@murrayc.com>
66 GwtTestOnlineGlom: Test a little more.
68 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
69 protected rather than private, as suggested by the gwt-test-utils
71 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
72 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
73 Test the initial visibility of the panels.
75 However, this is not a very useful test.
76 And I wonder how we should generally test using this idea for an
77 activity/places app like ours where the real changes happen implicitly
78 based on the history token/URL.
80 2012-01-01 Murray Cumming <murrayc@murrayc.com>
82 Slight modification to *Mapper comments.
84 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
86 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
88 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
90 Remove comments mentioning GIN because they are just copied from
91 the example code and are apparently not helpful:
92 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
93 Also change the mention of a class that is only in the example code.
95 2012-01-01 Murray Cumming <murrayc@murrayc.com>
97 GwtTestOnlineGlom test: Minor changes.
99 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
100 Avoid the long qualified class name and modify the comment
101 because it is now obvious to me that the mocked class is the only
102 custom one created via GWT.create().
104 2012-01-01 Murray Cumming <murrayc@murrayc.com>
106 Tests: Added the beginnings of a test using gwt-test-utils.
108 * pom.xml: Add dependencies on gwt-test-utils and easymock.
109 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
110 which tells gwt-test-utils what class will be tested.
111 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
112 Add a simple (but empty) test case. One class, used by the OnlineGlom
113 class, is mocked so that it can be created. However, I am not sure
114 why only this class needs to be mocked.
116 Note that mockito seems more popular, and clearer, than easymock,
117 but I have not got that working yet. It might be a matter of the
120 This test is run during mvn integration-test.
122 2011-12-31 Murray Cumming <murrayc@murrayc.com>
124 Tests: Use junit4-style syntax instead of junit3-style.
126 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
127 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
128 * src/test/java/org/glom/web/shared/DataItemTest.java:
129 Use the @Test annotation rather than relying on the test*() prefix.
130 Also no longer implement TestCase, to avoid triggering support for
131 the junit3-way, which stops the annotations from working.
132 Change the imports from import junit.framework.* to
133 import org.junit.*, which is apparently the new way.
135 2011-12-31 Murray Cumming <murrayc@murrayc.com>
137 Added a test for ListPlace token parsing and creation.
139 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
140 This is much the same as DetailsPlaceTest.
142 I wonder how we could test the other parts of the *Place API.
144 2011-12-30 Murray Cumming <murrayc@murrayc.com>
146 DetailsPlace test: Also test getToken() and recreation via getPlace().
148 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
149 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
150 recreate it, testing the recreated DetailsPlace for the same parameter
153 2011-12-30 Murray Cumming <murrayc@murrayc.com>
155 Use the surefire-report plugin.
157 * pom.xml: This generates a HTML report about the tests in
158 target/site/surefire-report.html
159 when you do mvn surefire-report:report. It seems to be popular/normal.
161 2011-12-30 Murray Cumming <murrayc@murrayc.com>
163 Added a test for DetailsPlace.
165 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
166 Test the getPlace() token parsing.
168 2011-12-30 Murray Cumming <murrayc@murrayc.com>
170 Added a first unit test.
172 * pom.xml: Add a test goal, and a dependency on junit in that scope.
173 * src/test/java/org/glom/web/shared/DataItemTest.java:
174 This is a silly test but it is just to get things started. Note that
175 maven/junit finds the test because it looks in src/test by default.
177 2011-12-22 Ben Konrath <ben@bagu.org>
179 Change charsetName to "UTF-8" when replacing line breaks.
181 JavaScript requires the charsetName to be "UTF-8". CharsetName values
182 that work in Java (such as "UTF8") will not work when compiled to
185 This fixes a problem with multi-line details view fields that have hard
186 line breaks. The "License Text" field on this page demonstrates the
189 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
191 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
193 2011-12-22 Ben Konrath <ben@bagu.org>
195 Fix another bug with related list navigation.
197 I've tested all the navigation buttons in all of the related lists
198 so things should be good now.
200 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
202 2011-12-22 Ben Konrath <ben@bagu.org>
204 Fix a crasher when refreshing the list view with the default table.
206 This crash will also happen when loading the list view with the default
207 table from a link or bookmark.
209 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
210 to the main document selection page when the document id hasn't been
212 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
213 the main document selection page when the document id hasn't been
215 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
216 values for the details place when the document id hasn't been set.
217 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
218 values for the list place when the document id hasn't been set.
220 2011-12-21 Ben Konrath <ben@bagu.org>
222 Protect against NPE when glom.document.locale is not in config.
224 This patch protects against an NPE when glom.document.locale is not in
225 the config file. This NPE will also happen if glom.document.locale is
228 The patch also updates the error message to display the class name when
229 the getMessage() returns null. This was happening when the NPE was
230 thrown and I had "Configuration Error: null". If an NPE is encountered
231 with this patch, "Configuration Error: NullPointerException " will be
234 This commit closes this bug:
236 https://bugzilla.gnome.org/show_bug.cgi?id=666669
238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
240 2011-12-20 Murray Cumming <murrayc@murrayc.com>
242 Rename onlineglom.properties to onlineglom.properties.sample.
244 * src/main/resources/onlineglom.properties: Rename to:
245 * src/main/resources/onlineglom.properties.sample:
246 * src/main/resources/README: And add this file explaining that people
247 should rename it back when deploying.
249 2011-12-20 Murray Cumming <murrayc@murrayc.com>
251 Allow choosing the translation in the .properties file.
253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
254 init(): Read a glom.document.locale value from the configuration file
255 and call Glom's TransatableItem::set_current_locale() method.
256 * src/main/resources/onlineglom.properties: Add a commented-out
257 example of this new setting.
259 It would be better to add &lang=de_DE to the URL, but the current
260 libglom API does not allow us to do this easily. I am working on that.
262 2011-12-19 Murray Cumming <murrayc@murrayc.com>
264 Avoid a crash in parsing of token parameters.
266 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
267 ava: getTokenParams(): Do not crash if a parameter has a key but no
268 value, and ignore parameters with neither.
270 2011-12-17 Murray Cumming <murrayc@murayc.com>
272 History token building/handling: Improve use of token parameters.
274 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
275 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
276 and buildParamsToken(HashMap), for use by derived classes.
277 Make the separator private because it is no longer be needed.
278 * src/main/java/org/glom/web/client/place/DetailsPlace.java
279 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
280 instead of manual string concatenation.
281 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
282 of hardcoded indices and awkward splitting code.
283 * src/main/java/org/glom/web/client/place/ListPlace.java
284 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
285 instead of manual string concatenation.
286 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
287 of hardcoded indices and awkward splitting code.
288 This should fix bug #666420
290 2011-12-16 Murray Cumming <murrayc@murrayc.com>
292 Fix a Navgiation->Navigation typo in the code.
294 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
295 Rename processNavgiation() to processNavigation().
297 2011-12-16 Murray Cumming <murrayc@murrayc.com>
299 Fix a seperator->separator typo in the code.
301 * src/main/java/org/glom/web/client/place/DetailsPlace.java
302 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
303 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
306 2011-12-15 Ben Konrath <ben@bagu.org>
308 Cleanup some comments.
310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
312 2011-12-14 Ben Konrath <ben@bagu.org>
314 Replace \n with <br/> for multiline text in the details view.
316 Vertical scrollbars are added when needed as well.
318 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
320 2011-12-14 Ben Konrath <ben@bagu.org>
322 Specify the font for document selection links.
324 * src/main/webapp/style.css:
326 2011-12-14 Ben Konrath <ben@bagu.org>
328 Fix bouncy CellTable while paging.
330 This doesn't currently work with related list tables in unselected
333 * src/main/java/org/glom/web/client/ui/list/ListTable.java
335 2011-12-14 Ben Konrath <ben@bagu.org>
337 Revamp the appearance of the document selection page.
339 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
340 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
341 * src/main/webapp/style.css:
343 2011-12-13 Ben Konrath <ben@bagu.org>
345 Set navigation button column to the smallest size possible.
347 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
349 2011-12-13 Ben Konrath <ben@bagu.org>
351 Change OpenButton nomenclature to NavigationButton.
353 Using NavigtionButton makes things more generic. Classes, methods and
354 variables have been changed.
356 This is a rename-only refactor.
358 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
359 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
360 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
361 Renamed from OpenButtonCell.
362 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
363 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
364 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
366 2011-12-12 Ben Konrath <ben@bagu.org>
368 Remove unnecessary String argument in RelatedListTable and ListViewTable.
370 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
371 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
372 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
373 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
375 2011-12-12 Ben Konrath <ben@bagu.org>
377 Update variable names and comments.
379 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
380 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
382 2011-12-12 Ben Konrath <ben@bagu.org>
384 Properly initialize numNonEmptyRows variable to zero.
386 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
387 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
389 2011-12-05 Ben Konrath <ben@bagu.org>
391 Add latest mockup with HTML tables.
393 Features of this mockup:
395 -> HTML table for flowtable
396 -> HTML table for flowtable column
397 -> Example of how related lists would look
398 -> Not using text entries for data items
400 The current version of Online Glom doesn't use HTML tables for the
403 This mockup has been sent to the glom-devel mailing list but it's good
404 to have it here as well.
406 * mockups/details-view-html-tables.html:
408 2011-12-05 Ben Konrath <ben@bagu.org>
410 Remove unnecessary getPrimaryKeyField() method.
412 getPrimaryKeyFieldForTable(String) has been renamed to
413 getPrimaryKeyField(String).
415 * src/main/java/org/glom/web/server/database/DBAccess.java:
416 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
417 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
419 2011-12-05 Ben Konrath <ben@bagu.org>
421 Add string representation of TypedDataItem value to conversion error message.
423 * src/main/java/org/glom/web/server/Utils.java: Logging the error
424 message was extracted into its own method to avoid duplication.
426 2011-12-05 Ben Konrath <ben@bagu.org>
428 Add type checking to navigation primary key value creation.
430 Create navigation primary key only if the expected type from the Glom
431 document matches the type returned by the SQL query.
433 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
435 2011-12-05 Ben Konrath <ben@bagu.org>
437 Rename a couple of variables in RelatedListNavigation.
439 This is a rename-only refactor.
441 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
443 2011-12-05 Ben Konrath <ben@bagu.org>
445 Move getListLayoutGroup() into getListViewLayoutGroup().
447 This removes getListLayoutGroup(). It was only being called by
448 getListViewLayoutGroup().
450 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
452 2011-12-05 Ben Konrath <ben@bagu.org>
454 Remove check for LayoutItem_Portal in list table method.
456 This check is no longer necessary because the method isn't being used
457 to create the LayoutItemPortal DTO.
459 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
461 2011-12-05 Ben Konrath <ben@bagu.org>
463 Properly support related list navigation.
465 Navigation from the "Repository Analyzer -> Package Scans ->
466 Dependencies" related table wasn't working because the primary key for
467 related tables wasn't being set properly. This commit fixes the
470 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
471 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
472 doesn't set the primary key properly for related list tables.
473 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
474 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
475 useful for getting the primary key for list view tables and for related
477 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
478 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
479 Move code to set the primary key for the table from the abstract
480 ListDBAccess class to ListViewDBAccess as it's only correct for list
482 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
483 Properly add primary key to related list tables.
485 2011-12-02 Ben Konrath <ben@bagu.org>
487 Properly set the horizontal alignment of fields.
489 This fix is for both the list tables and the details view.
491 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
492 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
493 to set the horizontal alignment of fields.
495 2011-12-02 Ben Konrath <ben@bagu.org>
497 Display currency codes in the details view.
499 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
501 2011-12-02 Ben Konrath <ben@bagu.org>
503 Avoid duplicate JNI call.
505 JNI is not as efficient as pure Java and this is an easy (and small)
508 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
509 Use previously retrieved value for whereClauseToTableName instead of
512 2011-12-02 Ben Konrath <ben@bagu.org>
514 Rename a couple of variables in RelatedListNavigation.
516 This is a rename-only refactor.
518 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
520 2011-12-02 Ben Konrath <ben@bagu.org>
522 Indicate clearly that a mismatched primary key type is a bug.
524 * src/main/java/org/glom/web/server/Utils.java: Change log level from
525 warning to error. Add 'This is a bug.' to message.
527 2011-12-02 Ben Konrath <ben@bagu.org>
529 Update / fix some comments.
531 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
533 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
535 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
536 Fix comments. Add some TODOs.
538 2011-12-02 Ben Konrath <ben@bagu.org>
540 Enable navigation to details view with string primary key from related list.
542 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
543 Create a text primary key value when return type of result is
544 java.sql.Types.VARCHAR.
546 2011-12-02 Ben Konrath <ben@bagu.org>
548 Use checkboxes for booleans in the details view.
550 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
552 2011-12-01 Ben Konrath <ben@bagu.org>
554 Improve performance of related list height calculation.
556 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
557 Put code to calculate the expected height in a static initializer so
558 that that it's only called once.
560 2011-12-01 Ben Konrath <ben@bagu.org>
562 Show related list tables in notebooks (again).
564 Calculate the height of the related list tables so the Notebook can be
565 set the correct height. The height of the related list table is also needed by
566 FlowTable to be able decide how to create the layout.
568 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
569 and set the Portal height based on the height of the related list
570 table and the Portal container.
571 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
572 Add method to calculate the height of the related list tables.
573 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
574 * src/main/webapp/style.css: Add css class for Pager. This is needed to
575 calculate the height of the Pager widget.
577 2011-12-01 Ben Konrath <ben@bagu.org>
579 Use CellTable API for table property instead of setting style on Element.
581 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
583 2011-12-01 Ben Konrath <ben@bagu.org>
585 Make ListViewTable and RelatedListTable a consistent height.
587 The tables are now a consistent height regardless of the contents of
588 the table. A hidden button is added to empty rows to ensure that the
589 height of these rows will match the height of rows with data.
591 A navigation button column is now added to every table. The width of
592 the navigation column is set to 0px when a RelatedListTable shouldn't
593 have navigation buttons. This maintains the a consistent row height in
594 tables that don't show the navigation buttons.
596 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
597 navigation column when not needed.
598 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
599 arguments for navigation button to constructor of ListViewTable.
600 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
601 hidden button for empty data rows.
602 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
603 arguments for navigation button to constructor.
604 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
605 create navigation buttons. Add hideNavigationButtons() method.
606 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
607 arguments for navigation button to constructor.
609 2011-12-01 Ben Konrath <ben@bagu.org>
611 Use 'visibility: hidden' in Utils.getWidgetHeight().
613 This is better choice because hidden elements are invisible, don't
614 respond to events and are not part of the tab order. They will,
615 however, take up space which is required to be able to calculate the
616 height of the widget.
618 * src/main/java/org/glom/web/client/Utils.java:
620 2011-12-01 Ben Konrath <ben@bagu.org>
622 Use Utils.getWidgetHeight() in FlowTable.
624 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
626 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
628 2011-12-01 Ben Konrath <ben@bagu.org>
630 Put the details css class name on the correct table column.
632 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
634 2011-11-30 Ben Konrath <ben@bagu.org>
636 Update for java-libglom API change.
638 The getters and setters on FieldFormatting and NumericFormat were
639 changed to remove the 'M'.
641 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
643 2011-11-29 Ben Konrath <ben@bagu.org>
645 Only allow RelatedListTables in Portals.
647 * src/main/java/org/glom/web/client/ui/details/Portal.java:
649 2011-11-29 Ben Konrath <ben@bagu.org>
651 Only create a contents panel for Portals when title is being set.
653 * src/main/java/org/glom/web/client/ui/details/Portal.java:
655 2011-11-29 Ben Konrath <ben@bagu.org>
657 Set TabLayoutPanel height based on calculated height its widgets.
659 This is a potential fix for this bug:
661 https://bugzilla.gnome.org/show_bug.cgi?id=665133
663 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
665 2011-11-29 Ben Konrath <ben@bagu.org>
667 Align details field labels and data with the Open buttons.
669 * src/main/webapp/style.css:
671 2011-11-29 Ben Konrath <ben@bagu.org>
673 Remove unnecessary <div> in the Notebook widget.
675 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
676 method to get container FlowPanel (<div>).
677 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
678 initWidget() method directly on the TabLayoutPanel widget instead of
679 Group's container widget.
681 2011-11-29 Ben Konrath <ben@bagu.org>
683 Don't add group titles for Portals in Notebooks.
685 This reverts the previous patch and fixes a bug I introduced with
686 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
688 * src/main/java/org/glom/web/client/ui/details/Group.java:
689 * src/main/java/org/glom/web/client/ui/details/Portal.java:
691 2011-11-28 Ben Konrath <ben@bagu.org>
693 Remove unused boolean argument in Portal constructor.
697 * src/main/java/org/glom/web/client/ui/details/Group.java:
698 * src/main/java/org/glom/web/client/ui/details/Portal.java:
700 2011-11-28 Ben Konrath <ben@bagu.org>
702 Remove hack for glom 1.18 style glom files.
704 * src/main/java/org/glom/web/client/ui/details/Group.java:
705 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
706 * src/main/java/org/glom/web/client/ui/details/Portal.java:
708 2011-11-28 Ben Konrath <ben@bagu.org>
710 Use Gda Value version of primary key to log result too large error.
712 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
714 2011-11-28 Ben Konrath <ben@bagu.org>
716 Don't use TypedDataItem.getText() for Unknown types from the URL.
718 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
719 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
720 instead of getText().
721 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
722 String field and getUnknown() method.
724 2011-11-28 Ben Konrath <ben@bagu.org>
726 Log an error message when the java-libglom .so is not present.
728 The error message was being set in the exception but not logged.
730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
732 2011-11-28 Ben Konrath <ben@bagu.org>
734 Ignore LayoutItem_CalendarPortals.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
737 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
739 2011-11-28 Ben Konrath <ben@bagu.org>
741 Extract method for creating the LayoutItemPortal DTO.
743 Just breaking the code up into smaller chunks.
745 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
747 2011-11-28 Ben Konrath <ben@bagu.org>
751 This should have been added with the refactor. Oops!
753 * src/main/java/org/glom/web/shared/TypedDataItem.java:
755 2011-11-28 Ben Konrath <ben@bagu.org>
757 Create primary key value from URL string using type from Glom document.
759 See this bug, comments 19 - 25:
761 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
763 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
764 create a TypeDataItem for the primary key here when loading from a
765 URL. Show the same string for the primary key value as was received
766 from the URL string (when loading from a URL).
767 * src/main/java/org/glom/web/server/Utils.java: Update method for
768 creating the Gda Value from the TypeDataItem to properly deal with
769 creating a Gda Value based on the Glom document type for the primary
770 key value string when loading from a URL.
771 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
772 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
773 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
774 Update for changed method name.
776 2011-11-27 Ben Konrath <ben@bagu.org>
778 Rename PrimaryKeyItem to TypedDataItem.
780 The name PrimaryKeyItem suggests what the class should be used for.
781 TypedDataItem is a neutral name that describes the class better.
783 This is a rename-only refactor.
785 * src/main/java/org/glom/web/client/OnlineGlomService.java:
786 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
787 * src/main/java/org/glom/web/client/Utils.java:
788 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
789 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
790 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
791 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
792 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
793 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
794 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
795 * src/main/java/org/glom/web/server/Utils.java:
796 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
797 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
798 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
799 * src/main/java/org/glom/web/shared/NavigationRecord.java:
801 2011-11-25 Ben Konrath <ben@bagu.org>
803 Improve Gda Value conversion from PrimaryKeyItem.
805 The value from the PrimaryKeyItem is only used if its type match the
806 type from the glom document.
808 * src/main/java/org/glom/web/server/Utils.java:
810 2011-11-25 Ben Konrath <ben@bagu.org>
812 Manually check if the java-liblgom .so is visible to the JVM.
814 It seems that Tomcat has problems when a static initializer throws an
815 exception. This check is done before the first method call into
816 java-libglom so that execution doesn't continue if the .so is not
819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
821 2011-11-25 Ben Konrath <ben@bagu.org>
823 Improve browser configuration error messages.
827 https://bugzilla.gnome.org/show_bug.cgi?id=662792
829 * src/main/java/org/glom/web/client/OnlineGlomService.java:
830 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
831 getConfigurationErrorMessage() method.
832 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
833 Get and display a specific configuration error message when no Glom
835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
836 Implement getConfigurationErrorMessage() method. Surround configuration
837 code in the init() method with a try/catch block. This allows the
838 errors to be caught while keeping the servlet available to retrieve the
839 configuration error message.
841 2011-11-25 Ben Konrath <ben@bagu.org>
843 Don't use Strings to hold primary key values.
845 The primary key values are now held in a new data object
846 (PrimaryKeyItem) that holds type information and the primary key value
847 using the correct type.
849 * src/main/java/org/glom/web/client/OnlineGlomService.java:
850 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
852 PrimaryKeyItem instead of String to hold the primary key value.
853 * src/main/java/org/glom/web/client/Utils.java: Remove
854 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
855 PrimaryKeyItem based on the GlomFieldType and the DataItem.
856 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
857 PrimaryKeyItem instead of String to hold the primary key value. Load
858 document selection page when the documentID has not been set correctly.
859 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
860 DetailsPlace -> URL and URL -> DetailsPlace conversion with
862 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
863 Return empty string for URL instead of "null".
864 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
865 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
866 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
867 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
868 PrimaryKeyItem instead of String to hold primary key values.
869 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
870 PrimaryKeyValue to a Gda Value.
871 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
872 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
873 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
874 Replace temporary database access code that uses the PrimaryKeyValue to
875 Gda Value conversion.
876 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
877 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
878 PrimaryKeyItem instead of String.
879 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
880 hold primary key values.
882 2011-11-24 Ben Konrath <ben@bagu.org>
884 Use newly added java-libglom API to create queries.
886 This isn't finished. I still need to stop using Strings for primary key
887 values in the client code.
889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
890 libglom to use fake connections so that retrieving the query string will
892 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
893 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
894 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
895 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
896 Use the newly added libglom sql methods and classes to create the
897 query. Add temporary hack to convert primary value strings to Gda
900 2011-11-23 Ben Konrath <ben@bagu.org>
902 Don't explicitly set the height of Portals.
904 See comments 6 - 10 of this bug for details:
906 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
908 * src/main/java/org/glom/web/client/ui/details/Portal.java:
910 2011-11-23 Ben Konrath <ben@bagu.org>
912 Use an HTML table instead of CSS for the FlowTable layout.
914 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
915 GWT's FlexTable to implement the FlowTable.
916 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
918 2011-11-18 Ben Konrath <ben@bagu.org>
920 Add boolean example to HTML table mockup.
922 * mockups/details-view-html-tables-text-entries.html:
924 2011-11-17 Ben Konrath <ben@bagu.org>
926 Ensure the pager buttons are always visible for related lists.
928 To accomplish this, I've turned off text wrapping in the list view and
929 related list tables for both the header and data text. The related list
930 table now has a fixed layout so the it doesn't overflow its container.
931 This is required to ensure that the cell text is clipped when it
932 overflows the cell and an ellipsis is added to the right side of the
933 cell when text is clipped.
935 A fixed table layout for the related list table in the details view
936 seems what we want for the details view anyway, so the side-effect is
939 The ellipsis will only be displayed in Firefox >= 7.
943 https://bugzilla.gnome.org/show_bug.cgi?id=662930
945 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
946 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
947 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
949 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
950 Set the 'table-layout: fixed' CSS property to the related list table.
951 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
952 'white-space: nowrap;' CSS property on both the list view and the
955 2011-11-16 Ben Konrath <ben@bagu.org>
957 Rework the fix for empty notebook tab labels.
959 Setting the empty group titles with its name caused problems for the
960 details layout. Instead of using libglom's
961 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
962 to the client when the title is empty. This allows the Notebook to use
963 the name when the title is empty without affecting anything else.
965 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
966 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
968 2011-11-16 Ben Konrath <ben@bagu.org>
970 Set group titles with name when title is empty.
972 This fixes a problem with an empty notebook tab label in the Lesson
973 Planner document. The forth tab in the notebook should be "Internet":
975 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
977 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
978 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
981 2011-11-16 Ben Konrath <ben@bagu.org>
983 Remove whitespace from the configured username properties.
985 This assumes that usernames won't have whitespace at the beginning
986 or end. But I think this is a reasonable assumption.
988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
989 String.trim() to remove the whitespace from the username properties.
991 2011-11-15 Ben Konrath <ben@bagu.org>
993 Add details view mockup with HTML tables and text entries.
995 This is from the attachment on this bug:
997 https://bugzilla.gnome.org/show_bug.cgi?id=663109
999 * mockups/details-view-html-tables-text-entries.html:
1001 2011-11-15 Ben Konrath <ben@bagu.org>
1003 Add space between the columns of the flow table.
1007 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1009 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1010 space between columns in the flow table.
1012 2011-11-15 Ben Konrath <ben@bagu.org>
1014 Add backup files to the .gitignore.
1016 * .gitignore: Ignore files that end with ~.
1018 2011-11-09 Ben Konrath <ben@bagu.org>
1020 Use latest release of gwt-log.
1022 Gwt-log releases are now being submitted to the maven central
1023 repository so manual installation of the jar is no longer required.
1025 * pom.xml: Update version and groupId of gwt-log dependency.
1027 2011-10-31 Ben Konrath <ben@bagu.org>
1029 Don't use GWT numeric formatting to override the glom currency formatting.
1031 Currencies are now displayed like they are in Glom. See this bug:
1033 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1035 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1037 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1038 currency code to constructor and set it when the cell is rendered.
1039 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1040 currency code to the constructor of the NumericCell.
1042 2011-10-27 Ben Konrath <ben@bagu.org>
1044 Require the latest release of java-libglom (1.17.4).
1048 2011-10-26 Ben Konrath <ben@bagu.org>
1050 Add style to Notebook that matches current theme.
1052 It's not the best style in the world but it's better than the default.
1054 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1055 padding at the bottom of the child widgets.
1056 * src/main/webapp/style.css: Add style for the Notebook.
1058 2011-10-26 Ben Konrath <ben@bagu.org>
1060 Move servlet initialization code to overridden init method.
1062 This is half of the solution to getting proper error messages
1063 displayed when configuration errors occur. Here's the relevant bug:
1065 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1067 The rest of the solution involves surrounding the init method with a
1068 try/catch block and setting a global variable with the error /
1069 exception. A new async method should be created to retrieve and display
1070 the error message / exception.
1072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1073 code from constructor to init method adding exceptions as needed.
1075 2011-10-26 Ben Konrath <ben@bagu.org>
1077 Add script to monitor and restart tomcat if required.
1079 * utils/check-and-recover-tomcat.py: New file.
1081 2011-10-26 Ben Konrath <ben@bagu.org>
1083 Display the correct number of data items in the pager.
1087 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1089 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1090 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1091 The implementation is the same for both tables: Keep track of the
1092 number of non-empty rows and fire and RowCountChangeEvent after the data has
1094 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1095 custom Pager class that subclasses SimplePager to handle displaying
1096 the correct number when empty rows have been added.
1098 2011-10-26 Ben Konrath <ben@bagu.org>
1100 Correct error in previous commit.
1102 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1103 eventBus parameter from listView.setCellTable().
1105 2011-10-26 Ben Konrath <ben@bagu.org>
1107 Fix error in TODO comment.
1109 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1111 2011-10-24 Ben Konrath <ben@bagu.org>
1113 Create Notebook widgets to the details view.
1115 This isn't finished just yet - I still need to create a reasonable
1116 style to match the current theme.
1118 * src/main/java/org/glom/web/client/Utils.java: Add method for
1119 calculating the height of a widget. This is used in the Notebook class.
1120 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1121 new constructor method in Group.
1122 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1123 method for creating child widget that can be used by subclasses
1124 like Notebook. New constructor that allows disabling the group
1125 titles - Notebooks don't set a group title for their child groups.
1126 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1127 to make Notebooks using GWT's TabLayoutPanel.
1128 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1129 constructor that allows disabling the group titles.
1130 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1131 LayoutItemNotebook DTO.
1132 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1133 DTO for Notebooks. It's just an empty class for now but we might need
1134 it to transfer some specific information in the future.
1136 2011-10-21 Ben Konrath <ben@bagu.org>
1138 Add navigation buttons to related list tables.
1140 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1141 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1143 method getSuitableRecordToViewDetails() for getting the table name
1144 and primary key value for related list navigation buttons.
1145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1146 private cell renderer class to get the navigation information for
1147 related list tables from the server. Extract the navigation
1148 processing code from the details cell navigation and use it for the
1149 related list navigation as well.
1150 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1151 cell renderer class for the details open buttons. This was needed
1152 because the related list navigation buttons and the list view
1153 navigation buttons need to react differently when clicked.
1154 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1155 the onEnterKeyDown() method because it's now overriden in the
1156 subclasses that are specific to the related list tables and the list
1158 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1159 the vertical size a little because the buttons add a bit of vertical
1160 space to table. This is not a perfect solution because the vertical
1161 size of with table fewer than 5 rows will be a little smaller.
1162 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1163 changes in how navigation buttons are handled.
1164 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1165 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1166 database access object.
1167 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1168 to find the portal for a given relationship name from
1169 RelatedListDBAccess. Add method to find a primary key field for a
1171 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1172 Move code to find the portal for a given relationship name to
1174 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1175 New file: database access object for getting the related list
1176 navigation information (the table name and the primary key value).
1177 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1178 DTO for transferring a table name to navigate to and a primary key
1180 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1181 boolean and getter/setter to specifies if the related list should add
1184 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1186 Use the master branch of java-libglom
1188 * pom.xml: Depend on java-libglom 1.19 instead.
1190 This is the master branch. See also the libglom-1-18 branch.
1192 2011-10-11 Ben Konrath <ben@bagu.org>
1194 Enable the open navigation button when the data has been set.
1196 This avoids having active buttons that don't do anything when the data
1199 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1201 2011-10-11 Ben Konrath <ben@bagu.org>
1203 Use IsWidget interface for FlowTableItem.
1205 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1206 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1208 2011-10-11 Ben Konrath <ben@bagu.org>
1210 Remove GWT styling from open button in details view.
1212 There are still some issues with how the details cell is arranged but
1213 this should be made to match Glom 1.20. I'm going to leave fixing this
1214 until I have Glom 1.20 up and running.
1216 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1217 style name on open button.
1218 * src/main/webapp/style.css: Move and edit details-navigation class.
1219 Re-arrange some classes to make them appear in the same order as the
1222 2011-10-07 Ben Konrath <ben@bagu.org>
1224 Update to GWT 2.4.0.
1226 * .gitignore: Ignore new cache directory.
1227 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1228 * pom.xml: Change GWT and maven plugin to 2.4.0.
1229 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1231 * src/main/java/org/glom/web/client/ClientFactory.java:
1232 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1233 * src/main/java/org/glom/web/client/OnlineGlom.java:
1234 Update source for API changes.
1235 * utils/build-onlineglom-war.sh: Remove cache directory before the
1238 2011-10-07 Ben Konrath <ben@bagu.org>
1240 Add navigation buttons in the details view.
1242 This isn't finished but I thought I'd commit what I have as it's a
1243 pretty good start. I still need to:
1245 1. Change the style so that it fits better into the current theme
1246 2. Adjust the details cell to expand as much as possible.
1248 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1249 click handlers to navigation buttons in the DetailsCells. Create a
1250 refreshData() method to get just the data from the server without the
1252 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1253 Update the tableSelector and browser title when the table name
1254 changes without using the tableSelector.
1255 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1256 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1257 getDetailsCells() to getCells(). Update variable names.
1258 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1259 method to set click handler on navigation button. Rename a few
1260 variables. Add navigation buttons where needed.
1261 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1262 variables and methods.
1263 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1264 navigation boolean and navigation table as required in the
1265 LayoutItemField DTO.
1266 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1267 variables for navigation along with getter/setter methods.
1269 2011-10-07 Ben Konrath <ben@bagu.org>
1271 Rename Field to DetailsCell.
1273 This is a refactor-only commit. No functionality has been added or
1276 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1277 Update variable and method names.
1278 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1279 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1280 variable and method names.
1281 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1283 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1284 variable and method names.
1286 2011-10-07 Ben Konrath <ben@bagu.org>
1288 Create separate methods for layout and data the details view.
1290 This is a refactor-only commit. No functionality has been added or
1293 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1294 private methods: setData(), createLayout().
1296 2011-10-07 Ben Konrath <ben@bagu.org>
1298 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1300 This is part of a change to get navigation buttons in the details view
1301 but it should have been done this way from the start.
1303 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1304 for method name change in TableSelectionView.
1305 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1306 Create TableChangeEvent and set the browser title using the
1307 TableSelectionView API.
1308 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1309 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1310 Change getSelectedTable() to getSelectedTableName(). Add
1311 getSelectedTableTitle().
1313 2011-10-07 Ben Konrath <ben@bagu.org>
1315 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1317 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1319 2011-10-07 Ben Konrath <ben@bagu.org>
1321 Update TableChangeEvent to use newTableName naming convention.
1323 This makes the class more consistent with GWT naming conventions.
1325 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1326 Update for method name change in TableChangeEvent.
1327 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1328 for method name change in TableChangeEvent.
1329 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1330 newTableName variable and getter method. Make toDebugString()
1333 2011-09-30 Ben Konrath <ben@bagu.org>
1335 Disable the pager in the list tables when the data row count is less than the minimum.
1337 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1338 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1340 2011-09-30 Ben Konrath <ben@bagu.org>
1342 Add empty rows to the end of related list and list view tables.
1344 I also extracted the cell rendering classes from the ListTable because
1345 the code was becoming a little crazy with all the anonymous inner
1346 classes. My plan is to use these cell rendering classes in the details
1347 view as well so this refactor will be needed for that change.
1349 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1350 set the row count in related list tables if the data has more rows
1351 than the minimum number of rows visible.
1352 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1353 row count in list view tables if the data has more rows than the
1354 minimum number of rows visible.
1355 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1356 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1358 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1359 for rendering TYPE_NUMERIC cells. The code was extracted from the
1361 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1362 class for rendering cells with buttons in list views. The code was
1363 extracted from the ListTable class.
1364 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1365 for rendering TYPE_TEXT cells. The code was extracted from the
1367 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1368 Add empty rows to the end of the data if required. Implement
1369 ListTable.getMinNumVisibleRows().
1370 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1371 cell renderer code to public classes. Return null in
1372 Column.getValue() for empty rows. Add new abstract method:
1373 getMinNumVisibleRows(). Move code to set the row count of the list view
1374 table to ListViewImpl.
1375 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1376 empty rows to the end of the data if required. Implement
1377 ListTable.getMinNumVisibleRows().
1380 2011-09-27 Ben Konrath <ben@bagu.org>
1382 Use GWT.log for client-side debugging statements.
1384 These are optimized out when deployed so I should have used this method
1385 in the first place. These statements will eventually be replaced with some sort
1386 of notification in the browser.
1388 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1389 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1390 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1391 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1392 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1394 2011-09-27 Ben Konrath <ben@bagu.org>
1396 Put tableselector on the right, back to list link on right.
1398 The idea is that the table selector is acting like a label for the
1399 currently displayed table so it should be placed below the document title. This
1400 puts the table title in a similar position to where it is in Glom.
1402 * mockups/details-contacts.html:
1403 * mockups/details-projects.html:
1404 * mockups/listview-contacts.html:
1405 * mockups/listview-projects.html:
1406 * mockups/style.css:
1407 Update mockups to match how the interfaces currently look.
1408 * src/main/webapp/style.css: Swap positions of backlink with the table
1409 selector. Add some space on the left side of the table selector to
1410 line things up with the document title.
1412 2011-09-27 Ben Konrath <ben@bagu.org>
1414 Add field colouring to details view.
1416 This change re-works how field colouring works. The colour formatting
1417 information is now set to the client with the layout information instead of
1418 with the data. This eliminates the need to send the same colour strings for
1419 data in list view column when colour information is set.
1421 In order to set an alternate colour for negative numeric values, the
1422 number is now sent to client and formatted with the GWT NumberFormat class.
1424 This change also fixes:
1426 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1428 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1429 internationalization framework which is needed for client side numeric
1431 * src/main/java/org/glom/web/client/Utils.java: New file for some
1432 client static utility methods.
1433 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1434 the DataItem object to the Field class. Use a utility method to
1435 create the foreignKeyValue string.
1436 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1437 alignment and text colours in the constructor. Add setData(DataItem)
1438 method. Remove setText(String) method.
1439 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1440 colour information to GlomTextCell. Create and use GlomNumberCell for
1441 rendering numbers. Use utility method to get the string for the
1442 primary key of the key provider. Re-work how the horizontal alignment
1444 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1445 formatting to layout information. Methods for converting the libglom
1446 formatting information were moved from DBAccess.
1447 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1448 numeric formatting (it's now done on the client side). Don't set text
1449 colours in DataItem. Move libglom formatting conversion methods to
1451 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1452 getters/setters for text colour information.
1453 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1454 for transferring the libglom NumericFormat information to the client.
1455 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1456 and getters/setters for: GlomNumericFormat, background colour and
1457 foreground colour strings.
1459 2011-09-26 Ben Konrath <ben@bagu.org>
1461 Simplify code that iterates through the LayoutGroup.
1463 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1465 2011-09-26 Ben Konrath <ben@bagu.org>
1467 Accept Eclipse formatting for OnlineGlomServiceAsync.
1469 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1471 2011-09-26 Ben Konrath <ben@bagu.org>
1473 Don't use the ListDBAccess classes to get the primary key layout information.
1475 This was causing a bug where the wrong index for the hidden primary key
1476 was being sent to the client.
1478 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1479 primary key while creating the LayoutGroup DTO. Create a
1480 LayoutItemField DTO for hidden primary keys. Don't use the
1481 RelatedListDBAccess because it was only used for getting the primary
1483 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1484 access modifier from public to protected for getPrimaryKeyField() and
1485 getPrimaryKeyLayoutItemField().
1486 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1487 abstract method getExpectedResultSize() because RelatedListDBAccess
1488 doesn't have enough info to implement it.
1489 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1490 Remove @Override for getExpectedResultSize().
1491 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1492 Remove method getExpectedResultSize().
1494 2011-09-23 Ben Konrath <ben@bagu.org>
1496 Log which layout (list or details) the ignored item is from.
1498 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1500 2011-09-23 Ben Konrath <ben@bagu.org>
1502 Remove annotations that turn off code formatting in DataItem.
1504 * src/main/java/org/glom/web/shared/DataItem.java:
1506 2011-09-23 Ben Konrath <ben@bagu.org>
1508 Rename GlomField to DataItem and update associated methods.
1510 This is a rename-only refactor. No functionality has been added or
1513 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1514 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1515 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1516 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1517 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1518 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1519 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1520 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1522 * src/main/java/org/glom/web/server/database/DBAccess.java:
1523 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1524 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1525 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1526 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1527 * src/main/java/org/glom/web/shared/DataItem.java:
1528 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1529 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1531 2011-09-23 Ben Konrath <ben@bagu.org>
1533 Rename GlomDocument to DocumentInfo and update associated methods.
1535 This is a rename-only refactor. No functionality has been added or
1538 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1539 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1540 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1541 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1542 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1544 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1546 2011-09-20 Ben Konrath <ben@bagu.org>
1548 Require java-libglom 1.17.3.
1550 This picks up the fix for the seg fault problem with the Scenes table
1551 in the Openismus Film Manager example.
1555 2011-09-20 Ben Konrath <ben@bagu.org>
1557 Change the way sort clause is added for primary key when no sort clause is requested.
1559 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1560 before the sort clause is created. When a sort clause is not requested, the
1561 sort clause is created by finding the primary key in the LayoutFieldVector
1564 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1566 2011-09-20 Ben Konrath <ben@bagu.org>
1568 Log error message if no documents are found in the configured directory.
1570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1571 Extract the glom file extension string to a private static final class
1572 variable (mostly as syntactic sugar). Accept a minor formatting change.
1573 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1574 the example glom.document.directory configuration property to make it
1575 more clear that it can any directory, not just the home directory.
1577 2011-09-18 Ben Konrath <ben@bagu.org>
1579 Add related lists to details view.
1581 The related list table has support for paging and sorting just like the
1582 table in the list view.
1584 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1585 SQL queries for the related list tables.
1586 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1587 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1588 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1589 Rename getList methods to getListView and add comments. Remove
1590 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1591 it being unused. Add methods: getDetailsLayoutAndData(),
1592 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1593 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1594 Create the layout and set the data for the fields in one async call
1595 instead of two. Create related lists where appropriate.
1596 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1597 for method name changes in OnlineGlomService.
1598 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1599 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1600 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1602 * src/main/java/org/glom/web/client/ui/ListView.java:
1603 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1604 tableName from setCellTable(). Create a ListViewTable instead of
1606 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1607 represent a data field in the details view.
1608 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1609 from addDetailsCell() to Field class. Keep track of the Fields and
1610 Portals in the details view.
1611 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1612 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1613 and add a method to get it. Add method to set the contents of the
1615 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1616 New class for related list tables. This class has the data provider
1617 for the related list table.
1618 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1619 abstract class which is the base class for the ListViewTable and the
1621 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1622 New class for list view tables. This class has the data provider for
1623 the list view table.
1624 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1625 methods for related list tables. Add more information to the
1626 LayoutItemField and LayoutItemPortal DTOs.
1627 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1628 Remove debugging print statement.
1629 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1630 Remove debugging print statements. Add primary key field to SQL count
1632 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1633 Remove unnecessary LayoutFieldVector parameter from
1634 getResultSizeOfSQLQuery() method.
1635 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1636 New class for related list table database access.
1637 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1638 class that is a wrapper DTO for details view layout and data.
1639 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1640 new 'fromField' string to this DTO.
1641 * src/main/webapp/style.css: Remove bottom margin and override top
1644 2011-09-15 Ben Konrath <ben@bagu.org>
1646 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1648 This sets things up to make it easier to add the data retrieval for
1649 related lists (portals). No user noticeable changes were made with
1652 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1653 class has the code to retrieve the layouts and access the
1654 database using the new database helper classes.
1655 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1656 Most of the functionality has been removed from this class. This
1657 class now represents the public interface for the client side
1658 code. It also deals with configuring the servlet and cleaning
1659 things up when the servlet is stopped.
1660 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1661 of static methods into this utility class.
1662 * src/main/java/org/glom/web/server/database/DBAccess.java:
1663 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1664 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1665 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1666 These classes have the database retrieval code. The class hierarchy
1667 has been setup to make it easy to reuse code for similar
1670 2011-09-06 Ben Konrath <ben@bagu.org>
1672 Create separate classes for list table code and the data provider.
1674 As part of this refactor, I also split up the code a bit to make it
1677 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1678 table code to two new classes (below).
1679 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1680 with code from ListViewImpl.
1681 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1682 New file with code from ListViewImpl.
1684 2011-09-06 Ben Konrath <ben@bagu.org>
1686 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1688 This fixes the LayoutItemPortal DTO to match the libglom layout object
1691 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1693 2011-09-01 Ben Konrath <ben@bagu.org>
1695 Set title of Portals in the Details View.
1697 * pom.xml: Bump required version of java-libglom to 1.17.1.
1698 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1699 widget creation to its own class. Add comments to constructor.
1700 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1701 The code is mostly from the Group class with the title now set.
1702 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1703 title of Portal. Update some comments. Fix some code formatting.
1705 2011-09-01 Ben Konrath <ben@bagu.org>
1707 Remove TODO comment for the flow table column width.
1709 The flow table column width is working correctly and doesn't need to be
1710 changed. See this mailing list post for more info:
1712 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1714 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1716 2011-08-27 Ben Konrath <ben@bagu.org>
1718 Add document title (database name) to top of the browser page.
1720 I added the document title to the TableSelecitonView but that will
1721 change if / when we add a view that doesn't require table selection.
1723 * mockups/details-contacts.html:
1724 * mockups/details-projects.html:
1725 * mockups/listview-contacts.html:
1726 * mockups/listview-projects.html:
1727 * mockups/style.css: Add document title to mockups to keep things
1729 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1730 sizes to account for the document title.
1731 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1732 Set the document title when it has been retrieved from the server.
1733 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1734 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1735 and implement setDocumentTitle(String) method.
1736 * src/main/webapp/style.css: Add ID for document title style.
1738 2011-08-25 Ben Konrath <ben@bagu.org>
1740 Add NavigationType enum to LayoutItemPortal DTO.
1742 This is the start of adding support for Portals to the Details View.
1744 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1745 LayoutItem_Portal.navigation_type enum from libglom to
1746 LayoutItemPortal.NavigationType enum.
1747 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1748 NavigationType enum, field for storing the NavigationType and getter
1751 2011-08-25 Ben Konrath <ben@bagu.org>
1753 Implement the flow table layout in the Details View.
1755 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1756 FlowTable to Group to account for the renamed class.
1757 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1758 File. This is a container widget that implements the Glom details view
1759 flow table behaviour.
1760 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1761 org/glom/web/client/ui/FlowTable.java.
1762 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1763 so that the size of the subgroups are a closer match to the size of
1764 the Glom subgroups. This makes the flowtable layout match the layout
1765 in Glom for the Music Collection example file.
1767 2011-08-16 Ben Konrath <ben@bagu.org>
1769 Create container element for LayoutItemPortal in Details View.
1771 This will help me develop the layout for the FlowTable.
1773 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1774 fieldPanel variable to detailsCell.
1776 2011-08-15 Ben Konrath <ben@bagu.org>
1778 Set the height of the data element in the Details View.
1780 I changed the InlineLabels (text in a span element) to Labels (text in
1781 a div element) so that I could set the height of the details-data
1782 elements instead of the details-cell parent elements. This allows the
1783 the details-data element to display the correct height if style is
1784 applied that shows the height.
1786 This change has the added benefit of allowing the order of the labels
1787 and data elements to be changed for right-to-left languages.
1789 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1790 InlineLabels to Labels.
1791 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1792 InlineLabels to Labels. Set the height of the data element.
1793 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1794 multiline text height in the Formatting DTO.
1795 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1796 for multiline height along with getter and setter methods.
1797 * src/main/webapp/style.css: Adjust style to account for the change
1798 from span elements to div elements in the details cell.
1800 2011-08-15 Ben Konrath <ben@bagu.org>
1802 Make the List View appearance match the mockups.
1804 It doesn't match exactly but it's much better than it was.
1806 * mockups/listview-contacts.html: Remove unused css classes.
1807 * mockups/listview-projects.html: Remove unused css classes.
1808 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1809 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1810 for mainPanel instead of VerticalPanel (table). Set style name on
1811 CellTable. Set style name on Details column. Right-align Details
1813 * src/main/webapp/style.css: Adjust properties to match the mockups.
1815 2011-08-12 Ben Konrath <ben@bagu.org>
1817 Add better support for subgroups in the details view.
1819 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1820 changed FlowTable constructor.
1821 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1822 support for subgroups and subgroup-titles.
1823 * src/main/webapp/style.css: Add CSS class for subgroups and
1826 2011-08-12 Ben Konrath <ben@bagu.org>
1828 Return the top level LayoutGroup title.
1830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1832 2011-08-11 Ben Konrath <ben@bagu.org>
1834 Make the TableSelector header match the mockup.
1836 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1837 the layout panel. Properly lineup the table selection header with
1838 the list and details view.
1839 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1840 margin around the details view.
1841 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1842 Rename listBox variable to tableSelector. Set id for the style sheet.
1843 Use a FlowPanel instead of a HorizontalPanel.
1844 * src/main/webapp/style.css: Add properties to make the TableSelector
1845 box match the mockups.
1847 2011-07-13 Ben Konrath <ben@bagu.org>
1849 Update install script for java-libglom version change.
1851 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1854 2011-07-13 Ben Konrath <ben@bagu.org>
1856 Add support sub-group in the details view.
1858 I also removed the code that special-cased the default details view
1861 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1863 I still have to make a proper flowtable.
1865 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1866 Don't special-case default details view layout.
1867 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1868 addLayoutField() as I'm going to use it.
1869 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1870 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1872 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1873 extracted from DetailsViewImpl.GroupPanel. Add support for
1875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1876 column count when getting the details layout.
1878 2011-07-12 Ben Konrath <ben@bagu.org>
1880 Set browser title with database and table titles.
1882 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1883 Set the browser title when the table changes and when the activity
1885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1886 title when retrieving document info (the GlomDocument object).
1887 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1888 with getter and setter methods. Remove unused convenience constructor.
1889 Use default code formatting.
1891 2011-07-12 Ben Konrath <ben@bagu.org>
1893 Ignore LayoutItemPortals in the details view.
1895 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1898 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1899 LayoutItemPortal layout objects.
1900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1901 LayoutItemPortal objects when retrieving the details layout.
1902 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1903 file. This is an empty class and just used to get type information for
1906 2011-07-12 Ben Konrath <ben@bagu.org>
1908 Use java-libglom 1.17.0.
1912 2011-07-11 Ben Konrath <ben@bagu.org>
1914 Remove "Table:" label from table selector.
1916 This matches a recent change in the Glom UI.
1918 * mockups/details-contacts.html:
1919 * mockups/details-projects.html:
1920 * mockups/listview-contacts.html:
1921 * mockups/listview-projects.html: Remove the "Table:" label from the
1923 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1925 2011-07-11 Ben Konrath <ben@bagu.org>
1927 Add main groups to the details view.
1929 This makes things look a little nicer in the details view. The next step
1930 is to implement the flowtable.
1932 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1933 resources from the standard gwt css theme. Standard.css is now
1934 included in OnlineGlom.html so that the online glom css rules have
1935 precedence over the gwt theme.
1936 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1937 the whole LayoutGroup to the DetailsView instead of just the titles.
1938 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1939 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1940 details layout with a helper class (GroupPanel). I might extract this
1941 class when I make the full flowtable.
1942 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1943 string as default so I don't have to worry about NPEs when processing
1945 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1946 note beside OnlineGlom.gwt.xml above).
1947 * src/main/webapp/style.css: Add default font-size to body to override
1948 the font-size set by the standard theme. Don't use h2 tags for
1949 group-title. Create new details-cell class.
1951 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1953 ConfiguredDocument: Set the port number too.
1955 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1956 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1957 Glom document. Presumably this worked sometimes so far because there is a
1958 default port number.
1960 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1962 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1964 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1965 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1966 correct, though we should throw an exception too.
1968 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1970 Fix a addDocuemnt typo.
1972 * src/main/java/org/glom/web/shared/Documents.java
1973 (Documents.addDocuemnt): Rename to addDocument().
1974 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1975 (OnlineGlomServiceImpl.getDocuments): Adapt.
1977 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1979 Slightly improved log output when connection fails.
1981 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1982 (ConfiguredDocument.setUsernameAndPassword):
1983 We don't know for sure if it' the username/password that's wrong, so
1984 rephrase the message.
1985 Also ouput the exception message, though it's generic in this case.
1987 2011-07-08 Ben Konrath <ben@bagu.org>
1991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1992 added braces to a one line if statement because the Eclipse formatter
1993 was getting confused.
1995 2011-07-07 Ben Konrath <ben@bagu.org>
1997 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1999 These should really be two separate tasks but I counldn't get things to
2000 work with GWT 2.2.0 and Eclipse 3.7.
2004 * .settings/org.eclipse.jdt.core.prefs:
2005 * .settings/org.eclipse.jdt.ui.prefs:
2006 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2007 * .settings/org.eclipse.m2e.core.prefs:
2008 Add new config files. Update current files. Remove references to the
2009 webtools plugins as we're not using any of the webtools features.
2010 * .gitignore: Add logs directory which is created when running with
2012 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2013 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2014 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2016 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2018 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2020 onlineglom.properties: Add explanatory comments.
2022 * src/main/resources/onlineglom.properties: Also change the default user
2023 from ben to someuser, to avoid the risk of people thinking we just
2024 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2026 2011-06-28 Ben Konrath <ben@bagu.org>
2028 Use filename in Log for incorrect passwords.
2030 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2031 getFileName(String) method to get the filename from the URI.
2033 2011-06-28 Ben Konrath <ben@bagu.org>
2035 Add the table name to the URL token for the ListPlace.
2037 This makes things consistent between the DetailsPlace and the
2038 ListPlace. It also allows the the ListPlace to be bookmarked.
2040 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2041 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2042 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2043 Remove getDefaultListLayout(). The default layout is now returned
2044 by the getListLayout() method when the table name is an empty string.
2045 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2046 Add table name field. Change to a new ListPlace when the table
2047 has been changed. Use getListLayout() for getting the default
2049 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2050 Add table name field. Set the correct table name in the list box
2051 when loading from bookmark. This corrects a problem for the
2053 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2054 Move table name to super-class (HasSelectableTable). Move document
2055 and table URL keys to super-class in HasSelectableTable.
2056 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2057 Add table name field. Add Tokenizer class with URL key common to
2058 the subclasses (DetailsPlace and ListPlace).
2059 * src/main/java/org/glom/web/client/place/ListPlace.java:
2060 Add table name. Add code to parse the URL token.
2061 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2062 Update ListPlace construction with empty table name string.
2063 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2064 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2065 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2066 Update ListPlace construction with table name string.
2067 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2068 Change defaultTableName field to tableName to reflect how it's now
2069 used. Update the getter and setter methods.
2071 2011-06-28 Ben Konrath <ben@bagu.org>
2073 Enable the table selector in the DetailsView.
2075 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2076 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2077 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2078 Remove getDefaultDetailsLayout(). The default layout is now returned
2079 by the getDetailsLayout() method when the table name is an empty
2081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2082 event handler for table change event. Change to using
2083 getDetailsLayout() for the default details layout.
2084 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2086 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2087 when navigating to the details place.
2089 2011-06-27 Ben Konrath <ben@bagu.org>
2091 Use filename based unique document ID in URL and for RPC.
2093 The document ID is the glom document name with spaces (' ') replaced
2094 with pluses ('+') and without the .glom extension.
2096 This change is mostly a string substitution of 'documentTitle' for
2097 'documentID'. The only code change is the addition of a Documents DTO to get the
2098 filename to document title mappings as indicated below.
2100 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2101 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2102 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2103 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2104 Use Documents DTO to create the document links in the document
2106 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2107 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2108 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2109 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2110 * src/main/java/org/glom/web/client/place/ListPlace.java:
2111 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2112 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2113 * src/main/java/org/glom/web/client/ui/ListView.java:
2114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2115 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2116 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2117 * src/main/java/org/glom/web/server/Log.java:
2118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2119 getDocumentTitles() to getDocuments() and return the Documents DTO.
2120 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2121 transferring the filename to document title mappings.
2123 2011-06-25 Ben Konrath <ben@bagu.org>
2125 Make the authentication popup work again.
2127 This bug was introduced when I extracted ConfiguredDocument to its own class.
2129 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2130 correct success / fail status in setUsernameAndPassword().
2132 2011-06-25 Ben Konrath <ben@bagu.org>
2134 Use filename as unique key for configuring database usernames and passwords.
2136 This replaces the use of the Glom document title which could change
2137 depending on the locale. Thanks to Murray Cumming for pointing out this
2140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2141 * src/main/resources/onlineglom.properties:
2143 2011-06-24 Ben Konrath <ben@bagu.org>
2145 Pass primary key value to DetailsView.
2147 This enables the DetailsView to load the correct data.
2149 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2150 primary key value field and set in constructor. Pass primary key
2151 value to getDetailsData().
2152 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2153 variables for document title and primary key value.
2154 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2155 key value to the DetailsPlace.
2157 2011-06-24 Ben Konrath <ben@bagu.org>
2159 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2161 This allows the primary key to be retrieved by the Details button. This
2162 functionality has not been implemented yet but it's in the works.
2164 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2165 the LayoutGroup result to ListView.setCellTable instead of all of its
2166 fields individually.
2167 * src/main/java/org/glom/web/client/ui/ListView.java:
2168 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2169 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2170 get the primary key for the table.
2171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2172 index of the primary key in the LayoutGroup accounting for hidden
2173 primary keys. Rename getJavaNumberFormat() to
2174 convertToJavaNumberFormat() for consistency. Cleanup / add some
2176 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2177 field for primary key index and a field to indicate whether the
2178 primary key is hidden or not.
2180 2011-06-23 Ben Konrath <ben@bagu.org>
2182 Rename getTableData methods to getListData.
2184 This is a rename refactor for consistency with other methods.
2186 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2188 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2191 2011-06-23 Ben Konrath <ben@bagu.org>
2193 Extract the ConfiguredDocument innerclass into its own class.
2195 This makes the servlet code more object oriented.
2197 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2198 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2199 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2200 new ConfiguredDocument class.
2202 2011-06-21 Ben Konrath <ben@bagu.org>
2204 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2206 This makes things more inline with how libglom works and reduces code
2207 duplication. This refactor lays the groundwork for adding the primary key to
2208 the LayoutGroup object.
2210 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2211 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2213 Change method names to getListLayout and getDefaultListLayout for
2214 consistency. Use LayoutGroup as the DTO for the list layout instead of
2215 ColumnInfo and LayoutListTable.
2216 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2217 new method names along with the LayoutGroup object for transferring the
2219 * src/main/java/org/glom/web/client/ui/ListView.java:
2220 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2221 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2222 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2224 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2225 Replaced with LayoutGroup.
2226 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2227 expectedResultSize and defaultTableName fields which are needed for
2229 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2230 type field which is needed for the list layout but will also be
2231 useful for the details layout as things progress.
2232 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2233 Make class abstract. Remove the unnecessary
2234 getFormattingHorizontalAlignment method. Add setFormatting method.
2236 2011-06-16 Ben Konrath <ben@bagu.org>
2238 Add scripts for building and installing war.
2240 These will help when updating OnlineGlom but they're also good
2241 supplemental documentation of the build and deployment proceeding.
2243 * utils/build-onlineglom-war.sh: New file.
2244 * utils/install-onlineglom-war.sh: New file.
2246 2011-06-16 Ben Konrath <ben@bagu.org>
2248 Create wrapper class to create consistent log messages.
2250 I wrapped methods in the Log class of gwt-log to add the method names
2251 from the servlet and create consistent formatting of the document title
2252 and table names in the log messages.
2254 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2256 log methods to use methods from wrapped Log class.
2258 2011-06-16 Ben Konrath <ben@bagu.org>
2260 Remove superfluous conditional return.
2262 Thanks to Murray Cumming for pointing this out!
2264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2266 2011-06-15 Ben Konrath <ben@bagu.org>
2268 Return an ArrayList of LayoutGroups for the Details layout.
2270 This corrects a problem with the details layout as it can have more
2271 than one top level LayoutGroup.
2273 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2274 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2275 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2276 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2278 with ArrayList of LayoutGroups for the details view layout.
2279 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2280 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2281 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2282 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2283 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2284 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2286 2011-06-14 Ben Konrath <ben@bagu.org>
2288 Use cast_dynamic method to determine the libglom LayoutItem type.
2290 This is better than finding the LayoutItem type by using the string
2291 returned from the get_part_type_name() method.
2293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2295 2011-06-14 Ben Konrath <ben@bagu.org>
2297 Add method names to log entries in the servlet.
2299 This helps when tracking down deployment problems.
2301 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2303 2011-06-14 Ben Konrath <ben@bagu.org>
2305 Add data to the DetailsView using a hard-coded primary key value.
2307 The layout and functionality of the DetailsView is not complete. This
2308 is just a checkpoint so the patch doesn't get too big.
2310 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2311 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2312 Add getDetailsData() servlet method.
2313 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2314 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2315 LayoutFields are added to the DetailsView.
2316 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2317 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2318 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2319 take the string for the title instead of the object.
2320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2321 Add implementation getDetailsData() along with some private helper
2323 * src/main/webapp/style.css: Add padding to details-data class. Add a
2324 details-label class with the same padding as the details-data class.
2326 2011-06-03 Ben Konrath <ben@bagu.org>
2328 Use presenter.goTo() to change to the DetailsPlace.
2330 This will make things easier when we need to open the DetailsView with
2331 data specific to the row that was clicked.
2333 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2335 2011-06-02 Ben Konrath <ben@bagu.org>
2337 Add CSS file from mockups.
2339 I'm adding this now because it's going to be useful to have when
2340 developing the DetailsView. The TableSelectionView and ListView aren't
2343 * src/main/webapp/OnlineGlom.html:
2344 * src/main/webapp/style.css:
2346 2011-06-02 Ben Konrath <ben@bagu.org>
2348 Use String.isEmpty() to check for empty string.
2350 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2352 2011-06-02 Ben Konrath <ben@bagu.org>
2354 Display main layout group titles in the DetailsView.
2356 This is the start of the DetailsActivity/DetailsView implementation.
2358 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2359 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2360 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2361 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2362 Get the layout information for the details view from the server and set
2363 the main layout group titles.
2364 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2365 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2366 Add addLayoutGroup() and addLayoutField() methods. This are just
2367 temporary methods for creating the the details view that will change
2369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2370 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2372 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2373 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2374 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2375 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2376 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2377 Data Transfer Objects that mimic the libglom object structure. These are
2378 used for transferring the details layout but could also be used for
2379 transferring the list layout.
2381 2011-05-27 Ben Konrath <ben@bagu.org>
2383 Reset the AuthenticationPopup when clearing the ListView.
2385 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2387 2011-05-27 Ben Konrath <ben@bagu.org>
2389 Fix problem with onlineglom.properties file loading.
2391 The old way worked in Eclipse but not on the server. Loading the
2392 onlineglom.properties file now works in Eclipse and on the server.
2394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2396 2011-05-24 Ben Konrath <ben@bagu.org>
2398 Update gwt-log from 3.1.0 to 3.1.2.
2400 Gwt-log 3.1.0 has been marked as depreciated.
2404 2011-05-24 Ben Konrath <ben@bagu.org>
2406 Add comment to ListActivity.goTo() method.
2408 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2410 2011-05-24 Ben Konrath <ben@bagu.org>
2412 Remove FIXME in convertGdkColorToHtmlColour()
2414 The Gdk::Color value returned by libglom is 16-bits per channel on both
2415 64 and 32-bit platforms.
2417 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2419 2011-05-19 Ben Konrath <ben@bagu.org>
2421 Improve performance of initial ListView load.
2423 I removed a round trip to the server for getting the default table name
2424 and then requesting information about that table. This also removes a potential
2425 problem with the table change handler not being setup in time to receive the
2426 table change event from the ListActivity.
2428 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2429 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2430 getDefaultLayoutListTable() method. Improve comments.
2431 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2432 getDefaultLayoutListTable() method instead of firing a table change
2433 event to get the table to load.
2434 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2435 implementation of getDefaultLayoutListTable() method.
2436 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2439 2011-05-19 Ben Konrath <ben@bagu.org>
2441 Override toDebugString() in TableChangeEvent.
2443 This is useful to have for debugging.
2445 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2447 2011-05-19 Ben Konrath <ben@bagu.org>
2449 Add a "Back to List" link when at the DetailsPlace.
2451 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2452 Populate the CellTable based on the selected table of the ListBox if
2453 it's set otherwise use the default table. This allows the "Back to
2455 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2456 Remove Place from constructors. Add a setPlace() method. Add
2457 goToPlace() method. Set class as presenter for TableSelectionView.
2458 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2459 Use the same TableSelectionActivity when switching between the List and
2461 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2462 Subclass the new HasSelectableTablePlace. This removes some duplicate
2464 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2465 New class to represent Places that display the TableSelectionView.
2466 * src/main/java/org/glom/web/client/place/ListPlace.java:
2467 Subclass the new HasSelectableTablePlace. This removes some duplicate
2469 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2470 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2471 Add Presenter interface. Add setBackLinkVisible() method. Add
2472 setBackLink() method.
2474 2011-05-18 Ben Konrath <ben@bagu.org>
2476 Enable the "Details" buttons.
2478 Right now only an empty details view is displayed.
2480 * src/main/java/org/glom/web/client/ClientFactory.java:
2481 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2482 Add DetailsView to ClientFactory.
2483 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2484 A basic activity for the details view.
2485 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2486 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2488 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2489 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2491 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2492 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2493 unnecessary super() in constructor.
2494 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2495 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2496 really shouldn't create a new TableSelectionActivity for both the ListPlace
2497 and the DetailsPlace so this should be considered a temporary solution.
2498 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2499 New file. Represents a URL for the details view.
2500 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2501 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2502 A basic details view interface and implementation.
2503 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2504 Enable the "Details" buttons.
2506 2011-05-12 Ben Konrath <ben@bagu.org>
2508 Use a LayoutPanel with multiple display areas for main layout.
2510 This is mostly a refactor in that there are no changes from the user
2511 point of view. These changes are required so that we can swap out the list view
2512 with the details view when the user clicks the "Details" button.
2514 * src/main/java/org/glom/web/client/ClientFactory.java:
2515 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2516 OnlineGlomView. Add TableSelectionView, ListView and
2517 AuthenticationPopup.
2518 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2519 for main layout. Add display regions for main activities. Add
2520 activity manager for for main activities.
2521 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2522 file from parts of the deleted OnlineGlomActivity.
2523 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2524 New file from parts of the deleted OnlineGlomActivity.
2525 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2526 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2527 New files for app wide table change event.
2528 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2529 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2530 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2531 Activity mappers for the main activities replace the deleted app-wide
2533 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2534 Fix a spelling error in he comment.
2535 * src/main/java/org/glom/web/client/ui/ListView.java:
2536 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2537 Renamed from LayoutListView and modified for MVP. This still not a
2538 proper dumb view as prescribed by the MVP pattern but it works for now.
2539 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2540 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2541 New widget stripped out of the deleted OnlineGlomView.
2542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2543 Remove hack that is fixed by this patch.
2545 2011-05-06 Ben Konrath <ben@bagu.org>
2547 Rename OnlineGlomPlace to ListPlace.
2549 The only change besides the rename is that url will now display #list
2550 instead of #Document.
2552 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2553 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2554 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2555 * src/main/java/org/glom/web/client/place/ListPlace.java:
2556 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2558 2011-05-06 Ben Konrath <ben@bagu.org>
2560 Use Presenter for app navigation.
2562 This is the proper way to deal with Place (URL) changes with the MVP
2565 * src/main/java/org/glom/web/client/ClientFactory.java:
2566 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2567 PlaceHistoryMapper and PlaceHistoryHandler.
2568 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2569 PlaceHistoryMapper and PlaceHistoryHandler.
2570 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2571 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2572 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2573 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2574 Add Presenter interface and setPresenter methods. Rename addHyperLink
2575 to addDocumentLink taking only the document title as a parameter.
2577 2011-04-14 Ben Konrath <ben@bagu.org>
2579 Prompt for db username/password if they haven't been set.
2581 This is implemented with a popup widget that is contained within the
2582 OnlineGlomView and managed by the OnlineGlomActivity.
2584 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2585 methods for checking and setting the database username and password.
2586 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2587 new methods for checking and setting the database username and
2589 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2590 Display authentication popup if the JDBC connection to the database
2591 has not been authenticated.
2592 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2594 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2595 for dealing with the authentication popup.
2596 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2597 Implement the methods for dealing with the authentication popup.
2598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2599 try to executed queries if the database connection hasn't been
2600 authenticated. Implement methods for checking and setting the
2601 database username and password.
2603 2011-04-12 Ben Konrath <ben@bagu.org>
2605 Make log messages a little clearer.
2607 Add a dash betweeen the document title and the table name.
2609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2611 2011-04-12 Ben Konrath <ben@bagu.org>
2613 Protect against NPEs when cleaning up database resources.
2615 While this isn't strictly necessary because the exception is caught,
2616 not protecting against the NPEs makes it harder to find the real error
2619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2621 2011-04-12 Ben Konrath <ben@bagu.org>
2623 Move configuration of the servlet to the constructor.
2625 The servlet will be initialized even if the database authentication
2626 information is not set or correct. I still need to add the UI for prompting
2627 the user for the authentication information when it's required.
2629 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2630 javadocs for getDocumentTitles() method.
2631 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2632 Set error message when RPC fails.
2633 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2634 glom files directory from the configuration file. Try to set the
2635 database authentication information for the specific document if it's
2636 set and works otherwise try to use the global authentication
2637 information set for the directory.
2638 * src/main/resources/onlineglom.properties: Moved from
2639 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2640 Added detailed comments for the new keys.
2642 2011-04-11 Ben Konrath <ben@bagu.org>
2644 Remove unnecessary @Override in DocumentSelectionViewImpl.
2646 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2648 2011-04-11 Ben Konrath <ben@bagu.org>
2650 Remove center alignment in DocumentSelectionView.
2652 The title element is still centred but the document titles and bottom
2653 sentence are both left-aligned.
2655 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2657 2011-04-11 Ben Konrath <ben@bagu.org>
2659 Change 'Demo' naming convention to 'Document'.
2661 This is just a rename refactor with no functional changes to the code.
2663 * src/main/java/org/glom/web/client/ClientFactory.java:
2664 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2665 * src/main/java/org/glom/web/client/OnlineGlom.java:
2666 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2667 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2668 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2669 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2670 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2671 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2672 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2673 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2674 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2675 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2677 2011-04-08 Ben Konrath <ben@bagu.org>
2679 Remove FIXME from safeLongToInt() method.
2681 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2686 2011-04-08 Ben Konrath <ben@bagu.org>
2688 Display an error if no glom documents are found in the specified directory.
2690 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2691 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2692 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2693 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2695 2011-04-08 Ben Konrath <ben@bagu.org>
2697 Add copyright header to one more file ... oops.
2699 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2701 2011-04-08 Ben Konrath <ben@bagu.org>
2703 Add copyright header to files without it.
2705 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2706 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2707 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2708 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2709 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2710 * src/main/java/org/glom/web/shared/GlomField.java:
2712 2011-04-08 Ben Konrath <ben@bagu.org>
2714 Add support for accessing multiple glom documents in the servlet.
2716 This completes the demo selection functionality.
2718 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2719 document title to methods.
2720 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2721 document title to methods.
2722 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2723 Set browser window title when the activity starts. Correct name of
2724 document title variable.
2725 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2726 Set browser window title when the activity starts. Set the table
2727 selector change handler after table selector has been set. Clear the
2728 OnlineGlomView when the activity has been stopped.
2729 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2730 document title as the place token. Use "#Document:" instead of
2731 "#OnlineGlomPlace:" in the URL.
2732 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2733 Change heading to "Online Glom"
2734 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2735 document title in RPC methods.
2736 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2737 setDocumentTitle() method. Add clear() method.
2738 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2739 setDocumentTitle() method. Implement clear() method which removes the
2740 change handler on the ListBox, clears the ListBox and clears the
2742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2743 Implement methods with document title. Keep track for the configured
2744 glom documents and their corresponding JDBC configurations in a hash
2745 table. This information is retrieved using the document title as the
2746 key in the hash table.
2747 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2748 document title field as it's no longer needed.
2750 2011-04-08 Ben Konrath <ben@bagu.org>
2752 Update the Eclipse JDT configuration.
2754 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2755 methods. Automatically add the copyright header to new files.
2757 2011-04-05 Ben Konrath <ben@bagu.org>
2759 Add new page for demo selection.
2761 This patch adds all the components required to view and start an
2762 OnlineGlom demo by clicking on the desired hyperlink. The user is
2763 able to return to the demo selection page with the browser's back
2764 button. I still need to modify the servlet to work with multiple
2765 documents so all demo links will load the file defined in the
2766 OnlineGlom.properties.
2768 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2769 This is only useful during development so we don't need to save it.
2770 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2771 get a reference to the DemoSelectionView.
2772 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2773 method to get a reference to the DemoSelectionView.
2774 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2775 default view to DemoSelectionView.
2776 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2777 to get glom document titles for glom files in a hard-coded directory.
2778 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2779 method to get glom document titles for glom files in a hard-coded
2781 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2782 Presenter for DemoSelectionView.
2783 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2784 for DemoSelectionView.
2785 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2786 Update for DemoSelectionView.
2787 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2788 Basic 'Place' implementation for the DemoSelectionView.
2789 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2790 The interface for the DemoSelectionView.
2791 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2792 The implementation of the DemoSelectionView.
2793 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2794 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2796 implementation of method to get glom document titles for glom files
2797 in a hard-coded directory.
2798 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2799 on longer being used.
2800 * src/main/webapp/glom.png: Glom logo.
2802 2011-04-05 Ben Konrath <ben@bagu.org>
2804 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2806 This is the forth and final commit of a refactor that will allow
2807 OnlineGlom to be used with multiple documents.
2809 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2810 Move RPC code from OnlineGlomViewImpl to this class.
2811 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2813 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2814 RPC code to the presenter class (the P in MVP).
2816 2011-04-04 Ben Konrath <ben@bagu.org>
2818 Start moving the existing OnlineGlom code to MVP.
2820 This work is based on the GWT MVP framework that is documented here:
2822 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2824 This is the third commit of a refactor that will allow OnlineGlom to
2825 be used with multiple documents.
2827 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2828 Interface for client factory which is used to get instances of various
2829 classes throughout the app.
2830 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2831 Implementation of client factory.
2832 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2833 initialize the MVP framework.
2834 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2835 New file. Activity manager for the main container widget. This is the
2837 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2838 Maps place (URL) to its corresponding activity.
2839 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2840 New file. This is just a place holder for a generated file.
2841 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2842 New file. Represents the URL for the main Online Glom app.
2843 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2844 for changes in LayoutListViewImpl.
2845 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2846 interface for View. Move code to OnlineGlomViewImpl class.
2847 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2848 file. Implementation of OnlineGlomView.
2849 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2850 Place resources. Use ClientFactoryImpl by default.
2852 2011-04-04 Ben Konrath <ben@bagu.org>
2854 Move View classes to their own package.
2856 This is the second commit of a refactor that will allow OnlineGlom to
2857 be used with multiple documents.
2859 * src/main/java/org/glom/web/client/OnlineGlom.java:
2860 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2861 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2863 2011-04-02 Ben Konrath <ben@bagu.org>
2865 Move UI code from the main module to its own class.
2867 This is the first commit of a refactor that will allow OnlineGlom to be
2868 used with multiple documents.
2870 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2871 references to OnlineGlom to OnlineGlomView.
2872 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2873 OnlineGlomView and instantiate it here.
2874 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2875 represents the main OnlineGlomView with one document.
2877 2011-04-01 Ben Konrath <ben@bagu.org>
2879 Fix formatting of gwt.xml and add DTD.
2881 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2883 2011-03-30 Ben Konrath <ben@bagu.org>
2885 Propperly convert gdkColor string to html colour string.
2887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2889 2011-03-28 Ben Konrath <ben@bagu.org>
2891 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2893 This implementation matches
2894 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2895 readable and is not tied to Swig.
2897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2899 2011-03-28 Ben Konrath <ben@bagu.org>
2901 Use read-only checkboxes for boolean field types.
2903 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2904 in the CellTable based on the field type. It currently only
2905 distinguishes between boolean and text columns but I'll need to add
2906 support for more types.
2907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2908 column type in the ColumnInfo object. Add method to convert between the
2909 glom field type enum in ColumnInfo and the glom field type in libglom.
2910 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2912 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2913 getting and setting booleans.
2915 2011-03-25 Ben Konrath <ben@bagu.org>
2917 Don't get the Date twice from the ResultSet.
2919 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2921 2011-03-25 Ben Konrath <ben@bagu.org>
2923 Cleanup code in the servlet.
2925 * TODO: Remove item about row count. Add item about testing row count
2926 query with large number of rows.
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2928 spelling mistakes, change method parameter to be consistent with
2931 2011-03-25 Ben Konrath <ben@bagu.org>
2933 Add server side logging with the gwt-log library.
2935 * .gitignore: Ignore the log file we're now producing.
2936 * TODO: Add a couple TODO item for logging.
2937 * pom.xml: Add gwt-log and log4j as a dependency.
2938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2939 logging of errors, warnings and some important info.
2940 * src/main/resources/log4j.properties: New file to configure log4j.
2942 2011-03-24 Ben Konrath <ben@bagu.org>
2944 Add a disable button for the Details view.
2946 * src/main/java/org/glom/web/client/LayoutListView.java:
2948 2011-03-22 Ben Konrath <ben@bagu.org>
2950 Use a count query to get the number of rows for the list view pager.
2952 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2954 2011-03-22 Ben Konrath <ben@bagu.org>
2956 Add more TODO information about CellTable pager positioning.
2960 2011-03-19 Ben Konrath <ben@bagu.org>
2962 Add TODO item about CellTable pager positioning.
2966 2011-03-18 Ben Konrath <ben@bagu.org>
2968 Remove unneeded GlomFieldColumn class.
2970 This is just a small code cleanup.
2972 * src/main/java/org/glom/web/client/LayoutListView.java:
2974 2011-03-18 Ben Konrath <ben@bagu.org>
2976 Use cursor mode in the query that gets data for the list view.
2978 I still need to fix the potential memory problem when getting the row
2979 count for the list view.
2981 * TODO: Add note about testing memory usage with large data sets. Add
2982 item about fixing row counting with large data sets.
2983 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2984 PostgreSQL JDBC driver into cursor mode when getting data for the
2987 2011-03-15 Ben Konrath <ben@bagu.org>
2989 Remove the GWT Container from the Eclipse build classpath.
2991 The GWT dependencies are set by Maven so this isn't needed.
2995 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2997 Added some earlier mockups to git, but not to the tarball dist.
2999 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
3000 Openismus. These hopefully show how we might structure the HTML so that
3001 it can be styled easily with CSS. However, we probably need to adapt them
3002 for the CSS structure that GWT dictates for common widgets.
3004 2011-03-14 Ben Konrath <ben@bagu.org>
3006 Locate OnlineGlom.properties using the ServletContext.
3008 This is required to be able to locate the file in the deployed servlet.
3010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3011 Configure the database and glom document in in a helper method so
3012 that the ServletContext can be used to locate OnlineGlom.properties.
3013 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
3014 src/main/webapp. This is the proper location for .properites files.
3016 2011-03-12 Ben Konrath <ben@bagu.org>
3018 Add note to README about why we're compiling down to obfuscated JavaScript.
3022 2011-03-11 Ben Konrath <ben@bagu.org>
3024 Use properties file to configure servlet.
3026 This allows people to change the glom file path, db username and db
3027 password without recompiling the code.
3029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3030 * src/main/webapp/OnlineGlom.properties:
3032 2011-03-11 Ben Konrath <ben@bagu.org>
3034 Use table fields in layout list view if the layout list is not defined.
3036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3037 Manually create a LayoutFieldVector for the query builder using the
3038 table fields when a layout list is not defined in the glom file.
3040 2011-03-11 Ben Konrath <ben@bagu.org>
3042 Only show FIXME string for images when there's an image.
3044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
3045 in this change are some small code cleanups.
3047 2011-03-11 Ben Konrath <ben@bagu.org>
3049 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3053 2011-03-11 Ben Konrath <ben@bagu.org>
3055 Correctly set the index of the default table.
3057 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3058 Correctly set the index of the default table. Add commented out example
3061 2011-03-10 Ben Konrath <ben@bagu.org>
3063 Add comment to pom.xml about the previous change.
3065 * pom.xml: Add comment about the deployment issue so that it's obvious
3066 why java-libglom is set to the provided scope.
3068 2011-03-10 Ben Konrath <ben@bagu.org>
3070 Change java-libglom dependency from compile to provided in pom.xml.
3072 Since java-libglom uses jni it can only be loaded once and therefore
3073 must be placed in $CATALINA_HOME/lib and not included in each war.
3074 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3075 More information about this issue can be found in the Tomcat 6 release
3076 notes in the "JNI Based Applications" section:
3078 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3080 * README: Remove note about this issue. Deployment info should really
3081 be on the wiki anyway so I'll add it right now.
3082 * pom.xml: Change java-libglom dependency from compile to provided so
3083 that it's copied in to the packaged war.
3085 2011-03-09 Ben Konrath <ben@bagu.org>
3087 Change to using a neutral locale for currency, date and time formatting.
3089 This solves the problem of currency values being represented without a
3090 space between the currency code and the number (e.g. "EUR5.89" is now
3091 represented as "EUR 5.89"). More work is required when we implement
3092 a locale preference setting.
3094 * TODO: Add note about currency formatting issues with different
3096 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3097 to using the neutral ROOT locale.
3099 2011-03-09 Ben Konrath <ben@bagu.org>
3101 Add support for currency codes that are not ISO 4217 codes.
3103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3104 the currency code defined in the glom file when it's not 3 characters
3105 long or when Java doesn't recognize the string as an ISO 4217 code.
3107 2011-03-08 Ben Konrath <ben@bagu.org>
3109 Remove test classes, launch configurations and configuration.
3111 The test stuff was getting in the way when creating the war. To make
3112 the war file you can now do 'mvn clean package'. The packaged war file
3113 will be in the target directory.
3115 * .classpath: Remove unused classpathentry for tests and i18n.
3116 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3117 property. Don't run test or i18n goals when packaging the war.
3118 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3123 * OnlineGlomTest-dev.launch:
3124 * OnlineGlomTest-prod.launch:
3125 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3126 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3128 2011-03-07 Ben Konrath <ben@bagu.org>
3130 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3132 These fixes allow me to use 'mvn deploy' to create the war file.
3134 * .classpath: This generated config has been updated by Eclipse. This
3135 change was probably triggered by me updating from Eclipse 3.6.1 to
3137 * .gitignore: Add entry to ignore the directory
3138 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3139 * .project: The generated config has been updated by Eclipse. This
3140 change was probably triggered by me updating from Eclipse 3.6.1 to
3142 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3143 so that Eclipse doesn't complain
3144 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3145 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3146 'tests' directory to 'client' directory. This is the new
3147 gwt-maven-plugin convension.
3148 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3149 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3151 2011-03-07 Ben Konrath <ben@bagu.org>
3153 Add support for horizontal alignment in the LayoutList columns.
3155 * TODO: Remove item about horizontal alignment. Add item about
3156 improvements to ColumnInfo.
3157 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3158 alignment on the columns. Use ColumnInfo RPC object get the column
3159 title and horizontal alignment.
3160 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3161 LayoutListView creation with ColumnInfo RPC object.
3162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3163 a ColumnInfo object for every LayoutList columnn. Convert the
3164 FieldFormatting.HorizontalAlignment to the correct
3165 ColumnnInfo.HorizontatlAlignment with the new
3166 getColumnInfoHorizontalAlignment helper method.
3167 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3168 to encapsulate column information like alignment and title. This
3169 could be used to set the colour instead of on a per cell field basis.
3170 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3171 column title storage and retrieval with ColumnInfo.
3173 2011-03-04 Ben Konrath <ben@bagu.org>
3175 Add support for column sorting.
3177 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3178 AsynDataProvider to be an anonymous inner class. Use new
3179 getSortedTableData RPC method when column sort is requested. Set all
3180 columns sortable and add an AsyncHandler to activate sorting in the
3182 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3183 method getSortedTableData(). Cleanup other method signatures.
3184 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3185 new method getSortedTableData(). Cleanup other method signatures.
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3187 Implement getSortedTableData() and getTableData() methods by using a
3188 private helper method with the appropriate parameters filled in. Use
3189 user supplied sort clause when supplied, otherwise fall back to
3190 sorting by the primary key. Move destroy() method to be underneath
3191 constructor for readability. Cleanup comments.
3193 2011-03-03 Ben Konrath <ben@bagu.org>
3195 Add support for colour text and colour backgrounds to the layout list cells.
3197 Only the cell backgrounds are coloured which leaves a gap between the
3198 cells that isn't coloured. I need to figure out a way to set
3199 'style=background-colour:' on the whole column rather than just the
3202 * TODO: Add a note about colouring the background of the whole column.
3203 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3204 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3205 render the coloured text and backgrounds. Use GlomField[] for the row type.
3206 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3208 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3209 GlomField[] for the row type.
3210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3211 GlomField[] for the row type. Set the text, text colour and background
3212 colour in the GlomField objects as specified in the glom document. Add
3213 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3214 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3215 the glom field text, foreground colour and background colour.
3217 2011-03-02 Ben Konrath <ben@bagu.org>
3219 Don't display hidden tables in the combo box.
3221 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3224 code to ignore hidden tables using ArrayLists for the table names and
3226 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3227 tableNames to use ArrayLists instead of String[]. Update getter and setter
3230 2011-03-01 Ben Konrath <ben@bagu.org>
3232 Add support for Date and Time number types.
3234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: